platform/upstream/freerdp.git
6 years agoFixed read/write of surface bits command.
Armin Novak [Wed, 28 Feb 2018 09:10:09 +0000 (10:10 +0100)]
Fixed read/write of surface bits command.

The optional field exBitmapDataHeader of TS_ BITMAP_DATA_EX was ignored.
Read and expose the data (currently unused)

6 years agoMerge pull request #4450 from akallabeth/assist_fix
Martin Fleisz [Wed, 21 Feb 2018 15:56:55 +0000 (16:56 +0100)]
Merge pull request #4450 from akallabeth/assist_fix

Assistance and RDP file parser fix

6 years agoMerge pull request #4451 from akallabeth/gsm_leak_fix
Martin Fleisz [Tue, 20 Feb 2018 10:10:57 +0000 (11:10 +0100)]
Merge pull request #4451 from akallabeth/gsm_leak_fix

Clean up GSM context on channel close.

6 years agoMerge pull request #4441 from akallabeth/paa
Martin Fleisz [Mon, 19 Feb 2018 16:28:32 +0000 (17:28 +0100)]
Merge pull request #4441 from akallabeth/paa

[cleanup] Support for gatewayaccesstoken / PAA

6 years agoFree gsmBuffer on channel close.
Armin Novak [Mon, 19 Feb 2018 13:03:49 +0000 (14:03 +0100)]
Free gsmBuffer on channel close.

6 years agoClean up GSM context on channel close.
Armin Novak [Mon, 19 Feb 2018 12:05:53 +0000 (13:05 +0100)]
Clean up GSM context on channel close.

6 years agoFixed .rdp and .msrcIncident checks.
Armin Novak [Mon, 19 Feb 2018 09:00:54 +0000 (10:00 +0100)]
Fixed .rdp and .msrcIncident checks.

The command line detection fails, if only one of the aforementioned
files is used as an argument. Detect those first and ignore command
line detection if found.

6 years agoAdded assistance file name NULL check.
Armin Novak [Mon, 19 Feb 2018 09:00:23 +0000 (10:00 +0100)]
Added assistance file name NULL check.

6 years agoMerge pull request #4448 from akallabeth/nightly_manpage_fix
MartinHaimberger [Fri, 16 Feb 2018 14:45:01 +0000 (15:45 +0100)]
Merge pull request #4448 from akallabeth/nightly_manpage_fix

Nightly manpage fix

6 years agoReenable -DWITH_SANITIZE_ADDRESS=ON for i386 builds.
Armin Novak [Fri, 16 Feb 2018 12:45:18 +0000 (13:45 +0100)]
Reenable -DWITH_SANITIZE_ADDRESS=ON for i386 builds.

Now that the manpage helper tool is always build without
address sanitizer there is no longer a reason to deactivate.

6 years agomanpage helper tool generation fixes
Armin Novak [Fri, 16 Feb 2018 12:42:10 +0000 (13:42 +0100)]
manpage helper tool generation fixes

The generator tool is called by CMake and is incompatible
with certain options. Therefore this commit
* removes WinPR dependency
* removes -fsanitize=* from CFLAGS

6 years agoMerge pull request #4447 from akallabeth/apple_rpath_namespace
Martin Fleisz [Fri, 16 Feb 2018 09:54:03 +0000 (10:54 +0100)]
Merge pull request #4447 from akallabeth/apple_rpath_namespace

Apple rpath namespace fixes

6 years agoFixed apple rpath settings.
Armin Novak [Fri, 16 Feb 2018 09:05:28 +0000 (10:05 +0100)]
Fixed apple rpath settings.

6 years agoRemoved apple flat-namespace hack.
Armin Novak [Fri, 16 Feb 2018 09:05:11 +0000 (10:05 +0100)]
Removed apple flat-namespace hack.

6 years agoMerge pull request #4446 from akallabeth/sam_crash_fix
David Fort [Fri, 16 Feb 2018 08:30:27 +0000 (09:30 +0100)]
Merge pull request #4446 from akallabeth/sam_crash_fix

Fix #3335: Do not call fclose on NULL file.

6 years agoFix #4445: Do not call fclose on NULL file.
Armin Novak [Fri, 16 Feb 2018 07:57:05 +0000 (08:57 +0100)]
Fix #4445: Do not call fclose on NULL file.

6 years agoMerge pull request #4440 from akallabeth/silence_unused_profiler
Martin Fleisz [Thu, 15 Feb 2018 11:22:50 +0000 (12:22 +0100)]
Merge pull request #4440 from akallabeth/silence_unused_profiler

Disable unused variable warning from profiler.

6 years agoFix PROFILER_* macros
Armin Novak [Thu, 15 Feb 2018 09:19:15 +0000 (10:19 +0100)]
Fix PROFILER_* macros

Add the semicolon to the macro to allow clean
undefinition if the profiler is not used.
This used to break VisualC compilers.

6 years agoMerge pull request #4414 from akallabeth/pthread_cleanup_fix
Martin Fleisz [Thu, 15 Feb 2018 10:02:37 +0000 (11:02 +0100)]
Merge pull request #4414 from akallabeth/pthread_cleanup_fix

Pthread cleanup fix

6 years agoModified RDG connection setup using PAA Cookie.
Jacco Braat [Tue, 13 Feb 2018 15:40:23 +0000 (16:40 +0100)]
Modified RDG connection setup using PAA Cookie.
Skip NTLM auth on the IN/OUT channels. Add PAACookie to TUNNEL_CREATE.

6 years agoAdded to rdp file parsing: gatewayaccesstoken:s:<token>
Jacco Braat [Tue, 13 Feb 2018 13:59:33 +0000 (14:59 +0100)]
Added to rdp file parsing: gatewayaccesstoken:s:<token>
Added to commandline parsing: /gat:<token>
Added GatewayAccessToken to sings

6 years agoMerge pull request #4325 from akallabeth/fixes_com
Martin Fleisz [Thu, 15 Feb 2018 09:39:33 +0000 (10:39 +0100)]
Merge pull request #4325 from akallabeth/fixes_com

Fixes serial redirection name check and SAM file parser

6 years agoMerge pull request #4415 from akallabeth/drdynvc_dyn_log
Martin Fleisz [Thu, 15 Feb 2018 09:06:05 +0000 (10:06 +0100)]
Merge pull request #4415 from akallabeth/drdynvc_dyn_log

Prefer dynamic logger in dynamic channel.

6 years agoMerge pull request #4434 from akallabeth/winpr_digest_param
Martin Fleisz [Wed, 14 Feb 2018 14:54:13 +0000 (15:54 +0100)]
Merge pull request #4434 from akallabeth/winpr_digest_param

Fixed winpr digest type.

6 years agoMerge pull request #4438 from akallabeth/gw_doublefree_fix
Martin Fleisz [Wed, 14 Feb 2018 14:02:53 +0000 (15:02 +0100)]
Merge pull request #4438 from akallabeth/gw_doublefree_fix

Fixed #4436: double free of http response.

6 years agoFixed #4436: double free of http response.
Armin Novak [Wed, 14 Feb 2018 13:09:12 +0000 (14:09 +0100)]
Fixed #4436: double free of http response.
Fixed #4436: reset of token split.

6 years agoMerge pull request #4435 from akallabeth/refguid_static
Martin Fleisz [Wed, 14 Feb 2018 13:13:52 +0000 (14:13 +0100)]
Merge pull request #4435 from akallabeth/refguid_static

fix windows nightly

6 years agoFixed missing error return.
Armin Novak [Wed, 14 Feb 2018 12:16:36 +0000 (13:16 +0100)]
Fixed missing error return.

6 years agoDo not export internal variables.
Armin Novak [Wed, 14 Feb 2018 12:05:39 +0000 (13:05 +0100)]
Do not export internal variables.

6 years agoMerge pull request #4432 from akallabeth/pubsub_fix
Martin Fleisz [Wed, 14 Feb 2018 11:58:48 +0000 (12:58 +0100)]
Merge pull request #4432 from akallabeth/pubsub_fix

Fixed PubSub function pointer casts.

6 years agoFixed winpr digest type.
Armin Novak [Wed, 14 Feb 2018 11:44:12 +0000 (12:44 +0100)]
Fixed winpr digest type.

6 years agoFixed broken extern C
Armin Novak [Wed, 14 Feb 2018 10:18:26 +0000 (11:18 +0100)]
Fixed broken extern C

6 years agoFixed PubSub function pointer casts.
Armin Novak [Wed, 14 Feb 2018 09:14:33 +0000 (10:14 +0100)]
Fixed PubSub function pointer casts.

6 years agoMerge pull request #4428 from hardening/video_fixes
akallabeth [Wed, 14 Feb 2018 09:52:24 +0000 (10:52 +0100)]
Merge pull request #4428 from hardening/video_fixes

fixes for video and other minor fixes

6 years agohttp: fix compilation with valgrind memcheck helpers
David Fort [Wed, 14 Feb 2018 09:15:51 +0000 (10:15 +0100)]
http: fix compilation with valgrind memcheck helpers

6 years agovideo, geometry: fix prototypes for timer callbacks
David Fort [Wed, 14 Feb 2018 09:12:32 +0000 (10:12 +0100)]
video, geometry: fix prototypes for timer callbacks

6 years agovideo: fix invalid geometry and invalid argument passing to time pubsub
David Fort [Tue, 13 Feb 2018 14:55:17 +0000 (15:55 +0100)]
video: fix invalid geometry and invalid argument passing to time pubsub

6 years agoMerge pull request #4430 from bmiklautz/rpmversion
Bernhard Miklautz [Tue, 13 Feb 2018 16:50:10 +0000 (17:50 +0100)]
Merge pull request #4430 from bmiklautz/rpmversion

pkg rpm: add support for .source_version in freerdp-nightly

6 years agopkg rpm: fix perapre script for freerdp-nightly
Bernhard Miklautz [Tue, 13 Feb 2018 15:36:20 +0000 (16:36 +0100)]
pkg rpm: fix perapre script for freerdp-nightly

6 years agopkg rpm: add version information to freerdp-nightly
Bernhard Miklautz [Tue, 13 Feb 2018 15:32:49 +0000 (16:32 +0100)]
pkg rpm: add version information to freerdp-nightly

6 years agopkg rpm: add prepare script for freerdp-nightly
Bernhard Miklautz [Tue, 13 Feb 2018 15:04:48 +0000 (16:04 +0100)]
pkg rpm: add prepare script for freerdp-nightly

6 years agoMerge pull request #4425 from akallabeth/windows_nego_fix
Bernhard Miklautz [Tue, 13 Feb 2018 14:26:44 +0000 (15:26 +0100)]
Merge pull request #4425 from akallabeth/windows_nego_fix

Fixed windows unicode authentication.

6 years agoMerge pull request #4426 from akallabeth/pointer_null_fix
Martin Fleisz [Tue, 13 Feb 2018 13:37:13 +0000 (14:37 +0100)]
Merge pull request #4426 from akallabeth/pointer_null_fix

Check if xfreerdp window != NULL

6 years agoMerge pull request #4364 from akallabeth/gateway_refactor
Martin Fleisz [Tue, 13 Feb 2018 12:48:45 +0000 (13:48 +0100)]
Merge pull request #4364 from akallabeth/gateway_refactor

Gateway refactor

6 years agoPrefer dynamic logger in dynamic channel.
Armin Novak [Fri, 9 Feb 2018 12:13:16 +0000 (13:13 +0100)]
Prefer dynamic logger in dynamic channel.

6 years agoMerge pull request #4376 from hardening/ms-rdpevor
Martin Fleisz [Tue, 13 Feb 2018 12:43:21 +0000 (13:43 +0100)]
Merge pull request #4376 from hardening/ms-rdpevor

Implement MS-RDPEVOR

6 years agoCheck if xfreerdp window != NULL
Armin Novak [Tue, 13 Feb 2018 12:38:02 +0000 (13:38 +0100)]
Check if xfreerdp window != NULL

When xfreerdp aborts a connection it may be before xfc->window was allocated.
Don't access it in that case.

6 years agoFixed windows unicode authentication.
Armin Novak [Tue, 13 Feb 2018 10:00:56 +0000 (11:00 +0100)]
Fixed windows unicode authentication.

6 years agoAdded missing FREERDP_API function export.
Armin Novak [Mon, 12 Feb 2018 14:32:56 +0000 (15:32 +0100)]
Added missing FREERDP_API function export.

6 years agoFixed gemoetry mapping.
Armin Novak [Thu, 8 Feb 2018 08:47:41 +0000 (09:47 +0100)]
Fixed gemoetry mapping.

6 years agoFixed copy offset issue.
Armin Novak [Thu, 8 Feb 2018 08:45:35 +0000 (09:45 +0100)]
Fixed copy offset issue.

6 years agoFixed code duplication.
Armin Novak [Thu, 8 Feb 2018 07:55:27 +0000 (08:55 +0100)]
Fixed code duplication.

6 years agoAdded software decoding fallback for RDPVOR
Armin Novak [Thu, 8 Feb 2018 07:44:46 +0000 (08:44 +0100)]
Added software decoding fallback for RDPVOR

6 years agoFixed scaled drawing of video content.
Armin Novak [Thu, 8 Feb 2018 06:49:50 +0000 (07:49 +0100)]
Fixed scaled drawing of video content.

6 years agovideo, geometry: fixed geometry handling
David Fort [Wed, 7 Feb 2018 16:13:14 +0000 (17:13 +0100)]
video, geometry: fixed geometry handling

It was not working when moving the video window.

6 years agovideo: mutualize things in the common channel code
David Fort [Fri, 2 Feb 2018 09:32:21 +0000 (10:32 +0100)]
video: mutualize things in the common channel code

6 years agovideo: do cleanups in post_connect
David Fort [Tue, 30 Jan 2018 16:57:45 +0000 (17:57 +0100)]
video: do cleanups in post_connect

6 years agodrdynvc: fixed stream leak on error
David Fort [Tue, 30 Jan 2018 10:36:17 +0000 (11:36 +0100)]
drdynvc: fixed stream leak on error

6 years agogeometry: drop server-side option for geometry
David Fort [Tue, 30 Jan 2018 10:35:23 +0000 (11:35 +0100)]
geometry: drop server-side option for geometry

6 years agovideo: fixed uninit of channel
David Fort [Tue, 30 Jan 2018 10:34:27 +0000 (11:34 +0100)]
video: fixed uninit of channel

6 years agovideo+geometry: fixed leaks, a segfault and concurrent accesses
David Fort [Fri, 26 Jan 2018 14:21:49 +0000 (15:21 +0100)]
video+geometry: fixed leaks, a segfault and concurrent accesses

6 years agovideo: fix prototype and cleanup at exit
David Fort [Tue, 23 Jan 2018 15:09:21 +0000 (16:09 +0100)]
video: fix prototype and cleanup at exit

6 years agovideo: an implementation of MS-RDPEVOR for X11
David Fort [Fri, 15 Dec 2017 10:15:24 +0000 (11:15 +0100)]
video: an implementation of MS-RDPEVOR for X11

Implements the decoding of video streams using common H264 decoders. We also implement
a trivial feedback algorithm.

Sponsored by: Rangee GmbH (http://www.rangee.de)

6 years agovideo: a skeleton for MS-RDPEVOR client
David Fort [Thu, 7 Dec 2017 21:50:29 +0000 (22:50 +0100)]
video: a skeleton for MS-RDPEVOR client

Basics for implementing the client side of the MS-RDPEVOR channel.

Sponsored by: Rangee GmbH (http://www.rangee.de)

6 years agogeometry: change the channel API to mutualize things
David Fort [Fri, 15 Dec 2017 10:16:34 +0000 (11:16 +0100)]
geometry: change the channel API to mutualize things

Try to mutualize things that are platform independant in the geometry client
channel.

Sponsored by: Rangee GmbH (http://www.rangee.de)

6 years agoMerge pull request #4423 from akallabeth/double_free
David Fort [Tue, 13 Feb 2018 09:43:49 +0000 (10:43 +0100)]
Merge pull request #4423 from akallabeth/double_free

bitmap free now always deallocating all resources.

6 years agobitmap free now always deallocating all resources.
Armin Novak [Tue, 13 Feb 2018 09:18:43 +0000 (10:18 +0100)]
bitmap free now always deallocating all resources.

6 years agoMerge pull request #4421 from akallabeth/x11_asan_fix_v2
David Fort [Mon, 12 Feb 2018 12:51:57 +0000 (13:51 +0100)]
Merge pull request #4421 from akallabeth/x11_asan_fix_v2

Fixed accidental free of XImage data.

6 years agoFixed accidental free of XImage data.
Armin Novak [Mon, 12 Feb 2018 10:14:54 +0000 (11:14 +0100)]
Fixed accidental free of XImage data.

6 years agoExit main thread with winpr_exit to trigger resource cleanup.
Armin Novak [Fri, 9 Feb 2018 11:25:45 +0000 (12:25 +0100)]
Exit main thread with winpr_exit to trigger resource cleanup.

When using pthread_once with destructors they are only called,
if each thread (including the main thread) is exited with pthread_exit.
Introducing winpr_exit as a wrapper for that purpose.

6 years agoMerge pull request #4420 from akallabeth/x11_memleak_fix
MartinHaimberger [Mon, 12 Feb 2018 09:27:19 +0000 (10:27 +0100)]
Merge pull request #4420 from akallabeth/x11_memleak_fix

Fixed #4412: XImage must be freed with XDestroyImage

6 years agoFixed #4412: XImage must be freed with XDestroyImage
Armin Novak [Mon, 12 Feb 2018 09:02:35 +0000 (10:02 +0100)]
Fixed #4412: XImage must be freed with XDestroyImage

6 years agoMerge pull request #4413 from akallabeth/memlead_queue_fixes
Martin Fleisz [Fri, 9 Feb 2018 11:42:43 +0000 (12:42 +0100)]
Merge pull request #4413 from akallabeth/memlead_queue_fixes

Memleak queue fixes

6 years agoSet up and tear down WLog
Armin Novak [Fri, 9 Feb 2018 11:08:39 +0000 (12:08 +0100)]
Set up and tear down WLog

6 years agoFixed cleanup of xfc->drawable.
Armin Novak [Fri, 9 Feb 2018 10:42:18 +0000 (11:42 +0100)]
Fixed cleanup of xfc->drawable.

6 years agoPrevent malloc of size 0
Armin Novak [Fri, 9 Feb 2018 10:41:53 +0000 (11:41 +0100)]
Prevent malloc of size 0

6 years agoAdded client channel queue object free function.
Armin Novak [Fri, 9 Feb 2018 09:39:46 +0000 (10:39 +0100)]
Added client channel queue object free function.

6 years agoAdd dynamic channel queue object free function.
Armin Novak [Fri, 9 Feb 2018 09:29:31 +0000 (10:29 +0100)]
Add dynamic channel queue object free function.

6 years agoClear message queue on free.
Armin Novak [Fri, 9 Feb 2018 09:29:18 +0000 (10:29 +0100)]
Clear message queue on free.

6 years agoFixed a memory leak.
Armin Novak [Fri, 9 Feb 2018 09:23:48 +0000 (10:23 +0100)]
Fixed a memory leak.

6 years agoMerge pull request #4411 from akallabeth/resolve_ipv6_fix
Martin Fleisz [Fri, 9 Feb 2018 08:40:00 +0000 (09:40 +0100)]
Merge pull request #4411 from akallabeth/resolve_ipv6_fix

Fixed IPv4/IPv6 to string

6 years agoFixed IPv4/IPv6 to string
Armin Novak [Thu, 8 Feb 2018 15:31:26 +0000 (16:31 +0100)]
Fixed IPv4/IPv6 to string

6 years agoMerge pull request #4380 from akallabeth/output_suppress_minimize
Norbert Federa [Thu, 8 Feb 2018 15:25:21 +0000 (16:25 +0100)]
Merge pull request #4380 from akallabeth/output_suppress_minimize

  Fixed SuppressOutput update.

6 years agoFixed GFX output expose.
Armin Novak [Thu, 8 Feb 2018 12:55:36 +0000 (13:55 +0100)]
Fixed GFX output expose.

6 years agoDo not update client if output suppressed.
Armin Novak [Thu, 8 Feb 2018 09:34:49 +0000 (10:34 +0100)]
Do not update client if output suppressed.

6 years agoFixed formatting.
Armin Novak [Thu, 8 Feb 2018 10:55:57 +0000 (11:55 +0100)]
Fixed formatting.

6 years agoFixed SuppressOutput update.
Armin Novak [Wed, 24 Jan 2018 15:26:27 +0000 (16:26 +0100)]
Fixed SuppressOutput update.

6 years agoMerge pull request #4408 from vinzent/rpm_spec_rhel7
Bernhard Miklautz [Wed, 7 Feb 2018 14:19:16 +0000 (15:19 +0100)]
Merge pull request #4408 from vinzent/rpm_spec_rhel7

Update rpm spec to support RHEL 7

6 years agoMerge pull request #4347 from akallabeth/h264_log
Martin Fleisz [Wed, 7 Feb 2018 14:03:35 +0000 (15:03 +0100)]
Merge pull request #4347 from akallabeth/h264_log

Using dynamic logger for GFX-H264 backend.

6 years agoMerge pull request #4409 from akallabeth/init_once_return
David Fort [Wed, 7 Feb 2018 13:33:02 +0000 (14:33 +0100)]
Merge pull request #4409 from akallabeth/init_once_return

Fixed init once return.

6 years agoFixed FFMPEG log messages.
Armin Novak [Wed, 7 Feb 2018 12:32:01 +0000 (13:32 +0100)]
Fixed FFMPEG log messages.

6 years agoUse dynamic logger in MediaFoundation backend
Armin Novak [Wed, 7 Feb 2018 09:45:28 +0000 (10:45 +0100)]
Use dynamic logger in MediaFoundation backend

6 years agoFixed obsolete TAG definitions and use.
Armin Novak [Fri, 19 Jan 2018 13:26:04 +0000 (14:26 +0100)]
Fixed obsolete TAG definitions and use.

6 years agoFix OpenH264 trace logging, set up context first
Armin Novak [Wed, 17 Jan 2018 14:35:11 +0000 (15:35 +0100)]
Fix OpenH264 trace logging, set up context first

6 years agoUsing dynamic logger for GFX-H264 backend.
Armin Novak [Tue, 9 Jan 2018 16:22:56 +0000 (17:22 +0100)]
Using dynamic logger for GFX-H264 backend.

6 years agoFixed init once return.
Armin Novak [Wed, 7 Feb 2018 12:13:02 +0000 (13:13 +0100)]
Fixed init once return.

6 years agoUpdate rpm spec to support RHEL 7
Thomas Mueller [Wed, 7 Feb 2018 08:33:44 +0000 (09:33 +0100)]
Update rpm spec to support RHEL 7

* fix bogus date in %changelog
* add/extend %if conditions for %{rhel}
* disable wayland on rhel <= 7
* enable GSSAPI and add krb5-devel build dep
* don't add provides information for libs of this package
  to prevent messing with packages depending on libs
  provided by system freerdp packages

6 years agoMerge pull request #4392 from akallabeth/yuv_asm
Norbert Federa [Wed, 7 Feb 2018 12:00:00 +0000 (13:00 +0100)]
Merge pull request #4392 from akallabeth/yuv_asm

Fixed AVC444v1 luma UV averaging

6 years agoMerge pull request #4397 from SriRamanujam/vaapi
Bernhard Miklautz [Wed, 7 Feb 2018 11:56:31 +0000 (12:56 +0100)]
Merge pull request #4397 from SriRamanujam/vaapi

Use libavcodec's VA-API to accelerate H.264 decoding.

6 years agoMerge pull request #4400 from hardening/defines_clean
Bernhard Miklautz [Wed, 7 Feb 2018 11:34:27 +0000 (12:34 +0100)]
Merge pull request #4400 from hardening/defines_clean

set some define consistency