Mark Nauwelaerts [Wed, 22 Sep 2010 11:55:20 +0000 (13:55 +0200)]
baseparse: localize use of provided fps information
Mark Nauwelaerts [Wed, 22 Sep 2010 10:13:12 +0000 (12:13 +0200)]
baseparse: seek table and accurate seek support
Mark Nauwelaerts [Tue, 21 Sep 2010 11:57:10 +0000 (13:57 +0200)]
baseparse: proper and more extended segment and seek handling
That is, loop pause handling, segment seek support, newsegment for gaps, etc
Mark Nauwelaerts [Tue, 21 Sep 2010 08:57:04 +0000 (10:57 +0200)]
baseparse: add index support
Mark Nauwelaerts [Tue, 21 Sep 2010 07:59:56 +0000 (09:59 +0200)]
baseparse: refactor state reset
Mark Nauwelaerts [Mon, 20 Sep 2010 14:39:37 +0000 (16:39 +0200)]
baseparse: prevent indefinite resyncing
Mark Nauwelaerts [Mon, 20 Sep 2010 11:57:55 +0000 (13:57 +0200)]
baseparse: specific EOS handling if no output so far
Mark Nauwelaerts [Mon, 20 Sep 2010 11:31:57 +0000 (13:31 +0200)]
baseparse: adjust _set_frame_prop documentation and set default as claimed
Mark Nauwelaerts [Mon, 20 Sep 2010 11:30:54 +0000 (13:30 +0200)]
baseparse: fix bitrate copy-and-paste and update heuristic
Mark Nauwelaerts [Fri, 17 Sep 2010 16:33:29 +0000 (18:33 +0200)]
baseparse: post duration message if average bitrates is updated
Mark Nauwelaerts [Fri, 17 Sep 2010 16:24:22 +0000 (18:24 +0200)]
baseparse: remove is_seekable vmethod and use a set_seek instead
Seekability, like duration, etc is unlikely to change (frequently), and
the default assumption covers most cases, so let subclass set when needed.
At the same time, allow subclass to indicate if it has seek-metadata (table)
available, and possibly have it provide an average bitrate.
Mark Nauwelaerts [Fri, 17 Sep 2010 15:35:40 +0000 (17:35 +0200)]
ac3parse: remove redundant default is_seekable
Mark Nauwelaerts [Fri, 17 Sep 2010 15:21:46 +0000 (17:21 +0200)]
baseparse: add another hook for subclass prior to pushing buffer
... and allow subclass to perform custom segment clipping, or to
emit tags or messages at this time.
Mark Nauwelaerts [Fri, 17 Sep 2010 15:19:37 +0000 (17:19 +0200)]
baseparse: 0 converts to 0 by default
Mark Nauwelaerts [Thu, 16 Sep 2010 16:56:46 +0000 (18:56 +0200)]
basepase: refactor conversion using helper function and export default convert
Mark Nauwelaerts [Thu, 16 Sep 2010 16:35:47 +0000 (18:35 +0200)]
baseparse: streamline query handling
Mark Nauwelaerts [Thu, 16 Sep 2010 09:51:20 +0000 (11:51 +0200)]
baseparse: cleanup struct and remove unused member
Mark Nauwelaerts [Mon, 16 Aug 2010 09:04:37 +0000 (11:04 +0200)]
audioparsers: increase ranks to enable auto-plugging
Because we can, and should, have some shakedown testing before having
these make it into -good later on ...
Arun Raghavan [Wed, 22 Sep 2010 10:37:24 +0000 (16:07 +0530)]
baseparse: Allow chaining of subclass event handlers
This allows the child class to chain its event handler with
GstBaseParse, so that subclasses don't have to duplicate all the default
event handling logic.
https://bugzilla.gnome.org/show_bug.cgi?id=622276
Sebastian Dröge [Fri, 27 Aug 2010 16:35:10 +0000 (18:35 +0200)]
baseparse: Don't use GST_FLOW_IS_FATAL()
Also don't post an error message for UNEXPECTED and do it
for NOT_LINKED.
Mark Nauwelaerts [Mon, 6 Sep 2010 12:12:00 +0000 (14:12 +0200)]
baseparse: non-TIME seek event is simply not handled
Mark Nauwelaerts [Tue, 15 Jun 2010 13:34:05 +0000 (15:34 +0200)]
baseparse: fix seek event ref handling
Mark Nauwelaerts [Tue, 15 Jun 2010 13:33:37 +0000 (15:33 +0200)]
baseparse: prevent arithmetic overflows in pull mode buffer cache handling
Mark Nauwelaerts [Tue, 15 Jun 2010 13:32:34 +0000 (15:32 +0200)]
baseparse: fix seek handling
Allow a few more seek event type combinations, and really use the result
of gst_segment_set_seek to perform the seek. Also add some debug.
Edward Hervey [Mon, 12 Apr 2010 16:07:29 +0000 (18:07 +0200)]
check: Don't re-declare 'GList *buffers' in the tests
It's an external which lives in gstcheck.c. Redeclaring it makes some
compilers/architectures think the 'buffers' in the individual tests are
a different symbol... and therefore we end up comparing holodecks with
oranges.
Arun Raghavan [Fri, 26 Mar 2010 18:56:49 +0000 (18:56 +0000)]
baseparse: Don't emit bitrate tags too early
We wait to parse a minimum number of frames (10, arbitrarily) before
emiting bitrate tags so that our early estimates are not wildly
inaccurate for streams that start with a silence. If the stream ends
before that, we just emit the tags anyway.
While it _would_ be nicer to be specify the threshold to start pushing
the tags in terms of duration, this would introduce more complexity than
this merits.
https://bugzilla.gnome.org/show_bug.cgi?id=614991
Sebastian Dröge [Fri, 26 Mar 2010 17:58:35 +0000 (18:58 +0100)]
flacparse: Optionally check the overall frame checksums too before accepting a frame as valid
This is optional because it's a quite expensive operation and it's very
unlikely that a non-frame is detected as frame after the header CRC check
and checking all bits for valid values. The overall frame checksums are
mainly useful to detect inconsistencies in the encoded payload.
Sebastian Dröge [Fri, 26 Mar 2010 17:42:28 +0000 (18:42 +0100)]
flacparse: Check the CRC-8 of the headers before accepting a frame as valid
This makes false-positives during seeking much less likely and detection of
them much faster.
Sebastian Dröge [Fri, 26 Mar 2010 17:20:24 +0000 (18:20 +0100)]
baseparse: Set the last stop to the buffer starttime if the duration is invalid
...instead of not setting it at all.
Joshua M. Doe [Fri, 26 Mar 2010 17:19:00 +0000 (18:19 +0100)]
baseparse: Send NEWSEGMENT event with correct start and position
Instead of taking the last stop (which could be buffer endtime instead
of starttime) always take the buffer starttime.
Fixes bug #614016.
Arun Raghavan [Fri, 26 Mar 2010 16:49:01 +0000 (16:49 +0000)]
flacparse: Fix buffer refcount issue
When called from the GST_FLAC_PARSE_STATE_HEADERS case,
gst_flac_parse_hand_headers() does a gst_buffer_set_caps() on a buffer
with refcount > 1. This change handles this case by making the buffer
metadata_Writable.
https://bugzilla.gnome.org/show_bug.cgi?id=614037
Tim-Philipp Müller [Thu, 25 Mar 2010 17:09:17 +0000 (17:09 +0000)]
audioparsers: remove unused GstBaseParseClassPrivate structure
Arun Raghavan [Thu, 25 Mar 2010 12:55:02 +0000 (12:55 +0000)]
flacparse: Make bitrate estimation more accurate
This implements the get_frame_overhead() vfunc so that baseparse can
make more accurate bitrate estimates.
Arun Raghavan [Thu, 25 Mar 2010 11:48:46 +0000 (11:48 +0000)]
aacparse: Fix bitrate calculation
This patch adds the get_frame_overhead() vfunc so that baseparse can
accurately calculate the min/avg/max bitrates for aacparse.
Note: The bitrate was being incorrectly calculated for ADTS streams
(it's not in the header as the code suggests).
Arun Raghavan [Thu, 25 Mar 2010 11:22:58 +0000 (11:22 +0000)]
audioparsers: Add bitrate calculation to baseparse
This makes baseparse keep a running average of the stream bitrate, as
well as the minimum and maximum bitrates. Subclasses can override a
vfunc to make sure that per-frame overhead from the container is not
accounted for in the bitrate calculation.
We take care not to override the bitrate, minimum-bitrate, and
maximum-bitrate tags if they have been posted upstream. We also
rate-limit the emission of bitrate so that it is only triggered by a
change of >10 kbps.
Benjamin Otte [Mon, 22 Mar 2010 15:56:03 +0000 (16:56 +0100)]
Add -Wold-style-definition
and fix the warnings
Benjamin Otte [Sun, 21 Mar 2010 20:39:18 +0000 (21:39 +0100)]
Add -Wmissing-declarations -Wmissing-prototypes to configure flags
And fix all warnings
Benjamin Otte [Thu, 18 Mar 2010 16:30:26 +0000 (17:30 +0100)]
gst_element_class_set_details => gst_element_class_set_details_simple
Mark Nauwelaerts [Thu, 14 Jan 2010 10:50:33 +0000 (11:50 +0100)]
audioparsers: rename baseparse GType name to avoid possible conflicts
Edward Hervey [Tue, 12 Jan 2010 17:55:53 +0000 (18:55 +0100)]
flacparse: Initialize variables.
Fixes build on $#@*( macosx
Ðóñëàí Èæáóëàòîâ [Mon, 11 Jan 2010 19:41:57 +0000 (22:41 +0300)]
win32: Include config.h before anything else. Fix mpegdemux LIBADD
Because config.h defines __MSVCRT_VERSION__, which should be defined
before inclusion of any system header.
Also fixes mpegdemux Makefile.am LIBADD typo.
Fixes #606665
Thiago Santos [Mon, 11 Jan 2010 16:20:26 +0000 (13:20 -0300)]
aacparse: Also add stream-format to template caps
Do not forget to add stream-format to template caps
off aacparse
Thiago Santos [Mon, 11 Jan 2010 16:13:41 +0000 (13:13 -0300)]
Rename aac's stream-format 'none' to 'raw'
Renames aac's stream-format from previous commits from none to
raw
Thiago Santos [Mon, 11 Jan 2010 15:10:02 +0000 (12:10 -0300)]
aacparse: update tests to stream-format changes
Updates aacparse unit tests to check for stream-format
correctness as well.
Thiago Santos [Mon, 11 Jan 2010 13:51:18 +0000 (10:51 -0300)]
aacparse: Add stream-format to output caps
Adds stream-format field to output caps
Mark Nauwelaerts [Tue, 5 Jan 2010 14:05:05 +0000 (15:05 +0100)]
audioparsers: documentation fixes
Mark Nauwelaerts [Tue, 5 Jan 2010 14:04:38 +0000 (15:04 +0100)]
ac3parse: add documentation
Mark Nauwelaerts [Tue, 5 Jan 2010 13:48:49 +0000 (14:48 +0100)]
flacparse: add documentation
Mark Nauwelaerts [Mon, 21 Dec 2009 17:29:43 +0000 (18:29 +0100)]
flacparse: perform additional frame checks when resyncing
Mark Nauwelaerts [Tue, 5 Jan 2010 15:35:52 +0000 (16:35 +0100)]
flacparse: fix (multiple channel) frame parsing
Mark Nauwelaerts [Tue, 5 Jan 2010 15:35:44 +0000 (16:35 +0100)]
flacparse: declare unparsed input and parsed output
Mark Nauwelaerts [Mon, 21 Dec 2009 17:19:23 +0000 (18:19 +0100)]
ac3parse: fix scanning for next syncword
Mark Nauwelaerts [Mon, 21 Dec 2009 17:18:39 +0000 (18:18 +0100)]
baseparse: adjust seek handling and newsegment sending
Perform sanity check on type of seek, and only perform one that is
appropriately supported. Adjust downstream newsegment event
to first buffer timestamp that is sent downstream.
Mark Nauwelaerts [Mon, 21 Dec 2009 10:59:45 +0000 (11:59 +0100)]
baseparse: minor refactor cleanup
Also add some debug logging.
Mark Nauwelaerts [Fri, 18 Dec 2009 20:05:11 +0000 (21:05 +0100)]
flacparse: locate next sync code more efficiently
Mark Nauwelaerts [Fri, 18 Dec 2009 20:04:12 +0000 (21:04 +0100)]
flacparse: baseparse takes care of handling leftover pieces
Mark Nauwelaerts [Fri, 18 Dec 2009 20:02:40 +0000 (21:02 +0100)]
baseparse: implement leftover draining in pull mode
Mark Nauwelaerts [Thu, 17 Dec 2009 11:45:36 +0000 (12:45 +0100)]
flacparse: set _OFFSET and _OFFSET_END on outgoing buffers
Mark Nauwelaerts [Thu, 17 Dec 2009 11:44:20 +0000 (12:44 +0100)]
audioparsers: move 'flacparse' into it
Mark Nauwelaerts [Wed, 16 Dec 2009 17:38:33 +0000 (18:38 +0100)]
baseparse: provide default conversion using bps if no fps available
Also store estimated duration as such, rather than pretending otherwise
(e.g. set by subclass).
Mark Nauwelaerts [Fri, 18 Dec 2009 12:30:29 +0000 (13:30 +0100)]
baseparse: check for remaining data when draining in push mode
Mark Nauwelaerts [Fri, 18 Dec 2009 12:30:07 +0000 (13:30 +0100)]
baseparse: fix pull mode cache size comparison
Edward Hervey [Fri, 18 Dec 2009 12:01:17 +0000 (13:01 +0100)]
ac3parse: Fix unitialized variable.
Christian Schaller [Thu, 17 Dec 2009 14:46:01 +0000 (14:46 +0000)]
Update spec file and fix ac3parser header listing in Makefile.am
Michael Smith [Fri, 11 Dec 2009 18:25:16 +0000 (10:25 -0800)]
audioparse: fix a format string as reported on irc.
Mark Nauwelaerts [Mon, 23 Nov 2009 15:34:50 +0000 (16:34 +0100)]
ac3parse: ensure sufficient data available for parsing
Mark Nauwelaerts [Thu, 29 Oct 2009 14:19:04 +0000 (15:19 +0100)]
ac3parse: extract and use some more details for Enhanced Ac-3 streams
Mark Nauwelaerts [Thu, 29 Oct 2009 14:18:37 +0000 (15:18 +0100)]
baseparse: custom bufferflag indicates not to count frame in stats
Mark Nauwelaerts [Wed, 28 Oct 2009 13:08:43 +0000 (14:08 +0100)]
ac3parse: perform additional frame checks when resyncing
Mark Nauwelaerts [Wed, 28 Oct 2009 13:07:17 +0000 (14:07 +0100)]
ac3parse: inform base parser of frame duration
Mark Nauwelaerts [Tue, 27 Oct 2009 15:16:50 +0000 (16:16 +0100)]
ac3parse: improve src caps settings
Mark Nauwelaerts [Fri, 27 Nov 2009 16:59:03 +0000 (17:59 +0100)]
ac3parse: initial version
MARGINAL rank for now; might take some time for some (useful)
framed=true/false to appear here and there.
Mark Nauwelaerts [Thu, 26 Nov 2009 17:34:45 +0000 (18:34 +0100)]
amrparse: use (default) time handling of baseparser class
Mark Nauwelaerts [Thu, 26 Nov 2009 17:15:21 +0000 (18:15 +0100)]
audioparsers: move 'amrparse' into it
Mark Nauwelaerts [Fri, 27 Nov 2009 16:27:32 +0000 (17:27 +0100)]
audioparsers: reference GstBaseParse now lives here
Mark Nauwelaerts [Sat, 28 Nov 2009 17:13:31 +0000 (18:13 +0100)]
audioparsers: rename 'aacparse' plugin to generic 'audioparsers' plugin
Mark Nauwelaerts [Thu, 26 Nov 2009 16:04:43 +0000 (17:04 +0100)]
aacparse: separate plugin registration and rename plugin
Mark Nauwelaerts [Thu, 26 Nov 2009 16:04:36 +0000 (17:04 +0100)]
aacparse: ensure sufficient data available before accessing
Mark Nauwelaerts [Thu, 5 Nov 2009 13:31:40 +0000 (14:31 +0100)]
aacparse: use (default) time handling of baseparser class
Mark Nauwelaerts [Thu, 29 Oct 2009 14:19:35 +0000 (15:19 +0100)]
aacparse: fixup comments to C-style
Mark Nauwelaerts [Thu, 29 Oct 2009 15:05:00 +0000 (16:05 +0100)]
baseparse: reset passthrough mode to default (disabled) on activation
Mark Nauwelaerts [Thu, 29 Oct 2009 14:16:59 +0000 (15:16 +0100)]
baseparse: ensure buffer metadata is writable
Mark Nauwelaerts [Wed, 28 Oct 2009 13:06:13 +0000 (14:06 +0100)]
baseparse: fix/enhance DISCONT marking
In particular, consider DISCONT == !sync, and allow subclass to query
sync state, as it may want to perform additional checks depending
on whether sync was achieved earlier on.
Also arrange for subclass to query whether leftover data is being drained.
Mark Nauwelaerts [Mon, 23 Nov 2009 14:48:25 +0000 (15:48 +0100)]
baseparse: add timestamp handling, and default conversion
In particular, (optionally) provide baseparse with a notion of frames per second
(and therefore also frame duration) and have it track frame and byte counts.
This way, subclass can provide baseparse with fps and have it provide default
buffer time metadata and conversions, though subclass can still install
callbacks to handle such itself.
Mark Nauwelaerts [Wed, 28 Oct 2009 11:02:03 +0000 (12:02 +0100)]
baseparse: documentation fixes
Mark Nauwelaerts [Wed, 28 Oct 2009 11:00:08 +0000 (12:00 +0100)]
baseparse: use_fixed_caps for src pad
After all, stream is as-is, and there is little molding to downstream's
taste that can be done. If subclass can and wants to do so, it can
still override as such.
Julien Moutte [Fri, 20 Nov 2009 16:32:13 +0000 (17:32 +0100)]
aacparse: Fix compilation warnings
Josep Torra [Sun, 11 Oct 2009 09:22:11 +0000 (11:22 +0200)]
aacparse: fix warnings in macosx snow leopard
Mark Nauwelaerts [Fri, 25 Sep 2009 15:02:53 +0000 (17:02 +0200)]
aacparse: forego (bogus) parsing of already parsed (raw) input
Mark Nauwelaerts [Fri, 7 Aug 2009 11:07:17 +0000 (13:07 +0200)]
baseparse: prevent infinite loop when draining
Mark Nauwelaerts [Fri, 7 Aug 2009 11:06:28 +0000 (13:06 +0200)]
baseparse: fix minor memory leak
Sebastian Dröge [Tue, 14 Jul 2009 12:08:04 +0000 (14:08 +0200)]
aacparse: Add function for the baseparse subclass to push buffers downstream
Also handle the case gracefully where the subclass decides to drop
the first buffers and has no caps set yet. It's still required to
have valid caps set when the first buffer should be passed downstream.
Sebastian Dröge [Tue, 14 Jul 2009 12:07:44 +0000 (14:07 +0200)]
baseparse: Fix seek event leaking
Mark Nauwelaerts [Thu, 18 Jun 2009 10:13:28 +0000 (12:13 +0200)]
aacparse: ADIF: do not send bogus timestamps, leave to downstream (decoder)
Tim-Philipp Müller [Mon, 1 Jun 2009 14:53:27 +0000 (15:53 +0100)]
aacparse: fix sample rate extraction from codec data
In one case we extracted the sample rate index from the codec data
and saved it as sample rate rather than getting the real sample
rate from the table. Fix that, and also make sure we don't access
non-existant table entries by adding a small helper function that
guards against out-of-bounds access in case of invalid input data.
Tim-Philipp Müller [Mon, 1 Jun 2009 13:02:33 +0000 (14:02 +0100)]
aacparse, amrparse: remove bogus gst_pad_fixate_caps() calls
Tim-Philipp Müller [Mon, 1 Jun 2009 12:56:18 +0000 (13:56 +0100)]
baseparse: propagate return value of GstBaseParse::set_sink_caps()
gst_base_parse_sink_setcaps() presumably should fail if the subclass
returns FALSE from its ::set_sink_caps() function.
Tim-Philipp Müller [Mon, 1 Jun 2009 12:47:01 +0000 (13:47 +0100)]
baseparse: don't try to GST_LOG an already-freed caps string
The proper way to log caps is via GST_PTR_FORMAT anyway.
Tim-Philipp Müller [Mon, 1 Jun 2009 12:05:35 +0000 (13:05 +0100)]
aacparse: set channels and rate on output caps, and keep codec_data
Create output caps from input caps, so we maintain any fields we
might get on the input caps, such as codec_data or rate and channels.
Set channels and rate on the output caps if we don't have input caps
or they don't contain such fields. We do this partly because we can,
but also because some muxers need this information. Tagreadbin will
also be happy about this.
Mark Nauwelaerts [Tue, 26 May 2009 17:43:53 +0000 (19:43 +0200)]
baseparse: fix debug category