Marcin Kostrzewa [Mon, 18 Mar 2013 00:44:43 +0000 (01:44 +0100)]
util: fix util.inspect() line width calculation
Have the formatter filter out vt100 color codes when calculating the
line width. Stops it from unnecessarily splitting strings over multiple
lines.
Fixes #5039.
Ben Noordhuis [Tue, 26 Mar 2013 22:19:50 +0000 (23:19 +0100)]
openssl: make sed tool configurable
Those poor sods on systems where /usr/bin/sed is a BSD sed can now do
`make -C deps/openssl/asm SED=gsed`.
isaacs [Tue, 26 Mar 2013 17:17:47 +0000 (10:17 -0700)]
test: Use 'close' event in simple/test-repl-timeout-throw
Trevor Norris [Mon, 25 Mar 2013 18:55:44 +0000 (11:55 -0700)]
buffer: remove _charsWritten
_charsWritten is an internal property that was constantly written to,
but never read from. So it has been removed.
Removed documentation reference as well.
Manav Rathi [Mon, 18 Mar 2013 14:10:41 +0000 (19:40 +0530)]
tls: expose SSL_CTX_set_timeout via tls.createServer
Add the `sessionTimeout` integral value to the list of options
recognized by `tls.createServer`.
This option will be useful for applications which need frequently
establish short-lived TLS connections to the same endpoint. The TLS
tickets RFC is an ideal option to reduce the socket setup overhead
for such scenarios, but the default ticket timeout value (5
minutes) is too low to be useful.
Ben Noordhuis [Mon, 25 Mar 2013 23:27:23 +0000 (00:27 +0100)]
Merge remote-tracking branch 'origin/v0.10'
Conflicts:
deps/v8/src/objects-inl.h
deps/v8/src/objects.h
src/node_crypto.cc
Timothy J Fontaine [Mon, 25 Mar 2013 23:16:44 +0000 (16:16 -0700)]
test: test name is the last elem, not second
When a test requires node to have parameters passed (--expose-gc) the
test name will be the last element in the command array, not the second.
Ben Noordhuis [Sun, 24 Mar 2013 23:29:55 +0000 (00:29 +0100)]
child_process: don't emit same handle twice
It's possible to read multiple messages off the parent/child channel.
When that happens, make sure that recvHandle is cleared after emitting
the first message so it doesn't get emitted twice.
Ben Noordhuis [Mon, 18 Mar 2013 23:16:55 +0000 (00:16 +0100)]
crypto: make getCiphers() return non-SSL ciphers
Commit f53441a added crypto.getCiphers() as a function that returns the
names of SSL ciphers.
Commit 14a6c4e then added crypto.getHashes(), which returns the names of
digest algorithms, but that creates a subtle inconsistency: the return
values of crypto.getHashes() are valid arguments to crypto.createHash()
but that is not true for crypto.getCiphers() - the returned values are
only valid for SSL/TLS functions.
Rectify that by adding tls.getCiphers() and making crypto.getCiphers()
return proper cipher names.
Mathias Bynens [Tue, 19 Mar 2013 08:10:23 +0000 (09:10 +0100)]
doc: mention `process.*.isTTY` under `process`
Ben Noordhuis [Thu, 14 Mar 2013 15:59:07 +0000 (16:59 +0100)]
child_process: fix sending utf-8 to child process
In process#send() and child_process.ChildProcess#send(), use 'utf8' as
the encoding instead of 'ascii' because 'ascii' mutilates non-ASCII
input. Correctly handle partial character sequences by introducing
a StringDecoder.
Sending over UTF-8 no longer works in v0.10 because the high bit of
each byte is now cleared when converting a Buffer to ASCII. See
commit 96a314b for details.
Fixes #4999 and #5011.
Ben Noordhuis [Thu, 21 Mar 2013 12:12:41 +0000 (13:12 +0100)]
bench: add child process read perf benchmark
Ben Noordhuis [Sun, 24 Mar 2013 21:53:07 +0000 (22:53 +0100)]
deps: fix openssl build on windows
Commit 8632af3 ("tools: update gyp to r1601") broke the Windows build.
Older versions of GYP link to kernel32.lib, user32.lib, etc. but that
was changed in r1584. See https://codereview.chromium.org/
12256017
Fix the build by explicitly linking to the required libraries.
isaacs [Fri, 22 Mar 2013 01:18:55 +0000 (18:18 -0700)]
stream: Fix early end in Writables on zero-length writes
Doing this causes problems:
z.write(Buffer(0));
z.end();
Fix by not ending Writable streams while they're still in the process of
writing something.
Ben Noordhuis [Sun, 24 Mar 2013 13:29:17 +0000 (14:29 +0100)]
tools: update gyp to r1601
Among other things, this should make it easier for people to build
node.js on openbsd.
Ben Noordhuis [Sun, 24 Mar 2013 12:22:01 +0000 (13:22 +0100)]
doc: update CONTRIBUTING.md
* Latest stable is v0.10 now.
* Add example of what the first line of the commit log should look like.
Alexey Kupershtokh [Fri, 26 Oct 2012 05:49:22 +0000 (12:49 +0700)]
timer: fix off-by-one ms error
Fix #5103
Timothy J Fontaine [Fri, 22 Mar 2013 20:51:11 +0000 (13:51 -0700)]
fs: uv_[fl]stat now reports subsecond resolution
While libuv supports reporting subsecond stat resolution across
platforms, to actually get that resolution your platform and filesystem
must support it (not HFS, ext[23], fat), otherwise the nsecs are 0
Ben Noordhuis [Sat, 23 Mar 2013 18:17:12 +0000 (19:17 +0100)]
deps: upgrade libuv to eca008a
Marcel Laverdet [Thu, 21 Mar 2013 21:56:02 +0000 (16:56 -0500)]
tls: remove harmful unnecessary bounds checking
The EncIn, EncOut, ClearIn & ClearOut functions are victims of some code
copy + pasting. A common line copied to all of them is:
`if (off >= buffer_length) { ...`
448e0f43 corrected ClearIn's check from `>=` to `>`, but left the others
unchanged (with an incorrect bounds check). However, if you look down at
the next very next bounds check you'll see:
`if (off + len > buffer_length) { ...`
So the check is actually obviated by the next line, and should be
removed.
This fixes an issue where writing a zero-length buffer to an encrypted
pair's *encrypted* stream you would get a crash.
Marcel Laverdet [Thu, 21 Mar 2013 21:56:02 +0000 (16:56 -0500)]
tls: remove harmful unnecessary bounds checking
The EncIn, EncOut, ClearIn & ClearOut functions are victims of some code
copy + pasting. A common line copied to all of them is:
`if (off >= buffer_length) { ...`
448e0f43 corrected ClearIn's check from `>=` to `>`, but left the others
unchanged (with an incorrect bounds check). However, if you look down at
the next very next bounds check you'll see:
`if (off + len > buffer_length) { ...`
So the check is actually obviated by the next line, and should be
removed.
This fixes an issue where writing a zero-length buffer to an encrypted
pair's *encrypted* stream you would get a crash.
verwaest@chromium.org [Mon, 18 Mar 2013 13:35:17 +0000 (13:35 +0000)]
v8: Unify kMaxArguments with number of bits used to encode it.
Increase the number of bits by 1 by making Flags unsigned.
BUG=chromium:211741
Review URL: https://chromiumcodereview.appspot.com/
12886008
This is a back-port of commits 13964 and 13988 addressing CVE-2013-2632.
Ben Noordhuis [Sat, 23 Mar 2013 14:48:56 +0000 (15:48 +0100)]
crypto: check randomBytes() size argument
Throw a TypeError if size > 0x3fffffff. Avoids the following V8 fatal
error:
FATAL ERROR: v8::Object::SetIndexedPropertiesToExternalArrayData()
length exceeds max acceptable value
Fixes #5126.
Ben Noordhuis [Sat, 23 Mar 2013 14:38:17 +0000 (15:38 +0100)]
doc: document that stdio is usually blocking
Gil Pedersen [Sun, 17 Mar 2013 14:04:01 +0000 (15:04 +0100)]
stream: Fix stall in Transform under very specific conditions
The stall is exposed in the test, though the test itself asserts before
it stalls.
The test is constructed to replicate the stalling state of a complex
Passthrough usecase since I was not able to reliable trigger the stall.
Some of the preconditions for triggering the stall are:
* rs.length >= rs.highWaterMark
* !rs.needReadable
* _transform() handler that can return empty transforms
* multiple sync write() calls
Combined this can trigger a case where rs.reading is not cleared when
further progress requires this. The fix is to always clear rs.reading.
Fedor Indutny [Thu, 21 Mar 2013 17:38:30 +0000 (21:38 +0400)]
timers: handle signed int32 overflow in enroll()
Before this patch calling `socket.setTimeout(0xffffffff)` will result in
signed int32 overflow in C++ which resulted in assertion error:
Assertion failed: (timeout >= -1), function uv__io_poll, file
../deps/uv/src/unix/kqueue.c, line 121.
see #5101
Trevor Norris [Thu, 21 Mar 2013 17:50:25 +0000 (10:50 -0700)]
doc: update that ascii write doesn't convert null
Since WriteBuffer has been replaced with WriteOneByte, writing ascii
will no longer automatically convert 0x0 to 0x20. So removed mention of
this special case from docs.
isaacs [Thu, 21 Mar 2013 17:52:01 +0000 (10:52 -0700)]
Merge remote-tracking branch 'ry/v0.10' into master
Conflicts:
src/node.cc
src/node_version.h
Trevor Norris [Thu, 21 Mar 2013 16:26:23 +0000 (09:26 -0700)]
src: write ascii strings using WriteOneByte
WriteAscii will be deprecated soon from v8, and performance has
regressed. The v8 team recommended using WriteOneByte instead.
isaacs [Thu, 21 Mar 2013 16:14:01 +0000 (09:14 -0700)]
blog: Post for v0.10.1
isaacs [Thu, 21 Mar 2013 16:14:23 +0000 (09:14 -0700)]
Now working on v0.10.2
isaacs [Thu, 21 Mar 2013 16:13:45 +0000 (09:13 -0700)]
Merge branch 'v0.10.1-release' into v0.10
Ben Noordhuis [Thu, 21 Mar 2013 13:59:16 +0000 (14:59 +0100)]
deps: upgrade libuv to 9b61939
isaacs [Thu, 21 Mar 2013 01:15:04 +0000 (18:15 -0700)]
2013.03.21, Version 0.10.1 (Stable)
* npm: upgrade to 1.2.15
* crypto: Improve performance of non-stream APIs (Fedor Indutny)
* tls: always reset this.ssl.error after handling (Fedor Indutny)
* tls: Prevent mid-stream hangs (Fedor Indutny, isaacs)
* net: improve arbitrary tcp socket support (Ben Noordhuis)
* net: handle 'finish' event only after 'connect' (Fedor Indutny)
* http: Don't hot-path end() for large buffers (isaacs)
* fs: Missing cb errors are deprecated, not a throw (isaacs)
* fs: make write/appendFileSync correctly set file mode (Raymond Feng)
* stream: Return self from readable.wrap (isaacs)
* stream: Never call decoder.end() multiple times (Gil Pedersen)
* windows: enable watching signals with process.on('SIGXYZ') (Bert Belder)
* node: revert removal of MakeCallback (Trevor Norris)
* node: Unwrap without aborting in handle fd getter (isaacs)
isaacs [Thu, 21 Mar 2013 00:49:57 +0000 (17:49 -0700)]
npm: upgrade to 1.2.15
Fedor Indutny [Fri, 15 Mar 2013 08:59:30 +0000 (12:59 +0400)]
crypto: initialize transform lazily
isaacs [Wed, 20 Mar 2013 23:14:36 +0000 (16:14 -0700)]
tls: Prevent hang in readStart
This is not a great fix, and it's a bug that's very tricky to reproduce.
Occasionally, while downloading a file, especially on Linux for some
reason, the pause/resume timing will be just right such that the
CryptoStream is in a 'reading' state, but actually has no data, so it
ought to pull more in. Because there's no reads happening, it just sits
there, and the process will exit
This is, fundamentally, a factor of how the HTTP implementation sits
atop CryptoStreams and TCP Socket objects, which is utterly horrible,
and needs to be rewritten. However, in the meantime, npm downloads are
prematurely exiting, causing hard-to-debug "cb() never called!" errors.
Trevor Norris [Wed, 20 Mar 2013 08:58:11 +0000 (01:58 -0700)]
bench: compare binaries equal times
The benchmark compare would drop the last run of the binary pairs. So
when they were only run once an error would arise because no data was
generated for the second binary.
Ben Noordhuis [Wed, 20 Mar 2013 15:53:23 +0000 (16:53 +0100)]
bench: add dgram send/recv benchmark
Fedor Indutny [Wed, 20 Mar 2013 13:35:38 +0000 (17:35 +0400)]
tls: always reset this.ssl.error after handling
Otherwise assertion may happen:
src/node_crypto.cc:962: void node::crypto::Connection::ClearError():
Assertion `handle_->Get(String::New("error"))->BooleanValue() == false'
failed.
See #5058
Fedor Indutny [Wed, 20 Mar 2013 08:25:46 +0000 (12:25 +0400)]
v8: unbreak build on smartos after
831af97df211f04
Ben Noordhuis [Wed, 20 Mar 2013 00:56:29 +0000 (01:56 +0100)]
src: bump NODE_MODULE_VERSION after abi change
Ben Noordhuis [Wed, 20 Mar 2013 00:53:14 +0000 (01:53 +0100)]
test: fix up weakref.cc after v8 api change
Raymond Feng [Wed, 20 Mar 2013 00:37:03 +0000 (01:37 +0100)]
fs: make write/appendFileSync correctly set file mode
Trevor Norris [Tue, 19 Mar 2013 21:55:05 +0000 (14:55 -0700)]
src: pass Isolate to all applicable api
Update the api to pass node_isolate to all supported methods.
Much thanks to Ben Noordhuis and his work in 51f6e6a.
Trevor Norris [Tue, 19 Mar 2013 10:28:17 +0000 (03:28 -0700)]
docs: show how to use Isolate
Part of the 3.17 update is to pass the isolate as an argument. The addon
docs have been updated with this usage.
Fedor Indutny [Sun, 20 Jan 2013 14:31:30 +0000 (18:31 +0400)]
dtrace: fix generation of v8 constants on freebsd
Every constant is certainly 4 bytes now, but freebsd's objdump utility
prints out odd byte sequences (5-bytes, 6-bytes and even 9-bytes long)
for v8's data section. We can safely ignore all upper bytes, because all
constants that we're using are just `int`s. Since on all supported
platforms `int` is 32bit long (and anyway v8's constants are 32bit too),
we ignore all higher bits if they were read.
isaacs [Mon, 7 Jan 2013 20:31:44 +0000 (12:31 -0800)]
dtrace: More style
Continuation lines should be indented with 4 spaces, not a tab.
isaacs [Mon, 7 Jan 2013 20:20:21 +0000 (12:20 -0800)]
dtrace: Make D style more D-ish
Fedor Indutny [Thu, 27 Dec 2012 03:16:23 +0000 (07:16 +0400)]
dtrace: x64 ustack helper
Fedor Indutny [Mon, 7 Jan 2013 18:53:50 +0000 (22:53 +0400)]
dtrace: fix style in ustack helper
Trevor Norris [Tue, 19 Mar 2013 09:06:13 +0000 (02:06 -0700)]
v8: revert dtrace fix from 3.14 downgrade
Revert "v8: fix postmortem and dtrace helper build"
This reverts commit
aa985392777dbe6159ce4ca56ae79d1039e43ec7.
Bryan Cantrill [Tue, 18 Sep 2012 22:35:29 +0000 (15:35 -0700)]
v8: loosen artificial mmap constraint
Fixes #4010.
Trevor Norris [Mon, 18 Mar 2013 20:54:00 +0000 (13:54 -0700)]
bindings: update api
All compile time warnings about using deprecated APIs have been
suppressed by updating node's API. Though there are still many function
calls that can accept Isolate, and still need to be updated.
node_isolate had to be added as an extern variable in node.h and
node_object_wrap.h
Also a couple small fixes for Error handling.
Before v8 3.16.6 the error stack message was lazily written when it was
needed, which allowed you to change the message after instantiation.
Then the stack would be written with the new message the first time it
was accessed. Though that has changed. Now it creates the stack message
on instantiation. So setting a different message afterwards won't be
displayed.
This is not a complete fix for the problem. Getting error without any
message isn't very useful.
Trevor Norris [Mon, 18 Mar 2013 20:50:55 +0000 (13:50 -0700)]
v8: remove optimization switches
Remove compiler switches from $(TOPLEVEL)/deps/v8/build/common.gypi,
they are set globally in $(TOPLEVEL)/common.gypi.
Trevor Norris [Mon, 18 Mar 2013 20:49:34 +0000 (13:49 -0700)]
deps: update v8 to 3.17.13
Iskren Ivov Chernev [Tue, 19 Mar 2013 17:58:18 +0000 (10:58 -0700)]
doc: fix streams2 SimpleProtocol example
A non-existing variable `b` was used to queue data for reading.
Bert Belder [Tue, 19 Mar 2013 23:16:02 +0000 (00:16 +0100)]
windows: enable watching signals with process.on('SIGXYZ')
This reverts commit
ea1cba6246a8b1784e22d076139b9244a9ff42f8.
The offending commit was intended to land on the v0.8 branch only, but
it accidentally got merged at some point.
Closes #5054.
Bert Belder [Tue, 19 Mar 2013 19:07:38 +0000 (20:07 +0100)]
Update .mailmap and AUTHORS
Scott Blomquist [Mon, 18 Mar 2013 17:48:13 +0000 (10:48 -0700)]
test: Misc Windows unit test fixes
Fixes #5071, #5073.
* Normalize capitalization of drive letter
* Fix `exit()` typo in failure path
* Ignore symlink tests (Windows) if not elevated
The `test_relative_input_cwd()` test was failing on Windows when
`skipSymlinks` was `true`. So we won't run it if `skipSymlinks` is
`true`.
When it failed, the unhandled error caused Node to die before
having a chance to clean up, which resulted in two files missing
in subsequent unit tests:
* `test/fixtures/nested-index/one/hello.js`
* `test/fixtures/nested-index/one/index.js`
We should probably find a way to isolate this test from the other
test (`simple/test-module-loading`) that was failing when this test
poluted the disk state.
Ben Noordhuis [Mon, 18 Mar 2013 13:40:03 +0000 (14:40 +0100)]
doc: fix broken links in blog footer
The blog lives at blog.nodejs.org while the main website lives at
nodejs.org. Ergo, use absolute URLs for links to the main website.
Fixes #5062.
Fedor Indutny [Fri, 15 Mar 2013 18:49:31 +0000 (22:49 +0400)]
tls: write pending data of opposite side
Fix stucked CryptoStream behaviour, happening when one of the sides
locks-up in queued state.
fix #5023
Fedor Indutny [Fri, 15 Mar 2013 18:49:31 +0000 (22:49 +0400)]
tls: write pending data of opposite side
Fix stucked CryptoStream behaviour, happening when one of the sides
locks-up in queued state.
fix #5023
Trevor Norris [Sun, 17 Mar 2013 04:59:47 +0000 (21:59 -0700)]
node: revert removal of MakeCallback
In 0168109 an implementation of MakeCallback was accidently removed. It
has been re-added.
JeongHoon Byun [Tue, 12 Mar 2013 12:21:43 +0000 (21:21 +0900)]
doc: fix typo in crypto docs
Yi EungJun [Fri, 15 Mar 2013 16:31:48 +0000 (01:31 +0900)]
doc: https: Fix the link to tls.connect
Ben Noordhuis [Sat, 16 Mar 2013 22:32:42 +0000 (23:32 +0100)]
deps: upgrade libuv to b45a74f
Ben Noordhuis [Sat, 16 Mar 2013 22:18:50 +0000 (23:18 +0100)]
install: don't install man page twice
Looks like a merge conflict in 77ed12f left in the old, unconditional
install rule. Remove it, the new and improved rule is a few lines down.
Fixes #5044.
Nao Iizuka [Sat, 16 Mar 2013 02:18:30 +0000 (16:18 -1000)]
readline: handle wide characters properly
Handle wide characters (such as あ, 谢, 고) as two column wide to make
cursor move properly.
Closes #555.
Closes #4994.
Timothy J Fontaine [Thu, 14 Mar 2013 23:06:59 +0000 (16:06 -0700)]
v8: move 32 bit heap hint on sunos
Setting the V8 heap at or near 0x20000000 on 32bit sunos only allows
512 MB of heap space, instead on sunos move this to 0x80000000.
Fixes #4010.
isaacs [Thu, 14 Mar 2013 23:43:19 +0000 (16:43 -0700)]
stream: Return self from readable.wrap
Also, set paused=false *before* calling resume(). Otherwise,
there's an edge case where an immediately-emitted chunk might make
it call pause() again incorrectly.
isaacs [Thu, 14 Mar 2013 23:18:42 +0000 (16:18 -0700)]
test: No need for kicking in streams2 test
This was necessary when we weren't auto-starting when a 'readable'
listener is added.
Gil Pedersen [Thu, 14 Mar 2013 13:01:14 +0000 (14:01 +0100)]
stream: Never call decoder.end() multiple times
Updated version that does what it says without assigning state.decoder.
isaacs [Thu, 14 Mar 2013 21:16:13 +0000 (14:16 -0700)]
repl: Use a domain to catch async errors safely
Fix #2031
Sami Samhuri [Thu, 14 Mar 2013 20:49:14 +0000 (10:49 -1000)]
repl: emit 'reset' event when context is reset
Closes #1183.
koichik [Thu, 14 Mar 2013 14:57:13 +0000 (23:57 +0900)]
doc: don't mark fs callbacks as optional
Refs #5005, #5008
isaacs [Thu, 14 Mar 2013 14:48:18 +0000 (07:48 -0700)]
http: Don't hot-path end() for large buffers
The benefits of the hot-path optimization below start to fall off when
the buffer size gets up near 128KB, because the cost of the copy is more
than the cost of the extra write() call. Switch to the write/end method
at that point.
Heuristics and magic numbers are awful, but slow http responses are
worse.
Fix #4975
Ben Noordhuis [Thu, 14 Mar 2013 14:13:58 +0000 (15:13 +0100)]
net: improve arbitrary tcp socket support
Consider this example:
// fd 3 is a bound tcp socket
var s = net.createServer(cb);
s.listen({ fd: 3 });
console.log(s.address()); // prints null
This commit makes net.Server#address() print the actual address.
Ditto for non-listen sockets; properties like net.Socket#localAddress
and net.Socket#remoteAddress now return the correct value.
Fixes #5009.
Ben Noordhuis [Thu, 14 Mar 2013 12:40:27 +0000 (13:40 +0100)]
deps: upgrade libuv to 7b66ea1
Adam Malcontenti-Wilson [Thu, 14 Mar 2013 02:17:07 +0000 (13:17 +1100)]
doc: change dgram to socket for properties of dgram.Socket
Fixes #4919.
isaacs [Wed, 13 Mar 2013 22:36:52 +0000 (15:36 -0700)]
Revert "fs: Missing cb errors are deprecated, not a throw"
This reverts commits
6bd8b7e5405e1cdc9f56214f5f6b741806c32e5f
and
fa05e8a2706e20a191942fe2b2273481605a1f14.
isaacs [Wed, 13 Mar 2013 22:51:24 +0000 (15:51 -0700)]
Merge remote-tracking branch 'ry/v0.10'
Conflicts:
src/node_version.h
isaacs [Wed, 13 Mar 2013 22:48:56 +0000 (15:48 -0700)]
Revert "stream: Never call decoder.end() multiple times"
This reverts commit
615d809ac684a7d2cc7ee5e1aa58f0a921b529a0.
isaacs [Wed, 13 Mar 2013 21:59:42 +0000 (14:59 -0700)]
fs: Missing cb errors are deprecated, not a throw
Commit a804347 makes fs function rethrow errors when the callback is
omitted. While the right thing to do, it's a change from the old v0.8
behavior where such errors were silently ignored.
To give users time to upgrade, temporarily disable that and replace it
with a function that warns once about the deprecated behavior.
Close #5005
Ben Noordhuis [Wed, 13 Mar 2013 21:52:33 +0000 (22:52 +0100)]
doc: implicit fs callbacks don't throw in v0.10
But they will in v0.12.
Re #5005.
Ben Noordhuis [Wed, 13 Mar 2013 22:22:55 +0000 (23:22 +0100)]
doc: add note on process.title max length
Fixes #5006.
Gil Pedersen [Tue, 12 Mar 2013 14:56:30 +0000 (15:56 +0100)]
stream: Never call decoder.end() multiple times
Fixes decoder.end() being called on every push(null). As the tls module
does this, corrupt stream data could potentially be added to the end.
isaacs [Wed, 13 Mar 2013 18:22:33 +0000 (11:22 -0700)]
core: Move UNWRAP_NO_ABORT to handle_wrap.h
Otherwise it cannot be used in StreamWrap.
Forgot to include in last patch, broke the build.
Ben Noordhuis [Wed, 13 Mar 2013 17:27:09 +0000 (18:27 +0100)]
doc: path.join() arguments must be strings
In v0.8, non-string arguments were ignored. v0.10 throws an exception.
Fedor Indutny [Wed, 13 Mar 2013 12:53:27 +0000 (16:53 +0400)]
net: handle 'finish' event only after 'connect'
isaacs [Wed, 13 Mar 2013 17:16:26 +0000 (10:16 -0700)]
core: Unwrap without aborting in handle fd getter
isaacs [Wed, 13 Mar 2013 17:15:30 +0000 (10:15 -0700)]
blog: Fix typo in typo fix
Fedor Indutny [Wed, 13 Mar 2013 12:53:27 +0000 (16:53 +0400)]
net: handle 'finish' event only after 'connect'
Nathan Rajlich [Wed, 13 Mar 2013 02:00:48 +0000 (19:00 -0700)]
blog: fix small typo in v0.10.0 release article
Nathan Rajlich [Tue, 12 Mar 2013 22:58:27 +0000 (15:58 -0700)]
doc: fix inpect() -> inspect() typo
Fedor Indutny [Tue, 12 Mar 2013 19:15:21 +0000 (23:15 +0400)]
crypto: replace BIO_free with BIO_free_all
From OpenSSL's documentation:
"If BIO_free() is called on a BIO chain it will only free one BIO
resulting in a memory leak."
and
"BIO_free_all() frees up an entire BIO chain, it does not halt if an
error occurs freeing up an individual BIO in the chain"
Fedor Indutny [Tue, 12 Mar 2013 10:18:24 +0000 (14:18 +0400)]
crypto: refactor crypto classes
Fedor Indutny [Tue, 12 Mar 2013 10:09:27 +0000 (14:09 +0400)]
crypto: merge Cipher and Decipher
Fedor Indutny [Mon, 11 Mar 2013 21:59:46 +0000 (01:59 +0400)]
crypto: split crypto classes
Nathan Rajlich [Wed, 30 Jan 2013 03:06:32 +0000 (19:06 -0800)]
util: custom `inspect()` method may return an Object
This is more like how `JSON.stringify()` works.
Closes #2711.