platform/upstream/dotnet/runtime.git
17 months agoChange IsolatedStorageFile path for mobile (#83380)
Meri Khamoyan [Thu, 11 May 2023 09:33:40 +0000 (13:33 +0400)]
Change IsolatedStorageFile path for mobile (#83380)

 Updated isolated storage root path for mobile platforms
---------
Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
17 months agoAdd integration tests for PreserveSig and use the MemberFunction calling convention...
Jeremy Koritzinsky [Thu, 11 May 2023 08:09:14 +0000 (01:09 -0700)]
Add integration tests for PreserveSig and use the MemberFunction calling convention by default in the ComInterfaceGenerator (#86072)

17 months ago[wasm] Docs on overriding runtime pack in blazor wasm (#85455)
Marek Fišera [Thu, 11 May 2023 07:55:10 +0000 (09:55 +0200)]
[wasm] Docs on overriding runtime pack in blazor wasm (#85455)

17 months ago[mono][llvm] Fix the emission of nonnull metadata on loads. (#86071)
Zoltan Varga [Thu, 11 May 2023 06:32:08 +0000 (23:32 -0700)]
[mono][llvm] Fix the emission of nonnull metadata on loads. (#86071)

Fixes llvm verification errors in newer llvm versions:
```
nonnull metadata must be empty
   %49 = load ptr, ptr @aotconst_ldstr_21, align 8, !nonnull !1
```

17 months ago[mono] Move most runtime callbacks into the MonoRuntimeCallbacks structure. (#86080)
Zoltan Varga [Thu, 11 May 2023 06:31:51 +0000 (23:31 -0700)]
[mono] Move most runtime callbacks into the MonoRuntimeCallbacks structure. (#86080)

17 months ago[mono][wasm] Allow linking out some runtime code on wasm. (#86079)
Zoltan Varga [Thu, 11 May 2023 06:14:03 +0000 (23:14 -0700)]
[mono][wasm] Allow linking out some runtime code on wasm. (#86079)

17 months agoFix official build after removing win-arm runtime build (#86074)
Bruce Forstall [Thu, 11 May 2023 04:41:38 +0000 (21:41 -0700)]
Fix official build after removing win-arm runtime build (#86074)

win-arm CI builds were removed with https://github.com/dotnet/runtime/pull/85947

17 months ago[JIT] X64 - Centralize peephole optimization for removing redundant `mov` instruction...
Will Smith [Thu, 11 May 2023 04:39:02 +0000 (21:39 -0700)]
[JIT] X64 - Centralize peephole optimization for removing redundant `mov` instructions (#85780)

17 months agoDelete Windows arm32 support (#86065)
Jan Kotas [Thu, 11 May 2023 03:02:38 +0000 (20:02 -0700)]
Delete Windows arm32 support (#86065)

17 months ago[mono][aot] Fix an assert. (#86054)
Zoltan Varga [Wed, 10 May 2023 22:36:48 +0000 (15:36 -0700)]
[mono][aot] Fix an assert. (#86054)

Fixes https://github.com/dotnet/runtime/issues/86052.

17 months agoUpdate dependencies from https://github.com/dotnet/roslyn-analyzers build 20230508...
dotnet-maestro[bot] [Wed, 10 May 2023 21:51:35 +0000 (16:51 -0500)]
Update dependencies from https://github.com/dotnet/roslyn-analyzers build 20230508.1 (#85972)

Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
 From Version 3.3.5-beta1.23256.1 -> To Version 3.3.5-beta1.23258.1

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
17 months agoAdd linux-x64 hosted tpdiff to superpmi-diffs pipeline (#86021)
Bruce Forstall [Wed, 10 May 2023 21:42:26 +0000 (14:42 -0700)]
Add linux-x64 hosted tpdiff to superpmi-diffs pipeline (#86021)

* Add linux-x64 hosted tpdiff to superpmi-diffs pipeline

With this, we get instruction count diffs based on clang compiled
native JITs.

* Fix some variables

Also, fix some Python 'lint' issues.

* Fix more path issues, Windows targeting global var

* Feedback

1. Make `determine_jit_name` a utility library function.
All 3 versions were different, so required some adjustments.
jitrollingbuild.py had not previously used `jitutil` so added use
and removed additional duplicated code.
2. Renamed partitions to not use `unix` name. This is purely an internal
name, not exposed.
3. Simplified some FileSeparatorChar usage.
4. Fixed more pylint complaints

17 months ago[PERF] Add arm64 dynamic pgo runs (#86014)
Parker Bibus [Wed, 10 May 2023 21:18:05 +0000 (14:18 -0700)]
[PERF] Add arm64 dynamic pgo runs (#86014)

* Add DynamicPGO arm64 linux and windows runs.
* Added parity to performance-setup.sh for pgo (no, dynamic, full) runs.
* Pass the pgoRunType through to the performance (Unix) setup script as well in performance-job.yml.
* Add Linux x64 dynamic pgo.

17 months agoILLink should keep parameter names for methods which are used to create a delagate...
Vitek Karas [Wed, 10 May 2023 21:01:12 +0000 (14:01 -0700)]
ILLink should keep parameter names for methods which are used to create a delagate (#85831)

This is a fix for https://github.com/dotnet/linker/issues/3061.

If the app creates a delegate over a method and later on access the `Delegate.Method` property it can get a `MethodInfo` which it can use to inspect some aspects of the method, specifically parameter names.

NativeAOT already handles this correctly, but ILLink doesn't and will trim the parameter names away. The correct behavior is to treat such method as reflection accessible (we really don't want to mark the `Delegate.Method` property as trim incompatible).

The ideal way to implement this is to perform full data flow on method addresses, which would allow us to detect which method is the delegate created for. (this is what NativeAOT ends up doing through JIT)

But that is rather complex, an easier solution is to treat any method which address is accessed as reflection enabled. This covers all delegates. It might mark more methods as reflection enabled, but it's very uncommon.

So this change does that, it will mark all methods accessed via `ldftn` (or similar) as reflection enabled.
Additionally this cleans up marking of reflection enabled members in the MarkStep. Specifically there was a distinction between reflection accessed and indirect accessed methods, but the latter only kicked in for the obsolete preserve attributes. It's better to reflection mark those as well. This might cause a small size regression, but it's very unlikely to be even observable.

This requires lot more test changes to enable sane testing:
* In the ILC test infra, track if method was kept with or without reflection metadata (as that is the difference in NativeAOT which will provide parameter names or not)
* Teach both the ILLink and ILC test infras how to handle compiler generated code with the `Kept` attribute validation
  * This is in no way complete, but it's an improvement
  * Mostly it means that we don't fail the test if a compiler generated code is kept without it being marked with the `Kept` attribute (as that's not always possible)
  * Note that we have some support for this for things like backing fields and private implementation details, but nothing which can handle state machines, and closure types for lambdas. These should now be workable, without the ability to verify that they were indeed kept (and how)
  * Finally adds tests verifying the new functionality.

17 months agoAdd ArgumentException.ThrowIfNullOrWhiteSpace (#86007)
Stephen Toub [Wed, 10 May 2023 20:49:47 +0000 (16:49 -0400)]
Add ArgumentException.ThrowIfNullOrWhiteSpace (#86007)

* Add ArgumentException.ThrowIfNullOrWhiteSpace

* Fix tests

17 months agoCapture remaining binding Bind & Get methods for source generator support (#85843)
Layomi Akinrinade [Wed, 10 May 2023 20:19:12 +0000 (13:19 -0700)]
Capture remaining binding Bind & Get methods for source generator support (#85843)

* Capture remaining binding methods for source generator support

* Capture remaining binding methods for source generator support

* Implement method emission

* Restore binder implemenation

* Complete currently unsupported test annotation

* Clean up method gen implementation

* Refactor for ideal emitted code (for baseline tests)

* Clean up

17 months agoUpdate linux build instructions (#86062)
Sven Boemer [Wed, 10 May 2023 19:54:40 +0000 (12:54 -0700)]
Update linux build instructions (#86062)

To reflect recent series of changes to our official build. This
updates the mentioned images to use floating tags, and clarifies
that the new official build containers all are designed for
cross-building.

17 months agoRevert "let user know working directory will be used as content root path by default...
Steve Harter [Wed, 10 May 2023 19:15:12 +0000 (14:15 -0500)]
Revert "let user know working directory will be used as content root path by default (#82445)" (#86057)

This reverts commit c958573654937f9582b6a23522b2ad16cd7dbf96.

17 months agoUpdate dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimizati...
dotnet-maestro[bot] [Wed, 10 May 2023 19:06:18 +0000 (14:06 -0500)]
Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build 20230508.3 (#85968)

optimization.linux-arm64.MIBC.Runtime , optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-arm64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime , optimization.PGO.CoreCLR
 From Version 1.0.0-prerelease.23256.3 -> To Version 1.0.0-prerelease.23258.3

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
17 months agoUpdate dependencies from https://github.com/dotnet/roslyn build 20230509.11 (#86036)
dotnet-maestro[bot] [Wed, 10 May 2023 19:05:24 +0000 (14:05 -0500)]
Update dependencies from https://github.com/dotnet/roslyn build 20230509.11 (#86036)

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.7.0-1.23254.5 -> To Version 4.7.0-1.23259.11

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
17 months agoUpdate dependencies from https://github.com/dotnet/arcade build 20230509.5 (#86034)
dotnet-maestro[bot] [Wed, 10 May 2023 19:04:50 +0000 (14:04 -0500)]
Update dependencies from https://github.com/dotnet/arcade build 20230509.5 (#86034)

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
 From Version 8.0.0-beta.23255.2 -> To Version 8.0.0-beta.23259.5

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
17 months agoFix null handling of built-in converters. (#86056)
Eirik Tsarpalis [Wed, 10 May 2023 18:18:38 +0000 (21:18 +0300)]
Fix null handling of built-in converters. (#86056)

17 months agoAdd PreserveSig support to ComInterfaceGenerator (#85941)
Jeremy Koritzinsky [Wed, 10 May 2023 18:09:44 +0000 (11:09 -0700)]
Add PreserveSig support to ComInterfaceGenerator (#85941)

17 months agoUpdate mariner images to latest with LLVM 16 (#84676)
Sven Boemer [Wed, 10 May 2023 17:09:52 +0000 (10:09 -0700)]
Update mariner images to latest with LLVM 16 (#84676)

This pulls in the updates from
https://github.com/dotnet/dotnet-buildtools-prereqs-docker/commit/53fee55b4115616c7029782c9733055db1bc565a
and moves to floating tags for the mariner images, which now
build the product with LLVM 16.

Once this flows to dotnet-optimization, this will require updates
to make the LLVM 16 tools available there. Before the opt data
collected with new LLVM flows into runtime, I plan to fix
https://github.com/dotnet/runtime/issues/85785 so that local
builds won't by default require clang-16.

17 months agoRemove Windows arm32 support (#85947)
Bruce Forstall [Wed, 10 May 2023 16:59:15 +0000 (09:59 -0700)]
Remove Windows arm32 support (#85947)

* Remove Windows arm32 support

Mostly, remove the CI runs. Windows arm32 product support was removed
before .NET 6.

* Restore a few files

Only change YML files to remove windows_arm runs.

Don't build Windows arm cross components.

Don't touch mono files.

Changing scripts to remove builds, and remove code, can follow.

17 months agoDisable autovectorization on wasm (#86038)
Katelyn Gadd [Wed, 10 May 2023 16:28:21 +0000 (09:28 -0700)]
Disable autovectorization on wasm (#86038)

7c75cbf added the -msimd128 flag to cmakelists so that the interpreter could use wasm vector intrinsics. That option appears to imply enabling all sorts of auto-vectorization, which may be responsible for the regressions in dotnet/perf-autofiling-issues#17570

17 months agoExpose various integer intrinsics for Avx512F, Avx512BW, and Avx512CD (#85833)
Tanner Gooding [Wed, 10 May 2023 16:04:09 +0000 (09:04 -0700)]
Expose various integer intrinsics for Avx512F, Avx512BW, and Avx512CD (#85833)

* Expose AlignRight32 and AlignRight64 on Avx512F

* Expose RotateLeft and RotateRight for Avx512F

* Expose SumAbsoluteDifferencesInBlock32 for Avx512BW + DetectConflicts and LeadingZeroCOunt for Avx512DQ

* Exponse TernaryLogic for Avx512F

* Apply formatting patch

* Ensure side effects are preserved when optimizing certain intrinsic imports

* Ensure the instruction code has the SIMD prefix before trying to encode the register

* Ensure side effects have been accounted for before swapping operands

* Move the complex ternary logic simplification logic to import, since the JIT will never produce such nodes itself

* Ensure gtNewSimdUnOpNode(GT_NOT) uses an in range constant for TernaryLogic

* Remove a new assert added to AND_NOT, logging an issue instead

* Add a missing `break;` statement

* Ensure val1/2/3 are GenTree** so swapping works and add a comment explaining the TernaryLogic table

* Fix formatting of a comment

* Don't double encode the 'vvvv' bits for `emitOutputAM`

* Avoid an assert in gtNewSimdCreateBroadcastNode for TYP_LONG on 32-bit

* Ensure we use CHECK_SPILL_ALL

* Ensure mustExpand is handled for `RotateLeft(Vector###<long>)` on 32-bit

* Make sure all tests are actually running and handle the "maybe no jmp table fallback"

* Handle a couple test issues  and ensure we set the constant when normalizing ~B | C

* Ensure ValidateRemaining uses firstOp[i]

17 months agoAdd instructions for running the runtime tests on iOS platforms (#86045)
Milos Kotlar [Wed, 10 May 2023 15:21:43 +0000 (17:21 +0200)]
Add instructions for running the runtime tests on iOS platforms (#86045)

17 months agoFix BigInteger parse hex strings on negative numbers (#84792)
Alexander Speshilov [Wed, 10 May 2023 14:36:50 +0000 (17:36 +0300)]
Fix BigInteger parse hex strings on negative numbers (#84792)

fixes dotnet#74758

17 months agofix JsonNode deserialising from null (#85463)
adj123 [Wed, 10 May 2023 14:00:36 +0000 (15:00 +0100)]
fix JsonNode deserialising from null (#85463)

* fix JsonNode deserialising from null

* add further tests for more null-deserialising scenarios

---------

Co-authored-by: Adam Jones <ajones@drwuk.com>
17 months agoFix mismatched types in native host test error messaging (#85995)
Elinor Fung [Wed, 10 May 2023 13:15:05 +0000 (15:15 +0200)]
Fix mismatched types in native host test error messaging (#85995)

17 months agoFix NativeLibraryTests for ilasm round-trip (#85991)
Elinor Fung [Wed, 10 May 2023 13:05:29 +0000 (15:05 +0200)]
Fix NativeLibraryTests for ilasm round-trip (#85991)

17 months agoJIT: Seed stress modes by string hash (#83771)
Jakob Botsch Nielsen [Wed, 10 May 2023 11:15:15 +0000 (13:15 +0200)]
JIT: Seed stress modes by string hash (#83771)

Instead of using the numeric value of each stress mode inside the enum,
calculate a hash based on the string name. This has the benefit that it
won't change based on new members being added/reordered and reduces
correlation of which stress modes get enabled together.

Fix #83733

17 months agoJIT: Peel offsets from spilled addresses for store decomposition (#85889)
Jakob Botsch Nielsen [Wed, 10 May 2023 10:59:54 +0000 (12:59 +0200)]
JIT: Peel offsets from spilled addresses for store decomposition (#85889)

For a block operation like

```
▌  ASG       struct (copy)
├──▌  BLK       struct<System.Nullable`1, 8>
│  └──▌  ADD       byref
│     ├──▌  LCL_VAR   ref    V00 this
│     └──▌  CNS_INT   long   40 Fseq[<unknown field>]
└──▌  LCL_VAR   struct<System.Nullable`1, 8>(P) V06 tmp2
└──▌    bool   V06.<unknown class>:hasValue (offs=0x00) -> V12 tmp8          (last use)
└──▌    int    V06.<unknown class>:value (offs=0x04) -> V13 tmp9          (last use)
```

We would previously spill the ADD(V00, 40) to a local and end up
producing:

```
▌  COMMA     void
├──▌  COMMA     void
│  ├──▌  ASG       byref
│  │  ├──▌  LCL_VAR   byref  V15 tmp11
│  │  └──▌  ADD       byref
│  │     ├──▌  LCL_VAR   ref    V00 this
│  │     └──▌  CNS_INT   long   40 Fseq[<unknown field>]
│  └──▌  ASG       bool
│     ├──▌  IND       bool
│     │  └──▌  LCL_VAR   byref  V15 tmp11
│     └──▌  LCL_VAR   bool   V12 tmp8
└──▌  ASG       int
   ├──▌  IND       int
   │  └──▌  ADD       byref
   │     ├──▌  LCL_VAR   byref  V15 tmp11
   │     └──▌  CNS_INT   long   4
   └──▌  LCL_VAR   int    V13 tmp9
```

Instead of this we can include the offsets with the field offsets. In
many cases that allows us to avoid any temporary locals, while in other
cases it usually allows us to avoid an instruction in favor of two
larger containments. In this case we instead end up with:

```
▌  COMMA     void
├──▌  ASG       bool
│  ├──▌  IND       bool
│  │  └──▌  ADD       byref
│  │     ├──▌  LCL_VAR   ref    V00 this
│  │     └──▌  CNS_INT   long   40 Fseq[<unknown field>]
│  └──▌  LCL_VAR   bool   V12 tmp8
└──▌  ASG       int
   ├──▌  IND       int
   │  └──▌  ADD       byref
   │     ├──▌  LCL_VAR   ref    V00 this
   │     └──▌  CNS_INT   long   44 Fseq[<unknown field>, 4]
   └──▌  LCL_VAR   int    V13 tmp9
```

17 months agoDisable HugeArray1 for crossgen2 x86 (#86020)
Bruce Forstall [Wed, 10 May 2023 06:05:58 +0000 (23:05 -0700)]
Disable HugeArray1 for crossgen2 x86 (#86020)

Tracking: https://github.com/dotnet/runtime/issues/85747

17 months agoMisc LSRA throughput improvements (#85842)
Kunal Pathak [Wed, 10 May 2023 05:00:45 +0000 (22:00 -0700)]
Misc LSRA throughput improvements (#85842)

* Use BitOperations in few hot methods

* Do not pass RegisterType for non-arm sarchitectures

* Add clearAssignedInterval()

* Consume clearAssignedInterval()

* Do not pass RegisterType for updateInterval()

* Revert the change in genFindLowestBit()

* Revert "Use BitOperations in few hot methods"

This reverts commit a75a7da436fe616d8226d8f2a4c5d50c0f447827.

* Add the missing case for clearAssignedInterval()

* Remove logging

* jit formatting

* Use popcount intrinsics

* Revert "Use popcount intrinsics"

This reverts commit 0b3da210a8b754521de29d40e01072fb1b01adc7.

* revert unintentional change from superpmi.py

* Revert "Do not pass RegisterType for non-arm sarchitectures"

This reverts commit 46d4d3d88704beca5f0817db3a6e48fc1a14dac6.

* fix the merge conflicts

17 months agoAllow set GC configuration in NativeAOT (#85921)
Andrii Kurdiumov [Wed, 10 May 2023 04:58:03 +0000 (10:58 +0600)]
Allow set GC configuration in NativeAOT (#85921)

Currently NativeAOT uses `uint32_t` for storing configuration values.
There assumption that configuration would take 8 characters in configuration.
If we set value which has 9 characters it would be silently ignored.
For example: `$env:DOTNET_GCHeapHardLimit="100000000"` which is 4Gb.
On CoreCLR GC uses `uint64_t` so it does not make sense to limit NativeAOT cofiguration
to 32-bit values here

17 months agoDelete rarely used bashing methods and add some documentation on bashing (#85925)
SingleAccretion [Wed, 10 May 2023 04:57:43 +0000 (07:57 +0300)]
Delete rarely used bashing methods and add some documentation on bashing (#85925)

17 months agoAdd aka.ms link for NativeAOT prerequisites to linker not found error messages (...
Michal Strehovský [Wed, 10 May 2023 04:02:21 +0000 (13:02 +0900)]
Add aka.ms link for NativeAOT prerequisites to linker not found error messages (#86024)

17 months ago[mono] Avoid an assert if the class name table is too large. (#85952)
Zoltan Varga [Wed, 10 May 2023 03:21:17 +0000 (20:21 -0700)]
[mono] Avoid an assert if the class name table is too large. (#85952)

Fixes https://github.com/dotnet/runtime/issues/85917.

17 months ago[mono][llvm] Fix an assert. (#85950)
Zoltan Varga [Wed, 10 May 2023 03:16:18 +0000 (20:16 -0700)]
[mono][llvm] Fix an assert. (#85950)

Fixes https://github.com/dotnet/runtime/issues/85724.

17 months agoDedup PemEncoding.TryCountBase64 with Base64.IsValid (#86002)
Stephen Toub [Wed, 10 May 2023 02:00:02 +0000 (22:00 -0400)]
Dedup PemEncoding.TryCountBase64 with Base64.IsValid (#86002)

* Dedup PemEncoding.TryCountBase64 with Base64.IsValid

* Address PR feedback

17 months agoJIT/EE interface cleanup (#85975)
Jan Kotas [Wed, 10 May 2023 01:46:58 +0000 (18:46 -0700)]
JIT/EE interface cleanup (#85975)

* JIT/EE interface cleanup
- Delete methods, fields and flags related to verification that is no longer supported
- Delete flags for old x86 models that are no longer needed given SSE2
  is our baseline

* Assert hardware minbar

17 months agoMake exception count performance counter thread-safe (#86018)
Jan Kotas [Wed, 10 May 2023 01:46:04 +0000 (18:46 -0700)]
Make exception count performance counter thread-safe (#86018)

Fixes #85997

17 months agoCreate a createdump static library for single-file dump generation (#84864)
Mike McLaughlin [Wed, 10 May 2023 00:32:34 +0000 (17:32 -0700)]
Create a createdump static library for single-file dump generation (#84864)

* Create a createdump static library for single-file and native AOT dump generation

A "createdump_static" lib is now built that is linked into the single-file host and
in the future can be linked into a Native AOT host/app going forward. For single-file
apps most of the same unhandled exception or crash dump generation code is the same
(same env vars, most of all the PAL code is the same) except where createdump executable
was execve, a callback invokes (set by the host) the static createdump lib entry point.

File full dumps are generated (which currently are very large under MacOS) but the user
can put the DAC side-by-side with their app and the smaller heap or mini dumps can be
generated. The SDK could give an option to publish the DAC SXS for a single-file app.

17 months agoJIT: enable profile repairs of OSR entry block weight is zero (#86011)
Andy Ayers [Tue, 9 May 2023 23:02:55 +0000 (16:02 -0700)]
JIT: enable profile repairs of OSR entry block weight is zero (#86011)

If the PGO solver finds the OSR entry block weight is zero, schedule the
method for profile repairs (similar to what we do for normal methods when
the method entry block weight is zero, see #84312).

Fixes #85838.

17 months agoUse string.IsNullOrEmpty and ArgumentException.ThrowIfNullOrEmpty in many more places...
Stephen Toub [Tue, 9 May 2023 22:15:38 +0000 (18:15 -0400)]
Use string.IsNullOrEmpty and ArgumentException.ThrowIfNullOrEmpty in many more places (#85858)

17 months agoJIT: Update class for Unsafe.As<>() (#85954)
Egor Bogatov [Tue, 9 May 2023 21:42:29 +0000 (23:42 +0200)]
JIT: Update class for Unsafe.As<>() (#85954)

17 months ago[mono][aot] Generate 'native-indirect' wrappers in full-aot mode. (#85923)
Zoltan Varga [Tue, 9 May 2023 21:30:30 +0000 (14:30 -0700)]
[mono][aot] Generate 'native-indirect' wrappers in full-aot mode. (#85923)

Fixes https://github.com/dotnet/runtime/issues/80853.

17 months agoUpdate life of data node for simd12 (#85956)
Kunal Pathak [Tue, 9 May 2023 21:23:29 +0000 (14:23 -0700)]
Update life of data node for simd12 (#85956)

* Update life of Data() node

* Review feedback

17 months agoSPMI: Use .tar.gz for pintools on Linux (#85999)
Jakob Botsch Nielsen [Tue, 9 May 2023 21:07:23 +0000 (23:07 +0200)]
SPMI: Use .tar.gz for pintools on Linux (#85999)

We need to preserve executable permissions on these files so use .tar.gz
instead of .zip.

17 months ago[wasm] Use a fixed chrome version for testing (#86012)
Ankit Jain [Tue, 9 May 2023 20:53:07 +0000 (16:53 -0400)]
[wasm] Use a fixed chrome version for testing (#86012)

`113.0.5672.63`

17 months agoUpgrade System.Reflection.Metadata version (#85738)
Andrew Au [Tue, 9 May 2023 19:33:59 +0000 (12:33 -0700)]
Upgrade System.Reflection.Metadata version (#85738)

* Upgrade System.Reflection.Metadata version

* Upgrade System.Collections.Immutable version

17 months agoSpeed up typeof (#85962)
Michal Strehovský [Tue, 9 May 2023 19:25:08 +0000 (04:25 +0900)]
Speed up typeof (#85962)

Saw it in BasicMinimalApi profiles. The ultimate fix is to make `RuntimeType` a frozen object, but this will do for now.

Also made a bit of progress in eradicating `EETypePtr` while I'm touching this.

17 months agoRevert "performance-setup.sh requires urllib3 version <2 (#85915)" (#86009)
Parker Bibus [Tue, 9 May 2023 19:00:05 +0000 (12:00 -0700)]
Revert "performance-setup.sh requires urllib3 version <2 (#85915)" (#86009)

This reverts commit b1329633572d124fe43f7d58bb113f59f886e80b.

17 months agoSPMI: Export dynamic symbols in superpmi for unix builds (#85967)
Jakob Botsch Nielsen [Tue, 9 May 2023 18:35:22 +0000 (20:35 +0200)]
SPMI: Export dynamic symbols in superpmi for unix builds (#85967)

This is necessary for Instrumentor_GetInsCount to get a public symbol
that pin can find.

17 months agoJIT: fix bug in jump threading (#85942)
Andy Ayers [Tue, 9 May 2023 18:20:32 +0000 (11:20 -0700)]
JIT: fix bug in jump threading (#85942)

Verify that the purported dominator of a block to be jump threaded dominates
all of the block's predecessors.

This will initially be true (modulo some odd cases with finally continuations),
but if we've jump threaded through the dominator it may not remain true as
we do not update dominators when optimizing.

Fixes #85892.

17 months agoMove assignment rationalization to before global morph (#85872)
SingleAccretion [Tue, 9 May 2023 17:54:44 +0000 (20:54 +0300)]
Move assignment rationalization to before global morph (#85872)

* Fix printing of volatile/unaligned

* Fix missing GTF_ASG

* QMARK expansion

* Global morph

* Tentatively fix stress

* Another stress fix

The assert is too strict, a better version in coming in the future changes.

17 months agoRevert "Previous changes fixed some runs, but some are still broken due to reinstall...
Parker Bibus [Tue, 9 May 2023 17:43:37 +0000 (10:43 -0700)]
Revert "Previous changes fixed some runs, but some are still broken due to reinstall installing a broken urllib version. (#85935)" (#86000)

This reverts commit 4ea93a6be4ea1b084158cf2aed7cac2414f10a2d due to the commit seemingly causes major failure in the pipelines.

17 months agoUpdate equals (#85896)
hrrrrustic [Tue, 9 May 2023 17:00:08 +0000 (20:00 +0300)]
Update equals (#85896)

17 months agoExclude the test DevDiv_255294.cmd on Windows arm in issues.targets (#85928)
Tomáš Rylek [Tue, 9 May 2023 16:36:52 +0000 (18:36 +0200)]
Exclude the test DevDiv_255294.cmd on Windows arm in issues.targets (#85928)

* Exclude the test DevDiv_255294.cmd on Windows arm in issues.targets

This test failure is known and tracked under

https://github.com/dotnet/runtime/issues/85663

I'm adding the issues.targets entry to baseline the failure and
make outerloop green again.

Thanks

Tomas

* Address Bruce's PR feedback

17 months agoDisable IUnknownTest under GCStress (#85937)
Bruce Forstall [Tue, 9 May 2023 16:28:55 +0000 (09:28 -0700)]
Disable IUnknownTest under GCStress (#85937)

Tracking: https://github.com/dotnet/runtime/issues/85234

17 months agoUnroll StringBuilder.Append for const string (#85894)
Jesper Meyer [Tue, 9 May 2023 16:27:52 +0000 (18:27 +0200)]
Unroll StringBuilder.Append for const string (#85894)

Co-authored-by: EgorBo <egorbo@gmail.com>
17 months ago[PERF] Fix Linux Musl Alpine Core Root build (#85946)
Parker Bibus [Tue, 9 May 2023 16:24:58 +0000 (09:24 -0700)]
[PERF] Fix Linux Musl Alpine Core Root build (#85946)

* Add crossbuild for coreroot building in perf-job.yml

17 months agoStop special casing reflected-on internals (#85963)
Michal Strehovský [Tue, 9 May 2023 15:11:26 +0000 (00:11 +0900)]
Stop special casing reflected-on internals (#85963)

* Stop special casing reflected-on internals

Concept of reflection blocked internals was deleted in #85810. This is no longer needed.

* Can no longer access ResourceSet outside corelib

17 months agoImprove IndexOfAnyValues for needles with 0 (#84184)
Miha Zupan [Tue, 9 May 2023 14:59:14 +0000 (16:59 +0200)]
Improve IndexOfAnyValues for needles with 0 (#84184)

17 months agoFix ReadOnlySpanGetReferenceAndReadInteger on BigEndian (#85969)
Egor Bogatov [Tue, 9 May 2023 14:25:01 +0000 (16:25 +0200)]
Fix ReadOnlySpanGetReferenceAndReadInteger on BigEndian (#85969)

17 months agoDelete `gtNewBlkOpNode` and `lvSimdBaseJitType` (#85848)
SingleAccretion [Tue, 9 May 2023 14:24:40 +0000 (17:24 +0300)]
Delete `gtNewBlkOpNode` and `lvSimdBaseJitType` (#85848)

* Delete "gtNewBlkOpNode"

Note: neither "initobj" nor "cpobj" can be preceded by "volatile.".

Delete the self-assignment handling

Block morphing will fold it to a NOP anyway.

I do not see the referenced liveness bug still being present.
It seems to have been a remnant of COPYBLK/COPYOBJ days.

Move the SIMD logic to gtNewAssignNode

Delete "gtNewBlkOpNode"

* Delete lvSimdBaseJitType

17 months agoFold "FrozenObjectHandle(REF) + CNS" to a byref constant (#85888)
Egor Bogatov [Tue, 9 May 2023 14:07:22 +0000 (16:07 +0200)]
Fold "FrozenObjectHandle(REF) + CNS" to a byref constant (#85888)

17 months agoFix comment for File.Exists (#85648)
Siqi Lu [Tue, 9 May 2023 14:05:13 +0000 (14:05 +0000)]
Fix comment for File.Exists (#85648)

17 months agoamend the multiply's overflow check and delete some unused codes. (#85959)
Qiao Pengcheng [Tue, 9 May 2023 14:01:47 +0000 (22:01 +0800)]
amend the multiply's overflow check and delete some unused codes. (#85959)

17 months ago[RISC-V] Fixed errors in jit and unwinding (#85900)
Dong-Heon Jung [Tue, 9 May 2023 14:01:25 +0000 (23:01 +0900)]
[RISC-V] Fixed errors in jit and unwinding (#85900)

* [JIT] Fix some errors in JIT

* Fix errors in unwinding

* [JIT] Pass float value with int arg reg

* [JIT] Fix register overwriting in RSVD

* [JIT] jit-format

* Fix an error

* [JIT] Add LOONGARCH64

17 months agoAttempt to bypass emscripten's generated wrappers for cwraps (#85919)
Katelyn Gadd [Tue, 9 May 2023 13:22:51 +0000 (06:22 -0700)]
Attempt to bypass emscripten's generated wrappers for cwraps (#85919)

Bypass emscripten's generated js wrappers when invoking cwraps, this may improve cross-language inlining
Fix signature for a cwrap that was missing an arg

17 months agoAdd Base64.IsValid and allow Base64.DecodeXx methods to skip whitespace (#85938)
Stephen Toub [Tue, 9 May 2023 12:32:08 +0000 (08:32 -0400)]
Add Base64.IsValid and allow Base64.DecodeXx methods to skip whitespace (#85938)

* Allow Base64Decoder to ignore space chars, add IsValid methods and tests

* Some cleanup of Base64.IsValid changes

This includes making FromBase64Transform significantly faster via SearchValues.

* Address PR feedback and some more cleanup

---------

Co-authored-by: Heath Baron-Morgan <heathbm@outlook.com>
17 months agoDo not generate PerfMap entries for methods we didn't compile (#85958)
Michal Strehovský [Tue, 9 May 2023 11:17:28 +0000 (20:17 +0900)]
Do not generate PerfMap entries for methods we didn't compile (#85958)

* Do not generate PerfMap entries for methods we didn't compile

dotnet/installer#16318 is currently blocked due to crossgen2 crash. While Jan (https://github.com/dotnet/installer/pull/16318#issuecomment-1537160058) is totally right that the command line to crossgen2 is garbage, we should try not to crash. Based on the stack we already emitted the PE and PDB. The crash seems to be caused by attempting to include methods that didn't successfully compile in the perfmap (`EnumerateCompilerMethods` has an `IsEmpty` check whereas walking all nodes looking for `MethodWithGCInfo` doesn't check that).

```
Internal.TypeSystem.TypeSystemException+TypeLoadException: Failed to load type 'System.Security.Policy.EvidenceBase' from assembly 'System.Security.AccessControl, Version=6.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' [/__w/1/s/src/redist/redist.csproj]
    at Internal.TypeSystem.ThrowHelper.ThrowTypeLoadException(ExceptionStringID, String, String) + 0x39 [/__w/1/s/src/redist/redist.csproj]
    at Internal.TypeSystem.ResolutionFailure.Throw() + 0x99 [/__w/1/s/src/redist/redist.csproj]
    at Internal.TypeSystem.Ecma.EcmaModule.GetObject(EntityHandle, NotFoundBehavior) + 0x8f [/__w/1/s/src/redist/redist.csproj]
    at Internal.TypeSystem.Ecma.EcmaModule.GetType(EntityHandle) + 0x2c [/__w/1/s/src/redist/redist.csproj]
    at Internal.TypeSystem.Ecma.EcmaType.InitializeBaseType() + 0x81 [/__w/1/s/src/redist/redist.csproj]
    at Internal.TypeSystem.Ecma.EcmaType.ComputeTypeFlags(TypeFlags) + 0x48 [/__w/1/s/src/redist/redist.csproj]
    at Internal.TypeSystem.TypeDesc.InitializeTypeFlags(TypeFlags) + 0x1e [/__w/1/s/src/redist/redist.csproj]
    at Internal.TypeSystem.TypeNameFormatter.AppendName(StringBuilder, TypeDesc) + 0x2d [/__w/1/s/src/redist/redist.csproj]
    at ILCompiler.PEWriter.TypeString.AppendName(StringBuilder, ArrayType) + 0x1b [/__w/1/s/src/redist/redist.csproj]
    at Internal.TypeSystem.TypeNameFormatter.FormatName(TypeDesc) + 0x54 [/__w/1/s/src/redist/redist.csproj]
    at ILCompiler.PEWriter.OutputInfoBuilder.FormatMethodName(MethodDesc, TypeNameFormatter) + 0x174 [/__w/1/s/src/redist/redist.csproj]
    at ILCompiler.PEWriter.OutputInfoBuilder.<EnumerateMethods>d__16.MoveNext() + 0x15f [/__w/1/s/src/redist/redist.csproj]
    at ILCompiler.Diagnostics.PerfMapWriter.Write(String, Int32, IEnumerable`1, IEnumerable`1, TargetDetails) + 0x13b [/__w/1/s/src/redist/redist.csproj]
    at ILCompiler.PEWriter.SymbolFileBuilder.SavePerfMap(String, Int32, String) + 0x1ba [/__w/1/s/src/redist/redist.csproj]
    at ILCompiler.DependencyAnalysis.ReadyToRunObjectWriter.EmitPortableExecutable() + 0xa59 [/__w/1/s/src/redist/redist.csproj]
```

This is all based on the stack trace. I didn't validate this fixes the issue (or that it compiles at all) but the fix seems legit to me.

My local workflows are affected by the installer repo break because the runtime repo had a breaking change in CoreLib that is not compatible with existing installer builds. Nobody seems to be doing anything with the failing integration PR, so this is my attempt...

17 months agoDisable foreground-shutdown test on Windows (#85936)
Bruce Forstall [Tue, 9 May 2023 11:05:38 +0000 (04:05 -0700)]
Disable foreground-shutdown test on Windows (#85936)

This test has failed across many configurations, but apparently only
on Windows. Tracked by https://github.com/dotnet/runtime/issues/84006,
https://github.com/dotnet/runtime/issues/83658.

17 months ago[wasm] Wasm.Build.Tests - Override KnownWebAssemblySdkPack to 8.0.0-dev (#85815)
Marek Fišera [Tue, 9 May 2023 09:55:32 +0000 (11:55 +0200)]
[wasm] Wasm.Build.Tests - Override KnownWebAssemblySdkPack to 8.0.0-dev (#85815)

17 months agoJIT: Fix block morphing/physical promotion self-interference (#85887)
Jakob Botsch Nielsen [Tue, 9 May 2023 07:27:03 +0000 (09:27 +0200)]
JIT: Fix block morphing/physical promotion self-interference (#85887)

Fix a couple of cases where it's possible that the decomposed stores
will modify the address being used as part of the operation too early.
In those cases we must spill the address to a new local ahead of time.

Fix #85874

17 months agoJIT: Stop using ref counts in forward sub (#85909)
Jakob Botsch Nielsen [Tue, 9 May 2023 07:24:34 +0000 (09:24 +0200)]
JIT: Stop using ref counts in forward sub (#85909)

Instead of going to great lengths to keep the ref counts correct in
physical promotion just stop using them in forward sub. The last use
information generalizes what forward sub needs except for when the
tracking limit is reached, which shows in the improvements we actually
get from consulting the ref counts -- the improvements are very modest
and in tests only.

This makes early liveness the only consumer of the "regular" ref counts
computed by local morph. Weighted ref counts are still used for undoing
regular promotion of implicit byref parameters.

17 months agoRemove check from FillStringChecked and rename it to CopyStringContent (#85880)
Egor Bogatov [Tue, 9 May 2023 01:09:22 +0000 (03:09 +0200)]
Remove check from FillStringChecked and rename it to CopyStringContent (#85880)

17 months ago[main] Update dependencies from dnceng/internal/dotnet-optimization (#85866)
dotnet-maestro[bot] [Tue, 9 May 2023 00:38:46 +0000 (19:38 -0500)]
[main] Update dependencies from dnceng/internal/dotnet-optimization (#85866)

* Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build 20230505.3

optimization.linux-arm64.MIBC.Runtime , optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-arm64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime , optimization.PGO.CoreCLR
 From Version 1.0.0-prerelease.23254.3 -> To Version 1.0.0-prerelease.23255.3

* Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build 20230506.3

optimization.linux-arm64.MIBC.Runtime , optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-arm64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime , optimization.PGO.CoreCLR
 From Version 1.0.0-prerelease.23254.3 -> To Version 1.0.0-prerelease.23256.3

---------

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
17 months agoDelete call to `GetMethod` in runtime type system (#85902)
Michal Strehovský [Mon, 8 May 2023 23:50:12 +0000 (08:50 +0900)]
Delete call to `GetMethod` in runtime type system (#85902)

I think this is a leftover from one of the appmodels that we deleted. I don't believe this ever returns non-empty enumeration.

17 months ago[main] Servicing docs improvements (#85855)
github-actions[bot] [Mon, 8 May 2023 23:38:34 +0000 (17:38 -0600)]
[main] Servicing docs improvements (#85855)

* Servicing docs improvements

* Apply suggestions from code review

* Apply suggestions from code review

* Apply suggestions from code review

Co-authored-by: Carlos Sánchez López <1175054+carlossanlop@users.noreply.github.com>
* Apply suggestions from code review

* Update .github/workflows/check-service-labels.yml

* Update .github/workflows/check-service-labels.yml

---------

Co-authored-by: Carlos Sánchez López <1175054+carlossanlop@users.noreply.github.com>
Co-authored-by: Juan Hoyos <19413848+hoyosjs@users.noreply.github.com>
17 months agoPrevious changes fixed some runs, but some are still broken due to reinstall installi...
Parker Bibus [Mon, 8 May 2023 22:37:53 +0000 (15:37 -0700)]
Previous changes fixed some runs, but some are still broken due to reinstall installing a broken urllib version. (#85935)

17 months agoEnsure the insTupleType mask entries stay correct (#85870)
Tanner Gooding [Mon, 8 May 2023 21:53:14 +0000 (14:53 -0700)]
Ensure the insTupleType mask entries stay correct (#85870)

* Ensure the insTupleType mask entries stay correct

* Ensure the bitwise result remains uint16_t

17 months agoSpeed up `GVMLookupForSlot` (#85901)
Michal Strehovský [Mon, 8 May 2023 21:08:59 +0000 (06:08 +0900)]
Speed up `GVMLookupForSlot` (#85901)

BasicMinimalApi spends about 1% of samples in this method.

17 months agoUse Roslyn Source Generator Testing SDK to test interop source generators (#84867)
Jeremy Koritzinsky [Mon, 8 May 2023 19:03:05 +0000 (12:03 -0700)]
Use Roslyn Source Generator Testing SDK to test interop source generators (#84867)

17 months agoAdd test for unnmanaged delegates interop (#85903)
Andrii Kurdiumov [Mon, 8 May 2023 18:46:39 +0000 (00:46 +0600)]
Add test for unnmanaged delegates interop (#85903)

17 months agoFix RVA field access in composite Crossgen2 build (#78723) (#85800)
Tomáš Rylek [Mon, 8 May 2023 18:31:23 +0000 (20:31 +0200)]
Fix RVA field access in composite Crossgen2 build (#78723) (#85800)

The pre-existing behavior was copying all RVA fields in
single-file builds and only selectively copying explicitly
referenced fields in composite builds. This has bitten us
in WPF where Managed C++ emits an array of early initializers
that are marked by an initial and final RVA field. By only
selectively copying those two without the remaining entries
in-between we end up crashing later on as the app is not
fully initialized.

Based on David Wrighton's advice I have kept the logic for
copying RVA fields in case of array initializers that seem
to be hot in terms of performance. For the remaining field
access I have ended up constructing a new precode fixup
RVA_FIELD_ADDRESS for this purpose.

Fixes: #78723

Thanks

Tomas

Co-authored-by: Jan Kotas <jkotas@microsoft.com>
17 months agoperformance-setup.sh requires urllib3 version <2 (#85915)
Milos Kotlar [Mon, 8 May 2023 17:03:55 +0000 (19:03 +0200)]
performance-setup.sh requires urllib3 version <2 (#85915)

17 months agoUpdate dependencies from https://github.com/dotnet/roslyn-analyzers build 20230506...
dotnet-maestro[bot] [Mon, 8 May 2023 16:57:05 +0000 (11:57 -0500)]
Update dependencies from https://github.com/dotnet/roslyn-analyzers build 20230506.1 (#85885)

Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
 From Version 3.3.5-beta1.23254.2 -> To Version 3.3.5-beta1.23256.1

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
17 months ago[main] Update dependencies from dotnet/arcade (#85867)
dotnet-maestro[bot] [Mon, 8 May 2023 16:50:59 +0000 (12:50 -0400)]
[main] Update dependencies from dotnet/arcade (#85867)

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
 From Version 8.0.0-beta.23255.1 -> To Version 8.0.0-beta.23255.2

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
17 months ago[wasm] Fetch interpreter opcode info from the runtime instead of generating a table...
Katelyn Gadd [Mon, 8 May 2023 15:52:55 +0000 (08:52 -0700)]
[wasm] Fetch interpreter opcode info from the runtime instead of generating a table (#85904)

* No longer generate a typescript opcode info table
* Fetch opcode info from the interpreter on-demand

17 months ago[wasm] Prune opcodes in the jiterpreter if they follow an unconditional bailout/exit...
Katelyn Gadd [Mon, 8 May 2023 15:51:48 +0000 (08:51 -0700)]
[wasm] Prune opcodes in the jiterpreter if they follow an unconditional bailout/exit (#85905)

* Prune opcodes that follow an unconditional bailout/abort since they are unreachable and we don't need to compile them

17 months agoJIT: assert if we see schema mismatches with dynamic pgo data (#85898)
Andy Ayers [Mon, 8 May 2023 15:01:58 +0000 (08:01 -0700)]
JIT: assert if we see schema mismatches with dynamic pgo data (#85898)

When the profile data comes from dynamic PGO, the spanning tree encoded in the
schema produced by an earlier tier should exactly match the spanning tree for
the current jit attempt, since the JIT and method IL are identical.

(This is not the case for static PGO; that schema may have come from a different
JIT and/or different version of IL).

Note in release modes we won't assert; instead, we will silently throw the PGO
data away.

Follow-on change to #85805 to catch more issues like #85799.

17 months ago[mono][interp] Fix arg alignment issues when mixing with compiled code (#85153)
Vlad Brezae [Mon, 8 May 2023 10:39:51 +0000 (13:39 +0300)]
[mono][interp] Fix arg alignment issues when mixing with compiled code (#85153)

* [mono][interp] Refactor arg offset computation to make code clearer

* [mono][interp] Remove redundant assign

* [mono][interp] Move mint_type out from header file

It makes no sense to inline this big method into callers.

* [mono][interp] Fix arg offset computation when doing pinvoke and aot/jit calls from interp

The previous code wasn't handling alignment of simd types.

* [mono][interp] Use the correct alignment for args when entering interp

We stop computing the arguments on the fly since it's getting too expensive doing the alignment checks. We directly use `imethod->arg_offsets` instead which is computed once during the first call, while also ensuring consistency with the calculation.

* [mono][interp] Fix arg offset computation when running clauses with interp

* [mono][interp] Remove dead code

* Temporaril disable jiterp for CI

* Update jiterpreter interp_entry wrapper generator and re-enable jiterp

* Revert options-def.h changes

---------

Co-authored-by: Katelyn Gadd <kg@luminance.org>
17 months agoGet rid of reflection blocked types (#85810)
Michal Strehovský [Mon, 8 May 2023 06:34:59 +0000 (15:34 +0900)]
Get rid of reflection blocked types (#85810)

Fixes #72570.

Still need to delete workarounds that make things public in corelib but maybe this diff is large enough already?

We were gradually getting less and less from reflection blocking:

* We stopped blocking things outside corelib (.NET Native blocked all of BCL; we don't).
* We trim reflection metadata and that allows us to have method bodies without metadata.

With this, we should be able to get type definition-level reflection metadata for any MethodTable there is in the system.

This is a ~30 kB size regression for BasicMinimalApis. It is pretty much a wash for Hello World, because all the BCL cruft to handle reflection blocked types costs as much as the benefit of blocking.

17 months agoPin urllib to version 1.26.15 based on github comments to fix ssl requests error...
Parker Bibus [Mon, 8 May 2023 05:45:34 +0000 (22:45 -0700)]
Pin urllib to version 1.26.15 based on github comments to fix ssl requests error. (#85881)

17 months agoFix JsonNode.ToString allocations (#85886)
Pent Ploompuu [Sun, 7 May 2023 22:29:39 +0000 (01:29 +0300)]
Fix JsonNode.ToString allocations (#85886)

17 months agoFix flags checking for GT_IND (#85890)
SingleAccretion [Sun, 7 May 2023 21:13:44 +0000 (00:13 +0300)]
Fix flags checking for GT_IND (#85890)