iposva@chromium.org [Mon, 13 Jul 2009 15:00:35 +0000 (15:00 +0000)]
- Added missing braces in an if statement as a drive-by-edit.
- Removed executable bits from Xcode project file.
Review URL: http://codereview.chromium.org/155411
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2443
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
kasperl@chromium.org [Mon, 13 Jul 2009 14:37:21 +0000 (14:37 +0000)]
Update svn:ignore for tools/ and tools/gyp/ directories.
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2440
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
kasperl@chromium.org [Mon, 13 Jul 2009 13:49:57 +0000 (13:49 +0000)]
Prepare to push version 1.2.14 to trunk.
Review URL: http://codereview.chromium.org/149533
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2437
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
kasperl@chromium.org [Mon, 13 Jul 2009 13:36:38 +0000 (13:36 +0000)]
Revert r2431. I don't think this is it.
Review URL: http://codereview.chromium.org/155419
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2436
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
kasperl@chromium.org [Mon, 13 Jul 2009 13:24:32 +0000 (13:24 +0000)]
Attempt at work-around for crbug.com/16276 by explicitly checking
for global objects in the assembly code for dictionary loads.
Review URL: http://codereview.chromium.org/155418
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2435
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
deanm@chromium.org [Mon, 13 Jul 2009 11:17:51 +0000 (11:17 +0000)]
Small cleanup to Utf8::CalculateValue:
- Don't duplicate kMaxXByteChar constants.
- Don't compare signed and unsigned integers.
Review URL: http://codereview.chromium.org/155414
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2434
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
antonm@chromium.org [Mon, 13 Jul 2009 10:10:28 +0000 (10:10 +0000)]
Convert object to fast mode after creation. That enables more optimizations.
Review URL: http://codereview.chromium.org/155405
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2433
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
kasperl@chromium.org [Mon, 13 Jul 2009 09:17:04 +0000 (09:17 +0000)]
Add support for tracking down leak of the hole value.
Review URL: http://codereview.chromium.org/149522
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2432
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
kasperl@chromium.org [Mon, 13 Jul 2009 08:31:30 +0000 (08:31 +0000)]
Try to work around crbug.com/16276 until we can
find the cause of the problem.
Review URL: http://codereview.chromium.org/149521
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2431
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
ager@chromium.org [Fri, 10 Jul 2009 23:26:33 +0000 (23:26 +0000)]
Port the function prototype load stub to ARM.
Review URL: http://codereview.chromium.org/155373
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2430
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
ager@chromium.org [Fri, 10 Jul 2009 19:25:18 +0000 (19:25 +0000)]
Remove the descriptor stream abstractions.
The abstractions have led to bugs because it looks like descriptor
streams are GC safe but they are not.
I have moved the descriptor stream helper functions to descriptor
arrays and I find most of the code just as readable now as it was
before.
Review URL: http://codereview.chromium.org/149458
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2428
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
yurys@chromium.org [Fri, 10 Jul 2009 12:12:23 +0000 (12:12 +0000)]
Disable debug-stepin-function-call.js test on ARM.
TBR=ager@chromium.org
Review URL: http://codereview.chromium.org/155348
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2427
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
yurys@chromium.org [Fri, 10 Jul 2009 09:57:53 +0000 (09:57 +0000)]
Fix an issue with debugger 'step in' when calling function has local variables.Corresponding Chromium bug:code.google.com/p/chromium/issues/detail?id=15824
Review URL: http://codereview.chromium.org/149326
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2426
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
kasperl@chromium.org [Fri, 10 Jul 2009 09:40:47 +0000 (09:40 +0000)]
Re-enable ICs for loads and calls that skips a global object during
lookup through the prototype chain.
Review URL: http://codereview.chromium.org/155344
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2425
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mikhail.naganov@gmail.com [Fri, 10 Jul 2009 08:36:37 +0000 (08:36 +0000)]
Fixed issue 401: os.system() hangs on Mac OS X.
Fixed by falling back to using 'waitpid' instead of 'waitid'.
BUG=http://code.google.com/p/v8/issues/detail?id=401
Review URL: http://codereview.chromium.org/149450
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2424
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
kmillikin@chromium.org [Thu, 9 Jul 2009 14:34:08 +0000 (14:34 +0000)]
Skip the write barrier for global property cell writes. The heap
verification code was refactored to avoid verifying that property
cells have correct remembered sets.
Review URL: http://codereview.chromium.org/149392
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2423
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
lrn@chromium.org [Thu, 9 Jul 2009 14:04:37 +0000 (14:04 +0000)]
X64: Added failure entries in test expectations.
Review URL: http://codereview.chromium.org/149389
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2422
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
whesse@chromium.org [Thu, 9 Jul 2009 13:30:27 +0000 (13:30 +0000)]
X64: Let debugger patch JSReturn with a debug break.
Review URL: http://codereview.chromium.org/155286
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2421
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
kmillikin@chromium.org [Thu, 9 Jul 2009 13:28:22 +0000 (13:28 +0000)]
During a scavenge, instead of sweeping remembered-set bits for global
property cells, sweep the cell values themselves.
Review URL: http://codereview.chromium.org/149387
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2420
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
kasperl@chromium.org [Thu, 9 Jul 2009 12:23:08 +0000 (12:23 +0000)]
Don't have too many holders. Reviewed offline by Kevin Millikin.
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2419
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
kmillikin@chromium.org [Thu, 9 Jul 2009 12:20:04 +0000 (12:20 +0000)]
Fix free list construction for global property cells on x64.
Review URL: http://codereview.chromium.org/155287
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2418
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
kmillikin@chromium.org [Thu, 9 Jul 2009 12:13:51 +0000 (12:13 +0000)]
Fix too-long line.
TBR=kasperl@chromium.org
Review URL: http://codereview.chromium.org/149386
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2417
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
erik.corry@gmail.com [Thu, 9 Jul 2009 11:59:58 +0000 (11:59 +0000)]
Get peep-hole optimizer working on ARM by not emitting
debug info at places where the debugger can't stop.
This fixes the ARM version after
http://codereview.chromium.org/14170
Reformat debug-backtrace.js test.
Review URL: http://codereview.chromium.org/155285
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2416
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
lrn@chromium.org [Thu, 9 Jul 2009 11:46:30 +0000 (11:46 +0000)]
X64: Fixed more bad smi operations.
Review URL: http://codereview.chromium.org/155281
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2415
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
kmillikin@chromium.org [Thu, 9 Jul 2009 11:46:12 +0000 (11:46 +0000)]
Fix x64 build.
Review URL: http://codereview.chromium.org/149385
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2414
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
kasperl@chromium.org [Thu, 9 Jul 2009 11:17:57 +0000 (11:17 +0000)]
Allow access through the global proxy to use ICs.
Review URL: http://codereview.chromium.org/155283
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2413
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
kmillikin@chromium.org [Thu, 9 Jul 2009 11:13:08 +0000 (11:13 +0000)]
Create a new paged heap space for global property cells. The new
space is similar to map space in that it has fixed-size objects. A
common superclass for a space with fixed size objects is used for the
map space and cell space.
Allocate all cells in cell space. Handle it during all GCs. Modify
the free-list node representation (so that the size is not at a fixed
offset in all cells) to allow two-pointer free-list nodes. Clean up
some stuff in the MC collector.
Review URL: http://codereview.chromium.org/155211
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2411
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
deanm@chromium.org [Thu, 9 Jul 2009 10:52:54 +0000 (10:52 +0000)]
Fix problems with including parser.h from the Windows platform SDK instead of v8 by making sure that the v8 include path comes first.
Review URL: http://codereview.chromium.org/149383
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2410
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
lrn@chromium.org [Thu, 9 Jul 2009 08:00:12 +0000 (08:00 +0000)]
X64: Fix bug in left-shift.
Also changed a few other places that looked suspicious in the same way.
Added more info to failing test case and rewrote incorrect uses of mjsunit "fail" function.
Review URL: http://codereview.chromium.org/155279
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2409
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mikhail.naganov@gmail.com [Thu, 9 Jul 2009 06:39:38 +0000 (06:39 +0000)]
Add automatic tests for Tick Processor, take two.
Now tests can be run from any directory. Location of test data is now determined using test file location provided by 'testcfg.py' script.
Tested under Linux, Mac, and Windows.
Review URL: http://codereview.chromium.org/155161
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2407
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
kasperl@chromium.org [Thu, 9 Jul 2009 05:44:19 +0000 (05:44 +0000)]
Prepare to push version 1.2.13 to trunk.
TBR=kmillikin@chromium.org
Review URL: http://codereview.chromium.org/149381
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2405
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
lrn@chromium.org [Thu, 9 Jul 2009 05:43:34 +0000 (05:43 +0000)]
X64: Fix recently introduced bug in movq with 64-bit literal.
Review URL: http://codereview.chromium.org/155223
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2404
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
kasperl@chromium.org [Thu, 9 Jul 2009 05:25:08 +0000 (05:25 +0000)]
Re-add v8_shell target to v8.gyp. Patch by Joel Stanley.
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2403
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
ager@chromium.org [Thu, 9 Jul 2009 04:22:05 +0000 (04:22 +0000)]
Address review comments.
Only jump over 'else' part of a conditional if it is actually
generated. Update a comment to more correctly reflect what is going
on.
Review URL: http://codereview.chromium.org/155272
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2402
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
iposva@chromium.org [Wed, 8 Jul 2009 22:13:42 +0000 (22:13 +0000)]
- Update comments and fix a small glitch in the ARM disassembler.
- Fix the use of OS::ActivationFrameAlignment() when running with
the simulator.
Review URL: http://codereview.chromium.org/155109
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2401
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
ager@chromium.org [Wed, 8 Jul 2009 22:05:06 +0000 (22:05 +0000)]
Fix crash bug in ARM codegenerator by adding another special case for
generating code after a call to LoadConditionAndSpill.
This crash is hit on www.rightmove.co.uk when using the ARM
codegenerator.
Review URL: http://codereview.chromium.org/149351
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2400
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
ager@chromium.org [Wed, 8 Jul 2009 19:43:22 +0000 (19:43 +0000)]
Fix crash in arm conditional expression code generation.
Review URL: http://codereview.chromium.org/155234
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2399
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
erik.corry@gmail.com [Wed, 8 Jul 2009 19:12:58 +0000 (19:12 +0000)]
* Move almost all roots into an array ready for use by a constant-pool
register on ARM.
* Make some compile-time loops into run-time loops for compactness.
Review URL: http://codereview.chromium.org/149324
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2398
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
whesse@chromium.org [Wed, 8 Jul 2009 16:19:13 +0000 (16:19 +0000)]
Fix an X64 problem with builtin fixups. Remove an assert from fixups that is no longer true on all platforms.
Review URL: http://codereview.chromium.org/149332
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2397
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
lrn@chromium.org [Wed, 8 Jul 2009 15:43:31 +0000 (15:43 +0000)]
X64: Fix bug in for-in iteration.
Review URL: http://codereview.chromium.org/155213
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2396
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
deanm@chromium.org [Wed, 8 Jul 2009 15:36:12 +0000 (15:36 +0000)]
Fix missing include directories in v8.gyp.
Review URL: http://codereview.chromium.org/149331
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2395
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
deanm@chromium.org [Wed, 8 Jul 2009 15:29:16 +0000 (15:29 +0000)]
Correct the location of libraries-empty.cc in v8.gyp.
Review URL: http://codereview.chromium.org/155220
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2394
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
deanm@chromium.org [Wed, 8 Jul 2009 15:22:44 +0000 (15:22 +0000)]
Correct the location of snapshot.cc in v8.gyp.
Review URL: http://codereview.chromium.org/155219
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2393
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
deanm@chromium.org [Wed, 8 Jul 2009 14:56:56 +0000 (14:56 +0000)]
Cleanup v8.gyp. This also drops a bunch of unused targets (the shell, d8,
etc).
There are now two gyp variables to control whether we build snapshots and which
target we are building for. This allows you to easily cross-compile for arm and
disable snapshots.
Patch by Joel Stanley.
Original review: http://codereview.chromium.org/149243
Review URL: http://codereview.chromium.org/155218
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2392
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
bak@chromium.org [Wed, 8 Jul 2009 11:51:43 +0000 (11:51 +0000)]
Fixed and exposure to the_hole from Runtime_KeyedGetProperty.
Added regression test that fails with previous revisions.
Review URL: http://codereview.chromium.org/155212
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2391
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
kasperl@chromium.org [Wed, 8 Jul 2009 11:32:03 +0000 (11:32 +0000)]
Fix crash that occurs when we're forced to delete a global
property that used to be DontDelete and we still have an IC
that reads from the cell.
Review URL: http://codereview.chromium.org/149322
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2390
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
lrn@chromium.org [Wed, 8 Jul 2009 10:46:13 +0000 (10:46 +0000)]
X64: Decrease limit in big-object-literal test. Hits max call stack.
Review URL: http://codereview.chromium.org/155210
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2389
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
whesse@chromium.org [Wed, 8 Jul 2009 09:46:26 +0000 (09:46 +0000)]
X64: Turn of gcc strict-aliasing optimization for X64 release.
Review URL: http://codereview.chromium.org/155208
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2388
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
lrn@chromium.org [Wed, 8 Jul 2009 09:26:51 +0000 (09:26 +0000)]
X64: Added unimplemented method in codegen-x64.cc.
Six more tests run.
Review URL: http://codereview.chromium.org/149320
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2387
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
kasperl@chromium.org [Wed, 8 Jul 2009 07:35:14 +0000 (07:35 +0000)]
Change the name of the Object.prototype.inherits function in
the DeltaBlue benchmark to inheritsFrom to avoid name clashes
when running in Chromium with extensions enabled.
See http://crbug.com/11797.
Review URL: http://codereview.chromium.org/155205
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2386
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
kasperl@chromium.org [Wed, 8 Jul 2009 07:13:44 +0000 (07:13 +0000)]
Fix issue with skipping global object during lookup through
the prototype chain. In case we're skipping a global object,
we have to be careful not to use ICs for the load, because
it's possible to introduce variables on the global object
without a map change.
Review URL: http://codereview.chromium.org/149316
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2385
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
ager@chromium.org [Wed, 8 Jul 2009 03:21:27 +0000 (03:21 +0000)]
Fix unsafe use of DescriptorWriter across allocation.
DescriptorWriters hold a raw pointer to the descriptor array and they
are therefore not GC safe.
Review URL: http://codereview.chromium.org/149304
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2384
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
ager@chromium.org [Tue, 7 Jul 2009 21:08:29 +0000 (21:08 +0000)]
Another attempt at correctly marking a debug test that fails in debug
mode on arm.
Let's see if we can make the builder green.
TBR=yurys@chromium.org
Review URL: http://codereview.chromium.org/149282
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2383
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
ager@chromium.org [Tue, 7 Jul 2009 20:13:52 +0000 (20:13 +0000)]
Remove passing test from expected failures.
TBR=yurys@chromium.org
Review URL: http://codereview.chromium.org/149274
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2382
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
ager@chromium.org [Tue, 7 Jul 2009 19:00:24 +0000 (19:00 +0000)]
Port IsConstructCall optimization to x64 and ARM.
Review URL: http://codereview.chromium.org/149266
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2381
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
yurys@chromium.org [Tue, 7 Jul 2009 18:17:20 +0000 (18:17 +0000)]
Disable test-clearbreakpointgroup on ARM
Review URL: http://codereview.chromium.org/149262
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2380
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
whesse@chromium.org [Tue, 7 Jul 2009 14:06:08 +0000 (14:06 +0000)]
Fix issue number 398: replacing a constant function on a clone.
Review URL: http://codereview.chromium.org/149249
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2379
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
kmillikin@chromium.org [Tue, 7 Jul 2009 13:17:22 +0000 (13:17 +0000)]
Remove the support for jump-table switches from the x64 port as well.
Review URL: http://codereview.chromium.org/126197
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2378
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
kasperl@chromium.org [Tue, 7 Jul 2009 13:06:40 +0000 (13:06 +0000)]
Revert r2372 to get the tree green again.
TBR=mikhail.naganov@gmail.com
Review URL: http://codereview.chromium.org/155137
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2377
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
yurys@chromium.org [Tue, 7 Jul 2009 12:48:57 +0000 (12:48 +0000)]
In Chrome several tabs may share the same v8 instance. Each of those tabs can be inspected with its own devtools window. When such devtools window closes we need to clear all breakpoints that belong to it. Notion of breakpoint group enables us to do that.
Storing the breakpoints on the client(in a different process) would be inreliable since 1) it may crash and 2) some 'setbreakpoint' requests may be not processed yet by the time devtools window closes.
Review URL: http://codereview.chromium.org/149197
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2376
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
lrn@chromium.org [Tue, 7 Jul 2009 12:40:15 +0000 (12:40 +0000)]
X64: Disassembler updated to using REX, extended registers and some X64 opcodes.
Not all opcodes fixed yet (some should be invalid in 64-bit mode, others should be added).
Review URL: http://codereview.chromium.org/155087
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2375
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
whesse@chromium.org [Tue, 7 Jul 2009 12:17:31 +0000 (12:17 +0000)]
X64: Use CmpObjectType macro everywhere, fix problem with sign of instance types.
Review URL: http://codereview.chromium.org/155132
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2374
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mikhail.naganov@gmail.com [Tue, 7 Jul 2009 12:11:12 +0000 (12:11 +0000)]
Add automatic tests for Tick Processor.
Added tests for cmdline args parsing, symbols processing, and the whole process.
Tick Processor code was refactored to make it testable.
Review URL: http://codereview.chromium.org/149195
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2373
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
kasperl@chromium.org [Tue, 7 Jul 2009 11:57:09 +0000 (11:57 +0000)]
Fix issue 397 and issue 399.
Review URL: http://codereview.chromium.org/149247
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2372
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
kmillikin@chromium.org [Tue, 7 Jul 2009 11:41:21 +0000 (11:41 +0000)]
Change a few sites where the Handle<T>(NULL) constructor is used so
that they use the static Handle<T>::null() member function instead.
Review URL: http://codereview.chromium.org/155135
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2371
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
kasperl@chromium.org [Tue, 7 Jul 2009 09:50:12 +0000 (09:50 +0000)]
Fix lint issue.
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2370
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
kmillikin@chromium.org [Tue, 7 Jul 2009 09:48:54 +0000 (09:48 +0000)]
Allow variable proxies for the same global variable to share the same
variable object.
Add a map from names to variables for global scopes just like
non-global scopes. Variables are added to the map by the parser when
it encounters a declaration in a global scope or else at scope
resolution time by a failed variable lookup from the global scope or
an inner one and with no intervening with statements or possible calls
to eval.
Review URL: http://codereview.chromium.org/149245
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2369
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
lrn@chromium.org [Tue, 7 Jul 2009 09:29:41 +0000 (09:29 +0000)]
Changed ?: into if/else to placate compiler.
Review URL: http://codereview.chromium.org/155131
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2368
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
erik.corry@gmail.com [Tue, 7 Jul 2009 08:55:55 +0000 (08:55 +0000)]
Fix the order in which ToNumber is called for some Math functions.
Avoid divisions when doing Math.min(0, 0).
https://bugs.webkit.org/show_bug.cgi?id=26978 has been
filed to fix inconsistencies between JSC and V8.
Review URL: http://codereview.chromium.org/149188
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2367
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
lrn@chromium.org [Tue, 7 Jul 2009 08:11:19 +0000 (08:11 +0000)]
Separate native and interpreted regexp by compile time flag, not runtime.
Clean-up of RegExp code.
Review URL: http://codereview.chromium.org/155085
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2366
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
whesse@chromium.org [Tue, 7 Jul 2009 07:53:15 +0000 (07:53 +0000)]
X64: Implement sin and cos.
Review URL: http://codereview.chromium.org/149200
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2365
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
whesse@chromium.org [Mon, 6 Jul 2009 13:21:39 +0000 (13:21 +0000)]
X64: Make comparisons work on zero-extended smis.
Review URL: http://codereview.chromium.org/155083
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2364
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
antonm@chromium.org [Mon, 6 Jul 2009 11:00:53 +0000 (11:00 +0000)]
Use attributes to communicate failed lookup instead of retval.
Review URL: http://codereview.chromium.org/151151
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2363
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
deanm@chromium.org [Mon, 6 Jul 2009 10:56:52 +0000 (10:56 +0000)]
Remove some unused messages.
Review URL: http://codereview.chromium.org/149194
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2362
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
kasperl@chromium.org [Mon, 6 Jul 2009 07:45:39 +0000 (07:45 +0000)]
Prepare to push version 1.2.12 to trunk.
Review URL: http://codereview.chromium.org/149192
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2360
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
kasperl@chromium.org [Mon, 6 Jul 2009 06:57:32 +0000 (06:57 +0000)]
Fix win32 build by moving template function definition.
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2359
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
whesse@chromium.org [Sun, 5 Jul 2009 15:38:06 +0000 (15:38 +0000)]
Lint error fix
Review URL: http://codereview.chromium.org/149189
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2358
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
whesse@chromium.org [Sun, 5 Jul 2009 15:22:59 +0000 (15:22 +0000)]
X64: Fix LoadFloatOperands.
Review URL: http://codereview.chromium.org/155073
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2357
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
whesse@chromium.org [Fri, 3 Jul 2009 13:30:15 +0000 (13:30 +0000)]
X64: Use low bits of registers in emit_sse_operand. Enable --stop-at flag.
Review URL: http://codereview.chromium.org/155052
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2356
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
erik.corry@gmail.com [Fri, 3 Jul 2009 12:44:31 +0000 (12:44 +0000)]
ARM improvements to constant div, mod and mul.
* Fast runtime calls for div and mod.
* Fix assembly and disassembly of multiply instructions.
* Strength reduce and inline multiplications to shift-add.
* Strength reduce and inline mod by power of 2.
* Strength reduce mod by other small integers to mul.
* Strength reduce div by 2 and 3.
Review URL: http://codereview.chromium.org/155047
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2355
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
erik.corry@gmail.com [Fri, 3 Jul 2009 12:43:59 +0000 (12:43 +0000)]
Fix thinko in IC code.
Review URL: http://codereview.chromium.org/149175
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2354
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
kasperl@chromium.org [Fri, 3 Jul 2009 12:08:00 +0000 (12:08 +0000)]
Remove unneeded ToString calls. We call ToString if necessary
when the result of calling the replace function is added to the
ReplaceResultBuilder.
Review URL: http://codereview.chromium.org/149179
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2353
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
lrn@chromium.org [Fri, 3 Jul 2009 11:09:34 +0000 (11:09 +0000)]
Reverted RegExp parser error message change that broke layout test.
Also cleaned up some leftover crud.
Review URL: http://codereview.chromium.org/155048
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2352
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
whesse@chromium.org [Fri, 3 Jul 2009 10:13:05 +0000 (10:13 +0000)]
X64: Exit frame should use x64 ABI callee-save registers.
Review URL: http://codereview.chromium.org/155045
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2351
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
kasperl@chromium.org [Fri, 3 Jul 2009 10:09:59 +0000 (10:09 +0000)]
Optimize Date construction and string concatenation with
string objects (not values).
Review URL: http://codereview.chromium.org/149177
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2350
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
yurys@chromium.org [Fri, 3 Jul 2009 10:02:51 +0000 (10:02 +0000)]
We've got complains that sending afterCompile events to debug message handler may have considerable impact on the profiler when inspected script does lots of 'eval's. The proposed solution is to request source of the compiled script lazily instead of sending it in afterCompile event.
Corresponding Chromium bug:
http://code.google.com/p/chromium/issues/detail?id=15913
Review URL: http://codereview.chromium.org/149176
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2349
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
whesse@chromium.org [Fri, 3 Jul 2009 09:24:53 +0000 (09:24 +0000)]
X64: Remove optimistic smi operations on non-smis. They cannot be undone on X64.
Review URL: http://codereview.chromium.org/151200
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2348
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
whesse@chromium.org [Fri, 3 Jul 2009 09:22:22 +0000 (09:22 +0000)]
X64: Ignore extra bits in Smi::value()
Review URL: http://codereview.chromium.org/155046
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2347
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
whesse@chromium.org [Fri, 3 Jul 2009 09:16:23 +0000 (09:16 +0000)]
X64: Fix floating point and integer instructions in assembler.
Review URL: http://codereview.chromium.org/151207
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2346
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
lrn@chromium.org [Fri, 3 Jul 2009 08:18:35 +0000 (08:18 +0000)]
Changed RegExp parser to use a recursive data structure instead of stack-based recursion.
Shouldn't run out of stack space while parsing deeply nested regexps.
Might be a little faster.
Review URL: http://codereview.chromium.org/149069
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2345
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
bak@chromium.org [Fri, 3 Jul 2009 08:00:51 +0000 (08:00 +0000)]
M ic-arm.cc
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2344
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
bak@chromium.org [Fri, 3 Jul 2009 06:58:56 +0000 (06:58 +0000)]
Missing file from last change
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2343
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
bak@chromium.org [Fri, 3 Jul 2009 06:34:59 +0000 (06:34 +0000)]
Improved code for megamorphic stub on ia32.
Review URL: http://codereview.chromium.org/150225
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2342
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
iposva@chromium.org [Thu, 2 Jul 2009 19:46:28 +0000 (19:46 +0000)]
- Cache on backtracking stack in the irregexp interpreter for future use.
Review URL: http://codereview.chromium.org/149131
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2341
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
christian.plesner.hansen@gmail.com [Thu, 2 Jul 2009 15:30:03 +0000 (15:30 +0000)]
Fixed test failures caused by enabling stack traces by default
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2340
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
ager@chromium.org [Thu, 2 Jul 2009 14:17:10 +0000 (14:17 +0000)]
Port %ClassOf() optimization to X64 and ARM.
Review URL: http://codereview.chromium.org/150226
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2339
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
christian.plesner.hansen@gmail.com [Thu, 2 Jul 2009 12:26:31 +0000 (12:26 +0000)]
Enable capture of the top of the stack on error instantiation.
Performance impact on v8 benchmarks seems limited. Will be backed out
if chrome performance regresses.
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2338
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
whesse@chromium.org [Thu, 2 Jul 2009 11:49:39 +0000 (11:49 +0000)]
X64: Align start of remembered set to a 4-byte boundary
Review URL: http://codereview.chromium.org/151198
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2337
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
bak@chromium.org [Thu, 2 Jul 2009 10:59:34 +0000 (10:59 +0000)]
Template instantiations for Windows build.
Review URL: http://codereview.chromium.org/150221
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2335
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
kasperl@chromium.org [Thu, 2 Jul 2009 10:51:46 +0000 (10:51 +0000)]
Fix crash when calling non-function globals.
Review URL: http://codereview.chromium.org/151199
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2334
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00