platform/upstream/dotnet/runtime.git
5 years agoaddress review feedback and fix test issue
Geoff Kizer [Wed, 24 Jul 2019 07:47:35 +0000 (00:47 -0700)]
address review feedback and fix test issue

Commit migrated from https://github.com/dotnet/corefx/commit/d6e6f52c928f56b424b08fcf6e08ea84a74748ab

5 years agofix race in request body completion
Geoff Kizer [Tue, 23 Jul 2019 20:18:56 +0000 (13:18 -0700)]
fix race in request body completion

Commit migrated from https://github.com/dotnet/corefx/commit/29328b71b65abe3a199f0daf62f6ee71ca916e78

5 years agofix race with _requestBodyCancellationSource creation
Geoff Kizer [Tue, 23 Jul 2019 08:10:16 +0000 (01:10 -0700)]
fix race with _requestBodyCancellationSource creation

Commit migrated from https://github.com/dotnet/corefx/commit/7394185c0fc8a52bebf384b933b07c1eb1fba360

5 years agorework SendHeadersAsync to address various issues
Geoff Kizer [Tue, 23 Jul 2019 05:15:05 +0000 (22:15 -0700)]
rework SendHeadersAsync to address various issues

Commit migrated from https://github.com/dotnet/corefx/commit/2d5a9555d4888c82c653a9d7ad8368bc94adfdf2

5 years agoaddress review feedback
Geoff Kizer [Tue, 23 Jul 2019 03:25:59 +0000 (20:25 -0700)]
address review feedback

Commit migrated from https://github.com/dotnet/corefx/commit/752c1c8d8a01d22d52b1a320f9ed082049494045

5 years agocombine into single Cancel method on stream, and ensure Dispose cancels properly...
Geoff Kizer [Sat, 20 Jul 2019 17:02:45 +0000 (10:02 -0700)]
combine into single Cancel method on stream, and ensure Dispose cancels properly when response is not read to end

Commit migrated from https://github.com/dotnet/corefx/commit/5973d1ee6f3b616d2af2bc80527bdf8fe76ee210

5 years agorework shutdown handling
Geoff Kizer [Fri, 12 Jul 2019 11:41:05 +0000 (04:41 -0700)]
rework shutdown handling

Commit migrated from https://github.com/dotnet/corefx/commit/0cd73b77e1f31d48037b56deb0206f4e56b4232e

5 years agoRe-enable xunit warning 2003 (dotnet/corefx#39696)
Stephen Toub [Tue, 23 Jul 2019 19:49:33 +0000 (15:49 -0400)]
Re-enable xunit warning 2003 (dotnet/corefx#39696)

* Replace "Assert.Equal(null, " with "Assert.Null("

* Replace "Assert.NotEqual(null, " with "Assert.NotNull("

* Replace "Assert.Same(null, " with "Assert.Null("

* Replace "Assert.StrictEqual(null, " with "Assert.Null("

Commit migrated from https://github.com/dotnet/corefx/commit/6de660a02e335eefebfcc3c81ecb0013e2a8148e

5 years agoMerge pull request dotnet/corefx#39693 from eiriktsarpalis/add-dockerignore
Eirik Tsarpalis [Tue, 23 Jul 2019 17:43:46 +0000 (18:43 +0100)]
Merge pull request dotnet/corefx#39693 from eiriktsarpalis/add-dockerignore

Add .dockerignore file to the root of the repo

Commit migrated from https://github.com/dotnet/corefx/commit/e6a5951fb68a09598f1fc1826a94de212385c649

5 years agoMake AsciiToLower ReadOnlySpan<byte> (dotnet/corefx#39678)
Egor Bogatov [Tue, 23 Jul 2019 14:25:37 +0000 (17:25 +0300)]
Make AsciiToLower ReadOnlySpan<byte> (dotnet/corefx#39678)

Commit migrated from https://github.com/dotnet/corefx/commit/794bde4b8eb26047b6495af09a428e03e81e7e81

5 years agoDisable SendAsync_SuppressedGlobalStaticPropagationNoListenerAppCtx test (dotnet...
Stephen Toub [Tue, 23 Jul 2019 13:09:51 +0000 (09:09 -0400)]
Disable SendAsync_SuppressedGlobalStaticPropagationNoListenerAppCtx test (dotnet/corefx#39692)

Commit migrated from https://github.com/dotnet/corefx/commit/687f36489c19072cd5a19d48c099f53bbc871c4d

5 years agoRe-enable xunit warning 1006 (dotnet/corefx#39685)
Stephen Toub [Tue, 23 Jul 2019 06:39:47 +0000 (02:39 -0400)]
Re-enable xunit warning 1006 (dotnet/corefx#39685)

Regex search and replace for [InlineData()] with [Theory].

Commit migrated from https://github.com/dotnet/corefx/commit/b58a866ba8709d66eed52bb8ecb13966b7436a1d

5 years agoRe-enable all DisableXUnitAnalyzer test projects (dotnet/corefx#39674)
Stephen Toub [Mon, 22 Jul 2019 20:56:01 +0000 (16:56 -0400)]
Re-enable all DisableXUnitAnalyzer test projects (dotnet/corefx#39674)

* Re-enable all DisableXUnitAnalyzer test projects

* Remove TODO comment

Commit migrated from https://github.com/dotnet/corefx/commit/16f3eef83d6df4c9dbc0e2992dafbc9553db363d

5 years agoRe-enable ~20 xunit analyzers (dotnet/corefx#39671)
Stephen Toub [Mon, 22 Jul 2019 20:45:03 +0000 (16:45 -0400)]
Re-enable ~20 xunit analyzers (dotnet/corefx#39671)

* Re-enable ~20 xunit analyzers

All but one of these had no associated warnings firing.  I fixed one warning to be able to re-enable another analyzer.

* Fix netfx build failures

Commit migrated from https://github.com/dotnet/corefx/commit/c60b8172cfcd1e7f0d8104872f279781fd288b68

5 years agoCustom converter contravariant test coverage (dotnet/corefx#39558)
buyaa-n [Mon, 22 Jul 2019 18:43:03 +0000 (11:43 -0700)]
Custom converter contravariant test coverage (dotnet/corefx#39558)

* Custom converter contravariant test coverage

Commit migrated from https://github.com/dotnet/corefx/commit/27228368037aeaa27fc5220d7d12c0550a2ef9c3

5 years agoUpdate breaking changes doc with a few clarifications (dotnet/corefx#39665)
Stephen Toub [Mon, 22 Jul 2019 18:06:56 +0000 (14:06 -0400)]
Update breaking changes doc with a few clarifications (dotnet/corefx#39665)

Commit migrated from https://github.com/dotnet/corefx/commit/f25b89e05594b0e56e1bea7080c935908142e960

5 years agoAdd missing fields to BrotliEncoder/Decoder ref (dotnet/corefx#39653)
Stephen Toub [Mon, 22 Jul 2019 16:32:21 +0000 (12:32 -0400)]
Add missing fields to BrotliEncoder/Decoder ref (dotnet/corefx#39653)

Without these, we can end up with corrupt encoder/decoder state due to uninitialized fields.

Commit migrated from https://github.com/dotnet/corefx/commit/3c3b9ceee6e1416db6f1ddbc1ab0d0ffb67c16fa

5 years agoRemove unnecessary empty try { } blocks (dotnet/corefx#39664)
Stephen Toub [Mon, 22 Jul 2019 16:30:03 +0000 (12:30 -0400)]
Remove unnecessary empty try { } blocks (dotnet/corefx#39664)

Unnecessary in .NET Core code.  I didn't modify additional instances in libraries that target netstandard/netfx.

Commit migrated from https://github.com/dotnet/corefx/commit/ca795a928d210c78c6bbd3fa10eb35f4c093a5a4

5 years agoDisable DefaultPageSettings_Null_ReturnsExpected test (dotnet/corefx#39647)
Stephen Toub [Sun, 21 Jul 2019 01:45:58 +0000 (21:45 -0400)]
Disable DefaultPageSettings_Null_ReturnsExpected test (dotnet/corefx#39647)

Commit migrated from https://github.com/dotnet/corefx/commit/9bb93a61365db848aaf914b5dfb8d6684df3335e

5 years agoFix NullReferenceExceptions in IndentedTextWriter without writer (dotnet/corefx#39584)
Hugh Bellamy [Sun, 21 Jul 2019 00:59:51 +0000 (01:59 +0100)]
Fix NullReferenceExceptions in IndentedTextWriter without writer (dotnet/corefx#39584)

Commit migrated from https://github.com/dotnet/corefx/commit/52f0a9192d1fcf624252c79e1fe5aa057f1db719

5 years agoFix up cgroup2fs in Interop.MountPoints.FormatInfo (dotnet/corefx#39633)
Omair Majid [Sun, 21 Jul 2019 00:54:49 +0000 (20:54 -0400)]
Fix up cgroup2fs in Interop.MountPoints.FormatInfo (dotnet/corefx#39633)

`stat -fc %T /sys/fs/cgroup` calls this file system `cgroup2fs`

Add the cgroup2fs file system magic number. Available from:

  - https://www.kernel.org/doc/Documentation/cgroup-v2.txt
  - man 2 statfs

Move cgroup2fs next to cgroupfs in the drive type list, since it is also
DriveType.Ram.

Commit migrated from https://github.com/dotnet/corefx/commit/11416bd48af2c695dde9ef0057659249be10f12d

5 years agoPass CancellationToken from Http2Connection.SendHeadersAsync to StartWriteAsync ...
Stephen Toub [Sun, 21 Jul 2019 00:47:17 +0000 (20:47 -0400)]
Pass CancellationToken from Http2Connection.SendHeadersAsync to StartWriteAsync (dotnet/corefx#39635)

Commit migrated from https://github.com/dotnet/corefx/commit/9597dadcea747960aba304253370a17a2218208d

5 years agoDisable nullable warnings for netstandard and netfx (dotnet/corefx#39636)
Stephen Toub [Sat, 20 Jul 2019 12:47:08 +0000 (08:47 -0400)]
Disable nullable warnings for netstandard and netfx (dotnet/corefx#39636)

Commit migrated from https://github.com/dotnet/corefx/commit/e64cac6dcacf996f98f0b3f75fb7ad0c12f588f7

5 years agoPort some methods of the VB Interaction module (dotnet/corefx#39574)
Edison Henrique Andreassy [Sat, 20 Jul 2019 04:04:33 +0000 (01:04 -0300)]
Port some methods of the VB Interaction module (dotnet/corefx#39574)

Commit migrated from https://github.com/dotnet/corefx/commit/45851336efa3b754f427d00cef3d388357aed308

5 years agoRemove unnecessary use of volatile in PartitionerStatic (dotnet/corefx#39591)
Stephen Toub [Sat, 20 Jul 2019 01:09:49 +0000 (21:09 -0400)]
Remove unnecessary use of volatile in PartitionerStatic (dotnet/corefx#39591)

`SharedInt`, which is just an object wrapper around a `volatile int` was being used even though a) the objects weren't actually being shared, and b) the stored `int` was sometimes being passed by `ref` and thus losing its voliatility in some cases anyway.

(It's not entirely clear why an object is being used, regardless, but from the comments it appears to be due to concerns around false sharing.  Presumably cases were found where the enumerators were all allocated up-front resulting in these ints stored as part of the enumerator objects ending up on the same cache line, so they were moved to objects allocated on discrete threads during MoveNext to minimize that possibility.)

Commit migrated from https://github.com/dotnet/corefx/commit/7f21952eed6c421d6854bcce3c0a8f76f2d5de9b

5 years agoDon't dispose StreamPipeWriter CancellationToken until after Flush (dotnet/corefx...
Justin Kotalik [Fri, 19 Jul 2019 19:53:12 +0000 (12:53 -0700)]
Don't dispose StreamPipeWriter CancellationToken until after Flush (dotnet/corefx#39610) (dotnet/corefx#39620)

Commit migrated from https://github.com/dotnet/corefx/commit/7431e4938c461f6e24cf3122c0b9ca4eb27e4dde

5 years agoRe-enable unicode host name test (dotnet/corefx#39606)
Stephen Toub [Fri, 19 Jul 2019 14:08:42 +0000 (10:08 -0400)]
Re-enable unicode host name test (dotnet/corefx#39606)

Site appears to be back up.

Commit migrated from https://github.com/dotnet/corefx/commit/1303d28179b4369cbfac43affd723fa6e0bc9554

5 years agoAvoid "async void" tests (dotnet/corefx#39613)
Stephen Toub [Fri, 19 Jul 2019 14:07:15 +0000 (10:07 -0400)]
Avoid "async void" tests (dotnet/corefx#39613)

Most of these are just because "async void" tests are rare and require special handling in xunit we needn't use.  But a few of these are plain wrong and were resulting in our not actually testing what we hoped to test.

Commit migrated from https://github.com/dotnet/corefx/commit/50d8c71bb6139f3c06dd820d6d757a095a9fe994

5 years agoAdd telemetry marker for tests (dotnet/corefx#39619)
Viktor Hofer [Fri, 19 Jul 2019 13:43:31 +0000 (15:43 +0200)]
Add telemetry marker for tests (dotnet/corefx#39619)

Commit migrated from https://github.com/dotnet/corefx/commit/cce2f2e92b75a42d07da123e091ac96fb47f44c5

5 years agoFix in System.Data.Common namespace, use correct WriteAttributeString API (dotnet...
Cheena Malhotra [Thu, 18 Jul 2019 22:45:54 +0000 (15:45 -0700)]
Fix in System.Data.Common namespace, use correct WriteAttributeString API (dotnet/corefx#39543)

Commit migrated from https://github.com/dotnet/corefx/commit/182bed51dec709b3b1b56a4f435e0727e5dea110

5 years agoRemove dead ifdef'd code from Microsoft.CSharp/VisualBasic (dotnet/corefx#39587)
Stephen Toub [Thu, 18 Jul 2019 18:23:46 +0000 (14:23 -0400)]
Remove dead ifdef'd code from Microsoft.CSharp/VisualBasic (dotnet/corefx#39587)

Commit migrated from https://github.com/dotnet/corefx/commit/9c2682f5899f280e3ca2e52569f84eaecb255647

5 years agoMove ConnectAsync_AddCustomHeaders_Success ClientWebSocket test to loopback (dotnet...
Stephen Toub [Thu, 18 Jul 2019 18:21:49 +0000 (14:21 -0400)]
Move ConnectAsync_AddCustomHeaders_Success ClientWebSocket test to loopback (dotnet/corefx#39589)

Commit migrated from https://github.com/dotnet/corefx/commit/83954bb1404c5bdfb56130c5a4994e5e05403beb

5 years agoFix ordering of visibility and abstract/virtual/override (dotnet/corefx#39590)
Stephen Toub [Thu, 18 Jul 2019 18:21:08 +0000 (14:21 -0400)]
Fix ordering of visibility and abstract/virtual/override (dotnet/corefx#39590)

To conform to expected style across corefx.

Commit migrated from https://github.com/dotnet/corefx/commit/b95ad3c0f9066fa426754bd6e3379fbaca24834e

5 years ago[master] Update dependencies from dotnet/coreclr (dotnet/corefx#39567)
dotnet-maestro[bot] [Thu, 18 Jul 2019 18:20:31 +0000 (11:20 -0700)]
[master] Update dependencies from dotnet/coreclr (dotnet/corefx#39567)

* Update dependencies from https://github.com/dotnet/coreclr build 20190716.2

- Microsoft.NET.Sdk.IL - 5.0.0-alpha1.19366.2
- Microsoft.NETCore.ILAsm - 5.0.0-alpha1.19366.2
- Microsoft.NETCore.Runtime.CoreCLR - 5.0.0-alpha1.19366.2

* Ignore System.Private.Corelib in netcoreapp3.0 package testing

Commit migrated from https://github.com/dotnet/corefx/commit/167bb417724b2338df492b417bdfea89d458e473

5 years agoCode coverage for JsonWriterHelper JsonWriter (dotnet/corefx#39407)
buyaa-n [Thu, 18 Jul 2019 17:59:35 +0000 (10:59 -0700)]
Code coverage for JsonWriterHelper JsonWriter (dotnet/corefx#39407)

* Code coverage for JsonWriterHelper JsonWriter

* Applying feedback

* Some updates was not saved for previous commit

* Remove not needed row, formatting

* Removing tests not needed anymore

* Applying feedback

Commit migrated from https://github.com/dotnet/corefx/commit/4cbad86c4e6aeaa135b9a569dbde9151180c40f5

5 years agoFold a bunch of CoreCLR's abandoned mutex tests into a parameterized test (dotnet...
Koundinya Veluri [Thu, 18 Jul 2019 17:48:31 +0000 (10:48 -0700)]
Fold a bunch of CoreCLR's abandoned mutex tests into a parameterized test (dotnet/corefx#39050)

Fold a bunch of CoreCLR's abandoned mutex tests into a parameterized test

- There are a large number of tests in CoreCLR with a lot of redundancy, timing issues, and which take unnecessarily long to run
- Folded a bunch of them into the existing parameterized test and improved it to cover more cases to replace the tests in CoreCLR that will be removed
- Coverage is not 100% equivalent, but I belive this sufficiently covers the necessary aspects of the tests in CoreCLR that will be removed

Commit migrated from https://github.com/dotnet/corefx/commit/fa722debec4c18a444a207171b686e40d7c0fc1a

5 years agoMake all events nullable (dotnet/corefx#39578)
Santiago Fernandez Madero [Thu, 18 Jul 2019 03:07:03 +0000 (20:07 -0700)]
Make all events nullable (dotnet/corefx#39578)

Commit migrated from https://github.com/dotnet/corefx/commit/ba2d62a24ea8574f40c43cd27cc384f079958a0c

5 years agoChange HttpStress app to highlight in red unchanged totals (dotnet/corefx#39576)
Stephen Toub [Wed, 17 Jul 2019 21:53:30 +0000 (17:53 -0400)]
Change HttpStress app to highlight in red unchanged totals (dotnet/corefx#39576)

When no additional operations have completed since the last time status was output, highlight that in red.

Commit migrated from https://github.com/dotnet/corefx/commit/53dc908890102d3a888ba603a06266b85d3f4a9b

5 years agoInclude file SafeHandleTest.cs into the project. (dotnet/corefx#39573)
David Cantu [Wed, 17 Jul 2019 20:39:10 +0000 (13:39 -0700)]
Include file SafeHandleTest.cs into the project. (dotnet/corefx#39573)

Commit migrated from https://github.com/dotnet/corefx/commit/9a29c851b33d904b5706e90c4f5309f2f8f1fece

5 years agoSpanify Cryptography.Base64Transform
Günther Foidl [Wed, 17 Jul 2019 18:06:17 +0000 (20:06 +0200)]
Spanify Cryptography.Base64Transform

So it can be non-allocating byte[] -> byte[], instead of allocating (temp. buffer) and copying with byte[] -> char[] -> byte[].

Commit migrated from https://github.com/dotnet/corefx/commit/d4a935c526f5f84d6136066bd554f619ed0b7476

5 years agoMove ASN.1 decoding/encoding out of PkcsPal
Filip Navara [Wed, 17 Jul 2019 18:05:00 +0000 (20:05 +0200)]
Move ASN.1 decoding/encoding out of PkcsPal

Both the Windows version and the AnyOS version will use the managed ASN.1/BER/DER code via PkcsHelpers.

Commit migrated from https://github.com/dotnet/corefx/commit/ccad56758140def8084943e5a8f2acabbf81d454

5 years agoSocket: improve cross-platform behavior on Dispose (dotnet/corefx#38804)
Tom Deseyn [Wed, 17 Jul 2019 15:48:33 +0000 (17:48 +0200)]
Socket: improve cross-platform behavior on Dispose (dotnet/corefx#38804)

* Add tests

* Don't skip SyncSendFileGetsCanceledByDispose on .NET Framework

* Implement using code from previous PR

* Update SocketErrors when CleanedUp for APM APIs

* Cleanup SO_TYPE socket length handling (Fixes https://github.com/dotnet/corefx/issues/38750)

* SyncSendFileGetsCanceledByDispose: remove SkipTargetFramework NetFramework

* PR feedback

* Fix comment typo

* Also wait for async operations, and wait longer on each retry

* clear sockaddr using memset

* Fix build

* Only perform CLOEXEC check for non-abortive close

Commit migrated from https://github.com/dotnet/corefx/commit/9b2f7a834691a3bbad2949181eec707dd4b5a13b

5 years agoIncrease connect timeout for Functional Tests (dotnet/corefx#39559)
v-jizho2 [Wed, 17 Jul 2019 03:37:31 +0000 (20:37 -0700)]
Increase connect timeout for Functional Tests (dotnet/corefx#39559)

Commit migrated from https://github.com/dotnet/corefx/commit/da3d086edde315db03ff9b04c2926ab22940d50c

5 years agoEnable HttpStress to target http.sys in addition to Kestrel (dotnet/corefx#39553)
Stephen Toub [Tue, 16 Jul 2019 23:31:47 +0000 (19:31 -0400)]
Enable HttpStress to target http.sys in addition to Kestrel (dotnet/corefx#39553)

Commit migrated from https://github.com/dotnet/corefx/commit/d34317fbfb4963e7d42b96c36c314e2af829c3c7

5 years agoAdd UnsafeRelaxedJsonEscaping static to JavascriptEncoder. (dotnet/corefx#39550)
Ahson Khan [Tue, 16 Jul 2019 23:18:22 +0000 (16:18 -0700)]
Add UnsafeRelaxedJsonEscaping static to JavascriptEncoder. (dotnet/corefx#39550)

* Add UnsafeRelaxedJsonEscaping static to JavascriptEncoder.

* Remove duplicate test case and fix test name.

* Fix formatting nits and move the new class to a separate file.

* No need to special case single quote, and fix more formatting.

* Update the remarks section to call out the difference between Default
and Relaxed.

Commit migrated from https://github.com/dotnet/corefx/commit/30ece647dae7d9ddff8a24cdd615119fde259927

5 years agoUpdate branding in master to 5.0 (dotnet/corefx#39503)
William Godbe [Tue, 16 Jul 2019 22:47:57 +0000 (15:47 -0700)]
Update branding in master to 5.0 (dotnet/corefx#39503)

* Update branding in master to 5.0

* Revert to old AssemblyVersions

* Update to correct package versions

* Update Prerelease to alpha1

* Remove redundant PackageVersions

* Disable index check

* Update packageIndex

* Update PackageIndex again

* Revert incorrect packageIndex versions

Commit migrated from https://github.com/dotnet/corefx/commit/1acaa2017cfc64ef1aabcf3b19d0e097af692616

5 years agoMerge pull request dotnet/corefx#39343 from geoffkizer/enableremotetestsforhttp2
Geoff Kizer [Tue, 16 Jul 2019 22:09:58 +0000 (15:09 -0700)]
Merge pull request dotnet/corefx#39343 from geoffkizer/enableremotetestsforhttp2

ensure remote server HTTP2 tests are actually using HTTP2

Commit migrated from https://github.com/dotnet/corefx/commit/6ec67c15c3f213206e9cf66a2d69d274d3836e6b

5 years agoClean up date helper (dotnet/corefx#39548)
Layomi Akinrinade [Tue, 16 Jul 2019 21:48:53 +0000 (17:48 -0400)]
Clean up date helper (dotnet/corefx#39548)

Commit migrated from https://github.com/dotnet/corefx/commit/9711b084829db7b8f69b3d3eb9effa3d2bdc0699

5 years agoFix Utf8JsonWriter xml docs (dotnet/corefx#39092)
Santiago Fernandez Madero [Tue, 16 Jul 2019 21:15:10 +0000 (14:15 -0700)]
Fix Utf8JsonWriter xml docs (dotnet/corefx#39092)

* Fix Utf8JsonWriter xml docs

* PR Feedback

* PR Feedback

* PR Feedback put back remarks for ROS/string overrides

* Remove duplicate remarks

* PR Feedback

* PR Feedback, i.e. -> that is

Commit migrated from https://github.com/dotnet/corefx/commit/7b90f41828abea1d9db6d55403a849c2613d996d

5 years agoSpecify DateTimeKind.Utc in JSON tests to avoid ArgumentOutOfRangeException (dotnet...
Martin Björkström [Tue, 16 Jul 2019 21:01:13 +0000 (00:01 +0300)]
Specify DateTimeKind.Utc in JSON tests to avoid ArgumentOutOfRangeException (dotnet/corefx#39547)

Commit migrated from https://github.com/dotnet/corefx/commit/6cd505d9aaabe656707766dee22e9aec0404568f

5 years agodisable two slow tests that time out in CI
Geoff Kizer [Tue, 16 Jul 2019 19:16:58 +0000 (12:16 -0700)]
disable two slow tests that time out in CI

Commit migrated from https://github.com/dotnet/corefx/commit/3bf02562f062bdf0faf787f7cfe1d67539363ed5

5 years agoFix datetime bug (dotnet/corefx#39541)
Layomi Akinrinade [Tue, 16 Jul 2019 18:59:27 +0000 (14:59 -0400)]
Fix datetime bug (dotnet/corefx#39541)

Commit migrated from https://github.com/dotnet/corefx/commit/05c0f516cf20cd6ae108ba034984b0cdc740732e

5 years agoDo not over-escape writing Base64 strings within JSON using the writer. (dotnet/coref...
Ahson Khan [Tue, 16 Jul 2019 18:56:21 +0000 (11:56 -0700)]
Do not over-escape writing Base64 strings within JSON using the writer. (dotnet/corefx#39522)

Commit migrated from https://github.com/dotnet/corefx/commit/063e38c7bc66e076fdcc7521e4c69650baae9427

5 years agoAdd arm64 runtime ids for Fedora and RHEL 8
Omair Majid [Tue, 16 Jul 2019 18:44:51 +0000 (14:44 -0400)]
Add arm64 runtime ids for Fedora and RHEL 8

Both Fedora and RHEL 8 have arm64 (aka aarch64) among the primary/main
architectures they support.

Fedora includes aarch64 as a "Primary Architecture":
https://fedoraproject.org/wiki/Architectures#Primary_Architectures

RHEL 8 lists aarch64 right next to x86_64 in the developer download site:
https://developers.redhat.com/products/rhel/download

Commit migrated from https://github.com/dotnet/corefx/commit/ec18a81e92f531343ea754d355c6d2665d36c2ef

5 years agoChange callbacks to virtual from being abstract (dotnet/corefx#39526)
David Fowler [Tue, 16 Jul 2019 17:35:33 +0000 (10:35 -0700)]
Change callbacks to virtual from being abstract (dotnet/corefx#39526)

- Obsolete the callbacks as well

Commit migrated from https://github.com/dotnet/corefx/commit/51cd78434953683040f93e69ed2a889e476f5cac

5 years agoFix HttpStress GET Parameters operation to respect Kestrel max line length (dotnet...
Stephen Toub [Tue, 16 Jul 2019 17:04:40 +0000 (13:04 -0400)]
Fix HttpStress GET Parameters operation to respect Kestrel max line length (dotnet/corefx#39535)

* Fix HttpStress GET Parameters operation to respect Kestrel max line length

* Address PR feedback

* Address PR feedback

Commit migrated from https://github.com/dotnet/corefx/commit/bb0516a4f8d0c4d84eff2ba2a3ad0a4764ece9d2

5 years agoAdd negative tests for ValidateNumber
Jeremy Barton [Tue, 16 Jul 2019 16:49:08 +0000 (09:49 -0700)]
Add negative tests for ValidateNumber

With this change ValidateNumber gets to 100% block coverage.

Commit migrated from https://github.com/dotnet/corefx/commit/7fe5f15813aedc2144b348baa2f26e7289618a05

5 years agoAdd Encoder option to writer and serializer (dotnet/corefx#39524)
Steve Harter [Tue, 16 Jul 2019 16:29:20 +0000 (09:29 -0700)]
Add Encoder option to writer and serializer (dotnet/corefx#39524)

Commit migrated from https://github.com/dotnet/corefx/commit/bc10b53838bc84ac2b626e16eee1338183ee55c8

5 years agoRemove a few unnecessary !s (dotnet/corefx#39531)
Stephen Toub [Tue, 16 Jul 2019 15:10:12 +0000 (11:10 -0400)]
Remove a few unnecessary !s (dotnet/corefx#39531)

Commit migrated from https://github.com/dotnet/corefx/commit/2b6f38911bb45548c8d1db015526518276e6c888

5 years agoMerge pull request dotnet/corefx#39485 from eiriktsarpalis/httpstress-randomize-cance...
Eirik Tsarpalis [Tue, 16 Jul 2019 14:58:47 +0000 (15:58 +0100)]
Merge pull request dotnet/corefx#39485 from eiriktsarpalis/httpstress-randomize-cancellation

HttpStress: Randomize cancellation of requests

Commit migrated from https://github.com/dotnet/corefx/commit/e15d8dcb334ebd896cd2b23359d95c2ca679fdd9

5 years agoJavaScriptEncoder should allow U+002F SOLIDUS by default (dotnet/corefx#39494)
Levi Broderick [Tue, 16 Jul 2019 14:35:32 +0000 (07:35 -0700)]
JavaScriptEncoder should allow U+002F SOLIDUS by default (dotnet/corefx#39494)

Commit migrated from https://github.com/dotnet/corefx/commit/1b2b8e1262da221bf7c83c01b14df00618d5e4f1

5 years agoUpdate src/System.Net.Http/tests/StressTests/HttpStress/Program.cs
Eirik Tsarpalis [Tue, 16 Jul 2019 14:02:44 +0000 (15:02 +0100)]
Update src/System.Net.Http/tests/StressTests/HttpStress/Program.cs

Co-Authored-By: Stephen Toub <stoub@microsoft.com>
Commit migrated from https://github.com/dotnet/corefx/commit/ac239fc682f296c7eeb953f9ee26dd8a0351b6e4

5 years agoUpdate src/System.Net.Http/tests/StressTests/HttpStress/Program.cs
Eirik Tsarpalis [Tue, 16 Jul 2019 13:59:34 +0000 (14:59 +0100)]
Update src/System.Net.Http/tests/StressTests/HttpStress/Program.cs

Co-Authored-By: Stephen Toub <stoub@microsoft.com>
Commit migrated from https://github.com/dotnet/corefx/commit/6b2ddf6b59d62ea0a6720b731678f61fbbae7634

5 years agoUpdate src/System.Net.Http/tests/StressTests/HttpStress/Program.cs
Eirik Tsarpalis [Tue, 16 Jul 2019 13:59:22 +0000 (14:59 +0100)]
Update src/System.Net.Http/tests/StressTests/HttpStress/Program.cs

Co-Authored-By: Stephen Toub <stoub@microsoft.com>
Commit migrated from https://github.com/dotnet/corefx/commit/35dec8a0cd2850ab9e0d5a97cfac4f458a3550a9

5 years agoUpdate src/System.Net.Http/tests/StressTests/HttpStress/Program.cs
Eirik Tsarpalis [Tue, 16 Jul 2019 13:59:12 +0000 (14:59 +0100)]
Update src/System.Net.Http/tests/StressTests/HttpStress/Program.cs

Co-Authored-By: Stephen Toub <stoub@microsoft.com>
Commit migrated from https://github.com/dotnet/corefx/commit/ae4dc79e57514eb9dfe4a8c0480691bd80731969

5 years agoUpdate src/System.Net.Http/tests/StressTests/HttpStress/Program.cs
Eirik Tsarpalis [Tue, 16 Jul 2019 13:58:32 +0000 (14:58 +0100)]
Update src/System.Net.Http/tests/StressTests/HttpStress/Program.cs

Co-Authored-By: Stephen Toub <stoub@microsoft.com>
Commit migrated from https://github.com/dotnet/corefx/commit/bee6f7fa2f76f5793a89027132b3ece7af82e30c

5 years agoAdd support for immutable array (dotnet/corefx#39493)
Layomi Akinrinade [Tue, 16 Jul 2019 12:53:06 +0000 (08:53 -0400)]
Add support for immutable array (dotnet/corefx#39493)

* Add support for ImmutableArray

* Refactor immutable materializer strategies to use creator helper

* Clean up + re-add tests

* Check for immutable array

* Correct immutable array check

* Fix whitespace

Commit migrated from https://github.com/dotnet/corefx/commit/2811879c01bf6f3b95aa4ee9b8994cfb62038610

5 years agoPropagate abort exceptions from CreditManager.Dispose (dotnet/corefx#39520)
Stephen Toub [Tue, 16 Jul 2019 11:07:22 +0000 (07:07 -0400)]
Propagate abort exceptions from CreditManager.Dispose (dotnet/corefx#39520)

Currently, if an abort occurs, it disposes of credit managers, and if there's a waiter on that credit manager, that waiter propagates an ObjectDisposedException.  It should instead propagate whatever exception resulted from the abort.

Commit migrated from https://github.com/dotnet/corefx/commit/3c71b23c676c3538b33f4ae653cf6f85de77e44d

5 years agoremove unused cli param
Eirik Tsarpalis [Tue, 16 Jul 2019 08:47:43 +0000 (09:47 +0100)]
remove unused cli param

Commit migrated from https://github.com/dotnet/corefx/commit/7e595109699e301f31e3ffd3dda4aca9755c5c8a

5 years agoMore Win7 EventLog retries (dotnet/corefx#39521)
Dan Moseley [Tue, 16 Jul 2019 06:57:31 +0000 (23:57 -0700)]
More Win7 EventLog retries (dotnet/corefx#39521)

Commit migrated from https://github.com/dotnet/corefx/commit/4b348cc28f0ec996322d4d1a62cfae300f77604e

5 years agoRemove hooking of system color changes (dotnet/corefx#39468)
Jeremy Kuhne [Tue, 16 Jul 2019 04:21:10 +0000 (21:21 -0700)]
Remove hooking of system color changes (dotnet/corefx#39468)

* Remove hooking of system color changes

Hooking user preference changes to update system colors is expensive, particularly as it is hooked via reflection. Getting the current color from the OS is extremely cheap.  Removing this layer of caching avoids creating a watcher window and thread and a significant number of startup allocations.

In starting up a blank WinForms app this cuts 200 allocations.

Note that Pens and Brushes in System.Drawing start their own user preference watcher so that they can update GDI+ when backed by system colors.

* Address feedback

* Remove newly dead files

Commit migrated from https://github.com/dotnet/corefx/commit/97c736e09f2e119d6ec3d3ebebb7234dee48145d

5 years agoAdd Win7 retries around Count (dotnet/corefx#39517)
Dan Moseley [Tue, 16 Jul 2019 02:00:50 +0000 (19:00 -0700)]
Add Win7 retries around Count (dotnet/corefx#39517)

Commit migrated from https://github.com/dotnet/corefx/commit/8973a72af9e3a2837d18e73041e2c8090d6871d1

5 years agoUpdate README.md
Maryam Ariyan [Tue, 16 Jul 2019 00:23:05 +0000 (17:23 -0700)]
Update README.md

Commit migrated from https://github.com/dotnet/corefx/commit/efee78fd498620fccd49810e63e0a1236083b6d3

5 years agoAdding readme for MEF (dotnet/corefx#39506)
Maryam Ariyan [Tue, 16 Jul 2019 00:18:28 +0000 (17:18 -0700)]
Adding readme for MEF (dotnet/corefx#39506)

Commit migrated from https://github.com/dotnet/corefx/commit/3b26bd7e11d7b1fdc8162c6ce753074935ef9f10

5 years agoRemove unnecessary "internal" from JsonConverterFactory ctor (dotnet/corefx#39504)
Stephen Toub [Tue, 16 Jul 2019 00:14:02 +0000 (20:14 -0400)]
Remove unnecessary "internal" from JsonConverterFactory ctor (dotnet/corefx#39504)

The ctor is already `protected`, so it can already be accessed by any derived type.  The only benefit adding `internal` would provide is so that it could be called directly by something else in the assembly, but the type is `abstract`, so that doesn't make sense for a ctor.

Commit migrated from https://github.com/dotnet/corefx/commit/902294e7933e84601aa4543fc3afe0dcf85c2d99

5 years agoRequest-in-flight GOAWAY test (dotnet/corefx#39501)
Krzysztof Wicher [Tue, 16 Jul 2019 00:00:19 +0000 (17:00 -0700)]
Request-in-flight GOAWAY test (dotnet/corefx#39501)

* request-in-flight GOAWAY test

* apply feedback

Commit migrated from https://github.com/dotnet/corefx/commit/3eabd4c7f1cc439233e0f8bae3ba37a8d73b7e8d

5 years agoAdd a retry to an EventLog test on Win7 (dotnet/corefx#39508)
Stephen Toub [Mon, 15 Jul 2019 23:32:58 +0000 (19:32 -0400)]
Add a retry to an EventLog test on Win7 (dotnet/corefx#39508)

Commit migrated from https://github.com/dotnet/corefx/commit/c953201a9918a5b699e6d23cd48c863975b9b14e

5 years agoforce cancellations to only trigger after request has been sent
Eirik Tsarpalis [Mon, 15 Jul 2019 22:38:16 +0000 (23:38 +0100)]
force cancellations to only trigger after request has been sent

Commit migrated from https://github.com/dotnet/corefx/commit/524af177fd3e39de47dae3394b516f8a02a6446d

5 years agodispose CancellationTokenSources
Eirik Tsarpalis [Mon, 15 Jul 2019 18:36:01 +0000 (19:36 +0100)]
dispose CancellationTokenSources

Commit migrated from https://github.com/dotnet/corefx/commit/58c85e29cfaa4b6bd8002a5c90c5262ca0cb29cf

5 years agoHttpStress: Randomize cancellation of requests
Eirik Tsarpalis [Mon, 15 Jul 2019 16:40:50 +0000 (17:40 +0100)]
HttpStress: Randomize cancellation of requests

Commit migrated from https://github.com/dotnet/corefx/commit/c4167ed11e1444433a33cc5d44a4aa33e0ffd651

5 years agoImprove allocations in WinForms startup (dotnet/corefx#39275)
Jeremy Kuhne [Mon, 15 Jul 2019 22:19:17 +0000 (15:19 -0700)]
Improve allocations in WinForms startup (dotnet/corefx#39275)

* Strip out delegate API calls and use the SetDllImportResolver functionality instead.

* Fix the Unix buidl

* Fix NetFX build, create class for custom resolving

* Fix namespace, tweak comments in project file

* Tweak LibraryResolver per feedback

* Fix  breaks

* Adjust tests for NetFX behavior

* Harvest downlevel packages

* Put back UAP build, respond to feedback on projects and LOGFONT marking

* Remove local

* Tweak FileNotFoundException, guard in PageSettings

* Address feedback

Change LOGFONT round tripping to allow structs

* Fix hintpath. Finish fixing LOGFONT references.

* Address feedback

Commit migrated from https://github.com/dotnet/corefx/commit/b75421a0035bf3a44e1f68447255470d57074dbb

5 years agoReenable GCNotificationTests test (dotnet/corefx#39499)
Andy Hanson [Mon, 15 Jul 2019 22:00:30 +0000 (15:00 -0700)]
Reenable GCNotificationTests test (dotnet/corefx#39499)

Undoes dotnet/corefx#39375

Fix dotnet/corefx#39374

Commit migrated from https://github.com/dotnet/corefx/commit/4cb27d38819050bd01576d042f54537887debaa8

5 years agoPropagate correct exception in Http2Connection.Abort (dotnet/corefx#39496)
Stephen Toub [Mon, 15 Jul 2019 21:17:18 +0000 (17:17 -0400)]
Propagate correct exception in Http2Connection.Abort (dotnet/corefx#39496)

Ensure we pass the `_abortException`, not `abortException`, to the streams, and log any non-duplicate exception.

Commit migrated from https://github.com/dotnet/corefx/commit/cfccc26f9e77fa9f745857ec48a256309e29f39d

5 years agoAdded client operation for posting form data (dotnet/corefx#39437)
Anirudh Agnihotry [Mon, 15 Jul 2019 21:13:30 +0000 (14:13 -0700)]
Added client operation for posting form data (dotnet/corefx#39437)

* added client operation for post data

* client operation for multipart data content

* remove the subset test

Commit migrated from https://github.com/dotnet/corefx/commit/eee164d069f36ed4d8f850799bd6b9e414b2d23b

5 years agoIncrease wait timeout and add extra logs for Pipe Deadlock tests (dotnet/corefx#39436)
Justin Kotalik [Mon, 15 Jul 2019 20:20:10 +0000 (13:20 -0700)]
Increase wait timeout and add extra logs for Pipe Deadlock tests (dotnet/corefx#39436)

* Increase wait timeout and add extra logs

* nits

* Update FlushAsyncCancellationTests.cs

* Update ReadAsyncCancellationTests.cs

* This is what happens when you edit on github

* another one

Commit migrated from https://github.com/dotnet/corefx/commit/0de2d187a080a306b88cf57cc762a1ca601eceaa

5 years agoEnsure that CancellationToken is propagated to built-in request content types (dotnet...
Stephen Toub [Mon, 15 Jul 2019 20:17:56 +0000 (16:17 -0400)]
Ensure that CancellationToken is propagated to built-in request content types (dotnet/corefx#39474)

* Ensure that CancellationToken is propagated to built-in request content types

We don't currently expose the overload that would allow CancellationToken to be accessed by HttpContent-derived types in general, but we can at least ensure that when using the built-in content types, the CancellationToken provided to SendAsync is appropriately threaded through.  We were doing this previously in only a few cases, where we knew that the previous overload wouldn't be overridden (namely internal types and sealed types), but we can enable the 90% scenario as well by doing a type check at run-time.

* Disable cancellation test for UAP handler

Commit migrated from https://github.com/dotnet/corefx/commit/450f49a1a80663529b31d3defafbd5e59822a16a

5 years agoMake CreateConverter public and add options (dotnet/corefx#39438)
Jeremy Kuhne [Mon, 15 Jul 2019 19:42:55 +0000 (12:42 -0700)]
Make CreateConverter public and add options (dotnet/corefx#39438)

* Make CreateConverter public and add options

This is to facilitate composition with factory converters.

* Remove unnecessary using

Commit migrated from https://github.com/dotnet/corefx/commit/db543576d757f2d448f004f5e9ba2b77c2b497fe

5 years agoDisable Connection_UnderDifferentUsers_BehavesAsExpected test on Fedora (dotnet/coref...
Stephen Toub [Mon, 15 Jul 2019 19:22:33 +0000 (15:22 -0400)]
Disable Connection_UnderDifferentUsers_BehavesAsExpected test on Fedora (dotnet/corefx#39491)

Commit migrated from https://github.com/dotnet/corefx/commit/ace61287bee166a3777f5b3832295902a58ca79a

5 years agoUpdate issue-guide.md
Tarek Mahmoud Sayed [Mon, 15 Jul 2019 19:21:35 +0000 (12:21 -0700)]
Update issue-guide.md

Commit migrated from https://github.com/dotnet/corefx/commit/dc2df780bc177aab90a1e1949bf10beff490e0ea

5 years agoAvoid calling ctor on abstract type during deserialization (dotnet/corefx#39481)
Steve Harter [Mon, 15 Jul 2019 18:52:41 +0000 (11:52 -0700)]
Avoid calling ctor on abstract type during deserialization (dotnet/corefx#39481)

Commit migrated from https://github.com/dotnet/corefx/commit/a7efd2a2b3c638b5490547ad6beca128ba5d7bfe

5 years agoDisable TestVerify test failing in outerloop on Unix (dotnet/corefx#39488)
Stephen Toub [Mon, 15 Jul 2019 17:55:36 +0000 (13:55 -0400)]
Disable TestVerify test failing in outerloop on Unix (dotnet/corefx#39488)

Commit migrated from https://github.com/dotnet/corefx/commit/0441d3e8ed8779f52a759890ac3e94fb7fe56bc0

5 years agoAdd tests for nullable metadata and unconditionally set nullablePublicOnly (dotnet...
Santiago Fernandez Madero [Mon, 15 Jul 2019 17:37:36 +0000 (10:37 -0700)]
Add tests for nullable metadata and unconditionally set nullablePublicOnly (dotnet/corefx#39395)

* Add tests for nullable compiler emitted attributes

* Set nullablePublicOnly compiler feature unconditionally

* PR Feedback

* PR Feedback -- add positive and more exhaustive tests

Commit migrated from https://github.com/dotnet/corefx/commit/08cd402602ab5d3ce26fda968f9e0e1dff2d8b6f

5 years agoAddress nits from other PRs (dotnet/corefx#39482)
Steve Harter [Mon, 15 Jul 2019 17:29:03 +0000 (10:29 -0700)]
Address nits from other PRs (dotnet/corefx#39482)

Commit migrated from https://github.com/dotnet/corefx/commit/8af2b531bdd0ea41d3507870fadf9a26d663e700

5 years agoFix support for scientific notation numbers with decimal separators in JsonElement...
Víctor Reyes Rodríguez [Mon, 15 Jul 2019 17:16:29 +0000 (19:16 +0200)]
Fix support for scientific notation numbers with decimal separators in JsonElement.WriteTo

Commit migrated from https://github.com/dotnet/corefx/commit/e88ed00a06561a33cafa40108f8eac5d4d0b2514

5 years agoFix SocketsHttpHandler canceling request when response stream dropped (dotnet/corefx...
Stephen Toub [Mon, 15 Jul 2019 17:12:27 +0000 (13:12 -0400)]
Fix SocketsHttpHandler canceling request when response stream dropped (dotnet/corefx#39471)

* Fix SocketsHttpHandler canceling request when response stream dropped

Good code using HttpClient should Dispose of the HttpResponseMessage and/or response Stream when its done with it.  However, if code fails to do so, we still want to ensure that we don't leak connections/requests to the server or leak resources on the client.  If the response isn't disposed but the code reads all the way to the end of it, then internally things are cleaned up.  But if the response isn't disposed and hasn't read to the end, for both HTTP/1.1 and HTTP/2, we have some issues.

For HTTP/1.1, we rely on the Socket's finalization to close the associated connection.  However, we use a cache of SocketAsyncEventArgs instances to handle creating connections, and it turns out that these SocketAsyncEventArgs instances are keeping around a reference to the last created Socket.  If the SAEA is reused for another connection, then there's no issue, but until it is, it maintains several references to the socket: in ConnectSocket, in _currentSocket, in _multipleConnect, and then further within another SAEA instance that the _multipleConnect itself is creating for some reason.  We should go through and clean all that up in SAEA, but for now, this just removes the SAEA cache.

For HTTP/2, nothing was cleaning up in this case.  To handle it, we:
1. Make the response stream finalizable, such that when finalized it behaves as if Dispose were called.
2. When SendAsync completes, we remove the strong reference from the Http2Stream to the response message, such that the response (and in turn the response stream) doesn't get rooted by the Http2Connection storing the Http2Stream in its dictionary).
3. The only reason that reference was still needed was to support trailing headers.  So we create a lazily-allocated list on the Http2Stream for storing trailers if any should arrive, and then when the response body completes, the response stream pulls those headers in from the temporary collection into the response that it then has a reference to.  This also helps to avoid a race condition where consuming code erroneously accesses TrailingHeaders before the request has completed, in which case we previously could have been trying to write to the collection while user code was reading from it; with this change, that mutation happens as part of a call the consumer makes.

* Address PR feedback

Commit migrated from https://github.com/dotnet/corefx/commit/8b5eb8d9fb7857e5b40e763287f8f8832c15af31

5 years agoAdd UTF-8 APIs on TextEncoder and add JavascriptEncoder to JsonEncodedText (dotnet...
Steve Harter [Mon, 15 Jul 2019 16:39:58 +0000 (09:39 -0700)]
Add UTF-8 APIs on TextEncoder and add JavascriptEncoder to JsonEncodedText (dotnet/corefx#39415)

Commit migrated from https://github.com/dotnet/corefx/commit/bbbcac59ac07f344ce4e257ef182a90c429d2b58

5 years agoReplace collection instances on deserialize (dotnet/corefx#39442)
Steve Harter [Mon, 15 Jul 2019 14:07:30 +0000 (07:07 -0700)]
Replace collection instances on deserialize (dotnet/corefx#39442)

Commit migrated from https://github.com/dotnet/corefx/commit/ef1ac63f264c6c1f170315c636da49b4bf421dd9

5 years agoUpdate Http2_FlowControl_ClientDoesNotExceedWindows to use ByteAtATimeContent for...
Cory Nelson [Mon, 15 Jul 2019 04:19:34 +0000 (21:19 -0700)]
Update Http2_FlowControl_ClientDoesNotExceedWindows to use ByteAtATimeContent for compat with recent buffering change. (dotnet/corefx#39472)

Clear ActiveIssue as original issue in dotnet/corefx#38799 could not be reproduced.

Commit migrated from https://github.com/dotnet/corefx/commit/929bd81ee11728434ebf9c06152408b4b9940d12

5 years agorevert workarounds for 39372
Geoff Kizer [Sun, 14 Jul 2019 00:19:39 +0000 (17:19 -0700)]
revert workarounds for 39372

Commit migrated from https://github.com/dotnet/corefx/commit/0aea825037c13e522bec6f6bc21df37720a1b414

5 years agodisable cert validation for HTTP2 endpoint on Linux
Geoff Kizer [Thu, 11 Jul 2019 00:37:00 +0000 (17:37 -0700)]
disable cert validation for HTTP2 endpoint on Linux

Commit migrated from https://github.com/dotnet/corefx/commit/d34a2579ad53d72fd2482b4faada174416497041