Armin Novak [Mon, 24 Sep 2018 07:38:01 +0000 (09:38 +0200)]
Fix NULL function pointer BeginPaint
Armin Novak [Mon, 24 Sep 2018 07:08:50 +0000 (09:08 +0200)]
Fixed freerdp_keyboard_layouts_free
Armin Novak [Mon, 24 Sep 2018 07:07:59 +0000 (09:07 +0200)]
Free RDP_KEYBOARD_LAYOUT with freerdp_keyboard_layouts_free
David Fort [Mon, 24 Sep 2018 07:46:33 +0000 (09:46 +0200)]
Merge pull request #4869 from akallabeth/clear_fix
Fix #4868: Separate codec reset from initial setup
Martin Fleisz [Fri, 21 Sep 2018 11:02:39 +0000 (13:02 +0200)]
Merge pull request #4872 from akallabeth/sw_gdi_default
Fix #4851: Software GDI is now default
Martin Fleisz [Fri, 21 Sep 2018 11:01:58 +0000 (13:01 +0200)]
Merge pull request #4871 from akallabeth/drdynvc_checks
Fix for #4866: Added additional length checks
Martin Fleisz [Thu, 20 Sep 2018 11:14:24 +0000 (13:14 +0200)]
Merge pull request #4873 from akallabeth/leak_fix
Fixed use after free and leak.
akallabeth [Thu, 20 Sep 2018 10:07:36 +0000 (12:07 +0200)]
Merge pull request #4855 from r-barnett/fix-logoff-exit-code
Map a particular disconnect situation triggered by a user logging off…
Armin Novak [Thu, 20 Sep 2018 09:04:20 +0000 (11:04 +0200)]
Fixed use after free and leak.
Armin Novak [Thu, 20 Sep 2018 08:44:03 +0000 (10:44 +0200)]
Fix #4851: Software GDI is now default
Armin Novak [Thu, 20 Sep 2018 07:06:01 +0000 (09:06 +0200)]
Fix for #4866: Added additional length checks
rbarnett [Wed, 19 Sep 2018 14:36:39 +0000 (09:36 -0500)]
Replace cryptic names; move the disconnect ultimatum reasons enum into public API and rename; remove setter
Martin Fleisz [Wed, 19 Sep 2018 14:20:32 +0000 (16:20 +0200)]
Merge pull request #4870 from corux/patch-1
[NLA] Password prompt is shown even if empty password is provided
Tobias [Wed, 19 Sep 2018 13:36:24 +0000 (15:36 +0200)]
Do not prompt if blank password was provided
Armin Novak [Wed, 19 Sep 2018 12:10:50 +0000 (14:10 +0200)]
Fixed clear codec reset and test cases.
Armin Novak [Wed, 19 Sep 2018 11:02:29 +0000 (13:02 +0200)]
Fixed buffer size for clear_decompress test.
Armin Novak [Wed, 19 Sep 2018 10:03:07 +0000 (12:03 +0200)]
Fix #4868: Allow empty bands data.
Martin Fleisz [Wed, 19 Sep 2018 11:45:15 +0000 (13:45 +0200)]
Merge pull request #4867 from akallabeth/empty_smartcard_filter_fix
Fixed smartcard filter for empty arguments.
Armin Novak [Wed, 19 Sep 2018 09:13:02 +0000 (11:13 +0200)]
Fixed smartcard filter for empty arguments.
rbarnett [Tue, 18 Sep 2018 20:31:10 +0000 (15:31 -0500)]
Store the disconnect provider ulimatum reason in a new field in struct rdp_context and move the test for a logoff reason to xf_client.c
Martin Fleisz [Tue, 18 Sep 2018 08:59:15 +0000 (10:59 +0200)]
Merge pull request #4859 from akallabeth/autoreconnect_gfx_fix
Fixed #4857: Properly reset clear codec.
Armin Novak [Tue, 18 Sep 2018 07:51:50 +0000 (09:51 +0200)]
Fixed #4857: Properly reset clear codec.
Martin Fleisz [Mon, 17 Sep 2018 07:08:47 +0000 (09:08 +0200)]
Merge pull request #4842 from akallabeth/smartcard_rdp_logon
Added /smartcard-logon option to set flag. (Stripped version of #4837…
Martin Fleisz [Mon, 17 Sep 2018 07:08:32 +0000 (09:08 +0200)]
Merge pull request #4840 from akallabeth/smartcard_filter
Added multi filter for smartcard. (based on #4837 by @informatimago)
rbarnett [Fri, 14 Sep 2018 14:54:35 +0000 (09:54 -0500)]
Map a particular disconnect situation triggered by a user logging off to a user logoff code.
Martin Fleisz [Fri, 14 Sep 2018 08:59:31 +0000 (10:59 +0200)]
Merge pull request #4853 from r-barnett/add-nego-fail-exit-code
Add an exit code for a security protocol negotiation failure
Martin Fleisz [Fri, 14 Sep 2018 08:58:36 +0000 (10:58 +0200)]
Merge pull request #4854 from akallabeth/rail_exec_arguments_fix
Fixed rail unicode string conversion and const correctness.
Armin Novak [Fri, 14 Sep 2018 08:08:38 +0000 (10:08 +0200)]
Fixed macro _stream_read_n16_le and _stream_read_n16_be
Cast to appropriate type to avoid integer truncation warnings.
Armin Novak [Fri, 14 Sep 2018 08:07:22 +0000 (10:07 +0200)]
Fixed const correctness for RAIL callbacks.
Armin Novak [Fri, 14 Sep 2018 08:04:16 +0000 (10:04 +0200)]
Fixed rail unicode string conversion and const correctness.
rbarnett [Thu, 13 Sep 2018 15:29:23 +0000 (10:29 -0500)]
Add an exit code for a security protocol negotiation failure
akallabeth [Thu, 13 Sep 2018 07:57:16 +0000 (09:57 +0200)]
Merge pull request #4852 from r-barnett/fix-net-disconnect-exit-code
Set an error exit code for an unsuccessful reconnect
rbarnett [Wed, 12 Sep 2018 15:16:27 +0000 (10:16 -0500)]
Set an error exit code for an unsuccessful reconnect
Martin Fleisz [Wed, 12 Sep 2018 09:35:08 +0000 (11:35 +0200)]
Merge pull request #4850 from r-barnett/fix-connection-type-parsing
Reject unknown connection type values for /network command line option.
rbarnett [Tue, 11 Sep 2018 15:17:52 +0000 (10:17 -0500)]
Reject unknown connection type values for /network command line option.
akallabeth [Tue, 11 Sep 2018 06:18:33 +0000 (08:18 +0200)]
Merge pull request #4848 from mfleisz/longer_window_title
wfreerdp: Increase buffer size for window title (#4731)
Martin Fleisz [Mon, 10 Sep 2018 12:44:29 +0000 (14:44 +0200)]
wfreerdp: Increase buffer size for window title (#4731)
Martin Fleisz [Mon, 10 Sep 2018 08:48:48 +0000 (10:48 +0200)]
Merge pull request #4844 from akallabeth/avcodec_version_check_fix
Fixed avcodec version test.
Armin Novak [Fri, 7 Sep 2018 08:54:33 +0000 (10:54 +0200)]
Removed manipulation of authentication modes.
Let +smartcard-logon be a simple flag not changing authentication
settings. This can be done with the /sec options already.
Armin Novak [Wed, 5 Sep 2018 12:19:57 +0000 (14:19 +0200)]
Fixed avcodec version test.
Armin Novak [Wed, 5 Sep 2018 13:28:06 +0000 (15:28 +0200)]
Fixed out of bound access.
Armin Novak [Tue, 4 Sep 2018 13:49:21 +0000 (15:49 +0200)]
Added /smartcard-logon option to set flag. (Stripped version of #4837 by @informatimago)
Armin Novak [Tue, 4 Sep 2018 13:22:06 +0000 (15:22 +0200)]
Set freed pointer to NULL avoiding double free.
David Fort [Tue, 4 Sep 2018 13:17:01 +0000 (15:17 +0200)]
Merge pull request #4839 from akallabeth/optional_begin_paint
Fixed #4835: BeginPaint callback now optional.
Armin Novak [Tue, 4 Sep 2018 10:58:05 +0000 (12:58 +0200)]
Added multi filter for smartcard. (based on #4837 by @informatimago)
Armin Novak [Tue, 4 Sep 2018 08:40:17 +0000 (10:40 +0200)]
Fixed #4835: BeginPaint callback now optional.
David Fort [Mon, 3 Sep 2018 08:55:03 +0000 (10:55 +0200)]
Merge pull request #4836 from akallabeth/strcpy_fix
Fixed an issue introduced with #4822
Armin Novak [Mon, 3 Sep 2018 06:48:33 +0000 (08:48 +0200)]
Fixed an issue introduced with #4822
The string prepared is not NULL terminated and the sources are of fixed sizes.
Use memcpy instead of print fucntions in this specific case.
David Fort [Thu, 30 Aug 2018 08:25:02 +0000 (10:25 +0200)]
Merge pull request #4822 from akallabeth/remove_unchecked_strcpy
Removed use of strcpy.
Martin Fleisz [Wed, 29 Aug 2018 09:40:50 +0000 (11:40 +0200)]
Merge pull request #4827 from akallabeth/fedora_build_fix
Fixed wayland man page detection on fedora/redhat builds.
Armin Novak [Mon, 27 Aug 2018 08:52:22 +0000 (10:52 +0200)]
Fixed buffer size and function name
Armin Novak [Mon, 27 Aug 2018 07:15:50 +0000 (09:15 +0200)]
Fixed size of command line value string.
Armin Novak [Fri, 24 Aug 2018 11:49:19 +0000 (13:49 +0200)]
Fixed missing includes.
Armin Novak [Fri, 24 Aug 2018 10:15:06 +0000 (12:15 +0200)]
Fixed coverity memory leak.
Armin Novak [Fri, 24 Aug 2018 08:39:48 +0000 (10:39 +0200)]
Removed use of unchecked sprintf
Armin Novak [Fri, 24 Aug 2018 07:54:25 +0000 (09:54 +0200)]
Removed use of strcpy.
akallabeth [Mon, 27 Aug 2018 12:33:09 +0000 (14:33 +0200)]
Merge pull request #4829 from informatimago/smartcard-logon-rdp--x509-certificate-info-extraction
Smartcard Logon: restructured x509 certificate info extraction; added extracting the UPN.
Pascal J. Bourguignon [Mon, 27 Aug 2018 11:51:30 +0000 (13:51 +0200)]
Corrected the compatibility function names: crypto_cert_subject_alt_name and crypto_cert_subject_alt_name_free.
David Fort [Mon, 27 Aug 2018 10:10:08 +0000 (12:10 +0200)]
Merge pull request #4828 from akallabeth/warning_fixes_2_0
Compiler warning fixes
Pascal J. Bourguignon [Fri, 24 Aug 2018 14:04:29 +0000 (16:04 +0200)]
Compute certificate_path from __FILE__ to adapt to changing compilation and test environments.
Pascal J. Bourguignon [Fri, 24 Aug 2018 13:20:03 +0000 (15:20 +0200)]
Put back deprecated function names crypto_cert_get_alt_names and crypto_cert_alt_names_free for FREERDP_API compatibility.
Pascal J. Bourguignon [Fri, 24 Aug 2018 13:05:50 +0000 (15:05 +0200)]
Use C comment syntax instead of C++; added static declaration for local functions.
Pascal J. Bourguignon [Fri, 24 Aug 2018 12:03:04 +0000 (14:03 +0200)]
Smartcard Logon: restructured x509 certificate info extraction; added extracting the UPN.
Armin Novak [Thu, 23 Aug 2018 11:25:46 +0000 (13:25 +0200)]
Device name now const.
Armin Novak [Thu, 23 Aug 2018 11:16:13 +0000 (13:16 +0200)]
Removed unused variables.
Armin Novak [Thu, 23 Aug 2018 11:15:46 +0000 (13:15 +0200)]
Removed unused variables in tests.
Armin Novak [Thu, 23 Aug 2018 11:08:52 +0000 (13:08 +0200)]
Fixed missing const.
Armin Novak [Thu, 23 Aug 2018 11:08:31 +0000 (13:08 +0200)]
Fixed missing type casts.
Armin Novak [Thu, 23 Aug 2018 11:06:34 +0000 (13:06 +0200)]
Fixed unused variable warnings.
Armin Novak [Thu, 23 Aug 2018 11:06:15 +0000 (13:06 +0200)]
Fixed freerdp_load_dynamic_addin path
Armin Novak [Thu, 23 Aug 2018 11:05:44 +0000 (13:05 +0200)]
Fixed missing type cast.
Armin Novak [Thu, 23 Aug 2018 11:05:12 +0000 (13:05 +0200)]
Fixed unused label warning.
Armin Novak [Thu, 23 Aug 2018 11:04:42 +0000 (13:04 +0200)]
Fixed invalid argument warnings.
Armin Novak [Thu, 23 Aug 2018 10:45:36 +0000 (12:45 +0200)]
Fixed dead initialization.
Armin Novak [Thu, 23 Aug 2018 10:43:29 +0000 (12:43 +0200)]
Fixed missing check before calling memcpy
Armin Novak [Fri, 24 Aug 2018 11:21:27 +0000 (13:21 +0200)]
Fixed wayland man page detection on fedora/redhat builds.
Martin Fleisz [Fri, 24 Aug 2018 09:41:58 +0000 (11:41 +0200)]
Merge pull request #4810 from akallabeth/no_proxy_support
No proxy support
Martin Fleisz [Fri, 24 Aug 2018 07:48:51 +0000 (09:48 +0200)]
Merge pull request #4815 from akallabeth/async_transport_remove
Removed +async-transport options
Martin Fleisz [Fri, 24 Aug 2018 07:45:26 +0000 (09:45 +0200)]
Merge pull request #4816 from akallabeth/drive_cmd_fix
Fix #4680: Return proper directory name.
Martin Fleisz [Fri, 24 Aug 2018 06:37:41 +0000 (08:37 +0200)]
Merge pull request #4814 from akallabeth/linked_list_add_object
Linked list add object for user defined functions
Armin Novak [Tue, 21 Aug 2018 09:01:54 +0000 (11:01 +0200)]
Added option to ignore proxy env.
Armin Novak [Tue, 21 Aug 2018 08:57:44 +0000 (10:57 +0200)]
Added option to deactivate proxy.
Armin Novak [Tue, 21 Aug 2018 08:53:33 +0000 (10:53 +0200)]
Added patch from #4697
Martin Fleisz [Thu, 23 Aug 2018 14:58:22 +0000 (16:58 +0200)]
Merge pull request #4811 from akallabeth/dyn_fullscreen_fix
Fixed single monitor fullscreen resolution update.
Martin Fleisz [Thu, 23 Aug 2018 14:07:48 +0000 (16:07 +0200)]
Merge pull request #4787 from akallabeth/redirect_fqdn_fix
Redirect fqdn fix
Armin Novak [Thu, 23 Aug 2018 08:04:26 +0000 (10:04 +0200)]
Fix #4680: Return proper directory name.
David Fort [Thu, 23 Aug 2018 07:40:49 +0000 (09:40 +0200)]
Merge pull request #4813 from ondrejholy/coverity
Bunch of fixes based on covscan results
Ondrej Holy [Mon, 20 Aug 2018 09:11:47 +0000 (11:11 +0200)]
winpr/winsock: Fix leak found by covscan
0 is valid return value from socket().
leaked_handle: Handle variable "fd" going out of scope leaks the handle.
Ondrej Holy [Wed, 22 Aug 2018 11:17:10 +0000 (13:17 +0200)]
winpr/winsock: Format code by astyle
Run ./scripts/format_code.sh before the following changes.
Ondrej Holy [Tue, 21 Aug 2018 08:27:56 +0000 (10:27 +0200)]
winpr/utils/wlog: Fix leak found by covscan
leaked_storage: Variable "result" going out of scope leaks the storage it points to.
leaked_storage: Variable "bt" going out of scope leaks the storage it points to.
Ondrej Holy [Wed, 22 Aug 2018 11:16:58 +0000 (13:16 +0200)]
winpr/utils/wlog: Format code by astyle
Run ./scripts/format_code.sh before the following changes.
Ondrej Holy [Mon, 20 Aug 2018 08:55:29 +0000 (10:55 +0200)]
winpr/utils/ntlm: Prevent releasing function argument
The patch changes API of functions instead of fixing unused and broken code.
freed_arg: "free" frees parameter "NtHash".
David Fort [Wed, 22 Aug 2018 15:53:16 +0000 (17:53 +0200)]
Merge pull request #4797 from akallabeth/rpm_expand_fix
Removed comments with variables and (previously added) buggy suse con…
Ondrej Holy [Wed, 22 Aug 2018 11:16:31 +0000 (13:16 +0200)]
winpr/utils/ntlm: Format code by astyle
Run ./scripts/format_code.sh before the following changes.
Ondrej Holy [Mon, 20 Aug 2018 07:52:24 +0000 (09:52 +0200)]
winpr/sspi/ntlm: Fix leak found by covscan
leaked_storage: Variable "sam" going out of scope leaks the storage it points to.
leaked_storage: Variable "s" going out of scope leaks the storage it points to.
leaked_storage: Variable "snt" going out of scope leaks the storage it points to.
Ondrej Holy [Mon, 20 Aug 2018 07:50:43 +0000 (09:50 +0200)]
winpr/io/device: Fix leak found by covscan
leaked_storage: Variable "lpPipePath" going out of scope leaks the storage it points to.
Ondrej Holy [Wed, 22 Aug 2018 11:16:03 +0000 (13:16 +0200)]
winpr/io/device: Format code by astyle
Run ./scripts/format_code.sh before the following changes.
Ondrej Holy [Mon, 20 Aug 2018 07:47:33 +0000 (09:47 +0200)]
winpr/file: Fix leak found by covscan
overwrite_var: Overwriting handle "h" in "h = (HANDLE)0xffffffffffffffff" leaks the handle.
Ondrej Holy [Mon, 20 Aug 2018 07:33:42 +0000 (09:33 +0200)]
uwac: Fix leak found by covscan
leaked_storage: Variable "data" going out of scope leaks the storage it points to.
copy_paste_error: "opaque_region" in "w->opaque_region" looks like a copy-paste error.
Ondrej Holy [Wed, 22 Aug 2018 11:15:32 +0000 (13:15 +0200)]
uwac: Format code by astyle
Run ./scripts/format_code.sh before the following changes.