Gwenole Beauchesne [Sat, 19 Apr 2014 05:49:30 +0000 (07:49 +0200)]
vp8: fix compilation with built-in libvpx.
Apply correct patch from fd.o #722760 to fix several issues: update the
license terms to LGPLv2.1+, fix dependencies to built-in libvpx and fix
make dist.
Gwenole Beauchesne [Thu, 13 Feb 2014 20:17:23 +0000 (21:17 +0100)]
vp8: use range decoder from libvpx.
Add libvpx submodule that tracks the upstream version 1.3.0. This is
needed to build a libgstcodecparsers_vpx.so library with all symbols
placed into the GSTREAMER namespace.
Gwenole Beauchesne [Fri, 4 Apr 2014 17:17:17 +0000 (19:17 +0200)]
vp8: fix check for disabling the loop filter.
Zhao, Halley [Thu, 26 Dec 2013 23:18:24 +0000 (07:18 +0800)]
Add initial VP8 decoder.
https://bugzilla.gnome.org/show_bug.cgi?id=722761
[complete overhaul, fixed support for resolution changes]
Signed-off-by: Gwenole Beauchesne <gwenole.beauchesne@intel.com>
Gwenole Beauchesne [Fri, 21 Mar 2014 14:15:37 +0000 (15:15 +0100)]
decoder: h264: cope with new gst_h264_parser_parse_sei() interface.
The gst_h264_parse_parse_sei() function now returns an array of SEI
messages, instead of a single SEI message. Reason: it is allowed to
have several SEI messages packed into a single SEI NAL unit, instead
of multiple NAL units.
Gwenole Beauchesne [Fri, 18 Apr 2014 17:36:16 +0000 (19:36 +0200)]
codecparsers: update to gst-vaapi-branch commit a454f86.
b2eb5f6 vp8: rename dboolhuff symbols
b74a881 vp8: add GStreamer native utilities
2940ac6 add VP8 bitstream parser
Gwenole Beauchesne [Fri, 18 Apr 2014 17:16:56 +0000 (19:16 +0200)]
codecparsers: update to gst-vaapi-branch commit d459bc5.
d459bc5 h264: set framerate even for interlaced videos
c78b82c h264: add support for Recovery Point SEI message
7693bac h264: add support for Frame Packing Arrangement SEI message
31fafa7 h264: add support for Stereo Video Information SEI message
8b113a6 h264: parse seq_parameter_set_mvc_extension()
040f9b8 h264: parse MVC syntax elements
cc18ef3 h264: add nal_reader_skip_long() helper
7e76a48 h264: fix slice_header() parsing for MVC
caf46d8 h264: add gst_h264_parse_nalu_header() helper
f75074e h264: add gst_h264_parse_sps_data() helper
798c397 h264: clean-up gst_h264_parser_parse_sei_message()
4e36737 h264: fix skipping of unsupported SEI messages
5300766 h264: fix SEI buffering_period() parsing
Gwenole Beauchesne [Fri, 21 Mar 2014 14:09:14 +0000 (15:09 +0100)]
codecparsers: update to gst-vaapi-branch commit 8fadf40.
8fadf40 h264: Fix multiple SEI messages in one SEI RBSP parsing.
644825f h265: remove trailling 0x00 bytes as the spec doesn't allow them
95f9f0f h264: remove trailling 0x00 bytes as the spec doesn't allow them
766007b h265: Initialize pointer correctly that is never assigned but freed in error cases
8ec5816 h265: Fix segfault when parsing HRD parameter
5b1730f h265: Fix segfault when parsing VPS
983b7f7 h265: prevent to overrun chroma_weight_l0_flag
7ba641d h265: Fix debug output
d9f9f9b h264: not all startcodes should have 3-byte 0 prefix
Gwenole Beauchesne [Tue, 4 Feb 2014 17:35:28 +0000 (18:35 +0100)]
decoder: h264: fix robustness patch for bytestream format.
Fix parser and decoder state to sync at the right locations. This is
because we could reset the parser state, while the decoder state was
not copied yet, e.g. when parsing several NAL units from multiple frames
whereas the current frame was not decoded yet.
This is a regression brought in by commit 6fe5496.
Gwenole Beauchesne [Tue, 18 Feb 2014 05:56:51 +0000 (06:56 +0100)]
build: fix pkgconfig file names (again).
It turns out it is more convenient to have only pkgconfig files named
after the installed GStreamer API version (1.0) instead of using all
possible subsequent names from that (1.0, 1.2, 1.4). i.e. they conflict
altogether anyway, so align pkgconfig file names to that.
Gwenole Beauchesne [Fri, 7 Feb 2014 08:43:51 +0000 (09:43 +0100)]
build: fix packaging for GStreamer 1.2.
Fix gstreamer-vaapi includedir for GStreamer 1.2 setups. i.e. use
the pkgconfig version (1.0) instead of the intended API version (1.2).
libgstvaapi1.0-dev and libgstvaapi1.2-dev packages will now conflict,
as would core GStreamer 1.0 and GStreamer 1.2 dev packages anyway.
Gwenole Beauchesne [Fri, 24 Jan 2014 10:27:30 +0000 (11:27 +0100)]
Bump version for development.
Gwenole Beauchesne [Fri, 24 Jan 2014 09:55:39 +0000 (10:55 +0100)]
debian: fix trailing whitespace in description.
Gwenole Beauchesne [Thu, 23 Jan 2014 22:24:55 +0000 (23:24 +0100)]
debian: fix package description.
Try to improve package description for the compiled plug-in elements
available in there. e.g. only display vaapidownload and vaapiupload
for GStreamer 0.10 builds, display vaapiencode_* elements when VA
encoding is enabled, etc.
Also increase the copyright notice date.
Gwenole Beauchesne [Thu, 23 Jan 2014 21:47:19 +0000 (22:47 +0100)]
build: fix warnings on 64-bit platforms.
Gwenole Beauchesne [Thu, 23 Jan 2014 21:44:09 +0000 (22:44 +0100)]
build: fix for older versions of VA-API (< 0.34.0).
Fix build with older versions of VA-API (< 0.34.0), or versions without
good enough headers for encoding support for instance.
Gwenole Beauchesne [Thu, 23 Jan 2014 18:36:14 +0000 (19:36 +0100)]
0.5.8.
Gwenole Beauchesne [Thu, 23 Jan 2014 18:32:28 +0000 (19:32 +0100)]
README: updates.
VA-API up to 0.34.0 is actually supported. Mention new video encoding
support. Update copyright years, list of supported Intel HD Graphics
hardware.
Gwenole Beauchesne [Thu, 23 Jan 2014 18:18:13 +0000 (19:18 +0100)]
NEWS: updates.
Gwenole Beauchesne [Mon, 20 Jan 2014 13:16:56 +0000 (14:16 +0100)]
tests: test-filter: fix "deinterlace" option parse.
Default to GST_VAAPI_DEINTERLACE_METHOD_NONE if no "deinterlace" option
string was provided, i.e. if it remained set to NULL.
Gwenole Beauchesne [Thu, 23 Jan 2014 17:41:24 +0000 (18:41 +0100)]
libs: factor out usages of vaGetConfigAttributes().
Add gst_vaapi_get_config_attribute() helper function that takes a
GstVaapiDisplay and the rest of the arguments with VA types. The aim
is to have thread-safe VA helpers by default.
Gwenole Beauchesne [Thu, 23 Jan 2014 16:41:02 +0000 (17:41 +0100)]
libs: re-indent all source code related to VA utilities.
Gwenole Beauchesne [Thu, 23 Jan 2014 16:06:08 +0000 (17:06 +0100)]
libs: add missing file (libgstvaapi_priv_check.h).
Gwenole Beauchesne [Thu, 23 Jan 2014 14:13:06 +0000 (15:13 +0100)]
encoder: notify the encoder of the submitted packed headers.
Make sure to configure the encoder with the set of packed headers we
intend to generate and submit. i.e. make selection of packed headers
to submit more robust.
Gwenole Beauchesne [Thu, 23 Jan 2014 14:10:11 +0000 (15:10 +0100)]
encoder: fix and factor out check for supported rate-control modes.
Cache the first compatible GstVaapiProfile found if the encoder is not
configured yet. Next, factor out the code to check for the supported
rate-control modes by moving out vaGetConfigAttributes() to a separate
function, while also making sure that the attribute type is actually
supported by the encoder.
Also fix the default set of supported rate control modes to not the
"none" variant. It's totally useless to expose it at this point.
Gwenole Beauchesne [Thu, 23 Jan 2014 13:01:33 +0000 (14:01 +0100)]
context: move rate-control mode to encoder specific config.
Move usage-specific config out of the common GstVaapiContextInfo.
Create a specialized config for encoding and move rate-control mode
to there.
Gwenole Beauchesne [Thu, 23 Jan 2014 12:30:41 +0000 (13:30 +0100)]
context: introduce concept of usage.
Introduce GstVaapiContextUsage so that to explicitly determine the
usage of a VA context. This is useful in view to simplifying the
creation of VA context for VPP too.
Gwenole Beauchesne [Thu, 23 Jan 2014 10:44:12 +0000 (11:44 +0100)]
context: fix get_attribute() value result.
Unknown attributes, or attributes that are not supported for the given
profile/entrypoint pair have a return value of VA_ATTRIB_NOT_SUPPORTED.
So, return failure in this case.
Gwenole Beauchesne [Thu, 23 Jan 2014 09:59:20 +0000 (10:59 +0100)]
context: move overlay composition to separate files.
Move GstVideoOverlayComposition handling to separate source files.
This helps keeing GstVaapiContext core implementation to the bare
minimal, i.e. simpy helpers to create a VA context and handle pool
of associated VA surfaces.
Gwenole Beauchesne [Thu, 23 Jan 2014 08:41:07 +0000 (09:41 +0100)]
context: clean-ups. Strip down APIs.
Improve documentation and debug messages. Clean-up APIs, i.e. strip
them down to the minimal set of interfaces. They are private, so no
need expose getters for instance.
Gwenole Beauchesne [Thu, 23 Jan 2014 08:27:38 +0000 (09:27 +0100)]
context: re-indent all GstVaapiContext related source code.
Gwenole Beauchesne [Thu, 23 Jan 2014 09:20:40 +0000 (10:20 +0100)]
libs: check that private headers remain private.
Make sure that libgstvaapi private headers remain internally used to
build libgstvaapi libraries only. All header dependencies were reviewed
and checks for IN_LIBGSTVAAPI definition were added accordingly.
Also rename GST_VAAPI_CORE definition to IN_LIBGSTVAAPI_CORE to keep
consistency.
Gwenole Beauchesne [Wed, 22 Jan 2014 18:04:58 +0000 (19:04 +0100)]
Bump library major version.
Bump the library major version due to API/ABI changes that occurred in
the imaging API. In particular, GstVaapiDisplay interfaces no longer
expose any GstCaps but provide GArray based ones e.g. to determine the
set of supported decode/encode profiles.
Gwenole Beauchesne [Wed, 22 Jan 2014 17:54:14 +0000 (18:54 +0100)]
legal: update copyright notice dates.
Gwenole Beauchesne [Wed, 22 Jan 2014 17:49:20 +0000 (18:49 +0100)]
legal: add per-file authorship information.
Gwenole Beauchesne [Wed, 22 Jan 2014 17:11:26 +0000 (18:11 +0100)]
decoder: fix video codec frame number in standalone mode.
Set a valid GstVideoCodecFrame.system_frame_number when decoding a
stream in standalone mode. While we are at it, improve the debugging
messages to also include that frame number.
Wind Yuan [Fri, 17 Jan 2014 08:56:53 +0000 (16:56 +0800)]
decoder: fix crash on invalid pointer for GST_DEBUG().
When decoding failed, or that the frame was dropped, the associated
surface proxy is not guaranteed to be present. Thus, the GST_DEBUG()
message needs to check whether the proxy is actually present or not.
https://bugzilla.gnome.org/show_bug.cgi?id=722403
[fixed gst_vaapi_surface_proxy_get_surface_id() to return VA_INVALID_ID]
Signed-off-by: Gwenole Beauchesne <gwenole.beauchesne@intel.com>
Gwenole Beauchesne [Wed, 22 Jan 2014 16:07:24 +0000 (17:07 +0100)]
encoder: h264: disable NAL HRD parameters for now.
Don't emit NAL HRD parameters for now in the SPS headers because the
SEI buffering_period() and picture_timing() messages are not handled
yet. Some additional changes are necessary to get it right.
https://bugzilla.gnome.org/show_bug.cgi?id=722734
Gwenole Beauchesne [Tue, 21 Jan 2014 18:04:41 +0000 (19:04 +0100)]
encoder: h264: fix default CPB buffer size.
Fix default CPB buffer size to something more reasonable (1500 ms)
and that still fits the level limits. This is a non configurable
property for now. The initial CPB removal delay is also fixed to
750 ms.
https://bugzilla.gnome.org/show_bug.cgi?id=722087
Gwenole Beauchesne [Wed, 22 Jan 2014 13:43:24 +0000 (14:43 +0100)]
encoder: h264: fix bitrate encoding for HRD conformance.
Round down the calculated, or supplied, bitrate (kbps) into a multiple
of the HRD bitrate scale factor. Use a bitrate scale factor of 64 so
that to have less losses in precision. Likewise, don't round up because
that could be a strict constraint imposed by the user.
Gwenole Beauchesne [Wed, 22 Jan 2014 10:25:13 +0000 (11:25 +0100)]
encoder: h264: fix level lookup constraints wrt. bitrate.
Fix the level calculation involving bitrate limits. Since we are
targetting NAL HRD conformance, the check against MaxBR from the
Table A-1 limits shall involve cpbBrNalFactor depending on the
active profile.
Gwenole Beauchesne [Tue, 21 Jan 2014 17:01:20 +0000 (18:01 +0100)]
encoder: h264: submit sequence parameter only once.
Submit sequence parameter buffers only once, or when the bitstream
was reconfigured in a way that requires such. Always submit packed
sequence parameter buffers at I-frame period, if the VA driver needs
those.
https://bugzilla.gnome.org/show_bug.cgi?id=722737
Gwenole Beauchesne [Tue, 21 Jan 2014 17:35:17 +0000 (18:35 +0100)]
encoder: h264: only submit packed headers when required.
Make sure to submit the packed headers only if the underlying VA driver
requires those. Currently, only handle packed sequence and picture
headers.
https://bugzilla.gnome.org/show_bug.cgi?id=722737
Gwenole Beauchesne [Tue, 21 Jan 2014 16:35:24 +0000 (17:35 +0100)]
encoder: h264: fix ip_period value in sequence parameter.
The VAEncSequenceParameterBuffer.ip_period value reprents the distance
between the I-frame and the next P-frame. So, this also accounts for
any additional B-frame in the middle of it.
This fixes rate control heuristics for certain VA drivers.
https://bugzilla.gnome.org/show_bug.cgi?id=722735
Gwenole Beauchesne [Tue, 21 Jan 2014 16:04:40 +0000 (17:04 +0100)]
encoder: h264: fix level when bitrate is automatically computed.
Fix level characterisation when the bitrate is automatically computed
from the active coding tools. i.e. ensure the bitrate once the profile
is completely characterized but before the level calculation process.
Gwenole Beauchesne [Tue, 21 Jan 2014 15:05:22 +0000 (16:05 +0100)]
encoder: h264: clean-ups.
Document and rename a few functions here and there. Drop code that
caps num_bframes variable in reset_properties() since they shall
have been checked beforehand, during properties initialization.
Gwenole Beauchesne [Tue, 21 Jan 2014 14:28:34 +0000 (15:28 +0100)]
encoder: h264: clean-up bitwriter related utilities.
Clean-up GstBitWriter related utility functions and simplify notations.
While we are at it, also make bitstream writing more robust should an
overflow occur. We could later optimize for writing headers capped to
their maximum possible size by using the _unchecked() helper variants.
Gwenole Beauchesne [Tue, 21 Jan 2014 14:23:01 +0000 (15:23 +0100)]
encoder: h264: completely remove private headers.
Drop private header since it was originally used to expose internals
to the plugin element. The proper interface is now the properties API,
thus rendering private headers totally obsolete.
Gwenole Beauchesne [Wed, 15 Jan 2014 14:54:32 +0000 (15:54 +0100)]
encoder: h264: fix PPS header packing with profile < high.
Fix PPS header packing when profile is below High since 8x8 transform
mode and scaling lists are High Profile features.
Gwenole Beauchesne [Wed, 15 Jan 2014 14:46:19 +0000 (15:46 +0100)]
encoder: h264: always emit VUI parameters for framerate.
Always emit VUI parameters for timing_info, which includes framerate
information.
Gwenole Beauchesne [Wed, 15 Jan 2014 14:10:48 +0000 (15:10 +0100)]
encoder: h264: really fix frame cropping rectangle calculation.
Make frame cropping rectangle calculation future proof, i.e. exactly
follow the specification (7-18) to (7-21), and subsampling definitions
from Table 6-1.
https://bugzilla.gnome.org/show_bug.cgi?id=722089
https://bugzilla.gnome.org/show_bug.cgi?id=722238
Holger Kaelberer [Wed, 15 Jan 2014 11:09:14 +0000 (12:09 +0100)]
vaapisink: set csc render flags from sinkpad caps.
This maps GstVideoColorimetry information in vaapisink's sinkpad caps
to GST_VAAPI_COLOR_STANDARD_* flags, if per-buffer information was not
available.
https://bugzilla.gnome.org/show_bug.cgi?id=722255
[factored out code, added SMPTE240M, handle per-buffer flags]
Signed-off-by: Gwenole Beauchesne <gwenole.beauchesne@intel.com>
Gwenole Beauchesne [Wed, 28 Mar 2012 13:05:26 +0000 (15:05 +0200)]
surface: rework render flags.
Pack render flags per category and provide more flags into the color
standard category. In particular, cover for SMPTE-240M.
Zhao, Halley [Thu, 12 Dec 2013 20:14:41 +0000 (04:14 +0800)]
vaapipostproc: add support for colorbalance filters.
Add support for hue, saturation, brightness and constrat adjustments.
Also fix cap info local copy to match the really expected cap subtype
of interest.
https://bugzilla.gnome.org/show_bug.cgi?id=720376
Signed-off-by: Gwenole Beauchesne <gwenole.beauchesne@intel.com>
Zhao, Halley [Thu, 12 Dec 2013 00:38:12 +0000 (08:38 +0800)]
vaapipostproc: fix support for "sharpen" filter.
Fix copy/paste error when submitting the "sharpen" value to the
GstVaapiFilter instance.
https://bugzilla.gnome.org/show_bug.cgi?id=720375
Signed-off-by: Gwenole Beauchesne <gwenole.beauchesne@intel.com>
Lionel Landwerlin [Fri, 20 Dec 2013 12:05:42 +0000 (12:05 +0000)]
pkgconfig: plugin dir should use PKG version not API version.
Fix the pluginsdir and includedir variables in the generated pkgconfig
(.pc) files. The location needs to be built with the PKG version in
mind instead of the API version.
While we are at it, also fix the PKG version for GStreamer >= 1.3.
https://bugzilla.gnome.org/show_bug.cgi?id=720820
[additional fixes for includedir and pkg requirements]
Signed-off-by: Gwenole Beauchesne <gwenole.beauchesne@intel.com>
Holger Kaelberer [Wed, 15 Jan 2014 09:05:45 +0000 (10:05 +0100)]
vaapisink: fix display initialization in GstVideoOverlay implementation.
When gst_vaapisink_video_overlay_set_window_handle() is called early,
before the pipeline has been set to PLAYING, the display has not yet
been initialized and _PLUGIN_BASE_DISPLAY_TYPE() is not yet
up-to-date. For this reason the foreign XID is not attached.
Now _ensure_display() is called earlier.
https://bugzilla.gnome.org/show_bug.cgi?id=722244
Signed-off-by: Gwenole Beauchesne <gwenole.beauchesne@intel.com>
Sreerenj Balachandran [Wed, 9 Oct 2013 10:47:54 +0000 (13:47 +0300)]
vaapisink: expose the raw video formats in static caps template.
Expose all raw video formats in the static caps template since the
vaapisink is supporting raw data. We will get the exact set of formats
supported by the driver dynamically through the _get_caps() routine.
https://bugzilla.gnome.org/show_bug.cgi?id=703271
https://bugzilla.gnome.org/show_bug.cgi?id=720737
Signed-off-by: Gwenole Beauchesne <gwenole.beauchesne@intel.com>
Matthieu Bouron [Wed, 11 Dec 2013 18:08:26 +0000 (18:08 +0000)]
vaapidecode: query downstream caps features like GLTextureUploadMeta.
Fix vaapidecode to correctly report caps features downstream, when
a custom pipeline is built manually.
https://bugzilla.gnome.org/show_bug.cgi?id=719372
Signed-off-by: Gwenole Beauchesne <gwenole.beauchesne@intel.com>
Matthieu Bouron [Tue, 17 Dec 2013 15:27:10 +0000 (15:27 +0000)]
vaapidecode: add system memory caps to template caps.
Since vaapidecode provides buffer that can be mapped as regular memory,
those caps should be added to the template caps. That only applies to
GStreamer >= 1.2.
https://bugzilla.gnome.org/show_bug.cgi?id=720608
Signed-off-by: Gwenole Beauchesne <gwenole.beauchesne@intel.com>
Wind Yuan [Tue, 17 Dec 2013 02:26:03 +0000 (10:26 +0800)]
vaapidecode: fix hang on SIGINT.
vaapidecode hangs when pipeline is stopped without any EOS, e.g. when
<Ctrl>+C is pressed, thus causing the srcpad task to keep running and
locked. This fixes a deadlock on state change from PAUSED to READY.
https://bugzilla.gnome.org/show_bug.cgi?id=720584
Signed-off-by: Gwenole Beauchesne <gwenole.beauchesne@intel.com>
Wind Yuan [Tue, 17 Dec 2013 09:23:42 +0000 (04:23 -0500)]
vaapiencode: fix possible hang on SIGINT.
vaapiencode might hang when the pipeline is stopped without any EOS,
e.g. when <Ctrl>+C is pressed, thus causing the srcpad task to keep
running and locked. This fixes a possible deadlock on state change
from PAUSED to READY.
https://bugzilla.gnome.org/show_bug.cgi?id=720584
Signed-off-by: Gwenole Beauchesne <gwenole.beauchesne@intel.com>
Gwenole Beauchesne [Tue, 14 Jan 2014 15:33:04 +0000 (16:33 +0100)]
vaapiencode: fix typo in error message.
Fix incomplete error message in gst_vaapiencode_push_frame().
Gwenole Beauchesne [Tue, 14 Jan 2014 18:08:36 +0000 (19:08 +0100)]
plugins: add helpers to create video caps with features.
Add gst_vaapi_video_format_new_template_caps_with_features() helper
function to add the supplied caps feature string on GStreamer >= 1.2.
Add gst_vaapi_find_preferred_caps_feature() helper function to discover
the "best" caps feature to use for the supplied pad. In practice, we
will always favor memory:VASurface first, then meta:GLTextureUploadMeta,
and finally the system memory caps.
https://bugzilla.gnome.org/show_bug.cgi?id=719372
Matthieu Bouron [Thu, 9 Jan 2014 11:54:11 +0000 (11:54 +0000)]
plugins: don't apply overlay composition in GLTextureUpload function.
The GLTextureUpload function is not in charge of doing the overlay
composition if any.
https://bugzilla.gnome.org/show_bug.cgi?id=721859
Signed-off-by: Gwenole Beauchesne <gwenole.beauchesne@intel.com>
Gwenole Beauchesne [Tue, 14 Jan 2014 12:47:52 +0000 (13:47 +0100)]
encoder: re-order submission of VA objects.
Change the submission order of VA objects so that to make that process
more logical. i.e. submit sequence parameter first, if any; next the
packed headers associated to sequece, picture or slices; and finally
the actual picture and associated slices.
Gwenole Beauchesne [Tue, 14 Jan 2014 11:01:11 +0000 (12:01 +0100)]
encoder: clean-up objects.
Various clean-ups to improve consistency and readability: rename some
variables, drop unused macro definitions, drop initialization of vars
that are zero-initialized from the base class, drop un-necessary casts,
allocate GPtrArrays with a destroy function.
Gwenole Beauchesne [Mon, 13 Jan 2014 12:41:35 +0000 (13:41 +0100)]
encoder: h264: fix frame cropping rectangle calculation.
Fix frame cropping rectangle calculation to handle horizontal resolutions
that don't match a multiple of 16 pixels, but also the vertical resolution
that was incorrectly computed for progressive sequences too.
https://bugzilla.gnome.org/show_bug.cgi?id=722089
Gwenole Beauchesne [Mon, 13 Jan 2014 10:49:14 +0000 (11:49 +0100)]
encoder: h264: improve automatic bitrate calculation.
For non "Constant-QP" modes, we could provide more reasonable heuristics
for the target bitrate. In general, 48 bits per macroblock with all the
useful coding tools enable looks safe enough. Then, this rate is raised
by +10% to +15% for each coding tool that is disabled.
https://bugzilla.gnome.org/show_bug.cgi?id=719699
Gwenole Beauchesne [Mon, 13 Jan 2014 10:11:25 +0000 (11:11 +0100)]
encoder: h264: support "high-compression" tuning option.
Add support for "high-compression" tuning option. First, determine the
largest supported profile by the hardware. Next, check any target limit
set by the user. Then, enable each individual coding tool based on the
resulting profile_idc value to use.
https://bugzilla.gnome.org/show_bug.cgi?id=719696
Gwenole Beauchesne [Sun, 12 Jan 2014 21:24:04 +0000 (22:24 +0100)]
encoder: h264: allow target decoder constraints.
Allow user to precise the largest profile to use for encoding due
to target decoder constraints. For instance, if CABAC entropy coding
mode is requested by "constrained-baseline" profile only is desired,
then an error is returned during codec configuration.
Also make sure that the suitable profile we derived actually matches
what the HW can cope with.
https://bugzilla.gnome.org/show_bug.cgi?id=719694
Gwenole Beauchesne [Sun, 12 Jan 2014 21:14:11 +0000 (22:14 +0100)]
encoder: h264: refine size of coded buffer.
Refine the heuristic to determine the maximum size of a coded buffer
to account for the exact number of slices. set_context_info() is the
last step during codec reconfiguration, no additional change is done
afterwards, so re-using the num_slices field here is fine.
https://bugzilla.gnome.org/show_bug.cgi?id=719953
Wind Yuan [Fri, 13 Dec 2013 09:36:08 +0000 (17:36 +0800)]
encoder: h264: expose more coding tools.
Add new H.264 coding tools to improve compression:
- "cabac": enable CABAC entropy coding (default: FALSE);
- "dct8x8": enable spatial transform 8x8 (default: FALSE).
https://bugzilla.gnome.org/show_bug.cgi?id=719693
Signed-off-by: Gwenole Beauchesne <gwenole.beauchesne@intel.com>
Gwenole Beauchesne [Fri, 10 Jan 2014 17:18:25 +0000 (18:18 +0100)]
encoder: h264: derive profile and level from active coding tools.
Automatically derive the minimum profile and level to be used for
encoding, based on the activated coding tools. The encoder will
be trying to generate a bitstream that has the best chances to be
decoded on most platforms by default.
Also change the default profile to "constrained-baseline" so that
to ensure maximum compatibility when the stream is decoded.
https://bugzilla.gnome.org/show_bug.cgi?id=719691
Gwenole Beauchesne [Fri, 10 Jan 2014 16:02:44 +0000 (17:02 +0100)]
encoder: h264: fix hardware profile lookup.
Fix lookup for a suitable HW profile, as to be used by the underlying
hardware, based on heuristics that lead to characterize the SW profile,
i.e. the one used by the SW level encoding logic.
Also fix constraint_set0_flag (A.2.1) and constraint_set1_flag (A.2.2)
as they should respectively match the baseline and main profile.
https://bugzilla.gnome.org/show_bug.cgi?id=719827
Gwenole Beauchesne [Fri, 10 Jan 2014 13:46:15 +0000 (14:46 +0100)]
encoder: h264: support only the byte-stream format.
The libgstvaapi core encoders are meant to support raw bitstreams only.
Henceforth, we are always producing a stream in "byte-stream" format.
However, the "codec-data" buffer which holds SPS and PPS headers is
always available. The "lengthSizeMinusOne" field is always set to 3
so that in-place "byte-stream" format to "avc" format conversion could
be performed.
Gwenole Beauchesne [Fri, 10 Jan 2014 13:05:40 +0000 (14:05 +0100)]
encoder: h264: clean-ups.
Various clean-ups to improve consistency and readability: rename some
variables, drop unused macro definitions, drop initialization of vars
that are zero-initialized from the base class, drop un-necessary casts.
Gwenole Beauchesne [Mon, 13 Jan 2014 16:11:15 +0000 (17:11 +0100)]
encoder: mpeg2: fix hardware profile lookup.
Fix lookup for a suitable HW profile, as to be used by the underlying
hardware, based on heuristics that lead to characterize the SW profile,
i.e. the one used by the SW level encoding logic.
Gwenole Beauchesne [Mon, 13 Jan 2014 15:56:04 +0000 (16:56 +0100)]
encoder: mpeg2: derive profile and level from active coding tools.
Automatically derive the minimum profile and level to be used for
encoding, based on the activated coding tools. Improve lookup for
the best suitable level with the new MPEG-2 helper functions.
Also change the default profile to "simple" so that to ensure maximum
compatibility when the stream is decoded.
https://bugzilla.gnome.org/show_bug.cgi?id=719703
Gwenole Beauchesne [Mon, 13 Jan 2014 13:41:15 +0000 (14:41 +0100)]
encoder: mpeg2: clean-ups.
Various clean-ups to improve consistency and readability: drop unused
macro definitions, drop initialization of vars that are zero-initialized
from the base class, drop un-necessary casts.
Gwenole Beauchesne [Mon, 13 Jan 2014 09:48:25 +0000 (10:48 +0100)]
encoder: add tuning options API.
Add encoder "tune" option to override the default behaviour that is to
favor maximum decoder compatibility at the expense of lower compression
ratios.
Expected tuning options to be developed are:
- "high-compression": improve compression, target best-in-class decoders;
- "low-latency": tune for low-latency decoding;
- "low-power": tune for encoding in low power / resources conditions.
Gwenole Beauchesne [Sun, 12 Jan 2014 22:17:14 +0000 (23:17 +0100)]
encoder: fix bitrate units to match kbps.
Bitrate is expressed in kilobits per second (kbps). So, this exactly
means in multiple of 1000 bits, not 1024 bits.
https://bugzilla.gnome.org/show_bug.cgi?id=722086
Gwenole Beauchesne [Sun, 12 Jan 2014 20:57:20 +0000 (21:57 +0100)]
encoder: clean-ups.
Drop obsolete and unused macros. Add a few doc comments. Slightly
improve indentation of a few leftovers.
Gwenole Beauchesne [Sun, 12 Jan 2014 17:52:14 +0000 (18:52 +0100)]
encoder: filter out the supported set of rate-control properties.
Only expose the exact static set of supported rate-control properties
to the upper layer. For instance, if the GstVaapiEncoderXXX class does
only support CQP rate control, then only add it the the exposed enum
type.
Add helper macros and functions to build a GType for an enum subset.
Gwenole Beauchesne [Fri, 10 Jan 2014 12:23:48 +0000 (13:23 +0100)]
encoder: add keyframe period API.
Add gst_vaapi_encoder_set_keyframe_period() interface to allow the
user control the maximum distance between two keyframes. This new
property can only be set prior to gst_vaapi_encoder_set_codec_state().
A value of zero for "keyframe-period" gets it re-evaluated to the
actual framerate during encoder reconfiguration.
Gwenole Beauchesne [Fri, 10 Jan 2014 11:01:51 +0000 (12:01 +0100)]
encoder: improve codec reconfiguration.
Improve codec reconfiguration to be performed only through a single
function. That is, remove the _set_context_info() hook as subclass
should not alter the parent GstVaapiContextInfo itself. Besides, the
VA context is constructed only at the final stages of reconfigure().
Gwenole Beauchesne [Fri, 10 Jan 2014 10:30:25 +0000 (11:30 +0100)]
encoder: fix possible memory leak of coded buffer pools.
Fix gst_vaapi_encoder_reconfigure_internal() to re-/allocate the coded
buffer pool only if the coded buffer size actually changed.
Gwenole Beauchesne [Fri, 10 Jan 2014 09:54:22 +0000 (10:54 +0100)]
encoder: add video codec-state API.
Add interface to communicate the encoder resolution and related info
like framerate, interlaced vs. progressive, etc. This new interface
supersedes gst_vaapi_encoder_set_format() and doesn't use any GstCaps
but rather use GstVideoCodecState.
Note that gst_vaapi_encoder_set_codec_state() is also a synchronization
point for codec config. This means that the encoder is reconfigured
there to match the latest properties.
Gwenole Beauchesne [Mon, 13 Jan 2014 16:18:42 +0000 (17:18 +0100)]
vaapiencode: don't crash on NULL encoder on _finish().
Don't try to destroy an encoder, in GstVideoEncoder::finish() handler,
if it was not created in the first place. Return "not-negotiated" error
since this means we did not even reach GstVideoEncoder::set_format(),
where the encoder could have been created.
This fixes a crash when the vaapiencode_* plug-in elements get deallocated
and that we failed to negotiate either pad.
https://bugzilla.gnome.org/show_bug.cgi?id=719704
Gwenole Beauchesne [Thu, 9 Jan 2014 17:20:24 +0000 (18:20 +0100)]
vaapiencode: use more GstVaapiPluginBase facilities.
Avoid duplication of pad references or query functions since they are
provided through the GstVaapiPluginBase object.
Gwenole Beauchesne [Thu, 9 Jan 2014 17:10:35 +0000 (18:10 +0100)]
vaapiencode: fix negotiation process of output caps.
The specified caps in gst_video_encoder_set_output_state() function
arguments should not contain any resolution, pixel-aspect-ratio,
framerate, codec-data et al. Those rather should be set through the
returned GstVideoCodecState. This means that output caps creation
could be delayed until before gst_video_encoder_finish_frame() is
called.
This greatly simplifies the GstVideoEncoder::set_format() callback
by the way.
Gwenole Beauchesne [Wed, 8 Jan 2014 17:56:23 +0000 (18:56 +0100)]
vaapiencode: make GstVaapiEncode an abstract type.
Make base GstVaapiEncode class an abstract type so that we cannot
create an instance from it without going through any of the codec
specific derived class.
Gwenole Beauchesne [Thu, 9 Jan 2014 09:09:38 +0000 (10:09 +0100)]
vaapiencode: rename a few member functions.
Rename a few member functions to make them more consistent:
- alloc_encoder(): now reduced to allocate the encoder object only;
- alloc_buffer(): allocate buffer from srcpad, and copy bitstream.
Gwenole Beauchesne [Wed, 8 Jan 2014 17:36:46 +0000 (18:36 +0100)]
vaapiencode: update for new properties API.
Update MPEG-2 and H.264 encode elements to cope with the new core
libgstvaapi properties API. i.e. all configurable properties are now
directly handled at the GstVaapiEncoder level.
Besides, this also makes sure to not use or modify the GstVaapiEncoder
private definitions directly. Private data need to remain private.
https://bugzilla.gnome.org/show_bug.cgi?id=719529
Gwenole Beauchesne [Mon, 6 Jan 2014 16:46:40 +0000 (17:46 +0100)]
encoder: add properties API.
Add interface to communicate configurable properties to the encoder.
This covers both the common ones (rate-control, bitrate), and the
codec specific properties.
https://bugzilla.gnome.org/show_bug.cgi?id=719529
Gwenole Beauchesne [Mon, 6 Jan 2014 17:01:33 +0000 (18:01 +0100)]
encoder: add bitrate API.
Add gst_vaapi_encoder_set_bitrate() interface to allow the user control
the bitrate for encoding. Currently, changing this parameter is only
valid before the first frame is encoded. Should the value be modified
afterwards, then GST_VAAPI_ENCODER_STATUS_ERROR_OPERATION_FAILED is
returned.
https://bugzilla.gnome.org/show_bug.cgi?id=719529
Gwenole Beauchesne [Mon, 6 Jan 2014 14:10:36 +0000 (15:10 +0100)]
encoder: add rate control API.
Add gst_vaapi_encoder_set_rate_control() interface to request a new
rate control mode for encoding. Changing the rate control mode is
only valid prior to encoding the very first frame. Afterwards, an
error ("operation-failed") is issued.
https://bugzilla.gnome.org/show_bug.cgi?id=719529
Gwenole Beauchesne [Fri, 3 Jan 2014 15:57:25 +0000 (16:57 +0100)]
vaapiencode: fix indentation.
Gwenole Beauchesne [Fri, 3 Jan 2014 15:57:09 +0000 (16:57 +0100)]
encoder: fix indentation.
Gwenole Beauchesne [Mon, 13 Jan 2014 15:20:06 +0000 (16:20 +0100)]
utils: add new MPEG-2 helper functions.
Add various helper functions to convert profile, level, chroma formats
from gstreamer-vaapi world and the MPEG-2 specification world.