fengmk2 [Wed, 6 Nov 2013 11:58:03 +0000 (19:58 +0800)]
http: cleanup freeSockets when socket destroyed
If the socket was destroyed, we need to remove it from the agent's
`freeSockets` list, otherwise dead socket could be reused by new
request.
Jackson Tian [Sun, 1 Sep 2013 17:41:00 +0000 (01:41 +0800)]
benchmark: Correct the bufferSize to highWaterMark
The bufferSize has been removed. Use highWaterMark instead of.
Fedor Indutny [Tue, 5 Nov 2013 14:14:28 +0000 (18:14 +0400)]
tls: more accurate wrapping of connecting socket
When socket, passed in `tls.connect()` `options` argument is not yet
connected to the server, `_handle` gets assigned to a `net.Socket`,
instead of `TLSSocket`.
When socket is connecting to the remote server (i.e. not yet connected,
but already past dns resolve phase), derive `_connecting` property from
it, because otherwise `afterConnect()` will throw an assertion.
fix #6443
Ben Noordhuis [Tue, 5 Nov 2013 07:23:58 +0000 (08:23 +0100)]
fs: make fs.watch() non-recursive by default
Fixes a behavioral regression introduced in commit 691b9eb.
Ben Noordhuis [Mon, 4 Nov 2013 21:42:48 +0000 (22:42 +0100)]
src: fix whitespace/braces lint error from 962686b
Silly warning. One day I'll probably remove it altogether, see if I
don't.
Nathan Rajlich [Mon, 4 Nov 2013 17:39:29 +0000 (09:39 -0800)]
http: make DELETE requests set `req.method`
Fixes #6461.
Ben Noordhuis [Sun, 3 Nov 2013 20:00:37 +0000 (21:00 +0100)]
src: squelch unused variable warning
|i| and |j| arent't used when building without crypto support. Hat tip
to Brian White.
Rename |l| to |k| while we're here because it's quite hard to discern
from |i| or |j| with some fonts.
Erik Dubbelboer [Mon, 14 Oct 2013 14:53:59 +0000 (16:53 +0200)]
tls: add ECDH ciphers support
Switch test fixtures to 1024 bit keys.
Trevor Norris [Fri, 1 Nov 2013 20:57:09 +0000 (13:57 -0700)]
test: fix async listener test for windows
Ben Noordhuis [Fri, 1 Nov 2013 14:44:43 +0000 (15:44 +0100)]
benchmark: add http chunked encoding benchmarks
Test both "Content-Length: xxx" and "Transfer-Encoding: chunked" responses in
the http/simple benchmark.
Trevor Norris [Wed, 30 Oct 2013 00:05:40 +0000 (17:05 -0700)]
doc: add docs for AsyncListeners
Documentation has been added on how to use the AsyncListener API.
Jacob Groundwater [Tue, 15 Oct 2013 20:50:00 +0000 (13:50 -0700)]
test: add additional async listener tests
Trevor Norris [Tue, 29 Oct 2013 23:35:32 +0000 (16:35 -0700)]
domain: use AsyncListener API
The domain module has been switched over to use the domain module API as
much as currently possible. There are still some hooks in the
EventEmitter, but hopefully we can remove those in the future.
Trevor Norris [Sat, 28 Sep 2013 00:04:30 +0000 (17:04 -0700)]
cares: add AsyncListener support
Trevor Norris [Tue, 1 Oct 2013 00:24:41 +0000 (17:24 -0700)]
crypto: convert pbkdf2_req to a class
pbkdf2_req has been renamed to PBKDF2Request and converted to a class.
It now uses AsyncWrap::MakeCallback.
Also includes, using env()->ondone_string() instead of "ondone" and
using malloc instead of new char[].
Trevor Norris [Sun, 29 Sep 2013 06:33:29 +0000 (23:33 -0700)]
crypto: convert RandomBytesRequest to a class
Since RandomBytesRequest makes a call to MakeCallback, needed it to be
a class so AsyncWrap could handle any async listeners.
Also added a simple test for an issue had during implementation where
the memory was being released and returned.
Trevor Norris [Mon, 7 Oct 2013 19:39:52 +0000 (12:39 -0700)]
async-wrap: add methods to udp/tcp/pipe/timers
Now it's possible to add/remove an async listener to an individual
handle created by UDP, TCP, Pipe or Timer.
Trevor Norris [Fri, 27 Sep 2013 17:30:02 +0000 (10:30 -0700)]
async-wrap: integrate with WeakObject
Making WeakObject inherit from AsyncWrap allows us to peak into almost
all the MakeCallback calls in Node internals.
Trevor Norris [Tue, 24 Sep 2013 21:12:11 +0000 (14:12 -0700)]
node: add AsyncListener support
AsyncListener is a JS API that works in tandem with the AsyncWrap class
to allow the user to be alerted to key events in the life cycle of an
asynchronous event. The AsyncWrap class has its own MakeCallback
implementation that core will be migrated to use, and uses state sharing
techniques to allow quicker communication between JS and C++ whether the
async event callbacks need to be called.
Fedor Indutny [Thu, 31 Oct 2013 19:39:43 +0000 (23:39 +0400)]
test: fix tls-client-reject after
ba7c9ce96
Ben Noordhuis [Mon, 28 Oct 2013 19:18:59 +0000 (20:18 +0100)]
build: use zero overhead systemtap probes
Profiling suggested that on Linux sometimes over 10% of CPU time was
being spent inside the systemtap probe entry points in the binding
layer, even when the process was not actively being traced with the
`stap` tool.
That's why this commit makes it possible to use the *_ENABLED() macros
and bail out early when we're not being traced, reducing the overhead
of unused probes to (almost) zero.
Said macros were already being generated by `dtrace -h` but were not
usable because they rely on external definitions. To remedy that, we
now generate the accompanying object files with `dtrace -G`.
This commit includes a change to libuv that has been landed upstream in
commit joyent/libuv@3c172ea.
Fedor Indutny [Mon, 28 Oct 2013 12:10:10 +0000 (16:10 +0400)]
tls: do not default to 'localhost' servername
Fedor Indutny [Mon, 28 Oct 2013 10:25:27 +0000 (14:25 +0400)]
tls: reuse hostname from underlying net.Socket
When `tls.connect()` is called with `socket` option, it should try to
reuse hostname previously passed to `net.connect()` and only after that
fall back to `'localhost'`.
fix #6409
Nick Simmons [Tue, 22 Oct 2013 02:08:28 +0000 (22:08 -0400)]
fs: add recursive subdirectory support to fs.watch
Currently fs.watch does not have an option to specify if a directory
should be recursively watched for events across all subdirectories.
Several file watcher APIs support this. FSEvents on OS X > 10.5 is
one example. libuv has added support for FSEvents, but fs.watch had
no way to specify that a recursive watch was required.
fs.watch now has an additional boolean option 'recursive'. When set
to true, and when supported, fs.watch will return notifications for
the entire directory tree hierarchy rooted at the specified path.
Timothy J Fontaine [Wed, 30 Oct 2013 15:55:06 +0000 (08:55 -0700)]
Now working on 0.11.9
Timothy J Fontaine [Wed, 30 Oct 2013 15:54:48 +0000 (08:54 -0700)]
Merge branch 'v0.11.8-release'
Timothy J Fontaine [Wed, 30 Oct 2013 00:08:07 +0000 (17:08 -0700)]
2013.10.30, Version 0.11.8 (Unstable)
* uv: Upgrade to v0.11.14
* v8: upgrade 3.21.18.3
* assert: indicate if exception message is generated (Glen Mailer)
* buffer: add buf.toArrayBuffer() API (Trevor Norris)
* cluster: fix premature 'disconnect' event (Ben Noordhuis)
* crypto: add SPKAC support (Jason Gerfen)
* debugger: count space for line numbers correctly (Alex Kocharin)
* debugger: make busy loops SIGUSR1-interruptible (Ben Noordhuis)
* debugger: repeat last command (Alex Kocharin)
* debugger: show current line, fix for #6150 (Alex Kocharin)
* dgram: send() can accept strings (Trevor Norris)
* dns: rename domain to hostname (Ben Noordhuis)
* dns: set hostname property on error object (Ben Noordhuis)
* dtrace, mdb_v8: support more string, frame types (Dave Pacheco)
* http: add statusMessage (Patrik Stutz)
* http: expose supported methods (Ben Noordhuis)
* http: provide backpressure for pipeline flood (isaacs)
* process: Add exitCode property (isaacs)
* tls: socket.renegotiate(options, callback) (Fedor Indutny)
* util: format as Error if instanceof Error (Rod Vagg)
Timothy J Fontaine [Tue, 29 Oct 2013 23:46:15 +0000 (16:46 -0700)]
fs_event_wrap: update to new libuv api
Timothy J Fontaine [Tue, 29 Oct 2013 23:33:17 +0000 (16:33 -0700)]
uv: Upgrade to v0.11.14
Trevor Norris [Tue, 29 Oct 2013 20:23:58 +0000 (13:23 -0700)]
src: shorten Object{Wrap,Unwrap}
Going back to the original names of Wrap/Unwrap now that most all the
class members that duplicate the name and functionality have been
removed.
Trevor Norris [Tue, 29 Oct 2013 20:09:52 +0000 (13:09 -0700)]
src: don't use class specific Unwrap methods
Instead use the template functions in util.h.
Trevor Norris [Tue, 29 Oct 2013 19:49:53 +0000 (12:49 -0700)]
src: don't use WeakObject::Unwrap
Switch out to use UnwrapObject from util.h.
Trevor Norris [Tue, 29 Oct 2013 19:27:24 +0000 (12:27 -0700)]
src: use function to get internal pointer
Remove the NODE_{WRAP,UNWRAP} macros and instead use template functions.
Trevor Norris [Tue, 27 Aug 2013 18:30:06 +0000 (11:30 -0700)]
node: don't share state with in_tick/last_threw
There was no need to share state between C++ and JS for these two
values. So they have been moved to their respective locations. This will
help performance only a tiny bit, but it does help code complexity much
more.
Scott Blomquist [Tue, 29 Oct 2013 19:49:41 +0000 (12:49 -0700)]
doc: Update documentation to reflect ObjectWrap changes
Scott Blomquist [Tue, 29 Oct 2013 18:43:31 +0000 (11:43 -0700)]
win: fix ObjectWrap for latest v8
We need to keep ObjectWrap around for module authors (we think), but
v8 3.21 broke node_object_wrap.h with respect to MSVC. Coincidentally,
we no longer use ObjectWrap at all in core, and native modules might
as well use their own entirely internal implementation if they need it.
Scott Blomquist [Thu, 24 Oct 2013 20:10:43 +0000 (13:10 -0700)]
src: Remove unused refs to node_object_wrap.h
Turns out that we don't use node_object_wrap.h any more in core,
and, with v8 3.21, it's breaking our Windows build. Removing refs
to it everywhere (and adding node.h in one case where it was the
only way node.h was being included), we have restored the Windows
build.
Thom Seddon [Fri, 4 Oct 2013 11:59:38 +0000 (12:59 +0100)]
src: accept passphrase when crypto signing with private key
Previous behaviour was to drop to an openssl prompt
("Enter PEM pass phrase:") when supplying a private key with a
passphrase. This change adds a fourth, optional, paramter that
will be used as the passphrase.
To include this parameter in a backwards compatible way it was
necessary to expose the previously undocumented (and unexposed)
feature of being able to explitly setting the output encoding.
Trevor Norris [Mon, 28 Oct 2013 21:58:37 +0000 (14:58 -0700)]
dgram: send() can accept strings
Strings passed to Socket#send() will be passed to Buffer and parsed as
UTF8.
isaacs [Mon, 28 Oct 2013 21:12:00 +0000 (14:12 -0700)]
Merge remote-tracking branch 'ry/v0.10'
isaacs [Mon, 28 Oct 2013 21:10:47 +0000 (14:10 -0700)]
npm@1.3.13
isaacs [Sat, 26 Oct 2013 01:56:25 +0000 (18:56 -0700)]
vm: Copy missing properties from context
This addresses a current shortcoming of the V8 SetNamedPropertyHandler
function.
It does not provide a way to intercept Object.defineProperty(..) calls.
As a result, these properties are not copied onto the contextified
sandbox when a new global property is added via either a function
declaration or a Object.defineProperty(global, ...) call.
Note that any function declarations or Object.defineProperty() globals
that are created asynchronously (in a setTimeout, callback, etc.) will
happen AFTER the call to copy properties, and thus not be caught.
The way to properly fix this is to add some sort of a
Object::SetNamedDefinePropertyHandler() function that takes a callback,
which receives the property name and property descriptor as arguments.
Luckily, such situations are rare, and asynchronously-added globals
weren't supported by Node's VM module until 0.12 anyway. But, this
should be fixed properly in V8, and this copy function should be removed
once there is a better way.
Fix #6416
Ben Noordhuis [Mon, 28 Oct 2013 12:44:41 +0000 (13:44 +0100)]
http: remove MethodToString()
The list of supported HTTP methods is available in JS land now so there
is no longer any need to pass a stringified version of the method to the
parser callback, it can look up the method name for itself.
Saves a call to v8::Eternal::Get() in the common case and a costly
v8::String::NewFromOneByte() in the uncommon case.
Ben Noordhuis [Mon, 28 Oct 2013 12:35:33 +0000 (13:35 +0100)]
http: expose supported methods
Expose the list of supported HTTP methods as a property on the 'http'
module object.
Fixes #6422.
Phillip Alexander [Sat, 26 Oct 2013 20:13:56 +0000 (13:13 -0700)]
doc: fs: clarify fs.symlink Windows specific args
Ryan Graham [Sat, 26 Oct 2013 05:03:02 +0000 (22:03 -0700)]
doc: improve module documentation
Expands on when to use module.exports vs. exports. This is a recurring
question on mailing list and continues to confuse new devs.
Sam Roberts [Fri, 25 Oct 2013 20:16:50 +0000 (13:16 -0700)]
doc: fix missing backtick in 2e16037
Timothy J Fontaine [Fri, 25 Oct 2013 18:26:05 +0000 (11:26 -0700)]
Merge remote-tracking branch 'upstream/v0.10'
Conflicts:
ChangeLog
deps/uv/ChangeLog
deps/uv/include/uv-darwin.h
deps/uv/src/unix/fsevents.c
deps/uv/src/unix/process.c
deps/uv/src/version.c
doc/api/addons.markdown
doc/api/cluster.markdown
doc/api/http.markdown
lib/http.js
lib/tls.js
src/node_crypto.cc
src/node_http_parser.cc
src/node_version.h
src/pipe_wrap.cc
src/v8abbr.h
src/v8ustack.d
test/simple/test-http-pipeline-flood.js
Brian White [Thu, 24 Oct 2013 02:43:23 +0000 (22:43 -0400)]
doc: streams: document default objectMode setting
Maxim Bogushevich [Tue, 22 Oct 2013 07:27:02 +0000 (17:27 +1000)]
debugger: Fix bug in sb() with unnamed script
setBreakpoint() cause error when unnamed script is loaded
isaacs [Thu, 24 Oct 2013 16:21:59 +0000 (09:21 -0700)]
npm@1.3.12
Ben Noordhuis [Wed, 23 Oct 2013 11:42:53 +0000 (13:42 +0200)]
build: fix test-gc weakref build rule
Make the build rule depend on the build artifact (weakref.node) itself
rather than the directory it's built in. Depending on the directory
means that a build failure won't trigger a rebuild on the next
invocation because the directory's timestamp has been updated.
This is a back-port of commit 1189571 from the master branch that
hopefully fixes the following CI error:
executing: make test/gc/node_modules/weak/build/
make: *** No rule to make target `test/gc/node_modules/weak/build/'.
Command exited with non-zero: make test/gc/node_modules/weak/build/
Build step 'Execute NodeJS script' marked build as failure
Zarko Stankovic [Thu, 12 Sep 2013 18:13:32 +0000 (20:13 +0200)]
doc: add nodejs.rs to the community page
isaacs [Wed, 23 Oct 2013 20:08:06 +0000 (13:08 -0700)]
http client: pull last chunk on socket close
When the socket closes, the client's http incoming message object was
emitting an 'aborted' event if it had not yet been ended.
However, it's possible, when a response is being repeatedly paused and
resumed (eg, if piped to a slow FS write stream), that there will be a
final chunk remaining in the js-land buffer when the socket is torn
down.
When that happens, the socketCloseListener function detects that we have
not yet reached the end of the response message data, and treats this as
an abrupt abort, immediately (and forcibly) ending the incoming message
data stream, and discarding that final chunk of data.
The result is that, for example, npm will have problems because tarballs
are missing a few bytes off the end, every time.
Closes GH-6402
Ben Noordhuis [Wed, 23 Oct 2013 11:45:57 +0000 (13:45 +0200)]
test: fix up weakref.cc after v8 api change
Ben Noordhuis [Wed, 23 Oct 2013 11:42:53 +0000 (13:42 +0200)]
build: fix test-gc weakref build rule
Make the build rule depend on the build artifact (weakref.node) itself
rather than the directory it's built in. Depending on the directory
means that a build failure won't trigger a rebuild on the next
invocation because the directory's timestamp has been updated.
Ben Noordhuis [Tue, 22 Oct 2013 22:17:45 +0000 (15:17 -0700)]
src: update after v8 api changes
Timothy J Fontaine [Tue, 22 Oct 2013 22:14:25 +0000 (15:14 -0700)]
v8: upgrade 3.21.18.3
Ben Noordhuis [Wed, 23 Oct 2013 11:25:35 +0000 (13:25 +0200)]
src: IsInt64() should return bool, not int
isaacs [Tue, 22 Oct 2013 17:56:03 +0000 (10:56 -0700)]
blog: HTTP server DoS vulnerability details
CVE-2013-4450
Timothy J Fontaine [Fri, 18 Oct 2013 22:46:02 +0000 (15:46 -0700)]
blog: Post for v0.10.21
Timothy J Fontaine [Fri, 18 Oct 2013 22:43:55 +0000 (15:43 -0700)]
blog: Post for v0.8.26
Timothy J Fontaine [Fri, 18 Oct 2013 22:40:32 +0000 (15:40 -0700)]
Now working on 0.10.22
Timothy J Fontaine [Fri, 18 Oct 2013 22:39:56 +0000 (15:39 -0700)]
Merge branch 'v0.10.21-release' into v0.10
Timothy J Fontaine [Fri, 18 Oct 2013 21:26:27 +0000 (14:26 -0700)]
2013.10.18, Version 0.10.21 (Stable)
* uv: Upgrade to v0.10.18
* crypto: clear errors from verify failure (Timothy J Fontaine)
* dtrace: interpret two byte strings (Dave Pacheco)
* fs: fix fs.truncate() file content zeroing bug (Ben Noordhuis)
* http: provide backpressure for pipeline flood (isaacs)
* tls: fix premature connection termination (Ben Noordhuis)
Timothy J Fontaine [Fri, 18 Oct 2013 21:14:21 +0000 (14:14 -0700)]
crypto: clear errors from verify failure
OpenSSL will push errors onto the stack when a verify fails, which can
disrupt TLS and other routines if we don't clear the error stack
Fixes #6304
Timothy J Fontaine [Fri, 18 Oct 2013 20:52:15 +0000 (13:52 -0700)]
uv: Upgrade to v0.10.18
Patrik Stutz [Thu, 17 Oct 2013 00:11:19 +0000 (02:11 +0200)]
http: add statusMessage
Now the status message can be set via req.statusMessage = 'msg';
isaacs [Wed, 16 Oct 2013 19:57:46 +0000 (12:57 -0700)]
http: provide backpressure for pipeline flood
If a client sends a lot more pipelined requests than we can handle, then
we need to provide backpressure so that the client knows to back off.
Do this by pausing both the stream and the parser itself when the
responses are not being read by the downstream client.
Backport of 085dd30
Timothy J Fontaine [Mon, 14 Oct 2013 18:57:45 +0000 (11:57 -0700)]
http_parser: expose pause/resume method for parser
Sam Roberts [Fri, 26 Jul 2013 01:17:38 +0000 (18:17 -0700)]
doc: cluster documentation cleanup and corrections
- fixed some incomprehensible wording ("event assigned to..."?)
- removed undocumented and unnecessary process properties from example
- corrected the docs on the default for the exec setting
- described when workers are removed from cluster.workers
- described addressType, which was documented as existing, but not what
values it might have
- spell out more clearly the limitations of setupMaster
- describe disconnect in sufficient detail that why a child does or does
not exit can be understood
- clarify which cluster functions and events are available on process or
just on the worker, as well as which are not available in children,
- don't describe events as the same, when they have receive different
arguments
- fix misleading disconnect example: since disconnect already calls
close on all servers, doing it again in the example is a no-op, not
the "force close" it was claimed to be
- document the error event, not catching it will kill your node
- describe suicide better, it is important, and a bit unintuitive
(process.exit() is not suicide?)
- use worker consistently throughout, instead of child.
Sam Roberts [Fri, 26 Jul 2013 00:35:21 +0000 (17:35 -0700)]
doc: child_process corrections and cleanups
- Make explicit that .disconnected is set before the disconnect event,
and it is not allowed to send messages after calling .disconnect(),
even while waiting for a delayed disconect event.
- Remove obsolete claim that explicit exit is required
- Describe silent: in the options for fork()
- Describe .connected as the property it is, not just as an aside in
the disconnect() method
Fedor Indutny [Wed, 16 Oct 2013 16:57:26 +0000 (20:57 +0400)]
cpplint: disallow if one-liners
Fedor Indutny [Wed, 16 Oct 2013 16:34:39 +0000 (20:34 +0400)]
cpplint: disallow comma-first in C++
Ben Noordhuis [Tue, 15 Oct 2013 11:01:23 +0000 (13:01 +0200)]
dns: set hostname property on error object
Make debugging and logging easier: when a DNS lookup for a hostname
fails, set the hostname as a property on the error object.
Fixes #5393.
Ben Noordhuis [Tue, 15 Oct 2013 10:51:12 +0000 (12:51 +0200)]
dns: rename domain to hostname
A follow-up commit will save the domain name on the request object but
we can't call that property 'domain' because that gets intercepted by
src/node.cc and lib/domain.js to implement the node.js feature of the
same name.
To avoid confusion, rename all variables called 'domain' to 'hostname'.
Ben Noordhuis [Wed, 16 Oct 2013 00:54:24 +0000 (02:54 +0200)]
debugger: fix SIGUSR1 bootstrap race condition
Before this commit, the SIGUSR1 signal handler wasn't installed until
late in the bootstrapping process and we were prone to miss signals
sent by other processes.
This commit installs an early-boot signal handler that merely records
the fact that we received a signal. Once the debugger infrastructure
is in place, the signal is re-raised, kickstarting the debugger.
Among other things, this means that simple/test-debugger-client is
now _much_ less likely to fail.
Ben Noordhuis [Tue, 15 Oct 2013 21:32:18 +0000 (23:32 +0200)]
debugger: make busy loops SIGUSR1-interruptible
Commit
30e5366b ("core: Use a uv_signal for debug listener") changed
SIGUSR1 handling from a signal handler to libuv's uv_signal_*()
functionality to fix a race condition (and possible hang) in the
signal handler.
While a good change in itself, it made it impossible to interrupt
long running scripts. When a script is stuck in a busy loop, control
never returns to the event loop, which in turn means the signal
callback - and therefore the debugger - is never invoked.
This commit changes SIGUSR1 handling back to a normal signal handler
but one that treads _very_ carefully.
isaacs [Thu, 10 Oct 2013 22:00:05 +0000 (15:00 -0700)]
http: provide backpressure for pipeline flood
If a client sends a lot more pipelined requests than we can handle, then
we need to provide backpressure so that the client knows to back off.
Do this by pausing both the stream and the parser itself when the
responses are not being read by the downstream client.
Fix GH-6214
Timothy J Fontaine [Sun, 13 Oct 2013 00:47:35 +0000 (17:47 -0700)]
http_parser: expose pause/resume method for parser
Jason Gerfen [Tue, 15 Oct 2013 14:31:14 +0000 (08:31 -0600)]
doc: crypto: document SPKAC additions
Document the SPKAC functionality that was added in commit 7bf46ba.
Jason Gerfen [Thu, 10 Oct 2013 20:24:53 +0000 (13:24 -0700)]
crypto: add SPKAC support
Implements new class 'Certificate' within crypto object for working
with SPKAC's (signed public key & challenge) natively.
Ben Noordhuis [Wed, 16 Oct 2013 10:32:47 +0000 (12:32 +0200)]
doc: http: reword IncomingMessage 'close' event
The bit that says "before response.end() was called or able to flush"
doesn't apply to incoming streams.
Fixes #6359.
Ben Noordhuis [Wed, 16 Oct 2013 10:20:25 +0000 (12:20 +0200)]
doc: http: add cross-links for easier clicking
Make it a little easier to navigate the http module documentation by
turning class names and methods into links to the appropriate section.
isaacs [Tue, 15 Oct 2013 22:59:05 +0000 (15:59 -0700)]
Revert "doc: crypto: document SPKAC additions"
This reverts commit
aa94450b31a28d6251df3b88fdd652ddd1e67a69.
isaacs [Tue, 15 Oct 2013 22:58:58 +0000 (15:58 -0700)]
Revert "crypto: add SPKAC support"
This reverts commit
7f66e44dc1e90e7abda2a9ed02d7e8163e1f6358.
Jason Gerfen [Tue, 15 Oct 2013 14:31:14 +0000 (08:31 -0600)]
doc: crypto: document SPKAC additions
Document the SPKAC functionality that was added in commit 7f66e44.
Ben Noordhuis [Tue, 15 Oct 2013 08:01:50 +0000 (10:01 +0200)]
doc: expand os.loadavg() section
Add a short explanation of what the load average is and why it's
unavailable on Windows.
Also sneak in a fix for a typo that I introduced in commit 56c5806.
Ben Noordhuis [Mon, 14 Oct 2013 11:15:00 +0000 (12:15 +0100)]
doc: document os.loadavg() behavior on windows
The load average is a very UNIX-y concept. That's why os.loadavg()
always returns zeros on Windows. Mention that in the documentation.
Jason Gerfen [Thu, 10 Oct 2013 20:24:53 +0000 (13:24 -0700)]
crypto: add SPKAC support
Implements new class 'Certificate' within crypto object for working
with SPKAC's (signed public key & challenge) natively.
Rod Vagg [Tue, 15 Oct 2013 01:26:18 +0000 (12:26 +1100)]
util: format as Error if instanceof Error
Ben Noordhuis [Mon, 14 Oct 2013 09:38:53 +0000 (11:38 +0200)]
cluster: fix premature 'disconnect' event
Don't emit the 'disconnect' event until all workers have gone away.
Before this commit, the event was emitted when all open handles were
closed, which usually - but not always - amounts to the same thing.
Fixes #6346.
Ben Noordhuis [Mon, 14 Oct 2013 09:07:14 +0000 (11:07 +0200)]
cares_wrap: remove superfluous 'this' keyword
Trevor Norris [Fri, 4 Oct 2013 03:43:35 +0000 (20:43 -0700)]
lint: fix a cpplint error
Added a NOLINT so that cpplint won't complain about some code.
Trevor Norris [Fri, 11 Oct 2013 18:44:56 +0000 (11:44 -0700)]
buffer: add buf.toArrayBuffer() API
Trevor Norris [Fri, 11 Oct 2013 18:11:36 +0000 (11:11 -0700)]
buffer: check data is not null
Because it's possible for the data within a Buffer instance to be
altered after instantiation, or in case a user attempts to do something
like the following:
Buffer.prototype.fill.call({}, 10, 0, 10);
It doesn't result in a segfault.
Glen Mailer [Wed, 11 Sep 2013 16:18:25 +0000 (17:18 +0100)]
assert: indicate if exception message is generated
AssertionError.generatedMessage is now true when
AssertionError.message was generated from expected and actual
Fixes #5836, #6206
Dave Pacheco [Thu, 10 Oct 2013 16:41:59 +0000 (09:41 -0700)]
test: use proper findjsobjects output format
Closes #6329
Ben Noordhuis [Thu, 10 Oct 2013 12:34:15 +0000 (14:34 +0200)]
doc: net: remove bad net.Server description
net.Server is not an instance of net.Socket so don't say it is.
Ben Noordhuis [Thu, 10 Oct 2013 12:09:38 +0000 (14:09 +0200)]
doc: addon: fix object instantiation examples
* Extend examples to show how to handle non-constructor invocation in
constructor callback functions.
* Fix up examples to initialize member variables at object construction.
* Fix up a few naming inconsistencies.
Fixes #5701.