Update Android PPM sample application for latest base code.

- Modify findResource api(connectivity type)

Change-Id: I78a79144d02e7089220b6927037a0e2b6b8b4bae
Signed-off-by: YounghyunJoo <yh_.joo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2048
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>

File formatting for PPM source code

Applied source code formatting for PPM code

Change-Id: I4c71da133477820388c2c17bb6c1bc4cf3ca4af0
Signed-off-by: YounghyunJoo <yh_.joo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2045
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>

resource-encapsulation: update container bundle resource

- update soft sensor resource to get input data
- modify soft sensor bundle example and configuration file

Change-Id: I9deb7669db33b8464d135a7133184067966fe84b
Signed-off-by: Markus Jung <markus.jung@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2021
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Hun-je Yeon <hunje.yeon@samsung.com>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>

Modify resourceCache Unittest code

- modify DataCache handler type which is low pointer to shared_ptr on the dataCache for updated DataCache code
- add unittest execute option(TEST) into the SConscript file
- remove useless comments
- set code format

Change-Id: I69d22561d0d028b624c5f836e9b8bdd1cdaa44e6
Signed-off-by: YounghyunJoo <yh_.joo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2043
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>

Refactoring for RemoteResourceObject

Refine code of RCSRemoteResourceObject, RCSDiscoveryManager and the unittests for them.
Also add new logger macro for scope logging.
Public exception classes are now located in RCSException header.

Change-Id: I20862491e05c21e2a0a5f608a9c615ebd734ed56
Signed-off-by: coderhyme <jhyo.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2038
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>

Modify PPM linux Sample Application&plugins SConscript for convenience of verify

- use copy factory to copy configuration files to proper output direcotry

Change-Id: I6fb408b0f4691ed502de4af63a9d1172c08815b7
Signed-off-by: YounghyunJoo <yh_.joo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2039
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>

[Resource-Encapsulation] improving unittest
- adding more functions
- modification for existing functions

Change-Id: I898221305bac3c2e2779ecca9f836a8fac57f627
Signed-off-by: Rami Jung <rami.jung@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2041
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>

Fix issues revealed by -Wextra flag.

Fix assorted warnings raised by the -Wextra flag, including
a few significant items. Reduced local build warnings from
over 9200 warnings to about 650.

At least one unicast send routine would drop all errors due
to type issues.

Change-Id: I9d8c90f83ccc89d9fba809f303ccf42b96c0eb82
Signed-off-by: Jon A. Cruz <jonc@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2018
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

removed fragmentation logic in EDR adapter.

I have removed unnecessary logic called fragmentation
in EDR adapter.
it doesn't need anymore,
because Blockwise-transfer was enabled.

Change-Id: I18a3c73b10cf9ad078558263f6661edad36f9397
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1864
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

updated the code related to descriptor of BLE in android

As there are some issue in BLE core as per platform,
I have modified the code of android to support
BLE for Tizen(2.3/2.4) to Android and
Android to Arduino, Android to Android.
- Tizen 2.4 is not support to get
  PROPERTY_NOTIFY through descriptor.
- Arduino have to use Descriptor for PROPERTY_NOTIFY

Change-Id: I4c552b2ee3cb3cf7d5eb17d2e5b2cceda84eb4f2
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1813
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Removed C++11 specific code from the CSDK, added platform_features

The CSDK provides some nice-to-have Constructors when compiling
some POD types.  The code erronously used C++11's 'default' keyword,
which isn't available on older compilers.  Since C++11/0x is not a
requirement for the CSDK, this disables the constructors in the case
where C++11/0x is not enabled.

In order to do this, it adds a platform_features.h, which should be used
to selectively compile things based on features (rather than based on
the platform name itself)

Change-Id: Ie8b9a5e9b5d6424fd8a1f37cfdbd587f665c2638
Signed-off-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2036
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>

Fixed a few SonarQube identified issues

JniListenerManager tried to modify its list inside of a for-loop,
which causes undefined behavior.  2 spots where there was un-initialized
variables.

Change-Id: I5da2cd39cef1dadcd05c743d8fc5e0db0a8f2679
Signed-off-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2033
Reviewed-by: Tim Kourt <tim.a.kourt@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>

Fixed Android EDR Crash issue.

Prevent global variable memory leak.

Change-Id: I08b75fcfb4a4ed5554e96e9d1a8772f072e7b8b8
Signed-off-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2017
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>

Removed vestigial automatic download of BlueZ.

The IoTivity Linux BLE transport no longer relies on headers found in
the BlueZ source distribution, such as <bluetooth/hci.h>, since it no
longer uses the kernel Bluetooth management API for LE advertising
related tasks.  LE advertising operations are now handled entirely
through BlueZ D-Bus API method calls.

Change-Id: I64ef5faac2fdac7aa15e2091b9a3bf44b786e1e5
Signed-off-by: Ossama Othman <ossama.othman@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2031
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Fixed a large amount of memory leaks/ Null pointer dereferences

This fix goes through nearly 200 issues discovered by Klocwork
and fixes a variety of null pointer dereferences and memory leaks.

Change-Id: Ic6c741872b5fb5a9e432636552dab815c4f1f96c
Signed-off-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1979
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ossama Othman <ossama.othman@intel.com>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>

[Jira IOT-604] Fix error handling from message handler

This is a specific case where error hadling is not handled
Fixed the error in the send thread

Change-Id: I3f4d1983d379550ee6e72d95b9341da847fce47a
Signed-off-by: jnashok <jn.ashok@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1871
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Modify PPM Sample Application & Plugins for updated base code

- Change CA connectivity type(CA_DEAFULT)
- Fix some errors on plugins

Change-Id: Idcb2d2dfb77f1c9e98686161e6989d6b96367ac4
Signed-off-by: YounghyunJoo <yh_.joo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2022
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

[Resource encapsulation]Add check logic about whether cached resource exists or not.

Throw exception when getCachedData() is requested for non-cached resource.
Add interface for checking cached resource existence.
Mutex for attributes is moved into the class member variable.

Change-Id: I25a163bf6900dd23f14158f28808873059798845
Signed-off-by: jyong2.kim <jyong2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2024
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

[Resource Encapsulation]Clean up code on ResourceCache.

fix typing error.

Change-Id: I081f149e6fa38890afc8982655f0bdfcf1caac58
Signed-off-by: jyong2.kim <jyong2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2015
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Habib Virji <habib.virji@samsung.com>
Tested-by: Habib Virji <habib.virji@samsung.com>

Modify resourceCache codes to synchronize the cacheDataList and to avoid retransmission

- add std::mutex for synchronization of cacheDataList valuable
- add lastSequenceNum valuable to avoid retransmission

Change-Id: I19cc85084d916b91f359ca116e1b3ef69db2150b
Signed-off-by: YounghyunJoo <yh_.joo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2019
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Habib Virji <habib.virji@samsung.com>
Tested-by: Habib Virji <habib.virji@samsung.com>

[Resource-Encapsulation]  compaction by reusing the definition of 'constexpr char KEY[]'

Change-Id: Ibfd7ad1cbf82652c6e30c584be5e0a920b44a228
Signed-off-by: Rami Jung <rami.jung@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1985
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>

Implemented Linux BLE transport.

This is an implementation of the proposed OIC Bluetooth Low Energy
transport for Linux.

Change-Id: Id105a1d7a86c59d41900c6e4b0fc1b0a60b97c75
Signed-off-by: Ossama Othman <ossama.othman@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1125
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Update 'resource broker' unit test code.

1. whether is called timeoutCB correctly or not when is occurred timeover about 'subscribe' request.
2. whether is called subscribeCB correctly or not when is request 'subscribe'.
3. whether is called timeoutCB correctly or not when is occurred timeover about 'get' request.

and, modify some bug.
this bug is not occurred problem at previous version.but correct this point in order to upgrade our unitTest'
performance.

add license comment and delete white space.

add api for 'device presence' in order to get device_state' value.

Change-Id: Ib265c6d529f84610cf134808bc5581377340bec6
Signed-off-by: doil.kwon <doil.kwon@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1987
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>

Fixed arduino server sending notifications after deregister.

This fixes IOT-627.
Arduino server continuted to send observe notifications even after
client deregisters. This happened because a bool variable tracking if
light was under observation was not set to false.

Change-Id: Ic1f00915632251a9be8772ca3cc4b71373dc3b18
Signed-off-by: Mandeep Shetty <mandeep.shetty@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2011
Reviewed-by: Omkar Hegde <omkar.m.hegde@intel.com>
Reviewed-by: Joseph Morrow <joseph.l.morrow@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Fixed unprocessed timed-out messages in the stack.

The portion of messages in the retransmission queue did not have the
resourceUri. As a result timed-out messages when reported back to the RI
layer did not have the resource uri which failed a check on entry into
the RI layer.

This caused the server to not de-register observers and it continued to
send observation notifications to a client that is not reachable.

Removed the check for the resource uri to fix the issue.
Added check for presence of uri before comparing it with the presence
uri so presence responses can be handled separately.

This also fixes IOT-622.

Change-Id: Ie3873d02f4163b81094ca1983e79315b85ff4751
Signed-off-by: Mandeep Shetty <mandeep.shetty@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1995
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Omkar Hegde <omkar.m.hegde@intel.com>
Reviewed-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Added null checks post cbor processing.

This allows requests with null parameters to still operate.

This fixes IOT-632.

Change-Id: I6b7b1a48e1d50d34268e1f0fface38b5fd59cb02
Signed-off-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1993
Reviewed-by: Tim Kourt <tim.a.kourt@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

updated the logic to combining block1 and block2 option

- fixed IOT-637 issue
  Both the request and response may be large enough to
  require the use of blockwise-transfer.
  In this case, we should use the block1 and block2 option together.

- fixed IOT-635 issue
  if a lot of ports is enable in IP adapter.
  Token of CoAP can be used as blockID of BlockData set
  since all messages have same Token in multicast
  so Token + port have to be used.

- fixed klocworks data leak issue
  in CAAddBlockSizeOption, option is created, but the actual option
  doesn't have anything done with it.

Change-Id: I82808856c76cfd343c71460e303744b002d9a745
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1873
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>

Fixed a merge of OcConnectivityType and OcConnectivityFlags
throughout the android stack

A small Android API change was introduced as part of the merge: all discovery
calls now take a Set of OcConnectivtyTypes instead of a single enum.

In addition, it fixes a setHeaderOptions bug.

Change-Id: Ib269e39a0168055b4a1f46353cbd620fbff1dbad
Signed-off-by: Tim Kourt <tim.a.kourt@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1992
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Adding -Wextra to builds using -Wall in order to catch problems that
were being missed.

Change-Id: I4bf0ae091aa2c3da255a9c07b2290f32abf2d0f0
Signed-off-by: Jon A. Cruz <jonc@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1978
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

[ARDUINO] Fixed send data failure in IP adapter

Change-Id: I8f3cbd6414fca8f92e22f5d3d7ce8c3eebcb4b71
Signed-off-by: vimala.v <vimala.v@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1975
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Corrected a criticial OICRealloc() bug and a few misc issues.

- Fixed a problem wither OICRealloc() where it was returning the
 old pointer instead of the sometimes-different new one.

- Removed some code duplication in #if/#else blocks.

- Fixed split declarations and later assignment. This step was the
 one that made the OICRealloc() bug immediately visible.

- Updated OICFree() counting to match that in OICMalloc(), except
 for the case of failed mallocs.

Change-Id: Ibdf8949d57e72821f0fea9e5c8ca607503ff14dc
Signed-off-by: Jon A. Cruz <jonc@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1982
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Doug Hudson <douglas.hudson@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Fix broken macros in octypes.h

Eliminate 16-bit definition of OCConnectivityType.
Repair macros used to build OCConnectivityType.

Change-Id: Ia1ff69f6bdab5d8d728cb33ea633a4ba9c3912d7
Signed-off-by: John Light <john.j.light@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1977
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Copy all items of CBOR string array

CBOR String array is coping only the first item.
Fix OCREP_PROP_STRING for string array to copy all items by
calling cbor_value_advance.

Change-Id: I1ea80e94cf21f746188af81dd946c474d8b00ba4
Signed-off-by: Sakthivel Samidurai <sakthivel.samidurai@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1990
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Update Log message for "resource Broker".

it will be shown when is called its related function.
and can be shown more detail(ex: the moment when is found item).
modify log message existing previously.
all log message will be shown before its related action' excution.
also delete white space.

Change-Id: Ibaf2c611ce17bb4635ebd6c68f530d5cc8a40b37
Signed-off-by: doil.kwon <doil.kwon@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1983
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>

updating build instructions for casample

this helps in fixing some build problems

Change-Id: I4f424cfa8c4af6304d7da55c7b2947f3dfdbfebc
Signed-off-by: jnashok <jn.ashok@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1973
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Clean up some SonarQube warnings (trailing whitespace, etc).

Clean up trailing whitespace and removed Windows line endings from
most text files to address SonarQube warnings.  As a side effect of
this clean-up, several files that should not have been executable had
their executable permission bit removed.

Change-Id: Ie388df6e383219cdebfb56ba8fa86cacf2ca3e46
Signed-off-by: Ossama Othman <ossama.othman@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1980
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Fix invalid memory access on resource cache module.

invalidate callback in deleted instance.

Change-Id: Ica3028700935c0cef062719a43affc5f4754a336
Signed-off-by: jyong2.kim <jyong2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1972
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Younghyun Joo <yh_.joo@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

RI Sample for Tizen

working RI Sample for Tizen

Change-Id: Idba74286734d2159b128ddde55cc588bbb19cbea
Signed-off-by: vimala.v <vimala.v@samsung.com>
Signed-off-by: koushik.girijala <g.koushik@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1719
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Abhishek Sharma <ce.abhishek@samsung.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Modify resourceCache unittest buildscript to fix gcc bug

- on gcc-4.6 in linux 64bit environment, gcc bug is occurred.
  To fix it, remove the '-Wnoexcept' option in the SConscript file
- additionally, remove constructor, destructor on the unittest class
  to prevent build error(noexcept tag) on gcc-4.8

Change-Id: I411ca979e607cdfe33ea50f9fe32b88b434320ed
Signed-off-by: YounghyunJoo <yh_.joo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1970
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>

Modify DataCache code files to support thread synchronization

- add thread synchronization for the subscriberList
- modify notifyObservers()'s parameter to const variable

Change-Id: I13e18a56be2ec2f6e7e4c0eadc371161dc6b5f3b
Signed-off-by: YounghyunJoo <yh_.joo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1949
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Hun-je Yeon <hunje.yeon@samsung.com>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>

Fix a callback problem of PrimitiveResource

The problem was calling the callback even after the object for it was gone.
PrimitiveResource is only created with shared_ptr and callbacks are async operations.
When received the response, there is a possibility that no one holds the resource.

Now checks the object is alive before executing the callback.

Change-Id: I07b20d251c2b8544e7d27f354193b53c910d579c
Signed-off-by: coderhyme <jhyo.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1950
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>

modified comment for doxygen.

Fixed several files with out of date or
incorrect doxygen comments

Change-Id: Iddd76b6aed32de74c819d3794e6845401561bae5
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1939
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>

modified Sconscript in Blockwise transfer

- BWT was not enabling in multiple selection case.
  ex) TARGET_TRANSPORT=BLE,IP
- added PDU null checker. (fixed IOT-647 issue)

Change-Id: I2ea5439d57cae63e128d8afb1b2ff519e914c9ce
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1925
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Add License notification to unit test codes of resource encapsulation

Insert License notification to Unit test codes

Change-Id: I7440b9f26147116f4f46644970b71309329400af
Signed-off-by: hunje.yeon <hunje.yeon@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1947
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>

Add new resource property 'EXPLICIT_DISCOVERABLE'

Some resources (such as, SVR's) needs to be discovered only when
explicitly requested. This property allows the resource to be included
in discovery response only when explicitly requested via query filters.

Change-Id: I1adeffa0996ecf36ffdd9ebd3dbf9c32d9f3cc0d
Signed-off-by: Sachin Agrawal <sachin.agrawal@intel.com>
Signed-off-by: Sakthivel Samidurai <sakthivel.samidurai@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1680
Reviewed-by: Joseph Morrow <joseph.l.morrow@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>

Doxygen: Statement end with period ('.')

Change-Id: Ie023e6be66c739c701509a6365237e659205d6d3
Signed-off-by: sandipan.p <sandipan.p@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1934
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Abhishek Sharma <ce.abhishek@samsung.com>
Reviewed-by: Abhishek Pandey <abhi.siso@samsung.com>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>

Including RCS prefix in ResourceContainer class name

Change-Id: Icc1c47349687911ed8ad878e6b0d546e177769a8
Signed-off-by: Markus Jung <markus.jung@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1945
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>

Fix set command line options for ANDROID_XXX into scons environment.

Due to this the android SDK, NDK and Gradle were downloaded even if
the options are specified on commandline.

Change-Id: I00564d62c8374b73f3b4b75b7d75735d0a49f16f
Signed-off-by: Ashwini Kumar <k.ashwini@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1513
Reviewed-by: Joseph Morrow <joseph.l.morrow@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

expanding the coverage of testing RCSResourceObject.cpp

It calls both
addAttributeUpdatedListener(const std::string& key,AttributeUpdatedListener h)
addAttributeUpdatedListener(const std::string&& key,AttributeUpdatedListener h)

Change-Id: Ic46f85104fb4887515af9745b3dc11b3d90b9516
Signed-off-by: Rami Jung <rami.jung@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1938
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Hun-je Yeon <hunje.yeon@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

[Resource-Encapsulation] Modified Sample Application

Change-Id: If5c5e1118d9a423a4e7eb1611ac80f431bab0f20
Signed-off-by: Jay Sharma <jay.sharma@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1941
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Hun-je Yeon <hunje.yeon@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Cleaning unused mutex variables for receiver handler.

Server Receiver Handler and Client Receiver Handler are
optimized and merged to a single function CALEDataReceiverHandler.

Change-Id: I633da97c4f6f1ff38efa3c81559223f51316de41
Signed-off-by: sandipan.p <sandipan.p@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1942
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Naga Ashok Jampani <jn.ashok@samsung.com>
Reviewed-by: Ossama Othman <ossama.othman@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>

update android sample app

I have added some log for port number
since there is no way to know it.

Change-Id: I306d0d94ae1523d9de948465ec303d503111ff2f
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1846
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
Reviewed-by: Abhishek Pandey <abhi.siso@samsung.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Modify resourceCache to handle datacache releasing exception

- catch release exception using try-cache
- clarify the exception discription of resourceCache

Change-Id: I865fc111c1fd8df05fb4e875109b339e99b744f8
Signed-off-by: YounghyunJoo <yh_.joo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1937
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>

Modify ResourcePresenceUnitTest Code

- There is Segmentation fault because it is used 'weak pointer' without non-pre used 'shared pointer'.
so ResourcePresence instance's type is changed 'low pointer' to 'shared pointer'

- ResourcePresence's logic was chaging. so UnitTest's logic was changing(used mocking api's order and number)

Change-Id: Ic7ab6ae24b4b7bcb671d11728d16d0031842e002
Signed-off-by: doil.kwon <doil.kwon@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1935
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>

Update ResourceCache Unittest code files

Change-Id: Ic5dab8f0f90fad94f464c68b5ae608415547ed2b
Signed-off-by: YounghyunJoo <yh_.joo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1931
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>

Update Doxygen path for Resource-Encapsulation

Update header path of resource-encapsulation APIs in Doxyfile.
Fix broken API links of RCSDiscoveryManager, RCSRemoteResourceObject

Change-Id: I34671cbbde69fe0e1d616f1a789261ce28a41da6
Signed-off-by: hunje.yeon <hunje.yeon@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1930
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

Fixing segmentation fault if container is started without configuration file.
https://jira.iotivity.org/browse/IOT-633

Change-Id: I3559719cf084e462260da55d0b54d0848767e09c
Signed-off-by: Markus Jung <markus.jung@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1926
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

Resource Manipulation: resolve Jira issue IOT-641.

Prevent calling incorrect OC::Platform method.

Change-Id: Ie08b578ac04b768bdcb9404c557749a37acaaf41
Signed-off-by: jyong2.kim <jyong2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1921
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Hun-je Yeon <hunje.yeon@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Fixed warning due to incorrect type and comparison order.

Change-Id: Ifb4a7c644c5599888b74895429eb2296ab2c9f57
Signed-off-by: Jon A. Cruz <jonc@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1900
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: JungYong KIM <jyong2.kim@samsung.com>
Reviewed-by: Hun-je Yeon <hunje.yeon@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

[Resource-Encapsulation] Splitted Resource Client to 2 files

- RCSDiscoveryManager and RCSRemoteResourceObject

Change-Id: Iccf1aae4100eba313127fad33dd2adb8bb6bec64
Signed-off-by: Jay Sharma <jay.sharma@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1914
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Hun-je Yeon <hunje.yeon@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

[Resource Encapsulation] Updated Discover API of Resource Client for RCSAddress

- updated Resource Client, sample, UnittestCases
- added more Exception to Resource Client

Change-Id: Ib91934b372efe23f7a657152a63a9dd7aa5d06ce
Signed-off-by: Jay Sharma <jay.sharma@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1905
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Removed noexcept(true) descrutor from test classes

Change-Id: Ibbb00a3b84f33545b7ab441c6f985216a00150d9
Signed-off-by: Markus Jung <markus.jung@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1906
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Rename ResourceAttributes to RCSResourceAttributes

Prefix is added for consistency for exposed headers.

Change-Id: I4b038fe5fdd79bfbc6d5b8963491332a180b77a4
Signed-off-by: coderhyme <jhyo.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1893
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Rename BundleInfo to RCSBundleInfo and ResourceContainer to RCSResourceContainer

Prefixes are added for consistency for exposed headers as a part of API.

Change-Id: Ia968888331f27210e2c8ec00f3859ddadf3e2844
Signed-off-by: coderhyme <jhyo.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1892
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Rename ResourceObject to RCSResourceObject

Prefix is added for consistency for exposed headers

Change-Id: I8366dba5f404089237ac4b16f19a498a2179356c
Signed-off-by: coderhyme <jhyo.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1891
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Add a comparison helper class for ResourceAttributes::Value

The hepler class is needed to avoid implicitly converting and comparing raw values,
because ResourceAttributes::Value has implicit constructors to make it easy to use.

Change-Id: Ie72524d9000f930e01e63b0f0e0384295ed4f41d
Signed-off-by: coderhyme <jhyo.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1890
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

BLE De-fragmentation changes and optimization for receiver handler

Change-Id: If2217589eb7538018fa9e4e79ee55cd3bb52aed8
Signed-off-by: sandipan.p <sandipan.p@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1410
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Abhishek Sharma <ce.abhishek@samsung.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>

[Resource-Manipulation] Renamed Resource-Manipulation to Resource-Encapsulation

Change-Id: I2520ee961d6556b26c3ba52be8e6d16238615d30
Signed-off-by: Jay Sharma <jay.sharma@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1888
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Modify UnitTest Code about "Resource Broker"

- Modify inherit class : "Test" class -> "TestWithMock" class
- Support 4.6, 4.7, 4.8 gcc compiler

Change-Id: Ie4de09086ba737033f17f5d87bf1a809019351b6
Signed-off-by: doil.kwon <doil.kwon@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1878
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

resource-manipulation: rcs_common.so add missing depending library

rcs_common.so is also depending on liboc.so and libpthread.so, this
patch adds these dependencies to the build.
Add LIBPATH to make sure the libs will be found, this fixes a problem
in some jenkins tests.

Without this the dynamic loader will not automatically load these
libraries and it could result in unresolved dependencies at runtime.

Change-Id: I753c5ec2d35876c789d93d843542344257f44c54
Signed-off-by: jyong2.kim <jyong2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1883
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>

csdk: libconnectivity_abstraction.so: add missing depending library

libconnectivity_abstractionso depends on libcoap.so and librt.so when
build as shared lib, which is the case for the Tizen build. This patch
adds these dependencies to the build.

Without this the dynamic loader will not automatically load these
libraries and it could result in unresolved dependencies at runtime.

Change-Id: Ib972be2b766d7fbccac9b246ae6f11e6182af94c
Signed-off-by: Hauke Mehrtens <hauke.mehrtens@lantiq.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1825
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>

Update UnitTest Code about "Resource Cache"

- Modify inherit class : "Test" class -> "TestWithMock" class
- Support 4.8 gcc compiler

Change-Id: I0d7f279c178a14eaef1b465ce3bce80253c97dae
Signed-off-by: YounghyunJoo <yh_.joo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1880
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Remove "define variables" on Notification Manager.

change anonymous namespace variables from define variables.
change macro to function in OIC::Service namespace.

Change-Id: I9d1e2a8d23d92b190b3255d21434c84efe359c73
Signed-off-by: jyong2.kim <jyong2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1875
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

resource-manipulation: libserver_builder.so add missing depending library

libserver_builder.so is also depending on liboc.so and
librcs_common.so, this patch adds these dependencies to the build.

liboctbstack.so is only needed when LOGGING=true is set. Without
liboctbstack.so libserver_builder.so misses the dependencies to the
OCLog and OCLogv symbols.
Add LIBPATH to make sure the libs will be found, this fixes a problem
in some jenkins tests.

pthread is added two times, once should be enough.

Without this the dynamic loader will not automatically load these
libraries and it could result in unresolved dependencies at runtime.

Change-Id: I6af126eb4af975b7231d01df922885c7dec5fc56
Signed-off-by: Hauke Mehrtens <hauke.mehrtens@lantiq.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1799
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

soft-sensor-manager: libSSMCore.so: add missing depending library

libSSMCore.so also depends on libdl.so, this patch adds these
dependencies to the build.

Without this the dynamic loader will not automatically load these
libraries and it could result in unresolved dependencies at runtime.

Change-Id: I76faff46fe96caef75fb6673c7e83d62b15b8489
Signed-off-by: Hauke Mehrtens <hauke.mehrtens@lantiq.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1796
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

things-manager: libTGMSDKLibrary.so: add missing depending library

libTGMSDKLibrary.so also depends on liboc.so, liboctbstack.so and
pthread, this patch adds these dependencies to the build.

Without this the dynamic loader will not automatically load these
libraries and it could result in unresolved dependencies at runtime.

Change-Id: I174b38e747be247fc25544db629f8ad2b7eb5ef5
Signed-off-by: Hauke Mehrtens <hauke.mehrtens@lantiq.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1795
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Update ResourceObject Class.

Doxygen comments for ResourceObject.
Implement feature of autoNotify about if Attribute is deleted.
And add unit test about that case.

Change-Id: I03974b098c13d6d71a1dc209f5a7d41b289274aa
Signed-off-by: Heewon Park <h_w.park@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1866
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Update UnitTest Code about "Resource Broker"

- Modify inherit class : "Test" class -> "TestWithMock" class
- Support 4.8 gcc compiler

Modify TestCase for DevicePresenceUnitTest.

Change-Id: Ia7ff55abc186c9dc388803ac967ed37c5d89ed73
Signed-off-by: doil.kwon <doil.kwon@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1843
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Fix invalid memory access on resource broker module.

remove the duplicated memory access on list.
invalidate callback in deleted instance.
delete useless member variable on ResourcePresence class.

Change-Id: If6b3831fa2355140b23efdafc213615280e336ac
Signed-off-by: jyong2.kim <jyong2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1844
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: kwon doil <doil.kwon@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Require explicit scons argument (containerJavaSupport=1) to include Java related code in resource container.

Further, added a fix of the ResoureContainerTest to be compatible with gcc 4.6. Removed virtual override usage.
More uniform API for whole resource-encapsulation module (using const string refererences).
Use test helper class to avoid gcc version problems.

Change-Id: I338ee7a7305a83f70babb7b07f9a542644f0c111
Signed-off-by: Markus Jung <markus.jung@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1838
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>

build: make build fail if unresolved symbols found

gcc links shared libs also when there are still some unresolved
symbols, you have to specify it explicitly to make it fail in such
cases. I think a compiler should fail in such cases otherwise
someone will add some not intended dependencies or some existing
dependencies are not getting declared.

This patch makes gcc fail in such cases. I have only activated this for
libs build in a Linux build and explicitly deactivates it for windows
(does this even work at all?) This should be build tested with Android
also.

This was build tested for Linux and Android.

This patch depends on some other patches I send which are fixing the
problems I found with this change.

Change-Id: I9ab79896ca2e86e9226cd9b39060a0763ef89694
Signed-off-by: Hauke Mehrtens <hauke.mehrtens@lantiq.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1802
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Reviewed-by: Hun-je Yeon <hunje.yeon@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Modify service/SConscript file to support PPM for Android platform.

Change-Id: I6708ec0a2d69f0e0f974abfa81df62b27cd6575b
Signed-off-by: YounghyunJoo <yh_.joo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1842
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Update comments for ResourceAttributes

Now, ResourceAttributes has appropriate comments for doxygen

Change-Id: I4a8f3f8881117c4cb91a0d871e0549faa66bd047
Signed-off-by: coderhyme <jhyo.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1849
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Corrected files with doxygen comments that were generating warnings.

Fixed several files with out of date or incorrect doxygen comments.
These included use of explicit tags (@fn, @var, @struct, etc.),
incorrect use of "[IN]" and "[OUT]", and other issues.

Aside from the problems actually marked in the output as warnings,
these issues were causing a large portion of the documentation to
be dropped silently.

Change-Id: I66027f4f98a6e82b7db826693b5ec1b1f30e58cf
Signed-off-by: Jon A. Cruz <jonc@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1836
Reviewed-by: Erich Keane <erich.keane@intel.com>
Reviewed-by: Ossama Othman <ossama.othman@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

Fixed doxygen comments in camutex.h

Fixed problems with doxygen comments that included a few causing
outright errors and missing functions in the resulting
documentation.

- Removed use of '@' on local names instead of Doxygen keywords
 which were causing errors.

- Prefixed '::' to types and enums that were not recongnized.

- Fixed typo in enum name

- Added missing periods at end of brief/summary prose.

Change-Id: I2731d9d5ebf10f738e387a1922027fb752a8a3be
Signed-off-by: Jon A. Cruz <jonc@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1834
Reviewed-by: Erich Keane <erich.keane@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

Corrected @file doxygen commands that had explicit filenames that
were not valid.

Removed the explicit filename from @file doxygen commands where
the filenames were invalid and causing warnings. (In general the
@file command should be used by itself, with no explicit filename)

Change-Id: I0c3e3392b172c8760e0a281f0c3b293050bedabc
Signed-off-by: Jon A. Cruz <jonc@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1835
Reviewed-by: Erich Keane <erich.keane@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

Fixed CA linux sample bug for bulk data

we have to create text file for bulk data only.
so I fixed the condition for data size check.

Change-Id: I96f9441e475dbe67729391e29571cdb8ab443e21
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1847
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Updated discovery response when filter query does not match.

Iotivity should respond to discovery requests in below manner:
If query filter matching fails (or if Server does not have
any DISCOVERABLE resources) and discovery request is multicast,
it should NOT send any response.
But, if the discovery request is unicast in above scenario,
it should send an error(RESOURCE_NOT_FOUND - 404) response with
empty payload.

Currently, Iotivity stack sends a response in all error scenarios
with return code as OC_EH_OK (along with some payload) which has
various drawbacks, such as, causes un-necessary traffic in the network
and also wastes power on constrained devices.

Change-Id: Ibb3bedc7b8ae67b708b89e9ad747c031ab552cae
Signed-off-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1766
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Changing resource "URL" to "URI"

We were logging the resource URI as URL which
was ambiguous for the test team.

Change-Id: I90e862cc35f3c1fd3ec2f3a95950668fb45d0134
Signed-off-by: Omkar Hegde <omkar.m.hegde@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1861
Reviewed-by: Erich Keane <erich.keane@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Joseph Morrow <joseph.l.morrow@intel.com>

Finalizing CI build script changes.

This commit effectively only affects the Integration/Validation build.
This had to be done in steps to not break any of the ongoing pre-[build
script overhaul] work that were already in their merge-into-master
validation stages.

Change-Id: I3c32df57d526f7a34847a96f48814fd31f79e4fc
Signed-off-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1859
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

liboc: add missing depending library

liboc.so depends on liboctbstack.so, liboc_logger.so and pthread, this
patch adds these dependencies to the build.

Without this the dynamic loader will not automatically load these
libraries and it could result in unresolved dependencies at runtime.

Change-Id: I971b45669adef31dc9cca719884ebeb74aaf735e
Signed-off-by: Hauke Mehrtens <hauke.mehrtens@lantiq.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1794
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Eliminate warning about const mismatch in caipadapter (IOT-632)

Change-Id: I9c5afff53ded18b01467c0426c24876b219d7a34
Signed-off-by: John Light <john.j.light@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1858
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

csdk: remove dependency to liboc_logger.so in c code

The liboc_logger.so is only used by the c++ part and not by the c part,
remove it from the c only part.

Change-Id: Ib0894974de8ef7150401f02fbd0ea864d1d6f2cd
Signed-off-by: Hauke Mehrtens <hauke.mehrtens@lantiq.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1801
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Charlie Lenahan <charlie.lenahan@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Removing unnecessary logs in message handler.

The "IN" and "OUT" tags give no useful information
and completely floods the debug mode. All the useful
information is already being logged within the function.

Change-Id: Ieac528913b659fbaccedcb465000f11f370b678a
Signed-off-by: Omkar Hegde <omkar.m.hegde@intel.com>
Signed-off-by: vimala.v <vimala.v@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1816
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Fix memory leak on OCDoResource

OCDoResource was leaking the generated payload each time, so
this fixes the issue by ensuring it is free'd at the end.

Change-Id: I693318bdcb6d7baa37a5397fab33b0fe4c784960
Signed-off-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1821
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

Clean up CBOR payload in Arduino sample app.

This effectively keeps Arduino server from crashing when it receives
+24 requests. Services bug IOT-484
(https://jira.iotivity.org/browse/IOT-484).

Change-Id: I1b651e560d935bc71c1b8a3aa5062c2162e313f7
Signed-off-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1824
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Fix Tizen Build

Hopefully fixes the Tizen build

Change-Id: Ic202729f4d6a571cfad18724da27e5295258a1e2
Signed-off-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1854
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

Modify resourceCache Unittest code for gcc 4.6 version

remove override tag on the each test code.

Change-Id: I8a22c442c65a3f9099cbb9adcf6e40a518c4fd56
Signed-off-by: YounghyunJoo <yh_.joo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1837
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

resource-manipulation: add unittest for container

- add unittest for dynamic bundle loading and resource registration
- update sample bundle used for unittest

Change-Id: I9a59ecd5cbd49a8adbff703d58c0cb72ff58687a
Signed-off-by: Minji Park <minjii.park@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1839
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

resource-manipulation: Fix some typo errors

Fixed some typo in resource-manipulation scons script.

Change-Id: I64099f8b7d1ec18954e13d177b47d5c5cd73bfc8
Signed-off-by: Ravi Nanjundappa <nravi.n@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1773
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>