platform/core/multimedia/libmm-utility.git
6 years agoChange the parameter order of internal functions 84/172184/1
Jiyong Min [Mon, 12 Mar 2018 10:31:42 +0000 (19:31 +0900)]
Change the parameter order of internal functions
(set input parameter before output parameter)

Change-Id: I274aae2dba1d1461d324062b81ae061cc905176c

6 years agoRemove jpeg decoding/encoding with turbo API because it is not stable 83/172183/1
Jiyong Min [Mon, 12 Mar 2018 10:27:01 +0000 (19:27 +0900)]
Remove jpeg decoding/encoding with turbo API because it is not stable

Change-Id: I59683cf0d608b0f782b23966f7479744bbcd1a7e

6 years agoreading & writing png code refactoring 74/171874/3
Jiyong Min [Thu, 8 Mar 2018 01:30:16 +0000 (10:30 +0900)]
reading & writing png code refactoring

Change-Id: I213c8c0f7b4475d1864d50410a1202b221e4d6b1
Signed-off-by: Jiyong Min <jiyong.min@samsung.com>
6 years agoreading & writing bmp code refactoring 05/171705/5
Jiyong Min [Wed, 7 Mar 2018 00:22:03 +0000 (09:22 +0900)]
reading & writing bmp code refactoring

Change-Id: I0078b61fe5e8cc42220231e78153f1f4bc8be4b4
Signed-off-by: Jiyong Min <jiyong.min@samsung.com>
6 years agoUse size_t for buffer size 76/171676/2
hj kim [Tue, 6 Mar 2018 10:25:06 +0000 (19:25 +0900)]
Use size_t for buffer size

Change-Id: I7bf0dad5063003c69f17874d4df6b18869614114

6 years agoUnify the type of the buffer size from 'unsigned int'/'unsigned long' to 'size_t' 71/171671/2
Jiyong Min [Tue, 6 Mar 2018 09:44:00 +0000 (18:44 +0900)]
Unify the type of the buffer size from 'unsigned int'/'unsigned long' to 'size_t'

Change-Id: Ibbc37e0c3b5efde47c3d546fe10716c2b2292142
Signed-off-by: Jiyong Min <jiyong.min@samsung.com>
6 years agoChange the order of the parameters 82/171582/3
Jiyong Min [Tue, 6 Mar 2018 04:52:46 +0000 (13:52 +0900)]
Change the order of the parameters

 - The order is input parameter before output parameter.
 - The decoded data is composed with width, height, format, data and size.
 - The source data of encoding is replaced to the decoded data.

Change-Id: Idf1de7e1515d5e5bc25e375031f81faaacdc07ba
Signed-off-by: Jiyong Min <jiyong.min@samsung.com>
6 years agoRemove unused function 81/171581/1
Jiyong Min [Tue, 6 Mar 2018 04:48:05 +0000 (13:48 +0900)]
Remove unused function

Change-Id: I36d02b3c97227c6d1e6bea87662d9e4dfef29ccf
Signed-off-by: Jiyong Min <jiyong.min@samsung.com>
6 years agoMerge "Fix typo and TAINTED_INT svace issue" into tizen
Jiyong Min [Tue, 6 Mar 2018 04:44:53 +0000 (04:44 +0000)]
Merge "Fix typo and TAINTED_INT svace issue" into tizen

6 years agoBuild error fix 79/171579/1 accepted/tizen/unified/20180307.071315 submit/tizen/20180305.053300
hj kim [Tue, 6 Mar 2018 04:21:41 +0000 (13:21 +0900)]
Build error fix

Change-Id: I16f46edb65f3eb4808b68400bbc32139102cb309

6 years agoFix typo and TAINTED_INT svace issue 71/171571/1
Jiyong Min [Tue, 6 Mar 2018 01:17:48 +0000 (10:17 +0900)]
Fix typo and TAINTED_INT svace issue

Change-Id: I71664d4f8cdf26e85371231873c8170add4474ea
Signed-off-by: Jiyong Min <jiyong.min@samsung.com>
6 years agoCode Refactoring for testsuite 94/171494/3
Jiyong Min [Mon, 5 Mar 2018 06:33:22 +0000 (15:33 +0900)]
Code Refactoring for testsuite

 - mm_util_bmp_testsuite
 - mm_util_jpeg_testsuite
 - mm_util_png_testsuite

Change-Id: I21b4f457152d9a5b1f20b8aa23c7cfbbaf0d9723
Signed-off-by: Jiyong Min <jiyong.min@samsung.com>
6 years agoCode Refactoring - wrong parameter usages 86/171286/2
Jiyong Min [Wed, 28 Feb 2018 07:35:04 +0000 (16:35 +0900)]
Code Refactoring - wrong parameter usages

Change-Id: Ic48a798223eb64b817302520a26a63320b24fc31
Signed-off-by: Jiyong Min <jiyong.min@samsung.com>
6 years agoCode Refactoring - remove unneccessary extern function 32/171232/1 submit/tizen/20180228.025609
Jiyong Min [Wed, 28 Feb 2018 00:16:30 +0000 (09:16 +0900)]
Code Refactoring - remove unneccessary extern function

Change-Id: Idbffd3ce9337a9b73e4a06b35a736f7b5ef2ab0d
Signed-off-by: Jiyong Min <jiyong.min@samsung.com>
6 years agoCode Refactoring - remove inefficient functions to set PNG value 31/171231/1
Jiyong Min [Tue, 27 Feb 2018 23:33:03 +0000 (08:33 +0900)]
Code Refactoring - remove inefficient functions to set PNG value

Change-Id: I72a46e6ed9fa264a283ec1805751db5f5a6422fa
Signed-off-by: Jiyong Min <jiyong.min@samsung.com>
6 years agoCode Refactoring - remove unused PNG progressive decoding 28/171228/4
Jiyong Min [Tue, 27 Feb 2018 23:24:37 +0000 (08:24 +0900)]
Code Refactoring - remove unused PNG progressive decoding

Change-Id: I235a533f148b3dee407dd5a319c10be873e6d2e3
Signed-off-by: Jiyong Min <jiyong.min@samsung.com>
6 years agoRemove abnormal free the decoded buffer to fix crash issue 18/171018/1 accepted/tizen/unified/20180226.142324 submit/tizen/20180223.061228
Jiyong Min [Mon, 26 Feb 2018 00:47:21 +0000 (09:47 +0900)]
Remove abnormal free the decoded buffer to fix crash issue

Change-Id: I01da12ea31669cd9da1e572f52cea99d4eb3642d
Signed-off-by: Jiyong Min <jiyong.min@samsung.com>
6 years agoChange unsigned int to size_t for buffer_size 97/170897/3
hj kim [Fri, 23 Feb 2018 05:11:21 +0000 (14:11 +0900)]
Change unsigned int to size_t for buffer_size

Change-Id: Iefcb87e8a4d834602a9689be5061d5cb8d13bf0d

6 years agoChange unsigned int to size_t for buffer_size 67/170867/3
hj kim [Fri, 23 Feb 2018 02:43:05 +0000 (11:43 +0900)]
Change unsigned int to size_t for buffer_size

Change-Id: Idb5e77b25a02d8ad53f7ada899f365c75be747ec

6 years agoUnify __mm_image_encode_to_jpeg_memory_with_libjpeg() and __mm_image_encode_to_jpeg_f... 16/170816/2
hj kim [Thu, 22 Feb 2018 09:07:33 +0000 (18:07 +0900)]
Unify __mm_image_encode_to_jpeg_memory_with_libjpeg() and __mm_image_encode_to_jpeg_file_with_libjpeg() to __mm_image_encode__with_libjpeg()

Change-Id: I77b3edc39c39218be412f7ef9a5574406722188a

6 years agoUnify __mm_image_decode_from_jpeg_file_with_libjpeg() and __mm_image_decode_from_jpeg... 85/170785/1
hj kim [Thu, 22 Feb 2018 05:59:50 +0000 (14:59 +0900)]
Unify __mm_image_decode_from_jpeg_file_with_libjpeg() and __mm_image_decode_from_jpeg_memory_with_libjpeg() to __mm_image_decode_with_libjpeg()

Change-Id: I200d2f08eb0eebe234fa058e4b4c3d9b650b7cfb

6 years agoRemove mm_util_decode_from_jpeg_memory() and mm_util_decode_from_jpeg_file() API... 27/170727/2
hj kim [Thu, 22 Feb 2018 01:08:22 +0000 (10:08 +0900)]
Remove mm_util_decode_from_jpeg_memory() and mm_util_decode_from_jpeg_file() API. because those are almost same as _with_downscale() API

Change-Id: I113bb58a73153d91c0d08c602e4c5283dbc996a4

6 years agoCode Refactoring - remove unused jpeg code 31/170731/3
Jiyong Min [Thu, 22 Feb 2018 01:23:11 +0000 (10:23 +0900)]
Code Refactoring - remove unused jpeg code

 - remove unused define and variables
 - change #ifdef LIBJPEG_TURBO boundary
 - use common ROUND_UP_X & ROUND_DOWN_X for imgp & jpeg

Change-Id: I0fd96993b1e5802a42c9a34b17c027d2c25f35d5
Signed-off-by: Jiyong Min <jiyong.min@samsung.com>
6 years agoModify mm_util_convert_colorspace() API to receive allocated buffer and buffer info 68/170668/1
hj kim [Wed, 21 Feb 2018 08:59:01 +0000 (17:59 +0900)]
Modify mm_util_convert_colorspace() API to receive allocated buffer and buffer info

Change-Id: I606b2789a900cbb78cfc01d38aef2e54d9667e25

6 years agoJust update debug msg 08/170608/3
hj kim [Wed, 21 Feb 2018 04:53:44 +0000 (13:53 +0900)]
Just update debug msg

Change-Id: I1fca7f465ad81e9dfad44d1fca11e729f3118c07

6 years agoModify mm_util_resize_image() API to receive allocated buffer and buffer info 53/170453/3
hj kim [Tue, 20 Feb 2018 06:10:46 +0000 (15:10 +0900)]
Modify mm_util_resize_image() API to receive allocated buffer and buffer info

Change-Id: I46bcdf8ef91f999cdddab5415d1daa5d371425c3

6 years agoModify mm_util_rotate_image() API to receive allocated buffer and buffer info 23/170423/3
hj kim [Tue, 20 Feb 2018 04:25:25 +0000 (13:25 +0900)]
Modify mm_util_rotate_image() API to receive allocated buffer and buffer info

Change-Id: Ie4bf988dc07230b2a0f66c7ce1a8d335434c8128

6 years agoAdd missing modification for imagesize replacement 75/170575/1
Jiyong Min [Wed, 21 Feb 2018 01:07:28 +0000 (10:07 +0900)]
Add missing modification for imagesize replacement

Change-Id: I4179839c22ba116d3b18fdfa607fd34e0251ed5a
Signed-off-by: Jiyong Min <jiyong.min@samsung.com>
6 years agoModify the range of 'imgsize' from 'unsigned int' to 'Size_t' 26/170426/2 submit/tizen/20180220.054545
Jiyong Min [Tue, 20 Feb 2018 05:05:23 +0000 (14:05 +0900)]
Modify the range of 'imgsize' from 'unsigned int' to 'Size_t'
(fix 64bit error)

Change-Id: I440601c12e34cfae2ca8cf75580bb5990bd24d86
Signed-off-by: Jiyong Min <jiyong.min@samsung.com>
6 years agochange dst_buf_size to res_buffer_size 92/170392/2 submit/tizen/20180220.014003
hj kim [Mon, 19 Feb 2018 23:59:52 +0000 (08:59 +0900)]
change dst_buf_size to res_buffer_size

Change-Id: I9e351f40cbd1aead859684111358e2649dd2474c

6 years agoRemove useless code. only RGB format can be round up in current gstreamer code 58/170358/1
hj kim [Mon, 19 Feb 2018 09:56:30 +0000 (18:56 +0900)]
Remove useless code. only RGB format can be round up in current gstreamer code

Change-Id: Ibfe95c1e38edc14bd601f1d02bc60c4ff3842213

6 years agoRemove useless buffer calcurate code 52/170352/1
hj kim [Mon, 19 Feb 2018 09:31:52 +0000 (18:31 +0900)]
Remove useless buffer calcurate code

Change-Id: Ic32cf33c9acad51cebeadee457e3fcec04cf499b

6 years agoJust update debug msg 46/170346/2
hj kim [Mon, 19 Feb 2018 08:49:11 +0000 (17:49 +0900)]
Just update debug msg

Change-Id: Ie1f91df536342038ea6eb5d7a0e4168241286d15

6 years agoModify mm_util_crop_image() API to receive allocated buffer and buffer info 38/170338/2
hj kim [Mon, 19 Feb 2018 08:07:12 +0000 (17:07 +0900)]
Modify mm_util_crop_image() API to receive allocated buffer and buffer info

Change-Id: If059b7e93e7a13bbb859e58d64d92c45c62674ed

6 years agoAdd to calculate the buffer size for NV21 colorsapce 12/170312/4 submit/tizen/20180219.051103
Jiyong Min [Mon, 19 Feb 2018 04:33:39 +0000 (13:33 +0900)]
Add to calculate the buffer size for NV21 colorsapce

Change-Id: I25da32e7cf667b58bfb1d5e4018b154043a848c0

6 years agoAdd safe_fopen safe_fclose to check realpath and remove useless code 65/170165/5
Jiyong Min [Wed, 14 Feb 2018 02:02:19 +0000 (11:02 +0900)]
Add safe_fopen safe_fclose to check realpath and remove useless code

Change-Id: Ib1d743adcb196e77d6b9409e2572d6f54762aef4

6 years agoFix test code and update some debug msg 84/170184/2
hj kim [Wed, 14 Feb 2018 05:10:29 +0000 (14:10 +0900)]
Fix test code and update some debug msg

Change-Id: I89a04243847ca46a645bba1474263e96df6511e6

6 years agoAdd code to check color format before doing transform. and remove useless code of... 51/170151/2
hj kim [Wed, 14 Feb 2018 00:31:18 +0000 (09:31 +0900)]
Add code to check color format before doing transform. and remove useless code of convert format check

Change-Id: Iada70374163342893c1c58c3d839a4d4fcf4ec5f

6 years agoRemove useless format_label 85/170085/2
hj kim [Tue, 13 Feb 2018 08:12:28 +0000 (17:12 +0900)]
Remove useless format_label

Change-Id: I8aa9106709c771c6a058070ea95d4619c18dfc68

6 years agoCode Refactoring: apply unified color format 52/169652/5 accepted/tizen/unified/20180214.144545 submit/tizen/20180212.075159
Jiyong Min [Thu, 8 Feb 2018 06:34:05 +0000 (15:34 +0900)]
Code Refactoring: apply unified color format

 - Add 'mmutil_common' library for using all
 - Replace color interface 'mmutil_imgp' to 'mmutil_common' library
 - Unify color formats
 - Remove unused replacement in spec file
 - Remove unused 'format' parameter of internal crop function

Change-Id: I308e484b90b958e870959214215c8f649b68e698

6 years agoRemove memory allocation code. because mm_imgp is changed to do alloc memory 43/169543/1
hj kim [Wed, 7 Feb 2018 09:01:30 +0000 (18:01 +0900)]
Remove memory allocation code. because mm_imgp is changed to do alloc memory

Change-Id: Icd030f536ab7c842845ec8f26fe47c4c18dc52e5

6 years agoCode refactoring. unify duplicated code 60/169460/1
hj kim [Wed, 7 Feb 2018 04:34:43 +0000 (13:34 +0900)]
Code refactoring. unify duplicated code

Change-Id: I64069b9568c59a9bfc306029dd3f10f644e65c31

6 years agoRemove unused functions and gif/png dependency of header 41/169341/4
Jiyong Min [Tue, 6 Feb 2018 05:42:50 +0000 (14:42 +0900)]
Remove unused functions and gif/png dependency of header

Change-Id: I1f05c9814b20decac56757e67196b7dd2aee54fe

6 years agoAdd to check installed libraries of libbmp, libnsbmp and libpng and replace the heade... 43/168943/5 accepted/tizen/unified/20180206.064130 submit/tizen/20180205.005408
Jiyong Min [Thu, 1 Feb 2018 09:18:01 +0000 (18:18 +0900)]
Add to check installed libraries of libbmp, libnsbmp and libpng and replace the header of libraries

Change-Id: Iee6ec8819f16d47020545b3b417ae29d6a86a224

6 years agoFix typo 01/169001/1 accepted/tizen/unified/20180202.061005 submit/tizen/20180202.000421
Minje Ahn [Thu, 1 Feb 2018 23:41:29 +0000 (08:41 +0900)]
Fix typo

Change-Id: I92886d9a73e2fc89076604d8fa56a54a6e70df3f
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
6 years agoAdd new API mm_util_extract_image_info() 33/168933/2 accepted/tizen/unified/20180202.060943 submit/tizen/20180201.081645
hj kim [Thu, 1 Feb 2018 07:59:53 +0000 (16:59 +0900)]
Add new API mm_util_extract_image_info()

Change-Id: I788c81943a4ff766a50aa154354f6a996e35852c

6 years agoImprove performance of Resize and Read from /Write to File. 53/168253/9 accepted/tizen/unified/20180131.060525 submit/tizen/20180130.062418
hj kim [Thu, 25 Jan 2018 07:46:13 +0000 (16:46 +0900)]
Improve performance of Resize and Read from /Write to File.

1. Use Sample and Scale API instead of Resize API
2. Apply jpeg Options like dct_method
3. Remove Profiles like IPTC, ICM

Change-Id: I7e54109c5855b6f49e08806586b26ca2d57d3722

6 years agoAdd new convert API using graphickMagicK mm_util_convert_B_B 13/168213/1
hj kim [Thu, 25 Jan 2018 05:06:52 +0000 (14:06 +0900)]
Add new convert API using graphickMagicK  mm_util_convert_B_B

Change-Id: I62fcd62ad171f813d4ef4ec42e88769de451857b

6 years agoAdd the debug mode for GraphicsMagick 06/167906/7
Jiyong Min [Tue, 23 Jan 2018 02:24:34 +0000 (11:24 +0900)]
Add the debug mode for GraphicsMagick

Change-Id: I87cd4c5018d5ce51a8aeaeec66bcaf6e8f78bec6

6 years agochange of debug msg format and update some debug msg 03/167903/4 accepted/tizen/unified/20180124.061556 submit/tizen/20180123.002657
hj kim [Tue, 23 Jan 2018 01:59:32 +0000 (10:59 +0900)]
change of debug msg format and update some debug msg

Change-Id: I88da902696b4ba0222400f5d58e9d530f7c5d3b5

6 years agoAdd new rotate and resize APIs those are use GraphickMagicK 51/166851/13
hj kim [Fri, 12 Jan 2018 06:30:13 +0000 (15:30 +0900)]
Add new rotate and resize APIs those are use GraphickMagicK

Change-Id: I2cb2a02be97fdfebf308733250bf4b236f27340e

6 years agoChange the buffer(memory) parameter of the image for decoding and remove unused code 63/165763/6 accepted/tizen/unified/20180109.172741 submit/tizen/20180108.064644
Jiyong Min [Wed, 3 Jan 2018 23:14:20 +0000 (08:14 +0900)]
Change the buffer(memory) parameter of the image for decoding and remove unused code
(The buffer is used as 'void *', so 'void **' is changed to 'void *'.)

Change-Id: Id1636f5e5550983efd7742205dcce462dc7b5385

6 years agoBug fix of realpath check. File does not exist for some case. so apply realpath only... 24/164224/2 accepted/tizen/unified/20171229.070222 submit/tizen/20171227.043416
hj kim [Mon, 18 Dec 2017 06:37:18 +0000 (15:37 +0900)]
Bug fix of realpath check. File does not exist for some case. so apply realpath only when file exist

Change-Id: I53ab9908425d750a75fca0c76cc081b4d53e671f

6 years agoAdd to check realpath before fopen 91/163391/6 accepted/tizen/unified/20171211.160409 submit/tizen/20171211.080624
Jiyong Min [Mon, 11 Dec 2017 04:04:33 +0000 (13:04 +0900)]
Add to check realpath before fopen

Change-Id: If29fb2f6e731625dd2b69fa3a8db404345bb3b72
Signed-off-by: Jiyong Min <jiyong.min@samsung.com>
6 years agoRemove mm_util_set_hardware_acceleration(). This API doesn't work 00/163100/1
hj kim [Thu, 7 Dec 2017 07:45:26 +0000 (16:45 +0900)]
Remove mm_util_set_hardware_acceleration(). This API doesn't work

Change-Id: Icf8db40cf36b80673fe52bd2a4e6bf3c779a83fb

6 years agoMake files clean up and fixing build error 93/162893/5 submit/tizen/20171207.225809
Jiyong Min [Wed, 6 Dec 2017 04:23:05 +0000 (13:23 +0900)]
Make files clean up and fixing build error

Change-Id: I76c89b0b1ebcbcbdfa77c0c2eee78a1fd986e58f
Signed-off-by: Jiyong Min <jiyong.min@samsung.com>
6 years agoChange 'LIBDIR' to '${LIB_INSTALL_DIR}'(macro) and remove unused configure 83/162683/3 submit/tizen/20171204.084209
Jiyong Min [Tue, 5 Dec 2017 02:02:12 +0000 (11:02 +0900)]
Change 'LIBDIR' to '${LIB_INSTALL_DIR}'(macro) and remove unused configure
(Fix C# TCT failure due to wrong libdir path)

Change-Id: I36ee7b665f2ebf36eb28fbe63d5d67ef805fc77d
Signed-off-by: Jiyong Min <jiyong.min@samsung.com>
6 years agoJust add define 13/162413/1
hj kim [Fri, 1 Dec 2017 02:43:05 +0000 (11:43 +0900)]
Just add define

Change-Id: Ifcd679a3714d80f011507dc10b356162f600a155

6 years agoChange hard coded path to get by using tzplatform API 42/162142/1 accepted/tizen/unified/20171130.113336 submit/tizen/20171130.061035
hj kim [Wed, 29 Nov 2017 08:51:16 +0000 (17:51 +0900)]
Change hard coded path to get by using tzplatform API

Change-Id: I786b53b07e41e44696f912aff556ff3d583332f4

6 years agoApply CMake 19/161719/5
Jiyong Min [Mon, 27 Nov 2017 06:20:37 +0000 (15:20 +0900)]
Apply CMake

Change-Id: If83b3416c06d22f5df1935e7e4a12cf02814f2e2
Signed-off-by: Jiyong Min <jiyong.min@samsung.com>
6 years agoRemove capi-media-tool dependency 58/161558/2
hj kim [Fri, 24 Nov 2017 06:23:24 +0000 (15:23 +0900)]
Remove capi-media-tool dependency

Change-Id: I9d12dbcfffe91cc7bc7d60a9a20085bcaaf9ebc7

6 years agoRemove capi-media-tool dependency & unused libraries 98/161198/3 submit/tizen/20171123.062739 submit/tizen/20171124.024723
Jiyong Min [Wed, 22 Nov 2017 05:53:30 +0000 (14:53 +0900)]
Remove capi-media-tool dependency & unused libraries

Change-Id: I4337e2dbc242fafc7e8683e833b403d8887e9689
Signed-off-by: Jiyong Min <jiyong.min@samsung.com>
6 years agoModify media_packet creation for invalid operation error 11/160411/3 accepted/tizen/unified/20171120.065131 submit/tizen/20171120.011858
Jiyong Min [Thu, 16 Nov 2017 05:28:16 +0000 (14:28 +0900)]
Modify media_packet creation for invalid operation error

[Problem]
Rarely, invalid operation was returned

[Cause]
Because of the difference between tbm buffer and gstreamer buffer,
the size of packet was not same with the size of buffer.

[Solution]
Use smaller size of buffer than others.

Change-Id: I3f32ef0396f26bada0df6dc907777dd325776924
Signed-off-by: Jiyong Min <jiyong.min@samsung.com>
6 years agoModify buffer overflow when image was rotated 84/160384/3
Jiyong Min [Thu, 16 Nov 2017 02:21:14 +0000 (11:21 +0900)]
Modify buffer overflow when image was rotated

[Problem] Crash happen by buffer overflow

[Cause]
The size of the buffer is calculated with width, height and format
The width should be a multiple of 4 or 8, so the size of the buffer is affected from the width.
But the width and the height were swapped for some cases. So the size of the buffer was not correct.

[Solution]
To swap the width and the height is not neccessary. It is removed.

Change-Id: I832b18a50470681588137ace90d0f6178c96a927
Signed-off-by: Jiyong Min <jiyong.min@samsung.com>
6 years agoModify the value returned by transform to return correct error 01/160201/6
Jiyong Min [Wed, 15 Nov 2017 01:18:06 +0000 (10:18 +0900)]
Modify the value returned by transform to return correct error

 + Replace 'media_format_make_writable' to 'media_format_create'
 because 'media_format_make_writable' does not create new media_format_h in some case.

Change-Id: I1292c14104e66beef6ed7c692821179724399e53
Signed-off-by: Jiyong Min <jiyong.min@samsung.com>
6 years agoRemove TTRACE dependency and refine debug msg 32/160032/4
hj kim [Tue, 14 Nov 2017 07:37:58 +0000 (16:37 +0900)]
Remove TTRACE dependency and refine debug msg

Change-Id: I55a3e86fdb1ef01b1016bff3c1cd845193a82d14

6 years agoFix 64bit build error (Replace 'llu' to 'PRIu64') 60/159960/1
Jiyong Min [Tue, 14 Nov 2017 02:43:23 +0000 (11:43 +0900)]
Fix 64bit build error (Replace 'llu' to 'PRIu64')

Change-Id: I9970ba17d5559940ba5115dd63c2e9901eb2450b
Signed-off-by: Jiyong Min <jiyong.min@samsung.com>
6 years agoAdd missing media_packet color to fix that image-util can not support BGRA color 03/159603/1 submit/tizen/20171113.042933 submit/tizen/20171113.231122
Jiyong Min [Fri, 10 Nov 2017 05:52:36 +0000 (14:52 +0900)]
Add missing media_packet color to fix that image-util can not support BGRA color

Change-Id: I2a57d755f3fdc848d5b9cdbe79ae97dbbb878d31
Signed-off-by: Jiyong Min <jiyong.min@samsung.com>
6 years agoCode clean up of TTRACE and modify converting colorspace not working 96/159596/1
Jiyong Min [Fri, 10 Nov 2017 04:50:12 +0000 (13:50 +0900)]
Code clean up of TTRACE and modify converting colorspace not working

 - On the case of converting colorspace, can missed dst_width and dst_height.
   As the result dst_width and dst_height is zero, src_width and src_height
   should be assigned to dst_width and dst_height.

Change-Id: I04c218ae4ac90d6e7aaa829846ff4f3d629784f4
Signed-off-by: Jiyong Min <jiyong.min@samsung.com>
6 years agoCode clean up header files and memory allocations 20/159320/4 submit/tizen/20171110.043613
Jiyong Min [Wed, 8 Nov 2017 07:18:13 +0000 (16:18 +0900)]
Code clean up header files and memory allocations

Change-Id: I958b612a5d56c2ae84a0ee0bd0de7e2fee74aa9a
Signed-off-by: Jiyong Min <jiyong.min@samsung.com>
6 years agoModify the size of the buffer for rotating or cropping image 72/159072/3 accepted/tizen/unified/20171108.063455 submit/tizen/20171107.034519
Jiyong Min [Tue, 7 Nov 2017 01:13:51 +0000 (10:13 +0900)]
Modify the size of the buffer for rotating or cropping image

 - Problem:
   Crash happen when image is rotated or cropped.

 - Cause & Solution:
   Because of removing the get resolution function at 'https://review.tizen.org/gerrit/#/c/158301/'.
   The size of 'dst' buffer is '0'.
   The size of buffer should be calculated by the width and height of source.

Change-Id: I1d87e51648a70504c754f99cca2fd8ce6b378c6d
Signed-off-by: Jiyong Min <jiyong.min@samsung.com>
6 years agoCode clean up of removing unused define, macro and variables 56/158756/1 accepted/tizen/unified/20171103.162253 submit/tizen/20171103.020449
Jiyong Min [Fri, 3 Nov 2017 01:16:44 +0000 (10:16 +0900)]
Code clean up of removing unused define, macro and variables

Change-Id: Ia00a96b050141df12abee7255072b96d7e816c3f
Signed-off-by: Jiyong Min <jiyong.min@samsung.com>
6 years agoModify to get the size of the cropped image and modify to check wrong parameter 77/158477/2
Jiyong Min [Wed, 1 Nov 2017 07:26:32 +0000 (16:26 +0900)]
Modify to get the size of the cropped image and modify to check wrong parameter

Cause: Cropping dosen't use gstreamer but getting the size is based
  on gstreamer. So the size of the cropped image is not matched with
  getting the size by mm_util_get_image_size().

Solution: The function to get the size of cropped image has been added.
  Generally, getting image size should be seperated for libraries.

Change-Id: If8086bf1a03b6fd0a8eb56d94bb05a355d902cb8
Signed-off-by: Jiyong Min <jiyong.min@samsung.com>
6 years agoCode Cleanup unneccessary variables and functions 56/158356/4 accepted/tizen/unified/20171101.064755 submit/tizen/20171101.024016
Jiyong Min [Tue, 31 Oct 2017 08:14:08 +0000 (17:14 +0900)]
Code Cleanup unneccessary variables and functions

 - Remove frames to fix memory leak (decoder supports 1 frame)
 - Remove GIF_ENCODER_V2 define
 - Remove unused functions after frames and define is deleted

Change-Id: Ie279fe4b83e4cb1de7b16b70ec2ac5a82f02df6f
Signed-off-by: Jiyong Min <jiyong.min@samsung.com>
6 years agoFix buffer-overflow issue when image was cropped 01/158301/3
Jiyong Min [Tue, 31 Oct 2017 04:03:08 +0000 (13:03 +0900)]
Fix buffer-overflow issue when image was cropped

Cause: Before image is cropped, the buffer in media packet is allocated.
At this case, the size of cropped image is changed to be multiple by 4.
The size of the buffer in media packet is smaller than the size of cropped image.
So It make buffer-overflow issue.

Solution: It is fixed to allocate the buffer in media_packet after image is cropped.

 - replace media_packet creation to after transform is done.
 - remove unused get_resolution function.
 - add to allocate and free 'handle->dst' buffer to use transform.

Change-Id: I127e7cd45035bd1c5c4277cff835a2e647c65765
Signed-off-by: Jiyong Min <jiyong.min@samsung.com>
6 years agoCode Cleanup for __mm_util_transform_exec 01/158201/3
Jiyong Min [Mon, 30 Oct 2017 09:28:06 +0000 (18:28 +0900)]
Code Cleanup for __mm_util_transform_exec

 - Add function for __mm_util_transform_exec to be simplified

Change-Id: Ie91b1a69c004c1586a4806e5f85a99a9f1ec5f68
Signed-off-by: Jiyong Min <jiyong.min@samsung.com>
6 years agoFix leak and double-free in gif encoding 78/157778/1
Anastasia Lyupa [Thu, 26 Oct 2017 07:35:12 +0000 (10:35 +0300)]
Fix leak and double-free in gif encoding

Not return before free remaining data in mm_util_gif_encode_destroy().
Free gif_file->saved_image after all saved images are freed
in mm_util_gif_encode().

Change-Id: I318049461669d769f6126c395089c56ab2311bc0
Signed-off-by: Anastasia Lyupa <a.lyupa@samsung.com>
6 years agoReplace thread creation before pushing data to async_queue after pushing data to... 67/157067/5 accepted/tizen/unified/20171025.075123 submit/tizen/20171024.105208
Jiyong Min [Mon, 23 Oct 2017 08:22:21 +0000 (17:22 +0900)]
Replace thread creation before pushing data to async_queue after pushing data to async_queue.
(Fix callback not invoked because thread finish with no data)

Change-Id: Id6109637cac8900ff95ad20feef64c037592b284
Signed-off-by: Jiyong Min <jiyong.min@samsung.com>
6 years agoRemove unused variables 91/156791/1
Jiyong Min [Fri, 20 Oct 2017 04:15:58 +0000 (13:15 +0900)]
Remove unused variables

Change-Id: Idcdd18f6d3d28ccf475b493ed39cd03f07ad4351
Signed-off-by: Jiyong Min <jiyong.min@samsung.com>
6 years agoModify to free memory encoded to bmp and add to check return value from fread 33/152933/7 accepted/tizen/unified/20170929.081607 submit/tizen/20170928.093256
Jiyong Min [Wed, 27 Sep 2017 10:36:17 +0000 (19:36 +0900)]
Modify to free memory encoded to bmp and add to check return value from fread
(fix coverity issue)

Change-Id: Id380453efa6a148e900aba38eff78045ac2c9840
Signed-off-by: Jiyong Min <jiyong.min@samsung.com>
6 years agoAdd finishing jpeg decompression due to memory leak 16/149316/4 accepted/tizen/unified/20170920.065524 submit/tizen/20170918.031342
Jiyong Min [Tue, 12 Sep 2017 05:29:49 +0000 (14:29 +0900)]
Add finishing jpeg decompression due to memory leak

 - The libjpeg release memory without stdio manager during compression
   So we should finish decompression before release jpeg source.
   If release jpeg decompression without finishing, jpeg_destroy_decompress makes memory leak.

Change-Id: Ic19ea9935edc0c461c7dcfad7670cd551f0525cc
Signed-off-by: Jiyong Min <jiyong.min@samsung.com>
6 years agoRemove unused parameter, the size of the buffer 96/148796/1 accepted/tizen/unified/20170913.070611 submit/tizen/20170911.075345
Jiyong Min [Mon, 11 Sep 2017 02:08:07 +0000 (11:08 +0900)]
Remove unused parameter, the size of the buffer

Change-Id: I87b6558f36c45250339996e064b1edd5e0b36810
Signed-off-by: Jiyong Min <jiyong.min@samsung.com>
6 years agoChange free to SAFE_FREE 07/147907/1 accepted/tizen/unified/20170907.060419 submit/tizen/20170906.051057
Haejeong Kim [Wed, 6 Sep 2017 04:46:41 +0000 (13:46 +0900)]
Change free to SAFE_FREE

Change-Id: I09f419176a7a3fed9fcb9ff35faee3f9104fb545

6 years agoRemove \n in dlog msg 15/147815/1
Haejeong Kim [Wed, 6 Sep 2017 01:11:28 +0000 (10:11 +0900)]
Remove \n in dlog msg

Change-Id: Id221e729189f4a828778ce89d9ea172902a3015f

6 years agoApply tizen coding rule 21/147521/1 accepted/tizen/unified/20170906.060721 submit/tizen/20170905.045152
Haejeong Kim [Mon, 4 Sep 2017 23:56:25 +0000 (08:56 +0900)]
Apply tizen coding rule

Change-Id: Iab66ccac21b03e0d84eb4a928c204e34ff2e43c1

6 years agoRemove useless exif dependency 88/146288/1 accepted/tizen/unified/20170829.053213 submit/tizen/20170828.073653
Haejeong Kim [Mon, 28 Aug 2017 01:12:45 +0000 (10:12 +0900)]
Remove useless exif dependency

Change-Id: Idba6316c330e4525d1558345eaadf56bd85e8f76

6 years agoModify the number of the pixcel to extract RGB 34/145934/3 accepted/tizen/unified/20170825.163238 submit/tizen/20170824.093048 submit/tizen/20170825.024959
Jiyong Min [Thu, 24 Aug 2017 07:42:05 +0000 (16:42 +0900)]
Modify the number of the pixcel to extract RGB

- The resolution of current frame is image_desc.
And the width, height of gif_image is the with & height of total image.
So the width, height can not be same with current frame.

Change-Id: I362cc07ab26298e6f502d66005f30ab7ac944eba
Signed-off-by: Jiyong Min <jiyong.min@samsung.com>
6 years agoJust remove function name in debug msg 56/145556/2
Haejeong Kim [Wed, 23 Aug 2017 02:30:59 +0000 (11:30 +0900)]
Just remove function name in debug msg

Change-Id: I0e6aeccf0fe53b8a2496ad5de41e11b9da4bd8eb

6 years agoModify to check parameter and return value 87/145587/2
Jiyong Min [Wed, 23 Aug 2017 04:24:20 +0000 (13:24 +0900)]
Modify to check parameter and return value

Change-Id: I9c92d4406b2e1006d914463a05d2b54bf9c61e89
Signed-off-by: Jiyong Min <jiyong.min@samsung.com>
6 years agoformat arguments error fix 53/145553/1
Haejeong Kim [Wed, 23 Aug 2017 02:25:24 +0000 (11:25 +0900)]
format arguments error fix

Change-Id: I1f51fac782400ba3e754c99798162d2374b682c7

6 years agoRefactoring __gif_get_index_in_colormap() function 47/145047/2
Jiyong Min [Mon, 21 Aug 2017 03:38:22 +0000 (12:38 +0900)]
Refactoring __gif_get_index_in_colormap() function

Change-Id: Ie5e664f4829f8c6e609422223ad52c0487dc4607
Signed-off-by: Jiyong Min <jiyong.min@samsung.com>
6 years agoAdd 'const' keyword to fix build warning of internal APIs. 46/145046/2
Jiyong Min [Mon, 21 Aug 2017 03:31:50 +0000 (12:31 +0900)]
Add 'const' keyword to fix build warning of internal APIs.

Change-Id: I8e36198f03a0f46a1dd87e2247bf14723cb645c1
Signed-off-by: Jiyong Min <jiyong.min@samsung.com>
6 years agoReplace system() to g_file_copy() due to exploitable vulnerabilities. 83/144983/6
Jiyong Min [Sun, 20 Aug 2017 23:26:14 +0000 (08:26 +0900)]
Replace system() to g_file_copy() due to exploitable vulnerabilities.

- Please refer to below webpage in detail
- https://www.securecoding.cert.org/confluence/pages/viewpage.action?pageId=2130132

Change-Id: I790a24e92439b73d4c6f43e563fc7da2d317d262
Signed-off-by: Jiyong Min <jiyong.min@samsung.com>
6 years agoAdd require default transforming library for building-block 08/143908/1 accepted/tizen/4.0/unified/20170829.015818 accepted/tizen/unified/20170818.001020 submit/tizen/20170817.011220 submit/tizen_4.0/20170828.100004 submit/tizen_4.0/20170828.110004
Jiyong Min [Mon, 14 Aug 2017 01:15:25 +0000 (10:15 +0900)]
Add require default transforming library for building-block

Change-Id: I1129095424ee3afdf3606b1efa4fa3704b437b98
Signed-off-by: Jiyong Min <jiyong.min@samsung.com>
6 years agoFix build error for 64bit enviroment 27/143427/2 accepted/tizen/unified/20170811.021127 submit/tizen/20170810.034601
Jiyong Min [Thu, 10 Aug 2017 01:54:46 +0000 (10:54 +0900)]
Fix build error for 64bit enviroment

Change-Id: Ie1cc521377a5c0d51e9e38562b1e8250b28e015c
Signed-off-by: Jiyong Min <jiyong.min@samsung.com>
6 years agoAdd testsuite for new version gif encoder(V2) 66/141366/5 submit/tizen/20170804.071846
Jiyong Min [Mon, 31 Jul 2017 06:59:00 +0000 (15:59 +0900)]
Add testsuite for new version gif encoder(V2)

Change-Id: I47b4bf663b3abb66da32698de2a5dc572b118a1d
Signed-off-by: Jiyong Min <jiyong.min@samsung.com>
6 years agoAdd new version gif encoder(V2) 39/141039/11
Jiyong Min [Fri, 28 Jul 2017 00:01:29 +0000 (09:01 +0900)]
Add new version gif encoder(V2)

 - Add new version gif encode api
  It reduce memory usage by encoding gif frame by frame.
  (After fixing capi, old version will be removed.)
 - At new version it support customized color map, disposal mode and tp color.

Change-Id: Ia7a64d77e321c1f89b69525a9e74f92a3f5ee368
Signed-off-by: Jiyong Min <jiyong.min@samsung.com>
7 years agoModify data type for the size of memory(buffer) from 'int' to 'unsigned int' 10/139010/9 accepted/tizen/4.0/unified/20170816.010329 accepted/tizen/4.0/unified/20170816.014131 accepted/tizen/unified/20170719.131949 submit/tizen/20170719.012528 submit/tizen_4.0/20170811.094300 submit/tizen_4.0/20170814.115522 submit/tizen_4.0_unified/20170814.115522
Jiyong Min [Mon, 17 Jul 2017 01:17:42 +0000 (10:17 +0900)]
Modify data type for the size of memory(buffer) from 'int' to 'unsigned int'
(Added to fix svace issue in imgp)

Change-Id: Ic71248e05d76beb68b57885692747c3297f1abf2
Signed-off-by: Jiyong Min <jiyong.min@samsung.com>
7 years ago[SATIZENVUL-952] Add to check that memory was allocated successfully. 12/138612/3
Jiyong Min [Thu, 13 Jul 2017 03:53:20 +0000 (12:53 +0900)]
[SATIZENVUL-952] Add to check that memory was allocated successfully.

Change-Id: I51308a8a1fc980a778cbb5a486548cde17521e7f
Signed-off-by: Jiyong Min <jiyong.min@samsung.com>
7 years agofix invalid format argument types for dlog 36/135136/1 accepted/tizen/unified/20170630.083259 submit/tizen/20170621.064821 submit/tizen/20170622.044226
Haejeong Kim [Wed, 21 Jun 2017 05:13:01 +0000 (14:13 +0900)]
fix invalid format argument types for dlog

Change-Id: I55ac07d824806ee0d95c0e789335bb9c6eeb705e