Zbigniew Jędrzejewski-Szmek [Thu, 14 Mar 2013 02:47:28 +0000 (22:47 -0400)]
fileio: use _cleanup_
Zbigniew Jędrzejewski-Szmek [Thu, 14 Mar 2013 01:59:11 +0000 (21:59 -0400)]
build-sys: link libsystemd-login also against libsystemd-daemon-internal
https://bugs.freedesktop.org/show_bug.cgi?id=62085
/usr/lib/gcc/x86_64-pc-linux-gnu/4.6.3/../../../../lib64/libsystemd-login.so:
undefined reference to `sd_listen_fds'
In
ee465038ce8 'build-sys: break dependency loop between
libsystemd-id128.la and -shared.la', a partial fix was applied, and
the use of functions from libsystemd-id128 was removed from
libsystemd-shared. Nevertheless, fdset.c was still using sd_listen_fds,
so libsystemd-login should be linked against libysystemd-daemon
or libsystemd-daemon-internal.
Tested-by: Elias Probst <mail@eliasprobst.eu>
Michal Sekletar [Tue, 12 Mar 2013 17:22:57 +0000 (18:22 +0100)]
systemctl: remove unused variable
Zbigniew Jędrzejewski-Szmek [Thu, 14 Mar 2013 00:20:54 +0000 (20:20 -0400)]
tmpfiles: add missing missing.h include
mbiebl> src/tmpfiles/tmpfiles.c:221:13: error: ‘MAX_HANDLE_SZ’
undeclared (first use in this function)
Fixup for
427b47c4abaf4b5.
Zbigniew Jędrzejewski-Szmek [Wed, 13 Mar 2013 23:40:01 +0000 (19:40 -0400)]
initctl: catch write error, use _cleanup_
!= operator always returns something nonnegative, so the
error condition was not caught.
Zbigniew Jędrzejewski-Szmek [Wed, 13 Mar 2013 23:30:05 +0000 (19:30 -0400)]
journalctl: show systemd messages about unit for -u
journalctl -u unit is not very useful, because it doesn't show
systemd messages about starting, stopping, coredumps, etc,
like systemctl status unit does. Make it show the same
information using the same rules.
If somebody really want to see just messages from by the unit,
it is easy enough to use _SYSTEMD_UNIT=...
Zbigniew Jędrzejewski-Szmek [Wed, 13 Mar 2013 23:30:05 +0000 (19:30 -0400)]
logs-show: export logic to add matches for units
After that functions which add matches, show_journal_by_unit
and show_journal_by_user_unit, become nearly identical, so
I merged them into one function.
Thomas Hindoe Paaboel Andersen [Wed, 13 Mar 2013 22:09:49 +0000 (23:09 +0100)]
man: fix some typos
Zbigniew Jędrzejewski-Szmek [Wed, 13 Mar 2013 17:24:06 +0000 (13:24 -0400)]
build-sys: add two new files to EXTRA_DIST
Also move custom-*.xsl EXTRA_DIST additions closer to where
they are used.
Hannes Reinecke [Mon, 11 Mar 2013 11:49:27 +0000 (12:49 +0100)]
libudev: implement udev_device_set_attribute_value()
Michal Schmidt [Sat, 2 Mar 2013 21:31:09 +0000 (22:31 +0100)]
core: single unit_kill implementation for all unit types
There are very few differences in the implementations of the kill method in the
unit types that have one. Let's unify them.
This does not yet unify unit_kill() with unit_kill_context().
Michal Schmidt [Tue, 5 Mar 2013 14:52:44 +0000 (15:52 +0100)]
util, manager: and mempset() and use it
Just like mempcpy() is almost identical to memcpy() except the useful
return value, so is the relation of mempset() to memset().
Michal Schmidt [Tue, 5 Mar 2013 14:46:37 +0000 (15:46 +0100)]
manager: use more stpcpy()
Kay Sievers [Wed, 13 Mar 2013 12:12:36 +0000 (13:12 +0100)]
tmpfiles: --clean -- check for bind mounts of the same filesystem and skip them
Harald Hoyer [Fri, 8 Mar 2013 09:50:33 +0000 (10:50 +0100)]
cryptsetup-generator: use _cleanup_ where possible
Harald Hoyer [Mon, 4 Mar 2013 18:01:05 +0000 (19:01 +0100)]
add initrd-fs.target and root-fs.target
Instead of using local-fs*.target in the initrd, use root-fs.target for
sysroot.mount and initrd-fs.target for /sysroot/usr and friends.
Using local-fs.target would mean to carry over the activated
local-fs.target to the isolated initrd-switch-root.target and thus in
the real root. Having local-fs.target already active after
deserialization causes ordering problems with the real root services and
targets.
We better isolate to targets for initrd-switch-root.target, which are
only available in the initrd.
Zbigniew Jędrzejewski-Szmek [Wed, 13 Mar 2013 04:55:32 +0000 (00:55 -0400)]
build-sys: use -f with ln -s
Parallel builds would sometimes try to recreate the link,
and fail since 'ln -s' would refuse to overwrite.
Mathieu Bridon [Wed, 13 Mar 2013 04:43:40 +0000 (12:43 +0800)]
man: Document the actual behaviour of ExecStopPost
The documentation makes it sound like ExecStopPost is only run when
stopping the service with `systemctl stop foo.service`
However, that is not the case, as it also gets run when the service
unexpectedly exists, crashes, or gets SIGKILLed.
Zbigniew Jędrzejewski-Szmek [Wed, 13 Mar 2013 03:57:09 +0000 (23:57 -0400)]
man,html: say 'systemd 198' in the header
This should help readers of the man or HTML pages know if the documentation
is out of date. An alternative to use a date generated from 'git log' was
considered, but since we try to keep user visible documentation up to date,
showing the project version should be enough.
Zbigniew Jędrzejewski-Szmek [Tue, 12 Mar 2013 21:22:19 +0000 (17:22 -0400)]
man: strip the comments in man page headers
They contained the date, which creates a problem with multiarch
packages, since the generated file would be different each time.
Zbigniew Jędrzejewski-Szmek [Wed, 13 Mar 2013 03:05:20 +0000 (23:05 -0400)]
build-sys: break dependency loop between libsystemd-id128.la and -shared.la
The loop was added in
d848b9cbfa0ba72 'Move generic specifier functions to shared'.
Michal Sekletar [Tue, 12 Mar 2013 17:32:52 +0000 (18:32 +0100)]
shutdown: move attribute packed to the end of the declaration, so it is not ignored
Michal Schmidt [Tue, 12 Mar 2013 21:28:44 +0000 (22:28 +0100)]
manager: push back animation timer whenever a job finishes
The running jobs animation is supposed to hide itself when jobs are
progressing sufficiently fast.
Harald Hoyer [Tue, 12 Mar 2013 17:24:44 +0000 (18:24 +0100)]
remote-fs.target: want remote-fs-pre.target
This pulls in remote-fs-pre.target if remote-fs.target is needed.
Previously remote-fs-pre.target was not active, if no remote fs was
mounted from /etc/fstab. So, every manual remote fs mount was ordered
against the inactive remote-fs-pre.target and umount.target.
Because remote-fs-pre.target was not active, the remote fs was umounted
at umount.target time, which was too late (network already down).
Now remote-fs-pre.target is active, even if no remote fs is mounted.
On shutdown it is deactivated in the correct order and all manual remote
fs mounts also.
Michal Sekletar [Fri, 8 Mar 2013 14:13:43 +0000 (15:13 +0100)]
core: fix getting information about mount unit
We should not try to get information about mount unit from fragment
if the unit was created because of /proc/self/mountinfo event.
Kay Sievers [Tue, 12 Mar 2013 14:35:17 +0000 (15:35 +0100)]
udevd: sort into sysinit instead of basic target
Zbigniew Jędrzejewski-Szmek [Mon, 11 Mar 2013 22:03:13 +0000 (18:03 -0400)]
core/smack: downgrade info to debug
BogdanR> I think it's cool it supports SMACK and that it encourages
them to use a propper mount point for smackfs but I don't
think it's cool that it's printing on the screen even when
I parse quiet to the kernel that "SMACK support is not
enabled ...".
Zbigniew Jędrzejewski-Szmek [Mon, 11 Mar 2013 22:03:13 +0000 (18:03 -0400)]
Remove or indent #define GNU_SOURCE
It is only needed in files designed to be usable in standalone
compilation. In those files the #ifdefinery is indented. When
compiling in-tree, GNU_SOURCE is always defined, so remove one
definition.
Lennart Poettering [Mon, 11 Mar 2013 21:54:36 +0000 (22:54 +0100)]
bootchart: bump RLIMIT_NOFILE only after we forked us off, so that the init system inherits the kernel default
Lennart Poettering [Mon, 11 Mar 2013 21:47:58 +0000 (22:47 +0100)]
bootchart: various superficial cleanups
Let's update bootchar to share the coding style a bit more with the rest
of the package.
- Some tabs/spaces fixes
- add #pragma to header
- split up header so that we have a 1:1 relation between .c and .h files
like everywhere else
- Prefix user command line arguments/configuration settings with "arg_".
- other coding style fixes
Lennart Poettering [Mon, 11 Mar 2013 18:18:50 +0000 (19:18 +0100)]
bootchart: rename log.c to store.c to aovid confusion with src/shared/log.c
Lennart Poettering [Mon, 11 Mar 2013 16:49:33 +0000 (17:49 +0100)]
update TODO
Michael Biebl [Mon, 11 Mar 2013 16:07:01 +0000 (17:07 +0100)]
Lennart Poettering [Mon, 11 Mar 2013 14:10:29 +0000 (15:10 +0100)]
journald: allow priority of 999, too
Michael Biebl [Mon, 11 Mar 2013 06:17:39 +0000 (07:17 +0100)]
Move udevadm to rootbindir
The udevadm utility is needed during early boot, so move it to
rootbindir to support split-/usr configurations.
Kay Sievers [Sun, 10 Mar 2013 22:18:50 +0000 (23:18 +0100)]
bootctl: print Options only when found
Kay Sievers [Sun, 10 Mar 2013 21:47:56 +0000 (22:47 +0100)]
bootctl: print secure boot flags
Zbigniew Jędrzejewski-Szmek [Sat, 9 Mar 2013 23:55:31 +0000 (18:55 -0500)]
Fix typos of /etc/systemd/systemd
<Lekensteyn> The 198 announcement mentions
"/etc/systemd/systemd/foobar.service.d/*.conf", is that a
typo? I only have a /etc/systemd/system/. Is there a
manpage describing this new feature?
Kay Sievers [Sat, 9 Mar 2013 17:14:54 +0000 (18:14 +0100)]
TODO: update
Zbigniew Jędrzejewski-Szmek [Sat, 9 Mar 2013 14:55:03 +0000 (09:55 -0500)]
python/docs: use the same links on top as in man pages
I forgot to commit the layout file, because it was gitignored.
Fixed now.
Zbigniew Jędrzejewski-Szmek [Fri, 8 Mar 2013 18:46:21 +0000 (13:46 -0500)]
html: make python docs look more like the rest
The result is ugly enough, I hope, to motivate someone with
design skills to fix it.
Zbigniew Jędrzejewski-Szmek [Fri, 8 Mar 2013 16:45:37 +0000 (11:45 -0500)]
systemd-python: provide version info to sphinx
Zbigniew Jędrzejewski-Szmek [Fri, 8 Mar 2013 01:13:40 +0000 (20:13 -0500)]
man: use lxml for faster generation and pretty printing
Zbigniew Jędrzejewski-Szmek [Fri, 8 Mar 2013 16:03:50 +0000 (11:03 -0500)]
build-sys: generate links for html alias pages
Zbigniew Jędrzejewski-Szmek [Fri, 8 Mar 2013 15:27:44 +0000 (10:27 -0500)]
build-sys: assemble HTML in docs/html
The goal is to be able to preview how the documenation
will look when uploaded. Just point your browser at
docs/html/man/index.html.
Zbigniew Jędrzejewski-Szmek [Fri, 8 Mar 2013 14:58:29 +0000 (09:58 -0500)]
build-sys: clean up make clean
Zbigniew Jędrzejewski-Szmek [Sat, 9 Mar 2013 04:06:55 +0000 (23:06 -0500)]
build-sys: fix distcheck
Michael Biebl [Sat, 9 Mar 2013 08:46:11 +0000 (09:46 +0100)]
build-sys: don't hard-code binary paths in initrd-*.service
Instead use @bindir@ for udevadm and @rootbindir@ for systemctl.
Lennart Poettering [Fri, 8 Mar 2013 18:10:24 +0000 (19:10 +0100)]
analyze: use defines where we don't need static variables
Lennart Poettering [Fri, 8 Mar 2013 18:03:50 +0000 (19:03 +0100)]
analyze: by now, systemd-analyze is hardly all my work
Lennart Poettering [Fri, 8 Mar 2013 17:58:08 +0000 (18:58 +0100)]
analyze: various cleanups
Update systemd-analyze to follow the coding style of the other tools
more closely. Also, update the CODING_STYLE to document this for future
additions.
Changes:
- Always use usec_t for time units, so that we always use the same types
everywhere, and format times the same way as everywhere else.
- Add "static" to global variables
- Make sure we can always distuingish OOM and other errors: ensure we
always return useful error codes from all functions.
- Always free unit_times array
Lennart Poettering [Fri, 8 Mar 2013 13:01:06 +0000 (14:01 +0100)]
update TODO
Lennart Poettering [Fri, 8 Mar 2013 12:49:14 +0000 (13:49 +0100)]
update TODO
Michal Schmidt [Fri, 8 Mar 2013 11:05:48 +0000 (12:05 +0100)]
journal: allow priority 0 in stdout stream
Priority 0 is acceptable (it's LOG_EMERG).
BTW, I'm not sure why we allow priorities up to 999, but I'm leaving
this be for now.
http://lists.freedesktop.org/archives/systemd-devel/2013-March/009510.html
Michal Schmidt [Fri, 8 Mar 2013 09:46:26 +0000 (10:46 +0100)]
util: fix printing of welcome message
Commit
984a2be4 failed to adjust this caller of status_printf().
Michal Schmidt [Wed, 6 Mar 2013 18:28:55 +0000 (19:28 +0100)]
path: avoid an allocation in path_spec_watch
No need for strdup. We can slice the path in place if we always undo it
afterwards.
Michal Schmidt [Wed, 6 Mar 2013 13:44:51 +0000 (14:44 +0100)]
shared: inline trivial auto-cleanup functions
Michal Schmidt [Wed, 6 Mar 2013 13:17:59 +0000 (14:17 +0100)]
shared: remove pointless checks in auto-cleanup functions
The argument given to the __attribute__((cleanup)) functions is the
address of the variable that's going out of scope. It cannot be NULL.
The "if (!s)" check in set_freep() is pointless.
Perhaps "if (!*s)" was intented. But that's pointless too, because
set_free()/set_free_free() are OK to call with a NULL argument (just
like free()).
Setting "*s = NULL" is pointless, because the variable that s points
to is about to go out of scope.
The same holds for strv_freep().
Lennart Poettering [Thu, 7 Mar 2013 12:39:57 +0000 (13:39 +0100)]
update TODO
Thomas Hindoe Paaboel Andersen [Thu, 7 Mar 2013 21:45:22 +0000 (22:45 +0100)]
test-util: add more tests
Improve test coverage a bit with tests for
close_many
strappend (to cover all ways through strnappend)
Lennart Poettering [Thu, 7 Mar 2013 21:18:34 +0000 (22:18 +0100)]
core: if we cannot JOB_ISOLATE the default target JOB_REPLACE it instead
In order to maintain compatibility with older initrds which do not have
AllowIsolate=yes set for their target units, fallback to JOB_REPLACE if
JOB_ISOLATE doesn't work, but complain about it.
Lennart Poettering [Thu, 7 Mar 2013 20:53:53 +0000 (21:53 +0100)]
build-sys: bump release and sonames
Lennart Poettering [Thu, 7 Mar 2013 20:49:12 +0000 (21:49 +0100)]
journalctl: imply -n1000 when -e is used
Make sure the pager does not have to buffer an unbounded number of log
messages, by default.
Lennart Poettering [Thu, 7 Mar 2013 20:48:17 +0000 (21:48 +0100)]
update TODO
Lennart Poettering [Thu, 7 Mar 2013 20:42:25 +0000 (21:42 +0100)]
pager: add -M to $LESS to make the bottom line nicer
Zbigniew Jędrzejewski-Szmek [Thu, 7 Mar 2013 20:28:03 +0000 (15:28 -0500)]
Revert "bootchart: use _cleanup_close_"
This reverts commit
0ea9530d401827e299c6e04a433e69a7a2a89d80.
attribute(cleanup) can only be used inside functions (*of, sysfd
are leaked).
Cleanup functions are only called once when exiting scope (*f
is leaked twice).
Zbigniew Jędrzejewski-Szmek [Thu, 7 Mar 2013 20:32:33 +0000 (15:32 -0500)]
systemd-python: fix segfault on double close
Zbigniew Jędrzejewski-Szmek [Thu, 7 Mar 2013 20:27:30 +0000 (15:27 -0500)]
systemd-python: fix typos
Zbigniew Jędrzejewski-Szmek [Thu, 7 Mar 2013 18:13:44 +0000 (13:13 -0500)]
man/*.html: link to directives, python, guvev, libudev in headers
Since the HTML files are in different directories during build
and on fd.o, links are broken in the build directory. This could
be fixed by moving stuff around, or by modifying the files during
upload, but I think that people do not usually create HTML files
for local browsing, and this is not necessary.
Zbigniew Jędrzejewski-Szmek [Thu, 7 Mar 2013 19:42:27 +0000 (14:42 -0500)]
build-sys: move sphinx output to docs/python-systemd
And on fd.o it goes into a dir parallel to man/.
Lennart Poettering [Thu, 7 Mar 2013 20:28:09 +0000 (21:28 +0100)]
pager: always override LESS
https://bugzilla.redhat.com/show_bug.cgi?id=868383
Primary reason to do this is to ensure "-e" works as intended, and is
not ignored because the user set his own LESS variable.
Lennart Poettering [Thu, 7 Mar 2013 20:28:05 +0000 (21:28 +0100)]
Update NEWS
Harald Hoyer [Thu, 7 Mar 2013 19:44:35 +0000 (20:44 +0100)]
pager: introduce "jump to end" option
$ journalctl -be
is what you want :)
https://bugzilla.redhat.com/show_bug.cgi?id=867841
Lennart Poettering [Thu, 7 Mar 2013 20:08:04 +0000 (21:08 +0100)]
update NEWS
Kay Sievers [Thu, 7 Mar 2013 20:07:52 +0000 (21:07 +0100)]
NEWS: update
<mbiebl> "this allows resetting" <- I was told this is not correct English, too: "this allows one to reset"
<notting> "adds the ability to reset"?
Kay Sievers [Thu, 7 Mar 2013 20:04:30 +0000 (21:04 +0100)]
<mbiebl> poettering: small typo in the NEWS file: directory systems looks for <- systemd
<mbiebl> the sentence reads a bit strange "looks for units in"
<mbiebl> " by assigning the empty strings to them" <- an empty string or the empty string
<mbiebl> "this allows resetting" <- I was told this is not correct English, too: "this allows one to reset"
Lennart Poettering [Thu, 7 Mar 2013 19:46:35 +0000 (20:46 +0100)]
update TODO
Lennart Poettering [Thu, 7 Mar 2013 19:46:27 +0000 (20:46 +0100)]
update NEWS
Nathaniel Chen [Thu, 7 Mar 2013 19:09:16 +0000 (11:09 -0800)]
bootchart: use _cleanup_close_
use _cleanup_{close_,fclose_} to close streams and file descriptors
Nathaniel Chen [Thu, 7 Mar 2013 19:06:58 +0000 (11:06 -0800)]
core: mount and initialize Smack
SMACK is the Simple Mandatory Access Control Kernel, a minimal
approach to Access Control implemented as a kernel LSM.
The kernel exposes the smackfs filesystem API through which access
rules can be loaded. At boot time, we want to load the access rules
as early as possible to ensure all early boot steps are checked by Smack.
This patch mounts smackfs at the new location at /sys/fs/smackfs for
kernels 3.8 and above. The /smack mountpoint is not supported.
After mounting smackfs, rules are loaded from the usual location.
For more information about Smack see:
http://www.kernel.org/doc/Documentation/security/Smack.txt
Nathaniel Chen [Thu, 7 Mar 2013 19:06:57 +0000 (11:06 -0800)]
core: move mount_setup_early() to main.c
move mount_setup_early() call to main.c, before security module setup,
so there are no more repeat calls.
Kay Sievers [Thu, 7 Mar 2013 19:44:26 +0000 (20:44 +0100)]
NEWS: update
Kay Sievers [Thu, 7 Mar 2013 19:39:12 +0000 (20:39 +0100)]
TODO: update
Lennart Poettering [Thu, 7 Mar 2013 19:25:12 +0000 (20:25 +0100)]
update NEWS
Kay Sievers [Thu, 7 Mar 2013 18:42:51 +0000 (19:42 +0100)]
hwdb: update
Zbigniew Jędrzejewski-Szmek [Thu, 7 Mar 2013 18:04:17 +0000 (13:04 -0500)]
build-sys: check if manpage ids match file names
Commit ed1553a fixed current errors, but this error is easy to
make. A wrong id messes up the indexes and linking, so it is
better to catch this automatically.
Zbigniew Jędrzejewski-Szmek [Thu, 7 Mar 2013 17:41:22 +0000 (12:41 -0500)]
TODO: python stuff and freeze and standby
Lennart Poettering [Thu, 7 Mar 2013 17:39:06 +0000 (18:39 +0100)]
core: don't complain about systemd.journald.xxx kernel command line arguments in PID 1
https://bugzilla.redhat.com/show_bug.cgi?id=880025
Zbigniew Jędrzejewski-Szmek [Thu, 7 Mar 2013 16:29:01 +0000 (11:29 -0500)]
systemd-python: update documentation for new systemd-journal group
Zbigniew Jędrzejewski-Szmek [Thu, 7 Mar 2013 16:28:44 +0000 (11:28 -0500)]
systemd-python: refuse path and flags together in __init__
It's better to explictly check, instead of just documenting it.
The return value from init is changed from 1 to -1 on error.
Python seems to ignore 1 every second time. Looks like a bug
in Python, but the return value doesn't seem to be documented
anywhere, and -1 works as expected... so let's just use that.
Zbigniew Jędrzejewski-Szmek [Thu, 7 Mar 2013 15:15:20 +0000 (10:15 -0500)]
build-sys: force creation of symlink
For some reason make sometimes wants to rerun this, and
ln would refuse to recreate the link.
Lennart Poettering [Thu, 7 Mar 2013 15:48:14 +0000 (16:48 +0100)]
logind: don't hit an assert if an close() on an input device fd fails with ENODEV because the device is gone
https://bugzilla.redhat.com/show_bug.cgi?id=907890
Lukas Nykryn [Thu, 7 Mar 2013 15:09:20 +0000 (16:09 +0100)]
systemctl: mangle unit name in is-enabled
https://bugs.freedesktop.org/show_bug.cgi?id=56072
https://bugzilla.redhat.com/show_bug.cgi?id=880353
Harald Hoyer [Thu, 7 Mar 2013 15:19:38 +0000 (16:19 +0100)]
bootchart: document -C, --cmdline parameter
Harald Hoyer [Thu, 7 Mar 2013 07:52:56 +0000 (08:52 +0100)]
bootchart: use _cleanup_fclose_
Harald Hoyer [Thu, 7 Mar 2013 07:52:55 +0000 (08:52 +0100)]
bootchart: rename global len to samples_len
Harald Hoyer [Thu, 7 Mar 2013 07:52:54 +0000 (08:52 +0100)]
bootchart: add parameter "-C" to expand process names to the full cmdline
Jan Janssen [Thu, 7 Mar 2013 14:12:46 +0000 (15:12 +0100)]
util: Fix grammar in comment
Jan Janssen [Thu, 7 Mar 2013 14:12:45 +0000 (15:12 +0100)]
man: Unify title for configuration files
Jan Janssen [Thu, 7 Mar 2013 14:12:44 +0000 (15:12 +0100)]
man: Fix id attributes