platform/upstream/libSkiaSharp.git
9 years agoRevert of Revert of Revert of Remove workaround to for lower glsl support for qualcom...
egdaniel [Wed, 13 May 2015 17:32:49 +0000 (10:32 -0700)]
Revert of Revert of Revert of Remove workaround to for lower glsl support for qualcomm (patchset #1 id:1 of https://codereview.chromium.org/1138013004/)

Reason for revert:
still broken :(

Original issue's description:
> Revert of Revert of Remove workaround to for lower glsl support for qualcomm (patchset #1 id:1 of https://codereview.chromium.org/1135393003/)
>
> Reason for revert:
> trying once more
>
> Original issue's description:
> > Revert of Remove workaround to for lower glsl support for qualcomm (patchset #1 id:1 of https://codereview.chromium.org/1133543004/)
> >
> > Reason for revert:
> > breaks many qualcomm gms
> >
> > Original issue's description:
> > > Remove workaround to for lower glsl support for qualcomm
> > >
> > > BUG=skia:
> > >
> > > Committed: https://skia.googlesource.com/skia/+/9770bdce776f45367c419b8dd82219eece26ca5c
> >
> > TBR=bsalomon@google.com
> > NOPRESUBMIT=true
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=skia:
> >
> > Committed: https://skia.googlesource.com/skia/+/0cfe1242ee284290bde1ebe3f48626c555fdac51
>
> TBR=bsalomon@google.com
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/b72f920ef581e9cf50a6c1afc80ed04bb086488e

TBR=bsalomon@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/1130413006

9 years agoclean up tests
caryclark [Wed, 13 May 2015 17:13:17 +0000 (10:13 -0700)]
clean up tests

Confirm that no path ops tests are flaky, and clean up errors around
that. The test framework was incorrectly checking for >= MAX_ERRORS for
failure and <= MAX_ERRORS for success.

TBR=reed@google.com

Review URL: https://codereview.chromium.org/1140563003

9 years agoRemove GrGLVertexArray from GrGpuResource hierarchy.
bsalomon [Wed, 13 May 2015 16:56:37 +0000 (09:56 -0700)]
Remove GrGLVertexArray from GrGpuResource hierarchy.

Review URL: https://codereview.chromium.org/1137093002

9 years agoExtensible Android font configuration parsing.
bungeman [Wed, 13 May 2015 15:52:16 +0000 (08:52 -0700)]
Extensible Android font configuration parsing.

The xml parsing of the Android font configuration is quite lax in what
it allows. This has lead to issues with forward compatibility and
extending the existing format. This has lead to some confusion about
what the actual format is and how a given proposed change will affect
existing files and readers.

The main issue this fixes is containment. Tags are now only recognized
at the correct levels in the correct containing tags. Tags which are
not recognized are properly skipped. Tags which accumulate character
data now only accumulate the character data in their own element as
opposed to all child elements.

Review URL: https://codereview.chromium.org/1138073002

9 years agoGLProgramsTest 3.0
joshualitt [Wed, 13 May 2015 15:51:49 +0000 (08:51 -0700)]
GLProgramsTest 3.0

BUG=skia:

Review URL: https://codereview.chromium.org/1139743002

9 years agoRevert of Revert of Remove workaround to for lower glsl support for qualcomm (patchse...
egdaniel [Wed, 13 May 2015 15:46:51 +0000 (08:46 -0700)]
Revert of Revert of Remove workaround to for lower glsl support for qualcomm (patchset #1 id:1 of https://codereview.chromium.org/1135393003/)

Reason for revert:
trying once more

Original issue's description:
> Revert of Remove workaround to for lower glsl support for qualcomm (patchset #1 id:1 of https://codereview.chromium.org/1133543004/)
>
> Reason for revert:
> breaks many qualcomm gms
>
> Original issue's description:
> > Remove workaround to for lower glsl support for qualcomm
> >
> > BUG=skia:
> >
> > Committed: https://skia.googlesource.com/skia/+/9770bdce776f45367c419b8dd82219eece26ca5c
>
> TBR=bsalomon@google.com
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/0cfe1242ee284290bde1ebe3f48626c555fdac51

TBR=bsalomon@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/1138013004

9 years agodeal more consistently with unsortable edges
caryclark [Wed, 13 May 2015 15:23:48 +0000 (08:23 -0700)]
deal more consistently with unsortable edges

Improve line/curve coincident detection and resolution. This fixed the remaining simple failures.

When an edge is unsortable, use the ray intersection to determine the angles' winding.

Deal with degenerate segments.

TBR=reed@google.com
BUG=skia:3588,skia:3762

Review URL: https://codereview.chromium.org/1140813002

9 years agoTurn on Sk4px xfermodes when we have NEON too.
mtklein [Wed, 13 May 2015 15:02:14 +0000 (08:02 -0700)]
Turn on Sk4px xfermodes when we have NEON too.

For SSE, Sk4px is better than Sk4f is better than SkXfermodes_opts_SSE2 (where implemented).
For NEON, Sk4px is better than SkXfermodes_opts_arm_neon is better than Sk4f (where implemented).

This is a 1.6-1.9x speedup for Plus,Modulate, and Screen for NEON.

BUG=skia:

Review URL: https://codereview.chromium.org/1128053004

9 years agofix bounds for BW lines, AA Hairlines
joshualitt [Wed, 13 May 2015 15:00:56 +0000 (08:00 -0700)]
fix bounds for BW lines, AA Hairlines

BUG=skia:

Review URL: https://codereview.chromium.org/1123253003

9 years agoFix assert in GrBatchAtlas.
jvanverth [Wed, 13 May 2015 14:55:55 +0000 (07:55 -0700)]
Fix assert in GrBatchAtlas.

Stops this assert from triggering on the iOS build.

Review URL: https://codereview.chromium.org/1131003004

9 years agosimplify RawIter
reed [Wed, 13 May 2015 14:55:48 +0000 (07:55 -0700)]
simplify RawIter

BUG=skia:

Review URL: https://codereview.chromium.org/1137783006

9 years agoRevert of Remove workaround to for lower glsl support for qualcomm (patchset #1 id...
egdaniel [Wed, 13 May 2015 14:21:17 +0000 (07:21 -0700)]
Revert of Remove workaround to for lower glsl support for qualcomm (patchset #1 id:1 of https://codereview.chromium.org/1133543004/)

Reason for revert:
breaks many qualcomm gms

Original issue's description:
> Remove workaround to for lower glsl support for qualcomm
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/9770bdce776f45367c419b8dd82219eece26ca5c

TBR=bsalomon@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/1135393003

9 years agoRemove documentation for missing SkiaExamples.
scroggo [Wed, 13 May 2015 13:45:43 +0000 (06:45 -0700)]
Remove documentation for missing SkiaExamples.

SkiaExamples were removed in February, so no need to instruct newbies
to try building them.
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1135303002

Review URL: https://codereview.chromium.org/1135303002

9 years agoDocumentation: open GM in SampleApp
halcanary [Wed, 13 May 2015 13:45:31 +0000 (06:45 -0700)]
Documentation: open GM in SampleApp
NOTRY=true
DOCS_PREVIEW= https://skia.org/dev/testing/tests?cl=1138353002

Review URL: https://codereview.chromium.org/1138353002

9 years agoRemove workaround to for lower glsl support for qualcomm
egdaniel [Wed, 13 May 2015 13:39:38 +0000 (06:39 -0700)]
Remove workaround to for lower glsl support for qualcomm

BUG=skia:

Review URL: https://codereview.chromium.org/1133543004

9 years agoDocument NO_MERGE_BUILDS keyword
borenet [Wed, 13 May 2015 13:14:57 +0000 (06:14 -0700)]
Document NO_MERGE_BUILDS keyword

BUG=skia:3584
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1135313004

Review URL: https://codereview.chromium.org/1135313004

9 years agoFix SkStrokeRec == to report true for all fills
kkinnunen [Wed, 13 May 2015 07:02:26 +0000 (00:02 -0700)]
Fix SkStrokeRec == to report true for all fills

Fix SkStrokeRec == to report true for all fills, regardless
of the stale stroking data the object might contain.

Review URL: https://codereview.chromium.org/1130153002

9 years agoPlus xfermode using Sk4px.
mtklein [Tue, 12 May 2015 22:48:09 +0000 (15:48 -0700)]
Plus xfermode using Sk4px.

Xfermode_Plus runs 4-5x faster.

We expect mixed_xfermodes to have a small diff.  This is because kFoldCoverageIntoSrcAlpha was incorrectly set to true.

This implementation handily beats the Sk4f impl, the portable impl, and the existing SSE2 impl.  Reading the SkXfermodes_opts_SSE2.cpp file, I'm pretty confident that we'll be able to beat all SSE2 impls.

I believe this impl will beat or match the existing NEON impl too, but that may not be true for more complicated xfermodes.  They can take advantage of transposing ARGBARGB... to AAAARRRR.... cheaply and I haven't figured out an abstraction for that yet that doesn't screw SSE.

Adds:
  - MapDstSrc() to Sk4px
  - saturatedAdd() to SkNi (only implemented as far as it's used).
  - div255Narrow()

BUG=skia:

Review URL: https://codereview.chromium.org/1138893002

9 years agoAdd check in GrGpu createTexture to make sure we don't create multisampled textures.
egdaniel [Tue, 12 May 2015 20:36:30 +0000 (13:36 -0700)]
Add check in GrGpu createTexture to make sure we don't create multisampled textures.

BUG=skia:

Review URL: https://codereview.chromium.org/1138223003

9 years agoMake Noto Sans Mono CJK JP an alias to MS Gothic
jshin [Tue, 12 May 2015 19:08:36 +0000 (12:08 -0700)]
Make Noto Sans Mono CJK JP an alias to MS Gothic

This CL works together with the following CrOS CL:

https://chromium-review.googlesource.com/#/c/269899/

BUG=chromium:486164
TEST=With the above CrOS CL, 'MS Gothic' in CSS is replaced by 'Noto Sans Mono CJK JP'.

Review URL: https://codereview.chromium.org/1134853002

9 years agoadd option to supress prints on context
joshualitt [Tue, 12 May 2015 19:03:50 +0000 (12:03 -0700)]
add option to supress prints on context

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/55661337667a8305ebb100e36af23d34c2fb83ba

Review URL: https://codereview.chromium.org/1128903008

9 years agoFix valgrind bug in Porter Duff LCD.
egdaniel [Tue, 12 May 2015 19:03:28 +0000 (12:03 -0700)]
Fix valgrind bug in Porter Duff LCD.

BUG=skia:

Review URL: https://codereview.chromium.org/1135283002

9 years agoPerGlyphInfo is on SkTypeface
reed [Tue, 12 May 2015 17:49:15 +0000 (10:49 -0700)]
PerGlyphInfo is on SkTypeface

BUG=skia:
NOTRY=True
NOTREECHECKS=True
TBR=

Review URL: https://codereview.chromium.org/1128023004

9 years agoRevert of Revert of stop calling SkScalarDiv (patchset #1 id:1 of https://codereview...
reed [Tue, 12 May 2015 17:37:34 +0000 (10:37 -0700)]
Revert of Revert of stop calling SkScalarDiv (patchset #1 id:1 of https://codereview.chromium.org/1138263002/)

Reason for revert:
android patched, blink has rolled

Original issue's description:
> Revert of stop calling SkScalarDiv (patchset #4 id:60001 of https://codereview.chromium.org/1135053002/)
>
> Reason for revert:
> need to wait for Blink roll (and patch android)
>
> Original issue's description:
> > stop calling SkScalarDiv
> >
> > BUG=skia:
> > TBR=
> >
> > Committed: https://skia.googlesource.com/skia/+/67d71c898249a7af3523b16c6a69895a63bfae0a
>
> TBR=
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/2629697933b5cc975e45d2a45c48f803fc6cbcec

TBR=
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/1135693003

9 years agofix reference to _PerGlyphInfo
reed [Tue, 12 May 2015 17:35:48 +0000 (10:35 -0700)]
fix reference to _PerGlyphInfo

BUG=skia:
TBR=bungeman@google.com
NOTRY=True
NOTREECHECKS=True

Review URL: https://codereview.chromium.org/1136283004

9 years agoopt into SkScalarDiv until we can fix android call-sites
reed [Tue, 12 May 2015 17:28:58 +0000 (10:28 -0700)]
opt into SkScalarDiv until we can fix android call-sites

BUG=skia:
TBR=
NOTRY=True

Review URL: https://codereview.chromium.org/1138273002

9 years agoRevert of stop calling SkScalarDiv (patchset #4 id:60001 of https://codereview.chromi...
reed [Tue, 12 May 2015 17:28:06 +0000 (10:28 -0700)]
Revert of stop calling SkScalarDiv (patchset #4 id:60001 of https://codereview.chromium.org/1135053002/)

Reason for revert:
need to wait for Blink roll (and patch android)

Original issue's description:
> stop calling SkScalarDiv
>
> BUG=skia:
> TBR=
>
> Committed: https://skia.googlesource.com/skia/+/67d71c898249a7af3523b16c6a69895a63bfae0a

TBR=
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/1138263002

9 years agoMake SkAdvancedTypefaceMetrics private.
reed [Tue, 12 May 2015 16:50:04 +0000 (09:50 -0700)]
Make SkAdvancedTypefaceMetrics private.

Review URL: https://codereview.chromium.org/1129283003

9 years agostop calling SkScalarDiv
reed [Tue, 12 May 2015 16:47:22 +0000 (09:47 -0700)]
stop calling SkScalarDiv

BUG=skia:
TBR=

Review URL: https://codereview.chromium.org/1135053002

9 years agoquickie tool to exercise chrome filter fuzz files
caryclark [Tue, 12 May 2015 15:36:48 +0000 (08:36 -0700)]
quickie tool to exercise chrome filter fuzz files

This is a quick Skia transcription of the Chromium tool at
src/skia/tools/filter_fuzz_stub.cc
to read and decode filters captured as .fil files.

R=joshualitt@google.com,mtklein@google.com,reed@google.com,robertphillips@google.com
BUG=487213

Review URL: https://codereview.chromium.org/1126423005

9 years agoRevert of add option to supress prints on context (patchset #5 id:80001 of https...
joshualitt [Tue, 12 May 2015 15:33:36 +0000 (08:33 -0700)]
Revert of add option to supress prints on context (patchset #5 id:80001 of https://codereview.chromium.org/1128903008/)

Reason for revert:
breaks windows rollbots

Original issue's description:
> add option to supress prints on context
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/55661337667a8305ebb100e36af23d34c2fb83ba

TBR=bsalomon@google.com,robertphillips@google.com,joshualitt@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/1125193006

9 years agoadd option to supress prints on context
joshualitt [Tue, 12 May 2015 14:00:57 +0000 (07:00 -0700)]
add option to supress prints on context

BUG=skia:

Review URL: https://codereview.chromium.org/1128903008

9 years agoMake Porter Duff LCD XP its own XferProcessor
egdaniel [Tue, 12 May 2015 13:11:35 +0000 (06:11 -0700)]
Make Porter Duff LCD XP its own XferProcessor

BUG=skia:

Review URL: https://codereview.chromium.org/1134093003

9 years agoSk4px
mtklein [Tue, 12 May 2015 13:11:21 +0000 (06:11 -0700)]
Sk4px

Xfermode_SrcOver:
   SSE: 2.08ms -> 2.03ms  (~2% faster)
   NEON: my N5 is noisy, but there appears to be no perf change

BUG=skia:

Review URL: https://codereview.chromium.org/1132273004

9 years agoRemove quickstart docs.
tfarina [Tue, 12 May 2015 01:19:52 +0000 (18:19 -0700)]
Remove quickstart docs.

It is now obsolete by skia.org. All the relevant doc is hosted there
now.

BUG=None
R=mtklein@google.com

Review URL: https://codereview.chromium.org/1138833005

9 years agoFix blur on large glyphs in runs < SkGlyphCache::max
joshualitt [Mon, 11 May 2015 21:52:11 +0000 (14:52 -0700)]
Fix blur on large glyphs in runs < SkGlyphCache::max

BUG=skia:

Review URL: https://codereview.chromium.org/1135113002

9 years agoremove near one check for arcs
caryclark [Mon, 11 May 2015 21:36:33 +0000 (14:36 -0700)]
remove near one check for arcs

Small arcs are pinned by SkSinCos and do not need to be additionally
pinned by SkConic::BuildUnitArc.

R=reed@google.com, djsollen@google.com

Review URL: https://codereview.chromium.org/1133113003

9 years agofix for cached textblobs look garbled
joshualitt [Mon, 11 May 2015 20:04:28 +0000 (13:04 -0700)]
fix for cached textblobs look garbled

BUG=skia:

Review URL: https://codereview.chromium.org/1135813007

9 years agoAdd virtual destructor for GrDrawTargetCaps
bsalomon [Mon, 11 May 2015 18:26:23 +0000 (11:26 -0700)]
Add virtual destructor for GrDrawTargetCaps

TBR=jvanverth@google.com

Review URL: https://codereview.chromium.org/1134043004

9 years agoAdd assignment op to enum bitfield ops
cdalton [Mon, 11 May 2015 18:21:23 +0000 (11:21 -0700)]
Add assignment op to enum bitfield ops

BUG=skia:

Review URL: https://codereview.chromium.org/1139513002

9 years agoAdd function for logging blend info on XP.
bsalomon [Mon, 11 May 2015 18:21:14 +0000 (11:21 -0700)]
Add function for logging blend info on XP.

Review URL: https://codereview.chromium.org/1132373003

9 years agoconvex path renderer unit tests
joshualitt [Mon, 11 May 2015 15:58:52 +0000 (08:58 -0700)]
convex path renderer unit tests

TBR=bsalomon@google.com
BUG=skia:

Review URL: https://codereview.chromium.org/1134753002

9 years agoAdd unit tests to text context
joshualitt [Mon, 11 May 2015 15:58:08 +0000 (08:58 -0700)]
Add unit tests to text context

TBR=bsalomon@google.com
BUG=skia:

Review URL: https://codereview.chromium.org/1128153005

9 years agoAdd unit tests for stroke rects and drawVertices
joshualitt [Mon, 11 May 2015 15:18:35 +0000 (08:18 -0700)]
Add unit tests for stroke rects and drawVertices

TBR=bsalomon@google.com
BUG=skia:

Review URL: https://codereview.chromium.org/1133613004

9 years agoAADistanceFieldPathRenderer unit tests
joshualitt [Mon, 11 May 2015 14:21:37 +0000 (07:21 -0700)]
AADistanceFieldPathRenderer unit tests

TBR=bsalomon@google.com
BUG=skia:

Review URL: https://codereview.chromium.org/1129083005

9 years agoPath ops formerly found the topmost unprocessed edge and determined its angle sort...
caryclark [Mon, 11 May 2015 14:21:27 +0000 (07:21 -0700)]
Path ops formerly found the topmost unprocessed edge and determined its angle sort order to initialize the winding. This never worked correctly with cubics and was flaky with paths consisting mostly of vertical edges.

This replacement shoots axis-aligned rays through all intersecting edges to find the outermost one either horizontally or vertically. The resulting code is smaller and twice as fast.

To support this, most of the horizontal / vertical intersection code was rewritten and standardized, and old code supporting the top-directed winding was deleted.

Contours were pointed to by an SkTDArray. Instead, put them in a linked list, and designate the list head with its own class to ensure that methods that take lists of contours start at the top. This change removed a large percentage of memory allocations used by path ops.

TBR=reed@google.com
BUG=skia:3588

Review URL: https://codereview.chromium.org/1111333002

9 years agoprint on unused uniforms in debug builds
joshualitt [Mon, 11 May 2015 13:21:34 +0000 (06:21 -0700)]
print on unused uniforms in debug builds

BUG=skia:

Review URL: https://codereview.chromium.org/1136803002

9 years agoAdd android_launch_app script to allow command line options to be passed to the sampl...
Derek Sollenberger [Mon, 11 May 2015 12:54:19 +0000 (08:54 -0400)]
Add android_launch_app script to allow command line options to be passed to the sampleApp when starting.

BUG=skia:3815
DOCS_PREVIEW= https://skia.org/?cl=1136753003
R=bungeman@google.com, tomhudson@google.com

Review URL: https://codereview.chromium.org/1136753003

9 years agoSkPictureShader: floor scaledSize not to exceed maxTextureSize
gen.kim [Mon, 11 May 2015 01:33:29 +0000 (18:33 -0700)]
SkPictureShader: floor scaledSize not to exceed maxTextureSize

scaledSize becomes larger than maxTextureSize by zoom level
because it is rounded.

BUG=chromium:485916

Review URL: https://codereview.chromium.org/1129413002

9 years agoOnly discard for XP dstCopies if we have a coverage value.
egdaniel [Sun, 10 May 2015 15:45:18 +0000 (08:45 -0700)]
Only discard for XP dstCopies if we have a coverage value.

TBR=bsalomon@google.com

BUG=skia:

Review URL: https://codereview.chromium.org/1125283005

9 years agoUpdate SKP version
skia.buildbots [Sun, 10 May 2015 08:14:35 +0000 (01:14 -0700)]
Update SKP version

Automatic commit by the RecreateSKPs bot.

TBR=

Review URL: https://codereview.chromium.org/1123233004

9 years agoDisable advance blend equations.
egdaniel [Fri, 8 May 2015 21:42:43 +0000 (14:42 -0700)]
Disable advance blend equations.

This is a temporary disabling of advanced blend equations till we can fix
the various bugs associated with it.

BUG=skia:3822

Review URL: https://codereview.chromium.org/1130003003

9 years agoRemove coverage multiplies when it is known to be fully opaque.
egdaniel [Fri, 8 May 2015 19:48:35 +0000 (12:48 -0700)]
Remove coverage multiplies when it is known to be fully opaque.

BUG=skia:

Review URL: https://codereview.chromium.org/1132883002

9 years agoRemove unused SK_SUPPORT_LEGACY_ROUND_MIPMAP_LEVEL_CHOICE guard
fmalita [Fri, 8 May 2015 18:40:41 +0000 (11:40 -0700)]
Remove unused SK_SUPPORT_LEGACY_ROUND_MIPMAP_LEVEL_CHOICE guard

R=reed@google.com,robertphillips@google.com

Review URL: https://codereview.chromium.org/1135823003

9 years agowhitespace change (testing flaky bots)
halcanary [Fri, 8 May 2015 18:39:26 +0000 (11:39 -0700)]
whitespace change (testing flaky bots)
NOTRY=true
TBR=

Review URL: https://codereview.chromium.org/1132043004

9 years agowhitespace change
halcanary [Fri, 8 May 2015 17:53:29 +0000 (10:53 -0700)]
whitespace change
NOTRY=true
TBR=

Review URL: https://codereview.chromium.org/1131053004

9 years agoTrim whitespace from parsed filename in Android v21.
bungeman [Fri, 8 May 2015 15:31:54 +0000 (08:31 -0700)]
Trim whitespace from parsed filename in Android v21.

The entire text content of the 'font' element is currently used as the
file name. This wasn't an issue in earlier versions, as the 'file'
element was dedicated to only containing the file name. The new 'font'
element also contains a number of attributes and potentially other tags.
This means that a 'font' element can become quite long, making it
desireable to be able to split it across multiple lines.

However, splitting the 'font' element across multiple lines is currently
difficult and awkward as any whitespace outside of tags will be
considered part of the file name. This change means that any leading or
trailing whitespace will not be considered part of the file name.

This only applies to v21 and later files, so while this restricts font
file names from beginning and ending with whitespace, it is unlikely to
break any users in practice. It is probably also undesireable to have
font files with names that begin or end with whitespace in any event.

Review URL: https://codereview.chromium.org/1125413003

9 years agoremove legacy Gr things
bsalomon [Fri, 8 May 2015 14:17:05 +0000 (07:17 -0700)]
remove legacy Gr things

Review URL: https://codereview.chromium.org/1132813002

9 years agoFix convex-lineonly-paths GM so it plays nice with SampleApp
robertphillips [Fri, 8 May 2015 14:08:13 +0000 (07:08 -0700)]
Fix convex-lineonly-paths GM so it plays nice with SampleApp

Review URL: https://codereview.chromium.org/1131273002

9 years agoEnable GrAAConvexTessellator in GrAAConvexPathRenderer
robertphillips [Fri, 8 May 2015 11:46:51 +0000 (04:46 -0700)]
Enable GrAAConvexTessellator in GrAAConvexPathRenderer

This CL plumbs the GrAAConvexTessellator into the GrAAConvexPathRenderer but disables in Chrome & Android.

Review URL: https://codereview.chromium.org/1130883003

9 years agoRevert of Sketch splitting SkPicture into an interface and SkBigPicture. (patchset...
reed [Fri, 8 May 2015 00:30:13 +0000 (17:30 -0700)]
Revert of Sketch splitting SkPicture into an interface and SkBigPicture. (patchset #22 id:420001 of https://codereview.chromium.org/1112523006/)

Reason for revert:
speculative revert to fix failures in DEPS roll

Original issue's description:
> Sketch splitting SkPicture into an interface and SkBigPicture.
>
> Adds small pictures for drawRect(), drawTextBlob(), and drawPath().
> These cover about 89% of draw calls from Blink SKPs,
> and about 25% of draw calls from our GMs.
>
> SkPicture handles:
>   - serialization and deserialization
>   - unique IDs
>
> Everything else is left to the subclasses:
>   - playback(), cullRect()
>   - hasBitmap(), hasText(), suitableForGPU(), etc.
>   - LayerInfo / AccelData if applicable.
>
> The time to record a 1-op picture improves a good chunk
> (2 mallocs to 1), and the time to record a 0-op picture
> greatly improves (2 mallocs to none):
>
>     picture_overhead_draw:   450ns -> 350ns
>     picture_overhead_nodraw: 300ns -> 90ns
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/c92c129ff85b05a714bd1bf921c02d5e14651f8b

TBR=reed@google.com,robertphillips@google.com,mtklein@google.com,mtklein@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/1130333002

9 years agonew image from backend desc
reed [Thu, 7 May 2015 22:36:17 +0000 (15:36 -0700)]
new image from backend desc

BUG=485243

Review URL: https://codereview.chromium.org/1121813002

9 years agoadding rect batch unit test
joshualitt [Thu, 7 May 2015 21:21:00 +0000 (14:21 -0700)]
adding rect batch unit test

BUG=skia:

Review URL: https://codereview.chromium.org/1135513002

9 years agoSketch splitting SkPicture into an interface and SkBigPicture.
mtklein [Thu, 7 May 2015 20:41:07 +0000 (13:41 -0700)]
Sketch splitting SkPicture into an interface and SkBigPicture.

Adds small pictures for drawRect(), drawTextBlob(), and drawPath().
These cover about 89% of draw calls from Blink SKPs,
and about 25% of draw calls from our GMs.

SkPicture handles:
  - serialization and deserialization
  - unique IDs

Everything else is left to the subclasses:
  - playback(), cullRect()
  - hasBitmap(), hasText(), suitableForGPU(), etc.
  - LayerInfo / AccelData if applicable.

The time to record a 1-op picture improves a good chunk
(2 mallocs to 1), and the time to record a 0-op picture
greatly improves (2 mallocs to none):

    picture_overhead_draw:   450ns -> 350ns
    picture_overhead_nodraw: 300ns -> 90ns

BUG=skia:

Review URL: https://codereview.chromium.org/1112523006

9 years agotesselating path renderer unit tests
joshualitt [Thu, 7 May 2015 20:06:41 +0000 (13:06 -0700)]
tesselating path renderer unit tests

BUG=skia:

Review URL: https://codereview.chromium.org/1127183006

9 years agoSkPDF: detect YUV-JPEG without relying on ImageGenerator
halcanary [Thu, 7 May 2015 18:46:59 +0000 (11:46 -0700)]
SkPDF:  detect YUV-JPEG without relying on ImageGenerator

JPEG/JFIF References:
*   http://www.w3.org/Graphics/JPEG/itu-t81.pdf
*   http://www.w3.org/Graphics/JPEG/jfif3.pdf

BUG=476721
BUG=446940

Review URL: https://codereview.chromium.org/1133443003

9 years agoIterate over instanced draws in GrGpu rather than above GrBatchTarget
bsalomon [Thu, 7 May 2015 18:35:55 +0000 (11:35 -0700)]
Iterate over instanced draws in GrGpu rather than above GrBatchTarget

Review URL: https://codereview.chromium.org/1127273007

9 years agoInitial CL to create Reorder command builder behind a flag
joshualitt [Thu, 7 May 2015 18:14:30 +0000 (11:14 -0700)]
Initial CL to create Reorder command builder behind a flag

BUG=skia:

Review URL: https://codereview.chromium.org/1129943004

9 years agoSK_ARRAY_COUNT shouldn't work on pointers.
mtklein [Thu, 7 May 2015 17:58:44 +0000 (10:58 -0700)]
SK_ARRAY_COUNT shouldn't work on pointers.

Simpler version of https://codereview.chromium.org/1123923002/

BUG=skia:3593
R=brucedawson@chromium.org,reed@google.com,tfarina@chromium.org

No public API changes.
TBR=reed@google.com

Review URL: https://codereview.chromium.org/1114283003

9 years agoAdd default resourcePath to SampleApp on Android.
bungeman [Thu, 7 May 2015 17:57:02 +0000 (10:57 -0700)]
Add default resourcePath to SampleApp on Android.

Currently SampleApp on Android cannot find resources. This sets the
resourcePath to /data/local/tmp/skia/resources/ which is the path
used in documentationo. A future change will allow this default to be
overridden.

BUG=skia:3815

Review URL: https://codereview.chromium.org/1125363004

9 years agoDM: use SkFunction to make required argument type clearer.
mtklein [Thu, 7 May 2015 17:53:34 +0000 (10:53 -0700)]
DM: use SkFunction to make required argument type clearer.

Previously it was hard to tell that DrawFn took an SkCanvas* and returned an Error.  Now it's clear from the type.

BUG=skia:

Review URL: https://codereview.chromium.org/1125233002

9 years agoWe don't use boxBlurY.
mtklein [Thu, 7 May 2015 17:51:55 +0000 (10:51 -0700)]
We don't use boxBlurY.

Also noticed nobody sets SK_DISABLE_BLUR_DIVISION_OPTIMIZATION.

BUG=skia:

Review URL: https://codereview.chromium.org/1134513003

9 years agoTest sp-8888 mode on a few fast bots.
mtklein [Thu, 7 May 2015 17:26:44 +0000 (10:26 -0700)]
Test sp-8888 mode on a few fast bots.

(It's not particularly slow, but this mode doesn't really need global coverage.)

BUG=skia:

Review URL: https://codereview.chromium.org/1129903003

9 years agoIsolate GrBufferAllocPools inside GrBatchTarget
robertphillips [Thu, 7 May 2015 16:51:43 +0000 (09:51 -0700)]
Isolate GrBufferAllocPools inside GrBatchTarget

This CL refactors the location of the GrBufferAllocPools so they reside entirely inside the GrBatchTarget. This is in preparation for making them use scratch resources.

Review URL: https://codereview.chromium.org/1131553002

9 years agoadding uniqueID to GrContext
joshualitt [Thu, 7 May 2015 15:23:19 +0000 (08:23 -0700)]
adding uniqueID to GrContext

BUG=skia:

Review URL: https://codereview.chromium.org/1128873009

9 years agoAdding unit tests for limited subset of DefaultPathRenderer
joshualitt [Thu, 7 May 2015 15:13:11 +0000 (08:13 -0700)]
Adding unit tests for limited subset of DefaultPathRenderer

BUG=skia:

Review URL: https://codereview.chromium.org/1129203002

9 years agoRe-enable validation for glBlendBarrierKHR and glBlendEquation
cdalton [Wed, 6 May 2015 20:53:12 +0000 (13:53 -0700)]
Re-enable validation for glBlendBarrierKHR and glBlendEquation

BUG=skia:

Review URL: https://codereview.chromium.org/1103673002

9 years agoImplement support for KHR_blend_equation_advanced
cdalton [Wed, 6 May 2015 20:40:21 +0000 (13:40 -0700)]
Implement support for KHR_blend_equation_advanced

Uses KHR(or NV)_blend_equation_advanced to implement custom Xfer modes
in hardware.

BUG=skia:

Review URL: https://codereview.chromium.org/1037123003

9 years agoReally use SSE4 (and SSSE3) in SkBlurImage_SSE4
mtklein [Wed, 6 May 2015 20:22:02 +0000 (13:22 -0700)]
Really use SSE4 (and SSSE3) in SkBlurImage_SSE4

We don't seem to be making good use of the available instruction set.
SSE4.1 gives us an easy way to unpack a pixel into an __m128i, and
SSSE3 gave us an easy way to do the reverse.

This should be bit-perfect and about a 10% speedup.

BUG=skia:

Review URL: https://codereview.chromium.org/1123263003

9 years agoPlace nvpr above tesselating path renderer in the chain
cdalton [Wed, 6 May 2015 20:16:43 +0000 (13:16 -0700)]
Place nvpr above tesselating path renderer in the chain

BUG=skia:

Review URL: https://codereview.chromium.org/1123343003

9 years agouse floor for mip-level choice
reed [Wed, 6 May 2015 20:02:37 +0000 (13:02 -0700)]
use floor for mip-level choice

this chrome change must land first: https://codereview.chromium.org/1131663002/

BUG=skia:

Review URL: https://codereview.chromium.org/1131613002

9 years agoMake drawImage a virtual on SkDevice
reed [Wed, 6 May 2015 19:56:48 +0000 (12:56 -0700)]
Make drawImage a virtual on SkDevice

This reverts commit 06dad4b92f1fcb593bc686f9537d3e0d866b2241.

BUG=485243

Review URL: https://codereview.chromium.org/1129843003

9 years agoAdd a control benchmark.
mtklein [Wed, 6 May 2015 19:42:04 +0000 (12:42 -0700)]
Add a control benchmark.

I'm thinking of using this in perf with something like:
   ratio(fill(filter("test=foo")), fill(filter("test=control")))

Does that make sense to you?

Not sure that this is really a good control bench on all bots,
but I propose we just run it a bit and find out if it needs work.

BUG=skia:

Review URL: https://codereview.chromium.org/1129823003

9 years agoAdd layout qualifiers to GrGLShaderBuilder
cdalton [Wed, 6 May 2015 18:48:56 +0000 (11:48 -0700)]
Add layout qualifiers to GrGLShaderBuilder

BUG=skia:

Review URL: https://codereview.chromium.org/1114813002

9 years agoDo we still need this DOUBLE_LOOP feature?
mtklein [Wed, 6 May 2015 18:35:40 +0000 (11:35 -0700)]
Do we still need this DOUBLE_LOOP feature?

If so, let's do it this way so it works for all source types and doesn't need
to be chosen at compile time.

BUG=skia:

Review URL: https://codereview.chromium.org/1129693003

9 years agoSkPDF: Move utility fns to SkPDFUtils
halcanary [Wed, 6 May 2015 17:56:04 +0000 (10:56 -0700)]
SkPDF: Move utility fns to SkPDFUtils

BUG=skia:3585

Review URL: https://codereview.chromium.org/1124193003

9 years agoRevert of Revert of Revert of Make drawImage a virtual on SkDevice (patchset #1 id...
reed [Wed, 6 May 2015 17:16:02 +0000 (10:16 -0700)]
Revert of Revert of Revert of Make drawImage a virtual on SkDevice (patchset #1 id:1 of https://codereview.chromium.org/1126273002/)

Reason for revert:
still breaking webglconformance

Original issue's description:
> Revert of Revert of Make drawImage a virtual on SkDevice (patchset #1 id:1 of https://codereview.chromium.org/1124003002/)
>
> Reason for revert:
> retry now that some fixes (onDrawImage overrides) have landed in chrome/blink
>
> Original issue's description:
> > Revert of Make drawImage a virtual on SkDevice (patchset #4 id:60001 of https://codereview.chromium.org/1122643005/)
> >
> > Reason for revert:
> > speculative to see if it unblocks DEPS roll
> >
> > Original issue's description:
> > > Make drawImage a virtual on SkDevice
> > >
> > > Now with patch for SkDeferredCanvas
> > >
> > > This reverts commit 119468b71f8f4f45657ab30ead331be665de5a57.
> > >
> > > BUG=skia:
> > >
> > > Committed: https://skia.googlesource.com/skia/+/14fe8fd3e53b5e988aac189a8bc3ed28904d85c8
> >
> > TBR=robertphillips@google.com,mtklein@google.com,reed@google.com
> > NOPRESUBMIT=true
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=skia:
> >
> > Committed: https://skia.googlesource.com/skia/+/3538e3bfe2e00bc1b5b48d977fa7adff64d8c96b
>
> TBR=robertphillips@google.com,mtklein@google.com,reed@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/620ba3afe09d4173c87537040fe50c1c1895fb1a

TBR=robertphillips@google.com,mtklein@google.com,reed@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/1127993004

9 years agoRemove upright-matrix- configs from Android bots
borenet [Wed, 6 May 2015 15:33:51 +0000 (08:33 -0700)]
Remove upright-matrix- configs from Android bots

The Android bots are flaking like crazy. I'm not sure if these configs
are hurting the situation, but let's see if this helps.

TBR=mtklein,halcanary
BUG=skia:

Review URL: https://codereview.chromium.org/1131603002

9 years agoRevert of Revert of Make drawImage a virtual on SkDevice (patchset #1 id:1 of https...
reed [Wed, 6 May 2015 14:54:38 +0000 (07:54 -0700)]
Revert of Revert of Make drawImage a virtual on SkDevice (patchset #1 id:1 of https://codereview.chromium.org/1124003002/)

Reason for revert:
retry now that some fixes (onDrawImage overrides) have landed in chrome/blink

Original issue's description:
> Revert of Make drawImage a virtual on SkDevice (patchset #4 id:60001 of https://codereview.chromium.org/1122643005/)
>
> Reason for revert:
> speculative to see if it unblocks DEPS roll
>
> Original issue's description:
> > Make drawImage a virtual on SkDevice
> >
> > Now with patch for SkDeferredCanvas
> >
> > This reverts commit 119468b71f8f4f45657ab30ead331be665de5a57.
> >
> > BUG=skia:
> >
> > Committed: https://skia.googlesource.com/skia/+/14fe8fd3e53b5e988aac189a8bc3ed28904d85c8
>
> TBR=robertphillips@google.com,mtklein@google.com,reed@google.com
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/3538e3bfe2e00bc1b5b48d977fa7adff64d8c96b

TBR=robertphillips@google.com,mtklein@google.com,reed@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/1126273002

9 years agoDM: add Via abstract class
mtklein [Wed, 6 May 2015 14:54:07 +0000 (07:54 -0700)]
DM: add Via abstract class

BUG=skia:

Review URL: https://codereview.chromium.org/1117183007

9 years agoMake SkFunction copyable so it can go in containers.
mtklein [Wed, 6 May 2015 14:40:25 +0000 (07:40 -0700)]
Make SkFunction copyable so it can go in containers.

This totally overhauls the implementation to use ordinary inheritance-based type erasure.  I give up for now getting my manual vtable shenanigans to work with MSVC.  Still those same "expected ; before ), also expected ) before ;" errors.

I added support for uninitialized SkFunctions and operator=(), because it was fairly straightforward with this implementation.

The main downside here is that I've removed the inline implementation.  All SkFunctions involve a heap allocation, even when just wrapping function pointers.

BUG=skia:

Review URL: https://codereview.chromium.org/1056673002

9 years agosmall fix to correct bounds on distance field text
joshualitt [Wed, 6 May 2015 13:46:01 +0000 (06:46 -0700)]
small fix to correct bounds on distance field text

BUG=skia:

Review URL: https://codereview.chromium.org/1122253003

9 years agoAdd GrAAConvexTessellator class
robertphillips [Wed, 6 May 2015 12:15:57 +0000 (05:15 -0700)]
Add GrAAConvexTessellator class

This CL adds a GrAAConvexTessellator class. It does not connect it to the GrAAConvexPathRenderer.

Review URL: https://codereview.chromium.org/1084943003

9 years agoReduce the API surface of GrBufferAllocPool and its derivatives
robertphillips [Wed, 6 May 2015 11:38:36 +0000 (04:38 -0700)]
Reduce the API surface of GrBufferAllocPool and its derivatives

This utility class is going to be revamped and moved. This CL shrinks it a bit so there will be less to shuffle around.

Review URL: https://codereview.chromium.org/1126753003

9 years agoRevert of Make drawImage a virtual on SkDevice (patchset #4 id:60001 of https://coder...
reed [Wed, 6 May 2015 00:30:45 +0000 (17:30 -0700)]
Revert of Make drawImage a virtual on SkDevice (patchset #4 id:60001 of https://codereview.chromium.org/1122643005/)

Reason for revert:
speculative to see if it unblocks DEPS roll

Original issue's description:
> Make drawImage a virtual on SkDevice
>
> Now with patch for SkDeferredCanvas
>
> This reverts commit 119468b71f8f4f45657ab30ead331be665de5a57.
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/14fe8fd3e53b5e988aac189a8bc3ed28904d85c8

TBR=robertphillips@google.com,mtklein@google.com,reed@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/1124003002

9 years agosmall cleanup in GrOvalRenderer
joshualitt [Tue, 5 May 2015 21:09:05 +0000 (14:09 -0700)]
small cleanup in GrOvalRenderer

BUG=skia:

Review URL: https://codereview.chromium.org/1126723004

9 years agotrivial fix for drawvertices bounds
joshualitt [Tue, 5 May 2015 20:58:20 +0000 (13:58 -0700)]
trivial fix for drawvertices bounds

BUG=skia:

Review URL: https://codereview.chromium.org/1127633003

9 years agoFix vertex/index buffer leaks
bsalomon [Tue, 5 May 2015 20:20:09 +0000 (13:20 -0700)]
Fix vertex/index buffer leaks

TBR=robertphillips@google.com

Review URL: https://codereview.chromium.org/1123823004

9 years agoAdd matrix configs to DM
borenet [Tue, 5 May 2015 20:11:27 +0000 (13:11 -0700)]
Add matrix configs to DM

BUG=skia:832

Review URL: https://codereview.chromium.org/1125793002

9 years agoDM: add a Via to simulate SP pictures.
mtklein [Tue, 5 May 2015 19:59:56 +0000 (12:59 -0700)]
DM: add a Via to simulate SP pictures.

Will use this to test the other CL that adds small SkPicture implementations.

Not quite sure why patch_primitive doesn't draw the same in 8888 and sp-8888, but everything else does, so I'm not going to let that hold me back for now.

BUG=skia:

Review URL: https://codereview.chromium.org/1126613005