Daniel Stenberg [Thu, 21 Dec 2006 10:18:15 +0000 (10:18 +0000)]
removed unused variables
Daniel Stenberg [Thu, 21 Dec 2006 10:15:38 +0000 (10:15 +0000)]
Robson Braga Araujo reported bug #1618359
(http://curl.haxx.se/bug/view.cgi?id=1618359) and subsequently provided a
patch for it: when downloading 2 zero byte files in a row, curl 7.16.0
enters an infinite loop, while curl 7.16.1-
20061218 does one additional
unnecessary request.
Fix: During the "Major overhaul introducing http pipelining support and
shared connection cache within the multi handle." change, headerbytecount
was moved to live in the Curl_transfer_keeper structure. But that structure
is reset in the Transfer method, losing the information that we had about
the header size. This patch moves it back to the connectdata struct.
Daniel Stenberg [Thu, 21 Dec 2006 09:36:03 +0000 (09:36 +0000)]
CURLOPT_CAPATH is OpenSSL-only
Daniel Stenberg [Tue, 19 Dec 2006 14:28:01 +0000 (14:28 +0000)]
* removed the SSH-based protocols as they are now being implemented
* added mentioning of doing the stunnel equivalent ourselves for the test suite
* spell-check
Daniel Stenberg [Tue, 19 Dec 2006 09:09:44 +0000 (09:09 +0000)]
37. Having more than one connection to the same host when doing NTLM
authentication (with performs multiple "passes" and authenticates a
connection rather than a HTTP request), and particularly when using the
multi interface, there's a risk that libcurl will re-use a wrong connection
when doing the different passes in the NTLM negotiation and thus fail to
negotiate (in seemingly mysterious ways).
36. --limit-rate (CURLOPT_MAX_SEND_SPEED_LARGE and
CURLOPT_MAX_RECV_SPEED_LARGE) are broken on Windows (since 7.16.0, but
that's when they were introduced as previous to that the limiting logic was
made in the application only and not in the library). This problem is easily
repeated and it takes a Windows person to fire up his/hers debugger in order
to fix. http://curl.haxx.se/bug/view.cgi?id=1603712
Daniel Stenberg [Sat, 16 Dec 2006 22:28:08 +0000 (22:28 +0000)]
recv() doesn't take MSG_NOSIGNAL in its forth argument so let's not pass it.
Brendan Jurd pointed out.
Daniel Stenberg [Sat, 16 Dec 2006 21:33:51 +0000 (21:33 +0000)]
Brendan Jurd provided a fix that now prevents libcurl from getting a SIGPIPE
during certain conditions when GnuTLS is used.
Daniel Stenberg [Sat, 16 Dec 2006 21:05:33 +0000 (21:05 +0000)]
Brendan Jurd pointed out these typos
Gisle Vanem [Fri, 15 Dec 2006 16:57:28 +0000 (16:57 +0000)]
Plug more leaks.
Gisle Vanem [Fri, 15 Dec 2006 16:49:40 +0000 (16:49 +0000)]
Fix typo.
Daniel Stenberg [Thu, 14 Dec 2006 18:20:46 +0000 (18:20 +0000)]
minor syntax mistake
Gisle Vanem [Thu, 14 Dec 2006 16:42:53 +0000 (16:42 +0000)]
Free 'config->iface' if set.
Gisle Vanem [Mon, 11 Dec 2006 15:18:52 +0000 (15:18 +0000)]
ahost.exe needs getopt.obj.
Daniel Stenberg [Mon, 11 Dec 2006 09:32:58 +0000 (09:32 +0000)]
Alexey Simak found out that when doing FTP with the multi interface and
something went wrong like it got a bad response code back from the server,
libcurl would leak memory. Added test case 538 to verify the fix.
I also noted that the connection would get cached in that case, which
doesn't make sense since it cannot be re-use when the authentication has
failed. I fixed that issue too at the same time, and also that the path
would be "remembered" in vain for cases where the connection was about to
get closed.
Daniel Stenberg [Mon, 11 Dec 2006 09:31:08 +0000 (09:31 +0000)]
PROT_CLOSEACTION doesn't have to be its own bit but can just as well just
include the protocol bits of such actions, which currently only means FTP
Daniel Stenberg [Thu, 7 Dec 2006 15:33:06 +0000 (15:33 +0000)]
fixed the printf formatting after I changed the type of 'excess'
Daniel Stenberg [Wed, 6 Dec 2006 10:07:12 +0000 (10:07 +0000)]
7.16.1 knows SFTP too
Daniel Stenberg [Wed, 6 Dec 2006 09:52:04 +0000 (09:52 +0000)]
clarify --limit-rate somewhat: it might send away/receive chunks of date in
temporarily higher speeds than requested, but the given limiting is considered
"over time" and is an average
Daniel Stenberg [Wed, 6 Dec 2006 09:37:40 +0000 (09:37 +0000)]
Sebastien Willemijns reported bug #1603712
(http://curl.haxx.se/bug/view.cgi?id=1603712) which is about connections
getting cut off prematurely when --limit-rate is used. While I found no such
problems in my tests nor in my reading of the code, I found that the
--limit-rate code was severly flawed (since it was moved into the lib, since
7.15.5) when used with the easy interface and it didn't work as documented so
I reworked it somewhat and now it works for my tests.
Daniel Stenberg [Tue, 5 Dec 2006 21:40:14 +0000 (21:40 +0000)]
Stefan Krause pointed out a compiler warning with a picky MSCV compiler when
passing a curl_off_t argument to the Curl_read_rewind() function which takes
an size_t argument. Curl_read_rewind() also had debug code left in it and it
was put in a different source file with no good reason when only used from
one single spot.
Daniel Stenberg [Tue, 5 Dec 2006 21:39:24 +0000 (21:39 +0000)]
removed the final traces of the closepolicy option
Daniel Stenberg [Tue, 5 Dec 2006 16:04:46 +0000 (16:04 +0000)]
update after today's work
Daniel Stenberg [Tue, 5 Dec 2006 16:04:01 +0000 (16:04 +0000)]
Sh Diao reported that CURLOPT_CLOSEPOLICY doesn't work, and indeed, there is
no code present in the library that receives the option. Since it was not
possible to use, we know that no current users exist and thus we simply
removed it from the docs and made the code always use the default path of
the code.
Daniel Stenberg [Tue, 5 Dec 2006 15:36:26 +0000 (15:36 +0000)]
Jared Lundell filed bug report #1604956
(http://curl.haxx.se/bug/view.cgi?id=1604956) which identified setting
CURLOPT_MAXCONNECTS to zero caused libcurl to SIGSEGV. Starting now, libcurl
will always internally use no less than 1 entry in the connection cache.
Daniel Stenberg [Tue, 5 Dec 2006 15:24:18 +0000 (15:24 +0000)]
better preprocessor check for recent MSVC versions
Daniel Stenberg [Tue, 5 Dec 2006 15:17:32 +0000 (15:17 +0000)]
CURLOPT_FORBID_REUSE works again with a cleaned up order of doing things in
Curl_done()
Daniel Stenberg [Tue, 5 Dec 2006 15:00:14 +0000 (15:00 +0000)]
oops, fix belonging to the previous curl_getdate() fix since it makes MSVC
use gmtime_r
Daniel Stenberg [Tue, 5 Dec 2006 14:57:43 +0000 (14:57 +0000)]
Martin Skinner brought back bug report #1230118 to haunt us once again.
(http://curl.haxx.se/bug/view.cgi?id=1230118) curl_getdate() did not work
properly for all input dates on Windows. It was mostly seen on some TZ time
zones using DST. Luckily, Martin also provided a fix.
Daniel Stenberg [Tue, 5 Dec 2006 13:49:29 +0000 (13:49 +0000)]
Alexey Simak filed bug report #1600447
(http://curl.haxx.se/bug/view.cgi?id=1600447) in which he noted that active
FTP connections don't work with the multi interface. The problem is here that
the multi interface state machine has a state during which it can wait for the
data connection to connect, but the active connection is not done in the same
step in the sequence as the passive one is so it doesn't quite work for
active. The active FTP code still use a blocking function to allow the remote
server to connect.
The fix (work-around is a better word) for this problem is to set the
boolean prematurely that the data connection is completed, so that the "wait
for connect" phase ends at once.
Daniel Stenberg [Tue, 5 Dec 2006 13:37:05 +0000 (13:37 +0000)]
Matt Witherspoon fixed a problem case when the CPU load went to 100% when a
HTTP upload was disconnected:
"What appears to be happening is that my system (Linux 2.6.17 and 2.6.13) is
setting *only* POLLHUP on poll() when the conditions in my previous mail
occur. As you can see, select.c:Curl_select() does not check for POLLHUP. So
basically what was happening, is poll() was returning immediately (with
POLLHUP set), but when Curl_select() looked at the bits, neither POLLERR or
POLLOUT was set. This still caused Curl_readwrite() to be called, which
quickly returned. Then the transfer() loop kept continuing at full speed
forever."
Daniel Stenberg [Tue, 5 Dec 2006 13:21:55 +0000 (13:21 +0000)]
curl.dsmirror.nl is another mirror
Daniel Stenberg [Tue, 5 Dec 2006 13:20:28 +0000 (13:20 +0000)]
fixed in CVS
Daniel Stenberg [Sun, 3 Dec 2006 09:19:23 +0000 (09:19 +0000)]
fix the libssh2 include path somewhat when --with-libssh2 is used and added
a warning output if no OpenSSL was found
Daniel Stenberg [Fri, 1 Dec 2006 11:54:00 +0000 (11:54 +0000)]
CURLOPT_CLOSEPOLICY can't be set
Daniel Stenberg [Fri, 1 Dec 2006 07:49:22 +0000 (07:49 +0000)]
Toon Verwaest reported that there are servers that send the Content-Range:
header in a third, not suppported by libcurl, format and we agreed that we
could make the parser more forgiving to accept all the three found
variations.
Daniel Stenberg [Thu, 30 Nov 2006 09:21:21 +0000 (09:21 +0000)]
the extra copy of downloads should be fixed too
Daniel Stenberg [Wed, 29 Nov 2006 21:47:22 +0000 (21:47 +0000)]
two more
Daniel Stenberg [Wed, 29 Nov 2006 14:39:50 +0000 (14:39 +0000)]
Is CURLOPT_FORBID_REUSE broken?
Daniel Stenberg [Mon, 27 Nov 2006 22:07:56 +0000 (22:07 +0000)]
adding notes of what to work on and fix before next release
Daniel Stenberg [Mon, 27 Nov 2006 13:38:32 +0000 (13:38 +0000)]
no need to access it with conn->data since data is already a local variable
holding the conn->data value
Daniel Stenberg [Sat, 25 Nov 2006 13:32:48 +0000 (13:32 +0000)]
added the new test 282
Daniel Stenberg [Sat, 25 Nov 2006 13:32:04 +0000 (13:32 +0000)]
Venkat Akella found out that libcurl did not like HTTP responses that simply
responded with a single status line and no headers nor body. Starting now, a
HTTP response on a persistent connection (i.e not set to be closed after the
response has been taken care of) must have Content-Length or chunked
encoding set, or libcurl will simply assume that there is no body.
To my horror I learned that we had no less than 57(!) test cases that did bad
HTTP responses like this, and even the test http server (sws) responded badly
when queried by the test system if it is the test system. So although the
actual fix for the problem was tiny, going through all the newly failing test
cases got really painful and boring.
Daniel Stenberg [Sat, 25 Nov 2006 09:49:29 +0000 (09:49 +0000)]
James Housley fixed SCP downloading by setting the maxdownload.
Yang Tse [Sat, 25 Nov 2006 01:02:52 +0000 (01:02 +0000)]
Make sure RETSIGTYPE is properly defined
Daniel Stenberg [Fri, 24 Nov 2006 22:14:39 +0000 (22:14 +0000)]
James Housley did lots of work and introduced SFTP downloads.
Yang Tse [Fri, 24 Nov 2006 16:38:58 +0000 (16:38 +0000)]
Define HAVE_SIGNAL_H, HAVE_SIG_ATOMIC_T and HAVE_SIG_ATOMIC_T_VOLATILE
as appropriate for platforms that don't have autotools support
Daniel Stenberg [Wed, 22 Nov 2006 22:54:41 +0000 (22:54 +0000)]
Michael Wallner fixed this problem: When I set domains in the options
struct, and there are domain/search entries in /etc/resolv.conf, the domains
of the options struct will be overridden.
Daniel Stenberg [Wed, 22 Nov 2006 22:51:01 +0000 (22:51 +0000)]
Install ares_dns.h too
Yang Tse [Wed, 22 Nov 2006 18:41:34 +0000 (18:41 +0000)]
Added a check in configure that verifies if <signal.h> is available,
defining HAVE_SIGNAL_H if the header is available.
Added a check in configure that tests if the sig_atomic_t type is
available, defining HAVE_SIG_ATOMIC_T if it is available. Providing
a suitable default in setup_once.h if not available.
Added a check in configure that tests if the sig_atomic_t type is
already defined as volatile, defining HAVE_SIG_ATOMIC_T_VOLATILE
if it is available and already defined as volatile.
Daniel Stenberg [Tue, 21 Nov 2006 07:45:49 +0000 (07:45 +0000)]
new french mirror
Yang Tse [Mon, 20 Nov 2006 16:58:41 +0000 (16:58 +0000)]
Revert ftpserver.pl back to revision 1.74 Adding change done in 1.76
This is done to back out changes done in revisions 1.77 and 1.75
Yang Tse [Mon, 20 Nov 2006 16:58:04 +0000 (16:58 +0000)]
Revert runtests.pl back to revision 1.212
This is done to back out changes done from revisions 1.213 to 1.217
Yang Tse [Mon, 20 Nov 2006 16:57:01 +0000 (16:57 +0000)]
Revert ftp.pm back to revision 1.5 Adding copyright notice.
This is done to back out changes done from revisions 1.6 to 1.10
Yang Tse [Mon, 20 Nov 2006 10:35:25 +0000 (10:35 +0000)]
Add some message logging
Yang Tse [Mon, 20 Nov 2006 06:22:51 +0000 (06:22 +0000)]
stop slaves before stopping servers
Yang Tse [Mon, 20 Nov 2006 03:25:17 +0000 (03:25 +0000)]
Revert to KILL test servers until all test servers
have proper TERM and INT signal handlers implemented.
Daniel Stenberg [Sun, 19 Nov 2006 22:48:40 +0000 (22:48 +0000)]
log the sleep, like when done in test 190
Daniel Stenberg [Sun, 19 Nov 2006 21:55:34 +0000 (21:55 +0000)]
Frank Teo provided an updated, mostly docs changed
Yang Tse [Sun, 19 Nov 2006 03:47:56 +0000 (03:47 +0000)]
Avoid passing child pid and test server pid, using the running
servers hash, and adjust message arguments accordingly.
Yang Tse [Sun, 19 Nov 2006 03:47:11 +0000 (03:47 +0000)]
Comment out the use of the "warnings" module now that ftp.pm seems to
be clear of warnings. Uncomment it if this module is further modified.
The "warnings" module requires perl 5.006 or later. Previous perl
versions don't have it and die on missing modules.
Daniel Stenberg [Sat, 18 Nov 2006 14:46:33 +0000 (14:46 +0000)]
new ruby binding, new tclcurl release
Yang Tse [Sat, 18 Nov 2006 04:07:01 +0000 (04:07 +0000)]
Avoid keeping dupe pids When forked pid and test server pid is the same one.
Yang Tse [Sat, 18 Nov 2006 04:05:42 +0000 (04:05 +0000)]
Fix warning "Use of uninitialized value in ...".
If the list has only one item avoid sort subroutine.
Yang Tse [Fri, 17 Nov 2006 16:44:22 +0000 (16:44 +0000)]
The hash of running servers is now a hash of hashes which for each running
server holds not only its two main pids, but also the pidfile of the test
server and the 'slavepidfiles' for ftp* servers. This allows a better control
when stopping servers.
Now from runtests.pl when test servers are stopped they are signalled in
sequence TERM, INT and KILL allowing time in between for them to die. This
will give us a chance of gracefully stopping test servers, which we didn't
have when we were killing them in first instance.
Gisle Vanem [Wed, 15 Nov 2006 05:35:35 +0000 (05:35 +0000)]
Call libssh2_session_free() to release memory allocated during
libssh2 startup.
Gisle Vanem [Tue, 14 Nov 2006 20:26:13 +0000 (20:26 +0000)]
Free 'scp->path' in case of libssh2 setup failure.
Daniel Stenberg [Mon, 13 Nov 2006 17:29:07 +0000 (17:29 +0000)]
Ron in bug #1595348 (curl.haxx.se/bug/view.cgi?id=1595348) pointed
out a stack overwrite (and the corresponding fix) on 64bit Windows when
dealing with HTTP chunked encoding.
Daniel Stenberg [Mon, 13 Nov 2006 17:26:43 +0000 (17:26 +0000)]
bug #1595348 by Ron pointed out this flaw and fix
Daniel Stenberg [Mon, 13 Nov 2006 13:48:55 +0000 (13:48 +0000)]
Tor Arntsen spotted this mistake
Daniel Stenberg [Sat, 11 Nov 2006 22:23:48 +0000 (22:23 +0000)]
we did 1.3.2 and are now on the 1.3.3 track!
Daniel Stenberg [Sat, 11 Nov 2006 22:05:33 +0000 (22:05 +0000)]
fix header to match actual proto
Daniel Stenberg [Sat, 11 Nov 2006 21:34:43 +0000 (21:34 +0000)]
cleaned up Curl_write() and the sub functions it uses for various protocols.
They all now return ssize_t to Curl_write().
Unfortunately, Curl_read() is in a sorrier state but it too would benefit from
a similar cleanup.
Daniel Stenberg [Thu, 9 Nov 2006 21:58:28 +0000 (21:58 +0000)]
Nir Soffer updated libcurl.framework.make: fix symlinks, should link to
Versions, not to ./Versions and indentation improvments
Daniel Stenberg [Thu, 9 Nov 2006 21:54:33 +0000 (21:54 +0000)]
Dmitriy Sergeyev found a SIGSEGV with his test04.c example posted on 7 Nov
2006. It turned out we wrongly assumed that the connection cache was present
when tearing down a connection.
Daniel Stenberg [Thu, 9 Nov 2006 21:36:18 +0000 (21:36 +0000)]
Ciprian Badescu found a SIGSEGV when doing multiple TFTP transfers using the
multi interface, but I could also repeat it doing multiple sequential ones
with the easy interface. Using Ciprian's test case, I could fix it.
Yang Tse [Thu, 9 Nov 2006 13:20:42 +0000 (13:20 +0000)]
Remove showing stderr log files unconditionally for tests 518 and 537.
Add failure checking for servers when fork()ed.
Use same code path in 'stopserver' when called with a single or multiple pids.
Daniel Stenberg [Wed, 8 Nov 2006 21:49:14 +0000 (21:49 +0000)]
Bradford Bruce reported that when setting CURLOPT_DEBUGFUNCTION without
CURLOPT_VERBOSE set to non-zero, you still got a few debug messages from the
SSL handshake. This is now stopped.
Daniel Stenberg [Wed, 8 Nov 2006 08:49:27 +0000 (08:49 +0000)]
ok stop using old and deprecated options
Daniel Stenberg [Tue, 7 Nov 2006 15:21:11 +0000 (15:21 +0000)]
add missing names
Daniel Stenberg [Tue, 7 Nov 2006 14:07:02 +0000 (14:07 +0000)]
Olaf fixed a leftover problem with the CONNECT fix of his that would leave a
wrong error message in the error message buffer.
Gisle Vanem [Tue, 7 Nov 2006 13:29:15 +0000 (13:29 +0000)]
Moved select_s() to Makefile.dj since select() is used in applications.
Gisle Vanem [Tue, 7 Nov 2006 13:20:01 +0000 (13:20 +0000)]
Update copyright year.
Yang Tse [Mon, 6 Nov 2006 18:28:34 +0000 (18:28 +0000)]
add TODO note
Yang Tse [Mon, 6 Nov 2006 18:27:25 +0000 (18:27 +0000)]
compiler warning fix
Yang Tse [Mon, 6 Nov 2006 18:26:36 +0000 (18:26 +0000)]
remove redundant check for Win32
Yang Tse [Mon, 6 Nov 2006 13:56:51 +0000 (13:56 +0000)]
avoid a couple of potential zero size memory allocations
Daniel Stenberg [Sun, 5 Nov 2006 23:11:22 +0000 (23:11 +0000)]
mention the areslib.dsp fix
Daniel Stenberg [Sun, 5 Nov 2006 23:11:07 +0000 (23:11 +0000)]
add the recent crowd of contributors
Daniel Stenberg [Sun, 5 Nov 2006 23:08:11 +0000 (23:08 +0000)]
Andreas Rieke fixed back the correct line endings!
Yang Tse [Sun, 5 Nov 2006 12:42:50 +0000 (12:42 +0000)]
Prevent multiple initialization of memdebug configuration variables.
This was possible on debug c-ares enabled builds when both CURL_MEMDEBUG
and CARES_MEMDEBUG environment variables were set. Leading to a file handle
leak even when both variables had the same value, and wierd test suite
results when different.
Gisle Vanem [Fri, 3 Nov 2006 15:52:21 +0000 (15:52 +0000)]
Ifdef around S_IRGRP and S_IROTH (meaningless on Win32).
Yang Tse [Fri, 3 Nov 2006 14:13:25 +0000 (14:13 +0000)]
add a couple more of debugging messages
Daniel Stenberg [Fri, 3 Nov 2006 13:45:52 +0000 (13:45 +0000)]
SCP support added
Daniel Stenberg [Fri, 3 Nov 2006 12:43:55 +0000 (12:43 +0000)]
Olaf Stueben provided a patch that I edited slightly. It fixes the notorious
KNOWN_BUGS #25, which happens when a proxy closes the connection when
libcurl has sent CONNECT, as part of an authentication negotiation. Starting
now, libcurl will re-connect accordingly and continue the authentication as
it should.
Daniel Stenberg [Fri, 3 Nov 2006 12:22:13 +0000 (12:22 +0000)]
initial SCP support is now added
Daniel Stenberg [Fri, 3 Nov 2006 10:56:37 +0000 (10:56 +0000)]
Update the information about what c-ares version that's required. 1.3.1 had
a fatal bug so we must require 1.3.2 to get flawless functionality with c-ares.
Daniel Stenberg [Fri, 3 Nov 2006 10:47:35 +0000 (10:47 +0000)]
stand clear for release 1.3.2
Daniel Stenberg [Fri, 3 Nov 2006 10:41:33 +0000 (10:41 +0000)]
Andreas Rieke added missing file and changed line endings
Yang Tse [Fri, 3 Nov 2006 10:05:21 +0000 (10:05 +0000)]
reduce max size of dinamically allocated arrays to minimize the nasty
behaviour some versions of IRIX exhibit of committing suicide on big
mallocs instead of just returning a friendly null pointer
Yang Tse [Fri, 3 Nov 2006 03:05:15 +0000 (03:05 +0000)]
fix missing '$' for var OPT_LIBSSH2