platform/upstream/gcc.git
4 years agoia64: Fix C++14 vs. C++17 ABI issue on ia64 [PR94706]
Jakub Jelinek [Wed, 22 Apr 2020 14:47:58 +0000 (16:47 +0200)]
ia64: Fix C++14 vs. C++17 ABI issue on ia64 [PR94706]

ia64 seems to be affected too, but the backend doesn't have any
-Wpsabi warnings and I'm not sure if we really need them for an (almost?)
dead target.

2020-04-22  Jakub Jelinek  <jakub@redhat.com>

PR target/94706
* config/ia64/ia64.c (hfa_element_mode): Ignore
cxx17_empty_base_field_p fields.

4 years agocalls: Introduce cxx17_empty_base_field_p [PR94383]
Jakub Jelinek [Wed, 22 Apr 2020 14:44:42 +0000 (16:44 +0200)]
calls: Introduce cxx17_empty_base_field_p [PR94383]

As multiple targets are affected apparently, I believe at least
aarch64, arm, powerpc64le, s390{,x} and ia64,
I think we should have a middle-end predicate for this, so that if we need
to tweak it, we can do it in one spot.

2020-04-22  Jakub Jelinek  <jakub@redhat.com>

PR target/94383
* calls.h (cxx17_empty_base_field_p): Declare.
* calls.c (cxx17_empty_base_field_p): Define.

4 years agotestsuite: [arm] Include arm_acle.h in related effective targets
Christophe Lyon [Wed, 22 Apr 2020 13:55:36 +0000 (13:55 +0000)]
testsuite: [arm] Include arm_acle.h in related effective targets

Since arm_acle.h includes stdint.h, its use requires the presence of
the right gnu/stub-*.h, so make sure to include arm_acle.h when
checking the effective targets that generally imply that the testcase
will include it: arm_dsp, arm_crc, arm_coproc[1-4]

This makes several tests unsupported rather than fail.

2020-04-22  Christophe Lyon  <christophe.lyon@linaro.org>

gcc/testsuite/
* lib/target-supports.exp (check_effective_target_arm_dsp)
(check_effective_target_arm_crc_ok_nocache)
(check_effective_target_arm_coproc1_ok_nocache)
(check_effective_target_arm_coproc2_ok_nocache)
(check_effective_target_arm_coproc3_ok_nocache)
(check_effective_target_arm_coproc4_ok_nocache): Include
arm_acle.h.

4 years agotestsuite: [arm/cde] Include arm_cde.h and arm_mve.h in arm_v8*m_main_cde*
Christophe Lyon [Wed, 22 Apr 2020 13:50:36 +0000 (13:50 +0000)]
testsuite: [arm/cde] Include arm_cde.h and arm_mve.h in arm_v8*m_main_cde*

Since arm_cde.h includes stdint.h, its use requires the presence of
the right gnu/stub-*.h, so make sure to include it when checking the
arm_v8*m_main_cde* effective targets, otherwise we can decide CDE is
supported while it's not really (all tests that use arm_v8m_main_cde*
also include arm_cde.h aynway).

Similarly for the effective targets that also require MVE.

This makes several tests unsupported rather than fail.

2020-04-22  Christophe Lyon  <christophe.lyon@linaro.org>

gcc/testsuite/
* lib/target-supports.exp (arm_v8m_main_cde, arm_v8m_main_cde_fp)
(arm_v8_1m_main_cde_mve, arm_v8_1m_main_cde_mve_fp): Include
arm_cde.h and arm_mve.h as ineeded.

4 years agotestsuite: [arm/mve] Include arm_mve.h in arm_v8_1m_mve_ok
Christophe Lyon [Wed, 22 Apr 2020 13:53:29 +0000 (13:53 +0000)]
testsuite: [arm/mve] Include arm_mve.h in arm_v8_1m_mve_ok

Since arm_mve.h includes stdint.h, its use requires the presence of
the right gnu/stub-*.h, so make sure to include it when checking the
arm_v8_1m_mve_ok_nocache effective target, otherwise we can decide MVE
is supported while it's not really. This makes several tests
unsupported rather than fail.

2020-04-22  Christophe Lyon  <christophe.lyon@linaro.org>

gcc/testsuite/
* lib/target-supports.exp
(check_effective_target_arm_v8_1m_mve_ok_nocache): Include
arm_mve.h.

4 years agotestsuite: [arm/mve] Use dg-add-options arm_v8_1m_mve in MVE tests
Christophe Lyon [Wed, 22 Apr 2020 13:48:59 +0000 (13:48 +0000)]
testsuite: [arm/mve] Use dg-add-options arm_v8_1m_mve in MVE tests

Several ARM/MVE tests can be compiled even if the toolchain does not
support -mfloat-abi=hard (softfp is OK).

Use dg-add-options arm_v8_1m_mve or arm_v8_1m_mve_fp instead of using
dg-additional-options.

2020-04-22  Christophe Lyon  <christophe.lyon@linaro.org>

gcc/testsuite/
* gcc.target/arm/mve/intrinsics/mve_vector_float.c: Use
arm_v8_1m_mve_fp.
* gcc.target/arm/mve/intrinsics/mve_vector_float1.c: Likewise.
* gcc.target/arm/mve/intrinsics/mve_vector_float2.c: Likewise.
* gcc.target/arm/mve/intrinsics/mve_vector_int.c: Use
arm_v8_1m_mve.
* gcc.target/arm/mve/intrinsics/mve_vector_int1.c: Likewise.
* gcc.target/arm/mve/intrinsics/mve_vector_int2.c: Likewise.
* gcc.target/arm/mve/intrinsics/mve_vector_uint.c: Likewise.
* gcc.target/arm/mve/intrinsics/mve_vector_uint1.c: Likewise.
* gcc.target/arm/mve/intrinsics/mve_vector_uint2.c: Likewise.

4 years agotestsuite: [arm/mve] Fix mve_move_gpr_to_gpr.c
Christophe Lyon [Wed, 22 Apr 2020 13:47:35 +0000 (13:47 +0000)]
testsuite: [arm/mve] Fix mve_move_gpr_to_gpr.c

This test can pass with a hard-float toolchain, provided we don't
force -mfloat-abi=softfp.

This patch removes this useless option, as well as -save-temps which
is implied by arm_v8_1m_mve_fp.

2020-04-22  Christophe Lyon  <christophe.lyon@linaro.org>

gcc/testsuite/
* gcc.target/arm/mve/intrinsics/mve_move_gpr_to_gpr.c: Remove
useless options.

4 years agotestsuite: [arm/mve] Use arm_softfp and arm_hard as needed in MVE tests
Christophe Lyon [Wed, 22 Apr 2020 13:45:05 +0000 (13:45 +0000)]
testsuite: [arm/mve] Use arm_softfp and arm_hard as needed in MVE tests

Some MVE tests explicitly test a -mfloat-abi=hard option, but we need
to check that the toolchain actually supports it (which may not be the
case for arm-linux-gnueabi* targets). We can thus remove the related
dg-skip directives.

We also make use of dg-add-options arm_v8_1m_mve_fp and arm_v8_1m_mve
instead of duplicating the corresponding options in
dg-additional-options where we keep only -mfloat-abi to override the
option selected by arm_v8_1m_mve_fp.

2020-04-22  Christophe Lyon  <christophe.lyon@linaro.org>

gcc/testsuite/
* gcc.target/arm/mve/intrinsics/mve_fp_fpu1.c: Use arm_hard_ok
effective target and arm_v8_1m_mve_fp options.
* gcc.target/arm/mve/intrinsics/mve_fp_fpu2.c: Use arm_softfp_ok
effective target and arm_v8_1m_mve_fp options.
* gcc.target/arm/mve/intrinsics/mve_fpu1.c: Use arm_hard_ok
effective target and arm_v8_1m_mve options.
* gcc.target/arm/mve/intrinsics/mve_fpu2.c: Use arm_softfp_ok
effective target and arm_v8_1m_mve options.

4 years agotestsuite: [arm] Add arm_softfp_ok and arm_hard_ok effective targets.
Christophe Lyon [Wed, 22 Apr 2020 13:42:04 +0000 (13:42 +0000)]
testsuite: [arm] Add arm_softfp_ok and arm_hard_ok effective targets.

For arm-linux-gnueabi* targets, a toolchain cannot support the
float-abi opposite to the one it has been configured for: since glibc
does not support such multilibs, we end up lacking gnu/stubs-*.h when
including stdint.h for instance.

This patch introduces two new effective targets to detect whether we
can compile tests with -mfloat-abi=softfp or -mfloat-abi=hard.

This enables to make such tests unsupported rather than fail.

2020-04-22  Christophe Lyon  <christophe.lyon@linaro.org>

gcc/testsuite/
* lib/target-supports.exp (arm_softfp_ok): New effective target.
(arm_hard_ok): Likewise.

gcc/
* doc/sourcebuild.texi (arm_softfp_ok, arm_hard_ok): Document.

4 years ago[arm] Add initial support for Arm Cortex-M55
Kyrylo Tkachov [Wed, 22 Apr 2020 12:21:31 +0000 (13:21 +0100)]
[arm] Add initial support for Arm Cortex-M55

This patch adds initial -mcpu support for the Arm Cortex-M55 CPU.
This CPU is an Armv8.1-M Mainline CPU supporting MVE.
An option to disable floating-point (and MVE) is provided with the +nofp.
For GCC 11 I'd like to add further fine-grained options to enable integer-only MVE
but that needs a bit more elaborate surgery in arm-cpus.in that I don't want to do
in GCC 10 at this stage.

As this CPU is not supported in gas and I don't want to couple GCC 10 to the very
latest binutils anyway, this CPU emits the cpu string in the assembly file as a build attribute
rather than a .cpu directive, thus sparing us the need to support .cpu cortex-m55 in gas.
The .cpu directive in gas isn't used for anything besides setting the Tag_CPU_name
build attribute anyway (which itself is not used by any tools I'm aware of).
All the architecture information used for target detection is already emitted using .arch_extension
directives and similar.

Bootstrapped and tested on arm-none-linux-gnueabihf. Also tested on arm-none-eabi.

2020-04-22  Kyrylo Tkachov  <kyrylo.tkachov@arm.com>
            Andre Vieira  <andre.simoesdiasvieira@arm.com>
            Mihail Ionescu  <mihail.ionescu@arm.com>

* config/arm/arm.c (arm_file_start): Handle isa_bit_quirk_no_asmcpu.
* config/arm/arm-cpus.in (quirk_no_asmcpu): Define.
(ALL_QUIRKS): Add quirk_no_asmcpu.
(cortex-m55): Define new cpu.
* config/arm/arm-tables.opt: Regenerate.
* config/arm/arm-tune.md: Likewise.
* doc/invoke.texi (Arm Options): Document -mcpu=cortex-m55.

4 years ago[Fortran] Truncate warn with OpenMP/OpenACC/!GCC$ (PR94709)
Tobias Burnus [Wed, 22 Apr 2020 12:07:55 +0000 (14:07 +0200)]
[Fortran] Truncate warn with OpenMP/OpenACC/!GCC$ (PR94709)

While '!$' with -fopenmp unsets too often load_line's seen_comment flag,
this only affects <tab> warnings; for trunction warnings, gfc_next_char_literal
re-handles the directives correctly.  In terms of missed warnings, a directive
that is completely in the truncated part is not diagnosted (as it starts
with a '!').

        PR fortran/94709
        * scanner.c (load_line): In fixed form, also treat 'C' as comment and
        'D'/'d' only with -fd-lines-as-comments. Treat '!$' with -fopenmp,
        '!$acc' with -fopenacc and '!GCC$' as non-comment to permit <tab>
        and truncation warnings.

        PR fortran/94709
        * gfortran.dg/gomp/warn_truncated.f: New.
        * gfortran.dg/gomp/warn_truncated.f90: New.

4 years agoAdd a missed Changelog entry.
Iain Sandoe [Wed, 22 Apr 2020 11:20:15 +0000 (12:20 +0100)]
Add a missed Changelog entry.

4 years agoforwprop: Fix ICE when building an identity constructor [PR94700]
Richard Sandiford [Wed, 22 Apr 2020 10:05:59 +0000 (11:05 +0100)]
forwprop: Fix ICE when building an identity constructor [PR94700]

This is really PR94683 part 2, handling the case in which the vector is
an identity and so doesn't need a VEC_PERM_EXPR.  I should have realised
at the time that the other arm of the "if" would need the same fix.

2020-04-22  Richard Sandiford  <richard.sandiford@arm.com>

gcc/
PR tree-optimization/94700
* tree-ssa-forwprop.c (simplify_vector_constructor): When processing
an identity constructor, use a VIEW_CONVERT_EXPR to handle mixtures
of similarly-structured but distinct vector types.

gcc/testsuite/
PR tree-optimization/94700
* gcc.target/aarch64/sve/acle/general/pr94700.c: New test.

4 years agocoroutines, testsuite: Tidy some test names (NFC).
Iain Sandoe [Wed, 22 Apr 2020 09:43:22 +0000 (10:43 +0100)]
coroutines, testsuite: Tidy some test names (NFC).

Try to make sure that we have consistent naming for the tests
before first release.

gcc/testsuite/ChangeLog:

2020-04-22 Iain Sandoe <iain@sandoe.co.uk>

* g++.dg/coroutines/torture/local-var-0.C: Rename to...
* g++.dg/coroutines/torture/local-var-00-const.C: ...this.
* g++.dg/coroutines/torture/local-var-1.C: Rename to...
* g++.dg/coroutines/torture/local-var-01-single.C: ...this.
* g++.dg/coroutines/torture/local-var-2.C: Rename to...
* g++.dg/coroutines/torture/local-var-02-conditional.C: ...this.
* g++.dg/coroutines/torture/local-var-3.C: Rename to...
* g++.dg/coroutines/torture/local-var-03-with-awaits.C: ...this.
* g++.dg/coroutines/torture/local-var-4.C: Rename to...
* g++.dg/coroutines/torture/local-var-04-hiding-nested-scopes.C: this.
* g++.dg/coroutines/torture/local-var-5-awaitable.C: Rename to...
* g++.dg/coroutines/torture/local-var-05-awaitable.C: ...this.

4 years agocoroutines: Pass class reference to promise param preview [PR94682]
Iain Sandoe [Wed, 22 Apr 2020 08:49:20 +0000 (09:49 +0100)]
coroutines: Pass class reference to promise param preview [PR94682]

As reported in the PR, per [dcl.fct.def.coroutine]/4 we should
be passing a reference to the object to the promise parameter
preview, and we are currently passing a pointer (this).  Amend to
pass the reference.

gcc/cp/ChangeLog:

2020-04-22  Iain Sandoe  <iain@sandoe.co.uk>

PR c++/94682
* coroutines.cc (struct param_info): Add a field to note that
the param is 'this'.
(morph_fn_to_coro): Convert this to a reference before using it
in the promise parameter preview.

gcc/testsuite/ChangeLog:

2020-04-22  Iain Sandoe  <iain@sandoe.co.uk>

PR c++/94682
* g++.dg/coroutines/pr94682-preview-this.C: New test.

4 years agoMAINTAINERS: add myself for write after approval
Stefan Schulze Frielinghaus [Wed, 22 Apr 2020 07:20:08 +0000 (09:20 +0200)]
MAINTAINERS: add myself for write after approval

ChangeLog:

2020-04-22  Stefan Schulze Frielinghaus  <stefansf@linux.ibm.com>

* MAINTAINERS (Write After Approval): add myself

4 years agotestsuite: Handle --save-temps in schedule-cleanups
Christophe Lyon [Wed, 22 Apr 2020 06:34:49 +0000 (06:34 +0000)]
testsuite: Handle --save-temps in schedule-cleanups

Some tests use --save-temps, but schedule-cleanups strictly matches
-save-temps, so we leave many temporary files after validation.
Instead of fixing every offending testcase, it's simpler and
future-proof to make schedule-cleanups handle both --save-temps and
-save-temps.

2020-04-22  Christophe Lyon  <christophe.lyon@linaro.org>

gcc/testsuite/
* lib/gcc-dg.exp (schedule-cleanups): Accept --save-temps.

4 years agoc++: generic lambda forwarding function [PR94546]
Jason Merrill [Wed, 22 Apr 2020 06:27:54 +0000 (02:27 -0400)]
c++: generic lambda forwarding function [PR94546]

While instantiating test(Plot) we partially instantiate the generic lambda.
We look at forward<T>(rest)... and see that it's just replacing parameter
packs with new parameter packs and tries to do a direct substitution.  But
because register_parameter_specializations had built up a
NONTYPE_ARGUMENT_PACK around the new parameter pack, the substitution
failed.  So let's not wrap it that way.

gcc/cp/ChangeLog
2020-04-22  Jason Merrill  <jason@redhat.com>

PR c++/94546
* pt.c (register_parameter_specializations): If the instantiation is
still a parameter pack, don't wrap it in a NONTYPE_ARGUMENT_PACK.
(tsubst_pack_expansion, tsubst_expr): Adjust.

4 years agoc++: reject scalar array initialization with nullptr [PR94510]
Martin Sebor [Wed, 22 Apr 2020 06:27:54 +0000 (02:27 -0400)]
c++: reject scalar array initialization with nullptr [PR94510]

The change committed to GCC 9 to allow string literals as template arguments
caused the compiler to prune away, and thus miss diagnosing, conversion from
nullptr to int in an array initializer.  After looking at various approaches
to improving the pruning, we realized that the only place the pruning is
necessary is in the mangler.

gcc/cp/ChangeLog
2020-04-22  Martin Sebor  <msebor@redhat.com>
    Jason Merrill  <jason@redhat.com>

PR c++/94510
* decl.c (reshape_init_array_1): Avoid stripping redundant trailing
zero initializers...
* mangle.c (write_expression): ...and handle them here even for
pointers to members by calling zero_init_expr_p.
* cp-tree.h (zero_init_expr_p): Declare.
* tree.c (zero_init_expr_p): Define.
(type_initializer_zero_p): Remove.
* pt.c (tparm_obj_values): New hash_map.
(get_template_parm_object): Store to it.
(tparm_object_argument): New.

gcc/testsuite/ChangeLog
2020-04-22  Martin Sebor  <msebor@redhat.com>

PR c++/94510
* g++.dg/init/array58.C: New test.
* g++.dg/init/array59.C: New test.
* g++.dg/cpp2a/nontype-class34.C: New test.
* g++.dg/cpp2a/nontype-class35.C: New test.

4 years agolibstdc++: Improve tests for __cpp_lib_erase_if macro
Jonathan Wakely [Wed, 22 Apr 2020 06:21:01 +0000 (07:21 +0100)]
libstdc++: Improve tests for __cpp_lib_erase_if macro

* testsuite/21_strings/basic_string/erasure.cc: Check for updated
value of __cpp_lib_erase_if.
* testsuite/23_containers/deque/erasure.cc: Likewise.
* testsuite/23_containers/forward_list/erasure.cc: Likewise.
* testsuite/23_containers/list/erasure.cc: Likewise.
* testsuite/23_containers/map/erasure.cc: Likewise.
* testsuite/23_containers/set/erasure.cc: Likewise.
* testsuite/23_containers/unordered_map/erasure.cc: Likewise.
* testsuite/23_containers/unordered_set/erasure.cc: Likewise.
* testsuite/23_containers/vector/erasure.cc: Likewise.

4 years agoc++: Diagnose invalid use of member function in requires
Patrick Palka [Wed, 22 Apr 2020 02:18:50 +0000 (22:18 -0400)]
c++: Diagnose invalid use of member function in requires

This updates diagnose_valid_expression to mirror the convert_to_void check added
to tsubst_valid_expression_requirement by r10-7554.

gcc/cp/ChangeLog:

PR c++/67825
* constraint.cc (diagnose_valid_expression): Check convert_to_void here
as well as in tsubst_valid_expression_requirement.

gcc/testsuite/ChangeLog:

PR c++/67825
* g++.dg/concepts/diagnostic10.C: New test.
* g++.dg/cpp2a/concepts-pr67178.C: Adjust dg-message.

4 years agoDaily bump.
GCC Administrator [Wed, 22 Apr 2020 00:16:21 +0000 (00:16 +0000)]
Daily bump.

4 years agolibstdc++: Fix __normal_iterator comparisons for C++20
Jonathan Wakely [Tue, 21 Apr 2020 22:43:27 +0000 (23:43 +0100)]
libstdc++: Fix __normal_iterator comparisons for C++20

This fixes a regression introduced when I replaced __normal_iterator's
relational operators with operator<=>. If the wrapped iterator type
doesn't define operator<=> then __normal_iterator doesdn't either, which
breaks any use of fancy pointers that don't define <=>. The regression
was found when trying to build cmcstl2.

The solution is to use synth-three-way to define __normal_iterator's
spaceship operator, so that it is still defined even if the wrapped type
only supports operator<.

* include/bits/stl_iterator.h (__normal_iterator): Use synth-three-way
to define operator<=>.
* testsuite/24_iterators/normal_iterator/cmp_c++20.cc: New test.

4 years agoc++: Constrained inherited constructor template [PR94549]
Patrick Palka [Tue, 21 Apr 2020 22:41:02 +0000 (18:41 -0400)]
c++: Constrained inherited constructor template [PR94549]

A comment in satisfy_declaration_constraints says

  /* For inherited constructors, consider the original declaration;
     it has the correct template information attached. */
  d = strip_inheriting_ctors (d);

but it looks like this comment is wrong when the inherited constructor is for an
instantiation of a constructor template.  In that case, DECL_TEMPLATE_INFO is
correct and DECL_INHERITED_CTOR points to the constructor template of the base
class rather than to the particular instantiation of the constructor template
(and so the DECL_TI_ARGS of the DECL_INHERITED_CTOR are in their dependent
form).

So doing strip_inheriting_ctors in this case then eventually leads to
satisfy_associated_constraints returning true regardless of the constraints
themselves, due to the passed in 'args' being dependent.

An inherited constructor seems to have a non-empty DECL_TEMPLATE_INFO only when
it's for an instantiation of a constructor template, so this patch fixes this
issue by checking for empty DECL_TEMPLATE_INFO before calling
strip_inheriting_ctors.

There is another unguarded call to strip_inheriting_ctors in
get_normalized_constraints_from_decl, but this one seems to be safe to do
unconditionally because the rest of that function doesn't need/look at the
DECL_TI_ARGS of the decl.

gcc/cp/ChangeLog:

PR c++/94549
* constraint.cc (satisfy_declaration_constraints): Don't strip the
inherited constructor if it already has template information.

gcc/testsuite/ChangeLog:

PR c++/94549
* g++.dg/concepts/inherit-ctor3.C: Adjust expected diagnostics.
* g++.dg/cpp2a/concepts-inherit-ctor4.C: New test.
* g++.dg/cpp2a/concepts-inherit-ctor8.C: New test.

4 years agotestsuite: Fix position of changelog entry
Jonathan Wakely [Tue, 21 Apr 2020 21:20:23 +0000 (22:20 +0100)]
testsuite: Fix position of changelog entry

One of the changelog entries in commit d76925e46fad09fc9be67 got put in
the wrong place after a rebase. This places it correctly.

4 years agolibstdc++: Improve C++14 and C++17 status docs
Jonathan Wakely [Tue, 21 Apr 2020 21:18:51 +0000 (22:18 +0100)]
libstdc++: Improve C++14 and C++17 status docs

This adds a full table of contents for the C++14 and C++17 standards,
with status for each part.

For C++14 the list of proposals is removed, as it adds little value now
that everything is supported. For C++17 the table of proposals is
retained, because it documents he feature test macros for the features.

* doc/Makefile.am (xml_sources_manual): Add missing XML files.
* doc/Makefile.in: Regenerate.
* doc/xml/manual/status_cxx1998.xml: Refer to "this section" instead
of "this page".
* doc/xml/manual/status_cxx2011.xml: Formatting and other corrections
to the C++11 status table.
* doc/xml/manual/status_cxx2014.xml: Replace list of C++14 feature
proposals with table matching contents of the C++14 standard.
* doc/xml/manual/status_cxx2017.xml: Add table matching contents of
the C++17 standard.
* doc/html/*: Regenerate.

4 years agolibstdc++: Support arrays in std::is_nothrow_constructible (PR 94149)
Jonathan Wakely [Tue, 21 Apr 2020 21:18:51 +0000 (22:18 +0100)]
libstdc++: Support arrays in std::is_nothrow_constructible (PR 94149)

The front end now supports parenthesized initialization for arrays in
C++20, so extend std::is_nothrow_constructible to support them too.

gcc/testsuite:

PR c++/94149
* g++.dg/cpp2a/paren-init24.C: Fix FIXMEs.

libstdc++-v3:

PR c++/94149
* include/std/type_traits (__is_nt_constructible_impl): Add partial
specializations for bounded arrays with non-empty initializers.
* testsuite/20_util/is_nothrow_constructible/value_c++20.cc: New test.

4 years agolibphobos: Remove GDCFLAGSX variable from configure scripts.
Iain Buclaw [Tue, 21 Apr 2020 21:03:23 +0000 (23:03 +0200)]
libphobos: Remove GDCFLAGSX variable from configure scripts.

Always run testsuite with same GDCFLAGS as used in build.

libphobos/ChangeLog:

* Makefile.in: Regenerate.
* configure: Regenerate.
* configure.ac: Remove GDCFLAGSX.
* libdruntime/Makefile.in: Regenerate.
* src/Makefile.in: Regenerate.
* testsuite/Makefile.in: Regenerate.
* testsuite/testsuite_flags.in: Use GDCFLAGS in --gdcflags.
* testsuite/libphobos.thread/fiber_guard_page.d: Test using -O0.

4 years agoPR middle-end/94647 - bogus -Warray-bounds on strncpy into a larger member array...
Martin Sebor [Tue, 21 Apr 2020 16:59:24 +0000 (10:59 -0600)]
PR middle-end/94647 - bogus -Warray-bounds on strncpy into a larger member array from a smaller array

gcc/ChangeLog:

PR middle-end/94647
* gimple-ssa-warn-restrict.c (builtin_access::builtin_access): Correct
the computation of the lower bound of the source access size.
(builtin_access::generic_overlap): Remove a hack for setting ranges
of overlap offsets.

gcc/testsuite/ChangeLog:

PR middle-end/94647
* c-c++-common/Warray-bounds-2.c: Adjust a test case and add a new one.
* c-c++-common/Warray-bounds-3.c: Add tests for missing warnings.
* c-c++-common/Wrestrict.c: Invert bounds in printed ranges.
* gcc.dg/Warray-bounds-59.c: New test.
* gcc.dg/Wrestrict-10.c: Add a missing warning.
* gcc.dg/Wrestrict-5.c: Adjust text of expected warning.
* gcc.dg/Wrestrict-6.c: Expect to see a range of overlap offsets.

4 years agoaarch64, libgcc: Fix unwinding from pac-ret to normal frames [PR94514]
Szabolcs Nagy [Fri, 3 Apr 2020 09:35:41 +0000 (09:35 +0000)]
aarch64, libgcc: Fix unwinding from pac-ret to normal frames [PR94514]

With -mbranch-protection=pac-ret the debug info toggles the
signedness state of the return address so the unwinder knows when
the return address needs pointer authentication.

The unwind context flags were not updated according to the dwarf
frame info.

This causes unwinding across frames that were built without pac-ret
to incorrectly authenticate the return address wich corrupts the
return address on a system where PAuth is enabled.

Note: This even affects systems where all code use pac-ret because
unwinding across a signal frame the return address is not signed.

gcc/testsuite/ChangeLog:

PR target/94514
* g++.target/aarch64/pr94514.C: New test.
* gcc.target/aarch64/pr94514.c: New test.

libgcc/ChangeLog:

PR target/94514
* config/aarch64/aarch64-unwind.h (aarch64_frob_update_context):
Update context->flags accroding to the frame state.

4 years agoFix weakening of external declarations.
John David Anglin [Tue, 21 Apr 2020 16:33:23 +0000 (16:33 +0000)]
Fix weakening of external declarations.

2020-04-21  John David Anglin  <danglin@gcc.gnu.org>

* config/pa/som.h (ASM_WEAKEN_LABEL): Delete.
(ASM_WEAKEN_DECL): New define.
(HAVE_GAS_WEAKREF): Undefine.

4 years agoforwprop: Fix ICE when building a VEC_PERM_EXPR [PR94683]
Richard Sandiford [Tue, 21 Apr 2020 15:11:07 +0000 (16:11 +0100)]
forwprop: Fix ICE when building a VEC_PERM_EXPR [PR94683]

The type compatibility handling in simplify_vector_constructor is
based on the number of elements and on element type compatibility,
but that's no longer enough to ensure that two vector types are
compatible.  This patch uses a VIEW_CONVERT_EXPR if the permutation
type and result type are distinct.

2020-04-21  Richard Sandiford  <richard.sandiford@arm.com>

gcc/
PR tree-optimization/94683
* tree-ssa-forwprop.c (simplify_vector_constructor): Use a
VIEW_CONVERT_EXPR to handle mixtures of similarly-structured
but distinct vector types.

gcc/testsuite/
PR tree-optimization/94683
* gcc.target/aarch64/sve/acle/general/pr94683.c: New test.

4 years agotestsuite: Extend C++ struct-layout-1.exp testing to test C++14 vs. C++17 interoperab...
Jakub Jelinek [Tue, 21 Apr 2020 15:08:10 +0000 (17:08 +0200)]
testsuite: Extend C++ struct-layout-1.exp testing to test C++14 vs. C++17 interoperability of structs with empty bases [PR94383]

Jonathan reported an ABI incompatibility between C++14 and C++17 in
passing some aggregates with empty bases on aarch64 (and apparently on arm
too).

The following patch adds 3000 (by default) tests for such interoperability,
using the struct-layout-1* framework.  The current 3000 tests are generated
as is (so unchanged from previous ones), and afterwards there is another set
of 3000 ones, where always one of the tNNN_x.C and tNNN_y.C tests get added
-std=c++14 -DCXX14_VS_CXX17 and another one -std=c++17 -DCXX14_VS_CXX17
options (which one which is chosen pseudo-randomly), which causes the
structs to have an empty base.

I haven't added (yet) checks if the alternate compiler does support these
options (I think that can be done incrementally), so for now this testing is
done only if the alternate compiler is not used.

I had to fix a bug in the flexible array handling, because while we were
lucky in the 3000 generated tests not to have toplevel fields after field
with flexible array members, in the next 3000 we aren't lucky anymore.
But even with that change, diff -upr between old and new
testsuite/g++/g++.dg/g++.dg-struct-layout-1/ doesn't show any differences
except for the ^Only in... messages for the new tests in there.

Bootstrapped/regtested on x86_64-linux and i686-linux and additionally
tested on aarch64-linux, where
FAIL: tmpdir-g++.dg-struct-layout-1/t032 cp_compat_x_tst.o-cp_compat_y_tst.o execute
FAIL: tmpdir-g++.dg-struct-layout-1/t056 cp_compat_x_tst.o-cp_compat_y_tst.o execute
FAIL: tmpdir-g++.dg-struct-layout-1/t057 cp_compat_x_tst.o-cp_compat_y_tst.o execute
FAIL: tmpdir-g++.dg-struct-layout-1/t058 cp_compat_x_tst.o-cp_compat_y_tst.o execute
FAIL: tmpdir-g++.dg-struct-layout-1/t059 cp_compat_x_tst.o-cp_compat_y_tst.o execute
because of the backend bug, and with that bug fixed it succeeds.
Matthew has kindly tested it also on aarch64-linux and arm*-*.

The primary goal of the patch is catch if some targets other than aarch64 or
arm aren't affected too.

2020-04-21  Jakub Jelinek  <jakub@redhat.com>

PR c++/94383
* g++.dg/compat/struct-layout-1.exp: If !$use_alt, add -c to generator
args.
* g++.dg/compat/struct-layout-1_generate.c (dg_options): Add another
%s to the start of dg-options arg.
(cxx14_vs_cxx17, do_cxx14_vs_cxx17): New variables.
(switchfiles): If cxx14_vs_cxx17, prepend -std=c++14 -DCXX14_VS_CXX17
or -std=c++17 -DCXX17_VS_CXX14 - randomly - to dg-options.
(output): Don't append further fields once one with flexible array
member is added.
(generate_random_tests): Don't use toplevel unions if cxx14_vs_cxx17.
(main): If -c, emit second set of tests for -std=c++14 vs. -std=c++17
testing.
* g++.dg/compat/struct-layout-1_x1.h (empty_base): New type.
(EMPTY_BASE): Define.
(TX): Use EMPTY_BASE.
* g++.dg/compat/struct-layout-1_y1.h (empty_base): New type.
(EMPTY_BASE): Define.
(TX): Use EMPTY_BASE.

4 years agoubsan: Avoid -Wpadded warnings [PR94641]
Jakub Jelinek [Tue, 21 Apr 2020 15:06:31 +0000 (17:06 +0200)]
ubsan: Avoid -Wpadded warnings [PR94641]

-Wpadded warnings aren't really useful for the artificial types that GCC
lays out for ubsan.

2020-04-21  Jakub Jelinek  <jakub@redhat.com>

PR c/94641
* stor-layout.c (place_field, finalize_record_size): Don't emit
-Wpadded warning on TYPE_ARTIFICIAL rli->t.
* ubsan.c (ubsan_get_type_descriptor_type,
ubsan_get_source_location_type, ubsan_create_data): Set
TYPE_ARTIFICIAL.
* asan.c (asan_global_struct): Likewise.

* c-c++-common/ubsan/pr94641.c: New test.

4 years agoc++: Dependent conversion operator in concept [PR94597]
Patrick Palka [Tue, 21 Apr 2020 14:56:57 +0000 (10:56 -0400)]
c++: Dependent conversion operator in concept [PR94597]

When building the parameter mapping for an atomic constraint,
find_template_parameters does not spot the template parameter within the
conversion-type-id of a dependent conversion operator, which later leads to an
ICE during substitution when looking up the missing template argument for this
unnoticed template parameter.

gcc/cp/ChangeLog:

PR c++/94597
* pt.c (any_template_parm_r) <case IDENTIFIER_NODE>: New case.  If this
is a conversion operator, visit its TREE_TYPE.

gcc/testsuite/ChangeLog:

PR c++/94597
* g++.dg/cpp2a/concepts-conv2.C: New test.

4 years agoaarch64: Add an error message in large code model for ilp32 [PR94577]
XieZhiheng [Tue, 21 Apr 2020 14:09:23 +0000 (15:09 +0100)]
aarch64: Add an error message in large code model for ilp32 [PR94577]

The option -mabi=ilp32 should not be used in large code model. An error
message is added for the option conflict.

2020-04-21  Duan bo  <duanbo3@huawei.com>

gcc/
PR target/94577
* config/aarch64/aarch64.c: Add an error message for option conflict.
* doc/invoke.texi (-mcmodel=large): Mention that -mcmodel=large is
incompatible with -fpic, -fPIC and -mabi=ilp32.

gcc/testsuite/
PR target/94577
* gcc.target/aarch64/pr94577.c: New test.

4 years agoc++: ICE with ptr_plus_expr
Nathan Sidwell [Tue, 21 Apr 2020 13:46:42 +0000 (06:46 -0700)]
c++: ICE with ptr_plus_expr

An ICE on darwin, when a SFINAE-context substitution produced
error_mark_node foo an operand of a POINTER_PLUS_EXPR.
fold_build_pointer_plus is unprepared to deal with that, so we need to
check earlier.  We had no luck reducing the testcase to something
manageable.

* pt.c (tsubst_copy_and_build) [POINTER_PLUS_EXPR]: Check for
error_mark_node.

4 years agoRemove fishy self-assignment in omp-low.c [PR94629]
Frederik Harwath [Tue, 21 Apr 2020 10:36:14 +0000 (12:36 +0200)]
Remove fishy self-assignment in omp-low.c [PR94629]

The PR noticed that omp-low.c contains a self-assignment in the
function new_omp_context:

if (outer_ctx) {
    ...
    ctx->outer_reduction_clauses = ctx->outer_reduction_clauses;

This is obviously useless.  The original intention might have been
to copy the field from the outer_ctx to ctx.  Since this is done
(properly) in the only function where this field is actually used
(in function scan_omp_for) and the field is being initialized to zero
during the struct allocation, there is no need to attempt to do
anything to this field in new_omp_context. Thus this commit
removes any assignment to the field from new_omp_context.

2020-04-21  Frederik Harwath  <frederik@codesourcery.com>

PR other/94629
* gcc/omp-low.c (new_omp_context): Remove assignments to
ctx->outer_reduction_clauses and ctx->local_reduction_clauses.

Reviewed-by: Thomas Schwinge <thomas@codesourcery.com>
4 years agolibphobos: Fix compilation dependencies on s390x-linux-musl
Iain Buclaw [Mon, 20 Apr 2020 16:20:12 +0000 (18:20 +0200)]
libphobos: Fix compilation dependencies on s390x-linux-musl

libphobos/ChangeLog:

* configure: Regenerate.
* configure.ac: Call DRUNTIME_LIBRARIES_UCONTEXT.
* m4/druntime/libraries.m4 (DRUNTIME_LIBRARIES_UCONTEXT): Define to
search libraries for swapcontext.
* libdruntime/gcc/sections/elf_shared.d (getTLSRange): Always use
__tls_get_addr on Musl.

Co-Authored-By: Mathias Lang <pro.mathias.lang@gmail.com>
4 years agotestsuite: Add testcase for already fixed PR [PR94686]
Jakub Jelinek [Tue, 21 Apr 2020 10:47:46 +0000 (12:47 +0200)]
testsuite: Add testcase for already fixed PR [PR94686]

This has been fixed by the PR71311 r7-1170-g4618c453205f18
change.

2020-04-21  Jakub Jelinek  <jakub@redhat.com>

PR c/94686
* gcc.c-torture/compile/pr94686.c: New test.

4 years agocoroutines: Fix handling of ramp return value [PR94661]
Iain Sandoe [Tue, 21 Apr 2020 09:35:13 +0000 (10:35 +0100)]
coroutines: Fix handling of ramp return value [PR94661]

Coroutine ramp functions have synthesised return values (the
user-authored function body cannot have an explicit 'return').
The current implementation attempts to optimise by building
the return in-place, in the manner of C++17 code. Clearly,
that was too ambitious and the fix builds a target expr for
the constructed version and passes that to finish_return_stmt.

This also means that we now get the same error messages for
implicit use of deleted CTORs etc.

gcc/cp/ChangeLog:

2020-04-21 Iain Sandoe <iain@sandoe.co.uk>

PR c++/94661
* coroutines.cc (morph_fn_to_coro): Simplify return
value computation.

gcc/testsuite/ChangeLog:

2020-04-21 Iain Sandoe <iain@sandoe.co.uk>

PR c++/94661
* g++.dg/coroutines/ramp-return-a.C: New test.
* g++.dg/coroutines/ramp-return-b.C: New test.
* g++.dg/coroutines/ramp-return-c.C: New test.

4 years agoSince the pdp11-aout target does not support gdb, gdbserver or gprof these should...
Stephen Casner [Tue, 21 Apr 2020 09:44:32 +0000 (10:44 +0100)]
Since the pdp11-aout target does not support gdb, gdbserver or gprof these should be excluded in configure.

PR 25830
* configure.ac (noconfigdirs): Exclude gdb & gprof for pdp11.
* configure: Rebuild.

4 years agolibstdc++: Fix PSTL tests to run correctly with newer Thread Building Blocks
Thomas Rodgers [Tue, 21 Apr 2020 08:01:26 +0000 (01:01 -0700)]
libstdc++: Fix PSTL tests to run correctly with newer Thread Building Blocks

* testsuite/lib/libstdc++.exp: Add additional_flags=
-DTBB_SUPRESS_DEPRECATED_MESSAGES=1 to suppress warnings when
compiling with a newer Thread Building Blocks.

4 years agod/dmd: Merge upstream dmd 62ce36f37
Iain Buclaw [Tue, 21 Apr 2020 06:50:12 +0000 (08:50 +0200)]
d/dmd: Merge upstream dmd 62ce36f37

Adjusts the hardcoded index of Error.bypassException.

Fixes: PR d/94623

Reviewed-on: https://github.com/dlang/dmd/pull/11052

4 years agogccgo: fix runtime compilation on NetBSD
Benny Siegert [Mon, 20 Apr 2020 14:11:14 +0000 (16:11 +0200)]
gccgo: fix runtime compilation on NetBSD

si_code in siginfo_t is a macro on NetBSD, not a member of the
struct itself, so add a C trampoline for receiving its value.

Also replace references to mos.waitsemacount with the replacement and
add some helpers from os_netbsd.go in the GC repository.

Update golang/go#38538.

Reviewed-on: https://go-review.googlesource.com/c/gofrontend/+/228918

4 years agoDaily bump.
GCC Administrator [Tue, 21 Apr 2020 00:16:20 +0000 (00:16 +0000)]
Daily bump.

4 years agoc++: Fix ICE with { } as template argument [PR94592]
Marek Polacek [Fri, 17 Apr 2020 19:47:15 +0000 (15:47 -0400)]
c++: Fix ICE with { } as template argument [PR94592]

As an extension (there should be a CWG about this though), we support
braced-init-list as a template argument, but convert_nontype_argument
had trouble digesting them.  We ICEd because of the double coercion we
perform for template arguments: convert_nontype_argument called from
finish_template_type got a { }, and since a class type was involved and
we were in a template, convert_like created an IMPLICIT_CONV_EXPR.  Then
the second conversion of the same argument crashed in constexpr.c
because the IMPLICIT_CONV_EXPR had gotten wrapped in a TARGET_EXPR.
Another issue was that an IMPLICIT_CONV_EXPR leaked to constexpr.c when
building an aggregate init.

We should have instantiated the IMPLICIT_CONV_EXPR in the first call to
convert_nontype_argument, but we didn't, because the call to
is_nondependent_constant_expression returned false because it checks
!BRACE_ENCLOSED_INITIALIZER_P.  Then non_dep was false even though the
expression didn't contain anything dependent and we didn't instantiate
it in convert_nontype_argument.  To fix this, check
BRACE_ENCLOSED_INITIALIZER_P in cxx_eval_outermost_constant_expr rather
than in is_nondependent_*.

PR c++/94592
* constexpr.c (cxx_eval_outermost_constant_expr): Return when T is
a BRACE_ENCLOSED_INITIALIZER_P.
(is_nondependent_constant_expression): Don't check
BRACE_ENCLOSED_INITIALIZER_P.
(is_nondependent_static_init_expression): Likewise.

* g++.dg/cpp2a/nontype-class34.C: New test.
* g++.dg/cpp2a/nontype-class35.C: New test.

4 years agoc++: Recursive unification with packs and explicit targs [PR94628]
Patrick Palka [Mon, 20 Apr 2020 22:34:00 +0000 (18:34 -0400)]
c++: Recursive unification with packs and explicit targs [PR94628]

This PR seems to be similar to PR c++/43382, except that the recursive call to
the variadic function with trailing return type in this testcase is additionally
given some explicit template arguments.

In the first testcase below, when resolving the recursive call to 'select',
fn_type_unification first substitutes in the call's explicit template arguments
before doing unification, and so during this substitution the template argument
pack for Args is incomplete.

Since the pack is incomplete, the substitution of 'args...' in the trailing
return type decltype(f(args...)) is handled by the unsubstituted_packs case of
tsubst_pack_expansion.  But the handling of this case happens _before_ we reset
local_specializations, and so the substitution ends up reusing the old binding
for 'args' from local_specializations rather than building a new one.

This patch fixes this issue by setting up local_specializations sooner in
tsubst_pack_expansion, before the handling of the unsubstituted_packs case.
It also adds a new policy to local_specialization_stack so that we could use the
class here to conditionally replace local_specializations.

gcc/cp/ChangeLog:

PR c++/94628
* cp-tree.h (lss_policy::lss_nop): New enumerator.
* pt.c (local_specialization_stack::local_specialization_stack): Handle
an lss_nop policy.
(local_specialization_stack::~local_specialization_stack): Likewise.
(tsubst_pack_expansion): Use a local_specialization_stack instead of
manually saving and restoring local_specializations.  Conditionally
replace local_specializations sooner, before the handling of the
unsubstituted_packs case.

gcc/testsuite/ChangeLog:

PR c++/94628
* g++.dg/cpp0x/variadic179.C: New test.
* g++.dg/cpp0x/variadic180.C: New test.

4 years agoUpdate gcc sv.po.
Joseph Myers [Mon, 20 Apr 2020 21:39:08 +0000 (21:39 +0000)]
Update gcc sv.po.

* sv.po: Update.

4 years agoAdd 'dg-do run' to 'libgomp.fortran/target-enter-data-2.F90'
Thomas Schwinge [Mon, 20 Apr 2020 14:15:07 +0000 (16:15 +0200)]
Add 'dg-do run' to 'libgomp.fortran/target-enter-data-2.F90'

Fix-up for commit af557050fd011a03d21dc26b31959033061a0443 "[OpenMP] Fix 'omp
exit data' for Fortran arrays (PR 94635)".

libgomp/
PR middle-end/94635
* testsuite/libgomp.fortran/target-enter-data-2.F90: Add 'dg-do
run'.

4 years agolibstdc++: Add test for using istreambuf_iterator with sentinel
Jonathan Wakely [Mon, 20 Apr 2020 21:06:32 +0000 (22:06 +0100)]
libstdc++: Add test for using istreambuf_iterator with sentinel

This test was supposed to be added two months ago as part of commit
120e873484f20d9a0b8400e2e464ac5b2088a747 but was omitted by mistake.

* testsuite/24_iterators/istreambuf_iterator/sentinel.cc: New test.

4 years agolibstdc++: Fix tests that fail in C++20 mode
Jonathan Wakely [Mon, 20 Apr 2020 21:06:32 +0000 (22:06 +0100)]
libstdc++: Fix tests that fail in C++20 mode

* testsuite/20_util/is_constructible/51185.cc: Make test class a
non-aggregate so that the test verifies the same thing in all -std
modes.
* testsuite/20_util/is_constructible/value-2.cc: Adjust expected
results for some types when paren-init for aggregates is supported.

4 years agoc++: Fix bogus -Wparentheses warning with fold-expression [PR94505]
Marek Polacek [Sun, 19 Apr 2020 16:12:01 +0000 (12:12 -0400)]
c++: Fix bogus -Wparentheses warning with fold-expression [PR94505]

We issue bogus -Wparentheses warnings (3 of them!) for this fold expression:

  ((B && true) || ...)

Firstly, issuing a warning for a compiler-generated expression is wrong
and secondly, B && true must be wrapped in ( ) otherwise you'll get
error: binary expression in operand of fold-expression.

PR c++/94505 - bogus -Wparentheses warning with fold-expression.
* pt.c (fold_expression): Add warning_sentinel for -Wparentheses
before calling build_x_binary_op.

* g++.dg/cpp1z/fold11.C: New test.

4 years agocoroutines: Fix STRIP_NOPS usage.
Marek Polacek [Mon, 20 Apr 2020 17:37:35 +0000 (13:37 -0400)]
coroutines: Fix STRIP_NOPS usage.

parm = STRIP_NOPS (parm); is unnecessary and generates
warning: operation on 'parm' may be undefined [-Wsequence-point]
when cp/coroutines.cc is compiled with -std=c++11.

* coroutines.cc (captures_temporary): Don't assign the result of
STRIP_NOPS to the same variable.

4 years agoS/390: Fix PR94666
Andreas Krebbel [Mon, 20 Apr 2020 18:06:53 +0000 (20:06 +0200)]
S/390: Fix PR94666

The vector popcount expanders use a hardcoded subreg.  This might lead
to double subregs being generated which then fail to match.  With this
patch simplify_gen_subreg is used instead to fold the subregs.

gcc/ChangeLog:

2020-04-20  Andreas Krebbel  <krebbel@linux.ibm.com>

* config/s390/vector.md ("popcountv8hi2_vx", "popcountv4si2_vx")
("popcountv2di2_vx"): Use simplify_gen_subreg.

gcc/testsuite/ChangeLog:

2020-04-20  Andreas Krebbel  <krebbel@linux.ibm.com>

* g++.dg/pr94666.C: New test.

4 years agoPR94613: Fix vec_sel builtin for IBM Z
Andreas Krebbel [Mon, 20 Apr 2020 17:36:33 +0000 (19:36 +0200)]
PR94613: Fix vec_sel builtin for IBM Z

The vsel instruction is a bit-wise select instruction.  Using an
IF_THEN_ELSE to express it in RTL is wrong and leads to wrong code being
generated in the combine pass.

With the patch the pattern is written using bit operations.  However,
I've just noticed that the manual still demands a fixed point mode for
AND/IOR and friends although several targets emit bit ops on floating
point vectors (including i386, Power, and s390). So I assume this is a
safe thing to do?!

gcc/ChangeLog:

2020-04-20  Andreas Krebbel  <krebbel@linux.ibm.com>

PR target/94613
* config/s390/s390-builtin-types.def: Add 3 new function modes.
* config/s390/s390-builtins.def: Add mode dependent low-level
builtin and map the overloaded builtins to these.
* config/s390/vx-builtins.md ("vec_selV_HW"): Rename to ...
("vsel<V_HW"): ... this and rewrite the pattern with bitops.

gcc/testsuite/ChangeLog:

2020-04-20  Andreas Krebbel  <krebbel@linux.ibm.com>

PR target/94613
* gcc.target/s390/zvector/pr94613.c: New test.
* gcc.target/s390/zvector/vec_sel-1.c: New test.

4 years agoAdd numerous flags to the -fdump-fortran-original attribute dump.
Thomas König [Mon, 20 Apr 2020 17:19:20 +0000 (19:19 +0200)]
Add numerous flags to the -fdump-fortran-original attribute dump.

2020-04-20  Thomas Koenig  <tkoenig@gcc.gnu.org>

* dump-parse-tree.c (show_attr): Add numerous flags, some cleanup.

4 years agolibstdc++: Correct changelog of previous commit
Jonathan Wakely [Mon, 20 Apr 2020 16:54:50 +0000 (17:54 +0100)]
libstdc++: Correct changelog of previous commit

After committing it I noticed I'd also accidentally added a change to
__synth3way as well, which I meant to do in a separate commit. I've
updated the changelog entry to reflect that additional change.

* libsupc++/compare (__detail::__synth3way): Add noexcept-specifier.

4 years agolibphobos: Fix option name for --with-libphobos-druntime-only.
Iain Buclaw [Mon, 20 Apr 2020 16:50:36 +0000 (18:50 +0200)]
libphobos: Fix option name for --with-libphobos-druntime-only.

libphobos/ChangeLog:

* configure: Regenerate.
* configure.ac: Fix option name for --with-libphobos-druntime-only.

4 years agolibstdc++: Update __cpp_lib_three_way_comparison macro
Jonathan Wakely [Mon, 20 Apr 2020 16:50:10 +0000 (17:50 +0100)]
libstdc++: Update __cpp_lib_three_way_comparison macro

With P1614R2 fully implemented (except for the <chrono> types which we
don't support at all) we can define the feature test macro to the new
value.

* include/std/version (__cpp_lib_three_way_comparison): Update value.
* libsupc++/compare (__cpp_lib_three_way_comparison): Likewise.

4 years agolibstdc++: Add comparison operators to associative containers
Jonathan Wakely [Mon, 20 Apr 2020 16:50:10 +0000 (17:50 +0100)]
libstdc++: Add comparison operators to associative containers

The last C++20 changes from P1614R2, "The Mothership has Landed"

* include/bits/stl_map.h (map): Define operator<=> and remove
operator< for C++20.
* include/bits/stl_multimap.h (multimap): Likewise.
* include/bits/stl_multiset.h (multiset): Likewise.
* include/bits/stl_set.h (set): Likewise.
* include/bits/stl_tree.h (_Rb_tree): Likewise.
(_Rb_tree_iterator, _Rb_tree_const_iterator): Remove redundant
operator!= for C++20.
* include/debug/map.h (__gnu_debug::map): Define operator<=> for C++20.
* include/debug/multimap.h (__gnu_debug::multimap): Likewise.
* include/debug/multiset.h (__gnu_debug::multiset): Likewise.
* include/debug/set.h (__gnu_debug::set): Likewise.
* testsuite/23_containers/map/operators/cmp_c++20.cc: New test.
* testsuite/23_containers/multimap/operators/cmp_c++20.cc: New test.
* testsuite/23_containers/multiset/operators/cmp_c++20.cc: New test.
* testsuite/23_containers/set/operators/cmp_c++20.cc: New test.

4 years agolibphobos: Remove undefined DRUNTIME_GC from configure scripts
Iain Buclaw [Mon, 20 Apr 2020 16:29:34 +0000 (18:29 +0200)]
libphobos: Remove undefined DRUNTIME_GC from configure scripts

libphobos/ChangeLog:

* configure: Regenerate.
* configure.ac: Remove DRUNTIME_GC.

4 years agovect: Tweak vect_better_loop_vinfo_p handling of variable VFs
Richard Sandiford [Mon, 20 Apr 2020 16:13:29 +0000 (17:13 +0100)]
vect: Tweak vect_better_loop_vinfo_p handling of variable VFs

This patch fixes a large lmbench performance regression with
128-bit SVE, compiled in length-agnostic mode.

vect_better_loop_vinfo_p (new in GCC 10) tries to estimate whether
a new loop_vinfo is cheaper than a previous one, with an in-built
preference for the old one.  For variable VF it prefers the old
loop_vinfo if it is cheaper for at least one VF.  However, we have
no idea how likely that VF is in practice.

Another extreme would be to do what most of the rest of the
vectoriser does, and rely solely on the constant estimated VF.
But as noted in the comment, this means that a one-unit cost
difference would be enough to pick the new loop_vinfo,
despite the target generally preferring the old loop_vinfo
where possible.  The cost model just isn't accurate enough
for that to produce good results as things stand: there might
not be any practical benefit to the new loop_vinfo at the
estimated VF, and it would be significantly worse for higher VFs.

The patch instead goes for a hacky compromise: make sure that the new
loop_vinfo is also no worse than the old loop_vinfo at double the
estimated VF.  For all but trivial loops, this ensures that the
new loop_vinfo is only chosen if it is better than the old one
by a non-trivial amount at the estimated VF.  It also avoids
putting too much faith in the VF estimate.

I realise this isn't great, but it's supposed to be a conservative fix
suitable for stage 4.  The only affected testcases are the ones for
pr89007-*.c, where Advanced SIMD is indeed preferred for 128-bit SVE
and is no worse for 256-bit SVE.

Part of the problem here is that if the new loop_vinfo is better,
we discard the old one and never consider using it even as an
epilogue loop.  This means that if we choose Advanced SIMD over SVE,
we're much more likely to have left-over scalar elements.

Another is that the estimate provided by estimated_poly_value might have
different probabilities attached.  E.g. when tuning for a particular core,
the estimate is probably accurate, but when tuning for generic code,
the estimate is more of a guess.  Relying solely on the estimate is
probably correct for the former but not for the latter.

Hopefully those are things that we could tackle in GCC 11.

2020-04-20  Richard Sandiford  <richard.sandiford@arm.com>

gcc/
* tree-vect-loop.c (vect_better_loop_vinfo_p): If old_loop_vinfo
has a variable VF, prefer new_loop_vinfo if it is cheaper for the
estimated VF and is no worse at double the estimated VF.

gcc/testsuite/
* gcc.target/aarch64/sve/cost_model_8.c: New test.
* gcc.target/aarch64/sve/cost_model_9.c: Likewise.
* gcc.target/aarch64/sve/pr89007-1.c: Add -msve-vector-bits=512.
* gcc.target/aarch64/sve/pr89007-2.c: Likewise.

4 years agoaarch64: Fix vector builds used by SVE vec_init [PR94668]
Richard Sandiford [Mon, 20 Apr 2020 14:43:32 +0000 (15:43 +0100)]
aarch64: Fix vector builds used by SVE vec_init [PR94668]

This testcase triggered an ICE in rtx_vector_builder::step because
we were trying to use a stepped representation for floating-point
constants.  The underlying problem was that the arguments to
rtx_vector_builder were the wrong way around, meaning that some
variations were likely to be incorrectly encoded for integers
(but probably as a silent failure).

Also, aarch64_sve_expand_vector_init_handle_trailing_constants
tries to extend the trailing constant elements to a full vector
by following the "natural" pattern of the original vector, which
should generally lead to nicer constants.  However, for the testcase,
we'd then end up picking a variable for some elements.  Fixed by
stubbing out all variable elements with zeros.

That fix involved testing valid_for_const_vector_p.  For consistency,
the patch uses the same test when finding trailing constants, instead
of the previous aarch64_legitimate_constant_p.

2020-04-20  Richard Sandiford  <richard.sandiford@arm.com>

gcc/
PR target/94668
* config/aarch64/aarch64.c (aarch64_sve_expand_vector_init): Fix
order of arguments to rtx_vector_builder.
(aarch64_sve_expand_vector_init_handle_trailing_constants): Likewise.
When extending the trailing constants to a full vector, replace any
variables with zeros.

gcc/testsuite/
PR target/94668
* gcc.target/aarch64/sve/pr94668.c: New test.

4 years agolibstdc++: Avoid illegal argument to verbose in dg-test callback
Matthias Kretz [Mon, 20 Apr 2020 14:29:41 +0000 (15:29 +0100)]
libstdc++: Avoid illegal argument to verbose in dg-test callback

If extra_tool_flags starts with a dash, an error like 'ERROR: verbose:
illegal argument: -march=native -O2 -std=c++17' is printed. This is
easily fixed by inserting a double dash before the variable.

2020-04-20  Matthias Kretz  <kretz@kde.org>

* testsuite/lib/libstdc++.exp: Avoid illegal argument to verbose.

4 years agoc++: tpl-tpl-parms are not canonicalizable types [pr94454]
Nathan Sidwell [Mon, 20 Apr 2020 13:52:30 +0000 (06:52 -0700)]
c++: tpl-tpl-parms are not canonicalizable types [pr94454]

We treat tpl-tpl-parms as types.  They're not; bound-tpl-tpl-parms
are.  We can get away with them being type-like.  Unfortunately we
give the original level==orig_level case a canonical type, but the
reduced cases of level<orig_level get structural equality.  This patch
gives them structural type always.

* pt.c (canonical_type_parameter): Assert not a tpl-tpl-parm.
(process_template_parm): tpl-tpl-parms are structural.
(rewrite_template_parm): Propagate structuralness.

4 years agoc++: Expr pack expansion equality [pr94454]
Nathan Sidwell [Mon, 20 Apr 2020 13:48:45 +0000 (06:48 -0700)]
c++: Expr pack expansion equality [pr94454]

We were not comparing expression pack expansions correctly. We could
consider distinct expansions equal and creating two, apparently equal,
specializations that would sometimes collide.  cp_tree_operand_length
says a pack has 1 operand (for mangling), whereas it actually has 3,
but only two of which are significant for equality.  We must special
case that in cp_tree_equal.  That new code matches the hasher and the
type_pack_expansion case in structural_comp_types.

* tree.c (cp_tree_equal): [TEMPLATE_ID_EXPR, default] Refactor.
[EXPR_PACK_EXPANSION]: Add.

4 years agoc++: Template argument hashing [pr94454]
Nathan Sidwell [Mon, 20 Apr 2020 13:44:08 +0000 (06:44 -0700)]
c++: Template argument hashing [pr94454]

One of the problems hit by pr94454 was that the argument hasher was
not skipping nodes that template_args_equal would.  Fixed by replacing
the STRIP_NOPS invocation by a bespoke loop.  We also confuse the
canonical type machinery by treating tpl-tpl-parms as types.  They're
not; bound-tpl-tpl-parms are.  We can get away with them being
type-like.  Unfortunately we give the original level==orig_level case
a canonical type, but the reduced cases of level<orig_level get
structural equality.  That breaks the hasher because we'll use
TYPE_HASH (CANONICAL_TYPE ()) when we can. There's a note in
tsubst[TEMPLATE_TEMPLATE_PARM] about why the reduced ones cannot have
a canonical type. (I didn't feel like questioning that assertion at
this point.)

* pt.c (iterative_hash_template_arg): Strip nodes as
template_args_equal does.
[ARGUMENT_PACK_SELECT, TREE_VEC, CONSTRUCTOR]: Refactor.
[node_class:TEMPLATE_TEMPLATE_PARM]: Hash by level & index.
[node_class:default]: Refactor.

4 years agoFix ICE on invalid calls_comdat_local flag [pr94582]
Jan Hubicka [Mon, 20 Apr 2020 13:25:50 +0000 (15:25 +0200)]
Fix ICE on invalid calls_comdat_local flag [pr94582]

PR ipa/94582
* tree-inline.c (optimize_inline_calls): Recompute calls_comdat_local
flag.

* g++.dg/torture/pr94582.C: New test.

4 years agoPR fortran/93364 - ICE in gfc_set_array_spec, at fortran/array.c:879
Harald Anlauf [Mon, 20 Apr 2020 12:20:19 +0000 (14:20 +0200)]
PR fortran/93364 - ICE in gfc_set_array_spec, at fortran/array.c:879

Add missing check in gfc_set_array_spec for sum of rank and corank to not
exceed GFC_MAX_DIMENSIONS.

2020-04-20  Harald Anlauf  <anlauf@gmx.de>

PR fortran/93364
* array.c (gfc_set_array_spec): Check for sum of rank and corank
not exceeding GFC_MAX_DIMENSIONS.

2020-04-20  Harald Anlauf  <anlauf@gmx.de>

PR fortran/93364
* gfortran.dg/pr93364.f90: New test.

4 years agoFix spacing in symtab_node::dump_references.
Martin Liska [Mon, 20 Apr 2020 12:09:41 +0000 (14:09 +0200)]
Fix spacing in symtab_node::dump_references.

* symtab.c (symtab_node::dump_references): Add space after
one entry.
(symtab_node::dump_referring): Likewise.

4 years agoPR 91800 - reject Hollerith constants as type initializer.
Steve Kargl [Mon, 20 Apr 2020 11:21:38 +0000 (13:21 +0200)]
PR 91800 - reject Hollerith constants as type initializer.

2020-04-20  Steve Kargl  <kargl@gcc.gnu.org>
Thomas Koenig  <tkoenig@gcc.gnu.org>

PR fortran/91800
* decl.c (variable_decl): Reject Hollerith constants as type
initializer.

2020-04-20  Steve Kargl  <kargl@gcc.gnu.org>
Thomas Koenig  <tkoenig@gcc.gnu.org>

PR fortran/91800
* gfortran.dg/hollerith_9.f90: New test.

4 years agoFix declare copyout in libgomp.oacc-c++/declare-pr94120.C
Tobias Burnus [Mon, 20 Apr 2020 10:38:50 +0000 (12:38 +0200)]
Fix declare copyout in libgomp.oacc-c++/declare-pr94120.C

Testing on the host does not make sense for 'declare copyout' for
a same-scope stack-allocated variable. Once the copyout is done,
the variable is gone. Hence, test the variable on the device. This
can be revisit after the OpenACC semantic has been fixed; but with
that fix, the test PASSes again with devices.

        PR middle-end/94120
        * testsuite/libgomp.oacc-c++/declare-pr94120.C: Fix 'declare copy(out)'
        test case.

4 years agoDaily bump.
GCC Administrator [Mon, 20 Apr 2020 00:16:17 +0000 (00:16 +0000)]
Daily bump.

4 years agolibstdc++: Define operator<=> for std::stack and std::queue
Jonathan Wakely [Sun, 19 Apr 2020 20:30:15 +0000 (21:30 +0100)]
libstdc++: Define operator<=> for std::stack and std::queue

Some more C++20 changes from P1614R2, "The Mothership has Landed".

* include/bits/stl_queue.h (queue): Define operator<=> for C++20.
* include/bits/stl_stack.h (stack): Likewise.
* testsuite/23_containers/queue/cmp_c++20.cc: New test.
* testsuite/23_containers/stack/cmp_c++20.cc: New test.

4 years agolibstdc++: Remove operator!= overloads for unordered containers
Jonathan Wakely [Sun, 19 Apr 2020 20:04:40 +0000 (21:04 +0100)]
libstdc++: Remove operator!= overloads for unordered containers

Some more C++20 changes from P1614R2, "The Mothership has Landed".

* include/bits/unordered_map.h (unordered_map, unordered_multimap):
Remove redundant operator!= for C++20.
* include/bits/unordered_set.h (unordered_set, unordered_multiset):
Likewise.
* include/debug/unordered_map (unordered_map, unordered_multimap):
Likewise.
* include/debug/unordered_set (unordered_set, unordered_multiset):
Likewise.

4 years agolibstdc++: Fix redundant assignment (PR 94629)
Jonathan Wakely [Sun, 19 Apr 2020 19:54:38 +0000 (20:54 +0100)]
libstdc++: Fix redundant assignment (PR 94629)

This appears to be a copy&paste error, which cppcheck diagnoses.

PR other/94629
* include/debug/formatter.h (_Error_formatter::_Parameter): Fix
redundant assignment in constructor.

4 years agors6000: Skip DWARF5 and -fcompare-debug testcases on AIX.
David Edelsohn [Sun, 19 Apr 2020 18:20:51 +0000 (14:20 -0400)]
rs6000: Skip DWARF5 and -fcompare-debug testcases on AIX.

AIX does not support DWARF5 sections.
-fcompare-debug causes gratuitous testcase failures on AIX.

2020-04-19  David Edelsohn  <dje.gcc@gmail.com>

        * g++.dg/debug/dwarf2/pr85550.C: Skip AIX.
        * g++.dg/debug/pr94272.C: Skip AIX.
        * g++.dg/debug/pr94281.C: Skip AIX.
        * g++.dg/debug/pr94323.C: Skip AIX.

4 years agolibphobos: Merge upstream phobos bf0d0a37c
Iain Buclaw [Sun, 19 Apr 2020 16:02:17 +0000 (18:02 +0200)]
libphobos: Merge upstream phobos bf0d0a37c

std.array.Appender and RefAppender: use .opSlice() instead of data()

Previously, Appender.data() was used to extract a slice of the Appender's array.
Now use the [] slice operator instead.  The same goes for RefAppender.

Fixes: PR d/94455

Reviewed-on: https://github.com/dlang/phobos/pull/7450

4 years agolibphobos: Merge upstream phobos 99003a75a
Iain Buclaw [Sun, 19 Apr 2020 13:48:27 +0000 (15:48 +0200)]
libphobos: Merge upstream phobos 99003a75a

Fixes hasLength unittest to pass on X32.

References: PR d/94609

Reviewed-on: https://github.com/dlang/phobos/pull/7448

4 years agod/dmd: Merge upstream dmd ba99ee345
Iain Buclaw [Sun, 19 Apr 2020 12:58:31 +0000 (14:58 +0200)]
d/dmd: Merge upstream dmd ba99ee345

Initializes the VectorArrayExp::size field with the correct value.

Fixes: PR d/94652

Reviewed-on: https://github.com/dlang/dmd/pull/11046

4 years agod/dmd: Merge upstream dmd 09be6ee14
Iain Buclaw [Sun, 19 Apr 2020 12:30:37 +0000 (14:30 +0200)]
d/dmd: Merge upstream dmd 09be6ee14

Initializes ncost before use, which was caught by valgrind.

Fixes: PR d/94653

Reviewed-on: https://github.com/dlang/dmd/pull/11045

4 years agoi386: Remove unneeded assignments when triggering SSE exceptions
Uros Bizjak [Sun, 19 Apr 2020 12:23:47 +0000 (14:23 +0200)]
i386: Remove unneeded assignments when triggering SSE exceptions

According to "Intel 64 and IA32 Arch SDM, Vol. 3:

"Because SIMD floating-point exceptions are precise and occur immediately,
the situation does not arise where an x87 FPU instruction, a WAIT/FWAIT
instruction, or another SSE/SSE2/SSE3 instruction will catch a pending
unmasked SIMD floating-point exception."

Remove unneeded assignments to volatile memory.

libgcc/ChangeLog:

* config/i386/sfp-exceptions.c (__sfp_handle_exceptions) [__SSE_MATH__]:
Remove unneeded assignments to volatile memory.

libatomic/ChangeLog:

* config/x86/fenv.c (__atomic_feraiseexcept) [__SSE_MATH__]:
Remove unneeded assignments to volatile memory.

libgfortran/ChangeLog:

* config/fpu-387.h (local_feraiseexcept) [__SSE_MATH__]:
Remove unneeded assignments to volatile memory.

4 years agocoroutines, testsuite: Require C++17 for two tests.
Iain Sandoe [Sun, 19 Apr 2020 12:16:12 +0000 (13:16 +0100)]
coroutines, testsuite: Require C++17 for two tests.

While the coroutines implementation, and most of the coroutines
tests, will operate with C++14 or newer, these tests require
facilities introduced in C++17.  Add the target requirement.

gcc/testsuite/

2020-04-19  Iain Sandoe  <iain@sandoe.co.uk>

* g++.dg/coroutines/torture/co-await-17-capture-comp-ref.C: Require
C++17.
* g++.dg/coroutines/torture/co-ret-15-default-return_void.C: Likewise.

4 years agoPR 94347 - fix previous ChangeLog entry.
Thomas König [Sun, 19 Apr 2020 12:08:16 +0000 (14:08 +0200)]
PR 94347 - fix previous ChangeLog entry.

4 years agoPR 94347 - add a test case for something a PR has fixed itself.
Thomas König [Sun, 19 Apr 2020 12:05:46 +0000 (14:05 +0200)]
PR 94347 - add a test case for something a PR has fixed itself.

2020-04-19  Thomas Koenig  <tkoenig@gcc.gnu.org>

PR fortran/94347
* gfortran.dg/char_pointer_init_1.f90: New test.

4 years agoCommit test case for PR 57129.
Thomas König [Sun, 19 Apr 2020 11:06:22 +0000 (13:06 +0200)]
Commit test case for PR 57129.

2020-04-19  Thomas Koenig  <tkoenig@gcc.gnu.org>

PR fortran/57129
* gfortran.dg/subroutine_as_type.f90: New test.

4 years agoFix PR fortran/93500, ICE on invalid.
Thomas König [Sun, 19 Apr 2020 10:56:32 +0000 (12:56 +0200)]
Fix PR fortran/93500, ICE on invalid.

Returning &gfc_bad_expr when simplifying bounds after a divisin by zero
happened results in the division by zero error actually reaching the user.

2020-04-19  Thomas Koenig  <tkoenig@gcc.gnu.org>

PR fortran/93500
* resolve.c (resolve_operator): If both operands are
NULL, return false.
* simplify.c (simplify_bound): If a division by zero
was seen during bound simplification, free the
corresponcing expression and return &gfc_bad_expr.

2020-04-19  Thomas Koenig  <tkoenig@gcc.gnu.org>

PR fortran/93500
* arith_divide_3.f90: New test.

4 years agoc, objc: Fix up c_parser_objc_selector_arg after CPP_SCOPE changes [PR94637]
Jakub Jelinek [Sun, 19 Apr 2020 10:13:33 +0000 (12:13 +0200)]
c, objc: Fix up c_parser_objc_selector_arg after CPP_SCOPE changes [PR94637]

Similarly to inline asm, :: (or any other number of consecutive colons) can
appear in ObjC @selector argument and with the introduction of CPP_SCOPE
into the C FE, we need to trat CPP_SCOPE as two CPP_COLON tokens.
The C++ FE does that already that way.

2020-04-19  Jakub Jelinek  <jakub@redhat.com>

PR objc/94637
* c-parser.c (c_parser_objc_selector_arg): Handle CPP_SCOPE like
two CPP_COLON tokens.

* objc.dg/pr94637.m: New test.

4 years agod: Fix FAIL in gdc.dg/runnable.d on X32 targets (PR94609)
Iain Buclaw [Sun, 19 Apr 2020 07:54:25 +0000 (09:54 +0200)]
d: Fix FAIL in gdc.dg/runnable.d on X32 targets (PR94609)

Patch fixes test failure seen on X32 where a nested struct was passed in
registers, rather than via invisible reference.  Now, all non-POD
structs are passed by invisible reference, not just those with a
user-defined copy constructor/destructor.

gcc/d/ChangeLog:

PR d/94609
* d-codegen.cc (argument_reference_p): Don't check TREE_ADDRESSABLE.
(type_passed_as): Build reference type if TREE_ADDRESSABLE.
* d-convert.cc (convert_for_argument): Build explicit TARGET_EXPR if
needed for arguments passed by invisible reference.
* types.cc (TypeVisitor::visit (TypeStruct *)): Mark all structs that
are not POD as TREE_ADDRESSABLE.

4 years agoDaily bump.
GCC Administrator [Sun, 19 Apr 2020 00:16:16 +0000 (00:16 +0000)]
Daily bump.

4 years agoAdd missing changelog entries for r10-7790
Iain Buclaw [Sat, 18 Apr 2020 18:53:08 +0000 (20:53 +0200)]
Add missing changelog entries for r10-7790

4 years agolibphobos: Add --with-libphobos-druntime-only option.
Iain Buclaw [Wed, 25 Mar 2020 08:38:58 +0000 (09:38 +0100)]
libphobos: Add --with-libphobos-druntime-only option.

The intended purpose of the option is both for targets that don't
support phobos yet, and for gdc itself to support bootstrapping itself
as a self-hosted D compiler.

The libphobos testsuite has been updated to only add libphobos to the
search paths if it's being built.  A new D2 testsuite directive
RUNNABLE_PHOBOS_TEST has also been patched in to disable some runnable
tests that have phobos dependencies, of which is a temporary measure
until upstream DMD fixes or removes these tests entirely.

gcc/testsuite/ChangeLog:

* lib/gdc-utils.exp (gdc-convert-test): Add dg-skip-if for tests that
depending on the phobos standard library.

libphobos/ChangeLog:

* configure: Regenerate.
* configure.ac: Add --with-libphobos-druntime-only option and the
conditional ENABLE_LIBDRUNTIME_ONLY.
* configure.tgt: Define LIBDRUNTIME_ONLY.
* src/Makefile.am: Add phobos sources if not ENABLE_LIBDRUNTIME_ONLY.
* src/Makefile.in: Regenerate.
* testsuite/testsuite_flags.in: Add phobos path if compiling phobos.

4 years agoDon't let DEBUG_INSNSs change register renaming decisions
Jeff Law [Sat, 18 Apr 2020 15:39:18 +0000 (09:39 -0600)]
Don't let DEBUG_INSNSs change register renaming decisions

PR debug/94439
* regrename.c (check_new_reg_p): Ignore DEBUG_INSNs when walking
the chain.

PR debug/94439
* gcc.dg/torture/pr94439.c: New test.

4 years agotestsuite: Disable gdc standard runtime tests if phobos is not built.
Iain Buclaw [Tue, 14 Apr 2020 16:27:49 +0000 (18:27 +0200)]
testsuite: Disable gdc standard runtime tests if phobos is not built.

The current check_effective_target_d_runtime procedure returns false if
the target is built without any core runtime library for D being
available (--disable-libphobos).  This additional procedure is for
targets where the core runtime library exists, but without the higher
level standard library.

gcc/ChangeLog:

* doc/sourcebuild.texi (Effective-Target Keywords, Environment
attributes): Document d_runtime_has_std_library.

gcc/testsuite/ChangeLog:

* gdc.dg/link.d: Use d_runtime_has_std_library effective target.
* gdc.dg/runnable.d: Move phobos tests to...
* gdc.dg/runnable2.d: ...here.  New test.
* lib/target-supports.exp
(check_effective_target_d_runtime_has_std_library): New.

libphobos/ChangeLog:

* testsuite/libphobos.phobos/phobos.exp: Skip if effective target is
not d_runtime_has_std_library.
* testsuite/libphobos.phobos_shared/phobos_shared.exp: Likewise.

4 years agoc++: spec_hasher::equal and PARM_DECLs [PR94632]
Patrick Palka [Sat, 18 Apr 2020 10:22:21 +0000 (06:22 -0400)]
c++: spec_hasher::equal and PARM_DECLs [PR94632]

In the testcase below, during specialization of c<int>::d, we build two
identical specializations of the parameter type b<decltype(e)::k> -- one when
substituting into c<int>::d's TYPE_ARG_TYPES and another when substituting into
c<int>::d's DECL_ARGUMENTS.

We don't reuse the first specialization the second time around as a consequence
of the fix for PR c++/56247 which made PARM_DECLs always compare different from
one another during spec_hasher::equal.  As a result, when looking up existing
specializations of 'b', spec_hasher::equal considers the template argument
decltype(e')::k to be different from decltype(e'')::k, where e' and e'' are the
result of two calls to tsubst_copy on the PARM_DECL e.

Since the two specializations are considered different due to the mentioned fix,
their TYPE_CANONICAL points to themselves even though they are otherwise
identical types, and this triggers an ICE in maybe_rebuild_function_decl_type
when comparing the TYPE_ARG_TYPES of c<int>::d to its DECL_ARGUMENTS.

This patch fixes this issue at the spec_hasher::equal level by ignoring the
'comparing_specializations' flag in cp_tree_equal whenever the DECL_CONTEXTs of
the two parameters are identical.  This seems to be a sufficient condition to be
able to correctly compare PARM_DECLs structurally.  (This also subsumes the
CONSTRAINT_VAR_P check since constraint variables all have empty, and therefore
identical, DECL_CONTEXTs.)

gcc/cp/ChangeLog:

PR c++/94632
* tree.c (cp_tree_equal) <case PARM_DECL>: Ignore
comparing_specializations if the parameters' contexts are identical.

gcc/testsuite/ChangeLog:

PR c++/94632
* g++.dg/template/canon-type-14.C: New test.

4 years agoc++: Abbreviated function template return type [PR92187]
Patrick Palka [Sat, 18 Apr 2020 10:22:14 +0000 (06:22 -0400)]
c++: Abbreviated function template return type [PR92187]

When updating an auto return type of an abbreviated function template in
splice_late_return_type, we should also propagate PLACEHOLDER_TYPE_CONSTRAINTS
(and cv-qualifiers) of the original auto node.

gcc/cp/ChangeLog:

PR c++/92187
* pt.c (splice_late_return_type): Propagate cv-qualifiers and
PLACEHOLDER_TYPE_CONSTRAINTS from the original auto node to the new one.

gcc/testsuite/ChangeLog:

PR c++/92187
* g++.dg/concepts/abbrev5.C: New test.
* g++.dg/concepts/abbrev6.C: New test.

4 years agoDaily bump.
GCC Administrator [Sat, 18 Apr 2020 00:16:16 +0000 (00:16 +0000)]
Daily bump.

4 years agolibstdc++: Add comparison operators to <chrono> types
Jonathan Wakely [Fri, 17 Apr 2020 23:47:45 +0000 (00:47 +0100)]
libstdc++: Add comparison operators to <chrono> types

Some more C++20 changes from P1614R2, "The Mothership has Landed".

* include/std/chrono (duration, time_point): Define operator<=> and
remove redundant operator!= for C++20.
* testsuite/20_util/duration/comparison_operators/three_way.cc: New
test.
* testsuite/20_util/time_point/comparison_operators/three_way.cc: New
test.

4 years agolibstdc++: Fix testsuite utility's use of allocators
Jonathan Wakely [Fri, 17 Apr 2020 23:10:54 +0000 (00:10 +0100)]
libstdc++: Fix testsuite utility's use of allocators

In C++20 the rebind and const_reference members of std::allocator are
gone, so this testsuite utility stopped working, causing
ext/pb_ds/regression/priority_queue_rand_debug.cc to FAIL.

* testsuite/util/native_type/native_priority_queue.hpp: Use
allocator_traits to rebind allocator.