eric@webkit.org [Tue, 4 Oct 2011 22:56:41 +0000 (22:56 +0000)]
Update html5-full-render.html to load the HTML5 spec incrementally, closer to how the browser would
https://bugs.webkit.org/show_bug.cgi?id=69374
Unreviewed.
Per https://bugs.webkit.org/show_bug.cgi?id=69374#c7
updating the chunksize to be a bit smaller now that the total
size of the html5 spec is smaller than when I wrote the test.
This should increase the prevalence of style resolution in the
sample time, which more closely matches instrument samples
taken when loading the full page in Safari.
* Parser/html5-full-render.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96658
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 4 Oct 2011 22:48:18 +0000 (22:48 +0000)]
Fix position check for double tap gesture detection. A double tap
should not be detected if the two taps are far from each other.
https://bugs.webkit.org/show_bug.cgi?id=69270
Patch by Varun Jain <varunjain@chromium.org> on 2011-10-04
Reviewed by Darin Fisher.
Test: Source/WebKit/chromium/tests/InnerGestureRecognizerTest.cpp
* platform/chromium/GestureRecognizerChromium.cpp:
(WebCore::GestureRecognizerChromium::isSecondClickInsideManhattanSquare):
(WebCore::GestureRecognizerChromium::updateValues):
(WebCore::GestureRecognizerChromium::click):
* platform/chromium/GestureRecognizerChromium.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96657
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adachan@apple.com [Tue, 4 Oct 2011 22:45:29 +0000 (22:45 +0000)]
toURLRef() in WKSharedAPICast.h should return null for a null string
https://bugs.webkit.org/show_bug.cgi?id=69380
Reviewed by Jon Honeycutt.
* Shared/API/c/WKSharedAPICast.h:
(WebKit::toURLRef): Add the missing "return" for the null string case.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96656
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 4 Oct 2011 22:38:27 +0000 (22:38 +0000)]
[chromium] Extract scheduling logic from CCThreadProxy to its own class
https://bugs.webkit.org/show_bug.cgi?id=69049
Patch by James Robinson <jamesr@chromium.org> on 2011-10-04
Reviewed by Kenneth Russell.
Source/WebCore:
This partially extracts the commit/draw scheduling from CCThreadProxy to a separate isolated class. This makes
the commit/draw logic easier to test, understand and extend.
There is one subtle behavior change here to the way that the function formerly known as
CCLayerTreeHost::setNeedsCommitAndRedraw works. Previously, this would trigger a begin frame message, if one
wasn't pending, and then trigger a redraw if one wasn't pending. This was subtly wrong - the intent of that call
is that a redraw should happen after the commit. It isn't useful to draw before the commit occurs. This patch
changes the name of the function to setNeedsCommitThenRedraw and only requests a redraw after a commit occurs.
Covered by new CCSchedulerTest unit tests, CCLayerTreeHostTest unit tests, and compositing/ layout tests.
* WebCore.gypi:
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::initialize):
(WebCore::CCLayerTreeHost::setZoomAnimatorTransform):
(WebCore::CCLayerTreeHost::setNeedsCommitThenRedraw):
(WebCore::CCLayerTreeHost::setViewport):
(WebCore::CCLayerTreeHost::setVisible):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
* platform/graphics/chromium/cc/CCProxy.h:
* platform/graphics/chromium/cc/CCScheduler.cpp: Added.
(WebCore::CCScheduler::CCScheduler):
(WebCore::CCScheduler::requestCommit):
(WebCore::CCScheduler::requestCommitThenRedraw):
(WebCore::CCScheduler::requestRedraw):
(WebCore::CCScheduler::didCommit):
(WebCore::CCScheduler::didDraw):
* platform/graphics/chromium/cc/CCScheduler.h: Added.
(WebCore::CCSchedulerClient::~CCSchedulerClient):
(WebCore::CCScheduler::create):
(WebCore::CCScheduler::commitPending):
(WebCore::CCScheduler::redrawPending):
(WebCore::CCScheduler::redrawAfterCommit):
* platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::setNeedsCommitThenRedraw):
(WebCore::CCSingleThreadProxy::setNeedsRedraw):
(WebCore::CCSingleThreadProxy::recreateContextIfNeeded):
(WebCore::CCSingleThreadProxy::doComposite):
* platform/graphics/chromium/cc/CCSingleThreadProxy.h:
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxySchedulerClient::create):
(WebCore::CCThreadProxySchedulerClient::~CCThreadProxySchedulerClient):
(WebCore::CCThreadProxySchedulerClient::scheduleBeginFrameAndCommit):
(WebCore::CCThreadProxySchedulerClient::scheduleDrawAndPresent):
(WebCore::CCThreadProxySchedulerClient::CCThreadProxySchedulerClient):
(WebCore::CCThreadProxy::CCThreadProxy):
(WebCore::CCThreadProxy::compositeAndReadback):
(WebCore::CCThreadProxy::initializeLayerRenderer):
(WebCore::CCThreadProxy::setNeedsCommit):
(WebCore::CCThreadProxy::setNeedsCommitOnCCThread):
(WebCore::CCThreadProxy::setNeedsCommitThenRedraw):
(WebCore::CCThreadProxy::setNeedsCommitThenRedrawOnCCThread):
(WebCore::CCThreadProxy::setNeedsRedraw):
(WebCore::CCThreadProxy::setNeedsRedrawOnCCThread):
(WebCore::CCThreadProxy::finishAllRenderingOnCCThread):
(WebCore::CCThreadProxy::obtainBeginFrameAndCommitTaskFromCCThread):
(WebCore::CCThreadProxy::createBeginFrameAndCommitTaskOnCCThread):
(WebCore::CCThreadProxy::beginFrameAndCommit):
(WebCore::CCThreadProxy::commitOnCCThread):
(WebCore::CCThreadProxy::drawLayersAndPresentOnCCThread):
(WebCore::CCThreadProxy::initializeImplOnCCThread):
* platform/graphics/chromium/cc/CCThreadProxy.h:
Source/WebKit/chromium:
Adds some unit tests for the new CCScheduler class. Since the class is very simple today, the tests are
similarly quite simple.
* WebKit.gypi:
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setRootLayerNeedsDisplay):
* tests/CCLayerTreeHostTest.cpp:
(WTF::CCLayerTreeHostTest::postSetNeedsCommitThenRedrawToMainThread):
(WTF::CCLayerTreeHostTest::dispatchSetNeedsCommitThenRedraw):
(WTF::CCLayerTreeHostTestShortlived2::beginTest):
(WTF::CCLayerTreeHostTestCommitingWithContinuousRedraw::beginTest):
(WTF::CCLayerTreeHostTestCommitingWithContinuousRedraw::drawLayersOnCCThread):
(WTF::CCLayerTreeHostTestSetNeedsCommit1::beginTest):
(WTF::CCLayerTreeHostTestSetNeedsCommit2::beginTest):
(WTF::CCLayerTreeHostTestSetNeedsCommit2::drawLayersOnCCThread):
(WTF::CCLayerTreeHostTestSetNeedsRedraw::beginTest):
* tests/CCSchedulerTest.cpp: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96655
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 4 Oct 2011 22:30:49 +0000 (22:30 +0000)]
occasional crash in Chromium in dispatching keyEvent
https://bugs.webkit.org/show_bug.cgi?id=67941
Patch by Scott Graham <scottmg@chromium.org> on 2011-10-04
Reviewed by Tony Chang.
Source/WebKit/chromium:
Guard Frame while handling keyEvent, as it can lose last reference due
to actions of handler.
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::keyEvent):
LayoutTests:
* fast/events/keyevent-iframe-removed-crash-expected.txt: Added.
* fast/events/keyevent-iframe-removed-crash.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96654
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Tue, 4 Oct 2011 22:28:54 +0000 (22:28 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=67774
PDF in a frameset is not displayed, always downloads
Reviewed by Darin Adler.
* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/Plugins/PDF: Added.
Added BuiltInPDFView class. It implements ScrollableArea and Plugin, working with iframes,
objects and embeds. The implementation targets Mac port only, fixing a WebKit2 regression.
* UIProcess/WebContext.cpp: (WebKit::WebContext::getPlugins): Tell WebCore that there is a
plug-in for PDF, so that it instantiates it in a regular fashion.
* UIProcess/WebFrameProxy.cpp: (WebKit::WebFrameProxy::canShowMIMEType): We can now show
PDF not only in main frame.
* WebProcess/Plugins/PDF/BuiltInPDFView.cpp: Added. This is largely an implementation of
ScrollableArea now, which can render the first page of a PDF. Further improvements to come.
* WebProcess/Plugins/PDF/BuiltInPDFView.h: Added.
* WebProcess/Plugins/Plugin.cpp: (WebKit::Plugin::updateControlTints): Give Plugin a chance
to invalidate its tintable controls - it's necessary for PDF because scrollbars are tintable.
* WebProcess/Plugins/Plugin.h: (WebKit::Plugin::controller): Added a const version, since
some ScrollableArea methods are const.
* WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::paint): Call updateControlTints
at updatingControlTints phase.
* WebProcess/Plugins/PluginView.h: PDF plug-in needs to tinker with embedding FrameView to
use Scrollbar class, so it needs to cast its PluginController up to PluginView. It's unfortunate
that PluginView has so much NPAPI specific code, but that's how it is now.
* WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::createPlugin): If there is no real plug-in
installed for PDF, instantiate built-in one.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96653
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 4 Oct 2011 22:14:49 +0000 (22:14 +0000)]
ScrollElasticityController should keep track of the rubberband timer state
https://bugs.webkit.org/show_bug.cgi?id=69381
Reviewed by Sam Weinig.
Add a m_snapRubberbandTimerIsActive member variable to ScrollElasticityController
and use it instead of checking whether the m_snapRubberbandTimer is active.
Eventually, ScrollElasticityControllerClient will have two member functions for starting
and stopping the timer, and the ScrollElasticityController will call them at the appropriate times.
* platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::handleWheelEvent):
(WebCore::ScrollAnimatorMac::beginScrollGesture):
It's OK to stop the timer unconditionally.
(WebCore::ScrollAnimatorMac::snapRubberBand):
(WebCore::ScrollAnimatorMac::snapRubberBandTimerFired):
* platform/mac/ScrollElasticityController.h:
* platform/mac/ScrollElasticityController.mm:
(WebCore::ScrollElasticityController::ScrollElasticityController):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96652
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 4 Oct 2011 21:58:18 +0000 (21:58 +0000)]
Move all rubber-banding related member variables to ScrollElasticityController
https://bugs.webkit.org/show_bug.cgi?id=69379
Reviewed by Dan Bernstein.
* platform/mac/ScrollAnimatorMac.h:
* platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::ScrollAnimatorMac):
(WebCore::ScrollAnimatorMac::handleWheelEvent):
(WebCore::ScrollAnimatorMac::smoothScrollWithEvent):
(WebCore::ScrollAnimatorMac::beginScrollGesture):
(WebCore::ScrollAnimatorMac::snapRubberBand):
(WebCore::ScrollAnimatorMac::snapRubberBandTimerFired):
* platform/mac/ScrollElasticityController.h:
* platform/mac/ScrollElasticityController.mm:
(WebCore::ScrollElasticityController::ScrollElasticityController):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96651
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Tue, 4 Oct 2011 21:50:04 +0000 (21:50 +0000)]
Update XP results for the font shaping patch.
* platform/chromium-win-xp/fast/text/international/bidi-neutral-run-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96650
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Tue, 4 Oct 2011 21:37:49 +0000 (21:37 +0000)]
Update baselines after trac.webkit.org/changeset/96620. These
changes match the changes Dave made to other platforms.
* platform/chromium-cg-mac/fast/multicol/vertical-lr/float-avoidance-expected.png:
* platform/chromium-cg-mac/fast/multicol/vertical-rl/float-avoidance-expected.png:
* platform/chromium-linux/fast/multicol/vertical-lr/float-avoidance-expected.png:
* platform/chromium-linux/fast/multicol/vertical-rl/float-avoidance-expected.png:
* platform/chromium-win/fast/multicol/vertical-lr/float-avoidance-expected.png:
* platform/chromium-win/fast/multicol/vertical-lr/float-avoidance-expected.txt:
* platform/chromium-win/fast/multicol/vertical-rl/float-avoidance-expected.png:
* platform/chromium-win/fast/multicol/vertical-rl/float-avoidance-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96649
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Tue, 4 Oct 2011 21:34:45 +0000 (21:34 +0000)]
Fix Leopard build bustage.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96648
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Tue, 4 Oct 2011 21:27:03 +0000 (21:27 +0000)]
Update html5-full-render.html to load the HTML5 spec incrementally, closer to how the browser would
https://bugs.webkit.org/show_bug.cgi?id=69374
Reviewed by James Robinson.
This should finally be able to provide us with a repeatable metric
for how fast we're currently able to load the HTML5 spec.
There are a variety of interesting functions which show up in this
sample, including of course style resolution.
* Parser/html5-full-render.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96647
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 4 Oct 2011 21:25:27 +0000 (21:25 +0000)]
Build fixes for everyone.
* platform/chromium/ScrollAnimatorChromiumMac.h:
* platform/chromium/ScrollAnimatorChromiumMac.mm:
(WebCore::isScrollingLeftAndShouldNotRubberBand):
(WebCore::isScrollingRightAndShouldNotRubberBand):
(WebCore::ScrollAnimatorChromiumMac::smoothScrollWithEvent):
Fix Chromium build.
* platform/gtk/PlatformWheelEventGtk.cpp:
(WebCore::PlatformWheelEvent::PlatformWheelEvent):
Fix GTK+ build.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96646
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jonlee@apple.com [Tue, 4 Oct 2011 21:23:29 +0000 (21:23 +0000)]
REGRESSION (WK2): (Shift-)option-tabbing skips over elements when transitioning from chrome to webview
https://bugs.webkit.org/show_bug.cgi?id=68412
<rdar://problem/9988252>
Reviewed by Darin Adler.
Source/WebKit2:
In WK1 setInitialFocus() is called on FocusController with the key event that
caused the web view to become first responder. In WK2 no event is sent. So if
the key stroke that caused the change in first responder status contains the
option modifier key, FocusController did not know that it had to switch behavior.
Because there are multiple ways that the WKView can becomeFirstResponder, I changed
the signature to setInitialFocus to express whether the key event parameter is an
actual key event.
* UIProcess/API/C/win/WKView.cpp:
(WKViewSetInitialFocus):
* UIProcess/API/mac/WKView.mm:
(-[WKView becomeFirstResponder]): Take the NSApp currentEvent and pass it along if
the event is a keyboard event, otherwise pass an empty event.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::setInitialFocus): Change in function signature to confirm that
the event that caused the initial focus was a keyboard event, and provide the keyboard
event itself.
* UIProcess/WebPageProxy.h:
* UIProcess/win/WebView.cpp:
(WebKit::WebView::setInitialFocus):
* UIProcess/win/WebView.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setInitialFocus): If we know that the cause of this was a keyboard
event, we pass that event to the FocusController. Otherwise we fall back to the original
behavior, which is to pass no event at all.
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in:
Tools:
In order to create a test for the bug, I had to update DRT and WKTR to create some
widget that allows first responder status to move away from the main web view.
Three methods were added to layoutTestController: addChromeInputField,
removeChromeInputField, and focusWebView. addChromeInputField adds a text field
that is a sibling to the web view, and sets up the key event loop between the two.
removeChromeInputField removes that field. focusWebView moves first responder
status to the web view.
The test makes the call via layoutTestController and passes a callback that it
assumes will be executed once the task is completed. In DRT the callback is called
synchronously. In WKTR this is handled with message passing between the two
processes.
* DumpRenderTree/LayoutTestController.cpp:
(addChromeInputFieldCallback):
(removeChromeInputFieldCallback):
(focusWebViewCallback):
(LayoutTestController::staticFunctions):
* DumpRenderTree/LayoutTestController.h:
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::addChromeInputField):
(LayoutTestController::removeChromeInputField):
(LayoutTestController::focusWebView):
* DumpRenderTree/mac/DumpRenderTree.mm:
(resetWebViewToConsistentStateBeforeTesting): When resetting for the next test,
make sure to remove the chrome input field.
* DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::addChromeInputField):
(LayoutTestController::removeChromeInputField):
(LayoutTestController::focusWebView):
* DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::addChromeInputField):
(LayoutTestController::removeChromeInputField):
(LayoutTestController::focusWebView):
* WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
* WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::didReceiveMessage):
(WTR::InjectedBundle::postAddChromeInputField):
(WTR::InjectedBundle::postRemoveChromeInputField):
(WTR::InjectedBundle::postFocusWebView):
* WebKitTestRunner/InjectedBundle/InjectedBundle.h:
* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR::callbackMap): Create a hash map that keeps track of the callbacks provided
through JS.
(WTR::cacheLayoutTestControllerCallback):
(WTR::callLayoutTestControllerCallback):
(WTR::LayoutTestController::addChromeInputField):
(WTR::LayoutTestController::removeChromeInputField):
(WTR::LayoutTestController::focusWebView):
(WTR::LayoutTestController::callAddChromeInputFieldCallback):
(WTR::LayoutTestController::callRemoveChromeInputFieldCallback):
(WTR::LayoutTestController::callFocusWebViewCallback):
* WebKitTestRunner/InjectedBundle/LayoutTestController.h:
* WebKitTestRunner/PlatformWebView.h:
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetStateToConsistentValues):
* WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
* WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
(WTR::PlatformWebView::addChromeInputField):
(WTR::PlatformWebView::removeChromeInputField):
(WTR::PlatformWebView::makeWebViewFirstResponder):
* WebKitTestRunner/mac/PlatformWebViewMac.mm:
(WTR::PlatformWebView::addChromeInputField):
(WTR::PlatformWebView::removeChromeInputField):
(WTR::PlatformWebView::makeWebViewFirstResponder):
* WebKitTestRunner/win/PlatformWebViewWin.cpp:
(WTR::PlatformWebView::addChromeInputField):
(WTR::PlatformWebView::removeChromeInputField):
(WTR::PlatformWebView::makeWebViewFirstResponder):
* DumpRenderTree/mac/LayoutTestControllerMac.mm: These functions have nothing to do
with the patch-- just cleaning up style.
(LayoutTestController::addDisallowedURL):
(originsArrayToJS):
(LayoutTestController::queueLoad):
(LayoutTestController::setMockDeviceOrientation):
(LayoutTestController::setIconDatabaseEnabled):
(LayoutTestController::setEditingBehavior):
LayoutTests:
The option-key navigation is only relevant to the Mac platform.
* platform/mac/fast/forms/focus-option-control-on-page-expected.txt: Added.
* platform/mac/fast/forms/focus-option-control-on-page.html: Added.
* platform/mac/fast/forms/script-tests/focus-option-control-on-page.js: Added.
(startTest):
(runKeyPresses):
(notifyDone):
(log):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96645
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 4 Oct 2011 21:18:53 +0000 (21:18 +0000)]
Add a ScrollElasticityController class and move some members over from ScrollAnimatorMac
https://bugs.webkit.org/show_bug.cgi?id=69373
Reviewed by David Hyatt.
ScrollElasticityController is a new class that will handle the rubber-banding when handling scroll events.
* WebCore.xcodeproj/project.pbxproj:
* platform/mac/ScrollAnimatorMac.h:
* platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::ScrollAnimatorMac):
(WebCore::ScrollAnimatorMac::handleWheelEvent):
(WebCore::ScrollAnimatorMac::smoothScrollWithEvent):
(WebCore::ScrollAnimatorMac::beginScrollGesture):
(WebCore::ScrollAnimatorMac::snapRubberBand):
(WebCore::ScrollAnimatorMac::snapRubberBandTimerFired):
* platform/mac/ScrollElasticityController.h: Added.
(WebCore::ScrollElasticityControllerClient::~ScrollElasticityControllerClient):
* platform/mac/ScrollElasticityController.mm: Added.
(WebCore::ScrollElasticityController::ScrollElasticityController):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96644
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Tue, 4 Oct 2011 21:16:56 +0000 (21:16 +0000)]
Source/JavaScriptCore: https://bugs.webkit.org/show_bug.cgi?id=69372
[CSS3 Regions] Make sure overflow:visible lets content spill out of regions.
Add support for reverse iteration to ListHashSet to support being able to walk them
backwards easily.
Reviewed by Anders Carlsson.
* wtf/ListHashSet.h:
(WTF::ListHashSetReverseIterator::ListHashSetReverseIterator):
(WTF::ListHashSetReverseIterator::get):
(WTF::ListHashSetReverseIterator::operator*):
(WTF::ListHashSetReverseIterator::operator->):
(WTF::ListHashSetReverseIterator::operator++):
(WTF::ListHashSetReverseIterator::operator--):
(WTF::ListHashSetReverseIterator::operator==):
(WTF::ListHashSetReverseIterator::operator!=):
(WTF::ListHashSetReverseIterator::operator const_reverse_iterator):
(WTF::ListHashSetReverseIterator::node):
(WTF::ListHashSetConstReverseIterator::ListHashSetConstReverseIterator):
(WTF::ListHashSetConstReverseIterator::get):
(WTF::ListHashSetConstReverseIterator::operator*):
(WTF::ListHashSetConstReverseIterator::operator->):
(WTF::ListHashSetConstReverseIterator::operator++):
(WTF::ListHashSetConstReverseIterator::operator--):
(WTF::ListHashSetConstReverseIterator::operator==):
(WTF::ListHashSetConstReverseIterator::operator!=):
(WTF::ListHashSetConstReverseIterator::node):
(WTF::::rbegin):
(WTF::::rend):
(WTF::::makeReverseIterator):
(WTF::::makeConstReverseIterator):
(WTF::::makeConstIterator):
Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=69372
[CSS3 Regions] Make sure overflow:visible lets content spill out of regions.
Reviewed by Anders Carlsson.
No new tests, since plenty of results changed.
* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::paintIntoRegion):
(WebCore::RenderFlowThread::hitTestRegion):
(WebCore::RenderFlowThread::repaintRectangleInRegions):
(WebCore::RenderFlowThread::firstRegion):
(WebCore::RenderFlowThread::lastRegion):
* rendering/RenderFlowThread.h:
* rendering/RenderRegion.cpp:
(WebCore::RenderRegion::regionOverflowRect):
(WebCore::RenderRegion::isFirstRegion):
(WebCore::RenderRegion::isLastRegion):
(WebCore::RenderRegion::layout):
* rendering/RenderRegion.h:
(WebCore::RenderRegion::setRegionRect):
(WebCore::RenderRegion::regionRect):
LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=69372
[CSS3 Regions] Make sure overflow:visible lets content spill out of regions.
Reviewed by Anders Carlsson.
* platform/mac/fast/regions/content-flowed-into-regions-dynamically-removed-expected.png:
* platform/mac/fast/regions/percentage-margins-mixed-ltr-dominant-regions-expected.png:
* platform/mac/fast/regions/percentage-margins-mixed-rtl-dominant-regions-expected.png:
* platform/mac/fast/regions/percentage-margins-rtl-variable-width-regions-expected.png:
* platform/mac/fast/regions/percentage-margins-variable-width-regions-expected.png:
* platform/mac/fast/regions/webkit-flow-double-pagination-float-push-expected.png:
* platform/mac/fast/regions/webkit-flow-float-unable-to-push-expected.png:
* platform/mac/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.png:
* platform/mac/fast/regions/webkit-flow-inlines-dynamic-expected.png:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96643
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
crogers@google.com [Tue, 4 Oct 2011 21:10:48 +0000 (21:10 +0000)]
Avoid unnecessary ASSERT in AudioDSPKernelProcessor::setNumberOfChannels()
https://bugs.webkit.org/show_bug.cgi?id=69361
Reviewed by James Robinson.
No new tests. This changes no JavaScript API.
* platform/audio/AudioDSPKernelProcessor.cpp:
(WebCore::AudioDSPKernelProcessor::setNumberOfChannels):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96642
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
gavinp@chromium.org [Tue, 4 Oct 2011 20:56:39 +0000 (20:56 +0000)]
fix gtk breakage caused by changeset 96595
https://bugs.webkit.org/show_bug.cgi?id=69371
ews did not catch build breakage in the gtk WebKitPluginProcess target; this patch removes
the pretty printer on gtk, which should fix the build on that platform.
Reviewed by NOBODY, this is a build fix.
* wtf/Assertions.cpp:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96641
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Tue, 4 Oct 2011 20:53:09 +0000 (20:53 +0000)]
Update our copy of the HTML5 spec used for performance testing to match the latest version
https://bugs.webkit.org/show_bug.cgi?id=69364
Unreviewed. The patch is too large to post, so landing this unreviewed. :(
The copy of the html5 spec we were using for testing was over a year old
and didn't have any of the subresources with it (we were only using it
as an HTML parsing benchmark). I'm about to use it for testing
the full load/render time of the benchmark, so I've updated to the latest
version of the spec (now 8mb instead of 5mb) and inlined two of the
CSS files. (Inlining the CSS was necessary to make my testing consistent
as there seems to be a race with some timer fired after CSS load.)
Increasing from 5mb to 8mb showed a similar 30% slowdown in our parser
benchmarks as expected.
* Parser/resources/html5.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96640
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 4 Oct 2011 20:44:05 +0000 (20:44 +0000)]
Use const PlatformWheelEvent references where possible
https://bugs.webkit.org/show_bug.cgi?id=69367
Reviewed by Sam Weinig.
* page/EventHandler.cpp:
(WebCore::EventHandler::handleWheelEvent):
* platform/ScrollAnimator.cpp:
(WebCore::ScrollAnimator::handleWheelEvent):
* platform/ScrollAnimator.h:
* platform/ScrollView.cpp:
(WebCore::ScrollView::wheelEvent):
* platform/ScrollView.h:
* platform/ScrollableArea.cpp:
(WebCore::ScrollableArea::handleWheelEvent):
* platform/ScrollableArea.h:
* platform/chromium/ScrollAnimatorChromiumMac.h:
* platform/chromium/ScrollAnimatorChromiumMac.mm:
(WebCore::ScrollAnimatorChromiumMac::handleWheelEvent):
* platform/mac/ScrollAnimatorMac.h:
* platform/mac/ScrollAnimatorMac.mm:
(WebCore::isScrollingLeftAndShouldNotRubberBand):
(WebCore::isScrollingRightAndShouldNotRubberBand):
(WebCore::ScrollAnimatorMac::handleWheelEvent):
(WebCore::ScrollAnimatorMac::smoothScrollWithEvent):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96639
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 4 Oct 2011 20:39:45 +0000 (20:39 +0000)]
Shrink HTMLTableCellElement.
https://bugs.webkit.org/show_bug.cgi?id=69347
Patch by Andreas Kling <kling@webkit.org> on 2011-10-04
Reviewed by Antti Koivisto.
Don't cache the rowspan and colspan attributes on the element.
This shrinks HTMLTableCellElement by one CPU word, reducing memory
consumption by 80 kB (on 64-bit) when loading the full HTML5 spec.
* html/HTMLTableCellElement.cpp:
(WebCore::HTMLTableCellElement::HTMLTableCellElement):
(WebCore::HTMLTableCellElement::colSpan):
(WebCore::HTMLTableCellElement::rowSpan):
(WebCore::HTMLTableCellElement::parseMappedAttribute):
* html/HTMLTableCellElement.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96638
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 4 Oct 2011 20:37:58 +0000 (20:37 +0000)]
Unreviewed, rolling out r96630.
http://trac.webkit.org/changeset/96630
https://bugs.webkit.org/show_bug.cgi?id=69368
Caused assertion failures in validateCell (Requested by
mhahnenberg on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-04
Source/JavaScriptCore:
* runtime/BooleanConstructor.cpp:
* runtime/BooleanConstructor.h:
* runtime/Error.cpp:
(JSC::StrictModeTypeErrorFunction::getCallDataVirtual):
(JSC::StrictModeTypeErrorFunction::getCallData):
* runtime/ErrorConstructor.cpp:
* runtime/ErrorConstructor.h:
* runtime/FunctionConstructor.cpp:
* runtime/FunctionConstructor.h:
* runtime/FunctionPrototype.cpp:
* runtime/FunctionPrototype.h:
Source/WebCore:
* bridge/qt/qt_runtime.cpp:
* bridge/qt/qt_runtime.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96637
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Tue, 4 Oct 2011 20:24:35 +0000 (20:24 +0000)]
[Qt] Unreviewed gardening. Update Qt specific expected results.
* platform/qt/fast/multicol/vertical-lr/float-avoidance-expected.png:
* platform/qt/fast/multicol/vertical-lr/float-avoidance-expected.txt:
* platform/qt/fast/multicol/vertical-rl/float-avoidance-expected.png:
* platform/qt/fast/multicol/vertical-rl/float-avoidance-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96636
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caryclark@google.com [Tue, 4 Oct 2011 20:20:13 +0000 (20:20 +0000)]
Enable sub pixel text (Skia on Mac)
https://bugs.webkit.org/show_bug.cgi?id=69354
http://code.google.com/p/chromium/issues/detail?id=98165
Reviewed by Eric Seidel.
No new tests. Layout test pixel results have been
disabled and will be rebaselined once all Skia on Mac
changes are in.
* platform/graphics/skia/FontSkia.cpp:
(WebCore::setupPaint):
Enable sub pixel text. This is set by default to enabled
by CoreGraphics, but by default disabled on Skia.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96635
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Tue, 4 Oct 2011 20:16:51 +0000 (20:16 +0000)]
Add loopsPerRun option to Parser performance test runner
https://bugs.webkit.org/show_bug.cgi?id=69363
Reviewed by Antti Koivisto.
Add loopsPerRun option and abstract out runLoop function (to make the UI more responsive).
No change in behavior in any of the tests.
* Parser/resources/runner.js:
(runLoop):
(run):
(start):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96634
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 4 Oct 2011 20:11:04 +0000 (20:11 +0000)]
Remove PlatformWheelEvent::m_isAccepted
https://bugs.webkit.org/show_bug.cgi?id=69357
Reviewed by Darin Adler.
../WebCore:
Remove PlatformWheelEvent::m_isAccepted and all the getters/setters.
* page/EventHandler.cpp:
(WebCore::EventHandler::handleWheelEvent):
(WebCore::EventHandler::handleGestureEvent):
* page/mac/EventHandlerMac.mm:
(WebCore::EventHandler::wheelEvent):
* platform/PlatformWheelEvent.h:
(WebCore::PlatformWheelEvent::PlatformWheelEvent):
* platform/ScrollAnimator.cpp:
(WebCore::ScrollAnimator::handleWheelEvent):
* platform/chromium/PopupContainer.cpp:
(WebCore::PopupContainer::handleGestureEvent):
* platform/chromium/ScrollAnimatorChromiumMac.mm:
(WebCore::ScrollAnimatorChromiumMac::handleWheelEvent):
* platform/efl/PlatformWheelEventEfl.cpp:
(WebCore::PlatformWheelEvent::PlatformWheelEvent):
* platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::handleWheelEvent):
* platform/mac/WheelEventMac.mm:
(WebCore::PlatformWheelEvent::PlatformWheelEvent):
* platform/qt/WheelEventQt.cpp:
(WebCore::PlatformWheelEvent::PlatformWheelEvent):
* platform/win/WheelEventWin.cpp:
(WebCore::PlatformWheelEvent::PlatformWheelEvent):
* platform/wx/MouseWheelEventWx.cpp:
(WebCore::PlatformWheelEvent::PlatformWheelEvent):
../WebKit/chromium:
* src/WebInputEventConversion.cpp:
(WebKit::PlatformWheelEventBuilder::PlatformWheelEventBuilder):
m_isAccepted has been removed.
* src/WebScrollbarImpl.cpp:
(WebKit::WebScrollbarImpl::onMouseWheel):
Just return the value of handleWheelEvent.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96633
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cdn@chromium.org [Tue, 4 Oct 2011 19:47:32 +0000 (19:47 +0000)]
Source/WebCore: Hold refptr to identified previous sibling within findPlaceForCounter.
https://bugs.webkit.org/show_bug.cgi?id=68563
Reviewed by Adam Barth.
Test: fast/css/counters/counter-after-style-crash.html
* rendering/RenderCounter.cpp:
(WebCore::findPlaceForCounter):
LayoutTests: Add test for crash when performing rich text mutations with counter nodes.
https://bugs.webkit.org/show_bug.cgi?id=68563
Reviewed by Adam Barth.
* fast/css/counters/counter-after-style-crash-expected.txt: Added.
* fast/css/counters/counter-after-style-crash.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96632
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 4 Oct 2011 19:35:23 +0000 (19:35 +0000)]
IndexedDB add() should fail if key is NaN
https://bugs.webkit.org/show_bug.cgi?id=62286
Patch by Joshua Bell <jsbell@chromium.org> on 2011-10-04
Reviewed by Tony Chang.
Source/WebCore:
Test: storage/indexeddb/invalid-keys.html
Implement special case - numbers are valid keys, except for NaN.
* bindings/v8/IDBBindingUtilities.cpp:
(WebCore::createIDBKeyFromValue):
LayoutTests:
Tests for NaN and other invalid IndexedDB keys.
* storage/indexeddb/invalid-keys-expected.txt: Added.
* storage/indexeddb/invalid-keys.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96631
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mhahnenberg@apple.com [Tue, 4 Oct 2011 19:22:00 +0000 (19:22 +0000)]
Add static ClassInfo structs to classes that override JSCell::getCallData
https://bugs.webkit.org/show_bug.cgi?id=69311
Reviewed by Darin Adler.
Source/JavaScriptCore:
Added ClassInfo structs to each class that defined its own getCallData
function but did not already have its own ClassInfo struct. This is a
necessary addition for when we switch over to looking up getCallData from
the MethodTable in ClassInfo rather than doing the virtual call (which we
are removing). These new ClassInfo structs are public because we often
use these structs in other areas of the code to uniquely identify JSC classes and
to enforce runtime invariants based on those class identities using ASSERTs.
* runtime/BooleanConstructor.cpp:
* runtime/BooleanConstructor.h:
getCallData was not marked as static is StrictModeTypeErrorFunction.
* runtime/Error.cpp:
(JSC::StrictModeTypeErrorFunction::getCallDataVirtual):
(JSC::StrictModeTypeErrorFunction::getCallData):
* runtime/ErrorConstructor.cpp:
* runtime/ErrorConstructor.h:
* runtime/FunctionConstructor.cpp:
* runtime/FunctionConstructor.h:
* runtime/FunctionPrototype.cpp:
* runtime/FunctionPrototype.h:
Source/WebCore:
No new tests.
Added ClassInfo structs to each class that defined its own getCallData
function but did not already have its own ClassInfo struct. This is a
necessary addition for when we switch over to looking up getCallData from
the MethodTable in ClassInfo rather than doing the virtual call (which we
are removing). These new ClassInfo structs are public because we often
use these structs in other areas of the code to uniquely identify JSC classes and
to enforce runtime invariants based on those class identities using ASSERTs.
* bridge/qt/qt_runtime.cpp:
* bridge/qt/qt_runtime.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96630
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Tue, 4 Oct 2011 19:17:25 +0000 (19:17 +0000)]
Leopard build fix after r96613.
* wtf/Platform.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96629
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Tue, 4 Oct 2011 19:02:44 +0000 (19:02 +0000)]
REGRESSION(r94274): setting input.value erroneously triggers focus event
https://bugs.webkit.org/show_bug.cgi?id=69315
Reviewed by Kent Tamura.
Fixed the bug by adding a new flag to setSelection to avoid calling setFocusedNodeIfNeeded
when called by nodeWillBeRemoved and textWillBeReplaced.
Added a manual test. Unfortunately, the test always passes in DRT.
* editing/FrameSelection.cpp:
(WebCore::FrameSelection::setSelection):
(WebCore::FrameSelection::respondToNodeModification):
(WebCore::FrameSelection::textWillBeReplaced):
* editing/FrameSelection.h:
* manual-tests/mutate-unfocused-text-with-selection.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96628
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mhahnenberg@apple.com [Tue, 4 Oct 2011 19:02:03 +0000 (19:02 +0000)]
Implicitly add toString and valueOf to prototype when convertToType callback is provided
https://bugs.webkit.org/show_bug.cgi?id=69156
Reviewed by Geoffrey Garen.
Added callbacks for toString and valueOf which are implicitly added to a client object's
prototype if they provide a convertToType callback when declaring their class through
the JSC API.
* API/JSCallbackFunction.cpp:
(JSC::JSCallbackFunction::toStringCallback):
(JSC::JSCallbackFunction::valueOfCallback):
* API/JSCallbackFunction.h:
* API/JSClassRef.cpp:
(OpaqueJSClass::prototype):
* API/tests/testapi.js:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96627
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 4 Oct 2011 18:58:47 +0000 (18:58 +0000)]
HTML canvas strokes with dash and dashOffset
https://bugs.webkit.org/show_bug.cgi?id=63933
Patch by Young Han Lee <joybro201@gmail.com> on 2011-10-04
Reviewed by Simon Fraser.
Add webkitLineDash and webkitLineDashOffset attributes to CanvasRenderingContext2D for JSC.
These attributes can be used to determine the dash-style of stroke in HTML Canvas.
As this kind of attributes are not specified in the HTML Canvas specification yet,
the 'webkit' prefix is added to its names.
Mozilla already implemented these attributes, mozDash and mozDashOffset [1], and this patch
is created by referring to the implementation. This patch is basically using the specified
behavior of stroke-dasharray and stroke-dashoffset in the SVG specification [2], except
that doesn't support units or percentages, just floating point numbers.
[1] https://bugzilla.mozilla.org/show_bug.cgi?id=662038
[2] http://www.w3.org/TR/SVG/painting.html#StrokeProperties
Source/WebCore:
Tests: fast/canvas/canvas-webkitLineDash-invalid.html
fast/canvas/canvas-webkitLineDash.html
* bindings/js/JSCanvasRenderingContext2DCustom.cpp:
(WebCore::JSCanvasRenderingContext2D::webkitLineDash):
(WebCore::JSCanvasRenderingContext2D::setWebkitLineDash):
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::State::State):
(WebCore::CanvasRenderingContext2D::webkitLineDash):
(WebCore::CanvasRenderingContext2D::setWebkitLineDash):
(WebCore::CanvasRenderingContext2D::webkitLineDashOffset):
(WebCore::CanvasRenderingContext2D::setWebkitLineDashOffset):
* html/canvas/CanvasRenderingContext2D.h:
* html/canvas/CanvasRenderingContext2D.idl:
LayoutTests:
* fast/canvas/canvas-webkitLineDash-expected.txt: Added.
* fast/canvas/canvas-webkitLineDash-invalid-expected.txt: Added.
* fast/canvas/canvas-webkitLineDash-invalid.html: Added.
* fast/canvas/canvas-webkitLineDash.html: Added.
* fast/canvas/script-tests/canvas-webkitLineDash-invalid.js: Added.
(trySettingLineDash):
(trySettingLineDashOffset):
* fast/canvas/script-tests/canvas-webkitLineDash.js: Added.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96626
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy_horton@apple.com [Tue, 4 Oct 2011 18:56:26 +0000 (18:56 +0000)]
Additional unreviewed Lion SVG pixel test rebaselining.
* platform/mac-snowleopard/svg/W3C-SVG-1.1/coords-units-01-b-expected.png: Added.
* platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-image-01-b-expected.png: Added.
* platform/mac-snowleopard/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png: Added.
* platform/mac-snowleopard/svg/W3C-SVG-1.1/pservers-grad-02-b-expected.png: Added.
* platform/mac-snowleopard/svg/W3C-SVG-1.1/pservers-grad-12-b-expected.png: Added.
* platform/mac-snowleopard/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.png: Added.
* platform/mac-snowleopard/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.png: Added.
* platform/mac-snowleopard/svg/carto.net: Added.
* platform/mac-snowleopard/svg/carto.net/selectionlist-expected.png: Added.
* platform/mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.png: Added.
* platform/mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.png: Added.
* platform/mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.png: Added.
* platform/mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.png: Added.
* platform/mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-type-prop-expected.png: Added.
* platform/mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-values-prop-expected.png: Added.
* platform/mac-snowleopard/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png: Added.
* platform/mac-snowleopard/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png: Added.
* platform/mac-snowleopard/svg/dynamic-updates/SVGLinearGradientElement-dom-gradientUnits-attr-expected.png: Added.
* platform/mac-snowleopard/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientTransform-prop-expected.png: Added.
* platform/mac-snowleopard/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientUnits-prop-expected.png: Added.
* platform/mac-snowleopard/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientTransform-prop-expected.png: Added.
* platform/mac/svg/W3C-SVG-1.1/coords-units-01-b-expected.png:
* platform/mac/svg/W3C-SVG-1.1/filters-image-01-b-expected.png:
* platform/mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png:
* platform/mac/svg/W3C-SVG-1.1/pservers-grad-02-b-expected.png:
* platform/mac/svg/W3C-SVG-1.1/pservers-grad-12-b-expected.png:
* platform/mac/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.png:
* platform/mac/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.png:
* platform/mac/svg/carto.net/selectionlist-expected.png:
* platform/mac/svg/custom/external-paintserver-reference-expected.png: Added.
* platform/mac/svg/custom/linking-base-external-reference-expected.png: Added.
* platform/mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-type-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-values-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGLinearGradientElement-dom-gradientUnits-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientTransform-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientUnits-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientTransform-prop-expected.png:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96625
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mdelaney@apple.com [Tue, 4 Oct 2011 18:41:41 +0000 (18:41 +0000)]
Allow canvas backing store to be lazily allocated
https://bugs.webkit.org/show_bug.cgi?id=67054
Reviewed by Darin Adler.
No new tests; doesn't affect behavior.
* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::createImageBuffer): Removed the setting of lineWidth
that caused the eager creation of ImageBuffer to use its GraphicsContext.
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::CanvasRenderingContext2D): Added in default
line width setting along with other default context settings.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96624
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Tue, 4 Oct 2011 18:39:33 +0000 (18:39 +0000)]
Move font-fixup code in WebKitTestRunner to a better place
https://bugs.webkit.org/show_bug.cgi?id=69356
Reviewed by Sam Weinig.
Move code that swizzles NSFontManager methods to ActivateFonts.mm, which
already contains font-related code.
* WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::initialize):
* WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
(WTR::allowedFontFamilySet):
(WTR::drt_NSFontManager_availableFontFamilies):
(WTR::drt_NSFontManager_availableFonts):
(WTR::swizzleNSFontManagerMethods):
(WTR::activateFonts):
* WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
(WTR::InjectedBundle::platformInitialize):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96623
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy_horton@apple.com [Tue, 4 Oct 2011 18:35:29 +0000 (18:35 +0000)]
Partial unreviewed rebaselines for Lion SVG pixel tests.
* platform/mac-snowleopard/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.png: Added.
* platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-31-t-expected.png: Added.
* platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-33-t-expected.png: Added.
* platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-34-t-expected.png: Added.
* platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-44-t-expected.png: Added.
* platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-52-t-expected.png: Added.
* platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-light-01-f-expected.png: Added.
* platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-turb-01-f-expected.png: Added.
* platform/mac-snowleopard/svg/W3C-SVG-1.1/fonts-elem-02-t-expected.png: Added.
* platform/mac-snowleopard/svg/W3C-SVG-1.1/text-fonts-03-t-expected.png: Added.
* platform/mac-snowleopard/svg/css: Added.
* platform/mac-snowleopard/svg/css/composite-shadow-example-expected.png: Added.
* platform/mac-snowleopard/svg/css/composite-shadow-with-opacity-expected.png: Added.
* platform/mac-snowleopard/svg/css/stars-with-shadow-expected.png: Added.
* platform/mac-snowleopard/svg/custom: Added.
* platform/mac-snowleopard/svg/custom/altglyph-expected.png: Added.
* platform/mac-snowleopard/svg/custom/dynamic-svg-document-creation-expected.png: Added.
* platform/mac-snowleopard/svg/custom/getscreenctm-in-scrollable-div-area-expected.png: Added.
* platform/mac-snowleopard/svg/custom/getscreenctm-in-scrollable-div-area-nested-expected.png: Added.
* platform/mac-snowleopard/svg/custom/getscreenctm-in-scrollable-svg-area-expected.png: Added.
* platform/mac-snowleopard/svg/custom/invisible-text-after-scrolling-expected.png: Added.
* platform/mac-snowleopard/svg/custom/junk-data-expected.png: Added.
* platform/mac-snowleopard/svg/custom/missing-xlink-expected.png: Added.
* platform/mac-snowleopard/svg/custom/object-sizing-no-width-height-expected.png: Added.
* platform/mac-snowleopard/svg/custom/path-bad-data-expected.png: Added.
* platform/mac-snowleopard/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png: Added.
* platform/mac-snowleopard/svg/custom/text-xy-updates-SVGList-expected.png: Added.
* platform/mac-snowleopard/svg/custom/use-font-face-crash-expected.png: Added.
* platform/mac-snowleopard/svg/dom: Added.
* platform/mac-snowleopard/svg/dom/SVGLengthList-appendItem-expected.png: Added.
* platform/mac-snowleopard/svg/dom/SVGLengthList-basics-expected.png: Added.
* platform/mac-snowleopard/svg/dom/SVGLengthList-initialize-expected.png: Added.
* platform/mac-snowleopard/svg/dom/SVGLengthList-insertItemBefore-expected.png: Added.
* platform/mac-snowleopard/svg/dom/SVGLengthList-removeItem-expected.png: Added.
* platform/mac-snowleopard/svg/dom/SVGLengthList-replaceItem-expected.png: Added.
* platform/mac-snowleopard/svg/dom/SVGLengthList-xml-dom-modifications-expected.png: Added.
* platform/mac-snowleopard/svg/dom/SVGNumberList-basics-expected.png: Added.
* platform/mac-snowleopard/svg/dom/SVGPathSegList-appendItem-expected.png: Added.
* platform/mac-snowleopard/svg/dom/SVGPathSegList-clear-and-initialize-expected.png: Added.
* platform/mac-snowleopard/svg/dom/SVGPathSegList-insertItemBefore-expected.png: Added.
* platform/mac-snowleopard/svg/dom/SVGPathSegList-removeItem-expected.png: Added.
* platform/mac-snowleopard/svg/dom/SVGPathSegList-replaceItem-expected.png: Added.
* platform/mac-snowleopard/svg/dom/SVGPointList-basics-expected.png: Added.
* platform/mac-snowleopard/svg/dom/SVGStringList-basics-expected.png: Added.
* platform/mac-snowleopard/svg/dom/SVGTransformList-basics-expected.png: Added.
* platform/mac-snowleopard/svg/dynamic-updates: Added.
* platform/mac-snowleopard/svg/dynamic-updates/SVGFEBlendElement-dom-in-attr-expected.png: Added.
* platform/mac-snowleopard/svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr-expected.png: Added.
* platform/mac-snowleopard/svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr-expected.png: Added.
* platform/mac-snowleopard/svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop-expected.png: Added.
* platform/mac-snowleopard/svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop-expected.png: Added.
* platform/mac-snowleopard/svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.png: Added.
* platform/mac-snowleopard/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.png: Added.
* platform/mac-snowleopard/svg/dynamic-updates/SVGLineElement-svgdom-requiredFeatures-expected.png: Added.
* platform/mac-snowleopard/svg/dynamic-updates/SVGTextElement-dom-lengthAdjust-attr-expected.png: Added.
* platform/mac-snowleopard/svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop-expected.png: Added.
* platform/mac-snowleopard/svg/dynamic-updates/SVGUseElement-dom-requiredFeatures-expected.png: Added.
* platform/mac-snowleopard/svg/hixie: Added.
* platform/mac-snowleopard/svg/hixie/error: Added.
* platform/mac-snowleopard/svg/hixie/error/012-expected.png: Added.
* platform/mac-snowleopard/svg/in-html: Added.
* platform/mac-snowleopard/svg/in-html/circle-expected.png: Added.
* platform/mac-snowleopard/svg/overflow: Added.
* platform/mac-snowleopard/svg/overflow/overflow-on-outermost-svg-element-defaults-expected.png: Added.
* platform/mac-snowleopard/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-1-expected.png: Added.
* platform/mac-snowleopard/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-2-expected.png: Added.
* platform/mac-snowleopard/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-3-expected.png: Added.
* platform/mac-snowleopard/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults-expected.png: Added.
* platform/mac-snowleopard/svg/text/kerning-expected.png: Added.
* platform/mac-snowleopard/svg/text/multichar-glyph-expected.png: Added.
* platform/mac-snowleopard/svg/wicd: Added.
* platform/mac-snowleopard/svg/wicd/rightsizing-grid-expected.png: Added.
* platform/mac-snowleopard/svg/wicd/test-rightsizing-b-expected.png: Added.
* platform/mac-snowleopard/svg/wicd/test-scalable-background-image1-expected.png: Added.
* platform/mac-snowleopard/svg/zoom: Added.
* platform/mac-snowleopard/svg/zoom/page: Added.
* platform/mac-snowleopard/svg/zoom/page/absolute-sized-document-scrollbars-expected.png: Added.
* platform/mac-snowleopard/svg/zoom/page/relative-sized-document-scrollbars-expected.png: Added.
* platform/mac-snowleopard/svg/zoom/page/zoom-foreignObject-expected.png: Added.
* platform/mac-snowleopard/svg/zoom/page/zoom-hixie-mixed-008-expected.png: Added.
* platform/mac-snowleopard/svg/zoom/page/zoom-mask-with-percentages-expected.png: Added.
* platform/mac-snowleopard/svg/zoom/page/zoom-svg-float-border-padding-expected.png: Added.
* platform/mac-snowleopard/svg/zoom/text: Added.
* platform/mac-snowleopard/svg/zoom/text/zoom-svg-float-border-padding-expected.png: Added.
* platform/mac/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.png:
* platform/mac/svg/W3C-SVG-1.1/animate-elem-31-t-expected.png:
* platform/mac/svg/W3C-SVG-1.1/animate-elem-33-t-expected.png:
* platform/mac/svg/W3C-SVG-1.1/animate-elem-34-t-expected.png:
* platform/mac/svg/W3C-SVG-1.1/animate-elem-44-t-expected.png:
* platform/mac/svg/W3C-SVG-1.1/animate-elem-52-t-expected.png:
* platform/mac/svg/W3C-SVG-1.1/filters-light-01-f-expected.png:
* platform/mac/svg/W3C-SVG-1.1/filters-turb-01-f-expected.png:
* platform/mac/svg/W3C-SVG-1.1/fonts-elem-02-t-expected.png:
* platform/mac/svg/W3C-SVG-1.1/text-fonts-03-t-expected.png:
* platform/mac/svg/css/composite-shadow-example-expected.png:
* platform/mac/svg/css/composite-shadow-with-opacity-expected.png:
* platform/mac/svg/css/stars-with-shadow-expected.png:
* platform/mac/svg/custom/altglyph-expected.png:
* platform/mac/svg/custom/dynamic-svg-document-creation-expected.png:
* platform/mac/svg/custom/getscreenctm-in-scrollable-div-area-expected.png:
* platform/mac/svg/custom/getscreenctm-in-scrollable-div-area-nested-expected.png:
* platform/mac/svg/custom/getscreenctm-in-scrollable-svg-area-expected.png:
* platform/mac/svg/custom/invisible-text-after-scrolling-expected.png:
* platform/mac/svg/custom/junk-data-expected.png:
* platform/mac/svg/custom/missing-xlink-expected.png:
* platform/mac/svg/custom/object-sizing-no-width-height-expected.png:
* platform/mac/svg/custom/path-bad-data-expected.png:
* platform/mac/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
* platform/mac/svg/custom/text-xy-updates-SVGList-expected.png:
* platform/mac/svg/custom/use-font-face-crash-expected.png:
* platform/mac/svg/dom/SVGLengthList-appendItem-expected.png:
* platform/mac/svg/dom/SVGLengthList-basics-expected.png:
* platform/mac/svg/dom/SVGLengthList-initialize-expected.png:
* platform/mac/svg/dom/SVGLengthList-insertItemBefore-expected.png:
* platform/mac/svg/dom/SVGLengthList-removeItem-expected.png:
* platform/mac/svg/dom/SVGLengthList-replaceItem-expected.png:
* platform/mac/svg/dom/SVGLengthList-xml-dom-modifications-expected.png:
* platform/mac/svg/dom/SVGNumberList-basics-expected.png:
* platform/mac/svg/dom/SVGPathSegList-appendItem-expected.png:
* platform/mac/svg/dom/SVGPathSegList-clear-and-initialize-expected.png:
* platform/mac/svg/dom/SVGPathSegList-insertItemBefore-expected.png:
* platform/mac/svg/dom/SVGPathSegList-removeItem-expected.png:
* platform/mac/svg/dom/SVGPathSegList-replaceItem-expected.png:
* platform/mac/svg/dom/SVGPointList-basics-expected.png:
* platform/mac/svg/dom/SVGStringList-basics-expected.png:
* platform/mac/svg/dom/SVGTransformList-basics-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEBlendElement-dom-in-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGLineElement-svgdom-requiredFeatures-expected.png:
* platform/mac/svg/dynamic-updates/SVGTextElement-dom-lengthAdjust-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGUseElement-dom-requiredFeatures-expected.png:
* platform/mac/svg/hixie/error/012-expected.png:
* platform/mac/svg/in-html/circle-expected.png:
* platform/mac/svg/overflow/overflow-on-outermost-svg-element-defaults-expected.png:
* platform/mac/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-1-expected.png:
* platform/mac/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-2-expected.png:
* platform/mac/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-3-expected.png:
* platform/mac/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults-expected.png:
* platform/mac/svg/text/kerning-expected.png:
* platform/mac/svg/text/multichar-glyph-expected.png:
* platform/mac/svg/wicd/rightsizing-grid-expected.png:
* platform/mac/svg/wicd/test-rightsizing-b-expected.png:
* platform/mac/svg/wicd/test-scalable-background-image1-expected.png:
* platform/mac/svg/zoom/page/absolute-sized-document-scrollbars-expected.png:
* platform/mac/svg/zoom/page/relative-sized-document-scrollbars-expected.png:
* platform/mac/svg/zoom/page/zoom-foreignObject-expected.png:
* platform/mac/svg/zoom/page/zoom-hixie-mixed-008-expected.png:
* platform/mac/svg/zoom/page/zoom-mask-with-percentages-expected.png:
* platform/mac/svg/zoom/page/zoom-svg-float-border-padding-expected.png:
* platform/mac/svg/zoom/text/zoom-svg-float-border-padding-expected.png:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96622
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Tue, 4 Oct 2011 18:30:32 +0000 (18:30 +0000)]
Add support for the CSP connect-src directive
https://bugs.webkit.org/show_bug.cgi?id=69353
Reviewed by Adam Barth.
Add CSP support for XMLHttpRequest, WebSockets and EventSource.
Source/WebCore:
Tests: http/tests/security/contentSecurityPolicy/connect-src-eventsource-allowed.html
http/tests/security/contentSecurityPolicy/connect-src-eventsource-blocked.html
http/tests/security/contentSecurityPolicy/connect-src-websocket-allowed.html
http/tests/security/contentSecurityPolicy/connect-src-websocket-blocked.html
http/tests/security/contentSecurityPolicy/connect-src-xmlhttprequest-allowed.html
http/tests/security/contentSecurityPolicy/connect-src-xmlhttprequest-blocked.html
* page/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::allowConnectFromSource):
(WebCore::ContentSecurityPolicy::addDirective):
* page/ContentSecurityPolicy.h:
Add connect-src directive parsing and predicate.
* page/EventSource.cpp:
(WebCore::EventSource::create):
* websockets/WebSocket.cpp:
(WebCore::WebSocket::connect):
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::open):
Test allowConnectFromSource when establishing a connection.
LayoutTests:
* http/tests/security/contentSecurityPolicy/connect-src-eventsource-allowed-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/connect-src-eventsource-allowed.html: Added.
* http/tests/security/contentSecurityPolicy/connect-src-eventsource-blocked-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/connect-src-eventsource-blocked.html: Added.
* http/tests/security/contentSecurityPolicy/connect-src-websocket-allowed-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/connect-src-websocket-allowed.html: Added.
* http/tests/security/contentSecurityPolicy/connect-src-websocket-blocked-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/connect-src-websocket-blocked.html: Added.
* http/tests/security/contentSecurityPolicy/connect-src-xmlhttprequest-allowed-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/connect-src-xmlhttprequest-allowed.html: Added.
* http/tests/security/contentSecurityPolicy/connect-src-xmlhttprequest-blocked-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/connect-src-xmlhttprequest-blocked.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96621
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Tue, 4 Oct 2011 18:17:04 +0000 (18:17 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=69317
[CSS3 Regions] Make overflow:hidden/auto/scroll sections behave properly when split across regions. This
includes sizing and positioning independently in each region, clipping independently in each region, and
shifting to avoid floats in each region.
Reviewed by Anders Carlsson.
Source/WebCore:
Added many new tests in fast/regions.
* editing/Editor.cpp:
(WebCore::Editor::insideVisibleArea):
Patching a call to overflowClipRect, which now includes a region argument so that clipping can be adjusted
per-region.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutBlock):
Don't clear out the cached region information when the width changes. Instead make a new call to
the flow thread to check if widths changed in any region and set relayoutChildren to true if so.
(WebCore::RenderBlock::computeStartPositionDeltaForChildAvoidingFloats):
This is a new function that has been split out from determineLogicalLeftPositionForChild so that it can
be called by region code to compute offsets independently in each region without altering the overall object's
logical left position.
(WebCore::RenderBlock::determineLogicalLeftPositionForChild):
Patched to call computeStartPositionDeltaForChildAvoidingFloats instead of doing the work of avoiding the floats
itself.
(WebCore::RenderBlock::computeLogicalLocationForFloat):
Fix the left clamping code to clamp to the left border in the correct region rather than always just clamping
to 0.
(WebCore::RenderBlock::logicalLeftOffsetForContent):
(WebCore::RenderBlock::logicalRightOffsetForContent):
Tweaked to handle the new signature of borderBoxRectInRegion.
(WebCore::RenderBlock::nextFloatLogicalBottomBelow):
Reworked not to return 0 on failure or when done, but to just return the current height. This is a more
fitting answer for the function to return when no more floats remain.
(WebCore::RenderBlock::getClearDelta):
Big changes to this function. It was never patched to support writing modes, so the new code is all
writing-mode-aware now. Also improved the computeLogicalWidth() call to make sure margins didn't get incorrectly changed.
The code computes transient information in each region as the object tries to find a place to fit, so that the
old widths are properly retained when layout of that child later checks to see if it needs to relayout children or not.
(WebCore::RenderBlock::nodeAtPoint):
Patched to call overflowClipRect with the region being hit tested.
(WebCore::inNormalFlow):
Tweaked to not need the initialBlock variable.
(WebCore::RenderBlock::applyBeforeBreak):
(WebCore::RenderBlock::applyAfterBreak):
(WebCore::RenderBlock::pageLogicalHeightForOffset):
(WebCore::RenderBlock::pageRemainingLogicalHeightForOffset):
(WebCore::RenderBlock::adjustForUnsplittableChild):
(WebCore::RenderBlock::adjustLinePositionForPagination):
(WebCore::RenderBlock::lineWidthForPaginatedLineChanged):
Tweaked to use inRenderFlowThread() now that it exists. Also removing the regionsHaveUniformLogicalWidth()
optimization, since you can't rely on that when objects size differently depending on floats. In other words,
the future of pagination is variable width objects even in printing/columns.
(WebCore::RenderBlock::offsetFromLogicalTopOfFirstPage):
Renamed to make it more clear what logicalPageOffset() was. It's your offset from the top of the first page.
(WebCore::RenderBlock::regionAtBlockOffset):
New helper function for accessing the region at a given offset within your block.
(WebCore::RenderBlock::logicalWidthChangedInRegions):
New helper function that computes whether or not your logical width information changed in any regions. If so,
relayoutChildren gets set to true (just as it would have when computeLogicalWidth for the overall block changes
values).
(WebCore::RenderBlock::collapsedMarginBeforeForChild):
(WebCore::RenderBlock::collapsedMarginAfterForChild):
(WebCore::RenderBlock::marginBeforeForChild):
(WebCore::RenderBlock::marginAfterForChild):
(WebCore::RenderBlock::marginLogicalLeftForChild):
(WebCore::RenderBlock::marginLogicalRightForChild):
(WebCore::RenderBlock::marginStartForChild):
(WebCore::RenderBlock::marginEndForChild):
Tweaked because of const to take const arguments.
* rendering/RenderBlock.h:
(WebCore::RenderBlock::availableLogicalWidthForLine):
(WebCore::RenderBlock::logicalRightOffsetForLine):
(WebCore::RenderBlock::logicalLeftOffsetForLine):
(WebCore::RenderBlock::startOffsetForLine):
(WebCore::RenderBlock::logicalWidthForChild):
(WebCore::RenderBlock::logicalHeightForChild):
(WebCore::RenderBlock::logicalTopForChild):
(WebCore::RenderBlock::logicalLeftForChild):
(WebCore::RenderBlock::availableLogicalWidthForContent):
(WebCore::RenderBlock::startOffsetForContent):
(WebCore::RenderBlock::logicalLeftOffsetForContent):
(WebCore::RenderBlock::logicalRightOffsetForContent):
Reworking these functions so versions exist that take regions and page offsets to avoid having to recalculate
where you are over and over again as you walk up a containing block chain.
* rendering/RenderBlockLineLayout.cpp:
(WebCore::LineWidth::fitBelowFloats):
Changed to handle the better return value for nextFloatLogicalBottomBelow.
(WebCore::RenderBlock::checkPaginationAndFloatsAtEndLine):
Removing the uniform logical width optimization.
* rendering/RenderBox.cpp:
(WebCore::RenderBox::borderBoxRectInRegion):
Changed to take a region and offset from the first page so that it doesn't have to be recomputed as you recur up
the containing block chain.
(WebCore::RenderBox::clearRenderBoxRegionInfo):
Changed to just use inRenderFlowThread().
(WebCore::RenderBox::pushContentsClip):
Changed for the new region-parameterized overflow clip function.
(WebCore::RenderBox::overflowClipRect):
Now takes a region so that a specific clip rect can be returned sized to the appropriate border box in that
region.
(WebCore::RenderBox::containingBlockLogicalWidthForContent):
(WebCore::RenderBox::containingBlockLogicalWidthForContentInRegion):
Objects in flow threads no longer shrink to avoid floats when computing their overall widths. The region-specific
check now does the shrinking. It checks at the point where the region slices the object, or the top of the object if
it begins in the middle of the region.
(WebCore::RenderBox::computeLogicalWidth):
(WebCore::RenderBox::computeLogicalWidthInRegion):
Push all the rest of the computeLogicalWidth code into computeLogicalWidthInRegion.
(WebCore::RenderBox::renderBoxRegionInfo):
Changed to take the region and the offset from the top of the first page to avoid recomputation.
* rendering/RenderBox.h:
(WebCore::RenderBox::hasRenderOverflow):
(WebCore::RenderBox::hasVisualOverflow):
New helper used by the RenderLayer code to avoid having to check visual overflow when none exists.
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
Use the new region-specific overflow clip.
* rendering/RenderBoxRegionInfo.h:
(WebCore::RenderBoxRegionInfo::shiftLogicalLeft):
Helper used by the region code to shift a box over when floats cause it to move.
* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::computeLogicalWidth):
Remove the optimization to avoid creating box info for uniform widths.
(WebCore::RenderFlowThread::paintIntoRegion):
Make the clip rects used when painting the flow thread's layer tree temporary in each region.
(WebCore::RenderFlowThread::removeRenderBoxRegionInfo):
Removing the uniform logical width optimization
(WebCore::RenderFlowThread::logicalWidthChangedInRegions):
* rendering/RenderFlowThread.h:
New helper called to see if a block needs to relayout its children because its width changed in some
region.
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paint):
(WebCore::RenderLayer::paintLayer):
(WebCore::RenderLayer::hitTestLayer):
(WebCore::RenderLayer::updateClipRects):
(WebCore::RenderLayer::calculateClipRects):
(WebCore::RenderLayer::parentClipRects):
(WebCore::RenderLayer::backgroundClipRect):
(WebCore::RenderLayer::calculateRects):
(WebCore::RenderLayer::childrenClipRect):
(WebCore::RenderLayer::selfClipRect):
(WebCore::RenderLayer::repaintBlockSelectionGaps):
* rendering/RenderLayer.h:
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateCompositedBounds):
(WebCore::clipBox):
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
(WebCore::RenderLayerBacking::paintIntoLayer):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::addToOverlapMap):
(WebCore::RenderLayerCompositor::clippedByAncestor):
Changing all the layer clipping code to pass regions through to all of the helper functions involved. This is
so overflowClipRect can ultimately take a region. Eventually when we get positioned objects moving independently
in each region, we'll patch the "clip" property as well, and it will be much easier because all the plumbing has
been put in place here for overflow.
* rendering/RenderObject.cpp:
(WebCore::RenderObject::enclosingRenderFlowThread):
Optimized to not walk up the render tree if we're in layout and a currentRenderFlowThread() exists.
* rendering/RenderRegion.cpp:
(WebCore::RenderRegion::renderBoxRegionInfo):
(WebCore::RenderRegion::setRenderBoxRegionInfo):
(WebCore::RenderRegion::takeRenderBoxRegionInfo):
Removing the optimization for uniform logical width regions. Changed remove to take so that the caller
can examine it before deleting.
(WebCore::RenderRegion::offsetFromLogicalTopOfFirstPage):
* rendering/RenderRegion.h:
Helper function that computes the region's offset from the top of the first page.
* rendering/RenderTable.cpp:
(WebCore::RenderTable::overflowClipRect):
(WebCore::RenderTable::nodeAtPoint):
* rendering/RenderTable.h:
* rendering/RenderTableCell.h:
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::nodeAtPoint):
Changed to pass the region to overflowClipRect.
* rendering/RenderTreeAsText.cpp:
(WebCore::writeLayers):
Modified because the layer clip functions need regions now.
* rendering/RenderView.h:
(WebCore::RenderView::pushLayoutState):
Changed to use inRenderFlowThread over view()->hasRenderFlowThread.
* rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::paint):
Patched to use the new overflowClipRect that is region-specific.
LayoutTests:
* fast/regions/floats-basic-in-variable-width-regions.html: Added.
* fast/regions/overflow-in-uniform-regions-dynamic.html: Added.
* fast/regions/overflow-in-uniform-regions.html: Added.
* fast/regions/overflow-in-variable-width-regions.html:
* fast/regions/overflow-moving-below-floats-in-variable-width-regions.html: Added.
* fast/regions/overflow-not-moving-below-floats-in-variable-width-regions.html: Added.
* fast/regions/overflow-rtl-in-variable-width-regions.html:
* fast/regions/overflow-size-change-in-variable-width-regions.html: Added.
* fast/regions/overflow-size-change-with-stacking-context.html: Added.
* platform/mac/fast/regions/floats-basic-in-variable-width-regions-expected.png: Added.
* platform/mac/fast/regions/floats-basic-in-variable-width-regions-expected.txt: Added.
* platform/mac/fast/regions/overflow-in-uniform-regions-dynamic-expected.png: Added.
* platform/mac/fast/regions/overflow-in-uniform-regions-dynamic-expected.txt: Added.
* platform/mac/fast/regions/overflow-in-uniform-regions-expected.png: Added.
* platform/mac/fast/regions/overflow-in-uniform-regions-expected.txt: Added.
* platform/mac/fast/regions/overflow-in-variable-width-regions-expected.png:
* platform/mac/fast/regions/overflow-in-variable-width-regions-expected.txt:
* platform/mac/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.png: Added.
* platform/mac/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.txt: Added.
* platform/mac/fast/regions/overflow-not-moving-below-floats-in-variable-width-regions-expected.png: Added.
* platform/mac/fast/regions/overflow-not-moving-below-floats-in-variable-width-regions-expected.txt: Added.
* platform/mac/fast/regions/overflow-rtl-in-variable-width-regions-expected.png:
* platform/mac/fast/regions/overflow-rtl-in-variable-width-regions-expected.txt:
* platform/mac/fast/regions/overflow-size-change-in-variable-width-regions-expected.png: Added.
* platform/mac/fast/regions/overflow-size-change-in-variable-width-regions-expected.txt: Added.
* platform/mac/fast/regions/overflow-size-change-with-stacking-context-expected.png: Added.
* platform/mac/fast/regions/overflow-size-change-with-stacking-context-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96620
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jeffm@apple.com [Tue, 4 Oct 2011 18:15:42 +0000 (18:15 +0000)]
WKPreferences should allow control of application chrome mode
https://bugs.webkit.org/show_bug.cgi?id=69344
Reviewed by Dan Bernstein.
* Shared/WebPreferencesStore.h: Add application chrome mode setting to FOR_EACH_WEBKIT_BOOL_PREFERENCE().
* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetApplicationChromeModeEnabled): Added.
(WKPreferencesGetApplicationChromeModeEnabled): Added.
* UIProcess/API/C/WKPreferencesPrivate.h: Added WKPreferencesSetApplicationChromeModeEnabled() and WKPreferencesGetApplicationChromeModeEnabled().
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences): Set application chrome mode setting.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96619
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 4 Oct 2011 18:15:30 +0000 (18:15 +0000)]
[EFL] DRT: Add DumpRenderTree.cpp
https://bugs.webkit.org/show_bug.cgi?id=62034
Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-10-04
Reviewed by Antonio Gomes.
This is the main implementation file for EFL's DumpRenderTree.
* DumpRenderTree/efl/DumpRenderTree.cpp: Added.
(dumpFramesAsText):
(dumpFrameScrollPosition):
(shouldLogFrameLoadDelegates):
(shouldDumpAsText):
(sendPixelResultsEOF):
(invalidateAnyPreviousWaitToDumpWatchdog):
(onEcoreEvasResize):
(onCloseWindow):
(useLongRunningServerMode):
(parseCommandLineOptions):
(getFinalTestURL):
(getExpectedPixelHash):
(createLayoutTestController):
(runTest):
(runTestingServerLoop):
(adjustOutputTypeByMimeType):
(dumpFrameContentsAsText):
(shouldDumpFrameScrollPosition):
(shouldDumpPixelsAndCompareWithExpected):
(shouldDumpBackForwardList):
(initEfl):
(shutdownEfl):
(displayWebView):
(dump):
(initEcoreEvas):
(main):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96618
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 4 Oct 2011 18:15:09 +0000 (18:15 +0000)]
More work towards making PlatformWheelEvent immutable
https://bugs.webkit.org/show_bug.cgi?id=69348
Reviewed by Sam Weinig.
More work on getting rid of m_isAccepted from PlatformWheelEvent. Add more asserts
that the return value of handleWheelEvent is equal to m_isAccepted.
* page/EventHandler.cpp:
(WebCore::EventHandler::handleWheelEvent):
* platform/ScrollAnimator.cpp:
(WebCore::ScrollAnimator::handleWheelEvent):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96617
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
carlosgc@webkit.org [Tue, 4 Oct 2011 18:14:19 +0000 (18:14 +0000)]
[GTK] Implement default error pages in WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=69255
Reviewed by Martin Robinson.
* UIProcess/API/gtk/WebKitError.cpp:
(webkit_policy_error_quark): Add quark for policy errors.
(webkit_plugin_error_quark): Add quark for plugin errors.
* UIProcess/API/gtk/WebKitError.h: Add policy and plugin errors.
* UIProcess/API/gtk/WebKitWebLoaderClient.cpp:
(webkitWebLoaderClientLoadFailed): Load a custom error page when
load failed and signal has not been handled.
(webkit_web_loader_client_class_init): Add default implementation
for provisional_load_failed and load_failed virtual methods.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96616
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caryclark@google.com [Tue, 4 Oct 2011 18:12:58 +0000 (18:12 +0000)]
Inset focus ring (Skia on Mac)
https://bugs.webkit.org/show_bug.cgi?id=69166
http://code.google.com/p/chromium/issues/detail?id=97956
This focus ring was drawn too large and was left tracks
in subsequent invalidations. Make it more closely match
the CG version.
Reviewed by Adam Barth.
No new tests. This platform is not enabled.
* platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::getFocusRingOutset):
(WebCore::GraphicsContext::drawFocusRing):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96615
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
carlosgc@webkit.org [Tue, 4 Oct 2011 18:11:55 +0000 (18:11 +0000)]
[GTK] Add webkit_web_view_load_alternate_html() to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=69254
Reviewed by Martin Robinson.
* UIProcess/API/gtk/WebKitWebView.cpp:
(webkit_web_view_load_alternate_html):
* UIProcess/API/gtk/WebKitWebView.h:
* UIProcess/API/gtk/tests/testloading.c:
(loadAlternateContentLoadFinished):
(loadAlternateContentLoadFailed):
(testLoadAlternateContent):
(main):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96614
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jonlee@apple.com [Tue, 4 Oct 2011 18:06:44 +0000 (18:06 +0000)]
Extend DOM WheelEvent to differentiate between physical and logical scroll directions
https://bugs.webkit.org/show_bug.cgi?id=68959
<rdar://problem/
10036688>
Reviewed by Sam Weinig.
Source/JavaScriptCore:
* wtf/Platform.h: Added HAVE_INVERTED_WHEEL_EVENTS for Lion and later.
Source/WebCore:
Test: fast/events/wheelevent-direction-inverted-from-device.html
* dom/WheelEvent.cpp:
(WebCore::WheelEvent::WheelEvent):
(WebCore::WheelEvent::initWheelEvent):
(WebCore::WheelEventDispatchMediator::WheelEventDispatchMediator):
* dom/WheelEvent.h:
(WebCore::WheelEvent::create):
(WebCore::WheelEvent::webkitDirectionInvertedFromDevice):
* dom/WheelEvent.idl: Added the webkitDirectionInvertedFromDevice idl attribute.
* platform/PlatformWheelEvent.h:
(WebCore::PlatformWheelEvent::PlatformWheelEvent):
(WebCore::PlatformWheelEvent::webkitDirectionInvertedFromDevice):
* platform/efl/PlatformWheelEventEfl.cpp:
(WebCore::PlatformWheelEvent::PlatformWheelEvent): default to false.
* platform/gtk/PlatformWheelEventGtk.cpp:
(WebCore::PlatformWheelEvent::PlatformWheelEvent): default to false.
* platform/mac/WheelEventMac.mm:
(WebCore::PlatformWheelEvent::PlatformWheelEvent): if building on Lion or later, use
[NSEvent isDirectionInvertedFromDevice].
* platform/qt/WheelEventQt.cpp:
(WebCore::PlatformWheelEvent::PlatformWheelEvent): default to false.
* platform/win/WheelEventWin.cpp:
(WebCore::PlatformWheelEvent::PlatformWheelEvent): default to false.
* platform/wx/MouseWheelEventWx.cpp:
(WebCore::PlatformWheelEvent::PlatformWheelEvent): default to false.
Source/WebKit2:
* Shared/WebEvent.h:
(WebKit::WebWheelEvent::directionInvertedFromDevice):
* Shared/WebEventConversion.cpp:
(WebKit::WebKit2PlatformWheelEvent::WebKit2PlatformWheelEvent):
* Shared/WebWheelEvent.cpp:
(WebKit::WebWheelEvent::WebWheelEvent):
(WebKit::WebWheelEvent::encode):
(WebKit::WebWheelEvent::decode):
* Shared/mac/WebEventFactory.mm:
(WebKit::WebEventFactory::createWebWheelEvent): get the flag from the NSEvent.
* UIProcess/WebPageProxy.cpp:
(WebKit::coalesce):
LayoutTests:
* fast/events/wheelevent-direction-inverted-from-device-expected.txt: Added.
* fast/events/wheelevent-direction-inverted-from-device.html: Added.
* platform/mac-wk2/Skipped: WKTR does not support mouse scroll events yet.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96613
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 4 Oct 2011 18:04:21 +0000 (18:04 +0000)]
[EFL] Fix compilation when SQLite and/or libxslt are not installed in /usr/include
https://bugs.webkit.org/show_bug.cgi?id=69338
Unreviewed build fix
Patch by Rémi Duraffort <remi.duraffort@st.com> on 2011-10-04
Source/WebCore:
* CMakeListsEfl.txt:
Source/WebKit/efl:
* CMakeListsEfl.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96612
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 4 Oct 2011 18:02:41 +0000 (18:02 +0000)]
[WebKit2][gtk] Generate gtk-doc for WebKit2-GTK.
https://bugs.webkit.org/show_bug.cgi?id=69325
Patch by Nayan Kumar K <nayankk@motorola.com> on 2011-10-04
Reviewed by Gustavo Noronha Silva.
Documentation generation for WebKit2-GTK+ APIs
using gtk-doc.
.:
* configure.ac:
Source/WebKit2:
* GNUmakefile.am: Added doc generation files to EXTRA_DIST.
* UIProcess/API/gtk/docs/GNUmakefile.am: Makefile for doc generation.
* UIProcess/API/gtk/docs/version.xml.in: Version information.
* UIProcess/API/gtk/docs/webkit2gtk-docs.sgml: Document template.
* UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Document sections added.
* UIProcess/API/gtk/docs/webkit2gtk.types: Added GObjects types.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96611
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 4 Oct 2011 18:00:32 +0000 (18:00 +0000)]
Resource loader should block HTTP redirects to local resources
https://bugs.webkit.org/show_bug.cgi?id=68706
Patch by Ken Buchanan <kenrb@chromium.org> on 2011-10-03
Reviewed by Adam Barth.
Source/WebCore:
Modified MainResourceLoader to add an extra security check on
HTTP redirects. Also, moved isFeedWithNestedProtocolInHTTPFamily
to SecurityOrigin.cpp.
* loader/FrameLoader.cpp:
(WebCore::isFeedWithNestedProtocolInHTTPFamily):
(WebCore::FrameLoader::loadFrameRequest):
* loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::willSendRequest):
* page/SecurityOrigin.cpp:
(WebCore::isFeedWithNestedProtocolInHTTPFamily):
(WebCore::SecurityOrigin::canDisplay):
LayoutTests:
Adding a test to attempt an HTTP redirect to a file: URL.
* http/tests/security/redirect-BLOCKED-to-localURL.html: Added.
* http/tests/security/redirect-BLOCKED-to-localURL-expected.txt: Added.
* http/tests/security/resources/file-redirect-target.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96610
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caryclark@google.com [Tue, 4 Oct 2011 17:49:46 +0000 (17:49 +0000)]
Apply color profile found to decoded bitmap (Skia on Mac)
https://bugs.webkit.org/show_bug.cgi?id=69144
This fixes http://code.google.com/p/chromium/issues/detail?id=97830
Reviewed by Stephen White.
No new tests. This platform is not enabled.
* platform/image-decoders/ImageDecoder.h:
Add color profile slot to Skia variation.
* platform/image-decoders/skia/ImageDecoderSkia.cpp:
(WebCore::resolveColorSpace):
Adjust the bitmap in place to use the supplied color space.
(WebCore::createColorSpace):
Create a CGColorSpace from a color profile.
(WebCore::ImageFrame::setColorProfile):
Save the image's color profile until the image is complete.
(WebCore::ImageFrame::setStatus):
Apply the color profile, if any, to the image.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96609
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Tue, 4 Oct 2011 17:47:29 +0000 (17:47 +0000)]
Restore Linux baseline for this test. The Linux baseline got clobbered
when I updated the Windows baseline.
* platform/chromium-linux/fast/text/international/bidi-neutral-run-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96608
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
leandro@webkit.org [Tue, 4 Oct 2011 17:44:49 +0000 (17:44 +0000)]
[CMake] Unreviewed: pass feature definitions in the right format for the CSS scripts.
The Perl scripts in the css/ directory expect the definitions passed via
--defines to be a string of space-separated entries, however we were passing a
list of semicolon-separated strings, thus making all feature defines actually
be ignored.
Detected after r96433, which checked for some definitions in
CSSPropertyNames.in.
No new tests, this is a build fix.
* CMakeLists.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96607
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 4 Oct 2011 17:39:33 +0000 (17:39 +0000)]
[WebKit2][gtk] Fix warnings while generating documentation using gtk-doc.
https://bugs.webkit.org/show_bug.cgi?id=69329
Patch by Nayan Kumar K <nayankk@motorola.com> on 2011-10-04
Reviewed by Martin Robinson.
Added documentation for WebKitNetworkError enum and corrected few other
minor issues in WebKit2-GTK+ API documentation.
* UIProcess/API/gtk/WebKitError.h: Added documentation for WebKitNetworkError.
* UIProcess/API/gtk/WebKitWebLoaderClient.cpp:
(webkit_web_loader_client_class_init): Corrected parameter name.
* UIProcess/API/gtk/WebKitWebView.cpp: Corrected annotation.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96606
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mario@webkit.org [Tue, 4 Oct 2011 17:22:16 +0000 (17:22 +0000)]
2011-10-04 Mario Sanchez Prada <msanchez@igalia.com>
Unreviewed; rebaselines for GTK after r96509.
* platform/gtk/fast/forms/file-input-disabled-expected.png:
* platform/gtk/fast/forms/file-input-disabled-expected.txt:
* platform/gtk/fast/invalid/017-expected.txt:
* platform/gtk/fast/invalid/018-expected.txt:
* platform/gtk/fast/invalid/020-expected.txt:
* platform/gtk/fast/invalid/residual-style-expected.png:
* platform/gtk/fast/invalid/residual-style-expected.txt:
* platform/gtk/fast/invalid/table-inside-stray-table-content-expected.txt:
* platform/gtk/fast/table/inline-form-assert-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug113235-2-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug23994-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug56405-expected.png:
* platform/gtk/tables/mozilla/bugs/bug56405-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug56563-expected.png:
* platform/gtk/tables/mozilla/bugs/bug56563-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug9024-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/bugs/bug220653-expected.png:
* platform/gtk/tables/mozilla_expected_failures/bugs/bug220653-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/bugs/bug7121-2-expected.png:
* platform/gtk/tables/mozilla_expected_failures/bugs/bug7121-2-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/core/conflicts-expected.png:
* platform/gtk/tables/mozilla_expected_failures/core/conflicts-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/other/empty_cells-expected.png:
* platform/gtk/tables/mozilla_expected_failures/other/empty_cells-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96605
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Tue, 4 Oct 2011 17:19:04 +0000 (17:19 +0000)]
Web Inspector: make SourceFrame compile.
https://bugs.webkit.org/show_bug.cgi?id=69345
Reviewed by Yury Semikhatsky.
* inspector/compile-front-end.sh:
* inspector/front-end/DOMAgent.js:
(WebInspector.DOMAgent.prototype.inspectElement):
(WebInspector.DOMDispatcher.prototype.inspectElementRequested):
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype._inspectElementRequested):
* inspector/front-end/ObjectPropertiesSection.js:
(WebInspector.ObjectPropertyTreeElement.prototype._contextMenuEventFired):
(WebInspector.ObjectPropertyTreeElement.prototype.startEditing):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype._applyDiffMarkup):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype._onShowPopover.showObjectPopover):
(WebInspector.SourceFrame.prototype._onShowPopover):
(WebInspector.SourceFrame.prototype._editBreakpointCondition):
(WebInspector.SourceFrame.prototype.startEditing):
(WebInspector.SourceFrame.prototype.commitEditing.didEditContent):
(WebInspector.SourceFrame.prototype.commitEditing):
(WebInspector.SourceFrameDelegate.prototype.requestContent):
(WebInspector.SourceFrameDelegate.prototype.debuggingSupported):
(WebInspector.SourceFrameDelegate.prototype.setBreakpoint):
(WebInspector.SourceFrameDelegate.prototype.removeBreakpoint):
(WebInspector.SourceFrameDelegate.prototype.updateBreakpoint):
(WebInspector.SourceFrameDelegate.prototype.findBreakpoint):
(WebInspector.SourceFrameDelegate.prototype.continueToLine):
(WebInspector.SourceFrameDelegate.prototype.canEditScriptSource):
(WebInspector.SourceFrameDelegate.prototype.setScriptSource):
(WebInspector.SourceFrameDelegate.prototype.setScriptSourceIsBeingEdited):
(WebInspector.SourceFrameDelegate.prototype.debuggerPaused):
(WebInspector.SourceFrameDelegate.prototype.evaluateInSelectedCallFrame):
(WebInspector.SourceFrameDelegate.prototype.releaseEvaluationResult):
(WebInspector.SourceFrameDelegate.prototype.suggestedFileName):
* inspector/front-end/externs.js:
(WebInspector.log):
* inspector/front-end/inspector.js:
(WebInspector.log.logMessage):
(WebInspector.log):
* inspector/front-end/utilities.js:
():
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96604
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mario@webkit.org [Tue, 4 Oct 2011 16:59:53 +0000 (16:59 +0000)]
2011-10-04 Mario Sanchez Prada <msanchez@igalia.com>
Unreviewed; new baselines for GTK after r96470
* platform/gtk/svg/custom/grayscale-gradient-mask-2-expected.png: Added.
* platform/gtk/svg/custom/grayscale-gradient-mask-2-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96603
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Tue, 4 Oct 2011 16:53:29 +0000 (16:53 +0000)]
Update font shaping result after trac.webkit.org/changeset/96582.
This appears to be a progression, but I'll check with the authors of
that patch to be sure.
* platform/chromium-win/fast/text/international/bidi-neutral-run-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96602
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Tue, 4 Oct 2011 16:48:48 +0000 (16:48 +0000)]
Update leopard results.
* platform/chromium-cg-mac-leopard/svg/as-object/embedded-svg-immediate-offsetWidth-query-expected.txt: Removed.
* platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug23994-expected.png: Added.
* platform/chromium-mac-leopard/svg/as-object: Removed.
* platform/chromium-mac-leopard/svg/as-object/embedded-svg-immediate-offsetWidth-query-expected.txt: Removed.
* platform/chromium-mac/svg/as-object/embedded-svg-immediate-offsetWidth-query-expected.png:
* platform/chromium/tables/mozilla/bugs/bug23994-expected.txt: Removed.
* platform/qt/svg/as-object/embedded-svg-immediate-offsetWidth-query-expected.txt: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96601
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mario@webkit.org [Tue, 4 Oct 2011 16:32:03 +0000 (16:32 +0000)]
2011-10-04 Mario Sanchez Prada <msanchez@igalia.com>
Unreviewed; new baselines for GTK after r96257, r96374 and r96404.
* platform/gtk/fast/repaint/selection-clear-expected.png: Added.
* platform/gtk/fast/repaint/selection-clear-expected.txt: Added.
* platform/gtk/fast/text/complex-synthetic-bold-space-width-expected.png: Added.
* platform/gtk/fast/text/complex-synthetic-bold-space-width-expected.txt: Added.
* platform/gtk/fast/text/line-initial-and-final-swashes-expected.png: Added.
* platform/gtk/fast/text/line-initial-and-final-swashes-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96600
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mnaganov@chromium.org [Tue, 4 Oct 2011 16:17:43 +0000 (16:17 +0000)]
Web Inspector: Factor out object properties popup.
https://bugs.webkit.org/show_bug.cgi?id=69234
Also, for HTML elements, show a non-empty id value in the element name.
Reviewed by Pavel Feldman.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96599
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Tue, 4 Oct 2011 16:16:16 +0000 (16:16 +0000)]
MinGW warning fix after r96286.
Avoid redefining STDCALL, because STDCALL is also defined in mingw32/include/windef.h:
Reviewed by Tor Arne Vestbø.
* assembler/MacroAssemblerCodeRef.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96598
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Tue, 4 Oct 2011 16:11:59 +0000 (16:11 +0000)]
Web Inspector: compile text editor.
https://bugs.webkit.org/show_bug.cgi?id=69339
Drive-by compilation for color, database and dom storage entities.
Reviewed by Yury Semikhatsky.
* inspector/Inspector.json:
* inspector/compile-front-end.sh:
* inspector/front-end/Color.js:
(WebInspector.Color.prototype._individualRGBValueToFloatValue):
* inspector/front-end/KeyboardShortcut.js:
(WebInspector.KeyboardShortcut.makeKey):
(WebInspector.KeyboardShortcut.makeKeyFromEvent):
(WebInspector.KeyboardShortcut.makeDescriptor):
* inspector/front-end/SourceCSSTokenizer.js:
* inspector/front-end/SourceCSSTokenizer.re2js:
* inspector/front-end/SourceHTMLTokenizer.js:
* inspector/front-end/SourceHTMLTokenizer.re2js:
* inspector/front-end/SourceJavaScriptTokenizer.js:
* inspector/front-end/SourceJavaScriptTokenizer.re2js:
* inspector/front-end/SourceTokenizer.js:
(WebInspector.SourceTokenizer.prototype._charAt):
(WebInspector.SourceTokenizer.prototype.createInitialCondition):
(WebInspector.SourceTokenizer.prototype.nextToken):
* inspector/front-end/TextEditorHighlighter.js:
(WebInspector.TextEditorHighlighter.prototype.highlight):
(WebInspector.TextEditorHighlighter.prototype._highlightLines):
* inspector/front-end/TextEditorModel.js:
* inspector/front-end/TextViewer.js:
(WebInspector.TextViewerDelegate.prototype.doubleClick):
(WebInspector.TextViewerDelegate.prototype.beforeTextChanged):
(WebInspector.TextViewerDelegate.prototype.afterTextChanged):
(WebInspector.TextViewerDelegate.prototype.commitEditing):
(WebInspector.TextViewerDelegate.prototype.cancelEditing):
(WebInspector.TextViewerDelegate.prototype.populateLineGutterContextMenu):
(WebInspector.TextViewerDelegate.prototype.populateTextAreaContextMenu):
(WebInspector.TextViewerDelegate.prototype.suggestedFileName):
(WebInspector.TextEditorMainPanel.prototype._enclosingLineRowOrSelf):
(WebInspector.TextEditorMainPanel.prototype._createLink):
(WebInspector.TextEditorMainPanel.prototype._applyDomUpdates):
(WebInspector.TextEditorMainPanel.prototype._updateChunksForRanges):
* inspector/front-end/externs.js:
(WebInspector.completeURL):
(window.getComputedStyle):
(Event.prototype.initWebKitWheelEvent):
* inspector/front-end/utilities.js:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96597
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vsevik@chromium.org [Tue, 4 Oct 2011 15:49:50 +0000 (15:49 +0000)]
Web Inspector: Timeline panel shortcut for filtering short records should have shorter description.
https://bugs.webkit.org/show_bug.cgi?id=69333
Reviewed by Pavel Feldman.
* English.lproj/localizedStrings.js:
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype._registerShortcuts):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96596
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
gavinp@chromium.org [Tue, 4 Oct 2011 15:39:46 +0000 (15:39 +0000)]
add more stack dumping methods
https://bugs.webkit.org/show_bug.cgi?id=69018
In addition to WTFReportBacktrace, this adds the cross-platform WTFGetBacktrace, which lets
WebKit programmatically retrieve the current stack. This is useful if you need to add more
reporting to field crash report uploads, if you're tracking down an irreproducable bug,
for instance.
Reviewed by Darin Adler.
* wtf/Assertions.cpp:
* wtf/Assertions.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96595
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 4 Oct 2011 15:13:45 +0000 (15:13 +0000)]
Shrink StyleRareNonInheritedData.
https://bugs.webkit.org/show_bug.cgi?id=69331
Patch by Andreas Kling <kling@webkit.org> on 2011-10-04
Reviewed by Antti Koivisto.
Rearrange the members and move all small types into the bitfield.
This shrinks StyleRareNonInheritedData by two CPU words, reducing memory
consumption by 140 kB (on 64-bit) when loading the full HTML5 spec.
* rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
* rendering/style/StyleRareNonInheritedData.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96594
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vsevik@chromium.org [Tue, 4 Oct 2011 15:02:25 +0000 (15:02 +0000)]
Web Inspector: Remove http/tests/inspector/network/disabled-cache-crash.html.
https://bugs.webkit.org/show_bug.cgi?id=69332
Reviewed by Pavel Feldman.
.:
* Source/autotools/symbols.filter:
Source/WebCore:
* WebCore.exp.in:
* testing/Internals.cpp:
* testing/Internals.h:
* testing/Internals.idl:
Source/WebKit2:
* win/WebKit2.def:
* win/WebKit2CFLite.def:
LayoutTests:
* http/tests/inspector/network/disabled-cache-crash-expected.txt: Removed.
* http/tests/inspector/network/disabled-cache-crash.html: Removed.
* platform/chromium/test_expectations.txt:
* platform/gtk/Skipped:
* platform/mac/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96593
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 4 Oct 2011 14:45:39 +0000 (14:45 +0000)]
allow failure of most Chromium-Mac-Skia tests while we clean up that port
https://bugs.webkit.org/show_bug.cgi?id=69279
Patch by Elliot Poger <epoger@google.com> on 2011-10-04
Reviewed by Adam Barth.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96592
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Tue, 4 Oct 2011 14:23:24 +0000 (14:23 +0000)]
Web Inspector: make DataGrid compile
https://bugs.webkit.org/show_bug.cgi?id=69334
Patch by Pavel Feldman <pfeldman@chromium.org> on 2011-10-04
Reviewed by Yury Semikhatsky.
* inspector/compile-front-end.sh:
* inspector/front-end/DataGrid.js:
(WebInspector.DataGrid):
(WebInspector.DataGrid.prototype._startEditingColumnOfDataGridNode):
(WebInspector.DataGrid.prototype._startEditing):
(WebInspector.DataGrid.prototype._startEditingConfig):
(WebInspector.DataGrid.prototype._editingCommitted.moveToNextIfNeeded):
(WebInspector.DataGrid.prototype._editingCommitted):
(WebInspector.DataGrid.prototype._editingCancelled):
(WebInspector.DataGrid.prototype.removeChildrenRecursive):
(WebInspector.DataGrid.prototype._keyDown):
(WebInspector.DataGrid.prototype._startResizerDragging):
(WebInspector.DataGrid.prototype._resizerDragging):
(WebInspector.DataGrid.prototype._endResizerDragging):
(WebInspector.DataGridNode.prototype._attach):
* inspector/front-end/UIUtils.js:
(WebInspector.isBeingEdited):
(WebInspector.markBeingEdited):
(WebInspector.isEditingAnyField):
(WebInspector.EditingConfig):
(WebInspector.startEditing.blurEventListener):
(WebInspector.startEditing.getContent):
(WebInspector.startEditing.cleanUpAfterEditing):
(WebInspector.startEditing.editingCancelled):
(WebInspector.startEditing.editingCommitted):
(WebInspector.startEditing.defaultFinishHandler):
(WebInspector.startEditing):
(WebInspector.startEditing.pasteEventListener):
(WebInspector.startEditing.keyDownEventListener):
* inspector/front-end/externs.js:
(Array.prototype.remove):
(window.getComputedStyle):
* inspector/front-end/inspector.js:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96591
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Tue, 4 Oct 2011 14:12:19 +0000 (14:12 +0000)]
[Chromium] Web Inspector: save inspector state into single string instead of string map
https://bugs.webkit.org/show_bug.cgi?id=69335
Added explicit methods for saving and restoring agent runtime state.
Reviewed by Pavel Feldman.
* public/WebDevToolsAgent.h:
* public/WebDevToolsAgentClient.h:
(WebKit::WebDevToolsAgentClient::saveAgentRuntimeState):
* src/WebDevToolsAgentImpl.cpp:
(WebKit::WebDevToolsAgentImpl::reattach):
(WebKit::WebDevToolsAgentImpl::updateInspectorStateCookie):
* src/WebDevToolsAgentImpl.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96590
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caseq@chromium.org [Tue, 4 Oct 2011 14:09:06 +0000 (14:09 +0000)]
2011-10-04 Andrey Kosyakov <caseq@chromium.org>
Web Inspector: [Extensions API] extension panel's toolbar icon is incorrect when inspector window is docked
https://bugs.webkit.org/show_bug.cgi?id=69336
Reviewed by Pavel Feldman.
* inspector/front-end/ExtensionPanel.js:
(WebInspector.ExtensionPanel):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96589
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
podivilov@chromium.org [Tue, 4 Oct 2011 13:24:01 +0000 (13:24 +0000)]
Web Inspector: update call frame location when source mapping is changed.
https://bugs.webkit.org/show_bug.cgi?id=68997
Currently we use fake "debugger-paused" event hack to update execution line and call stack placards when source mapping is changed.
- add PresentationCallFrame.createPlacard method to create "live" placards that are updated on source mapping changes.
- remove PresentationCallFrame functionName, isInternalScript, and url getters.
- fire execution-line-changed event when selected call frame or source mapping is changed.
Reviewed by Pavel Feldman.
* inspector/compile-front-end.sh:
* inspector/front-end/CallStackSidebarPane.js:
(WebInspector.CallStackSidebarPane.prototype.update):
* inspector/front-end/CompilerSourceMapping.js:
(WebInspector.ClosureCompilerSourceMappingPayload):
(WebInspector.ClosureCompilerSourceMapping):
(WebInspector.ClosureCompilerSourceMapping.prototype._parseMappings):
* inspector/front-end/ContentProviders.js:
(WebInspector.CompilerSourceMappingContentProvider.prototype.requestContent):
(WebInspector.CompilerSourceMappingContentProvider.prototype.searchInContent):
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerPresentationModel.prototype.createPlacard.updatePlacard):
(WebInspector.DebuggerPresentationModel.prototype.createPlacard):
(WebInspector.DebuggerPresentationModel.prototype._debuggerPaused):
(WebInspector.DebuggerPresentationModel.prototype._debuggerResumed):
(WebInspector.DebuggerPresentationModel.prototype.set selectedCallFrame):
(WebInspector.DebuggerPresentationModel.prototype.get selectedCallFrame):
(WebInspector.DebuggerPresentationModel.prototype._dispatchExecutionLineChanged):
(WebInspector.DebuggerPresentationModel.prototype._debuggerReset):
(WebInspector.PresentationCallFrame):
(WebInspector.PresentationCallFrame.prototype.get rawSourceCode):
(WebInspector.PresentationCallFrame.prototype.uiLocation):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._debuggerPaused.else.didGetUILocation):
(WebInspector.ScriptsPanel.prototype._debuggerPaused):
(WebInspector.ScriptsPanel.prototype._executionLineChanged):
(WebInspector.ScriptsPanel.prototype._callFrameSelected):
* inspector/front-end/externs.js:
(WebInspector.displayNameForURL):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96588
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Tue, 4 Oct 2011 12:58:27 +0000 (12:58 +0000)]
[Qt] Couple of tests have different results on 64 bit and/or in debug mode compared to 32 bit and/or release mode
https://bugs.webkit.org/show_bug.cgi?id=52810
* platform/qt/Skipped: Skip one more failing test.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96587
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Tue, 4 Oct 2011 12:56:38 +0000 (12:56 +0000)]
2011-10-04 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: inspector tests fix.
* inspector/front-end/ExtensionPanel.js:
(WebInspector.ExtensionPanel):
(WebInspector.ExtensionPanel.prototype.get toolbarItemLabel):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96586
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
podivilov@chromium.org [Tue, 4 Oct 2011 12:32:51 +0000 (12:32 +0000)]
Web Inspector: add compiler source mapping support to RawSourceCode.
https://bugs.webkit.org/show_bug.cgi?id=68891
Reviewed by Pavel Feldman.
Source/WebCore:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/front-end/BreakpointManager.js:
(WebInspector.BreakpointManager.prototype.uiSourceCodeAdded):
(WebInspector.BreakpointManager.prototype.setBreakpoint):
(WebInspector.BreakpointManager.prototype._materializeBreakpoint):
* inspector/front-end/CompilerSourceMappingProvider.js: Added.
(WebInspector.CompilerSourceMappingProvider):
(WebInspector.CompilerSourceMappingProvider.prototype.loadSourceMapping):
(WebInspector.CompilerSourceMappingProvider.prototype.loadSourceCode):
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype.continueToLine):
* inspector/front-end/RawSourceCode.js:
(WebInspector.RawSourceCode.prototype.setCompilerSourceMappingProvider):
(WebInspector.RawSourceCode.prototype._resourceFinished):
(WebInspector.RawSourceCode.prototype._updateSourceMapping.didCreateSourceMapping):
(WebInspector.RawSourceCode.prototype._updateSourceMapping):
(WebInspector.RawSourceCode.prototype._createSourceMapping.didLoadSourceMapping):
(WebInspector.RawSourceCode.PlainSourceMapping.prototype.uiLocationToRawLocation):
(WebInspector.RawSourceCode.FormattedSourceMapping.prototype.uiLocationToRawLocation):
(WebInspector.RawSourceCode.CompilerSourceMapping):
(WebInspector.RawSourceCode.CompilerSourceMapping.prototype.rawLocationToUILocation):
(WebInspector.RawSourceCode.CompilerSourceMapping.prototype.uiLocationToRawLocation):
(WebInspector.RawSourceCode.CompilerSourceMapping.prototype.get uiSourceCodeList):
(WebInspector.CompilerSourceMappingProvider):
(WebInspector.CompilerSourceMappingProvider.prototype.loadSourceMapping):
(WebInspector.CompilerSourceMappingProvider.prototype.loadSourceCode):
* inspector/front-end/UISourceCodeContentProviders.js:
(WebInspector.CompilerSourceMappingContentProvider):
(WebInspector.CompilerSourceMappingContentProvider.prototype.requestContent):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.html:
LayoutTests:
* inspector/debugger/breakpoint-manager.html:
* inspector/debugger/raw-source-code-expected.txt:
* inspector/debugger/raw-source-code.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96585
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Tue, 4 Oct 2011 11:37:25 +0000 (11:37 +0000)]
Web Inspector: start adding UI components to the compilation process.
https://bugs.webkit.org/show_bug.cgi?id=69319
Patch by Pavel Feldman <pfeldman@google.com> on 2011-10-04
Reviewed by Yury Semikhatsky.
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/compile-front-end.sh:
* inspector/front-end/Drawer.js:
(WebInspector.Drawer.prototype.show.animationFinished):
(WebInspector.Drawer.prototype.show):
(WebInspector.Drawer.prototype.resize):
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype.statusBarResized):
* inspector/front-end/EmptyView.js:
* inspector/front-end/Panel.js:
(WebInspector.Panel.prototype.set get toolbarItemLabel):
(WebInspector.Panel.prototype.get statusBarItems):
(WebInspector.Panel.prototype.updateMainViewWidth):
(WebInspector.Panel.prototype.statusBarResized):
* inspector/front-end/PropertiesSection.js:
* inspector/front-end/SearchController.js:
(WebInspector.SearchController.prototype._onKeyDown):
* inspector/front-end/Section.js:
(WebInspector.Section.prototype.set populated):
(WebInspector.Section.prototype.onpopulate):
(WebInspector.Section.prototype.expand):
* inspector/front-end/SidebarPane.js:
* inspector/front-end/Toolbar.js:
(WebInspector.Toolbar.createPanelToolbarItem):
(WebInspector.ToolbarDropdown.prototype.show):
* inspector/front-end/UIUtils.js: Added.
(WebInspector.elementDragStart):
(WebInspector.elementDragEnd):
(WebInspector.animateStyle):
(WebInspector.animateStyle.forceComplete):
(WebInspector.animateStyle.cancel):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/externs.js:
(WebInspector.extensionServer.notifyPanelShown):
(WebInspector.extensionServer.notifyPanelHidden):
(WebInspector.currentPanel):
(WebInspector.setCurrentPanel):
* inspector/front-end/inspector.html:
* inspector/front-end/inspector.js:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96584
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hans@chromium.org [Tue, 4 Oct 2011 11:03:42 +0000 (11:03 +0000)]
[Chromium] Update expectations for svg/W3C-SVG-1.1/pservers-grad-06-b.svg
https://bugs.webkit.org/show_bug.cgi?id=69330
Win rebaseline.
* platform/chromium-win-vista/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt: Removed.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96583
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bashi@chromium.org [Tue, 4 Oct 2011 10:16:05 +0000 (10:16 +0000)]
[Chromium] Implement font shaping with font-feature-settings on Windows
https://bugs.webkit.org/show_bug.cgi?id=65904
Reviewed by Kenneth Russell.
Source/WebCore:
Use Uniscribe's OpenType APIs to shape complex text to support -webkit-font-feature-settings property.
No new tests. css3/font-feature-settings-rendering.html should pass by this patch.
* platform/graphics/chromium/UniscribeHelper.cpp:
(WebCore::loadOpenTypeFunctions):
(WebCore::UniscribeHelper::UniscribeHelper): Calls loadOpenTypeFunctions if needed.
(WebCore::UniscribeHelper::fillRuns): Uses ScriptItemizeOpenType() if possible.
(WebCore::UniscribeHelper::shape): Uses ScriptShapeOpenType() if possible.
(WebCore::UniscribeHelper::fillShapes): Adds OpenType script tag as an argument.
(WebCore::convertFeatureTag): Added.
(WebCore::UniscribeHelper::setRangeProperties): Added.
* platform/graphics/chromium/UniscribeHelper.h:
* platform/graphics/chromium/UniscribeHelperTextRun.cpp:
(WebCore::UniscribeHelperTextRun::UniscribeHelperTextRun): Calls setRangeProperties().
LayoutTests:
Adds expectations of css3/font-feature-settings-rendering.html for Chromium win port. Since Uniscirbe OpenType APIs are not available on WinXP by default, the test could fail on WinXP.
* platform/chromium-win/css3/font-feature-settings-rendering-expected.png: Added.
* platform/chromium-win/css3/font-feature-settings-rendering-expected.txt: Added.
* platform/chromium/test_expectations.txt: VISTA and WIN7 should pass css3/font-feature-settings-rendering.html.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96582
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ryuan.choi@samsung.com [Tue, 4 Oct 2011 10:07:39 +0000 (10:07 +0000)]
[EFL] Implement declared but missing functions.
https://bugs.webkit.org/show_bug.cgi?id=65368
Unreviewed build fix for WebKit/Efl builds after r96566.
* platform/efl/CursorEfl.cpp:
(WebCore::Cursor::operator=):
* platform/efl/LocalizedStringsEfl.cpp:
(WebCore::localizedString):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96581
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Tue, 4 Oct 2011 10:05:46 +0000 (10:05 +0000)]
Web Inspector: move abstract panel search logic into the only view that is using it.
https://bugs.webkit.org/show_bug.cgi?id=69328
Reviewed by Yury Semikhatsky.
* inspector/front-end/Panel.js:
(WebInspector.Panel.prototype.searchCanceled):
(WebInspector.Panel.prototype.performSearch):
(WebInspector.Panel.prototype.jumpToNextSearchResult):
(WebInspector.Panel.prototype.jumpToPreviousSearchResult):
* inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfilesPanel.prototype.performSearch.updateMatchesCount):
(WebInspector.ProfilesPanel.prototype.performSearch.updateMatchesCountSoon):
(WebInspector.ProfilesPanel.prototype.performSearch.finishedCallback):
(WebInspector.ProfilesPanel.prototype.performSearch.processChunk):
(WebInspector.ProfilesPanel.prototype.performSearch):
(WebInspector.ProfilesPanel.prototype.jumpToNextSearchResult):
(WebInspector.ProfilesPanel.prototype.jumpToPreviousSearchResult):
(WebInspector.ProfilesPanel.prototype._searchableViews):
(WebInspector.ProfilesPanel.prototype.searchCanceled):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96580
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Tue, 4 Oct 2011 09:51:47 +0000 (09:51 +0000)]
2011-10-04 Pavel Feldman <pfeldman@google.com>
Not reviewed: fixed poor inspector merge, drive-by front-endcompilation fix.
* inspector/front-end/ContentProviders.js:
(WebInspector.ScriptContentProvider.prototype.requestContent):
(WebInspector.ScriptContentProvider.prototype.searchInContent):
(WebInspector.ConcatenatedScriptsContentProvider.prototype.searchInContent):
* inspector/front-end/DebuggerPresentationModel.js:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96579
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
reni@webkit.org [Tue, 4 Oct 2011 09:30:03 +0000 (09:30 +0000)]
[Qt] Unreviewed gardening. Update Qt specific expected files after r96498.
Patch by Oliver Varga <voliver@inf.u-szeged.hu> on 2011-10-04
* platform/qt/svg/filters/feColorMatrix-saturate-expected.png: Added.
* platform/qt/svg/filters/feColorMatrix-saturate-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96578
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Tue, 4 Oct 2011 09:17:08 +0000 (09:17 +0000)]
Web Inspector: remove dependency from GoToLine dialog from Panel.
https://bugs.webkit.org/show_bug.cgi?id=69327
Reviewed by Yury Semikhatsky.
* inspector/front-end/GoToLineDialog.js:
(WebInspector.GoToLineDialog.install):
(WebInspector.GoToLineDialog._show):
* inspector/front-end/NetworkItemView.js:
(WebInspector.NetworkItemView.prototype._tabSelected):
(WebInspector.ResourceContentView.prototype.contentLoaded):
(WebInspector.ResourceContentView.prototype.canHighlightLine):
(WebInspector.ResourceContentView.prototype.highlightLine):
(set WebInspector):
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkPanel.viewGetter):
(WebInspector.NetworkPanel):
* inspector/front-end/Panel.js:
(WebInspector.Panel.prototype.registerShortcut):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.viewGetter):
(WebInspector.ResourcesPanel):
(WebInspector.ResourcesPanel.prototype.showResource):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.viewGetter):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype.canHighlightLine):
* inspector/front-end/TabbedPane.js:
(WebInspector.TabbedPane.prototype._hideTab):
(WebInspector.TabbedPane.prototype.canHighlightLine):
(WebInspector.TabbedPane.prototype.highlightLine):
* inspector/front-end/View.js:
(WebInspector.View.prototype.canHighlightLine):
(WebInspector.View.prototype.highlightLine):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96577
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 4 Oct 2011 09:03:51 +0000 (09:03 +0000)]
Unreviewed, rolling out r96491.
http://trac.webkit.org/changeset/96491
https://bugs.webkit.org/show_bug.cgi?id=69326
Breaks Slow Leopard inspector tests (Requested by pfeldman on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-04
Source/WebCore:
* inspector/Inspector.json:
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::getScriptSource):
* inspector/InspectorDebuggerAgent.h:
* inspector/front-end/ContentProviders.js:
(WebInspector.ScriptContentProvider.prototype.requestContent):
* inspector/front-end/Script.js:
(WebInspector.Script.prototype.requestSource.didGetScriptSource):
(WebInspector.Script.prototype.requestSource):
LayoutTests:
* http/tests/inspector/resource-tree/resource-tree-test.js:
(initialize_ResourceTreeTest.InspectorTest.runAfterResourcesAreFinished):
(initialize_ResourceTreeTest.InspectorTest._runAfterResourcesAreFinished):
(initialize_ResourceTreeTest):
* http/tests/inspector/resources-test.js:
(initialize_ResourceTest):
* http/tests/inspector/search/resources/search-concatenated.html: Removed.
* http/tests/inspector/search/search-in-concatenated-script-expected.txt: Removed.
* http/tests/inspector/search/search-in-concatenated-script.html: Removed.
* http/tests/inspector/search/search-in-resource.html:
* http/tests/inspector/search/search-in-script-expected.txt: Removed.
* http/tests/inspector/search/search-in-script.html: Removed.
* http/tests/inspector/search/search-test.js:
(initialize_SearchTest.InspectorTest.runAfterResourcesAreCreated):
(initialize_SearchTest.InspectorTest._runAfterResourcesAreCreated):
(initialize_SearchTest.InspectorTest._runAfterResourcesAreCreated.maybeCallback):
(initialize_SearchTest.InspectorTest._runAfterResourcesAreCreated.addSniffer):
(initialize_SearchTest.InspectorTest._runAfterResourcesAreCreated.onResourceBind):
(initialize_SearchTest.InspectorTest._runAfterResourcesAreCreated.visit):
(initialize_SearchTest):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96576
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Tue, 4 Oct 2011 08:37:04 +0000 (08:37 +0000)]
Web Inspector: add DebuggerPresentationModel and ConsoleView to compilation.
https://bugs.webkit.org/show_bug.cgi?id=69269
Reviewed by Yury Semikhatsky.
* inspector/compile-front-end.sh:
* inspector/front-end/BreakpointManager.js:
(WebInspector.BreakpointManager.prototype.uiSourceCodeAdded):
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype._consoleCleared):
(WebInspector.ConsoleView.prototype._completions.evaluated.getCompletions):
(WebInspector.ConsoleView.prototype._completions.evaluated):
(WebInspector.ConsoleView.prototype._messagesClicked):
* inspector/front-end/ContentProviders.js:
(WebInspector.StaticContentProvider.prototype.requestContent):
(WebInspector.StaticContentProvider.prototype.searchInContent):
* inspector/front-end/ContextMenu.js:
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype._addScript):
(WebInspector.DebuggerPresentationModel.prototype._consoleMessageAdded):
(WebInspector.DebuggerPresentationModel.prototype._debuggerPaused):
(WebInspector.DebuggerPresentationModel.prototype._rawSourceCodeForScriptWithURL):
(WebInspector.DebuggerPresentationModel.prototype._rawSourceCodeForScript):
(WebInspector.DebuggerPresentationModel.prototype._scriptForRawSourceCode):
(WebInspector.DebuggerPresentationModel.prototype._createRawSourceCodeId):
(WebInspector.DebuggerPresentationModelResourceBinding.prototype.canSetContent):
(WebInspector.DebuggerPresentationModelResourceBinding.prototype.setContent):
* inspector/front-end/HelpScreen.js:
* inspector/front-end/JavaScriptContextManager.js:
(WebInspector.FrameEvaluationContext.prototype.get displayName):
* inspector/front-end/KeyboardShortcut.js:
(WebInspector.KeyboardShortcut):
* inspector/front-end/Resource.js:
(WebInspector.Resource.displayName):
* inspector/front-end/ScriptFormatter.js:
(WebInspector.ScriptFormatter.prototype._didFormatContent):
* inspector/front-end/ShortcutsScreen.js:
* inspector/front-end/StatusBarButton.js:
* inspector/front-end/TextPrompt.js:
* inspector/front-end/externs.js:
(WebInspector.populateHrefContextMenu):
(WebInspector.useLowerCaseMenuTitles):
(WebInspector.ScriptsPanel.this.evaluateInSelectedCallFrame):
(WebInspector.ScriptsPanel.this.getSelectedCallFrameVariables):
(WebInspector.ScriptsPanel):
* inspector/front-end/inspector.js:
* inspector/front-end/utilities.js:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96575
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Tue, 4 Oct 2011 07:21:48 +0000 (07:21 +0000)]
Mac rebaseline after r96510.
* platform/mac/svg/as-object/embedded-svg-immediate-offsetWidth-query-expected.png:
* svg/as-object/embedded-svg-immediate-offsetWidth-query-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96574
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Tue, 4 Oct 2011 06:42:36 +0000 (06:42 +0000)]
Mac rebaseline after r96509.
* platform/mac/fast/forms/file-input-disabled-expected.txt:
* platform/mac/fast/invalid/017-expected.txt:
* platform/mac/fast/invalid/018-expected.txt:
* platform/mac/fast/invalid/020-expected.txt:
* platform/mac/fast/invalid/residual-style-expected.txt:
* platform/mac/fast/invalid/table-inside-stray-table-content-expected.txt:
* platform/mac/fast/table/inline-form-assert-expected.txt:
* platform/mac/tables/mozilla/bugs/bug113235-2-expected.txt:
* platform/mac/tables/mozilla/bugs/bug23994-expected.txt:
* platform/mac/tables/mozilla/bugs/bug56405-expected.txt:
* platform/mac/tables/mozilla/bugs/bug56563-expected.png:
* platform/mac/tables/mozilla/bugs/bug56563-expected.txt:
* platform/mac/tables/mozilla/bugs/bug9024-expected.txt:
* platform/mac/tables/mozilla_expected_failures/bugs/bug220653-expected.png:
* platform/mac/tables/mozilla_expected_failures/bugs/bug220653-expected.txt:
* platform/mac/tables/mozilla_expected_failures/bugs/bug7121-2-expected.png:
* platform/mac/tables/mozilla_expected_failures/bugs/bug7121-2-expected.txt:
* platform/mac/tables/mozilla_expected_failures/core/conflicts-expected.txt:
* platform/mac/tables/mozilla_expected_failures/other/empty_cells-expected.txt:
* tables/mozilla_expected_failures/bugs/bug3517-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96573
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Tue, 4 Oct 2011 06:22:14 +0000 (06:22 +0000)]
[Qt] Unreviewed gardening. Update Qt specific expected files after r96509.
* platform/qt/fast/invalid/017-expected.png: Copied from LayoutTests/platform/qt/tables/mozilla_expected_failures/bugs/bug220653-expected.png.
* platform/qt/fast/invalid/017-expected.txt:
* platform/qt/fast/invalid/018-expected.png: Added.
* platform/qt/fast/invalid/018-expected.txt:
* platform/qt/fast/invalid/020-expected.png: Copied from LayoutTests/platform/qt/tables/mozilla/bugs/bug23994-expected.png.
* platform/qt/fast/invalid/020-expected.txt:
* platform/qt/fast/invalid/table-inside-stray-table-content-expected.png: Added.
* platform/qt/fast/invalid/table-inside-stray-table-content-expected.txt:
* platform/qt/fast/table/inline-form-assert-expected.png:
* platform/qt/fast/table/inline-form-assert-expected.txt:
* platform/qt/svg/as-object/embedded-svg-immediate-offsetWidth-query-expected.png: Added.
* platform/qt/svg/as-object/embedded-svg-immediate-offsetWidth-query-expected.txt: Added.
* platform/qt/tables/mozilla/bugs/bug113235-2-expected.png:
* platform/qt/tables/mozilla/bugs/bug113235-2-expected.txt:
* platform/qt/tables/mozilla/bugs/bug23994-expected.png:
* platform/qt/tables/mozilla/bugs/bug23994-expected.txt:
* platform/qt/tables/mozilla/bugs/bug56405-expected.png:
* platform/qt/tables/mozilla/bugs/bug56405-expected.txt:
* platform/qt/tables/mozilla/bugs/bug56563-expected.png:
* platform/qt/tables/mozilla/bugs/bug56563-expected.txt:
* platform/qt/tables/mozilla/bugs/bug9024-expected.png: Added.
* platform/qt/tables/mozilla/bugs/bug9024-expected.txt:
* platform/qt/tables/mozilla_expected_failures/bugs/bug220653-expected.png:
* platform/qt/tables/mozilla_expected_failures/bugs/bug220653-expected.txt:
* platform/qt/tables/mozilla_expected_failures/bugs/bug3517-expected.png: Added.
* platform/qt/tables/mozilla_expected_failures/bugs/bug3517-expected.txt: Copied from LayoutTests/platform/qt/tables/mozilla/bugs/bug9024-expected.txt.
* platform/qt/tables/mozilla_expected_failures/bugs/bug7121-2-expected.png:
* platform/qt/tables/mozilla_expected_failures/bugs/bug7121-2-expected.txt:
* platform/qt/tables/mozilla_expected_failures/core/conflicts-expected.png:
* platform/qt/tables/mozilla_expected_failures/core/conflicts-expected.txt:
* platform/qt/tables/mozilla_expected_failures/other/empty_cells-expected.png:
* platform/qt/tables/mozilla_expected_failures/other/empty_cells-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96572
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Tue, 4 Oct 2011 04:16:29 +0000 (04:16 +0000)]
Mac release build fix after r96561, and Leopard build fix after r96568.
* editing/TextCheckingHelper.h:
(WebCore::TextCheckingParagraph::textCharAt):
* page/mac/EventHandlerMac.mm:
(WebCore::EventHandler::wheelEvent):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96571
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Tue, 4 Oct 2011 03:52:43 +0000 (03:52 +0000)]
Build fix after r96568.
* accessibility/AccessibilityObject.cpp:
* accessibility/mac/WebAccessibilityObjectWrapper.mm:
* editing/Editor.cpp:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96570
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Tue, 4 Oct 2011 03:20:05 +0000 (03:20 +0000)]
DFG should inline Array.push and Array.pop
https://bugs.webkit.org/show_bug.cgi?id=69314
Reviewed by Geoff Garen.
Fix 32-bit.
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96569
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 4 Oct 2011 03:10:54 +0000 (03:10 +0000)]
Should call checkTextOfParagraph() indirectly to make unifying spell-checking code path easy.
https://bugs.webkit.org/show_bug.cgi?id=69241
Patch by Shinya Kawanaka <shinyak@google.com> on 2011-10-03
Reviewed by Ryosuke Niwa.
WebCore has two different code paths for spell-checking:
1) checkTextOfParagraph() for Snow Leopard or later
2) checkSpellingOfString() for checkGrammarOfString() for other platforms.
At the first step, this patch introduces an indirect wrapper to call
checkTextOfParagraph() in Snow Leopard or later. This is intended to make it easy to
introduce a function for mimicing checkTextOfParagraph() in Chromium platform or
other non-SL or non-Lion platform.
No new tests because this patch does not change a behavior.
* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::hasMisspelling): Calling checkTextOfParagraph() indirectly.
* accessibility/mac/WebAccessibilityObjectWrapper.mm:
(AXAttributeStringSetSpelling): ditto.
* editing/Editor.cpp:
(WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): ditto.
* editing/TextCheckingHelper.cpp:
(WebCore::TextCheckingHelper::findFirstMisspellingOrBadGrammar): ditto.
(WebCore::TextCheckingHelper::guessesForMisspelledOrUngrammaticalRange): ditto.
(WebCore::checkTextOfParagraph): Added.
* editing/TextCheckingHelper.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96568
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Tue, 4 Oct 2011 02:55:54 +0000 (02:55 +0000)]
DFG should inline Array.push and Array.pop
https://bugs.webkit.org/show_bug.cgi?id=69314
Reviewed by Oliver Hunt.
1% speed-up in V8 due to 6% speed-up in V8-deltablue.
* assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::storePtr):
* create_hash_table:
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleIntrinsic):
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
* dfg/DFGIntrinsic.h:
* dfg/DFGNode.h:
(JSC::DFG::Node::hasHeapPrediction):
* dfg/DFGOperations.cpp:
* dfg/DFGOperations.h:
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::getByValLoadElimination):
(JSC::DFG::Propagator::getMethodLoadElimination):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96567
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Tue, 4 Oct 2011 02:26:10 +0000 (02:26 +0000)]
Change cursor to hand over missing plug-in message
https://bugs.webkit.org/show_bug.cgi?id=69312
Reviewed by Sam Weinig.
No tests because we currently don't have any test machinery for cursors.
* page/EventHandler.cpp:
(WebCore::OptionalCursor::OptionalCursor): Added. Construct an object
to represent either a cursor, or no cursor change.
(WebCore::OptionalCursor::isCursorChange): Added.
(WebCore::OptionalCursor::cursor): Added.
(WebCore::EventHandler::selectCursor): Changed return type to OptionalCursor,
moved some special cases from handleMouseMoveEvent in here. Moved the logic
for plug-ins and framesets into the specific renderer classes for those.
Added a call to the new getCursor virtual function.
(WebCore::EventHandler::handleMouseMoveEvent): Changed cursor setting code to
just be a call to selectCursor and then setCursor. Plug-in-specific code is now
in RenderWidget.
* page/EventHandler.h: Changed return type of selectCursor.
* page/MouseEventWithHitTestResults.cpp: Made some functions be inline.
* page/MouseEventWithHitTestResults.h:
(WebCore::MouseEventWithHitTestResults::localPoint): Made this inline.
(WebCore::MouseEventWithHitTestResults::scrollbar): Made this inline.
Yes, this has nothing to do with the rest of the patch, but it's good.
* rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbeddedObject::getReplacementTextGeometry): Made const.
(WebCore::RenderEmbeddedObject::isInMissingPluginIndicator): Made const.
Overloaded so it can be called with a point rather than an event.
(WebCore::shouldMissingPluginMessageBeButton): Added. Helps streamline
the logic below.
(WebCore::RenderEmbeddedObject::handleMissingPluginIndicatorEvent):
Changed to use shouldMissingPluginMessageBeButton.
(WebCore::RenderEmbeddedObject::getCursor): Added. Sets the cursor to
a hand when over the missing plug-in message.
* rendering/RenderEmbeddedObject.h: Added getCursor override. Also updated
for other changes above.
* rendering/RenderFrameSet.cpp:
(WebCore::RenderFrameSet::getCursor): Added. Contains the logic that used
to be hardcoded in EventHandler::selectCursor about cursors when over
resizable frame borders.
* rendering/RenderFrameSet.h: Added getCursor.
* rendering/RenderObject.cpp:
(WebCore::RenderObject::getCursor): Added. Returns SetCursorBasedOnStyle.
* rendering/RenderObject.h: Added getCursor.
* rendering/RenderWidget.cpp:
(WebCore::RenderWidget::getCursor): Added. Contains the logic that used
to be hardcoded in EventHandler::handleMouseMoveEvent to prevent setting
the cursor when the pointer is over a plug-in. This new code is much better,
because it only kicks in when there is actually a plug-in present. The old
was based on the HTML tag!
* rendering/RenderWidget.h: Added getCursor.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96566
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Tue, 4 Oct 2011 02:00:14 +0000 (02:00 +0000)]
garden-o-matic should remove builders from the failure grid once they start to pass
https://bugs.webkit.org/show_bug.cgi?id=69309
Unreviewed. dglazkov is on vacation. I need to interest someone else
in reviewing these patches.
This patch follows the update/purge model from UpdateTracker. This
patch is less awesome than it could be because it causes the UI to
flash slightly. In a future patch, we'll want to use these
update/purge notifications to update the UI without flashing. However,
that's not such a big deal because this UI is hidden in the default
view.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96565
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Tue, 4 Oct 2011 01:37:19 +0000 (01:37 +0000)]
JSC ASSERT Opening the Web Inspector
https://bugs.webkit.org/show_bug.cgi?id=69293
Reviewed by Oliver Hunt.
If a polymorphic access structure list has a duplicated structure, then
don't crash.
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96564
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Tue, 4 Oct 2011 01:16:46 +0000 (01:16 +0000)]
On X86, switch bucketCount into a register, timeoutCheck into memory
https://bugs.webkit.org/show_bug.cgi?id=69299
Reviewed by Geoff Garen.
We don't have sufficient registers to keep both in registers, and DFG JIT will trample esi;
it doesn't matter if the bucketCount gets stomped on (in fact it may add to randomness!),
but it if the timeoutCheck gets trashed we may make calls out to the timout_check stub
function too frequently (regressing performance). This patch has no perf impact on sunspider.
* JavaScriptCore.xcodeproj/project.pbxproj:
* assembler/MacroAssemblerX86.h:
(JSC::MacroAssemblerX86::branchAdd32):
(JSC::MacroAssemblerX86::branchSub32):
- Added branchSub32 with AbsoluteAddress.
* jit/JIT.cpp:
(JSC::JIT::emitTimeoutCheck):
- Keep timeout count in memory on X86.
* jit/JITInlineMethods.h:
(JSC::JIT::emitValueProfilingSite):
- remove X86 specific code, switch bucket count back into a register.
* jit/JITStubs.cpp:
- Stop initializing esi (it is no longer the timeoutCheck!)
* jit/JSInterfaceJIT.h:
- change definition of esi to be the bucketCountRegister.
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
* runtime/JSGlobalData.h:
- Add timeoutCount as a property to global data (the counter should be per-thread).
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96563
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Tue, 4 Oct 2011 01:05:38 +0000 (01:05 +0000)]
DFG backends don't have access to per-node predictions from the propagator
https://bugs.webkit.org/show_bug.cgi?id=69291
Reviewed by Oliver Hunt.
Nodes now have two notion of predictions: the heap prediction, which is
what came directly from value profiling, and the propagator's predictions,
which arise out of abstract interpretation. Every node has a propagator
prediction, but not every node has a heap prediction; and there is no
guarantee that a node that has both will keep them consistent as the
propagator may have additional information available to it.
This is performance neutral.
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
* dfg/DFGGraph.h:
* dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::getPrediction):
* dfg/DFGNode.h:
(JSC::DFG::Node::Node):
(JSC::DFG::Node::hasHeapPrediction):
(JSC::DFG::Node::getHeapPrediction):
(JSC::DFG::Node::predictHeap):
(JSC::DFG::Node::prediction):
(JSC::DFG::Node::predict):
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::Propagator):
(JSC::DFG::Propagator::setPrediction):
(JSC::DFG::Propagator::mergePrediction):
(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::fixupNode):
(JSC::DFG::Propagator::isPredictedNumerical):
(JSC::DFG::Propagator::logicalNotIsPure):
(JSC::DFG::Propagator::setReplacement):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96562
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 4 Oct 2011 00:29:13 +0000 (00:29 +0000)]
Work towards making PlatformWheelEvent immutable
https://bugs.webkit.org/show_bug.cgi?id=69306
Reviewed by Sam Weinig.
Currently, PlatformWheelEvent has an m_isAccepted flag that tracks whether
the event has been handled or not. For all other event types, that state is instead
tracked by the return value of the various event handlers.
As a first step, add return values to the various handleWheelEvent functions and
add an assertion in EventHandler::wheelEvent that the return value is the same as
the state of PlatformWheelEvent::isAccepted.
* Configurations/Base.xcconfig:
Don't warn when using C++11 extensions.
* page/mac/EventHandlerMac.mm:
(WebCore::EventHandler::wheelEvent):
Assert that isAccepted matches the return value.
* platform/ScrollAnimator.cpp:
(WebCore::ScrollAnimator::handleWheelEvent):
Return isAccepted.
* platform/ScrollAnimator.h:
HandleWheelEvent now returns a boolean.
* platform/ScrollView.cpp:
(WebCore::ScrollView::wheelEvent):
Return whether the event was handled or not.
* platform/ScrollView.h:
ScrollView::wheelEvent now returns a bool.
* platform/ScrollableArea.cpp:
(WebCore::ScrollableArea::handleWheelEvent):
* platform/ScrollableArea.h:
ScrollableArea::handleWheelEvent now returns a bool.
* platform/chromium/ScrollAnimatorChromiumMac.h:
* platform/chromium/ScrollAnimatorChromiumMac.mm:
(WebCore::ScrollAnimatorChromiumMac::handleWheelEvent):
Add return values, based on either the base class calls or the state of
PlatformWheelEvent::isAccepted().
* platform/mac/ScrollAnimatorMac.h:
* platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::handleWheelEvent):
Ditto.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96561
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
levin@chromium.org [Tue, 4 Oct 2011 00:23:56 +0000 (00:23 +0000)]
webkitpy: Expose cc_emails and comments from bug.py
https://bugs.webkit.org/show_bug.cgi?id=69308
Reviewed by Adam Barth.
* Scripts/webkitpy/common/net/bugzilla/bug.py: Expose cc_emails and comments .
* Scripts/webkitpy/common/net/bugzilla/bugzilla.py: Add parsing support for comments.
* Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py: Fix the unit test due
to comments being exposed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96560
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Tue, 4 Oct 2011 00:13:01 +0000 (00:13 +0000)]
Add a microbenchmark for a full-page render of the HTML5 spec
https://bugs.webkit.org/show_bug.cgi?id=69285
Reviewed by Adam Barth.
This was designed to be a test for https://bugs.webkit.org/show_bug.cgi?id=68944
But it seems that by far our dominating cost for the HTML5 benchmark is
time spent laying out lines (which isn't actually that surprising).
I'm adding the performance test for posterity.
* Parser/html-parser.html:
- Removed use of "about:blank" which abarth says is a no-op. Made comment more accurate.
* Parser/html5-full-render.html: Copied from PerformanceTests/Parser/html-parser.html.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96559
268f45cc-cd09-0410-ab3c-
d52691b4dbfc