platform/upstream/gstreamer.git
3 years agopython: Fix using overrides when not building PyGObject
Thibault Saunier [Thu, 14 Oct 2021 20:01:01 +0000 (17:01 -0300)]
python: Fix using overrides when not building PyGObject

Since 547570cd790f2b2e390edc1dfb5df4c7a33de45c we do not always build
PyGObject and our development environment is broken when trying to use
GStreamer python when built against system PyGObject with the following
error importing Gst in there:

```
12345678** (gst-plugin-scanner:710617): CRITICAL **: 11:45:02.343: can't find gi.repository.Gst
Traceback (most recent call last):
  File "/usr/lib/python3.9/site-packages/gi/repository/__init__.py", line 23, in <module>
    from ..importer import DynamicImporter
  File "/usr/lib64/python3.9/site-packages/gi/importer.py", line 33, in <module>
    from .overrides import load_overrides
ImportError: cannot import name 'load_overrides' from 'gi.overrides' (/var/home/thiblahute/devel/gstreamer/gstreamer/subprojects/gst-editing-services/bindings/python/gi/overrides/__init__.py)
Factory Details:
```

The approach to fixing it is to implement override `gi` in
`gst-python/gi/` which we add to `PYTHONPATH`) and in there reset the
`gi` module to the right place and we get overrides from paths from
`_GI_OVERRIDES_PATH` we set in `gst-env.py` which points to all the
overrides that will be installed.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1155>

3 years agomediafoundation: Fix various string constness handling
Seungha Yang [Fri, 15 Oct 2021 14:18:41 +0000 (23:18 +0900)]
mediafoundation: Fix various string constness handling

... with fixing typo (g_strup -> g_strdup)

Constness needs to be explicit in C++ world otherwise compiler
would complain about that.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1164>

3 years agogstreamer/gst/gstconfig.h.in: Add support for ARC64 architecture
Veronika Kremneva [Fri, 8 Oct 2021 10:56:02 +0000 (13:56 +0300)]
gstreamer/gst/gstconfig.h.in: Add support for ARC64 architecture

Signed-off-by: Veronika Kremneva <kremneva@synopsys.com>
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1161>

3 years agomissing transceiver unref in WebRTC renegotiation example
Rob Agar [Fri, 15 Oct 2021 09:03:46 +0000 (10:03 +0100)]
missing transceiver unref in WebRTC renegotiation example

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1160>

3 years agoDocs: Fix a typo for Intel's vaapi driver name.
He Junyan [Thu, 14 Oct 2021 16:33:39 +0000 (00:33 +0800)]
Docs: Fix a typo for Intel's vaapi driver name.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1151>

3 years agowraps:ffmpeg: Move to 4.4
Thibault Saunier [Fri, 15 Oct 2021 00:00:59 +0000 (21:00 -0300)]
wraps:ffmpeg: Move to 4.4

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1156>

3 years agotests:va: Fix null ptr dereference in multi-vpp
Mengkejiergeli Ba [Wed, 13 Oct 2021 09:17:44 +0000 (17:17 +0800)]
tests:va: Fix null ptr dereference in multi-vpp

Dereference the pointer err before null check, which raised a null
pointer dereference issue by Coverity. Modify it to do the null check
of err first, then dereference it.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1143>

3 years agova: Fix null ptr dereference for vadeocder
Mengkejiergeli Ba [Wed, 13 Oct 2021 07:58:29 +0000 (15:58 +0800)]
va: Fix null ptr dereference for vadeocder

Making a null check in gst_va_decode_picture_free () indicates pic->buffers or pic->slices
can be null, then in _destroy_buffers () the pointers are dereferenced, which is detected
as dereference after null check by Coverity. Thus, modify the code to do null check in
_detroy_buffers ().

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1143>

3 years agoPin all wrap files to closest tag or commit sha1
Xavier Claessens [Thu, 14 Oct 2021 17:01:41 +0000 (13:01 -0400)]
Pin all wrap files to closest tag or commit sha1

Tracking branches, especially master, can cause regressions at any time.
We should try to use as much stable release tags as possible in the
future.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1152>

3 years agotsdemux: Handle delayed seek events
Vivia Nikolaidou [Mon, 5 Apr 2021 07:29:37 +0000 (10:29 +0300)]
tsdemux: Handle delayed seek events

Store the event in case it cannot be processed immediately and process
it after the first segment has been produced.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/980>

3 years agotsdemux: Protect demux->segment_event with a mutex
Vivia Nikolaidou [Mon, 5 Apr 2021 07:28:51 +0000 (10:28 +0300)]
tsdemux: Protect demux->segment_event with a mutex

Would otherwise cause weird issues when processing a delayed seek event

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/980>

3 years agovideo-converter: Fix v210->I420 last line conversion
Piotrek Brzeziński [Wed, 13 Oct 2021 19:28:58 +0000 (21:28 +0200)]
video-converter: Fix v210->I420 last line conversion

Last line would not be converted correctly if height was an odd number.
Fixed by accounting for data type (8bit vs. 16bit) differences between
respective packing and unpacking functions.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/973>

3 years agovideo-format: Clean up v210 packing code
Piotrek Brzeziński [Wed, 13 Oct 2021 14:53:41 +0000 (16:53 +0200)]
video-format: Clean up v210 packing code

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/973>

3 years agovideo-converter: Add fast paths from I420/YV12, UYVY, Y42B and YUY2 to v210
Piotrek Brzeziński [Wed, 13 Oct 2021 15:25:41 +0000 (17:25 +0200)]
video-converter: Add fast paths from I420/YV12, UYVY, Y42B and YUY2 to v210

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/973>

3 years agocodecs: h264: Fix wrong type of ret variable
Nicolas Dufresne [Thu, 14 Oct 2021 18:35:45 +0000 (14:35 -0400)]
codecs: h264: Fix wrong type of ret variable

This ret is not a GstFlowReturn. This broke v4l2 decoder which does not
implement new_picture() virtual function.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1154>

3 years agod3d11: Rename screen capture element
Seungha Yang [Wed, 13 Oct 2021 12:45:34 +0000 (21:45 +0900)]
d3d11: Rename screen capture element

Old name "desktopdup" may confuse users. Now it's renamed to
"screencapture"

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1136>

3 years agogitignore: Ignore *.wrap files again
Seungha Yang [Wed, 13 Oct 2021 15:40:16 +0000 (00:40 +0900)]
gitignore: Ignore *.wrap files again

There are various redirection *.wrap files which result in noisy
diff. Just ignore the entire wrap files. We can update wrap files
anytime via -f option.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1140>

3 years agoci: Move rules from `.build fedora x86_64` to `.build`
Thibault Saunier [Wed, 13 Oct 2021 21:10:40 +0000 (18:10 -0300)]
ci: Move rules from `.build fedora x86_64` to `.build`

They should apply to all job that extend it as the 2 jobs that depend on
`.build` but not on `.build fedora x86_64` is
`build nodebug fedora x86_64` which pulls `build static nodebug fedora x86_64`
both jobs should be manual on `main` and they should run only if some
files "modules_changes" happened

Also make sure we do no automatically run job on `main` branches from forks

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1141>

3 years agoci: Fix ordering of rules to always build on main
Thibault Saunier [Wed, 13 Oct 2021 21:00:13 +0000 (18:00 -0300)]
ci: Fix ordering of rules to always build on main

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1141>

3 years agohooks:python: Max line length should be 120
Thibault Saunier [Tue, 12 Oct 2021 21:09:16 +0000 (18:09 -0300)]
hooks:python: Max line length should be 120

As we ignore line length in pycodestyle and we have many places with
line with more than 80 and less than 120 chars

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1121>

3 years agovalidate:launcher: Reindent utils.py
Thibault Saunier [Tue, 12 Oct 2021 21:05:52 +0000 (18:05 -0300)]
validate:launcher: Reindent utils.py

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1121>

3 years agovalidate:launcher: Check if the running MR will close a referenced issue
Thibault Saunier [Tue, 12 Oct 2021 20:59:03 +0000 (17:59 -0300)]
validate:launcher: Check if the running MR will close a referenced issue

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1121>

3 years agoci: Check for closed bugs for unit tests too
Thibault Saunier [Tue, 12 Oct 2021 20:19:46 +0000 (17:19 -0300)]
ci: Check for closed bugs for unit tests too

And add FIXMEs for test that should have been reenabled but haven't,
we will reenable them when CI is stable enough!

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1121>

3 years agotests: Move all unit tests issues to the GStreamer monorepo
Thibault Saunier [Tue, 12 Oct 2021 20:14:49 +0000 (17:14 -0300)]
tests: Move all unit tests issues to the GStreamer monorepo

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1121>

3 years agotranscoder: Set state back to NULL after run() finishes
Thibault Saunier [Tue, 5 Oct 2021 21:52:25 +0000 (18:52 -0300)]
transcoder: Set state back to NULL after run() finishes

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1063>

3 years agotranscoder: Use full path for includes in 'gsttranscoder.h'
Thibault Saunier [Mon, 13 Sep 2021 21:02:03 +0000 (18:02 -0300)]
transcoder: Use full path for includes in 'gsttranscoder.h'

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1063>

3 years agova:display: Don't close an fd with negative value
Mengkejiergeli Ba [Tue, 12 Oct 2021 09:50:31 +0000 (17:50 +0800)]
va:display: Don't close an fd with negative value

Cannot pass negative parameter to close() and thus no need to apply
close() when fd < 0.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1131>

3 years agova: Fix error handling for decoder
Mengkejiergeli Ba [Tue, 12 Oct 2021 09:48:17 +0000 (17:48 +0800)]
va: Fix error handling for decoder

Need to check if va decoder is closed successfully.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1131>

3 years agova: Fix error handling for base transform
Mengkejiergeli Ba [Tue, 12 Oct 2021 09:44:27 +0000 (17:44 +0800)]
va: Fix error handling for base transform

Need to check the returned value of gst_buffer_pool_set_active() when
setting the active status of buffer pool.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1131>

3 years agoFix GStreamer msys2 builds in the CI
Andoni Morales Alastruey [Tue, 12 Oct 2021 21:13:44 +0000 (23:13 +0200)]
Fix GStreamer msys2 builds in the CI

Install ninja and the toolchain in the docker image.
Use the UCRT64 environment for building

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1000>

3 years agoci: prepare the Windows image for MSYS2 cerbero builds
Andoni Morales Alastruey [Fri, 1 Oct 2021 15:20:30 +0000 (17:20 +0200)]
ci: prepare the Windows image for MSYS2 cerbero builds

 * Install MSYS2 and VS with choco
 * Install Windows SDK 8.1 requied for libvpx
 * Improve build time of the windows image using as much RUN layers as
   possible

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1000>

3 years agogl/dmabuf: add some debug logging about why things may fail to be uploaded
Matthew Waters [Thu, 14 Oct 2021 06:48:59 +0000 (17:48 +1100)]
gl/dmabuf: add some debug logging about why things may fail to be uploaded

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1145>

3 years agoplaybin2/3: autoplug/caps: don't expand caps to ANY
Matthew Waters [Fri, 24 Sep 2021 05:02:27 +0000 (15:02 +1000)]
playbin2/3: autoplug/caps: don't expand caps to ANY

Retrieving the pad template caps from a ghost pad returns ANY which when
merged with any other caps will return ANY.  ANY is not very specific
and may cause suboptimal code paths in e.g. decoders that assume the
lowest common denominator when presented with ANY caps.

Fixes negotiating dma-buf with vaapidecodebin between glupload in the
video sink element.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1144>

3 years agomeson:avtp: Error out if sock_txtime is not present and avtp is enabled
Thibault Saunier [Thu, 14 Oct 2021 00:26:53 +0000 (21:26 -0300)]
meson:avtp: Error out if sock_txtime is not present and avtp is enabled

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1142>

3 years agoRevert "tests: Blacklist some tests that recently failed"
Thibault Saunier [Wed, 13 Oct 2021 14:09:20 +0000 (11:09 -0300)]
Revert "tests: Blacklist some tests that recently failed"

This reverts commit 9f13ee5b0eada5ca0997e59be2ef46d5c2dd1dcd as
it was merge as part of the bigger CI gardening MR
https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1113

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1139>

3 years agosoup-stub: Gate G_URI_FLAGS_SCHEME_NORMALIZE behind glib version check
Philippe Normand [Wed, 13 Oct 2021 13:42:15 +0000 (14:42 +0100)]
soup-stub: Gate G_URI_FLAGS_SCHEME_NORMALIZE behind glib version check

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1138>

3 years agoci: Run tests post merge
Thibault Saunier [Wed, 13 Oct 2021 01:35:38 +0000 (22:35 -0300)]
ci: Run tests post merge

This will make tracking new races much easier

Mark other jobs as manual when pipeline is running on master

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1129>

3 years agoges:test: Document some GES failures
Thibault Saunier [Wed, 13 Oct 2021 03:17:27 +0000 (00:17 -0300)]
ges:test: Document some GES failures

Namely races in:
 * check.gst-editing-services.edit_while_seeked_with_stop_it
 * check.gst-editing-services.check_layer_activness_gaps_it

See https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/803
and https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/804

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1130>

3 years agoges:tests: Create shorter assets to avoid timeouts
Thibault Saunier [Wed, 13 Oct 2021 03:07:20 +0000 (00:07 -0300)]
ges:tests: Create shorter assets to avoid timeouts

And use a simple GStreamer pipeline as testsrcbin with GstTranscoder
doesn't let us easily set the framerate of the source and we end up
having videorate dropping frames leading to the rendered file having
an unprecise duration.

This should fix races with `check.gst-editing-services.pythontests.pyunittest.python.test_assets.TestTimeline.test_reload_asset`

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1130>

3 years agovalidate:launcher: Avoid spamming terminal when inspecting unit tests
Thibault Saunier [Wed, 13 Oct 2021 03:06:34 +0000 (00:06 -0300)]
validate:launcher: Avoid spamming terminal when inspecting unit tests

And redirect GStreamer logs when necessary

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1130>

3 years agovalidate:launcher: Run validate unit tests as GstValidate tests
Thibault Saunier [Wed, 13 Oct 2021 02:05:20 +0000 (23:05 -0300)]
validate:launcher: Run validate unit tests as GstValidate tests

So we have all the features and we can properly document known issue
for them

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1130>

3 years agocodecparsers: {h264,h265}parser: Fix typo around SEI nalu generator
Seungha Yang [Sat, 9 Oct 2021 16:56:32 +0000 (01:56 +0900)]
codecparsers: {h264,h265}parser: Fix typo around SEI nalu generator

Fix to create correct SEI nalu when the size of payloadType and/or
payloadType is larger than 255 (0xff)

Fixes: https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/issues/1601
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1106>

3 years agorebase-branch-from-old: few improvments
Stéphane Cerveau [Thu, 30 Sep 2021 10:33:35 +0000 (12:33 +0200)]
rebase-branch-from-old: few improvments

- Enhance the documentation
- Allow to revert cherry-pick
- coding style

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1094>

3 years agovalidate: flow: Fix for line-ending mismatch issue on Windows
Seungha Yang [Thu, 7 Oct 2021 10:28:41 +0000 (19:28 +0900)]
validate: flow: Fix for line-ending mismatch issue on Windows

Unlike POSIX system, Windows distinguishes "w" and "wb" and when
a file is opened with text mode, OS will translate \n into \r\n.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1092>

3 years agovapostproc: Negotiate interlaced.
Víctor Manuel Jáquez Leal [Tue, 5 Oct 2021 18:15:44 +0000 (20:15 +0200)]
vapostproc: Negotiate interlaced.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1109>

3 years agovapostproc: Copy missing fields at fixate.
Víctor Manuel Jáquez Leal [Tue, 5 Oct 2021 18:15:09 +0000 (20:15 +0200)]
vapostproc: Copy missing fields at fixate.

When caps negotiation implies a caps feature change, some fields might
get lost. This patch brings them back from input caps.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1109>

3 years agovapostproc: Simplify size fixate.
Víctor Manuel Jáquez Leal [Tue, 5 Oct 2021 18:15:09 +0000 (20:15 +0200)]
vapostproc: Simplify size fixate.

gst_va_vpp_fixate_size() returned the fixated caps, but that is not
needed since `othercaps` are modified inline.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1109>

3 years agovapostproc: Simplify fixate.
Víctor Manuel Jáquez Leal [Tue, 5 Oct 2021 18:15:09 +0000 (20:15 +0200)]
vapostproc: Simplify fixate.

The first approach to fixate was simply a copy&paste of both
videoconvert and videoscale, trying to keep their logic as isolated
as possible. But that brought duplicated and sparse logic.

This patch merge both approaches simplifying the fixate operation.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1109>

3 years agova: filter, deinterlace, vpp: Add gst_va_buffer_get_surface_flags().
Víctor Manuel Jáquez Leal [Tue, 5 Oct 2021 15:41:57 +0000 (17:41 +0200)]
va: filter, deinterlace, vpp: Add gst_va_buffer_get_surface_flags().

Add a helper function to get, from GstVideoInfo and GstBuffers flags,
the VA interlace surface flags. This is used currently by vainterlace
element, but it will be used in vapostproc too if it can process
interlaced frames.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1109>

3 years agobuild: Disable pygobject submodule if system version exists
Bastien Nocera [Wed, 13 Oct 2021 10:38:35 +0000 (12:38 +0200)]
build: Disable pygobject submodule if system version exists

If pygobject is available on the system, its version is new enough,
don't build the older pygobject and rely on that system one.

This fixes totem not being able to use libpeas' Python support.

** (totem:544972): WARNING **: 12:04:05.407: Error initializing Python Plugin Loader: PyGObject initialization failed
ImportError: could not import gobject (version mismatch, 3.40.1 is required, found 3.38.1)

Closes: #806
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1135>

3 years agotests: Blacklist some tests that recently failed
Thibault Saunier [Sun, 26 Sep 2021 02:40:31 +0000 (23:40 -0300)]
tests: Blacklist some tests that recently failed

See:
    - https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/739
    - https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/740

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/927>

3 years agogtkglsink: Avoid assertion when applying "auto" rotation method
Bastien Nocera [Wed, 13 Oct 2021 08:38:07 +0000 (10:38 +0200)]
gtkglsink: Avoid assertion when applying "auto" rotation method

Guard against the orientation not coming from an inexistant tag, nor
from the application (rotation set to "auto") which caused an assertion.

When the application requests the auto rotation method, make sure it is
resolved to a rotation that's applicable.

ERROR:gstreamer/subprojects/gst-plugins-good/ext/gtk/gtkgstglwidget.c:745:gtk_gst_gl_widget_set_rotate_method: code should not be reached

Fixes: 103ceb853a5f7dade07a1ac4aa517e9df6ed5ded
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1134>

3 years agosoup: Runtime compatibility support for libsoup2 and libsoup3
Philippe Normand [Mon, 4 Oct 2021 08:31:02 +0000 (09:31 +0100)]
soup: Runtime compatibility support for libsoup2 and libsoup3

The src and sink elements no longer link against libsoup. It is now loaded at
runtime. If any version is resident already, it is used. Otherwise we first try
to load libsoup3 and if it's not found we fallback to libsoup2.

For the unit-tests, we now build one version of the test unit file per libsoup
version found. So if both libsoup2 and libsoup3 are available on the host, the
CI will cover them both.

Based on initial patch by Daniel Kolesa <dkolesa@igalia.com> and
Patrick Griffis <pgriffis@igalia.com>.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1044>

3 years agoexamples: playback-test: Fix for UI resize scenario on Windows
Seungha Yang [Mon, 2 Aug 2021 08:46:37 +0000 (17:46 +0900)]
examples: playback-test: Fix for UI resize scenario on Windows

Application needs to notify videosink element of video widget resize
via gst_video_overlay_set_render_rectangle() since WM_SIZE event
wouldn't be notified.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1115>

3 years agoaudio: Merge simd libs into the main one
Olivier Crête [Thu, 16 Apr 2020 03:41:52 +0000 (23:41 -0400)]
audio: Merge simd libs into the main one

Actually extract the .o objects from the convience libraries and put
them into the main one. Without this, they will just be referenced by
the .pc file, but it will be unusable because they are not installed.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1122>

3 years agoci: have the fedora docker build depend on the trigger job
Jordan Petridis [Tue, 12 Oct 2021 19:09:35 +0000 (22:09 +0300)]
ci: have the fedora docker build depend on the trigger job

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1120>

3 years agomeson: Remove duplicate definition of 'examples' option
Nirbheek Chauhan [Tue, 12 Oct 2021 21:28:29 +0000 (02:58 +0530)]
meson: Remove duplicate definition of 'examples' option

This is a hard error starting with Meson 0.60.0rc1, due to
https://github.com/mesonbuild/meson/pull/9184#issuecomment-941603358

The upstream change might get reverted before release, but we should
of course fix this regardless.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1127>

3 years agortopuspay: Set marker bit inside RTP packet too
Olivier Crête [Fri, 10 Sep 2021 22:03:55 +0000 (18:03 -0400)]
rtopuspay: Set marker bit inside RTP packet too

At the end of a talk spurt, not only set the marker flag on the
GstBuffer, but also set the bit inside the RTP header as recommended
by the RFC.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1124>

3 years agogtksink: Fetch the default "widget" value in the docs
Bastien Nocera [Mon, 11 Oct 2021 12:27:24 +0000 (14:27 +0200)]
gtksink: Fetch the default "widget" value in the docs

There's really no interesting "widget" value that could be shown in the
docs, so use the GST_PARAM_DOC_SHOW_DEFAULT flag to avoid showing
another value.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1088>

3 years agogtksink: Avoid errors fetching widget property
Bastien Nocera [Mon, 11 Oct 2021 08:22:41 +0000 (10:22 +0200)]
gtksink: Avoid errors fetching widget property

Avoid errors when fetching the "widget" property and GTK initialisation
fails, such as when running in a non-graphical environment.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1088>

3 years agogtksink: Return reference to GtkWidget in the acquire function
Olivier Crête [Tue, 4 May 2021 17:27:30 +0000 (13:27 -0400)]
gtksink: Return reference to GtkWidget in the acquire function

This should ensure thread safety.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1088>

3 years agogtkglsink: Add rotate-method property
Olivier Crête [Thu, 3 Sep 2020 22:27:19 +0000 (18:27 -0400)]
gtkglsink: Add rotate-method property

This mostly just takes code out of glimagesink and applies it here.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1088>

3 years agoglutils: Export affine transformation functions for gtkglsink
Olivier Crête [Tue, 29 Aug 2017 21:21:05 +0000 (17:21 -0400)]
glutils: Export affine transformation functions for gtkglsink

Also remove duplicated copy of those functions from the gl plugin

With contributions from Bastien Nocera

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1088>

3 years agoglvideoflip: Replace GstVideoFlipMethod -> GstVideoOrientationMethod
Olivier Crête [Tue, 4 May 2021 19:55:15 +0000 (15:55 -0400)]
glvideoflip: Replace GstVideoFlipMethod -> GstVideoOrientationMethod

It's the same enum, just drop the renamed copy. But keep the registered
GEnum as it is part of the API.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1088>

3 years agoglvideoflip: Use the API to parse the image orientation
Olivier Crête [Tue, 4 May 2021 19:51:36 +0000 (15:51 -0400)]
glvideoflip: Use the API to parse the image orientation

This will reduce the code duplication a little.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1088>

3 years agoglimagesink: Use the API to parse the image orientation
Olivier Crête [Tue, 4 May 2021 19:51:13 +0000 (15:51 -0400)]
glimagesink: Use the API to parse the image orientation

This will reduce the code duplication a little.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1088>

3 years agovideo: Add API to parse the image orientation from a GstTagList
Olivier Crête [Tue, 4 May 2021 19:50:59 +0000 (15:50 -0400)]
video: Add API to parse the image orientation from a GstTagList

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1088>

3 years agoglimagesink: Replace GstGLRotateMethod with GstVideoOrientationMethod
Olivier Crête [Tue, 4 May 2021 19:39:29 +0000 (15:39 -0400)]
glimagesink: Replace GstGLRotateMethod with GstVideoOrientationMethod

It's the same enum, just drop the renamed copy. But keep the registered
GEnum as it is part of the API.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1088>

3 years agovideo: Put nicer documentation in GstVideoOrientationMethod
Olivier Crête [Tue, 4 May 2021 19:28:25 +0000 (15:28 -0400)]
video: Put nicer documentation in GstVideoOrientationMethod

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1088>

3 years agosplitmuxsink: Don't assert on the input side if no GOP is available when shutting...
Sebastian Dröge [Tue, 12 Oct 2021 16:01:37 +0000 (19:01 +0300)]
splitmuxsink: Don't assert on the input side if no GOP is available when shutting down

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1119>

3 years agomove-script: fix type in dateutil package name
Benjamin Gaignard [Fri, 1 Oct 2021 13:10:14 +0000 (15:10 +0200)]
move-script: fix type in dateutil package name

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1080>

3 years agotests: Mark check.gstreamer.gst_gstbin.test_watch_for_state_change flaky
Thibault Saunier [Tue, 12 Oct 2021 13:10:05 +0000 (10:10 -0300)]
tests: Mark check.gstreamer.gst_gstbin.test_watch_for_state_change flaky

See https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/778

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1113>

3 years agoges:tests: Mark check.gst-plugins-base.validate.giosrc.read-growing-file as flaky
Thibault Saunier [Mon, 11 Oct 2021 15:03:02 +0000 (12:03 -0300)]
ges:tests: Mark check.gst-plugins-base.validate.giosrc.read-growing-file as flaky

See https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/776

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1113>

3 years agoges:tests: Mark ges 'check_edit_in_frames_with_framerate_mistmatch as flaky
Thibault Saunier [Mon, 11 Oct 2021 14:45:50 +0000 (11:45 -0300)]
ges:tests: Mark ges 'check_edit_in_frames_with_framerate_mistmatch as flaky

See https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/775

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1113>

3 years agotests:webrtcbin: Make known flaky webrtcbin as such
Thibault Saunier [Mon, 11 Oct 2021 14:05:36 +0000 (11:05 -0300)]
tests:webrtcbin: Make known flaky webrtcbin as such

See https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/773

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1113>

3 years agovalidate:launcher: Do not dump on failure test we will retry
Thibault Saunier [Fri, 8 Oct 2021 15:09:47 +0000 (12:09 -0300)]
validate:launcher: Do not dump on failure test we will retry

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1113>

3 years agogst-env: Ignore SIGINT when running on the CI server
Thibault Saunier [Fri, 8 Oct 2021 14:54:22 +0000 (11:54 -0300)]
gst-env: Ignore SIGINT when running on the CI server

We get spurious sigint and this is just a small temporary workaround

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1113>

3 years agotests: aggregator: Take `TIMEOUT_FACTOR` env var into account
Thibault Saunier [Sun, 26 Sep 2021 02:51:52 +0000 (23:51 -0300)]
tests: aggregator: Take `TIMEOUT_FACTOR` env var into account

This env var is set in the CI so we grow the timeout as required
(when running in valgrind for example).

Trying to avoid hitting wrong timeout in valgrind job like in:
https://gitlab.freedesktop.org/tpm/gstreamer/-/jobs/14009456

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1113>

3 years agoci: Split base and core valgrind on different runners
Thibault Saunier [Fri, 8 Oct 2021 13:48:30 +0000 (10:48 -0300)]
ci: Split base and core valgrind on different runners

Those are very slow compared to other jobs and it should mitigate the problem

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1113>

3 years agotests: Blacklist tests that are currently producing many CI failures
Thibault Saunier [Fri, 8 Oct 2021 13:44:50 +0000 (10:44 -0300)]
tests: Blacklist tests that are currently producing many CI failures

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1113>

3 years agovalidate:launcher: Allow more flexible handling of flaky tests
Thibault Saunier [Fri, 8 Oct 2021 12:09:21 +0000 (09:09 -0300)]
validate:launcher: Allow more flexible handling of flaky tests

And retry twice flaky tests

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1113>

3 years agovalidate:launcher: Fix progress reporting with --n-runs
Thibault Saunier [Fri, 8 Oct 2021 00:28:12 +0000 (21:28 -0300)]
validate:launcher: Fix progress reporting with --n-runs

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1113>

3 years agovalidate:tests: Mark rtsp tests as generally flaky
Thibault Saunier [Thu, 7 Oct 2021 22:43:58 +0000 (19:43 -0300)]
validate:tests: Mark rtsp tests as generally flaky

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1113>

3 years agoges:tests: Mark nested timelines as generally flaky
Thibault Saunier [Thu, 7 Oct 2021 22:43:30 +0000 (19:43 -0300)]
ges:tests: Mark nested timelines as generally flaky

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1113>

3 years agovalidate:launcher: Support retry on failure when using --n-runs
Thibault Saunier [Thu, 7 Oct 2021 22:42:10 +0000 (19:42 -0300)]
validate:launcher: Support retry on failure when using --n-runs

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1113>

3 years agovalidate:launcher: Fix potential invalid index access
Thibault Saunier [Thu, 7 Oct 2021 22:41:07 +0000 (19:41 -0300)]
validate:launcher: Fix potential invalid index access

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1113>

3 years agovalidate:launcher: Fix adding logs to xunit
Thibault Saunier [Wed, 6 Oct 2021 20:21:58 +0000 (17:21 -0300)]
validate:launcher: Fix adding logs to xunit

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1113>

3 years agogst-play: pick up minus and plus also from navigation events
Tim-Philipp Müller [Sun, 26 Sep 2021 17:05:31 +0000 (18:05 +0100)]
gst-play: pick up minus and plus also from navigation events

Makes it easier to test playback rate changes with the video
window being in focus.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/928>

3 years agolibsoup: Bump to 2.74 to fix gssapi build failure on macOS
Nirbheek Chauhan [Tue, 12 Oct 2021 06:13:16 +0000 (11:43 +0530)]
libsoup: Bump to 2.74 to fix gssapi build failure on macOS

See: https://gitlab.gnome.org/GNOME/libsoup/-/merge_requests/255

We also need to disable sysprof by default because it only builds on
native Linux. If someone really wants it, they can enable the option
on the command-line by passing -Dlibsoup:sysprof=enabled

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1114>

3 years agomsdkenc: fix vp9enc initialization fail
Mengkejiergeli Ba [Wed, 22 Sep 2021 06:50:40 +0000 (14:50 +0800)]
msdkenc: fix vp9enc initialization fail

MediaSDK does not support to handle extbuff with id
MFX_EXTBUFF_VIDEO_SIGNAL_INFO for mjpegenc and vp9enc. Hence, need to
exclude mjpeg and vp9 when passing color properties to MediaSDK during
msdkenc initialization.

Fix issue: https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/764

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1101>

3 years agoexamples: d3d11: Add a desktop capture example
Seungha Yang [Sun, 10 Oct 2021 08:04:13 +0000 (17:04 +0900)]
examples: d3d11: Add a desktop capture example

... with d3d11 desktop capture device provider

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1103>

3 years agod3d11: Add device provider for d3d11desktopdupsrc
Seungha Yang [Tue, 5 Oct 2021 12:49:38 +0000 (21:49 +0900)]
d3d11: Add device provider for d3d11desktopdupsrc

... and add support for multi-GPU/multi-monitor

By using newly added "monitor-handle" property, user can specify a
monitor to be captured via HMONITOR handle.

Fixes: https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/issues/1673
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1103>

3 years agottml: fix log init
Stéphane Cerveau [Mon, 11 Oct 2021 13:23:08 +0000 (15:23 +0200)]
ttml: fix log init

The log system should be init before calling a log

Fix regression after:

https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/2038

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1112>

3 years agomove-mrs-script: add url option
Stéphane Cerveau [Wed, 29 Sep 2021 12:41:31 +0000 (14:41 +0200)]
move-mrs-script: add url option

You can give as option:

--url
https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/-/merge_requests/1

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/960>

3 years agomove-mrs-script: add a list only options
Stéphane Cerveau [Wed, 29 Sep 2021 11:35:09 +0000 (13:35 +0200)]
move-mrs-script: add a list only options

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/960>

3 years agotests: va: Add VA buffer copy tests.
Víctor Manuel Jáquez Leal [Mon, 4 Oct 2021 11:30:37 +0000 (13:30 +0200)]
tests: va: Add VA buffer copy tests.

It should only work for raw buffers, but fails on dmabuf since it
should have a drm modifier.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1023>

3 years agova: allocator: dmabuf: Use GstVaSurfaceCopy, if possible.
Víctor Manuel Jáquez Leal [Wed, 6 Oct 2021 13:20:50 +0000 (15:20 +0200)]
va: allocator: dmabuf: Use GstVaSurfaceCopy, if possible.

If dmabuf-based buffer to copy contains only one memory, and there are
memories available in the allocator's pool, it's possible a fast
memory copy using GstVaSurfaceCopy, regardless the drm modifier.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1023>

3 years agova: allocator: Use GstVaSurfaceCopy.
Víctor Manuel Jáquez Leal [Tue, 5 Oct 2021 13:21:01 +0000 (15:21 +0200)]
va: allocator: Use GstVaSurfaceCopy.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1023>

3 years agova: Add GstVaSurfaceCopy class.
Víctor Manuel Jáquez Leal [Tue, 5 Oct 2021 11:36:56 +0000 (13:36 +0200)]
va: Add GstVaSurfaceCopy class.

This new class is a helper for fast/tricky copy of surfaces. First it
tries to copy using the function vaCopy in libva 1.12. If it fails, or
it's not available, a GstVaFilter is tried to be instantiated with the
allocator's parameters, and if succeed, it's used for copying the
source surface.

This is required for dmabuf surfaces with drm modifier.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1023>

3 years agova: filter: Enable to pass VASurfaceID in GstVaSample.
Víctor Manuel Jáquez Leal [Tue, 5 Oct 2021 11:21:00 +0000 (13:21 +0200)]
va: filter: Enable to pass VASurfaceID in GstVaSample.

Initially GstVaSample processed its GstBuffer member to get the
VASurfaceID. But it might cases where we already have the VASurfaceID
to process by the filter.

This patch enables the possibility to pass the surfaces rather than
the buffers. In order to validate the surfaces a function to check
surfaces were added.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1023>