Lennart Poettering [Tue, 27 Nov 2018 12:39:28 +0000 (13:39 +0100)]
systemctl: suffix unit file settings with = in our output
We do this in our man pages and log messages, and hence also in this
explanatory text.
Lennart Poettering [Tue, 27 Nov 2018 12:50:28 +0000 (13:50 +0100)]
locale-util: add unicode bullet to special glyphs
Yu Watanabe [Wed, 28 Nov 2018 05:02:42 +0000 (14:02 +0900)]
Merge pull request #10967 from evverx/check-directives
travis: make sure that *.perf and directives.* files are in sync
Evgeny Vereshchagin [Wed, 28 Nov 2018 04:13:17 +0000 (05:13 +0100)]
tests: update test/fuzz/fuzz-netdev-parser/directives.netdev
This is a follow-up to
2266864b04257d7a.
Evgeny Vereshchagin [Wed, 28 Nov 2018 03:50:04 +0000 (04:50 +0100)]
travis: make sure that *.perf and directives.* files are in sync
New features are constantly added to networkd. Apparently, not everybody
knows that the "directives" files should be updated too to make
the fuzzers aware of them.
Lennart Poettering [Tue, 27 Nov 2018 09:34:32 +0000 (10:34 +0100)]
tree-wide: more IOVEC_MAKE() conversions
Lennart Poettering [Tue, 27 Nov 2018 16:30:23 +0000 (17:30 +0100)]
test: make TEST-27 non-racy
Not sure how I missed this, but we of course need to wait for the
"systemd-run" commands to finish before we can check the output files
this generated.
Yu Watanabe [Wed, 28 Nov 2018 02:33:27 +0000 (11:33 +0900)]
Merge pull request #10952 from evverx/keep-fuzz-udev-rules-going
tests: make fuzz-udev-rules work also in the environment created by run_minijail
Evgeny Vereshchagin [Tue, 27 Nov 2018 20:57:33 +0000 (21:57 +0100)]
tests: suppress "unwanted log lines" in several fuzzers
According to https://oss-fuzz.com/fuzzer-stats/by-fuzzer/fuzzer/libFuzzer/job/libfuzzer_asan_systemd,
fuzz-network-parser, fuzz-netdev-parser and fuzz-journal-remote produce
a lot of unwanted log lines. Let's set the maximum log level to LOG_CRIT
as we do in the other fuzzers.
Evgeny Vereshchagin [Wed, 28 Nov 2018 00:29:57 +0000 (01:29 +0100)]
tests: make fuzz-udev-rules work also in the environment created by run_minijail
This should close https://oss-fuzz.com/testcase?key=
5642013043589120.
See also https://github.com/google/oss-fuzz/issues/1983.
Lennart Poettering [Tue, 27 Nov 2018 21:37:22 +0000 (22:37 +0100)]
Merge pull request #10951 from thom311/network-dhcp-route-option
add accessor for sd_dhcp_route's "option"
Zbigniew Jędrzejewski-Szmek [Tue, 27 Nov 2018 16:02:20 +0000 (17:02 +0100)]
man,factory: update factory config for nsswitch.conf to match the man pages
Also add a note in the man pages to remind people to adjust the factory config
and other man pages at the same time.
Lennart Poettering [Tue, 27 Nov 2018 16:12:57 +0000 (17:12 +0100)]
Merge pull request #10955 from keszybz/rc-local-more-info
Provide more information in rc-local-generator
Zbigniew Jędrzejewski-Szmek [Tue, 27 Nov 2018 14:24:07 +0000 (15:24 +0100)]
rc-local-generator: provide more debugging information
C.f. https://bugzilla.redhat.com/show_bug.cgi?id=1516188.
Zbigniew Jędrzejewski-Szmek [Tue, 27 Nov 2018 14:23:35 +0000 (15:23 +0100)]
rc-local-generator: use macro to define main()
Lennart Poettering [Tue, 27 Nov 2018 12:18:26 +0000 (13:18 +0100)]
Merge pull request #10944 from poettering/redirect-file-fix
StandardOutput=file: fixes
Zbigniew Jędrzejewski-Szmek [Tue, 27 Nov 2018 11:53:43 +0000 (12:53 +0100)]
Merge pull request #10902 from poettering/highlight-status
Highlight status
Evgeny Vereshchagin [Tue, 27 Nov 2018 11:47:06 +0000 (12:47 +0100)]
tests: keep going even if setup_mount_namespace has failed
This should address https://github.com/google/oss-fuzz/issues/1983.
Thomas Haller [Tue, 27 Nov 2018 11:18:29 +0000 (12:18 +0100)]
network: use sd_dhcp_route_get_option() accessor in link_set_dhcp_routes()
Thomas Haller [Tue, 27 Nov 2018 11:09:52 +0000 (12:09 +0100)]
network: add sd_dhcp_route_get_option() accessor
Since sd_dhcp_lease_get_routes() returns the list of all routes,
the caller may need to differenciate whether the route was option
33 (static-routes) or 121 (classless-static-route).
Add an accessor for the internal field.
Lennart Poettering [Tue, 27 Nov 2018 09:29:17 +0000 (10:29 +0100)]
Merge pull request #10813 from poettering/cgroup-exec-start-pre
make sure ExecStartPre= and Delegate=yes mix well
Lennart Poettering [Mon, 26 Nov 2018 20:52:36 +0000 (21:52 +0100)]
tree-wide: use IOVEC_MAKE() at many places
Lennart Poettering [Mon, 26 Nov 2018 20:09:07 +0000 (21:09 +0100)]
test: add a test for StandardError=file:…
This deserves a test of its, given how broken on so many levels this
previously was.
Lennart Poettering [Mon, 26 Nov 2018 20:07:48 +0000 (21:07 +0100)]
core: be more careful when inheriting stdout fds to stderr
We need to compare the fd name/file name if we inherit an fd from stdout
to stderr. Let's do that.
Fixes: #10875
Lennart Poettering [Mon, 26 Nov 2018 20:07:39 +0000 (21:07 +0100)]
bus-unit-util: properly accept StandardOutput=append:… settings
Lennart Poettering [Mon, 26 Nov 2018 20:07:06 +0000 (21:07 +0100)]
dbus-execute: generate the correct transient unit setting
Lennart Poettering [Mon, 26 Nov 2018 20:06:19 +0000 (21:06 +0100)]
dbus-execute: fix indentation
Lennart Poettering [Mon, 26 Nov 2018 20:05:37 +0000 (21:05 +0100)]
core: drop references to 'StandardOutputFileToCreate'
This property never existed, let's drop any reference to it.
Zbigniew Jędrzejewski-Szmek [Tue, 27 Nov 2018 09:04:20 +0000 (10:04 +0100)]
Merge pull request #10949 from yuwata/man-improve-unset
man: slightly update man pages of network related units
Yu Watanabe [Tue, 27 Nov 2018 06:07:58 +0000 (15:07 +0900)]
man: update explanation for boolean options
Yu Watanabe [Tue, 27 Nov 2018 05:40:25 +0000 (14:40 +0900)]
man: improve the explanation of "Defaults to unset"
Lennart Poettering [Mon, 26 Nov 2018 20:16:27 +0000 (21:16 +0100)]
test: add test for setting service manager environment variables
This is a follow-up for #10594. I somehow forgot to commit this when I
worked on that.
Yu Watanabe [Tue, 27 Nov 2018 05:24:43 +0000 (14:24 +0900)]
Merge pull request #10947 from poettering/sd-radv-fixes
sd-radv fixes
Lennart Poettering [Mon, 26 Nov 2018 16:48:22 +0000 (17:48 +0100)]
journald: don't try to rotate user journals in /var/log/journal/ if we are still in log-to-runtime-journal mode
Fixes: #10879
Susant Sahani [Mon, 26 Nov 2018 11:50:09 +0000 (17:20 +0530)]
networkd: Add support for ERSPAN tunnel
Please see: https://patchwork.ozlabs.org/patch/800327/
```
[NetDev]
Name=erspan-test
Kind=erspan
[Tunnel]
Independent=true
ERSPANIndex=123
Local = 172.16.1.200
Remote = 172.16.1.100
Key=101
SerializeTunneledPackets=true
```
Claudius Ellsel [Mon, 26 Nov 2018 20:10:42 +0000 (21:10 +0100)]
First restructuration of Logitech mice in 70-mouse.hwdb
Untested, just carefully copy and pasted under the created sections. First approach to #10941
Lennart Poettering [Mon, 26 Nov 2018 21:13:36 +0000 (22:13 +0100)]
sd-radv: use struct initializers
Lennart Poettering [Mon, 26 Nov 2018 21:13:15 +0000 (22:13 +0100)]
sd-radv: per our CODING_STYLE don't use 'bool' in public headers
Lennart Poettering [Mon, 26 Nov 2018 21:12:53 +0000 (22:12 +0100)]
sd-radv: no need to initialize r to zero
Lennart Poettering [Mon, 26 Nov 2018 21:12:38 +0000 (22:12 +0100)]
sd-radv: make sure we can deal with in_addr_to_string() failing
Lennart Poettering [Mon, 26 Nov 2018 21:12:07 +0000 (22:12 +0100)]
sd-radv: when receiving a too short packet, make sure we dequeue it
Lennart Poettering [Mon, 26 Nov 2018 21:11:12 +0000 (22:11 +0100)]
sd-radv: propagate OOM, it's reason to fail
Lennart Poettering [Mon, 26 Nov 2018 21:09:57 +0000 (22:09 +0100)]
sd-radv: follow our usualy rule that destructors can take NULL
Lennart Poettering [Mon, 26 Nov 2018 20:54:52 +0000 (21:54 +0100)]
sd-radv: simplify IPv6 address is-null check
Lennart Poettering [Mon, 26 Nov 2018 20:54:31 +0000 (21:54 +0100)]
sd-radv: drop const from non-ptr argument
Lennart Poettering [Mon, 26 Nov 2018 20:53:26 +0000 (21:53 +0100)]
sd-radv: use ether_addr_is_null() where appropriate
Lennart Poettering [Mon, 26 Nov 2018 16:38:52 +0000 (17:38 +0100)]
units: make fsck/grows/makefs/makeswap units conflict against shutdown.target
They are the only units we shipped/generated where this was missing really. Let's fix these.
Follow-up for: #10933
Lennart Poettering [Mon, 26 Nov 2018 18:10:26 +0000 (19:10 +0100)]
tree-wide: use SWAP_TWO a bit more
Yu Watanabe [Mon, 26 Nov 2018 06:46:55 +0000 (15:46 +0900)]
test-network: add tests for #5430 and GatewayOnLink=
Lennart Poettering [Mon, 26 Nov 2018 17:46:47 +0000 (18:46 +0100)]
Merge pull request #10928 from yuwata/fix-9940
network: also load foo.netdev.d/*.conf
Lennart Poettering [Fri, 16 Nov 2018 19:29:02 +0000 (20:29 +0100)]
man: link Delegate= documentation up with the markdown docs
Lennart Poettering [Fri, 16 Nov 2018 19:25:54 +0000 (20:25 +0100)]
docs: document the .control/ subcgroup contract in the docs
Lennart Poettering [Fri, 16 Nov 2018 19:19:07 +0000 (20:19 +0100)]
core: when Delegate=yes is set for a unit, run ExecStartPre= and friends in a subcgroup of the unit
Otherwise we might conflict with the "no-processes-in-inner-cgroup" rule
of cgroupsv2. Consider nspawn starting up and initializing its cgroup
hierarchy with "supervisor/" and "payload/" as subcgroup, with itself
moved into the former and the payload into the latter. Now, if an
ExecStartPre= is run right after it cannot be placed in the main cgroup,
because that is now in inner cgroup with populated children.
Hence, let's run these helpers in another sub-cgroup .control/ below it.
This is somewhat ugly since it weakens the clear separation of
ownership, but given that this is an explicit contract, and double opt-in should be acceptable.
Fixes: #10482
Lennart Poettering [Fri, 23 Nov 2018 16:46:25 +0000 (17:46 +0100)]
unit: tweak status output a bit
Let's highlight the unit description string in the status updates, to
separate them a bit more the english sentence they are part of, and thus
make the different casing less surprising.
Lennart Poettering [Fri, 23 Nov 2018 16:19:24 +0000 (17:19 +0100)]
show-status: use free_and_replace() where we can
Lennart Poettering [Fri, 23 Nov 2018 16:18:48 +0000 (17:18 +0100)]
show-status: fold two bool flags function arguments into a flags
parameter
Lennart Poettering [Mon, 26 Nov 2018 17:08:41 +0000 (18:08 +0100)]
Merge pull request #10919 from yuwata/sd-device-monitor-fixes
sd-device-monitor: several fixes
Harald Hoyer [Mon, 26 Nov 2018 10:41:29 +0000 (11:41 +0100)]
generator.c: systemd-fsck-root.service conflict with shutdown.target
Otherwise a "reboot" or "poweroff" in the initramfs will have to wait
until systemd-fsck-root.service has completed, which might never happen
if the root device never shows up.
Yu Watanabe [Mon, 26 Nov 2018 13:05:48 +0000 (22:05 +0900)]
test-network: add one more test for netdev dropin .conf files
For netdev, config files are loaded twice, and the first time,
only Match and NetDev setions are read. So, the test given by
the previous commit covers only the second loading.
This adds another test that also covers the first loading.
Yu Watanabe [Mon, 26 Nov 2018 13:40:51 +0000 (22:40 +0900)]
Merge pull request #10901 from poettering/startswith-list
add new STARTSWITH_SET() macro
Lennart Poettering [Mon, 26 Nov 2018 13:23:28 +0000 (14:23 +0100)]
Merge pull request #10927 from yuwata/udev-ctrl-cleanup
udev: update log messages and fix coding style issues
Lennart Poettering [Mon, 26 Nov 2018 13:20:36 +0000 (14:20 +0100)]
Merge pull request #10925 from yuwata/sd-boot-fixes
sd-boot: fixes trailing whitespace trimming and updates document
Lennart Poettering [Mon, 26 Nov 2018 13:19:03 +0000 (14:19 +0100)]
Merge pull request #10910 from yuwata/list-cleanups
basic/list: tiny fixes
Lennart Poettering [Mon, 26 Nov 2018 13:18:23 +0000 (14:18 +0100)]
Merge pull request #10909 from yuwata/import-cleanups
Import: cleanups
Lennart Poettering [Mon, 26 Nov 2018 13:13:01 +0000 (14:13 +0100)]
Merge pull request #10894 from poettering/root-cgroup-fix
A multitude of cgroup fixes
Lennart Poettering [Fri, 23 Nov 2018 15:53:39 +0000 (16:53 +0100)]
terminal-util: use PATH_STARTSWITH_SET() instead of plain startswith() where appropriate
After all, we deal with paths here.
Lennart Poettering [Fri, 23 Nov 2018 15:52:43 +0000 (16:52 +0100)]
journal-upload: use static initialization
Lennart Poettering [Fri, 23 Nov 2018 15:52:26 +0000 (16:52 +0100)]
journal-remote: shorten code a bit by using strcspn()
Lennart Poettering [Fri, 23 Nov 2018 15:51:53 +0000 (16:51 +0100)]
tree-wide: port more code over to PATH_STARTSWITH_SET()
Lennart Poettering [Fri, 23 Nov 2018 15:50:39 +0000 (16:50 +0100)]
path-util: beef up PATH_STARTSWITH_SET() macro a bit
Let's remove duplicate evaluation, and let's return the result of the
succesful path_startswith() call, i.e. the suffix to the matching
prefix.
Lennart Poettering [Fri, 23 Nov 2018 15:31:04 +0000 (16:31 +0100)]
tree-wide: port over more cases to STR_IN_SET()
Lennart Poettering [Fri, 23 Nov 2018 15:30:23 +0000 (16:30 +0100)]
tree-wide: port various places over to STARTSWITH_SET()
Lennart Poettering [Fri, 23 Nov 2018 15:27:15 +0000 (16:27 +0100)]
strv: add new macro STARTSWITH_SET()
This is to startswith() what PATH_STARTSWITH_SET() is to
path_startswith().
Or in other words, checks if the specified string has any of the listed
prefixes, and if so, returns the remainder of the string.
Lennart Poettering [Mon, 26 Nov 2018 12:41:07 +0000 (13:41 +0100)]
update TODO
Evgeny Vereshchagin [Mon, 26 Nov 2018 09:14:30 +0000 (12:14 +0300)]
tests: add a fuzzer for the udev rules parser (#10929)
Yu Watanabe [Mon, 26 Nov 2018 06:01:01 +0000 (15:01 +0900)]
test-network: add tests for dropin .conf files
Yu Watanabe [Mon, 26 Nov 2018 05:25:50 +0000 (14:25 +0900)]
network: also load foo.netdev.d/*.conf
Fixes #9940.
Yu Watanabe [Mon, 26 Nov 2018 02:57:48 +0000 (11:57 +0900)]
udevd: do not call udev_ctrl_enable_receiving() if the socket is passed from pid1
Before
c4b69e990f962128cc6975e36e91e9ad838fa2c4, if the socket fd is
passed from pid1, `udev_ctrl_enable_receiving()` was not called.
Let's preserve the original logic.
Yu Watanabe [Mon, 26 Nov 2018 02:53:21 +0000 (11:53 +0900)]
udev: drop duplicate whitespaces
Yu Watanabe [Mon, 26 Nov 2018 02:52:40 +0000 (11:52 +0900)]
udev-ctrl: update log messages
Yu Watanabe [Mon, 26 Nov 2018 02:37:29 +0000 (11:37 +0900)]
udev-rules: include device sysname in log messages
Yu Watanabe [Fri, 23 Nov 2018 19:46:27 +0000 (04:46 +0900)]
udev-ctrl: fix coding style isuues
Yu Watanabe [Mon, 26 Nov 2018 00:33:32 +0000 (09:33 +0900)]
Merge pull request #10926 from AsciiWolf/copyright
Drop my copyright
AsciiWolf [Sun, 25 Nov 2018 23:30:28 +0000 (00:30 +0100)]
mkosi: drop my copyright
AsciiWolf [Sun, 25 Nov 2018 23:26:03 +0000 (00:26 +0100)]
po: drop my copyright (cs.po)
Yu Watanabe [Sun, 25 Nov 2018 21:58:28 +0000 (06:58 +0900)]
man: systemd-boot does not read loader.conf.d/*.conf
Fixes #10923.
Yu Watanabe [Sun, 25 Nov 2018 21:43:33 +0000 (06:43 +0900)]
sd-boot: fix trailing whitespace trimming
Fixes #10922.
Marian Cepok [Sat, 24 Nov 2018 12:24:39 +0000 (13:24 +0100)]
hwdb: Add ACCEL_MOUNT_MATRIX for Trekstor T13B tablet
Yu Watanabe [Sun, 25 Nov 2018 06:04:26 +0000 (15:04 +0900)]
udevd: do not set buffer size if the socket is passed from pid1
Before
c4b69e990f962128cc6975e36e91e9ad838fa2c4, if the socket fd is
passed from pid1, `udev_monitor_set_receive_buffer_size()` (now it is
a wrapper of `sd_device_monitor_set_receive_buffer_size()`) was not
called. Let's preserve the original logic.
Yu Watanabe [Sun, 25 Nov 2018 05:52:24 +0000 (14:52 +0900)]
sd-device: do not call device_monitor_enable_receiving() for passed fd from pid1
Before
c4b69e990f962128cc6975e36e91e9ad838fa2c4, if the socket fd is
passed from pid1, `udev_monitor_enable_receiving()` (now it is a wrapper
of `device_monitor_enable_receiving`) was not called.
Let's preserve the original logic.
Fixes #10754.
Yu Watanabe [Sun, 25 Nov 2018 05:44:46 +0000 (14:44 +0900)]
sd-device: check whether filter is updated or not in sd_device_monitor_filter_update()
Yu Watanabe [Sun, 25 Nov 2018 05:06:56 +0000 (14:06 +0900)]
sd-device: update log message
Yu Watanabe [Sun, 25 Nov 2018 05:06:27 +0000 (14:06 +0900)]
sd-device: fix return value on error path
Lennart Poettering [Sat, 24 Nov 2018 14:59:37 +0000 (15:59 +0100)]
units: order systemd-rfkill.socket after /var/lib/systemd/rfkill (#10904)
Otherwise we might install the socket unit early, but the service
backing it late, and then end up in strange loops when we enter rescue
mode, because we saw an event on /dev/rfkill but really can't dispatch
it nor flush it.
Fixes: #9171
Evgeny Vereshchagin [Fri, 23 Nov 2018 17:26:02 +0000 (18:26 +0100)]
tests: skip test-execute on TravisCI under ASan
Unfortunately,
f5f9a580dd4a3cf487b didn't help much and now
the next subtest gets stuck from time to time. Let's skip
test-execute altogether so as not to bother anybody with
spurious failures.
https://github.com/systemd/systemd/issues/10696 is still open.
Everybody is welcome to share ideas :-)
nikolas [Fri, 23 Nov 2018 19:28:39 +0000 (14:28 -0500)]
Fix a few docs typos (#10907)
Found with [codespell](https://github.com/codespell-project/codespell)
Yu Watanabe [Fri, 23 Nov 2018 19:26:10 +0000 (04:26 +0900)]
basic/list: fix minor coding style issue
Yu Watanabe [Fri, 23 Nov 2018 19:25:00 +0000 (04:25 +0900)]
basic/list: add missing header
Some macros use assert() which is (re)defined in macro.h
Yu Watanabe [Fri, 23 Nov 2018 18:52:35 +0000 (03:52 +0900)]
import: use structured initializers
Yu Watanabe [Fri, 23 Nov 2018 18:14:32 +0000 (03:14 +0900)]
import: use _cleanup_ attribute for CURL object