Matthias Clasen [Wed, 4 Jan 2012 05:10:11 +0000 (00:10 -0500)]
Clarify g_utf8_strlen docs a bit
Paolo Borelli [Tue, 3 Jan 2012 10:49:55 +0000 (11:49 +0100)]
Add a testcase for an old regex bug.
Add a testcase for bug #455640, which was fixed in PCRE versions newer
than 7.2.
Javier Jardón [Mon, 2 Jan 2012 15:10:35 +0000 (16:10 +0100)]
glib/*: Use g_list_free_full()
Javier Jardón [Mon, 2 Jan 2012 15:30:11 +0000 (16:30 +0100)]
gio/*: Use g_list_free_full() convenience function
Javier Jardón [Mon, 2 Jan 2012 15:09:50 +0000 (16:09 +0100)]
gio/gdbus-2.0/codegen/codegen.py: Use g_list_free_full()
Matthias Clasen [Tue, 3 Jan 2012 15:48:50 +0000 (10:48 -0500)]
Fix parameter name mismatches in GWeakRef api
Matthias Clasen [Tue, 3 Jan 2012 13:02:49 +0000 (08:02 -0500)]
Add GWeakRef to the docs
Javier Jardón [Mon, 2 Jan 2012 14:20:42 +0000 (15:20 +0100)]
gio/tests: Use g_list_free_full() convenience function
Stef Walter [Mon, 14 Nov 2011 17:03:47 +0000 (18:03 +0100)]
gvariant: Never break out of g_variant_iter_loop
* Document how to break out of g_variant_iter_loop style loops.
https://bugzilla.gnome.org/show_bug.cgi?id=664069
Simon McVittie [Wed, 7 Dec 2011 15:04:59 +0000 (15:04 +0000)]
Add test for GDBusConnection singleton access racing with destruction
Bug: https://bugzilla.gnome.org/show_bug.cgi?id=665211
Simon McVittie [Tue, 6 Dec 2011 12:44:36 +0000 (12:44 +0000)]
GDBusConnection: use GWeakRef to make the singletons thread-safe
Bug: https://bugzilla.gnome.org/show_bug.cgi?id=665211
https://bugzilla.gnome.org/show_bug.cgi?id=548954
Simon McVittie [Wed, 7 Dec 2011 15:04:13 +0000 (15:04 +0000)]
Add regression test for GWeakRef used to cache a singleton
https://bugzilla.gnome.org/show_bug.cgi?id=548954
Simon McVittie [Thu, 8 Dec 2011 17:35:19 +0000 (17:35 +0000)]
Add deterministic tests for the API of GWeakRef
These don't address the thread-safety, but do address basic use.
https://bugzilla.gnome.org/show_bug.cgi?id=548954
Ryan Lortie [Tue, 6 Dec 2011 12:27:07 +0000 (12:27 +0000)]
GWeakRef: add a weak GObject reference believed to be thread-safe
This patch is a joint work with Simon McVittie.
https://bugzilla.gnome.org/show_bug.cgi?id=548954
Simon McVittie [Tue, 6 Dec 2011 11:37:45 +0000 (11:37 +0000)]
g_object_weak_ref, g_object_add_weak_pointer: document non-thread-safety
Transparent access to a weak pointer from the thread performing the
weak -> strong conversion is incompatible with thread-safety: that
thread will have to do something special. This is GNOME#548954.
https://bugzilla.gnome.org/show_bug.cgi?id=548954
Simon McVittie [Tue, 6 Dec 2011 11:35:02 +0000 (11:35 +0000)]
GBitLock: turn assumptions of g_futex_int_address into a static assertion
We'll probably never encounter a platform where these fail, but that's
what static assertions are for...
https://bugzilla.gnome.org/show_bug.cgi?id=548954
Ryan Lortie [Mon, 2 Jan 2012 16:38:40 +0000 (11:38 -0500)]
gthread.h: avoid anonymous union
This is a GNU extension.
https://bugzilla.gnome.org/show_bug.cgi?id=666978
William Hua [Mon, 2 Jan 2012 02:53:28 +0000 (21:53 -0500)]
nextstep gsettings backend: whitespace police
William Hua [Mon, 2 Jan 2012 02:38:05 +0000 (21:38 -0500)]
thread-safe nextstep gsettings backend
simplified key reset logic
William Hua [Mon, 26 Dec 2011 15:04:38 +0000 (10:04 -0500)]
GSettings: nextstep settings backend
Xan Lopez [Sun, 1 Jan 2012 18:01:14 +0000 (19:01 +0100)]
ginetaddressmask: plug leak
==24706== 52 bytes in 1 blocks are definitely lost in loss record 7,248 of 13,092
==24706== at 0x4A074CD: malloc (vg_replace_malloc.c:236)
==24706== by 0x70E9F5F: standard_malloc (gmem.c:85)
==24706== by 0x70E9FE8: g_malloc (gmem.c:159)
==24706== by 0x71018EC: g_slice_alloc (gslice.c:1003)
==24706== by 0x710192B: g_slice_alloc0 (gslice.c:1029)
==24706== by 0x7068526: g_type_create_instance (gtype.c:1872)
==24706== by 0x705067B: g_object_constructor (gobject.c:1835)
==24706== by 0x704FE47: g_object_newv (gobject.c:1699)
==24706== by 0x7050612: g_object_new_valist (gobject.c:1816)
==24706== by 0x704F894: g_object_new (gobject.c:1531)
==24706== by 0x6F0F2F0: g_inet_address_new_from_bytes (ginetaddress.c:459)
==24706== by 0x6F5D703: remove_network (gnetworkmonitornetlink.c:256)
==24706== by 0x6F5DD80: read_netlink_messages (gnetworkmonitornetlink.c:386)
==24706== by 0x6F2D5CA: socket_source_dispatch (gsocket.c:2505)
==24706== by 0x70E1D45: g_main_dispatch (gmain.c:2513)
==24706== by 0x70E2A06: g_main_context_dispatch (gmain.c:3050)
==24706== by 0x70E2BE9: g_main_context_iterate (gmain.c:3121)
==24706== by 0x70E2CAD: g_main_context_iteration (gmain.c:3182)
==24706== by 0x6F60A05: g_application_run (gapplication.c:1599)
==24706== by 0x42D011: main (ephy-main.c:472)
https://bugzilla.gnome.org/show_bug.cgi?id=667098
Yaron Shahrabani [Fri, 30 Dec 2011 08:47:56 +0000 (10:47 +0200)]
Updated Hebrew translation.
Chun-wei Fan [Fri, 30 Dec 2011 07:27:31 +0000 (15:27 +0800)]
config.h.win32.in: Cleanups
-Make the contents of the preconfigured config.h.win32(.in) more like the
contents of config.h.in
-Correct the sizing of void* on x64 platforms (which should be 8, unlike
4 on x86-32 platforms)
Matthias Clasen [Thu, 29 Dec 2011 16:57:42 +0000 (11:57 -0500)]
Correct some Since tags
As pointed out in bug 666951, g_mkdtemp and g_mkdtemp_full
were only added in 2.30.
Ravi Sankar Guntur [Tue, 20 Dec 2011 09:19:53 +0000 (14:49 +0530)]
Fix to handle '\v' (vertical tab) by g_strescape() and g_strcompress().
fix enables g_strescape() and g_strcompress() to handle '\v' along with other
special characters - '\b', '\f', '\n', '\r', '\t', '\'.
https://bugzilla.gnome.org/show_bug.cgi?id=664830
Signed-off-by: Ravi Sankar Guntur <ravi.g@samsung.com>
Matthias Clasen [Tue, 27 Dec 2011 23:10:42 +0000 (18:10 -0500)]
Some minor updates of building.sgml
https://bugzilla.gnome.org/show_bug.cgi?id=664830
Matthias Clasen [Tue, 27 Dec 2011 23:10:26 +0000 (18:10 -0500)]
Some minor updates of HACKING
Simon McVittie [Wed, 14 Dec 2011 17:31:23 +0000 (17:31 +0000)]
Add undefined/no-undefined mode options to GTester
https://bugzilla.gnome.org/show_bug.cgi?id=666116
Simon McVittie [Wed, 14 Dec 2011 18:08:59 +0000 (18:08 +0000)]
various tests: do not provoke SIGTRAP with -m no-undefined
Some of the GLib tests deliberately provoke warnings (or even fatal
errors) in a forked child. Normally, this is fine, but under valgrind
it's somewhat undesirable. We do want to follow fork(), so we can check
for leaks in child processes that exit gracefully; but we don't want to
be told about "leaks" in processes that are crashing, because there'd
be no point in cleaning those up anyway.
https://bugzilla.gnome.org/show_bug.cgi?id=666116
Simon McVittie [Wed, 14 Dec 2011 17:32:16 +0000 (17:32 +0000)]
Clarify documentation of fast/slow/thorough and quiet/verbose tests
It turns out that there is no middle setting between fast and
slow/thorough, but there *is* a middle setting between quiet and verbose.
https://bugzilla.gnome.org/show_bug.cgi?id=666116
Matthias Clasen [Tue, 27 Dec 2011 22:45:40 +0000 (17:45 -0500)]
Remove another unused AC_DEFINE
Nothing was using the HAVE_GCOV define.
Matthias Clasen [Tue, 27 Dec 2011 22:20:36 +0000 (17:20 -0500)]
Drop unused AC_SUBST
DISABLE_MEM_POOLS is only used as define.
Matthias Clasen [Tue, 27 Dec 2011 22:15:44 +0000 (17:15 -0500)]
Remove a bashism
Matthias Clasen [Tue, 27 Dec 2011 22:12:39 +0000 (17:12 -0500)]
Drop a lot of dead configury for threads
Much of this became obsolete by the recent rewrite of our
threading support.
Matthias Clasen [Tue, 27 Dec 2011 21:22:13 +0000 (16:22 -0500)]
Don't put documentation in glibconfig.h
Matthias Clasen [Tue, 27 Dec 2011 21:18:19 +0000 (16:18 -0500)]
Make glibconfig.h include guards consistent
Matthias Clasen [Tue, 27 Dec 2011 21:16:24 +0000 (16:16 -0500)]
Remove a commented-out macro
Matthias Clasen [Tue, 27 Dec 2011 20:55:04 +0000 (15:55 -0500)]
Remove obsolescent AC_HEADER_STDC macro
We only used the resulting define in one place, and really,
these headers just have to be around or its not worth trying.
Thomas Hindoe Paaboel Andersen [Sat, 24 Dec 2011 14:31:55 +0000 (15:31 +0100)]
docs: g_atexit: do not point in a direction for where to find details
https://bugzilla.gnome.org/show_bug.cgi?id=666804
Åsmund Skjæveland [Mon, 26 Dec 2011 16:15:32 +0000 (17:15 +0100)]
Updated Norwegian Nynorsk translation
Matthias Clasen [Sun, 25 Dec 2011 04:01:17 +0000 (23:01 -0500)]
Don't leak references to the menus
Matthias Clasen [Sun, 25 Dec 2011 03:59:10 +0000 (22:59 -0500)]
Add a test for ids on submenu and section elements
The test checks that menus which are created via
<submenu id=...> or <section id=...> end up in the objects
hash table.
Matthias Clasen [Sun, 25 Dec 2011 03:58:16 +0000 (22:58 -0500)]
Menu markup: Support ids on submenu and section elements
This was supposed to work, but didn't.
Bug 666595.
Benjamin Otte [Sat, 24 Dec 2011 13:26:24 +0000 (14:26 +0100)]
docs: Clarify non-NUL requirement in g_utf8_validate()
UTF8 validation is not about your character on a dating site, so don't
talk about meeting.
https://bugzilla.gnome.org/show_bug.cgi?id=666803
Dan Winship [Fri, 20 Aug 2010 17:04:19 +0000 (13:04 -0400)]
Add GSocketClient::event, for tracking socket client status
This can be used for debugging, or for progress UIs ("Connecting to
example.com..."), or to do low-level tweaking on the connection at
various points in the process.
https://bugzilla.gnome.org/show_bug.cgi?id=665805
Dan Winship [Sun, 12 Jun 2011 20:29:04 +0000 (16:29 -0400)]
Add g_socket_connection_connect(), etc
Previously it was more or less assumed that GSocketConnections were
always connected, although this was not enforced. Make it explicit
that they don't need to be, and add methods to connect them, and
simplify GSocketClient by using those methods.
https://bugzilla.gnome.org/show_bug.cgi?id=665805
Chun-wei Fan [Thu, 22 Dec 2011 12:18:11 +0000 (20:18 +0800)]
Update GIO Visual C++ projects
Link to zlib1.lib for release builds and zlib1d.lib for debug builds-
this is to be consistent across the board for the GTK+ stack (and many
other opensource code linking to the ZLib DLL on Windows)
Chun-wei Fan [Thu, 22 Dec 2011 10:49:01 +0000 (18:49 +0800)]
Update Visual C++ property sheets
"Install" the newly-introduced gremoteactiongroup.h header.
Ryan Lortie [Thu, 22 Dec 2011 05:24:20 +0000 (00:24 -0500)]
GSettingsBackend: allow floating refs from read()
Use g_variant_take_ref() to allow for backends to return floating
GVariant instances from their read() implementations.
rodrigorivascosta [Thu, 22 Dec 2011 02:48:09 +0000 (10:48 +0800)]
Bug 666551-Fix a few dangling pointers
When removing an item from the list, check the next one's my_owner,
and fix it accordingly. And take this case into account when last
of the list is deleted.
Also, assign NULL to 'my_owner' in g_thread_xp_WakeConditionVariable.
Chun-wei Fan [Wed, 21 Dec 2011 03:24:09 +0000 (11:24 +0800)]
glib/tests/private.c: Fix compilation on Windows
-process.h must be included for _beginthreadex
-Use a cast to HANDLE on _beginthreadex to silence warnings on different
types
Kjartan Maraas [Wed, 21 Dec 2011 21:22:05 +0000 (22:22 +0100)]
Updated Norwegian bokmål translation
Cosimo Cecchi [Wed, 21 Dec 2011 11:36:19 +0000 (12:36 +0100)]
menu: documentation fixes
g_menu_new_section() does not exist, the comment meant
g_menu_item_new_section().
Ryan Lortie [Wed, 21 Dec 2011 00:45:57 +0000 (19:45 -0500)]
GObject: do checks on interface property install
Add some checks to g_object_interface_install_property() similar to
those in g_object_class_install_property().
https://bugzilla.gnome.org/show_bug.cgi?id=666616
Ryan Lortie [Wed, 21 Dec 2011 00:43:21 +0000 (19:43 -0500)]
GObject: require READ or WRITE on property install
g_object_class_install_property() currently lets you install properties
that are neither readable nor writable. Add a check to prevent that.
https://bugzilla.gnome.org/show_bug.cgi?id=666616
Ryan Lortie [Wed, 21 Dec 2011 00:33:02 +0000 (19:33 -0500)]
GObject: allow G_PARAM_CONSTRUCT on any override
We were previously preventing implementations of an interface from
specifying G_PARAM_CONSTRUCT for a property of that interface if the
interface didn't specify it itself (or was readonly).
This is something that should only interest the implementation, so we
remove this restriction.
This allows 6 new possible override scenarios:
- writable -> writable/construct
- writable -> readwrite/construct
- readwrite -> readwrite/construct
- writable/construct-only -> writable/construct
- writable/construct-only -> readwrite/construct
- readwrite/construct-only -> readwrite/construct
and we update the testcase to reflect this.
https://bugzilla.gnome.org/show_bug.cgi?id=666616
Ryan Lortie [Tue, 20 Dec 2011 23:44:48 +0000 (18:44 -0500)]
GObject: add test for interface property overrides
Add a testcase to check all possibilities for overriding a property
specified on an interface from an implementation of that interface,
changing the type and flags.
https://bugzilla.gnome.org/show_bug.cgi?id=666616
Ryan Lortie [Tue, 20 Dec 2011 23:41:03 +0000 (18:41 -0500)]
GObject: change the order of property checks
Change the order of the checks so that we hear about the 'biggest'
problem first. Also, stop reporting problems after we report the first
one for a particular property.
Add some comments.
https://bugzilla.gnome.org/show_bug.cgi?id=666616
Ryan Lortie [Tue, 20 Dec 2011 23:26:14 +0000 (18:26 -0500)]
GObject: fix property override type checks
The property override typecheck was meant to enforce the type on the
overriding property being exactly equal to the type on the interface
property. Instead, g_type_is_a() was incorrectly used.
We could try to enforce equality, but if a property is read-only then it
should be possible for the implementation to type the property with any
subtype of the type specified on the interface (because returning a more
specific type will still satisfy the interface). Likewise, if the
property is write-only then it should be possible for the implementation
to type the property with any supertype.
We implement the check this way.
https://bugzilla.gnome.org/show_bug.cgi?id=666616
Ryan Lortie [Wed, 21 Dec 2011 00:12:56 +0000 (19:12 -0500)]
GSimpleAction: fix some whitespace fail
Ryan Lortie [Wed, 21 Dec 2011 00:11:19 +0000 (19:11 -0500)]
GSimpleAction: tweak property flags
There's no need for 'enabled' and 'state' to be marked construct-only.
These properties are writable at all times.
Ryan Lortie [Tue, 20 Dec 2011 20:29:16 +0000 (15:29 -0500)]
GObject: fixup reversed logic in last commit
Accidentally dropped a !.
Ryan Lortie [Tue, 20 Dec 2011 20:12:44 +0000 (15:12 -0500)]
gobject: Clean up logic in property checks
Simplify some of the logic in this function.
1) Simplify flag checks as per Colin's suggestions in
https://bugzilla.gnome.org/show_bug.cgi?id=605667
2) Don't repeatedly recheck if class_pspec is NULL.
Ryan Lortie [Tue, 20 Dec 2011 19:43:15 +0000 (14:43 -0500)]
GAction: back out changes to property flags
41e5ba86a791a17bb560dd7813ad7e849e0230dc introduced some changes to the
property flags of GAction. These changes were not a reflection of the
actual interface of GAction but were necessary due to GObject being
overly-sensitive to flag changes on property overrides.
Now that the GObject bug is fixed, we can restore the GAction flags to
their correct values.
https://bugzilla.gnome.org/show_bug.cgi?id=666615
Ryan Lortie [Tue, 20 Dec 2011 19:36:29 +0000 (14:36 -0500)]
gobject: loosen property override flag restrictions
GObject enforces the following restrictions on property overrides:
- must only add abilities: if the parent class supports
readability/writability then the subclass must also support them.
Subclasses are free to add readability/writability.
- must not add additional restrictions: if the parent class doesn't
have construct/construct-only restrictions then the subclass must
not add them. Subclasses are free to remove restrictions.
The problem with the previous implementation is that the check against
adding construct/construct-only restrictions was being done even if the
property was not previously writable. As an example:
"readable" and "writable only on construct"
was considered as being more restrictive than
"read only".
This patch tweaks the check to allow the addition of
construct/construct-only restrictions for properties that were
previously read-only and are now being made writable.
https://bugzilla.gnome.org/show_bug.cgi?id=666615
Matthias Clasen [Tue, 20 Dec 2011 17:15:05 +0000 (12:15 -0500)]
Add references to the dbus interface docs on the wiki
And strip out the (now) redundant copy of that information
from the sources.
Ryan Lortie [Tue, 20 Dec 2011 03:56:05 +0000 (22:56 -0500)]
docs: remove duplicate GMenuModel from gio.types
Ryan Lortie [Mon, 19 Dec 2011 22:35:31 +0000 (17:35 -0500)]
winxp threads: fix some condition variable races
There are some races in the condition variable emulation code for
Windows XP with respect to timeouts while waiting.
First, in the event of a timeout, we never remove the waiter from the
condition variable. This can cause crashes later. That problem was
found by Rodrigo Rivas Costa.
Second, if the waiting thread times out and exits just as we were about
to call SetEvent() on its waiter event, we could end up trying to access
the waiter after it was closed/freed. We need to hold on to the lock a
little bit longer to ensure that that's not possible.
https://bugzilla.gnome.org/show_bug.cgi?id=666551
Ryan Lortie [Mon, 19 Dec 2011 20:24:52 +0000 (15:24 -0500)]
*bump*
Dan Winship [Mon, 19 Dec 2011 20:19:19 +0000 (15:19 -0500)]
gnetworkmonitornetlink.c: Fix a gsize->gssize
https://bugzilla.gnome.org/show_bug.cgi?id=666422
Ryan Lortie [Mon, 19 Dec 2011 18:38:21 +0000 (13:38 -0500)]
glib 2.31.6
Ryan Lortie [Mon, 19 Dec 2011 18:37:06 +0000 (13:37 -0500)]
gitignore
Ryan Lortie [Mon, 19 Dec 2011 15:47:45 +0000 (10:47 -0500)]
Drop public menu APIs from GApplication
This is moving to Gtk, but we don't want to do it all right now.
Ryan Lortie [Mon, 19 Dec 2011 15:47:28 +0000 (10:47 -0500)]
Drop the GApplication menu test
Daniel Mustieles [Mon, 19 Dec 2011 16:13:11 +0000 (17:13 +0100)]
Updated Spanish translation
Giovanni Campagna [Sat, 17 Dec 2011 19:08:50 +0000 (20:08 +0100)]
gsettings-tool: allow specifying custom schema dirs
It happens that one wants to customize settings for plugins or
shell extensions, that installing schemas in nonstandard locations.
This patch adds the --schemadir option to gsettings, and ensure
that the appropriate schema is found.
https://bugzilla.gnome.org/show_bug.cgi?id=666415
Florian Müllner [Mon, 19 Dec 2011 13:52:10 +0000 (14:52 +0100)]
gdesktopappinfo: Use "Keywords" instead of "X-GNOME-Keywords"
The field has now been standardized, so drop the prefix.
Matthias Clasen [Mon, 19 Dec 2011 12:45:43 +0000 (07:45 -0500)]
Teach gtk-doc about G_GNUC_WARN_UNUSED_RESULT
Ryan Lortie [Sat, 17 Dec 2011 05:52:57 +0000 (00:52 -0500)]
GApplication: receiving end of GRemoteActionGroup
Use the fact that the action group exporter now speaks to
GRemoteActionGroup to get the platform data into GApplicion without
hacks.
https://bugzilla.gnome.org/show_bug.cgi?id=665737
Ryan Lortie [Sat, 17 Dec 2011 05:26:11 +0000 (00:26 -0500)]
action group exporter: kill GApplication hackery
Use the GRemoteActionGroup interface, if available, instead.
https://bugzilla.gnome.org/show_bug.cgi?id=665737
Ryan Lortie [Sat, 17 Dec 2011 05:17:08 +0000 (00:17 -0500)]
introduce GRemoteActionGroup
This interfaceifies the extra functions that were on GDBusActionGroup
for dealing with platform data.
The two main benefits of doing this:
- no longer have to do a silly song and dance in GApplication to avoid
calling GDBusActionGroup API from non-dbus-aware code
- the interface can be reused by the action group exporter to avoid
ugly and unbindable hook callbacks
https://bugzilla.gnome.org/show_bug.cgi?id=665737
Ryan Lortie [Sat, 17 Dec 2011 03:24:03 +0000 (22:24 -0500)]
GApplication: send platform data for actions again
Use the _full variants of the GDBusActionGroup API to send platform data
for action invocations once again.
Ryan Lortie [Sat, 17 Dec 2011 03:23:30 +0000 (22:23 -0500)]
GDBusActionGroup: add _full variants of activation
This allows the platform_data to be explicitly specified.
Ryan Lortie [Sat, 17 Dec 2011 02:25:57 +0000 (21:25 -0500)]
Revert "GDBusActionGroup: add static platform registration"
This reverts commit
fcc9902e98a6a6568a1150441c8680fd4615d437.
Ryan Lortie [Fri, 16 Dec 2011 16:39:24 +0000 (11:39 -0500)]
GApplication: emit signals on action changes
Now that we're a GActionMap the story about propagating signals from our
(now-constant) internal action group is vastly simplified. If someone
calls g_application_set_action_group() then signals will stop working --
but this function is deprecated and they never worked before, so no big
loss there.
https://bugzilla.gnome.org/show_bug.cgi?id=643736
Ryan Lortie [Thu, 15 Dec 2011 18:27:27 +0000 (13:27 -0500)]
windows XP threads: fix hilariously obvious race
I tried to do a double-checked lock without the double check.
Rodrigo Rivas Costa caught the problem and suggested the (obviously
correct) fix.
https://bugzilla.gnome.org/show_bug.cgi?id=666296
Ryan Lortie [Wed, 14 Dec 2011 18:31:27 +0000 (13:31 -0500)]
GDBusActionGroup: add static platform registration
We provide a mechanism by which a 'platform' (eg: Gtk) can register some
hook functions to be called to collect platform-data at the point of
sending an outgoing action activation request and also to inform the
platform of this data on incoming requests (before and after dispatching
the actual request).
This can be used for forwarding timestamp and startup-notification
information (as is presently done in GApplication) but the before/after
hook could also be used for acquiring/releasing the Gdk lock or other
similar things.
https://bugzilla.gnome.org/show_bug.cgi?id=665737
Ravi Sankar Guntur [Wed, 14 Dec 2011 14:47:54 +0000 (20:17 +0530)]
Added API g_queue_free_full().
g_queue_free_full(), to free a Queue including its dynamically-allocated elements.
On similar lines to List and Slist.
void g_queue_free_full (GQueue *queue, GDestroyNotify free_func);
Test case covering g_queue_free_full() is added.
Added export symbol to glib.symbols.
Closes Bug: https://bugzilla.gnome.org/show_bug.cgi?id=657433
Signed-off-by: Ravi Sankar Guntur <ravi.g@samsung.com>
Colin Walters [Thu, 15 Dec 2011 14:47:15 +0000 (09:47 -0500)]
GDBusActionGroup: Fix a typo in docs
Dan Winship [Wed, 14 Dec 2011 15:19:13 +0000 (10:19 -0500)]
configure.ac: robustify netlink.h check
https://bugzilla.gnome.org/show_bug.cgi?id=666173
Stef Walter [Fri, 9 Dec 2011 17:19:24 +0000 (18:19 +0100)]
GBytes: add a size argument to g_bytes_get_data
* An out size argument so that this is more easily bindable
by gobject-introspection.
https://bugzilla.gnome.org/show_bug.cgi?id=665879
Chris Coulson [Wed, 14 Dec 2011 14:00:56 +0000 (14:00 +0000)]
Initialize service_loop before running the service thread
Bug: https://bugzilla.gnome.org/show_bug.cgi?id=666129
Matthias Clasen [Thu, 15 Dec 2011 02:05:38 +0000 (21:05 -0500)]
menu markup: tolerate not having a hash table of objects
Various places in the code were assuming that the hash table was always
available. Fix this, and also avoid leaking strings now that the hash
table may be NULL.
Based on a patch by Simon McVittie, bug 666167
Simon McVittie [Wed, 14 Dec 2011 16:56:15 +0000 (16:56 +0000)]
g_array_free, g_ptr_array_free: decrement refcount if not the last ref
foo_free is conceptually "worth" one unref; not decrementing the
refcount here means the GArray or GPtrArray wrapper (but not its
contents) would leak in the following call sequence:
p = g_ptr_array_new ();
g_ptr_array_ref (p);
g_ptr_array_free (p, TRUE);
g_ptr_array_unref (p);
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Bug: https://bugzilla.gnome.org/show_bug.cgi?id=666113
Reviewed-by: Emmanuele Bassi <ebassi@linux.intel.com>
Simon McVittie [Wed, 14 Dec 2011 16:53:24 +0000 (16:53 +0000)]
GArray, GPtrArray: factor out the actual freeing
Depending how the array is freed, we may want to free the underlying
array (the "segment"), the struct wrapper or both.
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Bug: https://bugzilla.gnome.org/show_bug.cgi?id=666113
Reviewed-by: Emmanuele Bassi <ebassi@linux.intel.com>
Simon McVittie [Wed, 14 Dec 2011 16:46:56 +0000 (16:46 +0000)]
g_key_file_get_string_list: don't leak the pieces on error
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Bug: https://bugzilla.gnome.org/show_bug.cgi?id=666113
Reviewed-by: Emmanuele Bassi <ebassi@linux.intel.com>
Simon McVittie [Tue, 13 Dec 2011 18:18:27 +0000 (18:18 +0000)]
tls-interaction test: use a weak pointer instead of a deliberate use-after-free
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Bug: https://bugzilla.gnome.org/show_bug.cgi?id=666115
Reviewed-by: Dan Winship <danw@gnome.org>
Ryan Lortie [Wed, 14 Dec 2011 01:54:24 +0000 (20:54 -0500)]
gdbus tests: remove buggy use of GMainLoop
g_main_loop_quit() only quits mainloops that are currently running --
not ones that may run in the future. The way the gdbus-threading tests
are written can possibly result in a call to g_main_loop_quit() before
g_main_loop_run() has started.
The mainloops aren't actually used for anything other than signalling
the completion of the threads, so just use g_thread_join() for that.
https://bugzilla.gnome.org/show_bug.cgi?id=666129
Ryan Lortie [Wed, 14 Dec 2011 14:32:11 +0000 (09:32 -0500)]
two test fixes for ARM
First, some ARM systems are not fast enough to meet the 30 second
deadline in gwakeuptest.c, so increase that to 60.
Second, we have some signed/unsigned woes in the gparam transform tests.
Simon McVittie [Tue, 13 Dec 2011 18:18:07 +0000 (18:18 +0000)]
Plug some leaks in the GIO tests
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Bug: https://bugzilla.gnome.org/show_bug.cgi?id=666115
Reviewed-by: Matthias Clasen <mclasen@redhat.com>