angle-skia-autoroll [Tue, 22 May 2018 01:32:39 +0000 (01:32 +0000)]
Roll third_party/externals/angle2/
42cf958ce..
787338f9b (1 commit)
https://chromium.googlesource.com/angle/angle.git/+log/
42cf958ce8fa..
787338f9be51
$ git log
42cf958ce..
787338f9b --date=short --no-merges --format='%ad %ae %s'
2018-05-07 jgilbert Add headers to build file lists.
Created with:
roll-dep third_party/externals/angle2
The AutoRoll server is located here: https://angle-skia-roll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=allanmac@google.com
Change-Id: I27a743ad2e400a4bccbae04079323a02d7927674
Reviewed-on: https://skia-review.googlesource.com/129428
Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Kevin Lubick [Tue, 22 May 2018 01:17:15 +0000 (21:17 -0400)]
Fix FuzzCanvas - drawPath
Without this, our fuzzer would not be able to find
https://bugs.chromium.org/p/chromium/issues/detail?id=844457
on its own.
Bug: skia:
Change-Id: I61146242e9eca29821d13abfd6f777df2199df97
Reviewed-on: https://skia-review.googlesource.com/129502
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Herb Derby [Mon, 21 May 2018 20:10:17 +0000 (16:10 -0400)]
drawPosText no longer obeys paint alignment
Change-Id: Iac498b54dea4aa1b203d2b9c58e15bb5f2147f82
Reviewed-on: https://skia-review.googlesource.com/129462
Commit-Queue: Herb Derby <herb@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
Chris Dalton [Mon, 21 May 2018 15:10:53 +0000 (09:10 -0600)]
ccpr: Abstract the draws list in a separate class
Bug: skia:
Change-Id: I583c1bdc470e5830d041955d14b164fc00d5d014
Reviewed-on: https://skia-review.googlesource.com/129227
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
Mike Reed [Mon, 21 May 2018 20:50:01 +0000 (16:50 -0400)]
remove fragile hack in addOval to avoid computing bounds
Bug: skia:
Change-Id: Ide917f54633370f1fce46a115fa923794b981e2e
Reviewed-on: https://skia-review.googlesource.com/129461
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Reed <reed@google.com>
Herb Derby [Mon, 21 May 2018 17:46:38 +0000 (13:46 -0400)]
Simplify aligment for DFT drawText
The original code had to compensate for the alignment
that was passed in throught the paint. You can
simplifiy the code by just changing the paint to
left alignment.
Change-Id: I532ae5224ea5de078c6cd6255f03fc1db06baa83
Reviewed-on: https://skia-review.googlesource.com/129360
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Commit-Queue: Herb Derby <herb@google.com>
Herb Derby [Wed, 20 Sep 2017 15:56:00 +0000 (11:56 -0400)]
Remove sk_64_isS32 and sk_64_asS32
This is an API change. I assume that only Skia uses these routines.
Change-Id: Iefc98fa5c0b83eb4f52c478e345fd99121ecb254
Reviewed-on: https://skia-review.googlesource.com/129440
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
Kevin Lubick [Mon, 21 May 2018 19:47:14 +0000 (15:47 -0400)]
Make ASAN setup of Android bots more fault tolerant
Bug: skia:7975
Change-Id: I3f123337913870a921d1c09714873eaf2949e88f
Reviewed-on: https://skia-review.googlesource.com/129364
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Ben Wagner [Tue, 17 Apr 2018 21:42:08 +0000 (17:42 -0400)]
IWYU for tests starting with 'D'.
Change-Id: I9189e4b56ce1635b627119733447c2ed4220753d
Reviewed-on: https://skia-review.googlesource.com/129319
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
Mike Klein [Tue, 1 May 2018 14:36:42 +0000 (10:36 -0400)]
Reland "Retry enabling skcms on Android"
This is a reland of
05b5e40519ae18939867f8de5d48f7c7a173f745
Original change's description:
> Retry enabling skcms on Android
>
> Since we tried this last, DM has a direct skcms dependency
> via tests/ColorSpaceTest.cpp, so I've rearranged gn_to_bp.py slightly.
>
> We need to keep our eyes out for BitmapRGBAF16Test.testGetPixel in CTS.
>
> Change-Id: I3630bbebb4574522c43362c359d1a14da3bdd480
> Reviewed-on: https://skia-review.googlesource.com/124720
> Commit-Queue: Mike Klein <mtklein@google.com>
> Reviewed-by: Mike Klein <mtklein@google.com>
Change-Id: I67041fb00687f789c80b7ba41acd3bf2cf257cf3
Reviewed-on: https://skia-review.googlesource.com/126825
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
Brian Salomon [Mon, 21 May 2018 18:37:49 +0000 (14:37 -0400)]
Remove mask-filters and aa from SkPaint in SkCanvas for nine-patch/lattice.
Remove GPU fallback code which would have applied AA and mask filter
separately to each lattice cell.
Change-Id: I43d50f337d24bb34b94f3d0ea6cca686a2e11a50
Reviewed-on: https://skia-review.googlesource.com/129318
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Leon Scroggins <scroggo@google.com>
Ben Wagner [Mon, 21 May 2018 18:47:03 +0000 (14:47 -0400)]
Omit failing test.
Bug: skia:7046
Change-Id: Iea1ec862adedeabe05d227c0bd8e635e42fab27d
NoTry: true
Reviewed-on: https://skia-review.googlesource.com/129362
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Adrienne Walker [Mon, 21 May 2018 18:05:48 +0000 (11:05 -0700)]
Fix unit tests when workarounds are enabled
Change-Id: Ia660a6d91aa3615e0fa21fba67f5029c131b1ba2
Reviewed-on: https://skia-review.googlesource.com/128983
Commit-Queue: Adrienne Walker <enne@chromium.org>
Reviewed-by: Brian Salomon <bsalomon@google.com>
Greg Daniel [Thu, 3 May 2018 20:54:03 +0000 (16:54 -0400)]
Reland "Remove GrBackendObject and all related functions from Skia."
This is a reland of
ccd4cfc23ebbbecbc6b292359352aad335ad7b73
Original change's description:
> Remove GrBackendObject and all related functions from Skia.
>
> Bug: skia:
> Change-Id: I59434b7477c0bc26fd982bd81eb97ab94bbba073
> Reviewed-on: https://skia-review.googlesource.com/125822
> Reviewed-by: Brian Salomon <bsalomon@google.com>
> Commit-Queue: Greg Daniel <egdaniel@google.com>
Bug: skia:
Change-Id: Ibd1b9bd04b36840d9d872e2f0970dd6bac378bc9
Reviewed-on: https://skia-review.googlesource.com/129380
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
Brian Salomon [Mon, 21 May 2018 16:54:39 +0000 (12:54 -0400)]
Add perspective support to GrTextureOp.
Bug: skia:
Change-Id: Idea4ffae37dc2c2f339af60a2b74ded476091758
Reviewed-on: https://skia-review.googlesource.com/127600
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
Greg Daniel [Mon, 21 May 2018 17:48:03 +0000 (13:48 -0400)]
Move gn setup for vulkan library/headers into their own third_party directory.
Bug: skia:
Change-Id: I4605f0d962271efb77bf3c17f1b0daaaddfb51c8
Reviewed-on: https://skia-review.googlesource.com/128540
Commit-Queue: Greg Daniel <egdaniel@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
Cary Clark [Mon, 21 May 2018 15:56:57 +0000 (11:56 -0400)]
remove defines and add commas
Preparation for generating bookmaker files for all remaining
interfaces
Standardize enum and enum classes by including a comma after
the last entry.
Replace flatten-related #define in public interfaces
with their equivalent.
The motivation is to give documentation something to refer to.
An alternative would be to move part or all of this out of the
public interface; something I can work on in a follow-up CL.
R=reed@google.com,bsalomon@google.com
Bug: skia:6898
Change-Id: I4b865f6ec3d8f5d31e50448fef7d2714510302f0
Reviewed-on: https://skia-review.googlesource.com/129312
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Cary Clark <caryclark@skia.org>
skia-recreate-skps [Mon, 21 May 2018 15:34:43 +0000 (15:34 +0000)]
Update SKP version
Automatic commit by the RecreateSKPs bot.
TBR=rmistry@google.com
NO_MERGE_BUILDS
Change-Id: I86e4a692f30ef9f6455216c68602b88070d68e85
Reviewed-on: https://skia-review.googlesource.com/129331
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Herb Derby [Mon, 21 May 2018 14:47:13 +0000 (10:47 -0400)]
Add SkMakeUnique to gn
Change-Id: Ic1bee4551d471c4451837a93c14d49edc7c0f760
Reviewed-on: https://skia-review.googlesource.com/129314
Reviewed-by: Herb Derby <herb@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Herb Derby <herb@google.com>
Jim Van Verth [Mon, 21 May 2018 14:36:55 +0000 (10:36 -0400)]
Disable perspective for emoji fallback
Bug: skia:7562
Change-Id: Icc7182c8ae2ec403b2ea2659539d4f9561eddd02
Reviewed-on: https://skia-review.googlesource.com/113200
Commit-Queue: Jim Van Verth <jvanverth@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
Florin Malita [Mon, 21 May 2018 13:14:35 +0000 (09:14 -0400)]
Roll third_party/rapidjson to
af223d44f4e8d3772cb1ac0ce8bc2a132b51717f
Includes https://github.com/Tencent/rapidjson/pull/1261.
Bug: oss-fuzz:8301
Change-Id: I119dc65fe1f0176b26164589939c9c9bd476b3bb
Reviewed-on: https://skia-review.googlesource.com/129310
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Florin Malita <fmalita@chromium.org>
Greg Daniel [Thu, 3 May 2018 20:53:46 +0000 (16:53 -0400)]
Reland "Remove guard flag for SK_SUPPORT_LEGACY_BACKEND_OBJECTS on flutter."
This is a reland of
333031b921264508ca1869769c1021bc08e4e07a
Original change's description:
> Remove guard flag for SK_SUPPORT_LEGACY_BACKEND_OBJECTS on flutter.
>
> Bug: skia:
> Change-Id: I2c8c116f825278cae4001d169aaef42ce9a21873
> Reviewed-on: https://skia-review.googlesource.com/125725
> Commit-Queue: Greg Daniel <egdaniel@google.com>
> Reviewed-by: Brian Osman <brianosman@google.com>
> Reviewed-by: Robert Phillips <robertphillips@google.com>
Bug: skia:
Change-Id: Ibb8f89f1d3559a8484976f6a07f9a01d28394c48
Reviewed-on: https://skia-review.googlesource.com/129341
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
Cary Clark [Sun, 20 May 2018 23:15:43 +0000 (23:15 +0000)]
Revert "remove toString"
This reverts commit
5191880cbf3ee4d122b0d11b4945fbab0784fda7.
Reason for revert: broke flutter
Original change's description:
> remove toString
>
> toString may have been used by obsolete debugger only
> find out if that is so
>
> R=​brianosman@google.com,bsalomon@google.com
>
> Docs-Preview: https://skia.org/?cl=119894
> Bug:830651
> Change-Id: I737f19b7d3fbc869bea2f443fa3b5ed7c1393ffd
> Reviewed-on: https://skia-review.googlesource.com/119894
> Commit-Queue: Cary Clark <caryclark@google.com>
> Reviewed-by: Brian Salomon <bsalomon@google.com>
TBR=bsalomon@google.com,brianosman@google.com,caryclark@google.com,caryclark@skia.org
Change-Id: I9f81de6c3615ee0608bcea9081b77239b4b8816c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 830651
Reviewed-on: https://skia-review.googlesource.com/129340
Reviewed-by: Cary Clark <caryclark@google.com>
Commit-Queue: Cary Clark <caryclark@google.com>
Cary Clark [Fri, 18 May 2018 14:02:02 +0000 (10:02 -0400)]
remove toString
toString may have been used by obsolete debugger only
find out if that is so
R=brianosman@google.com,bsalomon@google.com
Docs-Preview: https://skia.org/?cl=119894
Bug:830651
Change-Id: I737f19b7d3fbc869bea2f443fa3b5ed7c1393ffd
Reviewed-on: https://skia-review.googlesource.com/119894
Commit-Queue: Cary Clark <caryclark@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
Brian Osman [Fri, 18 May 2018 20:59:13 +0000 (16:59 -0400)]
Add drawBitmapLattice to SkDebugCanvas
One more step to full coverage of SkCanvas API. (Also, it would be nice
to implement fromJSON for both lattice types, I'll attempt that in a
follow up CL).
Change-Id: I5fe55ca90b7859e40f5e8ec83bc12b7938674b60
Reviewed-on: https://skia-review.googlesource.com/129245
Reviewed-by: Joe Gregorio <jcgregorio@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Ravi Mistry [Sun, 20 May 2018 14:46:04 +0000 (10:46 -0400)]
Omit "espn" from key_mobile_sites_smooth in RecreateSKPs bot
We already have a espn page set in Skia. Removing it from the chromium page
set does not lose us coverage.
NoTry: true
Bug: skia:7917
Change-Id: Ie5456ee7f8053ad904eb858eddfe564e3781249a
Reviewed-on: https://skia-review.googlesource.com/129303
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
Roll third_party/externals/angle2/
78b7f3a8e..
42cf958ce (3 commits)
https://chromium.googlesource.com/angle/angle.git/+log/
78b7f3a8e813..
42cf958ce8fa
$ git log
78b7f3a8e..
42cf958ce --date=short --no-merges --format='%ad %ae %s'
2018-05-17 jmadill Make UNIMPLEMENTED a warning.
2018-05-17 jmadill dEQP: Use overload of CreateWindow.
2018-05-17 jmadill dEQP: Format display factory and clean up style.
Created with:
roll-dep third_party/externals/angle2
The AutoRoll server is located here: https://angle-skia-roll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=herb@google.com
Change-Id: I50cea3083e11fc547615cbc92b32e60c277ad889
Reviewed-on: https://skia-review.googlesource.com/129236
Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Roll third_party/externals/angle2/
a9ab0f37c..
78b7f3a8e (1 commit)
https://chromium.googlesource.com/angle/angle.git/+log/
a9ab0f37cf8f..
78b7f3a8e813
$ git log
a9ab0f37c..
78b7f3a8e --date=short --no-merges --format='%ad %ae %s'
2018-05-18 lfy GLES1: New packed enums for materials and lighting
Created with:
roll-dep third_party/externals/angle2
The AutoRoll server is located here: https://angle-skia-roll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=herb@google.com
Change-Id: I914e6378546fa11911cac14d67b695b6faa86b23
Reviewed-on: https://skia-review.googlesource.com/129234
Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Roll third_party/externals/angle2/
8688bf46f..
a9ab0f37c (4 commits)
https://chromium.googlesource.com/angle/angle.git/+log/
8688bf46f183..
a9ab0f37cf8f
$ git log
8688bf46f..
a9ab0f37c --date=short --no-merges --format='%ad %ae %s'
2018-05-17 lucferron Vulkan: Fix DynamicBuffer usages, need to use specific alignment
2018-05-10 geofflang Don't make redundant calls to Display::makeCurrent.
2018-05-18 jmadill Documentation maintenance.
2018-05-18 lucferron Revert "Vulkan: readPixels improvement - use DynamicBuffer"
Created with:
roll-dep third_party/externals/angle2
The AutoRoll server is located here: https://angle-skia-roll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=herb@google.com
Change-Id: Ia2199cfb46c19d850a3244b7064f4e1f27de5fe4
Reviewed-on: https://skia-review.googlesource.com/129232
Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Mike Reed [Fri, 18 May 2018 20:29:11 +0000 (16:29 -0400)]
harden line2d effect
Suggested by https://fuzzer.skia.org/category/n32_canvas/file/c3JjL2NvcmUvU2tTdHJva2UuY3Bw?
Bug: skia:
Change-Id: I8ec48f844bfa5d063f0ab1bdfe0612ec4673ada3
Reviewed-on: https://skia-review.googlesource.com/129260
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Mike Reed <reed@google.com>
Herb Derby [Fri, 18 May 2018 19:09:41 +0000 (15:09 -0400)]
Add rules for cmake 3.11 to not error
As of cmake 3.11, the add_library target must have sources
associated with it. If there are sources, just compile
the file empty.cpp.
Change-Id: I7fec03dc0f0d2e6098572ed6e9fcdfaac3811024
Reviewed-on: https://skia-review.googlesource.com/129189
Commit-Queue: Herb Derby <herb@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
Mike Reed [Fri, 18 May 2018 18:07:57 +0000 (14:07 -0400)]
tweak conservative bounds value to save aberrant cubic
Bug: 844457
Change-Id: Ia3c7c0592df59022cf04f6747b1fe30975431ea4
Reviewed-on: https://skia-review.googlesource.com/129200
Reviewed-by: Cary Clark <caryclark@google.com>
Commit-Queue: Mike Reed <reed@google.com>
Timothy Liang [Fri, 18 May 2018 18:38:19 +0000 (14:38 -0400)]
added global variable and multi-texture support to metal sksl backend
Bug: skia:
Change-Id: If676774ec0a30c5b536ccffbff2220d180b7fa59
Reviewed-on: https://skia-review.googlesource.com/129187
Commit-Queue: Timothy Liang <timliang@google.com>
Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
Robert Phillips [Fri, 18 May 2018 16:43:27 +0000 (12:43 -0400)]
Fix fuzzer bug i.e., compute the correct repeated dst domain
BUG: oss-fuzz:8367
Change-Id: Ib5a9bf6e8446459db88016176e4c22397a3f1965
Reviewed-on: https://skia-review.googlesource.com/129184
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
Brian Salomon [Fri, 18 May 2018 16:32:32 +0000 (12:32 -0400)]
Use inheritance to define TextureGeometryProcesor vertex structs
Change-Id: Ibddc994e6b5599ab20a6f3d81dfe9c6644fb1f69
Reviewed-on: https://skia-review.googlesource.com/129183
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
Brian Salomon [Fri, 18 May 2018 16:52:22 +0000 (12:52 -0400)]
Add convenience overload of SkPointPriv::SetRectTriStrip that takes SkRect
Change-Id: Idf5bfafaf19c20f074f12d706b8b8984c5935e6d
Reviewed-on: https://skia-review.googlesource.com/129185
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
Stephen White [Fri, 18 May 2018 15:49:21 +0000 (11:49 -0400)]
GrTessellator: fix for zombie edge fuzzer crash.
While splitting one edge, merge_collinear_edges() may in rare cases
merge the other edge of the intersection out of existence.
split_edge() then brings these dead edges partially back to life,
leaving the mesh in an inconsistent state.
The fix is to null out the top and bottom pointers of dead edges to
mark them as dead, and only split living edges.
Bug: skia:7911
Change-Id: I1c0b59581acfcd0b8191f2d129b33f7d0d1a2516
Reviewed-on: https://skia-review.googlesource.com/129181
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Stephen White <senorblanco@chromium.org>
Ben Wagner [Mon, 14 Aug 2017 15:06:12 +0000 (11:06 -0400)]
Add BOOK and DEMI_LIGHT.
It would be nice to use FcWeightToOpenType but this was buggy until
2.12.4.
Change-Id: Ifcf9bfc783ea63c684bedb2a22267e97461d4945
Reviewed-on: https://skia-review.googlesource.com/129182
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
Adrienne Walker [Thu, 17 May 2018 18:37:14 +0000 (11:37 -0700)]
Driver bug workaround: unbind_attachments_on_bound_render_fbo_delete
Bug: chromium: 829614
Change-Id: Ic6bc276d1203d24f96fe92b41655871e25f69623
Reviewed-on: https://skia-review.googlesource.com/128395
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Adrienne Walker <enne@chromium.org>
Kevin Lubick [Fri, 18 May 2018 15:32:33 +0000 (11:32 -0400)]
Prevent SkMatrixConvolutionImageFilter from allocating large buffers it can't fill
Bug: skia:7937
Change-Id: I71a5673939b3d91864a4b788e1e3a520b0ee04dd
Reviewed-on: https://skia-review.googlesource.com/129179
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Mike Reed [Fri, 18 May 2018 15:48:50 +0000 (11:48 -0400)]
validate perlin inputs
Bug: oss-fuzz:8359
Change-Id: Ib539c8549f2e00d6b0da099f48c4084d2bfbefd8
Reviewed-on: https://skia-review.googlesource.com/129180
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
Cary Clark [Fri, 18 May 2018 15:57:17 +0000 (11:57 -0400)]
fix bookmaker typo
Fix one character and update the web documentation.
Docs-Preview: https://skia.org/?cl=128938
TBR=robertphillips@google.com
Bug: skia:6898
Change-Id: I4525ef8d3bae85ef1d63f84ff414a32b9935ae0e
Reviewed-on: https://skia-review.googlesource.com/128938
Reviewed-by: Cary Clark <caryclark@skia.org>
Commit-Queue: Cary Clark <caryclark@skia.org>
Auto-Submit: Cary Clark <caryclark@skia.org>
Roll third_party/externals/angle2/
4607148c6..
8688bf46f (1 commit)
https://chromium.googlesource.com/angle/angle.git/+log/
4607148c6be3..
8688bf46f183
$ git log
4607148c6..
8688bf46f --date=short --no-merges --format='%ad %ae %s'
2018-05-18 lucferron Vulkan: readPixels improvement - use DynamicBuffer
Created with:
roll-dep third_party/externals/angle2
The AutoRoll server is located here: https://angle-skia-roll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=herb@google.com
Change-Id: Ica913fa2f0036a43260525ec5b036e5e7f90226b
Reviewed-on: https://skia-review.googlesource.com/129146
Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
swiftshader-skia-autoroll [Fri, 18 May 2018 15:09:46 +0000 (15:09 +0000)]
Roll third_party/externals/swiftshader/
607771b44..
cbb80f5f0 (1 commit)
https://swiftshader.googlesource.com/SwiftShader/+log/
607771b44474..
cbb80f5f0078
$ git log
607771b44..
cbb80f5f0 --date=short --no-merges --format='%ad %ae %s'
2018-05-17 krzysio Accept GL_TEXTURE_MAX_ANISOTROPY_EXT for samplers.
Created with:
roll-dep third_party/externals/swiftshader
The AutoRoll server is located here: https://swiftshader-skia-roll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-CPU-AVX2-x86_64-Debug-All-SwiftShader
TBR=herb@google.com
Change-Id: Id1bc594cff9f77e9f51ff84ca093e57765fdd9b7
Reviewed-on: https://skia-review.googlesource.com/129149
Commit-Queue: swiftshader-skia-autoroll <swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: swiftshader-skia-autoroll <swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Brian Salomon [Fri, 18 May 2018 14:29:54 +0000 (10:29 -0400)]
Modifications to GrTextureOp outsetting, edge equation code.
Factor out to its own function to be reused with perspective.
Avoid initial shuffles to fan order using nextCW and nextCCW helpers that
assume tri strip order.
Make sign test stay in 4f.
Use fmas.
Change-Id: I60cff205f6193c4e01ea84218812a663ce74038f
Reviewed-on: https://skia-review.googlesource.com/129175
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
Ben Wagner [Fri, 7 Oct 2016 19:50:53 +0000 (15:50 -0400)]
Make SkStream readers report failure.
This also fixes an issue noticed while making this change where
SkFontDescriptor improperly round trips negative axis values.
Change-Id: Iacc5929a185659dcacc18c802c4908e4f34c6899
Reviewed-on: https://skia-review.googlesource.com/128341
Commit-Queue: Ben Wagner <bungeman@google.com>
Reviewed-by: Leon Scroggins <scroggo@google.com>
Robert Phillips [Fri, 18 May 2018 14:19:05 +0000 (10:19 -0400)]
Add SkIRect::adjust method
Change-Id: Ib18d1a82944524e20d5d72912d8db7a823c470de
Reviewed-on: https://skia-review.googlesource.com/128884
Commit-Queue: Robert Phillips <robertphillips@google.com>
Reviewed-by: Cary Clark <caryclark@google.com>
Eric Boren [Fri, 18 May 2018 13:54:02 +0000 (09:54 -0400)]
[recipes] Remove a bunch of unnecessary expectations
Bug: skia:6473
Change-Id: Ic2eee8074476c449cc9bed4701105609e91ea12b
Reviewed-on: https://skia-review.googlesource.com/128929
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Joe Gregorio [Fri, 18 May 2018 13:02:48 +0000 (09:02 -0400)]
[skiaserver] Start loading html/css/js from https://debugger-assets.skia.org.
Also clean up quoting and fix a hard-coded URL to https://debugger.skia.org.
Bug: skia:
Change-Id: I31283f3769c81a138d82c03214f005c7fb82c5b2
Reviewed-on: https://skia-review.googlesource.com/129164
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Joe Gregorio <jcgregorio@google.com>
Robert Phillips [Fri, 18 May 2018 13:29:27 +0000 (09:29 -0400)]
Fix bugs related to SkMatrixConvolutionImageFilter in repeat mode
This should fix most of the fuzzer complaints
Change-Id: I47a616e78b47bd162cbef647b03f5c1f23017c6f
Reviewed-on: https://skia-review.googlesource.com/129165
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
Eric Boren [Fri, 18 May 2018 11:36:55 +0000 (07:36 -0400)]
[recipes] Move a lot of logic out of vars module
In general, vars should only contain variables which are the same for
all tasks. Variables specific to compilation belong in the build
module (or compile recipe), and those specific to running tests belong
in the flavor module, or the individual recipe which uses them.
Bug: skia:6473
Change-Id: Ifd55a57118c5801e6f4934a6b5de9d1567415b9a
Reviewed-on: https://skia-review.googlesource.com/128545
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Chris Dalton [Fri, 18 May 2018 03:45:25 +0000 (21:45 -0600)]
Add proxy unique key management to GrOnFlushResourceProvider
Bug: skia:
Change-Id: I0c462e282ea6d78f22340546c03b357f1ba7666f
Reviewed-on: https://skia-review.googlesource.com/129140
Commit-Queue: Robert Phillips <robertphillips@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
Roll third_party/externals/angle2/
1ce8aede0..
4607148c6 (4 commits)
https://chromium.googlesource.com/angle/angle.git/+log/
1ce8aede0043..
4607148c6be3
$ git log
1ce8aede0..
4607148c6 --date=short --no-merges --format='%ad %ae %s'
2018-05-15 courtneygo Add build-id for all builds to help debugging
2018-05-17 courtneygo Format cleanup
2018-05-17 ynovikov Revert "Vulkan: readPixels improvement - use DynamicBuffer"
2018-05-15 lucferron Vulkan: readPixels improvement - use DynamicBuffer
Created with:
roll-dep third_party/externals/angle2
The AutoRoll server is located here: https://angle-skia-roll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=herb@google.com
Change-Id: I5426450c2e0fc6f4b6584ac7ed70b18e3ac38581
Reviewed-on: https://skia-review.googlesource.com/129122
Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
swiftshader-skia-autoroll [Thu, 17 May 2018 21:45:45 +0000 (21:45 +0000)]
Roll third_party/externals/swiftshader/
419a5806a..
607771b44 (1 commit)
https://swiftshader.googlesource.com/SwiftShader/+log/
419a5806a9ff..
607771b44474
$ git log
419a5806a..
607771b44 --date=short --no-merges --format='%ad %ae %s'
2018-05-08 capn Prevent 32-bit numeric overflow on image allocation.
Created with:
roll-dep third_party/externals/swiftshader
The AutoRoll server is located here: https://swiftshader-skia-roll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-CPU-AVX2-x86_64-Debug-All-SwiftShader
TBR=herb@google.com
Change-Id: Ia1373841ed2db63eb726701f606b6e6c9e22b345
Reviewed-on: https://skia-review.googlesource.com/128997
Commit-Queue: swiftshader-skia-autoroll <swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: swiftshader-skia-autoroll <swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Mike Klein [Thu, 17 May 2018 21:06:05 +0000 (17:06 -0400)]
refactor setBoundsCheck() a bit
This doesn't change anything practical, but makes sure setBoundsCheck()
and setBoundsNoCheck() run through the same logic.
Bug: skia:7967
Change-Id: Ic78e2ebd5ebf46d6251c84ba93dcd397a97816fc
Reviewed-on: https://skia-review.googlesource.com/129060
Auto-Submit: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Mike Reed <reed@google.com>
swiftshader-skia-autoroll [Thu, 17 May 2018 21:04:45 +0000 (21:04 +0000)]
Roll third_party/externals/swiftshader/
89c43d202..
419a5806a (2 commits)
https://swiftshader.googlesource.com/SwiftShader/+log/
89c43d202302..
419a5806a9ff
$ git log
89c43d202..
419a5806a --date=short --no-merges --format='%ad %ae %s'
2018-05-08 capn Refactor surface buffer size calculation.
2018-05-08 capn Refactor maximum texture dimensions.
Created with:
roll-dep third_party/externals/swiftshader
The AutoRoll server is located here: https://swiftshader-skia-roll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-CPU-AVX2-x86_64-Debug-All-SwiftShader
TBR=herb@google.com
Change-Id: Ied9e8682161980e45f6bf7f66297b5a0c6416f4d
Reviewed-on: https://skia-review.googlesource.com/128995
Commit-Queue: swiftshader-skia-autoroll <swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: swiftshader-skia-autoroll <swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
recipe-roller [Thu, 17 May 2018 20:37:42 +0000 (13:37 -0700)]
Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
https://crrev.com/
8fe4d8cbef3bff9d615de14d9a414679cf9ca8c3 gclient: Actually fix roll-dep. (ehmaldonado@chromium.org)
TBR=borenet@google.com
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I78e4093faa596bc197e9777aad7d851e7b5e9d85
Reviewed-on: https://skia-review.googlesource.com/129040
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Khushal [Thu, 17 May 2018 17:41:40 +0000 (10:41 -0700)]
fonts: Handle fallback to using paths for text rendering for remoting.
SkRemoteGlyphCache only sends images for glyphs, even for cases where
the gpu falls back to drawing text as paths. This includes cases in
SkDraw::ShouldDrawTextAsPaths and when the glyph exceeds the max bounds
that can fit on the atlas. Fix this by identifying these cases in the
renderer and sending paths instead.
Note: We still don't handle distance field text correctly.
R=herb@google.com, bsalomon@google.com
Bug: skia:7913
Change-Id: I17d4eccbeaa2e995ae67b61c76cebd27f8280329
Reviewed-on: https://skia-review.googlesource.com/128203
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Khusal Sagar <khushalsagar@chromium.org>
Ben Wagner [Thu, 17 May 2018 15:58:38 +0000 (11:58 -0400)]
Remove SK_IGNORE_SKIMAGE_ONREFENCODED_CHANGE.
All implementers have been updated, so remove the flag and old code.
Change-Id: Ie9747f37dd0ea3f1db682891bcae2496a470bc3a
Reviewed-on: https://skia-review.googlesource.com/128883
Reviewed-by: Leon Scroggins <scroggo@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
Khushal [Wed, 16 May 2018 23:07:24 +0000 (16:07 -0700)]
fonts: Use empty glyphs on cache miss.
In case of a cache miss, we end up using a glyph with garbage memory
which can result in arbitrary memory allocations for generating images
for these glyphs. Use empty glyphs instead.
R=herb@google.com
Bug: skia:7913
Change-Id: Ie81b006a6872e077f9fd37e0a5751750c66f9ecb
Reviewed-on: https://skia-review.googlesource.com/128701
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Khusal Sagar <khushalsagar@chromium.org>
Roll skia/third_party/skcms
3e527c6..
5bfec77 (1 commits)
https://skia.googlesource.com/skcms.git/+log/
3e527c6..
5bfec77
2018-05-17 mtklein@chromium.org rm GaussNewton.[ch]
The AutoRoll server is located here: https://skcms-skia-roll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=herb@google.com
Change-Id: Idf7e24d60750f69db9d09a71e9665073380b8912
Reviewed-on: https://skia-review.googlesource.com/128987
Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cary Clark [Thu, 17 May 2018 19:16:57 +0000 (15:16 -0400)]
fix setBoundsNoCheck example
fix setBoundsNoCheck example
R=caryclark@google.com
Docs-Preview: https://skia.org/?cl=129000
Bug: skia:6898
Change-Id: Ic7ad412089bf21fd4de93f3acbeb50c7efc30a81
Reviewed-on: https://skia-review.googlesource.com/129000
Reviewed-by: Cary Clark <caryclark@skia.org>
Commit-Queue: Cary Clark <caryclark@skia.org>
Auto-Submit: Cary Clark <caryclark@skia.org>
Kevin Lubick [Thu, 17 May 2018 18:35:43 +0000 (14:35 -0400)]
Specify the ADB keys to use for ADB
In the golo, specifically, the adb keys used by swarming
are different than those used in the docker instance, unless
configured otherwise.
This means swarming can think a device is ready (authorized)
but the adb we called was not (authorized)
BUG: 843284
Change-Id: I697d5075258a176e7fc7a4b51a9e2c926e1b8fd0
Reviewed-on: https://skia-review.googlesource.com/128930
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Roll skia/third_party/skcms
3f444c5..
3e527c6 (1 commits)
https://skia.googlesource.com/skcms.git/+log/
3f444c5..
3e527c6
2018-05-17 brianosman@google.com Added skcms_AreApproximateInverses(Curve, TransferFunction)
The AutoRoll server is located here: https://skcms-skia-roll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=herb@google.com
Change-Id: Ia10c2fe8dc17972b8e5570819ff6ac197f4d77f8
Reviewed-on: https://skia-review.googlesource.com/128984
Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
recipe-roller [Thu, 17 May 2018 18:18:06 +0000 (11:18 -0700)]
Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
https://crrev.com/
b496b6a0570bd4c9be2c1034ae1b5ae4360b327b gclient: Fix roll-dep. (ehmaldonado@chromium.org)
TBR=borenet@google.com
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ib1c636a7657412e3a45fbcfc20b6b4eb5bd069bb
Reviewed-on: https://skia-review.googlesource.com/128933
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Roll skia/third_party/skcms
06d773b..
3f444c5 (1 commits)
https://skia.googlesource.com/skcms.git/+log/
06d773b..
3f444c5
2018-05-17 mtklein@chromium.org rm skcms_PolyTF and skcms_OptimizeForSpeed()
The AutoRoll server is located here: https://skcms-skia-roll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=herb@google.com
Change-Id: Ibdab92aa3d3cd9cc478623051ad1abb915765a7e
Reviewed-on: https://skia-review.googlesource.com/128981
Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Roll skia/third_party/skcms
14afdb8..
06d773b (1 commits)
https://skia.googlesource.com/skcms.git/+log/
14afdb8..
06d773b
2018-05-17 mtklein@chromium.org add android.fp16 build
The AutoRoll server is located here: https://skcms-skia-roll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=herb@google.com
Change-Id: Iba574756d324fb12f2091a9af6d5f4da4a8b8f7d
Reviewed-on: https://skia-review.googlesource.com/128965
Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Chris Dalton [Thu, 17 May 2018 16:17:10 +0000 (10:17 -0600)]
Add MoltenVK_Vulkan bots
Adds a prebuilt MoltenVK framework asset from:
KhronosGroup/MoltenVK.git:
0279543e0bb561f8d0166d4030481136bc914fec
And creates bots that use it.
Bug: skia:
Change-Id: I081b2745c41a25de9ecd94a5363f4fb13b120215
Reviewed-on: https://skia-review.googlesource.com/128646
Commit-Queue: Chris Dalton <csmartdalton@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Roll third_party/externals/angle2/
0e1c158ed..
1ce8aede0 (1 commit)
https://chromium.googlesource.com/angle/angle.git/+log/
0e1c158ed0e6..
1ce8aede0043
$ git log
0e1c158ed..
1ce8aede0 --date=short --no-merges --format='%ad %ae %s'
2018-05-17 jmadill dEQP: Shorten test case names.
Created with:
roll-dep third_party/externals/angle2
The AutoRoll server is located here: https://angle-skia-roll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=herb@google.com
Change-Id: If6e173ca3092ee1bd938eb3c30e87fed54fa78bc
Reviewed-on: https://skia-review.googlesource.com/128961
Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Jim Van Verth [Thu, 17 May 2018 16:33:52 +0000 (12:33 -0400)]
Check for correct bounds of large rotated and skewed emoji.
Bug: skia:7879
Change-Id: I039ca9d216c3a9a913f5dd5f63d7f01de3abfdc8
Reviewed-on: https://skia-review.googlesource.com/128923
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>
Roll skia/third_party/skcms
e4c0e54..
14afdb8 (1 commits)
https://skia.googlesource.com/skcms.git/+log/
e4c0e54..
14afdb8
2018-05-17 mtklein@chromium.org bump package versions on skcms tree
The AutoRoll server is located here: https://skcms-skia-roll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=herb@google.com
Change-Id: Ic9cfb0c2fddca3e0ab3aca06f48af3fd94d3c5c5
Reviewed-on: https://skia-review.googlesource.com/128962
Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Robert Phillips [Thu, 17 May 2018 15:17:39 +0000 (11:17 -0400)]
Fix srcBounds computation in SkMatrixConvolutionImageFilter
Note that this does change the behavior of the cropRect for the repeated case. The cropRect now only acts as a hard clip on the output.
BUG= skia:7766
Change-Id: I1d66678bc797cd4835701cd20c36e68b22ac880a
Reviewed-on: https://skia-review.googlesource.com/127338
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
Cary Clark [Thu, 17 May 2018 16:17:28 +0000 (12:17 -0400)]
Color Documentation
- treat Color, ARGB, etc as things not requiring definitions
- fix links to Anti-alias, RGB-565
- finish everything marked incomplete, color and elsewhere
- add #Code blocks for #Typedef
R=caryclark@google.com
Docs-Preview: https://skia.org/?cl=128547
Bug: skia:6898
Change-Id: Icf12fe70bc2bf1a8b1a5b31380b2454610949f23
Reviewed-on: https://skia-review.googlesource.com/128547
Reviewed-by: Cary Clark <caryclark@skia.org>
Commit-Queue: Cary Clark <caryclark@skia.org>
Auto-Submit: Cary Clark <caryclark@skia.org>
recipe-roller [Thu, 17 May 2018 15:57:44 +0000 (08:57 -0700)]
Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
https://crrev.com/
4727c64750e84e093a8046384fb0d1f0fbb2b339 gclient: Fix getdep and setdep and add tests. (ehmaldonado@chromium.org)
TBR=borenet@google.com
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ib044ca18ad05a485c779f94cf32484ce826bd731
Reviewed-on: https://skia-review.googlesource.com/128882
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Kevin Lubick [Thu, 17 May 2018 15:29:10 +0000 (11:29 -0400)]
Return nullptr when ReadBuffer becomes invalid
This especially helps in SkDrawLooper because we can bail out early
instead of looping for a potentially long time, e.g. when fuzzed
input says count is a large number.
This also cleans up validate in a few spots, and adds validateCanReadN
as a helper function.
Bug: skia:7937
Change-Id: Ic5eff357c8cadc91eeafc6e39c78c570ba74df2f
Reviewed-on: https://skia-review.googlesource.com/128847
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Brian Salomon [Thu, 17 May 2018 14:42:14 +0000 (10:42 -0400)]
Rewrite GrQuad to use separate arrays of x and y values to be Sk4f friendly.
Change-Id: Ie2ad197c5f17849fe6e034b60bc7ec18a00edb24
Reviewed-on: https://skia-review.googlesource.com/128842
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
Timothy Liang [Thu, 17 May 2018 14:40:04 +0000 (10:40 -0400)]
added basic texturing to metal sksl backend
Bug: skia:
Change-Id: I2e70efe53f5c2fb208979cc89be9c3c841944a48
Reviewed-on: https://skia-review.googlesource.com/128844
Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
Commit-Queue: Timothy Liang <timliang@google.com>
Mike Reed [Thu, 17 May 2018 14:11:31 +0000 (10:11 -0400)]
check path bounds before trying to shadow
Bug: oss-fuzz:8331
Change-Id: Idbff0deb0b9968edf4b4fafd4cf497bbb71c64fa
Reviewed-on: https://skia-review.googlesource.com/128550
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Commit-Queue: Mike Reed <reed@google.com>
Ben Wagner [Thu, 17 May 2018 13:47:30 +0000 (09:47 -0400)]
Remove static initializer to register destructor.
Skia cannot have global sk_sp objects because they will register an exit
time destructor which will be done through a static initializer.
BUG=chromium:843858
Change-Id: I43e3d18c9d8b50ff067414148c7524bffd3523da
Reviewed-on: https://skia-review.googlesource.com/128843
Auto-Submit: Ben Wagner <bungeman@google.com>
Commit-Queue: Herb Derby <herb@google.com>
Reviewed-by: Herb Derby <herb@google.com>
Ben Wagner [Wed, 16 May 2018 19:20:06 +0000 (15:20 -0400)]
Set margin for outer blur masks with no blur.
The margin of a mask filter is intended to be the additional src region
which the mask filter will take into account when creating the dst (a
region which will be assumed to be fully transparent around the src).
In the event there is an outer blur with no effective blur the src does
not need to be considered at all since the outcome will always be an
empty mask. The 'margin' is then effectively -inf in all directions, but
currently users of margin expect the value to come back non-negative.
This sets the margin in this case to 0 to allow the users to do their
work and then the filter will simply discard that work.
Currently the margin is not being set at all, leading to undefined
behavior. In the future the users of mask filters need to be able to
handle negative margins and there needs to be a way for the mask filter
to signal that it will disregard any src image.
BUG=oss-fuzz:8332
Change-Id: Ia9d1711b8c68142134bb6d393de17b9abaf7b23a
Reviewed-on: https://skia-review.googlesource.com/128683
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
Cary Clark [Thu, 17 May 2018 01:28:55 +0000 (21:28 -0400)]
mapRect should not fiddle with nonfinite values.
Docs-Preview: https://skia.org/?cl=128682
Bug: skia:7967
Change-Id: Ic43387b7705ee8385b8df2430886484ff856077c
Reviewed-on: https://skia-review.googlesource.com/128682
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
recipe-roller [Thu, 17 May 2018 06:27:33 +0000 (23:27 -0700)]
Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
https://crrev.com/
16f4bad9148c587a0254988138e713df72b035b7 gclient: Merge hook_os with hooks and deps_os with os. (ehmaldonado@chromium.org)
https://crrev.com/
ed1bb34fc59e5539ea29def4d68cd94a8e17e71b gclient: Remove condition_value. (ehmaldonado@chromium.org)
https://crrev.com/
23a358764dd8cd61e7d6efe086fb51c78ae0ac9b gclient: Fix for extra custom_deps. (ehmaldonado@chromium.org)
TBR=borenet@google.com
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I4ba63046af4d1d1824c7e8850ef46103b1de781d
Reviewed-on: https://skia-review.googlesource.com/128740
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Roll third_party/externals/angle2/
f299a378f..
0e1c158ed (2 commits)
https://chromium.googlesource.com/angle/angle.git/+log/
f299a378f1e6..
0e1c158ed0e6
$ git log
f299a378f..
0e1c158ed --date=short --no-merges --format='%ad %ae %s'
2018-05-16 ynovikov Log error of RegisterClassA in DisplayWGL::initialize
2018-05-16 ynovikov Revert "Don't double-terminate a display."
Created with:
roll-dep third_party/externals/angle2
The AutoRoll server is located here: https://angle-skia-roll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=herb@google.com
Change-Id: I75978b3ebb3f0cdd87a367f41c2e045aa2af689b
Reviewed-on: https://skia-review.googlesource.com/128720
Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Roll skia/third_party/skcms
5cc905d..
e4c0e54 (1 commits)
https://skia.googlesource.com/skcms.git/+log/
5cc905d..
e4c0e54
2018-05-16 brianosman@google.com Add lerping to skcms_eval_curve
The AutoRoll server is located here: https://skcms-skia-roll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=herb@google.com
Change-Id: Ie44a66826197489e499a2ce7dcbba8592a43973f
Reviewed-on: https://skia-review.googlesource.com/128650
Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
swiftshader-skia-autoroll [Wed, 16 May 2018 20:45:45 +0000 (20:45 +0000)]
Roll third_party/externals/swiftshader/
c8403ec14..
89c43d202 (1 commit)
https://swiftshader.googlesource.com/SwiftShader/+log/
c8403ec14aaf..
89c43d202302
$ git log
c8403ec14..
89c43d202 --date=short --no-merges --format='%ad %ae %s'
2018-05-15 capn Ignore glGenerateMipmap for unspecified or zero-sized textures.
Created with:
roll-dep third_party/externals/swiftshader
The AutoRoll server is located here: https://swiftshader-skia-roll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-CPU-AVX2-x86_64-Debug-All-SwiftShader
TBR=herb@google.com
Change-Id: I3c12b97d4f57176d10e1a10a92c4aa8f76ca39d1
Reviewed-on: https://skia-review.googlesource.com/128657
Commit-Queue: swiftshader-skia-autoroll <swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: swiftshader-skia-autoroll <swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Roll third_party/externals/angle2/
80c32ccbb..
f299a378f (6 commits)
https://chromium.googlesource.com/angle/angle.git/+log/
80c32ccbbcc6..
f299a378f1e6
$ git log
80c32ccbb..
f299a378f --date=short --no-merges --format='%ad %ae %s'
2018-05-14 lucferron Vulkan: Implement copyImage and enable all tests for it
2018-05-14 lucferron Vulkan: Finish implementation of the copySubImage
2018-05-14 lucferron Vulkan: Implement PACK_STATE dirty bit and remove warning
2018-05-16 jmadill dEQP: Implement --deqp-case for GTest.
2018-05-10 lucferron Vulkan: Basic support of copySubImage
2018-05-15 geofflang Add more dEQP EGL expectations for Linux and Android.
Created with:
roll-dep third_party/externals/angle2
The AutoRoll server is located here: https://angle-skia-roll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=herb@google.com
Change-Id: I406b94873c427557c759279cf3e288d01aec1b6b
Reviewed-on: https://skia-review.googlesource.com/128654
Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
recipe-roller [Wed, 16 May 2018 20:07:50 +0000 (13:07 -0700)]
Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
https://crrev.com/
babd098f3684f1bc965a0f72f96cb701eec91e52 gclient: Simplify GetScmName and CreateSCM. (ehmaldonado@chromium.org)
https://crrev.com/
cbf0204555fe07fda96d20456e03f105e2922005 do not try collecting issues information for an empty issues list (vbendeb@chromium.org)
https://crrev.com/
8de3800ce55ba459ffcbedcfa52ef5e6e59caab6 print access errors separately (vbendeb@chromium.org)
https://crrev.com/
3f0591d4f12991ed39bae2dca96d3593879be382 Reland "bot_update: Patch on gclient by default." (ehmaldonado@chromium.org)
TBR=borenet@google.com
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Id709515589c521a2896f4ecbf50385b936773930
Reviewed-on: https://skia-review.googlesource.com/128686
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Brian Osman [Wed, 16 May 2018 19:58:31 +0000 (15:58 -0400)]
Suppress bad-function-cast warning
Bug: skia:
Change-Id: Ic5efe371b6365913a47d833c698958cc842d16ae
Reviewed-on: https://skia-review.googlesource.com/128685
Commit-Queue: Brian Osman <brianosman@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
Auto-Submit: Brian Osman <brianosman@google.com>
Reviewed-by: Mike Klein <mtklein@chromium.org>
Adrienne Walker [Tue, 15 May 2018 20:03:13 +0000 (13:03 -0700)]
Driver bug workaround: pack_parameters_workaround_with_pack_buffer
Bug: chromium: 829614
Change-Id: I3fae2b4181e4a6e37fb31fe2f2e9a6cfacb1860f
Reviewed-on: https://skia-review.googlesource.com/128206
Commit-Queue: Adrienne Walker <enne@chromium.org>
Reviewed-by: Brian Salomon <bsalomon@google.com>
Jim Van Verth [Wed, 16 May 2018 18:54:41 +0000 (14:54 -0400)]
Fix check for valid proxies returned by AtlasManager.
Also renames a lot of variables to make it clearer that getProxies()
returns the number of instantiated proxies, not the number of all
proxies.
Bug: skia:
Change-Id: Ifbc910cbd6635dccdb4e7f0df2e69a0f341130af
Reviewed-on: https://skia-review.googlesource.com/128660
Commit-Queue: Jim Van Verth <jvanverth@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
Roll skia/third_party/skcms
a7e79c5..
5cc905d (1 commits)
https://skia.googlesource.com/skcms.git/+log/
a7e79c5..
5cc905d
2018-05-16 mtklein@chromium.org remove BUILD.gn
The AutoRoll server is located here: https://skcms-skia-roll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=herb@google.com
Change-Id: I97601850cec8011097ec66d8ece8efd50e86c41c
Reviewed-on: https://skia-review.googlesource.com/128640
Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
swiftshader-skia-autoroll [Wed, 16 May 2018 18:26:45 +0000 (18:26 +0000)]
Roll third_party/externals/swiftshader/
596f653f5..
c8403ec14 (1 commit)
https://swiftshader.googlesource.com/SwiftShader/+log/
596f653f59eb..
c8403ec14aaf
$ git log
596f653f5..
c8403ec14 --date=short --no-merges --format='%ad %ae %s'
2018-05-16 sugoi Fix glBlitFramebuffer validation for BGRA8 IOSurfaces
Created with:
roll-dep third_party/externals/swiftshader
The AutoRoll server is located here: https://swiftshader-skia-roll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-CPU-AVX2-x86_64-Debug-All-SwiftShader
TBR=herb@google.com
Change-Id: Ie1a520ee9674b2ec436eacff0e832829da109567
Reviewed-on: https://skia-review.googlesource.com/128644
Reviewed-by: swiftshader-skia-autoroll <swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: swiftshader-skia-autoroll <swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Ben Wagner [Tue, 15 May 2018 18:12:14 +0000 (14:12 -0400)]
SkImage::onRefEncoded to return sk_sp.
This changes SkImage::onRefEncoded and downstack calls to return sk_sp.
All of the values returned are already sk_sp, so this just updates the
API. This change is currently behind the new flag
SK_IGNORE_SKIMAGE_ONREFENCODED_CHANGE so that Chromium can be updated.
Change-Id: Ic53a88ae23fa8b3b41b84c4abdc4b74e9879da38
Reviewed-on: https://skia-review.googlesource.com/128311
Reviewed-by: Leon Scroggins <scroggo@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
Adrienne Walker [Tue, 15 May 2018 18:47:07 +0000 (11:47 -0700)]
Driver bug workaround: gl_clear_broken
Skia does not appear to use depth buffers and this appears to be
identical to ClearFramebufferResourceManager::ClearFramebuffer in
Chromium code. Therefore, just hook up this workaround to turn
on these internal Skia workarounds.
Bug: chromium: 829614
Change-Id: Icc5f2eb981e39ffef487efa16940d2e50cdbc399
Reviewed-on: https://skia-review.googlesource.com/127220
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Adrienne Walker <enne@chromium.org>
swiftshader-skia-autoroll [Wed, 16 May 2018 17:45:45 +0000 (17:45 +0000)]
Roll third_party/externals/swiftshader/
e475674ef..
596f653f5 (1 commit)
https://swiftshader.googlesource.com/SwiftShader/+log/
e475674ef6e1..
596f653f59eb
$ git log
e475674ef..
596f653f5 --date=short --no-merges --format='%ad %ae %s'
2018-05-15 sugoi Fixed atan corner case
Created with:
roll-dep third_party/externals/swiftshader
The AutoRoll server is located here: https://swiftshader-skia-roll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-CPU-AVX2-x86_64-Debug-All-SwiftShader
TBR=herb@google.com
Change-Id: Ie9f4f83d9ba24e7014e20cff944b8e86aae991a0
Reviewed-on: https://skia-review.googlesource.com/128620
Reviewed-by: swiftshader-skia-autoroll <swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: swiftshader-skia-autoroll <swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Adrienne Walker [Tue, 15 May 2018 18:44:34 +0000 (11:44 -0700)]
Driver bug workaround: restore_scissor_on_fbo_change
Bug: chromium: 829614
Change-Id: I333aed9a378ab9b7aafaa96bb495378d1db4a61d
Reviewed-on: https://skia-review.googlesource.com/127118
Commit-Queue: Adrienne Walker <enne@chromium.org>
Reviewed-by: Brian Salomon <bsalomon@google.com>
Kevin Lubick [Wed, 16 May 2018 17:36:57 +0000 (13:36 -0400)]
Remove problematic pre-allocations when deserializing
The fuzzer would frequently OOM on these.
Bug: skia:7937
Change-Id: I5e6a7dabeca327452f774100c9db05cd6be4cb06
Reviewed-on: https://skia-review.googlesource.com/128551
Reviewed-by: Florin Malita <fmalita@chromium.org>
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
Herb Derby [Wed, 16 May 2018 17:08:37 +0000 (13:08 -0400)]
Fix compiler warning for MSVC
BUG=skia:7954
Change-Id: I2b100f723a88a57aaa4de08860f40ab73b9b674f
Reviewed-on: https://skia-review.googlesource.com/128580
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Herb Derby <herb@google.com>
Roll skia/third_party/skcms
e040063..
a7e79c5 (2 commits)
https://skia.googlesource.com/skcms.git/+log/
e040063..
a7e79c5
2018-05-16 mtklein@chromium.org try yet again to fix gauss-newton stepping
2018-05-16 mtklein@chromium.org add clang.O0 build
The AutoRoll server is located here: https://skcms-skia-roll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=herb@google.com
Change-Id: I63a0ed3f912f69b114e3100ea44311f478563d3a
Reviewed-on: https://skia-review.googlesource.com/128475
Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Roll skia/third_party/skcms
ce2fabc..
e040063 (1 commits)
https://skia.googlesource.com/skcms.git/+log/
ce2fabc..
e040063
2018-05-16 mtklein@chromium.org spin off Curve.[ch]
The AutoRoll server is located here: https://skcms-skia-roll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=herb@google.com
Change-Id: Ie9571b17589849e55d2db079f38c40ba5a8fede4
Reviewed-on: https://skia-review.googlesource.com/128465
Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
projects / platform / upstream / libSkiaSharp.git / log