William Godbe [Wed, 17 May 2017 01:36:29 +0000 (18:36 -0700)]
Fix Formatting in TestsFailingOutsideOfWindows.txt
Commit migrated from https://github.com/dotnet/coreclr/commit/
5311ea34f8d6c72f0415bf890b629170bc4f4328
William Godbe [Wed, 17 May 2017 01:35:31 +0000 (18:35 -0700)]
Merge pull request dotnet/coreclr#11620 from wtgodbe/BuildToolsUpdate
Update Coreclr to 2.0.0 buildtools
Commit migrated from https://github.com/dotnet/coreclr/commit/
0fd82ac5feaf98d493973a1e1a5de95ba1812943
Pat Gavlin [Wed, 17 May 2017 00:28:20 +0000 (17:28 -0700)]
Disable opt-sensitive tests under tailcall stress and balance pushd. (dotnet/coreclr#11658)
Just what it says on the tin.
Commit migrated from https://github.com/dotnet/coreclr/commit/
8a24a64e018de999a07ea45b408fd3a3ca672ba8
Brian Robbins [Wed, 17 May 2017 00:11:47 +0000 (17:11 -0700)]
Allow provider deletion to be deferred until after tracing is stopped. (dotnet/coreclr#11651)
Commit migrated from https://github.com/dotnet/coreclr/commit/
40b87c9810c31fb6ab471a44b5735408269ce6ba
wtgodbe [Tue, 2 May 2017 23:33:41 +0000 (16:33 -0700)]
Update Coreclr to 2.0.0 buildtools
Commit migrated from https://github.com/dotnet/coreclr/commit/
798387ee90d7536d5a620af8482100ba76f6061a
dotnet bot [Tue, 16 May 2017 21:53:08 +0000 (14:53 -0700)]
Update CoreClr to preview2-25316-03 (dotnet/coreclr#11650)
Commit migrated from https://github.com/dotnet/coreclr/commit/
36e988ee6593351f1e962118a99154df5eae0254
Drew Scoggins [Tue, 16 May 2017 20:55:49 +0000 (13:55 -0700)]
Merge pull request dotnet/coreclr#9354 from tannergooding/math
Adding perf tests for the single precision math functions in System.MathF.
Commit migrated from https://github.com/dotnet/coreclr/commit/
c114603f41fbbb12c8a7295919a346b00361d999
Swaroop Sridhar [Wed, 10 May 2017 09:25:16 +0000 (02:25 -0700)]
Add LinkBench to BenchView
1) Add LinkBench to the xunit-perf benchmark runs, as a scenario test
2) Some improvements to run-xunit-perf to
- Handle tests that perform size measurement
- Parametrization of test group
- Tests running multiple scenarios
CoreFX testing is currently disabled because it fails in the lab
due to a path length limitation.
Commit migrated from https://github.com/dotnet/coreclr/commit/
fcca93a670ce4f9916993d83f5581de4e13fec1f
Tanner Gooding [Mon, 6 Feb 2017 00:08:20 +0000 (00:08 +0000)]
Updated the JIT/Performance/CodeQuality/Math/Functions single-precision tests to have the correct expected results.
Commit migrated from https://github.com/dotnet/coreclr/commit/
1c6f4945bae19ac8c31364053a1d4cfff9b63347
Tanner Gooding [Sun, 5 Feb 2017 23:46:56 +0000 (23:46 +0000)]
JIT/Performance/CodeQuality/Math/Functions tests to use the appropriate precision when printing failure messages.
Commit migrated from https://github.com/dotnet/coreclr/commit/
b8bee85eda03852a72921bc3bbea0f45d073a75d
Tanner Gooding [Sun, 5 Feb 2017 23:00:29 +0000 (23:00 +0000)]
Updating the JIT/Performance/CodeQuality/Math/Functions tests to target netcoreapp1.1 instead of netstandard1.4
Commit migrated from https://github.com/dotnet/coreclr/commit/
1b7b588240445d77387988f4dcdb4e9462ef87a0
Tanner Gooding [Sun, 5 Feb 2017 21:41:37 +0000 (13:41 -0800)]
Adding perf tests for the single precision math functions in System.MathF.
Commit migrated from https://github.com/dotnet/coreclr/commit/
4807b9fc40a8d5644df9dd15e0f43bd307fab395
Pat Gavlin [Tue, 16 May 2017 18:20:37 +0000 (11:20 -0700)]
Disable tail call stress in GH_10780 if ZapDisable is enabled. (dotnet/coreclr#11649)
* Disable tail call stress in GH_10780 if ZapDisable is enabled.
Tail call stress does not mix well with ZapDisable due to the issues
described in dotnet/coreclr#11408.
Fixes dotnet/coreclr#11648.
* Add a missing semicolon.
Commit migrated from https://github.com/dotnet/coreclr/commit/
f2913a39793be26a5bb598582c41790593a5e5f8
Jarret Shook [Tue, 16 May 2017 16:05:05 +0000 (09:05 -0700)]
Merge pull request dotnet/coreclr#11037 from jashook/arm64_test_update
Turn on tests which are now passing.
Commit migrated from https://github.com/dotnet/coreclr/commit/
bad672907a73790f5301352ce5bdca688da7b78f
Jeremy Kuhne [Tue, 16 May 2017 15:40:15 +0000 (08:40 -0700)]
Update Corelib to use SetThreadErrorMode (dotnet/coreclr#11625)
See dotnet/coreclr#19738. Note that the enumerable is only used on Unix- but updated
it anyway. Conditioned the set/unset for ! Unix. SetErrorMode in the
PAL is a no-op, want to use the shared interop.
Commit migrated from https://github.com/dotnet/coreclr/commit/
b96c7b9878ea3b530c9455ca7bfeac0e425f6461
Jonghyun Park [Tue, 16 May 2017 15:39:40 +0000 (00:39 +0900)]
[x86/Linux] Remove GetFrameFromRedirectedStubStackFrame stub (dotnet/coreclr#11638)
Commit migrated from https://github.com/dotnet/coreclr/commit/
2fbc698079b26e5fbb745082d30264a8ccb8644d
Stephen Toub [Tue, 16 May 2017 14:35:21 +0000 (10:35 -0400)]
Merge pull request dotnet/coreclr#11639 from brianrob/fix_corefx
Fix EventSource Test Breaks in CoreFX
Commit migrated from https://github.com/dotnet/coreclr/commit/
0e71141cf38dd146c2d34dc53e2b2b66e0bade8a
Brian Robbins [Tue, 16 May 2017 05:23:44 +0000 (22:23 -0700)]
Fix EventSource tests.
Commit migrated from https://github.com/dotnet/coreclr/commit/
c3d04c6c600b064ec23d2d3636d309791979351d
Jonghyun Park [Tue, 16 May 2017 05:20:34 +0000 (14:20 +0900)]
Move PopSEHRecords into excepx86.cpp (dotnet/coreclr#11626)
Commit migrated from https://github.com/dotnet/coreclr/commit/
094d8301dc238abe470f67342c8b17217585c798
Jan Kotas [Mon, 15 May 2017 23:40:31 +0000 (16:40 -0700)]
Merge pull request dotnet/corertdotnet/coreclr#3622 from dotnet/nmirror
Merge nmirror to master
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/
a44d2a19dfcef497333487a531ba5b43b3006e81
dotnet bot [Tue, 16 May 2017 04:13:10 +0000 (21:13 -0700)]
Update CoreClr, CoreFx to preview2-25316-01, preview2-25316-01, respectively (dotnet/coreclr#11622)
Commit migrated from https://github.com/dotnet/coreclr/commit/
b14c529f14f6ce1f660ce66951b1c29fc41632bd
Swaroop Sridhar [Tue, 16 May 2017 02:18:17 +0000 (19:18 -0700)]
Remove an unnecessary binary file
Remove a binary file that was unintentionally checked in.
Commit migrated from https://github.com/dotnet/coreclr/commit/
f2688a682b639d4383b62afde31593dac58d39f3
jashook [Mon, 17 Apr 2017 23:27:37 +0000 (16:27 -0700)]
Turn on tests which are now passing.
This also adds metadata for all tests which are to be excluded
because they do not work with core.
Commit migrated from https://github.com/dotnet/coreclr/commit/
3c2d83fbacd72622ad4090963f55edfcc61829b2
Sergey Andreenko [Mon, 15 May 2017 23:42:18 +0000 (16:42 -0700)]
Use full move for byte registers stores in jumps. (dotnet/coreclr#11570)
* Use the 4-byte move for jump spilling.
The other types of spilling already use the proper move:
1) for lsra spilling it always use 4-byte move because we allocate 4-byte slots;
2) for other types it sets needsByteReg and lsra chooses correct register;
We do not apply the second approach to fixing this issue because jmp doesn't
have real uses, that can keep this requirement on. Also, it creates more strict
restrictions, that we need.
Commit migrated from https://github.com/dotnet/coreclr/commit/
81baf0a53fdc3cae247dd80ebc1e8f54e7ad54fa
Xiangyang (Mark) Guo [Mon, 15 May 2017 20:05:32 +0000 (13:05 -0700)]
Write EventSource events with metadata to EventPipe (dotnet/coreclr#11577)
* Fix EventPipe initialization.
* rebase code with master, add prototype of event source metadata
* fix define event
* add null ptr checking
* move WriteEvent metadata serialization to managed side
* Fix enabled keywords for COMPlus_PerformanceTracing=1.
* put parameter name into metadata, use WriteToBuffer
* Write event metadata to the file.
* allocate buffer in EventPipeEvent ctor
* prevent double free
* refactor code
* AddEvent params reorder
Commit migrated from https://github.com/dotnet/coreclr/commit/
a7fae647fc09448cce04276a87a2873c09d31d42
Pat Gavlin [Mon, 15 May 2017 20:04:30 +0000 (13:04 -0700)]
Fix issue dotnet/coreclr#11574. (dotnet/coreclr#11579)
This bug was yet another case of a transformation being performed during
remorphing that preserved a tree's value number without preserving its
associated semantics. This fix disables the problematic transformations
in morph.
Commit migrated from https://github.com/dotnet/coreclr/commit/
37168aeaf5d70de2d7af52d102002fc29b9feaf1
Tarek Mahmoud Sayed [Mon, 15 May 2017 20:00:15 +0000 (13:00 -0700)]
Update License Info (dotnet/coreclr#11617)
Commit migrated from https://github.com/dotnet/coreclr/commit/
272b65025e9ad00e04d1dc3acd07233ffb723fce
Koundinya Veluri [Mon, 15 May 2017 19:47:36 +0000 (12:47 -0700)]
Throw PNSE in ThreadPoolBoundHandle.BindHandle on Unixes (dotnet/coreclr#11613)
Throw PNSE in ThreadPoolBoundHandle.BindHandle on Unixes
Functional fix for https://github.com/dotnet/corefx/issues/19785
Commit migrated from https://github.com/dotnet/coreclr/commit/
b8b0b127361e3a241adb66b3074db6923c2abf17
dotnet bot [Mon, 15 May 2017 15:48:36 +0000 (08:48 -0700)]
Update CoreClr, CoreFx to preview2-25315-02, preview2-25315-01, respectively (dotnet/coreclr#11596)
Commit migrated from https://github.com/dotnet/coreclr/commit/
fd7b8ca0faaa21fde687db55e124bf0fd683aec1
Jonghyun Park [Mon, 15 May 2017 15:47:55 +0000 (00:47 +0900)]
Remove unused code from excepx86.cpp (dotnet/coreclr#11602)
Commit migrated from https://github.com/dotnet/coreclr/commit/
38ae7da0e46c0ea4ccbbadf60d64ba91074f0e69
Brian Robbins [Mon, 15 May 2017 15:15:51 +0000 (08:15 -0700)]
Allow coniguration of sampling rate. (dotnet/coreclr#11595)
Commit migrated from https://github.com/dotnet/coreclr/commit/
1cf39a4e686668f35aec3f336615c422e3cc9fec
Brian Robbins [Mon, 15 May 2017 15:13:42 +0000 (08:13 -0700)]
EventPipe: Prepend variable length field sizes (dotnet/coreclr#11600)
* Write the size in bytes of the stack before the stack contents.
* Specify the size of the metadata payload explicitly in the file.
Commit migrated from https://github.com/dotnet/coreclr/commit/
f11f3d73eb432b1dc4c42df6eb1e1fb099222730
Mike McLaughlin [Mon, 15 May 2017 06:56:22 +0000 (23:56 -0700)]
Fix minidump hang under shipping lldb 3.9.1 (dotnet/coreclr#11591)
Issue: dotnet/coreclr#11590
Commit migrated from https://github.com/dotnet/coreclr/commit/
c4db3ea4f2912288256f55d16dffe225abbb72e8
dotnet bot [Sat, 13 May 2017 21:32:19 +0000 (14:32 -0700)]
Update CoreClr, CoreFx to preview2-25313-04, preview2-25313-02, respectively (dotnet/coreclr#11575)
Commit migrated from https://github.com/dotnet/coreclr/commit/
76cbc581382ebbcf745dd2b79ac02c419970808c
Stephen Toub [Sat, 13 May 2017 21:31:31 +0000 (17:31 -0400)]
Merge pull request dotnet/coreclr#11593 from brianrob/eventsource_unix
Disable ETW calls on UNIX
Commit migrated from https://github.com/dotnet/coreclr/commit/
148bcb0a16c34e82e3876424684792904bc1d18d
Brian Robbins [Sat, 13 May 2017 18:39:10 +0000 (11:39 -0700)]
Disable ETW calls on UNIX.
Commit migrated from https://github.com/dotnet/coreclr/commit/
e029e54d6d5bfe6a886a761c77eb3f66c3131ac9
Tarek Mahmoud Sayed [Sat, 13 May 2017 06:35:49 +0000 (23:35 -0700)]
Fix String.IndexOf with empty string input (dotnet/coreclr#11587)
Commit migrated from https://github.com/dotnet/coreclr/commit/
e44d8548b2464319716c40ef2bbd793a780d389b
Brian Robbins [Sat, 13 May 2017 01:34:16 +0000 (18:34 -0700)]
Enable Symbolic Rundown for EventPipe (dotnet/coreclr#11582)
Commit migrated from https://github.com/dotnet/coreclr/commit/
49dce08b281c19cf0d7283754fdf8436886c9dbc
Brian Sullivan [Fri, 12 May 2017 23:49:45 +0000 (16:49 -0700)]
Merge pull request dotnet/coreclr#11584 from dotnet/revert-11500-from-tfs
Revert "Merge changes from TFS"
Commit migrated from https://github.com/dotnet/coreclr/commit/
cb28a2c3a94db38f9ad10e6245fcd85178e538e5
Jarret Shook [Fri, 12 May 2017 23:47:12 +0000 (16:47 -0700)]
Revert "Merge changes from TFS"
Commit migrated from https://github.com/dotnet/coreclr/commit/
3d97892fdd0c2436d113058c8c466d0bfe8c3e4f
Brian Robbins [Fri, 12 May 2017 21:42:04 +0000 (14:42 -0700)]
Put the serialization marker under its own IFDEF. (dotnet/coreclr#11568)
Commit migrated from https://github.com/dotnet/coreclr/commit/
27faf8b3d2dec455a32b581f574e6dcac4daf5c7
Brian Robbins [Fri, 12 May 2017 21:14:28 +0000 (14:14 -0700)]
Don't allow specification of needStack to EventPipeProvider when creating an event. (dotnet/coreclr#11571)
Commit migrated from https://github.com/dotnet/coreclr/commit/
c8f77deb64c8bf582a7a9a090dea6a8ad6c9be6b
dotnet bot [Fri, 12 May 2017 20:23:36 +0000 (13:23 -0700)]
Update CoreClr, CoreFx to preview2-25312-01, preview2-25312-03, respectively (dotnet/coreclr#11544)
Commit migrated from https://github.com/dotnet/coreclr/commit/
f90a27bfa18f078a39acd6fed57b9e9dd1adc8a9
Brian Robbins [Fri, 12 May 2017 19:22:06 +0000 (12:22 -0700)]
Only call EventActivityIdControl ETW function on Windows. (dotnet/coreclr#11549)
Commit migrated from https://github.com/dotnet/coreclr/commit/
97beb51d92895e34c2dc8ff8b859b814d0c50f6c
Atsushi Kanamori [Fri, 12 May 2017 15:22:52 +0000 (08:22 -0700)]
Delete non-shared version and switch over to shared version.
Commit migrated from https://github.com/dotnet/coreclr/commit/
0c4845c9a327446ad6f5acb41b34dff6c1f489d8
Jan Kotas [Fri, 12 May 2017 14:56:00 +0000 (07:56 -0700)]
Merge pull request dotnet/corertdotnet/coreclr#3601 from dotnet/nmirror
Merge nmirror to master
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/
7bb792119303ffceee4fd2ee950a7f5c6f561860
Carol Eidt [Fri, 12 May 2017 18:04:23 +0000 (11:04 -0700)]
Merge pull request dotnet/coreclr#10972 from hqueue/arm/ryujit/lsra
[Ryujit/ARM32] LSRA support for arm32 floating-point register allocation
Commit migrated from https://github.com/dotnet/coreclr/commit/
79ee21ab8bc2fff4dbed6d056ac370306f67aa96
Jarret Shook [Fri, 12 May 2017 18:00:57 +0000 (11:00 -0700)]
Merge pull request dotnet/coreclr#11500 from dotnet-bot/from-tfs
Merge changes from TFS
Commit migrated from https://github.com/dotnet/coreclr/commit/
d80336efafd4132b95bcd3206a99227091ca904e
Brian Robbins [Fri, 12 May 2017 17:51:31 +0000 (10:51 -0700)]
EventPipe Circular Buffer Support and Ability to Start/Stop Tracing (dotnet/coreclr#11507)
Commit migrated from https://github.com/dotnet/coreclr/commit/
fca97d0ca72524b3bdd61817f7a172dd47d53287
Jarret Shook [Fri, 12 May 2017 16:40:00 +0000 (09:40 -0700)]
Merge pull request dotnet/coreclr#11536 from jashook/green_arm64_ci
[Arm64] Disable new test regressions
Commit migrated from https://github.com/dotnet/coreclr/commit/
f70698458849e3541dc96fac8d6c0d6b52ccf048
jashook [Thu, 11 May 2017 22:54:44 +0000 (15:54 -0700)]
[Arm64] Disable new test regressions
Disable tests based on dotnet/coreclr#11533, dotnet/coreclr#11534.
Commit migrated from https://github.com/dotnet/coreclr/commit/
946bbe6a8db691cd9bad94657c38f0b8eeb8641e
Pat Gavlin [Fri, 12 May 2017 06:02:54 +0000 (23:02 -0700)]
Re-morph lclVar nodes after simplifying (ind (addr (lclVar))). (dotnet/coreclr#11531)
Morph simplifies (ind (addr (lclVar))) if the type of the load matches
the type of the lclVar node. This simplification is not valid, however,
if the lclVar must be normalized upon load: in that case, the lclVar
node must be normalized appropriately as part of the transformation.
This change fixes the simplification to perform this normalization if
necessary by calling `fgMorphLclVar` on the result if the result is a
lclVar node.
Fixes issue dotnet/coreclr#11508.
Commit migrated from https://github.com/dotnet/coreclr/commit/
1c280808e694aee3ca575bee0693f27ccd11c298
dotnet bot [Fri, 12 May 2017 03:35:41 +0000 (20:35 -0700)]
Update CoreFx to preview2-25311-04 (dotnet/coreclr#11532)
Commit migrated from https://github.com/dotnet/coreclr/commit/
6fb6d4fdc1fa08f34445ff49d5842bdde419d5cb
Brian Sullivan [Fri, 12 May 2017 02:43:34 +0000 (19:43 -0700)]
Merge pull request dotnet/coreclr#11528 from sdmaclea/PR-ARM64-Add-ldar-stlr-instrs
[Arm64] Add emitter support for ldar/stlr
Commit migrated from https://github.com/dotnet/coreclr/commit/
4ae4295d617a7a105a85c8b1b164fb8654fff282
Brian Sullivan [Fri, 12 May 2017 02:28:08 +0000 (19:28 -0700)]
Merge pull request dotnet/coreclr#11468 from sdmaclea/PR-ARM64-3092
[Arm64] Use movn in instGen_Set_Reg_To_Imm
Commit migrated from https://github.com/dotnet/coreclr/commit/
e34414282f89a635cf8bf4e1a16fbfec5bbefaa6
Morgan Brown [Fri, 12 May 2017 02:24:42 +0000 (19:24 -0700)]
Removes unneeded Serializable attributes from enums and delegates. They can be serialized without attributes and this will remove noise from future serialization changes. (dotnet/coreclr#11535)
Commit migrated from https://github.com/dotnet/coreclr/commit/
906f60ce3c55ab0cc41765d9eeea542ec65ff737
mskvortsov [Fri, 12 May 2017 01:32:11 +0000 (04:32 +0300)]
[RyuJIT/ARM32] Fix GT_NEG decomposition (dotnet/coreclr#11495)
RyuJIT/ARM32: Fix GT_NEG decomposition.
Commit migrated from https://github.com/dotnet/coreclr/commit/
e236ed54426e1e2bc53115123adbf9bad9584b5d
Sujin Kim [Fri, 12 May 2017 01:26:23 +0000 (10:26 +0900)]
[RyuJIT/ARM32] Implement for GT_STORE_OBJ (dotnet/coreclr#10721)
* Implement lowering for GT_STORE_OBJ
In dotnet/coreclr#10657, I commented that the messages for NYI were printed about GT_STORE_OBJ on running the CodeGenBringUpTests.
'Lowering::LowerBlockStore(GenTreeBlk* blkNode)' method implementation is just copied.
but after lowering phase, in code generation, codegenarm.cpp, below would be used.
```cpp
blkNode->gtBlkOpKind = GenTreeBlk::BlkOpKindUnroll;
```
```cpp
blkNode->gtBlkOpKind = GenTreeBlk::BlkOpKindHelper;
```
```cpp
void CodeGen::genCodeForStoreBlk(GenTreeBlk* blkOp)
{
if (blkOp->gtBlkOpGcUnsafe)
{
getEmitter()->emitDisableGC();
}
bool isCopyBlk = blkOp->OperIsCopyBlkOp();
switch (blkOp->gtBlkOpKind)
{
case GenTreeBlk::BlkOpKindHelper:
if (isCopyBlk)
{
genCodeForCpBlk(blkOp);
}
else
{
genCodeForInitBlk(blkOp);
}
break;
case GenTreeBlk::BlkOpKindUnroll:
if (isCopyBlk)
{
genCodeForCpBlkUnroll(blkOp);
}
else
{
genCodeForInitBlkUnroll(blkOp);
}
break;
default:
unreached();
}
if (blkOp->gtBlkOpGcUnsafe)
{
getEmitter()->emitEnableGC();
}
}
```
'genCodeForCpBlk' and 'genCodeForInitBlk' are implemented in ARM/ARM64 by MEMCPY/MEMSET
but 'genCodeForCpBlkUnroll' and 'genCodeForInitBlkUnroll' are not implemented both ARM and ARM64.
Therefore those need to implement.
* Implement NYI : GT_STORE_OBJ is needed of write barriers implementation
It was copied from ARM64 and removed codes related with gc write barrier which doesn't support on ARM.
* Implement CodeGen::genCodeForCpObj
* Refactor some codes
* Use INS_OPTS_LDST_POST_INC option for post-indexing
When structure is copied, the results of asm codes have been strange.
IN0013: 000048 ldr r3, [r1+4]
IN0014: 00004A str r3, [r0+4]
IN0015: 00004C ldr r3, [r1+4]
IN0016: 00004E str r3, [r0+4]
It needs that the index would increment or the post-indexing.
So I use INS_OPTS_LDST_POST_INC option for post-indexing when the instruction is emitted.
* Fix conflicts
* Fix conflicts and Apply dotnet/coreclr#11219
I want to merge genCodeForCpObj to codegenarmarch.cpp but the function has modified in dotnet/coreclr#11219.
So I decided to keep the code divided now.
In future, If modifying the function on ARM is also needed, it would be able to modify.
* Fix conflicts
* Remove NYI
* Fix genCountBits assertion
Commit migrated from https://github.com/dotnet/coreclr/commit/
4be9be99e578bd93616f439ba603b6a2909afcec
Steve MacLean [Thu, 11 May 2017 23:59:50 +0000 (19:59 -0400)]
Comment per review
Commit migrated from https://github.com/dotnet/coreclr/commit/
b86966047c3bee135ddf8e166aeeb14a559ba1a9
Brian Robbins [Thu, 11 May 2017 01:04:24 +0000 (18:04 -0700)]
Fix build.
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/
4a321d8000aa49e3a82f70467dfce2c1400089e3
Sujin Kim [Thu, 11 May 2017 23:13:33 +0000 (08:13 +0900)]
[RyuJIT/ARM32] Fix assertion in 'unreached' when using emitIns_R_L (dotnet/coreclr#11486)
* [RyuJIT/ARM32] Fix assertion in 'unreached'
Now, All of CodeGenBringUpTests have failed.
message : Assertion failed 'unreached' in 'DomainNeutralILStubClass:IL_STUB_PInvoke(ref)'
I found the problem was caused by dotnet/coreclr#11377 that 'genCodeForTreeNode' merged to codegenarmarch.cpp.
Commit migrated from https://github.com/dotnet/coreclr/commit/
3ccf725bcd895a5cf472bfc5b3d041825bd1b4f9
Swaroop Sridhar [Thu, 11 May 2017 20:49:17 +0000 (13:49 -0700)]
LinkBench: Report reduction as a ratio.
Report the linker size reduction metric as a ratio
(linked filesize / unlinked filesize) instead of as a percentage.
Commit migrated from https://github.com/dotnet/coreclr/commit/
06e414557942715ca44c017c5729c188cafbedc0
Jarret Shook [Thu, 11 May 2017 22:26:44 +0000 (15:26 -0700)]
Merge pull request dotnet/coreclr#11423 from jashook/arm64_live_tests
Windows Arm64 - Build/Run tests in CI
Commit migrated from https://github.com/dotnet/coreclr/commit/
ecc16425c7023bd60c931f2cf991b0265bd68fd5
jashook [Fri, 5 May 2017 18:10:12 +0000 (11:10 -0700)]
Windows Arm64 - Build/Run tests in CI
Build tests with arm64 runs and upload/run them to the arm64 test
machines.
Commit migrated from https://github.com/dotnet/coreclr/commit/
9004feee78284250c0193fc816eb0313231dd6ab
Michelle McDaniel [Thu, 11 May 2017 19:28:28 +0000 (12:28 -0700)]
Handle ADC in x86 unwindLazyState (dotnet/coreclr#11527)
When we add PGO instrumentation to coreclr, the instrumentation injects
PUSH, MOV, ADD, ADC, POP into the prolog to mark the function entry. This
causes a crash because we do not currently handle ADC instructions in
unwindLazyState. This change adds support for ADC, which uses the normal
DecodeRM code we already have in place.
Commit migrated from https://github.com/dotnet/coreclr/commit/
0d5d0b40c4ecb3f7f4fcdc83a5a51a2ee65dfc89
Jan Kotas [Thu, 11 May 2017 18:45:38 +0000 (11:45 -0700)]
Add back private BadImageFormatException constructor called by the VM (dotnet/coreclr#11523)
Also removed rethrowing of an exception inside AssemblyName.GetAssemblyName that sometimes resulted into two identical exceptions getting nested into each other.
Fixes dotnet/coreclr#11499
Commit migrated from https://github.com/dotnet/coreclr/commit/
11dea52f9d82b19481e5a6df54263b85fb5663e2
Sepideh Khoshnood [Thu, 11 May 2017 18:45:06 +0000 (11:45 -0700)]
Fix AssemblyName version (dotnet/coreclr#11505)
* Fix AssemblyName.FullName
* Use canonicalized version instead of Version.ToString
Commit migrated from https://github.com/dotnet/coreclr/commit/
e52d80fa5b53fea51d18f03e441cf0c2fff58419
[Arm64] Fixup stlr instrs
Commit migrated from https://github.com/dotnet/coreclr/commit/
78b23c32b7a8cc8ad6bb4f76ee5375bcbf6fbee4
[Arm64] Add emitter support for ldar/stlr
Commit migrated from https://github.com/dotnet/coreclr/commit/
56cca165927eddc98ad370b23d2b7e037464dd21
[Arm64] Fix instGen_Set_Reg_To_Imm per review
Commit migrated from https://github.com/dotnet/coreclr/commit/
1679f651728aa4132590ce17e98b444c6060aa16
Noah Falk [Thu, 11 May 2017 03:29:30 +0000 (20:29 -0700)]
Merge pull request dotnet/coreclr#11437 from mjsabby/eventpipetoprofilerapi
Add dynamic method unload event to Profiler API
Commit migrated from https://github.com/dotnet/coreclr/commit/
27f4b80d1e0935bcd04b1a0024e824984b407928
Swaroop Sridhar [Wed, 10 May 2017 22:25:53 +0000 (15:25 -0700)]
This change has the following improvements to LinkBench
1. Move the testing to the latest version of ILLink package
(for all benchmarks except for Roslyn, which is still on netcoreapp1.1)
2. Support for LinkBench to run individual benchmarks in the suite --
helps local testing.
3. Support for running without clean, cloning, build etc --
for local runs during continuous development.
4. Support to obtain the correct version(s) of DotNet CLI required to run
the benchmarks
5. Get-Crossgen.ps1 is required to crossgen MusicStore binaries (before/after linking).
Since it was recently dropped from JitBench repo, it is added to linkBench as an asset.
6. Add the --perf:runid parameter to generate output file names suitable
to upload the results to BenchView.
Commit migrated from https://github.com/dotnet/coreclr/commit/
406166785e168d840b711783e9806b155376a930
Mukul Sabharwal [Thu, 11 May 2017 01:41:13 +0000 (18:41 -0700)]
Remove eventpipe stuff left from prev commit
Commit migrated from https://github.com/dotnet/coreclr/commit/
a595f4e633fb69c65383692920ba81248ff14103
Mukul Sabharwal [Thu, 11 May 2017 01:39:37 +0000 (18:39 -0700)]
add prebuilt file
Commit migrated from https://github.com/dotnet/coreclr/commit/
2c4c50a9dad454906000640274c56229e2fb89ba
Mukul Sabharwal [Thu, 11 May 2017 01:37:58 +0000 (18:37 -0700)]
Remove EventPipeProfiler due to time constraints
Commit migrated from https://github.com/dotnet/coreclr/commit/
095c7fec7fc928ceff364c1eaa86386f26b53c93
Alex Ghiondea [Wed, 10 May 2017 23:45:01 +0000 (16:45 -0700)]
Allow multiple SetData calls on AppDomain (dotnet/coreclr#11496)
* Allow multiple SetData calls on AppDomain
* Remove restriction from GetData and remove now-dead code Locate
* Remove LoaderOptimization check since it is not used on CoreCLR
Commit migrated from https://github.com/dotnet/coreclr/commit/
0dcdd0d9edd30fddd7dcb1c0e149abffb4e0a1cd
Brian Robbins [Wed, 10 May 2017 22:11:28 +0000 (15:11 -0700)]
Re-Factor EventSource to Support Writing to EventPipe (dotnet/coreclr#11435)
Re-Factor EventSource to Support Writing to EventPipe.
Commit migrated from https://github.com/dotnet/coreclr/commit/
377073385e4545d36e1a96429dd78548f87c597c
Brian Sullivan [Wed, 10 May 2017 20:50:19 +0000 (13:50 -0700)]
Merge pull request dotnet/coreclr#11478 from sdmaclea/PR-ARM64-9711
[Arm64] Support GTF_IND_VOLATILE
Commit migrated from https://github.com/dotnet/coreclr/commit/
0b625bfdbb97565b7d489d1d083cfaf4dbd47e0d
Jose Perez Rodriguez [Wed, 10 May 2017 20:23:28 +0000 (13:23 -0700)]
Add version.txt to the coreclr transport package (dotnet/coreclr#11497)
* Add version.txt to the coreclr transport package
* PR Feedback
Commit migrated from https://github.com/dotnet/coreclr/commit/
c9f469e5fc99a498f46bd2d60fb198b7f7f1c22b
Drew Scoggins [Wed, 10 May 2017 20:07:12 +0000 (13:07 -0700)]
Merge pull request dotnet/coreclr#11448 from DrewScoggins/AddPriority
Launch perf process with high priority
Commit migrated from https://github.com/dotnet/coreclr/commit/
695164b9c69fbffd640494e661bae02c44ffa0f0
dotnet-bot [Wed, 10 May 2017 19:43:11 +0000 (12:43 -0700)]
Renable building frankenjit
[tfs-changeset: 1657926]
Commit migrated from https://github.com/dotnet/coreclr/commit/
349822367cf5ce581f13e502383e153d55c586df
Jonghyun Park [Wed, 10 May 2017 19:32:33 +0000 (12:32 -0700)]
[ARM/Linux] Enable build with FEATURE_DBGIPC=0 (dotnet/coreclr#11254)
* [ARM/Linux] Enable build with FEATURE_DBGIPC=0
* Replace HAVE_ALIGNED_MALLOC with SUPPORT_LOCAL_DEBUGGING
Commit migrated from https://github.com/dotnet/coreclr/commit/
cdd7d58e75667f108a4843c5aeb61648cd25f340
[Arm64] Revise GTF_IND_VOLATILE per comments
Commit migrated from https://github.com/dotnet/coreclr/commit/
84e39c38feae031c71ed3861a183ec5017783b7a
Jan Vorlicek [Wed, 10 May 2017 16:32:42 +0000 (18:32 +0200)]
Fix clang version detection in src/pal/tools/gen-buildsys-clang.sh (dotnet/coreclr#11398)
The version detection that was added recently for the purpose of selecting
optimization options for ARM builds was not working properly when the
clang binary doesn't have version in its name. This resulted in syntax
error being reported on OSX and some Linux distros:
/Users/janvorli/git/coreclr/src/pal/tools/gen-buildsys-clang.sh:
line 162: : /usr/bin/clang: syntax error: operand expected (error token is "/usr/bin/clang")
Commit migrated from https://github.com/dotnet/coreclr/commit/
b1247408c30dd4dc511e8a65adf8a4efb2776f10
Tarek Mahmoud Sayed [Wed, 10 May 2017 15:38:20 +0000 (08:38 -0700)]
Update the License to MIT for coreclr repo (dotnet/coreclr#11482)
Commit migrated from https://github.com/dotnet/coreclr/commit/
c78891ae1cc668a77377b2b0fb03c7e1a6894b29
Jonghyun Park [Wed, 10 May 2017 15:10:22 +0000 (08:10 -0700)]
Allow users to enable automatic NI bind fallback via command-line (dotnet/coreclr#11485)
* Add FEATURE_NI_BIND_FALLBACK support
* Fix incorrect variable setup
* Negate the check condition
* Use WIN32 instead of FEATURE_PAL
* Check WIN32 first, and FEATURE_NI_BIND_FALLBACK later
Commit migrated from https://github.com/dotnet/coreclr/commit/
17468288b4093efc8fea4748ee3c890bf82535bb
Pat Gavlin [Wed, 10 May 2017 13:56:57 +0000 (06:56 -0700)]
Merge pull request dotnet/coreclr#11484 from pgavlin/DisableLongRunningTests
Disable a few long-running tests.
Commit migrated from https://github.com/dotnet/coreclr/commit/
aa82eb3e057ff6f7853b27749cefd0991625066d
dotnet bot [Wed, 10 May 2017 05:20:44 +0000 (22:20 -0700)]
Update CoreFx to preview2-25310-01 (dotnet/coreclr#11483)
Commit migrated from https://github.com/dotnet/coreclr/commit/
1413d462631f0d9bfc4c3df3cb5371e23bcbd8d9
Pat Gavlin [Wed, 10 May 2017 03:41:05 +0000 (20:41 -0700)]
Disable a few long-running tests.
These tests consistently time out under GC stress or heap verification.
Each disabled test is known to complete successfully given adequate
time.
Commit migrated from https://github.com/dotnet/coreclr/commit/
8ada9acdf8895d313ad71cbeb2dab4e92b02853f
Mike McLaughlin [Wed, 10 May 2017 02:14:09 +0000 (19:14 -0700)]
Fix lldbplugin to properly build with lldb 3.9. (dotnet/coreclr#11480)
Commit migrated from https://github.com/dotnet/coreclr/commit/
c50b6ae6ecaeafce033f568423f5f40fec723e7b
Sergey Andreenko [Tue, 9 May 2017 21:11:24 +0000 (14:11 -0700)]
[x86, R2R] Exclude DevDiv_278523 because it fails in R2R
Look at dotnet/coreclr#11476 for the description.
Commit migrated from https://github.com/dotnet/coreclr/commit/
b1e4097046588d4a4b7c1efab665c023ccf1d5d4
Joseph Tremoulet [Tue, 9 May 2017 23:36:14 +0000 (19:36 -0400)]
Merge pull request dotnet/coreclr#11465 from JosephTremoulet/StaticHoist
Stop hoisting statics above cctors
Commit migrated from https://github.com/dotnet/coreclr/commit/
3d689cadda3f9ff6eb3a6792677b9ac12c36c3c8
Brian Sullivan [Tue, 9 May 2017 23:11:33 +0000 (16:11 -0700)]
Merge pull request dotnet/coreclr#11351 from sdmaclea/PR-ARM64-RRSS-SSRR
[Arm64] Add emitIns_R_R_S_S & emitIns_S_S_R_R
Commit migrated from https://github.com/dotnet/coreclr/commit/
bdd61eae2b36e09d41b76527d469947c4284afeb
Sergey Andreenko [Tue, 9 May 2017 20:24:37 +0000 (13:24 -0700)]
delete tabs from the exclude list
Commit migrated from https://github.com/dotnet/coreclr/commit/
cda214110f763c8a9901f8fb605db088ed6babc6
Joseph Tremoulet [Tue, 9 May 2017 02:30:04 +0000 (22:30 -0400)]
Stop hoisting statics above cctors
Extend the logic in optLoopHoist around `CLS_VAR` nodes to ensure we don't
hoist any tree that contains a `CLS_VAR` for a field with the flag
`CORINFO_FLG_FIELD_INITCLASS` set, unless we also (identify and) hoist the
corresponding static init helper call. The previous logic was
insufficient in that it blocked hoisting of singleton `CLS_VAR` nodes, but
not hoisting of trees that contain `CLS_VAR` nodes as sub-trees.
Add flag `GTF_FLD_INITCLASS`/`GTF_CLS_VAR_INITCLASS` so that optLoopHoist
can recall which fields are paired with static init helper calls, and only
block the hoisting of their trees.
Fixes dotnet/coreclr#10780.
Commit migrated from https://github.com/dotnet/coreclr/commit/
673f56aa91d69b78fc0055e4419d5ad59c47b83b
[Arm64] Support GTF_IND_VOLATILE
Addresses dotnet/coreclr#9711 for arm64
Commit migrated from https://github.com/dotnet/coreclr/commit/
5d16da3f37041c797ad39571d0e88b73e8aaad7a
Sergey Andreenko [Tue, 9 May 2017 19:07:20 +0000 (12:07 -0700)]
Replace tabs with spaces.
Commit migrated from https://github.com/dotnet/coreclr/commit/
f3f57bc07ec5c12c11a7216d2c5190f585c45ab7
Sergey Andreenko [Tue, 9 May 2017 18:00:08 +0000 (11:00 -0700)]
Return DevDiv_255294 test to the exclude list for x86
Because it causes out of memory exception in crossgen mode.
Commit migrated from https://github.com/dotnet/coreclr/commit/
033b592756f34381c63c037c68de3f6924677270
Koundinya Veluri [Tue, 9 May 2017 20:56:40 +0000 (13:56 -0700)]
Fix static analysis issues (dotnet/coreclr#11466)
Fix static analysis issues
Commit migrated from https://github.com/dotnet/coreclr/commit/
c8a37801f8483d05766e0bf053ffa41aaa155f2c
Bruce Forstall [Tue, 9 May 2017 19:05:20 +0000 (12:05 -0700)]
Merge pull request dotnet/coreclr#11406 from sdmaclea/PR-ARM64-ENABLE-FEATURE_TAILCALL_OPT
[Arm64] Enable FEATURE_TAILCALL_OPT
Commit migrated from https://github.com/dotnet/coreclr/commit/
39a841c33a6ae70cc887ee9fa7cfdeb834c6ca59