platform/upstream/llvm.git
7 years agoAlso don't inline dllimport functions referring to non-dllimport constructors.
Hans Wennborg [Tue, 13 Sep 2016 22:51:42 +0000 (22:51 +0000)]
Also don't inline dllimport functions referring to non-dllimport constructors.

The AST walker wasn't visiting CXXConstructExprs before.

This is a follow-up to r281395.

llvm-svn: 281413

7 years agoWarning flag updates:
Richard Smith [Tue, 13 Sep 2016 22:51:09 +0000 (22:51 +0000)]
Warning flag updates:
-Wdiv-by-zero may as well be an alias for -Wdivision-by-zero rather than a GCC-compatibility no-op.
-Wno-shadow should disable -Wshadow-ivar.
-Weffc++ may as well enable -Wnon-virtual-dtor like it does in GCC.

llvm-svn: 281412

7 years agorevert: [ELF] - Versionscript: support mangled symbols with the same name.
George Rimar [Tue, 13 Sep 2016 22:26:12 +0000 (22:26 +0000)]
revert: [ELF] - Versionscript: support mangled symbols with the same name.

Something broked BBots:
281318 failed on step 9:
http://lab.llvm.org:8011/builders/clang-with-lto-ubuntu/builds/413

r281317 built step 9 green:
http://lab.llvm.org:8011/builders/clang-with-lto-ubuntu/builds/415

Initial revision commits were:
This is PR30312. Info from bug page:

Both of these symbols demangle to abc::abc():
_ZN3abcC1Ev
_ZN3abcC2Ev
(These would be abc's complete object constructor and base object constructor, respectively.)
however with "abc::abc()" in the version script only one of the two receives the symbol version.

Patch fixes that.
It uses testcase created by Ed Maste (D24306).

Differential revision: https://reviews.llvm.org/D24336

llvm-svn: 281411

7 years ago[asan] alloc_dealloc_mismatch=0 by default on Android.
Evgeniy Stepanov [Tue, 13 Sep 2016 22:25:44 +0000 (22:25 +0000)]
[asan] alloc_dealloc_mismatch=0 by default on Android.

All known (to me) Android deployments are disabling this flag anyway.
The in-tree script (asan_device_setup) does that, too.

llvm-svn: 281410

7 years ago[asan] Remove lit -j5 flag for android tests.
Evgeniy Stepanov [Tue, 13 Sep 2016 22:25:41 +0000 (22:25 +0000)]
[asan] Remove lit -j5 flag for android tests.

It makes the tests extremely slow due to high latency of the test launcher.
The main reason for -j5 was high memory usage with handle_abort=1, which
is now disabled in the test runner.

llvm-svn: 281409

7 years agoFix a FIXME about MSVC 2013 in the diagnostic doc generation code
Reid Kleckner [Tue, 13 Sep 2016 22:22:56 +0000 (22:22 +0000)]
Fix a FIXME about MSVC 2013 in the diagnostic doc generation code

Ultimately it boiled down to adding a move constructor.

llvm-svn: 281408

7 years ago[AArch64] Simplify patchpoint/stackmap size test (r281301). NFC.
Ahmed Bougacha [Tue, 13 Sep 2016 22:16:40 +0000 (22:16 +0000)]
[AArch64] Simplify patchpoint/stackmap size test (r281301). NFC.

llvm-svn: 281407

7 years ago[CUDA] Do not merge CUDA target attributes.
Artem Belevich [Tue, 13 Sep 2016 22:16:30 +0000 (22:16 +0000)]
[CUDA] Do not merge CUDA target attributes.

CUDA target attributes are used for function overloading and must not be merged.

This fixes a bug where attributes were inherited during function template
specialization in CUDA and made it impossible for specialized function
to provide its own target attributes.

Differential Revision: https://reviews.llvm.org/D24522

llvm-svn: 281406

7 years ago[CodeGen] Fix an assert in EmitNullConstant.
Akira Hatanaka [Tue, 13 Sep 2016 22:13:02 +0000 (22:13 +0000)]
[CodeGen] Fix an assert in EmitNullConstant.

r235815 changed CGRecordLowering::accumulateBases to ignore non-virtual
bases of size 0, which prevented adding those non-virtual bases to
CGRecordLayout's NonVirtualBases. This caused clang to assert when
CGRecordLayout::getNonVirtualBaseLLVMFieldNo was called in
EmitNullConstant. This commit fixes the bug by ignoring zero-sized
non-virtual bases in EmitNullConstant.

rdar://problem/28100139

Differential Revision: https://reviews.llvm.org/D24312

llvm-svn: 281405

7 years agoObjectiveC Generics: follow-up commit to r281355.
Manman Ren [Tue, 13 Sep 2016 21:57:28 +0000 (21:57 +0000)]
ObjectiveC Generics: follow-up commit to r281355.

Correct getExtraLocalDataSize for ObjCTypeParamTypeLoc.

rdar://24619481
rdar://25060179

llvm-svn: 281404

7 years ago[CodeGen] Fix invalid shift in mul expansion
Pawel Bylica [Tue, 13 Sep 2016 21:55:41 +0000 (21:55 +0000)]
[CodeGen] Fix invalid shift in mul expansion

Summary: When expanding mul in type legalization make sure the type for shift amount can actually fit the value. This fixes PR30354 https://llvm.org/bugs/show_bug.cgi?id=30354.

Reviewers: hfinkel, majnemer, RKSimon

Subscribers: RKSimon, llvm-commits

Differential Revision: https://reviews.llvm.org/D24478

llvm-svn: 281403

7 years ago[DAG] Allow build-to-shuffle combine to combine builds from two wide vectors.
Michael Kuperstein [Tue, 13 Sep 2016 21:53:32 +0000 (21:53 +0000)]
[DAG] Allow build-to-shuffle combine to combine builds from two wide vectors.

This allows us to, in some cases, create a vector_shuffle out of a build_vector, when
the inputs to the build are extract_elements from two different vectors, at least one
of which is wider than the output. (E.g. a <8 x i16> being constructed out of
elements from a <16 x i16> and a <8 x i16>).

Differential Revision: https://reviews.llvm.org/D24491

llvm-svn: 281402

7 years agoTemporary fix for MS _Interlocked intrinsics
Albert Gutowski [Tue, 13 Sep 2016 21:51:37 +0000 (21:51 +0000)]
Temporary fix for MS _Interlocked intrinsics

llvm-svn: 281401

7 years agoNext set of additional error checks for invalid Mach-O files for bad load commands
Kevin Enderby [Tue, 13 Sep 2016 21:42:28 +0000 (21:42 +0000)]
Next set of additional error checks for invalid Mach-O files for bad load commands
that use the Mach::dyld_info_command type for the load commands that are
currently use in the MachOObjectFile constructor.

This contains the missing checks for LC_DYLD_INFO and
LC_DYLD_INFO_ONLY load commands and the fields for the
Mach::dyld_info_command type.

llvm-svn: 281400

7 years agoReverse commit 281375 (breaks building Chromium)
Albert Gutowski [Tue, 13 Sep 2016 21:24:51 +0000 (21:24 +0000)]
Reverse commit 281375 (breaks building Chromium)

llvm-svn: 281399

7 years agoCleaned up some of the "frame diagnose" code to use Operands as currency.
Sean Callanan [Tue, 13 Sep 2016 21:18:27 +0000 (21:18 +0000)]
Cleaned up some of the "frame diagnose" code to use Operands as currency.

Also added some utility functions around Operands to make code easier and more
compact to write.

llvm-svn: 281398

7 years ago[Hexagon] Better handling of HVX vector lowering
Krzysztof Parzyszek [Tue, 13 Sep 2016 21:16:07 +0000 (21:16 +0000)]
[Hexagon] Better handling of HVX vector lowering

- Expand SELECT_CC and BR_CC for vector types.
- Implement TLI::isShuffleMaskLegal.

llvm-svn: 281397

7 years agocmake: PollyPPCG depends on PollyISL
Tobias Grosser [Tue, 13 Sep 2016 21:09:35 +0000 (21:09 +0000)]
cmake: PollyPPCG depends on PollyISL

This line makes BUILD_SHARED_LIBS=ON work for Polly-ACC. Without it, ld
complains about missing isl symbols when constructing the shared library.

llvm-svn: 281396

7 years agoTry harder to not inline dllimport functions referencing non-dllimport functions
Hans Wennborg [Tue, 13 Sep 2016 21:08:20 +0000 (21:08 +0000)]
Try harder to not inline dllimport functions referencing non-dllimport functions

In r246338, code was added to check for this, but it failed to take into
account implicit destructor invocations because those are not reflected
in the AST. This adds a separate check for them.

llvm-svn: 281395

7 years ago[ELF] Set EF_ARM_EABI_VER5 for ARM
Rui Ueyama [Tue, 13 Sep 2016 20:51:32 +0000 (20:51 +0000)]
[ELF] Set EF_ARM_EABI_VER5 for ARM

Without this flag set, an AArch64 Linux kernel won't try to load the executable
(even if a 32 bit arm kernel will run the binary just fine).

Patch by Martin Storsjö!

Differential revision: https://reviews.llvm.org/D24471

llvm-svn: 281394

7 years agoSplit scanVersionScript. NFC.
Rui Ueyama [Tue, 13 Sep 2016 20:51:30 +0000 (20:51 +0000)]
Split scanVersionScript. NFC.

llvm-svn: 281393

7 years ago[asan] Reify ErrorSanitizerGetAllocatedSizeNotOwned
Filipe Cabecinhas [Tue, 13 Sep 2016 20:47:42 +0000 (20:47 +0000)]
[asan] Reify ErrorSanitizerGetAllocatedSizeNotOwned

Summary: Continuing implementation mentioned in this thread: http://lists.llvm.org/pipermail/llvm-dev/2016-July/101933.html

Reviewers: kcc, eugenis, vitalybuka

Subscribers: llvm-commits, kubabrecka

Differential Revision: https://reviews.llvm.org/D24392

llvm-svn: 281392

7 years ago[asan] Reify ErrorMallocUsableSizeNotOwned
Filipe Cabecinhas [Tue, 13 Sep 2016 20:47:37 +0000 (20:47 +0000)]
[asan] Reify ErrorMallocUsableSizeNotOwned

Summary: Continuing implementation mentioned in this thread: http://lists.llvm.org/pipermail/llvm-dev/2016-July/101933.html

Reviewers: kcc, eugenis, vitalybuka

Subscribers: llvm-commits, kubabrecka

Differential Revision: https://reviews.llvm.org/D24391

llvm-svn: 281391

7 years ago[asan] Reify ErrorAllocTypeMismatch
Filipe Cabecinhas [Tue, 13 Sep 2016 20:47:33 +0000 (20:47 +0000)]
[asan] Reify ErrorAllocTypeMismatch

Summary: Continuing implementation mentioned in this thread: http://lists.llvm.org/pipermail/llvm-dev/2016-July/101933.html

Reviewers: kcc, eugenis, vitalybuka

Subscribers: llvm-commits, kubabrecka

Differential Revision: https://reviews.llvm.org/D24390

llvm-svn: 281390

7 years ago[asan] Reify ErrorFreeNotMalloced
Filipe Cabecinhas [Tue, 13 Sep 2016 20:47:29 +0000 (20:47 +0000)]
[asan] Reify ErrorFreeNotMalloced

Summary: Continuing implementation mentioned in this thread: http://lists.llvm.org/pipermail/llvm-dev/2016-July/101933.html

Reviewers: kcc, eugenis, vitalybuka

Subscribers: llvm-commits, kubabrecka

Differential Revision: https://reviews.llvm.org/D24389

llvm-svn: 281389

7 years agoAdd comments.
Rui Ueyama [Tue, 13 Sep 2016 20:41:06 +0000 (20:41 +0000)]
Add comments.

llvm-svn: 281388

7 years agoAdd some unit tests for ArchSpec.
Zachary Turner [Tue, 13 Sep 2016 20:40:26 +0000 (20:40 +0000)]
Add some unit tests for ArchSpec.

I'm was trying to do some cleanup and code modernization and in
doing so I needed to change ParseMachCPUDashSubtypeTriple to take
a StringRef.  To ensure I don't break anything, I'm adding some
unit tests for this function.  As a side benefit, this also expands
test coverage of this function to all platforms, since in general
this code would rarely be exercised on non Mac platforms, and never
in the test suite.

llvm-svn: 281387

7 years agoadd tests for PR28672
Sanjay Patel [Tue, 13 Sep 2016 20:36:13 +0000 (20:36 +0000)]
add tests for PR28672

I'm not sure if we actually want to transform all of these in InstCombine yet,
so I'm not labeling these with FIXME.

llvm-svn: 281386

7 years agoRemove excessive padding from PTHWriter
Alexander Shaposhnikov [Tue, 13 Sep 2016 20:17:57 +0000 (20:17 +0000)]
Remove excessive padding from PTHWriter

The class PTHWriter is in lib/Frontend/CacheTokens.cpp
inside the anonymous namespace.
This diff changes the order of fields an removes excessive padding.
Test plan: make -j8 check-clang

Differential revision: https://reviews.llvm.org/D23902

llvm-svn: 281385

7 years ago[SE] Use real HostPlatformDevice for testing
Jason Henline [Tue, 13 Sep 2016 20:14:44 +0000 (20:14 +0000)]
[SE] Use real HostPlatformDevice for testing

Summary:
Replace uses of SimpleHostPlatformDevice in tests with
HostPlatformDevice.

Reviewers: jlebar

Subscribers: jlebar, jprice, parallel_libs-commits

Differential Revision: https://reviews.llvm.org/D24519

llvm-svn: 281384

7 years ago[SemaObjC] Be more strict while parsing type arguments and protocols
Bruno Cardoso Lopes [Tue, 13 Sep 2016 20:04:35 +0000 (20:04 +0000)]
[SemaObjC] Be more strict while parsing type arguments and protocols

Fix a crash-on-invalid.

When parsing type arguments and protocols,
parseObjCTypeArgsOrProtocolQualifiers() calls ParseTypeName(), which tries to
find matching tokens for '[', '(', etc whenever they appear among potential
type names. If unmatched, ParseTypeName() yields a tok::eof token stream. This
leads to crashes since the parsing at this point is not expected to go beyond
the param list closing '>'.

Fix that by properly handling tok::eof in
parseObjCTypeArgsOrProtocolQualifiers() callers.

Differential Revision: https://reviews.llvm.org/D23852

rdar://problem/25063557

llvm-svn: 281383

7 years agoWork around MSVC 2013's inability to default move special members.
Richard Smith [Tue, 13 Sep 2016 20:00:02 +0000 (20:00 +0000)]
Work around MSVC 2013's inability to default move special members.

llvm-svn: 281382

7 years agoInline small funciton.
Rui Ueyama [Tue, 13 Sep 2016 19:56:27 +0000 (19:56 +0000)]
Inline small funciton.

llvm-svn: 281381

7 years agoFix comments.
Rui Ueyama [Tue, 13 Sep 2016 19:56:25 +0000 (19:56 +0000)]
Fix comments.

llvm-svn: 281380

7 years agoReapply "InstCombine: Reduce trunc (shl x, K) width."
Matt Arsenault [Tue, 13 Sep 2016 19:43:57 +0000 (19:43 +0000)]
Reapply "InstCombine: Reduce trunc (shl x, K) width."

This reapplies r272987 with a fix for infinitely looping
when the truncated value is another shift of a constant.

llvm-svn: 281379

7 years agoAdd bunch of _Interlocked builtins
Albert Gutowski [Tue, 13 Sep 2016 19:43:33 +0000 (19:43 +0000)]
Add bunch of _Interlocked builtins

Reviewers: compnerd, thakis, Prazek, majnemer, rnk

Subscribers: cfe-commits

Differential Revision: https://reviews.llvm.org/D24153

llvm-svn: 281378

7 years ago[SE] Host platform implementation
Jason Henline [Tue, 13 Sep 2016 19:28:02 +0000 (19:28 +0000)]
[SE] Host platform implementation

Summary:
This implementation does not currently support multiple concurrent streams, and
it won't allow kernels to be launched with grids larger than one block or
blocks larger than one thread. These limitations could be removed in the future
by launching new threads on the host, but that is not done in this
implementation.

Reviewers: jlebar

Subscribers: beanz, mgorny, jprice, parallel_libs-commits

Differential Revision: https://reviews.llvm.org/D24473

llvm-svn: 281377

7 years agoAArch64: Cleanup tailcall CC check, enable swiftcc.
Matthias Braun [Tue, 13 Sep 2016 19:27:38 +0000 (19:27 +0000)]
AArch64: Cleanup tailcall CC check, enable swiftcc.

Cleanup/change the code that checks for possible tailcall conventions to
look the same as the one in the X86 target. This makes the distinction
between calling conventions that can guarnatee tailcalls and the ones
that may tailcall more obvious.

- Add Swift to the mayTailCall list
- PreserveMost seemed to be incorrectly part of the guarnteed tail call
  list, move it to the mayTailCall list.

llvm-svn: 281376

7 years agoAdd some MS aliases for existing intrinsics
Albert Gutowski [Tue, 13 Sep 2016 19:26:42 +0000 (19:26 +0000)]
Add some MS aliases for existing intrinsics

Reviewers: thakis, compnerd, majnemer, rsmith, rnk

Subscribers: cfe-commits

Differential Revision: https://reviews.llvm.org/D24330

llvm-svn: 281375

7 years ago[SE] Add .clang-format
Jason Henline [Tue, 13 Sep 2016 19:25:43 +0000 (19:25 +0000)]
[SE] Add .clang-format

Summary:
The .clang-tidy file is copied from the top-level LLVM source directory.

Also fix warnings generated by clang-format:

* Moved SimpleHostPlatformDevice.h so its header include guard could
  have the right format.
* Changed signatures of methods taking llvm::Twine by value to take it
  by const ref instead.
* Add "noexcept" to some move constructors and assignment operators.
* Removed a bunch of places where single-statement loops and
  conditionals were surrounded with braces. (This was not found by the
  current clang-tidy, but with a local patch that I hope to upstream
  soon.)

Reviewers: jlebar, jprice

Subscribers: parallel_libs-commits

Differential Revision: https://reviews.llvm.org/D24468

llvm-svn: 281374

7 years ago[analyzer] Fix ExprEngine::VisitMemberExpr
Alexander Shaposhnikov [Tue, 13 Sep 2016 19:17:20 +0000 (19:17 +0000)]
[analyzer] Fix ExprEngine::VisitMemberExpr

AST may contain intermediate ParenExpr nodes
between MemberExpr and ArrayToPointerDecay.
This diff adjusts the check in ExprEngine::VisitMemberExpr accordingly.
Test plan: make -j8 check-clang-analysis

Differential revision: https://reviews.llvm.org/D24484

llvm-svn: 281373

7 years agoAMDGPU: Remove code I think is dead
Matt Arsenault [Tue, 13 Sep 2016 19:15:25 +0000 (19:15 +0000)]
AMDGPU: Remove code I think is dead

As far as I can tell, resolveFrameIndex is supposed to be
called with a legal offset, so inserting an add shouldn't be
necessary.

llvm-svn: 281372

7 years agoSwitch to 64-bit allocator on android/aarch64.
Evgeniy Stepanov [Tue, 13 Sep 2016 19:05:33 +0000 (19:05 +0000)]
Switch to 64-bit allocator on android/aarch64.

This uses the "very compact" size class mapping that fits in the
39-bit address space.

llvm-svn: 281371

7 years ago.clang-tidy: correct style name is 'camelBack' not 'lowerCase'.
Mike Aizatsky [Tue, 13 Sep 2016 19:04:26 +0000 (19:04 +0000)]
.clang-tidy: correct style name is 'camelBack' not 'lowerCase'.

Summary: clang-tidy doesn't like to complain.

Differential Revision: https://reviews.llvm.org/D24413

llvm-svn: 281370

7 years agoAMDGPU: Support commuting a FrameIndex operand
Matt Arsenault [Tue, 13 Sep 2016 19:03:12 +0000 (19:03 +0000)]
AMDGPU: Support commuting a FrameIndex operand

llvm-svn: 281369

7 years ago[LV] Clean up uniform induction variable analysis (NFC)
Matthew Simpson [Tue, 13 Sep 2016 19:01:45 +0000 (19:01 +0000)]
[LV] Clean up uniform induction variable analysis (NFC)

llvm-svn: 281368

7 years ago[clang-cl] Diagnose duplicate uuids.
Nico Weber [Tue, 13 Sep 2016 18:55:26 +0000 (18:55 +0000)]
[clang-cl] Diagnose duplicate uuids.

This mostly behaves cl.exe's behavior, even though clang-cl is stricter in some
corner cases and more lenient in others (see the included test).

To make the uuid declared previously here diagnostic work correctly, tweak
stripTypeAttributesOffDeclSpec() to keep attributes in the right order.

https://reviews.llvm.org/D24469

llvm-svn: 281367

7 years ago[LTO] Don't pass SF_Undefined symbols to the IRmover.
Davide Italiano [Tue, 13 Sep 2016 18:45:13 +0000 (18:45 +0000)]
[LTO] Don't pass SF_Undefined symbols to the IRmover.

This should fix PR 30363.

llvm-svn: 281366

7 years agoFix MSVC 2013 build by using our <thread> wrapper header
Reid Kleckner [Tue, 13 Sep 2016 18:40:04 +0000 (18:40 +0000)]
Fix MSVC 2013 build by using our <thread> wrapper header

llvm-svn: 281365

7 years ago[asan] Re-poison all redzones on activation.
Evgeniy Stepanov [Tue, 13 Sep 2016 18:38:40 +0000 (18:38 +0000)]
[asan] Re-poison all redzones on activation.

When running with start_deactivated=1 in ASAN_OPTIONS, heap redzones
are not poisoned until the first instrumented module is loaded. This
can cause false negatives even on memory allocated after activation,
because redzones are normally poisoned only once when a new allocator
region is mapped.

This change attempts to fix it by iterating over all existing
allocator chunks and poisoning their redzones.

llvm-svn: 281364

7 years agoWork around a GCC 4.7-specific issue: due to implementing older rules for
Richard Smith [Tue, 13 Sep 2016 18:35:34 +0000 (18:35 +0000)]
Work around a GCC 4.7-specific issue: due to implementing older rules for
implicit declarations of move operations, GCC 4.7 would find that SelectPiece
has neither a move constructor nor a copy constructor. The copy constructor was
(correctly) deleted because the class has a member of move-only type, and the
move constructor was (incorrectly, per current C++ rules) not provided because
the class has a copy-only base class (in turn because it explicitly declares a
destructor).

llvm-svn: 281363

7 years ago[DAGCombiner] Use APInt directly in (shl (zext (srl x, C)), C) combine range test
Simon Pilgrim [Tue, 13 Sep 2016 18:33:29 +0000 (18:33 +0000)]
[DAGCombiner] Use APInt directly in (shl (zext (srl x, C)), C) combine range test

To avoid assertion, we must ensure that the inner shift constant is within range before calling ConstantSDNode::getZExtValue(). We already know that the outer shift constant is in range.

Followup to D23007

llvm-svn: 281362

7 years agoRevert r281336 (and r281337), it caused PR30372.
Nico Weber [Tue, 13 Sep 2016 18:17:00 +0000 (18:17 +0000)]
Revert r281336 (and r281337), it caused PR30372.

llvm-svn: 281361

7 years agoSome more pointer safety in Breakpoint.
Zachary Turner [Tue, 13 Sep 2016 17:53:38 +0000 (17:53 +0000)]
Some more pointer safety in Breakpoint.

Plumb unique_ptrs<> all the way through the baton interface.
NFC, this is a minor improvement to remove the possibility of an
accidental pointer ownership issue.

Reviewed By: jingham
Differential Revision: https://reviews.llvm.org/D24495

llvm-svn: 281360

7 years ago[Myriad]: set LeonCASA processor feature
Douglas Katzman [Tue, 13 Sep 2016 17:51:41 +0000 (17:51 +0000)]
[Myriad]: set LeonCASA processor feature

llvm-svn: 281359

7 years agoObjectiveC Generics: Start using ObjCTypeParamType.
Manman Ren [Tue, 13 Sep 2016 17:41:05 +0000 (17:41 +0000)]
ObjectiveC Generics: Start using ObjCTypeParamType.

For ObjC type parameter, we used to have TypedefType that is canonicalized to
id or the bound type. We can't represent "T <protocol>" and thus will lose
the type information in the following example:
@interface MyMutableDictionary<KeyType, ObjectType> : NSObject
- (void)setObject:(ObjectType)obj forKeyedSubscript:(KeyType <NSCopying>)key;
@end
MyMutableDictionary<NSString *, NSString *> *stringsByString;
NSNumber *n1, *n2;
stringsByString[n1] = n2;
--> no warning on type mismatch of the key.

To fix the problem, we introduce a new type ObjCTypeParamType that supports
a list of protocol qualifiers.

We create ObjCTypeParamType for ObjCTypeParamDecl when we create
ObjCTypeParamDecl. We also substitute ObjCTypeParamType instead of TypedefType
on an ObjCTypeParamDecl.

rdar://24619481
rdar://25060179

Differential Revision: http://reviews.llvm.org/D23080

llvm-svn: 281358

7 years agoAMDGPU: Fix target options fp32/64-denormals
Yaxun Liu [Tue, 13 Sep 2016 17:37:09 +0000 (17:37 +0000)]
AMDGPU: Fix target options fp32/64-denormals

Fix target options for fp32/64-denormals so that

+fp64-denormals is set if fp64 is supported
-fp32-denormals if fp32 denormals is not supported, or -cl-denorms-are-zero is set
+fp32-denormals if fp32 denormals is supported and -cl-denorms-are-zero is not set

If target feature fp32/64-denormals is explicitly set, they will override default options and options deduced from -cl-denorms-are-zero.

Differential Revision: https://reviews.llvm.org/D24512

llvm-svn: 281357

7 years ago[X86][SSE] Added AVX512F and additional vector truncate test cases
Simon Pilgrim [Tue, 13 Sep 2016 17:34:56 +0000 (17:34 +0000)]
[X86][SSE] Added AVX512F and additional vector truncate test cases

trunc16i16_16i8 is currently commented out due to PR25684

llvm-svn: 281356

7 years agoObjectiveC generics: Add ObjCTypeParamType in the type system.
Manman Ren [Tue, 13 Sep 2016 17:25:08 +0000 (17:25 +0000)]
ObjectiveC generics: Add ObjCTypeParamType in the type system.

We also need to add ObjCTypeParamTypeLoc. ObjCTypeParamType supports the
representation of "T <protocol>" where T is a type parameter. Before this,
we use TypedefType to represent the type parameter for ObjC.

ObjCTypeParamType has "ObjCTypeParamDecl *OTPDecl" and it extends from
ObjCProtocolQualifiers. It is a non-canonical type and is canonicalized
to the underlying type with the protocol qualifiers.

rdar://24619481
rdar://25060179

Differential Revision: http://reviews.llvm.org/D23079

llvm-svn: 281355

7 years ago[DAGCombiner] Use APInt directly in (shl (ext (shl x, c1)), c2) combine
Simon Pilgrim [Tue, 13 Sep 2016 17:15:28 +0000 (17:15 +0000)]
[DAGCombiner] Use APInt directly in (shl (ext (shl x, c1)), c2) combine

Fix failure to detect out of range shift constants leading to assert in ConstantSDNode::getZExtValue()

Followup to D23007

llvm-svn: 281354

7 years agoObjectiveC: Refactor applyObjCProtocolQualifiers.
Manman Ren [Tue, 13 Sep 2016 17:03:12 +0000 (17:03 +0000)]
ObjectiveC: Refactor applyObjCProtocolQualifiers.

To construct the canonical type of ObjCTypeParamType, we need to apply
qualifiers on ObjCObjectPointerType. The updated applyObjCProtocolQualifiers
handles this case by merging the protocol lists, constructing a new
ObjCObjectType, then a new ObjCObjectPointerType.

rdar://24619481
rdar://25060179

Differential Revision: http://reviews.llvm.org/D24059

llvm-svn: 281353

7 years agofixup Xcode build for removal of MIUtilParse.*
Todd Fiala [Tue, 13 Sep 2016 16:53:07 +0000 (16:53 +0000)]
fixup Xcode build for removal of MIUtilParse.*

llvm-svn: 281352

7 years agoAdd a class ObjCProtocolQualifiers to wrap APIs for ObjC protocol list.
Manman Ren [Tue, 13 Sep 2016 16:45:29 +0000 (16:45 +0000)]
Add a class ObjCProtocolQualifiers to wrap APIs for ObjC protocol list.

Now ObjCObjectType extends from ObjCProtocolQualifiers. We save number of
protocols in ObjCProtocolQualifiers.

This is in preparation of adding a new type class ObjCTypeParamType that
can take protocol qualifiers.

rdar://24619481
rdar://25060179

Differential Revision: http://reviews.llvm.org/D23078

llvm-svn: 281351

7 years agoFix misleading comment for getOrEnforceKnownAlignment
Matt Arsenault [Tue, 13 Sep 2016 16:39:43 +0000 (16:39 +0000)]
Fix misleading comment for getOrEnforceKnownAlignment

It does not return 0 to indicate failure, and returns the known
alignment.

llvm-svn: 281350

7 years agoFix a merge mishap in rL281348
Dimitar Vlahovski [Tue, 13 Sep 2016 16:22:15 +0000 (16:22 +0000)]
Fix a merge mishap in rL281348

llvm-svn: 281349

7 years agoMinidumpParsing: pid, modules, exceptions, strings
Dimitar Vlahovski [Tue, 13 Sep 2016 15:54:38 +0000 (15:54 +0000)]
MinidumpParsing: pid, modules, exceptions, strings

Summary:
Added parsing of the MiscInfo data stream.
The main member of it that we care about is the process_id
On Linux generated Minidump (from breakpad) we don't have
the MiscInfo, we have the /proc/$pid/status from where we can get the
pid.
Also parsing the module list - the list of all of the loaded
modules/shared libraries.
Parsing the exception stream.
Parsing MinidumpStrings.

I have unit tests for all of that.
Also added some tests using a Minidump generated from Windows tools (not
from breakpad)

Reviewers: labath, zturner

Subscribers: beanz, lldb-commits

Differential Revision: https://reviews.llvm.org/D24385

llvm-svn: 281348

7 years ago[SE] Stop using llvm-config --cxxflags
Jason Henline [Tue, 13 Sep 2016 15:44:18 +0000 (15:44 +0000)]
[SE] Stop using llvm-config --cxxflags

Summary:
Build configuration was adding $(llvm-config --cxxflags) to the
StreamExecutor CXXFLAGS, but this was causing "-O3" to be passed even
for debug builds, and was making debugging difficult.

The llvm-config call was originally introduced to handle the -fno-rtti
flag because an RTTI StreamExecutor could not link with a no-RTTI LLVM.
This patch converts to using LLVM_ENABLE_RTTI and only adding the
`-fno-rtti` flag if needed, not all the rest of the LLVM CXXFLAGS.

I have tested this with clang-4.0 and gcc-4.8 on Ubuntu. Some work will
probably have to be done to support MSVC.

Reviewers: jlebar

Subscribers: beanz, jprice, parallel_libs-commits, mgorny

Differential Revision: https://reviews.llvm.org/D24474

llvm-svn: 281347

7 years agoTraversing template paramter lists of DeclaratorDecls and/or TagDecls.
Nico Weber [Tue, 13 Sep 2016 15:05:04 +0000 (15:05 +0000)]
Traversing template paramter lists of DeclaratorDecls and/or TagDecls.

The unit tests in this patch demonstrate the need to traverse template
parameter lists of DeclaratorDecls (e.g. VarDecls, CXXMethodDecls) and
TagDecls (e.g. EnumDecls, RecordDecls).

Fixes PR29042.
https://reviews.llvm.org/D24268

Patch from Lukasz
Łukasz Anforowicz <lukasza@chromium.org>!

llvm-svn: 281345

7 years agoRemove redundant comma around parenthesis in parameter list.
Eric Liu [Tue, 13 Sep 2016 15:02:43 +0000 (15:02 +0000)]
Remove redundant comma around parenthesis in parameter list.

Reviewers: djasper

Subscribers: cfe-commits, klimek

Differential Revision: https://reviews.llvm.org/D24501

llvm-svn: 281344

7 years ago[ConstantFold] Improve the bitcast folding logic for constant vectors.
Andrea Di Biagio [Tue, 13 Sep 2016 14:50:47 +0000 (14:50 +0000)]
[ConstantFold] Improve the bitcast folding logic for constant vectors.

The constant folder didn't know how to always fold bitcasts of constant integer
vectors. In particular, it was unable to handle the case where a constant vector
had some undef elements, and the resulting (i.e. bitcasted) vector type had more
elements than the original vector type.

Example:
  %cast = bitcast <2 x i64><i64 undef, i64 2> to <4 x i32>

On a little endian target, %cast could have been folded to:
  <4 x i32><i32 undef, i32 undef, i32 2, i32 0>

This patch improves the folding logic by teaching how to correctly propagate
undef elements in the folded vector.

Differential Revision: https://reviews.llvm.org/D24301

llvm-svn: 281343

7 years ago[asan] Add missing include for rand()
Jonas Hahnfeld [Tue, 13 Sep 2016 14:42:40 +0000 (14:42 +0000)]
[asan] Add missing include for rand()

llvm-svn: 281342

7 years ago[X86] Regenerated shift combine tests.
Simon Pilgrim [Tue, 13 Sep 2016 14:41:39 +0000 (14:41 +0000)]
[X86] Regenerated shift combine tests.

Added x86_64 tests

llvm-svn: 281341

7 years ago[modules] Re-enable some previously excluded files.
Vassil Vassilev [Tue, 13 Sep 2016 14:41:35 +0000 (14:41 +0000)]
[modules] Re-enable some previously excluded files.

Our modules support seems to be able to handle them nowadays.

Patch by Cristina Cristescu!

llvm-svn: 281340

7 years ago[Hexagon] Clear the flow queue after visiting a single instruction
Krzysztof Parzyszek [Tue, 13 Sep 2016 14:36:55 +0000 (14:36 +0000)]
[Hexagon] Clear the flow queue after visiting a single instruction

llvm-svn: 281339

7 years agoEnable merging of SHF_MERGE sections with linker scripts.
Rafael Espindola [Tue, 13 Sep 2016 14:23:14 +0000 (14:23 +0000)]
Enable merging of SHF_MERGE sections with linker scripts.

This also fixes the related problem of non SHF_MERGE sections with
different flags not being merged.

Fixes pr30355.

llvm-svn: 281338

7 years agoApply Clang-format to MCAsmParser.cpp NFC.
Nirav Dave [Tue, 13 Sep 2016 13:57:16 +0000 (13:57 +0000)]
Apply Clang-format to MCAsmParser.cpp NFC.

llvm-svn: 281337

7 years agoDefer asm errors to post-statement failure
Nirav Dave [Tue, 13 Sep 2016 13:55:06 +0000 (13:55 +0000)]
Defer asm errors to post-statement failure

Recommitting after fixing AsmParser Initialization.

Allow errors to be deferred and emitted as part of clean up to simplify
and shorten Assembly parser code. This will allow error messages to be
emitted in helper functions and be modified by the caller which has
better context.

As part of this many minor cleanups to the Parser:

* Unify parser cleanup on error
* Add Workaround for incorrect return values in ParseDirective instances
* Tighten checks on error-signifying return values for parser functions
  and fix in-tree TargetParsers to be more consistent with the changes.
* Fix AArch64 test cases checking for spurious error messages that are
  now fixed.

These changes should be backwards compatible with current Target Parsers
so long as the error status are correctly returned in appropriate
functions.

Reviewers: rnk, majnemer

Subscribers: aemerson, jyknight, llvm-commits

Differential Revision: https://reviews.llvm.org/D24047

llvm-svn: 281336

7 years ago[LoopInterchange] Minor refactor. NFC.
Chad Rosier [Tue, 13 Sep 2016 13:30:30 +0000 (13:30 +0000)]
[LoopInterchange] Minor refactor. NFC.

llvm-svn: 281334

7 years agoGPGPU: Use const_cast to avoid compiler warning [NFC]
Tobias Grosser [Tue, 13 Sep 2016 13:22:27 +0000 (13:22 +0000)]
GPGPU: Use const_cast to avoid compiler warning [NFC]

llvm-svn: 281333

7 years ago[InstSimplify] Add tests to show missed bitcast folding opportunities.
Andrea Di Biagio [Tue, 13 Sep 2016 13:17:42 +0000 (13:17 +0000)]
[InstSimplify] Add tests to show missed bitcast folding opportunities.

InstSimplify doesn't always know how to fold a bitcast of a constant vector.
In particular, the logic in InstSimplify doesn't know how to handle the case
where the constant vector in input contains some undef elements, and the
number of elements is smaller than the number of elements of the bitcast
vector type.

llvm-svn: 281332

7 years agoDon't use else if after return. Tidy comments. NFC.
Chad Rosier [Tue, 13 Sep 2016 13:08:53 +0000 (13:08 +0000)]
Don't use else if after return. Tidy comments. NFC.

llvm-svn: 281331

7 years agoTypo. NFC.
Chad Rosier [Tue, 13 Sep 2016 13:00:29 +0000 (13:00 +0000)]
Typo. NFC.

llvm-svn: 281330

7 years agoRefactor duplicated code. NFC.
Rafael Espindola [Tue, 13 Sep 2016 13:00:06 +0000 (13:00 +0000)]
Refactor duplicated code. NFC.

llvm-svn: 281329

7 years ago[LoopInterchange] Tidy up and remove unnecessary dyn_casts. NFC.
Chad Rosier [Tue, 13 Sep 2016 12:56:04 +0000 (12:56 +0000)]
[LoopInterchange] Tidy up and remove unnecessary dyn_casts. NFC.

llvm-svn: 281328

7 years agoRevert "[ARM] Promote small global constants to constant pools"
James Molloy [Tue, 13 Sep 2016 12:45:51 +0000 (12:45 +0000)]
Revert "[ARM] Promote small global constants to constant pools"

This reverts commit r281314. Speculatively revert as it's possible this caused linker errors: http://lab.llvm.org:8011/builders/clang-native-arm-lnt/builds/19656

llvm-svn: 281327

7 years agoRemove InstCombine test file
Sam Parker [Tue, 13 Sep 2016 12:33:06 +0000 (12:33 +0000)]
Remove InstCombine test file

My previous commit should of removed a test file but I missed it.

llvm-svn: 281326

7 years agoTurn createKey into a static helper. NFC.
Rafael Espindola [Tue, 13 Sep 2016 12:25:30 +0000 (12:25 +0000)]
Turn createKey into a static helper. NFC.

llvm-svn: 281325

7 years ago[ARM] Add ".code 32" to functions in the ARM instruction set
Pablo Barrio [Tue, 13 Sep 2016 12:18:15 +0000 (12:18 +0000)]
[ARM] Add ".code 32" to functions in the ARM instruction set

Before, only Thumb functions were marked as ".code 16". These
".code x" directives are effective until the next directive of its
kind is encountered. Therefore, in code with interleaved ARM and
Thumb functions, it was possible to declare a function as ARM and
end up with a Thumb function after assembly. A test has been added.

An existing test has also been fixed to take this change into
account.

Reviewers: aschwaighofer, t.p.northover, jmolloy, rengolin

Subscribers: aemerson, rengolin, llvm-commits

Differential Revision: https://reviews.llvm.org/D24337

llvm-svn: 281324

7 years ago[Thumb] Teach ISel how to lower compares of AND bitmasks efficiently
James Molloy [Tue, 13 Sep 2016 12:12:32 +0000 (12:12 +0000)]
[Thumb] Teach ISel how to lower compares of AND bitmasks efficiently

For the common pattern (CMPZ (AND x, #bitmask), #0), we can do some more efficient instruction selection if the bitmask is one consecutive sequence of set bits (32 - clz(bm) - ctz(bm) == popcount(bm)).

1) If the bitmask touches the LSB, then we can remove all the upper bits and set the flags by doing one LSLS.
2) If the bitmask touches the MSB, then we can remove all the lower bits and set the flags with one LSRS.
3) If the bitmask has popcount == 1 (only one set bit), we can shift that bit into the sign bit with one LSLS and change the condition query from NE/EQ to MI/PL (we could also implement this by shifting into the carry bit and branching on BCC/BCS).
4) Otherwise, we can emit a sequence of LSLS+LSRS to remove the upper and lower zero bits of the mask.

1-3 require only one 16-bit instruction and can elide the CMP. 4 requires two 16-bit instructions but can elide the CMP and doesn't require materializing a complex immediate, so is also a win.

llvm-svn: 281323

7 years agoEnable simplify libcalls for ARM PCS
Sam Parker [Tue, 13 Sep 2016 12:10:14 +0000 (12:10 +0000)]
Enable simplify libcalls for ARM PCS

Teach SimplifyLibcalls that in can treat functions annotated with
apcs, aapcs or aapcs_vfp like normal C functions if they only take
and return integer or pointer values, and the target is not iOS.

Differential Revision: https://reviews.llvm.org/D24453

llvm-svn: 281322

7 years ago[llvm-cov] - Included footer "Generated by llvm-cov -- llvm version <version number...
Ying Yi [Tue, 13 Sep 2016 11:28:31 +0000 (11:28 +0000)]
[llvm-cov] - Included footer "Generated by llvm-cov -- llvm version <version number>" in the coverage report.

The llvm-cov version information will be useful to the user when comparing the code coverage across different versions of llvm-cov. This patch provides the llvm-cov version information in the generated coverage report.

Differential Revision: https://reviews.llvm.org/D24457

llvm-svn: 281321

7 years agoDelete dead code.
Rafael Espindola [Tue, 13 Sep 2016 11:28:22 +0000 (11:28 +0000)]
Delete dead code.

We already handle this is createSections.

llvm-svn: 281320

7 years ago[ARM] Support ldr.w in pseudo instruction ldr rd,=immediate
Peter Smith [Tue, 13 Sep 2016 11:15:51 +0000 (11:15 +0000)]
[ARM] Support ldr.w in pseudo instruction ldr rd,=immediate

The changes made in r269352, r269353 and r269354 to support the
transformation of the ldr rd,=immediate to mov introduced a regression
from 3.8 (ldr.w rd, =immediate) not supported.

This change puts support back in for ldr.w by means of a t2InstAlias for
the .w form. The .w is ignored in ARM state and propagated to the ldr in
Thumb2.

llvm-svn: 281319

7 years ago[ELF] - Versionscript: support mangled symbols with the same name.
George Rimar [Tue, 13 Sep 2016 10:45:39 +0000 (10:45 +0000)]
[ELF] - Versionscript: support mangled symbols with the same name.

This is PR30312. Info from bug page:

Both of these symbols demangle to abc::abc():
_ZN3abcC1Ev
_ZN3abcC2Ev
(These would be abc's complete object constructor and base object constructor, respectively.)
however with "abc::abc()" in the version script only one of the two receives the symbol version.

Patch fixes that.
It uses testcase created by Ed Maste (D24306).

Differential revision: https://reviews.llvm.org/D24336

llvm-svn: 281318

7 years agoRemove MIUtilParse (no longer used)
Pavel Labath [Tue, 13 Sep 2016 10:39:12 +0000 (10:39 +0000)]
Remove MIUtilParse (no longer used)

Summary: follow-up to https://reviews.llvm.org/D23882

Reviewers: dawn, krytarowski, labath, ki.stfu

Subscribers: beanz, mgorny, labath, ki.stfu, lldb-commits

Differential Revision: https://reviews.llvm.org/D23883
Author: Michał Górny <mgorny@gentoo.org>

llvm-svn: 281317

7 years agoRevert accidentally checked in change in r281315.
Vassil Vassilev [Tue, 13 Sep 2016 10:38:26 +0000 (10:38 +0000)]
Revert accidentally checked in change in r281315.

llvm-svn: 281316

7 years agoSimplify. NFC.
Vassil Vassilev [Tue, 13 Sep 2016 10:36:12 +0000 (10:36 +0000)]
Simplify. NFC.

llvm-svn: 281315

7 years ago[ARM] Promote small global constants to constant pools
James Molloy [Tue, 13 Sep 2016 10:28:11 +0000 (10:28 +0000)]
[ARM] Promote small global constants to constant pools

If a constant is unamed_addr and is only used within one function, we can save
on the code size and runtime cost of an indirection by changing the global's storage
to inside the constant pool. For example, instead of:

      ldr r0, .CPI0
      bl printf
      bx lr
    .CPI0: &format_string
    format_string: .asciz "hello, world!\n"

We can emit:

      adr r0, .CPI0
      bl printf
      bx lr
    .CPI0: .asciz "hello, world!\n"

This can cause significant code size savings when many small strings are used in one
function (4 bytes per string).

llvm-svn: 281314

7 years ago[clang-tidy] Fix naming in container-size-empty.
Kirill Bobyrev [Tue, 13 Sep 2016 10:19:13 +0000 (10:19 +0000)]
[clang-tidy] Fix naming in container-size-empty.

llvm-svn: 281313

7 years ago[WebAssembly] Trying to fix broken tests in CodeGen/WebAssembly caused by r281285.
Eric Liu [Tue, 13 Sep 2016 10:05:44 +0000 (10:05 +0000)]
[WebAssembly] Trying to fix broken tests in CodeGen/WebAssembly caused by r281285.

Reviewers: bkramer, ddcc, dschuff, sunfish

Subscribers: jfb, llvm-commits, dschuff

Differential Revision: https://reviews.llvm.org/D24497

llvm-svn: 281312