review.tizen.org Git - platform/upstream/libSkiaSharp.git/log

projects / platform / upstream / libSkiaSharp.git / log

humper@google.com [Tue, 9 Jul 2013 18:02:06 +0000 (18:02 +0000)]

Revert "More general image filter interface; tested implementation of standalone"

This reverts commit 4df3e8b079e019af5f60c13e7e6ec6589663962a.

git-svn-id: http://skia.googlecode.com/svn/trunk@9937 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

humper@google.com [Tue, 9 Jul 2013 17:48:15 +0000 (17:48 +0000)]

More general image filter interface; tested implementation of standalone
image scaler (not yet plumbed). High quality downsampler. Fast SSE
resampler.

BUG=
R=reed@google.com

Review URL: https://codereview.chromium.org/17381008

git-svn-id: http://skia.googlecode.com/svn/trunk@9936 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Tue, 9 Jul 2013 16:57:01 +0000 (16:57 +0000)]

Fix Win7 compiler warnings/errors in r9934

git-svn-id: http://skia.googlecode.com/svn/trunk@9935 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Tue, 9 Jul 2013 16:30:38 +0000 (16:30 +0000)]

Animated the PathUtils Sample to show path contours# Enter a description of the change.

Animated the PathUtils Sample to path contours

BUG=
R=reed@google.com, scroggo@google.com, djsollen@google.com

Author: dierk@google.com

Review URL: https://chromiumcodereview.appspot.com/18552005

git-svn-id: http://skia.googlecode.com/svn/trunk@9934 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Tue, 9 Jul 2013 16:04:32 +0000 (16:04 +0000)]

When gather pixel refs was broken, REPORTER_ASSERT(data) realized that data was NULL, but subsequent lines dereferenced it anyway, and so segfaulted.

R=reed@google.com, tomhudson@google.com

Author: tomhudson@chromium.org

Review URL: https://chromiumcodereview.appspot.com/18904003

git-svn-id: http://skia.googlecode.com/svn/trunk@9933 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

scroggo@google.com [Tue, 9 Jul 2013 15:48:24 +0000 (15:48 +0000)]

Allow ico decoder to decode PNG sub-images.

Since Windows Vista, PNG can be embedded in an ICO file. Update
our decoder to support this.

BUG=https://code.google.com/p/skia/issues/detail?id=1398
R=djsollen@google.com

Review URL: https://codereview.chromium.org/18655007

git-svn-id: http://skia.googlecode.com/svn/trunk@9932 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

scroggo@google.com [Tue, 9 Jul 2013 15:45:14 +0000 (15:45 +0000)]

Remove bitmap reuse from SkImageDecoder.

Now that Android is using an SkBitmap::Allocator to reuse bitmap
memory, remove the unnecessary code to handle bitmap reuse inside
the decoders themselves.

Leaves in the code for bitmap reuse in decodeSubset, which still
may reuse bitmaps, and cropBitmap, which is called by decodeSubset.

R=djsollen@google.com

Review URL: https://codereview.chromium.org/17620004

git-svn-id: http://skia.googlecode.com/svn/trunk@9931 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Tue, 9 Jul 2013 15:29:32 +0000 (15:29 +0000)]

move failable work outside of constructors for SkGlyphCache and SkScalerContextGDI. If we fail, try to purge everything and try again, in case the failure was from memory/os-resource exhaustion (e.g. out of HDC handles in windows)

BUG=

Review URL: https://codereview.chromium.org/18132009

git-svn-id: http://skia.googlecode.com/svn/trunk@9930 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Tue, 9 Jul 2013 15:03:59 +0000 (15:03 +0000)]

GM (and fix) for drawArc capping issue

https://codereview.chromium.org/18271003/

git-svn-id: http://skia.googlecode.com/svn/trunk@9928 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

humper@google.com [Tue, 9 Jul 2013 14:13:04 +0000 (14:13 +0000)]

add extra flag (currently unused) for high quality downsampling

BUG=
R=reed@google.com, robertphillips@google.com

Review URL: https://codereview.chromium.org/18386006

git-svn-id: http://skia.googlecode.com/svn/trunk@9927 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Tue, 9 Jul 2013 13:50:09 +0000 (13:50 +0000)]

Revert of r9902 (Consider conical shader opaque if it covers
entire plane - https://chromiumcodereview.appspot.com/18533006) due to roll issues (https://codereview.chromium.org/18859007/)

git-svn-id: http://skia.googlecode.com/svn/trunk@9926 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

tfarina@chromium.org [Tue, 9 Jul 2013 13:33:16 +0000 (13:33 +0000)]

Remove unused private fields from PathUtilsBench.

This allows compilation to proceed on Linux with clang when building the "most"
target.

R=robertphillips@google.com

Review URL: https://codereview.chromium.org/18338011

git-svn-id: http://skia.googlecode.com/svn/trunk@9925 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Tue, 9 Jul 2013 12:51:58 +0000 (12:51 +0000)]

More valgrind suppressions

(SkipBuildbotRuns)

git-svn-id: http://skia.googlecode.com/svn/trunk@9923 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Tue, 9 Jul 2013 12:38:59 +0000 (12:38 +0000)]

Performance trigger rebaselines

(SkipBuildbotRuns)

git-svn-id: http://skia.googlecode.com/svn/trunk@9920 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

skia.committer@gmail.com [Tue, 9 Jul 2013 07:00:56 +0000 (07:00 +0000)]

Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@9919 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Mon, 8 Jul 2013 23:17:57 +0000 (23:17 +0000)]

Added SkPDFStream::setData(SkData*) in preparation for move from SkStream to SkData

R=vandebo@chromium.org, edisonn@google.com

Author: richardlin@chromium.org

Review URL: https://chromiumcodereview.appspot.com/18328026

git-svn-id: http://skia.googlecode.com/svn/trunk@9916 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

scroggo@google.com [Mon, 8 Jul 2013 23:17:29 +0000 (23:17 +0000)]

Add expectations files covering new image files.

New image files are in Google Storage, so add expectations for them.
The ICO file is expected to fail, although there is a patch to fix
that out for review (https://chromiumcodereview.appspot.com/18655007/)

Unreviewed.

Since we are currently ignoring failures in skimage, this should at
most produce a warning, but I expect it to remove the current warning
state.

The razr expectation is copied from nexus-7, as razr is currently
not working.

Review URL: https://codereview.chromium.org/18271012

git-svn-id: http://skia.googlecode.com/svn/trunk@9915 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

scroggo@google.com [Mon, 8 Jul 2013 22:00:17 +0000 (22:00 +0000)]

Debugging statements to investigate a bug.

https://code.google.com/p/skia/issues/detail?id=1395 is a non-
deterministic bug that I have been unable to reproduce. Add
some debugging information to try to help diagnose.

BUG=https://code.google.com/p/skia/issues/detail?id=1395
R=edisonn@google.com

Review URL: https://codereview.chromium.org/18523008

git-svn-id: http://skia.googlecode.com/svn/trunk@9914 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

epoger@google.com [Mon, 8 Jul 2013 20:53:28 +0000 (20:53 +0000)]

rebaseline.py: look in gm-expected directory to see whether it's using git or svn

(before this change, it checked in the current working dir instead)

Review URL: https://codereview.chromium.org/18209010

git-svn-id: http://skia.googlecode.com/svn/trunk@9913 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

epoger@google.com [Mon, 8 Jul 2013 19:13:33 +0000 (19:13 +0000)]

GM: stop recording all *_pdf.png results as "INVALID" on non-Mac platforms

BUG=https://code.google.com/p/skia/issues/detail?id=1352
R=edisonn@google.com

Review URL: https://codereview.chromium.org/17366003

git-svn-id: http://skia.googlecode.com/svn/trunk@9912 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

scroggo@google.com [Mon, 8 Jul 2013 18:40:42 +0000 (18:40 +0000)]

Revert "Temporary change to keep chrome happy."

Now that chrome has https://chromiumcodereview.appspot.com/18078003/,
this is no longer needed.

Fully switched over to using CreateFromStream!

Review URL: https://codereview.chromium.org/18655008

git-svn-id: http://skia.googlecode.com/svn/trunk@9911 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

epoger@google.com [Mon, 8 Jul 2013 17:51:58 +0000 (17:51 +0000)]

rebaseline.py: if expectations dir contains JSON format results, update those instead of image files

Part of Step 3 in https://goto.google.com/ChecksumTransitionDetail

R=senorblanco@chromium.org

Review URL: https://codereview.chromium.org/18348018

git-svn-id: http://skia.googlecode.com/svn/trunk@9910 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Mon, 8 Jul 2013 17:26:07 +0000 (17:26 +0000)]

More valgrind suppressions

(SkipBuildbotRuns)

git-svn-id: http://skia.googlecode.com/svn/trunk@9909 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

caryclark@google.com [Mon, 8 Jul 2013 17:17:02 +0000 (17:17 +0000)]

path ops work in progress

BUG=

Review URL: https://codereview.chromium.org/18058007

git-svn-id: http://skia.googlecode.com/svn/trunk@9908 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

zachr@google.com [Mon, 8 Jul 2013 15:04:45 +0000 (15:04 +0000)]

add JSONP option to output of skpdiff

R=bsalomon@google.com

Review URL: https://codereview.chromium.org/18648002

git-svn-id: http://skia.googlecode.com/svn/trunk@9907 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

tfarina@chromium.org [Mon, 8 Jul 2013 13:00:42 +0000 (13:00 +0000)]

Fix header guard typos.

This is preventing compilation on Linux with clang.

R=robertphillips@google.com

Review URL: https://codereview.chromium.org/18131007

git-svn-id: http://skia.googlecode.com/svn/trunk@9905 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Mon, 8 Jul 2013 12:03:47 +0000 (12:03 +0000)]

Performance trigger rebaselines for r9888 (Add canFilterMaskGPU & filterMaskGPU to SkMaskFilter - https://codereview.chromium.org/18110012/)

(SkipBuildbotRuns)

git-svn-id: http://skia.googlecode.com/svn/trunk@9904 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 4 Jul 2013 18:13:05 +0000 (18:13 +0000)]

Removing highp variables from perlin noise shader

Variables using highp on the Adreno320 (A.K.A. Nexus 4) seem to be causing issues. I modified the shader so that all variables stay in a lower range, no longer requiring the "highp" qualifier.
This may improve performance on other devices, like the xoom, where the "highp" qualifier was required.

In Blink, these layout tests may require rebaselining :
./css3/filters/effect-reference-hw.html
./css3/filters/effect-reference-zoom-hw.html

BUG=https://code.google.com/p/skia/issues/detail?id=1376
R=senorblanco@google.com, sugoi@google.com

Author: sugoi@chromium.org

Review URL: https://chromiumcodereview.appspot.com/18454004

git-svn-id: http://skia.googlecode.com/svn/trunk@9903 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 4 Jul 2013 14:42:26 +0000 (14:42 +0000)]

Consider conical shader opaque if it covers entire plane.

BUG=222380
R=junov@chromium.org, senorblanco@chromium.org, reed@google.com

Author: arbesfeld@chromium.org

Review URL: https://chromiumcodereview.appspot.com/18533006

git-svn-id: http://skia.googlecode.com/svn/trunk@9902 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Thu, 4 Jul 2013 11:48:52 +0000 (11:48 +0000)]

Fix for DEPS roll failure (a patch to r9898)

git-svn-id: http://skia.googlecode.com/svn/trunk@9901 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

skia.committer@gmail.com [Thu, 4 Jul 2013 07:01:07 +0000 (07:01 +0000)]

Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@9900 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Wed, 3 Jul 2013 19:36:55 +0000 (19:36 +0000)]

Fix for r9888 bug

https://codereview.chromium.org/18656002/

git-svn-id: http://skia.googlecode.com/svn/trunk@9899 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Wed, 3 Jul 2013 18:37:27 +0000 (18:37 +0000)]

Minor GrContext/GrInOrderDrawBuffer cleanup

https://codereview.chromium.org/18341007/

git-svn-id: http://skia.googlecode.com/svn/trunk@9898 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

epoger@google.com [Wed, 3 Jul 2013 17:43:11 +0000 (17:43 +0000)]

rebaseline.py self-tests: prepare to add tests of JSON-format rebaselining

For now, rebaseline.py still does not support JSON-format rebaselining, so
the one self-test reports failure. But this change will allow us to test
the JSON-format rebaselining once rebaseline.py supports it.

R=scroggo@google.com

Review URL: https://codereview.chromium.org/18348015

git-svn-id: http://skia.googlecode.com/svn/trunk@9896 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

epoger@google.com [Wed, 3 Jul 2013 15:56:45 +0000 (15:56 +0000)]

Delete empty test subdir

git-svn-id: http://skia.googlecode.com/svn/trunk@9892 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

borenet@google.com [Wed, 3 Jul 2013 15:55:05 +0000 (15:55 +0000)]

Enable ASAN build

Requires Clang 3.1 or higher to be installed.

R=epoger@google.com

Review URL: https://codereview.chromium.org/18205007

git-svn-id: http://skia.googlecode.com/svn/trunk@9891 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Wed, 3 Jul 2013 15:49:05 +0000 (15:49 +0000)]

GPU-less build fix for r9888

git-svn-id: http://skia.googlecode.com/svn/trunk@9890 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Wed, 3 Jul 2013 15:39:10 +0000 (15:39 +0000)]

valgrind suppressions for tests & gm

https://codereview.chromium.org/18332016/

git-svn-id: http://skia.googlecode.com/svn/trunk@9889 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Wed, 3 Jul 2013 15:34:35 +0000 (15:34 +0000)]

Add canFilterMaskGPU & filterMaskGPU to SkMaskFilter

https://codereview.chromium.org/18110012/

git-svn-id: http://skia.googlecode.com/svn/trunk@9888 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Wed, 3 Jul 2013 15:09:30 +0000 (15:09 +0000)]

Build fix for [-Werror=maybe-uninitialized].

gcc v4.7.3 failed to build due to uninitialized variables.

BUG=http://code.google.com/p/skia/issues/detail?id=1381
R=bungeman@google.com, reed@google.com

Author: dongseong.hwang@intel.com

Review URL: https://chromiumcodereview.appspot.com/17572010

git-svn-id: http://skia.googlecode.com/svn/trunk@9887 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Wed, 3 Jul 2013 15:06:38 +0000 (15:06 +0000)]

Revert of r9581 (oops, fix missing change in 9532, setting hashbits to 8) due to Chromium assert failure (https://code.google.com/p/chromium/issues/detail?id=256476)

git-svn-id: http://skia.googlecode.com/svn/trunk@9886 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Wed, 3 Jul 2013 08:39:46 +0000 (08:39 +0000)]

Make SK_OVERRIDE expand to OVERRIDE on iOS

BUG=256595
R=reed@google.com

Author: glider@chromium.org

Review URL: https://chromiumcodereview.appspot.com/18531002

git-svn-id: http://skia.googlecode.com/svn/trunk@9883 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

skia.committer@gmail.com [Wed, 3 Jul 2013 07:00:57 +0000 (07:00 +0000)]

Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@9882 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

edisonn@google.com [Tue, 2 Jul 2013 23:17:27 +0000 (23:17 +0000)]

pdf viewer: remove const for int scalar types

Review URL: https://codereview.chromium.org/18103009

git-svn-id: http://skia.googlecode.com/svn/trunk@9881 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

edisonn@google.com [Tue, 2 Jul 2013 23:10:04 +0000 (23:10 +0000)]

remove now all the files fro depot for PDF API since we generate them at build time

Review URL: https://codereview.chromium.org/18404006

git-svn-id: http://skia.googlecode.com/svn/trunk@9880 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

edisonn@google.com [Tue, 2 Jul 2013 22:42:53 +0000 (22:42 +0000)]

isolate podofo to prepare for native parser, autogenerate PDF API during build

Review URL: https://codereview.chromium.org/18042005

git-svn-id: http://skia.googlecode.com/svn/trunk@9879 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

epoger@google.com [Tue, 2 Jul 2013 20:22:27 +0000 (20:22 +0000)]

Create jsondiff tool to capture diffs between two JSON expectations files.
This will be used to view diffs before committing rebaselines, or to review
exactly what changed between two baseline revisions in the past.

Part of Step 3 in https://goto.google.com/ChecksumTransitionDetail

R=scroggo@google.com

Review URL: https://codereview.chromium.org/18103005

git-svn-id: http://skia.googlecode.com/svn/trunk@9878 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Tue, 2 Jul 2013 20:06:00 +0000 (20:06 +0000)]

make sure we pass legal utf8

git-svn-id: http://skia.googlecode.com/svn/trunk@9877 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Tue, 2 Jul 2013 20:02:06 +0000 (20:02 +0000)]

speculative fix for signed-unsinged compare warning

git-svn-id: http://skia.googlecode.com/svn/trunk@9876 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

zachr@google.com [Tue, 2 Jul 2013 19:55:32 +0000 (19:55 +0000)]

add diff recording and output code

R=bsalomon@google.com

Review URL: https://codereview.chromium.org/18348011

git-svn-id: http://skia.googlecode.com/svn/trunk@9875 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

epoger@google.com [Tue, 2 Jul 2013 18:25:06 +0000 (18:25 +0000)]

Fix rebaseline.py self-test to account for r9859

R=robertphillips@google.com

Review URL: https://codereview.chromium.org/18559002

git-svn-id: http://skia.googlecode.com/svn/trunk@9872 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Tue, 2 Jul 2013 17:40:22 +0000 (17:40 +0000)]

Update tests valgrind suppressions

R=borenet@google.com

Author: robertphillips@google.com

Review URL: https://chromiumcodereview.appspot.com/18510005

git-svn-id: http://skia.googlecode.com/svn/trunk@9871 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Tue, 2 Jul 2013 17:40:19 +0000 (17:40 +0000)]

Commented SSE blend functions and cleaned-up variable naming.

R=senorblanco@chromium.org, alokp@chromium.org, reed@google.com, bungeman@google.com

Author: ernstm@chromium.org

Review URL: https://chromiumcodereview.appspot.com/17847010

git-svn-id: http://skia.googlecode.com/svn/trunk@9870 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Tue, 2 Jul 2013 16:32:29 +0000 (16:32 +0000)]

impl charsToGlyphs for freetype

BUG=
R=bungeman@google.com

Review URL: https://codereview.chromium.org/18040004

git-svn-id: http://skia.googlecode.com/svn/trunk@9866 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Tue, 2 Jul 2013 16:28:53 +0000 (16:28 +0000)]

test null-glyphs param case

git-svn-id: http://skia.googlecode.com/svn/trunk@9865 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

jvanverth@google.com [Tue, 2 Jul 2013 14:46:03 +0000 (14:46 +0000)]

Fix for Ovals/RRects on N4 missing interior rectangles.

Clamp square of gradiant length to non-zero value so it can be passed to
inversesqrt().
Also adds some fixes to rrect setup to avoid crossing zero.

Skia issue #1372

R=bsalomon@google.com, robertphillips@google.com

Review URL: https://codereview.chromium.org/18375003

git-svn-id: http://skia.googlecode.com/svn/trunk@9864 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Tue, 2 Jul 2013 14:44:27 +0000 (14:44 +0000)]

use else instead of else-if -- fixes 'possibly unused' warning

BUG=
R=bsalomon@google.com

Review URL: https://codereview.chromium.org/18527003

git-svn-id: http://skia.googlecode.com/svn/trunk@9863 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Tue, 2 Jul 2013 14:01:23 +0000 (14:01 +0000)]

use if (false) instead of #ifdef to avoid unused code warning

git-svn-id: http://skia.googlecode.com/svn/trunk@9861 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Tue, 2 Jul 2013 13:56:39 +0000 (13:56 +0000)]

add charsToGlyphs to SkTypeface

Will disable new unittest until all backends are implemented.

On Mac, new API is 4x faster than old paint one, so next CL I will reimplement the paint calls in terms of the new typeface call.

R=eae@chromium.org

Review URL: https://codereview.chromium.org/18083023

git-svn-id: http://skia.googlecode.com/svn/trunk@9860 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Tue, 2 Jul 2013 12:54:37 +0000 (12:54 +0000)]

Add N4 to rebaseline.py

https://codereview.chromium.org/18023014/
(SkipBuildbotRuns)

git-svn-id: http://skia.googlecode.com/svn/trunk@9859 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Tue, 2 Jul 2013 12:09:06 +0000 (12:09 +0000)]

Performance trigger rebaselines

(SkipBuildbotRuns)

git-svn-id: http://skia.googlecode.com/svn/trunk@9857 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

skia.committer@gmail.com [Tue, 2 Jul 2013 07:00:59 +0000 (07:00 +0000)]

Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@9856 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Tue, 2 Jul 2013 00:16:57 +0000 (00:16 +0000)]

Fix for Win7 bench compiler error/warning

git-svn-id: http://skia.googlecode.com/svn/trunk@9855 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Mon, 1 Jul 2013 23:47:44 +0000 (23:47 +0000)]

Yet another fix for Win7 compiler errors/warnings

git-svn-id: http://skia.googlecode.com/svn/trunk@9854 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Mon, 1 Jul 2013 23:15:57 +0000 (23:15 +0000)]

Yet another attempt to fix Win7 warnings/errors

git-svn-id: http://skia.googlecode.com/svn/trunk@9852 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Mon, 1 Jul 2013 22:50:18 +0000 (22:50 +0000)]

Fixed Win7 compiler warning/error

git-svn-id: http://skia.googlecode.com/svn/trunk@9850 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

dierk@google.com [Mon, 1 Jul 2013 20:50:41 +0000 (20:50 +0000)]

Merge remote-tracking branch 'refs/remotes/git-svn'

changed all makeXYWH args to SkScalar

Fixed non-constant array size in test.

Merge remote-tracking branch 'refs/remotes/git-svn'

Fixed non-constant array size in test.

Merge remote-tracking branch 'refs/remotes/git-svn'

fixed SkPathUtils.cpp:78

Fixed PathUtils.cpp:90

Fixed the float being passed to an int method

Fixed the bugs that crashed the build bots

git-svn-id: http://skia.googlecode.com/svn/trunk@9849 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

dierk@google.com [Mon, 1 Jul 2013 20:36:31 +0000 (20:36 +0000)]

Fixed non-constant array size in test.

Merge remote-tracking branch 'refs/remotes/git-svn'

Fixed non-constant array size in test.

Merge remote-tracking branch 'refs/remotes/git-svn'

fixed SkPathUtils.cpp:78

Fixed PathUtils.cpp:90

Fixed the float being passed to an int method

Fixed the bugs that crashed the build bots

git-svn-id: http://skia.googlecode.com/svn/trunk@9848 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

dierk@google.com [Mon, 1 Jul 2013 20:10:56 +0000 (20:10 +0000)]

Merge remote-tracking branch 'refs/remotes/git-svn'

fixed SkPathUtils.cpp:78

Fixed PathUtils.cpp:90

Fixed the float being passed to an int method

Fixed the bugs that crashed the build bots

git-svn-id: http://skia.googlecode.com/svn/trunk@9847 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

dierk@google.com [Mon, 1 Jul 2013 19:52:36 +0000 (19:52 +0000)]

Fixed PathUtils.cpp:90

Fixed the float being passed to an int method

Fixed the bugs that crashed the build bots

git-svn-id: http://skia.googlecode.com/svn/trunk@9846 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

dierk@google.com [Mon, 1 Jul 2013 19:30:14 +0000 (19:30 +0000)]

Fixed the bugs that crashed the build bots

git-svn-id: http://skia.googlecode.com/svn/trunk@9845 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Mon, 1 Jul 2013 17:50:29 +0000 (17:50 +0000)]

Adding my Bitmap2Path sample for 1on1 meeting.

BUG=
R=reed@google.com, borenet@google.com

Author: dierk@google.com

Review URL: https://chromiumcodereview.appspot.com/16829003

git-svn-id: http://skia.googlecode.com/svn/trunk@9843 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

zachr@google.com [Mon, 1 Jul 2013 17:04:32 +0000 (17:04 +0000)]

fix copy in SkTDArray

R=bsalomon@google.com

Review URL: https://codereview.chromium.org/18363003

git-svn-id: http://skia.googlecode.com/svn/trunk@9839 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

scroggo@google.com [Mon, 1 Jul 2013 14:44:54 +0000 (14:44 +0000)]

Add a newline to the error message from JPEG.

Review URL: https://codereview.chromium.org/18344006

git-svn-id: http://skia.googlecode.com/svn/trunk@9836 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bungeman@google.com [Mon, 1 Jul 2013 14:24:12 +0000 (14:24 +0000)]

Separate showing and hiding the debugger settings and inspector.

Internally the settings and inspector in the debugger are separate, but the
inspector button toggles both of them. This is unfortunate, because both of
these have large minimum vertical sizes. This means that those with vertical
resolutions less than ~1024 cannot see the the details tab.

This change separates the settings and inspector toggles into two so that
the interface is usable on screens of smaller size.

R=robertphillips@google.com

Review URL: https://codereview.chromium.org/18279002

git-svn-id: http://skia.googlecode.com/svn/trunk@9835 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bungeman@google.com [Mon, 1 Jul 2013 13:54:10 +0000 (13:54 +0000)]

Basic error checking for debugger GL widget.

Currently the debugger segfaults if the GL context cannot be created.
This change allows the debugger to build with GL support, but still run if the
GL context cannot be created at runtime.

R=robertphillips@google.com

Review URL: https://codereview.chromium.org/18275002

git-svn-id: http://skia.googlecode.com/svn/trunk@9834 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

rmistry@google.com [Mon, 1 Jul 2013 13:50:32 +0000 (13:50 +0000)]

Whitespace change to trigger GCE compile bots.

git-svn-id: http://skia.googlecode.com/svn/trunk@9833 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Mon, 1 Jul 2013 13:10:10 +0000 (13:10 +0000)]

Partial revert of r9812 & put rest of r9812 behind a compile flag

https://codereview.chromium.org/18317003/

git-svn-id: http://skia.googlecode.com/svn/trunk@9832 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

scroggo@google.com [Mon, 1 Jul 2013 12:42:49 +0000 (12:42 +0000)]

Fixes for nacl_debugger's use of picture.

Now that CreateFromStream is used, check for NULL rather than
looking at width and height (prevents a crash on an invalid SKP).

Unref the picture when done with it.

Remove the member variable for picture, since it is only accessed
inside the one function.

R=borenet@google.com

Review URL: https://codereview.chromium.org/18055014

git-svn-id: http://skia.googlecode.com/svn/trunk@9831 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

scroggo@google.com [Mon, 1 Jul 2013 12:38:50 +0000 (12:38 +0000)]

Expect razr to fail on some decoding tests.

Review URL: https://codereview.chromium.org/18272005

git-svn-id: http://skia.googlecode.com/svn/trunk@9830 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

skia.committer@gmail.com [Sat, 29 Jun 2013 07:03:21 +0000 (07:03 +0000)]

Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@9826 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

edisonn@google.com [Fri, 28 Jun 2013 22:01:06 +0000 (22:01 +0000)]

refactor folders to make prepare for native pdf parser

Review URL: https://codereview.chromium.org/18179007

git-svn-id: http://skia.googlecode.com/svn/trunk@9825 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

scroggo@google.com [Fri, 28 Jun 2013 21:57:51 +0000 (21:57 +0000)]

Use CreateFromStream in nacl debugger.

Review URL: https://codereview.chromium.org/18153012

git-svn-id: http://skia.googlecode.com/svn/trunk@9824 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

scroggo@google.com [Fri, 28 Jun 2013 21:35:29 +0000 (21:35 +0000)]

Temporary change to keep chrome happy.

Add back in a version of the constructor taking a stream so that
chrome can build until we switch chrome to using the factory.

Will be reverted once chrome switches to using the factory.

R=robertphillips@google.com

Review URL: https://codereview.chromium.org/17916003

git-svn-id: http://skia.googlecode.com/svn/trunk@9823 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

scroggo@google.com [Fri, 28 Jun 2013 21:32:00 +0000 (21:32 +0000)]

Replace SkPicture(SkStream) constructors with a factory.

SkPicture:
Remove the constructors which take an SkStream as an argument. Rather
than having to check a variable for success, the factory will return
NULL on failure.
Add a protected function for determining if an SkStream is an SKP
to share code with SkTimedPicture.
In the factory, check for a NULL SkStream.
Use a default decoder (from BUG:
https://code.google.com/p/skia/issues/detail?id=1325)

SkDebuggerGUI:
Call SkPicture::CreateFromStream when necessary.
Write a factory for creating SkTimedPictures and use it.

Use the factory throughout tools.

Add include/lazy to utils and effects gyp include_dirs so SkPicture.h
can reference SkImageDecoder.h which references SkBitmapFactory.h (in
include/lazy).

Changes code Chromium uses, so this will require a temporary Skia
and then a change to Chromium to use the new Skia code.

TODO: Create a decoder that does nothing to be used by pinspect,
lua pictures, etc, and allow it to not assert in SkOrderedReadBuffer.

R=reed@google.com

Review URL: https://codereview.chromium.org/17113004

git-svn-id: http://skia.googlecode.com/svn/trunk@9822 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

scroggo@google.com [Fri, 28 Jun 2013 20:04:42 +0000 (20:04 +0000)]

Skip the TIMESTAMP file.

Allows run_decoding_tests.py to pass the name of the folder, so
Android will not fail on account of the long adb command.

R=borenet@google.com

Review URL: https://codereview.chromium.org/18175008

git-svn-id: http://skia.googlecode.com/svn/trunk@9817 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Fri, 28 Jun 2013 19:47:43 +0000 (19:47 +0000)]

use width() instead of fWidth to get int value

git-svn-id: http://skia.googlecode.com/svn/trunk@9816 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Fri, 28 Jun 2013 19:40:50 +0000 (19:40 +0000)]

add bitmap::eraseArea

BUG=
R=scroggo@google.com

Review URL: https://codereview.chromium.org/18029021

git-svn-id: http://skia.googlecode.com/svn/trunk@9815 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bsalomon@google.com [Fri, 28 Jun 2013 18:57:35 +0000 (18:57 +0000)]

Add flag bits for partial GrContext reset

BUG=248728
R=bsalomon@google.com

Committed: https://code.google.com/p/skia/source/detail?r=9802

Review URL: https://codereview.chromium.org/17027003

git-svn-id: http://skia.googlecode.com/svn/trunk@9814 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

edisonn@google.com [Fri, 28 Jun 2013 18:51:20 +0000 (18:51 +0000)]

more work on pdf fonts, more to come

Review URL: https://codereview.chromium.org/18117005

git-svn-id: http://skia.googlecode.com/svn/trunk@9813 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Fri, 28 Jun 2013 17:57:06 +0000 (17:57 +0000)]

GPU "fix" for thin stroked rects

https://codereview.chromium.org/17845003/

git-svn-id: http://skia.googlecode.com/svn/trunk@9812 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

scroggo@google.com [Fri, 28 Jun 2013 17:52:53 +0000 (17:52 +0000)]

Print the file being deserialized before deserializing.

That way it is easier to tell which file failed.

R=edisonn@google.com

Review URL: https://codereview.chromium.org/18219002

git-svn-id: http://skia.googlecode.com/svn/trunk@9811 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bungeman@google.com [Fri, 28 Jun 2013 17:21:35 +0000 (17:21 +0000)]

Make implicit cast explicit to fix r9807 on gcc.

git-svn-id: http://skia.googlecode.com/svn/trunk@9809 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bungeman@google.com [Fri, 28 Jun 2013 16:44:55 +0000 (16:44 +0000)]

Minimal changes for SampleApp to eb HiDPI aware on Mac.

R=caryclark@google.com

Review URL: https://codereview.chromium.org/18055009

git-svn-id: http://skia.googlecode.com/svn/trunk@9807 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

zachr@google.com [Fri, 28 Jun 2013 16:27:33 +0000 (16:27 +0000)]

add point of interest API

R=bsalomon@google.com

Review URL: https://codereview.chromium.org/18176005

git-svn-id: http://skia.googlecode.com/svn/trunk@9806 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

edisonn@google.com [Fri, 28 Jun 2013 16:03:21 +0000 (16:03 +0000)]

revert 9802 breacking tests on some configs

git-svn-id: http://skia.googlecode.com/svn/trunk@9805 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

zachr@google.com [Fri, 28 Jun 2013 15:37:15 +0000 (15:37 +0000)]

fix OpenCL memory leak

R=djsollen@google.com

Review URL: https://codereview.chromium.org/18051004

git-svn-id: http://skia.googlecode.com/svn/trunk@9804 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

zachr@google.com [Fri, 28 Jun 2013 15:34:56 +0000 (15:34 +0000)]

add yee's perceptual metric

R=bsalomon@google.com

Review URL: https://codereview.chromium.org/18066004

git-svn-id: http://skia.googlecode.com/svn/trunk@9803 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bsalomon@google.com [Fri, 28 Jun 2013 14:32:08 +0000 (14:32 +0000)]

Add flag bits for partial GrContext reset

BUG=248728
R=bsalomon@google.com

Review URL: https://codereview.chromium.org/17027003

git-svn-id: http://skia.googlecode.com/svn/trunk@9802 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Fri, 28 Jun 2013 11:47:01 +0000 (11:47 +0000)]

Clang has stricter checking for conversion to a null pointer. In C++11 mode, false will produce an error if it is used in a place that expects a pointer. Change these cases to NULL.

R=reed@google.com, robertphillips@google.com

Author: rtrieu@google.com

Review URL: https://chromiumcodereview.appspot.com/18118004

git-svn-id: http://skia.googlecode.com/svn/trunk@9800 2bbb7eff-a529-9590-31e7-b0007b416f81

Domain: Dotnet / API;

RSS Atom