오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Tue, 9 Apr 2019 11:13:01 +0000 (20:13 +0900)]
Fix copyright checker (#4954)
Rename copyright check script
Change mode: remove execution and allow only source (by nnfw command)
Exit with exit code when invalid result
Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Tue, 9 Apr 2019 11:11:15 +0000 (20:11 +0900)]
Ignore directories generated by coverage scripts (#4960)
Ignore directories generated by coverage scripts
- coverage test run: /gcov
- coverage analysis result: /coverage
Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
이상규/On-Device Lab(SR)/Principal Engineer/삼성전자 [Tue, 9 Apr 2019 09:31:12 +0000 (18:31 +0900)]
[neurun] Remove redundant virtual from override functions (#4956)
I removed `virtual` when I am sure it is our code.
Otherwise, I did not removed `virtual`.
Signed-off-by: Sanggyu Lee <sg5.lee@samsung.com>
박천교/On-Device Lab(SR)/Engineer/삼성전자 [Tue, 9 Apr 2019 05:17:52 +0000 (14:17 +0900)]
Update usage example of unittest script (#4949)
Previously usage example for unittest script refers not appropriate
directory. This commit updates the directory for running example.
Signed-off-by: Cheongyo Bahk <ch.bahk@samsung.com>
박천교/On-Device Lab(SR)/Engineer/삼성전자 [Tue, 9 Apr 2019 04:20:42 +0000 (13:20 +0900)]
Use variable for nnapi unittest install (#4951)
For consistency and code maintainability, better to use variable rather
than target name itself.
Signed-off-by: Cheongyo Bahk <ch.bahk@samsung.com>
Add copyright checker for newly added files (#4214)
* Add copyright checker for newly added files
Add copyright checker for newly added files
Signed-off-by: Poshshoev Dilshodzhon <d.poshshoev@samsung.com>
* Update command that lists newly added files
Update command that lists newly added files
Signed-off-by: Poshshoev Dilshodzhon <d.poshshoev@samsung.com>
* Check just listed directories
Check just listed directories by skipping exluded ones
Signed-off-by: Poshshoev Dilshodzhon <d.poshshoev@samsung.com>
* Check all files, that were added this year
This prevents from updating copyright year of a file, that were added
with correct copyright, but later on somehow was updated incorrectly.
Also, this addresses feedbacks of @hseok82-oh
Signed-off-by: Poshshoev Dilshodzhon <d.poshshoev@samsung.com>
* Fix Copyright grep command
Fix Copyright grep command
Signed-off-by: Poshshoev Dilshodzhon <d.poshshoev@samsung.com>
* Move checker to seperate file and change checking method
Also fixed files, that have wrong copyright
Checks just `.h, .hpp, .cc, .cpp, .cl` files
Check each files of subdir, that were added to git, or moved from other
directory in current year. If a file is added (not merged into master)
in this year and its copyright has incorrect format or copyright year
isn't current year, then print it.
Signed-off-by: Poshshoev Dilshodzhon <d.poshshoev@samsung.com>
* Rebase
Signed-off-by: Poshshoev Dilshodzhon <d.poshshoev@samsung.com>
* Remove unused pushd and popd
Signed-off-by: Poshshoev Dilshodzhon <d.poshshoev@samsung.com>
* Revert fixed copyrights
Signed-off-by: Poshshoev Dilshodzhon <d.poshshoev@samsung.com>
박천교/On-Device Lab(SR)/Engineer/삼성전자 [Tue, 9 Apr 2019 04:02:30 +0000 (13:02 +0900)]
Correct architecture in skip file (#4950)
This commit corrects architecture in x86_64 skip file corresponds to
its file name and recommended usage
Signed-off-by: Cheongyo Bahk <ch.bahk@samsung.com>
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Mon, 8 Apr 2019 10:46:26 +0000 (19:46 +0900)]
Remove deprecated header include in neurun cpu kernel (#4942)
Remove deprecated header include in neurun cpu fully connected kernel
Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
이상규/On-Device Lab(SR)/Principal Engineer/삼성전자 [Thu, 4 Apr 2019 22:05:38 +0000 (07:05 +0900)]
[neurun] Garden and remove redundunt code from ExecManager Test (#4930)
- Merge duplicated calls into one
model->operands.at(operand_activation).usage(Usage::CONSTANT);
model->operands.at(operand_activation).usage(operand::Usage::CONSTANT);
- Group the related statements by operand and operator
Signed-off-by: Sanggyu Lee <sg5.lee@samsung.com>
장지섭/On-Device Lab(SR)/Engineer/삼성전자 [Thu, 4 Apr 2019 09:49:25 +0000 (18:49 +0900)]
[neurun] Eliminate the concept of scalar type (#4929)
This commit eliminate the concept of scalar type.
Signed-off-by: jiseob.jang <jiseob.jang@samsung.com>
장지섭/On-Device Lab(SR)/Engineer/삼성전자 [Thu, 4 Apr 2019 09:21:17 +0000 (18:21 +0900)]
[PACL] Fix wrong setting of for SpaceToBatch in NHWC (#4366)
This commit fixes wrong setting of block_size and padding size for SpaceToBatch in NHWC.
- Change setting of them to only support 4-dimensional input and the 2-dimensional spatial shape.
Signed-off-by: jiseob.jang <jiseob.jang@samsung.com>
장지섭/On-Device Lab(SR)/Engineer/삼성전자 [Thu, 4 Apr 2019 07:14:29 +0000 (16:14 +0900)]
[neurun] Fix a typo (#4931)
This commit fixes a type.
Signed-off-by: jiseob.jang <jiseob.jang@samsung.com>
이상규/On-Device Lab(SR)/Principal Engineer/삼성전자 [Thu, 4 Apr 2019 06:14:09 +0000 (15:14 +0900)]
[neurun] Fix wrong output operand in ExecManager test (#4927)
Fix wrong added output operand. (operand_rhs to operand_result)
Signed-off-by: Sanggyu Lee <sg5.lee@samsung.com>
이한종/On-Device Lab(SR)/Engineer/삼성전자 [Thu, 4 Apr 2019 04:54:59 +0000 (13:54 +0900)]
[neurun] Enable Test DataflowExecutor (#4924)
Enable Test DataflowExecutor for both acl_cl and cpu.
Signed-off-by: Hanjoung Lee <hanjoung.lee@samsung.com>
이상규/On-Device Lab(SR)/Principal Engineer/삼성전자 [Thu, 4 Apr 2019 04:20:01 +0000 (13:20 +0900)]
[neurun] Simpify TypeInfo constructor using default parameters (#4926)
`scale` and `offset` are used only in case of `TENSOR_QUANT8_ASYMM`.
For most cases, we don't need the values at all.
Signed-off-by: Sanggyu Lee <sg5.lee@samsung.com>
Fix some errors from Clang compiler (#4915)
* Fix some errors from Clang compiler
* Fix abs on unsigned char, fix hidden overloaded virtual function, rename predeclared class on struct, remove unused private variable, remove std::move when he called in return statement
Signed-off-by: Pavel Iliutchenko <p.iliutchenk@samsung.com>
* Fix unused variables, struct/class mismatching
Signed-off-by: Pavel Iliutchenko <p.iliutchenk@samsung.com>
* Fix extern C++, unused variables, explicit overriding, remove std::move in return statement
Signed-off-by: Pavel Iliutchenko <p.iliutchenk@samsung.com>
* Fix file for format-check and extern C
Signed-off-by: Pavel Iliutchenko <p.iliutchenk@samsung.com>
* Fix library information removing from neurun
Signed-off-by: Pavel Iliutchenko <p.iliutchenk@samsung.com>
장지섭/On-Device Lab(SR)/Engineer/삼성전자 [Wed, 3 Apr 2019 10:08:21 +0000 (19:08 +0900)]
Fix x64-push-builder-tester #4922 (#4923)
This commit fixes x64-push-builder-tester #4922.
- Add GREATER_EQUAL and LESS tests to skiplist of x64.
Signed-off-by: jiseob.jang <jiseob.jang@samsung.com>
장지섭/On-Device Lab(SR)/Engineer/삼성전자 [Wed, 3 Apr 2019 08:27:58 +0000 (17:27 +0900)]
Support GREATER_EQUAL and LESS (#4900)
* Append nnapi tests of GREATER_EQUAL and LESS
This commit appends nnapi tests of of GREATER_EQUAL and LESS.
Signed-off-by: jiseob.jang <jiseob.jang@samsung.com>
* [neurun] Support GREATER_EQUAL and LESS
This commit supports GREATER_EQUAL and LESS operations.
Signed-off-by: jiseob.jang <jiseob.jang@samsung.com>
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Wed, 3 Apr 2019 06:49:29 +0000 (15:49 +0900)]
Remove deprecated cmake variables (#4913)
Remove deprecated cmake variables: TARGET_IS_ARMARCH, BUILD_IS_NATIVE
Update comment about variable setting
Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
이상규/On-Device Lab(SR)/Principal Engineer/삼성전자 [Wed, 3 Apr 2019 04:38:58 +0000 (13:38 +0900)]
[neurun] Allow integer list for neurun::operand::Shape (#4909)
This patch enables initilization of neurun::operand::Shape with list.
Before:
```
operand::Shape shape{4};
shape.dim(0) = 1;
shape.dim(1) = 2;
shape.dim(2) = 2;
shape.dim(3) = 1;
```
After:
```
operand::Shape shape{1, 2, 2, 1};
```
Signed-off-by: Sanggyu Lee <sg5.lee@samsung.com>
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Wed, 3 Apr 2019 00:18:13 +0000 (09:18 +0900)]
Divide by zero check in average pool (#4916)
Change count as int type
Check divide by zero in average pool calculation
Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Tue, 2 Apr 2019 06:47:52 +0000 (15:47 +0900)]
Remove unused header in cpu backend ReshapeLayer (#4917)
Remove unused header in cpu backend ReshapeLayer to remove dependency with tensorflow lite
Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Tue, 2 Apr 2019 06:47:32 +0000 (15:47 +0900)]
Introduce cpu quant8 fully connected kernel (#4918)
Introduce cpu quantized int8 fully connected kernel from tflite
Use kernel in neurun cpu backend
Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
이춘석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Mon, 1 Apr 2019 10:22:25 +0000 (19:22 +0900)]
Fix coverage build fail on gbs (#4912)
On gbs, CMAKE_C_FLAGS_DEBUG seems to apply -O0 flag on coverage build.
This patch cancels -O0 flag in the case of coverage build.
Note that arm-ubuntu build does not show this kinds of error.
Signed-off-by: Chunseok Lee <chunseok.lee@samsung.com>
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Mon, 1 Apr 2019 10:09:05 +0000 (19:09 +0900)]
Introduce float softrmax cpu kernel (#4911)
* Introduce float softrmax cpu kernel
Introduce float softmax cpu kernel from tflite
Use kernel in neurun cpu backend
Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
* Fix release build bug
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Mon, 1 Apr 2019 10:08:26 +0000 (19:08 +0900)]
Introduce cpu quant8 convolution kernel (#4910)
Introduce cpu quantized int8 convolution kernel from tflite and gemmlowp
Use kernel in neurun cpu backend
Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Mon, 1 Apr 2019 09:30:59 +0000 (18:30 +0900)]
Introduce float fully connected kernel (#4894)
Introduce float fully connected kernel from tflite
Use kernel in neurun cpu backend
Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Mon, 1 Apr 2019 07:33:38 +0000 (16:33 +0900)]
Install unzip in docker image (#4908)
Install unzip in docker image
It will be used for x86-64 test
Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Mon, 1 Apr 2019 06:56:00 +0000 (15:56 +0900)]
Introduce cpu float depthwise convolution kernel and backend (#4906)
Introduce cpu float depthwise convolution kernel from tflite
Implement neurun cpu backend for depthwise convolution
Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Mon, 1 Apr 2019 05:31:19 +0000 (14:31 +0900)]
Platform specific cmake option setting (#4898)
Make platform specific cmake option setting files
Platform specific setting have higher priority than common setting
Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Mon, 1 Apr 2019 02:08:47 +0000 (11:08 +0900)]
Add assertion for cpu backend shape conversion (#4904)
CPU backend assume that neurun's internal shape is always same or less than 4.
It is true on current neurun implementation, but it may change.
So add assertion to check this.
Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Mon, 1 Apr 2019 01:42:50 +0000 (10:42 +0900)]
Fix cmake acl module check (#4905)
Use QUIET to download source code in acl module check,
and return false when fail to get source code
Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
장지섭/On-Device Lab(SR)/Engineer/삼성전자 [Mon, 1 Apr 2019 00:58:51 +0000 (09:58 +0900)]
[neurun] Add validation of ComparisonNode (#4901)
This commit adds validation of ComparisonNode.
Signed-off-by: jiseob.jang <jiseob.jang@samsung.com>
이상규/On-Device Lab(SR)/Principal Engineer/삼성전자 [Mon, 1 Apr 2019 00:57:44 +0000 (09:57 +0900)]
Fix wrong nnapi tests path in Doxyfile's exclude (#4899)
Wrong nnapi tests location is fixed in Doxyfile exclude.
It causes "input buffer overflow, can't enlarge buffer
because scanner uses REJECT" error.
Signed-off-by: Sanggyu Lee <sg5.lee@samsung.com>
이한종/On-Device Lab(SR)/Engineer/삼성전자 [Mon, 1 Apr 2019 00:40:25 +0000 (09:40 +0900)]
[neurun] Simplify Backend C Interface (#4891)
C API was 3 functions that creates each components of a Backend. This
commit revises it to have only one API function `neurun_backend_create`
which packs all the components.
Signed-off-by: Hanjoung Lee <hanjoung.lee@samsung.com>
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Mon, 1 Apr 2019 00:37:39 +0000 (09:37 +0900)]
Move cmake buildtool flag setting (#4893)
Move cmake buildtool flag setting file into cmake/buildtool/
Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Mon, 1 Apr 2019 00:37:29 +0000 (09:37 +0900)]
Introduce cpu maxpool kernel (#4897)
Introduce cpu maxpool kernel from tflite
Use kernel in neurun cpu backend
Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Fri, 29 Mar 2019 06:16:23 +0000 (15:16 +0900)]
Introduce float convolution kernel (#4892)
Introduce float convolution kernel from tflite
Use kernel in neurun cpu backend
Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
장지섭/On-Device Lab(SR)/Engineer/삼성전자 [Fri, 29 Mar 2019 06:16:06 +0000 (15:16 +0900)]
[neurun] Enable operations using boolean type (#4883)
This commit enable operations using boolean type.
Signed-off-by: jiseob.jang <jiseob.jang@samsung.com>
윤지영/On-Device Lab(SR)/Staff Engineer/삼성전자 [Fri, 29 Mar 2019 04:21:56 +0000 (13:21 +0900)]
Revert "[PACL] Apply DepthwiseConvolutionLayer3x3 to DepthwiseConv operation (#4354)" (#4840)
This reverts commit
34f49de36ae41f10735fd570e006981671e13a68.
The same changes were merged in acl v19.02.
Related PR : https://review.mlplatform.org/#/c/ml/ComputeLibrary/+/511/
Signed-off-by: Jiyoung Yun <jy910.yun@samsung.com>
이한종/On-Device Lab(SR)/Engineer/삼성전자 [Thu, 28 Mar 2019 09:44:17 +0000 (18:44 +0900)]
[neurun] DataflowExecutor indentation fix (#4890)
* [neurun] DataflowExecutor indentation fix
Remove the extra block in DataflowExecutor implementation.
Signed-off-by: Hanjoung Lee <hanjoung.lee@samsung.com>
* Remove another block
Signed-off-by: Hanjoung Lee <hanjoung.lee@samsung.com>
이춘석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Thu, 28 Mar 2019 09:43:37 +0000 (18:43 +0900)]
[neurun] Add NEON backend (#4522)
* [neurun] Add CMakeLists.txt for NEON
Add CMakeLists.txt for NEON backend
Signed-off-by: Chunseok Lee <chunseok.lee@samsung.com>
* [neurun] Replicate the acl_cl backend code
- This is just a replication of acl_cl backend code
Signed-off-by: Chunseok Lee <chunseok.lee@samsung.com>
* [neurun] Add acl_neon sub dir
Add acl_neon sub dir for NEON backend
Signed-off-by: Chunseok Lee <chunseok.lee@samsung.com>
* [neurun] Fix build failure
[neurun] Fix build failure in NEON
Signed-off-by: Chunseok Lee <chunseok.lee@samsung.com>
* Add acl_neon backend into Config file
Add acl_neon backend into Config file
Signed-off-by: Chunseok Lee <chunseok.lee@samsung.com>
* Use NEReshapeLayer for runinng mobilenet model
With this patch, neurun can run mobilenet
Signed-off-by: Chunseok Lee <chunseok.lee@samsung.com>
* Fix build error after rebase
Fix build error after rebase
Signed-off-by: Chunseok Lee <chunseok.lee@samsung.com>
* Fix copyright year and macros
Fix copyright year and macros
Signed-off-by: Chunseok Lee <chunseok.lee@samsung.com>
* Remove unsupported op from StageGenerator.cc
Remove unsupported op from StageGenerator.cc
Signed-off-by: Chunseok Lee <chunseok.lee@samsung.com>
* Use NEFullyConnectedLayer instead of GenericFCLayer
Use NEFullyConnectedLayer instead of GenericFCLayer
Signed-off-by: Chunseok Lee <chunseok.lee@samsung.com>
* [neurun] Fix build error
[neurun] Fix build error #2
Signed-off-by: Chunseok Lee <chunseok.lee@samsung.com>
* [neurun] Reuse cl version of convert and Swizzle
Also fixed INETensor class: it didn't implemented one abstract member of ITensor
Signed-off-by: Poshshoev Dilshodzhon <d.poshshoev@samsung.com>
* [neurun] Rebase onto master
[neurun] Rebase changes onto master
Signed-off-by: Poshshoev Dilshodzhon <d.poshshoev@samsung.com>
* [neurun] Phase 2: Reuse other backends codes where needed
Reuse other backends codes where needed
Signed-off-by: Poshshoev Dilshodzhon <d.poshshoev@samsung.com>
* [neurun] Fix linking errors of reused codes
Fix linking errors of reused codes
Signed-off-by: Poshshoev Dilshodzhon <d.poshshoev@samsung.com>
* Separate acl common files into single dir
Pull all files, that are used in both acl_cl and acl_neon into separate
dir
Signed-off-by: Poshshoev Dilshodzhon <d.poshshoev@samsung.com>
* Cleanup virtual function declarations in neurun backends
Cleanup virtual function declarations in neurun backends.
This is borrowed from PR 4791
Signed-off-by: Poshshoev Dilshodzhon <d.poshshoev@samsung.com>
* Rename make_acl_function as asAclFunction
Fix coding style of make_acl_function
Signed-off-by: Poshshoev Dilshodzhon <d.poshshoev@samsung.com>
* Move cpu::Object into neurun_core::backend
Move cpu::Object into neurun_core since it is used in NEON also
Signed-off-by: Poshshoev Dilshodzhon <d.poshshoev@samsung.com>
* Rebase onto master: conflict because of TensorInfo
Rebase onto master: conflict because of TensorInfo
Signed-off-by: Poshshoev Dilshodzhon <d.poshshoev@samsung.com>
* Fix copyright year of acl_common/TemplTensorBuilder.h
Fix copyright year of acl_common/TemplTensorBuilder.h
Signed-off-by: Poshshoev Dilshodzhon <d.poshshoev@samsung.com>
* Merge onto master: fixStageGenerator
Merge onto master: fixStageGenerator
Signed-off-by: Poshshoev Dilshodzhon <d.poshshoev@samsung.com>
윤지영/On-Device Lab(SR)/Staff Engineer/삼성전자 [Thu, 28 Mar 2019 07:57:28 +0000 (16:57 +0900)]
[pureacl] Use fused_act parameter in Conv and DepthwiseConv acl layer (#4851)
* [pureacl] Use fused_act parameter in Conv and DepthwiseConv acl layer
acl v19.03 support fused_act parameter in Conv and DepthwiseConv layer.
Signed-off-by: Jiyoung Yun <jy910.yun@samsung.com>
* Revert DepthwiseConvolution changes
Activation layer information only works for QASYMM8 in DepthwiseConvolutionLayer.
* Add comments for configure of ConvolutionLayer
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Thu, 28 Mar 2019 07:56:37 +0000 (16:56 +0900)]
[Interpreter] Allocate and assign constant tensor (#4888)
Allocate tensor for constant operand
Assign constant tensor to exec-env
Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Thu, 28 Mar 2019 07:21:29 +0000 (16:21 +0900)]
[cker] Introduce average pool kernel (#4889)
Introduce average pool kernel from tflite
Use kernel in neurun cpu backend
Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Thu, 28 Mar 2019 06:30:23 +0000 (15:30 +0900)]
Introduce concat kernel (#4887)
Introduce concat kernel from tflite
Use concat kernel in cpu backend
Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
이한종/On-Device Lab(SR)/Engineer/삼성전자 [Thu, 28 Mar 2019 06:24:18 +0000 (15:24 +0900)]
[neurun] Rename Executor as LinearExecutor (#4874)
Before this was the only Executor so its name was "Executor", now that
we have more Executors so rename it to prevent from confusion.
Signed-off-by: Hanjoung Lee <hanjoung.lee@samsung.com>
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Thu, 28 Mar 2019 04:06:26 +0000 (13:06 +0900)]
Introduce cpu kernel in libs (#4886)
* Introduce cpu kernel in libs
Introduce cpu kernel in libs for cpu backend and interpreter
Introduce shape implementation from tflite
Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
* Fix header define and license format
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Thu, 28 Mar 2019 04:05:58 +0000 (13:05 +0900)]
Move cmake compile flag setting (#4880)
* Move cmake compile flag setting
Move target independent/dependent copmile flag setting into ApplyCompileFlags.cmake
Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
* Remove setting duplication
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Thu, 28 Mar 2019 04:02:08 +0000 (13:02 +0900)]
Introduce ExecEnv for intepreter (#4882)
Define ExecEnv to gather interpreter environment - status, memory, etc
Assign input and output tensor into ExecEnv
Fix unittest
Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
장지섭/On-Device Lab(SR)/Engineer/삼성전자 [Wed, 27 Mar 2019 10:56:38 +0000 (19:56 +0900)]
[neurun] Enable setting the data type of mode operand::Object (#4881)
This commit Enable setting the data type of made operand::Object.
Signed-off-by: jiseob.jang <jiseob.jang@samsung.com>
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Wed, 27 Mar 2019 09:53:14 +0000 (18:53 +0900)]
Fix cl codes' format (#4820)
Fix cl codes' format using c++ format
Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Wed, 27 Mar 2019 08:08:07 +0000 (17:08 +0900)]
Move cmake platform identifier (#4878)
* Move cmake platform identifier
Move cmake file for platform identify
Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
* Move IdentifyPlatform.cmake and use nnfw_include
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Wed, 27 Mar 2019 07:21:14 +0000 (16:21 +0900)]
GBS neurun build (#4876)
Build neurun as default on gbs build
Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Wed, 27 Mar 2019 05:29:03 +0000 (14:29 +0900)]
Fix build error by conflict (#4873)
Fix build error by operationFactory parameter change
Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Wed, 27 Mar 2019 05:06:34 +0000 (14:06 +0900)]
Move backend unittest (#4870)
Move backend unittest into each backend
Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
김수진/Quality Tool Lab(SR)/Engineer/삼성전자 [Wed, 27 Mar 2019 04:55:51 +0000 (13:55 +0900)]
[neurun] Enable LocalResponseNorm, DepthToSpace, ReduceMin ops (#4714)
Related : #3708
This commit enables `LocalResponseNormalization`, `DepthToSpace`, `ReduceMin` ops for `acl_cl`.
Signed-off-by: sjsujinkim <sjsujin.kim@samsung.com>
이한종/On-Device Lab(SR)/Engineer/삼성전자 [Wed, 27 Mar 2019 04:52:16 +0000 (13:52 +0900)]
[neurun] Reuse code in Executor::execute (#4869)
Reuse setting inputs and outputs part with template method pattern.
Signed-off-by: Hanjoung Lee <hanjoung.lee@samsung.com>
장지섭/On-Device Lab(SR)/Engineer/삼성전자 [Wed, 27 Mar 2019 04:27:18 +0000 (13:27 +0900)]
[neurun] Add passing a param of operand::Set when creating the Node (#4867)
This commit adds passing a param of operand::Set when creating the Node in order to adjust operand information for each operation.
Signed-off-by: jiseob.jang <jiseob.jang@samsung.com>
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Wed, 27 Mar 2019 03:36:47 +0000 (12:36 +0900)]
Coverage test with log (#4868)
Enable logging and dot-dump on coverage test
Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
이한종/On-Device Lab(SR)/Engineer/삼성전자 [Wed, 27 Mar 2019 01:32:50 +0000 (10:32 +0900)]
[neurun] Bugfix - running with multiple backends (#4866)
Due to not defining DefBackend for model inputs, there was a problem
when running with multiple backends.
Fix #4828
Signed-off-by: Hanjoung Lee <hanjoung.lee@samsung.com>
이한종/On-Device Lab(SR)/Engineer/삼성전자 [Tue, 26 Mar 2019 23:57:50 +0000 (08:57 +0900)]
[neurun] Promote OperandContext to ExecutorBase (#4864)
As all the executors have OperandContext in common, we can promote it to
its base class `ExecutorBase`.
Part of #4823
Signed-off-by: Hanjoung Lee <hanjoung.lee@samsung.com>
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Tue, 26 Mar 2019 11:20:15 +0000 (20:20 +0900)]
Enable external IO memory set validation test (#4860)
Implement NNAPI to set input and output using external memory
Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Tue, 26 Mar 2019 08:25:55 +0000 (17:25 +0900)]
Enable supported validation test (#4862)
Enable validation test
- SetInput
- SestOutput
- EventWait
Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
이상규/On-Device Lab(SR)/Principal Engineer/삼성전자 [Tue, 26 Mar 2019 06:34:51 +0000 (15:34 +0900)]
Make sure standalone scripts are not source'd (#4853)
Scripts under standalone are supposed to run, not sourced.
On error, it would exit, it may cause the shell terminated.
To prevent unintended use style, each script is checked whether
it is sourced or not.
Signed-off-by: Sanggyu Lee <sg5.lee@samsung.com>
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Tue, 26 Mar 2019 06:10:53 +0000 (15:10 +0900)]
Remove gbs build check for cpu backend build (#4858)
To build neurun cpu backend, check tensorflow lite internal source code instead of gbs build flag
Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
장지섭/On-Device Lab(SR)/Engineer/삼성전자 [Tue, 26 Mar 2019 04:56:41 +0000 (13:56 +0900)]
[neurun] Move out of the graph of neurun to collect the model's information (#4838)
This commit moves out of the graph of neurun to collect the model's infomation.
Signed-off-by: jiseob.jang <jiseob.jang@samsung.com>
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Tue, 26 Mar 2019 04:19:32 +0000 (13:19 +0900)]
Remove architecture check for backend build (#4854)
To build neurun acl_cl backend, check acl support instead of target architecture name
Fix arm architecture flag bug
Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Tue, 26 Mar 2019 02:24:43 +0000 (11:24 +0900)]
Check invalid NNAPI input and output index (#4849)
* Check invalid NNAPI input and output index
Check too large index by return invalid index value in wrppaer function
Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
* Fix validation check log
김수진/Quality Tool Lab(SR)/Engineer/삼성전자 [Tue, 26 Mar 2019 02:24:17 +0000 (11:24 +0900)]
[neurun] Enable ArgMax, Dequantize, Mean ops (#4751)
* [neurun] Enable ArgMax, Dequantize, Mean ops
This commit enables `ArgMax`, `Dequantize`, `Mean` ops for `acl_cl`.
* fix build break
Signed-off-by: sjsujinkim <sjsujin.kim@samsung.com>
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Tue, 26 Mar 2019 00:53:12 +0000 (09:53 +0900)]
Check input and output tensor length (#4847)
Check correctness of length for input and output tensor setting based on NNAPI spec
Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Mon, 25 Mar 2019 11:09:20 +0000 (20:09 +0900)]
Fix test script bug (#4837)
* Fix test script bug
- Check copy and script failure
- Fix test driver parameter
Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
* Add set -e for all standalone scripts
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Mon, 25 Mar 2019 10:19:26 +0000 (19:19 +0900)]
Fix rootfs default setting bug (#4846)
Fix rootfs default setting bug by changing path
Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
이한종/On-Device Lab(SR)/Engineer/삼성전자 [Mon, 25 Mar 2019 10:19:15 +0000 (19:19 +0900)]
[neurun] Extract OperandContext from Plan (#4834)
Extract OperandContext from Plan so OperandContext can be merged in
ExecutorBase. (Both Executor and DataflowExecutor contains
OperandContext so we can promote it to ExecutorBase, later.)
Signed-off-by: Hanjoung Lee <hanjoung.lee@samsung.com>
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Mon, 25 Mar 2019 10:02:38 +0000 (19:02 +0900)]
Move util for frontend only (#4843)
* Move util for frontend only
Move util implementation for NNAPI frontend only
* Define static function for convert
Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Mon, 25 Mar 2019 10:01:58 +0000 (19:01 +0900)]
Change compiler::TensorInfo to model::operand::Info (#4830)
Change compiler::TensorInfo to model::operand::Info
All data fields in TensorInfo is model operand's info
Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
Redo TensorBuilderSet as unordered_set (#4836)
Redo TensorBuilderSet as unordered_set since we don't care if it is
sorted or not
Signed-off-by: Poshshoev Dilshodzhon <d.poshshoev@samsung.com>
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Mon, 25 Mar 2019 09:15:43 +0000 (18:15 +0900)]
Rename toolchain setting files (#4839)
- Rename toolchain setting directory and files for cross build to cmake/buildtool/cross/toolchain_$(TARGET_ARCH_LC)-$(TARGET_OS).cmake
- Remove needless x86-64 cross build toolchain setting
Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Mon, 25 Mar 2019 05:07:42 +0000 (14:07 +0900)]
Move cmake options (#4841)
Move cmake options for build and download into cmake/CfgOptionFlgs.cmake
Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Mon, 25 Mar 2019 03:21:16 +0000 (12:21 +0900)]
Introduce tensor interface and class for interpreter (#4818)
Introduce tensor interface for interpreter
Introduce ROTensor (read-only tensor) and Tensor (writable tensor) class
Generate interpreter tensor when input/output is set
Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
이한종/On-Device Lab(SR)/Engineer/삼성전자 [Fri, 22 Mar 2019 08:41:35 +0000 (17:41 +0900)]
[neurun] Abstract compilation into functions (#4803)
* [neurun] Abstract compilation into functions
Abstract compilation procedure as a function for each Executors.
They are introduced as static, private and has a parameter and a return
value. It is intended to explicitly show which is input and output for
compilation.
Signed-off-by: Hanjoung Lee <hanjoung.lee@samsung.com>
* Rename functions prefix - compile to create
Signed-off-by: Hanjoung Lee <hanjoung.lee@samsung.com>
이상규/On-Device Lab(SR)/Principal Engineer/삼성전자 [Fri, 22 Mar 2019 07:31:05 +0000 (16:31 +0900)]
[neurun] Replace uint32_t with Index in Set (#4816)
operand::Set and operation::Set have hardcoded uint32_t and assertion,
which is based on wrong assumption that Index is always uint32_t.
This patch replaces uint32_t with Index.
Signed-off-by: Sanggyu Lee <sg5.lee@samsung.com>
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Fri, 22 Mar 2019 06:30:41 +0000 (15:30 +0900)]
Fix tizen cross build bug (#4831)
Fix to use nnfw command in tizen cross build script
Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
Андрей Шедько/AI Tools Lab /SRR/Engineer/삼성전자 [Fri, 22 Mar 2019 03:45:27 +0000 (06:45 +0300)]
Cleanup virtual function declarations in neurun backends (#4791)
Cleanup virtual function declarations in neurun cpu and acl_cl backends
Signed-off-by: Andrei Shedko <a.shedko@samsung.com>
[neurun] Remove unneeded dependency of neurun-core on tflite (#4817)
Looks like it is a remnant of times when neurun was being built as a single library (now it is divided into several parts, such as core, front end and back end).
Signed-off-by: Sergei Barannikov <s.barannikov@samsung.com>
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Thu, 21 Mar 2019 23:42:44 +0000 (08:42 +0900)]
Remove skiplist for pacl x86-64 (#4821)
Remove skiplist for pacl x86-64 because pacl is not available for x86-64
Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Thu, 21 Mar 2019 23:35:44 +0000 (08:35 +0900)]
Enable NNAPI compilation validation test (#4808)
* Enable NNAPI compilation validation test
Enable ValidationTestCompilation.Finish test
Define compile state STARTED
Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
* Rename NONE to CREATED
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Thu, 21 Mar 2019 10:49:29 +0000 (19:49 +0900)]
Remove simple operation in ARMComputeEx (#4814)
Remve simple operation in ARMComputeEx except pack/unpack
Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
이상규/On-Device Lab(SR)/Principal Engineer/삼성전자 [Thu, 21 Mar 2019 10:49:09 +0000 (19:49 +0900)]
make distclean should remove nnapi generated tests (#4812)
`make distclean` should remove all derived files after git cloned.
nnapi generated tests are among them.
Signed-off-by: Sanggyu Lee <sg5.lee@samsung.com>
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Thu, 21 Mar 2019 10:48:51 +0000 (19:48 +0900)]
Add reduce max and custom operator framework test (#4811)
Add custom op for reduce max and reduce sum test (for tizen build)
Add custom op squared difference and abs test
Add reduce_max op test
Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Thu, 21 Mar 2019 10:48:06 +0000 (19:48 +0900)]
Set input and output tensor info for interpreter (#4798)
- Set input and output tensor info for interpreter
- Fix TensorInfo bug
- Remove sink/source implementation
Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Thu, 21 Mar 2019 10:07:36 +0000 (19:07 +0900)]
Remove NENormalizationLayer (#4813)
Remove deprecated NENormalizationLayer and NENormalizationLayerExKernel implementation
Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
김수진/On-Device Lab(SR)/Engineer/삼성전자 [Thu, 21 Mar 2019 05:20:40 +0000 (14:20 +0900)]
[neurun] Enable Gather, Neg, Abs ops (#4740)
This commit enables `Gather`, `Neg`, `Abs` ops for `acl_cl`.
Signed-off-by: sjsujinkim <sjsujin.kim@samsung.com>
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Thu, 21 Mar 2019 05:06:46 +0000 (14:06 +0900)]
Enable NNAPI I/O identify validation check (#4810)
Enable ValidationTestIdentify.DuplicateInputs and ValidationTestIdentify.DuplicateOutputs for acl_cl kernel
Enable all ValidationTestIdentify test for cpu kernel
Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
김수진/On-Device Lab(SR)/Engineer/삼성전자 [Thu, 21 Mar 2019 03:46:03 +0000 (12:46 +0900)]
[neurun] Add additional skip lists related to unsupported U8 (#4809)
As We've discussed in #4797 and already merged skip list PR #4805, but some tests related to unsupported U8 are also failed.
This commit adds additional skip lists related to unsupported U8.
Signed-off-by: sjsujinkim <sjsujin.kim@samsung.com>
윤현식/On-Device Lab(SR)/Principal Engineer/삼성전자 [Thu, 21 Mar 2019 02:18:15 +0000 (11:18 +0900)]
[Tools] tool to convert pb file (binary) to pbtxt file (text) (#4788)
* [Tools] Convert pb file to pbtxt file
This tool converts frozen pb file in tensorflow to pbtxt text file.
Signed-off-by: Hyun Sik Yoon <hyunsik.yoon@samsung.com>
* remove common.py
* remove underbar from parameter
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Thu, 21 Mar 2019 01:40:39 +0000 (10:40 +0900)]
Introduce paramter checker (#4804)
Introduce parameter checker. As a first commit,
- Check add node only
- Check activation paramter is constant only
Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Thu, 21 Mar 2019 01:25:00 +0000 (10:25 +0900)]
Rename reduce max operation (#4806)
Rename NNAPI Ex operation for reduce max
TENSORFLOW_MAX_EX -> REDUCE_MAX_EX
Update NeuralNetworksEx.h comment
Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
장지섭/On-Device Lab(SR)/Engineer/삼성전자 [Thu, 21 Mar 2019 01:06:45 +0000 (10:06 +0900)]
Remove const keyword from converting functions in NNAPIConvert (#4802)
This commit removes const keyword from converting functions in NNAPIConvert.
In general, const is used on a return value of RVO because const affect move semantics.
Signed-off-by: jiseob.jang <jiseob.jang@samsung.com>
장지섭/On-Device Lab(SR)/Engineer/삼성전자 [Thu, 21 Mar 2019 01:05:45 +0000 (10:05 +0900)]
Append nnapi tests of comparison into skiplist of neurun (#4805)
This commit appends nnapi tests of comparison into skiplist of neurun.
Signed-off-by: jiseob.jang <jiseob.jang@samsung.com>