Sean Fertile [Wed, 8 Jan 2020 17:32:32 +0000 (12:32 -0500)]
[PowerPC] The VK_PLT symbolref modifier is only used on 32-bit ELF. [NFC]
Fix a conditional that guarded code for execution only on 32-bit ELF by
checking that the Subtarget was not 64-bit and not-Darwin. By adding a new
target ABI (AIX), the condition is no longer correct. This code is dead for
AIX, due to a 'report_fatal_error' for thread local storage usage earlier in the
pipeline, but needs to be modifed as part of Darwins removal from the
PowerPC backend.
Erik Pilkington [Thu, 9 Jan 2020 18:24:09 +0000 (10:24 -0800)]
[demangle] Copy back some NFC commits from LLVM
Craig Topper [Thu, 9 Jan 2020 00:12:31 +0000 (16:12 -0800)]
[TargetLowering][X86] TeachSimplifyDemandedBits to handle cases where only the sign bit is demanded from a SETCC and can be passed through
If we're doing a compare that only tests the sign bit and only the sign bit is demanded, we can just bypass the node. This removes one of the blend dependencies in our v2i64->v2f32 uint_to_fp codegen on pre-sse4.2 targets.
Differential Revision: https://reviews.llvm.org/D72356
Bruno Ricci [Thu, 9 Jan 2020 18:14:05 +0000 (18:14 +0000)]
[Support][NFC] Add an explicit unit test for Process::getPageSize()
It turns out that it was only tested indirectly. For now test only on Linux
X86-64 and aarch64.
Sanjay Patel [Thu, 9 Jan 2020 18:06:54 +0000 (13:06 -0500)]
[x86] add tests for 2-way splat copy; NFC
Based on code in PR42024:
https://bugs.llvm.org/show_bug.cgi?id=42024
Ulrich Weigand [Thu, 9 Jan 2020 18:03:16 +0000 (19:03 +0100)]
[SystemZ] Fix matching another pattern for nxgrk (PR44496)
SystemZDAGToDAGISel::Select will attempt to split logical instruction
with a large immediate constant. This must not happen if the result
matches one of the z15 combined operations, so the code checks for
those. However, one of them was missed, causing invalid code to
be generated in the test case for PR44496.
Jonas Devlieghere [Thu, 9 Jan 2020 17:54:46 +0000 (09:54 -0800)]
[lldb/SWIG] Undo incorrect substitution
The Python directory for the script interpreter is still capitalized.
Bruno Ricci [Thu, 9 Jan 2020 17:38:50 +0000 (17:38 +0000)]
[Support][NFC] Make some helper functions "static" in Memory.inc
Simon Moll [Thu, 9 Jan 2020 17:37:08 +0000 (18:37 +0100)]
[NFC,format] Sort switch cases alphabetically
This patch brings the switch cases of `llvm/lib/Support/Triple.cpp` back into alphabetical order.
This was noted during the the review of https://reviews.llvm.org/D69103
Reviewed By: arsenm
Differential Revision: https://reviews.llvm.org/D72452
Bruno Ricci [Thu, 9 Jan 2020 17:11:29 +0000 (17:11 +0000)]
[Support][NFC] Add a comment about the semantics of MF_HUGE_HINT flag
Simon Tatham [Thu, 9 Jan 2020 17:01:13 +0000 (17:01 +0000)]
[Clang] Handle target-specific builtins returning aggregates.
Summary:
A few of the ARM MVE builtins directly return a structure type. This
causes an assertion failure at code-gen time if you try to assign the
result of the builtin to a variable, because the `RValue` created in
`EmitBuiltinExpr` from the `llvm::Value` produced by codegen is always
made by `RValue::get()`, which creates a non-aggregate `RValue` that
will fail an assertion when `AggExprEmitter::withReturnValueSlot` calls
`Src.getAggregatePointer()`. A similar failure occurs if you try to use
the struct return value directly to extract one field, e.g.
`vld2q(address).val[0]`.
The existing code-gen tests for those MVE builtins pass the returned
structure type directly to the C `return` statement, which apparently
managed to avoid that particular code path, so we didn't notice the
crash.
Now `EmitBuiltinExpr` checks the evaluation kind of the builtin's return
value, and does the necessary handling for aggregate returns. I've added
two extra test cases, both of which crashed before this change.
Reviewers: dmgreen, rjmccall
Reviewed By: rjmccall
Subscribers: kristof.beyls, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D72271
Jonas Devlieghere [Thu, 9 Jan 2020 17:22:04 +0000 (09:22 -0800)]
[lldb/SWIG] Fix capitalization for case sensitive file systems.
When moving the Python directory I renamed it to python (lowercase) but
didn't update the python.swig file.
Kadir Cetinkaya [Thu, 9 Jan 2020 15:54:22 +0000 (16:54 +0100)]
[clangd] Adjust diagnostic range to be inside main file
Summary:
LSP requires diagnostics to lay inside main file. In clangd we keep
diagnostics in three different cases:
- already in main file
- adjusted to a header included in main file
- has a note covering some range in main file
In the last case, we were not adjusting the diagnostics range to be in main
file, therefore these diagnostics ended up pointing some arbitrary locations.
This patch fixes that issue by adjusting the range of diagnostics to be the
first note inside main file when converting to LSP.
Reviewers: ilya-biryukov
Subscribers: MaskRay, jkorous, arphaman, usaxena95, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D72458
Jonas Devlieghere [Thu, 9 Jan 2020 15:57:59 +0000 (07:57 -0800)]
[lldb/Bindings] Move bindings into their own subdirectory
All the code required to generate the language bindings for Python and
Lua lives under scripts, even though the majority of this code aren't
scripts at all, and surrounded by scripts that are totally unrelated.
I've reorganized these files and moved everything related to the
language bindings into a new top-level directory named bindings. This
makes the corresponding files self contained and much more discoverable.
Differential revision: https://reviews.llvm.org/D72437
Sven van Haastregt [Thu, 9 Jan 2020 16:31:45 +0000 (16:31 +0000)]
[OpenCL][Docs] Rename C++ for OpenCL label
To avoid potential confusion with OpenCL C++.
serge-sans-paille [Wed, 11 Dec 2019 20:30:10 +0000 (21:30 +0100)]
Improve support of GNU mempcpy
- Lower to the memcpy intrinsic
- Raise warnings when size/bounds are known
Differential Revision: https://reviews.llvm.org/D71374
Whitney Tsang [Thu, 9 Jan 2020 16:15:53 +0000 (16:15 +0000)]
[NFCI][LoopUnrollAndJam] Changing LoopUnrollAndJamPass to a function
pass.
Summary: This patch changes LoopUnrollAndJamPass to a function pass, and
keeps the loops traversal order same as defined in
FunctionToLoopPassAdaptor LoopPassManager.h.
The next patch will change the loop traversal to outer to inner order,
so more loops can be transform.
Discussion in llvm-dev mailing list:
https://groups.google.com/forum/#!topic/llvm-dev/LF4rUjkVI2g
Reviewer: dmgreen, jdoerfert, Meinersbur, kbarton, bmahjour, etiotto
Reviewed By: dmgreen
Subscribers: hiraditya, zzheng, llvm-commits
Tag: LLVM
Differential Revision: https://reviews.llvm.org/D72230
Jonas Devlieghere [Thu, 9 Jan 2020 16:15:01 +0000 (08:15 -0800)]
[lldb/Lua] Make lldb.debugger et al available to Lua
The Python script interpreter makes the current debugger, target,
process, thread and frame available to interactive scripting sessions
through convenience variables. This patch does the same for Lua.
Differential revision: https://reviews.llvm.org/D71801
Jonas Devlieghere [Thu, 9 Jan 2020 16:13:25 +0000 (08:13 -0800)]
[lldb/SWIG] Add missing '\' in macros again
Making the string conversion operator a macro unintentionally dropped
the backslash before '\n' and '\r' and was therefore incorrectly
stripping 'n' and 'r' from the object description.
David Goldman [Wed, 8 Jan 2020 22:01:59 +0000 (17:01 -0500)]
[clangd] Respect `--sysroot` argument if it is set
Summary:
- Since `--sysroot` is a superset of the `-isysroot` argument, we
shouldn't add the `-isysroot` if we detect a `--sysroot` flag.
Reviewers: sammccall
Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, kadircet, usaxena95, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D72415
Sergej Jaskiewicz [Thu, 26 Dec 2019 09:28:39 +0000 (12:28 +0300)]
[libcxxabi] Allow tests to link with static libc++abi/libc++ even if the shared version is present
Summary:
Right now the only way to force libc++abi tests to link with the static version of libc++abi is to set `LIBCXXABI_ENABLE_SHARED` to `OFF`. However, this doesn't work when libc++abi is built as standalone project because of [this](https://github.com/llvm/llvm-project/blob/
54c522420347e58aa7bae1892cf5c5672b57c875/libcxxabi/CMakeLists.txt#L503-L519).
This change allows specifying the version of the library for tests to link with.
This is useful for remote testing, for example, with `SSHExecutor`, where we _have_ to link with libc++abi statically.
Two new CMake options are introduced here: `LIBCXXABI_LINK_TESTS_WITH_SHARED_LIBCXXABI` and `LIBCXXABI_LINK_TESTS_WITH_SHARED_LIBCXX`. They can be set to `OFF` to tell the test utility to link tests with the static libraries.
It shouldn't break anything, because the default values of these options are set such that the test utility will behave the same way.
Reviewers: EricWF, mclow.lists, phosek, mehdi_amini, ldionne, jroelofs, bcraig
Subscribers: mgorny, christof, ldionne, libcxx-commits
Tags: #libc
Differential Revision: https://reviews.llvm.org/D71894
@raghesh (Raghesh Aloor) [Thu, 9 Jan 2020 15:52:39 +0000 (10:52 -0500)]
[InstCombine] Z / (1.0 / Y) => (Y * Z)
This is a special case of Z / (X / Y) => (Y * Z) / X, with X = 1.0.
The m_OneUse check is avoided because even in the case of the
multiple uses for 1.0/Y, the number of instructions remain the same
and a division is replaced by a multiplication.
Differential Revision: https://reviews.llvm.org/D72319
Sid Manning [Thu, 2 Jan 2020 18:54:59 +0000 (12:54 -0600)]
[ELF][Hexagon] Add support for IE relocations
Differential Revision: https://reviews.llvm.org/D71143
Matt Arsenault [Wed, 8 Jan 2020 15:53:22 +0000 (10:53 -0500)]
TableGen: Remove unused code
Matt Arsenault [Wed, 8 Jan 2020 01:22:06 +0000 (20:22 -0500)]
AMDGPU/GlobalISel: Fix import of integer med3
This isn't too useful now, since nothing is currently trying to form
min/max from cmp+select.
Matt Arsenault [Tue, 7 Jan 2020 23:52:18 +0000 (18:52 -0500)]
AMDGPU: Eliminate more legacy codepred address space PatFrags
These should now be limited to R600 code.
Matt Arsenault [Tue, 7 Jan 2020 22:46:52 +0000 (17:46 -0500)]
AMDGPU: Use new PatFrag system for d16 stores
Matt Arsenault [Tue, 7 Jan 2020 21:48:05 +0000 (16:48 -0500)]
AMDGPU: Use new PatFrag system for d16 load nodes
Matt Arsenault [Tue, 7 Jan 2020 18:10:08 +0000 (13:10 -0500)]
AMDGPU/GlobalISel: Fix import of zext of s16 op patterns
Matt Arsenault [Tue, 7 Jan 2020 17:38:35 +0000 (12:38 -0500)]
AMDGPU/GlobalISel: Add IMMPopCount xform
Partially fixes BFE pattern import.
Matt Arsenault [Tue, 7 Jan 2020 17:21:18 +0000 (12:21 -0500)]
AMDGPU/GlobalISel: Add selectVOP3Mods_nnan
This doesn't enable any new imports yet, but moves the fmed patterns
from failing on this to hitting the "complex suboperand referenced
more than once" limitation in tablegen.
Matt Arsenault [Tue, 7 Jan 2020 16:45:10 +0000 (11:45 -0500)]
AMDGPU/GlobalISel: Add equiv xform for bitcast_fpimm_to_i32
Only partially fixes one pattern import.
Matt Arsenault [Tue, 7 Jan 2020 16:29:05 +0000 (11:29 -0500)]
AMDGPU/GlobalISel: Fix add of neg inline constant pattern
Matt Arsenault [Wed, 8 Jan 2020 23:57:44 +0000 (18:57 -0500)]
TableGen/GlobalISel: Fix slightly wrong generated comment
Matt Arsenault [Wed, 8 Jan 2020 19:12:19 +0000 (14:12 -0500)]
AMDGPU: Add register class to DS_SWIZZLE_B32 pattern
Reduces diff for a future patch.
Simon Tatham [Thu, 9 Jan 2020 11:23:20 +0000 (11:23 +0000)]
[ARM,MVE] Add missing IntrNoMem flag on IR intrinsics.
A lot of the IR-level intrinsics we've been defining for MVE recently
accidentally had `props = []` instead of `props = [IntrNoMem]`, so
that optimization would have been overcautious about reordering them.
All the affected cases were due to instantiating the multiclasses
`MVEPredicated` and `MVEMXPredicated` without filling in the `props`
parameter, because I //thought// I remembered having set the defaults
in those multiclasses to `[IntrNoMem]`. In fact I hadn't done that.
Now I have.
(The IR intrinsics that //do// read and write memory are all
explicitly marked as `[IntrReadMem]` or `[IntrWriteMem]` already, so
they will override these defaults.)
Simon Tatham [Thu, 9 Jan 2020 10:49:41 +0000 (10:49 +0000)]
[ARM,MVE] Fix valid immediate range for vsliq_n.
In common with most MVE immediate shift instructions, the left shift
takes an immediate in the range [0,n-1], while the right shift takes
one in the range [1,n]. I had absent-mindedly made them both the
latter.
While I'm here, I've added a set of regression tests checking both
ends of the immediate range for a representative sample of the
immediate shifts.
Tim Northover [Thu, 9 Jan 2020 14:28:48 +0000 (14:28 +0000)]
IR: remove "else" after "return". NFCI.
Alexey Bataev [Thu, 9 Jan 2020 14:28:59 +0000 (09:28 -0500)]
[OPENMP]Remove unused code, NFC.
Sanjay Patel [Thu, 9 Jan 2020 14:36:22 +0000 (09:36 -0500)]
[DAGCombiner] reduce extract subvector of concat
If we are extracting a chunk of a vector that's a fraction of an
operand of the concatenated vector operand, we can extract directly
from one of those original operands.
This is another suggestion from PR42024:
https://bugs.llvm.org/show_bug.cgi?id=42024#c2
But I'm not sure yet if it will make any difference on those patterns.
It seems to help a few existing AVX512 tests though.
Differential Revision: https://reviews.llvm.org/D72361
Saar Raz [Thu, 9 Jan 2020 14:13:46 +0000 (16:13 +0200)]
[Concepts] Fix failing test on Windows
Fix test failed by D43357 on Windows.
Sanjay Patel [Thu, 9 Jan 2020 14:02:53 +0000 (09:02 -0500)]
[InstSimplify] select Cond, true, false --> Cond
This is step 1 of damage control assuming that we need to remove several
over-reaching folds for select-of-booleans because they can cause
miscompiles as shown in D72396.
The scalar case seems obviously safe:
https://rise4fun.com/Alive/jSj
And I don't think there's any danger for vectors either - if the
condition is poisoned, then the select must be poisoned too, so undef
elements don't make any difference.
Differential Revision: https://reviews.llvm.org/D72412
Momchil Velikov [Thu, 9 Jan 2020 13:47:52 +0000 (13:47 +0000)]
[ARM][MVE] MVE-I should not be disabled by -mfpu=none
Architecturally, it's allowed to have MVE-I without an FPU, thus
-mfpu=none should not disable MVE-I, or moves to/from FP-registers.
This patch removes `+/-fpregs` from features unconditionally added to
target feature list, depending on FPU and moves the logic to Clang
driver, where the negative form (`-fpregs`) is conditionally added to
the target features list for the cases of `-mfloat-abi=soft`, or
`-mfpu=none` without either `+mve` or `+mve.fp`. Only the negative
form is added by the driver, the positive one is derived from other
features in the backend.
Differential Revision: https://reviews.llvm.org/D71843
Sanjay Patel [Thu, 9 Jan 2020 13:20:24 +0000 (08:20 -0500)]
[InstCombine] Use minimal FMF in testcase for Z / (1.0 / Y) => (Y * Z); NFC
Patch by: @raghesh (Raghesh Aloor)
Differential Revision: https://reviews.llvm.org/D72431
Pavel Labath [Thu, 9 Jan 2020 13:14:54 +0000 (14:14 +0100)]
[lldb] Modernize OptionValue::SetValueChangedCallback
instead of a function pointer + void*, take a std::function. This
removes a bunch of repetitive, unsafe void* casts.
Hiroshi Inoue [Thu, 9 Jan 2020 13:03:23 +0000 (13:03 +0000)]
[mlir] fix test failure in EDSC/builder-api-test
This patch fixes a test failure on a non-intel (PowerPC64) box.
The two affine.load are independent and hence llvm may reorder them.
The CHECK lines are modified for supporting reordered case.
Differential Revision: https://reviews.llvm.org/D72435
Saar Raz [Thu, 9 Jan 2020 13:07:51 +0000 (15:07 +0200)]
[Concepts] Function trailing requires clauses
Function trailing requires clauses now parsed, supported in overload resolution and when calling, referencing and taking the address of functions or function templates.
Differential Revision: https://reviews.llvm.org/D43357
Sam Parker [Thu, 9 Jan 2020 12:52:50 +0000 (12:52 +0000)]
[NFC][ARM] LowOverheadLoop comments
Add a comment describing the dependencies of the pass.
Simon Pilgrim [Thu, 9 Jan 2020 12:35:21 +0000 (12:35 +0000)]
Fix "pointer is null" static analyzer warning. NFCI.
Use cast<> instead of dyn_cast<> since we know that the pointer should be valid (and is dereferenced immediately).
Simon Pilgrim [Thu, 9 Jan 2020 12:33:37 +0000 (12:33 +0000)]
Fix "pointer is null" static analyzer warning. NFCI.
Use cast<> instead of dyn_cast<> since we know that the pointer should be valid (and is dereferenced immediately below).
Pavel Labath [Fri, 20 Dec 2019 08:42:37 +0000 (09:42 +0100)]
[lldb/DWARF] Fix mixed v4+v5 location lists
Summary:
Our code was expecting that a single (symbol) file contains only one
kind of location lists. This is not correct (on non-apple platforms, at
least) as a file can compile units with different dwarf versions.
This patch moves the deteremination of location list flavour down to the
compile unit level, fixing this problem. I have also tried to rougly
align the code with the llvm DWARFUnit. Fully matching the API is not
possible because of how lldb's DWARFExpression lives separately from the
rest of the DWARF code, but this is at least a step in the right
direction.
Reviewers: JDevlieghere, aprantl, clayborg
Subscribers: dblaikie, lldb-commits
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D71751
Pavel Labath [Tue, 17 Dec 2019 16:12:29 +0000 (17:12 +0100)]
[lldb/DWARF] Add is_dwo member to DWARFUnit
Summary:
A skeleton unit can easily be detected by checking the m_dwo_symbol_file
member, but we cannot tell a split unit from a normal unit from the
"inside", which is sometimes useful.
This patch adds a m_is_dwo member to enable this, and align the code
with llvm::DWARFUnit. Right now it's only used to avoid creating a split
unit inside another split unit (which removes one override from
SymbolFileDWARFDwo and brings us a step closer to deleting it), but my
main motivation is fixing the handling of location lists in mixed v4&v5
files. This comes in a separate patch.
Reviewers: JDevlieghere, aprantl, clayborg
Subscribers: dblaikie, lldb-commits
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D71750
Simon Pilgrim [Thu, 9 Jan 2020 12:05:30 +0000 (12:05 +0000)]
Fix "pointer is null" static analyzer warnings. NFCI.
Use castAs<> instead of getAs<> since the pointer is dereferenced immediately below and castAs will perform the null assertion for us.
Simon Pilgrim [Thu, 9 Jan 2020 11:48:06 +0000 (11:48 +0000)]
Fix "pointer is null" static analyzer warnings. NFCI.
Assert that the pointers are non-null before dereferencing them.
Sam Parker [Thu, 9 Jan 2020 11:57:04 +0000 (11:57 +0000)]
[ARM][MVE] Don't unroll intrinsic loops.
We don't unroll vector loops for MVE targets, but we miss the case
when loops only contain intrinsic calls. So just move the logic a
bit to catch this case.
Differential Revision: https://reviews.llvm.org/D72440
Andi-Bogdan Postelnicu [Thu, 9 Jan 2020 08:00:05 +0000 (10:00 +0200)]
[clang-tidy] For checker `readability-misleading-indentation` update tests.
Summary: In D72333 we've introduced support for `if constexpr` but the test for uninstantiated template was not ready to land on windows platform since this target uses `-fdelayed-template-parsing` by default. This patch addresses this by passing `-fno-delayed-template-parsing` to the test.
Reviewers: JonasToth
Subscribers: xazax.hun, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D72438
Simon Pilgrim [Thu, 9 Jan 2020 11:10:46 +0000 (11:10 +0000)]
Fix MSVC unhandled enum warning. NFCI.
Raphael Isemann [Thu, 9 Jan 2020 11:09:44 +0000 (12:09 +0100)]
[lldb] Fix that TestNoSuchArch.py was passing for the wrong reason
The command here failed due to the type in 'create' but the expect
did not actually check for the error message. This fixes the typo
and adds a check for the actuall error message we should see.
Florian Hahn [Thu, 9 Jan 2020 10:23:34 +0000 (10:23 +0000)]
[Matrix] Update shape propagation to iterate until done.
This patch updates the shape propagation to iterate until no new shape
information is discovered.
As initial seed for the forward propagation, we use the matrix intrinsic
instructions. Both propagateShapeForward and propagateShapeBackward
return new work lists, with the instructions to be used for the next
iteration. When propagating forward, we record all instructions we added
new shape information for. When propagating backward, we record all
users of instructions we added new shape information for.
Reviewers: anemet, Gerolf, reames, hfinkel, andrew.w.kaylor
Reviewed By: anemet
Differential Revision: https://reviews.llvm.org/D70901
Kadir Cetinkaya [Fri, 13 Dec 2019 08:34:59 +0000 (09:34 +0100)]
[clangd] Refurbish HoverInfo::present
Summary: Improves basic hover presentation logic to include more info.
Reviewers: sammccall
Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, usaxena95, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D71555
Florian Hahn [Thu, 9 Jan 2020 09:52:04 +0000 (09:52 +0000)]
[Matrix] Propagate and use shape information for loads.
This patch extends to shape propagation to also include load
instructions and implements shape aware lowering for vector loads.
Reviewers: anemet, Gerolf, reames, hfinkel, andrew.w.kaylor
Reviewed By: anemet
Differential Revision: https://reviews.llvm.org/D70900
Kazushi (Jam) Marukawa [Thu, 9 Jan 2020 08:59:37 +0000 (09:59 +0100)]
[VE] Target stub for NEC SX-Aurora
Summary:
This patch registers the 've' target: the NEC SX-Aurora TSUBASA Vector Engine.
Reviewed By: arsenm
Differential Revision: https://reviews.llvm.org/D69103
Evgeniy Brevnov [Tue, 31 Dec 2019 06:33:44 +0000 (13:33 +0700)]
[LoopUtils][NFC] Minor refactoring in getLoopEstimatedTripCount.
Florian Hahn [Thu, 9 Jan 2020 09:47:26 +0000 (09:47 +0000)]
[Matrix] Implement back-propagation of shape information.
This patch extends the shape propagation for matrix operations to also
propagate the shape of instructions to their operands.
Reviewers: anemet, Gerolf, reames, hfinkel, andrew.w.kaylor
Reviewed By: anemet
Differential Revision: https://reviews.llvm.org/D70899
Sam Parker [Thu, 9 Jan 2020 09:21:05 +0000 (09:21 +0000)]
Revert "[ARM][LowOverheadLoops] Update liveness info"
This reverts commit
e93e0d413f3afa1df5c5f88df546bebcd1183155.
There's some ordering problems on some on the buildbots which needs
investigating.
Pavel Labath [Thu, 9 Jan 2020 09:14:30 +0000 (10:14 +0100)]
[DWARFDebugLoc] Tweak error message when resolving offset pairs with no base address
The previous message mentioned DW_LLE_offset_pair, but this is
incorrect/confusing because we can get this message even with DWARF4
(which does not use DW_LLE encodings). This happens because DWARF<=4
location entries are "upgraded" to DWARF v5 during parsing.
The new error message refrains from referencing specific constants.
Fixes pr44482.
Sjoerd Meijer [Thu, 9 Jan 2020 09:14:00 +0000 (09:14 +0000)]
[LV] Still vectorise when tail-folding can't find a primary inducation variable
This addresses a vectorisation regression for tail-folded loops that are
counting down, e.g. loops as simple as this:
void foo(char *A, char *B, char *C, uint32_t N) {
while (N > 0) {
*C++ = *A++ + *B++;
N--;
}
}
These are loops that can be vectorised, but when tail-folding is requested, it
can't find a primary induction variable which we do need for predicating the
loop. As a result, the loop isn't vectorised at all, which it is able to do
when tail-folding is not attempted. So, this adds a check for the primary
induction variable where we decide how to lower the scalar epilogue. I.e., when
there isn't a primary induction variable, a scalar epilogue loop is allowed
(i.e. don't request tail-folding) so that vectorisation could still be
triggered.
Having this check for the primary induction variable make sense anyway, and in
addition, in a follow-up of this I will look into discovering earlier the
primary induction variable for counting down loops, so that this can also be
tail-folded.
Differential revision: https://reviews.llvm.org/D72324
Alex Zinenko [Tue, 7 Jan 2020 19:00:54 +0000 (20:00 +0100)]
[mlir][GPU] introduce utilities for promotion to workgroup memory
Introduce a set of function that promote a memref argument of a `gpu.func` to
workgroup memory using memory attribution. The promotion boils down to
additional loops performing the copy from the original argument to the
attributed memory in the beginning of the function, and back at the end of the
function using all available threads. The loop bounds are specified so as to
adapt to any size of the workgroup. These utilities are intended to compose
with other existing utilities (loop coalescing and tiling) in cases where the
distribution of work across threads is uneven, e.g. copying a 2D memref with
only the threads along the "x" dimension. Similarly, specialization of the
kernel to specific launch sizes should be implemented as a separate pass
combining constant propagation and canonicalization.
Introduce a simple attribute-driven pass to test the promotion transformation
since we don't have a heuristic at the moment.
Differential revision: https://reviews.llvm.org/D71904
Sam Parker [Thu, 9 Jan 2020 08:33:47 +0000 (08:33 +0000)]
[ARM][LowOverheadLoops] Update liveness info
After expanding the pseudo instructions, update the liveness info.
We do this in a post-order traversal of the loop, including its
exit blocks and preheader(s).
Differential Revision: https://reviews.llvm.org/D72131
Nicolas Vasilache [Thu, 9 Jan 2020 08:12:41 +0000 (03:12 -0500)]
[mlir][VectorOps] Implement insert_strided_slice conversion
Summary:
This diff implements the progressive lowering of insert_strided_slice.
Two cases appear:
1. when the source and dest vectors have different ranks, extract the dest
subvector at the proper offset and reduce to case 2.
2. when they have the same rank N:
a. if the source and dest type are the same, the insertion is trivial:
just forward the source
b. otherwise, iterate over all N-1 D subvectors and create an
extract/insert_strided_slice/insert replacement, reducing the problem
to vecotrs of the same N-1 rank.
This combines properly with the other conversion patterns to lower all the way to LLVM.
Reviewers: ftynse, rriddle, AlexEichenberger, andydavis1, tetuante, nicolasvasilache
Reviewed By: andydavis1
Subscribers: merge_guards_bot, mehdi_amini, jpienaar, burmako, shauheen, antiagainst, arpith-jacob, mgester, lucyrfox, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D72317
Nicolas Vasilache [Thu, 9 Jan 2020 07:58:21 +0000 (02:58 -0500)]
[mlir][VectorOps] Implement strided_slice conversion
Summary:
This diff implements the progressive lowering of strided_slice to either:
1. extractelement + insertelement for the 1-D case
2. extract + optional strided_slice + insert for the n-D case.
This combines properly with the other conversion patterns to lower all the way to LLVM.
Appropriate tests are added.
Reviewers: ftynse, rriddle, AlexEichenberger, andydavis1, tetuante
Reviewed By: andydavis1
Subscribers: merge_guards_bot, mehdi_amini, jpienaar, burmako, shauheen, antiagainst, arpith-jacob, mgester, lucyrfox, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D72310
Ehud Katz [Thu, 9 Jan 2020 07:42:32 +0000 (09:42 +0200)]
[APFloat] Fix checked error assert failures
`APFLoat::convertFromString` returns `Expected` result, which must be
"checked" if the LLVM_ENABLE_ABI_BREAKING_CHECKS preprocessor flag is
set.
To mark an `Expected` result as "checked" we must consume the `Error`
within.
In many cases, we are only interested in knowing if an error occured,
without the need to examine the error info. This is achieved, easily,
with the `errorToBool()` API.
Zheng Chen [Thu, 9 Jan 2020 06:24:22 +0000 (01:24 -0500)]
[SCEV] [NFC] add testcase for constant range for addrecexpr with nsw flag
Jonas Devlieghere [Thu, 9 Jan 2020 04:56:11 +0000 (20:56 -0800)]
[lldb/SWIG] Refactor extensions to be non Python-specific (3/3)
The current SWIG extensions for the string conversion operator is Python
specific because it uses the PythonObjects. This means that the code
cannot be reused for other SWIG supported languages such as Lua.
This reimplements the extensions in a more generic way that can be
reused. It uses a SWIG macro to reduce code duplication.
Differential revision: https://reviews.llvm.org/D72377
QingShan Zhang [Thu, 9 Jan 2020 03:41:36 +0000 (03:41 +0000)]
[DAGCombine] Fold the (fma -x, y, -z) to -(fma x, y, z)
This is a positive combination as long as the NEG is NOT free,
as we are reducing the number of NEG from two to one.
Differential Revision: https://reviews.llvm.org/D72312
Daniel Sanders [Thu, 9 Jan 2020 04:02:37 +0000 (20:02 -0800)]
Revert "Revert "[MIR] Target specific MIR formating and parsing""
There was an unguarded dereference of MF in a function that permitted
nullptr. Fixed
This reverts commit
71d64f72f934631aa2f12b9542c23f74f256f494.
Nico Weber [Thu, 9 Jan 2020 03:50:49 +0000 (22:50 -0500)]
Revert "[MIR] Target specific MIR formating and parsing"
This reverts commit
3ef05d85be8c3666ebfa3ad986eb334da5195a47.
It broke check-llvm on many bots, see comments on D69836.
Peng Guo [Thu, 9 Jan 2020 01:13:24 +0000 (17:13 -0800)]
[MIR] Target specific MIR formating and parsing
Summary:
Added MIRFormatter for target specific MIR formating and parsing with
immediate and custom pseudo source values. Target machine can subclass
MIRFormatter and implement custom logic for printing and parsing
immediate and custom pseudo source values for better readability.
* Target specific immediate mnemonic need to start with "." follows by
identifier string. When MIR parser sees immediate it will call target
specific parsing function.
* Custom pseudo source value need to start with custom follows by
double-quoted string. MIR parser will pass the quoted string to target
specific PSV parsing function.
* MIRFormatter have 2 helper functions to facilitate LLVM value printing
and parsing for custom PSV if they refers LLVM values.
Patch by Peng Guo
Reviewers: dsanders, arsenm
Reviewed By: dsanders
Subscribers: wdng, jvesely, nhaehnle, hiraditya, jfb, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D69836
Daniel Sanders [Thu, 9 Jan 2020 02:44:12 +0000 (18:44 -0800)]
Revert "[MIR] Target specific MIR formating and parsing"
Forgot to credit Peng in the commit message.
This reverts commit
be841f89d0014b1e0246a4feae941b2f74abd908.
Jason Molenda [Thu, 9 Jan 2020 02:44:50 +0000 (18:44 -0800)]
Save more descriptive error msg from FBS/BKS, relay it up to lldb.
When lldb requests an app launch through FrontBoard/BackBoard,
we get back an NSError object if there was a problem with an
integer error code and a descriptive text string. debugserver
would log the descriptive text string to the console, but it
would only save the error code value, ask for the
much-less-specific name of that error code, and send that very
generic error word back to lldb.
This patch saves the longer description of the failure when
available, and sends that to lldb. If unavailable, it falls
back to sending up the generic description of the error code
as it was doing before.
This only impacts the iOS on-device debugserver.
<rdar://problem/
49953304>
Peng Guo [Thu, 9 Jan 2020 01:13:24 +0000 (17:13 -0800)]
[MIR] Target specific MIR formating and parsing
Summary:
Added MIRFormatter for target specific MIR formating and parsing with
immediate and custom pseudo source values. Target machine can subclass
MIRFormatter and implement custom logic for printing and parsing
immediate and custom pseudo source values for better readability.
* Target specific immediate mnemonic need to start with "." follows by
identifier string. When MIR parser sees immediate it will call target
specific parsing function.
* Custom pseudo source value need to start with custom follows by
double-quoted string. MIR parser will pass the quoted string to target
specific PSV parsing function.
* MIRFormatter have 2 helper functions to facilitate LLVM value printing
and parsing for custom PSV if they refers LLVM values.
Reviewers: dsanders, arsenm
Reviewed By: dsanders
Subscribers: wdng, jvesely, nhaehnle, hiraditya, jfb, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D69836
Alex Langford [Wed, 8 Jan 2020 23:35:21 +0000 (15:35 -0800)]
[lldb] Remove various dead Compare functions
Zheng Chen [Thu, 9 Jan 2020 01:54:15 +0000 (20:54 -0500)]
[PowerPC] when folding rlwinm+rlwinm. to andi., we should use first rlwinm
input reg.
%2:gprc = RLWINM %1:gprc, 27, 5, 10
%3:gprc = RLWINM_rec %2:gprc, 8, 5, 10, implicit-def $cr0
==>
%3:gprc = ANDI_rec %1, 0, implicit-def $cr0
we should use %1 instead of %2 as ANDI_rec input.
Reviewed By: steven.zhang
Differential Revision: https://reviews.llvm.org/D71885
Mircea Trofin [Thu, 9 Jan 2020 01:42:23 +0000 (17:42 -0800)]
Revert "[NFC][InlineCost] Factor cost modeling out of CallAnalyzer traversal."
This reverts commit
76aab66d34446ccf764cf8127b73e1517df75fb4.
Failure:
http://lab.llvm.org:8011/builders/clang-with-thin-lto-ubuntu/builds/20562,
will investigate and resubmit.
Johannes Doerfert [Tue, 7 Jan 2020 22:01:57 +0000 (16:01 -0600)]
[Attributor][FIX] Carefully change invokes to calls (after manifest)
Before we manually inserted unreachable early but that could lead to
broken PHI nodes. Now we use the existing late modification
functionality.
Johannes Doerfert [Tue, 7 Jan 2020 21:10:30 +0000 (15:10 -0600)]
[Attributor][FIX] Avoid dangling value pointers during code modification
When we replace instructions with unreachable we delete instructions. We
now avoid dangling pointers to those deleted instructions in the
`ToBeChangedToUnreachableInsts` set. Other modification collections
might need to be updated in the future as well.
Mircea Trofin [Thu, 9 Jan 2020 01:11:23 +0000 (17:11 -0800)]
[NFC][InlineCost] Factor cost modeling out of CallAnalyzer traversal.
Summary:
The goal is to simplify experimentation on the cost model. Today,
CallAnalyzer decides 2 things: legality, and benefit. The refactoring
keeps legality assessment in CallAnalyzer, and factors benefit
evaluation out, as an extension.
Reviewers: davidxl, eraman
Subscribers: kamleshbhalui, fedor.sergeev, hiraditya, baloghadamsoftware, haicheng, a.sidorin, Szelethus, donat.nagy, dkrupp, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D71733
Justin Hibbits [Mon, 30 Dec 2019 21:09:39 +0000 (15:09 -0600)]
[PowerPC]: Add powerpcspe target triple subarch component
Summary:
This allows the use of '-target powerpcspe-unknown-linux-gnu' or
'powerpcspe-unknown-freebsd' to be used, instead of
'-target powerpc-unknown-linux-gnu -mspe'.
Reviewed By: dim
Differential Revision: https://reviews.llvm.org/D72014
Jonas Paulsson [Tue, 19 Nov 2019 11:34:49 +0000 (12:34 +0100)]
Recommit "[MachineVerifier] Improve verification of live-in lists."
MachineVerifier::visitMachineFunctionAfter() is extended to check the
live-through case for live-in lists. This is only done for registers without
aliases and that are neither allocatable or reserved, such as the SystemZ::CC
register.
The MachineVerifier earlier only catched the case of a live-in use without an
entry in the live-in list (as "using an undefined physical register").
A comment in LivePhysRegs.h has been added stating a guarantee that
addLiveOuts() can be trusted for a full register both before and after
register allocation.
Review: Quentin Colombet
Differential Revision: https://reviews.llvm.org/D68267
Billy Robert O'Neal III [Thu, 9 Jan 2020 00:46:55 +0000 (16:46 -0800)]
[libcxx] [test] Disable refwrap/weak_result.pass.cpp in C++20 mode (broken by P0357R3)
Gabor Horvath [Thu, 9 Jan 2020 00:37:46 +0000 (16:37 -0800)]
[NFC] Whitespace fixes
Jonas Paulsson [Wed, 11 Dec 2019 20:45:53 +0000 (21:45 +0100)]
[X86] Remove EFLAGS from live-in lists in X86FlagsCopyLowering.
When EFLAGS is no longer live into a basic block, remove it from the live-in
list.
Fixes https://bugs.llvm.org/show_bug.cgi?id=44462.
Review: Craig Topper
Differential Revision: https://reviews.llvm.org/D71375
Jonas Devlieghere [Thu, 9 Jan 2020 00:13:03 +0000 (16:13 -0800)]
[lldb/SWIG] Refactor extensions to be non Python-specific (2/2)
The current SWIG extensions for the string conversion operator is Python
specific because it uses the PythonObjects. This means that the code
cannot be reused for other SWIG supported languages such as Lua.
This reimplements the extensions in a more generic way that can be
reused. It uses a SWIG macro to reduce code duplication.
Differential revision: https://reviews.llvm.org/D72377
Fangrui Song [Wed, 8 Jan 2020 23:44:35 +0000 (15:44 -0800)]
[cfi][test] cross-dso/stats.cpp: don't assume the order of static constructors
__sanitizer_stat_init is called for the executable first, then the
shared object. In WriterModuleReport(), the information for the shared
object will be recorded first. It'd be nice to get rid of the order
requirement of static constructors. (This should make .ctors platforms
work.)
Ahmed Taei [Wed, 8 Jan 2020 20:28:11 +0000 (12:28 -0800)]
[MLIR] Don't use SSA names directly for std.view canonicalization test
Reviewers: rriddle, nicolasvasilache
Subscribers: mehdi_amini, jpienaar, burmako, shauheen, antiagainst, arpith-jacob, mgester, lucyrfox, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D72408
Evgenii Stepanov [Wed, 8 Jan 2020 22:33:28 +0000 (14:33 -0800)]
Revert "Merge memtag instructions with adjacent stack slots."
*** Bad machine code: Tied use must be a register ***
- function: stg_alloca17
- basic block: %bb.0 entry (0x20076710580)
- instruction: early-clobber %0:gpr64common, early-clobber %1:gpr64sp = STGloop 272, %stack.0.a :: (store 272 into %ir.a, align 16)
- operand 3: %stack.0.a
http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/21481/steps/test-check-all/logs/stdio
This reverts commit
b675a7628ce6a21b1e4a71c079a67badfb8b073d.
Adrian Prantl [Wed, 8 Jan 2020 22:31:27 +0000 (14:31 -0800)]
Delete dead code.
https://reviews.llvm.org/D58856
Jonas Devlieghere [Wed, 8 Jan 2020 22:01:57 +0000 (14:01 -0800)]
[lldb/CMake] Only auto-enable Lua when SWIG is found
Just like Python, Lua should only be auto-enabled if SWIG is found as
well. This moves the logic of finding SWIG and Lua as a whole into a new
CMake package.
Kazu Hirata [Wed, 8 Jan 2020 21:58:39 +0000 (13:58 -0800)]
Revert "[JumpThreading] Thread jumps through two basic blocks"
It looks like my patch breaks the sanitizer-windows build:
http://lab.llvm.org:8011/builders/sanitizer-windows/builds/56324
This reverts commit
ead815924e6ebeaf02c31c37ebf7a560b5fdf67b.
Jonas Devlieghere [Wed, 8 Jan 2020 21:34:55 +0000 (13:34 -0800)]
[lldb/SWIG] Refactor extensions to be non Python-specific
The current SWIG extensions for the string conversion operator is Python
specific because it uses the PythonObjects. This means that the code
cannot be reused for other SWIG supported languages such as Lua.
This reimplements the extensions in a more generic way that can be
reused.
Differential revision: https://reviews.llvm.org/D72377