H Hartley Sweeten [Thu, 18 Jun 2015 17:54:54 +0000 (10:54 -0700)]
staging: comedi: adv_pci_dio: rename 'this_board' variables
For aesthetics, rename the 'this_board' variables to 'board'. That name
is more commonly used for the boardinfo pointer in comedi drivers.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
H Hartley Sweeten [Thu, 18 Jun 2015 17:54:53 +0000 (10:54 -0700)]
staging: comedi: cb_pcidas64: rename 'thisboard' variables
For aesthetics, rename the 'thisboard' variables to 'board'. That name
is more commonly used for the boardinfo pointer in comedi drivers.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
H Hartley Sweeten [Thu, 18 Jun 2015 17:54:52 +0000 (10:54 -0700)]
staging: comedi: cb_pcidas: rename 'thisboard' variables
For aesthetics, rename the 'thisboard' variables to 'board'. That name
is more commonly used for the boardinfo pointer in comedi drivers.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
H Hartley Sweeten [Thu, 18 Jun 2015 17:54:51 +0000 (10:54 -0700)]
staging: comedi: me4000: rename 'thisboard' variables
For aesthetics, rename the 'thisboard' variables to 'board'. That name
is more commonly used for the boardinfo pointer in comedi drivers.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
H Hartley Sweeten [Thu, 18 Jun 2015 17:54:50 +0000 (10:54 -0700)]
staging: comedi: das1800: rename 'thisboard' variables
For aesthetics, rename the 'thisboard' variables to 'board'. That name
is more commonly used for the boardinfo pointer in comedi drivers.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
H Hartley Sweeten [Thu, 18 Jun 2015 17:54:49 +0000 (10:54 -0700)]
staging: comedi: das1800: cleanup das1800_probe()
Make this function return a pointer to the boardinfo instead of an index.
Since it's not typical, add a comment to clarify why this legacy driver
does a probe.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
H Hartley Sweeten [Thu, 18 Jun 2015 17:54:48 +0000 (10:54 -0700)]
staging: comedi: das800: rename 'thisboard' variables
For aesthetics, rename the 'thisboard' variables to 'board'. That name
is more commonly used for the boardinfo pointer in comedi drivers.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
H Hartley Sweeten [Thu, 18 Jun 2015 17:54:47 +0000 (10:54 -0700)]
staging: comedi: das800: cleanup das800_probe()
Make this function return a pointer to the boardinfo instead of an index.
Since it's not typical, add a comment to clarify why this legacy driver
does a probe. For aesthetics, rename the local variable 'board' to 'index.
Consolidate the dev_dbg() messages when a probed boardinfo is used and
remove the extra dev_dbg() message when the boardinfo is not found.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
H Hartley Sweeten [Thu, 18 Jun 2015 17:54:46 +0000 (10:54 -0700)]
staging: comedi: das08: rename 'thisboard' variables
For aesthetics, rename the 'thisboard' variables to 'board'. That name
is more commonly used for the boardinfo pointer in comedi drivers.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
H Hartley Sweeten [Thu, 18 Jun 2015 17:54:45 +0000 (10:54 -0700)]
staging: comedi: das08_isa: rename 'thisboard' variables
For aesthetics, rename the 'thisboard' variables to 'board'. That name
is more commonly used for the boardinfo pointer in comedi drivers.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
H Hartley Sweeten [Thu, 18 Jun 2015 17:54:44 +0000 (10:54 -0700)]
staging: comedi: ni_at_a2150: rename 'thisboard' variables
For aesthetics, rename the 'thisboard' variables to 'board'. That name
is more commonly used for the boardinfo pointer in comedi drivers.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
H Hartley Sweeten [Thu, 18 Jun 2015 17:54:43 +0000 (10:54 -0700)]
staging: comedi: ni_at_a2150: cleanup a2150_probe()
Make this function return a pointer to the boardinfo instead of an index.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
H Hartley Sweeten [Thu, 18 Jun 2015 17:54:42 +0000 (10:54 -0700)]
staging: comedi: ni_670x: rename 'thisboard' variables
For aesthetics, rename the 'thisboard' variables to 'board'. That name
is more commonly used for the boardinfo pointer in comedi drivers.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
H Hartley Sweeten [Thu, 18 Jun 2015 17:54:41 +0000 (10:54 -0700)]
staging: comedi: cb_pcidda: rename 'thisboard' variables
For aesthetics, rename the 'thisboard' variables to 'board'. That name
is more commonly used for the boardinfo pointer in comedi drivers.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
H Hartley Sweeten [Thu, 18 Jun 2015 17:54:40 +0000 (10:54 -0700)]
staging: comedi: amplc_pci230: rename 'thisboard' variables
For aesthetics, rename the 'thisboard' variables to 'board'. That name
is more commonly used for the boardinfo pointer in comedi drivers.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
H Hartley Sweeten [Thu, 18 Jun 2015 17:54:39 +0000 (10:54 -0700)]
staging: comedi: amplc_pci224: rename 'thisboard' variables
For aesthetics, rename the 'thisboard' variables to 'board'. That name
is more commonly used for the boardinfo pointer in comedi drivers.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
H Hartley Sweeten [Thu, 18 Jun 2015 17:54:38 +0000 (10:54 -0700)]
staging: comedi: amplc_pc236_common: rename 'thisboard' variables
For aesthetics, rename the 'thisboard' variables to 'board'. That name
is more commonly used for the boardinfo pointer in comedi drivers.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Hari Prasath Gujulan Elango [Thu, 18 Jun 2015 13:27:28 +0000 (13:27 +0000)]
staging: dgnc: free memory allocated
The memory allocated in dgnc_tty_register() for two objects is not freed
anywhere.This patch addresses this by freeing the memory in
dgnc_tty_uninit.
Signed-off-by: Hari Prasath Gujulan Elango <hgujulan@visteon.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Hari Prasath Gujulan Elango [Thu, 18 Jun 2015 13:43:28 +0000 (13:43 +0000)]
staging: dgnc: fix typo in comments secion
This patch fixes a typo in the comments section as warned by
checkpatch.pl
Signed-off-by: Hari Prasath Gujulan Elango <hgujulan@visteon.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Hari Prasath Gujulan Elango [Thu, 18 Jun 2015 06:03:17 +0000 (06:03 +0000)]
staging: wlan-ng: Remove ununsed debug print & associated macro
This patch removed a undefined macro and debug prints associated with
it.
Signed-off-by: Hari Prasath Gujulan Elango <hgujulan@visteon.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Hari Prasath Gujulan Elango [Thu, 18 Jun 2015 11:28:55 +0000 (11:28 +0000)]
staging: lustre: lnet: selftest: use min_t in place of min
This patch silences the checkpatch warning 'min() should
probably be min_t'
Signed-off-by: Hari Prasath Gujulan Elango <hgujulan@visteon.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Peter Karlsson [Thu, 18 Jun 2015 13:51:01 +0000 (15:51 +0200)]
staging: ft1000-usb: Removed CVS keyword marker
Fix checkpatch warnings about CVS keyword marker.
Signed-off-by: Peter Karlsson <peter@zapto.se>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jimmy Devine [Thu, 18 Jun 2015 18:13:21 +0000 (12:13 -0600)]
staging: rtl8188eu: remove space before open square bracket '['
Fixes checkpatch error regarding the space before open square bracket '['
Signed-off-by: Jimmy Devine <fxmulder@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Greg Donald [Thu, 18 Jun 2015 20:06:56 +0000 (15:06 -0500)]
drivers: staging: sm750fb: Fix "'foo * bar' should be 'foo *bar'" errors
Fix checkpatch.pl "'foo * bar' should be 'foo *bar'" errors
Signed-off-by: Greg Donald <gdonald@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Hari Prasath Gujulan Elango [Thu, 18 Jun 2015 12:56:54 +0000 (12:56 +0000)]
staging: sm750fb: convert pr_err to pr_info
This patch modifies few debug prints from pr_err() to pr_info() as they
fall under that category.
Signed-off-by: Hari Prasath Gujulan Elango <hgujulan@visteon.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaehyun Lim [Fri, 19 Jun 2015 00:06:28 +0000 (09:06 +0900)]
staging: wilc1000: fix checkpatch warning
Fix warning founded by checkpatch.pl.
WARNING: __func__ should be used instead of gcc specific __FUNCTION__
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaehyun Lim [Thu, 18 Jun 2015 13:08:51 +0000 (22:08 +0900)]
staging: wilc1000: remove unnecessary typecast in #define macro
Remove unnecessary typecast in #define macro.
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaehyun Lim [Thu, 18 Jun 2015 13:08:50 +0000 (22:08 +0900)]
staging: wilc1000: align #define macro
Align #define macro.
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Abdul Hussain [Thu, 18 Jun 2015 12:37:00 +0000 (12:37 +0000)]
Staging: wilc1000: NULL check before some freeing functions is not needed
This patch removes check before freeing the memory
since kfree(NULL) is safe
Signed-off-by: Abdul Hussain <habdul@visteon.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaehyun Lim [Thu, 18 Jun 2015 05:46:05 +0000 (14:46 +0900)]
staging: wilc1000: remove commented code
Remove the commented codes using #if 0.
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sudip Mukherjee [Wed, 17 Jun 2015 11:24:48 +0000 (16:54 +0530)]
staging: sm7xxfb: fix camelcase
Fix the checkpatch warning about CamelCase.
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sudip Mukherjee [Wed, 17 Jun 2015 11:24:47 +0000 (16:54 +0530)]
staging: sm7xxfb: fix indention
Fix the odd indention of vesa_mode_table.
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sudip Mukherjee [Wed, 17 Jun 2015 11:24:46 +0000 (16:54 +0530)]
staging: sm7xxfb: move mode table
move vgamode table from the header file to the C file and mark it
as const.
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sudip Mukherjee [Wed, 17 Jun 2015 11:24:45 +0000 (16:54 +0530)]
staging: sm7xxfb: reduce indention
reduce code indention keeping the logic same.
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sudip Mukherjee [Wed, 17 Jun 2015 11:24:44 +0000 (16:54 +0530)]
staging: sm7xxfb: fix alignment
Fix the alignment.
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sudip Mukherjee [Wed, 17 Jun 2015 11:24:43 +0000 (16:54 +0530)]
staging: sm7xxfb: no space after cast
fixes the checkpatch warning about using space after typecast.
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sudip Mukherjee [Wed, 17 Jun 2015 11:24:42 +0000 (16:54 +0530)]
staging: sm7xxfb: add newline
new line was missing in some of the dev_* macros while printing
the debug and error messages.
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sudip Mukherjee [Wed, 17 Jun 2015 11:24:41 +0000 (16:54 +0530)]
staging: sm7xxfb: remove numvgamodes
numvgamodes was only used in one place, so remove the #define
and use its defined value.
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sudip Mukherjee [Wed, 17 Jun 2015 11:24:40 +0000 (16:54 +0530)]
staging: sm7xxfb: declare struct as const
The vesa_mode_table is not to be modified, so declare it as const.
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Geert Uytterhoeven [Wed, 17 Jun 2015 08:38:55 +0000 (10:38 +0200)]
staging: board: armadillo800eva: Board staging for sh_mobile_lcdc_fb
Add staging board support for the r8a7740-based armadillo800eva board
and add platform devices to allow in-tree continuous development of the
drivers on the armadillo800eva board.
When DT bindings are ready for theses drivers then the platform devices
in the armadillo800eva staging board code can easily be removed. Until
then we use platform devices to continuously improve the driver and
integrate code.
Added platform devices:
- sh_mobile_lcdc_fb for the on-board LCD.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Acked-by: Simon Horman <horms+renesas@verge.net.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Geert Uytterhoeven [Wed, 17 Jun 2015 08:38:54 +0000 (10:38 +0200)]
staging: board: Add support for devices with complex dependencies
Add support for easy registering of one ore more platform devices that
may:
- need clocks that are described in DT,
- be part of a PM Domain.
All these dependencies are optional.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Acked-by: Simon Horman <horms+renesas@verge.net.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Geert Uytterhoeven [Wed, 17 Jun 2015 08:38:53 +0000 (10:38 +0200)]
staging: board: kzm9d: Translate hwirq numbers to virq numbers
As of commit
9a1091ef0017c40a ("irqchip: gic: Support hierarchy irq
domain."), GIC IRQ numbers are virtual, breaking hardcoded hardware IRQ
numbers in platform device resources.
Translate the hardware IRQ numbers to virtual IRQ numbers to fix this.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Acked-by: Simon Horman <horms+renesas@verge.net.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Geert Uytterhoeven [Wed, 17 Jun 2015 08:38:52 +0000 (10:38 +0200)]
staging: board: Add support for translating hwirq to virq numbers
As of commit
9a1091ef0017c40a ("irqchip: gic: Support hierarchy irq
domain."), GIC IRQ numbers are virtual, breaking hardcoded hardware IRQ
numbers in platform device resources.
Add support for translating hardware IRQ numbers to virtual IRQ numbers,
and fixing up platform device resources with hardcoded IRQ numbers.
Add a copyright header, including the original author.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Acked-by: Simon Horman <horms+renesas@verge.net.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Geert Uytterhoeven [Wed, 17 Jun 2015 08:38:51 +0000 (10:38 +0200)]
staging: board: Initialize staging board code earlier
Currently the staging board code is initialized from a late_initcall().
However, unused PM domains are also disabled from a late_initcall(),
which happens before due to link order.
Change the initialization of staging board code from using
late_initcall() to device_initcall() to fix this.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Acked-by: Simon Horman <horms+renesas@verge.net.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Geert Uytterhoeven [Wed, 17 Jun 2015 08:38:50 +0000 (10:38 +0200)]
Revert "staging: board: disable as it breaks the build"
This reverts commit
d13778d537a0ed6115d2a79a942af999cfb8eec6.
Commit
13c11072536f2613 ("staging:board: remove unnecessary function")
fixed the build of drivers/staging/board/board.c.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
Acked-by: Simon Horman <horms+renesas@verge.net.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Abdul Hussain [Tue, 16 Jun 2015 07:18:08 +0000 (07:18 +0000)]
Staging: lusture: Remove an open coded simple_open() function
This patch removes an open coded simple_open() function and replace file
operations references to the function with simple_open() instead
Signed-off-by: Abdul Hussain <habdul@visteon.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Niranjan Dighe [Tue, 16 Jun 2015 05:05:47 +0000 (05:05 +0000)]
Staging: sm750fb: correct spacing between lines of code
This patch corrects line spacing by removing and adding newline
characters wherever necessary
Signed-off-by: Niranjan Dighe <ndighe@visteon.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Niranjan Dighe [Tue, 16 Jun 2015 05:04:01 +0000 (05:04 +0000)]
Staging: sm750fb: replace spaces by tabs
This patch replaces spaces by tabs at the start of the line and in
between variable declarations.
Signed-off-by: Niranjan Dighe <ndighe@visteon.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Gnanachandran Dhanapal [Tue, 16 Jun 2015 07:25:48 +0000 (07:25 +0000)]
Staging: rtl8192e: Timer setup using macro rather assignment
This patch shall replaces user defined timer setup function with
standard timer setup macro. Also removes init_timer, because timer can
be initialized in setup_timer macro as well.
Signed-off-by: Gnanachandran Dhanapal <gdhanapa@visteon.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mateusz Kulikowski [Mon, 15 Jun 2015 19:06:10 +0000 (21:06 +0200)]
staging: rtl8192e: Remove rtllib_device::agregation
Variable is always true; Resolve condition where it is used
(and change indentation of conditional expression).
Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mateusz Kulikowski [Mon, 15 Jun 2015 19:06:09 +0000 (21:06 +0200)]
staging: rtl8192e: Remove softmac_hint11d_wq queue
This queue is never used, and function handler is empty
Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mateusz Kulikowski [Mon, 15 Jun 2015 19:06:08 +0000 (21:06 +0200)]
staging: rtl8192e: Remove unused rtllib_device members
Delete several members of rtllib_device including
their initializers if needed.
Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mateusz Kulikowski [Mon, 15 Jun 2015 19:06:07 +0000 (21:06 +0200)]
staging: rtl8192e: Remove rt_pwr_save_ctrl members
Following members were removed:
- tmpJoinAction
- tmpSuppRateBuf
- bTmpIbpm
As a consequence several unused defines/enums/structs were
also removed from rtllib.h
Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mateusz Kulikowski [Mon, 15 Jun 2015 19:06:06 +0000 (21:06 +0200)]
staging: rtl8192e: Remove rtllib_network::last_associate
Variable was initialized and never used.
Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mateusz Kulikowski [Mon, 15 Jun 2015 19:06:05 +0000 (21:06 +0200)]
staging: rtl8192e: Remove WIRELESS_EXT checks
Current WIRELESS_EXT version is at least 22.
Resolve ifdefs and delete dead code.
Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mateusz Kulikowski [Mon, 15 Jun 2015 19:06:04 +0000 (21:06 +0200)]
staging: rtl8192e: Remove rtllib_device::get_nic_desc_num()
This function/callback was initialized and never called.
rtl8192_get_nic_desc_num() function that was default
implementation was also removed.
Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mateusz Kulikowski [Mon, 15 Jun 2015 19:06:03 +0000 (21:06 +0200)]
staging: rtl8192e: Remove rtllib_wx_get_encode_ext()
This function was declared but never unused.
Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mateusz Kulikowski [Mon, 15 Jun 2015 19:06:02 +0000 (21:06 +0200)]
staging: rtl8192e: Remove rtllib_is_shortslot()
This function was declared but never unused.
Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mateusz Kulikowski [Mon, 15 Jun 2015 19:06:01 +0000 (21:06 +0200)]
staging: rtl8192e: Remove rtllib_wake_queue()
This function was declared but never unused.
Also remove dequeue_mgmt() and rtllib_resume_tx() that are
no longer used.
Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mateusz Kulikowski [Mon, 15 Jun 2015 19:06:00 +0000 (21:06 +0200)]
staging: rtl8192e: Remove rtllib_stop_queue()
This function was declared but never unused.
Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mateusz Kulikowski [Mon, 15 Jun 2015 19:05:59 +0000 (21:05 +0200)]
staging: rtl8192e: Remove ENABLE_LOCK_DEBUG reference
ENABLE_LOCK_DEBUG macro was never set, so condition that used
it can be resolved manually.
Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mateusz Kulikowski [Mon, 15 Jun 2015 19:05:58 +0000 (21:05 +0200)]
staging: rtl8192e: Remove rt_hi_throughput::ChnkOp
Field was initialized and never used.
This patch also removes chnl_op enum that was only
referenced by ChnkOp init code.
Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mateusz Kulikowski [Mon, 15 Jun 2015 19:05:57 +0000 (21:05 +0200)]
staging: rtl8192e: Remove unused code in rtllib.h
Delete macros, structure members and declarations etc. that are not
referenced anywhere in code.
Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mateusz Kulikowski [Mon, 15 Jun 2015 19:05:56 +0000 (21:05 +0200)]
staging: rtl8192e: Remove unused code in rtl819x_HT.h
Delete unused enums, structures and macros.
Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Gaston Gonzalez [Sun, 14 Jun 2015 22:59:34 +0000 (19:59 -0300)]
staging: rtl8192u: ieee80211: Fix incorrect type in assignment
Added le16_to_cpu() conversion fixing the following warning in assignment detected by sparse:
drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c:2157:30: warning: invalid assignment: +=
drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c:2157:30: left side has type unsigned long
drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c:2157:30: right side has type restricted __le16
Signed-off-by: Gaston Gonzalez <gascoar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Prasanna Karthik [Tue, 16 Jun 2015 13:42:02 +0000 (13:42 +0000)]
staging:lustre:mdc: Fix return statement reported by coccinelle
Modified return statement and removed local declaration no longer
needed. No Compiler warnings.
Signed-off-by: Prasanna Karthik <mkarthi3@visteon.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Maxime Lorrillere [Tue, 16 Jun 2015 09:35:28 +0000 (11:35 +0200)]
staging:lustre fix lines starting with spaces in libcfs/hash.c
This patch fixes lines starting with spaces.
Signed-off-by: Maxime Lorrillere <maxime.lorrillere@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Abdul Hussain [Tue, 16 Jun 2015 07:05:17 +0000 (07:05 +0000)]
Staging: lustre: Use memdup_user rather than duplicating its implementation
This patch uses memdup_user rather than duplicating its implementation
Signed-off-by: Abdul Hussain <habdul@visteon.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Abdul Hussain [Tue, 16 Jun 2015 07:04:51 +0000 (07:04 +0000)]
Staging: lustre: Use memdup_user rather than duplicating its implementation
This patch uses memdup_user rather than duplicating its implementation
Signed-off-by: Abdul Hussain <habdul@visteon.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Hari Prasath Gujulan Elango [Tue, 16 Jun 2015 13:43:50 +0000 (13:43 +0000)]
staging: comedi: amplc_pci230: rename 'todo' variable
This patch renames the very generic variable name 'todo' to
nsamples.
Signed-off-by: Hari Prasath Gujulan Elango <hgujulan@visteon.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Hari Prasath Gujulan Elango [Tue, 16 Jun 2015 14:15:46 +0000 (14:15 +0000)]
staging: comedi: use BIT macro for bit shift operation
This patch silences the Checkpatch.pl warning 'Prefer using the
BIT macro'
Signed-off-by: Hari Prasath Gujulan Elango <hgujulan@visteon.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Peng Fan [Tue, 16 Jun 2015 15:13:21 +0000 (23:13 +0800)]
staging: nvec: remove duplicated const
Sparse checking warning:
"drivers/staging/nvec/nvec_ps2.c:172:14: warning: duplicate const".
Remove the duplicated const to fix the warning.
Signed-off-by: Peng Fan <van.freenix@gmail.com>
Acked-by: Marc Dietrich <marvin24@gmx.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Hari Prasath Gujulan Elango [Wed, 17 Jun 2015 07:26:59 +0000 (07:26 +0000)]
staging: slicoss: remove unused macro
This patch removes a couple of ununsed MACRO's in this header file
Signed-off-by: Hari Prasath Gujulan Elango <hgujulan@visteon.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Tue, 16 Jun 2015 22:43:12 +0000 (23:43 +0100)]
staging: vt6655: use module_pci_driver helper
Remove vt6655_init_module and vt6655_cleanup_module and replace
module_pci_driver
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Tue, 16 Jun 2015 22:43:11 +0000 (23:43 +0100)]
staging: vt6655: remove suspend struct notifier_block.
The only thing this does is vt6655_suspend which is already been called
upon suspend.
Remove function device_notify_reboot and structure device_notifier.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Abdul Hussain [Tue, 16 Jun 2015 05:43:16 +0000 (05:43 +0000)]
staging: vt6656: Boolean tests don't need comparisons.
This patch remove true and false from boolean tests.
Signed-off-by: Abdul Hussain <habdul@visteon.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Prasanna Karthik [Wed, 17 Jun 2015 12:50:14 +0000 (12:50 +0000)]
staging:rtl8723au: Fix return statement reported by coccinelle
Modified return statement and removed local declaration no longer
needed. No Compiler warnings.
Signed-off-by: Prasanna Karthik <mkarthi3@visteon.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Daniele Alessandrelli [Mon, 15 Jun 2015 18:44:21 +0000 (20:44 +0200)]
staging: rtl8723au: include/rtl8723a_hal.h: use __leXX types in fw header struct
This patch makes fields in struct rt_8723a_firmware_hdr use
endianness-aware types (__leXX), thus fixing the following sparse warnings:
CHECK drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c
drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:263:37: warning: cast to
restricted __le16
drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:265:39: warning: cast to
restricted __le16
drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:277:13: warning: cast to
restricted __le16
drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:277:13: warning: cast to
restricted __le16
drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:277:13: warning: cast to
restricted __le16
Signed-off-by: Daniele Alessandrelli <daniele.alessandrelli@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Daniele Alessandrelli [Mon, 15 Jun 2015 18:44:20 +0000 (20:44 +0200)]
staging: rtl8723au: include/rtl8723a_hal.h: fix Rsvd1 size in fw header struct
The size of field Rsvd1 in struct rt_8723a_firmware_hdr should be u8
otherwise we exceeds the boundaries of "LONG WORD 0". This patch fixes
the issue.
Signed-off-by: Daniele Alessandrelli <daniele.alessandrelli@gmail.com>
Acked-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Andreas Ruprecht [Mon, 15 Jun 2015 13:03:00 +0000 (15:03 +0200)]
staging: rtl8723au: core: Remove unneeded #ifdefs
In rtw_mlme_ext.c, nested #ifdef blocks form the following
structure inside the file:
#ifdef CONFIG_8723AU_AP_MODE (line 1323)
[...]
#ifdef CONFIG_8723AU_AP_MODE (line 1720)
[...]
#endif
(2 more ifdef blocks with CONFIG_8723AU_AP_MODE follow)
[...]
#endif /* CONFIG_8723AU_AP_MODE */ (line 1763)
The inner #ifdefs are unnecessary as they depend on the
same condition as the outer #ifdef and can thus be removed.
Signed-off-by: Andreas Ruprecht <andreas.ruprecht@fau.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Fabio Falzoi [Sun, 14 Jun 2015 13:48:53 +0000 (15:48 +0200)]
Staging: rts5208: helper function to manage delink states
Use a helper function to manage delink states
Signed-off-by: Fabio Falzoi <fabio.falzoi84@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Fabio Falzoi [Sun, 14 Jun 2015 13:48:52 +0000 (15:48 +0200)]
Staging: rts5208: helper function to manage 1lun and 2lun modes
Use a helper function to manage lun modes when SUPPORT_OCP is defined
Signed-off-by: Fabio Falzoi <fabio.falzoi84@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Fabio Falzoi [Sun, 14 Jun 2015 13:48:51 +0000 (15:48 +0200)]
Staging: rts5208: helper function to manage idle
Use a helper function to manage idle state
Signed-off-by: Fabio Falzoi <fabio.falzoi84@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Fabio Falzoi [Sun, 14 Jun 2015 13:48:50 +0000 (15:48 +0200)]
Staging: rts5208: helper function to manage aspm
Use a helper function to manage aspm mode
Signed-off-by: Fabio Falzoi <fabio.falzoi84@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Fabio Falzoi [Sun, 14 Jun 2015 13:48:49 +0000 (15:48 +0200)]
Staging: rts5208: helper function to manage ss
Use a helper function to manage ss_counter
Signed-off-by: Fabio Falzoi <fabio.falzoi84@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Fabio Falzoi [Sun, 14 Jun 2015 13:48:48 +0000 (15:48 +0200)]
Staging: rts5208: helper function to manage power off
Use a helper function to check if power off is needed.
Signed-off-by: Fabio Falzoi <fabio.falzoi84@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Fabio Falzoi [Sun, 14 Jun 2015 13:48:47 +0000 (15:48 +0200)]
Staging: rts5208: helper function to manage sd erase status
Use a helper function to manage SD erase status when SUPPORT_SD_LOCK is
defined
Signed-off-by: Fabio Falzoi <fabio.falzoi84@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sunghoon Cho [Wed, 17 Jun 2015 05:42:36 +0000 (14:42 +0900)]
staging: wilc1000: add a blank line
This adds a blank line after struct declaration, WILC_WFI_mon_priv.
Signed-off-by: Sunghoon Cho <ywhsbliss@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sunghoon Cho [Wed, 17 Jun 2015 05:42:33 +0000 (14:42 +0900)]
staging: wilc1000: remove unnecessary blank line.
This patch removes blank line which is not necesssary after an open
brace.
Signed-off-by: Sunghoon Cho <ywhsbliss@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sunghoon Cho [Wed, 17 Jun 2015 05:42:32 +0000 (14:42 +0900)]
staging: wilc1000: remove the warnings on the multiple blank lines.
This patch removes the warnings reported by checkpatch.pl regarding on
the multiple blank line uses.
Signed-off-by: Sunghoon Cho <ywhsbliss@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Abdul Hussain [Wed, 17 Jun 2015 04:48:23 +0000 (04:48 +0000)]
Staging: wilc1000: Remove casting the values returned by kmalloc()
This patch removes casting the values returned by memory allocation functions.
Signed-off-by: Abdul Hussain <habdul@visteon.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Peter Karlsson [Wed, 17 Jun 2015 15:32:11 +0000 (17:32 +0200)]
staging: ft1000-usb: Removed global initialization
Fix checkpatch error about initialize globals to 0.
Signed-off-by: Peter Karlsson <peter.p.karlsson@svt.se>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Peter Karlsson [Wed, 17 Jun 2015 15:32:10 +0000 (17:32 +0200)]
staging: ft1000-usb: Removed unnecessary parenthes
Fix checkpatch warning about unnecessary parenthes.
Signed-off-by: Peter Karlsson <peter.p.karlsson@svt.se>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michał Kępień [Tue, 16 Jun 2015 13:21:23 +0000 (15:21 +0200)]
staging: ft1000: ft1000-usb: ft1000_hw.c: fix long lines
Fix checkpatch.pl warnings about lines longer than 80 characters.
Signed-off-by: Michał Kępień <kernel@kempniu.pl>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Hari Prasath Gujulan Elango [Tue, 16 Jun 2015 07:38:02 +0000 (07:38 +0000)]
staging: wilc1000: remove unwanted code
This patch removes SIOCDEVPRIVATE + 1 ioctl. It currently is just a
stub which does some useless printks and returns. In the original code,
if the user passes priv_cmd.total_len == 0 then it will Oops. Also it
leaks memory every time it's called. In the future, we will implement
this functionality using generic API functions
Signed-off-by: Hari Prasath Gujulan Elango <hgujulan@visteon.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Abdul Hussain [Tue, 16 Jun 2015 09:44:06 +0000 (09:44 +0000)]
Staging: wilc1000: Boolean tests don't need comparisons
This patch removes unwanted true and false from boolean tests.
Signed-off-by: Abdul Hussain <habdul@visteon.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Abdul Hussain [Tue, 16 Jun 2015 09:49:49 +0000 (09:49 +0000)]
Staging: wilc1000: Assign proper boolean value
This patch assign proper boolean value to boolean variable.
Signed-off-by: Abdul Hussain <habdul@visteon.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaehyun Lim [Wed, 17 Jun 2015 02:08:09 +0000 (11:08 +0900)]
staging: wilc1000: align defines
Align some defines in linux_wlan_common.h
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Dean Lee [Tue, 16 Jun 2015 06:28:21 +0000 (15:28 +0900)]
staging: wilc1000: rework include wilc_oswrapper.h
rework line '#include "wilc_oswrapper.h"'
it does not used anywhere after change own data type to common data type.
Signed-off-by: Dean Lee <dean.lee@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 16 Jun 2015 13:13:33 +0000 (09:13 -0400)]
staging: unisys: visorchannel_write() fix potential memory corruption
This fixes the memory corruption case, if nbytes is less than offset
and sizeof(struct channel_header)
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>