platform/kernel/linux-starfive.git
6 years agostaging: fsl-mc: use device_type instead of strcmp()
Laurentiu Tudor [Fri, 17 Nov 2017 13:38:34 +0000 (15:38 +0200)]
staging: fsl-mc: use device_type instead of strcmp()

Replace strcmp() based device type checks with the standard device
model type.

Signed-off-by: Laurentiu Tudor <laurentiu.tudor@nxp.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
6 years agostaging: fsl-mc: add support for device type
Laurentiu Tudor [Fri, 17 Nov 2017 13:38:33 +0000 (15:38 +0200)]
staging: fsl-mc: add support for device type

The MC bus has different types of devices and this is supported by
device model. This patch adds initial support for device types
(defines them, adds helpers and sets the device type).

Signed-off-by: Laurentiu Tudor <laurentiu.tudor@nxp.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
6 years agostaging: fsl-mc: remove debug WARN_ONs doubling error checks
Laurentiu Tudor [Fri, 17 Nov 2017 13:38:32 +0000 (15:38 +0200)]
staging: fsl-mc: remove debug WARN_ONs doubling error checks

A lot of error checks are doubled by debug WARN_ONs. Given that the
driver was thoroughly debugged and is in a stable state, it's time to
drop them.

Signed-off-by: Laurentiu Tudor <laurentiu.tudor@nxp.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
6 years agostaging: fsl-mc: remove some superfluous WARN_ONs
Laurentiu Tudor [Fri, 17 Nov 2017 13:38:31 +0000 (15:38 +0200)]
staging: fsl-mc: remove some superfluous WARN_ONs

These WARN_ONs shouldn't trigger unless something went very wrong.
Since the driver is in a stable state let's remove these debug
WARN_ONs.

Signed-off-by: Laurentiu Tudor <laurentiu.tudor@nxp.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
6 years agostaging: fsl-mc/dpio: change to use EXPORT_SYMBOL_GPL()
Laurentiu Tudor [Fri, 17 Nov 2017 13:38:30 +0000 (15:38 +0200)]
staging: fsl-mc/dpio: change to use EXPORT_SYMBOL_GPL()

No need to use EXPORT_SYMBOL() so switch to the GPL variant.

Signed-off-by: Laurentiu Tudor <laurentiu.tudor@nxp.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
6 years agostaging: fsl-mc: consistently use EXPORT_SYMBOL_GPL()
Laurentiu Tudor [Fri, 17 Nov 2017 13:38:29 +0000 (15:38 +0200)]
staging: fsl-mc: consistently use EXPORT_SYMBOL_GPL()

The bus driver is mixing EXPORT_SYMBOL()/EXPORT_SYMBOL_GPL() usage.
Change it to consistently use EXPORT_SYMBOL_GPL().

Signed-off-by: Laurentiu Tudor <laurentiu.tudor@nxp.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
6 years agostaging: fsl-mc/dpio: remove couple of unused functions
Laurentiu Tudor [Fri, 17 Nov 2017 13:38:28 +0000 (15:38 +0200)]
staging: fsl-mc/dpio: remove couple of unused functions

These couple of functions are not yet used so lets remove them
for now and add them back when/if needed.

Signed-off-by: Laurentiu Tudor <laurentiu.tudor@nxp.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
6 years agostaging: fsl-mc/dpio: drop EXPORT_SYMBOL() for a few functions
Laurentiu Tudor [Fri, 17 Nov 2017 13:38:27 +0000 (15:38 +0200)]
staging: fsl-mc/dpio: drop EXPORT_SYMBOL() for a few functions

These functions are only used within this driver so no need for
EXPORT_SYMBOL().

Signed-off-by: Laurentiu Tudor <laurentiu.tudor@nxp.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
6 years agostaging: fsl-mc/dpio: remove incomplete refcount implementation
Laurentiu Tudor [Fri, 17 Nov 2017 13:38:26 +0000 (15:38 +0200)]
staging: fsl-mc/dpio: remove incomplete refcount implementation

There's an unfinished implementation of reference counting for dpaa2_io
structure using atomics. Since it's unused lets remove it for now and,
if needed at a later time, make use of krefs instead of rolling our
own refcounting.

Signed-off-by: Laurentiu Tudor <laurentiu.tudor@nxp.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
6 years agostaging: fsl-mc: drop unused dpcon APIs
Laurentiu Tudor [Fri, 17 Nov 2017 13:38:25 +0000 (15:38 +0200)]
staging: fsl-mc: drop unused dpcon APIs

Couple of API functions are not used so lets drop them together with
the associated structures and defines.

Signed-off-by: Laurentiu Tudor <laurentiu.tudor@nxp.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
6 years agostaging: comedi: usbdux: remove redundant initialization of val
Colin Ian King [Tue, 7 Nov 2017 19:07:24 +0000 (19:07 +0000)]
staging: comedi: usbdux: remove redundant initialization of val

The early initialization of val is redundant as the value is never
read and is updated inside a for-loop. Remove the initialization
and move the declaration and initialization to the for-loop scope.
Cleans up clang warning:

drivers/staging/comedi/drivers/usbdux.c:812:15: warning: Value stored
to 'val' during its initialization is never read

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
6 years agostaging: speakup: selection: replace _manual_ swap with swap macro
Gustavo A. R. Silva [Fri, 10 Nov 2017 22:13:03 +0000 (16:13 -0600)]
staging: speakup: selection: replace _manual_ swap with swap macro

Make use of the swap macro instead of _manually_ swapping values
and remove unnecessary variable tmp.

This makes the code easier to read and maintain.

This code was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Acked-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
6 years agostaging: rtlwifi: rtlwifi: use ktime_get_real_seconds() for suspend time
Arnd Bergmann [Tue, 7 Nov 2017 10:43:34 +0000 (11:43 +0100)]
staging: rtlwifi: rtlwifi: use ktime_get_real_seconds() for suspend time

do_gettimeofday() is deprecated and slower than necessary for the purpose
of reading the seconds. This changes rtl_op_suspend/resume to use
ktime_get_real_seconds() instead, which is simpler and avoids confusion
about whether it is y2038-safe or not.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
6 years agostaging: rtlwifi: remove redundant assignments to ul_enc_algo
Colin Ian King [Wed, 8 Nov 2017 13:30:31 +0000 (13:30 +0000)]
staging: rtlwifi: remove redundant assignments to ul_enc_algo

Variable ul_enc_algo is being initialized with a value that is never
read, it is being set again in the following switch statements in
all of the case and default paths. Hence the unitialization is
redundant and can be removed.  Cleans up two clang warnings:

Value stored to 'ul_enc_algo' during its initialization is never read

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
6 years agostaging: dgnc: Fix usleep_range is preferred over udelay
Joshua Abraham [Tue, 7 Nov 2017 18:24:25 +0000 (13:24 -0500)]
staging: dgnc: Fix usleep_range is preferred over udelay

This patch fixes the issue:

CHECK: usleep_range is preferred over udelay; see
Documentation/timers/timers-howto.txt

Signed-off-by: Joshua Abraham <j.abraham1776@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
6 years agostaging: ccree: fix incorrect indentation of break statement
Colin Ian King [Fri, 17 Nov 2017 18:19:08 +0000 (18:19 +0000)]
staging: ccree: fix incorrect indentation of break statement

The break statement is indented one level too many, fix this.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
6 years agostaging: ccree: drop unused macro
Gilad Ben-Yossef [Mon, 13 Nov 2017 14:45:52 +0000 (14:45 +0000)]
staging: ccree: drop unused macro

The CC_REG_NAME macro is unused. Drop it.

Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
6 years agostaging: ccree: use local vars for readability
Gilad Ben-Yossef [Mon, 13 Nov 2017 14:45:51 +0000 (14:45 +0000)]
staging: ccree: use local vars for readability

Refactor cc_map_aead_request() to use local vars for addresses
for better readability of code.

Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
6 years agostaging: ccree: replace msleep with a completion
Gilad Ben-Yossef [Mon, 13 Nov 2017 14:45:50 +0000 (14:45 +0000)]
staging: ccree: replace msleep with a completion

When the driver would try to queue commands to the HW FIFO but ran out of
slots it would use msleep as a delay until the FIFO would clear. This is
messy and not accurate.

Replace the msleep with a proper completion on the event of command
completion which should indicate at least one slot is free.

Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
6 years agostaging: ccree: remove unused field
Gilad Ben-Yossef [Mon, 13 Nov 2017 14:45:49 +0000 (14:45 +0000)]
staging: ccree: remove unused field

Field monitor_null_cycles of struct drvdata was not being used.
Remove it.

Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
6 years agostaging: ccree: remove unneeded wrapper function
Gilad Ben-Yossef [Mon, 13 Nov 2017 14:45:48 +0000 (14:45 +0000)]
staging: ccree: remove unneeded wrapper function

Remove unneeded wrapper function to simplify code.

Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
6 years agostaging: ccree: rename long define for readability
Gilad Ben-Yossef [Mon, 13 Nov 2017 14:45:47 +0000 (14:45 +0000)]
staging: ccree: rename long define for readability

Rename the too long  SSI_MAX_HASH_OPAD_TMP_KEYS_SIZE
to SSI_MAX_OPAD_KEYS_SIZE for better code readability.

Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
6 years agostaging: ccree: rename func for readability
Gilad Ben-Yossef [Mon, 13 Nov 2017 14:45:46 +0000 (14:45 +0000)]
staging: ccree: rename func for readability

Rename the insanely long ssi_ahash_get_larval_digest_sram_addr() func
to cc_larval_digest_addr() for better code readability

Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
6 years agostaging: ccree: refactor code with local vars
Gilad Ben-Yossef [Mon, 13 Nov 2017 14:45:45 +0000 (14:45 +0000)]
staging: ccree: refactor code with local vars

Refactor the queue handling loop using local variables for better
code readability.

Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
6 years agostaging: ccree: remove dead defs and decls
Gilad Ben-Yossef [Mon, 13 Nov 2017 14:45:44 +0000 (14:45 +0000)]
staging: ccree: remove dead defs and decls

Remove no longer definitions of enums and forward declaration of functions
dealing with sysfs interface of the long removed ccree cycle counter.

Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
6 years agostaging: ccree: trim long lines for readability
Gilad Ben-Yossef [Mon, 13 Nov 2017 14:45:43 +0000 (14:45 +0000)]
staging: ccree: trim long lines for readability

The ccree driver did not adhere to the kernel max 80 chars per line limit
making the code hard to follow. Fix this by breaking long lines and
in some cases, moving comments to a separate line from code.

Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
6 years agostaging: ccree: replace macro with inline func
Gilad Ben-Yossef [Mon, 13 Nov 2017 14:45:42 +0000 (14:45 +0000)]
staging: ccree: replace macro with inline func

Replace GET_DMA_BUFFER_TYPE with an inline function
variant with type checking.

Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
6 years agostaging: ccree: Replace CONFIG_PM_RUNTIME with CONFIG_PM
Gilad Ben-Yossef [Mon, 13 Nov 2017 14:45:41 +0000 (14:45 +0000)]
staging: ccree: Replace CONFIG_PM_RUNTIME with CONFIG_PM

After commit b2b49ccbdd54
("PM: Kconfig: Set PM_RUNTIME if PM_SLEEP is selected")
PM_RUNTIME is always set if PM is set, so #ifdef blocks
depending on CONFIG_PM_RUNTIME may now be changed to depend on
CONFIG_PM.

Replace CONFIG_PM_RUNTIME with CONFIG_PM.

Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
6 years agostaging: ccree: fix code indent
Gilad Ben-Yossef [Mon, 13 Nov 2017 14:45:40 +0000 (14:45 +0000)]
staging: ccree: fix code indent

Fix code ident not following the coding style.

Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
6 years agostaging: ccree: constify help string
Gilad Ben-Yossef [Mon, 13 Nov 2017 14:45:39 +0000 (14:45 +0000)]
staging: ccree: constify help string

Make help string static const

Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
6 years agostaging: ccree: document spinlock usage
Gilad Ben-Yossef [Mon, 13 Nov 2017 14:45:38 +0000 (14:45 +0000)]
staging: ccree: document spinlock usage

Document spinlock usage to protect against concurrent
access to HW register which must occur a single
request at a time.

Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
6 years agostaging: ccree: replace open coded loop with for
Gilad Ben-Yossef [Mon, 13 Nov 2017 14:45:37 +0000 (14:45 +0000)]
staging: ccree: replace open coded loop with for

Replace open coded register writing loop with a for.
Further simplify code by using a local var to precompute
the register address for readability.

Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
6 years agostaging: ccree: make mem barrier per request
Gilad Ben-Yossef [Mon, 13 Nov 2017 14:45:36 +0000 (14:45 +0000)]
staging: ccree: make mem barrier per request

The driver was issuing a write memory barrier per each
HW descriptor written but these descriptors are written
in groups and we really only need one per group.

White at it, document memory barrier reason.

Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
6 years agostaging: ccree: remove unneeded cast
Gilad Ben-Yossef [Mon, 13 Nov 2017 14:45:35 +0000 (14:45 +0000)]
staging: ccree: remove unneeded cast

Remove uneeded cast from writel_relaxed parameter.

Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
6 years agostaging: ccree: remove unneeded empty lines
Gilad Ben-Yossef [Mon, 13 Nov 2017 14:45:34 +0000 (14:45 +0000)]
staging: ccree: remove unneeded empty lines

Remove uneeded empty lines that crept in to code.

Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
6 years agostaging: ccree: move logical cont. to 1st line
Gilad Ben-Yossef [Mon, 13 Nov 2017 14:45:33 +0000 (14:45 +0000)]
staging: ccree: move logical cont. to 1st line

Move logical continuations to first line for readability.

Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
6 years agostaging: ccree: remove MIN/MAX macros
Gilad Ben-Yossef [Mon, 13 Nov 2017 14:45:32 +0000 (14:45 +0000)]
staging: ccree: remove MIN/MAX macros

The driver was using open coded MIN/MAX macros to
compute fixed defines. Remove them and use bigger
value always instead.

Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
6 years agostaging: ccree: remove unnecessary parentheses
Gilad Ben-Yossef [Mon, 13 Nov 2017 14:45:31 +0000 (14:45 +0000)]
staging: ccree: remove unnecessary parentheses

Remove unnecessary parentheses in if statements across the driver.

Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
6 years agostaging: ccree: alloc by instance not type
Gilad Ben-Yossef [Mon, 13 Nov 2017 14:45:30 +0000 (14:45 +0000)]
staging: ccree: alloc by instance not type

Allocation by instance is preferred to allocation by type.

Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
6 years agostaging: ccree: fix typos
Gilad Ben-Yossef [Mon, 13 Nov 2017 14:45:29 +0000 (14:45 +0000)]
staging: ccree: fix typos

Fix a bunch of comment typos.

Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
6 years agostaging: ccree: remove unused cc_base parameter
Gilad Ben-Yossef [Thu, 9 Nov 2017 09:16:18 +0000 (09:16 +0000)]
staging: ccree: remove unused cc_base parameter

Remove a common parameter named cc_base with the pointer
to the mapped command registers which was used by the
old register access macros that are not longer in use.

Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
6 years agostaging: ccree: remove braces for single statement
Gilad Ben-Yossef [Thu, 9 Nov 2017 09:16:17 +0000 (09:16 +0000)]
staging: ccree: remove braces for single statement

Remove necessary braces for single statement blocks to
improve code readabilty.

Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
6 years agostaging: ccree: remove compare to none zero
Gilad Ben-Yossef [Thu, 9 Nov 2017 09:16:16 +0000 (09:16 +0000)]
staging: ccree: remove compare to none zero

The driver was full of code checking "if (x != 0)".
Replace by "if (x)" for better readability.

Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
6 years agostaging: ccree: remove unneeded cast
Gilad Ben-Yossef [Thu, 9 Nov 2017 09:16:15 +0000 (09:16 +0000)]
staging: ccree: remove unneeded cast

Remove unneeded cast of the return value of dev_get_drvdata()
to struct ssi_drvdata * for better readability.

Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
6 years agostaging: ccree: simplify pm manager using local var
Gilad Ben-Yossef [Thu, 9 Nov 2017 09:16:14 +0000 (09:16 +0000)]
staging: ccree: simplify pm manager using local var

Make the code more readable by using a local variable.

Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
6 years agostaging: ccree: fold common code into function
Gilad Ben-Yossef [Thu, 9 Nov 2017 09:16:13 +0000 (09:16 +0000)]
staging: ccree: fold common code into function

Fold common code copying MAC to/from a temp. buffer
into an inline function instead of keeping multiple
open coded versions of same.

Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
6 years agostaging: ccree: simplify buf mgr using local vars
Gilad Ben-Yossef [Thu, 9 Nov 2017 09:16:12 +0000 (09:16 +0000)]
staging: ccree: simplify buf mgr using local vars

Make the code more readable by using a local variables
for commonly use expressions in the buffer manager part
of the driver.

Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
6 years agostaging: ccree: simplify AEAD using local var
Gilad Ben-Yossef [Thu, 9 Nov 2017 09:16:11 +0000 (09:16 +0000)]
staging: ccree: simplify AEAD using local var

Make the code more readable by using a local variable
for commonly use expression in the AEAD part of the driver.

Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
6 years agostaging: ccree: make long func call sites readable
Gilad Ben-Yossef [Thu, 9 Nov 2017 09:16:10 +0000 (09:16 +0000)]
staging: ccree: make long func call sites readable

The driver was using a function naming scheme
including common prefixes for driver global
functions based on the code module they came from.

The combination of long names with long common
prefixes made the whole thing too long for a human
to parse.

Switch to simple and shorter function naming
scheme. Where required, realign parameters and
add paranthesis for better code readability.

Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
6 years agostaging: lustre: obdclass: simplify cl_lock_fini()
NeilBrown [Mon, 30 Oct 2017 04:59:27 +0000 (15:59 +1100)]
staging: lustre: obdclass: simplify cl_lock_fini()

Using list_first_entry_or_null() makes this (slightly)
simpler.

Signed-off-by: NeilBrown <neilb@suse.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
6 years agostaging: lustre: simplfy lov_finish_set()
NeilBrown [Mon, 30 Oct 2017 04:59:27 +0000 (15:59 +1100)]
staging: lustre: simplfy lov_finish_set()

When deleting everything from a list, a while loop
is cleaner than list_for_each_safe().

Signed-off-by: NeilBrown <neilb@suse.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
6 years agostaging: lustre: ldlm: use list_for_each_entry in ldlm_lock.c
NeilBrown [Mon, 30 Oct 2017 04:59:27 +0000 (15:59 +1100)]
staging: lustre: ldlm: use list_for_each_entry in ldlm_lock.c

This makes some slightly-confusing code a bit clearer, and
avoids the need for 'tmp'.

Signed-off-by: NeilBrown <neilb@suse.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
6 years agostaging: lustre: ldlm: use list_first_entry in ldlm_lock
NeilBrown [Mon, 30 Oct 2017 04:59:27 +0000 (15:59 +1100)]
staging: lustre: ldlm: use list_first_entry in ldlm_lock

This make the code (slightly) more readable.

Signed-off-by: NeilBrown <neilb@suse.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
6 years agostaging: most: usb: fix show/store function names
Christian Gromm [Tue, 21 Nov 2017 14:05:24 +0000 (15:05 +0100)]
staging: most: usb: fix show/store function names

This patch renames the show/store functions of the USB module.
It is needed to make the module meet the established naming
convention.

Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
6 years agostaging: most: add ABI documentation
Christian Gromm [Tue, 21 Nov 2017 14:05:23 +0000 (15:05 +0100)]
staging: most: add ABI documentation

This patchg adds the sysfs-bus-most.txt file to the source tree.
It is needed to have an ABI description of the driver's sysfs
interface.

Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
6 years agostaging: most: core: fix list traversing
Andrey Shvetsov [Tue, 21 Nov 2017 14:05:22 +0000 (15:05 +0100)]
staging: most: core: fix list traversing

This patch fixes the offset and data handling when traversing
the list of devices that are attached to the bus.

Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
6 years agostaging: most: core: remove class generation
Christian Gromm [Tue, 21 Nov 2017 14:05:21 +0000 (15:05 +0100)]
staging: most: core: remove class generation

This patch stops the core from generating a module owned class and
registering it with the kernel. It is needed, because there is no need for
a default MOST class to be present in the kernel.

Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
6 years agostaging: most: cdev: bundle module variables in structure
Christian Gromm [Tue, 21 Nov 2017 14:05:20 +0000 (15:05 +0100)]
staging: most: cdev: bundle module variables in structure

This patch creates the structure comp to put the module variables for
encapsulation purposes. For an improved readability some variables are
renamed.

Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
6 years agostaging: most: cdev: replace function prefix
Christian Gromm [Tue, 21 Nov 2017 14:05:19 +0000 (15:05 +0100)]
staging: most: cdev: replace function prefix

This patch replaces the function prefixes aim_* with comp_*. It is needed
to complete the process of changing the module designator from AIM to
Component.

Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
6 years agostaging: most: update driver usage file
Andrey Shvetsov [Tue, 21 Nov 2017 14:05:18 +0000 (15:05 +0100)]
staging: most: update driver usage file

This patch keeps the usage file up to date.

Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
6 years agostaging: most: core: check value returned by match function
Christian Gromm [Tue, 21 Nov 2017 14:05:17 +0000 (15:05 +0100)]
staging: most: core: check value returned by match function

This patch adds a check for the pointer returned by the function
match_component. It is needed to prevent a NULL pointer dereference in
case the provided component name does not match any list entry.

Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
6 years agostaging: most: core: fix data type
Christian Gromm [Tue, 21 Nov 2017 14:05:16 +0000 (15:05 +0100)]
staging: most: core: fix data type

This patch fixes the type used to manage the channels of an
registered MOST interface.

Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
6 years agostaging: most: usb: clear functional stall on OUT endpoint
Christian Gromm [Tue, 21 Nov 2017 14:05:15 +0000 (15:05 +0100)]
staging: most: usb: clear functional stall on OUT endpoint

For the MOST packet channel there are two dedicated USB endpoints. But
internally the hardware has actually one channel for data forwarding from
and to MOST. To have the hardware clean up its state machine correctly in
case of an error, both USB pipes need to be reset.  This patch triggers the
host to also clear the OUT endpoint's halt condition in case an IN endpoint
has signaled to be stalled.

Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
6 years agostaging: most: core: fix formatting
Christian Gromm [Tue, 21 Nov 2017 14:05:14 +0000 (15:05 +0100)]
staging: most: core: fix formatting

This patch fixes coding style violations.

Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
6 years agostaging: most: core: denote modules as components
Christian Gromm [Tue, 21 Nov 2017 14:05:13 +0000 (15:05 +0100)]
staging: most: core: denote modules as components

Substrings containing 'module' are replaced with 'component' by this patch.
It is needed to complete the process of changing the module designator from
AIM to Component.

Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
6 years agostaging: most: fix comment sections
Christian Gromm [Tue, 21 Nov 2017 14:05:12 +0000 (15:05 +0100)]
staging: most: fix comment sections

This patch updates and corrects the comment sections of the code.

Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
6 years agostaging: most: cdev: rename variable cdev_aim
Christian Gromm [Tue, 21 Nov 2017 14:05:11 +0000 (15:05 +0100)]
staging: most: cdev: rename variable cdev_aim

This patch renames the variable cdev_aim to cdev_comp. It is needed to
complete the process of changing the module designator from AIM to
Component.

Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
6 years agostaging: most: cdev: rename class instance aim_class
Christian Gromm [Tue, 21 Nov 2017 14:05:10 +0000 (15:05 +0100)]
staging: most: cdev: rename class instance aim_class

This patch renames the instance  aim_class of struct class to comp_class.
It is needed to complete the process of changing the module designator from
AIM to Component.

Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
6 years agostaging: most: cdev: rename variable aim_devno
Christian Gromm [Tue, 21 Nov 2017 14:05:09 +0000 (15:05 +0100)]
staging: most: cdev: rename variable aim_devno

This patch renames the variable aim_devno to comp_devno. It is needed
to complete the process of changing the module designator from AIM to
Component.

Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
6 years agostaging: most: cdev: rename struct aim_channel
Christian Gromm [Tue, 21 Nov 2017 14:05:08 +0000 (15:05 +0100)]
staging: most: cdev: rename struct aim_channel

This patch renames the structure aim_channel to comp_channel. It is needed
to complete the process of changing the module designator from AIM to
Component.

Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
6 years agostaging: most: video: remove aim designators
Christian Gromm [Tue, 21 Nov 2017 14:05:07 +0000 (15:05 +0100)]
staging: most: video: remove aim designators

This patch takes the 'aim' prefixes and variable names off the module and
uses component instead. It is needed because userspace interfacing modules
are referred to as components.

Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
6 years agostaging: most: sound: remove aim designator
Christian Gromm [Tue, 21 Nov 2017 14:05:06 +0000 (15:05 +0100)]
staging: most: sound: remove aim designator

This patch removes all 'aim' designators and replaces them with 'comp'.  It
is needd because userspace interfacing modules are referred to as
components.

Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
6 years agostaging: most: net: remove aim designators
Christian Gromm [Tue, 21 Nov 2017 14:05:05 +0000 (15:05 +0100)]
staging: most: net: remove aim designators

This patch renames the all aim designators with comp. It is needed because
userspace interfacing modules are referred to as components.

Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
6 years agostaging: most: core: rename function link_channel_to_aim
Christian Gromm [Tue, 21 Nov 2017 14:05:04 +0000 (15:05 +0100)]
staging: most: core: rename function link_channel_to_aim

This patch renames the function link_channel_to_aim to
link_channel_to_component. It is needed because userspace
interfacing modules are referred to as components.

Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
6 years agostaging: most: core: rename aim variables
Christian Gromm [Tue, 21 Nov 2017 14:05:03 +0000 (15:05 +0100)]
staging: most: core: rename aim variables

This patch replaces the 'aim' substrings of variable names with 'comp'.
It is needed because of the renaming of AIM modules to components.

Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
6 years agostaging: most: core: rename mod_list
Christian Gromm [Tue, 21 Nov 2017 14:05:02 +0000 (15:05 +0100)]
staging: most: core: rename mod_list

This patch renames the variable mod_list to comp_list.  It is needed
because modules that interface userspace are referred to as components.

Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
6 years agostaging: most: rename functions to register a driver with most_core
Christian Gromm [Tue, 21 Nov 2017 14:05:01 +0000 (15:05 +0100)]
staging: most: rename functions to register a driver with most_core

This patch renames the functions to register and deregister a component
module with the core. It is needed because the modules that interface the
userspace are referred to as components.

Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
6 years agostaging: most: rename struct most_aim
Christian Gromm [Tue, 21 Nov 2017 14:05:00 +0000 (15:05 +0100)]
staging: most: rename struct most_aim

The designator of a module that proivdes means to interface userspace is
called an AIM. Since this name seems to be unappropiate, this kind of
moduels are going to be referred to as componetns. This is done because
such modules function as components to enhance the core with new features.
This patch renames the struct most_aim to core_component.

Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
6 years agostaging: most: usb: remove pointer initialization
Christian Gromm [Tue, 21 Nov 2017 14:04:59 +0000 (15:04 +0100)]
staging: most: usb: remove pointer initialization

This patch removes the initialization of the priv pointer of the
most_interface structure.

Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
6 years agostaging: most: core: remove context pointer
Christian Gromm [Tue, 21 Nov 2017 14:04:58 +0000 (15:04 +0100)]
staging: most: core: remove context pointer

This patch removes the unused context pointer that was meant to provide the
opportunity to store context information.

Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
6 years agostaging: most: core: put channel name in struct most_channel
Christian Gromm [Tue, 21 Nov 2017 14:04:57 +0000 (15:04 +0100)]
staging: most: core: put channel name in struct most_channel

This patch stores a channel's name inside the most_channel structure. It
is needed to have the channel attributes tied together.

Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
6 years agostaging: most: core: replace struct most_inst_obj
Christian Gromm [Tue, 21 Nov 2017 14:04:56 +0000 (15:04 +0100)]
staging: most: core: replace struct most_inst_obj

This patch introduces struct interface_private as a replacement for
the struct most_inst_obj. This structure holds private data that is
only needed by the core module and will be accessed by a pointer from
within the most_interface structure. As a result of this replacement
the bus helper functions can be used to search for devices.

Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
6 years agostaging: most: core: rename function
Christian Gromm [Tue, 21 Nov 2017 14:04:55 +0000 (15:04 +0100)]
staging: most: core: rename function

The core module used to have two functions to find a certain
channel. One by name and one by interface. Since no channel is
searched by its interface name anymore the by_name suffix is
rendered redundant. This patch renames the function accordingly.

Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
6 years agostaging: most: core: remove struct device
Christian Gromm [Tue, 21 Nov 2017 14:04:54 +0000 (15:04 +0100)]
staging: most: core: remove struct device

This patch takes out the struct device of struct most_aim, because it is
not needed.

Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
6 years agostaging: most: core: fix sysfs attribute management
Christian Gromm [Tue, 21 Nov 2017 14:04:53 +0000 (15:04 +0100)]
staging: most: core: fix sysfs attribute management

This patch creates a new attribute group to manage the attributes
of a registered aim module in sysfs and changes the show and store
functions accordingly.

Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
6 years agostaging: most: core: track aim modules with linked list
Christian Gromm [Tue, 21 Nov 2017 14:04:52 +0000 (15:04 +0100)]
staging: most: core: track aim modules with linked list

The core needs to know what modules are registered. This patch makes the
core keep track of the registered modules.

Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
6 years agostaging: most: core: use structure to pack driver specific data
Christian Gromm [Tue, 21 Nov 2017 14:04:51 +0000 (15:04 +0100)]
staging: most: core: use structure to pack driver specific data

This patch introduces the structure "mostcore" to bundle core specific
data structures.

Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
6 years agostaging: most: core: rename members aim* of struct most_channel
Christian Gromm [Tue, 21 Nov 2017 14:04:50 +0000 (15:04 +0100)]
staging: most: core: rename members aim* of struct most_channel

This patch renames the struct members "aim0" and "aim0" to "pipe0" and
"pipe1".  It is needed to have a conclusive nomenclature of the struct and
its instances.

Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
6 years agostaging: most: core: rename struct memeber
Christian Gromm [Tue, 21 Nov 2017 14:04:49 +0000 (15:04 +0100)]
staging: most: core: rename struct memeber

This patch renames the member "ptr" of struct pipe to "aim". This is needed
to increase the readability of the code.

Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
6 years agostaging: most: core: rename struct most_c_aim_obj to pipe
Christian Gromm [Tue, 21 Nov 2017 14:04:48 +0000 (15:04 +0100)]
staging: most: core: rename struct most_c_aim_obj to pipe

This patch replaces the confusing name of struct "most_c_aim_obj" with
"pipe" to better express the function that is behind the structure.

Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
6 years agostaging: most: core: rename structure
Christian Gromm [Tue, 21 Nov 2017 14:04:47 +0000 (15:04 +0100)]
staging: most: core: rename structure

This patch renames the structure most_c_obj to most_channel. This is needed
to enhance readability.

Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
6 years agostaging: most: core: encapsulate code in function
Christian Gromm [Tue, 21 Nov 2017 14:04:46 +0000 (15:04 +0100)]
staging: most: core: encapsulate code in function

This patch adds the function link_channel_to_aim to increase readability
of the function add_link_store.

Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
6 years agostaging: most: core: add a match function for the bus
Christian Gromm [Tue, 21 Nov 2017 14:04:45 +0000 (15:04 +0100)]
staging: most: core: add a match function for the bus

This patch adds the function most_match. It is needed to accociate
registered devices and drivers with the bus.

Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
6 years agostaging: most: core: remove function get_channel_by_iface
Christian Gromm [Tue, 21 Nov 2017 14:04:44 +0000 (15:04 +0100)]
staging: most: core: remove function get_channel_by_iface

This patch removes the function get_channel_by_iface that walks a list of
all registered interfaces and returns a pointer to a channel when matched.
Instead the private field of the interface structure is used to directly
access the channel via the id. The patch is needed to remove unnecessary
list traversing.

Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
6 years agostaging: most: remove proprietary kobjects
Christian Gromm [Tue, 21 Nov 2017 14:04:43 +0000 (15:04 +0100)]
staging: most: remove proprietary kobjects

This patch removes the proprietary kobjects used by the driver modules and
replaces them with device structs. The patch is needed to have the driver
being integrated into the kernel's device model.

Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
6 years agostaging: most: video: rename module
Christian Gromm [Tue, 21 Nov 2017 14:04:42 +0000 (15:04 +0100)]
staging: most: video: rename module

This patch renames the folder of the video module. It is needed
to clean up the directory layout of the driver.

Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
6 years agostaging: most: usb: rename module
Christian Gromm [Tue, 21 Nov 2017 14:04:41 +0000 (15:04 +0100)]
staging: most: usb: rename module

This patch renames the folder of the usb module. It is needed
to clean up the  directory layout of the driver.

Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
6 years agostaging: most: sound: rename module
Christian Gromm [Tue, 21 Nov 2017 14:04:40 +0000 (15:04 +0100)]
staging: most: sound: rename module

This patch renames the folder of the sound module. It is needed
to clean up the directory layout of the driver.

Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
6 years agostaging: most: net: rename module
Christian Gromm [Tue, 21 Nov 2017 14:04:39 +0000 (15:04 +0100)]
staging: most: net: rename module

This patch renames the folder and the source file of the networking module.
It is needed to clean up the directory layout of the driver.

Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
6 years agostaging: most: dim2: rename module
Christian Gromm [Tue, 21 Nov 2017 14:04:38 +0000 (15:04 +0100)]
staging: most: dim2: rename module

This patch renames the folder and source files of the dim2 module. It is
needed to clear the directory layout of the driver.

Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>