David Shulman [Tue, 22 May 2018 01:09:16 +0000 (18:09 -0700)]
Fix websocket partial message receive test (dotnet/corefx#29826)
This test was originally disabled before we switched from WinHTTP to a managed
implementation on Windows. And any other failure noted on Linux was probably due
to a transient network/environment issue.
I simplified the test to use smaller buffer sizes which might help with any test
environment issues. These updated sizes still meet the requirements of what needs
to be tested. If we find that this test is still failing frequently then we will
switch to a loopback echo websocket server (which we don't have fully implemented yet).
Fixes dotnet/corefx#9296
Commit migrated from https://github.com/dotnet/corefx/commit/
077280bd5b20d158136ea000bb6c4c86ec40ac0c
David Shulman [Tue, 22 May 2018 01:08:01 +0000 (18:08 -0700)]
Fix HttpWebRequest Connection header test (dotnet/corefx#29833)
Change the test to use a loopback server instead of an external server. And make sure to
not use a proxy since it isn't needed anyway. These changes will improve the test reliability.
Fixes dotnet/corefx#19225
Fixes dotnet/corefx#28437
Commit migrated from https://github.com/dotnet/corefx/commit/
6fc873aee0d80622e12aed29d4e6fffd065afcfc
Tarek Mahmoud Sayed [Tue, 22 May 2018 00:58:43 +0000 (17:58 -0700)]
Add Xamrin platform placeholder in S.T.Tasks.Extensions package (dotnet/corefx#29830)
Commit migrated from https://github.com/dotnet/corefx/commit/
19426a761c94bb17eb761e02dee47ba98e76e916
Koundinya Veluri [Mon, 21 May 2018 19:09:03 +0000 (12:09 -0700)]
Fix test for Thread constructor taking stack size (dotnet/corefx#29798)
* Fix test for Thread constructor taking stack size
Leave some pages worth of buffer when allocating stack space. See https://github.com/dotnet/coreclr/issues/17170.
* Fix comment
* Fix comment
Commit migrated from https://github.com/dotnet/corefx/commit/
0c9ecd37fd9c9404205f195bb9ce74cce7d4fd8d
Tanner Gooding [Sun, 20 May 2018 06:17:02 +0000 (23:17 -0700)]
Revert "Enable partially implemented Intel HW intrinsics ISAs - CoreFX part"
This reverts commit dotnet/corefx@
29f0ce5fda8595aecf235f2a5beb03a20390c7c1.
Commit migrated from https://github.com/dotnet/corefx/commit/
502b7973e9705e33f1d8dc3cdedea29a596eb192
Stephen Toub [Mon, 21 May 2018 17:12:13 +0000 (13:12 -0400)]
Fix comment link for the original TryValidateUtf8 src
Commit migrated from https://github.com/dotnet/corefx/commit/
32845d2fbdbceacfbeb08a9452b776d522b5b16f
Matthew Donoughe [Mon, 21 May 2018 16:43:50 +0000 (12:43 -0400)]
Fix FromBase64Transform for oversize buffers
Add the missing length check to the optimization to use the input array instead of creating a new one, which was particularly a problem when in ignore-whitespace mode while being used by CryptoStream in Write mode.
Commit migrated from https://github.com/dotnet/corefx/commit/
ba9b702d10dae9ac9360f8ae7b4f7dcda01f0f73
David Shulman [Mon, 21 May 2018 16:38:29 +0000 (09:38 -0700)]
Fix WebSocket.Client tests on UAP (dotnet/corefx#29810)
Fixed WinRTWebSocket for the edge case of dealing with 0-byte receive calls.
Made a few adjustments to the tests for UAP test runs.
Fixes dotnet/corefx#28755.
Commit migrated from https://github.com/dotnet/corefx/commit/
3a84f58a3889f1308f8908fcb1e294a5b09a9fbe
Stephen Toub [Mon, 21 May 2018 15:47:50 +0000 (11:47 -0400)]
Revert "Fix Uri.Host for IPv6 Link-local address (dotnet/corefx#29769)" (dotnet/corefx#29818)
This reverts commit dotnet/corefx@
e1ded5ac59d5101a19ea549d19aa9532f2074239.
Commit migrated from https://github.com/dotnet/corefx/commit/
18a84ea61991676673f681ed467e2825d56c9465
Stephen Toub [Mon, 21 May 2018 14:56:23 +0000 (10:56 -0400)]
Remove old bug number comment (dotnet/corefx#29819)
Commit migrated from https://github.com/dotnet/corefx/commit/
01879f12fcbbf40131acec16a29d96d12a6b27c3
David Shulman [Sun, 20 May 2018 13:33:35 +0000 (06:33 -0700)]
Disable Http tests on UAP (dotnet/corefx#29803)
Many dozen of Http tests are failing on UAP test runs. This is not showing up during PR/CI
because the UWP leg only is building the product and test sources and not actually running
any tests. However, the test failures show up in Helix and also when run locally on a dev machine.
So, for now, I'm disabling some of these tests so that the inner and outer test runs will pass.
Contributes to dotnet/corefx#29802
Closes dotnet/corefx#27953
Commit migrated from https://github.com/dotnet/corefx/commit/
3326f3f24dd083f0966c8f71c7d1e8c2caa1ddae
Stephen Toub [Sat, 19 May 2018 23:14:05 +0000 (19:14 -0400)]
Remove unnecessary NoInlining uses (dotnet/corefx#29801)
Commit migrated from https://github.com/dotnet/corefx/commit/
28f6f35d6465486b0b014332d7c3733d5e5f30e0
Tony Di Nucci [Sat, 19 May 2018 19:01:14 +0000 (20:01 +0100)]
Override CopyTo on DeflateStream (dotnet/corefx#29751)
* Override CopyTo on DeflateStream
* Address PR comments
Commit migrated from https://github.com/dotnet/corefx/commit/
3b65271ea8e59b085b6a3e374ab15bb7e8745231
David Shulman [Sat, 19 May 2018 17:01:12 +0000 (10:01 -0700)]
Change EnsureSuccessStatusCode to not dispose response content (dotnet/corefx#29795)
* Change EnsureSuccessStatusCode to not dispose response content
Historically, this method has always disposed the response content if it was
throwing an exception. The reason documented in the comment really doesn't
make much sense, especially to just dispose the content but not the actual
response object. The developer pattern we advise when getting an HttpResponseMessage
is to wrap it in a 'using' statement or use an explicit .Dispose() call. And
disposing the HttpResponseMessage would always dispose the inner .Content
anyways.
The use case of dotnet/corefx#26684 is that the response content should be available regardless
if this method throws an exception or not. Developers normally don't expect an object
to get disposed (partially in this case) as a side-affect of calling a method on the
object. So, we're changing the behavior to be more consistent generally with other
.NET objects.
Fixes dotnet/corefx#26684
* Address PR feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
b0e049cc3db252129a36648780cf78cb0641afbf
Paulo Janotti [Sat, 19 May 2018 04:31:31 +0000 (21:31 -0700)]
Disable serial ports tests on Windows Nano (dotnet/corefx#29793)
Fix dotnet/corefx#29756
Commit migrated from https://github.com/dotnet/corefx/commit/
70959b289ae72f04ad36853cf17c7262fda4ef6b
Jeremy Kuhne [Sat, 19 May 2018 02:09:15 +0000 (19:09 -0700)]
Fix getting attributes for sharing violation files (dotnet/corefx#29790)
* Fix getting attributes for sharing violation files
Some files, such as the pagefile, refuse to allow you to get attributes directly.
You need to enumerate to get the attributes.
Enumerating is expensive, so we had changed from an opt-out to an opt-in. As
it took nearly a year to find this case, switching back to an opt-out with a
larger set of known cases where we get no value from trying again.
Also add an assert to flush out other error codes and scenarios.
* Skip lock test on MacOS (not supported)
* Nano was getting ERROR_NETWORK_UNREACHABLE
Commit migrated from https://github.com/dotnet/corefx/commit/
31cdcaa77ab7d03a5430488e180cd1b47d0ee25e
Marco Rossignoli [Sat, 19 May 2018 00:51:36 +0000 (02:51 +0200)]
Fix Uri.Host for IPv6 Link-local address (dotnet/corefx#29769)
Contributes to dotnet/corefx#28863
This PR address the second part of issue:
Uri.Host LLA (Link-local address) IPv6 address doesn't contain %number part.
Currently it returns [fe80::e077:c9a3:eeba:b8e9], it should return [fe80::e077:c9a3:eeba:b8e9%18].
Note: Uri.IdnHost correctly contains the %number part.
Commit migrated from https://github.com/dotnet/corefx/commit/
e1ded5ac59d5101a19ea549d19aa9532f2074239
David Shulman [Sat, 19 May 2018 00:24:44 +0000 (17:24 -0700)]
Optimize eligible client certificate lookup (dotnet/corefx#29766)
Optimize eligible client certificate lookup
Following up from PR dotnet/corefx#29758, this PR optimizes how we search a collection of certificates
to find an eligible client certificate. This PR moves us away from using the inefficient Find()
API which creates new managed objects for collections and certificates and complicated lifetime
issues for PFX based certificates.
Now, we just do a simple one-time pass over the existing collection and return a certificate
(or null) from that collection.
This change was validated against both System.Net.Http functional tests (which exercise client
certificates) and System.Net.Http.WinHttpHandler unit tests which test all the code paths here
including Client EKU and DigitalSignature OID combinations.
See: https://github.com/dotnet/corefx/blob/master/src/System.Net.Http.WinHttpHandler/tests/UnitTests/ClientCertificateScenarioTest.cs
Commit migrated from https://github.com/dotnet/corefx/commit/
ef3418c6b6e9dd525b273f8e7cb271804b56c678
Paulo Janotti [Sat, 19 May 2018 00:02:19 +0000 (17:02 -0700)]
WMI: make DMTF and DateTime match netfx behavior (dotnet/corefx#29774)
Fixes dotnet/corefx#29712
Commit migrated from https://github.com/dotnet/corefx/commit/
15b13d5a73c48c15731ea0f5fe899bdefe20cf25
Stephen Toub [Fri, 18 May 2018 20:05:24 +0000 (16:05 -0400)]
Merge pull request dotnet/corefx#29789 from stephentoub/nanotests
Disable some tests on Nano server
Commit migrated from https://github.com/dotnet/corefx/commit/
2cf4f1d41f41167a41d1bb77aad266e2f3d38900
Stephen Toub [Fri, 18 May 2018 18:31:07 +0000 (14:31 -0400)]
Disable System.Configuration.ConfigurationManager tests failing on Nano server
Commit migrated from https://github.com/dotnet/corefx/commit/
e5b6fc429ac1b8be5cc55b210136beb9a2f37331
Stephen Toub [Fri, 18 May 2018 18:30:27 +0000 (14:30 -0400)]
Disable and fix System.Diagnostics.Process tests on Nano server
Commit migrated from https://github.com/dotnet/corefx/commit/
c6d212929d3f62b6f9835e7172a47d4e09c1a928
Stephen Toub [Fri, 18 May 2018 18:27:57 +0000 (14:27 -0400)]
Disable System.IO.Ports tests failing on Nano server
Commit migrated from https://github.com/dotnet/corefx/commit/
d8d7bd2e90d104b1fe02a1226e6c0e7d1320608a
Stephen Toub [Fri, 18 May 2018 18:26:27 +0000 (14:26 -0400)]
Disable System.Diagnostics.Tracing tests failing on Nano server
Commit migrated from https://github.com/dotnet/corefx/commit/
57372a005853a95c9865125897a34b8e28c869d3
Stephen Toub [Fri, 18 May 2018 17:51:58 +0000 (13:51 -0400)]
Fix NotSupportedException from WaitHandle.WaitAll in transactions tests (dotnet/corefx#29787)
I hit this exception in a .NET Framework run of the System.Transactions.Local tests:
```
Unhandled Exception of Type System.NotSupportedException
Message :
System.NotSupportedException : WaitAll for multiple handles on a STA thread is not supported.
Stack Trace :
at System.Threading.WaitHandle.WaitMultiple(WaitHandle[] waitHandles, Int32 millisecondsTimeout, Boolean exitContext, Boolean WaitAll)
at System.Threading.WaitHandle.WaitAll(WaitHandle[] waitHandles, Int32 millisecondsTimeout, Boolean exitContext)
at System.Threading.WaitHandle.WaitAll(WaitHandle[] waitHandles, TimeSpan timeout, Boolean exitContext)
at System.Transactions.Tests.LTMEnlistmentTests.EnlistVolatile(Int32 volatileCount, EnlistmentOptions enlistmentOption, Phase1Vote volatilePhase1Vote, Phase1Vote lastPhase1Vote, Boolean commit, EnlistmentOutcome expectedEnlistmentOutcome, TransactionStatus expectedTxStatus)
```
The test is using WaitHandle.WaitAll, which isn't supported on STA threads, and this test must have been executed by xunit on such a thread. I'm fixing it by offloading the wait ot the thread pool.
Commit migrated from https://github.com/dotnet/corefx/commit/
80dd7955724dcfd162a5c89d3afc2ad3943878e6
Stephen Toub [Fri, 18 May 2018 15:59:22 +0000 (11:59 -0400)]
Fix warning about Brotli in uap System.Net.Http build (dotnet/corefx#29775)
Commit migrated from https://github.com/dotnet/corefx/commit/
fdaee74e260ebe3239b3e5c9b80d45ba1f0d650c
Jeremy Kuhne [Thu, 17 May 2018 18:02:08 +0000 (11:02 -0700)]
Test enumerating deleted directories. (dotnet/corefx#29750)
Directories can vanish after we first see them when enumerating. This adds a test that specifically does that behavior.
Commit migrated from https://github.com/dotnet/corefx/commit/
bc0d84559cfe847a820dac7c1f21442385aa9b09
David Shulman [Thu, 17 May 2018 17:46:18 +0000 (10:46 -0700)]
Fix client certificate lifetime handling in tests (dotnet/corefx#29758)
* Fix client certificate lifetime handling in tests
This was a difficult bug to track down. Our use of importing PFX files into the
tests has problems due to a combination of issues. The summary is that these
issues cause the private key (which is written to a temp file on disk) to get
corrupted/deleted. This is why we would get random errors about "invalid client
credentials" when using client certificates in HttpClient (or SslStream).
Thanks to @bartonjs for helping me work thru this.
The lifetime of the temp file containing the private key is associated with the managed
X509Certificate2 object that is created. However, our use of X509Certificate2Collection
followed by the use of the .Find() API in
[GetEligibleClientCertificate](https://github.com/dotnet/corefx/blob/dotnet/corefx@
10aa8277de2521fb1e6a5b42d053ad8cc947be81/src/Common/src/System/Net/Security/CertificateHelper.cs#L55-L59)
causes new managed objects to get created including both a new collection object and
new certificate objects wrapping the existing native PCCERT_CONTEXT of the old managed
certificate object. This causes lifetime issues for the temp file containing the private
key since the old managed objects are GC'd.
In terms of fixing this for the tests, I've optimized the Configuration.Certificates
helper and removed constructs that we don't actually use in our tests. Switching from
using .Import() on the collection object to actually creating the X509Certificate2
object directly helps with managing the lifetime of the certificate.
I will be doing a follow-up PR to optimze GetEligibleClientCertificate() to switch from
using .Find() and instead directly query the certificates in the original collection.
This will result in less managed objects being created as well as avoid additional private
key lifetime issues for certificates imported that use the default X509KeyStorage.DefaultKeySet
flags.
I also fixed a problem with the test which was always failing on NETFX.
Closes dotnet/corefx#9543
* Remove Mutex
Commit migrated from https://github.com/dotnet/corefx/commit/
75ba6cd878b6764e1f400c839271866f7d2a049a
Ben Adams [Thu, 17 May 2018 15:46:40 +0000 (16:46 +0100)]
BufferSegment inline WritableBytes (dotnet/corefx#29719)
Commit migrated from https://github.com/dotnet/corefx/commit/
81b4faa619f604991f0c0374a63aaecd237f5633
Paulo Janotti [Thu, 17 May 2018 13:06:54 +0000 (06:06 -0700)]
Fix performance regression of XmlDocument.Create (dotnet/corefx#29626)
Fixes dotnet/corefx#29260
Commit migrated from https://github.com/dotnet/corefx/commit/
be36a44d23c3841507bce52bb212b45d5a14c014
Stephen Toub [Thu, 17 May 2018 02:11:33 +0000 (22:11 -0400)]
Add more missing overrides to refs (dotnet/corefx#29738)
Ran /t:GenerateReferenceSource and undid irrelevant changes, though I kept a few files where the changes were trivial (e.g. whitespace) and it seemed better to just accept the change to stay in sync with GenerateReferenceSource.
In general I only added missing overrides on non-sealed classes, but when there were already overrides included on sealed classes, I added them back for consistency.
Commit migrated from https://github.com/dotnet/corefx/commit/
10aa8277de2521fb1e6a5b42d053ad8cc947be81
Stephen Toub [Thu, 17 May 2018 01:40:53 +0000 (21:40 -0400)]
Add Brotli support to SocketsHttpHandler (dotnet/corefx#29729)
* Add Brotli support to SocketsHttpHandler
- Add DecompressionMethods.Brotli
- Add support for Brotli to SocketsHttpHandler
- Add some tests
* Address PR feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
91f2cd7e3de0c4eab799e4d946b1d50c4d15d930
Michal Strehovský [Wed, 16 May 2018 23:27:48 +0000 (01:27 +0200)]
Disable FEATURE_DLG_INVOKE and FEATURE_FAST_CREATE on UapAot (dotnet/corefx#29734)
* Disable FEATURE_DLG_INVOKE and FEATURE_FAST_CREATE on UapAot
dotnet/corefx#28792 broke UapAot platform by introducing reflection on private implementation details of the framework. It's not possible to reflect on non-public classes/members of the framework on AoT platfrorms. While this would be fixable by making `FuncCallInstruction` and friends public (same way `ExpressionCreator` is already public), we need measurements first that demonstrate this is an actual runtime performance improvement on UapAot (e.g. reflection invoke on AoT platforms is 4x faster than on the CLR, but on the other hand `MakeGenericType` random types might make us fall back to universal shared code for the new instantiations, which is pretty bad).
I have reasons to believe enabling FEATURE_DLG_INVOKE and FEATURE_FAST_CREATE also causes a pretty significant size on disk regression.
Fixes dotnet/corefx#29652.
* Add link to issue
Commit migrated from https://github.com/dotnet/corefx/commit/
9ab3f57fec3c72fd471c45d2085d40e90640aa3b
Stephen Toub [Wed, 16 May 2018 22:36:49 +0000 (18:36 -0400)]
Remove MonoTODO and MonoLimitation from System.Drawing.Common (dotnet/corefx#29739)
Commit migrated from https://github.com/dotnet/corefx/commit/
165e65f14c1499fdcd86a1e62319e2cf3b5beb41
Tom Deseyn [Wed, 16 May 2018 20:41:31 +0000 (22:41 +0200)]
Fix deadlock when waiting for process exit in Console.CancelKeyPress (dotnet/corefx#29709)
* Fix deadlock when waiting for process exit in Console.CancelKeyPress
This deadlock occurs because the thread invoking CancelKeyPress is
also responsible for detecting process exits. We change to using a
new thread for handling CancelKeyPress.
* Test: replace SemaphoreSlim with ManualResetEventSlim
* Fix comment typo
* PR Feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
779910613e71f7ea062adf43a96829cf9a024af7
Jeremy Barton [Wed, 16 May 2018 20:39:54 +0000 (13:39 -0700)]
Merge pull request dotnet/corefx#29705 from bartonjs/signedcms_negativeserialsigner
Fix SignedCms handling of negative certificate serial numbers.
Commit migrated from https://github.com/dotnet/corefx/commit/
2e46c5bd3f492a178620b26c1d4ce3707728d949
David Shulman [Wed, 16 May 2018 19:18:52 +0000 (12:18 -0700)]
Disable test on NETFX (dotnet/corefx#29743)
This newly added test was always failing in NETFX (Outerloop).
.NET Framework has always had a limitation and cannot resolve DNS names with Unicode since it is p/invoking into the 'A' and not 'W' version of the native APIs. The workaround for developers is to use punnyname for the DNS name.
This is currently being tracked with internal bug 125570.
Commit migrated from https://github.com/dotnet/corefx/commit/
8ab4f2c1b3bddf79ea3d206a0fec8444f0af167a
David Shulman [Wed, 16 May 2018 18:42:46 +0000 (11:42 -0700)]
Update System.Net tests to use newer corefx-testdata PFX files (dotnet/corefx#29724)
Updated PFX files were checked into corefx-testdata repro via
https://github.com/dotnet/corefx-testdata/pull/24. This PR removed
the friendly name attribute from the private key. This fixes the
problem in Windows dealing with parallel PFX import.
This PR updates the System.Net.* tests to use the updated corefx-testdata package.
Closes dotnet/corefx#23341
Contributes to dotnet/corefx#9543
Commit migrated from https://github.com/dotnet/corefx/commit/
84883052ef0f720a8befdc8525db50c9544227d5
Vance Morrison [Wed, 16 May 2018 17:16:56 +0000 (10:16 -0700)]
Merge pull request dotnet/corefx#29720 from vancem/DiagSourceGuidance
Clarify how DiagnosticsSource filtering works
Commit migrated from https://github.com/dotnet/corefx/commit/
8181ba6ea1ae03c402e8e830b92a9982015c8a77
Vance Morrison [Wed, 16 May 2018 17:12:32 +0000 (10:12 -0700)]
review feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
61aa46ca2e72589b9c6ab4117961cc0c5d300946
Maxim Lipnin [Wed, 16 May 2018 12:17:31 +0000 (15:17 +0300)]
Fix outdated comment about where PkcsPal's "s_instance" is declared (dotnet/corefx#29727)
Commit migrated from https://github.com/dotnet/corefx/commit/
d5f6e6a10b9b1a9cb42066ebceea21e929adb487
Marek Safar [Tue, 15 May 2018 19:05:03 +0000 (21:05 +0200)]
Factors out few GC specific tests (dotnet/corefx#29647)
* Factors out few GC specific tests
* Tweaks to address the review
Commit migrated from https://github.com/dotnet/corefx/commit/
ae9c3608e6ecb0389c668e8e6fbc6ee8f6b7ddfa
Vance Morrison [Tue, 15 May 2018 17:59:19 +0000 (10:59 -0700)]
Clarify how filtering works
Commit migrated from https://github.com/dotnet/corefx/commit/
5413862f678513a62d2277876bfe377e990d37ec
Caesar Chen [Tue, 15 May 2018 17:47:07 +0000 (10:47 -0700)]
Fix a test and add a argument check for DiagnosticsHandler (dotnet/corefx#29701)
* fix test and add a check for DiagnosticsHandler
* address feedback
* improve comment
Commit migrated from https://github.com/dotnet/corefx/commit/
cda3d63089ec3e1e4d51d635da444b7319b98440
Levi Broderick [Tue, 15 May 2018 13:15:24 +0000 (06:15 -0700)]
Add unit test to check edge case in Array.Reverse(Array, ...) (dotnet/corefx#29559)
* Fix Array.Reverse tests to match validation checks in corelib
* Revert "Fix Array.Reverse tests to match validation checks in corelib"
Commit migrated from https://github.com/dotnet/corefx/commit/
c75431cd74a92f97d7be15e754b15f76d9bce28c
Jeremy Barton [Mon, 14 May 2018 23:54:02 +0000 (16:54 -0700)]
Fix SignedCms handling of negative certificate serial numbers.
The AsnSerializer normalized ReadOnlyMemory versions of Integer values to
unsigned interpretations on Serialize, but Deserialize read values as-is. So
signing a SignedCms with a negative-valued certificate serial, or creating an
EnvelopedCms with a negative-valued recipient serial changed the
representation of the serial number in the encoded file.
This change fixes the serializer to do a pass-through by adding the missing
"just use these bytes" method to AsnWriter. Then fixes the one place counting
on this behavior, and adds a number of tests to prevent regressions.
Commit migrated from https://github.com/dotnet/corefx/commit/
a6bd17a8ccbebda8b865e17e4c91f20963111dca
Stephen Toub [Mon, 14 May 2018 21:54:29 +0000 (17:54 -0400)]
Add missing Read/Write{Async} overrides on Streams in ref assemblies (dotnet/corefx#29658)
For non-sealed types, not specifying an override in a ref can lead to a derived type skipping the method in the hierarchy when calling to base.Method().
Commit migrated from https://github.com/dotnet/corefx/commit/
33b44346378ba0caebb1ab96ab015e4098868c16
dotnet-maestro-bot [Mon, 14 May 2018 21:20:16 +0000 (16:20 -0500)]
Update CoreClr, CoreSetup to preview1-26514-05, preview1-26514-01, respectively (dotnet/corefx#29692)
Commit migrated from https://github.com/dotnet/corefx/commit/
dd996990012c21ff6f0aaf30e4ba0eb6e7375dcd
Anirudh Agnihotry [Mon, 14 May 2018 19:33:38 +0000 (01:03 +0530)]
Added Filters Property to FileSystemWatcher class (dotnet/corefx#29315)
* Filters Property and tests added
* Tests fixed for osx
* Tests fixed for netfx and error message improved
* Tests fixed for netfx and error message improved
* Added tests for insert,contains ,removeat, index of , to string and gettype
* ToString removed and asser.equal corrected
* Comments and overload of epectevent added for netcoreapp
* Removed duplicate code
* setup and execution separated
* Expected patshs argument added
* ExpectNoEvent Added, negative added for all the test , expected path problem corrected
* handler
* Storing tuple and Unexpected Events
* name added to return values tuples
Commit migrated from https://github.com/dotnet/corefx/commit/
9f2377fcd4e46f2c607d03672ed0bb92fe9cb68e
Hugh Bellamy [Mon, 14 May 2018 18:57:16 +0000 (19:57 +0100)]
Release the HDC when disposing graphics (dotnet/corefx#29630)
Commit migrated from https://github.com/dotnet/corefx/commit/
145ef1ab8e5bf54b6e29e7753b2edff8635ec519
Hugh Bellamy [Mon, 14 May 2018 18:55:55 +0000 (19:55 +0100)]
Consolidate Image code between Unix/Windows (dotnet/corefx#29632)
* Consolidate Image code
* PR feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
3bbe534e51f22aa5475511cfbc26aba93467cfa2
Marco Rossignoli [Mon, 14 May 2018 17:58:24 +0000 (19:58 +0200)]
Move StringTests.cs to Common.Tests (dotnet/corefx#29601)
* move StringTests to common, add ref for S.M.T. S.R.T.
* address PR feedback
* nit: space cleanup
* remove duplicates from S.M.T.
Commit migrated from https://github.com/dotnet/corefx/commit/
1e9b1f278e8638a19e34bae6e40b67784483084c
Eric StJohn [Mon, 14 May 2018 17:54:54 +0000 (10:54 -0700)]
Merge pull request dotnet/corefx#29684 from WonyoungChoi/add_rids_for_tizen
Add missing RIDs for Tizen
Commit migrated from https://github.com/dotnet/corefx/commit/
12a019e0156c4cb715ecf09e295563d62fb41ea1
Hugh Bellamy [Mon, 14 May 2018 17:06:30 +0000 (18:06 +0100)]
Fix Pen test failures with latest libgdiplus (dotnet/corefx#29631)
Commit migrated from https://github.com/dotnet/corefx/commit/
b5b75ee8969f2c67689eafe7b1ba73d0bddda019
Maryam Ariyan [Mon, 14 May 2018 16:35:21 +0000 (09:35 -0700)]
Skipping test on uap-aot because metadata removed for perf reason (dotnet/corefx#29670)
Fixes: dotnet/corefx#29652
Commit migrated from https://github.com/dotnet/corefx/commit/
9034a2a79051d99fb74896089131c107dc61bd62
dotnet-maestro-bot [Mon, 14 May 2018 05:05:37 +0000 (00:05 -0500)]
Update CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to preview1-26514-01, preview1-26514-01, preview1-26513-04, beta-26514-00, beta-26514-00, respectively (dotnet/corefx#29681)
Commit migrated from https://github.com/dotnet/corefx/commit/
ccdb5a48a49d3e932aa00d02749777464f4c8d5b
Wonyoung Choi [Fri, 11 May 2018 06:44:53 +0000 (15:44 +0900)]
Add missing RIDs for Tizen
Commit migrated from https://github.com/dotnet/corefx/commit/
e6abbd366f75062bd828c5f1e26806be26b644d4
Nick Craver [Sun, 13 May 2018 17:15:41 +0000 (13:15 -0400)]
Style C# blocks in Activity user guide for readability (dotnet/corefx#29682)
This styles some generic code blocks as C# to make this far more readable - trivial markdown change to make life a bit easier.
Commit migrated from https://github.com/dotnet/corefx/commit/
cb749a1e158cce702bbb98bcb3e974e43459d179
Santiago Fernandez Madero [Sun, 13 May 2018 13:38:43 +0000 (06:38 -0700)]
Update official runs to use RS4 target queues (dotnet/corefx#29666)
Commit migrated from https://github.com/dotnet/corefx/commit/
cfd24117e523a5da6bebc5c9adba4b726fc0ef09
dotnet-maestro-bot [Sun, 13 May 2018 04:11:12 +0000 (23:11 -0500)]
Update CoreClr, CoreFx, CoreSetup to preview1-26513-01, preview1-26513-01, preview1-26512-04, respectively (dotnet/corefx#29677)
Commit migrated from https://github.com/dotnet/corefx/commit/
ca293c071b88cfc0f0c7d6b43775b0a3982ba3c3
dotnet-maestro-bot [Sat, 12 May 2018 17:59:20 +0000 (12:59 -0500)]
Update CoreClr, CoreFx, CoreSetup to preview1-26512-05, preview1-26512-05, preview1-26512-01, respectively (dotnet/corefx#29672)
Commit migrated from https://github.com/dotnet/corefx/commit/
344c31c7ba9bc171bbab31167acdd279e9f6027c
dotnet-maestro-bot [Sat, 12 May 2018 07:34:58 +0000 (02:34 -0500)]
Update CoreClr, CoreFx to preview1-26512-01, preview1-26512-01, respectively (dotnet/corefx#29671)
Commit migrated from https://github.com/dotnet/corefx/commit/
c3207180abe28433e4a801f38b6b883f2fbe2a68
Max Kerr [Fri, 11 May 2018 23:29:14 +0000 (16:29 -0700)]
Switch recently re-enabled tests to run only on new versions of .NET Framework (dotnet/corefx#29663)
* Switch recently re-enabled tests to run only on new versions of .NET Framework.
* Fix method naming, add support for PlatformDetection.IsNetfx472OrNewer, change check from > 4.7 to > 4.7.1
* Update comment.
Commit migrated from https://github.com/dotnet/corefx/commit/
5310249c2d8939b38c008a2b10f7548e2162ac17
dotnet-maestro-bot [Fri, 11 May 2018 22:45:23 +0000 (17:45 -0500)]
Update BuildTools, CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to preview1-02810-02, preview1-26511-05, preview1-26511-04, preview1-26511-03, beta-26511-00, beta-26511-00, respectively (dotnet/corefx#29646)
Commit migrated from https://github.com/dotnet/corefx/commit/
1b30478fa0857637ea0616933acaecd217fdc51a
Stephen Toub [Fri, 11 May 2018 22:44:55 +0000 (18:44 -0400)]
Disable parallelization of System.Transactions tests (dotnet/corefx#29665)
Commit migrated from https://github.com/dotnet/corefx/commit/
4e065e31c8bc9e1ae52b1f6ac18ea0c2e5764299
Stephen Toub [Fri, 11 May 2018 22:44:31 +0000 (18:44 -0400)]
Fix TaskContinuationOptions => TaskCreationOptions in test (dotnet/corefx#29667)
Commit migrated from https://github.com/dotnet/corefx/commit/
1b5782d29d18f96c20d26e5c8f2844f5d082c887
Stephen Toub [Fri, 11 May 2018 21:39:06 +0000 (17:39 -0400)]
Use shared StringBuilderCache (dotnet/corefx#29657)
Commit migrated from https://github.com/dotnet/corefx/commit/
03df812785e99885efde06a0f88d82578955276e
Stephen Toub [Fri, 11 May 2018 17:32:59 +0000 (13:32 -0400)]
Fix terminfo number reading with 32-bit integers (dotnet/corefx#29655)
Commit migrated from https://github.com/dotnet/corefx/commit/
62bbc0bfef4ff22bc5215349b9db5f5a53f3a580
Santiago Fernandez Madero [Fri, 11 May 2018 16:21:14 +0000 (09:21 -0700)]
Fix compat pack dependencies now that we bumped them to 4.6.0-* for netcoreapp2.2 (dotnet/corefx#29592)
* Fix compat pack dependencies now that we bumped them to 4.6.0-* for netcoreapp2.2
* Use PackageVersion in Packaging.props for PrereleaseLibrary
* Remove unnecessary target override that was already fixed in newest package
Commit migrated from https://github.com/dotnet/corefx/commit/
7f2604e4346d98cbdd3034257e548e04ee6e2ab5
Stephen Toub [Fri, 11 May 2018 02:27:53 +0000 (22:27 -0400)]
Merge pull request dotnet/corefx#29636 from stephentoub/formatmessage
Improvements to FormatMessage
Commit migrated from https://github.com/dotnet/corefx/commit/
48ce3254e28f2dae2d9a5efe7dd42cfab119d287
Eric StJohn [Fri, 11 May 2018 02:13:05 +0000 (19:13 -0700)]
Object model attributes (dotnet/corefx#29639)
* Add ValueSerializerAttribute to System.ObjectModel
* Move TypeConverterAttribute down to System.ObjectModel
This enables types to plug into TypeConverter without taking a dependency on it.
One type in particular which requires this is ICommand in System.ObjectModel.
* Fix ValueSerializerAttribute formatting
Commit migrated from https://github.com/dotnet/corefx/commit/
2db76263e64ab73c8d284060f597816158406810
Afsaneh Rafighi [Fri, 11 May 2018 00:20:27 +0000 (17:20 -0700)]
Merge pull request dotnet/corefx#29614 from AfsanehR/github29391
Fixed GithubIssue dotnet/corefx#29391
Commit migrated from https://github.com/dotnet/corefx/commit/
8e1d7bda3a56c7ec2f937e83a704dc6478477654
Maryam Ariyan [Thu, 10 May 2018 23:41:16 +0000 (16:41 -0700)]
Adding delay to fix assertion on tests. (dotnet/corefx#29638)
Fixes dotnet/corefx#29634
Commit migrated from https://github.com/dotnet/corefx/commit/
76dffd6a6f4e713e51d75402472f38b6cb621c41
David Shulman [Thu, 10 May 2018 21:33:25 +0000 (14:33 -0700)]
Add EventSource tracing to WinHttpHandler (dotnet/corefx#29604)
Add EventSource tracing to WinHttpHandler
Removed the custom OutputDebugString-style tracing from WinHttpHandler and replaced it with
NetEventSource. Didn't define any new event id's but tried to use "Info" vs. "Error"
in more places.
Due to the unique way the WinHttpHandler class gets built into two different binaries,
I needed to add a new EventSource name/GUID for the standalone System.Net.Http.WinHttpHandler.dll
binary. The logging output is similar but will show up in either "Microsoft-System-Net-Http" or
"Microsoft-System-Net-Http-WinHttpHandler" EventSource's depending on which binary is being used,
i.e. whether "new HttpClientHandler()" or "new WinHttpHandler()" was used.
For those curious about how the new GUID for "Microsoft-System-Net-Http-WinHttpHandler" was done, it
was not generated randomly. EventSource GUID's are generated based on the string name for the
EventSource according to a well-defined formula. Doing a construct like this will return back the
information:
```c#
Type esType = typeof(WinHttpHandler).GetTypeInfo().Assembly.GetType("System.Net.NetEventSource", true, false);
Console.WriteLine($"Name={EventSource.GetName(esType)}, Guid={EventSource.GetGuid(esType).ToString()}");
```
Closes dotnet/corefx#7856
Commit migrated from https://github.com/dotnet/corefx/commit/
11222269ae3bc45cd414dcb973f2d92f1bad73f8
Max Kerr [Thu, 10 May 2018 21:29:08 +0000 (14:29 -0700)]
Minor improvements to SocketsHttpHandler redirect logging (dotnet/corefx#29584)
* Minor additions to redirect logging.
* Fix logging of original request method.
* Whitespace
* Update to use the HandlerMessage format.
Commit migrated from https://github.com/dotnet/corefx/commit/
fe3df48064dfe35d19b8ff98dfb4eac4f606eaf2
Chris Rummel [Thu, 10 May 2018 21:01:49 +0000 (16:01 -0500)]
Fix extra space in MSBuild variable that causes BuildingAnOfficialBuildLeg to be set incorrectly. (dotnet/corefx#29641)
Commit migrated from https://github.com/dotnet/corefx/commit/
68fbecc4ce4e0410df92630b09d6238a436aadcf
David Gardiner [Thu, 10 May 2018 20:38:50 +0000 (06:38 +1000)]
Update XML comments to use correct interface name (dotnet/corefx#29627)
Interface is named "IConfigurationSectionHandler", not "IConfigSectionHandler"
(maybe there's some history there, or someone didn't want to type "uration" :-)
Commit migrated from https://github.com/dotnet/corefx/commit/
986fc93181a682954fd768e4e2e8fd9a3eaa0a71
Stephen Toub [Thu, 10 May 2018 19:55:04 +0000 (15:55 -0400)]
Mark Microsoft.Win32.Exception with ILLinkClearInitLocals
Commit migrated from https://github.com/dotnet/corefx/commit/
f872d7420254b4c191fbf25912763a5fbcffa0f0
Stephen Toub [Thu, 10 May 2018 19:53:12 +0000 (15:53 -0400)]
Use FORMAT_MESSAGE_ALLOCATE_BUFFER with FormatMessage
Avoid looping and growing a managed heap buffer when we can instead just ask the native side to allocate one of the right size for us.
Commit migrated from https://github.com/dotnet/corefx/commit/
e118304d264163f03e79965e4f2ab1d5c1a43961
dotnet-maestro-bot [Thu, 10 May 2018 20:08:19 +0000 (15:08 -0500)]
Update BuildTools, CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to preview1-02810-01, preview1-26510-06, preview1-26510-05, preview1-26510-01, beta-26510-00, beta-26510-00, respectively (dotnet/corefx#29628)
Commit migrated from https://github.com/dotnet/corefx/commit/
81bb57084c5a40c71e37a8502a22b9ad64f83492
Maxim Lipnin [Thu, 10 May 2018 20:05:25 +0000 (23:05 +0300)]
Change IsSynchronized and SyncRoot of CryptographicAttributeObjectCollection class from explicitly implementing the interface to implicitly implementing the interface. (dotnet/corefx#29635)
* Change IsSynchronized and SyncRoot of CryptographicAttributeObjectCollection class from explicitly implementing the interface to implicitly implementing the interface.
* Remove redundant call of IsSyncronized because it's always going to return false.
* Remove unnecessary change
Commit migrated from https://github.com/dotnet/corefx/commit/
56b8169b386914c83bd50e4d221ed8f3678f405a
Stephen Toub [Thu, 10 May 2018 14:07:36 +0000 (10:07 -0400)]
Replace shared Interop.FormatMessage.cs with non-shared one
Commit migrated from https://github.com/dotnet/corefx/commit/
f3414d6cc3463b9e243e5d732d7e401c2d037d05
Afsaneh Rafighi [Thu, 10 May 2018 18:42:29 +0000 (11:42 -0700)]
changed Fact to CheckConnStrSetupFact
Commit migrated from https://github.com/dotnet/corefx/commit/
63828972d76fef57c4d276c013aebe582a512597
Afsaneh Rafighi [Thu, 10 May 2018 18:15:16 +0000 (11:15 -0700)]
resolve the exception with CI.
Commit migrated from https://github.com/dotnet/corefx/commit/
76922b95a7134124ac48282b7d14e5afede31e32
stakx [Thu, 10 May 2018 14:50:38 +0000 (16:50 +0200)]
Reflection.Emit: Add test for `ParameterBuilder.SetConstant(null)` (dotnet/corefx#29532)
* Reflection.Emit: Test P'Builder.SetConstant(null)
Verifies that `ParameterBuilder.SetConstant(null)` works for any type,
including non-nullable value types.
* Exclude SetConstant(null) for value types on NETFX
Commit migrated from https://github.com/dotnet/corefx/commit/
5c521c8dd9e46c2da34ead4046000c3c3c4e998f
stakx [Thu, 10 May 2018 14:50:01 +0000 (16:50 +0200)]
Reflection: Add test verifying ParameterInfo.DefaultValue doesn't throw for optional DateTime parameter (dotnet/corefx#29533)
* Reflection: Test DefaultValue for DateTime params
* Exclude DateTime test cases for NETFX
Commit migrated from https://github.com/dotnet/corefx/commit/
156cbfaad66d1dc0a2bb9ef8846de6d6a6007f56
Stephen Toub [Thu, 10 May 2018 10:54:51 +0000 (06:54 -0400)]
Remove StringBuilder marshaling from X509Certificates (dotnet/corefx#29605)
* Remove StringBuilder marshaling from X509Certificates
This avoids allocations for the StringBuilder itself, and if the data is small enough to be put on the stack, also the char[]. It also avoids marshaling overheads associated with doing a wstrlen on the resulting data, as we're told exactly how long the string is.
* Address PR feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
7edeec59d41460b3bf41610850827b99d20ad0df
Stephen Toub [Thu, 10 May 2018 10:54:33 +0000 (06:54 -0400)]
Add tests for Type.FilterName{IgnoreCase} and Module.FilterTypeName{IgnoreCase} (dotnet/corefx#29624)
I made a change in coreclr that touched these members, and I noticed they didn't have any tests, so I'm adding some.
Commit migrated from https://github.com/dotnet/corefx/commit/
679090706f73c9d893a3ea9c2122eadd8efcb19d
dotnet-maestro-bot [Thu, 10 May 2018 04:35:35 +0000 (23:35 -0500)]
Update BuildTools, CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to preview1-02808-01, preview1-26510-01, preview1-26510-01, preview1-26509-06, beta-26509-00, beta-26509-00, respectively (dotnet/corefx#29561)
Commit migrated from https://github.com/dotnet/corefx/commit/
013a2ed3e6312dd2579a2d79f2e2324706fc4bc3
Stephen Toub [Thu, 10 May 2018 01:06:35 +0000 (21:06 -0400)]
Remove intermediate char[] allocation from ToHexStringUpper (dotnet/corefx#29612)
Use the new String.Create overload to write the hex representation directly into the target string rather than first writing into an allocated char[] and then creating a string from that.
Commit migrated from https://github.com/dotnet/corefx/commit/
9deaec59658a91df87991aa90ea466a353ad33e0
Martin Baulig [Thu, 10 May 2018 01:06:18 +0000 (21:06 -0400)]
SslApplicationProtocol: don't use local functions to support older compilers. (dotnet/corefx#29617)
Commit migrated from https://github.com/dotnet/corefx/commit/
6e4db3f55bfdec4c681361b77b619b4a7474a3b7
Max Kerr [Thu, 10 May 2018 00:21:23 +0000 (17:21 -0700)]
Re-enable tests that depend on new netfx behaviors. (dotnet/corefx#29621)
Several tests in System.Private.Uri.FunctionalTests were disabled because they depended on fixes that were not yet present in .NET Framework. Now that we're running against a newer version that includes the fixes, I've re-enabled these tests.
Fixes: dotnet/corefx#15145
Commit migrated from https://github.com/dotnet/corefx/commit/
140a84d88636ae3067eea5adf4df32e895e6eb73
Afsaneh Rafighi [Wed, 9 May 2018 21:46:31 +0000 (14:46 -0700)]
added license header file and formatted code
Commit migrated from https://github.com/dotnet/corefx/commit/
205f2cf7147f8f4365b739bdf56fc2626c663afa
Ian Hays [Wed, 9 May 2018 20:54:55 +0000 (13:54 -0700)]
Merge pull request dotnet/corefx#29616 from ianhays/master_sx
Misc fixes to sxl
Commit migrated from https://github.com/dotnet/corefx/commit/
6d571f70a69a3a1dcf54f73ab828c545de40690a
Ian Hays [Thu, 29 Mar 2018 19:35:27 +0000 (12:35 -0700)]
SignedXMl misc improvements
Commit migrated from https://github.com/dotnet/corefx/commit/
8322265bb13336b40e0cfd3b9fe0216eadf51df8
Santiago Fernandez Madero [Wed, 9 May 2018 18:55:29 +0000 (11:55 -0700)]
Add net472 version to PlatformDetection.GetFrameworkVersion (dotnet/corefx#29606)
Commit migrated from https://github.com/dotnet/corefx/commit/
8c47d918d13ecbad90f2f2e9c4ef994d8415be60
Afsaneh Rafighi [Wed, 9 May 2018 17:59:52 +0000 (10:59 -0700)]
Fixed GithubIssue29391
Commit migrated from https://github.com/dotnet/corefx/commit/
fc34319aea1f47a554b890286ec6ff942a901137
Wes Haggard [Wed, 9 May 2018 16:18:27 +0000 (09:18 -0700)]
Update intellisense files based on 5-7-2018 doc build (dotnet/corefx#29587)
Commit migrated from https://github.com/dotnet/corefx/commit/
a9249665664236494d59adb14d27bff7b900832d
Bruno Juchli [Wed, 9 May 2018 14:40:39 +0000 (16:40 +0200)]
ConcurrentDictionary: improve documentation (dotnet/corefx#29599)
* ConcurrentDictionary: improve documentation
Improve the summary of ConcurrentyDictionary.TryUpdate. The summary mentions parameters in a different order and with different names than they are represented in the method signature. This is confusing.
To clear things up, I've replaced the "verbal" parameter references by `<paramref name="XYZ"/>`.
* ConcurrentDictionary: improve documentation
Improving summary of ConcurrentDictionary.TryUpdate by mentioning parameters in the same order as they occur in the method signature.
Commit migrated from https://github.com/dotnet/corefx/commit/
91eb6661d95b9826e66579251faebe6f40fe1134
Maryam Ariyan [Wed, 9 May 2018 05:34:36 +0000 (22:34 -0700)]
Creating ~/.local/share directory if not created yet (dotnet/corefx#29514)
* Creating ~/.local/share directory if not created yet
Fixes: dotnet/corefx#29354
Commit migrated from https://github.com/dotnet/corefx/commit/
fd0d17874bdbfc5b6f662c62720428867aaea486