platform/upstream/VK-GL-CTS.git
7 years agoUse glReadnPixels only if KHR_robustness is supported am: d99ba132d9
Alexander Galazin [Wed, 15 Mar 2017 15:27:25 +0000 (15:27 +0000)]
Use glReadnPixels only if KHR_robustness is supported am: d99ba132d9
am: d01980d03d

Change-Id: If10695499f41c716416cb4277170529a1f325596

7 years agoUse glReadnPixels only if KHR_robustness is supported
Alexander Galazin [Wed, 15 Mar 2017 15:22:52 +0000 (15:22 +0000)]
Use glReadnPixels only if KHR_robustness is supported
am: d99ba132d9

Change-Id: Icd032ba51a9c2c6141b21083b300e8709ecd7b45

7 years agoMerge "Fix stencil bits when creating reference image in depth stencil tests"
Treehugger Robot [Mon, 13 Mar 2017 19:56:27 +0000 (19:56 +0000)]
Merge "Fix stencil bits when creating reference image in depth stencil tests"

7 years agoFix stencil bits when creating reference image in depth stencil tests
Kenneth Graunke [Sat, 11 Mar 2017 17:26:19 +0000 (09:26 -0800)]
Fix stencil bits when creating reference image in depth stencil tests

renderReference expects the number of stencil bits, but we were passing
the number of depth bits.

Affects:
- dEQP-GLES2.functional.fragment_ops.depth_stencil.*
- dEQP-GLES3.functional.fragment_ops.depth_stencil.*

Patch authored by Iago Toral.  See also:
https://bugs.freedesktop.org/show_bug.cgi?id=94455

Change-Id: Id20a4a976c11d5dbe099e0acacc2f7c38dddeb17

7 years agoUse glReadnPixels only if KHR_robustness is supported
Alexander Galazin [Thu, 23 Feb 2017 12:01:18 +0000 (13:01 +0100)]
Use glReadnPixels only if KHR_robustness is supported

glReadnPixels is introduced in KHR_robustness/GLES 3.2.
Use of this function in GLES 3.1 tests will result in segfault
on implementations that don't support KHR_robustness.

Components: AOSP, Framework

Affects: dEQP-GLES31.functional.debug.negative_coverage.callbacks.buffer.read_pixels_format_mismatch

VK-GL-CTS issue: 166
Google bug: 36122027

Change-Id: Idbe8734f7d82882ea99c75a8b74d693ac6dd831f
(cherry picked from commit 219019495770c221e92f43df3e76a954c613210d)

7 years agoFix typo in dEQP-GLES31.functional.srgb_texture_decode.skip_decode.*
Sunny Sun [Fri, 10 Mar 2017 06:46:23 +0000 (14:46 +0800)]
Fix typo in dEQP-GLES31.functional.srgb_texture_decode.skip_decode.*

Change-Id: I1432dbff1db24b0f1dd2c9a297822b4fbdb1aa76

7 years agoFix flakiness of compositeDeadline check of eglGetFrameTimestsmps
Brian Anderson [Tue, 7 Mar 2017 00:34:03 +0000 (16:34 -0800)]
Fix flakiness of compositeDeadline check of eglGetFrameTimestsmps

maxDeadline already has some slack built into the check.
This ensures proper slack for the mindDeadline too.

Test: --deqp-case=dEQP-EGL*get_frame_timestamps*

7 years agoMerge "Modify EGL robustness tests to use VBOs"
Treehugger Robot [Mon, 6 Mar 2017 19:54:49 +0000 (19:54 +0000)]
Merge "Modify EGL robustness tests to use VBOs"

7 years agoModify EGL robustness tests to use VBOs
John Richardson [Fri, 3 Mar 2017 12:01:08 +0000 (12:01 +0000)]
Modify EGL robustness tests to use VBOs

Remove use of client-side vertex arrays and use buffer objects instead.
Delete buffers on teardown and in destructor.
Move test description logs to start log file.

Affected tests:
- dEQP-EGL.functional.robustness.reset_context.*

Change-Id: I9432258f30d6c7e02362c0b2f6c36fc3694bd72d

7 years agoFix "null" ID in sRGB decode tests
Pyry Haulos [Fri, 3 Mar 2017 16:44:08 +0000 (08:44 -0800)]
Fix "null" ID in sRGB decode tests

Use 0 as "null" GL object ID as -1 is potentially valid ID.

Change-Id: I95f9f0c300d5b6e95c0c7c81e29fd28ac9ca3b82

7 years agoModify single_tessellation_stage to check for GL_NV_gpu_shader5
Mark Adams [Thu, 2 Mar 2017 15:19:49 +0000 (10:19 -0500)]
Modify single_tessellation_stage to check for GL_NV_gpu_shader5

That extension permits the use of a tessellation control shader
without a tessellation evaluation shader. Affected tests:

dEQP-GLES31.functional.debug.negative_coverage.*.tessellation.single_tessellation_stage

7 years agoAdd new robustness extension tests
John Richardson [Wed, 1 Feb 2017 15:00:53 +0000 (15:00 +0000)]
Add new robustness extension tests

New tests for KHR_robustness extension. Attempts to provoke context
reset scenarios and test GL state after a reset has occurred.

New test group:
- dEQP-EGL.functional.robustness.*

New tests:
- create_context.query_robust_access
- create_context.no_reset_notification
- create_context.lose_context_on_reset

- reset_context.shaders.infinite_loop.*   (various shaders)
- reset_context.shaders.out_of_bounds.*   (various resource types)
- reset_context.fixed_function_pipeline.* (index and vertex buffers)

- negative_context.invalid_robust_context_creation
- negative_context.invalid_robust_shared_context_creation

Note: Test groups ending in *_non_robust are for internal use only.

Change-Id: I91d7e3e95ec52f908dbaa1f49c56dcd94d60fd8f

7 years agoFix tessellation support checks in negative binding tests
Mika Isojärvi [Wed, 22 Feb 2017 21:25:59 +0000 (13:25 -0800)]
Fix tessellation support checks in negative binding tests

Bug: 35618877
Test: Run the tests on couple of devices supporting tessellation
Change-Id: Ieca6a28a57a278a07ff688f760eb7da807e66d49

7 years agoMerge Vulkan CTS 1.0.2.1 into AOSP
Pyry Haulos [Mon, 27 Feb 2017 19:26:45 +0000 (11:26 -0800)]
Merge Vulkan CTS 1.0.2.1 into AOSP

Change-Id: Ib0aaf12ec60902ebc31d00ad02291bd3d1cd7fae

7 years agoFix extension support checks in negative api tests
Graeme Leese [Thu, 23 Feb 2017 16:56:10 +0000 (16:56 +0000)]
Fix extension support checks in negative api tests

Add checks for tessellation and geometry shader support for negative
shader storage and primitive bounding box tests.

Move all uses of cubemap array textures inside the extension checks in
the texture tests.

Bug: 29835218
Change-Id: I6051fff231285ed7d9c71015c2bb11a9fc7b909b
Signed-off-by: Pierre Couillaud <pierre@broadcom.com>
7 years agoMerge "Drop MAX_TESS_CONTROL_TOTAL_OUTPUT_COMPONENTS to 2048"
Pyry Haulos [Fri, 24 Feb 2017 16:52:34 +0000 (16:52 +0000)]
Merge "Drop MAX_TESS_CONTROL_TOTAL_OUTPUT_COMPONENTS to 2048"

7 years agoDrop MAX_TESS_CONTROL_TOTAL_OUTPUT_COMPONENTS to 2048
Pyry Haulos [Thu, 23 Feb 2017 20:50:22 +0000 (12:50 -0800)]
Drop MAX_TESS_CONTROL_TOTAL_OUTPUT_COMPONENTS to 2048

GL_MAX_TESS_CONTROL_TOTAL_OUTPUT_COMPONENTS minmax has been changed to
2048 (from 4096) in OpenGL ES 3.2 spec in response to bug 12823.

Bug: 35619900
Change-Id: I59d75d23df02d339bf7094a8e73d3a24d2e785be

7 years agoModify tessellation_not_active to check for GL_NV_gpu_shader5
Mark Adams [Wed, 22 Feb 2017 22:03:36 +0000 (17:03 -0500)]
Modify tessellation_not_active to check for GL_NV_gpu_shader5

That extension permits use of GL_PATCHES for stages other than
tessellation stages. Affected test:

dEQP-GLES31.functional.debug.negative_coverage.get_error.tessellation.tessellation_not_active

Bug 35670519

7 years agoMerge "Fix whitespace issues"
Treehugger Robot [Wed, 22 Feb 2017 19:44:27 +0000 (19:44 +0000)]
Merge "Fix whitespace issues"

7 years agoAdd non-seperable TCS-but-no-TES subcase and fix draw time check subcase
John Richardson [Mon, 20 Feb 2017 11:26:04 +0000 (11:26 +0000)]
Add non-seperable TCS-but-no-TES subcase and fix draw time check subcase

- Add a non-separable TCS-but-no-TES (new subcase).

Section 7.3 of the OpenGL ES 3.2 specification says:

   "Linking can fail for [...] any of the following reasons:

    * program contains an object to form a tessellation evaluation
      shader [...] and [...] the program is not separable and
      contains no object to form a tessellation control shader"

Add a test to ensure the implementation does raise a link error.

- Make program separable in TES-but-no-TCS draw time check test (fix)

Since the test is trying to check for a draw time error, it should use
a separable program - otherwise we may hit a link error.

Changes made to test case:
dEQP-GLES31.functional.debug.negative_coverage.*.tessellation.single_tessellation_stage

Bug: 35354738
Change-Id: I902106864059cfbe7d718da0d0527284de04a915

7 years agoFix whitespace issues
Pyry Haulos [Wed, 22 Feb 2017 18:05:57 +0000 (10:05 -0800)]
Fix whitespace issues

Change-Id: I31cd4e4d3e113192fce0bccd20fd8fa14d182620

7 years agoAdd GetFrameTimestamps tests
Brian Anderson [Sun, 22 Jan 2017 00:03:19 +0000 (16:03 -0800)]
Add GetFrameTimestamps tests

Add tests for EGL_ANDROID_get_frame_timestamps.

Verifies:
1) Frame IDs properly identify frames.
2) The frame timestamp ordering is correct
3) The compositor timing values are reasonable.
4) All timestamps from the most recently swapped frame can
   be retrieved without additional swaps.

Test: --deqp-case=dEQP-EGL*get_frame_timestamps*
Change-Id: I393a3bc79f019951a2fddb83760b6e1d919663b6

7 years agoMerge "Fix multiple resource leaks in new srgb_texture_decode tests"
Treehugger Robot [Tue, 21 Feb 2017 18:52:36 +0000 (18:52 +0000)]
Merge "Fix multiple resource leaks in new srgb_texture_decode tests"

7 years agoMerge "Reduce read pixel calls in copy image tests"
Kalle Raita [Tue, 21 Feb 2017 17:43:45 +0000 (17:43 +0000)]
Merge "Reduce read pixel calls in copy image tests"

7 years agoMerge "Restructure copy image test iterations"
Kalle Raita [Tue, 21 Feb 2017 17:43:25 +0000 (17:43 +0000)]
Merge "Restructure copy image test iterations"

7 years agoFix multiple resource leaks in new srgb_texture_decode tests
Mark Adams [Fri, 17 Feb 2017 19:14:18 +0000 (14:14 -0500)]
Fix multiple resource leaks in new srgb_texture_decode tests

There were multiple issues here, ranging from never freeing resources,
to overwriting resources, to only freeing them at class destruction
instead of deinit time. This was resulting in hitting OOM on platforms
without tons of memory.

Bug: 35457323
Change-Id: I492177bb9e71bdbc7efc9d3a7c8a34bef35c709e

7 years agoMerge changes Icb29d2da,Ida906e21
Pyry Haulos [Fri, 17 Feb 2017 20:21:40 +0000 (20:21 +0000)]
Merge changes Icb29d2da,Ida906e21

* changes:
  Add a non-separable TCS-but-no-TES subcase.
  Make program separable in TCS-but-no-TES draw time check test.

7 years agoTest descriptor_update_template, push_descriptor
Petros Bantolas [Fri, 4 Nov 2016 15:12:52 +0000 (15:12 +0000)]
Test descriptor_update_template, push_descriptor

Extended the existing binding_model tests with 3 new variants,
'with_template', 'with_push_template' and 'with_push'.

The least invasive method to support push descriptor updates without
template was to persist the DescriptorSetUpdateBuilder object in the
test instance classes, so that it can be referenced when building the
command buffer.

Change-Id: I731fa41c5ff99ab1d390d77d7aabb4424e091e35
(cherry picked from commit 7f5ba3914c1d9033dd4f896ef6fcaa22f5c5e038)

7 years agoAdd sRGB skip decode test
Michael Hadley [Wed, 1 Feb 2017 12:48:08 +0000 (12:48 +0000)]
Add sRGB skip decode test

New Tests:
- deqp-case=dEQP-GLES31.functional.srgb_texture_decode.*

Change-Id: I0257e63b15ee0334efad985411d8070ddecdd51a

7 years agoReduce read pixel calls in copy image tests
Kalle Raita [Thu, 19 Jan 2017 22:15:58 +0000 (14:15 -0800)]
Reduce read pixel calls in copy image tests

Reduce glReadPixels calls in the copy image tests by rendering multiple
texture sub-images for each read back. Significant improvement for
certain platforms, no impact on others.

Bug: 33965234
Test: Run tests on Pixel C and Pixel XL, Check that old N9 results still
have same failures. Spot checks with 240x200 target surface.
Change-Id: I133c56b7855a664f164f1eb0b1307259462e098f

7 years agoRestructure copy image test iterations
Kalle Raita [Tue, 24 Jan 2017 19:47:17 +0000 (11:47 -0800)]
Restructure copy image test iterations

Packing test iterations so that work per buffer swap is maximized
without running the risk of hitting per-iteration timeout. Yields
execution time drops of roughly 50% on at least 2 GPU architectures.

Bug: 33965234
Test: Copy image tests on multiple devices and L MR1 N9 for detection capability.
Change-Id: I7de5231da0d8a1d2bd22ec3741f1481e2ebd5475

7 years agoAdd a non-separable TCS-but-no-TES subcase.
Kenneth Graunke [Sat, 11 Feb 2017 06:45:39 +0000 (22:45 -0800)]
Add a non-separable TCS-but-no-TES subcase.

   "Linking can fail for [...] any of the following reasons:

* program contains an object to form a tessellation control
  shader [...] and [...] the program is not separable and
  contains no object to form a tessellation evaluation shader"

Add a test to ensure the implementation does raise a link error.

The new subcase is part of:
dEQP-GLES31.functional.debug.negative_coverage.*.tessellation.single_tessellation_stage

Change-Id: Icb29d2da50b2c327bfd2196af9be56bb7d8644f9

7 years agoMake program separable in TCS-but-no-TES draw time check test.
Kenneth Graunke [Sat, 11 Feb 2017 05:30:50 +0000 (21:30 -0800)]
Make program separable in TCS-but-no-TES draw time check test.

Section 7.3 of the OpenGL ES 3.2 specification says:

   "Linking can fail for [...] any of the following reasons:

    * program contains an object to form a tessellation control
      shader [...] and [...] the program is not separable and
      contains no object to form a tessellation evaluation shader"

Since the test is trying to check for a draw time error, it should use
a separable program - otherwise we may hit a link error.

Fixes a bug in:
dEQP-GLES31.functional.debug.negative_coverage.*.tessellation.single_tessellation_stage

Change-Id: Ida906e21c3e3534fd2a8c7bac0334083881bdb19

7 years agoUpdate Android CTS Vulkan mustpass
Pyry Haulos [Mon, 13 Feb 2017 18:42:12 +0000 (10:42 -0800)]
Update Android CTS Vulkan mustpass

Following commits modify Vulkan CTS 1.0.2 mustpass:

 * fbaba83dbee101b3096ce33f21ae398efee3fa67
 * c09596ed4b8d17f057f77a42475d59c1ac126797

This change simply updates Android version of mustpass to match Khronos
Vulkan CTS 1.0.2 mustpass.

Change-Id: I79e2696ec4c457d11b59e03cf2a73977ab98d8d5
Components: AOSP

7 years agoUpdate Android CTS Vulkan mustpass to match 1.0.2
Pyry Haulos [Tue, 31 Jan 2017 00:02:32 +0000 (16:02 -0800)]
Update Android CTS Vulkan mustpass to match 1.0.2

This CL updates Android CTS mustpass for Vulkan to match Khronos Vulkan
CTS 1.0.2.0.

Change-Id: Ia2f82b5f6675c67940679eb98f59510f264d62bf
(cherry picked from commit 15f342274521c1be1032e993dbfd4a46b878f337)

7 years agoMerge vk-gl-cts/vulkan-cts-1.0.1 into vk-gl-cts/vulkan-cts-1.0.2
Pyry Haulos [Mon, 13 Feb 2017 18:34:37 +0000 (10:34 -0800)]
Merge vk-gl-cts/vulkan-cts-1.0.1 into vk-gl-cts/vulkan-cts-1.0.2

Change-Id: Ida077bae420c265f4a92d78d68b0f1c9b8d1c85c

7 years agoWrite gl_PointSize value when it is undefined
Iago Toral Quiroga [Fri, 10 Feb 2017 10:35:52 +0000 (11:35 +0100)]
Write gl_PointSize value when it is undefined

gl_PointSize is undefined unless expicitly written to. The only
exception to this rule is the case when
shaderTessellationAndGeometryPointSize is disabled, in which case it
defaults to 1.0 for these stages.

Since we don't have access to the physical device features at shader
compile time, implement two variants of the tessellation evaluation
shader when point mode is enabled, one that writes gl_PointSize and
one that doesn't and decide the one we need at run time based on
whether the feature is enabled or not.

Components: Vulkan
Fixes VK-GL-CTS issue: 159

Affects:
dEQP-VK.tessellation.primitive_discard.*point_mode

Change-Id: Idadbc70a704f00ed601ff65afeb2a3edfbeb3f19

7 years agoFix a few bugs in a EGL_KHR_no_config_context test.
Kenneth Graunke [Thu, 2 Feb 2017 18:40:02 +0000 (10:40 -0800)]
Fix a few bugs in a EGL_KHR_no_config_context test.

The dEQP-EGL.functional.create_context.no_config test had the eglBindAPI
check backwards - so it was skipping APIs assuming they failed when they
actually succeeded.

Secondly, it failed to actually set the test result to "pass" if all
cases passed, which led to assertion failures:

    Assertion `testResult != QP_TEST_RESULT_LAST' failed.

Change-Id: I7a20467012fd6c174f79679bbf640917c327574c

7 years agoLimit changes by xor to upper 8 bits in mixed atomic tests am: 6bc3c7a634
Mika Isojrvi [Thu, 9 Feb 2017 22:44:03 +0000 (22:44 +0000)]
Limit changes by xor to upper 8 bits in mixed atomic tests am: 6bc3c7a634
am: eef2e716e7

Change-Id: Icadf536794c067056e66f6a2041fbb937952f35a

7 years agoLimit changes by xor to upper 8 bits in mixed atomic tests
Mika Isojrvi [Thu, 9 Feb 2017 22:41:59 +0000 (22:41 +0000)]
Limit changes by xor to upper 8 bits in mixed atomic tests
am: 6bc3c7a634

Change-Id: I354ee074ad57d53c2b4b0a84d8bc02a02912f19d

7 years agoMerge "Use deFloatIsNaN, not isnan."
Treehugger Robot [Thu, 9 Feb 2017 21:28:03 +0000 (21:28 +0000)]
Merge "Use deFloatIsNaN, not isnan."

7 years agoUse deFloatIsNaN, not isnan.
Dan Albert [Wed, 8 Feb 2017 19:37:30 +0000 (11:37 -0800)]
Use deFloatIsNaN, not isnan.

Discovered because this file includes cmath rather than math.h, so
some header cleanup made isnan go away (it should have been
std::isnan).

Test: mma
Bug: http://b/34724220
Change-Id: Idb6b26a90307f510ad1a118b694a34e32ce7507c

7 years agodEQP-VK.info.*image_format_properties2* VkImageUsageFlags fix
Marcin Kańtoch [Mon, 6 Feb 2017 09:25:56 +0000 (10:25 +0100)]
dEQP-VK.info.*image_format_properties2* VkImageUsageFlags fix

The usage flags loop iterator starts currently with 0, which is not
a valid image usage value. It is reported as an error by Validation
Layers.

The patch contains also a simple fix for iterating over valid sample
count flag bits.

Modified tests:
dEQP-VK.info.image_format_properties2*
dEQP-VK.info.sparse_image_format_properties2*

Components: Vulkan
VK-GL-CTS issue: 133

Change-Id: I0edbdbc389fa3bd9a71ca4d3b7777ede38a7b353

7 years agoAndroid: Test that mandatory extensions are supported
Pyry Haulos [Fri, 3 Feb 2017 21:25:48 +0000 (13:25 -0800)]
Android: Test that mandatory extensions are supported

Change-Id: Id0e44299f1d8441bf1e7ecc91d82d3b06400e7e6

7 years agoAndroid: Test that no Vulkan layers are enumerated
Pyry Haulos [Tue, 17 Jan 2017 23:49:02 +0000 (15:49 -0800)]
Android: Test that no Vulkan layers are enumerated

Change-Id: I43dacf306b468485fc160f175160555b9cf1c86d

7 years agoAndroid: Check KHX, GOOGLE, and ANDROID extensions
Pyry Haulos [Wed, 11 Jan 2017 23:02:19 +0000 (15:02 -0800)]
Android: Check KHX, GOOGLE, and ANDROID extensions

Change-Id: I6ee24e584666e1f2542adf35943a2973c9392ad9

7 years agoMerge vk-gl-cts/vulkan-cts-1.0.1 into vk-gl-cts/vulkan-cts-1.0.2
Pyry Haulos [Thu, 9 Feb 2017 17:54:38 +0000 (09:54 -0800)]
Merge vk-gl-cts/vulkan-cts-1.0.1 into vk-gl-cts/vulkan-cts-1.0.2

Change-Id: I32aa09e131335c13262518708fd5970191aad77b

7 years agoFix memory management, image layout issues in uploadImageSparse()
Dominik Witczak [Thu, 17 Nov 2016 12:10:19 +0000 (13:10 +0100)]
Fix memory management, image layout issues in uploadImageSparse()

Fixes an issue where ShaderRenderCaseInstance::uploadSparseImage()
would first configure sparse image bindings and then deallocate
the memory objects, prior to actually sampling the image.

Fixes an issue where the sparse image, after having been filled with
contents, would first be transitioned to SHADER_READ_ONLY_OPTIMAL
layout, and then used in a DS which was expecting it to be in
GENERLA layout.

Finally, the patch addresses a problem, where the function would not
correctly recognize the VK_SPARSE_IMAGE_FORMAT_SINGLE_MIPTAIL_BIT,
as reported by the running driver.

The change affects dEQP-VK.glsl.*sparse* tests

VK-GL-CTS issue: 156

Change-Id: Ie5717841fe0ef9c0672b5075380ff96bba9855b9
(cherry picked from commit 70fc0800efe725f4f91f4d03b09aa0e567dbb09c)

7 years agoDo not require unsupported sparse images in image_format_properties test
Slawomir Cygan [Tue, 10 Jan 2017 15:59:29 +0000 (16:59 +0100)]
Do not require unsupported sparse images in image_format_properties test

Affects tests: dEQP-VK.api.info.image_format_properties*

This change removes the requirement for supporting sparse residency images:
- with compressed format
- with non-color format
- with format of pixel size that is not power ot two (for example: RGB).

 Additionally do not require 1D sparse residency images (not in spec),
 and require 2D/3D residency images basing on the device capabilities.

Spec 28.1. Sparse Resource Features:
"A sparse image created using VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT
supports all non-compressed color formats with power-of-two element
size that non-sparse usage supports.

(...)

sparseResidencyImage2D: Support for creating 2D single-sampled VkImage
objects with VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT.

sparseResidencyImage3D: Support for creating 3D VkImage objects with
 VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT.
"

Component: Vulkan
VK-GL-CTS Issue: 131

(cherry picked from commit 5534b44a15b530ece4b310e1dd935fb9b0cefeb6)

Change-Id: Ia2481fbcd12a32a6470af26df213a2f930c2e6db

7 years agoMerge "Fix out of bounds accesses in TexImage*DParamsCase."
Mika Isojarvi [Wed, 8 Feb 2017 19:21:10 +0000 (19:21 +0000)]
Merge "Fix out of bounds accesses in TexImage*DParamsCase."

7 years agoFix out of bounds accesses in TexImage*DParamsCase.
Mika Isojärvi [Tue, 7 Feb 2017 20:52:54 +0000 (12:52 -0800)]
Fix out of bounds accesses in TexImage*DParamsCase.

Bug: 28764822
Test: Ran the tests on couple of devices and checked the results.
Change-Id: I3f743bf75d73ce7de7ff2b0633551c0cc7606ca0

7 years agoFix Android builds compiler flags
Mika Isojärvi [Mon, 6 Feb 2017 22:48:37 +0000 (14:48 -0800)]
Fix Android builds compiler flags

- Move -fwrapv to common flags
- Add -Wno-delete-non-virtual-dtor

Bug: 34676963
Test: Build deqp with the AOSP ARM64 target
Change-Id: I21e4c70ef5f2ebe7d306d5a4dcbb52933c4dff6d

7 years agoFix dEQP-VK.api.info.get_physical_device_properties2.properties
Iago Toral Quiroga [Wed, 1 Feb 2017 09:38:52 +0000 (10:38 +0100)]
Fix dEQP-VK.api.info.get_physical_device_properties2.properties

The test uses memcmp to compare structs that may include padding
bytes. Although the test initializes all bytes prior to calling any
Vulkan APIs, there is no guarantee that drivers won't write to the
padding bytes, for example if they write the properties to a local
variable and then memcpy into the result pointer, which is a valid
implementation.

This patch fixes the problem by reusing the offset table that we
already use in another test to obtain the offsets and sizes for all
struct fields and exclude any padding bytes during comparisons.

Affects:
dEQP-VK.api.info.get_physical_device_properties2.properties

VK-GL-CTS issue: 63
Components: Vulkan

Change-Id: I4417a95d41241523acd13adc739e739da9b0c2ed

7 years agoMerge vk-gl-cts/vulkan-cts-1.0.1 into vk-gl-cts/vulkan-cts-1.0.2
Pyry Haulos [Mon, 6 Feb 2017 21:01:07 +0000 (13:01 -0800)]
Merge vk-gl-cts/vulkan-cts-1.0.1 into vk-gl-cts/vulkan-cts-1.0.2

Change-Id: Ie39f778967a81af072e60194987d6e3978afb45e

7 years agoFix XCB window dimensions setter
Igor Ostrowski [Mon, 30 Jan 2017 13:08:45 +0000 (14:08 +0100)]
Fix XCB window dimensions setter

Make sure that dimension setter catched appropriate property notify event.

Components: Framework

VK-GL-CTS issue: 134

Change-Id: I4630175dffea57a54375fe6900df7dd3aa5823d4

7 years agoMerge "Check NDK version in the app build script"
Treehugger Robot [Mon, 6 Feb 2017 20:18:40 +0000 (20:18 +0000)]
Merge "Check NDK version in the app build script"

7 years agoCheck NDK version in the app build script
Kalle Raita [Wed, 1 Feb 2017 19:25:05 +0000 (11:25 -0800)]
Check NDK version in the app build script

Prevents accidentally starting build with wrong version and prints
instructions for retrieving correct NDK version.

Test: manual for current build, using r12 (wrong version), and override
Change-Id: I4a021e71261d17897bb4285ce996a758db7e5419

7 years agoFix issues in Vulkan PointCoord test
Pyry Haulos [Wed, 1 Feb 2017 23:24:52 +0000 (15:24 -0800)]
Fix issues in Vulkan PointCoord test

 * Fixed PointCoord calculation to follow spec.

 * Made random point size generation code more robust. Existing code
resulted in rnd.getInt() being called with invalid range.

Changed: dEQP-VK.glsl.builtin_var.simple.pointcoord
Components: Vulkan
VK-GL-CTS issue: 68

Change-Id: I34f0c2c2ec5c8d759f22e81a1683c21572887c58

7 years agoFix uint precision issue in pipeline barrier tests
Mika Isojärvi [Wed, 18 Jan 2017 21:41:39 +0000 (13:41 -0800)]
Fix uint precision issue in pipeline barrier tests

Add missing highp qualifier for int types in fragment shaders.

Affected tests
dEQP-VK.memory.pipeline_barrier.host_write_uniform_buffer.*
dEQP-VK.memory.pipeline_barrier.host_write_uniform_texel_buffer.*
dEQP-VK.memory.pipeline_barrier.host_write_storage_buffer.*
dEQP-VK.memory.pipeline_barrier.host_write_storage_texel_buffer.*
dEQP-VK.memory.pipeline_barrier.transfer_dst_uniform_buffer.*
dEQP-VK.memory.pipeline_barrier.transfer_dst_uniform_texel_buffer.*
dEQP-VK.memory.pipeline_barrier.transfer_dst_storage_buffer.*
dEQP-VK.memory.pipeline_barrier.transfer_dst_storage_texel_buffer.*
dEQP-VK.memory.pipeline_barrier.all.*
dEQP-VK.memory.pipeline_barrier.all_device.*

VK-GL-CTS issue: 67

Change-Id: I9c78a1c19a06554dd86bf7dbb3c7bc3a96cb72dc

7 years agoUpdate SPIR-V tools to ab03b87
Pyry Haulos [Wed, 1 Feb 2017 22:46:11 +0000 (14:46 -0800)]
Update SPIR-V tools to ab03b87

This fixes SPIR-V tools build when git is configured to check out
windows-style line endings.

Generated SPIR-V binaries are not affected by this change.

VK-GL-CTS issue: 73

Change-Id: Ic1639a50a059211ad315a8b07f2279b50ed9a133

7 years agoAndroid: Test that mandatory extensions are supported
Pyry Haulos [Fri, 3 Feb 2017 21:25:48 +0000 (13:25 -0800)]
Android: Test that mandatory extensions are supported

Change-Id: Id0e44299f1d8441bf1e7ecc91d82d3b06400e7e6

7 years agoAndroid: Test that no Vulkan layers are enumerated
Pyry Haulos [Tue, 17 Jan 2017 23:49:02 +0000 (15:49 -0800)]
Android: Test that no Vulkan layers are enumerated

Change-Id: I43dacf306b468485fc160f175160555b9cf1c86d

7 years agoAndroid: Check KHX, GOOGLE, and ANDROID extensions
Pyry Haulos [Wed, 11 Jan 2017 23:02:19 +0000 (15:02 -0800)]
Android: Check KHX, GOOGLE, and ANDROID extensions

Change-Id: I6ee24e584666e1f2542adf35943a2973c9392ad9

7 years agoMerge "Update Android CTS Vulkan mustpass to match 1.0.2"
Treehugger Robot [Tue, 31 Jan 2017 01:45:31 +0000 (01:45 +0000)]
Merge "Update Android CTS Vulkan mustpass to match 1.0.2"

7 years agoUpdate Android CTS Vulkan mustpass to match 1.0.2
Pyry Haulos [Tue, 31 Jan 2017 00:02:32 +0000 (16:02 -0800)]
Update Android CTS Vulkan mustpass to match 1.0.2

This CL updates Android CTS mustpass for Vulkan to match Khronos Vulkan
CTS 1.0.2.0.

Change-Id: Ia2f82b5f6675c67940679eb98f59510f264d62bf

7 years agoAdded gl_BoundingBox built-in type access tests
Michael Hadley [Wed, 14 Dec 2016 20:08:59 +0000 (20:08 +0000)]
Added gl_BoundingBox built-in type access tests

New tests:
- dEQP-GLES31.functional.debug.negative_coverage.callbacks.shader_directive.accessing_bounding_box_type

Change-Id: I8f47dfdfde631f36f6a515459867b59e3c210701

7 years agoAdd SSBO block tests
Michael Hadley [Thu, 1 Dec 2016 17:52:17 +0000 (17:52 +0000)]
Add SSBO block tests

New Tests:
- dEQP-GLES31.functional.debug.negative_coverage.callbacks.ssbo_block.ssbo_block.*

Change-Id: I60d52bc34d9211e93332dcc719535f1f5e4a0596

7 years agoAdd tessellation shader stages to negative layout_binding tests
John Richardson [Wed, 23 Nov 2016 14:48:32 +0000 (14:48 +0000)]
Add tessellation shader stages to negative layout_binding tests

Tests groups added to:
- dEQP-GLES31.functional.layout_binding.negative.sampler.sampler2d.*.
- dEQP-GLES31.functional.layout_binding.negative.sampler.sampler3d.*.
- dEQP-GLES31.functional.layout_binding.negative.ubo.*.
- dEQP-GLES31.functional.layout_binding.negative.ssbo.*.
- dEQP-GLES31.functional.layout_binding.negative.image.image2d.*.
- dEQP-GLES31.functional.layout_binding.negative.image.image3d.*.

New tests (tess_control, tess_evalution):
- binding_neg
- binding_over_max
- binding_neg_array
- binding_over_max_array

Extended tests:
- binding_contradictory
- binding_contradictory_array

Change-Id: Ia6b66f1d5316e3bba376a8aea189074b60fbedb5

7 years agoAdd new tessellation negative coverage tests
John Richardson [Wed, 9 Nov 2016 08:34:43 +0000 (08:34 +0000)]
Add new tessellation negative coverage tests

Test groups added to:
- dEQP-GLES31.functional.shaders.linkage.tessellation.varying.rules
- dEQP-GLES31.functional.shaders.linkage.tessellation.layout_declarations.rules (new)
- dEQP-GLES31.functional.shaders.linkage.tessellation.barriers.rules (new)
- dEQP-GLES31.functional.debug.negative_coverage.*.tessellation (new)

New tests:
- output_non_array
- invalid_patch_in_usage
- invalid_patch_out_usage
- invalid_per_patch_qualifier_usage
- output_block_non_array

- invalid_barrier_usage_within_control_flow
- invalid_barrier_usage_after_return

- primitive_mode_mismatch
- spacing_mode_mismatch
- vertex_order_mismatch
- vertex_count_mismatch

- single_tessellation_stage
- invalid_primitive_mode
- tessellation_not_active
- invalid_program_state
- get_programiv
- invalid_program_queries
- tessellation_control_invalid_vertex_count

Change-Id: I0c4f4b407bfe80e09546af51fdb2d184cf310757

7 years agoMerge nougat-mr1-cts-dev into master.
Xin Li [Thu, 26 Jan 2017 18:55:24 +0000 (10:55 -0800)]
Merge nougat-mr1-cts-dev into master.

7 years agoSkip commit 'c5bbebc46ac7725d43692602422ee3fc76cac7b0' on master.
Xin Li [Thu, 26 Jan 2017 18:53:54 +0000 (10:53 -0800)]
Skip commit 'c5bbebc46ac7725d43692602422ee3fc76cac7b0' on 

7 years agoMerge commit '2a9d42a651ef444f32f0a6e60711bb2c371d3fce' from
Xin Li [Thu, 26 Jan 2017 18:28:31 +0000 (10:28 -0800)]
Merge commit '2a9d42a651ef444f32f0a6e60711bb2c371d3fce' from
nougat-cts-mr1-dev to master.

Change-Id: I9ad6799aaae603a05c0cc65bcff60df8bff88a95

7 years agoLimit changes by xor to upper 8 bits in mixed atomic tests
Mika Isojärvi [Wed, 16 Nov 2016 23:10:29 +0000 (15:10 -0800)]
Limit changes by xor to upper 8 bits in mixed atomic tests

Bug: 31270281
Test: Ran tests on multiple devices
Change-Id: I64393591171b304cd071f7a37b91efd2c7a853a6

7 years agoAdd eglChooseConfig() tests for EXT_pixel_format_float
Pyry Haulos [Fri, 20 Jan 2017 18:30:13 +0000 (10:30 -0800)]
Add eglChooseConfig() tests for EXT_pixel_format_float

These tests verify that eglChooseConfig() filters configs correctly
based on EGL_COLOR_COMPONENT_TYPE_EXT attribute.

Change-Id: Icaaffee69dd46a9044149c01c8fe8b7ec8928305

7 years agoAdd basic test for EGL_KHR_no_config_context
Pyry Haulos [Fri, 20 Jan 2017 19:04:46 +0000 (11:04 -0800)]
Add basic test for EGL_KHR_no_config_context

Change-Id: I14aa3f38ea8d2aaa224c13a992d41cf5ef546f6e

7 years agoMerge aosp/upstream-vulkan-cts-1.0-dev into aosp/master
Pyry Haulos [Tue, 24 Jan 2017 17:07:51 +0000 (09:07 -0800)]
Merge aosp/upstream-vulkan-cts-1.0-dev into aosp/master

Change-Id: Ifee45dee9fe57a8386c468dfedfb822c329f2504

7 years agoMerge "x11: Call XInitThreads()" into nougat-cts-dev
Tina Zhou [Mon, 23 Jan 2017 19:12:27 +0000 (19:12 +0000)]
Merge "x11: Call XInitThreads()" into nougat-cts-dev
am: cbdbf95222

Change-Id: I2531e5a260f50c8bae1a756a61026a46ae253614

7 years agox11: Call XInitThreads()
Chad Versace [Mon, 23 Jan 2017 19:12:25 +0000 (19:12 +0000)]
x11: Call XInitThreads()
am: 5d11c9d2c0

Change-Id: Ib89f9fbfaa7d0b3dcb590fc2ac20ff2c83e3fbad

7 years agoMerge "x11: Fix deadlock" into nougat-cts-dev
Tina Zhou [Mon, 23 Jan 2017 19:12:12 +0000 (19:12 +0000)]
Merge "x11: Fix deadlock" into nougat-cts-dev
am: 34b869eeea

Change-Id: I5ffe988c3affcd3afeaf3c63b5011e42ef9a4ba1

7 years agox11: Fix deadlock
Chad Versace [Mon, 23 Jan 2017 19:12:10 +0000 (19:12 +0000)]
x11: Fix deadlock
am: 5e863331b2

Change-Id: Ic938e269f89e59fc9ab8b43c97efcb49e0317180

7 years agoMerge "x11: Call XInitThreads()" into nougat-cts-dev
Tina Zhou [Mon, 23 Jan 2017 19:11:49 +0000 (19:11 +0000)]
Merge "x11: Call XInitThreads()" into nougat-cts-dev
am: cbdbf95222

Change-Id: I063e616e5eb47560c87e4e550cb41e29bddca05a

7 years agox11: Call XInitThreads()
Chad Versace [Mon, 23 Jan 2017 19:11:47 +0000 (19:11 +0000)]
x11: Call XInitThreads()
am: 5d11c9d2c0

Change-Id: Ibdd37ad696a32e47d56e7138949cac34cb6245a8

7 years agoMerge "x11: Fix deadlock" into nougat-cts-dev
Tina Zhou [Mon, 23 Jan 2017 19:11:34 +0000 (19:11 +0000)]
Merge "x11: Fix deadlock" into nougat-cts-dev
am: 34b869eeea

Change-Id: I7af8485bb0a56711f3dfe09bd16bf26bc7b5588a

7 years agox11: Fix deadlock
Chad Versace [Mon, 23 Jan 2017 19:11:32 +0000 (19:11 +0000)]
x11: Fix deadlock
am: 5e863331b2

Change-Id: I1de362ce859395f3c7c932b1d6ad652925516dda

7 years agoMerge "x11: Call XInitThreads()" into nougat-cts-dev
Tina Zhou [Mon, 23 Jan 2017 19:09:19 +0000 (19:09 +0000)]
Merge "x11: Call XInitThreads()" into nougat-cts-dev

7 years agoMerge "x11: Fix deadlock" into nougat-cts-dev
Tina Zhou [Mon, 23 Jan 2017 19:06:21 +0000 (19:06 +0000)]
Merge "x11: Fix deadlock" into nougat-cts-dev

7 years agoCP: Remove two read-backs from copy image tests
Kalle Raita [Sat, 21 Jan 2017 00:35:05 +0000 (00:35 +0000)]
CP: Remove two read-backs from copy image tests
am: 263e135474  -s ours

Change-Id: I3145b66433218cbd2d7a13452d2626cda66f001e

7 years agoCP: Non-compressed copy image target size (64,64,8
Kalle Raita [Sat, 21 Jan 2017 00:35:03 +0000 (00:35 +0000)]
CP: Non-compressed copy image target size (64,64,8
am: 7aff1a044f

Change-Id: I263ee368df721429983ace2e80a4ddeb17c2e2c3

7 years agoCP: Remove two read-backs from copy image tests
Kalle Raita [Sat, 21 Jan 2017 00:23:35 +0000 (00:23 +0000)]
CP: Remove two read-backs from copy image tests
am: 263e135474

Change-Id: I9926edda54ffa5bdb0b5b7f9aeac08aab58237e8

7 years agoCP: Non-compressed copy image target size (64,64,8
Kalle Raita [Sat, 21 Jan 2017 00:23:33 +0000 (00:23 +0000)]
CP: Non-compressed copy image target size (64,64,8
am: 7aff1a044f

Change-Id: I55e1c77eb6558a7a396707cf541d529394be34b7

7 years agox11: Fix deadlock
Chad Versace [Fri, 20 Jan 2017 22:59:10 +0000 (14:59 -0800)]
x11: Fix deadlock

When waiting for a window's MapNotify event, drain only that window's
event queue.  Do NOT drain the global event queue, which includes all
windows' events.

Fixes deadlock in test 'dEQP-EGL.functional.multithread.window_context'
on Mesa master@f57bdd48 with Intel Skylake.

Change-Id: I8c7f2db6c145f59493cb7572b20c4799e9a2cd0a
Depends-On: Ib3b535cec8295e062994fd759ae083c78641cf13

7 years agox11: Call XInitThreads()
Chad Versace [Tue, 27 Dec 2016 21:47:33 +0000 (13:47 -0800)]
x11: Call XInitThreads()

Because the X11 manual says we must.

From man:XInitThreads(3):

  The XInitThreads function initializes Xlib support for concurrent
  threads.  This function must be the first Xlib function
  a multi-threaded program calls, and it must complete before any other
  Xlib call is made.

Fixes crash in multithreaded test:

  Test case 'dEQP-EGL.functional.multithread.window_context'..
  [xcb] Unknown sequence number while processing queue
  [xcb] Most likely this is a multi-threaded client and XInitThreads has not been called
  [xcb] Aborting, sorry about that.
  deqp-egl: xcb_io.c:259: poll_for_event: Assertion `!xcb_xlib_threads_sequence_lost' failed.

Change-Id: Ib3b535cec8295e062994fd759ae083c78641cf13

7 years agoCP: Remove two read-backs from copy image tests
Kalle Raita [Thu, 1 Sep 2016 20:21:50 +0000 (13:21 -0700)]
CP: Remove two read-backs from copy image tests

Cherry pick commit b2fb8ad5ceefe26964101bd403e7786ae83274a9
from master.

Bug: 33965234

Remove two read-backs from copy image tests

Test: Ran copy_image on N6 & N9 with L MR1 image to check for
false-negatives. PixelC and Pixel XL for passing with current OS image.

Change-Id: I9f7028eb550012f8d9abe2f7afee2d1402f5abf3

7 years agoCP: Non-compressed copy image target size (64,64,8
Kalle Raita [Wed, 7 Dec 2016 17:41:41 +0000 (09:41 -0800)]
CP: Non-compressed copy image target size (64,64,8

Cherry-pick commit 8076c97ac0fc706288ef266b0cbe748012c4e0c4 from master:

Non-compressed copy image tests target size reduced to (64,64,8). The
compressed cases retain old size of (128,128,16) to ensure coverage of
all block size combinations.

Bug: 33965234
Test: Run tests on N6 and N9 on L MR 1 with known failures
Change-Id: If22e8722c1de58aa239cf6fe29e79d3bdd13c589

7 years agoMerge "Remove tests affected by NV/OES_viewport_array extension" into nougat-cts-dev
Tina Zhou [Fri, 20 Jan 2017 20:28:13 +0000 (20:28 +0000)]
Merge "Remove tests affected by NV/OES_viewport_array extension" into nougat-cts-dev
am: e98444b9bf  -s ours

Change-Id: I35eea6598260946f05bec754e9a627c263cad2f0

7 years agoRemove tests affected by NV/OES_viewport_array extension
Pyry Haulos [Fri, 20 Jan 2017 20:28:12 +0000 (20:28 +0000)]
Remove tests affected by NV/OES_viewport_array extension
am: 267c765690  -s ours

Change-Id: I8f9d7aef632660fe6201035d381485072dbee063

7 years agoMerge "Generate flat triangles in polygon offset tests." into nougat-cts-dev
Tina Zhou [Fri, 20 Jan 2017 20:27:56 +0000 (20:27 +0000)]
Merge "Generate flat triangles in polygon offset tests." into nougat-cts-dev
am: 61d6d95a66

Change-Id: I1eb46e5e8e20d1f35eb7c0234e97aa0f0d8c1ea1

7 years agoGenerate flat triangles in polygon offset tests.
Alexander Galazin [Fri, 20 Jan 2017 20:27:55 +0000 (20:27 +0000)]
Generate flat triangles in polygon offset tests.
am: 975a59ebca

Change-Id: Ia1226e8da8462deb895b6e7e8113db5fd500565f

7 years agoMerge "Relax line width verification in primitive bbox tests" into nougat-cts-dev
Tina Zhou [Fri, 20 Jan 2017 20:27:45 +0000 (20:27 +0000)]
Merge "Relax line width verification in primitive bbox tests" into nougat-cts-dev
am: 312a550657

Change-Id: Ic9ad221d68e82f4b2fc31a6ca51f21fc731ca31d

7 years agoresolve merge conflicts of ba455914 to master
Pyry Haulos [Fri, 20 Jan 2017 18:34:24 +0000 (10:34 -0800)]
resolve merge conflicts of ba455914 to master

Change-Id: Iad350278ba3cf6adcc0fa5e4914e8d98db71a567