Drew Scoggins [Wed, 10 May 2017 20:07:12 +0000 (13:07 -0700)]
Merge pull request dotnet/coreclr#11448 from DrewScoggins/AddPriority
Launch perf process with high priority
Commit migrated from https://github.com/dotnet/coreclr/commit/
695164b9c69fbffd640494e661bae02c44ffa0f0
Jonghyun Park [Wed, 10 May 2017 19:32:33 +0000 (12:32 -0700)]
[ARM/Linux] Enable build with FEATURE_DBGIPC=0 (dotnet/coreclr#11254)
* [ARM/Linux] Enable build with FEATURE_DBGIPC=0
* Replace HAVE_ALIGNED_MALLOC with SUPPORT_LOCAL_DEBUGGING
Commit migrated from https://github.com/dotnet/coreclr/commit/
cdd7d58e75667f108a4843c5aeb61648cd25f340
Jan Vorlicek [Wed, 10 May 2017 16:32:42 +0000 (18:32 +0200)]
Fix clang version detection in src/pal/tools/gen-buildsys-clang.sh (dotnet/coreclr#11398)
The version detection that was added recently for the purpose of selecting
optimization options for ARM builds was not working properly when the
clang binary doesn't have version in its name. This resulted in syntax
error being reported on OSX and some Linux distros:
/Users/janvorli/git/coreclr/src/pal/tools/gen-buildsys-clang.sh:
line 162: : /usr/bin/clang: syntax error: operand expected (error token is "/usr/bin/clang")
Commit migrated from https://github.com/dotnet/coreclr/commit/
b1247408c30dd4dc511e8a65adf8a4efb2776f10
Tarek Mahmoud Sayed [Wed, 10 May 2017 15:38:20 +0000 (08:38 -0700)]
Update the License to MIT for coreclr repo (dotnet/coreclr#11482)
Commit migrated from https://github.com/dotnet/coreclr/commit/
c78891ae1cc668a77377b2b0fb03c7e1a6894b29
Jonghyun Park [Wed, 10 May 2017 15:10:22 +0000 (08:10 -0700)]
Allow users to enable automatic NI bind fallback via command-line (dotnet/coreclr#11485)
* Add FEATURE_NI_BIND_FALLBACK support
* Fix incorrect variable setup
* Negate the check condition
* Use WIN32 instead of FEATURE_PAL
* Check WIN32 first, and FEATURE_NI_BIND_FALLBACK later
Commit migrated from https://github.com/dotnet/coreclr/commit/
17468288b4093efc8fea4748ee3c890bf82535bb
Pat Gavlin [Wed, 10 May 2017 13:56:57 +0000 (06:56 -0700)]
Merge pull request dotnet/coreclr#11484 from pgavlin/DisableLongRunningTests
Disable a few long-running tests.
Commit migrated from https://github.com/dotnet/coreclr/commit/
aa82eb3e057ff6f7853b27749cefd0991625066d
dotnet bot [Wed, 10 May 2017 05:20:44 +0000 (22:20 -0700)]
Update CoreFx to preview2-25310-01 (dotnet/coreclr#11483)
Commit migrated from https://github.com/dotnet/coreclr/commit/
1413d462631f0d9bfc4c3df3cb5371e23bcbd8d9
Pat Gavlin [Wed, 10 May 2017 03:41:05 +0000 (20:41 -0700)]
Disable a few long-running tests.
These tests consistently time out under GC stress or heap verification.
Each disabled test is known to complete successfully given adequate
time.
Commit migrated from https://github.com/dotnet/coreclr/commit/
8ada9acdf8895d313ad71cbeb2dab4e92b02853f
Mike McLaughlin [Wed, 10 May 2017 02:14:09 +0000 (19:14 -0700)]
Fix lldbplugin to properly build with lldb 3.9. (dotnet/coreclr#11480)
Commit migrated from https://github.com/dotnet/coreclr/commit/
c50b6ae6ecaeafce033f568423f5f40fec723e7b
Sergey Andreenko [Tue, 9 May 2017 21:11:24 +0000 (14:11 -0700)]
[x86, R2R] Exclude DevDiv_278523 because it fails in R2R
Look at dotnet/coreclr#11476 for the description.
Commit migrated from https://github.com/dotnet/coreclr/commit/
b1e4097046588d4a4b7c1efab665c023ccf1d5d4
Joseph Tremoulet [Tue, 9 May 2017 23:36:14 +0000 (19:36 -0400)]
Merge pull request dotnet/coreclr#11465 from JosephTremoulet/StaticHoist
Stop hoisting statics above cctors
Commit migrated from https://github.com/dotnet/coreclr/commit/
3d689cadda3f9ff6eb3a6792677b9ac12c36c3c8
Brian Sullivan [Tue, 9 May 2017 23:11:33 +0000 (16:11 -0700)]
Merge pull request dotnet/coreclr#11351 from sdmaclea/PR-ARM64-RRSS-SSRR
[Arm64] Add emitIns_R_R_S_S & emitIns_S_S_R_R
Commit migrated from https://github.com/dotnet/coreclr/commit/
bdd61eae2b36e09d41b76527d469947c4284afeb
Sergey Andreenko [Tue, 9 May 2017 20:24:37 +0000 (13:24 -0700)]
delete tabs from the exclude list
Commit migrated from https://github.com/dotnet/coreclr/commit/
cda214110f763c8a9901f8fb605db088ed6babc6
Joseph Tremoulet [Tue, 9 May 2017 02:30:04 +0000 (22:30 -0400)]
Stop hoisting statics above cctors
Extend the logic in optLoopHoist around `CLS_VAR` nodes to ensure we don't
hoist any tree that contains a `CLS_VAR` for a field with the flag
`CORINFO_FLG_FIELD_INITCLASS` set, unless we also (identify and) hoist the
corresponding static init helper call. The previous logic was
insufficient in that it blocked hoisting of singleton `CLS_VAR` nodes, but
not hoisting of trees that contain `CLS_VAR` nodes as sub-trees.
Add flag `GTF_FLD_INITCLASS`/`GTF_CLS_VAR_INITCLASS` so that optLoopHoist
can recall which fields are paired with static init helper calls, and only
block the hoisting of their trees.
Fixes dotnet/coreclr#10780.
Commit migrated from https://github.com/dotnet/coreclr/commit/
673f56aa91d69b78fc0055e4419d5ad59c47b83b
Sergey Andreenko [Tue, 9 May 2017 19:07:20 +0000 (12:07 -0700)]
Replace tabs with spaces.
Commit migrated from https://github.com/dotnet/coreclr/commit/
f3f57bc07ec5c12c11a7216d2c5190f585c45ab7
Sergey Andreenko [Tue, 9 May 2017 18:00:08 +0000 (11:00 -0700)]
Return DevDiv_255294 test to the exclude list for x86
Because it causes out of memory exception in crossgen mode.
Commit migrated from https://github.com/dotnet/coreclr/commit/
033b592756f34381c63c037c68de3f6924677270
Koundinya Veluri [Tue, 9 May 2017 20:56:40 +0000 (13:56 -0700)]
Fix static analysis issues (dotnet/coreclr#11466)
Fix static analysis issues
Commit migrated from https://github.com/dotnet/coreclr/commit/
c8a37801f8483d05766e0bf053ffa41aaa155f2c
Bruce Forstall [Tue, 9 May 2017 19:05:20 +0000 (12:05 -0700)]
Merge pull request dotnet/coreclr#11406 from sdmaclea/PR-ARM64-ENABLE-FEATURE_TAILCALL_OPT
[Arm64] Enable FEATURE_TAILCALL_OPT
Commit migrated from https://github.com/dotnet/coreclr/commit/
39a841c33a6ae70cc887ee9fa7cfdeb834c6ca59
Jan Vorlicek [Tue, 9 May 2017 18:30:59 +0000 (20:30 +0200)]
Stop loading crossgen-ed binaries at preferred address on Unix (dotnet/coreclr#11467)
This change removes attempt to load crossgen-ed binaries at preferred
address on Unix and uses whatever address the mmap returns instead.
Commit migrated from https://github.com/dotnet/coreclr/commit/
1ce30c0e3b17555459b936fe61f527b175b0035e
Pat Gavlin [Tue, 9 May 2017 18:10:00 +0000 (11:10 -0700)]
Fix issue dotnet/coreclr#11446. (dotnet/coreclr#11455)
This issue was a GC hole that was caused by bad IR produced by
recursivelty promoting a struct with the following form:
```
struct S
{
struct T
{
object o;
};
T t;
}
```
In this case, the recursive promotion logic created a single lclVar to
represent `S.t` and retyped it using the type of `T.o`, but did not
rewrite IR that treated the single lclVar as a struct (e.g. instances of
`lclFld/st.lclFld Vx` where `Vx` referred to the lclVar that represented
`S.t` were not rewritten an `lclVar/st.lclVar Vx`). This IR in
turn confused the incremental liveness used during code generation,
which caused the stack slot holding `o`'s value to die too early.
This change fixes codegen's incremental liveness to handle this case.
Commit migrated from https://github.com/dotnet/coreclr/commit/
4f6fe878d7dfe2a148252eecc672981eedda1f1c
dotnet bot [Tue, 9 May 2017 14:32:46 +0000 (07:32 -0700)]
Update CoreClr, CoreFx to preview2-25309-01, preview2-25309-01, respectively (dotnet/coreclr#11427)
Commit migrated from https://github.com/dotnet/coreclr/commit/
ce327d54bc2af18d9b470b926c6805fa4dcad2cd
Jan Vorlicek [Tue, 9 May 2017 09:03:32 +0000 (11:03 +0200)]
Enable build on old Linux (dotnet/coreclr#11414)
This change enables building coreclr on old Linux distros that
don't have PR_SET_PTRACER and don't have _xstate struct in the
standard sigcontext.h header.
Commit migrated from https://github.com/dotnet/coreclr/commit/
3437a820fdc94caa3d1775bcee802b056f3adce2
Tarek Mahmoud Sayed [Tue, 9 May 2017 01:03:05 +0000 (18:03 -0700)]
Avoid throwing in the globalization managed callbacks (dotnet/coreclr#11454)
* Avoid throwing in the globalization managed callbacks
* Add Assert
Commit migrated from https://github.com/dotnet/coreclr/commit/
eac27ca7fb6e80a0a1af44b889469b2818c45a9a
Viktor Hofer [Tue, 9 May 2017 00:41:06 +0000 (17:41 -0700)]
FailFast stderr logging with stacktrace (dotnet/coreclr#11397)
Commit migrated from https://github.com/dotnet/coreclr/commit/
0c4a490a74c81e9735b0b7ef5b272add75e95ddf
Jarret Shook [Mon, 8 May 2017 23:18:08 +0000 (16:18 -0700)]
Merge pull request dotnet/coreclr#11457 from jashook/arm64_pri1_tests
[Arm64] For arm64 jobs build pri1 tests by default
Commit migrated from https://github.com/dotnet/coreclr/commit/
f19e02d75ac17337bf04539d22db0a06137dc726
Pat Gavlin [Mon, 8 May 2017 22:56:54 +0000 (15:56 -0700)]
Merge pull request dotnet/coreclr#11451 from pgavlin/gh11447
Fix issue dotnet/coreclr#11447.
Commit migrated from https://github.com/dotnet/coreclr/commit/
2299624395524e97baec864683c5fc61a963179a
jashook [Mon, 8 May 2017 22:41:12 +0000 (15:41 -0700)]
[Arm64] For arm64 jobs build pri1 tests by default
This relates to coreclr dotnet/coreclr#11423, enabling pri1 tests to
be built.
Commit migrated from https://github.com/dotnet/coreclr/commit/
3440877c8beac92f192e32b0968d77b9267ba38f
Alex Ghiondea [Mon, 8 May 2017 22:14:02 +0000 (15:14 -0700)]
Add assembly level attribute on CoreLib (dotnet/coreclr#11449)
Commit migrated from https://github.com/dotnet/coreclr/commit/
e623a2b5894c997fcefe2dcad76e554821912c66
Drew Scoggins [Mon, 8 May 2017 18:59:23 +0000 (11:59 -0700)]
Launch perf process with high priority
This change uses the stability prefix flag that was already in
run-xunit-perf to pass flags to set the affinity of the process to a
single processor and to run the process at high priority.
Commit migrated from https://github.com/dotnet/coreclr/commit/
9ad3212945092c1eb20c37564b28970941f89d74
Mike McLaughlin [Mon, 8 May 2017 20:34:41 +0000 (13:34 -0700)]
Add the "createdump" to the linux runtime package. (dotnet/coreclr#11441)
Commit migrated from https://github.com/dotnet/coreclr/commit/
94eb128265d39fbe350f68bba4cc6658e3ddeada
Pat Gavlin [Mon, 8 May 2017 19:17:42 +0000 (12:17 -0700)]
Fix issue dotnet/coreclr#11447.
This issue was caused by the code for PInvoke frame initialization reading
from the stub argument register after it had been trashed by prior
instructions. This change fixes this issue by inserting the PInvoke
frame initialization at the beginning of the scratch block into which it
is inserted rather than at the end.
Note that a more correct fix here would be to represent the stub
argument as a lclVar rather than a physical register; that work is
tracked by dotnet/coreclr#11450.
Commit migrated from https://github.com/dotnet/coreclr/commit/
673242edd0a0939e0e4cd22d6a217dbd9295ba00
Koundinya Veluri [Mon, 8 May 2017 19:16:21 +0000 (12:16 -0700)]
Make CoreCLR work properly under PaX's RANDMMAP (dotnet/coreclr#11382)
Make CoreCLR work properly under PaX's RANDMMAP
Issues:
- The ExecutableMemoryAllocator is used to attempt to map native images into a memory range near libcoreclr so that its helper table can use short relative addresses for jumps to libcoreclr
- RANDMMAP typically prevents mmap calls with a specific address from reserving memory at the requested address, so the executable memory allocator fails to reserve any memory. When Server GC is enabled, the large GC heap can exacerbate the issue by taking address space near libcoreclr.
- Native images are loaded far from libcoreclr, and now jump stub space needs to be allocated near the native image, but RANDMMAP typically prevents this too
- NGenReserveForJumpStubs is intended to reserve some memory near mapped native images for jump stubs, but that reservation is done with a separate mmap call in the same way as above and RANDMMAP typically prevents this too
- The JIT needs to allocate memory for code that may need to jump/call to a native image or libcoreclr, which may require jump stubs near the code that cannot be allocated. CodeHeapReserveForJumpStubs reserves space in code heap blocks without using a separate call to mmap, so this works, but without this environment variable by default there is still a good chance of failing.
- See https://github.com/dotnet/coreclr/blob/dotnet/coreclr@
56d550d4f8aec2dd40b72a182205d0a2463a1bc9/Documentation/design-docs/jump-stubs.md for more details
Fixes dotnet/coreclr#8480
- It would be ideal to fix all of the above properly, such that there would never be a need to attempt reserving memory within a certain range. Since we're running out of time for 2.0, I figured the following simpler, temporary solution that should cover most of the practical cases, may be appropriate for 2.0.
- Extended ExecutableMemoryAllocator to reserve address space even when it cannot do so near libcoreclr
- Had ClrVirtualAllocWithinRange use the executable memory allocator to reserve memory for jump stubs when the requested range is satisfied
- This covers a maximum of ~2 GB of executable code and should cover most of the practical cases. Once this space is exhausted, under RANDMMAP, native images loaded later will fail, and for jitted code the environment variable above can be used.
Commit migrated from https://github.com/dotnet/coreclr/commit/
8514226271bd125d62fbab552d9ebb107bd67fb1
Jarret Shook [Mon, 8 May 2017 19:14:18 +0000 (12:14 -0700)]
Merge pull request dotnet/coreclr#11445 from jashook/fix_build_break
Add define for FEATURE_SIMD
Commit migrated from https://github.com/dotnet/coreclr/commit/
1db5bbc0b29c2801a2d548ee852424d6ea207388
Drew Scoggins [Mon, 8 May 2017 18:50:45 +0000 (11:50 -0700)]
Merge pull request dotnet/coreclr#11443 from DrewScoggins/CopyFix
Fix copy error in perf script
Commit migrated from https://github.com/dotnet/coreclr/commit/
9ffd44e07959b9166d84c9bad8809901b53e8e2a
Russell C Hadley [Mon, 8 May 2017 18:08:11 +0000 (11:08 -0700)]
Merge pull request dotnet/coreclr#11231 from russellhadley/UpdateEHDoc
Update EH WriteThru doc with review feedback.
Commit migrated from https://github.com/dotnet/coreclr/commit/
ba1de7fd77bc0a138414b65472afd00ddf31ce1d
Russell Hadley [Wed, 26 Apr 2017 19:24:24 +0000 (12:24 -0700)]
Update doc with review feedback.
Factor in additional exception cases from Andy and fix some wording from
Joe.
Commit migrated from https://github.com/dotnet/coreclr/commit/
93bdf190c9bfd5e62e4b471ec94a6f15d44a00d4
jashook [Mon, 8 May 2017 16:30:24 +0000 (09:30 -0700)]
Add define for FEATURE_SIMD
This fixs a build break in the desktop product.
Commit migrated from https://github.com/dotnet/coreclr/commit/
adfd1856a4eaa1e3cb5e45389c6e672cb84cb55d
Drew Scoggins [Mon, 8 May 2017 17:19:05 +0000 (10:19 -0700)]
Use profile information to differentiate files
Commit migrated from https://github.com/dotnet/coreclr/commit/
bc1bc9cacb65a0692d054f578b00852c5b6e449f
[Arm64] Revise per comments
Commit migrated from https://github.com/dotnet/coreclr/commit/
637c9db949076a595710a88aea9b6ff38694f8dc
[Arm64] Add emitIns_R_R_S_S
Commit migrated from https://github.com/dotnet/coreclr/commit/
16ca06c4b68502b39c105367f27a8f62368959d4
[Arm64] Add emitIns_S_S_R_R
Commit migrated from https://github.com/dotnet/coreclr/commit/
494f00cb881cc68426718b32a62464d4c7c48007
Sebastian Lauber [Mon, 8 May 2017 16:08:27 +0000 (18:08 +0200)]
Minor typo corrected (dotnet/coreclr#11444)
Commit migrated from https://github.com/dotnet/coreclr/commit/
4a9af731456a2b72e90d34f79824602cb455f5cd
Drew Scoggins [Mon, 8 May 2017 06:26:42 +0000 (23:26 -0700)]
Change xcopy to copy
Commit migrated from https://github.com/dotnet/coreclr/commit/
2f15c84ef9e4df3f94052a6e105d5a9cbad0d09d
Drew Scoggins [Mon, 8 May 2017 05:09:20 +0000 (22:09 -0700)]
Fix copy error in perf script
When I merged the PR that enabled the lean runs I added another call to
our run script. This run script had an assumption that it would only
ever be called once and as such would try and copy two files that had
the same name. This would cause it to prompt to overwrite or not and
fail the run. This change makes each copy unique based on the
collection flags that were used for collection.
Commit migrated from https://github.com/dotnet/coreclr/commit/
fa0ee737a0c05b1e3db83f508fd1b8018da97b61
Justin Van Patten [Mon, 8 May 2017 03:42:41 +0000 (20:42 -0700)]
Make Debugger class static (dotnet/coreclr#11439)
* Make Debugger class static
It's static in the .NET Standard and .NET Core refs, and in CoreRT's
implementation, so make it static in the CoreCLR implementation as well.
Also, minor cleanup while making changes here.
Commit migrated from https://github.com/dotnet/coreclr/commit/
487cb23e80d8cc02e21f1497d1c3c16b5ff1f367
Brian Robbins [Sat, 6 May 2017 19:36:08 +0000 (12:36 -0700)]
Log Events to EventPipe on Linux (dotnet/coreclr#11433)
* Implement the EventPipe object model for providers and events.
* Plumb Runtime Events into EventPipe (dotnet/coreclr#11145)
Plumb runtime ETW events into the EventPipe.
* Fix bug where all events except for SampleProfiler events were never enabled.
* Plumb EventPipeEventInstance through the EventPipe.
* Implement EventPipeFile and FastSerializer.
* Write event contents to the EventPipeFile.
* Only build EventPipe on Linux.
* Conditionally add a sentinel value marking event end.
* Send SampleProfiler events to the EventPipeFile.
* Fix provider ID printing to JSON file.
* Write the start date/time, timestamp, and clock frequency into the trace file.
* Support unloading of EventPipeProviders.
* Handle failure cases when we can't walk the stack or are shutting down.
* Fix a bug where we pass a null src pointer to memcpy.
Commit migrated from https://github.com/dotnet/coreclr/commit/
72ac46450bec8ea88ed023d9c1faf5a04556c834
Jan Kotas [Sat, 6 May 2017 18:03:27 +0000 (11:03 -0700)]
Delete dead code (dotnet/coreclr#11431)
Commit migrated from https://github.com/dotnet/coreclr/commit/
3ababc21ab334a2e37c6ba4115c946ea26a6f2fb
Jan Kotas [Sat, 6 May 2017 14:18:56 +0000 (07:18 -0700)]
Delete moved file
Commit migrated from https://github.com/dotnet/coreclr/commit/
278837ee1072f60a01663dcf09367bd2fd86dcae
Jan Kotas [Sat, 6 May 2017 03:48:28 +0000 (20:48 -0700)]
Delete moved files and fix build breaks
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/
c853b030a2701b39cb098ea1facfd8721bba1cf1
Jan Kotas [Sat, 6 May 2017 03:32:38 +0000 (20:32 -0700)]
Move more files to shared CoreLib partition (dotnet/coreclr#11429)
Commit migrated from https://github.com/dotnet/coreclr/commit/
7babb04d94c58b8639ecbe6f9c8bef0a5d88cf05
Justin Van Patten [Fri, 5 May 2017 23:56:49 +0000 (16:56 -0700)]
Remove ArrayList (dotnet/coreclr#11426)
Also cleanup FEATURE_NONGENERIC_COLLECTIONS while on it.
Commit migrated from https://github.com/dotnet/coreclr/commit/
bb70a71ee1aa9c5ff6b4ff0851a8e622bb23c1ac
Drew Scoggins [Fri, 5 May 2017 23:44:00 +0000 (08:44 +0900)]
Merge pull request dotnet/coreclr#11428 from DrewScoggins/LeanRuns
Fix typo in perf.groovy
Commit migrated from https://github.com/dotnet/coreclr/commit/
99143691275477103b8ec0b4bc283b1062ee91fd
Drew Scoggins [Fri, 5 May 2017 23:07:27 +0000 (16:07 -0700)]
Fix typo in perf.groovy
Had a typo where I was passing deafult instead of default as a flag to
the collection harness. This fixes that.
Commit migrated from https://github.com/dotnet/coreclr/commit/
1e14842f722c9e9335c0e709fc6ffbbd9cb81381
Steve MacLean [Fri, 5 May 2017 23:16:37 +0000 (19:16 -0400)]
[Arm64/Unix] Enable FEATURE_USE_SOFTWARE_WRITE_WATCH_FOR_GC_HEAP (dotnet/coreclr#11375)
* [Arm64/Unix] Enable FEATURE_USE_SOFTWARE_WRITE_WATCH_FOR_GC_HEAP
* [Arm64/Unix] Enable FEATURE_MANUALLY_MANAGED_CARD_BUNDLES
Commit migrated from https://github.com/dotnet/coreclr/commit/
060dc1d1e6d89d999f0741e5daf99f5fa564772f
Sean Gillespie [Fri, 5 May 2017 22:57:25 +0000 (15:57 -0700)]
Add a GC Reliability Framework job to the CI (dotnet/coreclr#11280)
* Add GC Reliability Framework CI job
* Three changes:
1) To address offline feedback, update the CI trigger phase document
and the GC testing instructions
2) Set the timeout for GC RF CI jobs to 24 hours, so they don't time
out (they will run for 15 hours by default)
3) Refactor "scenario == 'gc_reliability_framework' to its own method
so that new GC RF scenarios can easily and cleanly be added if
desired in the future
Commit migrated from https://github.com/dotnet/coreclr/commit/
30a09322644a5512315d34bbb4fccfddf5795f0f
Jarret Shook [Fri, 5 May 2017 21:35:56 +0000 (14:35 -0700)]
Merge pull request dotnet/coreclr#11425 from jashook/build_arm64_tests
Build tests for arm64 runs.
Commit migrated from https://github.com/dotnet/coreclr/commit/
624378eb5a90386777d05acda5d374af925f2756
gbalykov [Fri, 5 May 2017 20:07:44 +0000 (23:07 +0300)]
Add compact entry points for ARM (dotnet/coreclr#11109)
Commit migrated from https://github.com/dotnet/coreclr/commit/
980c1204d68f54be77eb840cc3f2e4fe2df42a26
jashook [Fri, 5 May 2017 20:06:31 +0000 (13:06 -0700)]
Build tests for arm64 runs.
This has been separated to allow coreclr dotnet/coreclr#11423 to be tested
incrementally in the PR.
Commit migrated from https://github.com/dotnet/coreclr/commit/
c1f8ef3fea431070e836ce2fff9141d3e5af865d
dotnet bot [Fri, 5 May 2017 19:54:49 +0000 (12:54 -0700)]
Update CoreClr to preview2-25305-03 (dotnet/coreclr#11421)
Commit migrated from https://github.com/dotnet/coreclr/commit/
f32af15fd8c5ceae9ac10b5d2ef0eed9c66ca4e3
Pedro Lamas [Fri, 5 May 2017 19:30:05 +0000 (20:30 +0100)]
Return null from CultureData.GetLocaleInfoEx (dotnet/coreclr#11422)
Commit migrated from https://github.com/dotnet/coreclr/commit/
1a3dfa8c8405fa56ea3de897c43d79650463e74c
Jan Kotas [Fri, 5 May 2017 15:47:11 +0000 (08:47 -0700)]
Fix build breaks
Commit migrated from https://github.com/dotnet/coreclr/commit/
712cd0668801e2db3e78a49bbf9c5cb53011bc5f
Jan Kotas [Fri, 5 May 2017 15:03:16 +0000 (08:03 -0700)]
Switch over to shared Interop.Globalization.cs on Windows (dotnet/coreclr#3528)
- Match CoreCLR refactoring done for invariant culture
- Use actual unsafe types in the interop signatures instead of opaque IntPtr
- Use Unsafe.As to get a pointer to stack allocated structure instead of allocating GCHandles
- Remove use of NativeCallable for enumeration to make the same code work on both CoreRT and CoreCLR. (I have kelp the NativeCallable annotations commented out so that we can switch back to them once C# gets the intrinsics to make it possible.)
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/
8026a02a3abb3f83f666e5eac8a6ddce20c70e77
Roman Artemev [Fri, 5 May 2017 18:17:42 +0000 (11:17 -0700)]
Merge pull request dotnet/coreclr#11405 from rartemev/issue_10857_addingseq
Fixed memory instruction selection for integer register which contants simd8 type in ELT hook prolog
Commit migrated from https://github.com/dotnet/coreclr/commit/
d37d98054f535fcaba161cd533c034dfb80342f1
Santiago Fernandez Madero [Fri, 5 May 2017 18:12:21 +0000 (11:12 -0700)]
Path.GetDirectoryName() throw exception when path is empty or has only white spaces (dotnet/coreclr#11403)
* Throw exception when path is empty or has only white spaces
Commit migrated from https://github.com/dotnet/coreclr/commit/
d9722358f905a6ed0edcb0fccded66bb6a64fa0c
Tarun Pothulapati [Fri, 5 May 2017 17:49:59 +0000 (17:49 +0000)]
Removed Dictionary<TKey, TValue>.GetValueOrDefault Methods (dotnet/coreclr#11388)
* Removed Dictionary.GetValueOrDefault Methods and the method calls in Rtpe.cs,CustomAttribute.cs
* Replaced the Dictionary.GetValueOrDefault Methods
* Used !s_pca.ContainsKey(caType) instead of s_pca.ContainsKey(caType) == false
Commit migrated from https://github.com/dotnet/coreclr/commit/
0581f34ca9b0cd27abf03a4d0232ca59250ab9f0
Drew Scoggins [Fri, 5 May 2017 17:39:15 +0000 (02:39 +0900)]
Add lean run support to CoreCLR perf (dotnet/coreclr#11347)
In the xunit performance harness we added support for a "lean" run which
only runs the stopwatch to collect duration and none of the ETW
providers are turned on. This adds support in the automation for doing
runs that use this lean feature.
Commit migrated from https://github.com/dotnet/coreclr/commit/
803b48ca0f6e3097a3453d1d15d3765704461651
Stephen Toub [Fri, 5 May 2017 16:35:21 +0000 (12:35 -0400)]
Merge pull request dotnet/coreclr#11411 from justinvp/delegate_opequality
Use ReferenceEquals instead of Delegate.op_Equality for sentinel checks
Commit migrated from https://github.com/dotnet/coreclr/commit/
c84237673b6167ee964ba6bea00041dac9dca3e2
dotnet bot [Fri, 5 May 2017 15:19:07 +0000 (08:19 -0700)]
Update CoreClr, CoreFx to preview2-25305-01, preview2-25305-01, respectively (dotnet/coreclr#11384)
Commit migrated from https://github.com/dotnet/coreclr/commit/
5011a33a24866e14dc7b953bec798ff03901bc2b
sergey ignatov [Fri, 5 May 2017 15:12:07 +0000 (18:12 +0300)]
Fixed issue dotnet/coreclr#11383 (dotnet/coreclr#11385)
Commit migrated from https://github.com/dotnet/coreclr/commit/
f0a850b785d73740add815329409183de23a2c35
Bruce Forstall [Fri, 5 May 2017 14:24:49 +0000 (07:24 -0700)]
Merge pull request dotnet/coreclr#11361 from mikedn/imp-strlen-except
Add missing GTF_EXCEPT when importing string length intrinsic
Commit migrated from https://github.com/dotnet/coreclr/commit/
f3bf62697c63e1bc4c383b9af82d0d3e42ac2afd
Mike McLaughlin [Fri, 5 May 2017 05:48:21 +0000 (22:48 -0700)]
Fix incorrect metadata on SOS.NETCore.dll (dotnet/coreclr#11395) again (dotnet/coreclr#11415)
There was a simple msbuild property.
Issue dotnet/coreclr#11381
Commit migrated from https://github.com/dotnet/coreclr/commit/
f1b1172f132acb9a6d8280eb9088ce52868c8956
Mike Danes [Wed, 3 May 2017 05:35:13 +0000 (08:35 +0300)]
Add missing GTF_EXCEPT when importing string length intrinsic
Commit migrated from https://github.com/dotnet/coreclr/commit/
331c37eb26ca29413dffe6997d5514492d5dbba8
Jan Kotas [Fri, 5 May 2017 04:12:20 +0000 (21:12 -0700)]
Move UnmanagedMemoryStream and related types to shared CoreLib partition (dotnet/coreclr#11409)
Commit migrated from https://github.com/dotnet/coreclr/commit/
ceb81e1a78e8415cddb79f5aaba96108fe7cb2e7
Bruce Forstall [Fri, 5 May 2017 03:55:26 +0000 (20:55 -0700)]
Add new test for COMPlus_TailcallStress=1 bug, currently disabled (dotnet/coreclr#11410)
Add new test for COMPlus_TailcallStress=1 bug, currently disabled
Commit migrated from https://github.com/dotnet/coreclr/commit/
4d12501d34d327d5cb7347f1b3af1c21f20a3c1c
William Godbe [Fri, 5 May 2017 02:54:53 +0000 (19:54 -0700)]
Merge pull request dotnet/coreclr#11401 from wtgodbe/DeleteNis
Rename all xxx.ni.dll's to xxx.dll for Helix Crossgen runs
Commit migrated from https://github.com/dotnet/coreclr/commit/
6952aaaec5f6ff760e1281b3e56b4af29639b13b
Roman Artemev [Thu, 4 May 2017 20:14:15 +0000 (13:14 -0700)]
Fixed memory instruction selector for integer register which contants simd8 type
Commit migrated from https://github.com/dotnet/coreclr/commit/
27e1de2e2da551a5ed64c411bbeb6ba59ec155ac
Karel Zikmund [Thu, 4 May 2017 23:23:21 +0000 (16:23 -0700)]
Update contributing-workflow.md
Commit migrated from https://github.com/dotnet/coreclr/commit/
4ce7c65a1c0ccb457abaf38217d8ca6f5383bd49
Bruce Forstall [Thu, 4 May 2017 23:07:26 +0000 (16:07 -0700)]
Refactor arm32/arm64 per-node codegen into functions (dotnet/coreclr#11377)
These new functions can sometimes be shared, as they are identical or
virtually so.
In addition, the driver function genCodeForTreeNode() has been
made common.
Commit migrated from https://github.com/dotnet/coreclr/commit/
1aa7ca424deb65c510bc8b7e3ee34039c9f0e6a1
wtgodbe [Thu, 4 May 2017 18:57:51 +0000 (11:57 -0700)]
Rename all xxx.ni.dll's to xxx.dll for Helix Crossgen runs
Commit migrated from https://github.com/dotnet/coreclr/commit/
cd37819de42a5f208c9d7b9bcf08b9f6d928e1a2
Mike McLaughlin [Thu, 4 May 2017 22:19:57 +0000 (15:19 -0700)]
Fix incorrect metadata on SOS.NETCore.dll (dotnet/coreclr#11395)
Issue dotnet/coreclr#11381
Commit migrated from https://github.com/dotnet/coreclr/commit/
78b34158ef2048e3559a8ca782be609b94d98ed4
Carol Eidt [Thu, 4 May 2017 22:09:55 +0000 (15:09 -0700)]
Update first-class-structs.md
Commit migrated from https://github.com/dotnet/coreclr/commit/
2928ea3a1c0cfbcb6945f1c4146b6fbee117d942
Carol Eidt [Thu, 4 May 2017 22:07:37 +0000 (15:07 -0700)]
Update first-class-structs.md
Commit migrated from https://github.com/dotnet/coreclr/commit/
c45a32f9fe9fbbde5e33acab90785a36ffdacfd4
Justin Van Patten [Thu, 4 May 2017 22:05:38 +0000 (15:05 -0700)]
Use ReferenceEquals instead of Delegate.op_Equality for sentinel checks
The reference equality check is more efficient than
Delegate.op_Equality.
Commit migrated from https://github.com/dotnet/coreclr/commit/
e42e2ce0d6422fc74175e032842aaa5bb38e2112
Ian Hays [Thu, 4 May 2017 22:01:16 +0000 (15:01 -0700)]
Remove UnmanagedMemoryStream overflow checks. (dotnet/coreclr#11376)
* Remove UnmanagedMemoryStream overflow checks.
* Catch negative UMS PositionPointers
* Switch UMS PositionPointer exception order
Commit migrated from https://github.com/dotnet/coreclr/commit/
07efb266175e96ebf1c455d2524b410f26b7385e
Jan Kotas [Thu, 4 May 2017 19:37:39 +0000 (12:37 -0700)]
Fix ProjectN build break (dotnet/corertdotnet/coreclr#3517)
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/
3c17dbc325de61c7899af9d9f019e6d0f561fd19
[Arm64] Enable FEATURE_TAILCALL_OPT
Commit migrated from https://github.com/dotnet/coreclr/commit/
08a3547dd4eab57e58f82db2ad283bec60fc00b7
Viktor Hofer [Thu, 4 May 2017 21:11:33 +0000 (23:11 +0200)]
System.IO.Path.GetPathRoot string.Empty or whitespace character string should throw ArgumentException (dotnet/coreclr#11387)
* GetPathRoot string.Empty and string whitespace throws ArgumentException
* throw in next line
* Refined method description
* Unix impl adjusted
* Indentation
* pr feedback
* Delete Path.Unix.cs
* Adding param to ArgumentException
Commit migrated from https://github.com/dotnet/coreclr/commit/
8e99cd8031b2f568ea69116e7cf96d55e32cb7f5
Jan Vorlicek [Thu, 4 May 2017 20:19:53 +0000 (13:19 -0700)]
Reenable MapViewOfFile PAL test1 (dotnet/coreclr#11393)
This change reenables the test that was having problems on systems when the /tmp
is created on tmpfs file system which doesn't support direct access (unbuffered).
The fix is to explicitly use /var/tmp instead (and /data/local/tmp/ on Android).
Commit migrated from https://github.com/dotnet/coreclr/commit/
bae3ded1b302abdb1d0b46346f03162bddadba40
Mike McLaughlin [Thu, 4 May 2017 17:58:58 +0000 (10:58 -0700)]
Remove stale section on managed debugging. (dotnet/coreclr#11392)
Commit migrated from https://github.com/dotnet/coreclr/commit/
1ff9062d235630a3a47bffa6459549c669432c4a
Carol Eidt [Thu, 4 May 2017 17:49:09 +0000 (10:49 -0700)]
Merge pull request dotnet/coreclr#11370 from CarolEidt/ILOffsetDump
Dump GT_IL_OFFSET value in hex
Commit migrated from https://github.com/dotnet/coreclr/commit/
e9582650e72e9b100d2bff187a50005daa0231a9
Tom Deseyn [Thu, 4 May 2017 15:13:22 +0000 (17:13 +0200)]
Document Linux libnuma dependency (dotnet/coreclr#11367)
Commit migrated from https://github.com/dotnet/coreclr/commit/
e3b89a4abce3afb23ef92757cb77c7ade8d77862
Davis Goodin [Thu, 4 May 2017 14:17:24 +0000 (09:17 -0500)]
Disable symbol package MyGet publish on release/* (dotnet/coreclr#11372)
Commit migrated from https://github.com/dotnet/coreclr/commit/
4eb6cb798ef238d8a09e8b85d94da281ba95acf7
Jan Kotas [Thu, 4 May 2017 03:35:14 +0000 (20:35 -0700)]
Delete moved file
Commit migrated from https://github.com/dotnet/coreclr/commit/
9ca09de5f54e5edb2733523fad3a52b01700e3de
Jan Kotas [Thu, 4 May 2017 01:58:57 +0000 (18:58 -0700)]
Merge pull request dotnet/corertdotnet/coreclr#3506 from dotnet/nmirror
Merge nmirror to master
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/
48a8b9dcddaee0cf74731db3590d1d4c645954df
dotnet bot [Thu, 4 May 2017 04:58:52 +0000 (21:58 -0700)]
Update CoreClr, CoreFx to preview2-25303-03, preview2-25303-04, respectively (dotnet/coreclr#11354)
Commit migrated from https://github.com/dotnet/coreclr/commit/
e8eb00ebe44dffda27959fc0913fd2b8bb2667d2
Mike McLaughlin [Thu, 4 May 2017 00:17:22 +0000 (17:17 -0700)]
Createdump fixes and cleanup. (dotnet/coreclr#11368)
Fixed "with heap" option to actually include all the heaps. The way /proc/$pid/maps
was parsed missed most of the RW data/heap regions.
Added -u/--full full core dump options.
Removed the useless m_memStatus variable in enummem.cpp.
Commit migrated from https://github.com/dotnet/coreclr/commit/
3fb9d8d2fe094f09a914d31a551e14fe8a1f2215
Steve MacLean [Wed, 3 May 2017 22:52:42 +0000 (18:52 -0400)]
[Arm64/Unix] Revise JIT_MemSet (dotnet/coreclr#11217)
* [Arm64/Unix] Revise JIT_MemSet
Use DC ZVA
Use stp
Correctly handle short set lengths
Simplify code & pseudo code
Use uint*_t to make pseudo code more readable
Commit migrated from https://github.com/dotnet/coreclr/commit/
cac4e2e82e63c3d892c935262cfb2b04090acae9
Vladimir Sadov [Wed, 3 May 2017 22:22:32 +0000 (15:22 -0700)]
Adding System\Runtime\CompilerServices\IsByRefLikeAttribute type (dotnet/coreclr#11369)
described in: https://github.com/dotnet/corefx/issues/19212
Commit migrated from https://github.com/dotnet/coreclr/commit/
8ba07fc124eee6a0fbb6f886e90ffd0628e86e48
Russ Keldorph [Sun, 30 Apr 2017 13:17:30 +0000 (06:17 -0700)]
Fix some static analysis warnings
Most fixes are just addressing the use of (signed) enum-typed variables
as array indices. Casting to unsigned allows us to cheaply include the
lower bound checks in the existing upper bound checks. I would prefer
to force the underlying types of enumerations to be unsigned, but that
is a relatively new C++ feature and could have broader consequences than
I want to risk at this point.
The one other fix to asmparse.cpp just suppresses a warning that, while
technically valid, is not causing a real problem. Perhaps this will get
better if/when dotnet/coreclr#2305 is addressed.
Commit migrated from https://github.com/dotnet/coreclr/commit/
1c7e1f4e0b9d338c209a8e73a00c8e9ab42b22e3
Carol Eidt [Wed, 3 May 2017 21:01:44 +0000 (14:01 -0700)]
Dump GT_IL_OFFSET value in hex
Commit migrated from https://github.com/dotnet/coreclr/commit/
7409f38936dd332d4b5c08752fc961b2827cf758