platform/upstream/dotnet/runtime.git
9 months agoThrow NotSupportedException when applying JsonObjectHandling.Populate on types with...
github-actions[bot] [Wed, 4 Oct 2023 01:37:55 +0000 (18:37 -0700)]
Throw NotSupportedException when applying JsonObjectHandling.Populate on types with parameterized constructors. (#92947)

Co-authored-by: Eirik Tsarpalis <eirik.tsarpalis@gmail.com>
9 months agoCI: runtime-wasm-perf: disable for PRs (#92977)
Ankit Jain [Wed, 4 Oct 2023 01:28:29 +0000 (21:28 -0400)]
CI: runtime-wasm-perf: disable for PRs (#92977)

9 months agoUpdate EventPipeEventDispatcher.cs (#92912)
github-actions[bot] [Tue, 3 Oct 2023 19:45:25 +0000 (12:45 -0700)]
Update EventPipeEventDispatcher.cs (#92912)

Co-authored-by: David Mason <davmason@microsoft.com>
9 months ago[release/8.0][wasm] Use intended ports when running `DevServer` (#92906)
Ankit Jain [Tue, 3 Oct 2023 19:42:56 +0000 (15:42 -0400)]
[release/8.0][wasm] Use intended ports when running `DevServer` (#92906)

* [wasm] Ignore empty `$ASPNETCORE_URLS`

* [wasm] DevServer: honor urls specified in the options

* [wasm] CI: Don't trigger non-wbt jobs on wasm-app-host changes

* CI: don't trigger wasm runtime tests on wasm-app-host changes

* [wasm] wasmbrowser - change the default webserver port to 0, to randomly select a port

9 months ago[release/8.0] Update dependencies from dotnet/cecil dotnet/hotreload-utils (#92932)
dotnet-maestro[bot] [Tue, 3 Oct 2023 17:30:41 +0000 (10:30 -0700)]
[release/8.0] Update dependencies from dotnet/cecil dotnet/hotreload-utils (#92932)

* Update dependencies from https://github.com/dotnet/cecil build 20231002.1

Microsoft.DotNet.Cecil
 From Version 0.11.4-alpha.23476.1 -> To Version 0.11.4-alpha.23502.1

* Update dependencies from https://github.com/dotnet/hotreload-utils build 20231002.1

Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
 From Version 8.0.0-alpha.0.23475.1 -> To Version 8.0.0-alpha.0.23502.1

---------

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
9 months agoUpdate dependencies from https://github.com/dotnet/source-build-externals build 20231...
dotnet-maestro[bot] [Tue, 3 Oct 2023 17:30:29 +0000 (10:30 -0700)]
Update dependencies from https://github.com/dotnet/source-build-externals build 20231002.1 (#92935)

Microsoft.SourceBuild.Intermediate.source-build-externals
 From Version 8.0.0-alpha.1.23475.1 -> To Version 8.0.0-alpha.1.23502.1

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
9 months ago[release/8.0] [wasm] Endian fix for Webcil (#92495)
github-actions[bot] [Tue, 3 Oct 2023 17:28:26 +0000 (10:28 -0700)]
[release/8.0] [wasm] Endian fix for Webcil (#92495)

* [wasm] Endian fix for Webcil

'dotnet new blazorwasm' command failed on s390x and was throwing a not implemented exception

The issue was with with the WebCil writer and reader, specific endianness conversions relating to the webcil payload were not implemented for big endian machines.

We considered fixing the generic implementation, but there were only two structures in use: WebcilHeader and WebcilSectionHeader, so it was easier to handle them explicitly.

* Fix infinite recursion

* rename var

---------

Co-authored-by: Sanjam Panda <sanjam.panda@ibm.com>
Co-authored-by: Aleksey Kliger (λgeek) <alklig@microsoft.com>
9 months agoMake config binding gen incremental (#89587) (#92730)
Layomi Akinrinade [Tue, 3 Oct 2023 17:07:13 +0000 (10:07 -0700)]
Make config binding gen incremental (#89587) (#92730)

* Make config binding gen incremental

* Iterate on implementation

* Add incremental tests & driver

* Make incremental tests pass and revert functional regression

* Address failing tests

* Make tests pass

* Suppress diagnostic

* Address feedback on diag info creation

* Refactor member access expr parsing to indicate assumptions

* Address feedback & do misc clean up

* Adjust model to minimize baseline diff / misc clean up

Co-authored-by: Carlos Sánchez López <1175054+carlossanlop@users.noreply.github.com>
9 months ago[release/8.0] Update dependencies from dotnet/roslyn (#92503)
dotnet-maestro[bot] [Tue, 3 Oct 2023 02:39:16 +0000 (19:39 -0700)]
[release/8.0] Update dependencies from dotnet/roslyn (#92503)

* Update dependencies from https://github.com/dotnet/roslyn build 20230922.3

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23472.2 -> To Version 4.8.0-3.23472.3

* Update dependencies from https://github.com/dotnet/roslyn build 20230922.4

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23472.2 -> To Version 4.8.0-3.23472.4

* Update dependencies from https://github.com/dotnet/roslyn build 20230922.5

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23472.2 -> To Version 4.8.0-3.23472.5

* Update dependencies from https://github.com/dotnet/roslyn build 20230922.6

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23472.2 -> To Version 4.8.0-3.23472.6

* Update dependencies from https://github.com/dotnet/roslyn build 20230922.7

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23472.2 -> To Version 4.8.0-3.23472.7

* Update dependencies from https://github.com/dotnet/roslyn build 20230922.8

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23472.2 -> To Version 4.8.0-3.23472.8

* Update dependencies from https://github.com/dotnet/roslyn build 20230922.9

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23472.2 -> To Version 4.8.0-3.23472.9

* Update dependencies from https://github.com/dotnet/roslyn build 20230922.10

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23472.2 -> To Version 4.8.0-3.23472.10

* Update dependencies from https://github.com/dotnet/roslyn build 20230923.1

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23472.2 -> To Version 4.8.0-3.23473.1

* Update dependencies from https://github.com/dotnet/roslyn build 20230923.2

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23472.2 -> To Version 4.8.0-3.23473.2

* Update dependencies from https://github.com/dotnet/roslyn build 20230923.3

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23472.2 -> To Version 4.8.0-3.23473.3

* Update dependencies from https://github.com/dotnet/roslyn build 20230923.4

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23472.2 -> To Version 4.8.0-3.23473.4

* Update dependencies from https://github.com/dotnet/roslyn build 20230924.1

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23472.2 -> To Version 4.8.0-3.23474.1

* Update dependencies from https://github.com/dotnet/roslyn build 20230924.2

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23472.2 -> To Version 4.8.0-3.23474.2

* Update dependencies from https://github.com/dotnet/roslyn build 20230924.3

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23472.2 -> To Version 4.8.0-3.23474.3

* Update dependencies from https://github.com/dotnet/roslyn build 20230925.1

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23472.2 -> To Version 4.8.0-3.23475.1

* Update dependencies from https://github.com/dotnet/roslyn build 20230925.2

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23472.2 -> To Version 4.8.0-3.23475.2

* Update dependencies from https://github.com/dotnet/roslyn build 20230925.3

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23472.2 -> To Version 4.8.0-3.23475.3

* Update dependencies from https://github.com/dotnet/roslyn build 20230925.4

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23472.2 -> To Version 4.8.0-3.23475.4

* Update dependencies from https://github.com/dotnet/roslyn build 20230925.5

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23472.2 -> To Version 4.8.0-3.23475.5

* Update dependencies from https://github.com/dotnet/roslyn build 20230925.6

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23472.2 -> To Version 4.8.0-3.23475.6

* Update dependencies from https://github.com/dotnet/roslyn build 20230925.7

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23472.2 -> To Version 4.8.0-3.23475.7

* Update dependencies from https://github.com/dotnet/roslyn build 20230925.8

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23472.2 -> To Version 4.8.0-3.23475.8

* Update dependencies from https://github.com/dotnet/roslyn build 20230925.10

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23472.2 -> To Version 4.8.0-3.23475.10

* Update dependencies from https://github.com/dotnet/roslyn build 20230926.3

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23472.2 -> To Version 4.8.0-3.23476.3

* Update dependencies from https://github.com/dotnet/roslyn build 20230926.6

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23472.2 -> To Version 4.8.0-3.23476.6

* Small refactor to BuildElement to address NRT changes

* Update dependencies from https://github.com/dotnet/roslyn build 20230926.13

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23472.2 -> To Version 4.8.0-3.23476.13

* Update dependencies from https://github.com/dotnet/roslyn build 20230926.14

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23472.2 -> To Version 4.8.0-3.23476.14

* Update dependencies from https://github.com/dotnet/roslyn build 20230926.15

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23472.2 -> To Version 4.8.0-3.23476.15

* Update dependencies from https://github.com/dotnet/roslyn build 20230926.21

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23472.2 -> To Version 4.8.0-3.23476.21

* Update dependencies from https://github.com/dotnet/roslyn build 20230926.22

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23472.2 -> To Version 4.8.0-3.23476.22

* Update dependencies from https://github.com/dotnet/roslyn build 20230927.1

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23472.2 -> To Version 4.8.0-3.23477.1

* Update dependencies from https://github.com/dotnet/roslyn build 20230927.4

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23472.2 -> To Version 4.8.0-3.23477.4

* Update dependencies from https://github.com/dotnet/roslyn build 20230928.3

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23472.2 -> To Version 4.8.0-3.23478.3

* Update dependencies from https://github.com/dotnet/roslyn build 20230928.4

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23472.2 -> To Version 4.8.0-3.23478.4

* Update dependencies from https://github.com/dotnet/roslyn build 20231001.1

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23472.2 -> To Version 4.8.0-3.23501.1

---------

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Levi Broderick <levib@microsoft.com>
Co-authored-by: Fred Silberberg <frsilb@microsoft.com>
9 months agofix https://github.com/dotnet/runtime/issues/92713 (#92890)
github-actions[bot] [Tue, 3 Oct 2023 02:35:48 +0000 (19:35 -0700)]
fix https://github.com/dotnet/runtime/issues/92713 (#92890)

Co-authored-by: pavelsavara <pavel.savara@gmail.com>
9 months ago[release/8.0] [browser] Remove duplicated marshaling of return value for JSExport...
github-actions[bot] [Tue, 3 Oct 2023 02:35:29 +0000 (19:35 -0700)]
[release/8.0] [browser] Remove duplicated marshaling of return value for JSExport (#92886)

* Remove duplicated marshaling of return value for JSExport

* Move unmarshal and return value marshal into try block

---------

Co-authored-by: Marek Fišera <mara@neptuo.com>
9 months agoChanges from https://github.com/dotnet/runtime/pull/92630 (#92753)
Ilona Tomkowicz [Tue, 3 Oct 2023 02:34:52 +0000 (04:34 +0200)]
Changes from https://github.com/dotnet/runtime/pull/92630 (#92753)

9 months agoUpdate dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimizati...
dotnet-maestro[bot] [Fri, 29 Sep 2023 23:38:07 +0000 (16:38 -0700)]
Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build 20230928.3 (#92816)

optimization.linux-arm64.MIBC.Runtime , optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-arm64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime , optimization.PGO.CoreCLR
 From Version 1.0.0-prerelease.23477.3 -> To Version 1.0.0-prerelease.23478.3

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
9 months agoUpdate dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimizati...
dotnet-maestro[bot] [Fri, 29 Sep 2023 01:17:11 +0000 (18:17 -0700)]
Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build 20230927.3 (#92762)

optimization.linux-arm64.MIBC.Runtime , optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-arm64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime , optimization.PGO.CoreCLR
 From Version 1.0.0-prerelease.23471.3 -> To Version 1.0.0-prerelease.23477.3

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
9 months agoUpdate dependencies from `dotnet/installer` (#92795)
Ankit Jain [Fri, 29 Sep 2023 00:59:07 +0000 (20:59 -0400)]
Update dependencies from `dotnet/installer` (#92795)

Updating 'Microsoft.Dotnet.Sdk.Internal': '8.0.100-rtm.23477.25' => '8.0.100-rtm.23478.7' (from build '20230928.7' of 'https://github.com/dotnet/installer')

9 months ago[release/8.0] Bring back CopyOutputSymbolsToPublishDirectory (#92369)
github-actions[bot] [Fri, 29 Sep 2023 00:58:38 +0000 (17:58 -0700)]
[release/8.0] Bring back CopyOutputSymbolsToPublishDirectory (#92369)

* Bring back CopyOutputSymbolsToPublishDirectory

I accidentally removed this property from AOT compilation
when adding support for Mac dsym bundles. This change re-enables
support for suppressing debugging symbols in the output.

Fixes #92188

* Update src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Publish.targets

Co-authored-by: Michal Strehovský <MichalStrehovsky@users.noreply.github.com>
---------

Co-authored-by: Andy Gocke <andy@commentout.net>
Co-authored-by: Andy Gocke <angocke@microsoft.com>
Co-authored-by: Michal Strehovský <MichalStrehovsky@users.noreply.github.com>
9 months agoUpdate dependencies from dotnet/installer (#92745)
Ankit Jain [Thu, 28 Sep 2023 20:53:01 +0000 (16:53 -0400)]
Update dependencies from dotnet/installer (#92745)

Updating 'Microsoft.Dotnet.Sdk.Internal': '8.0.100-rc.2.23470.7' => '8.0.100-rtm.23477.25' (from build '202309
27.25' of 'https://github.com/dotnet/installer')

9 months ago[wasm] WBT: Update skiasharp reference (#92747)
Ankit Jain [Thu, 28 Sep 2023 01:34:51 +0000 (21:34 -0400)]
[wasm] WBT: Update skiasharp reference (#92747)

`blz_deploy_on_build_Debug_True_npl3f0nk_qee.csproj : error NU1903: Package 'SkiaSharp' 2.88.4-preview.76 has a known high severity vulnerability`

9 months ago[release/8.0] Update dependencies from dotnet/cecil dotnet/emsdk (#92702)
dotnet-maestro[bot] [Thu, 28 Sep 2023 00:20:26 +0000 (17:20 -0700)]
[release/8.0] Update dependencies from dotnet/cecil dotnet/emsdk (#92702)

* Update dependencies from https://github.com/dotnet/cecil build 20230926.1

Microsoft.DotNet.Cecil
 From Version 0.11.4-alpha.23468.2 -> To Version 0.11.4-alpha.23476.1

* Update dependencies from https://github.com/dotnet/emsdk build 20230927.1

Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport
 From Version 8.0.0-rtm.23475.3 -> To Version 8.0.0-rtm.23477.1

* [wasm] WBT: Update skiasharp reference

`blz_deploy_on_build_Debug_True_npl3f0nk_qee.csproj : error NU1903: Package 'SkiaSharp' 2.88.4-preview.76 has a known high severity vulnerability`

---------

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Ankit Jain <radical@gmail.com>
9 months ago[release/8.0] Put HasNativeCodeReJITAware into GetFunctionAddress (#92665)
github-actions[bot] [Wed, 27 Sep 2023 22:38:12 +0000 (15:38 -0700)]
[release/8.0] Put HasNativeCodeReJITAware into GetFunctionAddress (#92665)

* Put HasNativeCodeReJITAware into GetFunctionAddress

* get rid of unused code

* reverting GetFunctionAddress to previous behavior

* removing if statement

* clarify method names

* add comments

* use BreakpointData.codeStartAddress

* dac cast

* address code review

* the method has not been jitted yet

---------

Co-authored-by: Mikelle <mirogers@microsoft.com>
9 months ago[release/8.0] Remove all PGO assets except for the runtime PGO archive. (#92735)
github-actions[bot] [Wed, 27 Sep 2023 19:14:48 +0000 (12:14 -0700)]
[release/8.0] Remove all PGO assets except for the runtime PGO archive. (#92735)

* Remove all PGO assets except for the runtime PGO archive.

* Don't produce a NuGet package for the runtime pack when PGO instrumenting

---------

Co-authored-by: Jeremy Koritzinsky <jekoritz@microsoft.com>
Co-authored-by: Jeremy Koritzinsky <jkoritzinsky@gmail.com>
9 months ago[release/8.0] Fix LLVMAOT Mono runtime variant official build to produce correctly...
github-actions[bot] [Wed, 27 Sep 2023 19:13:53 +0000 (12:13 -0700)]
[release/8.0] Fix LLVMAOT Mono runtime variant official build to produce correctly named runtime packs (#92737)

* Fix LLVMAOT Mono runtime variant official build to produce correctly named runtime packs

In https://github.com/dotnet/runtime/commit/75ee623b8f0350a4b4be86fa71745a74beb059d1 the condition in src/installer/pkg/sfx/Microsoft.NETCore.App/Microsoft.NETCore.App.Runtime.props got changed from checking `MonoBundleLLVMOptimizer` to `MonoAOTEnableLLVM` but we weren't setting that property in runtime-official.yml so both jobs produced runtime packs with the same suffix, resulting in the artifact uploads randomly overwriting each other.

* Fix more places that need MonoAOTEnableLLVM=true

---------

Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
9 months ago[release/8.0] Make CoreCLR/NativeAOT assembly compile with .subsections_via_symbols...
github-actions[bot] [Wed, 27 Sep 2023 16:27:17 +0000 (09:27 -0700)]
[release/8.0] Make CoreCLR/NativeAOT assembly compile with .subsections_via_symbols on Apple platforms (#92544)

* Make CoreCLR/NativeAOT assembly compile with .subsections_via_symbols on Apple platforms

* Fix build with LSE_INSTRUCTIONS_ENABLED_BY_DEFAULT

---------

Co-authored-by: Filip Navara <navara@emclient.com>
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
9 months agodefine bool as Interop.BOOL to prevent upper bytes setting native bool (#92681)
github-actions[bot] [Wed, 27 Sep 2023 10:13:21 +0000 (03:13 -0700)]
define bool as Interop.BOOL to prevent upper bytes setting native bool (#92681)

Co-authored-by: yowl <scott.waye@hubse.com>
9 months ago[release/8.0] JIT: Fixed containment of STOREIND of HW intrinsics ConvertTo*/Extract...
github-actions[bot] [Wed, 27 Sep 2023 10:13:09 +0000 (03:13 -0700)]
[release/8.0] JIT: Fixed containment of STOREIND of HW intrinsics ConvertTo*/Extract* (#92513)

* Added OperIsHWIntrinsicSIMDScalar. Do not remove CAST on SIMD scalar operations for stores.

* Minor cleanup

* Minor cleanup

* Feedback

* Added test case

* Update Runtime_92349.cs

* Update Runtime_92349.cs

* Update Runtime_92349.cs

* Update Runtime_92349.cs

* JIT: Fix containment of extract intrinsics as STOREIND sources

Fix #92590

---------

Co-authored-by: TIHan <lol.tihan@gmail.com>
Co-authored-by: Jakob Botsch Nielsen <jakob.botsch.nielsen@gmail.com>
9 months ago[release/8.0][wasm] Fix regressed file sizes for blazor (#92627)
Ankit Jain [Wed, 27 Sep 2023 02:45:35 +0000 (22:45 -0400)]
[release/8.0][wasm] Fix regressed file sizes for blazor (#92627)

* [wasm] Add getters for __indirect_function_table, and wasmMemory

.. so that can work even if they get renamed during minimization.

* [wasm] build: Revert to older behavior for WasmNativeStrip

The earlier change was done in 678fd6a73756f8438be115898cdd4fe0500e3d18,
which changed to pass `-g` to the link step also. But that resulted in
increased native file sizes.

Changed sizes for the `minimum blazor template - publish` scenario:

```
                                                          | Last rc1 run     | With the change
----------------------------------------------------------|----------------- |------------------
SOD - Minimum Blazor Template - Publish                   |8590723.000 bytes |7889806.000 bytes
Total Uncompressed _framework                             |4304274.000 bytes |4202273.000 bytes
pub/wwwroot/_framework/dotnet.js                          |35722.000 bytes   |35838.000 bytes
pub/wwwroot/_framework/dotnet.native.8.0.0-VERSION.js     |239307.000 bytes  |134566.000 bytes
pub/wwwroot/_framework/dotnet.native.wasm                 |1174394.000 bytes |1148841.000 bytes
pub/wwwroot/_framework/dotnet.runtime.8.0.0-VERSION.js    |221356.000 bytes  |221712.000 bytes
```

* [wasm] cleanup corresponding tests

* [wasm] Remove WasmNativeStrip from wasm.proj as it will have no effect

9 months ago[release/8.0] Update dependencies from dotnet/emsdk dotnet/hotreload-utils (#92606)
dotnet-maestro[bot] [Tue, 26 Sep 2023 21:52:34 +0000 (14:52 -0700)]
[release/8.0] Update dependencies from dotnet/emsdk dotnet/hotreload-utils (#92606)

* Update dependencies from https://github.com/dotnet/emsdk build 20230925.3

Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport
 From Version 8.0.0-rtm.23473.1 -> To Version 8.0.0-rtm.23475.3

* Update dependencies from https://github.com/dotnet/hotreload-utils build 20230925.1

Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
 From Version 8.0.0-alpha.0.23461.1 -> To Version 8.0.0-alpha.0.23475.1

---------

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
9 months agoUpdate dependencies from https://github.com/dotnet/source-build-externals build 20230...
dotnet-maestro[bot] [Tue, 26 Sep 2023 21:04:51 +0000 (14:04 -0700)]
Update dependencies from https://github.com/dotnet/source-build-externals build 20230925.1 (#92641)

Microsoft.SourceBuild.Intermediate.source-build-externals
 From Version 8.0.0-alpha.1.23471.2 -> To Version 8.0.0-alpha.1.23475.1

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
9 months agoMerge pull request #92515 from dotnet-maestro-bot/merge/release/8.0-rc2-to-release/8.0
Carlos Sánchez López [Mon, 25 Sep 2023 20:28:34 +0000 (13:28 -0700)]
Merge pull request #92515 from dotnet-maestro-bot/merge/release/8.0-rc2-to-release/8.0

[automated] Merge branch 'release/8.0-rc2' => 'release/8.0'

9 months agoMerge branch 'release/8.0' into merge/release/8.0-rc2-to-release/8.0
Carlos Sánchez López [Mon, 25 Sep 2023 18:13:00 +0000 (11:13 -0700)]
Merge branch 'release/8.0' into merge/release/8.0-rc2-to-release/8.0

9 months agoUpdate dependencies from https://github.com/dotnet/emsdk build 20230923.1 (#92532)
dotnet-maestro[bot] [Mon, 25 Sep 2023 16:11:14 +0000 (11:11 -0500)]
Update dependencies from https://github.com/dotnet/emsdk build 20230923.1 (#92532)

Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport
 From Version 8.0.0-rtm.23470.1 -> To Version 8.0.0-rtm.23473.1

Dependency coherency updates

runtime.linux-arm64.Microsoft.NETCore.Runtime.ObjWriter,runtime.linux-x64.Microsoft.NETCore.Runtime.ObjWriter,runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.ObjWriter,runtime.linux-musl-x64.Microsoft.NETCore.Runtime.ObjWriter,runtime.win-arm64.Microsoft.NETCore.Runtime.ObjWriter,runtime.win-x64.Microsoft.NETCore.Runtime.ObjWriter,runtime.osx-arm64.Microsoft.NETCore.Runtime.ObjWriter,runtime.osx-x64.Microsoft.NETCore.Runtime.ObjWriter,runtime.linux-arm64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.linux-x64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.linux-musl-x64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.win-arm64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.win-x64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.osx-arm64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.osx-x64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.linux-musl-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.linux-musl-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools
 From Version 16.0.5-alpha.1.23423.1 -> To Version 16.0.5-alpha.1.23472.2 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
9 months agoUpdate dependencies from https://github.com/dotnet/emsdk build 20230923.3 (#92533)
dotnet-maestro[bot] [Mon, 25 Sep 2023 15:11:41 +0000 (08:11 -0700)]
Update dependencies from https://github.com/dotnet/emsdk build 20230923.3 (#92533)

Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport
 From Version 8.0.0-rc.2.23471.3 -> To Version 8.0.0-rc.2.23473.3

Dependency coherency updates

runtime.linux-arm64.Microsoft.NETCore.Runtime.ObjWriter,runtime.linux-x64.Microsoft.NETCore.Runtime.ObjWriter,runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.ObjWriter,runtime.linux-musl-x64.Microsoft.NETCore.Runtime.ObjWriter,runtime.win-arm64.Microsoft.NETCore.Runtime.ObjWriter,runtime.win-x64.Microsoft.NETCore.Runtime.ObjWriter,runtime.osx-arm64.Microsoft.NETCore.Runtime.ObjWriter,runtime.osx-x64.Microsoft.NETCore.Runtime.ObjWriter,runtime.linux-arm64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.linux-x64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.linux-musl-x64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.win-arm64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.win-x64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.osx-arm64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.osx-x64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.linux-musl-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.linux-musl-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools
 From Version 16.0.5-alpha.1.23423.1 -> To Version 16.0.5-alpha.1.23472.2 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
10 months agoUpdate dependencies from https://github.com/dotnet/roslyn-analyzers build 20230922...
dotnet-maestro[bot] [Sat, 23 Sep 2023 02:05:43 +0000 (19:05 -0700)]
Update dependencies from https://github.com/dotnet/roslyn-analyzers build 20230922.1 (#92499)

Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
 From Version 3.11.0-beta1.23468.1 -> To Version 3.11.0-beta1.23472.1

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
10 months ago[release/8.0-rc2] `IDispatch` should accept `HRESULT` as valuetype (#92494)
github-actions[bot] [Sat, 23 Sep 2023 02:05:19 +0000 (19:05 -0700)]
[release/8.0-rc2] `IDispatch` should accept `HRESULT` as valuetype (#92494)

* IDispatch should accept HRESULT as valuetype

This is a regression from .NET Framework.
The current behavior has existed since
IDispatch was introduced into .NET Core.
Added tests for the current behavior.

* Ensure vtables line up for early bound.

* Add larger comment to workaround.

* Comment

---------

Co-authored-by: Aaron R Robinson <arobins@microsoft.com>
10 months agoUpdate dependencies from https://github.com/dotnet/roslyn-analyzers build 20230922...
dotnet-maestro[bot] [Sat, 23 Sep 2023 02:05:04 +0000 (19:05 -0700)]
Update dependencies from https://github.com/dotnet/roslyn-analyzers build 20230922.1 (#92504)

Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
 From Version 3.11.0-beta1.23468.1 -> To Version 3.11.0-beta1.23472.1

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
10 months agoMerge pull request #92484 from dotnet-maestro-bot/merge/release/8.0-rc2-to-release/8.0
Carlos Sánchez López [Fri, 22 Sep 2023 20:37:18 +0000 (13:37 -0700)]
Merge pull request #92484 from dotnet-maestro-bot/merge/release/8.0-rc2-to-release/8.0

[automated] Merge branch 'release/8.0-rc2' => 'release/8.0'

10 months agoUpdate dependencies from https://github.com/dotnet/roslyn build 20230922.2 (#92488)
dotnet-maestro[bot] [Fri, 22 Sep 2023 20:04:25 +0000 (13:04 -0700)]
Update dependencies from https://github.com/dotnet/roslyn build 20230922.2 (#92488)

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23471.11 -> To Version 4.8.0-3.23472.2

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
10 months agoMerge branch 'release/8.0' into merge/release/8.0-rc2-to-release/8.0
Ankit Jain [Fri, 22 Sep 2023 17:53:59 +0000 (13:53 -0400)]
Merge branch 'release/8.0' into merge/release/8.0-rc2-to-release/8.0

10 months ago[release/8.0-rc2] Ensure Bind can handle null from GetSection (#92477)
github-actions[bot] [Fri, 22 Sep 2023 17:25:30 +0000 (10:25 -0700)]
[release/8.0-rc2] Ensure Bind can handle null from GetSection (#92477)

* Ensure Bind can handle null from GetSection

IConfiguration instances may return a null value from GetSection.
We were not handling this and would throw a NullReferenceException.

* Address feedback

* Remove Moq from ConfigBinder tests

---------

Co-authored-by: Eric StJohn <ericstj@microsoft.com>
10 months ago[release/8.0-rc2] Do not call SignalSession on invalid session IDs (#92444)
github-actions[bot] [Fri, 22 Sep 2023 17:16:16 +0000 (10:16 -0700)]
[release/8.0-rc2] Do not call SignalSession on invalid session IDs  (#92444)

* Update EventPipeEventDispatcher.cs

* Update EventPipeEventDispatcher.cs

---------

Co-authored-by: David Mason <davmason@microsoft.com>
10 months ago[release/8.0-rc2] Ensure that embedded broadcast checks the base type of the parent...
github-actions[bot] [Fri, 22 Sep 2023 17:14:27 +0000 (10:14 -0700)]
[release/8.0-rc2] Ensure that embedded broadcast checks the base type of the parent node (#92459)

* Ensure that embedded broadcast checks the base type of the parent node

* Ensure the regression test exits if AVX2 is not supported

* Also handle embedded broadcasts for mismatched memory sizes

---------

Co-authored-by: Tanner Gooding <tagoo@outlook.com>
10 months agoUpdate dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimizati...
dotnet-maestro[bot] [Fri, 22 Sep 2023 16:27:01 +0000 (09:27 -0700)]
Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build 20230921.3 (#92473)

optimization.linux-arm64.MIBC.Runtime , optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-arm64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime , optimization.PGO.CoreCLR
 From Version 1.0.0-prerelease.23465.3 -> To Version 1.0.0-prerelease.23471.3

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
10 months agoUpdate dependencies from https://github.com/dotnet/source-build-reference-packages...
dotnet-maestro[bot] [Fri, 22 Sep 2023 16:15:39 +0000 (09:15 -0700)]
Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20230921.1 (#92474)

Microsoft.SourceBuild.Intermediate.source-build-reference-packages
 From Version 8.0.0-alpha.1.23469.1 -> To Version 8.0.0-alpha.1.23471.1

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
10 months ago[release/8.0] Update dependencies from dotnet/roslyn (#92418)
dotnet-maestro[bot] [Fri, 22 Sep 2023 16:11:13 +0000 (09:11 -0700)]
[release/8.0] Update dependencies from dotnet/roslyn (#92418)

* Update dependencies from https://github.com/dotnet/roslyn build 20230921.3

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23471.2 -> To Version 4.8.0-3.23471.3

* Update dependencies from https://github.com/dotnet/roslyn build 20230921.4

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23471.2 -> To Version 4.8.0-3.23471.4

* Update dependencies from https://github.com/dotnet/roslyn build 20230921.5

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23471.2 -> To Version 4.8.0-3.23471.5

* Update dependencies from https://github.com/dotnet/roslyn build 20230921.6

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23471.2 -> To Version 4.8.0-3.23471.6

* Update dependencies from https://github.com/dotnet/roslyn build 20230921.7

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23471.2 -> To Version 4.8.0-3.23471.7

* Update dependencies from https://github.com/dotnet/roslyn build 20230921.9

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23471.2 -> To Version 4.8.0-3.23471.9

* Update dependencies from https://github.com/dotnet/roslyn build 20230921.10

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23471.2 -> To Version 4.8.0-3.23471.10

* Update dependencies from https://github.com/dotnet/roslyn build 20230921.11

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23471.2 -> To Version 4.8.0-3.23471.11

---------

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
10 months agoUpdate dependencies from https://github.com/dotnet/emsdk build 20230921.3 (#92454)
dotnet-maestro[bot] [Fri, 22 Sep 2023 15:45:56 +0000 (08:45 -0700)]
Update dependencies from https://github.com/dotnet/emsdk build 20230921.3 (#92454)

Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport
 From Version 8.0.0-rc.2.23469.4 -> To Version 8.0.0-rc.2.23471.3

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
10 months agoMerge pull request #92401 from dotnet-maestro-bot/merge/release/8.0-rc2-to-release/8.0
Carlos Sánchez López [Fri, 22 Sep 2023 15:44:55 +0000 (08:44 -0700)]
Merge pull request #92401 from dotnet-maestro-bot/merge/release/8.0-rc2-to-release/8.0

[automated] Merge branch 'release/8.0-rc2' => 'release/8.0'

10 months agoUpdate dependencies from https://github.com/dotnet/source-build-externals build 20230...
dotnet-maestro[bot] [Fri, 22 Sep 2023 15:44:12 +0000 (10:44 -0500)]
Update dependencies from https://github.com/dotnet/source-build-externals build 20230921.2 (#92476)

Microsoft.SourceBuild.Intermediate.source-build-externals
 From Version 8.0.0-alpha.1.23469.1 -> To Version 8.0.0-alpha.1.23471.2

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
10 months ago[release/8.0-rc2] Make HostModel PEUtils always read/write little endian (#92441)
github-actions[bot] [Fri, 22 Sep 2023 03:20:42 +0000 (20:20 -0700)]
[release/8.0-rc2] Make HostModel PEUtils always read/write little endian (#92441)

* Make HostModel PEUtils always read/write little endian

* PR feeback - helper methods

---------

Co-authored-by: Elinor Fung <elfung@microsoft.com>
10 months ago[release/8.0-rc2] Address feedback and fix some TensorPrimitives issues (#92437)
github-actions[bot] [Fri, 22 Sep 2023 01:58:50 +0000 (18:58 -0700)]
[release/8.0-rc2] Address feedback and fix some TensorPrimitives issues (#92437)

* Address feedback and fix some TensorPrimitives issues

- Added a few APIs based on initial feedback: Abs (vectorized), Log2, and element-wise Max/Min{Magnitude}
- Renamed L2Normalize to Norm
- Fixed semantics of Min/MaxMagnitude to return original value rather than the absolute value
- Renamed a few helper types for consistency
- Added tests

* Add a few more uses of Tolerance

---------

Co-authored-by: Stephen Toub <stoub@microsoft.com>
10 months ago[release/8.0-rc2] [browser] Fix SIMD+EH check (#92439)
github-actions[bot] [Fri, 22 Sep 2023 01:54:40 +0000 (18:54 -0700)]
[release/8.0-rc2] [browser] Fix SIMD+EH check (#92439)

* Move simd+eh check after emcripten provided build time values

* Call cwraps.mono_wasm_abort from runtimeHelpers.abort when cwraps are ready (onRuntimeInitializedAsync)

* Assign early mono_wasm_exit and abort even earlier

* Fire feature check before awaiting wasm download, but await it after.

* Whitespaces

---------

Co-authored-by: Marek Fišera <mara@neptuo.com>
10 months agoMerge branch 'release/8.0' into merge/release/8.0-rc2-to-release/8.0
Carlos Sánchez López [Fri, 22 Sep 2023 01:50:25 +0000 (18:50 -0700)]
Merge branch 'release/8.0' into merge/release/8.0-rc2-to-release/8.0

10 months ago[release/8.0-rc2] Bump downlevel version to 7.0.12 (#92419)
Steve Pfister [Thu, 21 Sep 2023 22:37:35 +0000 (15:37 -0700)]
[release/8.0-rc2] Bump downlevel version to 7.0.12 (#92419)

Co-authored-by: Steve Pfister <steve.pfister@microsoft.com>
10 months agoJIT: Fix invalid containment of vector broadcasts (#92371)
github-actions[bot] [Thu, 21 Sep 2023 22:37:09 +0000 (15:37 -0700)]
JIT: Fix invalid containment of vector broadcasts (#92371)

The containment checks for vector broadcasts were missing a size check,
meaning that a uint broadcast could contain a ubyte/ushort indirection.
That would lead to out-of-bounds reads.

Fix #83387

Co-authored-by: Jakob Botsch Nielsen <jakob.botsch.nielsen@gmail.com>
10 months ago[release/8.0] Bump version to GA (#92305)
Carlos Sánchez López [Thu, 21 Sep 2023 19:43:26 +0000 (12:43 -0700)]
[release/8.0] Bump version to GA (#92305)

* [release/8.0] Bump version to RTM

* Add check to properly handle release/rtm naming for workloads

---------

Co-authored-by: Steve Pfister <steve.pfister@microsoft.com>
10 months ago[release/8.0-rc2] [CI][Android] Build mono runtime for Android on PRs (#92411)
github-actions[bot] [Thu, 21 Sep 2023 17:52:39 +0000 (10:52 -0700)]
[release/8.0-rc2] [CI][Android] Build mono runtime for Android on PRs (#92411)

* [CI][Android] Build mono runtime for Android on PRs

* [CI][Android] Build and run smoke tests

* Mimic ios/tvos devices job

---------

Co-authored-by: mdh1418 <mitchhwang1418@gmail.com>
10 months agoMerge pull request #92374 from dotnet-maestro-bot/merge/release/8.0-rc1-to-release/8.0
Carlos Sánchez López [Thu, 21 Sep 2023 17:49:43 +0000 (10:49 -0700)]
Merge pull request #92374 from dotnet-maestro-bot/merge/release/8.0-rc1-to-release/8.0

[automated] Merge branch 'release/8.0-rc1' => 'release/8.0'

10 months ago[release/8.0] Update dependencies from dotnet/roslyn (#92303)
dotnet-maestro[bot] [Thu, 21 Sep 2023 16:34:09 +0000 (09:34 -0700)]
[release/8.0] Update dependencies from dotnet/roslyn (#92303)

* Update dependencies from https://github.com/dotnet/roslyn build 20230919.3

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23469.1 -> To Version 4.8.0-3.23469.3

* Update dependencies from https://github.com/dotnet/roslyn build 20230919.4

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23469.1 -> To Version 4.8.0-3.23469.4

* Update dependencies from https://github.com/dotnet/roslyn build 20230919.6

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23469.1 -> To Version 4.8.0-3.23469.6

* Update dependencies from https://github.com/dotnet/roslyn build 20230919.7

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23469.1 -> To Version 4.8.0-3.23469.7

* Update dependencies from https://github.com/dotnet/roslyn build 20230919.9

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23469.1 -> To Version 4.8.0-3.23469.9

* Update dependencies from https://github.com/dotnet/roslyn build 20230919.10

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23469.1 -> To Version 4.8.0-3.23469.10

* Update dependencies from https://github.com/dotnet/roslyn build 20230919.11

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23469.1 -> To Version 4.8.0-3.23469.11

* Update dependencies from https://github.com/dotnet/roslyn build 20230920.1

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23469.1 -> To Version 4.8.0-3.23470.1

* Update dependencies from https://github.com/dotnet/roslyn build 20230920.2

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23469.1 -> To Version 4.8.0-3.23470.2

* Update dependencies from https://github.com/dotnet/roslyn build 20230920.4

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23469.1 -> To Version 4.8.0-3.23470.4

* Update dependencies from https://github.com/dotnet/roslyn build 20230920.5

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23469.1 -> To Version 4.8.0-3.23470.5

* Update dependencies from https://github.com/dotnet/roslyn build 20230920.7

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23469.1 -> To Version 4.8.0-3.23470.7

* Update dependencies from https://github.com/dotnet/roslyn build 20230920.8

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23469.1 -> To Version 4.8.0-3.23470.8

* Update dependencies from https://github.com/dotnet/roslyn build 20230920.10

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23469.1 -> To Version 4.8.0-3.23470.10

* Update dependencies from https://github.com/dotnet/roslyn build 20230920.6

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23469.1 -> To Version 4.8.0-3.23470.6

* Update dependencies from https://github.com/dotnet/roslyn build 20230920.12

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23469.1 -> To Version 4.8.0-3.23470.12

* Update dependencies from https://github.com/dotnet/roslyn build 20230921.1

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23469.1 -> To Version 4.8.0-3.23471.1

* Update dependencies from https://github.com/dotnet/roslyn build 20230921.2

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23469.1 -> To Version 4.8.0-3.23471.2

---------

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
10 months agoFix the VN for xor operation (#92372)
github-actions[bot] [Thu, 21 Sep 2023 15:35:35 +0000 (08:35 -0700)]
Fix the VN for xor operation (#92372)

Co-authored-by: Kunal Pathak <Kunal.Pathak@microsoft.com>
10 months ago[release/8.0] Properly handle debugger-enumerating interior pointers and enregistered...
github-actions[bot] [Thu, 21 Sep 2023 09:25:17 +0000 (02:25 -0700)]
[release/8.0] Properly handle debugger-enumerating interior pointers and enregistered refs (#92360)

* Fix issue with enregistered values

* Fix assert and enregistered ref reporting

* Fix issue from merge

---------

Co-authored-by: Lee Culver <leculver@microsoft.com>
Co-authored-by: Juan Sebastian Hoyos Ayala <juan.hoyos@microsoft.com>
Co-authored-by: Juan Hoyos <19413848+hoyosjs@users.noreply.github.com>
10 months ago[release/8.0-rc2] Fixes for LLVM AOT on Windows from @lateralusX (#92365)
github-actions[bot] [Thu, 21 Sep 2023 09:24:45 +0000 (02:24 -0700)]
[release/8.0-rc2] Fixes for LLVM AOT on Windows from @lateralusX (#92365)

* Fixes for LLVM AOT on Windows from @lateralusX

* fix HOST/TARGET issue

---------

Co-authored-by: Jo Shields <directhex@apebox.org>
10 months agoAdd missing case for constrained gsharedvt call. (#92347)
github-actions[bot] [Thu, 21 Sep 2023 09:24:03 +0000 (02:24 -0700)]
Add missing case for constrained gsharedvt call. (#92347)

https://github.com/dotnet/runtime/commit/1b788f4dc3e3a8829488e52c032ad6a70671e070
added a new value to our MonoRgctxInfoType enum type, but appears
that all cases where not full adjusted. Running System.Buffers tests
in full AOT hits the assert in info_equal about missing case,
https://github.com/dotnet/runtime/blob/0dc5903679606b072adac70a268cdb77d1147b3e/src/mono/mono/mini/mini-generic-sharing.c#L2908.

This commit adds the new enum value and align handling similar to other cases added
by that commit.

Co-authored-by: lateralusX <lateralusx.github@gmail.com>
10 months agoMerge pull request #92325 from dotnet-maestro-bot/merge/release/8.0-rc2-to-release/8.0
Carlos Sánchez López [Thu, 21 Sep 2023 09:20:31 +0000 (02:20 -0700)]
Merge pull request #92325 from dotnet-maestro-bot/merge/release/8.0-rc2-to-release/8.0

[automated] Merge branch 'release/8.0-rc2' => 'release/8.0'

10 months ago[wasm] InstallWorkloadFromArtifacts: correctly handle rtm versions
Ankit Jain [Wed, 20 Sep 2023 20:41:07 +0000 (16:41 -0400)]
[wasm] InstallWorkloadFromArtifacts: correctly handle rtm versions

In case of a version like `8.0.100-rtm.23470.1`, we incorrectly
extracted `-rtm.23470` instead of `-rtm`, which resulted in trying to
install package named `Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100-rtm.23470` instead of `Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100-rtm`.

10 months agoUpdate dependencies from dotnet/emsdk
Ankit Jain [Wed, 20 Sep 2023 23:15:45 +0000 (19:15 -0400)]
Update dependencies from dotnet/emsdk

Picking the update from https://github.com/dotnet/runtime/pull/92320 to
here, to avoid the overlap.

10 months ago[release/8.0-rc2][wasm] Add a dependency on dotnet/installer to get the latest (...
Ankit Jain [Wed, 20 Sep 2023 22:53:04 +0000 (18:53 -0400)]
[release/8.0-rc2][wasm] Add a dependency on dotnet/installer to get the latest (#92353)

* [wasm] Add a dependency on dotnet/installer to get the latest

And update version from `.NET 8.0.1xx SDK` channel.

(cherry picked from commit c821c361321d710aae7a24a6293a876ddcbf374e)

* [wasm] WBT: Use --skip-sign-check when installing workloads

* [wasm] WBT: Update blazor tests to track changed path for Pages

.. from `Pages/` to `Components/Pages/`.

10 months ago[release/8.0-rc1] [release/8.0] Fix wasi build. (#92368)
github-actions[bot] [Wed, 20 Sep 2023 20:19:28 +0000 (13:19 -0700)]
[release/8.0-rc1] [release/8.0] Fix wasi build. (#92368)

* Fix wasi build.

* dummy change in wasi README to trigger a build

* dummy change in wasi to trigger a build

---------

Co-authored-by: Zoltan Varga <vargaz@gmail.com>
Co-authored-by: Ankit Jain <radical@gmail.com>
10 months agoUpdate dependencies from https://github.com/dotnet/source-build-externals build 20230...
dotnet-maestro[bot] [Wed, 20 Sep 2023 16:30:17 +0000 (09:30 -0700)]
Update dependencies from https://github.com/dotnet/source-build-externals build 20230919.1 (#92340)

Microsoft.SourceBuild.Intermediate.source-build-externals
 From Version 8.0.0-alpha.1.23468.1 -> To Version 8.0.0-alpha.1.23469.1

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
10 months agoUpdate dependencies from https://github.com/dotnet/emsdk build 20230919.4 (#92322)
dotnet-maestro[bot] [Wed, 20 Sep 2023 16:26:56 +0000 (09:26 -0700)]
Update dependencies from https://github.com/dotnet/emsdk build 20230919.4 (#92322)

Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport
 From Version 8.0.0-rc.2.23469.1 -> To Version 8.0.0-rc.2.23469.4

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
10 months ago[release/8.0-rc2] porting DATAS change back to RC2 (#92323)
Maoni Stephens [Wed, 20 Sep 2023 16:25:14 +0000 (09:25 -0700)]
[release/8.0-rc2] porting DATAS change back to RC2 (#92323)

* new synchronization mechanism for DATAS (#90726)

The current mechanism has a fundamental flaw which is the idling threads can start running at unpredictable times when they are woken up. This causes all sorts of problems. For example, when a thread gets here in gc_thread_function -

`if (n_heaps <= heap_number)`

if it's true it's supposed to wait. But its execution could be delayed so after it reads n_heaps it can stop for a while since no thread is waiting on this thread anyway... till some time later when a heap count changes happens again and it requires this thread to participating. And now this thread does the comparison and discovers that it needs to wait so it goes idle and all other threads will just be waiting for this thread to join.

Another example is it's not safe to change the heap count for a join from a larger one to a smaller one. It's fine to change from a smaller one to a larger one because all the threads participating will have to run in order for a join to finish. But if no one is waiting on a thread, it could just wake up from the event being set by the last thread joining and not run for a while. Then go back to the respin loop at a point where the color was changed and changed again! So now it thinks it can proceed with a join it does not belong to. And of course that wouldn't work.

The way threads are going idle/waking up is hard to keep track of - not only does it involve the gc_start_event and gc_idle_thread_event, it also uses WaitForGCEvent which is used by SuspendEE/RestartEE which in turn means whenever we want to call these we'd need to care about how that would affect this.

The new mechanism only uses gc_start_event and gc_idle_thread_event, but I changed gc_idle_thread_event to a per heap event. We can easily track which threads are going idling easily - whenever a thread is about to wait on the idle event, we increase the current idle_thread_count. And when we increase the heap count we only set the gc_idle_thread_event for the new heaps that are about to participate so we can deduct that many from idle_thread_count. There's a much simpler code path between "we know we don't need these threads anymore" to "these threads are at a known point" because the next time gc_start_event is set (ie, a GC is requested) we make sure to get these threads to a good known point, ie, we wait till all of them have completed increasing idle_thread_count.

Also fixed a couple of other problems that I hit while testing the new mechanism -

We are setting freeable_uoh_segment and freeable_soh_segment in decommission_heap to DECOMMISSIONED_REGION_P. And this causes us to simply lose the value for them. We should make sure we do push these to the free regions before we start changing the heap count.

We should also call background_delay_delete_uoh_segments before we start changing the heap count so we can get rid of the regions marked with heap_segment_flags_uoh_delete. If we allow these to be rearranged in equalize_promoted_bytes it means the order can change the invariant of the first region never being deleted no longer holds true and we can AV in this method.

I added an new method delay_free_segments to perform both tasks.

The accounting of generation_free_list_space is slightly off for LOH which causes us to hit assert (gen_size >= dd_fragmentation (dd)); in change_heap_count because we were not counting the loh_pad size.
I also disabled assert (free_list_space_decrease <= dd_fragmentation (dd)); for gen2 since I'm seeing this fired while I'm doing stress runs. I have yet to investigate this since I didn't want to add yet more changes to this PR.

* fixed problems with how sampling is done and how we suspend to change heap count in DATAS (#91712)

+ Moved the sample recording into when we are suspended. The way we were calculating the throughput cost was in check_heap_count (which is called right after we restart EE on heap0), we record the msl_wait_time (and reset it to 0 for soh/uoh). This is not synchronized with the allocating threads (which are already running at this point). So what can happen is the allocating threads are already accumulated more wait time which is attributed to this GC but it's not within the period we are counting for this GC (and we lose this part for the next GC). For BGC this is incorrect. If an ephemeral GC did happen before the BGC starts, we'd be adding a sample for that GC which is basically correct for that eph GC. But if an eph GC did not happen, we are just adding a random sample which is calculating the tcp as (msl wait + whatever GC that was finished before this BGC) so obviously incorrect.

+ Added gen2 sampling - this was adapted from Peter's gen2 sampling changes. This serves as a backstop in case the existing sampling doesn't ever pick gen2 GC costs. I made the following fixes -

1) changed the way we calculated the median

2) moved where this is calculated to again avoid timing issues

3) made the gen2 samples actually count instead of losing that info if we happen to sample when a gen2 didn't just occur.

+ Changed when check_heap_count is called - the previous place is right after a suspension which does not help with spacing the suspension time out (it was "suspend for GC" then "immediately suspend to change heap count"). And it caused a problem with BGC which was it always tried to change heap count when it couldn't because BGC was in progress. I changed this to be on a timeout to intentionally space the suspensions out. Now most of the time, heap count changes happen due to this time out. If we are really in a situation where GCs are happening too quickly and we return from waiting on the ee_suspend_event due to a GC started, we change the heap count right before we do a GC. So this also helps with the BGC problem.

* gen0_bricks_cleared flag needs to be propagated when we change heap count (#90457)

when we change the heap count, in heap X we get a region from heap Y and the gen0_bricks_cleared flag from Y says false but heap X says true. So when we check the bricks on heap X, we assume it’s true but it’s not.

the fix is to detect if any heap has this flag as false and if so make all heaps’ flag false (tracking which region is moved from which other heap is something we need additional recording for and it’s not really worth doing just for this)

* a logging change

---------

Co-authored-by: Maoni0 <maoni@microsoft.com>
10 months ago[release/8.0-rc1] [release/8.0] Events for IL methods without IL headers (#92317)
github-actions[bot] [Wed, 20 Sep 2023 15:10:18 +0000 (08:10 -0700)]
[release/8.0-rc1] [release/8.0] Events for IL methods without IL headers (#92317)

* Events for IL methods without IL headers

Dynamically generated methods like UnsafeAccessor
functions are marked as IL, but don't contain an IL
header. The lack of header is an indication the IL must
be generated at runtime.

* Debugger check for no IL header

* Update src/coreclr/debug/daccess/stack.cpp

Co-authored-by: Tlakaelel Axayakatl Ceja <tlakaelel.ceja@microsoft.com>
* Review feedback

* Remove redundent calls and another spot to check.

* Move header include

---------

Co-authored-by: Aaron R Robinson <arobins@microsoft.com>
Co-authored-by: Tlakaelel Axayakatl Ceja <tlakaelel.ceja@microsoft.com>
10 months agoDon't generate AddMask as it requires more explicit consideration of semantics (...
github-actions[bot] [Wed, 20 Sep 2023 06:12:45 +0000 (23:12 -0700)]
Don't generate AddMask as it requires more explicit consideration of semantics (#92308)

Co-authored-by: Tanner Gooding <tagoo@outlook.com>
Co-authored-by: Carlos Sánchez López <1175054+carlossanlop@users.noreply.github.com>
10 months agoJIT: add missing xarch RMW case (#92293)
github-actions[bot] [Wed, 20 Sep 2023 06:12:03 +0000 (23:12 -0700)]
JIT: add missing xarch RMW case (#92293)

Handle the case where we're indirectly updating a local with a value
that is not a constant.

Fixes #92218.

Co-authored-by: Andy Ayers <andya@microsoft.com>
Co-authored-by: Carlos Sánchez López <1175054+carlossanlop@users.noreply.github.com>
10 months agoFix options Validation with objects have indexers (#92311)
github-actions[bot] [Wed, 20 Sep 2023 06:11:15 +0000 (23:11 -0700)]
Fix options Validation with objects have indexers (#92311)

Co-authored-by: Tarek Mahmoud Sayed <tarekms@microsoft.com>
Co-authored-by: Carlos Sánchez López <1175054+carlossanlop@users.noreply.github.com>
10 months agoUpdate dependencies from https://github.com/dotnet/emsdk build 20230919.1 (#92306)
dotnet-maestro[bot] [Wed, 20 Sep 2023 00:12:11 +0000 (17:12 -0700)]
Update dependencies from https://github.com/dotnet/emsdk build 20230919.1 (#92306)

Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport
 From Version 8.0.0-rtm.23469.3 -> To Version 8.0.0-rc.2.23469.1

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
10 months ago[release/8.0] Update dependencies from 7 repositories (#92143)
dotnet-maestro[bot] [Tue, 19 Sep 2023 20:00:17 +0000 (13:00 -0700)]
[release/8.0] Update dependencies from 7 repositories (#92143)

* Update dependencies from https://github.com/dotnet/emsdk build 20230915.1

Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport
 From Version 8.0.0-rc.2.23463.1 -> To Version 8.0.0-rc.2.23465.1

* Update dependencies from https://github.com/dotnet/roslyn-analyzers build 20230916.2

Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
 From Version 3.11.0-beta1.23464.2 -> To Version 3.11.0-beta1.23466.2

* Update dependencies from https://github.com/dotnet/roslyn-analyzers build 20230916.2

Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
 From Version 3.11.0-beta1.23464.2 -> To Version 3.11.0-beta1.23466.2

* Update dependencies from https://github.com/dotnet/emsdk build 20230918.1

Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport
 From Version 8.0.0-rc.2.23463.1 -> To Version 8.0.0-rc.2.23468.1

* Update dependencies from https://github.com/dotnet/emsdk build 20230918.2

Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport
 From Version 8.0.0-rc.2.23463.1 -> To Version 8.0.0-rtm.23468.2

* Update dependencies from https://github.com/dotnet/roslyn-analyzers build 20230918.1

Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
 From Version 3.11.0-beta1.23464.2 -> To Version 3.11.0-beta1.23468.1

* Update dependencies from https://github.com/dotnet/cecil build 20230918.2

Microsoft.DotNet.Cecil
 From Version 0.11.4-alpha.23461.1 -> To Version 0.11.4-alpha.23468.2

* Update dependencies from https://github.com/dotnet/roslyn-analyzers build 20230918.1

Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
 From Version 3.11.0-beta1.23464.2 -> To Version 3.11.0-beta1.23468.1

* Update dependencies from https://github.com/dotnet/msquic build 20230918.1

System.Net.MsQuic.Transport
 From Version 8.0.0-alpha.1.23412.1 -> To Version 8.0.0-alpha.1.23468.1

* Update dependencies from https://github.com/dotnet/hotreload-utils build 20230918.2

Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
 From Version 8.0.0-alpha.0.23461.1 -> To Version 8.0.0-alpha.0.23468.2

* Update dependencies from https://github.com/dotnet/icu build 20230918.3

Microsoft.NETCore.Runtime.ICU.Transport
 From Version 8.0.0-rc.2.23454.2 -> To Version 8.0.0-rtm.23468.3

* Roll back icu and emsdk to rc2 builds

* Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20230919.1

Microsoft.SourceBuild.Intermediate.source-build-reference-packages
 From Version 8.0.0-alpha.1.23463.1 -> To Version 8.0.0-alpha.1.23469.1

* Update dependencies from https://github.com/dotnet/emsdk build 20230919.3

Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport
 From Version 8.0.0-rc.2.23463.1 -> To Version 8.0.0-rtm.23469.3

---------

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Carlos Sánchez López <1175054+carlossanlop@users.noreply.github.com>
Co-authored-by: Larry Ewing <lewing@microsoft.com>
10 months ago[release/8.0] Bump Microsoft.Private.IntelliSense package version (#92254)
Carlos Sánchez López [Tue, 19 Sep 2023 19:24:32 +0000 (12:24 -0700)]
[release/8.0] Bump Microsoft.Private.IntelliSense package version (#92254)

10 months agoUpdate dependencies from https://github.com/dotnet/roslyn build 20230919.1 (#92288)
dotnet-maestro[bot] [Tue, 19 Sep 2023 19:22:09 +0000 (12:22 -0700)]
Update dependencies from https://github.com/dotnet/roslyn build 20230919.1 (#92288)

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23468.4 -> To Version 4.8.0-3.23469.1

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
10 months agoUpdate Newtonsoft.Json from 13.0.1 to 13.0.3 (#92277)
Matt Thalman [Tue, 19 Sep 2023 19:00:12 +0000 (14:00 -0500)]
Update Newtonsoft.Json from 13.0.1 to 13.0.3 (#92277)

* Update Newtonsoft.Json from 13.0.1 to 13.0.3

* Update source-build-externals

* Add prebuilt exclusion

10 months ago[release/8.0] Fix downlevel build break in TensorPrimitives (#92270)
github-actions[bot] [Tue, 19 Sep 2023 16:15:33 +0000 (09:15 -0700)]
[release/8.0] Fix downlevel build break in TensorPrimitives (#92270)

* Fix downlevel build break in TensorPrimitives

* Make net6.0 Tensors use ns2.0 implementation

---------

Co-authored-by: Stephen Toub <stoub@microsoft.com>
Co-authored-by: Eric StJohn <ericstj@microsoft.com>
10 months ago[release/8.0] Update dependencies from dotnet/roslyn (#92149)
dotnet-maestro[bot] [Tue, 19 Sep 2023 16:09:48 +0000 (09:09 -0700)]
[release/8.0] Update dependencies from dotnet/roslyn (#92149)

* Update dependencies from https://github.com/dotnet/roslyn build 20230915.1

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23462.10 -> To Version 4.8.0-3.23465.1

* Update dependencies from https://github.com/dotnet/roslyn build 20230915.2

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23462.10 -> To Version 4.8.0-3.23465.2

* Update dependencies from https://github.com/dotnet/roslyn build 20230915.4

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23462.10 -> To Version 4.8.0-3.23465.4

* Update dependencies from https://github.com/dotnet/roslyn build 20230915.5

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23462.10 -> To Version 4.8.0-3.23465.5

* Use InterceptorsPreviewNamespaces instead of the InterceptorsPreview feature

* Update dependencies from https://github.com/dotnet/roslyn build 20230918.1

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23462.10 -> To Version 4.8.0-3.23468.1

* Bring back removed lines

* Add CSharpParseOption InterceptorsPreviewNamespaces feature to GeneratorTests.Helpers.cs

* Add TODO comment to remove feature

* Update dependencies from https://github.com/dotnet/roslyn build 20230918.3

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23462.10 -> To Version 4.8.0-3.23468.3

* Update dependencies from https://github.com/dotnet/roslyn build 20230918.4

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23462.10 -> To Version 4.8.0-3.23468.4

---------

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Carlos Sánchez López <1175054+carlossanlop@users.noreply.github.com>
10 months ago[release/8.0] Use strategy in StrategyBasedComWrappers.ComputeVtables (#92250)
github-actions[bot] [Tue, 19 Sep 2023 04:38:55 +0000 (21:38 -0700)]
[release/8.0] Use strategy in StrategyBasedComWrappers.ComputeVtables (#92250)

* Use strategy in StrategyBasedComWrappers.ComputeVtables

We didn't actually use the strategy object here, so users like WinForms can't actually use it.

* Update src/libraries/System.Runtime.InteropServices/src/System/Runtime/InteropServices/Marshalling/StrategyBasedComWrappers.cs

Co-authored-by: Jackson Schuster <36744439+jtschuster@users.noreply.github.com>
---------

Co-authored-by: Jeremy Koritzinsky <jekoritz@microsoft.com>
Co-authored-by: Jackson Schuster <36744439+jtschuster@users.noreply.github.com>
10 months agoLocalized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 227045...
dotnet bot [Tue, 19 Sep 2023 04:38:23 +0000 (21:38 -0700)]
Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2270458 (#92258)

10 months ago[release/8.0] Fix: Config binder generator doesn't generate code when named arguments...
github-actions[bot] [Tue, 19 Sep 2023 04:38:03 +0000 (21:38 -0700)]
[release/8.0] Fix: Config binder generator doesn't generate code when named arguments are out of order (#92257)

* Fix Named parameters bug

* Test the generator only, don't compare generated file row by row

* Add other named parameter combinatios for other overloads in the test, add test for OptionsBuilder... and ServiceCollection extensins

* Adjust line numbers with source generator updates

* Move similar code section into helper method, don't exact exact line count

* Apply feedbacks

---------

Co-authored-by: Buyaa Namnan <bunamnan@microsoft.com>
10 months ago[release/8.0] Numerics and Tensors backport (#92245)
Michael Sharp [Tue, 19 Sep 2023 01:55:53 +0000 (19:55 -0600)]
[release/8.0] Numerics and Tensors backport (#92245)

* added Bcl.Numerics

* Adding a naive implementation of various primitive tensor operations (#91228)

* Adding a naive implementation of various primitive tensor operations

* Adding tests covering the new tensor primitives APIs

* Adding tensor primitives APIs to the ref assembly

* Allow .NET Framework to build/run

* Sync TFMs between ref and src, csproj simplication and clean-up

* Apply suggestions from code review

Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com>
* Don't use var

* Fix the S.N.Tensors readme and remove the file marking it as non-shipping

---------

Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com>
Co-authored-by: Michael Sharp <51342856+michaelgsharp@users.noreply.github.com>
* Start vectorizing TensorPrimitives (#91596)

* Start vectorizing TensorPrimitives

Just does two functions to establish the files into which the rest of the implementations can be moved.

* 6 more naive methods for Tensor Primitives. (#92142)

* 6 more naive methods

* updates from pr comments

* Add remaining set of TensorPrimitives APIs for .NET 8 (#92154)

* Add remaining set of TensorPrimitives APIs for .NET 8

Adds non-vectorized implementations of:
- Max
- Min
- MaxMagnitude
- MinMagnitude
- IndexOfMax
- IndexOfMin
- IndexOfMaxMagnitude
- ConvertToHalf (only on .NET Core)
- ConvertToSingle (only on .NET Core)
- IndexOfMinMagnitude

Adds vectorized implementations of:
- Sum
- SumOfSquares
- SumOfMagnitudes
- Product
- ProductOfSums
- ProductOfDifferences

Also includes the helpers that'll make it trivial to vectorize Dot.

Beyond vectorizing the non-vectorized ones, the vectorized implementations should be improved further, including:
- Handling alignment better
- Vectorizing the remainder that doesn't fit in a vector rather than falling back to scalar

* Cleanup after previous PR, vectorize CosineSimilarity/Dot/L2Normalize/Distance, add tests

* Address PR feedback, and fix a few other issues

* Fix TensorPrimitives.CosineSimilarity to use vectorized implementations (#92204)

* Fixed duplicated code from merge.

* New Microsoft.BCL.Numerics package (#91074)

* bcl numberics library added

* bcl done

* added explicit 2.1 target

* Minor doc updates

* Apply suggestions from code review

Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com>
* fixes from PR comments

* minor csproj fixes

* fixed ref target frameworks

* minor ref csproj updates

* minor csproj updates

---------

Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com>
* Microsoft.Bcl.Numerics.Tests: fix restore failure when DotNetBuildFromSource. (#91402)

* Microsoft.Bcl.Numerics.Tests: fix restore failure when DotNetBuildFromSource.

* Use NetCoreAppCurrent.

* Try fix CI test failures.

---------

Co-authored-by: Tanner Gooding <tagoo@outlook.com>
Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com>
Co-authored-by: Stephen Toub <stoub@microsoft.com>
Co-authored-by: Tom Deseyn <tom.deseyn@gmail.com>
10 months ago[release/8.0] Update HttpClientJsonExtensions.Get.AsyncEnumerable.cs (#92199)
github-actions[bot] [Mon, 18 Sep 2023 23:54:39 +0000 (16:54 -0700)]
[release/8.0] Update HttpClientJsonExtensions.Get.AsyncEnumerable.cs (#92199)

* Update HttpClientJsonExtensions.Get.AsyncEnumerable.cs

reuse method from ReadFromJsonAsAsyncEnumerable

* fix trailing space

* feat: add test case

* Update HttpClientJsonExtensions.Get.AsyncEnumerable.cs

add httpClient null check

* Update HttpClientJsonExtensions.Get.AsyncEnumerable.cs

fix trailing space style

* Update src/libraries/System.Net.Http.Json/tests/FunctionalTests/HttpClientJsonExtensionsTests.cs

Co-authored-by: Eirik Tsarpalis <eirik.tsarpalis@gmail.com>
* refine updates

---------

Co-authored-by: Weihan Li <weihanli@outlook.com>
Co-authored-by: Eirik Tsarpalis <eirik.tsarpalis@gmail.com>
10 months ago[release/8.0] Make src gen for property setters consistent with reflection (#92167)
github-actions[bot] [Mon, 18 Sep 2023 19:50:42 +0000 (12:50 -0700)]
[release/8.0] Make src gen for property setters consistent with reflection (#92167)

* Make src gen for property setters consistent with reflection

* Don't default value during initialization

* Remove unnecessary bang operator

* Don't default a property when it is a collection or child type

* Simply use of new variable; add to test

* Review feedback

---------

Co-authored-by: Steve Harter <steveharter@users.noreply.github.com>
10 months ago[release/8.0] Fix wasi build. (#92232)
github-actions[bot] [Mon, 18 Sep 2023 18:43:24 +0000 (11:43 -0700)]
[release/8.0] Fix wasi build. (#92232)

* Fix wasi build.

* dummy change in wasi README to trigger a build

* dummy change in wasi to trigger a build

---------

Co-authored-by: Zoltan Varga <vargaz@gmail.com>
Co-authored-by: Ankit Jain <radical@gmail.com>
10 months ago[release/8.0] Check if loop body occured before loopTop and if so unmark alignment...
github-actions[bot] [Mon, 18 Sep 2023 18:31:42 +0000 (11:31 -0700)]
[release/8.0] Check if loop body occured before loopTop and if so unmark alignment (#91918)

* Check if loop body occured before loopTop"

* Check if bbNatLoopNum is not NOT_IN_LOOP

* review feedback

---------

Co-authored-by: Kunal Pathak <Kunal.Pathak@microsoft.com>
10 months ago[release/8.0] JIT: Initialize jitstdout lazily (#92212)
Jakob Botsch Nielsen [Mon, 18 Sep 2023 17:24:19 +0000 (19:24 +0200)]
[release/8.0] JIT: Initialize jitstdout lazily (#92212)

* JIT: Initialize jitstdout lazily

Avoid duplicating a handle and doing several I/O operations on the
startup path. Fixes #91856 as a side effect.

* Fix jitShutdown

* Add volatile

* CSE

* Ensure jitstdout() is not used eagerly

* Move comment, fix printf -> jitprintf

* Clean up

10 months agoJIT: Extract all side effects of the index in optRemoveRangeCheck (#92210)
github-actions[bot] [Mon, 18 Sep 2023 17:23:48 +0000 (10:23 -0700)]
JIT: Extract all side effects of the index in optRemoveRangeCheck (#92210)

optRemoveRangeCheck extracts only GTF_ASG from the bounds check. If the
BOUNDS_CHECK is complex, that results in silently dropping side effects
on the floor (see the example case).

The ideal fix is that we should always extract all side effects from the
index and length operands, however this has large regressions because
the length typically has an ARR_LENGTH that we then extract. This PR
instead has a surgical fix for the problem case that can be backported
to .NET 8. It extracts all side effects from the index, but keeps
extracting only GTF_ASG from the length to get around the issue
mentioned above.

Fix #91862

Co-authored-by: Jakob Botsch Nielsen <jakob.botsch.nielsen@gmail.com>
10 months ago[release/8.0] [browser] Add link to docs to interop error messages (#92182)
github-actions[bot] [Mon, 18 Sep 2023 17:22:10 +0000 (10:22 -0700)]
[release/8.0] [browser] Add link to docs to interop error messages (#92182)

* JS part

* C# part

---------

Co-authored-by: Marek Fišera <mara@neptuo.com>
10 months ago[mono][aot] Avoid compiling the same method multiple times during dedup. (#92178)
github-actions[bot] [Mon, 18 Sep 2023 17:21:39 +0000 (10:21 -0700)]
[mono][aot] Avoid compiling the same method multiple times during dedup. (#92178)

Co-authored-by: Zoltan Varga <vargaz@gmail.com>
10 months ago[release/8.0] Update dependencies from dnceng/internal/dotnet-optimization (#92177)
dotnet-maestro[bot] [Mon, 18 Sep 2023 17:20:30 +0000 (10:20 -0700)]
[release/8.0] Update dependencies from dnceng/internal/dotnet-optimization (#92177)

* Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build 20230915.3

optimization.linux-arm64.MIBC.Runtime , optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-arm64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime , optimization.PGO.CoreCLR
 From Version 1.0.0-prerelease.23464.6 -> To Version 1.0.0-prerelease.23465.3

* Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build 20230915.3

optimization.linux-arm64.MIBC.Runtime , optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-arm64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime , optimization.PGO.CoreCLR
 From Version 1.0.0-prerelease.23464.6 -> To Version 1.0.0-prerelease.23465.3

* Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build 20230915.3

optimization.linux-arm64.MIBC.Runtime , optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-arm64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime , optimization.PGO.CoreCLR
 From Version 1.0.0-prerelease.23464.6 -> To Version 1.0.0-prerelease.23465.3

---------

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
10 months ago[workloads] Opt into using package groups (#92168)
github-actions[bot] [Mon, 18 Sep 2023 17:13:31 +0000 (10:13 -0700)]
[workloads] Opt into using package groups (#92168)

This is to make sure the MSI's we generate for VS are recognized as the same. Enabling sxs workloads by itself caused the package id's that wrap the manifest MSI's to be different. This prevents that from happening.

Co-authored-by: Steve Pfister <steve.pfister@microsoft.com>
10 months ago[release/8.0] Avoid marking property/event attributes multiple times (#92153)
github-actions[bot] [Mon, 18 Sep 2023 17:11:57 +0000 (10:11 -0700)]
[release/8.0] Avoid marking property/event attributes multiple times (#92153)

* Avoid marking property attributes multiple times

* Fix test for nativeaot

* Add issue link

* Simplify test, fix bug for events, add more coverage

* Fix event tests

* Fix test for nativeaot

NativeAot requires a call to GetCustomAttribute for the
attributes to be kept.

---------

Co-authored-by: Sven Boemer <sbomer@gmail.com>
10 months ago[release/8.0] Remove public provider from rundown session (#92048)
github-actions[bot] [Mon, 18 Sep 2023 17:09:53 +0000 (10:09 -0700)]
[release/8.0] Remove public provider from rundown session (#92048)

* add rundown check

* Update ep-session.c

* Check for rundown provider

* Fix

* Update src/mono/mono/eventpipe/ep-rt-types-mono.h

Co-authored-by: Aleksey Kliger (λgeek) <akliger@gmail.com>
* Fix cross plat build

* Revert previous changes

* Remove public provider from rundown session

* Finish reverting

* Update ep-session.c

---------

Co-authored-by: David Mason <davmason@microsoft.com>
Co-authored-by: Aleksey Kliger (λgeek) <akliger@gmail.com>
10 months agoMerge pull request #92224 from dotnet/PackageREADMEsRelease80
Viktor Hofer [Mon, 18 Sep 2023 15:10:45 +0000 (17:10 +0200)]
Merge pull request #92224 from dotnet/PackageREADMEsRelease80

[release/8.0] Add package readmes

10 months agoLast clean-up
Viktor Hofer [Mon, 18 Sep 2023 14:33:59 +0000 (16:33 +0200)]
Last clean-up

10 months agoConfigurationManager clean-up
Viktor Hofer [Mon, 18 Sep 2023 14:00:28 +0000 (16:00 +0200)]
ConfigurationManager clean-up

10 months agoMore clean-up
Viktor Hofer [Mon, 18 Sep 2023 13:57:55 +0000 (15:57 +0200)]
More clean-up