Maryam Ariyan [Fri, 25 Jan 2019 01:06:44 +0000 (17:06 -0800)]
Test Fix: Add IsSoundPlaySupported condition to skip on Nano (dotnet/corefx#34820)
* Test Fix: Add IsSoundPlaySupported condition to skip on Nano
Fixes: dotnet/corefx#34808
* Removed Helpers class
Commit migrated from https://github.com/dotnet/corefx/commit/
dfb8fd883963de134fd09b54c61ac8da5ad573bf
Jose Perez Rodriguez [Fri, 25 Jan 2019 00:34:25 +0000 (16:34 -0800)]
Nesting source package files for a better experience when consuming it. (dotnet/corefx#34812)
Commit migrated from https://github.com/dotnet/corefx/commit/
c70cfa6d5600f01df3a15c151c18539f52e9bfd0
Stephen Toub [Fri, 25 Jan 2019 00:21:39 +0000 (19:21 -0500)]
Replace thread aborts in SoundPlayer (dotnet/corefx#34815)
This only addresses the issue of SoundPlayer using Thread.Abort, replacing it with cancellation.
Commit migrated from https://github.com/dotnet/corefx/commit/
2100e4f54637c124bdf880c7c036b4c79053e72f
David Shulman [Thu, 24 Jan 2019 21:45:39 +0000 (13:45 -0800)]
Fix SslStream channel binding token (dotnet/corefx#34814)
While working on Enterprise Scenario testing I discovered a bug in how the Unix layer generates
the channel binding token. It was using the wrong prefix for 'Endpoint' tokens.
Fixed 'Endpoint' token generation and added more detailed tests.
Commit migrated from https://github.com/dotnet/corefx/commit/
c6b4a1c39d91943dc536c3621d43d2bf88aca487
Tomas Weinfurt [Thu, 24 Jan 2019 17:58:13 +0000 (09:58 -0800)]
support for fragmentation Ping option on Unix (dotnet/corefx#34435)
* add support for fragmentation Ping option on Unix
* add missing project file
* small adjustments
* fix typo
* feedback from review
* remove no longer needed import
* remove changes to HttpCookieProtocolTests pulled in by mistake
Commit migrated from https://github.com/dotnet/corefx/commit/
8fea941db55fd79635fde1a54058620ddac16961
Tomas Weinfurt [Thu, 24 Jan 2019 17:57:49 +0000 (09:57 -0800)]
collect some info about SendRecvPollSync_TcpListener_Socket() test run (dotnet/corefx#34751)
* add instrumentation for test run
* improve output
Commit migrated from https://github.com/dotnet/corefx/commit/
bd3b5d2f1de9f4a9e6bbc0f154085de7f8228375
Ahson Khan [Thu, 24 Jan 2019 14:13:05 +0000 (06:13 -0800)]
Make ReadToEnd static helper resilient against stream.Length changes. (dotnet/corefx#34798)
Commit migrated from https://github.com/dotnet/corefx/commit/
49109de03f113bb87117a4e3aaa9ffabc5c06bfb
Santiago Fernandez Madero [Thu, 24 Jan 2019 13:22:52 +0000 (05:22 -0800)]
Set MaxRetryCount to 4 for both Windows and non-Windows jobs (dotnet/corefx#34792)
Commit migrated from https://github.com/dotnet/corefx/commit/
fd21fbc661a26eab435a9925fc243616a1798362
Maryam Ariyan [Thu, 24 Jan 2019 13:19:49 +0000 (05:19 -0800)]
Test fix for Nano: WindowAndCursorProps/Title_Get_Windows_NoNulls (dotnet/corefx#34755)
* Modifying assertion code for Nano on WindowAndCursorProps/Title_Get_Windows_NoNulls
Fixes: dotnet/corefx#34717
* Change Contains to Equal
Commit migrated from https://github.com/dotnet/corefx/commit/
0c437d886f194d34caf20c3078e27c6ce26d4119
Viktor [Thu, 24 Jan 2019 12:05:06 +0000 (13:05 +0100)]
Disable ApartmentState on UAP
Commit migrated from https://github.com/dotnet/corefx/commit/
a33d75aec0daff5e6a043352d443ce6270f6660c
Viktor Hofer [Thu, 24 Jan 2019 11:56:47 +0000 (12:56 +0100)]
Fix UapAot runs (dotnet/corefx#34678)
* Fix UapAot runs
* Darc update from build '
20190124.1'
Commit migrated from https://github.com/dotnet/corefx/commit/
4adc562336698dfc77e9fd3553c569c72cfc94f4
Matt Mitchell [Thu, 24 Jan 2019 06:01:30 +0000 (22:01 -0800)]
Merge pull request dotnet/corefx#34757 from dotnet/darc-master-
b26a5f18-f603-49aa-822a-
9931dbe2063d
Update dependencies from dotnet/coreclr
Commit migrated from https://github.com/dotnet/corefx/commit/
d40bfe3ec3d16f6d4ba2a0ab1e8a5d691d3e7fdc
Santiago Fernandez Madero [Thu, 24 Jan 2019 04:35:52 +0000 (20:35 -0800)]
Merge branch 'master' into darc-master-
b26a5f18-f603-49aa-822a-
9931dbe2063d
Commit migrated from https://github.com/dotnet/corefx/commit/
1ac555fc95a09f4e001703762f6b7f6d6d464ec2
Jan Kotas [Sun, 20 Jan 2019 00:50:37 +0000 (16:50 -0800)]
Test for negative offset passed to ArrayWithOffset
Fixes dotnet/corefx#34699
Commit migrated from https://github.com/dotnet/corefx/commit/
6168758a66ad6bb9584305eccee8b1601299ef03
Dan Moseley [Thu, 24 Jan 2019 02:09:18 +0000 (18:09 -0800)]
Increase timeout in Process test (dotnet/corefx#34753)
Commit migrated from https://github.com/dotnet/corefx/commit/
ef23e3317ca6e83f1e959ab265a8e59fb8a6dcd9
Stephen Toub [Thu, 24 Jan 2019 02:07:21 +0000 (21:07 -0500)]
Filter apphost rather than trying to have nuget suppress it (dotnet/corefx#34785)
NuGet wasn't honoring the Exclude=all across runtime dependencies
but I can make this simpler by just telling depproj filtering
target to remove the file.
Commit migrated from https://github.com/dotnet/corefx/commit/
0f6c2fc52b969309308faf442fc77ef99f370344
dotnet-maestro-bot [Thu, 24 Jan 2019 02:07:01 +0000 (18:07 -0800)]
Update CoreFx, ProjectNTfs, ProjectNTfsTestILC to preview.19073.1, beta-27323-00, beta-27323-00, respectively (dotnet/corefx#34748)
Commit migrated from https://github.com/dotnet/corefx/commit/
e95daf2da50c826c9931e0b7d483551d448cffda
Maryam Ariyan [Thu, 24 Jan 2019 01:19:21 +0000 (17:19 -0800)]
Expose System.Media.SoundPlayer in System.Windows.Extensions (dotnet/corefx#34649)
* Port System.Media members
* Add System.Media tests
Commit migrated from https://github.com/dotnet/corefx/commit/
438e6af0b9d69610b25417da41ea00b2830d1b0d
Maryam Ariyan [Thu, 24 Jan 2019 01:15:26 +0000 (17:15 -0800)]
Add lock around timersSignalled (dotnet/corefx#34790)
Fixes: dotnet/corefx#22108
Commit migrated from https://github.com/dotnet/corefx/commit/
8c7771a74510479afc7417041cb5208354164ff6
Tarek Mahmoud Sayed [Tue, 22 Jan 2019 23:44:24 +0000 (15:44 -0800)]
Reduce the time spent in System.Linq.Parallel.Tests
A couple of tests are failing because running for long time. The change here is to reduce the time spent there to avoid such failures in the outerloop runs
Commit migrated from https://github.com/dotnet/corefx/commit/
1c7b52620676d3578d940d00f2768678d289f8e4
Stephen Toub [Wed, 23 Jan 2019 23:34:30 +0000 (18:34 -0500)]
Fix build warnings for System.Threading.Channels ref (dotnet/corefx#34787)
Commit migrated from https://github.com/dotnet/corefx/commit/
f00a336700b207f51b83a1a0201c6353fdaff7a8
Eric St. John [Wed, 23 Jan 2019 20:52:35 +0000 (12:52 -0800)]
Filter apphost rather than trying to have nuget suppress it
NuGet wasn't honoring the Exclude=all across runtime dependencies
but I can make this simpler by just telling depproj filtering
target to remove the file.
Commit migrated from https://github.com/dotnet/corefx/commit/
16e45eea9a85c206ca7ec6b4ebc18a4a5187cd55
Dan Moseley [Wed, 23 Jan 2019 20:03:00 +0000 (12:03 -0800)]
Make TimerFiring test more robust to machine disturbances (dotnet/corefx#34762)
* Retries around timer test
* bug
* Add delay
Commit migrated from https://github.com/dotnet/corefx/commit/
81be7f52b9d0769e3fd5058292af53aa892de7c3
Jose Perez Rodriguez [Wed, 23 Jan 2019 19:23:13 +0000 (11:23 -0800)]
Adding alpine 3.8 to the RID graph (dotnet/corefx#34758)
* Adding alpine 3.8 to the RID graph
* Adding alpine 3.9 to the RID graph
Commit migrated from https://github.com/dotnet/corefx/commit/
47f042960fa1b9c651ca1370d5548852ffdcd339
Santiago Fernandez Madero [Wed, 23 Jan 2019 18:38:59 +0000 (10:38 -0800)]
Update testing with private CoreCLR bits
Remove the `--` to pass in `/p:CoreCLROverridePath` to `build.cmd` as it no longer needed.
Commit migrated from https://github.com/dotnet/corefx/commit/
0e7236fda21a07302b14030c82f79bb981c723a6
Stephen Toub [Wed, 23 Jan 2019 15:55:26 +0000 (10:55 -0500)]
Add ChannelReader.ReadAllAsync to System.Threading.Channels (dotnet/corefx#34756)
* Add ChannelReader.ReadAllAsync to System.Threading.Channels
* Address PR feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
abc7e38a7a6bb0eed6a972127438685d7e9cbc98
Ahson Khan [Wed, 23 Jan 2019 08:19:01 +0000 (00:19 -0800)]
Add try/catch OOM around large tests and exclude tests on x86 (dotnet/corefx#34763)
* Add try/catch OOM around large tests and exclude tests on x86
* Address PR feedback.
Commit migrated from https://github.com/dotnet/corefx/commit/
bc0cfc49d1a8c1681fb09603f3389ef65342d542
Ahson Khan [Wed, 23 Jan 2019 08:18:42 +0000 (00:18 -0800)]
Move JsonDocument related files to a Document subdirectory. (dotnet/corefx#34769)
Commit migrated from https://github.com/dotnet/corefx/commit/
bce48c1441a0c11635d9bd45a0fc8d5fae05961b
Ahson Khan [Wed, 23 Jan 2019 06:32:59 +0000 (22:32 -0800)]
Add link to source package md within the package description. (dotnet/corefx#34760)
Commit migrated from https://github.com/dotnet/corefx/commit/
8ebea7a0bd164154805b5e3696f9f0795c5f6e4f
Jeremy Barton [Wed, 23 Jan 2019 00:56:47 +0000 (16:56 -0800)]
Introduce JsonDocument
JsonDocument is a read-only random-access document model for JSON payloads.
The JsonDocument class holds parsing state, and carves off JsonElement
and JsonProperty cursors as needed to represent different locations within
the logical document.
Commit migrated from https://github.com/dotnet/corefx/commit/
2d9dd533e16889ea4d279162df4039982bfbbca2
Tomas Weinfurt [Tue, 22 Jan 2019 22:28:44 +0000 (14:28 -0800)]
add some synchronization between sender and receiver (dotnet/corefx#34691)
Commit migrated from https://github.com/dotnet/corefx/commit/
0c1ef7f5df7a6cbf218577180e0f09327bd91619
Tom Deseyn [Tue, 22 Jan 2019 17:26:56 +0000 (18:26 +0100)]
Unix: Add test for ExitCode on SIGTERM (dotnet/corefx#34585)
* Unix: Add test for ExitCode on SIGTERM
This test verifies the default ExitCode on SIGTERM is not zero.
Verifies https://github.com/dotnet/coreclr/pull/21300.
* PR feedback
* Fix BuildConfigurations
Commit migrated from https://github.com/dotnet/corefx/commit/
e3ab2b0c9bc3bcbcedecb21c3c6d83ea5793a719
Anirudh Agnihotry [Tue, 22 Jan 2019 17:22:44 +0000 (09:22 -0800)]
making the milisecond test deterministic (dotnet/corefx#34734)
Commit migrated from https://github.com/dotnet/corefx/commit/
673e1c171b95eeb0c23c980bd97aaf9b4f580ab9
dotnet-maestro-bot [Tue, 22 Jan 2019 13:07:11 +0000 (05:07 -0800)]
Update CoreFx, ProjectNTfs, ProjectNTfsTestILC to preview.19071.2, beta-27322-00, beta-27322-00, respectively (dotnet/corefx#34738)
Commit migrated from https://github.com/dotnet/corefx/commit/
f285d0a68feedf76377b3f5981ed5e21268f4390
Stephen Toub [Tue, 22 Jan 2019 01:44:39 +0000 (20:44 -0500)]
Add tests for various length DateTime.ToString years (dotnet/corefx#34727)
* Add tests for various length DateTime.ToString years
* Address PR feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
b8aeb16796a44110f97f03641f43db075a6b2faf
dotnet-maestro-bot [Tue, 22 Jan 2019 01:37:01 +0000 (17:37 -0800)]
Update CoreFx to preview.19071.1 (dotnet/corefx#34732)
Commit migrated from https://github.com/dotnet/corefx/commit/
7cf002ec36109943c048ec8da8ef80621190b4be
dotnet-maestro-bot [Mon, 21 Jan 2019 13:56:03 +0000 (05:56 -0800)]
Update CoreFx, ProjectNTfs, ProjectNTfsTestILC to preview.19070.4, beta-27321-00, beta-27321-00, respectively (dotnet/corefx#34714)
Commit migrated from https://github.com/dotnet/corefx/commit/
de3800194569dc35d938eb44f193d963b413a4e1
Jan Kotas [Mon, 21 Jan 2019 13:55:09 +0000 (05:55 -0800)]
Fix inefficient interop in OSX FileSystemWatcher (dotnet/corefx#34715)
* Fix inefficient interop in OSX FileSystemWatcher
Avoid unnecessary array allocations in the FileSystemWatcher callback
* Add using for FSEventStreamEventFlags
Commit migrated from https://github.com/dotnet/corefx/commit/
93386f5dd75e291d7c0dbbb450f5b96659b3d58f
Liran Chen [Mon, 21 Jan 2019 00:35:24 +0000 (02:35 +0200)]
Replaced hardcoded value (2) with TypeCode.DBNull (dotnet/corefx#34707)
Commit migrated from https://github.com/dotnet/corefx/commit/
34fd5242fc32e691e33e02b435b7a9b6cb01a2af
dotnet-maestro-bot [Mon, 21 Jan 2019 00:35:12 +0000 (16:35 -0800)]
Update CoreFx to preview.19070.2 (dotnet/corefx#34708)
Commit migrated from https://github.com/dotnet/corefx/commit/
ef7502a1848440dc4fb166c340d1f48de8a403bb
dotnet-maestro-bot [Sun, 20 Jan 2019 20:22:40 +0000 (12:22 -0800)]
Update CoreFx to preview.19070.1 (dotnet/corefx#34703)
Commit migrated from https://github.com/dotnet/corefx/commit/
10f9ee73a8475d48dff150a5de578e2b0d36fe42
dotnet-maestro-bot [Sun, 20 Jan 2019 14:56:43 +0000 (06:56 -0800)]
Update CoreFx to preview.19069.3 (dotnet/corefx#34684)
Commit migrated from https://github.com/dotnet/corefx/commit/
0977577864d1c98de9526e192da125ef58ec9c41
Ahson Khan [Sat, 19 Jan 2019 23:49:36 +0000 (15:49 -0800)]
Update calls in Json tests from GetStringValue to GetString (dotnet/corefx#34698)
Commit migrated from https://github.com/dotnet/corefx/commit/
88ec3d985b4879bd77b7821f154663099e7bae29
Maxim Shoshin [Sat, 19 Jan 2019 16:39:57 +0000 (19:39 +0300)]
Reduce memory allocations on read performance counters. (dotnet/corefx#32393)
* Reduce memory allocations on read performance counters
* Fix review issues
* Add license header
* Remove unnecessary code: for ArrayPool diagnostic and check in Dispose
* Remove unnecessary usage of MemoryMarshal
Commit migrated from https://github.com/dotnet/corefx/commit/
c4f331961bfc6317a16a6ec43b53c780bd3c8dc4
Ben Adams [Sat, 19 Jan 2019 16:11:55 +0000 (17:11 +0100)]
Update Newtonsoft.Json version (dotnet/corefx#34664)
Commit migrated from https://github.com/dotnet/corefx/commit/
c6ff82c826a8c070f541cce389d26a5b8367d387
Mandar Sahasrabuddhe [Sat, 19 Jan 2019 14:39:58 +0000 (20:09 +0530)]
Implement Get APIs using TryGet counterparts (dotnet/corefx#34604)
* CoreFx dotnet/corefx#33320 Implement Get APIs using TryGet
* CoreFx dotnet/corefx#33320 Implement Get APIs using TryGet
* Fixed NITs
Commit migrated from https://github.com/dotnet/corefx/commit/
814e1ca9f1171bf50c425aba13c4148170d639ae
Ahson Khan [Sat, 19 Jan 2019 14:38:38 +0000 (06:38 -0800)]
Always reset ValueSpan and ValueSequence whenever the other is set. (dotnet/corefx#34667)
* Always reset ValueSpan and ValueSequence whenever the other is set.
* Fix bug in GetNextSpan so current position remains at non-empty segment.
* Add valuespan and valuesequence checks in more places.
* Always set value properties to default at the start of Read
* Assert span == default instead of IsEmpty
Commit migrated from https://github.com/dotnet/corefx/commit/
a45eb78f3d115cd545ef285129e11ddc2da3cad1
Ahson Khan [Sat, 19 Jan 2019 14:37:57 +0000 (06:37 -0800)]
Unescape JSON string token before transcoding to UTF-16 and returning to the user. (dotnet/corefx#34636)
* Unescape JSON string token before transcoding to UTF-16 and returning to
the user.
* Handle escaping and transcoding surrogate pairs correctly.
* Fix unescaping forward slash.
* Add a double high surrogate test.
* Factor out common helpers between the reader and writer.
* Fix exception messages.
* Fix build issues related to source package.
* Add comments regarding Debug.Asserts and fix InRange impl.
* Dont throw DecoderFallBackException and add invalid utf-8 string tests.
* Wrap the DecoderfallbackException within the InvalidOperationException.
Commit migrated from https://github.com/dotnet/corefx/commit/
38e5e28646687da306ad1f3e3fc9876e67e031bb
Ahson Khan [Sat, 19 Jan 2019 04:29:41 +0000 (20:29 -0800)]
Add documentation around source package consumption. (dotnet/corefx#34688)
* Add documentation around source package consumption.
* Fix typos and formatting.
* Add a sample csproj that users can reference.
Commit migrated from https://github.com/dotnet/corefx/commit/
bb82656656520e110d4568180f50922fce1a293c
Ahson Khan [Sat, 19 Jan 2019 04:29:30 +0000 (20:29 -0800)]
Add CoverageSourceLink option to code coverage doc. (dotnet/corefx#34685)
Commit migrated from https://github.com/dotnet/corefx/commit/
538bc23057af1c6a4e4e4e0958d7277ab859483c
Ahson Khan [Fri, 18 Jan 2019 23:22:34 +0000 (15:22 -0800)]
Add a sample csproj that users can reference.
Commit migrated from https://github.com/dotnet/corefx/commit/
4dd2562dd5e29bb74818d8e864a8642ea371942c
Matt Mitchell [Fri, 18 Jan 2019 23:14:46 +0000 (15:14 -0800)]
Merge pull request dotnet/corefx#34682 from mmitche/reclassify-deps
Reclassify the test dependencies in corefx as toolset
Commit migrated from https://github.com/dotnet/corefx/commit/
df75edc45dfb58d4b0ea8ff3047356c82d781624
Ahson Khan [Fri, 18 Jan 2019 23:12:47 +0000 (15:12 -0800)]
Fix typos and formatting.
Commit migrated from https://github.com/dotnet/corefx/commit/
9a6f5b75f27e06eab32f4d9f4457a3c782645ab4
Ahson Khan [Fri, 18 Jan 2019 23:04:29 +0000 (15:04 -0800)]
Add documentation around source package consumption.
Commit migrated from https://github.com/dotnet/corefx/commit/
f3172194982de9b972e95695d67368179b6d4811
Santiago Fernandez Madero [Fri, 18 Jan 2019 19:25:26 +0000 (11:25 -0800)]
Run Ubuntu arm tests in 1604 (dotnet/corefx#34680)
Commit migrated from https://github.com/dotnet/corefx/commit/
19d609f5360868397bb0aa0b1d0cd241e675c720
Jose Perez Rodriguez [Fri, 18 Jan 2019 19:17:43 +0000 (11:17 -0800)]
Generating Source package for System.Text.Json (dotnet/corefx#34552)
* Generating Source package for System.Text.Json
* Changing the placeholder file to be in netcoreapp3.0 instead
* Renaming package
* Updating arcade to get new SourceRewriter package
* Fix package location of resource files
* Adding .resx file to the package and addressing PR Feedback
* Adding description and fixing issue with spacing
* Automatically generate targets file that goes in the package
Commit migrated from https://github.com/dotnet/corefx/commit/
09b8b4b1b6c07a7e14385507eaa866e7da83395b
dotnet-maestro-bot [Fri, 18 Jan 2019 18:40:03 +0000 (10:40 -0800)]
Update CoreFx to preview.19068.1 (dotnet/corefx#34677)
Commit migrated from https://github.com/dotnet/corefx/commit/
98596eb7f24bbb396234b23f2c1c1ca9625f64d1
Tomas Weinfurt [Fri, 18 Jan 2019 15:47:52 +0000 (07:47 -0800)]
fixes for ARM32 (dotnet/corefx#34559)
* arm fixes
* use PassingTestTimeoutMilliseconds instead of hardcoded number
Commit migrated from https://github.com/dotnet/corefx/commit/
4eccf3ff4e87831de660e6a23b3ba24d55f7bca1
Swaroop Sridhar [Fri, 18 Jan 2019 14:07:58 +0000 (06:07 -0800)]
Expose AssemblyLoadContext Native Library Resolve Event (dotnet/corefx#34668)
Expose System.Runtime.Loader.AssemblyLoadContext.ResolvingUnmanagedDll
API Review: https://github.com/dotnet/corefx/issues/32850
Implementation: https://github.com/dotnet/coreclr/blob/master/src/System.Private.CoreLib/src/System/Runtime/Loader/AssemblyLoadContext.cs#L549
Tests: https://github.com/dotnet/coreclr/blob/master/tests/src/Interop/NativeLibraryResolveEvent/ResolveEventTests.cs
Commit migrated from https://github.com/dotnet/corefx/commit/
b7b69691ff07178afd31941c013ff8fa4987732f
dotnet-maestro-bot [Fri, 18 Jan 2019 14:02:46 +0000 (06:02 -0800)]
Update CoreFx, ProjectNTfs, ProjectNTfsTestILC to preview.19067.7, beta-27318-00, beta-27318-00, respectively (dotnet/corefx#34665)
Commit migrated from https://github.com/dotnet/corefx/commit/
55459d3a5d7050b0ffba50bd7b3a508f279aa6f1
Nicolas Portmann [Fri, 18 Jan 2019 06:34:15 +0000 (07:34 +0100)]
Remove unnecessary checks in ConsumeNumber (dotnet/corefx#33294) (dotnet/corefx#34500)
* Remove unnecessary checks in ConsumeNumber (dotnet/corefx#33294)
* Remove unnecessary _isNotPrimitive check
Commit migrated from https://github.com/dotnet/corefx/commit/
d2b28cc506e5858dccdd388e2c8189d10e5687f9
Roman Marusyk [Fri, 18 Jan 2019 04:54:53 +0000 (06:54 +0200)]
Utf8JsonReader throw when isFinal is true and the first call to Read returns false (dotnet/corefx#34155)
* Utf8JsonReader throw when isFinal is true and the first call to Read returns false
* Fix unit tests
* Code review fixes
* Fix unit test
* Fix unit test
* Fixes after code review
Commit migrated from https://github.com/dotnet/corefx/commit/
4431b3c63cbe121e5587c6bc6b18c69e80385b14
Matt Mitchell [Fri, 18 Jan 2019 01:53:51 +0000 (17:53 -0800)]
Merge pull request dotnet/corefx#34658 from chcosta/addlocation
Add Location info to asset manifest
Commit migrated from https://github.com/dotnet/corefx/commit/
d8c200414ccf65e0be94358937e9c711c0fd532d
Stephen Toub [Fri, 18 Jan 2019 01:07:12 +0000 (20:07 -0500)]
Move Environment to shared CoreLib (dotnet/corefx#34654)
Rather than having Environment partially live in corefx and call into an EnvironmentAugments type in CoreLib that in turn calls into an Environment type in CoreLib, we're just moving Environment to live in CoreLib.
To start that, this PR moves Environment and its dependencies from their current locations into the shared CoreLib. Those changes will mirror over to coreclr. After that, I'll fix it up to work in CoreLib. And once those changes are built and available back to corefx, I'll update System.Runtime.Extensions to just use the functionality from CoreLib and delete remaining unnecessary code from corefx.
Commit migrated from https://github.com/dotnet/corefx/commit/
b2d890a311ff66857339c7dae493efa43237284c
dotnet-maestro-bot [Fri, 18 Jan 2019 00:29:55 +0000 (16:29 -0800)]
Update BuildTools to preview1-03617-02 (dotnet/corefx#34656)
Commit migrated from https://github.com/dotnet/corefx/commit/
34ce0d08ee59fe1a64d547c2088fbe4c5062f038
Christopher Costa [Thu, 17 Jan 2019 23:59:47 +0000 (15:59 -0800)]
Add Location info to asset manifest
Commit migrated from https://github.com/dotnet/corefx/commit/
8c2107c72495780dac61dd3a2b14518a165ab786
Eugene Rozenfeld [Thu, 17 Jan 2019 23:55:59 +0000 (15:55 -0800)]
Merge pull request dotnet/corefx#34653 from erozenfeld/FixExceptionTest
Fix ThrowAndRethrowOtherMethod test.
Commit migrated from https://github.com/dotnet/corefx/commit/
2fc5a59589d07ea4f2f5bd2bcce987100e24eaa6
Santiago Fernandez Madero [Thu, 17 Jan 2019 23:45:04 +0000 (15:45 -0800)]
Change all configurations PR job to use non-hosted pool for more space in machines (dotnet/corefx#34655)
Commit migrated from https://github.com/dotnet/corefx/commit/
d322f797e3d5c94496ae6f38cce5f6afaa1d2ecd
Maryam Ariyan [Thu, 17 Jan 2019 23:21:30 +0000 (15:21 -0800)]
Removing assertion not true for all events (dotnet/corefx#34650)
Commit migrated from https://github.com/dotnet/corefx/commit/
caebf8a1173d4f09bcf3007aa8607f981e8ec9af
Stephen Toub [Thu, 17 Jan 2019 22:03:41 +0000 (17:03 -0500)]
Use RemoteInvoke with tracing tests (dotnet/corefx#34645)
Various test projects validate that EventSource data is being appropriately generated. Since these tests can run concurrently with others in the process, they should be done as out-of-process such that they don't interfere with each other, but some test projects aren't doing that. This fixes that, ensuring we're using RemoteInvoke everywhere we should be.
Commit migrated from https://github.com/dotnet/corefx/commit/
827f91c666c2b40e078c3f1df7a7e5ab13781eaa
Fred Silberberg [Thu, 17 Jan 2019 21:58:29 +0000 (13:58 -0800)]
Renamed Microsoft.VisualBasic to Microsoft.VisualBasic.Core (dotnet/corefx#34087)
* Renamed Microsoft.VisualBasic to Microsoft.VisualBasic.Core
Part of porting Microsoft.VisualBasic to core. A facade for
Microsoft.VisualBasic is now generated in place of the original dll so
existing applications will be able to continue with the same set of
references.
* Addressed feedback
* Address PR feedback.
* Continued work on renaming
* Remove package for Microsoft.VisualBasic.Core and make API additions framework specific
(cherry picked from commit dotnet/corefx@
0ef22b502e77b06f68e97e0614144da8c05b08ef)
* Fix test Configurations
* Fix VB test build for UAP
* PR feedback.
Commit migrated from https://github.com/dotnet/corefx/commit/
90dc9459b8eaf0c8ac93440e58c7535c67dacc22
Eugene Rozenfeld [Thu, 17 Jan 2019 21:11:46 +0000 (13:11 -0800)]
Fix ThrowAndRethrowOtherMethod test.
ThrowAndRethrowOtherMethod is sensitive to jit inlining decisions.
In particular, it fails if the jit decides to inline ThrowException.
That can happen with, e.g., random inlining policy.
In that case the stack trace doesn't have frame info for ThrowException
and VerifyCallStack skips the wrong frame.
One of the jit stress legs is failing because of that:
https://github.com/dotnet/coreclr/issues/21644 .
The fix is to ensure that ThrowException is not inlined.
Commit migrated from https://github.com/dotnet/corefx/commit/
165e71266f79025209f293dd26d755a1c268f40c
Ahson Khan [Thu, 17 Jan 2019 20:52:13 +0000 (12:52 -0800)]
Fix outerloop JsonWriter test by creating new instance of the writer when writing invalid JSON (dotnet/corefx#34637)
* Re-initialize json writer within invalid test that throws to avoid writing a value in a JSON object.
* Uncomment outerloop attribute.
Commit migrated from https://github.com/dotnet/corefx/commit/
54f3a59c5e0cd0db90e9c74cd11eebfd28f028b7
Ahson Khan [Thu, 17 Jan 2019 20:50:48 +0000 (12:50 -0800)]
Update S.T.Json sources with ifdefs so that a netstandard compatible source package can be produced (dotnet/corefx#34611)
* Test changes necessary to build S.T.Json sources targetting netstandard
* Revert unnecessary change from private to internal.
* Revert props and csproj changes to support netstandard along with test
changes.
* Address PR feedback.
* Revert "Revert props and csproj changes to support netstandard along with test"
This reverts commit dotnet/corefx@
7a2f22e127c4ef0476f20bddd64796045f79ddb5.
* Fix code formatting/spacing.
* Invert the ifdef so it is false by default (for source package) and add
comments.
Commit migrated from https://github.com/dotnet/corefx/commit/
36893daefdc114306efe86eca4170836bc02ff68
Stephen Toub [Thu, 17 Jan 2019 20:13:56 +0000 (15:13 -0500)]
Avoid unnecessary Span to ReadOnlySpan casts (dotnet/corefx#34646)
In a bunch of places we're creating a Span only to then cast it (generally implicitly) to a ReadOnlySpan. While the JIT is generally able to do the RightThing(tm), we can avoid the unnecessary IL and pressure on the JIT by just creating a ReadOnlySpan to begin with.
Commit migrated from https://github.com/dotnet/corefx/commit/
ab925533fade636748f5d932546e1ce2fe33c1dd
Matt Mitchell [Thu, 17 Jan 2019 19:17:51 +0000 (11:17 -0800)]
Change to build each commit (dotnet/corefx#34644)
Commit migrated from https://github.com/dotnet/corefx/commit/
31a9af82c15e4553cec9d10c1d0ce55c86b93df9
Santiago Fernandez Madero [Wed, 16 Jan 2019 00:50:54 +0000 (16:50 -0800)]
Disable System.Drawing.Common flaky tests
Commit migrated from https://github.com/dotnet/corefx/commit/
ea36815081fcc8dfac19dfe7343db77c33803a61
Santiago Fernandez Madero [Fri, 4 Jan 2019 00:24:27 +0000 (16:24 -0800)]
Enable Azure Devops CI leg for PRs
Commit migrated from https://github.com/dotnet/corefx/commit/
efc74834dccabb4d1b779a549b942c9d2c0069fa
Swaroop Sridhar [Thu, 17 Jan 2019 16:57:11 +0000 (08:57 -0800)]
Expose NativeLibrary APIs (dotnet/corefx#34567)
Expose the System.Runtime.Interop.NativeLibrary APIs implemented in CoreCLR.
API review: dotnet/corefx#32015
CoreCLR Change: https://github.com/dotnet/coreclr/pull/21821
Tests for the API are here:
https://github.com/dotnet/coreclr/blob/master/tests/src/Interop/NativeLibrary/NativeLibraryTests.cs
Commit migrated from https://github.com/dotnet/corefx/commit/
5241ad4927d1a124976ea7de5f0f610a2c7be777
dotnet-maestro-bot [Thu, 17 Jan 2019 13:41:25 +0000 (05:41 -0800)]
Update ProjectNTfs, ProjectNTfsTestILC to beta-27317-00, beta-27317-00, respectively (dotnet/corefx#34634)
Commit migrated from https://github.com/dotnet/corefx/commit/
be1557ae32a0f652d6e3af47c840d307b6555573
Adeel Mujahid [Thu, 17 Jan 2019 09:26:47 +0000 (11:26 +0200)]
Enable official portable musl build (dotnet/corefx#34352)
* Enable portable builds in linux-musl.groovy
* Enable official portable musl build
* Add back Windowws_NT condition
Commit migrated from https://github.com/dotnet/corefx/commit/
1072799465f41315f2d041e09db17e0390445739
Afsaneh Rafighi [Wed, 16 Jan 2019 23:04:38 +0000 (15:04 -0800)]
Merge pull request dotnet/corefx#34134 from Wraith2/sqlperf-asynchelper
SqlClient minor memory improvements
Commit migrated from https://github.com/dotnet/corefx/commit/
abd0482315951333d051abdac89b33f2985aba0a
Layomi Akinrinade [Wed, 16 Jan 2019 19:59:47 +0000 (14:59 -0500)]
Add roundtrip tests for EncoderNLS and DecoderNLS (dotnet/corefx#34610)
This increases code coverage for System.Text.Encoding.Codepages from
68.9% to 74.5%.
Commit migrated from https://github.com/dotnet/corefx/commit/
4febb444f82cabed2b3df186bcc8e9ad0b31dbf9
dotnet-maestro-bot [Wed, 16 Jan 2019 17:24:47 +0000 (09:24 -0800)]
Update CoreFx, ProjectNTfs, ProjectNTfsTestILC to preview.19066.1, beta-27316-00, beta-27316-00, respectively (dotnet/corefx#34614)
Commit migrated from https://github.com/dotnet/corefx/commit/
536ef01e18d6b3b2e7ef74057d0772c3daf893fa
Sven Boemer [Wed, 16 Jan 2019 06:28:19 +0000 (22:28 -0800)]
Consume coreclr dependencies (dotnet/corefx#34169)
* Consume coreclr dependencies using new dependency flow
* Use consistent casing for new package versions
* Use dotnet-coreclr source in Directory.Build.props, NuGet.config, and symbol asset urls
Directory.Build.props is used for packagereferences, NuGet.config is used for assets in global.json, and constructed urls are used to download symbols.
Commit migrated from https://github.com/dotnet/corefx/commit/
23a05d37db809e2fb76db60abb80e6f8ed5168a6
Jeremy Koritzinsky [Wed, 16 Jan 2019 03:38:49 +0000 (19:38 -0800)]
Expose System.Runtime.Loader.AssemblyDependencyResolver. (dotnet/corefx#34484)
* Expose AssemblyDependencyResolver.
* PR feedback.
* Update ApiCompatBaseline.
Commit migrated from https://github.com/dotnet/corefx/commit/
fa50c5c55b47e14e0da26a4be940347ec71b2885
Roman Marusyk [Wed, 16 Jan 2019 01:19:31 +0000 (03:19 +0200)]
System.Management. Refactor DllImports (dotnet/corefx#34477)
* System.Management. Refactor DllImports
Commit migrated from https://github.com/dotnet/corefx/commit/
290538004e795df183e7fd7c583cb28d6d243346
Stephen Toub [Wed, 16 Jan 2019 00:55:56 +0000 (19:55 -0500)]
Test to validate that TaskCompletionSource doesn't capture ExecutionContext (dotnet/corefx#34587)
Commit migrated from https://github.com/dotnet/corefx/commit/
db7daabdb592da062d8a80f27bbad1178c364530
Stephen Toub [Wed, 16 Jan 2019 00:55:30 +0000 (19:55 -0500)]
Merge pull request dotnet/corefx#34451 from stephentoub/teststringconcat
Expose/test/use string.Concat(ReadOnlySpan, ...)
Commit migrated from https://github.com/dotnet/corefx/commit/
34078a7d3259c6b2d929949babde3a24f9a03e84
Karel Zikmund [Wed, 16 Jan 2019 00:43:28 +0000 (16:43 -0800)]
Add area-System.Numerics.Tensors
Commit migrated from https://github.com/dotnet/corefx/commit/
c5f4baf47cc952b29432300305f5d69129cd7f34
Ahson Khan [Tue, 15 Jan 2019 22:42:39 +0000 (14:42 -0800)]
Add Utf8JsonWriter along with unit tests (dotnet/corefx#34425)
* Move JsonReader related files to the Reader directory.
* Update S.T.Json ref to include new JsonWriter APIs.
* Port initial JsonWriter files from corefxlab.
* Auto-generate System.Text.Json ref to update the ordering for
consistency.
* Fixed some TODOs, delete dead code, and formatting cleanup.
* Make use of self-descriptive constants where possible.
* Fix leftover TODOs and update throw helper/exception messages.
* Add xml comments/docs to the public surface area.
* Add JsonWriter unit tests.
* Change GetCurrentState back to a property and explicitly Flush on the
callers behalf instead of throwing.
* Save current depth as part of state and update tests.
* Fix constant names, account for quotes in bytes needed, and add fixed buffer writer tests.
* Fix inconsistent use of braces by adding them for single line ifs
* Update parameter name to exclude encoding.
* Remove JsonWriterException and use InvalidOperationException instead.
* Use Rune and Utf8Formatter/TryFormat in more places and remove
UnicodeScalar.
* Fix nits, typos, and reorder field assignment and method calls.
* Pass spans by in (or by value) instead of by ref.
* Update comments and remove unnecessary test.
* Remove some aggressive inlining and pass spans by value rather than in
* Update comments, dont compute bytes needed, and use if instead of loop before advancing.
* Reduce code bloat by removing duplciate calls to ValidateX.
* Add details on how .NET types are formatted to comments.
* Reduce code duplication when writing values.
* Change the StandardFormat used for DateTime(Offset) to 'O'
* Refactor calculating the maximum escaped length to a helper.
* Remove unnecessary checks and rename locals to be more descriptive.
* Rename suppressEscaping to escape and flip default from false to true.
* Comment cleanup, add debug.asserts, and move transcoding helpers to a
separate file.
* Increase the deicmal max size to account for sign and add tests.
* Rename ROS<byte> property name and value params to include utf8 in the
name.
* Remove redundant code where idx is set to 0 unnecessarily.
* Remove dead code (dont escape forward slash) and make tests culture
invariant.
Commit migrated from https://github.com/dotnet/corefx/commit/
f84927d4a85444e63ede2da38a49eff7116790db
Stephen Toub [Tue, 15 Jan 2019 21:52:54 +0000 (16:52 -0500)]
Merge pull request dotnet/corefx#34596 from dotnet-maestro-bot/master-UpdateDependencies
Update CoreClr, CoreFx, ProjectNTfs, ProjectNTfsTestILC to preview-27315-02, preview.19065.1, beta-27315-00, beta-27315-00, respectively (master)
Commit migrated from https://github.com/dotnet/corefx/commit/
2fde649511160865d09398e657645489a669182a
Stephen Toub [Tue, 15 Jan 2019 19:14:49 +0000 (14:14 -0500)]
Fix ManualResetValueTaskSource tests missing event Waits (dotnet/corefx#34603)
These are sporadically failing because they're missing required .Wait() calls on an event that gets set.
Commit migrated from https://github.com/dotnet/corefx/commit/
c0da1a5b0b5028e43ea5ad5369672f298b272daa
Tomas Weinfurt [Tue, 15 Jan 2019 18:20:56 +0000 (10:20 -0800)]
skip SetDateTimeMax test on 32b Unix platforms (dotnet/corefx#34595)
* skip SetDateTimeMax test on 32b Unix platforms
* s/OsHasMaxTime/SupportsLongMaxDateTime/g
Commit migrated from https://github.com/dotnet/corefx/commit/
403deb436d91dcad4340fa45520d307767d297c9
Stephen Toub [Tue, 15 Jan 2019 15:35:05 +0000 (10:35 -0500)]
Undo workarounds for CoreLib types
Commit migrated from https://github.com/dotnet/corefx/commit/
94c43e147d6aac8de3f9d6ad8f4db5881b1007df
Tarek Mahmoud Sayed [Sat, 12 Jan 2019 00:26:11 +0000 (16:26 -0800)]
Update TimeSpan Parsing Test
Commit migrated from https://github.com/dotnet/corefx/commit/
a58777883c9102f9586dd723e2d4ba35aeedf0ef
dotnet-maestro-bot [Tue, 15 Jan 2019 06:16:40 +0000 (22:16 -0800)]
Update CoreClr, CoreFx, ProjectNTfs, ProjectNTfsTestILC to preview-27315-01, preview.19064.4, beta-27315-00, beta-27315-00, respectively
Commit migrated from https://github.com/dotnet/corefx/commit/
cc7ff9490ae7ba898d531ae4174cb43af9881f05
Santiago Fernandez Madero [Tue, 15 Jan 2019 01:23:33 +0000 (17:23 -0800)]
Consume core-setup using darc (dotnet/corefx#34344)
* Consume core-setup using darc
* Import versions.props in package tests now that versions where moved
* Run darc update with latest core-setup build
Commit migrated from https://github.com/dotnet/corefx/commit/
6df97f7e9434a34e62288444993cf6e782c44191
Nicolas Portmann [Mon, 14 Jan 2019 23:29:07 +0000 (00:29 +0100)]
Utf8JsonReader should store if parsed number contains exponent (dotnet/corefx#34386)
* Store if number contains exponent
* Store number format directly
Commit migrated from https://github.com/dotnet/corefx/commit/
60f871b05ac8db8de316dc9ed5e7647808011225
Jeremy Koritzinsky [Mon, 14 Jan 2019 23:24:18 +0000 (15:24 -0800)]
Remove flaky ReadByte assert. (dotnet/corefx#34589)
* Remove flaky ReadByte assert.
We've hit the flaky assert in the Marshal.ReadByte test. I don't think that this test is worth the flaky-ness in the `Byte` case, so I'm just going to remove this assert and bring it back to how it was beforehand. Fixes dotnet/corefx#34579.
See dotnet/corefx#34445.
cc: @AaronRobinsonMSFT
* Update ByteTests.cs
Commit migrated from https://github.com/dotnet/corefx/commit/
4d82935de75cff4893efbc1340626995601e49dc