platform/core/csapi/xsf.git
5 years ago[UWP] The SelectedItem in a ListView is not highlighted when set while constructing...
Gerald Versluis [Thu, 1 Aug 2019 11:28:29 +0000 (13:28 +0200)]
[UWP] The SelectedItem in a ListView is not highlighted when set while constructing a page (#6973)

* Enable selection of an item from constructor

* Update ListViewRenderer.cs

* Update ListViewRenderer.cs

* Update ListViewRenderer.cs

5 years agoMerge branch '4.0.0' into 4.1.0
Stephane Delcroix [Tue, 30 Jul 2019 14:31:31 +0000 (16:31 +0200)]
Merge branch '4.0.0' into 4.1.0

5 years ago[UWP] Register the Xaml assembly (#7004)
Stephane Delcroix [Tue, 30 Jul 2019 07:45:11 +0000 (09:45 +0200)]
[UWP] Register the Xaml assembly (#7004)

the Xaml asssembly need to be scanned for DependecyServices. The
code in place intended it, but was referring to the wrong type...

 - fixes #6974

5 years ago[iOS] UITableView.Appearance.BackgroundColor ignored or overridden for ListView ...
Gerald Versluis [Tue, 30 Jul 2019 06:25:59 +0000 (08:25 +0200)]
[iOS] UITableView.Appearance.BackgroundColor ignored or overridden for ListView (#6910)

* Fix and UI test

# Conflicts:
# Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Xamarin.Forms.Controls.Issues.Shared.projitems

* Apply suggestions from code review

Co-Authored-By: Samantha Houts <samhouts@users.noreply.github.com>
* Last typo fix

5 years agofixes .create-nuget script (#6913)
Pavel Yakovlev [Mon, 29 Jul 2019 21:11:38 +0000 (00:11 +0300)]
fixes .create-nuget script (#6913)

5 years agoMerge branch '4.0.0' into 4.1.0
Rui Marinho [Mon, 29 Jul 2019 09:22:33 +0000 (10:22 +0100)]
Merge branch '4.0.0' into 4.1.0

5 years agoiOS - Test and fix for VoiceOver crash on a ContentPage not having any Content define...
Samantha Houts [Mon, 29 Jul 2019 09:01:24 +0000 (02:01 -0700)]
iOS - Test and fix for VoiceOver crash on a ContentPage not having any Content defined (#6987) fixes #6926

* Added test case for showing crash for issue 6926.

* Potential fix for issue 6926. Prevents a null reference exception when a ContentPage has no Content.

5 years ago[Android] add check for double dispose scrollview/page/platform (#6923)
Shane Neuville [Fri, 26 Jul 2019 07:54:10 +0000 (01:54 -0600)]
[Android] add check for double dispose scrollview/page/platform (#6923)

5 years agoAdded UpdateScreenSize call at instantiation (#6912)
Gerald Versluis [Thu, 25 Jul 2019 20:24:31 +0000 (22:24 +0200)]
Added UpdateScreenSize call at instantiation (#6912)

5 years ago[Android] Fix previewer exceptions with SearchBar (#6930) fixes #4108
Pavel Yakovlev [Thu, 25 Jul 2019 16:39:08 +0000 (19:39 +0300)]
[Android] Fix previewer exceptions with SearchBar (#6930) fixes #4108

* [Android] fixes previewer exceptions with SearchBar

* added comment

5 years agoFixes #6539 (#6969)
kingces95 [Thu, 25 Jul 2019 09:52:36 +0000 (23:52 -1000)]
Fixes #6539 (#6969)

5 years ago[Android] Fix previewer exceptions with TabbedPage (#6897)
Pavel Yakovlev [Mon, 22 Jul 2019 16:53:28 +0000 (19:53 +0300)]
[Android] Fix previewer exceptions with TabbedPage (#6897)

* [Android] Fix previewer exceptions with TabbedPage

* - consolidated code

5 years agoAdded UITest for #2577 (#6728)
Gerald Versluis [Thu, 18 Jul 2019 11:43:27 +0000 (13:43 +0200)]
Added UITest for #2577 (#6728)

* Added UITest for issue 2577

* Added Wait statements

* Apply suggestions from code review

Co-Authored-By: Pavel Yakovlev <v-payako@microsoft.com>
* AutomationId to const

* Update Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue2577.cs

Co-Authored-By: Pavel Yakovlev <v-payako@microsoft.com>
* All strings to const

5 years agoMerge branch '4.0.0' into 4.1.0
Samantha Houts [Thu, 18 Jul 2019 02:58:30 +0000 (19:58 -0700)]
Merge branch '4.0.0' into 4.1.0

5 years ago[Bug][iOS] listview / observable collection throwing native error on load (#6576)
Gerald Versluis [Thu, 18 Jul 2019 02:49:21 +0000 (04:49 +0200)]
[Bug][iOS] listview / observable collection throwing native error on load (#6576)

* Added reproduction and commented out the misbehaving code

* Fixed merge conflicts

# Conflicts:
# Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Xamarin.Forms.Controls.Issues.Shared.projitems

* Implemented UI test

* Somehow merged in a non-existing UI test

* Removed DetermineEstimatedRowHeight in WillDisplay

* Revert "Removed DetermineEstimatedRowHeight in WillDisplay"

This reverts commit 431178d923c3bf642aae83331a5dc5b57c4436de.

* Removed WillDisplay with DetermineEstimatedRowHeight

* Reinstate projitems

* Added some more test scenarios

* Removed commented code

* Update Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue6472.cs
fixes #6472

5 years ago[Android] refactoring fixes layouts (#6390)
Pavel Yakovlev [Thu, 18 Jul 2019 01:29:08 +0000 (04:29 +0300)]
[Android] refactoring fixes layouts (#6390)

* [Android] refactoring fixes layouts (issues 1332, 1760, 5766, 5184, 6297)

* issue3000 and ToolbarItem tests should be passes

* MaybeRequestLayout extension method

* added automated UITest 5766

* fix 5766

* fix 6297

* merge 6297 into 5766 uitest

* rename test

5 years ago[iOS] fixes material checkbox color (#6820) fixes #6816
Pavel Yakovlev [Mon, 15 Jul 2019 17:39:21 +0000 (20:39 +0300)]
[iOS] fixes material checkbox color (#6820) fixes #6816

5 years ago[HR] properly reload merged rds
Stephane Delcroix [Fri, 12 Jul 2019 13:40:16 +0000 (15:40 +0200)]
[HR] properly reload merged rds

5 years agoAdd protected GetTemplateChild to ContentPage and ContentView #6747 (#6752)
Andrei Nitescu [Thu, 11 Jul 2019 01:35:25 +0000 (04:35 +0300)]
Add protected GetTemplateChild to ContentPage and ContentView #6747 (#6752)

fixes #6747

5 years ago[X] hide TypedBinding from Intelisense
Stephane Delcroix [Wed, 10 Jul 2019 10:18:17 +0000 (12:18 +0200)]
[X] hide TypedBinding from Intelisense

5 years ago[X] Allow x:Null for x:DataType (#6822)
Stephane Delcroix [Mon, 8 Jul 2019 23:03:32 +0000 (01:03 +0200)]
[X] Allow x:Null for x:DataType (#6822)

- fixes #6648

5 years ago[Shell] Apply Query string parameters even if they aren't present and correctly apply...
Shane Neuville [Wed, 3 Jul 2019 23:57:46 +0000 (17:57 -0600)]
[Shell] Apply Query string parameters even if they aren't present and correctly apply them to nested pages (#6695)

* apply query string parameters if they aren't there
- apply query string parameters correctly to nested pages

* Update Xamarin.Forms.Core/Shell/Shell.cs

Co-Authored-By: Stephane Delcroix <stephane@delcroix.org>
fixes #6543

5 years agoUnhook Page from embedded Application on disposal (#6735)
E.Z. Hart [Wed, 3 Jul 2019 23:46:47 +0000 (17:46 -0600)]
Unhook Page from embedded Application on disposal (#6735)

* Unhook Page from embedded Application on disposal

* Update Xamarin.Forms.Core/Application.cs

fixes #4671

5 years agoMerge branch '4.0.0' into 4.1.0
Samantha Houts [Wed, 3 Jul 2019 23:42:03 +0000 (16:42 -0700)]
Merge branch '4.0.0' into 4.1.0

5 years ago[UWP] fixes crash after reset text color (#6435)
Pavel Yakovlev [Wed, 3 Jul 2019 23:24:57 +0000 (02:24 +0300)]
[UWP] fixes crash after reset text color (#6435)

5 years ago[GTK] Fix navigation (#6692)
nels83 [Wed, 3 Jul 2019 22:59:37 +0000 (00:59 +0200)]
[GTK] Fix navigation (#6692)

Commit 491947606d03647124bffffcea8547e135869027
introduced this change :

* [GTK] Don't recreate the toolbar on each change

However when changing page, toolbar needs to be recreated.

5 years agoRename some tests to better identify purpose and change query to WaitForElement ...
Shane Neuville [Wed, 3 Jul 2019 15:44:14 +0000 (09:44 -0600)]
Rename some tests to better identify purpose and change query to WaitForElement (#6759)

5 years agoMake building easier on Windows by setting PowerShell execution policy (attempt 2...
Eilon Lipton [Tue, 2 Jul 2019 20:36:22 +0000 (13:36 -0700)]
Make building easier on Windows by setting PowerShell execution policy (attempt 2) (#6755)

* Make building easier on Windows by setting PowerShell execution policy

* Update build.cake to reference cmd as well as ps1

* remove . on instructions

5 years agoCherry pick Issue4597 fixes back to branch 4.0.0 (#6724)
Shane Neuville [Mon, 1 Jul 2019 16:42:41 +0000 (10:42 -0600)]
Cherry pick Issue4597 fixes back to branch 4.0.0 (#6724)

* Split up Issue4597 into separate testable chunks (#6654)

* split up tests

* fix tests for ios

* comment out tests for UWP for now

* - add delay for loading from uri
- rearrage components so switch is always visible

* add retry logic to url based tests so images can load

* fix automationid binding

* remove extra file

* fix tabs

5 years agoMerge branch '4.0.0' into 4.1.0
ShaneN [Sun, 30 Jun 2019 16:02:26 +0000 (10:02 -0600)]
Merge branch '4.0.0' into 4.1.0

5 years agorequest layout of measure changes force layout if it doesn't (#6704)
Shane Neuville [Sun, 30 Jun 2019 16:00:34 +0000 (10:00 -0600)]
request layout of measure changes force layout if it doesn't (#6704)

5 years agoMerge branch '4.0.0' into 4.1.0
Rui Marinho [Sat, 29 Jun 2019 14:18:41 +0000 (15:18 +0100)]
Merge branch '4.0.0' into 4.1.0

5 years agoSplit up Issue4597 into separate testable chunks (#6654)
Shane Neuville [Sat, 29 Jun 2019 13:53:38 +0000 (07:53 -0600)]
Split up Issue4597 into separate testable chunks (#6654)

* split up tests

* fix tests for ios

* comment out tests for UWP for now

* - add delay for loading from uri
- rearrage components so switch is always visible

* add retry logic to url based tests so images can load

5 years agoreturn empty dictionary instead of null (#6675) fixes #6614
Shane Neuville [Fri, 28 Jun 2019 10:17:11 +0000 (04:17 -0600)]
return empty dictionary instead of null (#6675) fixes #6614

* return empty dictionary instead of null

* add warning if Element is being reparented

* fix warning message

* only fire warning if parent has inner children

5 years agoMerge branch '4.0.0' into 4.1.0
Samantha Houts [Thu, 27 Jun 2019 23:49:07 +0000 (16:49 -0700)]
Merge branch '4.0.0' into 4.1.0

5 years ago[iOS] Provide a base CarouselViewRenderer (#6686)
Rui Marinho [Thu, 27 Jun 2019 23:34:52 +0000 (00:34 +0100)]
[iOS] Provide a base CarouselViewRenderer (#6686)

* [iOS] Don't provide a CarouselViewRenderer

* [iOS] Fix CarouselViewRenderer

* Update CarouselViewRenderer.cs

5 years agotry to generate more unique names (#6669)
Stephane Delcroix [Thu, 27 Jun 2019 09:30:11 +0000 (11:30 +0200)]
try to generate more unique names (#6669)

- fixes #6668

5 years ago[Tizen] Added support AutomationProperties (#6080)
Kangho Hur [Wed, 26 Jun 2019 16:10:09 +0000 (01:10 +0900)]
[Tizen] Added support AutomationProperties (#6080)

5 years agowait for animation to complete (#6652)
Shane Neuville [Wed, 26 Jun 2019 15:57:26 +0000 (09:57 -0600)]
wait for animation to complete (#6652)

5 years ago[X] resolve event handlers in base generic types (#6194)
Stephane Delcroix [Wed, 26 Jun 2019 12:35:54 +0000 (14:35 +0200)]
[X] resolve event handlers in base generic types (#6194)

* [XamlC] fix Debug harness generation code

* [X] resolve event handlers in base generic types

- fixes #6176

5 years agoIssue1733 change Query to WaitForElement (#6588)
Shane Neuville [Wed, 26 Jun 2019 04:52:09 +0000 (22:52 -0600)]
Issue1733 change Query to WaitForElement (#6588)

- rename test

5 years agoBackport41 (#6651)
Stephane Delcroix [Tue, 25 Jun 2019 22:20:55 +0000 (00:20 +0200)]
Backport41 (#6651)

* use a BP for QueryAttributes (#6569)

* use a BP for QueryAttributes

* Update Xamarin.Forms.Core/Shell/ShellContent.cs

* Allow tracking of StyleSheets (#6502)

* remove excess code and clean up sandbox (#6503)

* Allow tracking of StyleSheets

*  ¯\_(ツ)_/¯

5 years agoDon't reset implicit style (#6641) (#6641)
Andrei Nitescu [Tue, 25 Jun 2019 18:45:50 +0000 (21:45 +0300)]
Don't reset implicit style (#6641) (#6641)

fixes #6635

5 years agoUndo broken change in un-watching empty view observer;
E.Z. Hart [Mon, 24 Jun 2019 19:47:46 +0000 (13:47 -0600)]
Undo broken change in un-watching empty view observer;
This may cause a small leak in some corner cases, but that leak is fixed by

5 years agoClean up Platform on PlatformRenderer disposal: fixes #4671 (#6636)
E.Z. Hart [Mon, 24 Jun 2019 19:01:57 +0000 (13:01 -0600)]
Clean up Platform on PlatformRenderer disposal: fixes #4671 (#6636)

5 years agoMerge branch '4.0.0' into 4.1.0
Samantha Houts [Fri, 21 Jun 2019 00:10:59 +0000 (17:10 -0700)]
Merge branch '4.0.0' into 4.1.0

5 years agoUpdate ItemsViewLayout.cs (#6583)
E.Z. Hart [Thu, 20 Jun 2019 17:48:36 +0000 (11:48 -0600)]
Update ItemsViewLayout.cs (#6583)

Unsubscribe from PropertyChanged during Dispose() on ItemsViewLayout (iOS).

5 years agoImplement ItemSizingStrategy.MeasureFirstItem on Android (#6422)
E.Z. Hart [Thu, 20 Jun 2019 02:28:43 +0000 (20:28 -0600)]
Implement ItemSizingStrategy.MeasureFirstItem on Android (#6422)

* Implement ItemSizingStrategy.MeasureFirstItem on Android

* Remove unnecessary method

5 years ago[UWP] fixes hangs ListView when using Narrator (#6431)
Pavel Yakovlev [Thu, 20 Jun 2019 02:27:53 +0000 (19:27 -0700)]
[UWP] fixes hangs ListView when using Narrator (#6431)

fixes #5340

5 years ago[Android] Dispose the collection view item adapter (#6525)
Kevin Petit [Thu, 20 Jun 2019 02:27:25 +0000 (04:27 +0200)]
[Android] Dispose the collection view item adapter (#6525)

* [Android] Dispose the collection view adapter.

* More complete fix.

5 years ago[Android] Hamburger icon not shown when using FormsAppCompatActivity (#6548)
Gerald Versluis [Thu, 20 Jun 2019 02:27:04 +0000 (04:27 +0200)]
[Android] Hamburger icon not shown when using FormsAppCompatActivity (#6548)

* Update NavigationPageRenderer.cs

* Add reproduction for #2577

* Update NavigationPageRenderer.cs

* Taking into account MasterDetailPage and GetHasBackButton correctly

* Update NavigationPageRenderer.cs
fixes #2577

5 years agoMerge branch '3.6.0' into 4.0.0
Samantha Houts [Thu, 20 Jun 2019 02:25:10 +0000 (19:25 -0700)]
Merge branch '3.6.0' into 4.0.0

5 years agodon't setup webview if running as designer (#6592)
Shane Neuville [Wed, 19 Jun 2019 23:52:31 +0000 (17:52 -0600)]
don't setup webview if running as designer (#6592)

5 years agoAdded missing named sizes (#6591)
Gerald Versluis [Wed, 19 Jun 2019 23:40:59 +0000 (01:40 +0200)]
Added missing named sizes (#6591)

fixes #6517

5 years agoMake ShellTabLayoutAppearanceTracker public (#6530)
Gerald Versluis [Wed, 19 Jun 2019 23:30:33 +0000 (01:30 +0200)]
Make ShellTabLayoutAppearanceTracker public (#6530)

fixes #6529

5 years ago[Android] Fixes loading image from uri (#6394)
Pavel Yakovlev [Wed, 19 Jun 2019 23:26:41 +0000 (16:26 -0700)]
[Android] Fixes loading image from uri (#6394)

* [Android] Fixes loading image form uri

* - modified Issue4597 test

* nested function is removed

* moved redundant code

* Update Xamarin.Forms.Platform.Android/Extensions/ImageViewExtensions.cs

Co-Authored-By: Pavel Yakovlev <v-payako@microsoft.com>
fixes #6313

5 years ago[Android] Fixes layout in AppCompat ButtonRenderer (#6329)
Pavel Yakovlev [Wed, 19 Jun 2019 23:24:51 +0000 (16:24 -0700)]
[Android] Fixes layout in AppCompat ButtonRenderer (#6329)

* [Android] Fixes layout in AppCompact ButtonRenderer

* - fixes button alignment when fast changing padding
- fixes material button alignment

* refactoring

* forceLayout

* generalize force layout

* if APP check on ui test
fixes #6282

5 years ago[Android] fix accessibility of Picker (#5125)
Pavel Yakovlev [Wed, 19 Jun 2019 23:23:00 +0000 (16:23 -0700)]
[Android] fix accessibility of Picker (#5125)

* [Android] fix accessibility of Picker

* fix NRE

* fixes read selected item with accessibility

* refactoring test

* added dispose of accessibility delegate

* fix build uitest

* Update Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue3454.cs

Co-Authored-By: paymicro <v-payako@microsoft.com>
* Update Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue3454.cs

Co-Authored-By: paymicro <v-payako@microsoft.com>
5 years ago[Android] Add disposed check to MasterDetailPageRenderer (#6354)
Samantha Houts [Wed, 19 Jun 2019 22:55:59 +0000 (15:55 -0700)]
[Android] Add disposed check to MasterDetailPageRenderer (#6354)

* [Android] Add disposed check to MasterDetailPageRenderer

Co-Authored-By: Felipe Silveira <transis2@users.noreply.github.com>
* Fix dispose pattern

a la #6305

* apply same set of changes to NavigationPageRenderer

fixes #3489
closes #4586

5 years ago[Android] hide keyboard after tapping on pickers (#6284)
Pavel Yakovlev [Wed, 19 Jun 2019 22:54:00 +0000 (15:54 -0700)]
[Android] hide keyboard after tapping on pickers (#6284)

fixes #6235

5 years agoMerge branch '4.0.0' into 4.1.0
Rui Marinho [Wed, 19 Jun 2019 22:49:12 +0000 (23:49 +0100)]
Merge branch '4.0.0' into 4.1.0

5 years agoMerge branch '3.6.0' into 4.0.0
Rui Marinho [Wed, 19 Jun 2019 22:48:36 +0000 (23:48 +0100)]
Merge branch '3.6.0' into 4.0.0

5 years agoDynamic view gallery support all Enum properties (#6434)
Pavel Yakovlev [Wed, 19 Jun 2019 18:45:54 +0000 (11:45 -0700)]
Dynamic view gallery support all Enum properties (#6434)

5 years ago[UITests] Wait a little bit longer for go to test button to appear (#6570)
Shane Neuville [Wed, 19 Jun 2019 17:21:08 +0000 (11:21 -0600)]
[UITests] Wait a little bit longer for go to test button to appear (#6570)

5 years ago[Android] Fixed applying effects to Frames (#6412)
Andrei [Wed, 19 Jun 2019 16:59:32 +0000 (19:59 +0300)]
[Android] Fixed applying effects to Frames (#6412)

* [Android] Fixed effects applying to Frame

fixes https://github.com/xamarin/Xamarin.Forms/issues/3548

* Added ui test case

* added UITest

* fixed test case's affected platform

Co-Authored-By: Shane Neuville <shane94@hotmail.com>
5 years agoSet ExceptionHandler on HydrationContext in ApplyPropertiesVisitor.SetTemplate()...
Tim Barham [Wed, 19 Jun 2019 08:31:30 +0000 (18:31 +1000)]
Set ExceptionHandler on HydrationContext in ApplyPropertiesVisitor.SetTemplate() (#6573)

5 years agoMerge 4.0.0 into 4.1.0
ShaneN [Tue, 18 Jun 2019 16:42:55 +0000 (10:42 -0600)]
Merge 4.0.0 into 4.1.0

5 years ago[Build] Don't push NuGet packages from build
Rui Marinho [Tue, 18 Jun 2019 12:01:26 +0000 (13:01 +0100)]
[Build] Don't push NuGet packages from build

5 years agowait for test to finish so it doesn't break later tests (#6562)
Shane Neuville [Tue, 18 Jun 2019 10:21:30 +0000 (04:21 -0600)]
wait for test to finish so it doesn't break later tests (#6562)

5 years ago[Android] Fix context actions icon so that it loads (#6437) fixes #6258
Shane Neuville [Tue, 18 Jun 2019 10:20:37 +0000 (04:20 -0600)]
[Android] Fix context actions icon so that it loads (#6437) fixes #6258

* fix icon load loading and setting accessibility on menuitem

* instructions

* clean up

* Update Xamarin.Forms.Platform.Android/Extensions/AccessibilityExtensions.cs

Co-Authored-By: Pavel Yakovlev <v-payako@microsoft.com>
* Update Xamarin.Forms.Platform.Android/ResourceManager.cs

* Update Xamarin.Forms.Platform.Android/CellAdapter.cs

Co-Authored-By: Pavel Yakovlev <v-payako@microsoft.com>
* Fix load TitleIcon on non app compact

* apply valid check one more place

* automate titleicon fixes

* fix ui tests and removed _isdisposed

* toolbaritem ui test tweaks

* toolbar tweaks

* ios toolbaritem tweak

* update menuitem to read like other platforms

* retain automationid if content desc not set

5 years agoAdd Intellisense for vertical/horizontal list options in CollectionView (#6537)
E.Z. Hart [Tue, 18 Jun 2019 09:20:02 +0000 (03:20 -0600)]
Add Intellisense for vertical/horizontal list options in CollectionView (#6537)

5 years agoFix occasional disappearing content in CV items on UWP (#6465)
E.Z. Hart [Mon, 17 Jun 2019 22:46:18 +0000 (16:46 -0600)]
Fix occasional disappearing content in CV items on UWP (#6465)

fixes #4658

5 years ago[iOS] Fix missing partial columns in horizontal grid layout (#6241)
E.Z. Hart [Mon, 17 Jun 2019 21:07:32 +0000 (15:07 -0600)]
[iOS] Fix missing partial columns in horizontal grid layout (#6241)

* Create repro

* Work around UICollectionViewFlowLayout bug to display partial columns; fixes #6077
Fix content inset behaviors when dealing with safe area on newer iOS versions

* Add check for case where there is only a single partial column

* Works better if I don't forget the return statement

* Split up tests to make it easier to determine what failed

* Fix bounds exception when changing to a smaller ItemsSource

* Add preserve attributes so the linker won't ruin my UI test

* Fix missing using after rebase

5 years agoFix for layouts in a cell to expand on resize (WPF) Issue #5682 (#6179)
jaytilly [Mon, 17 Jun 2019 11:47:26 +0000 (04:47 -0700)]
Fix for layouts in a cell to expand on resize (WPF) Issue #5682 (#6179)

* Added fix for grids in a cell to expand on resize

* Added check for expand before expanding grid

* Removed unused using

* Made the resize fix more generic

* Removed generic constraint on type check for layout controls on resize for children of cell control

5 years ago[Android] Fixes work IsClippedToBounds on (Fast Renderer) Frame (#6358) fixes #3150...
Pavel Yakovlev [Mon, 17 Jun 2019 11:43:11 +0000 (04:43 -0700)]
[Android] Fixes work IsClippedToBounds on (Fast Renderer) Frame (#6358) fixes #3150 fixes #6447

* [Android] Fixes work IsClippedToBounds on (Fast Renderer) Frame
- fixes float values in Dynamic ViewGallery

* added on-screen instructions for test

* added API check

* added SetClipToOutline to ViewExtensions

* added button to toggle IsClippedToBounds

5 years agoMerge branch '3.6.0' into 4.0.0
Rui Marinho [Mon, 17 Jun 2019 11:15:59 +0000 (12:15 +0100)]
Merge branch '3.6.0' into 4.0.0

5 years ago[ios] change checkbox to use default constructor (#6512)
Shane Neuville [Fri, 14 Jun 2019 19:07:17 +0000 (13:07 -0600)]
[ios] change checkbox to use default constructor (#6512)

5 years agoadd checkbox style to nuspec (#6504)
Shane Neuville [Thu, 13 Jun 2019 20:29:39 +0000 (14:29 -0600)]
add checkbox style to nuspec (#6504)

fixes #6501

5 years ago[iOS] adds a flag to ios if user needs to disable accessibility sizing for named...
Shane Neuville [Thu, 13 Jun 2019 19:59:01 +0000 (13:59 -0600)]
[iOS] adds a flag to ios if user needs to disable accessibility sizing for named font sizes (#6345)

* adds a flag to ios if user needs to disable accessibility sizing for named font sizes

* move setting to platform specific

* move to mobile if defs

* move comment back

* move comment back

* invert and delete

5 years ago[Android] Retrieve PackageName from the correct Platform instance (#6420)
Shane Neuville [Thu, 13 Jun 2019 19:57:30 +0000 (13:57 -0600)]
[Android] Retrieve PackageName from the correct Platform instance (#6420)

* Fix getting packagename and pass context into RM
- fixes #6327

* spacing

5 years agoResolve fallback type before trying to make constructed generic type (#6511)
Tim Barham [Thu, 13 Jun 2019 18:21:55 +0000 (04:21 +1000)]
Resolve fallback type before trying to make constructed generic type (#6511)

* Resolve fallback type before trying to make constructed generic type

The FallbackTypeResolver hander in the Forms previewer does not have access to the x:TypeArguments attribute, so if it constructs a proxy generic type from metadata it can't construct it. So the previewer has to create an unconstructed generic type, and Forms will need to construct it.

So we need to move the code that constructs the generic type after the call to FallbackTypeResolver.

(cherry picked from commit 5acfea4f457453856a8905002f4d35c8e9aad106)

* Fix error building DesignTimeLoaderTests in 4.1

5 years ago[Android, iOS] Item Spacing for CollectionView (#6478) fixes #4681
E.Z. Hart [Thu, 13 Jun 2019 18:17:10 +0000 (12:17 -0600)]
[Android, iOS] Item Spacing for CollectionView (#6478) fixes #4681

* First pass at item spacing for CollectionView ListItemsLayout on Android

* Handle GridItemsLayout spacing on Android

* Change spacings from int -> double
Implement spacing on iOS

* Remove old TODO comment

5 years ago[iOS] Protect against SetNativeControl when no Element is present (#6415) fixes ...
Rui Marinho [Thu, 13 Jun 2019 13:21:09 +0000 (14:21 +0100)]
[iOS] Protect against SetNativeControl when no Element is present (#6415) fixes #6368 fixes #6328

* [Controls] Add repo for issue #6368 and #6328

* [iOS] Protect against no Element from CustomRenderers bad usage

* [Controls] Drop private on sample code

5 years agoremove excess code and clean up sandbox (#6503)
Shane Neuville [Wed, 12 Jun 2019 23:42:25 +0000 (17:42 -0600)]
remove excess code and clean up sandbox (#6503)

5 years ago[UWP] Fixes IndexOutOfRangeException on TabbedPage (#6385)
Pavel Yakovlev [Wed, 12 Jun 2019 23:41:46 +0000 (16:41 -0700)]
[UWP] Fixes IndexOutOfRangeException on TabbedPage (#6385)

* [UWP] Fixes IndexOutOfRangeException on TabbedPage

* add tab page category

* fix update colors

* optimization

5 years agoMerge branch '4.0.0' into 4.1.0
Rui Marinho [Tue, 11 Jun 2019 09:09:30 +0000 (10:09 +0100)]
Merge branch '4.0.0' into 4.1.0

5 years agoMerge branch '3.6.0' into 4.0.0
Rui Marinho [Tue, 11 Jun 2019 09:08:29 +0000 (10:08 +0100)]
Merge branch '3.6.0' into 4.0.0

5 years ago[UWP] fixes ListView displays null values black (#6211)
Pavel Yakovlev [Sat, 8 Jun 2019 01:11:42 +0000 (18:11 -0700)]
[UWP] fixes ListView displays null values black (#6211)

fixes #6154
fixes #6233

5 years ago[Android] fixes ListView pull-to-refresh gesture in non-data areas (#5417) fixes...
Pavel Yakovlev [Thu, 6 Jun 2019 13:55:17 +0000 (06:55 -0700)]
[Android] fixes ListView pull-to-refresh gesture in non-data areas (#5417) fixes #5268

* [Android] fixes ListView pull-to-refresh gesture in non-data areas

* refactoring

* addressing comments

5 years agoMerge branch '4.0.0' into 4.1.0
Samantha Houts [Thu, 6 Jun 2019 04:15:41 +0000 (21:15 -0700)]
Merge branch '4.0.0' into 4.1.0

5 years agoMerge branch '3.6.0' into 4.0.0
Samantha Houts [Thu, 6 Jun 2019 04:10:49 +0000 (21:10 -0700)]
Merge branch '3.6.0' into 4.0.0

5 years ago[iOS] Fix Bounds for PageContainer (#6405)
Rui Marinho [Thu, 6 Jun 2019 04:07:59 +0000 (05:07 +0100)]
[iOS] Fix Bounds for PageContainer  (#6405)

* [Controls] Add repo for issue #6334

* [iOS] Give a default size to the PageContainer so Effects can use Bounds

* {UITests] Update AutomationID

fixes #6334
fixes #6372

5 years agoreadd IVT
Stephane Delcroix [Wed, 5 Jun 2019 19:22:14 +0000 (21:22 +0200)]
readd IVT

5 years ago[WPF] restore missed assembly attribute (#6418) fixes #6399
Pavel Yakovlev [Wed, 5 Jun 2019 16:09:17 +0000 (09:09 -0700)]
[WPF] restore missed assembly attribute (#6418) fixes #6399

5 years agohandle implicit resources (#6416)
Stephane Delcroix [Wed, 5 Jun 2019 13:23:04 +0000 (15:23 +0200)]
handle implicit resources (#6416)

5 years ago[CSS] workaround for corner-radius (#6401)
Stephane Delcroix [Wed, 5 Jun 2019 06:26:51 +0000 (08:26 +0200)]
[CSS] workaround for corner-radius (#6401)

Frame and Button implement IBorderElement bot do not share the CornerRadiusProperty.
This ifx workaround that so the CSS engine is not confused. This is a workaround,
a proper, but breaking, change is required and will happen on master

5 years agoMerge branch '3.6.0' into 4.0.0
ShaneN [Tue, 4 Jun 2019 23:49:27 +0000 (17:49 -0600)]
Merge branch '3.6.0' into 4.0.0

5 years agoCherry pick Tizen project changes to 4.0.0 and modify SLN changes VS makes (#6396)
Shane Neuville [Tue, 4 Jun 2019 23:48:29 +0000 (17:48 -0600)]
Cherry pick Tizen project changes to 4.0.0 and modify SLN changes VS makes (#6396)

* [Tizen] Add TFM identifier and version explictly for vs2019 16.1 (#6304)

* sln changes that vs wants to apply

5 years agoCherry pick Tizen project changes to 3.6.0 and modify SLN changes VS makes (#6407)
Shane Neuville [Tue, 4 Jun 2019 23:47:21 +0000 (17:47 -0600)]
Cherry pick Tizen project changes to 3.6.0 and modify SLN changes VS makes (#6407)

* [Tizen] Add TFM identifier and version explictly for vs2019 16.1 (#6304)

* sln changes that vs wants to apply

5 years agoSpeed up core UI tests and reduce flakiness (#6395)
E.Z. Hart [Tue, 4 Jun 2019 18:28:21 +0000 (12:28 -0600)]
Speed up core UI tests and reduce flakiness (#6395)

* Speed up ViewUITests and hopefully reduce flakiness

* Make focus tests work even when keyboard pops up

* Move Date/Time picker tests to the end so they can't break the other bubbling tests
Add delay before trying to dismiss dialogs so they can fully appear

* Fix accidental triggering of Picker when removing focus from Entry

* Bump up number of tests before restart