reed@google.com [Fri, 14 Mar 2014 17:26:15 +0000 (17:26 +0000)]
remove SK_SUPPORT_LEGACY_WRITEPIXELSCONFIG
BUG=skia:
Review URL: https://codereview.chromium.org/
200533002
git-svn-id: http://skia.googlecode.com/svn/trunk@13808
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Fri, 14 Mar 2014 17:24:05 +0000 (17:24 +0000)]
remove SK_SUPPORT_LEGACY_GETDEVICECAPABILITIES
BUG=skia:
Review URL: https://codereview.chromium.org/
195763023
git-svn-id: http://skia.googlecode.com/svn/trunk@13807
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Fri, 14 Mar 2014 16:48:39 +0000 (16:48 +0000)]
Revert "Implement support for expanding crop rects in image filters"
Breaking ImageFilterTests unit test.
TBR=bsalomon@google.com
BUG=skia:
Review URL: https://codereview.chromium.org/
196353021
git-svn-id: http://skia.googlecode.com/svn/trunk@13806
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Fri, 14 Mar 2014 16:35:08 +0000 (16:35 +0000)]
Implement support for expanding crop rects in image filters
NOTE: this patch set is based on https://codereview.chromium.org/
189913021/,
and needs that patch to land first.
Until now, crop rects in Skia have only been able to reduce
the size of the destination bounds, but not expand them.
SVG semantics require the latter as well. The heart of
the change is in applyCropRect(), which now assigns each
edge, instead of doing an intersection with the crop rect.
In order to support this (and still work well with tiled
drawing) we need to clip the resulting crop rect to the
clipping region of the filters. This uses the Context struct
previously landed from https://codereview.chromium.org/
189913021/.
Many of the pixel loops are not yet ready to handle a
destination rect larger than the source rect. So we provide
a convenience version of applyCropRect() which creates an
offscreen and pads it out with transparent black. Once the
pixel loops and shaders have been fixed to support larger
destination bounds, they should be switched back to the
non-drawing version of applyCropRect().
BUG=skia:
R=bsalomon@google.com, reed@google.com
Review URL: https://codereview.chromium.org/
198003008
git-svn-id: http://skia.googlecode.com/svn/trunk@13805
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 14 Mar 2014 15:50:39 +0000 (15:50 +0000)]
tools/roll_deps: add '-m tryserver.chromium' to git-cl-try
R=rmistry@google.com
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/
200203003
git-svn-id: http://skia.googlecode.com/svn/trunk@13804
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Fri, 14 Mar 2014 15:44:01 +0000 (15:44 +0000)]
Implement support for a Context parameter in image filters
Some upcoming work (support for expanding crop rects) requires
the clip bounds to be available during filter traversal. This change
replaces the SkMatrix parameter in the onFilterImage() traversals
with a Context parameter. It contains the CTM, as well as the clip
bounds.
BUG=skia:
R=reed@google.com
Review URL: https://codereview.chromium.org/
189913021
git-svn-id: http://skia.googlecode.com/svn/trunk@13803
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Fri, 14 Mar 2014 14:02:58 +0000 (14:02 +0000)]
check for null-device pixels in onWritePixels, so we don't crash
https://code.google.com/p/chromium/issues/detail?id=352616
Review URL: https://codereview.chromium.org/
196223013
git-svn-id: http://skia.googlecode.com/svn/trunk@13802
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Fri, 14 Mar 2014 12:32:07 +0000 (12:32 +0000)]
keep kVector enum in legacy mode for getDeviceProperties
git-svn-id: http://skia.googlecode.com/svn/trunk@13801
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Fri, 14 Mar 2014 03:02:26 +0000 (03:02 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@13800
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 13 Mar 2014 20:03:58 +0000 (20:03 +0000)]
De-virtualize SkCanvas matrix ops.
This moves the matrix management logic into non-virtual SkCanvas
methods, and turns the virtuals into protected notifiers.
R=reed@google.com, robertphillips@google.com, bsalomon@google.com
BUG=skia:2297
Author: fmalita@chromium.org
Review URL: https://codereview.chromium.org/
195793012
git-svn-id: http://skia.googlecode.com/svn/trunk@13799
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 13 Mar 2014 19:45:41 +0000 (19:45 +0000)]
Added Z scale when X and Y scale to spot lights and point lights
Z scale is set as the average of X scale and Y scale.
BUG=skia:
R=senorblanco@google.com, senorblanco@chromium.org
Author: sugoi@chromium.org
Review URL: https://codereview.chromium.org/
198013002
git-svn-id: http://skia.googlecode.com/svn/trunk@13798
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 13 Mar 2014 19:38:10 +0000 (19:38 +0000)]
getDeviceCapabilities is no longer need, so remove it
BUG=skia:
R=bungeman@google.com, vandebo@chromium.org
Author: reed@google.com
Review URL: https://codereview.chromium.org/
198943003
git-svn-id: http://skia.googlecode.com/svn/trunk@13797
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Thu, 13 Mar 2014 19:20:32 +0000 (19:20 +0000)]
Attempt to fix -1->unsigned warning on mac 10.6
TBR=bungeman@google.com
Review URL: https://codereview.chromium.org/
199433002
git-svn-id: http://skia.googlecode.com/svn/trunk@13796
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 13 Mar 2014 18:02:17 +0000 (18:02 +0000)]
Allow toString capability to be toggled independent of developer mode.
This change is motivated by the desire to see the text information in the debugger when not in developer mode. It is structured so user's can disable it if the capability is not wanted.
R=bsalomon@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
197763008
git-svn-id: http://skia.googlecode.com/svn/trunk@13795
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 13 Mar 2014 18:01:05 +0000 (18:01 +0000)]
Add effect-based clip for nine-patch SkRRects.
BUG=skia:2181
R=jvanverth@google.com, robertphillips@google.com, rmistry@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
194703011
git-svn-id: http://skia.googlecode.com/svn/trunk@13794
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Thu, 13 Mar 2014 17:51:05 +0000 (17:51 +0000)]
Add comment for gcc compiler bug work-around for SK_COMPILE_ASSERT.
If this comment had existed previously, I could have avoided breaking
some bots.
R=bsalomon@google.com
Review URL: https://codereview.chromium.org/
196473013
git-svn-id: http://skia.googlecode.com/svn/trunk@13793
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 13 Mar 2014 17:44:01 +0000 (17:44 +0000)]
make rebaseline_server client check schema version number
(SkipBuildbotRuns)
NOTREECHECKS=True
NOTRY=True
R=rmistry@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
195763013
git-svn-id: http://skia.googlecode.com/svn/trunk@13792
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 13 Mar 2014 17:11:44 +0000 (17:11 +0000)]
Fix distance field edge detection.
When computing the initial edges for distance field generation, I was skipping
the outer pixels of glyphs to avoid accessing out of range memory. However,
there might be an edge transition on those pixels. This detects those cases.
R=robertphillips@google.com
Author: jvanverth@google.com
Review URL: https://codereview.chromium.org/
197423003
git-svn-id: http://skia.googlecode.com/svn/trunk@13791
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 13 Mar 2014 16:33:36 +0000 (16:33 +0000)]
add schema version to rebaseline_server intermediate JSON
NOTREECHECKS=True
NOTRY=True
R=rmistry@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
196343009
git-svn-id: http://skia.googlecode.com/svn/trunk@13790
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 13 Mar 2014 16:24:49 +0000 (16:24 +0000)]
Changes to SkFontHost_linux
* Use SkOSPath::SkPathJoin() rather than append so that
SK_FONT_FILE_PREFIX does not have to end in a '/'.
* Add another font to the default font list.
Motivation: Some tests fail when there are no default fonts.
BUG=skia:2282
R=bungeman@google.com
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/
195733007
git-svn-id: http://skia.googlecode.com/svn/trunk@13789
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 13 Mar 2014 16:23:20 +0000 (16:23 +0000)]
Mark strokerects_gpu GM as ignore-failure on Win7/Perspective
BUG=skia:2295
R=bsalomon@google.com, epoger@google.com
Author: borenet@google.com
Review URL: https://codereview.chromium.org/
198923003
git-svn-id: http://skia.googlecode.com/svn/trunk@13788
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 13 Mar 2014 16:22:00 +0000 (16:22 +0000)]
--dryRun flag for bench
causes bench to print out what tests it would be running, without actually running them.
BUG=skia:2294
R=reed@google.com
Author: humper@google.com
Review URL: https://codereview.chromium.org/
197873010
git-svn-id: http://skia.googlecode.com/svn/trunk@13787
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 13 Mar 2014 16:18:49 +0000 (16:18 +0000)]
fix memory leak introduced in
9e5f85e8
R=sugoi@chromium.org, robertphillips@google.com
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/
199173002
git-svn-id: http://skia.googlecode.com/svn/trunk@13786
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 13 Mar 2014 16:16:36 +0000 (16:16 +0000)]
--dryRun flag for gm
Causes gm to not actually run any tests / create any directories, just print its normal output. Useful for showing what tests would be run without actually taking the time to run them.
BUG=skia:2294
R=reed@google.com
Author: humper@google.com
Review URL: https://codereview.chromium.org/
199093002
git-svn-id: http://skia.googlecode.com/svn/trunk@13785
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Thu, 13 Mar 2014 15:33:02 +0000 (15:33 +0000)]
New GPU baselines for colormatrix GM.
TBR=halcanary@google.com
BUG=skia:
Review URL: https://codereview.chromium.org/
198973003
git-svn-id: http://skia.googlecode.com/svn/trunk@13784
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 13 Mar 2014 14:56:29 +0000 (14:56 +0000)]
rebaseline_server: generate JSON that can be viewed without a live server
BUG=skia:1919
NOTREECHECKS=True
NOTRY=True
R=rmistry@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
195943004
git-svn-id: http://skia.googlecode.com/svn/trunk@13783
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Thu, 13 Mar 2014 03:02:23 +0000 (03:02 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@13782
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Wed, 12 Mar 2014 21:56:23 +0000 (21:56 +0000)]
Add required parens for r13779.
git-svn-id: http://skia.googlecode.com/svn/trunk@13781
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 12 Mar 2014 21:47:51 +0000 (21:47 +0000)]
remove SK_SUPPORT_LEGACY_COPYTO_CONFIG
TBR=robertphillips@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/
196413009
git-svn-id: http://skia.googlecode.com/svn/trunk@13780
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Wed, 12 Mar 2014 21:41:06 +0000 (21:41 +0000)]
Fix (1 << 31) to (1u << 31) in SkOTTable_OS_2.
When ints are 32 bits, (1 << 31) is undefined.
R=reed@google.com
Committed: https://code.google.com/p/skia/source/detail?r=13757
Review URL: https://codereview.chromium.org/
189093020
git-svn-id: http://skia.googlecode.com/svn/trunk@13779
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Wed, 12 Mar 2014 21:37:42 +0000 (21:37 +0000)]
Fix GPU colormatrix color filter with saturated alpha.
Clamp RGBA values before unpremultiplying, to match the raster path. This causes a problem when the resulting
alpha is >1.0, resulting in overly saturated RGB.
Covered by the setYUV2RGB() test case in the colormatrix GM.
R=bsalomon@google.com
Review URL: https://codereview.chromium.org/
196133006
git-svn-id: http://skia.googlecode.com/svn/trunk@13778
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 12 Mar 2014 20:31:24 +0000 (20:31 +0000)]
add gm to show bug in stroked-text in drawPosText
BUG=skia:
R=fmalita@google.com, bungeman@google.com, fmalita@chromium.org
Author: reed@google.com
Review URL: https://codereview.chromium.org/
198083003
git-svn-id: http://skia.googlecode.com/svn/trunk@13777
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 12 Mar 2014 20:21:48 +0000 (20:21 +0000)]
De-virtualize SkCanvas save/restore.
This moves the state management logic into non-virtual SkCanvas methods,
and turns the virtuals into protected notifiers.
R=reed@google.com, robertphillips@google.com
Author: fmalita@chromium.org
Review URL: https://codereview.chromium.org/
194713008
git-svn-id: http://skia.googlecode.com/svn/trunk@13776
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 12 Mar 2014 20:09:46 +0000 (20:09 +0000)]
render_pictures unittests: run over a dir with multiple SKPs, like production
BUG=skia:1942
R=borenet@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
194563004
git-svn-id: http://skia.googlecode.com/svn/trunk@13775
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Wed, 12 Mar 2014 18:28:35 +0000 (18:28 +0000)]
support direct writing to top layer, and hide getTopLayer()
this should remove many of the chrome callers that today call
accessBitmap on the toplayer, so they can read/write those pixels.
The ultimate fix will be to support custom allocation of raster layers
(via GDI/cairo/mac) so we can remove PlatformDevice subclassing in
skia/ext
BUG=skia:
R=bsalomon@google.com, scroggo@google.com
Review URL: https://codereview.chromium.org/
197433002
git-svn-id: http://skia.googlecode.com/svn/trunk@13774
2bbb7eff-a529-9590-31e7-
b0007b416f81
fmalita@google.com [Wed, 12 Mar 2014 17:31:20 +0000 (17:31 +0000)]
Remove unused zero_fill() in GrAtlas.cpp
Triggers warnings with some local clang builds.
R=jvanverth@google.com
Review URL: https://codereview.chromium.org/
197663003
git-svn-id: http://skia.googlecode.com/svn/trunk@13773
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Wed, 12 Mar 2014 17:29:46 +0000 (17:29 +0000)]
Fix unit tests
Review URL: https://codereview.chromium.org/
197823002
git-svn-id: http://skia.googlecode.com/svn/trunk@13772
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Wed, 12 Mar 2014 17:16:59 +0000 (17:16 +0000)]
Fix for test failure
git-svn-id: http://skia.googlecode.com/svn/trunk@13771
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 12 Mar 2014 17:05:46 +0000 (17:05 +0000)]
Add compile flag to force usage of distance fields for all SkPaints.
BUG=skia:2173
R=reed@google.com, robertphillips@google.com
Author: jvanverth@google.com
Review URL: https://codereview.chromium.org/
195213003
git-svn-id: http://skia.googlecode.com/svn/trunk@13770
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 12 Mar 2014 17:04:28 +0000 (17:04 +0000)]
Add capture snapshot as data to SkWriter32, use it to optimise record->playback.
This is a new way of implementing https://codereview.chromium.org/
155863005/
It uses copy on write semantics to return a buffer without copying it, so that record -> playback does not need to copy the buffer.
BUG=skia:2125
R=tomhudson@google.com, mtklein@google.com, reed@google.com, iancottrell@chromium.org
Author: iancottrell@google.com
Review URL: https://codereview.chromium.org/
167113003
git-svn-id: http://skia.googlecode.com/svn/trunk@13769
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 12 Mar 2014 16:36:08 +0000 (16:36 +0000)]
Clean up SkImageFilter.
Rename more occurences of 'target' to 'kernelOffset'.
This is a follow-up patch to
https://codereview.chromium.org/
182983003/
BUG=skia:2187
R=senorblanco@chromium.org
Author: dominikg@chromium.org
Review URL: https://codereview.chromium.org/
197013003
git-svn-id: http://skia.googlecode.com/svn/trunk@13768
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 12 Mar 2014 16:23:33 +0000 (16:23 +0000)]
Stores per-iteration bench values in BenchDataPoint.
BUG=skia:2225
NOTRY=true
R=borenet@google.com
Author: bensong@google.com
Review URL: https://codereview.chromium.org/
197573002
git-svn-id: http://skia.googlecode.com/svn/trunk@13767
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 12 Mar 2014 15:32:50 +0000 (15:32 +0000)]
Add elliptical-corner rrect clip effect. Currently only handles the case where all corners have the same pair of radii.
BUG=skia:2181
R=jvanverth@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
194603004
git-svn-id: http://skia.googlecode.com/svn/trunk@13766
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 12 Mar 2014 15:08:22 +0000 (15:08 +0000)]
Revert of Revert of Revert "De-virtualize SkCanvas save/restore." (https://codereview.chromium.org/
196323003/)
Reason for revert:
Pulling out to rename the virtuals.
Original issue's description:
> Revert of Revert "De-virtualize SkCanvas save/restore." (https://codereview.chromium.org/
194923008/)
>
> Reason for revert:
> Re-landing after roll fix.
>
> Original issue's description:
> > Revert "De-virtualize SkCanvas save/restore."
> >
> > (To allow a roll fix into the tree).
> >
> > This reverts commit
edf702204be42c945254191f9f9cd6585b3d189b.
> >
> > R=halcanary@google.com
> >
> > Committed: https://code.google.com/p/skia/source/detail?r=13748
>
> TBR=halcanary@google.com,fmalita@chromium.org
> NOTREECHECKS=true
> NOTRY=true
>
> Committed: http://code.google.com/p/skia/source/detail?r=13754
R=halcanary@google.com, fmalita@chromium.org
TBR=fmalita@chromium.org, halcanary@google.com
NOTREECHECKS=true
NOTRY=true
Author: fmalita@google.com
Review URL: https://codereview.chromium.org/
197553002
git-svn-id: http://skia.googlecode.com/svn/trunk@13765
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 12 Mar 2014 14:46:41 +0000 (14:46 +0000)]
Fixing SkPicture serialization
Fixed a few issues while attempting to use the new
serialization path for SkPicture inside a fuzzer:
- SkReadBuffer and SkValidatingReadBuffer both had a fReader
member instead of sharing the same member, which leads to
problems if a base class function is used
- In SkPicture, a header is now written as a single chunk of
data, so it also has to be read as a single chunk of data
- In the SkPicturePlayback destructor, a bad deserialization
would lead to a crash if we don't safely unref fOpData
- Also in SkPicturePlayback, if we only use a ReadBuffer for
the whole deserialization, additional tags must be added to
parseBufferTag()
- SkValidatingReadBuffer::readBitmap() was broken, but this
path wasn't usen't since the only use case for
SkValidatingReadBuffer is currently image filters and
bitmaps are unflattened as part of the deserialization of
SkBitmapSource
- SkPictureImageFilter was not deserializable. Added it to
SkGlobalInitialization*
- Added a test that exercises the SkPicture serialization /
deserialization code
BUG=skia:
R=senorblanco@google.com, senorblanco@chromium.org, reed@google.com, robertphillips@google.com
Author: sugoi@chromium.org
Review URL: https://codereview.chromium.org/
195223003
git-svn-id: http://skia.googlecode.com/svn/trunk@13764
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 12 Mar 2014 14:46:31 +0000 (14:46 +0000)]
Add NVPR configs to DM
Add NVPR configs to DM. The bench and gm parts support NVPR already.
R=bsalomon@google.com
Author: kkinnunen@nvidia.com
Review URL: https://codereview.chromium.org/
196633005
git-svn-id: http://skia.googlecode.com/svn/trunk@13763
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Wed, 12 Mar 2014 14:01:48 +0000 (14:01 +0000)]
New baselines for imagefiltersclipped, offsetimagefilter GMs.
These were modified by
https://code.google.com/p/skia/source/detail?r=13744
TBR=halcanary@google.com
Review URL: https://codereview.chromium.org/
196603005
git-svn-id: http://skia.googlecode.com/svn/trunk@13762
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Wed, 12 Mar 2014 13:35:23 +0000 (13:35 +0000)]
Rebaseline performance triggers for Mac10.6 & N7
https://codereview.chromium.org/
196573006/
git-svn-id: http://skia.googlecode.com/svn/trunk@13761
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 12 Mar 2014 09:42:01 +0000 (09:42 +0000)]
[WIP] Add Context to SkDrawLooper.
SkDrawLooper carries some state during draws. This CL extracts this state into
a separate class Context, which is then passed by the users of SkDrawLooper
into the appropriate methods.
This is a step towards making SkDrawLooper immutable.
BUG=skia:2141
R=scroggo@google.com, reed@google.com, sugoi@google.com
Author: dominikg@chromium.org
Review URL: https://codereview.chromium.org/
155513012
git-svn-id: http://skia.googlecode.com/svn/trunk@13760
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Wed, 12 Mar 2014 04:00:25 +0000 (04:00 +0000)]
Revert the rest of r13757.
git-svn-id: http://skia.googlecode.com/svn/trunk@13759
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Wed, 12 Mar 2014 03:46:48 +0000 (03:46 +0000)]
Revert 13757.
git-svn-id: http://skia.googlecode.com/svn/trunk@13758
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Wed, 12 Mar 2014 03:13:48 +0000 (03:13 +0000)]
Fix (1 << 31) to (1u << 31) in SkOTTable_OS_2.
When ints are 32 bits, (1 << 31) is undefined.
R=reed@google.com
Review URL: https://codereview.chromium.org/
189093020
git-svn-id: http://skia.googlecode.com/svn/trunk@13757
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 12 Mar 2014 03:04:08 +0000 (03:04 +0000)]
make onReadPixels protected and have default impl (so we can remove chrome override)
R=reed@google.com
TBR=bsalomon@google.com
Author: reed@chromium.org
Review URL: https://codereview.chromium.org/
196543004
git-svn-id: http://skia.googlecode.com/svn/trunk@13756
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Wed, 12 Mar 2014 03:02:18 +0000 (03:02 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@13755
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 11 Mar 2014 23:47:35 +0000 (23:47 +0000)]
Revert of Revert "De-virtualize SkCanvas save/restore." (https://codereview.chromium.org/
194923008/)
Reason for revert:
Re-landing after roll fix.
Original issue's description:
> Revert "De-virtualize SkCanvas save/restore."
>
> (To allow a roll fix into the tree).
>
> This reverts commit
edf702204be42c945254191f9f9cd6585b3d189b.
>
> R=halcanary@google.com
>
> Committed: https://code.google.com/p/skia/source/detail?r=13748
R=halcanary@google.com, fmalita@chromium.org
TBR=fmalita@chromium.org, halcanary@google.com
NOTREECHECKS=true
NOTRY=true
Author: fmalita@google.com
Review URL: https://codereview.chromium.org/
196323003
git-svn-id: http://skia.googlecode.com/svn/trunk@13754
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 11 Mar 2014 22:58:24 +0000 (22:58 +0000)]
remove SK_SUPPORT_LEGACY_COPYTO_CONFIG
R=halcanary@google.com
TBR=halcanary@google.com
NOTRY=True
NOTREECHECK=True
Author: reed@chromium.org
Review URL: https://codereview.chromium.org/
196003003
git-svn-id: http://skia.googlecode.com/svn/trunk@13753
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 11 Mar 2014 22:58:00 +0000 (22:58 +0000)]
Alter bench_pictures to "respect" the logPerIter flag.
When --logPerIters is set and --repeat is great then 2 then bench_pictures will run each test "repeat" times (to generate the correct number of timings) by rendering 5 times.
This CL also adds a swapBuffers in addition to the pre-existing flush calls.
R=bsalomon@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
194973003
git-svn-id: http://skia.googlecode.com/svn/trunk@13752
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 11 Mar 2014 22:57:50 +0000 (22:57 +0000)]
First pass at a web app that lets you run Skia code and see the results.
BUG=skia:
R=reed@google.com
Author: jcgregorio@google.com
Review URL: https://codereview.chromium.org/
195143004
git-svn-id: http://skia.googlecode.com/svn/trunk@13751
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 11 Mar 2014 22:57:21 +0000 (22:57 +0000)]
Only set USE_ANDROID_NDK_CPU_FEATURES if it's not already been explicitly set
R=djsollen@google.com, reed@google.com
BUG=skia:
Author: george@mozilla.com
Review URL: https://codereview.chromium.org/
189263015
git-svn-id: http://skia.googlecode.com/svn/trunk@13750
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 11 Mar 2014 21:50:00 +0000 (21:50 +0000)]
fix build error in chromium
NOTREECHECKS=true
NOTRY=true
R=fmalita@google.com, jvanverth@google.com, fmalita@chromium.org
TBR=fmalita@google.com
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/
195223004
git-svn-id: http://skia.googlecode.com/svn/trunk@13749
2bbb7eff-a529-9590-31e7-
b0007b416f81
fmalita@google.com [Tue, 11 Mar 2014 21:46:56 +0000 (21:46 +0000)]
Revert "De-virtualize SkCanvas save/restore."
(To allow a roll fix into the tree).
This reverts commit
edf702204be42c945254191f9f9cd6585b3d189b.
R=halcanary@google.com
Review URL: https://codereview.chromium.org/
194923008
git-svn-id: http://skia.googlecode.com/svn/trunk@13748
2bbb7eff-a529-9590-31e7-
b0007b416f81
fmalita@google.com [Tue, 11 Mar 2014 21:04:41 +0000 (21:04 +0000)]
De-virtualize SkCanvas save/restore.
This moves the state management logic into non-virtual SkCanvas methods,
and turns the virtuals into protected notifiers.
R=robertphillips@google.com, reed@google.com
Review URL: https://codereview.chromium.org/
194713008
git-svn-id: http://skia.googlecode.com/svn/trunk@13747
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Tue, 11 Mar 2014 19:55:51 +0000 (19:55 +0000)]
Drop executable flag from headers so that they can be packaged
https://codereview.chromium.org/
194883004/
git-svn-id: http://skia.googlecode.com/svn/trunk@13746
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 11 Mar 2014 19:12:44 +0000 (19:12 +0000)]
Fix linking errors on android builds due to
cdd0f92b1ac
NOTREECHECKS=true
NOTRY=true
R=iancottrell@google.com, tomhudson@google.com
TBR=tomhudson@google.com
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/
194563003
git-svn-id: http://skia.googlecode.com/svn/trunk@13745
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Tue, 11 Mar 2014 18:29:42 +0000 (18:29 +0000)]
Fix SkOffsetImageFilter to use a temporary for bounds computations.
SkOffsetImageFilter::onFilterBounds() was writing to *dst, and later
referring to src. These may be the same memory location, so the results
were incorrect.
Covered by the 5th test case in offsetimagefilter.
BUG=skia:
Review URL: https://codereview.chromium.org/
195163004
git-svn-id: http://skia.googlecode.com/svn/trunk@13744
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 11 Mar 2014 17:27:07 +0000 (17:27 +0000)]
New version of the bbh shootout.
There were a bunch of problems with the existing code, all of which I would of ignored, except it could only benchmark none and rtree.
The new version measures the same numbers, in almost exactly the same way, it's the structure over the top of the actual test runner that I changed.
Now it only loads the pictures once, it is configurable in which bbh's it runs and how may loops on them it does, it uses standard command line processing, and it does not do so much redundant work so it runs quicker. It is also much easier to understand and change IMHO.
Doing this so I can reasonably compare the new QuadTree implementation.
BUG=skia:2242
Committed: http://code.google.com/p/skia/source/detail?r=13736
R=tomhudson@google.com, mtklein@google.com, reed@google.com
Author: iancottrell@google.com
Review URL: https://codereview.chromium.org/
186973005
git-svn-id: http://skia.googlecode.com/svn/trunk@13743
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Tue, 11 Mar 2014 17:09:17 +0000 (17:09 +0000)]
Fix radical assumption that 0.5 in double is exactly convertible to float.
BUG=skia:2181
Review URL: https://codereview.chromium.org/
195423002
git-svn-id: http://skia.googlecode.com/svn/trunk@13742
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 11 Mar 2014 17:07:15 +0000 (17:07 +0000)]
Enable use of distance fields via SkPaint flag.
Now that distance field generation is fast enough to make it practical, this makes distances field fonts easily available to anyone who wants to try them out (i.e Chromium).
BUG=skia:2173
R=reed@google.com, bsalomon@google.com
Author: jvanverth@google.com
Review URL: https://codereview.chromium.org/
193163003
git-svn-id: http://skia.googlecode.com/svn/trunk@13741
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 11 Mar 2014 15:57:40 +0000 (15:57 +0000)]
Add new module for distance field generation.
This improves the speed over the previous method by 10x+, and makes using distance fields practical.
BUG=skia:2173
Committed: http://code.google.com/p/skia/source/detail?r=13729
R=bsalomon@google.com, robertphillips@google.com
Author: jvanverth@google.com
Review URL: https://codereview.chromium.org/
178543007
git-svn-id: http://skia.googlecode.com/svn/trunk@13740
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 11 Mar 2014 15:54:51 +0000 (15:54 +0000)]
Handle rrects with one circular corner and three square corners in GrRRectEffect.
BUG=skia:2181
R=jvanverth@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
193263002
git-svn-id: http://skia.googlecode.com/svn/trunk@13739
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 11 Mar 2014 14:28:10 +0000 (14:28 +0000)]
bench rebaseline after Brian's improvement e5a041c
BUG=skia:2274
NOTRY=true
R=bsalomon@google.com
TBR=bsalomon@google.com
Author: bensong@google.com
Review URL: https://codereview.chromium.org/
195053003
git-svn-id: http://skia.googlecode.com/svn/trunk@13738
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 11 Mar 2014 14:23:50 +0000 (14:23 +0000)]
Revert of New version of the bbh shootout (https://codereview.chromium.org/
186973005/)
Reason for revert:
breaking build on at least 12 configurations.
Original issue's description:
> New version of the bbh shootout.
> There were a bunch of problems with the existing code, all of which I would of ignored, except it could only benchmark none and rtree.
> The new version measures the same numbers, in almost exactly the same way, it's the structure over the top of the actual test runner that I changed.
> Now it only loads the pictures once, it is configurable in which bbh's it runs and how may loops on them it does, it uses standard command line processing, and it does not do so much redundant work so it runs quicker. It is also much easier to understand and change IMHO.
>
> Doing this so I can reasonably compare the new QuadTree implementation.
> BUG=skia:2242
>
> Committed: http://code.google.com/p/skia/source/detail?r=13736
R=tomhudson@google.com, mtklein@google.com, reed@google.com, iancottrell@google.com
TBR=iancottrell@google.com, mtklein@google.com, reed@google.com, tomhudson@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:2242
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/
194903003
git-svn-id: http://skia.googlecode.com/svn/trunk@13737
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 11 Mar 2014 13:51:28 +0000 (13:51 +0000)]
New version of the bbh shootout.
There were a bunch of problems with the existing code, all of which I would of ignored, except it could only benchmark none and rtree.
The new version measures the same numbers, in almost exactly the same way, it's the structure over the top of the actual test runner that I changed.
Now it only loads the pictures once, it is configurable in which bbh's it runs and how may loops on them it does, it uses standard command line processing, and it does not do so much redundant work so it runs quicker. It is also much easier to understand and change IMHO.
Doing this so I can reasonably compare the new QuadTree implementation.
BUG=skia:2242
R=tomhudson@google.com, mtklein@google.com, reed@google.com
Author: iancottrell@google.com
Review URL: https://codereview.chromium.org/
186973005
git-svn-id: http://skia.googlecode.com/svn/trunk@13736
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 10 Mar 2014 22:53:20 +0000 (22:53 +0000)]
plumbing for GPU fast blur
BUG=skia:2281
R=bsalomon@google.com
Author: humper@google.com
Review URL: https://codereview.chromium.org/
193193002
git-svn-id: http://skia.googlecode.com/svn/trunk@13735
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Mon, 10 Mar 2014 21:42:48 +0000 (21:42 +0000)]
Rebase bezier_effect GMs and lingering changed GMs from laggy bots
Review URL: https://codereview.chromium.org/
190663019
git-svn-id: http://skia.googlecode.com/svn/trunk@13734
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 10 Mar 2014 21:42:06 +0000 (21:42 +0000)]
plumb API for analytic rrect blur
BUG=skia:2281
R=bsalomon@google.com, reed@google.com
Author: humper@google.com
Review URL: https://codereview.chromium.org/
189663012
git-svn-id: http://skia.googlecode.com/svn/trunk@13733
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 10 Mar 2014 20:37:54 +0000 (20:37 +0000)]
Revert of Add new module for distance field generation. (https://codereview.chromium.org/
178543007/)
Reason for revert:
multiple compile errors
Original issue's description:
> Add new module for distance field generation.
>
> This improves the speed over the previous method by 10x+, and makes using distance fields practical.
>
> BUG=skia:2173
>
> Committed: http://code.google.com/p/skia/source/detail?r=13729
R=bsalomon@google.com, robertphillips@google.com, jvanverth@google.com
TBR=bsalomon@google.com, jvanverth@google.com, robertphillips@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:2173
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/
190753015
git-svn-id: http://skia.googlecode.com/svn/trunk@13732
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Mon, 10 Mar 2014 19:51:46 +0000 (19:51 +0000)]
Fix no GPU build after r13728
Review URL: https://codereview.chromium.org/
193163002
git-svn-id: http://skia.googlecode.com/svn/trunk@13731
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 10 Mar 2014 19:47:58 +0000 (19:47 +0000)]
flag to make kClipToLayer_SaveFlag the default behavior
#define SK_SUPPORT_LEGACY_CLIPTOLAYERFLAG to get the old behavior
The goal is to remove the feature of saveLayer that allows the canvas to draw outside of the top-most layer.
R=robertphillips@google.com, scroggo@google.com
Review URL: https://codereview.chromium.org/
190723004
git-svn-id: http://skia.googlecode.com/svn/trunk@13730
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 10 Mar 2014 19:38:51 +0000 (19:38 +0000)]
Add new module for distance field generation.
This improves the speed over the previous method by 10x+, and makes using distance fields practical.
BUG=skia:2173
R=bsalomon@google.com, robertphillips@google.com
Author: jvanverth@google.com
Review URL: https://codereview.chromium.org/
178543007
git-svn-id: http://skia.googlecode.com/svn/trunk@13729
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 10 Mar 2014 19:33:16 +0000 (19:33 +0000)]
reorg iteration code in rrects GM, tightly pack rrects drawn in _effect version.
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
190953008
git-svn-id: http://skia.googlecode.com/svn/trunk@13728
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 10 Mar 2014 19:12:53 +0000 (19:12 +0000)]
rebaseline_server: disable image magnifier, for huge UI speedup
BUG=skia:2248
NOTREECHECKS=True
NOTRY=True
R=rmistry@google.com
TBR=rmistry
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
193073003
git-svn-id: http://skia.googlecode.com/svn/trunk@13727
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 10 Mar 2014 18:09:25 +0000 (18:09 +0000)]
rebaseline_server: add actual_repo and actual_revision command line options
So, if you want to see divergences from expectations as of https://code.google.com/p/skia-autogen/source/detail?r=29365 , specify --actuals-revision 29365
This is also handy for testing rebaseline_server performance improvements against a static set of results.
BUG=skia:2248
NOTREECHECKS=True
NOTRY=True
R=borenet@google.com, bsalomon@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
193023002
git-svn-id: http://skia.googlecode.com/svn/trunk@13726
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 10 Mar 2014 18:05:15 +0000 (18:05 +0000)]
rebaseline_server: fix reload delay when there is client/server clock skew
Currently, if there is >10 second clock skew between client and server, the
client will attempt to reload constantly while the server is still loading
results.
NOTREECHECKS=True
NOTRY=True
R=borenet@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
192833003
git-svn-id: http://skia.googlecode.com/svn/trunk@13725
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 10 Mar 2014 16:41:00 +0000 (16:41 +0000)]
Pulling these out of other reviews so avoid code review clutter.
R=jvanverth@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
192783002
git-svn-id: http://skia.googlecode.com/svn/trunk@13724
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 10 Mar 2014 16:08:22 +0000 (16:08 +0000)]
Use bitfield rather than distinct enum types for circular corners in RRectEffect.
BUG=skia:2181
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
191613003
git-svn-id: http://skia.googlecode.com/svn/trunk@13723
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 10 Mar 2014 16:05:57 +0000 (16:05 +0000)]
remove legacy ifdef wrapping fast blur
BUG=skia:
R=robertphillips@google.com
Author: humper@google.com
Review URL: https://codereview.chromium.org/
192833002
git-svn-id: http://skia.googlecode.com/svn/trunk@13722
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 10 Mar 2014 16:04:47 +0000 (16:04 +0000)]
Avoid black flashes when resizing debugger window using MSAA
Avoid black flashes when resizing debugger window using MSAA. Clear the
stencil buffer always after resize. Also reset the GrContext state
when Qt calls resizeGL -- we do not know what GL state Qt changes.
Remove setting of white background to SkGLWidget, it is not
effective. QGLWidget does not respect the stylesheet.
Also move the initial stencil clearing before GrContext is created
in order to preserve GrContext state consistent with actual GL
state.
R=robertphillips@google.com
Author: kkinnunen@nvidia.com
Review URL: https://codereview.chromium.org/
192433003
git-svn-id: http://skia.googlecode.com/svn/trunk@13721
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 10 Mar 2014 15:36:06 +0000 (15:36 +0000)]
rebaseline_server: display how long it took to render the list
BUG=skia:2248
NOTREECHECKS=True
NOTRY=True
R=borenet@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
189833008
git-svn-id: http://skia.googlecode.com/svn/trunk@13720
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 10 Mar 2014 12:17:06 +0000 (12:17 +0000)]
Revert "remove flag for legacy copyTo -- call sites have been updated"
This reverts commit
85586a92f50942ede4422aca7308b9d8a88469db.
git-svn-id: http://skia.googlecode.com/svn/trunk@13719
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 10 Mar 2014 10:51:58 +0000 (10:51 +0000)]
Factory methods for heap-allocated SkImageFilter objects.
This is part of an effort to ensure that all SkPaint effects can only be
allocated on the heap.
This patch makes the constructors of SkImageFilter and its subclasses non-public
and instead provides factory methods for creating these objects on the heap. We
temporarily keep constructor of publicly visible classes public behind a flag.
BUG=skia:2187
R=scroggo@google.com, mtklein@chromium.org, reed@google.com, senorblanco@google.com, senorblanco@chromium.org, bsalomon@google.com, sugoi@chromium.org, zork@chromium.org
Author: dominikg@chromium.org
Review URL: https://codereview.chromium.org/
182983003
git-svn-id: http://skia.googlecode.com/svn/trunk@13718
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 10 Mar 2014 07:40:03 +0000 (07:40 +0000)]
Add API for GrContext to recommend rendertarget sample count
Add GrContext::getRecommendedSampleCount method that can be
used to determine which GPU backend and what exact sample count
is recommendeded for a particular render target at particular
dpi.
Make this initially recommend 4xMSAA for contexts which have
NVPR enabled if dpi is 250 or more, 16 if dpi is less than 250
and no MSAA for others.
BUG=chromium:347962
R=bsalomon@google.com
Author: kkinnunen@nvidia.com
Review URL: https://codereview.chromium.org/
188403003
git-svn-id: http://skia.googlecode.com/svn/trunk@13717
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Sun, 9 Mar 2014 03:02:09 +0000 (03:02 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@13716
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Sat, 8 Mar 2014 03:57:19 +0000 (03:57 +0000)]
hide getTotalClip, so we can eventually remove it
hide getClipType, so we can eventually remove it
patch from issue
189443007
TBR=robertphilips@google.com
Author: reed@chromium.org
Review URL: https://codereview.chromium.org/
189883010
git-svn-id: http://skia.googlecode.com/svn/trunk@13715
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Sat, 8 Mar 2014 03:02:06 +0000 (03:02 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@13714
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Fri, 7 Mar 2014 22:34:32 +0000 (22:34 +0000)]
Rebaselines for https://codereview.chromium.org/
188693008/
Review URL: https://codereview.chromium.org/
189913006
git-svn-id: http://skia.googlecode.com/svn/trunk@13713
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Fri, 7 Mar 2014 20:33:07 +0000 (20:33 +0000)]
update ignored-tests.txt to accound for acceptable changes due to r13710
TBR=robertphillips@google.com
Review URL: https://codereview.chromium.org/
189803005
git-svn-id: http://skia.googlecode.com/svn/trunk@13712
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Fri, 7 Mar 2014 19:44:59 +0000 (19:44 +0000)]
remove dead code
git-svn-id: http://skia.googlecode.com/svn/trunk@13711
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 7 Mar 2014 19:43:43 +0000 (19:43 +0000)]
Implement the clip as 4 or fewer GrEffects when possible.
BUG=skia:2181
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
188693008
git-svn-id: http://skia.googlecode.com/svn/trunk@13710
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 7 Mar 2014 18:42:15 +0000 (18:42 +0000)]
Once Chromium starts holding on to paths and we can actually reuse cached path data (e.g., masks & geometry) we will need a way to preserve that reuse in the skps. This CL begins adding that capability. More analysis & profiling needs to be done before it is always enabled.
When enabled it does make the disabled path de-duping test in the Canvas unit test pass.
BUG=skia:507
R=bsalomon@google.com, mtklein@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
190923002
git-svn-id: http://skia.googlecode.com/svn/trunk@13709
2bbb7eff-a529-9590-31e7-
b0007b416f81
projects / platform / upstream / libSkiaSharp.git / log