Matthew Netsch [Fri, 14 Oct 2022 16:22:49 +0000 (16:22 +0000)]
Merge vk-gl-cts/github-main into vk-gl-cts/main
Change-Id: I70c130a367afa7d3eb2cbd81dd1662331c6723b8
ziga-lunarg [Fri, 2 Sep 2022 18:15:59 +0000 (20:15 +0200)]
Fix uninitialized variable in multisample clear attachments tests
Test parameter dynamicRendering was uninitialized
Components: Vulkan
VK-GL-CTS issue: 3920
Affected tests:
dEQP-VK.pipeline.*.multisample.misc.clear_attachments.*
Change-Id: I7e8f9227150b7d4b84172a9fa88ac98ac9b4175e
aitor_lunarg [Wed, 5 Oct 2022 11:26:49 +0000 (13:26 +0200)]
Add remaining div by zero tests
This change adds remaining amber tests that execute various explicit and
implicit division by zero operations, which should not crash or fail the
rendering operation.
New test:
dEQP-VK.glsl.crash_test.divbyzero_vert
dEQP-VK.glsl.crash_test.divbyzero_tesc
dEQP-VK.glsl.crash_test.divbyzero_tese
dEQP-VK.glsl.crash_test.divbyzero_geom
Components: Vulkan
VK-GL-CTS issue: 869
Change-Id: I5a448300ea81987d36ce1e2e977aa975fd5335ff
ziga-lunarg [Tue, 27 Sep 2022 21:05:54 +0000 (23:05 +0200)]
Add tests with primitive restart with no restart index
Test enabling primitive restart and using an index buffer which does not
contain any restart index
Components: Vulkan
VK-GL-CTS issue: 2177
New tests:
dEQP-VK.pipeline.*.input_assembly.primitive_restart.*.no_restart_*
Affected tests:
dEQP-VK.pipeline.*.input_assembly.primitive_restart.*
Change-Id: I8b8822f9fc3321a50a5881d4b2b414c5c5111692
Hyunjun Ko [Tue, 6 Sep 2022 02:23:07 +0000 (11:23 +0900)]
Add tests for VkImageDrmFormatModifierExplicitCreateInfoEXT
With adding VkPhysicalDeviceExternalImageFormatInfo when confirming the
format is supported.
New tests:
dEQP-VK.drm_format_modifiers.create_explicit_modifier*
Affects:
dEQP-VK.drm_format_modifiers.create*
VK-GL-CTS Issue: 3025
Components: Vulkan
Change-Id: I39f699951d9e27d3cf4fa4692b3942423ac35718
Ricardo Garcia [Thu, 13 Oct 2022 15:28:27 +0000 (17:28 +0200)]
Fix build on main branch
This commit fixes several build errors and warnings on the main branch,
as reported by clang/GCC on a Ubuntu 20.04 system. The warnings were
also being converted to errors in check_build_sanity, preventing the
checks from completing successfully.
* VulkanSC did not compile with DEQP_SUPPORT_DRM.
* Some GL callbacks used the wrong prototype.
* Some functions had write-only variables that were not being used.
* One class was not using the "override" suffix for virtual methods
consistently.
VK-GL-CTS issue: 4032
Components: OpenGL, Vulkan, Framework
Change-Id: I9c3e1af13713f1f6ed10cde1c475f7a1c7e6581a
Matthew Netsch [Fri, 14 Oct 2022 15:30:37 +0000 (15:30 +0000)]
Merge vk-gl-cts/vulkan-cts-1.3.4 into vk-gl-cts/main
Change-Id: I79d5e514a4aa33ff3fd105d2415a1d1a4284fc72
marz [Tue, 4 Oct 2022 20:17:03 +0000 (22:17 +0200)]
Pipeline creation feedback clear per iteration
Considering pipelineStageCreationFeedbackCount = 0 case
memory that hold feedback information have to be memset to 0
every round of test to prevent false readings
Part two of the https://gerrit.khronos.org/c/vk-gl-cts/+/9765
Components: Vulkan
VK-GL-CTS issue: 3736
Affects:
dEQP-VK.pipeline.*.creation_feedback.*
Change-Id: I1dce88369b70dcff78baa9c18285d1a76c9ac71d
Sławomir Cygan [Fri, 7 Oct 2022 13:21:40 +0000 (15:21 +0200)]
Fix rendering info flag in secondary command buffer
According to spec, the rendering info flag cannot be
VK_RENDERING_CONTENTS_SECONDARY_COMMAND_BUFFERS_BIT
when calling vkCmdBeginRendering on secondary command
buffer.
Components: Vulkan
Affects: dEQP-VK.draw.dynamic_rendering.complete_secondary_cmd_buff.differing_interpolation.*
VK-GL-CTS Issue: 4026
x
Change-Id: Ib34d810979bb3eef80f85f58cc8ed3e95b0ef32c
Sławomir Cygan [Thu, 6 Oct 2022 16:04:28 +0000 (18:04 +0200)]
Fix dEQP-VK.dynamic_state.monolithic.discard to check if stencil format is supported
Fix the test to pick stencil format from a list, instead of assuming that S8 format is supported
Components: Vulkan
Issues: 4024
Affects: dEQP-VK.dynamic_state.monolithic.discard.stencil
Change-Id: I5708fc6523369c5b72f04e1a4fcb1a9f3d5df3aa
Matthew Netsch [Fri, 14 Oct 2022 14:21:04 +0000 (14:21 +0000)]
Merge vk-gl-cts/vulkan-cts-1.3.3 into vk-gl-cts/vulkan-cts-1.3.4
Change-Id: Ieddcbfb470587bd3263c22b78276d210355fb59c
Matthew Netsch [Fri, 14 Oct 2022 13:55:44 +0000 (09:55 -0400)]
Merge pull request #360 from tomeuv/zlib-uprev
Update zlib dependency
Tomeu Vizoso [Fri, 14 Oct 2022 06:30:26 +0000 (08:30 +0200)]
Update zlib dependency
A new version addressing a security issue has been released, and the
existing URL isn't valid any more.
Update to 1.2.13 and take the chance to switch to an archive URL, that
should be more stable going forward.
Matthew Netsch [Thu, 13 Oct 2022 21:38:44 +0000 (21:38 +0000)]
Merge vk-gl-cts/vulkan-cts-1.3.2 into vk-gl-cts/vulkan-cts-1.3.3
Change-Id: I6f074d5b4611da1efe18afcee1707a3a2c3b4e03
Ricardo Garcia [Wed, 21 Sep 2022 15:01:14 +0000 (17:01 +0200)]
Fix out-of-bounds vertex buffer writes in PrimitiveGeneratedQuery tests
Wrong index usage was leaving a gap in the vertex buffer and writing out
of bounds.
Affects:
dEQP-VK.transform_feedback.primitives_generated_query.*
Components: Vulkan
VK-GL-CTS issue: 3965
VK-GL-CTS issue: 3966
Change-Id: I2d656797506031713187a867902c05b1a363b450
James Fitzpatrick [Mon, 10 Oct 2022 17:23:16 +0000 (18:23 +0100)]
Update IMG waiver #229
Update waiver #229 after test names were changed to add tests for
VK_EXT_graphics_pipeline_libraries
Components: vulkan
VK-GL-CTS issue: 229
Change-Id: I33bd7a44631c8ddb95eff3a95db04033e2773983
Matthew Netsch [Thu, 13 Oct 2022 21:07:11 +0000 (21:07 +0000)]
Merge vk-gl-cts/vulkan-cts-1.3.1 into vk-gl-cts/vulkan-cts-1.3.2
Change-Id: I5350055731e9c6ef9cab81fc347f102681555570
Matthew Netsch [Thu, 13 Oct 2022 19:04:21 +0000 (19:04 +0000)]
Merge vk-gl-cts/vulkan-cts-1.3.0 into vk-gl-cts/vulkan-cts-1.3.1
Change-Id: I9a1dfa4f5801789b9ef062699bd6cadbfb1ddd20
Arkadiusz Sarwa [Tue, 11 Oct 2022 14:29:06 +0000 (16:29 +0200)]
Add missing barrier after cmdFillBuffer.
Components: Vulkan
VK-GL-CTS issue: 4036
Affected tests:
dEQP-VK.api.image_clearing.*
Change-Id: Ieddaa85461311e1b39de4aeee69a192d01c6c92c
Matthew Netsch [Thu, 13 Oct 2022 16:45:19 +0000 (16:45 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/vulkan-cts-1.3.0
Change-Id: I0146109f64a3a011ba56b33e1c498dcc0f2bae56
Matthew Netsch [Thu, 13 Oct 2022 16:16:54 +0000 (16:16 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8
Change-Id: I867eda5f06e1a9df38b95d604b1d98ee5691e552
Alex Shi [Fri, 30 Sep 2022 04:29:53 +0000 (12:29 +0800)]
Fix winding issue in watertightness tests
The winding order of shared edge vertices wasn't consistent.
Add a check to ensure all triangles have same winding order.
Affects:
dEQP-VK.ray_tracing_pipeline.watertightness*
Components: Vulkan
VK-GL-CTS issue: 4009
Change-Id: I24607720fedcae2e903707dcd8f2d2d8b6ec12c0
ziga-lunarg [Sat, 8 Oct 2022 18:32:44 +0000 (20:32 +0200)]
Remove tests using invalid sType
This test creates a structure with sType VK_STRUCTURE_TYPE_MAX_ENUM and
passes it to other create info structs through pNext, but this sType is
not allowed in the pNext of those create info structs
Components: Vulkan
VK-GL-CTS issue: 4023
Removed tests:
dEQP-VK.api.smoke-triangle_ext_structs
Change-Id: Iccfbcebb2bf9b43e93871bfc74aecea921bc31b8
Russell Chou [Tue, 4 Oct 2022 21:07:52 +0000 (14:07 -0700)]
Fix synchronization.cross_instance TEMPORARY permanence
VK_EXTERNAL_SEMAPHORE_HANDLE_TYPE_SYNC_FD_BIT only supports TEMPORARY permanence, so check for that.
Affects:
dEQP-VK.synchronization.cross_instance.*_binary_semaphore_fence_fd
dEQP-VK.synchronization2.cross_instance.*_binary_semaphore_fence_fd
Components: Vulkan Framework
VK-GL-CTS issue: 4021
Change-Id: I6f663cbc35fcd7f81927878f31f78a6aaadf1a74
ziga-lunarg [Sun, 25 Sep 2022 15:39:29 +0000 (17:39 +0200)]
Fix subpass dependency in geometry layered tests
If both stages include a framebuffer-space stage in a self dependency,
then flags must include VK_DEPENDENCY_BY_REGION_BIT
Components: Vulkan
VK-GL-CTS issue: 3997
Affected tests:
dEQP-VK.geometry.layered.*
Change-Id: Id9941c16488a4c3bfbf569490d9e146437c4ae40
ziga-lunarg [Fri, 23 Sep 2022 23:31:28 +0000 (01:31 +0200)]
Fix color blend state in pipeline stencil tests
attachmentCount of pColorBlendState in pipeline create info must match
the colorAttachmentCount of the subpass used in creating the pipeline
Components: Vulkan
VK-GL-CTS issue: 3990
Affected tests:
dEQP-VK.pipeline.*stencil.*
Change-Id: Ic9bbcd9e14fc98e13e02698d7a138662a28782ae
ziga-lunarg [Mon, 19 Sep 2022 23:15:07 +0000 (01:15 +0200)]
Check if buffer size is multiple of nonCoherentAtomSize
When flushing memory range, if VK_WHOLE_SIZE is used, size must be a
multiple of VkPhysicalDeviceLimits::nonCoherentAtomSize
Components: Vulkan
VK-GL-CTS issue: 3972
Affected tests:
dEQP-VK.memory.binding.*
Change-Id: If66e593f88af00450a55dfacc988df93ef6991eb
ziga-lunarg [Mon, 26 Sep 2022 17:46:26 +0000 (19:46 +0200)]
Add imageless framebuffer with different attachments test
Test using different attachments in different render passes with the
same imageless framebuffer
Components: Vulkan
VK-GL-CTS issue: 3999
New test:
dEQP-VK.imageless_framebuffer.different_attachments
Change-Id: I4a365952044974bcac2a957b0fda1eaa63c8adb2
Graeme Leese [Wed, 24 Aug 2022 16:12:27 +0000 (17:12 +0100)]
Add depth range interaction tests
Add versions of the VK_EXT_depth_clamp_zero_one tests that run with
VK_EXT_depth_range_unrestricted enabled to verify the interaction
between the extensions.
Components: Vulkan
New Tests: dEQP-VK.depth.out_of_range_unrestricted
dEQP-VK.depth.bias_outside_range_fs_clamp_unrestricted
Change-Id: I50ede4e0bf65f304f8815ed636de3baaf56f8e61
Ricardo Garcia [Wed, 28 Sep 2022 12:39:53 +0000 (14:39 +0200)]
Enable some combined pipeline and image robustness tests
One of the applied filters when generating test combinations removed all
of them for pipeline robustness and image robustness, so only a number
of empty groups remained.
New tests:
dEQP-VK.robustness.pipeline_robustness.image_robustness.*
Components: Vulkan
VK-GL-CTS issue: 4003
Change-Id: I70cbe7aed450c03e84528c275725c24c6c613a74
Russell Chou [Thu, 12 May 2022 03:35:39 +0000 (20:35 -0700)]
Add more VK_EXT_acquire_drm_display tests
Adds a new wsi::Type, DIRECT_DRM, and all accompanying tests.
New tests:
dEQP-VK.wsi.direct_drm.*
dEQP-VK.api.image_compression_control.swapchain.direct_drm.*
dEQP-VK.image.swapchain_mutable.direct_drm.*
dEQP-VK.protected_memory.interaction.wsi.direct_drm.*
Components: Vulkan Framework
VK-GL-CTS issue: 3685
Change-Id: I306fb54fe19fe73926a66a1f68208fb9d4af10a9
Russell Chou [Thu, 5 May 2022 02:30:42 +0000 (19:30 -0700)]
Add VK_EXT_acquire_drm_display tests
Also refactors tcuLibDrm from vktApiDeviceDrmPropertiesTests.
New tests:
dEQP-VK.wsi.acquire_drm_display.*
Affects:
dEQP-VK.api.device_drm_properties.drm_files_exist
Components: Vulkan Framework
VK-GL-CTS issue: 3685
Change-Id: I69d23b4f84a1a481d15422753c2f2fbea8f9ddc9
ziga-lunarg [Sun, 11 Sep 2022 20:23:34 +0000 (22:23 +0200)]
Add tests with create pipeline cache flags
Add tests with pipeline cache using
VK_PIPELINE_CACHE_CREATE_EXTERNALLY_SYNCHRONIZED_BIT flag
Components: Vulkan
VK-GL-CTS issue: 3729
New tests:
dEQP-VK.pipeline.*.cache.graphics_tests.vertex_stage_*_externally_synchronized
Change-Id: Iac1a01a0d478a51e75fdf77c9b526cd5400af7eb
Ricardo Garcia [Wed, 28 Sep 2022 11:32:48 +0000 (13:32 +0200)]
Fix enum values in pipeline robustness tests
Pipeline robustness tests fill out VkPipelineRobustnessCreateInfoEXT
structures using robustness2 values when robustness2 is not activated,
and vice versa.
Affected tests:
dEQP-VK.robustness.pipeline_robustness.*
Components: Vulkan
VK-GL-CTS issue: 4004
Change-Id: Ic3abe5fda40cc999a7ee288aa5df35ee407743f2
Ricardo Garcia [Wed, 21 Sep 2022 15:06:48 +0000 (17:06 +0200)]
Fix missing multisample info in PrimitivesGeneratedQuery tests
The layers were complaining about the multisample state not being
passed.
Also see:
https://github.com/KhronosGroup/Vulkan-ValidationLayers/pull/4583
Affects:
dEQP-VK.transform_feedback.primitives_generated_query.*
Components: Vulkan
VK-GL-CTS issue: 3965
VK-GL-CTS issue: 3966
Vulkan issue: 3240
Change-Id: I2b27992acd0882757ef758a69faa5378b56802e7
Ricardo Garcia [Thu, 29 Sep 2022 12:34:49 +0000 (14:34 +0200)]
Pass fragment shading rate info to pre rasterization shader state
Fragment shading rate info needs to be passed both as part of the
pre-rasterization shader state and as part of the fragment shader state
when creating pipelines, and it needs to be consistent in both cases.
The graphics pipeline library utilities were only passing that
information as part of the fragment shader state.
Affects:
dEQP-VK.fragment_shading_rate.*.misc_tests.*
dEQP-VK.fragment_shading_rate.*.basic.*
dEQP-VK.pipeline.*.mixed_attachment_samples.*
dEQP-VK.*.sample_locations_ext.*
dEQP-VK.pipeline.*.multisample_with_fragment_shading_rate.*
Components: Vulkan
VK-GL-CTS issue: 4006
Change-Id: Idebba54be2fe0a34a68aab1c5c9ba3d07affe47b
Ricardo Garcia [Mon, 26 Sep 2022 09:16:41 +0000 (11:16 +0200)]
Drop scalar block layout requirement in many robustness tests
Many robustness2, image_robustness and pipeline_robustness tests were
requiring VK_EXT_scalar_block_layout while not actually using the
feature.
Affects:
dEQP-VK.robustness.robustness2.*
dEQP-VK.robustness.image_robustness.*
dEQP-VK.robustness.pipeline_robustness.*
Components: Vulkan
VK-GL-CTS issue: 3985
Change-Id: Ia5dbab2eaf9ae188ab805ec1b5ffd32498e7332b
aitor_lunarg [Wed, 21 Sep 2022 19:44:57 +0000 (21:44 +0200)]
Ensure correct size is allocated for buffer in mismatch tests
Affected tests:
dEQP-VK.spirv_assembly.instruction.graphics.image_sampler.*optypeimage_mismatch.*
Components: Vulkan
VK-GL-CTS issue: 3974
Change-Id: I66868b9f1e2f8a48f8613b79267bdf5922aa6c70
ziga-lunarg [Fri, 16 Sep 2022 16:46:35 +0000 (18:46 +0200)]
Add missing dependency flag in attachment feedback loop layout tests
If srcSubpass and dstSubpass are equal and both srcStageMask and
dstStageMask include framebuffer-space stage,
VK_DEPENDENCY_BY_REGION_BIT is required in VkSubpassDependency
Components: Vulkan
VK-GL-CTS issue: 3950
Affected tests:
dEQP-VK.pipeline.*.attachment_feedback_loop_layout.*
Change-Id: Ib27dfcef863106d67755a26b0c1a57b76d4b6118
Piotr Byszewski [Mon, 3 Oct 2022 16:08:23 +0000 (18:08 +0200)]
Remove redundant *_EXTENSION_NAME defines
Recent gen_framework change, that generates .inl files directly
from vk.xml, added all extension defines to vkBasicTypes.inl.
This means that all *_EXTENSION_NAME defines could be removed
from the tests code and also from vkDeviceFeatures.inl and
vkDeviceProperties.inl.
VK-GL-CTS issue: 3151
Components: Framework, Vulkan
Affects:
dEQP-VK.*
Change-Id: I041d82813fbfb564d7ffeaf7aad69e38c49393b5
ziga-lunarg [Fri, 16 Sep 2022 18:55:40 +0000 (20:55 +0200)]
Add missing check for pipelineCreationCacheControl feature
Shader module identifier tests do not check for
pipelineCreationCacheControl feature when using
VK_PIPELINE_CREATE_FAIL_ON_PIPELINE_COMPILE_REQUIRED_BIT
Components: Vulkan
VK-GL-CTS issue: 3951
Affected tests:
dEQP-VK.pipeline.*.shader_module_identifier.*
Change-Id: I805b60427123f000a72d65119f69dca857d086c3
Matthew Netsch [Mon, 10 Oct 2022 15:59:18 +0000 (15:59 +0000)]
Merge vk-gl-cts/vulkan-cts-1.3.3 into vk-gl-cts/main
Change-Id: I32090c113cd2300b3209cffe0b6fb4faf09a728b
Matthew Netsch [Mon, 10 Oct 2022 14:19:20 +0000 (14:19 +0000)]
Merge vk-gl-cts/vulkan-cts-1.3.3 into vk-gl-cts/vulkan-cts-1.3.4
Change-Id: Ia707ef6ca16380802af77b4d8068206fea512589
ziga-lunarg [Sun, 25 Sep 2022 13:38:58 +0000 (15:38 +0200)]
Fix queueFamilyIndex in synchronization tests
Invalid index is used, instead of retrieving queueFamilyIndex
Components: Vulkan
VK-GL-CTS issue: 3996
Affected tests:
dEQP-VK.synchronization.internally_synchronized_objects.*
Change-Id: I69aabf6199437cc26f519c257a3b26ee1605f8ef
ziga-lunarg [Sat, 17 Sep 2022 17:00:11 +0000 (19:00 +0200)]
Enable instance extensions when creating robustness device
Custom robustness context enables device extensions without enabling any
of the required instance extensions
Components:
Framework Vulkan VulkanSC
VK-GL-CTS issue: 3958
Affected tests:
dEQP-VK.*
dEQP-VKSC.*
Change-Id: I06d7d914eceb5aec97f723f726f97168341d8da5
ziga-lunarg [Thu, 15 Sep 2022 22:44:14 +0000 (00:44 +0200)]
Remove invalid dedicated allocation tests with bind offset
When dedicated allocation is used VkMemoryRequirements::size must match
VkMemoryAllocateInfo::allocationSize
Components: Vulkan
VK-GL-CTS issue: 3947
Affected tests:
dEQP-VK.api.copy_and_blit.*
Change-Id: I6eb0939746504566750b1cc958e1704cbf15ae51
ziga-lunarg [Fri, 16 Sep 2022 23:08:45 +0000 (01:08 +0200)]
Fix enabling timelineSemaphore feature
The feature was only enabled if the extension was used and not when
vulkan version 1.2 was used
Components: Vulkan
VK-GL-CTS issue: 3955
Affected tests:
dEQP-VK.*.smoke.timeline_semaphores
dEQP-VKSC.*.smoke.timeline_semaphores
Change-Id: If1b6fb3a6b0f6ef6e54b3bc2f36f1a7a55fd5fab
ziga-lunarg [Fri, 23 Sep 2022 00:11:33 +0000 (02:11 +0200)]
Fix missing cmd buffer reset flag in query_pool_results tests
Command buffer is begun multiple times when command pool was created
without VK_COMMAND_POOL_CREATE_RESET_COMMAND_BUFFER_BIT
Components: Vulkan
VK-GL-CTS issue: 3983
Affected tests:
dEQP-VK.ray_tracing_pipeline.acceleration_structures.query_pool_results.*
Change-Id: If5445bb51c3b3a7b1aebd5397ef97f0f57dc7a9d
Neslisah [Mon, 26 Sep 2022 20:00:49 +0000 (16:00 -0400)]
Limit call of getQueryPoolResults to BUILD_TYPE_DEVICE
When the buildType is BUILD_TYPE_HOST, queryPool results are retrieved immediately to the CPU, and queryPool is not set to the result value.
Due to unset value at queryPool, later calling getQueryPoolResults causes the size to be messed up, and assertion to be trigerred.
The intention to call getQueryPoolResults is for BUILD_TYPE_DEVICE where you need to wait for cmdBuffer to be executed.
Call of getQueryPoolResults should only be made if the build type is BUILD_TYPE_DEVICE.
Affects:
dEQP-VK.ray_tracing_pipeline.acceleration_structures.copy_within_pipeline.cpu.*
Components: Vulkan
https://gitlab.khronos.org/Tracker/vk-gl-cts/-/issues/4016
Change-Id: I2e8c3dc9c56c98c288bba17d6c4074a9b88e0851
Matthew Netsch [Fri, 7 Oct 2022 21:32:23 +0000 (21:32 +0000)]
Merge vk-gl-cts/vulkan-cts-1.3.2 into vk-gl-cts/vulkan-cts-1.3.3
Change-Id: I869c5e50453097a134dfa73defee01f9512b1bcb
ziga-lunarg [Sat, 24 Sep 2022 20:09:24 +0000 (22:09 +0200)]
Remove VK_PIPELINE_CREATE_DERIVATIVE_BIT for pipeline libraries in util
vkPipelineConstructionUtil creates pipeline libraries with same flags as
the main pipeline, but base pipeline handle is never provided
Components: Vulkan, Framework
VK-GL-CTS issue: 3994
Affected tests:
dEQP-VK.pipeline.*
Change-Id: If30b3caebd00463587a00f9e82810b53a7b72eb6
ziga-lunarg [Sat, 24 Sep 2022 15:06:34 +0000 (17:06 +0200)]
Fix color blend state in FSR tests
The attachment count used in pColorBlendState must match the attachment
count in the subpass the pipeline is created with
Components: Vulkan
VK-GL-CTS issue: 3993
Affected tests:
dEQP-VK.pipeline.*.multisample_with_fragment_shading_rate.*
Change-Id: Ic208371f7a6c704f169c3c16f0c19836014dcd85
ziga-lunarg [Fri, 23 Sep 2022 21:12:31 +0000 (23:12 +0200)]
Fix enabling pipeline libraries in push descriptor tests
Add missing required extension and enable the required feature for
pipeline libraries
Components: Vulkan
VK-GL-CTS issue: 3989
Affected tests:
dEQP-VK.pipeline.*.push_descriptor.*
Change-Id: Ibd7b588e822e94e42a405c2d3bb8c3ef81bd4aa0
Matthew Netsch [Fri, 7 Oct 2022 17:28:26 +0000 (17:28 +0000)]
Merge vk-gl-cts/vulkan-cts-1.3.1 into vk-gl-cts/vulkan-cts-1.3.2
Change-Id: I62bf1f49ff0dab41398a140dc29ca17a46142be5
ziga-lunarg [Fri, 16 Sep 2022 22:24:22 +0000 (00:24 +0200)]
Enable dynamicRendering feature in FSR tests using it
Fragment shading rate tests using dynamic rendering did not enable the
feature
Components: Vulkan
VK-GL-CTS issue: 3953
Affected tests:
dEQP-VK.fragment_shading_rate.dynamic_rendering.attachment_rate.*
Change-Id: I0959c88f42d820bed3b58473d45693bbcbd28896
Mike Byrne [Thu, 16 Jun 2022 11:00:53 +0000 (11:00 +0000)]
Fix barriers in dynamic rendering fragment density tests
Addeded additional barrier to ensure work on subsampled image is
complete before copy to output image.
Affects: dEQP-VK.dynamic_rendering.fragment_*
Components: Vulkan
VK-GL-CTS Issue: 3796
Change-Id: I5875f22b7fd3ccb47c9762067cb57048011115c0
Matthew Netsch [Fri, 7 Oct 2022 16:17:26 +0000 (09:17 -0700)]
Merge vk-gl-cts/vulkan-cts-1.3.0 into vk-gl-cts/vulkan-cts-1.3.1
Change-Id: I995d279b4aa7949762e1321013c1ae56c2bacad5
Matthew Netsch [Thu, 6 Oct 2022 21:08:48 +0000 (14:08 -0700)]
Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/vulkan-cts-1.3.0
Change-Id: Iccd8336664b28aaa5c009f7da85295995a8297eb
ziga-lunarg [Mon, 29 Aug 2022 00:16:31 +0000 (02:16 +0200)]
Add missing buffer features check in image store tests
Check if format supports storage write for VkBufferView where
OpTypeImage is Unknown
Components: Vulkan
VK-GL-CTS issue: 3765
Affected tests:
dEQP-VK.image.store.without_format.*
Change-Id: I74365f2f753fb61397d83403098a288cdcf53953
ziga-lunarg [Sat, 17 Sep 2022 19:46:02 +0000 (21:46 +0200)]
Fix resetting command buffer in ray tracing tests
VK_COMMAND_POOL_CREATE_RESET_COMMAND_BUFFER_BIT must be set to reset
command buffer and add missing reset
Components: Vulkan
VK-GL-CTS issue: 3960
Affected tests:
dEQP-VK.ray_tracing_pipeline.acceleration_structures.*
Change-Id: Icc5029fc796bff7cf095cbb78832483463cdaaaa
ziga-lunarg [Mon, 19 Sep 2022 18:46:43 +0000 (20:46 +0200)]
Fix ds attachment formats in dynamic rendering with inheritance
In VkCommandBufferInheritanceRenderingInfoKHR the depthAttachmentFormat
must have a depth aspect or be VK_FORMAT_UNDEFINED, and the
stencilAttachmentFormat must have a stencil aspect or be
VK_FORMAT_UNDEFINED
Components: Vulkan
VK-GL-CTS issue: 3970
Affected tests:
dEQP-VK.dynamic_rendering.*
Change-Id: I6d3248643a7a2b1f5761833828889e3484a25a57
ziga-lunarg [Fri, 16 Sep 2022 21:07:44 +0000 (23:07 +0200)]
Fix VkPipelineRenderingCreateInfoKHR formats in dynamic rendering tests
depthAttachmentFormat must include a depth aspect and stencilAttachment
format must include a stencil aspect
Components: Vulkan
VK-GL-CTS issue: 3952
Affected tests:
dEQP-VK.dynamic_rendering.*
Change-Id: Ifbbadb4f2917fb36fef669f1fc0a0eae6d0c7802
ziga-lunarg [Sat, 17 Sep 2022 15:31:33 +0000 (17:31 +0200)]
Enable used features in present_id_wait tests
Featuers presentId and presentWait are used, but not enabled
Components: Vulkan
VK-GL-CTS issue: 3957
Affected tests:
dEQP-VK.wsi.win32.present_id_wait.*
Change-Id: Ia6e899d65c05a81876c5d46b8426425c10b657f1
ziga-lunarg [Sat, 17 Sep 2022 22:07:41 +0000 (00:07 +0200)]
Add image format support check in sparse render target tests
Check if format is supported for the test
Components: Vulkan
VK-GL-CTS issue: 3961
Affected tests:
dEQP-VK.*.suballocation.sparserendertarget.*
Change-Id: I9878d04465839ce73f9f6661e263a114c01037fb
ziga-lunarg [Fri, 23 Sep 2022 15:27:22 +0000 (17:27 +0200)]
Fix rendering flags in secondary command buffers tests
VkCommandBufferInheritanceRenderingInfo::flags must match
VkRenderingInfo::flags excluding
VK_RENDERING_CONTENTS_SECONDARY_COMMAND_BUFFERS_BIT
Components: Vulkan
VK-GL-CTS issue: 3987
Affected tests:
dEQP-VK.multiview.dynamic_rendering.secondary_cmd_buffer.*
Change-Id: I205594a88fbe7baf60146121e05b75201be9b46b
Matthew Netsch [Thu, 6 Oct 2022 19:54:16 +0000 (12:54 -0700)]
Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8
Change-Id: I56e0faf8f022888c1d28b368d7852a83575ae57d
ziga-lunarg [Sat, 17 Sep 2022 22:29:20 +0000 (00:29 +0200)]
Check if stage is supported with subgroup size
When using required subgroup size, shader stage used must be a bit in
VkPhysicalDeviceSubgroupSizeControlProperties requiredSubgroupSizeStages
Components: Vulkan
VK-GL-CTS issue: 3962
Affected tests:
dEQP-VK.reconvergence.*
Change-Id: Ie2109b6974c4da57f19e8d321e27ccbad1298c71
Matthew Netsch [Thu, 6 Oct 2022 16:26:49 +0000 (09:26 -0700)]
Merge vk-gl-cts/vulkan-cts-1.2.6 into vk-gl-cts/vulkan-cts-1.2.7
Change-Id: Iea1e614855e2a12ab124da1dd1f24f2aaa938406
ziga-lunarg [Mon, 19 Sep 2022 21:23:16 +0000 (23:23 +0200)]
Fix dedicated allocations in split frame rendering tests
The image bound to dedicated memory must match the image from
VkMemoryDedicatedAllocateInfo
Components: Vulkan
VK-GL-CTS issue: 3971
Affected tests:
dEQP-VK.device_group.sfr_*
Change-Id: I23684ae6777d575da5eb244dfd856946ba67aa4a
ziga-lunarg [Wed, 21 Sep 2022 21:00:04 +0000 (23:00 +0200)]
Fix external memory opaque fd tests for MacOS
Components: Vulkan
VK-GL-CTS issue: 3981
Affected tests:
dEQP-VK.api.external.memory.*
Change-Id: I21a169aab047e58bc716d2aa69426b23af9295f2
ziga-lunarg [Fri, 16 Sep 2022 00:42:41 +0000 (02:42 +0200)]
Fix attachment load op in framebuffer compatible render pass tests
If image layout is VK_LAYOUT_UNDEFINED the loadOp of
VkAttachmentDescription must not be VK_ATTACHMENT_LOAD_OP_LOAD
Components: Vulkan
VK-GL-CTS issue:3948
Affected tests:
dEQP-VK.api.pipeline.renderpass.framebuffer_compatible_renderpass
Change-Id: I4b31df7fa9ca56d9c31af1326b8036f81e9d80fe
ziga-lunarg [Mon, 19 Sep 2022 17:01:59 +0000 (19:01 +0200)]
Fix errors in imageless framebuffer tests
Attachment must not be VK_ATTACHMENT_LOAD_OP_LOAD if initialLayout is
VK_IMAGE_LAYOUT_UNDEFINED
If framebuffer flags contain VK_FRAMEBUFFER_CREATE_IMAGELESS_BIT then
image usage must include VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT
Components: Vulkan
VK-GL-CTS issue: 3969
Affected tests:
dEQP-VK.imageless_framebuffer.*
Change-Id: Ie588c547f8f55710eeffdccea94dd552dd8559a2
ziga-lunarg [Sat, 17 Sep 2022 19:25:08 +0000 (21:25 +0200)]
Use only required buffer usage bit in robustness tests
Using all bits requires additional checks for format support
Components: Vulkan
VK-GL-CTS issue: 3959
Affected tests:
dEQP-VK.robustness.*
Change-Id: I7a7c9e338b1e38a2d028f1fcffd6196bb75fa285
ziga-lunarg [Wed, 21 Sep 2022 16:45:54 +0000 (18:45 +0200)]
Fix srcStageMask in vkCmdWaitEvents in external fence tests
If event is set with vkSetEvent the srcStageMask must be
VK_PIPELINE_STAGE_HOST_BIT
Components: Vulkan
VK-GL-CTS issue: 3979
Affected tests:
dEQP-VK.api.external.fence.*
Change-Id: I9ca6fb5bdb597639cd5cb88afdbb03dde565acd8
ziga-lunarg [Wed, 21 Sep 2022 17:11:03 +0000 (19:11 +0200)]
Fix srcStageMask in vkCmdWaitEvents in secondary cmd buffers tests
If event is set with vkCmdSetEvent the srcStageMask must be
VK_PIPELINE_STAGE_HOST_BIT
Components: Vulkan
VK-GL-CTS issue: 3980
Affected tests:
dEQP-VK.api.command_buffers.secondary_execute_twice
Change-Id: Ib784e454ecf2bead488a267a069111da16ddfa8d
ziga-lunarg [Tue, 20 Sep 2022 19:49:29 +0000 (21:49 +0200)]
Fix memory allocation tests with device coherent memory
Extension VK_AMD_device_coherent_memory needs to be enabled in order ot
use VkPhysicalDeviceCoherentMemoryFeaturesAMD
Components: Vulkan
VK-GL-CTS issue: 3973
Affected tests:
dEQP-VK.memory.allocation.*
Change-Id: Ia866ab947bbd1af867f409053f830598965dea12
ziga-lunarg [Sat, 24 Sep 2022 00:25:44 +0000 (02:25 +0200)]
Fix color blend state in multisample tests
If the subpass the pipeline is created with has no color attachment the
attachmentCount of pColorBlendState must also be 0
Components: Vulkan
VK-GL-CTS issue: 3991
Affected tests:
dEQP-VK.pipeline.multisample.alpha_to_coverage_no_color_attachment.*
Change-Id: I37ca31e3114ca3e840759b118365f41b1a9565a1
ziga-lunarg [Wed, 21 Sep 2022 00:23:28 +0000 (02:23 +0200)]
Fix signal order tests timeline semaphore value
The new timeline semaphore value must be greater than the current value
of the semaphore
Components: Vulkan
VK-GL-CTS issue: 3978
Affected tests:
dEQP-VK.synchronization.signal_order.*
Change-Id: I7f1276dda7739f7817148550fd1b0782d9045849
Hyunjun Ko [Fri, 30 Sep 2022 01:02:25 +0000 (10:02 +0900)]
Add checking drawIndirectCount in conditional rendering tests.
Affects:
dEQP-VK.conditional_rendering.*_indirect_count
Components: Vulkan
VK-GL-CTS issue: 4012
Change-Id: Iad77cebba4a84833f7733a2f8041285623a000bc
ziga-lunarg [Sat, 17 Sep 2022 13:08:43 +0000 (15:08 +0200)]
Fix image barriers in image to image copy tests
The same image barriers are used twice if clearDestination is used,
the oldLayout of the second barrier does not match the current layout of
the image
Components: Vulkan
VK-GL-CTS issue: 3956
Affected tests:
dEQP-VK.api.copy_and_blit.*.image_to_image.*
Change-Id: I2623e70f3d4f0b97f9f941e4e6cb2760fd2c9d74
ziga-lunarg [Sat, 17 Sep 2022 22:40:54 +0000 (00:40 +0200)]
Fix srcStageMask in buffer_marker tests
If srcAccessMask in pipeline barrier is VK_ACCESS_TRANSFER_WRITE_BIT the
srcStageMask must be VK_PIPELINE_STAGE_TRANSFER_BIT
Components: Vulkan
VK-GL-CTS issue: 3963
Affected tests:
dEQP-VK.api.buffer_marker.compute.default_mem.*
Change-Id: I0a5957d714c4c5cb9f2855421cd78683b7b7b819
ziga-lunarg [Mon, 19 Sep 2022 00:00:02 +0000 (02:00 +0200)]
Enable features in synchrnozation tests custom device
The custom device used in synchrnonization utils does not enable any
features, but uses for example geometryShader
Components: Vulkan
VK-GL-CTS issue: 3964
Affected tests:
dEQP-VK.synchronization.*
Change-Id: Ia8f46b3e1ca519f0436f7545ef1b1a80652dbc88
ziga-lunarg [Tue, 27 Sep 2022 18:49:28 +0000 (20:49 +0200)]
Remove invalid unmatched flags test
The test is removed as it tries to perform a test case which is not
allowed by valid usage descriptions
This test was already removed from main, but not older release branches
Components: Vulkan
VK-GL-CTS issue: 3621
Removed tests:
dEQP-VK.api.device_init.create_device_queue2_unmatched_flags
Change-Id: I42c21222f7c3a066ca07b967bdde54dbb3007336
ziga-lunarg [Tue, 20 Sep 2022 23:07:56 +0000 (01:07 +0200)]
Fix barriers in synchronization2 tests
Stage VK_PIPELINE_STAGE_2_PRE_RASTERIZATION_SHADERS_BIT_KHR
is not supported with access mask VK_ACCESS_2_VERTEX_ATTRIBUTE_READ_BIT
or VK_ACCESS_2_INDEX_READ_BIT
Components: Vulkan
VK-GL-CTS issue: 3977
Affected tests:
dEQP-VK.synchronization2.*
Change-Id: I0c40b798e80fda98cdda49788210331a878f6bd5
ziga-lunarg [Fri, 23 Sep 2022 00:34:09 +0000 (02:34 +0200)]
Fix errors in buffer_marker tests
If srcAccessMask is VK_ACCESS_TRANSFER_WRITE_BIT the stage mask must be
VK_PIPELINE_STAGE_TRANSFER_BIT
If vkFreeDescriptors is called, the descriptor pool must have been
created with VK_DESCRIPTOR_POOL_CREATE_FREE_DESCRIPTOR_SET_BIT
Components: Vulkan
VK-GL-CTS issue: 3984
Affected tests:
dEQP-VK.api.buffer_marker.*.default_mem.*
Change-Id: Iaec7d2a74f7d4084258206d4c96cc112c23e38f8
Piotr Byszewski [Fri, 9 Sep 2022 17:04:27 +0000 (19:04 +0200)]
Test cmdCopyBuffer with unaligned offsets & sizes
VK-GL-CTS issue: 3686
Components: Vulkan
New tests:
dEQP-VK.api.copy_and_blit.*.buffer_to_buffer.unaligned_regions
Change-Id: I76304689ff5474dcadbbf0bfb2f422939a6dfc27
ziga-lunarg [Mon, 12 Sep 2022 21:35:35 +0000 (23:35 +0200)]
Fix tracking image layout in load_store_op_none tests
If multiple aspects of the image were read, the image was transitioned
from the same layout multiple times
Components: Vulkan
VK-GL-CTS issue: 3941
Affected tests:
dEQP-VK.*.load_store_op_none.*
Change-Id: Iea645d3c6fc683dcd3005e11d7c4ec50379dd2ff
Graeme Leese [Mon, 12 Sep 2022 16:34:14 +0000 (17:34 +0100)]
Enable extended_dynamic_state tests for VK1.3
The partial promotion of the 2 extended dynamic state extensions meant
that the tests were not being run on VK 1.3 core if the extension was
not also exposed.
This change has the tests checkSupport always based off the feature
struct, with the framework extended to fill in the extension features on
core implementations. This is consistent with how unsupported extensions
are normally handled (the framework fills in an empty feature struct, so
they can always be used to determine test support).
Components: Vulkan, Framework
VK-GL-CTS issue: 3937
Affects: dEQP-VK.pipeline.*.extended_dynamic_state.*
Change-Id: Ifc3e821a50e55e54cc0bbd938d2080e526a7b55f
Hyunjun Ko [Tue, 20 Sep 2022 02:39:36 +0000 (11:39 +0900)]
Add alpha to one tests with single sample.
The current multisample alpha to one tests all use multiple sample but
it should work for single sample too.
New tests:
dEQP-VK.pipeline.*.multisample.alpha_to_one.samples_1*
Affects:
dEQP-VK.pipeline.*.multisample.alpha_to_one.*
Components: Vulkan
VK-GL-CTS issue: 3834
Change-Id: Idf434335f0ef4651543b74860ec4c0a0781eea02
Hyunjun Ko [Thu, 15 Sep 2022 07:29:30 +0000 (16:29 +0900)]
Add FSR tests with ImageView VK_NULL_HANDLE for dynamic rendering.
New tests:
dEQP-VK.fragment_shading_rate.dynamic_rendering.*.attachment_noimageview.*
Affects:
dEQP-VK.fragment_shading_rate.dynamic_rendering.*
VK-GL-CTS Issue: 3919
Components: Vulkan
Change-Id: Ic86bd7cf89bdc895663af1fd7b8248db38cc4dce
Hyunjun Ko [Tue, 23 Aug 2022 05:14:06 +0000 (14:14 +0900)]
Add more tests for occlusion and statistics query.
1. Test without any color attachment.
- To verify the results are same as normal cases.
2. Test to execute clear operations within a query activated.
- To make sure internal driver operations are not counted.
New tests:
dEQP-VK.query_pool.occlusion_query.*_no_color_attachments
dEQP-VK.query_pool.statistics_query.*_no_color_attachments
dEQP-VK.query_pool.occlusion_query.*_clear_color
dEQP-VK.query_pool.occlusion_query.*_clear_depth
dEQP-VK.query_pool.statistics_query.*_clear_color
dEQP-VK.query_pool.statistics_query.*_clear_depth
Affects:
dEQP-VK.query_pool.occlusion_query.*
dEQP-VK.query_pool.statistics_query.*
VK-GL-CTS Issue: 3570
Components: Vulkan
Change-Id: I687814f75e4c3936f26fe9217068c190f73a5165
ziga-lunarg [Sun, 19 Jun 2022 20:59:01 +0000 (22:59 +0200)]
Add tests for transfers with uneven vertical sizes
Test transfers from buffer to image and back to buffer where
image height is not divisible by 4
Components: Vulkan
VK-GL-CTS issue: 3769
New Tests:
dEQP-VK.image.queue_transfer.*
Affected Tests:
dEQP-VK.ycbcr.copy.*
Change-Id: Ia34f18d73a3091bc32bdb9eaaaf80911e5264992
michal_jakubek [Fri, 1 Apr 2022 11:53:36 +0000 (13:53 +0200)]
Apply BLAS pool to ray_tracing_pipeline.build.* tests
In addition to replacing traditional memory allocation
with a pool of BLAS structures the tests have been
explicitly divided into GPU and CPU parts. The main
motivation to do this was a inability to run the tests
on implementations that do not support both methods
concurently. so the names have changed respectively.
Nevertheless,the logic of the tests remained unchanged.
Affects: dEQP-VK.ray_tracing_pipeline.build.*
Components: Vulkan
VK-GL-CTS issue: 3599
Change-Id: I7fd022797b1f0fbea9c59bab7ca580d5d0a3eb62
Marcin Zając [Thu, 10 Mar 2022 15:38:28 +0000 (16:38 +0100)]
Add tests for transformFeedbackStreamsLinesTriangles
Exercise transform feedback for lines and triangles.
Add tests:
dEQP-VK.transform_feedback.simple.lines_or_triangles_*
Affect tests:
dEQP-VK.transform_feedback.simple.*
Components: Vulkan
VK-GL-CTS issue: 2930
Change-Id: I9e9ac9ced5ae9c7e5da3dd7d3b25babc385d0ef1
Piers Daniell [Mon, 26 Sep 2022 20:52:09 +0000 (14:52 -0600)]
Fix missing pipelineStageCreationFeedbackCount=0 cases
The new test coverage in https://gerrit.khronos.org/c/vk-gl-cts/+/9765
didn't set pipelineStageCreationFeedbackCount=0 for the pipeline_library
cases leading to false failures.
Components: Vulkan
VK-GL-CTS issue: 3736
Affects:
dEQP-VK.pipeline.*.creation_feedback.*
Change-Id: Ia06d383aec28accc6055e6a2a0573a6625315df0
John Barbone [Tue, 27 Sep 2022 13:51:49 +0000 (14:51 +0100)]
Fixed number of vertices in draw call
tests were drawing 6 vertices but only 2 had been added to buffer
Affects:
dEQP-VK.dynamic_state.*.image.clear
dEQP-VK.dynamic_state.*.image.blit
dEQP-VK.dynamic_state.*.image.copy
dEQP-VK.dynamic_state.*.image.resolve
Components: Vulkan
VK-GL-CTS issue: 4001
Change-Id: I5fe593195770e3a705ed9b9986d140a9f7dd9bce
Matthew Netsch [Fri, 30 Sep 2022 17:42:08 +0000 (10:42 -0700)]
Merge vk-gl-cts/vulkan-cts-1.3.3 into vk-gl-cts/main
Change-Id: I128184c0a25ceb0c53106ce46d6d0207976f4b77
Matthew Netsch [Fri, 30 Sep 2022 14:36:51 +0000 (07:36 -0700)]
Merge vk-gl-cts/vulkan-cts-1.3.3 into vk-gl-cts/vulkan-cts-1.3.4
Change-Id: Ic15bc53351152edb7ff0d091678d7edb0a0724a3
Hyunjun Ko [Tue, 20 Sep 2022 01:07:41 +0000 (10:07 +0900)]
Add checking VK_KHR_ray_tracing_pipeline extension.
Affects:
dEQP-VK.ray_tracing_pipeline.acceleration_structures.copy_within_pipeline.*
Components: Vulkan
VK-GL-CTS issue: 3824
Change-Id: Iac1380eb2f2d458570271217e433cd0bcd147b99
ziga-lunarg [Mon, 29 Aug 2022 19:10:47 +0000 (21:10 +0200)]
Add missing check for imageCubeArray feature
Feature imageCubeArray needs to be enabled when image views use type
VK_IMAGE_VIEW_TYPE_CUBE_ARRAY
Components: Vulkan
VK-GL-CTS issue: 3910
Affected tests:
dEQP-VK.api.object_management.*
Change-Id: Ie49c70b7311b29609bec5e1cc6f5570c33002d90
projects / platform / upstream / VK-GL-CTS.git / log