commit-queue@webkit.org [Mon, 21 May 2012 21:53:06 +0000 (21:53 +0000)]
[Qt][WK2] fast/forms/submit-to-blank-multiple-times.html fails
https://bugs.webkit.org/show_bug.cgi?id=68309
Patch by Hugo Parente Lima <hugo.lima@openbossa.org> on 2012-05-21
Reviewed by Alexis Menard.
Source/WebKit2:
Force focus when the element receives a double click event.
* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebView::mouseDoubleClickEvent):
LayoutTests:
Unskip the test.
* platform/qt-5.0-wk2/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117820
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
leviw@chromium.org [Mon, 21 May 2012 21:40:47 +0000 (21:40 +0000)]
Unreviewed Chromium expectation update following sub-pixel r117815. This covers all updates
in chromium and chromium-mac directories. Seperate patches coming for Linux and Windows.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117818
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jsbell@chromium.org [Mon, 21 May 2012 21:34:39 +0000 (21:34 +0000)]
IndexedDB: Store key paths in IDBKeyPath type instead of String
https://bugs.webkit.org/show_bug.cgi?id=85298
Reviewed by Tony Chang, Kentaro Hara and James Robinson.
Source/WebCore:
Migrate from storing key paths as (nullable) Strings to a dedicated IDBKeyPath
type. Prep work for supporting array-type key paths: http://webkit.org/b/84207
Only functional change is handling of null/undefined parameters for key paths,
to align with IDB spec, covered by layout test.
Test: storage/indexeddb/keypath-basics.html
Test: WebKit/chromium/IDBLevelDBCodingTest.cpp
* Modules/indexeddb/IDBAny.cpp: Allow IDBAny to yield DOMStrings.
(WebCore::IDBAny::createString):
(WebCore):
(WebCore::IDBAny::string):
(WebCore::IDBAny::set):
* Modules/indexeddb/IDBAny.h:
(IDBAny):
* Modules/indexeddb/IDBBackingStore.h: Switch from String to IDBKeyPath.
(IDBBackingStore):
* Modules/indexeddb/IDBDatabase.cpp: Switch from String to IDBKeyPath.
(WebCore::IDBDatabase::createObjectStore):
* Modules/indexeddb/IDBDatabaseBackendImpl.cpp: Switch from String to IDBKeyPath.
(WebCore::IDBDatabaseBackendImpl::createObjectStore):
(WebCore::IDBDatabaseBackendImpl::loadObjectStores):
* Modules/indexeddb/IDBDatabaseBackendImpl.h: Switch from String to IDBKeyPath.
(IDBDatabaseBackendImpl):
* Modules/indexeddb/IDBDatabaseBackendInterface.h: Switch from String to IDBKeyPath.
(WebCore):
(IDBDatabaseBackendInterface):
* Modules/indexeddb/IDBIndex.h: Switch from String to IDBAny (via IDBKeyPath).
(WebCore::IDBIndex::keyPath):
* Modules/indexeddb/IDBIndex.idl: Switch from DOMString? to IDBAny.
* Modules/indexeddb/IDBIndexBackendImpl.cpp: Switch from String to IDBKeyPath.
(WebCore::IDBIndexBackendImpl::IDBIndexBackendImpl):
* Modules/indexeddb/IDBIndexBackendImpl.h: Switch from String to IDBKeyPath.
(WebCore::IDBIndexBackendImpl::create):
(WebCore::IDBIndexBackendImpl::keyPath):
(IDBIndexBackendImpl):
* Modules/indexeddb/IDBIndexBackendInterface.h: Switch from String to IDBKeyPath.
(WebCore):
(IDBIndexBackendInterface):
* Modules/indexeddb/IDBKeyPath.cpp: Non-trivial method implementations.
(WebCore::IDBKeyPath::isValid):
(WebCore):
(WebCore::IDBKeyPath::operator PassRefPtr<IDBAny>):
* Modules/indexeddb/IDBKeyPath.h: Introduce IDBKeyPath type.
(IDBKeyPath):
(WebCore::IDBKeyPath::IDBKeyPath):
(WebCore::IDBKeyPath::type):
(WebCore::IDBKeyPath::array):
(WebCore::IDBKeyPath::string):
(WebCore::IDBKeyPath::isNull):
(WebCore):
* Modules/indexeddb/IDBKeyPathBackendImpl.cpp: Switch from String to IDBKeyPath.
(WebCore::IDBKeyPathBackendImpl::createIDBKeysFromSerializedValuesAndKeyPath):
(WebCore::IDBKeyPathBackendImpl::injectIDBKeyIntoSerializedValue):
* Modules/indexeddb/IDBKeyPathBackendImpl.h: Switch from String to IDBKeyPath.
(WebCore):
(IDBKeyPathBackendImpl):
* Modules/indexeddb/IDBLevelDBBackingStore.cpp: Switch from String to IDBKeyPath, with back-compat.
(WebCore):
(WebCore::putIDBKeyPath):
(WebCore::IDBLevelDBBackingStore::getObjectStores):
(WebCore::IDBLevelDBBackingStore::createObjectStore):
(WebCore::IDBLevelDBBackingStore::getIndexes):
(WebCore::IDBLevelDBBackingStore::createIndex):
* Modules/indexeddb/IDBLevelDBBackingStore.h:
(IDBLevelDBBackingStore):
* Modules/indexeddb/IDBLevelDBCoding.cpp: New coding scheme for key paths (with back-compat).
(IDBLevelDBCoding):
(WebCore::IDBLevelDBCoding::encodeIDBKeyPath):
(WebCore::IDBLevelDBCoding::decodeIDBKeyPath):
* Modules/indexeddb/IDBLevelDBCoding.h: Add key-path-specific methods.
(WebCore):
(IDBLevelDBCoding):
* Modules/indexeddb/IDBObjectStore.cpp: Switch from String to IDBKeyPath.
(WebCore::IDBObjectStore::keyPath):
(WebCore::IDBObjectStore::createIndex):
(WebCore):
* Modules/indexeddb/IDBObjectStore.h: Switch from String to IDBAny (via IDBKeyPath).
(IDBObjectStore):
* Modules/indexeddb/IDBObjectStore.idl: Switch from DOMString? to IDBAny.
* Modules/indexeddb/IDBObjectStoreBackendImpl.cpp: Switch from String to IDBKeyPath.
(WebCore::IDBObjectStoreBackendImpl::IDBObjectStoreBackendImpl):
(WebCore::fetchKeyFromKeyPath):
(WebCore::injectKeyIntoKeyPath):
(WebCore::IDBObjectStoreBackendImpl::createIndex):
(WebCore::IDBObjectStoreBackendImpl::loadIndexes):
* Modules/indexeddb/IDBObjectStoreBackendImpl.h: Switch from String to IDBKeyPath.
(WebCore::IDBObjectStoreBackendImpl::create):
(WebCore::IDBObjectStoreBackendImpl::keyPath):
(IDBObjectStoreBackendImpl):
* Modules/indexeddb/IDBObjectStoreBackendInterface.h: Switch from String to IDBKeyPath.
(WebCore):
(IDBObjectStoreBackendInterface):
* bindings/v8/Dictionary.cpp: Add getter for DOMString[] (i.e. Vector<String>)
(WebCore):
(WebCore::Dictionary::get):
* bindings/v8/Dictionary.h:
(Dictionary):
* bindings/v8/IDBBindingUtilities.cpp: Switch from String to IDBKeyPath.
(WebCore::createIDBKeyFromSerializedValueAndKeyPath):
(WebCore::injectIDBKeyIntoSerializedValue):
* bindings/v8/IDBBindingUtilities.h: Switch from String to IDBKeyPath.
(WebCore):
* bindings/v8/custom/V8IDBAnyCustom.cpp: Support String/DOMString.
(WebCore::toV8):
* dom/DOMStringList.h: Allow easy (const) access to strings.
(WebCore::DOMStringList::operator const Vector<String>&):
(DOMStringList):
* inspector/InspectorIndexedDBAgent.cpp: Temporary shim for non-strings: see http://webkit.org/b/84303
(WebCore):
* platform/chromium/PlatformSupport.h: Switch from String to IDBKeyPath.
(WebCore):
(PlatformSupport):
* storage/chromium/IDBKeyPathBackendImpl.cpp: Switch from String to IDBKeyPath.
(WebCore::IDBKeyPathBackendImpl::createIDBKeysFromSerializedValuesAndKeyPath):
(WebCore::IDBKeyPathBackendImpl::injectIDBKeyIntoSerializedValue):
Source/WebKit/chromium:
No functional changes, just finish migration from String to IDBKeyPath
for storing key paths, for eventual array support http://webkit.org/b/84207
* public/WebIDBDatabase.h: Remove temporary overload.
(WebKit):
(WebKit::WebIDBDatabase::objectStoreNames):
* public/WebIDBIndex.h: Remove temporary method.
(WebKit::WebIDBIndex::keyPath):
* public/WebIDBKeyPath.h: Remove obsolete methods, wrap WebCore::IDBKeyPath
(WebIDBKeyPath):
(WebKit::WebIDBKeyPath::WebIDBKeyPath):
* public/WebIDBObjectStore.h: Remove temporary method and overload.
(WebKit::WebIDBObjectStore::keyPath):
* public/platform/WebKitPlatformSupport.h: Remove temporary overloads.
(WebKit):
* src/AssertMatchingEnums.cpp: WebIDBKeyPath vs. IDBKeyPath enums.
* src/IDBDatabaseBackendProxy.cpp: Switch from String to IDBKeyPath.
(WebKit::IDBDatabaseBackendProxy::createObjectStore):
* src/IDBDatabaseBackendProxy.h: Switch from String to IDBKeyPath.
(IDBDatabaseBackendProxy):
* src/IDBIndexBackendProxy.cpp: Switch from String to IDBKeyPath.
(WebKit::IDBIndexBackendProxy::keyPath):
* src/IDBIndexBackendProxy.h: Switch from String to IDBKeyPath.
(IDBIndexBackendProxy):
* src/IDBObjectStoreBackendProxy.cpp: Switch from String to IDBKeyPath.
(WebKit::IDBObjectStoreBackendProxy::keyPath):
(WebKit::IDBObjectStoreBackendProxy::createIndex):
* src/IDBObjectStoreBackendProxy.h: Switch from String to IDBKeyPath.
(IDBObjectStoreBackendProxy):
* src/PlatformSupport.cpp: Switch from String to IDBKeyPath.
(WebCore::PlatformSupport::createIDBKeysFromSerializedValuesAndKeyPath):
(WebCore::PlatformSupport::injectIDBKeyIntoSerializedValue):
* src/WebIDBDatabaseImpl.cpp: Switch from String to IDBKeyPath.
(WebKit::WebIDBDatabaseImpl::createObjectStore):
* src/WebIDBDatabaseImpl.h: Remove temporary overload.
(WebIDBDatabaseImpl):
* src/WebIDBIndexImpl.cpp: Remove temporary method.
* src/WebIDBIndexImpl.h: Remove temporary method.
(WebIDBIndexImpl):
* src/WebIDBKeyPath.cpp: Remove most logic; just a wrapper for WebCore::IDBKeyPath.
(WebKit::WebIDBKeyPath::~WebIDBKeyPath):
(WebKit::WebIDBKeyPath::create):
(WebKit::WebIDBKeyPath::createNull):
(WebKit::WebIDBKeyPath::isValid):
(WebKit::WebIDBKeyPath::type):
(WebKit):
(WebKit::WebIDBKeyPath::array):
(WebKit::WebIDBKeyPath::string):
(WebKit::WebIDBKeyPath::WebIDBKeyPath):
(WebKit::WebIDBKeyPath::operator=):
(WebKit::WebIDBKeyPath::operator const WebCore::IDBKeyPath&):
* src/WebIDBObjectStoreImpl.cpp: Remove temporary method and overload.
(WebKit::WebIDBObjectStoreImpl::keyPath):
(WebKit::WebIDBObjectStoreImpl::createIndex):
* src/WebIDBObjectStoreImpl.h: Remove temporary method and overload.
(WebIDBObjectStoreImpl):
* tests/IDBBindingUtilitiesTest.cpp: Use IDBKeyPath.
(WebCore::checkKeyFromValueAndKeyPathInternal):
(WebCore::injectKey):
* tests/IDBLevelDBCodingTest.cpp: Added EncodeIDBKeyPath and DecodeIDBKeyPath tests.
(IDBLevelDBCoding::TEST):
(IDBLevelDBCoding):
* tests/IDBKeyPathTest.cpp:
(WebCore::checkKeyPath): Test IDBKeyPath validity.
LayoutTests:
* storage/indexeddb/keypath-basics-expected.txt:
* storage/indexeddb/resources/keypath-basics.js:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117817
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jsbell@chromium.org [Mon, 21 May 2012 21:30:59 +0000 (21:30 +0000)]
Move WebSQL tests in LayoutTests/storage to websql directory
https://bugs.webkit.org/show_bug.cgi?id=86138
Reviewed by Ryosuke Niwa.
* fast/workers/storage/resources/database-worker-controller.js:
(runTest):
* platform/chromium-mac/storage/websql/statement-error-callback-expected.txt: Renamed from LayoutTests/platform/chromium-mac/storage/statement-error-callback-expected.txt.
* platform/chromium-mac/storage/websql/transaction-callback-exception-crash-expected.txt: Renamed from LayoutTests/platform/chromium-mac/storage/transaction-callback-exception-crash-expected.txt.
* platform/chromium-mac/storage/websql/transaction-error-callback-expected.txt: Renamed from LayoutTests/platform/chromium-mac/storage/transaction-error-callback-expected.txt.
* platform/chromium-win/storage/websql/statement-error-callback-expected.txt: Renamed from LayoutTests/platform/chromium-win/storage/statement-error-callback-expected.txt.
* platform/chromium-win/storage/websql/transaction-callback-exception-crash-expected.txt: Renamed from LayoutTests/platform/chromium-win/storage/transaction-callback-exception-crash-expected.txt.
* platform/chromium-win/storage/websql/transaction-error-callback-expected.txt: Renamed from LayoutTests/platform/chromium-win/storage/transaction-error-callback-expected.txt.
* platform/chromium/storage/websql/quota-tracking-expected.txt: Renamed from LayoutTests/platform/chromium/storage/quota-tracking-expected.txt.
* platform/chromium/storage/websql/sql-error-codes-expected.txt: Renamed from LayoutTests/platform/chromium/storage/sql-error-codes-expected.txt.
* platform/chromium/test_expectations.txt:
* platform/gtk/test_expectations.txt:
* storage/websql/change-version-expected.txt: Renamed from LayoutTests/storage/change-version-expected.txt.
* storage/websql/change-version-handle-reuse-expected.txt: Renamed from LayoutTests/storage/change-version-handle-reuse-expected.txt.
* storage/websql/change-version-handle-reuse.html: Renamed from LayoutTests/storage/change-version-handle-reuse.html.
* storage/websql/change-version-handle-reuse.js: Renamed from LayoutTests/storage/change-version-handle-reuse.js.
(finishTest):
(runTest.catch):
(runTest):
(runTest2.catch):
(runTest2):
* storage/websql/change-version-no-crash-on-preflight-failure-expected.txt: Renamed from LayoutTests/storage/change-version-no-crash-on-preflight-failure-expected.txt.
* storage/websql/change-version-no-crash-on-preflight-failure.html: Renamed from LayoutTests/storage/change-version-no-crash-on-preflight-failure.html.
* storage/websql/change-version.html: Renamed from LayoutTests/storage/change-version.html.
* storage/websql/close-during-stress-test-expected.txt: Renamed from LayoutTests/storage/close-during-stress-test-expected.txt.
* storage/websql/close-during-stress-test.html: Renamed from LayoutTests/storage/close-during-stress-test.html.
* storage/websql/database-lock-after-reload-expected.txt: Renamed from LayoutTests/storage/database-lock-after-reload-expected.txt.
* storage/websql/database-lock-after-reload.html: Renamed from LayoutTests/storage/database-lock-after-reload.html.
* storage/websql/empty-statement-expected.txt: Renamed from LayoutTests/storage/empty-statement-expected.txt.
* storage/websql/empty-statement.html: Renamed from LayoutTests/storage/empty-statement.html.
* storage/websql/execute-sql-args-expected.txt: Renamed from LayoutTests/storage/execute-sql-args-expected.txt.
* storage/websql/execute-sql-args.html: Renamed from LayoutTests/storage/execute-sql-args.html.
* storage/websql/execute-sql-args.js: Renamed from LayoutTests/storage/execute-sql-args.js.
(throwOnToStringObject.toString):
(var):
(tryExecuteSql):
(runTransactionTest):
(runTransactionTests):
(runTest):
* storage/websql/executesql-accepts-only-one-statement-expected.txt: Renamed from LayoutTests/storage/executesql-accepts-only-one-statement-expected.txt.
* storage/websql/executesql-accepts-only-one-statement.html: Renamed from LayoutTests/storage/executesql-accepts-only-one-statement.html.
* storage/websql/hash-change-with-xhr-expected.txt: Renamed from LayoutTests/storage/hash-change-with-xhr-expected.txt.
* storage/websql/hash-change-with-xhr.html: Renamed from LayoutTests/storage/hash-change-with-xhr.html.
* storage/websql/hash-change-with-xhr.js: Renamed from LayoutTests/storage/hash-change-with-xhr.js.
(stopIntervals):
(stopTest):
(updateDatabase):
(checkForSuccess):
(errorHandler):
(sendXhr):
(invokeBack):
(runTest):
(runTestsInner):
* storage/websql/multiple-databases-garbage-collection-expected.txt: Renamed from LayoutTests/storage/multiple-databases-garbage-collection-expected.txt.
* storage/websql/multiple-databases-garbage-collection.html: Renamed from LayoutTests/storage/multiple-databases-garbage-collection.html.
* storage/websql/multiple-databases-garbage-collection.js: Renamed from LayoutTests/storage/multiple-databases-garbage-collection.js.
(GC):
(checkCompletion):
(runTest):
* storage/websql/multiple-transactions-expected.txt: Renamed from LayoutTests/storage/multiple-transactions-expected.txt.
* storage/websql/multiple-transactions-on-different-handles-expected.txt: Renamed from LayoutTests/storage/multiple-transactions-on-different-handles-expected.txt.
* storage/websql/multiple-transactions-on-different-handles.html: Renamed from LayoutTests/storage/multiple-transactions-on-different-handles.html.
* storage/websql/multiple-transactions-on-different-handles.js: Renamed from LayoutTests/storage/multiple-transactions-on-different-handles.js.
(checkCompletion):
(openTestDatabase):
(statementSuccessCallback):
(statementErrorCallback):
(runTransaction):
(runTest):
* storage/websql/multiple-transactions.html: Renamed from LayoutTests/storage/multiple-transactions.html.
* storage/websql/multiple-transactions.js: Renamed from LayoutTests/storage/multiple-transactions.js.
(checkCompletion):
(runTest.db):
(runTest):
* storage/websql/null-callbacks-expected.txt: Renamed from LayoutTests/storage/null-callbacks-expected.txt.
* storage/websql/null-callbacks.html: Renamed from LayoutTests/storage/null-callbacks.html.
* storage/websql/open-database-creation-callback-expected.txt: Renamed from LayoutTests/storage/open-database-creation-callback-expected.txt.
* storage/websql/open-database-creation-callback-isolated-world-expected.txt: Renamed from LayoutTests/storage/open-database-creation-callback-isolated-world-expected.txt.
* storage/websql/open-database-creation-callback-isolated-world.html: Renamed from LayoutTests/storage/open-database-creation-callback-isolated-world.html.
* storage/websql/open-database-creation-callback.html: Renamed from LayoutTests/storage/open-database-creation-callback.html.
* storage/websql/open-database-empty-version-expected.txt: Renamed from LayoutTests/storage/open-database-empty-version-expected.txt.
* storage/websql/open-database-empty-version.html: Renamed from LayoutTests/storage/open-database-empty-version.html.
* storage/websql/open-database-over-quota-expected.txt: Renamed from LayoutTests/storage/open-database-over-quota-expected.txt.
* storage/websql/open-database-over-quota.html: Renamed from LayoutTests/storage/open-database-over-quota.html.
* storage/websql/open-database-set-empty-version-expected.txt: Renamed from LayoutTests/storage/open-database-set-empty-version-expected.txt.
* storage/websql/open-database-set-empty-version.html: Renamed from LayoutTests/storage/open-database-set-empty-version.html.
* storage/websql/open-database-while-transaction-in-progress-expected.txt: Renamed from LayoutTests/storage/open-database-while-transaction-in-progress-expected.txt.
* storage/websql/open-database-while-transaction-in-progress.html: Renamed from LayoutTests/storage/open-database-while-transaction-in-progress.html.
* storage/websql/open-database-while-transaction-in-progress.js: Renamed from LayoutTests/storage/open-database-while-transaction-in-progress.js.
(openTestDatabase):
(runTest.db1.transaction):
(runTest):
* storage/websql/private-browsing-noread-nowrite-expected.txt: Renamed from LayoutTests/storage/private-browsing-noread-nowrite-expected.txt.
* storage/websql/private-browsing-noread-nowrite.html: Renamed from LayoutTests/storage/private-browsing-noread-nowrite.html.
* storage/websql/quota-tracking-expected.txt: Renamed from LayoutTests/storage/quota-tracking-expected.txt.
* storage/websql/quota-tracking.html: Renamed from LayoutTests/storage/quota-tracking.html.
* storage/websql/read-and-write-transactions-dont-run-together-expected.txt: Renamed from LayoutTests/storage/read-and-write-transactions-dont-run-together-expected.txt.
* storage/websql/read-and-write-transactions-dont-run-together.html: Renamed from LayoutTests/storage/read-and-write-transactions-dont-run-together.html.
* storage/websql/read-and-write-transactions-dont-run-together.js: Renamed from LayoutTests/storage/read-and-write-transactions-dont-run-together.js.
(terminateTest):
(openTestDatabase):
(runTransaction):
(runTest):
* storage/websql/read-transactions-running-concurrently-expected.txt: Renamed from LayoutTests/storage/read-transactions-running-concurrently-expected.txt.
* storage/websql/read-transactions-running-concurrently.html: Renamed from LayoutTests/storage/read-transactions-running-concurrently.html.
* storage/websql/resources/database-common.js: Renamed from LayoutTests/storage/resources/database-common.js.
(openDatabaseWithSuffix):
(log):
(setLocationHash):
(setupAndRunTest):
* storage/websql/resources/database-lock-after-reload-2.html: Renamed from LayoutTests/storage/resources/database-lock-after-reload-2.html.
* storage/websql/resources/stress-frame.html: Renamed from LayoutTests/storage/resources/stress-frame.html.
* storage/websql/sql-data-types-expected.txt: Renamed from LayoutTests/storage/sql-data-types-expected.txt.
* storage/websql/sql-data-types.html: Renamed from LayoutTests/storage/sql-data-types.html.
* storage/websql/sql-data-types.js: Renamed from LayoutTests/storage/sql-data-types.js.
(writeMessageToLog):
(notifyDone):
(shouldBeSameTypeAndValue):
(testDBValues):
(fetchDBValuesStmt):
(insertTestValuesStmt):
(createTestDBStmt):
(runTest):
* storage/websql/sql-error-codes-expected.txt: Renamed from LayoutTests/storage/sql-error-codes-expected.txt.
* storage/websql/sql-error-codes.html: Renamed from LayoutTests/storage/sql-error-codes.html.
* storage/websql/sql-error-codes.js: Renamed from LayoutTests/storage/sql-error-codes.js.
(finishTest):
(transactionErrorCallback):
(transactionSuccessCallback):
(testTransaction):
(testTransactionThrowsException):
(testTransactionFailureBecauseOfStatementFailure):
(testInvalidStatement):
(testIncorrectNumberOfBindParameters):
(testBindParameterOfWrongType.badString.toString):
(testBindParameterOfWrongType):
(testQuotaExceeded):
(testVersionMismatch.db.transaction):
(testVersionMismatch):
(runTest):
* storage/websql/statement-error-callback-expected.txt: Renamed from LayoutTests/storage/statement-error-callback-expected.txt.
* storage/websql/statement-error-callback-isolated-world-expected.txt: Renamed from LayoutTests/storage/statement-error-callback-isolated-world-expected.txt.
* storage/websql/statement-error-callback-isolated-world.html: Renamed from LayoutTests/storage/statement-error-callback-isolated-world.html.
* storage/websql/statement-error-callback.html: Renamed from LayoutTests/storage/statement-error-callback.html.
* storage/websql/statement-success-callback-isolated-world-expected.txt: Renamed from LayoutTests/storage/statement-success-callback-isolated-world-expected.txt.
* storage/websql/statement-success-callback-isolated-world.html: Renamed from LayoutTests/storage/statement-success-callback-isolated-world.html.
* storage/websql/success-callback-expected.txt: Renamed from LayoutTests/storage/success-callback-expected.txt.
* storage/websql/success-callback.html: Renamed from LayoutTests/storage/success-callback.html.
* storage/websql/test-authorizer-expected.txt: Renamed from LayoutTests/storage/test-authorizer-expected.txt.
* storage/websql/test-authorizer.html: Renamed from LayoutTests/storage/test-authorizer.html.
* storage/websql/test-authorizer.js: Renamed from LayoutTests/storage/test-authorizer.js.
(terminateTest):
(logAndTerminateTest):
(cleanup):
(statementSuccessCallback):
(statementErrorCallback):
(executeStatement):
(createTableCallback):
(createStatementsCallback):
(otherStatementsCallback):
(dropStatementsCallback):
(testReadWriteMode):
(testReadOnlyMode.db):
(testReadOnlyMode):
(runTest):
* storage/websql/transaction-callback-exception-crash-expected.txt: Renamed from LayoutTests/storage/transaction-callback-exception-crash-expected.txt.
* storage/websql/transaction-callback-exception-crash.html: Renamed from LayoutTests/storage/transaction-callback-exception-crash.html.
* storage/websql/transaction-callback-isolated-world-expected.txt: Renamed from LayoutTests/storage/transaction-callback-isolated-world-expected.txt.
* storage/websql/transaction-callback-isolated-world.html: Renamed from LayoutTests/storage/transaction-callback-isolated-world.html.
* storage/websql/transaction-error-callback-expected.txt: Renamed from LayoutTests/storage/transaction-error-callback-expected.txt.
* storage/websql/transaction-error-callback-isolated-world-expected.txt: Renamed from LayoutTests/storage/transaction-error-callback-isolated-world-expected.txt.
* storage/websql/transaction-error-callback-isolated-world.html: Renamed from LayoutTests/storage/transaction-error-callback-isolated-world.html.
* storage/websql/transaction-error-callback.html: Renamed from LayoutTests/storage/transaction-error-callback.html.
* storage/websql/transaction-success-callback-isolated-world-expected.txt: Renamed from LayoutTests/storage/transaction-success-callback-isolated-world-expected.txt.
* storage/websql/transaction-success-callback-isolated-world.html: Renamed from LayoutTests/storage/transaction-success-callback-isolated-world.html.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117816
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
leviw@chromium.org [Mon, 21 May 2012 21:18:32 +0000 (21:18 +0000)]
Enable SUBPIXEL_LAYOUT feature flag on Chromium
https://bugs.webkit.org/show_bug.cgi?id=85555
Source/WTF:
Reviewed by Eric Seidel.
Enabling sub-pixel layout on Chromium port.
* wtf/Platform.h:
LayoutTests:
Patch by Levi Weintraub <leviw@chromium.org> and Emil A Eklund <eae@chromium.org> on 2012-05-21
Reviewed by Eric Seidel.
Updating tests to handle sub-pixel layout, and updating chromium-linux expecations. Updated test
expectations for Chromium Linux and Mac are ready, but the diff is too large for Buzgilla's tiny
brain (>10MB).
* css1/units/rounding.html:
* fast/borders/border-radius-huge-assert.html:
* fast/css/zoom-in-length-round-trip.html:
* fast/dom/Document/CaretRangeFromPoint/hittest-relative-to-viewport.html:
* fast/dom/Window/webkitConvertPoint.html:
* fast/dom/elementFromPoint-relative-to-viewport.html:
* fast/events/clientXY-in-zoom-and-scroll.html:
* fast/events/document-elementFromPoint.html:
* fast/events/offsetX-offsetY.html:
* fast/multicol/break-properties.html:
* fast/multicol/vertical-lr/break-properties.html:
* fast/multicol/vertical-rl/break-properties.html:
* fast/regions/region-style-rule-specificity.html:
* fast/replaced/table-percent-height.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117815
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zmo@google.com [Mon, 21 May 2012 21:01:04 +0000 (21:01 +0000)]
Restore WebGL's framebuffer binding after DrawingBuffer's prepareBackBuffer()
https://bugs.webkit.org/show_bug.cgi?id=87032
Reviewed by James Robinson.
* platform/graphics/chromium/DrawingBufferChromium.cpp:
(WebCore::DrawingBuffer::prepareBackBuffer): restore the user's framebuffer binding if there is one.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117814
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Mon, 21 May 2012 20:52:31 +0000 (20:52 +0000)]
isStartOfDocument and isEndOfDocument are poorly named
https://bugs.webkit.org/show_bug.cgi?id=86649
Reviewed by Levi Weintraub.
Renamed isEndOfDocument to isEndOfEditableOrNonEditableContent because that's what this function checks.
Also added new versions of isStartOfDocument and isEndOfDocument that correctly cross editing boundaries
to be used in selectFrameElementInParentIfFullySelected.
* editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary):
* editing/Editor.cpp:
(WebCore::Editor::insertLineBreak):
(WebCore::Editor::insertParagraphSeparator):
* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::doApply):
* editing/VisibleSelection.cpp:
(WebCore::VisibleSelection::setStartAndEndFromBaseAndExtentRespectingGranularity):
* editing/visible_units.cpp:
(WebCore::isEndOfEditableOrNonEditableContent):
* editing/visible_units.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117813
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 21 May 2012 20:48:22 +0000 (20:48 +0000)]
[Qt][WK2] REGRESSION, fix a failing API test in qmltests
https://bugs.webkit.org/show_bug.cgi?id=82700
Patch by Marcelo Lira <marcelo.lira@openbossa.org> on 2012-05-21
Reviewed by Alexis Menard.
The value of a CSS font-family property is expected to have single
quotes when white space is present in its name, and no quotes otherwise.
Font family names returned by WebView.experimental.preferences never add quotes.
Since what matter to the test is only the identity of the font, an auxiliar
method to remove single quotes was added.
* UIProcess/API/qt/tests/qmltests/WebView/tst_preferences.qml:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117812
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
annacc@chromium.org [Mon, 21 May 2012 20:34:21 +0000 (20:34 +0000)]
Only render text track cues if kind=captions or kind=subtitles.
https://bugs.webkit.org/show_bug.cgi?id=83321
Reviewed by Eric Carlson.
Source/WebCore:
No new tests. Modification to media/track/track-kind.html
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::textTrackKindChanged):
If the kind changes from a 'visible' kind to a 'non-visible' kind,
update the track's mode to HIDDEN.
* html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlTextTrackContainerElement::updateDisplay):
Do not render cues from tracks that are not captions or subtitles.
* html/track/TextTrack.cpp:
(WebCore::TextTrack::setMode):
If the track's mode changes from SHOWING to HIDDEN or DISABLED,
ensure any currently visible cues will no longer be rendered.
* html/track/TextTrackCue.cpp:
(WebCore::TextTrackCue::removeDisplayTree): New method.
* html/track/TextTrackCue.h:
(TextTrackCue):
LayoutTests:
* media/track/track-kind-expected.txt:
* media/track/track-kind.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117811
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pkasting@chromium.org [Mon, 21 May 2012 20:06:27 +0000 (20:06 +0000)]
[chromium] More accurate test expectations.
http://code.google.com/p/chromium/issues/detail?id=89282
https://bugs.webkit.org/show_bug.cgi?id=81145
https://bugs.webkit.org/show_bug.cgi?id=82297
Unreviewed, test expectations update.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117810
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kling@webkit.org [Mon, 21 May 2012 19:36:39 +0000 (19:36 +0000)]
CSS: Move duplicate property elimination to parser.
<http://webkit.org/b/86948>
Reviewed by Antti Koivisto.
Source/WebCore:
Remove the StylePropertySet constructor that handled elimination of duplicate
properties and move that to a new parser method, CSSParser::filteredProperties().
Call sites are converted to using StylePropertySet(const Vector<CSSProperty>&).
Instead of building a hashmap of seen properties, use the new WTF::BitArray class
to track whether a given property ID has been seen, and whether we have an
!important entry for a given ID.
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseDeclaration):
(WebCore::CSSParser::filteredProperties):
(WebCore::CSSParser::createStyleRule):
(WebCore::CSSParser::createFontFaceRule):
(WebCore::CSSParser::createPageRule):
(WebCore::CSSParser::createKeyframe):
* css/CSSParser.h:
* css/StylePropertySet.cpp:
(WebCore::StylePropertySet::StylePropertySet):
(WebCore::StylePropertySet::addParsedProperties):
* css/StylePropertySet.h:
(WebCore::StylePropertySet::create):
(StylePropertySet):
* svg/SVGFontFaceElement.cpp:
(WebCore::SVGFontFaceElement::rebuildFontFace):
Source/WTF:
Add WTF::BitArray, a simple, malloc free, fixed-size bit array class.
* GNUmakefile.list.am:
* WTF.gypi:
* WTF.pro:
* WTF.vcproj/WTF.vcproj:
* WTF.xcodeproj/project.pbxproj:
* wtf/BitArray.h: Added.
(WTF):
(BitArray):
(WTF::BitArray::BitArray):
(WTF::BitArray::set):
(WTF::BitArray::get):
* wtf/CMakeLists.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117809
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jsbell@chromium.org [Mon, 21 May 2012 19:28:01 +0000 (19:28 +0000)]
IndexedDB: Index key paths that yield invalid keys should not fail an add/put
https://bugs.webkit.org/show_bug.cgi?id=86122
Reviewed by Tony Chang.
Source/WebCore:
A clause was removed from the IDB spec. Previously, on add/put, if evaluating an
index's key path yielded a value that was not a valid key, an exception would be
raised. Now, it is treated the same as if no value was yielded.
Test: storage/indexeddb/index-basics.html
Test: storage/indexeddb/index-basics-workers.html
Test: storage/indexeddb/objectstore-basics.html
Test: storage/indexeddb/objectstore-basics-workers.html
* Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:
(WebCore::IDBObjectStoreBackendImpl::put): Preconditions removed
(WebCore::IDBObjectStoreBackendImpl::putInternal): Treat invalid keys the same as missing keys.
LayoutTests:
* storage/indexeddb/index-basics-expected.txt:
* storage/indexeddb/index-basics-workers-expected.txt:
* storage/indexeddb/objectstore-basics-expected.txt:
* storage/indexeddb/objectstore-basics-workers-expected.txt:
* storage/indexeddb/resources/index-basics.js: Add checks that index key paths
that evaluate to invalid keys do not fail puts/adds, just don't add index entries.
(addData3):
(addData4):
(cursor1Continue3):
(cursor1Continue4):
(cursor2Continue3):
(cursor2Continue4):
(last):
(index1Count):
(index2Count):
* storage/indexeddb/resources/objectstore-basics.js: Remove precondition checks
that would previously raise an exception if invalid keys were specified.
(addAgainFailure):
(testPreConditions.request.onsuccess):
(testPreConditions):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117808
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rakuco@webkit.org [Mon, 21 May 2012 19:24:38 +0000 (19:24 +0000)]
[EFL] Do not enable Web Audio support by default at build time.
https://bugs.webkit.org/show_bug.cgi?id=86982
Reviewed by Philippe Normand.
Follow-up to r115800. Even though Web Audio support is disabled by
default in build-webkit, enabling it in OptionsEfl.cmake will turn
it on when building the port without build-webkit.
Since Web Audio support for the EFL port does not seem to be fully
working yet, it is better to disable it in all cases.
* Source/cmake/OptionsEfl.cmake: Remove option override for
ENABLE_WEB_AUDIO.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117807
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jsbell@chromium.org [Mon, 21 May 2012 19:20:14 +0000 (19:20 +0000)]
LayoutTests: fast/js/resources/js-test-pre.js - shouldBeEqualToString fails on "
https://bugs.webkit.org/show_bug.cgi?id=86931
Implementations of shouldBeEqualToString() function were not correctly escaping
double quote ('"') characters. Switch to using JSON.stringify() which does
correct escaping, and updated one test that couldn't previously use the function.
Reviewed by Ojan Vafai.
* fast/js/resources/js-test-pre.js:
(shouldBeEqualToString):
* fast/js/resources/standalone-pre.js:
(shouldBeEqualToString):
* storage/indexeddb/cursor-advance-expected.txt:
* storage/indexeddb/resources/cursor-advance.js:
(runTest):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117806
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Mon, 21 May 2012 18:52:16 +0000 (18:52 +0000)]
webkitpy: clean up the TestExpectations constructor
https://bugs.webkit.org/show_bug.cgi?id=86926
Reviewed by Ojan Vafai.
The TestExpectations constructor was attempting to pretend
it didn't need to get stuff from the Port, and as a result we
had a complicated constructor with a bunch of arguments, and
calling it was too complicated (although it made testing a
little easier and simplified the style checker).
This patch has the constructor pull all the data it needs from
the port directly, and allows us to delete a bunch of code.
* Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager.parse_expectations):
* Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
(ManagerTest.test_update_summary_with_result):
(ResultSummaryTest.get_result_summary):
* Scripts/webkitpy/layout_tests/models/test_expectations.py:
(TestExpectations.__init__):
* Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
(parse_exp):
(SkippedTests.check):
(RemoveConfigurationsTest.test_remove):
(test_remove_line):
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(lint):
(run):
* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(LintTest.test_all_configurations.FakePort.__init__):
(LintTest.test_all_configurations.FakePort.test_expectations):
(LintTest.test_all_configurations.FakePort.skipped_layout_tests):
(LintTest.test_all_configurations.FakePort):
(LintTest.test_all_configurations.FakePort.all_test_configurations):
(LintTest.test_all_configurations.FakePort.configuration_specifier_macros):
(LintTest.test_all_configurations.FakePort.path_from_webkit_base):
(LintTest.test_all_configurations.FakePort.get_option):
(LintTest.test_all_configurations.FakeFactory.__init__):
(LintTest.test_all_configurations.FakeFactory.all_port_names):
(LintTest.test_all_configurations):
* Scripts/webkitpy/layout_tests/views/printing_unittest.py:
(Testprinter.get_result_summary):
* Scripts/webkitpy/style/checkers/test_expectations.py:
(TestExpectationsChecker.check_test_expectations):
* Scripts/webkitpy/tool/commands/queries.py:
(PrintExpectations._model):
* Scripts/webkitpy/tool/commands/rebaseline.py:
(RebaselineTest._update_expectations_file):
(RebaselineExpectations._expectations):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117805
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 21 May 2012 18:50:36 +0000 (18:50 +0000)]
[GTK] DRT support for layoutTestController.setSerializeHTTPLoads
https://bugs.webkit.org/show_bug.cgi?id=86653
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-05-21
Reviewed by Gustavo Noronha Silva.
Source/WebKit/gtk:
Add support for setSerializeHTTPLoads in DumpRenderTreeSupportGtk
to allow testing resource load order.
* WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::setSerializeHTTPLoads):
* WebCoreSupport/DumpRenderTreeSupportGtk.h:
(DumpRenderTreeSupportGtk):
Tools:
Add missing implementation setSerializeHTTPLoads to allow
testing resource load order.
* DumpRenderTree/gtk/DumpRenderTree.cpp:
(resetDefaultsToConsistentValues):
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::setSerializeHTTPLoads):
LayoutTests:
Unskip test cases which rely on LayoutTestController's setSerializeHTTPLoads
implementation.
* platform/gtk/fast/loader/file-protocol-fragment-expected.txt: Removed. The current
result matches the base expectation, so removed the platform-specific results.
* platform/gtk/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117804
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dmazzoni@google.com [Mon, 21 May 2012 18:42:59 +0000 (18:42 +0000)]
AX: A disabled select element should not be exposed as focusable
https://bugs.webkit.org/show_bug.cgi?id=86949
Reviewed by Chris Fleizach.
* LayoutTests/accessibility/disabled-controls-not-focusable-expected.txt: Added.
* LayoutTests/accessibility/disabled-controls-not-focusable.html: Added.
* Source/WebCore/accessibility/AccessibilityListBox.h:
(AccessibilityListBox):
* Source/WebCore/accessibility/AccessibilityMenuList.cpp:
(WebCore::AccessibilityMenuList::canSetFocusAttribute):
(WebCore):
* Source/WebCore/accessibility/AccessibilityMenuList.h:
(AccessibilityMenuList):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117803
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
michaeln@google.com [Mon, 21 May 2012 18:37:17 +0000 (18:37 +0000)]
Unreviewed, fix ChangeLog line endings
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117802
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Mon, 21 May 2012 17:42:59 +0000 (17:42 +0000)]
Checking in correct test results for https://bugs.webkit.org/show_bug.cgi?id=86119
Unreviewed.
* svg/custom/bug86119-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117801
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jsbell@chromium.org [Mon, 21 May 2012 17:33:49 +0000 (17:33 +0000)]
Unreviewed expectations update after r117702 - shared worker test is
skipped in DRT, but run in Chromium: http://crbug.com/128959
* storage/indexeddb/basics-shared-workers-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117800
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Mon, 21 May 2012 17:27:37 +0000 (17:27 +0000)]
Web Inspector: refactor revision history to not include resource itself.
https://bugs.webkit.org/show_bug.cgi?id=87026
Reviewed by Vsevolod Vlasov.
Source/WebCore:
This change makes resource contain pure revisions, it stops updating Resources upon free flow editing.
* inspector/front-end/JavaScriptSource.js:
(WebInspector.JavaScriptSource.prototype.setFormatted.didGetContent.didFormatContent):
(WebInspector.JavaScriptSource.prototype.setFormatted.didGetContent):
(WebInspector.JavaScriptSource.prototype.setFormatted):
* inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame.prototype.commitEditing):
(WebInspector.JavaScriptSourceFrame.prototype._onContentChanged):
(WebInspector.JavaScriptSourceFrame.prototype._didEditContent):
* inspector/front-end/Resource.js:
(WebInspector.Resource.prototype.addRevision):
(WebInspector.Resource.prototype._innerRequestContent.callback):
(WebInspector.Resource.prototype._innerRequestContent):
(WebInspector.Resource.prototype.revertToOriginal):
(WebInspector.ResourceRevision.prototype.revertToThis):
(WebInspector.ResourceRevision.prototype.requestContent):
(WebInspector.ResourceRevision.prototype.searchInContent):
(WebInspector.ResourceRevision.prototype._persistRevision):
* inspector/front-end/RevisionHistoryView.js:
(WebInspector.RevisionHistoryView):
(WebInspector.RevisionHistoryView.prototype._revisionAdded):
(WebInspector.RevisionHistoryTreeElement):
* inspector/front-end/ScriptSnippetModel.js:
(WebInspector.ScriptSnippetModel.prototype.setScriptSnippetContent):
* inspector/front-end/StylesPanel.js:
(WebInspector.StyleSourceFrame.prototype.commitEditing):
(WebInspector.StyleSourceFrame.prototype._didEditContent):
(WebInspector.StyleSourceFrame.prototype._onContentChanged):
* inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode.prototype._revisionAdded):
(WebInspector.UISourceCode.prototype.contentChanged):
(WebInspector.UISourceCode.prototype.commitWorkingCopy):
* inspector/front-end/inspector.js:
(WebInspector._doLoadedDoneWithCapabilities.get if):
LayoutTests:
* http/tests/inspector/network/network-request-revision-content.html:
* inspector/styles/styles-history-expected.txt:
* inspector/styles/styles-history.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117799
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 21 May 2012 17:25:35 +0000 (17:25 +0000)]
GCC 4.7 and C++11
https://bugs.webkit.org/show_bug.cgi?id=86465
Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-05-21
Reviewed by Darin Adler.
Source/WebCore:
Avoid triggering C++11 string literals and use nullptr for correct type casting.
* bindings/js/JSNodeFilterCondition.cpp:
(WebCore::JSNodeFilterCondition::JSNodeFilterCondition):
* platform/sql/SQLiteFileSystem.cpp:
(WebCore::SQLiteFileSystem::getFileNameForNewDatabase):
Source/WebKit2:
Avoid triggering C++11 string literals.
* UIProcess/API/qt/tests/inspectorserver/tst_inspectorserver.cpp:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117798
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
michaeln@google.com [Mon, 21 May 2012 17:19:40 +0000 (17:19 +0000)]
Source/WebCore: [chromium] DomStorage events handling needs TLC (2)
https://bugs.webkit.org/show_bug.cgi?id=85221
Alter the StorageArea virtual interface such that the mutators no longer
return old values. This is to allow implementations of the interface to operate
more asynchronously.
Reviewed by Adam Barth.
No new tests. Existing tests cover this.
* storage/StorageArea.h: Alter the interface so the mutators no longer return previous values
* storage/StorageAreaImpl.cpp:
(WebCore::StorageAreaImpl::disabledByPrivateBrowsingInFrame): removed an unneeded PLATFORM(CHROMIUM) guard
(WebCore::StorageAreaImpl::setItem): no longer return the old value
(WebCore::StorageAreaImpl::removeItem): no longer return the old value
(WebCore::StorageAreaImpl::clear): no longer return whether something was cleared
* storage/StorageAreaImpl.h: match StorageArea's virtual interface
Source/WebKit/chromium: [chromium] DomStorage events handling needs TLC (2)
https://bugs.webkit.org/show_bug.cgi?id=85221
Alter the WebStorageArea virtual interface such that the mutators no longer
return old values. This is to allow implementations of the interface to operate
more asynchronously.
Also clean up from a previous patch, remove support for the DEPRECATED event
dispatching API.
Reviewed by Adam Barth.
* WebKit.gyp: delete three files indicated below
* public/WebStorageArea.h:
(WebKit::WebStorageArea::setItem): no longer returns the old value
(WebKit::WebStorageArea::removeItem): no longer returns the old value
(WebKit::WebStorageArea::clear): no longer returns a bool indicated if something was cleared
* public/WebStorageEventDispatcher.h: removed the DEPRECATED instance methods
* public/WebStorageNamespace.h: removed the DEPRECATED close() method
* public/platform/WebKitPlatformSupport.h: removed the DEPRECATED dispatchStorageEvent() method
* src/StorageAreaProxy.cpp: removed the DEPREACTED storageEvent() method
(WebCore::StorageAreaProxy::setItem): no return value
(WebCore::StorageAreaProxy::removeItem): no return value
(WebCore::StorageAreaProxy::clear): no return value
(WebCore::StorageAreaProxy::dispatchLocalStorageEvent): remove an early return thats no longer needed
(WebCore::findPageWithSessionStorageNamespace): switched to passing pageGroup by ptr value instead of by name
(WebCore::StorageAreaProxy::dispatchSessionStorageEvent): remove an early return thats no longer needed
* src/StorageAreaProxy.h:
(WebCore):
(StorageAreaProxy):
* src/StorageEventDispatcherImpl.cpp: Deleted the file.
* src/StorageEventDispatcherImpl.h: Deleted the file.
* src/WebStorageEventDispatcherImpl.cpp: Deleted the DEPRECATED instance methods.
(WebKit::WebStorageEventDispatcher::dispatchLocalStorageEvent): use WebViewImpl::defaultPageGroup
(WebKit::WebStorageEventDispatcher::dispatchSessionStorageEvent): use WebViewImpl::defaultPageGroup
* src/WebStorageEventDispatcherImpl.h: Deleted the file.
* src/WebViewImpl.cpp: added a static method to retrieve a ptr to the default page group,
(WebKit::WebViewImpl::defaultPageGroup):
* src/WebViewImpl.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117797
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
morrita@google.com [Mon, 21 May 2012 16:59:02 +0000 (16:59 +0000)]
[Refactoring] Node should have youngestShadowRoot.
https://bugs.webkit.org/show_bug.cgi?id=86427
Reviewed by Dimitri Glazkov.
This change adds Node::youngestShadowRoot() and replaced
ElementShadow::youngestShadowRoot() with it if appropriate.
By introducing this, traversal across node and its shadow tree can
look more fluent and idiomatic. There are a few non-trivial traversal
remaining like ElementShadow::recalcStyle() and attach().
But they should be flattened out eventually.
No new tests. Refactoring.
* dom/ContainerNodeAlgorithms.cpp:
(WebCore::ChildNodeInsertionNotifier::notifyDescendantInsertedIntoTree):
* dom/Document.cpp:
(WebCore::Document::buildAccessKeyMap):
* dom/ElementShadow.cpp:
* dom/ElementShadow.h:
(ElementShadow):
(WebCore::Node::youngestShadowRoot):
(WebCore):
* dom/Node.h:
(Node):
* dom/TreeScopeAdopter.cpp:
(WebCore::TreeScopeAdopter::moveTreeToNewScope):
(WebCore::TreeScopeAdopter::moveTreeToNewDocument):
* dom/TreeScopeAdopter.h:
(TreeScopeAdopter):
* html/shadow/TextFieldDecorationElement.cpp:
(WebCore::getDecorationRootAndDecoratedRoot):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117796
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 21 May 2012 16:43:24 +0000 (16:43 +0000)]
Add support for MessagePortArray type to JSC
https://bugs.webkit.org/show_bug.cgi?id=84093
Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-05-21
Reviewed by Adam Barth.
Add support for MessagePortArray type to JSC code generator similarly
to what was done for the V8 generator in r114319.
Update bindings test results to reflect to change to the bindings
generator.
* CMakeLists.txt: Add new DeliveredIntent files to CMake.
* bindings/js/JSDOMBinding.h:
(WebCore):
(WebCore::jsArray): Tweak jsArray() so that it accepts MessagePortArray as argument.
* bindings/scripts/CodeGeneratorJS.pm:
(JSValueToNative):
(NativeToJSValue):
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::jsTestObjPrototypeFunctionSerializedValue):
* bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
(WebCore::JSTestSerializedScriptValueInterfaceConstructor::constructJSTestSerializedScriptValueInterface):
(WebCore::jsTestSerializedScriptValueInterfacePorts):
(WebCore::setJSTestSerializedScriptValueInterfaceValue):
(WebCore::setJSTestSerializedScriptValueInterfaceCachedValue):
(WebCore::jsTestSerializedScriptValueInterfacePrototypeFunctionAcceptTransferList):
(WebCore::jsTestSerializedScriptValueInterfacePrototypeFunctionMultiTransferList):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117795
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Mon, 21 May 2012 16:36:10 +0000 (16:36 +0000)]
Web Inspector: [Styles] Cannot tab from selector of inherited rule, which in turn has leading inherited properties
https://bugs.webkit.org/show_bug.cgi?id=87014
Reviewed by Yury Semikhatsky.
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertiesSection.prototype._moveEditorFromSelector):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117794
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 21 May 2012 16:24:06 +0000 (16:24 +0000)]
Add suggestions field to web intents API.
https://bugs.webkit.org/show_bug.cgi?id=86791
Patch by Greg Billock <gbillock@google.com> on 2012-05-21
Reviewed by Adam Barth.
Source/WebCore:
The |suggestions| field is used by the client to avoid an empty
web intents selection window (picker). The UA can add the given
suggestions to the picker if it would otherwise be empty. See
http://dvcs.w3.org/hg/web-intents/raw-file/tip/spec/Overview.html#intent-parameters-dictionary
* Modules/intents/DeliveredIntent.cpp:
(WebCore::DeliveredIntent::DeliveredIntent):
* Modules/intents/Intent.cpp:
(WebCore::Intent::create):
(WebCore::Intent::Intent):
* Modules/intents/Intent.h:
(WebCore::Intent::suggestions):
(Intent):
Source/WebKit/chromium:
* public/WebIntent.h:
(WebIntent):
* src/WebIntent.cpp:
(WebKit::WebIntent::suggestions):
(WebKit):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117793
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
schenney@chromium.org [Mon, 21 May 2012 16:19:58 +0000 (16:19 +0000)]
SVGAnimatedPropertyTearOff does not clear a self pointer on deletion
https://bugs.webkit.org/show_bug.cgi?id=86119
Reviewed by Nikolas Zimmermann.
Source/WebCore:
SVGAnimatedPropertyTearOff contains two SVGPropertyTearOff objects
that have a pointer back to the SVGAnimatedPropertyTearOff. JS may
also have a reference to these SVGPropertyTearOff objects. When the
SVGAnimatedPropertyTearOff is deleted, the SVGPropertyTearOff objects
may live on, but the pointer back to the deleted animated property
tear off is left invalid. This patch clears the pointers on destruction
of the SVGAnimatedPropertyTearOff.
Test: svg/custom/bug86119.html
* svg/properties/SVGAnimatedPropertyTearOff.h:
(WebCore::SVGAnimatedPropertyTearOff::~SVGAnimatedPropertyTearOff):
(SVGAnimatedPropertyTearOff):
LayoutTests:
* svg/custom/bug86119.html: Added.
* svg/custom/bug86119-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117792
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
macpherson@chromium.org [Mon, 21 May 2012 16:13:52 +0000 (16:13 +0000)]
Add additional test cases for CSS variables.
https://bugs.webkit.org/show_bug.cgi?id=86987
Reviewed by Dimitri Glazkov.
* fast/css/variables/border-width-expected.html: Added.
* fast/css/variables/border-width.html: Added.
* fast/css/variables/transform-test-expected.html: Added.
* fast/css/variables/transform-test.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117791
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
schenney@chromium.org [Mon, 21 May 2012 16:12:10 +0000 (16:12 +0000)]
[Chromium] REGRESSION: Assertion failure on svg/custom/acid3-test-77.html
https://bugs.webkit.org/show_bug.cgi?id=86715
Reviewed by Nikolas Zimmermann.
Source/WebCore:
Calls to clear the text positioning elements in RenderSVGText must be
protected with a FontCachePurgeProtector so that fonts are not removed
before the SVG metrics are rebuilt. The protection must cover both the
cache clearing and the reconstruction calls.
Patch fixes existing tests.
* rendering/svg/RenderSVGText.cpp:
(WebCore::RenderSVGText::subtreeChildWasAdded):
(WebCore::RenderSVGText::subtreeChildWasRemoved):
(WebCore::RenderSVGText::subtreeTextDidChange):
(WebCore::RenderSVGText::removeChild):
LayoutTests:
* platform/chromium/test_expectations.txt: Removing expectation for acid3 test.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117790
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
epoger@chromium.org [Mon, 21 May 2012 16:08:25 +0000 (16:08 +0000)]
add skia_test_expectations override file to chromium NRWT
https://bugs.webkit.org/show_bug.cgi?id=86749
Reviewed by Dirk Pranke
* Scripts/webkitpy/layout_tests/port/base.py:
(Port.test_expectations_overrides):
* Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumPort.test_expectations_overrides):
* Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
(ChromiumPortTest.test_overrides_and_builder_names):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117789
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
schenney@chromium.org [Mon, 21 May 2012 16:06:50 +0000 (16:06 +0000)]
SVGTextRunRenderingContext can return null font, calling code asserts not null
https://bugs.webkit.org/show_bug.cgi?id=86738
Reviewed by Nikolas Zimmermann.
SVGTextRunRenderingContext::glyphDataForCharacter was returning a glyph with
null font data for numerous code paths. It seems that it was doing so
whenever it detected null fontData, rather than try to continue.
Calling code would then immediately assert on this null fontData.
This patch refactors SVGTextRunRenderingContext::glyphDataForCharacter
so that it never returns null font data, adding an assertion to that
effect. In particular, when the font data is null the code will reach
the fallback glyph calculations.
Refactoring covered by existing tests. A previously crashing test, svg/custom/acid3-test-77.html, no longer crashes.
* rendering/svg/SVGTextRunRenderingContext.cpp:
(WebCore::SVGTextRunRenderingContext::glyphDataForCharacter):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117788
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 21 May 2012 16:06:42 +0000 (16:06 +0000)]
webkitdirs.pm: Fix undefined CXXFLAGS variable
https://bugs.webkit.org/show_bug.cgi?id=87000
Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-05-21
Reviewed by Martin Robinson.
Fixes a warning on Autotools and CMake buildsystem when
CXXFLAGS is not defined.
* Scripts/webkitdirs.pm:
(runAutogenForAutotoolsProjectIfNecessary):
(generateBuildSystemFromCMakeProject):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117787
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
loislo@chromium.org [Mon, 21 May 2012 16:02:07 +0000 (16:02 +0000)]
Web Inspector: switch buildDominatedNodes function to front-end calculated _dominatorsTree
https://bugs.webkit.org/show_bug.cgi?id=87022
The new version is using _dominatorsTree array that was build at front-end.
Reviewed by Yury Semikhatsky.
Source/WebCore:
* inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshot.prototype._init):
(WebInspector.HeapSnapshot.prototype._buildDominatedNodes):
LayoutTests:
* inspector/profiler/heap-snapshot-expected.txt:
* inspector/profiler/heap-snapshot.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117786
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 21 May 2012 15:54:58 +0000 (15:54 +0000)]
[EFL] Clients should be able to set page cache capacity.
https://bugs.webkit.org/show_bug.cgi?id=86960
Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-05-21
Reviewed by Csaba Osztrogonác.
Exported memory page cache capacity getter and setter functions.
Those will be used both by clients and DRT Layout Test Controller.
* ewk/ewk_settings.cpp:
(ewk_settings_page_cache_capacity_get):
(ewk_settings_page_cache_capacity_set):
* ewk/ewk_settings.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117785
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Mon, 21 May 2012 15:53:52 +0000 (15:53 +0000)]
Web Inspector: change WebCore/English.lproj/locallizedStrings encoding from UTF-16 to UTF-8.
https://bugs.webkit.org/show_bug.cgi?id=86822
Reviewed by Yury Semikhatsky.
* English.lproj/localizedStrings.js:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117784
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
carlosgc@webkit.org [Mon, 21 May 2012 15:32:54 +0000 (15:32 +0000)]
Unreviewed. Fix make distcheck.
* GNUmakefile.list.am: Add missing header files.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117783
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 21 May 2012 15:13:11 +0000 (15:13 +0000)]
GCC 4.7 and C++11
https://bugs.webkit.org/show_bug.cgi?id=86465
Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-05-21
Reviewed by Darin Adler.
Set emptyValueIsZero flag so RegExpKey can be used with the non-copyable RegExp values.
* runtime/RegExpKey.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117782
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vsevik@chromium.org [Mon, 21 May 2012 15:09:56 +0000 (15:09 +0000)]
Web Inspector: Move working copy support to UISourceCode and use it for both styles and scripts.
https://bugs.webkit.org/show_bug.cgi?id=87021
Reviewed by Pavel Feldman.
UISourceCode now listens for RevisionAdded event.
Virtual methods workingCopyChanged and workingCopyCommitted added to UISourceCode and implemented in descendants.
DebuggerResourceBinding does not call contentChanged on UISourceCode explicitly anymore.
* inspector/front-end/DebuggerResourceBinding.js:
(WebInspector.DebuggerResourceBinding.setScriptSource.didEditScriptSource):
(WebInspector.DebuggerResourceBinding.setScriptSource):
* inspector/front-end/JavaScriptSource.js:
(WebInspector.JavaScriptSource.prototype.workingCopyCommitted):
* inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame.prototype.commitEditing):
* inspector/front-end/ScriptSnippetModel.js:
(WebInspector.SnippetJavaScriptSource.prototype.workingCopyCommitted):
* inspector/front-end/StylesPanel.js:
(WebInspector.StyleSource.prototype.workingCopyCommitted):
(WebInspector.StyleSource.prototype.workingCopyChanged):
(WebInspector.StyleSourceFrame):
(WebInspector.StyleSourceFrame.prototype.commitEditing):
(WebInspector.StyleSourceFrame.prototype.afterTextChanged):
(WebInspector.StyleSourceFrame.prototype._didEditContent):
(WebInspector.StyleSourceFrame.prototype._onContentChanged):
* inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode):
(WebInspector.UISourceCode.prototype._revisionAdded):
(WebInspector.UISourceCode.prototype.contentChanged):
(WebInspector.UISourceCode.prototype.workingCopy):
(WebInspector.UISourceCode.prototype.setWorkingCopy):
(WebInspector.UISourceCode.prototype.workingCopyChanged):
(WebInspector.UISourceCode.prototype.commitWorkingCopy):
(WebInspector.UISourceCode.prototype.workingCopyCommitted):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117781
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
loislo@chromium.org [Mon, 21 May 2012 14:49:25 +0000 (14:49 +0000)]
Web Inspector: introduce a helper for HeapSnapshot post-processing tests.
https://bugs.webkit.org/show_bug.cgi?id=87009
the sample:
var builder = new InspectorTest.HeapSnapshotBuilder();
var debuggerNode = new InspectorTest.HeapNode("Debugger");
builder.rootNode.linkNode(debuggerNode, InspectorTest.HeapEdge.Type.element);
var windowNode = new InspectorTest.HeapNode("Window");
builder.rootNode.linkNode(windowNode, InspectorTest.HeapEdge.Type.shortcut);
debuggerNode.linkNode(windowNode, InspectorTest.HeapEdge.Type.property, "windowProperty");
return builder.generateSnapshot();
Reviewed by Yury Semikhatsky.
* inspector/profiler/heap-snapshot-test.js:
(initialize_HeapSnapshotTest):
(initialize_HeapSnapshotTest.):
* inspector/profiler/heap-snapshot.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117780
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 21 May 2012 14:24:22 +0000 (14:24 +0000)]
Colliding isinf/isnan between C99 and C++11 with GCC >=4.6
https://bugs.webkit.org/show_bug.cgi?id=59249
Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-05-21
Reviewed by Darin Adler.
Workaround the isinf and isnan conflict in GCC C++11.
* wtf/Compiler.h:
* wtf/MathExtras.h:
(std::wtf_isinf):
(std::wtf_isnan):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117779
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caseq@chromium.org [Mon, 21 May 2012 13:50:36 +0000 (13:50 +0000)]
Web Inspector: [refactoring] promote fill/border colors used by timeline's frame overview to TimelineCategory
https://bugs.webkit.org/show_bug.cgi?id=87016
Reviewed by Pavel Feldman.
- drop unused 'color' field from TimelineCategory;
- add borderColor and fillColorStop[0-1] to TimelineCategory;
- fix style in a handful of places.
Note we store textual values for color stops, not premade gradients so we can build gradients with different
orientations rather than transforming a gradient.
* inspector/front-end/TimelineOverviewPane.js:
(WebInspector.HeapGraph):
(WebInspector.HeapGraph.prototype.get element):
(WebInspector.HeapGraph.prototype.get visible):
(WebInspector.HeapGraph.prototype.show):
(WebInspector.HeapGraph.prototype.hide):
(WebInspector.HeapGraph.prototype._clear):
(WebInspector.TimelineCategoryStrips):
(WebInspector.TimelineVerticalOverview):
(WebInspector.TimelineVerticalOverview.prototype._renderBar):
* inspector/front-end/TimelinePresentationModel.js:
(WebInspector.TimelinePresentationModel.categories):
(WebInspector.TimelinePresentationModel.recordStyle):
(WebInspector.TimelineCategory):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117778
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 21 May 2012 13:49:48 +0000 (13:49 +0000)]
Disambiguate WTF::bind and std::bind from C++11
https://bugs.webkit.org/show_bug.cgi?id=86465
Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-05-21
Reviewed by Darin Adler.
* Platform/CoreIPC/Connection.cpp:
(CoreIPC::Connection::SyncMessageState::processIncomingMessage):
(CoreIPC::Connection::addQueueClient):
(CoreIPC::Connection::removeQueueClient):
(CoreIPC::Connection::invalidate):
(CoreIPC::Connection::sendMessage):
(CoreIPC::Connection::postConnectionDidCloseOnConnectionWorkQueue):
(CoreIPC::Connection::connectionDidClose):
(CoreIPC::Connection::enqueueIncomingMessage):
* Platform/CoreIPC/unix/ConnectionUnix.cpp:
(CoreIPC::Connection::open):
(CoreIPC::Connection::setShouldCloseConnectionOnProcessTermination):
* WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::pluginThreadAsyncCall):
* WebProcess/WebPage/FindController.cpp:
(WebKit::FindController::findString):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117777
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Mon, 21 May 2012 13:49:40 +0000 (13:49 +0000)]
[WK2] WTR needs an implementation of setAsynchronousSpellCheckingEnabled.
https://bugs.webkit.org/show_bug.cgi?id=81042
Unreviewed gardening. Move skipped tests (and add one more test) to wk2/Skipped
list, because it isn't mac-wk2 specific bug, but general wk2 specific bug.
* platform/mac-wk2/Skipped:
* platform/wk2/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117776
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Mon, 21 May 2012 13:02:57 +0000 (13:02 +0000)]
Web Inspector: declare setFormatted on UISourceCode (otherwise fails for styles).
Not reviewed: front-end fix as a follow up to r117751.
* inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode.prototype.consoleMessagesCleared):
(WebInspector.UISourceCode.prototype.setFormatted):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117774
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Mon, 21 May 2012 12:44:14 +0000 (12:44 +0000)]
Unreviewed. Fix Closure compiler error after r117753.
* inspector/front-end/HeapSnapshotGridNodes.js:
(WebInspector.HeapSnapshotConstructorNode.prototype.revealNodeBySnapshotObjectId.didGetNodePosition):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117773
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zandobersek@gmail.com [Mon, 21 May 2012 12:35:57 +0000 (12:35 +0000)]
Unreviewed GTK gardening, add expectations for an SVG test for hit
testing on strokes and a few more tests that fail because of repainting
issues that fail intermittently.
* platform/gtk/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117772
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caio.oliveira@openbossa.org [Mon, 21 May 2012 12:24:04 +0000 (12:24 +0000)]
Move setEditingBehavior() from layoutTestController to window.internals
https://bugs.webkit.org/show_bug.cgi?id=42689
Reviewed by Hajime Morita and Kenneth Rohde Christiansen.
Source/WebCore:
Add setEditingBehavior() to window.internals.settings. No new tests, but this
change will allow more tests to run in WebKitTestRunner.
* testing/InternalSettings.cpp:
(WebCore::InternalSettings::InternalSettings):
(WebCore::InternalSettings::restoreTo):
(WebCore::InternalSettings::setEditingBehavior):
(WebCore):
* testing/InternalSettings.h:
(InternalSettings):
* testing/InternalSettings.idl:
Source/WebKit/efl:
* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
* WebCoreSupport/DumpRenderTreeSupportEfl.h:
Source/WebKit/mac:
Remove Mac private API to get/set the editing behavior, since it was only there
for the DRT.
* WebKit.order:
* WebView/WebFrame.mm:
* WebView/WebFrameInternal.h:
* WebView/WebPreferenceKeysPrivate.h:
* WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
* WebView/WebPreferencesPrivate.h:
* WebView/WebView.mm:
(-[WebView _preferencesChanged:]):
Source/WebKit/qt:
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::setWindowsBehaviorAsEditingBehavior): Reduce the job
done by this function to the minimal.
* WebCoreSupport/DumpRenderTreeSupportQt.h:
Source/WebKit/win:
Remove Win private API to get/set the editing behavior. Follow the previous
removals that keep the virtual functions there but failing.
* Interfaces/IWebPreferences.idl:
* WebPreferenceKeysPrivate.h:
* WebPreferences.cpp:
(WebPreferences::unused5):
(WebPreferences::unused6):
* WebPreferences.h:
(WebPreferences):
* WebView.cpp:
(WebView::notifyPreferencesChanged):
Tools:
Remove code that implements setEditingBehavior() for each platform. Note that
During the InternalsObject reset the behavior is changed back to the platform
default.
Qt and Chromium ports set a default editing behavior for running tests different
from the platform default, so they still keep code for resetting to the desired
editing behavior. Other ports use the their defaults, that are restored by
internals object.
* DumpRenderTree/LayoutTestController.cpp:
(LayoutTestController::staticFunctions):
* DumpRenderTree/LayoutTestController.h:
(LayoutTestController):
* DumpRenderTree/blackberry/DumpRenderTree.cpp:
(BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
* DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
* DumpRenderTree/chromium/LayoutTestController.h:
(LayoutTestController):
* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::resetDefaultsToConsistentValues):
* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
* DumpRenderTree/mac/DumpRenderTree.mm:
(resetDefaultsToConsistentValues):
* DumpRenderTree/mac/LayoutTestControllerMac.mm:
* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
* DumpRenderTree/qt/LayoutTestControllerQt.h:
(LayoutTestController):
* DumpRenderTree/win/DumpRenderTree.cpp:
(resetDefaultsToConsistentValues):
* DumpRenderTree/win/LayoutTestControllerWin.cpp:
* DumpRenderTree/wx/LayoutTestControllerWx.cpp:
LayoutTests:
* editing/deleting/delete-ligature-003.html:
* editing/deleting/paragraph-in-preserveNewline.html:
* editing/deleting/whitespace-pre-1.html:
* editing/execCommand/script-tests/query-command-state.js:
(runTests):
* editing/execCommand/script-tests/query-text-alignment.js:
(runRangeTests):
* editing/execCommand/script-tests/toggle-compound-styles.js:
* editing/selection/5195166-1.html:
* editing/selection/5354455-1.html:
* editing/selection/caret-mode-paragraph-keys-navigation.html:
* editing/selection/collapse-selection-in-bidi.html:
* editing/selection/context-menu-text-selection.html:
* editing/selection/directionality-after-undo-replace.html:
* editing/selection/extend-after-mouse-selection.html:
* editing/selection/extend-selection-after-double-click.html:
* editing/selection/move-by-word-visually-crash-test-1.html:
* editing/selection/move-by-word-visually-crash-test-2.html:
* editing/selection/move-by-word-visually-crash-test-3.html:
* editing/selection/move-by-word-visually-crash-test-4.html:
* editing/selection/move-by-word-visually-crash-test-5.html:
* editing/selection/move-by-word-visually-crash-test-css-generated-content.html:
* editing/selection/move-by-word-visually-crash-test-textarea.html:
* editing/selection/move-by-word-visually-inline-block-positioned-element.html:
* editing/selection/move-by-word-visually-mac.html:
* editing/selection/move-by-word-visually-multi-line.html:
* editing/selection/move-by-word-visually-multi-space.html:
* editing/selection/move-by-word-visually-null-box.html:
* editing/selection/move-by-word-visually-single-space-inline-element.html:
* editing/selection/move-by-word-visually-single-space-one-element.html:
* editing/selection/move-by-word-visually-textarea.html:
* editing/selection/move-by-word-visually-wrong-left-right.html:
* editing/selection/programmatic-selection-on-mac-is-directionless.html:
* editing/selection/rtl-move-selection-right-left.html:
* editing/selection/script-tests/click-in-margins-inside-editable-div.js:
* editing/selection/script-tests/click-in-padding-with-multiple-line-boxes.js:
* editing/selection/script-tests/shift-click.js:
(runShiftClickTest):
* editing/selection/selection-extend-should-not-move-across-caret-on-mac.html:
* editing/style/iframe-onload-crash-mac.html:
* editing/style/iframe-onload-crash-unix.html:
* editing/style/iframe-onload-crash-win.html:
* fast/events/backspace-navigates-back.html:
* fast/forms/selection-direction.html:
* platform/gtk-wk2/Skipped: Add here tests that are still failing for GTK WK2 port.
* platform/wk2/Skipped: Unskip!
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117771
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Mon, 21 May 2012 12:19:28 +0000 (12:19 +0000)]
[Qt] Unreviewed gardening after r112112.
* platform/qt/Skipped:
* platform/qt/css2.1/
20110323/c543-txt-decor-000-expected.png: Added.
* platform/qt/css2.1/
20110323/c543-txt-decor-000-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117770
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Mon, 21 May 2012 12:01:04 +0000 (12:01 +0000)]
[Qt] Unreviewed gardening.
* platform/qt-5.0-wk1/Skipped: Skip failing tests because of bug86452.
* platform/qt-5.0/svg/custom/svg-fonts-in-text-controls-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117769
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vsevik@chromium.org [Mon, 21 May 2012 11:55:32 +0000 (11:55 +0000)]
Web Inspector: Temporary UISourceCode should be replaced each time another inline script is added in RawSourceCode with pending request.
https://bugs.webkit.org/show_bug.cgi?id=87003
Reviewed by Pavel Feldman.
Source/WebCore:
This is needed to correctly show document content when debugger stops on several breakpoints in different scripts during page load.
* inspector/front-end/RawSourceCode.js:
(WebInspector.RawSourceCode.prototype.addScript):
(WebInspector.RawSourceCode.prototype._finishedLoading):
LayoutTests:
* inspector/debugger/raw-source-code-expected.txt:
* inspector/debugger/raw-source-code.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117768
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Mon, 21 May 2012 11:50:23 +0000 (11:50 +0000)]
inspector/styles/css-live-edit.html times out.
https://bugs.webkit.org/show_bug.cgi?id=82409
Not reviewed: test fix.
* inspector/styles/css-live-edit.html:
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117767
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kinuko@chromium.org [Mon, 21 May 2012 11:25:19 +0000 (11:25 +0000)]
Cleanup: Remove WebCore::revealFolderInOS() which is no longer used anywhere
https://bugs.webkit.org/show_bug.cgi?id=86993
Reviewed by Adam Barth.
Source/WebCore:
No new tests as this must be just removing dead code.
* platform/FileSystem.h:
* platform/chromium/FileSystemChromium.cpp:
* platform/chromium/PlatformSupport.h:
(PlatformSupport):
Source/WebKit/chromium:
* public/WebFileUtilities.h:
(WebFileUtilities):
* src/PlatformSupport.cpp:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117766
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Mon, 21 May 2012 11:25:10 +0000 (11:25 +0000)]
[Qt] Unreviewed gardening, unskip a now passing test.
* platform/qt/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117765
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 21 May 2012 11:15:32 +0000 (11:15 +0000)]
[EFL] [DRT] Update EFL baselines after r116069
https://bugs.webkit.org/show_bug.cgi?id=86963
Unreviewed gardening, update results after r116069.
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-05-21
* platform/efl/fast/block/float/016-expected.png:
* platform/efl/fast/css/border-solid-single-edge-antialias-expected.png: Added.
* platform/efl/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117764
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Mon, 21 May 2012 10:44:10 +0000 (10:44 +0000)]
Web Inspector: Annotate CSSStyleModel.js for the closure compiler
https://bugs.webkit.org/show_bug.cgi?id=86858
Reviewed by Yury Semikhatsky.
* inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSStyleDeclaration.parseComputedStylePayload):
(WebInspector.CSSStyleDeclaration.prototype.newBlankProperty):
(WebInspector.CSSStyleDeclaration.prototype.insertPropertyAt):
(WebInspector.CSSProperty.parsePayload):
(WebInspector.CSSProperty.prototype.setText):
(WebInspector.CSSProperty.prototype.setDisabled):
(WebInspector.CSSStyleSheet.prototype.setText):
(WebInspector.CSSStyleModelResourceBinding.prototype._innerSetContent.callbackWrapper):
(WebInspector.CSSStyleModelResourceBinding.prototype._innerSetContent):
(WebInspector.CSSStyleModelResourceBinding.prototype._loadStyleSheetHeaders):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117755
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 21 May 2012 10:29:37 +0000 (10:29 +0000)]
[Forms] Refactor HTMLFormCollection
https://bugs.webkit.org/show_bug.cgi?id=86602
Patch by Rakesh KN <rakesh.kn@motorola.com> on 2012-05-21
Reviewed by Kent Tamura.
Modify HTMLFormCollection to be independent of HTMLFormElement which is needed
for implementing HTMLFieldSetElement's element attribute.
Covered by existing tests.
* html/HTMLFormCollection.cpp:
(WebCore::HTMLFormCollection::HTMLFormCollection):
Modified to take more generic HTMLElement* instead of HTMLFormElement* so that
HTMLFormCollection for HTMLFieldSetElement can also be created.
(WebCore::HTMLFormCollection::create): Ditto.
(WebCore::HTMLFormCollection::formControlElements):
Helper function for getting the array of FormAssociatedElements for this form.
(WebCore::HTMLFormCollection::formImageElements):
Helper function for getting the array of image elements for this form.
(WebCore::HTMLFormCollection::numberOfFormControlElements):
Helper function for getting the number of elements in this form.
(WebCore::HTMLFormCollection::calcLength):
Modified to use new helper functions defined for getting the FormAssociatedElements
and image elements array instead of static_cast to HTMLFormElement.
(WebCore::HTMLFormCollection::item): Ditto.
(WebCore::HTMLFormCollection::getNamedFormItem): Ditto.
(WebCore::HTMLFormCollection::updateNameCache): Ditto.
* html/HTMLFormCollection.h:
(WebCore):
(HTMLFormCollection):
* html/HTMLFormElement.h:
(WebCore::HTMLFormElement::imageElements):
New accessor for image elements array of form element.
Also HTMLFormCollection is not needed to be friend of HTMLFormElement as collection
does not access the form element memebers directly now.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117754
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Mon, 21 May 2012 09:49:53 +0000 (09:49 +0000)]
Web Inspector: expand only neighbors of the highlighted node when revealing it in heap snapshot
https://bugs.webkit.org/show_bug.cgi?id=86998
Reviewed by Pavel Feldman.
Only nearest nodes are expanded when a node is revealed in heap snapshot
summary view.
* inspector/front-end/HeapSnapshotDataGrids.js:
(WebInspector.HeapSnapshotSortableDataGrid.prototype.highlightNode):
(WebInspector.HeapSnapshotViewportDataGrid.prototype.highlightNode):
(WebInspector.HeapSnapshotViewportDataGrid.prototype._isScrolledIntoView):
* inspector/front-end/HeapSnapshotGridNodes.js:
(WebInspector.HeapSnapshotConstructorNode.prototype.revealNodeBySnapshotObjectId):
(WebInspector.HeapSnapshotConstructorNode.prototype.revealNodeBySnapshotObjectId.didGetNodePosition):
* inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfilesPanel.prototype.showProfile):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117753
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 21 May 2012 09:43:48 +0000 (09:43 +0000)]
[EFL] PlatformKeyboardEventEfl is missing ESC key handling.
https://bugs.webkit.org/show_bug.cgi?id=86837
Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-05-21
Reviewed by Kenneth Rohde Christiansen.
Source/WebCore:
Added ESC key handling.
* platform/efl/EflKeyboardUtilities.cpp:
(WebCore::createKeyMap):
(WebCore::singleCharacterString):
Tools:
* DumpRenderTree/efl/EventSender.cpp:
(keyNameFromJSValue): Added ESC key handling.
LayoutTests:
* platform/efl/Skipped: Unskipped fast/forms/input-search-press-escape-key.html.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117752
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Mon, 21 May 2012 09:30:02 +0000 (09:30 +0000)]
Web Inspector: move sources panel out of experimental.
https://bugs.webkit.org/show_bug.cgi?id=86997
Reviewed by Yury Semikhatsky.
This change moves sources panel out of experimental, removes revision support from the resources panel.
* English.lproj/localizedStrings.js:
* inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame.prototype._onContentChanged):
(WebInspector.JavaScriptSourceFrame.prototype._continueToLine):
* inspector/front-end/ResourceView.js:
* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype._showResourceView):
(WebInspector.FrameTreeElement.prototype.appendResource):
(WebInspector.FrameResourceTreeElement):
(WebInspector.FrameResourceTreeElement.prototype.sourceView):
* inspector/front-end/ScriptsNavigator.js:
(WebInspector.ScriptsNavigator):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.get toolbarItemLabel):
(WebInspector.ScriptsPanel.prototype.appendApplicableItems):
* inspector/front-end/Settings.js:
(WebInspector.ExperimentsSettings):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype._setTextViewerDecorations):
* inspector/front-end/textViewer.css:
* inspector/front-end/utilities.js:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117751
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Mon, 21 May 2012 08:55:58 +0000 (08:55 +0000)]
Web Inspector: implement revision history view.
https://bugs.webkit.org/show_bug.cgi?id=86966
Reviewed by Yury Semikhatsky.
Added revision view into the drawer. It now lists all the revisions
along with the inline diffs. Once source panel is enabled by default,
this view will completely substitute the one in the resources panel.
See the screenshot attached. View is updated when revisions are added
and when editor view is switched.
* English.lproj/localizedStrings.js:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/compile-front-end.py:
* inspector/front-end/AdvancedSearchController.js:
(WebInspector.FileBasedSearchResultsPane.prototype._appendSearchMatches):
* inspector/front-end/ContextMenu.js:
(WebInspector.ContextMenu.prototype._itemSelected):
(WebInspector.ContextMenu.prototype.appendApplicableItems):
(WebInspector.ContextMenu.Provider.prototype.appendApplicableItems):
(WebInspector.ContextMenu.registerProvider):
* inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame.prototype.populateTextAreaContextMenu):
* inspector/front-end/Resource.js:
(WebInspector.ResourceRevision.prototype.revertToThis):
* inspector/front-end/RevisionHistoryView.js: Added.
(WebInspector.RevisionHistoryView):
(WebInspector.RevisionHistoryView.showHistory):
(WebInspector.RevisionHistoryView.uiSourceCodeSelected):
(WebInspector.RevisionHistoryView.prototype._revisionAdded):
(WebInspector.RevisionHistoryView.prototype._onclose):
(WebInspector.RevisionHistoryTreeElement.else.revert):
(WebInspector.RevisionHistoryTreeElement):
(WebInspector.RevisionHistoryTreeElement.prototype.onexpand.step1):
(WebInspector.RevisionHistoryTreeElement.prototype.onexpand.step2):
(WebInspector.RevisionHistoryTreeElement.prototype.onexpand):
(WebInspector.RevisionHistoryTreeElement.prototype._createLine):
(WebInspector.RevisionHistoryTreeElement.prototype._diff.popsym):
(WebInspector.RevisionHistoryTreeElement.prototype._diff):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._editorSelected):
(WebInspector.ScriptsPanel.prototype.registerUISourceCodeProvider):
(WebInspector.ScriptsPanel.prototype._showLocalHistory):
(WebInspector.ScriptsPanel.prototype.appendApplicableItems):
* inspector/front-end/StylesPanel.js:
(WebInspector.StyleSourceFrame.prototype._contentChanged):
(WebInspector.StyleSourceFrame.prototype.populateTextAreaContextMenu):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.css:
(#search-results-pane-file-based .search-result):
(#search-results-pane-file-based .search-result:hover):
(#search-results-pane-file-based .search-match:hover):
(#search-results-pane-file-based .search-match .search-match-content):
* inspector/front-end/inspector.html:
* inspector/front-end/scriptsPanel.css:
(.outline-disclosure.revision-history-drawer):
(.outline-disclosure.revision-history-drawer ol):
(.outline-disclosure.revision-history-drawer > ol):
(.outline-disclosure.revision-history-drawer li):
(.outline-disclosure.revision-history-drawer li.parent):
(.revision-history-link):
(.outline-disclosure.revision-history-drawer .revision-history-line):
(.revision-history-drawer .webkit-line-number):
(.revision-history-line-added):
(.revision-history-line-removed):
* inspector/front-end/textViewer.css:
(.webkit-added-line.webkit-line-number):
(.webkit-removed-line.webkit-line-number):
(.webkit-changed-line.webkit-line-number):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117750
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
loislo@chromium.org [Mon, 21 May 2012 08:53:37 +0000 (08:53 +0000)]
Web Inspector: upstream build dominators tree procedure from v8.
https://bugs.webkit.org/show_bug.cgi?id=86640
The idea is to reduce transfer size and move all the post-processing steps to the front-end.
The JS implementation is ~1.5 times slower.
Reviewed by Yury Semikhatsky.
Covered by existing tests and performance tests.
PerformanceTests:
* inspector/heap-snapshot.html:
Source/WebCore:
* inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshot.prototype._init):
(WebInspector.HeapSnapshot.prototype._buildAggregates):
(WebInspector.HeapSnapshot.prototype._buildPostOrderIndex):
(WebInspector.HeapSnapshot.prototype._buildDominatorTree):
(WebInspector.HeapSnapshot.prototype._markPageOwnedNodes):
(WebInspector.HeapSnapshot.prototype._markQueriableHeapObjects):
(WebInspector.HeapSnapshot.prototype._calculateFlags):
LayoutTests:
* inspector/profiler/heap-snapshot-expected.txt:
* inspector/profiler/heap-snapshot-test.js:
(initialize_HeapSnapshotTest.InspectorTest.createHeapSnapshotMockRaw):
* inspector/profiler/heap-snapshot.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117749
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mikelawther@chromium.org [Mon, 21 May 2012 08:49:27 +0000 (08:49 +0000)]
Crash in -webkit-calc
https://bugs.webkit.org/show_bug.cgi?id=86954
Reviewed by Abhishek Arya.
Source/WebCore:
Ensure that both ends of a blend are checked for being Calculated. The current
check did not cover the case where the 'from' end was Calculated and nonzero,
and the 'to' end was zero and not Calculated.
Blending doesn't work with calculated expressions and is being tracked in
bug http://webkit.org/b/86160
Tests: css3/calc/transition-crash3.html
css3/calc/transition-crash4.html
* platform/Length.h:
(WebCore::Length::blend):
LayoutTests:
* css3/calc/transition-crash3-expected.txt: Added.
* css3/calc/transition-crash3.html: Added.
* css3/calc/transition-crash4-expected.txt: Added.
* css3/calc/transition-crash4.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117748
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 21 May 2012 08:42:53 +0000 (08:42 +0000)]
[EFL] [DRT] Update EFL baselines after r117412 and r117477
https://bugs.webkit.org/show_bug.cgi?id=86968
Unreviewed EFL gardening. Update results after r117412 and r117477.
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-05-21
* platform/efl/fast/multicol/shadow-breaking-expected.png:
* platform/efl/tables/mozilla/bugs/bug10296-1-expected.png:
* platform/efl/tables/mozilla/bugs/bug10296-1-expected.txt:
* platform/efl/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117747
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Mon, 21 May 2012 08:36:39 +0000 (08:36 +0000)]
Web Inspector: make search results view more dense
https://bugs.webkit.org/show_bug.cgi?id=86937
Reviewed by Yury Semikhatsky.
- moved search field to the 'drawer status bar'
- search view is now shown on scripts panel only
- switching from the scripts panel closes the search view
- beautified the looks (see the screenshot)
* English.lproj/localizedStrings.js:
* inspector/front-end/AdvancedSearchController.js:
(WebInspector.AdvancedSearchController.prototype.handleShortcut):
(WebInspector.AdvancedSearchController.prototype.show):
(WebInspector.AdvancedSearchController.prototype.close):
(WebInspector.SearchView):
(WebInspector.FileBasedSearchResultsPane):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.willHide):
* inspector/front-end/externs.js:
(WebInspector.showViewInDrawer):
(WebInspector.closeViewInDrawer):
* inspector/front-end/inspector.css:
(.search-drawer-header input[type="search"].search-config-search):
(.search-drawer-header label.search-config-label):
(.search-drawer-header input[type="checkbox"].search-config-checkbox):
(body:not(.platform-mac) .search-drawer-header input[type="checkbox"].search-config-checkbox):
(body.platform-mac .search-drawer-header input[type="checkbox"].search-config-checkbox):
(.drawer-header):
(.drawer-header-close-button):
(.drawer-header-close-button:hover):
(.drawer-header-close-button:active):
(.search-view .search-results):
(#search-results-pane-file-based li):
(#search-results-pane-file-based ol):
(#search-results-pane-file-based ol.children):
(#search-results-pane-file-based ol.children.expanded):
(#search-results-pane-file-based li.parent::before):
(#search-results-pane-file-based li.parent.expanded::before):
(#search-results-pane-file-based .search-result):
(#search-results-pane-file-based .show-more-matches):
* inspector/front-end/inspector.js:
(WebInspector.showViewInDrawer.closeButtonPressed):
(WebInspector.showViewInDrawer):
(WebInspector.closeViewInDrawer):
(WebInspector.postDocumentKeyDown):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117746
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Mon, 21 May 2012 08:27:42 +0000 (08:27 +0000)]
[Chromium] Implement WebViewImpl::textInputInfo() for Android
https://bugs.webkit.org/show_bug.cgi?id=86440
Reviewed by Darin Fisher.
This patch adds WebView::textInputInfo(), which describes the text
input that currently has focus. Android is planning to use this to
determine what sort of keyboard or text entry UI to show. This API
subsumes the textInputType() API, which will be removed once the
clients have been updated.
* WebKit.gyp:
* public/WebTextInputInfo.h: Added.
(WebKit):
(WebTextInputInfo):
(WebKit::WebTextInputInfo::WebTextInputInfo):
(WebKit::operator==):
(WebKit::operator!=):
* public/WebTextInputType.h:
* public/WebWidget.h:
(WebWidget):
(WebKit::WebWidget::textInputInfo):
(WebKit::WebWidget::textInputType):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::textInputInfo):
(WebKit):
(WebKit::WebViewImpl::textInputType):
* src/WebViewImpl.h:
(WebViewImpl):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117745
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kling@webkit.org [Mon, 21 May 2012 08:14:46 +0000 (08:14 +0000)]
REGRESSION(r117501): IconDatabase asserts on startup in synchronousIconForPageURL().
<http://webkit.org/b/86935>
<rdar://problem/
11480012>
Reviewed by Anders Carlsson.
Source/WebCore:
- Correctly set m_retainOrReleaseIconRequested to true in retainIconForPageURL().
This was causing the assertions, as we would end up doing nothing until the first
icon release request came in.
- Require that m_urlsToRetainOrReleaseLock be held when accessing m_retainOrReleaseIconRequested.
This removes a possible race condition in double checked locking.
- Swap over the retain/release work queues while holding m_urlsToRetainOrReleaseLock
and release it right away to avoid sitting on the lock while updating the database.
* loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::synchronousIconForPageURL):
(WebCore::IconDatabase::retainIconForPageURL):
(WebCore::IconDatabase::releaseIconForPageURL):
(WebCore::IconDatabase::retainedPageURLCount):
(WebCore::IconDatabase::performURLImport):
(WebCore::IconDatabase::syncThreadMainLoop):
(WebCore::IconDatabase::performPendingRetainAndReleaseOperations):
* loader/icon/IconDatabase.h:
(IconDatabase):
Source/WTF:
Added a swap() to HashCountedSet.
* wtf/HashCountedSet.h:
(HashCountedSet::swap):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117744
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Mon, 21 May 2012 08:08:14 +0000 (08:08 +0000)]
Unreviewed, build fix.
* html/StepRange.cpp:
(WebCore::StepRange::parseStep): Remove bogus asssetions.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117743
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Mon, 21 May 2012 07:58:42 +0000 (07:58 +0000)]
Unreviewed, build fix.
* html/StepRange.cpp:
(WebCore::StepRange::StepRange): Remove another ASSERT_NOT_REACHED.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117742
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 21 May 2012 07:57:34 +0000 (07:57 +0000)]
Unreviewed. Rolled DEPS.
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-21
* DEPS:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117741
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Mon, 21 May 2012 07:53:50 +0000 (07:53 +0000)]
Unreviewed, build fix.
* html/StepRange.h:
(WebCore::StepRange::StepDescription::StepDescription):
Remove ASSERT_NOT_REACHED.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117739
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yosin@chromium.org [Mon, 21 May 2012 07:15:38 +0000 (07:15 +0000)]
[Forms] Move numeric related methods in HTMLInputElement class to another place
https://bugs.webkit.org/show_bug.cgi?id=82034
Reviewed by Kent Tamura.
This patch moves step and range related methods into StepRange class
for ease of using step calculation other than double floating point
number arithmetic, e.g. decimal, long double, and so on.
New class StepRange::StepDescription holds values for calculating
stepped value, defaultStep, defaultStepBase, integer rounding flags,
step scale factor instead of virtual methods in InputType class.
No new tests because of this patch doesn't change behavior.
* WebCore.xcodeproj/project.pbxproj: Set attribute of StepRange.h to "Private" for including it in HTMLInputElement.cpp.
* html/BaseDateAndTimeInputType.cpp:
(WebCore::InputType::rangeOverflow): Moved to use InputType class.
(WebCore::InputType::rangeUnderflow): Moved to use InputType class.
(WebCore::BaseDateAndTimeInputType::stepMismatch): Moved to use stepRange.
* html/BaseDateAndTimeInputType.h:
(BaseDateAndTimeInputType): Removed method declaration for stepBase.
* html/DateInputType.cpp:
(WebCore::DateInputType::setupStepRange): Added.
* html/DateInputType.h:
(DateInputType): Removed method declarations.
* html/DateTimeInputType.cpp:
(WebCore::DateTimeInputType::defaultStep): Removed.
(WebCore::DateTimeInputType::maximum): Removed.
(WebCore::DateTimeInputType::minimum): Removed.
(WebCore::DateTimeInputType::setupStepRange): Added
(WebCore::DateTimeInputType::stepScaleFactor): Removed.
* html/DateTimeInputType.h:
(DateTimeInputType): Removed deprecated method declarations.
* html/DateTimeLocalInputType.cpp:
(WebCore::DateTimeLocalInputType::defaultStep): Removed.
(WebCore::DateTimeLocalInputType::maximum): Removed.
(WebCore::DateTimeLocalInputType::minimum): Removed.
(WebCore::DateTimeLocalInputType::setupStepRange): Added.
(WebCore::DateTimeLocalInputType::stepScaleFactor): Removed.
* html/DateTimeLocalInputType.h:
(DateTimeLocalInputType):
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::isInRange): Changed to call InputType::isInRange.
(WebCore::HTMLInputElement::isOutOfRange): Changed to call InputType::isOutOfRange.
(WebCore::HTMLInputElement::setupStepRange): Added.
* html/HTMLInputElement.h:
(HTMLInputElement):
* html/InputType.cpp:
(WebCore::InputType::acceptableError): Moved to StepRange class.
(WebCore::InputType::alignValueForStep): Moved to StepRange class.
(WebCore::InputType::minimum): Changed to use StepRange class.
(WebCore::InputType::maximum): Changed to use StepRange class.
(WebCore::InputType::parseToDouble): Changed to have ASSERT_NOT_REACHED.
(WebCore::InputType::stepBaseWithDecimalPlaces): Changed to use StepRange class.
(WebCore::InputType::validationMessage): Changed to use StepRange class.
(WebCore::InputType::applyStep): Changed to use StepRange class.
(WebCore::InputType::getAllowedValueStep): Changed to use StepRange class.
(WebCore::InputType::isInRange): Added.
(WebCore::InputType::isOutOfRange): Added.
(WebCore::InputType::rangeOverflow): Changed to use StepRange class.
(WebCore::InputType::rangeUnderflow): Changed to use StepRange class.
(WebCore::InputType::setupStepRange): Added.
(WebCore::InputType::stepUpFromRenderer): Changed to use StepRange class.
(WebCore::InputType::stepMismatch): Changed to use StepRange class.
* html/InputType.h:
(InputType):
* html/MonthInputType.cpp:
(WebCore::MonthInputType::defaultStep): Removed.
(WebCore::MonthInputType::maximum): Removed.
(WebCore::MonthInputType::minimum): Removed.
(WebCore::MonthInputType::setupStepRange): Added.
(WebCore::MonthInputType::stepScaleFactor): Removed.
* html/MonthInputType.h:
(MonthInputType):
* html/NumberInputType.cpp:
(WebCore):
(WebCore::NumberInputType::defaultStep): Removed.
(WebCore::NumberInputType::maximum): Removed.
(WebCore::NumberInputType::minimum): Removed.
(WebCore::NumberInputType::rangeOverflow): Moved to InputType class.
(WebCore::NumberInputType::rangeUnderflow): Moved to InputType class.
(WebCore::NumberInputType::setupStepRange): Added.
(WebCore::NumberInputType::stepMismatch): Moved to InputType class.
(WebCore::NumberInputType::stepBaseWithDecimalPlaces): Changed to use StepRange class.
(WebCore::NumberInputType::stepScaleFactor): Removed.
* html/NumberInputType.h:
(NumberInputType):
* html/RangeInputType.cpp:
(WebCore::RangeInputType::defaultStep): Removed.
(WebCore::RangeInputType::maximum): Removed.
(WebCore::RangeInputType::minimum): Removed.
(WebCore::RangeInputType::setupStepRange): Added.
(WebCore::RangeInputType::stepScaleFactor): Removed.
(WebCore::RangeInputType::handleKeydownEvent): Changed to use StepRange class.
(WebCore::RangeInputType::fallbackValue): Changed to use StepRange class.
(WebCore::RangeInputType::sanitizeValue): Changed to use StepRange class.
* html/RangeInputType.h:
(RangeInputType):
* html/StepRange.cpp:
(WebCore::StepRange::StepRange): Added.
(WebCore::StepRange::clampValue): Changed for member variable name changes.
(WebCore::StepRange::hasStep): Added.
(WebCore::StepRange::maximum): Added.
(WebCore::StepRange::minimum): Added.
(WebCore::StepRange::step): Added.
(WebCore::StepRange::stepBase): Added.
(WebCore::StepRange::stepDecimalPlaces): Added.
(WebCore::StepRange::stepScaleFactor): Added.
(WebCore::StepRange::setHasStep): Added.
(WebCore::StepRange::setup): Added.
(WebCore::StepRange::parse): Added.
* html/StepRange.h:
(StepDescription): Added
(WebCore::StepRange::StepDescription::StepDescription):
(WebCore::StepRange::acceptableError): Moved from InputType class.
(WebCore::StepRange::alignValueForStep): Moved from InputType class.
(WebCore::StepRange::defaultValue): Changed for member variable name changes.
(WebCore::StepRange::proportionFromValue): Changed for member variable name changes.
(WebCore::StepRange::valueFromProportion): Changed for member variable name changes.
* html/TimeInputType.cpp:
(WebCore::TimeInputType::defaultStep): Removed.
(WebCore::TimeInputType::maximum): Removed.
(WebCore::TimeInputType::minimum): Removed.
(WebCore::TimeInputType::setupStepRange): Added.
(WebCore::TimeInputType::stepScaleFactor): Removed.
* html/TimeInputType.h:
(TimeInputType):
* html/WeekInputType.cpp:
(WebCore):
(WebCore::WeekInputType::defaultStep): Removed.
(WebCore::WeekInputType::maximum): Removed.
(WebCore::WeekInputType::minimum): Removed.
(WebCore::WeekInputType::setupStepRange): Added.
(WebCore::WeekInputType::stepScaleFactor): Removed.
* html/WeekInputType.h:
(WeekInputType):
* html/shadow/SliderThumbElement.cpp:
(WebCore::sliderPosition): Changed to use StepRange class.
(WebCore::SliderThumbElement::setPositionFromPoint): Changed to use StepRange class.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117738
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 21 May 2012 07:11:00 +0000 (07:11 +0000)]
[EFL] Minor style fixes in web intents code are needed
https://bugs.webkit.org/show_bug.cgi?id=86986
Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-05-21
Reviewed by Adam Barth.
Source/WebKit:
Fix minor ordering issues in CMake files.
* CMakeLists.txt:
* PlatformEfl.cmake:
Source/WebKit/efl:
* ewk/EWebKit.h: Add new intent headers.
* ewk/ewk_frame.h: Add missing underscores to EwkIntentRequest type.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117737
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
haraken@chromium.org [Mon, 21 May 2012 07:08:21 +0000 (07:08 +0000)]
[V8] Pass Isolate to throwNotEnoughArgumentsError()
https://bugs.webkit.org/show_bug.cgi?id=86983
Reviewed by Adam Barth.
The objective is to pass Isolate around in V8 bindings.
This patch passes Isolate to throwNotEnoughArgumentsError().
No tests. No change in behavior.
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateArgumentsCountCheck):
(GenerateEventConstructorCallback):
* bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore::Float64ArrayV8Internal::fooCallback):
* bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore::TestActiveDOMObjectV8Internal::excitingFunctionCallback):
(WebCore::TestActiveDOMObjectV8Internal::postMessageCallback):
* bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
(WebCore::TestCustomNamedGetterV8Internal::anotherFunctionCallback):
* bindings/scripts/test/V8/V8TestEventConstructor.cpp:
(WebCore::V8TestEventConstructor::constructorCallback):
* bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore::TestEventTargetV8Internal::itemCallback):
(WebCore::TestEventTargetV8Internal::dispatchEventCallback):
* bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::TestInterfaceV8Internal::supplementalMethod2Callback):
(WebCore::V8TestInterface::constructorCallback):
* bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore::TestMediaQueryListListenerV8Internal::methodCallback):
* bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore::V8TestNamedConstructorConstructorCallback):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::voidMethodWithArgsCallback):
(WebCore::TestObjV8Internal::intMethodWithArgsCallback):
(WebCore::TestObjV8Internal::objMethodWithArgsCallback):
(WebCore::TestObjV8Internal::methodWithSequenceArgCallback):
(WebCore::TestObjV8Internal::methodReturningSequenceCallback):
(WebCore::TestObjV8Internal::methodThatRequiresAllArgsAndThrowsCallback):
(WebCore::TestObjV8Internal::serializedValueCallback):
(WebCore::TestObjV8Internal::idbKeyCallback):
(WebCore::TestObjV8Internal::optionsObjectCallback):
(WebCore::TestObjV8Internal::methodWithNonOptionalArgAndOptionalArgCallback):
(WebCore::TestObjV8Internal::methodWithNonOptionalArgAndTwoOptionalArgsCallback):
(WebCore::TestObjV8Internal::methodWithCallbackArgCallback):
(WebCore::TestObjV8Internal::methodWithNonCallbackArgAndCallbackArgCallback):
(WebCore::TestObjV8Internal::overloadedMethod1Callback):
(WebCore::TestObjV8Internal::overloadedMethod2Callback):
(WebCore::TestObjV8Internal::overloadedMethod3Callback):
(WebCore::TestObjV8Internal::overloadedMethod4Callback):
(WebCore::TestObjV8Internal::overloadedMethod5Callback):
(WebCore::TestObjV8Internal::overloadedMethod6Callback):
(WebCore::TestObjV8Internal::overloadedMethod7Callback):
(WebCore::TestObjV8Internal::overloadedMethod11Callback):
(WebCore::TestObjV8Internal::overloadedMethod12Callback):
(WebCore::TestObjV8Internal::enabledAtRuntimeMethod1Callback):
(WebCore::TestObjV8Internal::enabledAtRuntimeMethod2Callback):
(WebCore::TestObjV8Internal::convert1Callback):
(WebCore::TestObjV8Internal::convert2Callback):
(WebCore::TestObjV8Internal::convert3Callback):
(WebCore::TestObjV8Internal::convert4Callback):
(WebCore::TestObjV8Internal::convert5Callback):
(WebCore::TestObjV8Internal::strictFunctionCallback):
(WebCore::V8TestObj::constructorCallback):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::TestSerializedScriptValueInterfaceV8Internal::acceptTransferListCallback):
(WebCore::V8TestSerializedScriptValueInterface::constructorCallback):
* bindings/v8/ScriptController.cpp:
(WebCore::setValueAndClosePopupCallback):
* bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::throwNotEnoughArgumentsError):
* bindings/v8/V8Proxy.h:
(V8Proxy):
* bindings/v8/custom/V8AudioContextCustom.cpp:
(WebCore::V8AudioContext::constructorCallback):
* bindings/v8/custom/V8DataViewCustom.cpp:
(WebCore::V8DataView::getInt8Callback):
(WebCore::V8DataView::getUint8Callback):
(WebCore::V8DataView::setInt8Callback):
(WebCore::V8DataView::setUint8Callback):
* bindings/v8/custom/V8DirectoryEntryCustom.cpp:
(WebCore::V8DirectoryEntry::getDirectoryCallback):
(WebCore::V8DirectoryEntry::getFileCallback):
* bindings/v8/custom/V8IntentConstructor.cpp:
(WebCore::V8Intent::constructorCallback):
* bindings/v8/custom/V8SVGLengthCustom.cpp:
(WebCore::V8SVGLength::convertToSpecifiedUnitsCallback):
* bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
(WebCore::getObjectParameter):
(WebCore::V8WebGLRenderingContext::getAttachedShadersCallback):
(WebCore::V8WebGLRenderingContext::getExtensionCallback):
(WebCore::V8WebGLRenderingContext::getFramebufferAttachmentParameterCallback):
(WebCore::V8WebGLRenderingContext::getParameterCallback):
(WebCore::V8WebGLRenderingContext::getProgramParameterCallback):
(WebCore::V8WebGLRenderingContext::getShaderParameterCallback):
(WebCore::V8WebGLRenderingContext::getUniformCallback):
(WebCore::vertexAttribAndUniformHelperf):
(WebCore::uniformHelperi):
(WebCore::uniformMatrixHelper):
* bindings/v8/custom/V8WebKitMutationObserverCustom.cpp:
(WebCore::V8WebKitMutationObserver::constructorCallback):
(WebCore::V8WebKitMutationObserver::observeCallback):
* bindings/v8/custom/V8WebSocketCustom.cpp:
(WebCore::V8WebSocket::constructorCallback):
(WebCore::V8WebSocket::sendCallback):
* bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
(WebCore::V8XMLHttpRequest::openCallback):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117736
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
carlosgc@webkit.org [Mon, 21 May 2012 06:39:22 +0000 (06:39 +0000)]
[GTK] Add GCancellable parameter to all methods using gio async pattern
https://bugs.webkit.org/show_bug.cgi?id=86843
Reviewed by Gustavo Noronha Silva.
Source/WebKit2:
Add a private macro WEBKIT_DEFINE_ASYNC_DATA_STRUCT() to make it
easier to define temporary structs used in async operations.
* UIProcess/API/gtk/WebKitCookieManager.cpp:
(GetAcceptPolicyAsyncData):
(webkitCookieManagerGetAcceptPolicyCallback):
(webkit_cookie_manager_get_accept_policy):
(webkit_cookie_manager_get_accept_policy_finish):
(GetDomainsWithCookiesAsyncData):
(webkitCookieManagerGetDomainsWithCookiesCallback):
(webkit_cookie_manager_get_domains_with_cookies):
(webkit_cookie_manager_get_domains_with_cookies_finish):
* UIProcess/API/gtk/WebKitCookieManager.h:
* UIProcess/API/gtk/WebKitPrivate.h:
* UIProcess/API/gtk/WebKitWebContext.cpp:
(webkit_web_context_get_plugins):
* UIProcess/API/gtk/WebKitWebResource.cpp:
(ResourceGetDataAsyncData):
(resourceDataCallback):
(webkit_web_resource_get_data):
(webkit_web_resource_get_data_finish):
* UIProcess/API/gtk/WebKitWebResource.h:
* UIProcess/API/gtk/WebKitWebView.cpp:
(ValidateEditingCommandAsyncData):
(didValidateCommand):
(webkit_web_view_can_execute_editing_command):
(webkit_web_view_can_execute_editing_command_finish):
(RunJavaScriptAsyncData::~RunJavaScriptAsyncData):
(RunJavaScriptAsyncData):
(webkitWebViewRunJavaScriptCallback):
(webkit_web_view_run_javascript):
(webkit_web_view_run_javascript_finish):
* UIProcess/API/gtk/WebKitWebView.h:
* UIProcess/API/gtk/tests/TestCookieManager.cpp:
* UIProcess/API/gtk/tests/TestResources.cpp:
* UIProcess/API/gtk/tests/TestWebKitWebView.cpp:
* UIProcess/API/gtk/tests/TestWebViewEditor.cpp:
* UIProcess/API/gtk/tests/WebViewTest.cpp:
(WebViewTest::runJavaScriptAndWaitUntilFinished):
Tools:
* MiniBrowser/gtk/BrowserWindow.c:
(browser_window_load_uri):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117735
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
haraken@chromium.org [Mon, 21 May 2012 06:30:51 +0000 (06:30 +0000)]
[V8] Pass Isolate to throwError()s in V8 custom bindings (Part 2)
https://bugs.webkit.org/show_bug.cgi?id=86981
Reviewed by Adam Barth.
The objective is to pass Isolate around in V8 bindings.
This patch passes Isolate to throwError()s in V8 custom bindings.
No tests. No change in behavior.
* bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
(WebCore::v8HTMLImageElementConstructorCallback):
* bindings/v8/custom/V8HistoryCustom.cpp:
(WebCore::V8History::pushStateCallback):
(WebCore::V8History::replaceStateCallback):
* bindings/v8/custom/V8IntentConstructor.cpp:
(WebCore::V8Intent::constructorCallback):
* bindings/v8/custom/V8MessagePortCustom.cpp:
(WebCore::handlePostMessageCallback):
* bindings/v8/custom/V8NotificationCenterCustom.cpp:
(WebCore::V8NotificationCenter::createHTMLNotificationCallback):
(WebCore::V8NotificationCenter::createNotificationCallback):
(WebCore::V8NotificationCenter::requestPermissionCallback):
* bindings/v8/custom/V8SQLResultSetRowListCustom.cpp:
(WebCore::V8SQLResultSetRowList::itemCallback):
* bindings/v8/custom/V8SQLTransactionCustom.cpp:
(WebCore::V8SQLTransaction::executeSqlCallback):
* bindings/v8/custom/V8SQLTransactionSyncCustom.cpp:
(WebCore::V8SQLTransactionSync::executeSqlCallback):
* bindings/v8/custom/V8StorageCustom.cpp:
(WebCore::storageSetter):
* bindings/v8/custom/V8WebKitMutationObserverCustom.cpp:
(WebCore::V8WebKitMutationObserver::constructorCallback):
(WebCore::V8WebKitMutationObserver::observeCallback):
* bindings/v8/custom/V8WebSocketCustom.cpp:
(WebCore::V8WebSocket::constructorCallback):
(WebCore::V8WebSocket::sendCallback):
(WebCore::V8WebSocket::closeCallback):
* bindings/v8/custom/V8WorkerContextCustom.cpp:
(WebCore::V8WorkerContext::importScriptsCallback):
* bindings/v8/custom/V8WorkerCustom.cpp:
(WebCore::handlePostMessageCallback):
* bindings/v8/custom/V8XMLHttpRequestConstructor.cpp:
(WebCore::V8XMLHttpRequest::constructorCallback):
* bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
(WebCore::V8XMLHttpRequest::responseTextAccessorGetter):
(WebCore::V8XMLHttpRequest::openCallback):
(WebCore::V8XMLHttpRequest::sendCallback):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117734
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
haraken@chromium.org [Mon, 21 May 2012 06:28:54 +0000 (06:28 +0000)]
[V8] Pass Isolate to throwError()s in V8 custom bindings (Part 1)
https://bugs.webkit.org/show_bug.cgi?id=86980
Reviewed by Adam Barth.
The objective is to pass Isolate around in V8 bindings.
This patch passes Isolate to throwError()s in V8 custom bindings.
No tests. No change in behavior.
* bindings/v8/custom/V8ArrayBufferCustom.cpp:
(WebCore::V8ArrayBuffer::constructorCallback):
* bindings/v8/custom/V8ArrayBufferViewCustom.h:
(WebCore::constructWebGLArrayWithArrayBufferArgument):
(WebCore::constructWebGLArray):
* bindings/v8/custom/V8AudioContextCustom.cpp:
(WebCore::V8AudioContext::constructorCallback):
* bindings/v8/custom/V8BlobCustom.cpp:
(WebCore::V8Blob::constructorCallback):
* bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:
(WebCore::V8CSSStyleDeclaration::namedPropertySetter):
* bindings/v8/custom/V8ClipboardCustom.cpp:
(WebCore::V8Clipboard::clearDataCallback):
(WebCore::V8Clipboard::setDragImageCallback):
* bindings/v8/custom/V8DOMFormDataCustom.cpp:
(WebCore::V8DOMFormData::appendCallback):
* bindings/v8/custom/V8DOMStringMapCustom.cpp:
(WebCore::V8DOMStringMap::namedPropertySetter):
* bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::handlePostMessageCallback):
* bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp:
(WebCore::handlePostMessageCallback):
* bindings/v8/custom/V8DirectoryEntryCustom.cpp:
(WebCore::V8DirectoryEntry::getDirectoryCallback):
(WebCore::V8DirectoryEntry::getFileCallback):
* bindings/v8/custom/V8DocumentCustom.cpp:
(WebCore::V8Document::evaluateCallback):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117733
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
haraken@chromium.org [Mon, 21 May 2012 06:20:01 +0000 (06:20 +0000)]
[V8] Pass Isolate to V8NPObject::npObjectGetProperty() and V8NPObject::npObjectSetProperty()
https://bugs.webkit.org/show_bug.cgi?id=86979
Reviewed by Adam Barth.
The objective is to pass Isolate around in V8 bindings.
This patch passes Isolate to V8NPObject::npObjectGetProperty()
and V8NPObject::npObjectSetProperty().
No tests. No change in behavior.
* bindings/v8/V8NPObject.cpp:
(WebCore::npObjectGetProperty):
(WebCore::npObjectNamedPropertyGetter):
(WebCore::npObjectIndexedPropertyGetter):
(WebCore::npObjectGetNamedProperty):
(WebCore::npObjectGetIndexedProperty):
(WebCore::npObjectQueryProperty):
(WebCore::npObjectSetProperty):
(WebCore::npObjectNamedPropertySetter):
(WebCore::npObjectIndexedPropertySetter):
(WebCore::npObjectSetNamedProperty):
(WebCore::npObjectSetIndexedProperty):
* bindings/v8/V8NPObject.h:
(WebCore):
* bindings/v8/custom/V8HTMLPlugInElementCustom.cpp:
(WebCore::npObjectNamedGetter):
(WebCore::npObjectNamedSetter):
(WebCore::npObjectIndexedGetter):
(WebCore::npObjectIndexedSetter):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117732
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Mon, 21 May 2012 06:11:02 +0000 (06:11 +0000)]
Using createContextualFragment to insert a <script> does not cause the script to execute
https://bugs.webkit.org/show_bug.cgi?id=12234
Reviewed by Adam Barth.
Source/WebCore:
Renamed FragmentScriptingAllowed and FragmentScriptingNotAllowed to DisallowScriptingContent
and AllowScriptingContent as these two flags are used in code for non-fragment cases and they
indicate whether attributes and elements that can invoke scripting should be removed or not.
To fix the bug, added a new value AllowScriptingContentAndDoNotMarkAlreadyStarted unset
already-started and parser-inserted flags [1] on script elements in addition to allowing
scripting contents.
While the HTML5 specification and the DOM Parsing and Serialization specification [2] state that
we should set these flags in the parser and later unset them, doing so would require traversing
the parsed fragment to find relevant script elements. We short circuit this logic by simply not
setting parser-inserted and already-started flags in createContextualFragment.
[1] http://www.whatwg.org/specs/web-apps/current-work/multipage/scripting-1.html#already-started
[2] http://html5.org/specs/dom-parsing.html#dom-range-createcontextualfragment
Tests: fast/dom/Range/create-contextual-fragment-script-not-ran.html
fast/dom/Range/create-contextual-fragment-script-unmark-already-started.html
* dom/DocumentFragment.h:
(DocumentFragment):
* dom/Element.cpp:
(WebCore::Element::parserSetAttributes):
(WebCore::Element::setAttributeNS):
* dom/Element.h:
(Element):
* dom/FragmentScriptingPermission.h:
* dom/Range.cpp:
(WebCore::Range::createContextualFragment): Removed FragmentScriptingPermission from the argument
list since no one uses it. Always use AllowScriptingContentAndDoNotMarkAlreadyStarted instead.
* dom/Range.h:
* editing/markup.h:
* html/parser/HTMLConstructionSite.cpp:
(WebCore::HTMLConstructionSite::HTMLConstructionSite):
(WebCore::HTMLConstructionSite::insertScriptElement): Pass false to both parserInserted and
alreadyStarted when the scripting permission is AllowScriptingContentAndDoNotMarkAlreadyStarted.
Also call parserSetAttributes when the scripting permission is either AllowScriptingContent or
AllowScriptingContentAndDoNotMarkAlreadyStarted.
* html/parser/HTMLDocumentParser.h:
(HTMLDocumentParser):
* html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::FragmentParsingContext::FragmentParsingContext):
(WebCore::HTMLTreeBuilder::processEndTag):
* html/parser/HTMLTreeBuilder.h:
(FragmentParsingContext):
* platform/blackberry/PasteboardBlackBerry.cpp:
(WebCore::Pasteboard::documentFragment):
* platform/chromium/DragDataChromium.cpp:
(WebCore::DragData::asFragment):
* platform/chromium/PasteboardChromium.cpp:
(WebCore::Pasteboard::documentFragment):
* platform/gtk/PasteboardGtk.cpp:
(WebCore::Pasteboard::documentFragment):
* platform/mac/PasteboardMac.mm:
(WebCore::Pasteboard::documentFragment):
* platform/qt/DragDataQt.cpp:
(WebCore::DragData::asFragment):
* platform/qt/PasteboardQt.cpp:
(WebCore::Pasteboard::documentFragment):
* platform/win/ClipboardUtilitiesWin.cpp:
(WebCore::fragmentFromCFHTML):
(WebCore::fragmentFromHTML):
* xml/XMLErrors.cpp:
(WebCore::createXHTMLParserErrorHeader):
(WebCore::XMLErrors::insertErrorMessageBlock):
* xml/parser/NewXMLDocumentParser.h:
(NewXMLDocumentParser):
* xml/parser/XMLDocumentParser.h:
(XMLDocumentParser):
* xml/parser/XMLDocumentParserLibxml2.cpp:
(WebCore::XMLDocumentParser::XMLDocumentParser):
(WebCore::XMLDocumentParser::endElementNs):
* xml/parser/XMLDocumentParserQt.cpp:
(WebCore::XMLDocumentParser::XMLDocumentParser):
(WebCore::XMLDocumentParser::parseEndElement):
Source/WebKit/mac:
Renamed FragmentScriptingNotAllowed to DisallowScriptingContent.
* WebView/WebFrame.mm:
(-[WebFrame _documentFragmentWithMarkupString:baseURLString:]):
LayoutTests:
Added regressions tests to ensure createContextualFragment doesn't execute script elements
immediately as they are parsed and it doesn't mark those script elements as already started.
The behavior of innerHTML is tested elsewhere and this patch does not affect its behavior.
* fast/dom/Range/create-contextual-fragment-script-not-ran-expected.txt: Added.
* fast/dom/Range/create-contextual-fragment-script-not-ran.html: Added.
* fast/dom/Range/create-contextual-fragment-script-unmark-already-started-expected.txt: Added.
* fast/dom/Range/create-contextual-fragment-script-unmark-already-started.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117731
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
haraken@chromium.org [Mon, 21 May 2012 05:53:42 +0000 (05:53 +0000)]
[V8] Pass Isolate to V8Utilities::createFunctionCallback()
https://bugs.webkit.org/show_bug.cgi?id=86978
Reviewed by Adam Barth.
The objective is to pass Isolate around in V8 bindings.
This patch passes Isolate to V8Utilities::createFunctionCallback().
No tests. No change in behavior.
* bindings/v8/V8Utilities.cpp:
(WebCore::throwTypeMismatchException):
* bindings/v8/V8Utilities.h:
(WebCore):
(WebCore::createFunctionOnlyCallback):
* bindings/v8/custom/V8GeolocationCustom.cpp:
(WebCore::V8Geolocation::getCurrentPositionCallback):
(WebCore::V8Geolocation::watchPositionCallback):
* bindings/v8/custom/V8NotificationCustom.cpp:
(WebCore::V8Notification::requestPermissionCallback):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117730
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
msaboff@apple.com [Mon, 21 May 2012 05:42:56 +0000 (05:42 +0000)]
JSGlobalData ScratchBuffers Are Not Visited During Garbage Collection
https://bugs.webkit.org/show_bug.cgi?id=86553
Reviewed by Gavin Barraclough.
Scratch buffers can contain the only reference to live objects.
Therefore visit scratch buffer contents as conservative roots.
Changed the scratch buffers to be a struct with an "active"
length and the actual buffer. The users of the scratch
buffer emit code where needed to set and clear the active
length as appropriate. During marking, the active count is
used for conservative marking.
* dfg/DFGAssemblyHelpers.h:
(JSC::DFG::AssemblyHelpers::debugCall):
* dfg/DFGOSRExitCompiler32_64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
* dfg/DFGOSRExitCompiler64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
* dfg/DFGOperations.cpp:
* dfg/DFGOperations.h:
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGThunks.cpp:
(JSC::DFG::osrExitGenerationThunkGenerator):
* heap/Heap.cpp:
(JSC::Heap::markRoots):
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::gatherConservativeRoots):
* runtime/JSGlobalData.h:
(JSC::ScratchBuffer::ScratchBuffer):
(ScratchBuffer):
(JSC::ScratchBuffer::allocationSize):
(JSC::ScratchBuffer::setActiveLength):
(JSC::ScratchBuffer::activeLength):
(JSC::ScratchBuffer::activeLengthPtr):
(JSC::ScratchBuffer::dataBuffer):
(JSGlobalData):
(JSC::JSGlobalData::scratchBufferForSize):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117729
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
haraken@chromium.org [Mon, 21 May 2012 05:42:25 +0000 (05:42 +0000)]
[V8] Pass Isolate to throwError()s in bindings/v8/*.{h,cpp}
https://bugs.webkit.org/show_bug.cgi?id=86977
Reviewed by Adam Barth.
The objective is to pass Isolate around in V8 bindings.
This patch passes Isolate to throwError()s in bindings/v8/*.{h,cpp}
except for a couple of non-trivial cases. I'll upload a follow-up patch
for the non-trivial cases.
No tests. No change in behavior.
* bindings/v8/DateExtension.cpp:
(WebCore::DateExtension::OnSleepDetected):
* bindings/v8/SerializedScriptValue.cpp:
(WebCore::SerializedScriptValue::transferArrayBuffers):
(WebCore::SerializedScriptValue::SerializedScriptValue):
* bindings/v8/SerializedScriptValue.h:
* bindings/v8/V8NPObject.cpp:
(WebCore::npObjectInvokeImpl):
(WebCore::npObjectPropertyEnumerator):
* bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::checkNewLegal):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117728
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jsbell@chromium.org [Mon, 21 May 2012 05:16:35 +0000 (05:16 +0000)]
IndexedDB: Delete obsolete Chromium WebKit API method
https://bugs.webkit.org/show_bug.cgi?id=86933
Implementation was previously removed in r17512 and callers are updated.
Reviewed by Adam Barth.
* public/WebIDBIndex.h: Delete storeName()
(WebKit::WebIDBIndex::name):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117727
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
keishi@webkit.org [Mon, 21 May 2012 05:05:57 +0000 (05:05 +0000)]
[Chromium] Enable datalist for input type email
https://bugs.webkit.org/show_bug.cgi?id=85356
Reviewed by Kent Tamura.
Source/WebCore:
No new tests. Covered in fast/forms/datalist/input-list.html
* rendering/RenderThemeChromiumCommon.cpp:
(WebCore::RenderThemeChromiumCommon::supportsDataListUI):
LayoutTests:
* platform/chromium/fast/forms/datalist/input-list-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117726
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
haraken@chromium.org [Mon, 21 May 2012 05:03:33 +0000 (05:03 +0000)]
[V8] Pass Isolate to throwError()s in CodeGeneratorV8.pm
https://bugs.webkit.org/show_bug.cgi?id=86976
Reviewed by Adam Barth.
The objective is to pass Isolate around in V8 bindings.
This patch passes Isolate to throwError()s in CodeGeneratorV8.pm.
No tests. No change in behavior.
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateNormalAttrGetter):
(GenerateNormalAttrSetter):
(GenerateParametersCheck):
(GenerateConstructorCallback):
(GenerateNamedConstructorCallback):
(GenerateFunctionCallString):
* bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::V8TestInterface::constructorCallback):
* bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore::V8TestNamedConstructorConstructorCallback):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::withScriptStateAttributeAttrSetter):
(WebCore::TestObjV8Internal::withScriptStateAttributeRaisesAttrGetter):
(WebCore::TestObjV8Internal::withScriptStateAttributeRaisesAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeRaisesAttrGetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeRaisesAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateWithSpacesAttributeAttrSetter):
(WebCore::TestObjV8Internal::withScriptStateVoidCallback):
(WebCore::TestObjV8Internal::withScriptStateObjCallback):
(WebCore::TestObjV8Internal::withScriptStateVoidExceptionCallback):
(WebCore::TestObjV8Internal::withScriptStateObjExceptionCallback):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateCallback):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateObjExceptionCallback):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateWithSpacesCallback):
(WebCore::TestObjV8Internal::methodWithCallbackArgCallback):
(WebCore::TestObjV8Internal::methodWithNonCallbackArgAndCallbackArgCallback):
(WebCore::TestObjV8Internal::methodWithCallbackAndOptionalArgCallback):
(WebCore::TestObjV8Internal::overloadedMethod5Callback):
(WebCore::V8TestObj::constructorCallback):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117725
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
staikos@webkit.org [Mon, 21 May 2012 02:44:05 +0000 (02:44 +0000)]
[BlackBerry] Implement the Screen functions to get DPI.
https://bugs.webkit.org/show_bug.cgi?id=86967
Reviewed by Antonio Gomes.
* platform/blackberry/PlatformScreenBlackBerry.cpp:
(WebCore::screenHorizontalDPI):
(WebCore::screenVerticalDPI):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117724
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
shinyak@chromium.org [Mon, 21 May 2012 02:41:58 +0000 (02:41 +0000)]
[Refactoring] Node::shadowHost() and Node::setShadowHost() can be moved to ShadowRoot.
https://bugs.webkit.org/show_bug.cgi?id=86585
Reviewed by Hajime Morita.
Since Node::shadowHost() and Node::setShadowHost() are valid only if Node is ShadowRoot,
they should be moved to ShadowRoot.
However, Node::setParent cannot be called from ShadowRoot, we add Node::setParentOrHostNode
to call it as Node::parentOrHostNode() calls Node::parent(). Node::setParent() is now private.
We also add SVGElementInstance::setParentOrHostNode() to share ContainerNodeAlgorithm.
No new tests, no change in behavior.
* dom/Attr.cpp:
(WebCore::Attr::createTextChild):
* dom/ContainerNode.cpp:
(WebCore::ContainerNode::insertBeforeCommon):
(WebCore::ContainerNode::removeBetween):
(WebCore::ContainerNode::removeChildren):
* dom/ContainerNodeAlgorithms.h:
(WebCore::appendChildToContainer):
(WebCore::Private::addChildNodesToDeletionQueue):
* dom/ElementShadow.cpp:
(WebCore::validateShadowRoot):
(WebCore::ElementShadow::addShadowRoot):
(WebCore::ElementShadow::removeAllShadowRoots):
* dom/EventDispatcher.cpp:
(WebCore::eventTargetRespectingSVGTargetRules):
(WebCore::EventDispatcher::ensureEventAncestors):
(WebCore::EventDispatcher::determineDispatchBehavior):
* dom/EventDispatcher.h:
(WebCore):
(EventDispatcher):
* dom/Node.cpp:
(WebCore::Node::parentOrHostElement):
* dom/Node.h:
(Node):
(WebCore::Node::setParentOrHostNode):
(WebCore):
* dom/NodeRenderingContext.cpp:
(WebCore::NodeRenderingContext::NodeRenderingContext):
* dom/ShadowRoot.h:
(WebCore::ShadowRoot::host):
(WebCore):
(WebCore::ShadowRoot::setHost):
* dom/TreeScope.cpp:
(WebCore::TreeScope::focusedNode):
* html/shadow/ContentSelectorQuery.cpp:
(WebCore::ContentSelectorQuery::matches):
* page/DragController.cpp:
(WebCore::asFileInput):
* page/EventHandler.cpp:
(WebCore::EventHandler::handleMousePressEvent):
(WebCore::instanceAssociatedWithShadowTreeElement):
(WebCore::EventHandler::dispatchMouseEvent):
* page/FocusController.cpp:
(WebCore::FocusScope::owner):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::hasLineIfEmpty):
* svg/SVGElementInstance.h:
(WebCore::SVGElementInstance::setParentOrHostNode):
(SVGElementInstance):
* svg/SVGStyledElement.cpp:
(WebCore::SVGStyledElement::title):
* svg/SVGTRefElement.cpp:
(WebCore::SVGShadowText::willRecalcTextStyle):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117723
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
staikos@webkit.org [Mon, 21 May 2012 02:25:55 +0000 (02:25 +0000)]
[BlackBerry] Define navigator.vendor for BlackBerry.
https://bugs.webkit.org/show_bug.cgi?id=86975
Reviewed by Antonio Gomes.
* Source/cmake/OptionsBlackBerry.cmake:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117722
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 21 May 2012 01:47:16 +0000 (01:47 +0000)]
Unsupported commands should have queryCommandValue() = "", not false
https://bugs.webkit.org/show_bug.cgi?id=86964
Patch by Joe Thomas <joethomas@motorola.com> on 2012-05-20
Reviewed by Ryosuke Niwa.
queryCommandValue for unsupported commands should return empty string.
The specification related to this can be located at http://dvcs.w3.org/hg/editing/raw-file/tip/editing.html#methods-to-query-and-execute-commands
Source/WebCore:
Test: editing/execCommand/queryCommandValue-unsupported-commands.html
* dom/Document.idl:
LayoutTests:
* editing/execCommand/queryCommandValue-unsupported-commands-expected.txt: Added.
* editing/execCommand/queryCommandValue-unsupported-commands.html: Added.
* editing/execCommand/use-css-expected.txt:
* editing/execCommand/use-css.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117721
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 21 May 2012 01:25:04 +0000 (01:25 +0000)]
[EFL] ewk_view navigation_policy_decision() input parameters should be extended
https://bugs.webkit.org/show_bug.cgi?id=85048
Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-05-20
Reviewed by Antonio Gomes.
Introduced new enum Ewk_Navigation_Type cloning WebCore::NavigationType.
Extended ewk_view navigation_policy_decision() input parameters with new
navigationType parameter. This paramater gives more data for making a
navigation policy decision and also provides dumping necessary for many Layout
testcases.
* WebCoreSupport/AssertMatchingEnums.cpp:
* WebCoreSupport/FrameLoaderClientEfl.cpp:
(WebCore::FrameLoaderClientEfl::dispatchDecidePolicyForNavigationAction):
* ewk/ewk_frame.h:
* ewk/ewk_view_private.h:
* ewk/ewk_view.cpp:
(_Ewk_View_Private_Data):
(ewk_view_navigation_policy_decision):
* ewk/ewk_view.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117720
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
haraken@chromium.org [Mon, 21 May 2012 01:01:25 +0000 (01:01 +0000)]
Unreviewed. Rebaselined run-bindings-tests results.
* bindings/scripts/test/JS/JSTestInterface.cpp:
(WebCore::setJSTestInterfaceSupplementalStr2):
(WebCore::setJSTestInterfaceSupplementalStr3):
(WebCore::setJSTestInterfaceSupplementalNode):
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::setJSTestObjShortAttr):
(WebCore::setJSTestObjUnsignedShortAttr):
(WebCore::setJSTestObjIntAttr):
(WebCore::setJSTestObjLongLongAttr):
(WebCore::setJSTestObjUnsignedLongLongAttr):
(WebCore::setJSTestObjStringAttr):
(WebCore::setJSTestObjTestObjAttr):
(WebCore::setJSTestObjSequenceAttr):
(WebCore::setJSTestObjIntSequenceAttr):
(WebCore::setJSTestObjShortSequenceAttr):
(WebCore::setJSTestObjLongSequenceAttr):
(WebCore::setJSTestObjLongLongSequenceAttr):
(WebCore::setJSTestObjUnsignedIntSequenceAttr):
(WebCore::setJSTestObjUnsignedShortSequenceAttr):
(WebCore::setJSTestObjUnsignedLongSequenceAttr):
(WebCore::setJSTestObjUnsignedLongLongSequenceAttr):
(WebCore::setJSTestObjFloatSequenceAttr):
(WebCore::setJSTestObjDoubleSequenceAttr):
(WebCore::setJSTestObjBooleanSequenceAttr):
(WebCore::setJSTestObjVoidSequenceAttr):
(WebCore::setJSTestObjDateSequenceAttr):
(WebCore::setJSTestObjXMLObjAttr):
(WebCore::setJSTestObjCreate):
(WebCore::setJSTestObjReflectedStringAttr):
(WebCore::setJSTestObjReflectedIntegralAttr):
(WebCore::setJSTestObjReflectedUnsignedIntegralAttr):
(WebCore::setJSTestObjReflectedBooleanAttr):
(WebCore::setJSTestObjReflectedURLAttr):
(WebCore::setJSTestObjReflectedCustomIntegralAttr):
(WebCore::setJSTestObjReflectedCustomBooleanAttr):
(WebCore::setJSTestObjReflectedCustomURLAttr):
(WebCore::setJSTestObjAttrWithGetterException):
(WebCore::setJSTestObjAttrWithSetterException):
(WebCore::setJSTestObjStringAttrWithGetterException):
(WebCore::setJSTestObjStringAttrWithSetterException):
(WebCore::setJSTestObjCustomAttr):
(WebCore::setJSTestObjWithScriptStateAttribute):
(WebCore::setJSTestObjWithScriptExecutionContextAttribute):
(WebCore::setJSTestObjWithScriptStateAttributeRaises):
(WebCore::setJSTestObjWithScriptExecutionContextAttributeRaises):
(WebCore::setJSTestObjWithScriptExecutionContextAndScriptStateAttribute):
(WebCore::setJSTestObjWithScriptExecutionContextAndScriptStateAttributeRaises):
(WebCore::setJSTestObjWithScriptExecutionContextAndScriptStateWithSpacesAttribute):
(WebCore::setJSTestObjWithScriptArgumentsAndCallStackAttribute):
(WebCore::setJSTestObjConditionalAttr1):
(WebCore::setJSTestObjConditionalAttr2):
(WebCore::setJSTestObjConditionalAttr3):
(WebCore::setJSTestObjConditionalAttr4Constructor):
(WebCore::setJSTestObjConditionalAttr5Constructor):
(WebCore::setJSTestObjConditionalAttr6Constructor):
(WebCore::setJSTestObjMutablePoint):
(WebCore::setJSTestObjImmutablePoint):
(WebCore::setJSTestObjStrawberry):
(WebCore::setJSTestObjStrictFloat):
(WebCore::setJSTestObjId):
* bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
(WebCore::setJSTestSerializedScriptValueInterfaceValue):
(WebCore::setJSTestSerializedScriptValueInterfaceCachedValue):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117719
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
staikos@webkit.org [Mon, 21 May 2012 00:51:57 +0000 (00:51 +0000)]
Use reinterpret_cast_ptr<> to fix an alignment warning.
https://bugs.webkit.org/show_bug.cgi?id=80790
Reviewed by Rob Buis.
* platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
(WebCore::error_exit):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117718
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Mon, 21 May 2012 00:51:27 +0000 (00:51 +0000)]
Unreviewed, GTK gardening.
* platform/gtk/test_expectations.txt: Fix expectation of
svg/hittest/svg-shapes-non-scale-stroke.html after r117713.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117717
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 21 May 2012 00:50:01 +0000 (00:50 +0000)]
Needs style recalculation by changing applyAuthorStyles dynamically
https://bugs.webkit.org/show_bug.cgi?id=84251
Source/WebCore:
Modifying setApplyAuthorStyles to invoke owner()'s
setNeedsRedistributing if applyAuthorStyles changes.
Patch by Takashi Sakamoto <tasak@google.com> on 2012-05-20
Reviewed by Hajime Morita.
No new tests. Adding new tests to existing
fast/dom/shadow/shadow-root-applyAuthorStyles.html to test this
feature.
* dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::setApplyAuthorStyles):
If applyAuthorStyles changes, invoke owner's setNeedsRedistributing to
recalculate styles of the shadow root's child elements.
LayoutTests:
Patch by Takashi Sakamoto <tasak@google.com> on 2012-05-20
Reviewed by Hajime Morita.
* fast/dom/shadow/shadow-root-applyAuthorStyles-expected.html:
* fast/dom/shadow/shadow-root-applyAuthorStyles.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117716
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dbates@webkit.org [Sun, 20 May 2012 23:32:43 +0000 (23:32 +0000)]
svn-apply cannot apply patches to files that contain space
characters in their path
https://bugs.webkit.org/show_bug.cgi?id=85742
Reviewed by Eric Seidel.
Fixes an issue where svn-apply cannot apply a patch to a file
if there is a space in its file path.
The regular expression we were using to fix up +++/--- lines
was too strict; it only matched file paths that contained non-
whitespace characters. Instead, it's sufficient to match file
paths whose characters aren't in the set {\t, \n, \r}.
* Scripts/VCSUtils.pm:
(parseSvnDiffHeader):
(runCommand): Added.
* Scripts/svn-apply:
(scmWillDeleteFile): Modified to call runCommand() so as to
handle querying git for a file whose path may contain a space
character.
* Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl:
- Added test case "new file with spaces in its name".
* Scripts/webkitperl/VCSUtils_unittest/runCommand.pl: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117715
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dbates@webkit.org [Sun, 20 May 2012 23:29:58 +0000 (23:29 +0000)]
svn-apply fails to apply a patch that moves files from directory A to A/B
https://bugs.webkit.org/show_bug.cgi?id=86973
Reviewed by Eric Seidel.
Fixes an issue where svn-apply fails to apply a patch that moves files in a
directory A to some sub-directory B in A with a Git checkout of WebKit.
Currently, svn-apply only creates new directories along a file system path that
it hasn't already processed. That is, if svn-apply creates/traverses all the
intermediate directories along the path A/B then it will assume the directory A/B
exists for all subsequent requests to create sub-directories in A/B (e.g. A/B/C).
When moving a file F in directory A to directory A/B using a Git checkout, Git
may remove directory A if F is the last file in A. Therefore, svn-apply will fail
to create sub-directory B in A (since A no longer exists).
* Scripts/svn-apply:
(addDirectoriesIfNeeded):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117714
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pdr@google.com [Sun, 20 May 2012 23:12:57 +0000 (23:12 +0000)]
Skip failing hit testing tests
https://bugs.webkit.org/show_bug.cgi?id=86971
Unreviewed, skipping tests.
* platform/efl/test_expectations.txt:
* platform/gtk/test_expectations.txt:
* platform/qt/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117713
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rakuco@webkit.org [Sun, 20 May 2012 21:35:16 +0000 (21:35 +0000)]
[EFL] Unskip passing test after r117709.
* platform/efl/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117712
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pdr@google.com [Sun, 20 May 2012 20:58:04 +0000 (20:58 +0000)]
Accumulate SVG animations into first contributing element
https://bugs.webkit.org/show_bug.cgi?id=86385
Reviewed by Nikolas Zimmermann.
Source/WebCore:
Previously we were accumulating animations into the first animation element when
there were multiple animations for a single element. This crashed if the first
animation ended first because the first animation was prematurely cleaned up.
This change accumulates animations into the first _contributing_ animation element.
Tests: svg/animations/multiple-animations-ending.html
svg/animations/svg-two-animate-elements-crash-expected.svg
svg/animations/svg-two-animate-elements-crash.svg
* svg/animation/SMILTimeContainer.cpp:
(WebCore::SMILTimeContainer::updateAnimations):
* svg/animation/SVGSMILElement.cpp:
(WebCore::SVGSMILElement::progress):
LayoutTests:
* svg/animations/multiple-animations-ending-expected.txt: Added.
* svg/animations/multiple-animations-ending.html: Added.
* svg/animations/resources/multiple-animations-ending.svg: Added.
* svg/animations/script-tests/multiple-animations-ending.js: Added.
(sample1):
(sample2):
(sample3):
(sample4):
(sample5):
(sample6):
(sample7):
(sample8):
(sample9):
(sample10):
(sample11):
(sample12):
(sample13):
(sample14):
(sample15):
(sample16):
(sample17):
(sample18):
(sample19):
(sample20):
(sample21):
(sample22):
(sample23):
(executeTest):
* svg/animations/svg-two-animate-elements-crash-expected.svg: Added.
* svg/animations/svg-two-animate-elements-crash.svg: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117711
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kevino@webkit.org [Sun, 20 May 2012 20:29:32 +0000 (20:29 +0000)]
[wx] Unreviewed build fix. Clean up no longer used files in DerivedSources.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117710
268f45cc-cd09-0410-ab3c-
d52691b4dbfc