Treat Visual Studio C4133 warning as error

Change-Id: I9cc9019fb90d38913151b9d6678f359ca35c06a4
Signed-off-by: David Antler <david.a.antler@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13567
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>
Reviewed-by: Kevin Kane <kkane@microsoft.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>

Added CAcloseSslConnectionAll() in ssl adapter

added api to close all of ssl connections

Change-Id: I2bcd1890a70ba64fd7f4cc33e6a1dfcbf6590050
Signed-off-by: Joonghwan Lee <jh05.lee@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13953
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-by: Chul Lee <chuls.lee@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/14357

Build json2cbor on OSX

Change-Id: I5858833c85a76bc4acaab1b6393f0feda28284b7
Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/14259
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>

[IOT-1519] Don't clear ownerPSK secret too early

Owner PSK secret was cleared too early; only clear after
all uses are finished.

Change-Id: Ie39990a5aabfcd71b8370103b7182cb76cb09f40
Signed-off-by: Kevin Kane <kkane@microsoft.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/14491
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Reviewed-by: Jongsung Lee <js126.lee@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit d07d715c49707a0940cc27f57b128e44954829e8)
Reviewed-on: https://gerrit.iotivity.org/gerrit/14497

Fix bug for can not callback on consumer cpp layer.

When starting consumer service, getTopic callback fisrt
and then discover callback due to can not call both changed callback and discover callback.
because when callback getTopic, NSProvider instance does not set the listener,
and when callback discover after, NSProvider instance already create, so can not callback discover.
This point is invalid logic on CPP layer.

With this patch, altough call getTopic first, can callback discover callback.

Change-Id: Ib7a3c8cf3e78edf24d0251227c5d3c225c3ba3a4
Signed-off-by: KIM JungYong <jyong2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13855
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>
(cherry picked from commit 6124156346ad25e57fb1489ccd7febf532c58fa6)
Reviewed-on: https://gerrit.iotivity.org/gerrit/13863
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

[IOT-1519] Securely zero buffers containing secret data

Add an OICClearMemory helper function, and use it to securely
clear buffers that contain keys and other secret data that
shouldn't be left in the stack or on the heap.

Rename privateKey to g_privateKey in csr.c.

Fix a couple of leaked payloads on error return paths in
secureresourceprovider.c (which will also now zero their
contents).

Change-Id: If79c840ad758be2a7ca1bf7e6ccccb6dbdc39cf2
Signed-off-by: Kevin Kane <kkane@microsoft.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/14091
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit 916ced6413b93c3c4448fb4124be429c0f13bb82)
Reviewed-on: https://gerrit.iotivity.org/gerrit/14443

[IOT-1550] Resolved reset issue on rowner of cred

https://jira.iotivity.org/browse/IOT-1550

issue : Rowner of cred is reset, when saving Cert. chain
        using SRPSaveTrustCertChain and SRPSaveOwnCertChain.

Patch 1: upload patch
Patch 2: rebase
Patch 3: Apply review comment

Change-Id: I59cdbfb30253c61e1c27dcf640958899af976a96
Signed-off-by: js126.lee <js126.lee@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/14327
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Chul Lee <chuls.lee@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit 39f4a884082aa687f86fc24296b37401780dc9cb)
Reviewed-on: https://gerrit.iotivity.org/gerrit/14441

fix Sample App related getPlatformInfo/getDeviceInfo

Change-Id: I07e2e0e24241f0c5dd53259f8333eccc722d4e39
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/14405
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Larry Sachs <larry.j.sachs@intel.com>
Reviewed-by: Rick Bell <richard.s.bell@intel.com>
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>

Enable mbedTLS's log with LOGGING=1 option

Change-Id: I51b285aac780d17d5ff45a6e5be200bef4359602
Signed-off-by: Chul Lee <chuls.lee@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/14311
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Dmitriy Zhuravlev <d.zhuravlev@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit a682f6f440066ab1656b7704dca486684d64eaa4)
Reviewed-on: https://gerrit.iotivity.org/gerrit/14437

added log messages on ip adapter to improve debugging

Because there was no log for the netlink event, it was hard to see the triggering
point for multicast group join.

And modified some codes for optimization.

Change-Id: I06c8ca4e7ec5e87db6f9fe3cb0b03ae22fb6b42e
Signed-off-by: Jaewook Jung <jw0213.jung@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/14201
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

[IOT-1570] fixed a crash issue related to block-wise transfer

When a resource server receives 4.08 error response from a resource
client, the server will try to send the response from the first
block again.
But now, the server assumes the message type that has to be sent
for receiving 4.08 error is only request message.
So I modified to handle it up to the message type.

Change-Id: I555b5dd5c44b73647c2543de551aba6f5113f909
Signed-off-by: Jaewook Jung <jw0213.jung@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/14433
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

Addressed "missing braces around initializer" warning.

Gcc exhibited a "missing braces around initializer" warning when zero
initializing the ipv6mr_multiaddr field in the ipv6_mreq structure.
This appears to be a known issue with gcc.  Avoid the warning by
removing the explicit zero initialization, and rely on the implicit
initialization behavior of designated initializers instead.

Change-Id: I5658fb620433bc7f47a31d94bab2e9f07ce66f40
Signed-off-by: Ossama Othman <ossama.othman@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/14257
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
Reviewed-by: Mike Fenelon <mike.fenelon@microsoft.com>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

fixed bug for ESEnrolleeState validation check logic

Change-Id: I51225c3f814ed6a651a06082a2504fb65289c58a
Signed-off-by: Parkhi <h_w.park@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/14401
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

[IOT-1511] Update mbedTLS to use 2.4.0 release tagged version

Reviewed-on: https://gerrit.iotivity.org/gerrit/13973
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: David Antler <david.a.antler@intel.com>
Reviewed-by: Habib Virji <habib.virji@samsung.com>
Reviewed-by: Oleksandr Dmytrenko <o.dmytrenko@samsung.com>
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
This change also includes the fix:

Fix mbedtls-2.4.0 build error

.git/refs/tags directory is empty

Reviewed-on: https://gerrit.iotivity.org/gerrit/14223
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Kevin Kane <kkane@microsoft.com>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Reviewed-by: Chul Lee <chuls.lee@samsung.com>
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Change-Id: I259709cd2024eb9eca83aa19c90783bc2a9f8c72
Signed-off-by: Kevin Kane <kkane@microsoft.com>
Signed-off-by: Dmitriy Zhuravlev <d.zhuravlev@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/14195
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>

[IOT-1544]: Fixing ParseRecur memory corruption.

 Removing possible memory corruption from ParseRecur
 by adding buffer size checks.

Change-Id: Ib4a6e943057d1ce7ba6dadca1b20090f3e4c456c
Signed-off-by: Pawel Winogrodzki <pawelwi@microsoft.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/14315
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Reviewed-by: Way Vadhanasin <wayvad@microsoft.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>

Junit files for acl id and acl verify methods

Change-Id: Ib2b138631a63a1eba9a15608d04605f726fc5ba6
Signed-off-by: Sunil Kumar K R <sunil.k14@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/14175
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit 1cd48fe9add7032fdf0e3afbd06fe190142b01ef)
Reviewed-on: https://gerrit.iotivity.org/gerrit/14399

fix findresource failure issue.

this fix is from https://gerrit.iotivity.org/gerrit/#/c/12283/

Change-Id: I70314bdc6506101b551c9389bb694cad3bf222f5
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/14397
Reviewed-by: Dave Thaler <dthaler@microsoft.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Habib Virji <habib.virji@samsung.com>

[IOT-1549] Add DTLS retransmission

Create thread for checking peer timer

Change-Id: I067b5924035b4b2563fcc094a5cbcf6dd9ae6e50
Signed-off-by: Dmitriy Zhuravlev <d.zhuravlev@samsung.com>
Signed-off-by: Chul Lee <chuls.lee@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/14287
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>

Change pstat.deviceuuid from R-only to RW

As SWG decided that pstat.deviceuuid is RW,
pstat handler has been fixed accordingly.

Patch #1: Initial upload

Change-Id: Ibc0b1d86ddfb06306268dddaf07f38152d8800f2
Signed-off-by: Jongmin Choi <jminl.choi@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/14069
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Kevin Kane <kkane@microsoft.com>
Reviewed-by: Nathan Heldt-Sheller <nathan.heldt-sheller@intel.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit 4f64da7a5e385b66948daee3d61b9b2bf6a408e8)
Reviewed-on: https://gerrit.iotivity.org/gerrit/14347

Change doxm.deviceuuid from R-only to RW in doxm entity handler.

CTT testing revealed a bug in 1.2 (and a matching bug in the 1.1
schema) that had marked deviceuuid as R-only.  However this is
not correct: deviceuuid must be Writeable to allow the OBT
to update with a new UUID during onboarding.  This has been
verified by SecWG and needs to be fixed in 1.2.

Patch #2: added a line to also copy deviceuuid in updateWriteableProperty() function

Change-Id: Icff6d978f5a12af021d557a5c71f25a4e9957ba2
Signed-off-by: Nathan Heldt-Sheller <nathan.heldt-sheller@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/14345
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>

Modify NotificationService Script to support Tizen OS

- Modify Script files to build on Tizen Platform
- Modify Logic for logging to print log through dlog api

Change-Id: I0a624400187d37817627875f983104cb14b7946b
Signed-off-by: YounghyunJoo <yh_.joo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/14097
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
Reviewed-by: JungYong KIM <jyong2.kim@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>

fix crash issue related set interfaceQuery.

Change-Id: I7c40c0930879a0ad860e935325adc44b860d9ee8
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/14355
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Larry Sachs <larry.j.sachs@intel.com>
Reviewed-by: Habib Virji <habib.virji@samsung.com>

Add RD_MODE build option on Tizen Platform

- in case of building using gbsscript, can get RD_MODE option

Change-Id: I88a027e2ba050ce9eb622eabf3d988eba8db9c64
Signed-off-by: YounghyunJoo <yh_.joo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/14281
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Habib Virji <habib.virji@samsung.com>

Fix Discovery issue with OCResource

Fix memory allocation and handling response as introduced in the change for issue 1134.

Change-Id: Ieebd1dde50d87e05f9e7ea0cec04af398cabe3ef
Signed-off-by: Habib Virji <habib.virji@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/14289
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>

[IOT-1537] Fixed twice response on both svc and amacl

Issue: In CTT test (version 1.3.15), CT1.1.1 was failed.
https://jira.iotivity.org/browse/IOT-1537
Cause: the server is responding with both 4.00(ACK) & 5.00(CON)
       error message for not supported SVR(amacl, svc).

Patch 1: Resolved this issue.

Change-Id: I552781a242a0932fbe89823d17a5403b419116b0
Signed-off-by: js126.lee <js126.lee@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/14211
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Chul Lee <chuls.lee@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit 198848194084af8981c4690f6d2182ef3850fb6d)
Reviewed-on: https://gerrit.iotivity.org/gerrit/14331

[IOT-1524] Added check to reject unsecure request for selected SVR resources

ALL SVR resources other than DOXM & PSTAT resource should reject request over coap.

Change-Id: Idcf0ff22d7c676bef2480fe9b32a9e7b22c2317a
Signed-off-by: Randeep Singh <randeep.s@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/14137
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Kevin Kane <kkane@microsoft.com>
Reviewed-by: Chul Lee <chuls.lee@samsung.com>
(cherry picked from commit c9e82ceebe5ac962ec5ef0a42b1d6e62d9476f5d)
Reviewed-on: https://gerrit.iotivity.org/gerrit/14323

[IOT-1514] Always log sensitive data at DEBUG level

Some sensitive data is logged at levels other than DEBUG. Having
all of these at DEBUG can help ensure in release builds secret
data isn't inadvertently leaked through logging.

Change-Id: I58aa4ebc8e8dcdbc9d267d7eef3135a21e6daa0b
Signed-off-by: Kevin Kane <kkane@microsoft.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/14085
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit 7257937531b5a9165f58e377eafffae175259665)
Reviewed-on: https://gerrit.iotivity.org/gerrit/14321

Removed SECURED define dependency from JNI.

Change-Id: I7fd578d3d18a220e86794ce558e3cc704784b605
Signed-off-by: Chul Lee <chuls.lee@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/14229
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit dc5ce01c137d023418d31d9cfa1de2c34051b53d)
Reviewed-on: https://gerrit.iotivity.org/gerrit/14319

[IOT-1540] replace the path for BLE connection manager

Change-Id: Id6e2adf906bcd86586ebe7743b626fdd6a00944f
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/14271
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

build: Use project path for libcoap headers path

Without this change, build is failing,
because compiler looks for non existing libcoap in service/...

This was observed on Tizen Yocto

Change-Id: Ib1e3a4dd7aae929213165576840157fdb6286941
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/14083
Reviewed-by: Habib Virji <habib.virji@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

tizen: Add resource_directory lib to main package

Change-Id: I168fe5915466abdd82049bb43744f7b425fedbe2
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/14283
Reviewed-by: Habib Virji <habib.virji@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

[IOT-1543] modified some log message more clearly.

since some log message is printing with ERROR level even not issue,
replace it with normal message.

Change-Id: I6de18b072c4dd5b9011094368a77cec1fa4043b8
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Signed-off-by: Abhishek Sharma <ce.abhishek@samsung.com>
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/14189
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

Added error callback when adapter is terminated

If application try to send data when adapter is terminated,
Error message should be delivered to application layer.

Change-Id: Iec02116e864fb8667570c67982f44838d74f84a9
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/14181
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

Remove resource directory dependency in lib OC

- Android code related to the resource directory is removed from OCPlatform and is in standalone file.
- In android resource-directory is linked as a shared file.
- Resource directory code in the InProcServerWrapper was creating a circular dependency and unwanted requirement
for the unit test and sample code.
- This patch fixes this dependency and moves C++ code to the resource directory.

https://jira.iotivity.org/browse/IOT-1510

Change-Id: I23423929b3000471d7fb91cb7c7bac89c3d1879b
Signed-off-by: Habib Virji <habib.virji@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/14059
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Rick Bell <richard.s.bell@intel.com>

Fix crash issue while stopCaching.

Change-Id: I7319690301e32cb41e224528e8e032e57d58fc77
Signed-off-by: Harry <h.marappa@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/14213
Reviewed-by: JungYong KIM <jyong2.kim@samsung.com>
Reviewed-by: Jihun Ha <jihun.ha@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Habib Virji <habib.virji@samsung.com>
Reviewed-by: Hun-je Yeon <hunje.yeon@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Add manufacturer certificate

1. Added ability to switch TLS
between different credential usage types
2. Manufacturer credentials injected to
oic_svr_db_client.dat and oic_svr_db_server_mfg.dat

Change-Id: Ide5ec7f849a03a787e45bb77e31076e94e1eb1b3
Signed-off-by: Dmitriy Zhuravlev <d.zhuravlev@samsung.com>
Signed-off-by: Oleksii Beketov <ol.beketov@samsung.com>
Signed-off-by: Chul Lee <chuls.lee@samsung.com>
Signed-off-by: Oleksii Beketov <ol.beketov@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/14049
Reviewed-by: Kevin Kane <kkane@microsoft.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit 1d7f903fabdb827ea27ca19874c4d93c5f6da465)
Reviewed-on: https://gerrit.iotivity.org/gerrit/14265

Fix static analysis issues in CA, rd_client and ocstack

- variable initialization and null checking added

Change-Id: Ibb47193ccb480941abfa71b0d32020891d2025f6
Signed-off-by: Minji Park <minjii.park@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/14157
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-by: Habib Virji <habib.virji@samsung.com>

Added C and C++ callback API for TrustCertChain Change Notification.

patch #2,3,4 : Fix callback context at RI layer
patch #5: Address review comments

Change-Id: I1d776a01cfb41074ce518ee20ddda1ce7ccde40f
Signed-off-by: Sandeep Sharma <sandeep.s9@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13627
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Kevin Kane <kkane@microsoft.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>

[CONPRO-296] Check Null parameter in GetACLResourceData()

Check Null parameter in GetACLResourceData()

Change-Id: Ifac67589b6d3fd949122d94584574635c38f8ab0
Signed-off-by: Jongmin Choi <jminl.choi@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/14159
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jongsung Lee <js126.lee@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit 2653631403ed52cc49f16c7eeac2307f038804ee)
Reviewed-on: https://gerrit.iotivity.org/gerrit/14205

Return correct error code when send fails in catcpserver

Modified ssl adapter along with  modified return type.

Change-Id: I68d0d1ab73f1a858c42b3340947f01ca61974987
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Signed-off-by: Joonghwan Lee <jh05.lee@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13991
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
Reviewed-by: jihwan seo <jihwan.seo@samsung.com>
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

[CONPRO-311] Fix due to TinyCBOR v0.4 Release

The anonymous union member of struct CborEncoder is no longer anonymous.
References to the union member are replaced by API added for them

Patch #1: Initial upload

Change-Id: Ie47779bee68cfae4fa578ae39ae087ea23b905df
Signed-off-by: Jongmin Choi <jminl.choi@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/14179
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jongsung Lee <js126.lee@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit 9a31ef80095f6382985404ba0a6c71437c9d8c43)
Reviewed-on: https://gerrit.iotivity.org/gerrit/14203

[IOT-1530]Fix resource interface checking logic

Fix resource interface checking logic
when server receive discovery request
for find matched interface type.

Change-Id: I439017180a367d0b3b20c0637d826c2a3bea1c3c
Signed-off-by: bg.chun <bg.chun@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/14169
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Habib Virji <habib.virji@samsung.com>

yocto: Add aarch64 for DragonBoard-410c

Change-Id: I0ebf93ca17a9a6624da3caaaf7487529b2c556d6
Credit-to: Kotaro HASHIMOTO <Hashimoto.Kotaro@ds.MitsubishiElectric.co.jp>
Origin: https://lists.linuxfoundation.org/pipermail/automotive-discussions/2016-November/002805.html
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/14183
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Habib Virji <habib.virji@samsung.com>

tizen: cbor headers are no more needed

Change-Id: I1c9df13d1b05a9b0aa0f8d60de8519c0c44b2486
Bug: https://jira.iotivity.org/browse/IOT-1460
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13775
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Habib Virji <habib.virji@samsung.com>
(cherry picked from commit e8426c062339308674329ca75d2da227c7f58d69)
Reviewed-on: https://gerrit.iotivity.org/gerrit/14081

[JIRA-1134] Fix mem leak in HandleVirtualResource

- VERIFY_NON_NULL to exit by cleaning the mem already allocated.
- InterfaceQuery which wa being assigned is not done, and instead if no interfaceQuery it is considered as oic.if.ll.
- Moved out rd resource search out of function,
- Baseline information handling has been updated to be handled separately.

https://jira.iotivity.org/browse/IOT-1134

Change-Id: Ie894284e4c67a7bbd4bbaa52801416a0c8dab778
Signed-off-by: Habib Virji <habib.virji@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/9279
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: David Antler <david.a.antler@intel.com>

Add OIC_ prefix for security module's log.

Change-Id: I6802265094222c0d01acc000a14b9b5afdacf6ee
Signed-off-by: Chul Lee <chuls.lee@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/14107
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Kevin Kane <kkane@microsoft.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit af2c4591eca2a68cc797f0ec41a53926cdfc23d4)
Reviewed-on: https://gerrit.iotivity.org/gerrit/14149

Update the OTMContext management mechanism to improve the reliability of the OTM process.

  1. Apply the list mechanism to manage the OTMContext.
    -> It replaces the global variables of OTMContext.

  2. Add the OCDoHandle member into OTMContext.
    -> In case of OTM process stopped before OTM process complete,
       unnecessary retransmission can be occur
       due to request is performed just before the OTM process stops.
       So we need to cancel this request to prevent retransmission.
       OCDoHandle will be used at this time.

  3. Add the device status of PDM to prevent duplicate OTM.
    -> Added PDM_DEVICE_INIT to prevent deplicate OTM.
       If device status is PDM_DEVICE_INIT, PT will skip OTM process of this device.

Change-Id: I74e200aa88a0c5016c065a518b75614bf4a3a7a8
Signed-off-by: Chul Lee <chuls.lee@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13857
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Kevin Kane <kkane@microsoft.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>

[IOT-1472] Separated BLE receive queue.

Change-Id: I64d63ed15070d851b4c02cc4c355266d972ebc46
Signed-off-by: junghun kim <jhun1105.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13623
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: jihwan seo <jihwan.seo@samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

OCRepPayload NULL array handling

OCRepPayload was not handling empty array. This patch handles both conversion and parsing. Also added new tests.

Change-Id: If06e1f47ecaaa926e0ee720ab890ca67076bad03
Signed-off-by: Habib Virji <habib.virji@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/14095
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
Reviewed-by: byonggon chun <bg.chun@samsung.com>

IOT-1513: Incorrect URI parsing in OCDoResource

RFC 6874 support was missing from ParseRequestUri

Change-Id: I023745e76a4d14dc6d786a6423eaf80d5d71e428
Signed-off-by: Dave Thaler <dthaler@microsoft.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/14057
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Habib Virji <habib.virji@samsung.com>

IOT-1461 Fix double-close bugs

1. Fix two handle double-close bugs.
2. Add asserts to catch possible similar bugs.
3. Log WSAGetLastError in decimal, for easier match with the values
from MSDN docs.

Change-Id: I7f382344994c496c67e2e370d2241f080ce0e71c
Signed-off-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13665
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>
Reviewed-by: David Antler <david.a.antler@intel.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

Fix svace defects for 1.2-rel (cloudResource.c)

Change-Id: I74a65a64347e0832d8b42ec0fdf3ac0eab50a9cc
Signed-off-by: Andrii Shtompel <a.shtompel@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/14041
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Kevin Kane <kkane@microsoft.com>
Reviewed-by: Jongsung Lee <js126.lee@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit 053384162d114770dd79e0a04da3898895cc9f29)
Reviewed-on: https://gerrit.iotivity.org/gerrit/14101

Add api about non-iterated request get at cache.

Current data update logic on RE cache is subscribing and also polling get request to resource server.
but it is causes additional communication load.
Additional api will provide a disabled polling req for reducing communication loads.

void startCaching(CacheUpdatedCallback cb, CacheMode mode); // added api
if mode on param is OBSERVE_ONLY, polling req will be disabled.
otherwise, cache will polling req and subscribing.

And unused function is removed.

Change-Id: Ifa5fd5a21dc10a0e412a8cde0370413a362603ca
Signed-off-by: KIM JungYong <jyong2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/14065
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>

Tizen: Support Ethernet/3G Status Monitoring in IP Adapter

Currently Wifi status monitoring is supported for tizen.
To support Ethernet/3G status monitoring in IP Adapter,
Wifi Manager is replaced with Connection Manager.

Change-Id: Ie5350269c152a42267218749952ab47171b865be
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13711
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Abhishek Sharma <ce.abhishek@samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

Add copyright information

Change-Id: If6e9eea119d9a1b639d82686dec8a29aecf970fd
Signed-off-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/14005
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: David Antler <david.a.antler@intel.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

Fix tcp_adapter for CAgetNetworkInfo support to getting ifindex

Fix CAGetTCPInterfaceInformation to copy NIC index
when copy network infomation CAInterface_t to CAEndpoint_t.

Change-Id: I93b37adeb5a1c927ef8ea775bd5de7eeeb40a09d
Signed-off-by: bg.chun <bg.chun@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/14037
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

Resolve svace defect related to provisioningclient.c and pbkdf2.c

Patch 1 : fix defect on provisioningclient.c
Patch 2,3 : fix defect on pbkdf2.c
Patch 4 : Retrigger Jenkins

Change-Id: I8fb6993639efca6fa8f7bfd861a46fe26b3d6269
Signed-off-by: js126.lee <js126.lee@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/14023
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: dongik Lee <dongik.lee@samsung.com>
Reviewed-by: Chul Lee <chuls.lee@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit 60aa05472ff9e2188a391cea043c3392c2f705d2)
Reviewed-on: https://gerrit.iotivity.org/gerrit/14099

Add ifindex when check duplicated message

Add ifindex when the function CADropSecondMessage() compare
duplicated message with message ID, token, address family

Change-Id: Ida49daa92ea4e0e5e099c77aeacbad55da308d2f
Signed-off-by: bg.chun <bg.chun@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13943
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

modified BLE scanning logic to stop while is connecting.

since connection lead time have improved in stop scan state.
BLE scan should be stopped while is connecting.

Change-Id: Iefcb37c7c366efecc22ae9014615a3795ba0fdaa
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13871
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

update loop of OCProcessPresence more safer.

Change-Id: I4ab9dc9f474c57aa2da457f47e0574c370a6fd7d
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13919
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

build: Fix scons mistake (close square brackets)

Maybe squashed into:
https://gerrit.iotivity.org/gerrit/#/c/13615/

Change-Id: I139955f421d6d3e24f1986880006f34349fbe5cf
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/14079
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Habib Virji <habib.virji@samsung.com>

build: Export mbedtls defines with iotivity.pc

Change-Id: Ic15661d9300b56e93b0ae53c4d71d85430af31b8
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13965
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Dmitriy Zhuravlev <d.zhuravlev@samsung.com>
(cherry picked from commit e282030872fe4cf065b26fef5c46e95d75c4bc07)
Reviewed-on: https://gerrit.iotivity.org/gerrit/13947
Reviewed-by: Habib Virji <habib.virji@samsung.com>

Update the cred's POST request handler to accept rowner update request.

This update can handle the following payload :
   {"rowneruuid":"28516ab8-b35a-4726-a082-ee7685c33c8c"}

Change-Id: Ibee20c99ff05409fdaf44c2bdac209b871bde043
Signed-off-by: Chul Lee <chuls.lee@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13993
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jongmin Choi <jminl.choi@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit 210bfd947e151abaa37c80fd1bdad0c5b731a768)
Reviewed-on: https://gerrit.iotivity.org/gerrit/14061

[IOT-1479]
Fix excluding cloud provisioning java source file.

change WITH_CLOUD to WITH_TCP in build.gradle if switch.

Change-Id: I4e10d3a41d983303daf51e11d4c29dd31f559de1
Signed-off-by: Sandeep Sharma <sandeep.s9@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13761
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashwini Kumar <k.ashwini@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>

Function to read Trust certificate chain from SVR

Change-Id: Icfef62eca83a360dc73ecee3e3bbe7f8c5821d85
Signed-off-by: saurabh.s9 <saurabh.s9@samsung.com>
Signed-off-by: Randeep Singh <randeep.s@samsung.com>
Signed-off-by: Ashwini Kumar <k.ashwini@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/14031
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
(cherry picked from commit de505627a5bec12a0fefc3d084286b70d9309d59)
Signed-off-by: Randeep Singh <randeep.s@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13389

IOT-1476 Remove pthread from sampleserver_randompin

- Using C++ threads as a cross-platform approach
- Added .gitattributes file to ensure *.dat files are binary

Change-Id: I602649d55ee5a8e24a2215d5f68ca5897c9cc6c7
Signed-off-by: David Antler <david.a.antler@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13727
Reviewed-by: Kevin Kane <kkane@microsoft.com>
Reviewed-by: Alex Kelley <alexke@microsoft.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>

Merge 13921 and 14039 into master

Change-Id: I5b88b2c470614772340bc711e00d1253d647e164
Signed-off-by: Alex Kelley <alexke@microsoft.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/14051
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>

Fix MOT build error

Fix MOT build error due to API name change in
https://gerrit.iotivity.org/gerrit/#/c/13921/

Change-Id: I6bc0ffce1a953538c9eb73427c0e6e213b4b9e06
Signed-off-by: Jongmin Choi <jminl.choi@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/14039
Reviewed-by: Jongsung Lee <js126.lee@samsung.com>
Reviewed-by: Chul Lee <chuls.lee@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit bf74820ac803f91ee8493bede4f4a6c7a89281f0)
Reviewed-on: https://gerrit.iotivity.org/gerrit/14047

Fix Windows builds to correctly build -release tests

Change-Id: I80b4a9f09cc3278414b289b0693efb491dc00e89
Signed-off-by: Mike Fenelon <mike.fenelon@microsoft.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13791
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>

Export more functions in octbstack.dll

Some new functions needed to be exported for iotivity-node support.
This patch adds those functions, and sorts the section
alphabetically.

The following functions were added to octbstack.dll:
  - OCRepPayloadSetIntArray
  - OCRepPayloadSetBoolArray
  - OCRepPayloadSetStringArray
  - OCRepPayloadSetDoubleArray

Change-Id: I37e317c077750b78c1f992df4e7670ba9311ffab
Signed-off-by: David Antler <david.a.antler@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/14003
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Reviewed-by: Alex Kelley <alexke@microsoft.com>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>
(cherry picked from commit dbcf570b60ac6dbf2d535f6b3f2d9ce2b1bc3d55)
Reviewed-on: https://gerrit.iotivity.org/gerrit/14007

Fix DTLS backward compatibility

mbedTLS expects the close_notify message as warning alert,
but tinyDTLS sends fatal alert

Change-Id: I91046d4eb23f6b7537abe0a3a2a2e2c6c2893f14
Signed-off-by: Dmitriy Zhuravlev <d.zhuravlev@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13961
Reviewed-by: Kevin Kane <kkane@microsoft.com>
Reviewed-by: Oleksii Beketov <ol.beketov@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jongsung Lee <js126.lee@samsung.com>
Reviewed-by: Jongmin Choi <jminl.choi@samsung.com>
Reviewed-by: Chul Lee <chuls.lee@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>

Remove unused file related to ck_manager

Change-Id: Ib77dd5547d32f9bc2fc03d379f657990a8bffea6
Signed-off-by: js126.lee <js126.lee@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/14021
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>

Fix CAGetNetworkInfo support to getting ifindex

Current CAGetNetworkInfo function always set ifindex as 0.
Change logic to set ifindex parsed from platform.

Change-Id: I98d53dc0fe4a666b6c9eaf8900d1e68ee4c925f2
Signed-off-by: bg.chun <bg.chun@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13955
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jaewook Jung <jw0213.jung@samsung.com>
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

fix crash issue related resource directory in android.

there was some unsatisfiedLinkError issue of RD library.
after merge https://gerrit.iotivity.org/gerrit/#/c/13657/

Change-Id: Ib9f9fc3e14200cc9f1e97b6d04ef71fa27f7499f
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/14025
Reviewed-by: Jaewook Jung <jw0213.jung@samsung.com>
Reviewed-by: Hyuna Jo <hyuna0213.jo@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Habib Virji <habib.virji@samsung.com>

Check payload length of CoAP PDU before TLS encryption

Check payload length of CoAP PDU before TLS encryption

Change-Id: I85880aaf3b81a4ebdefe491943e22b896db1f162
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13549
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Joonghwan Lee <jh05.lee@samsung.com>
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
(cherry picked from commit 52ea58a005ffea5615af4df51958b388cfe41dd4)
Reviewed-on: https://gerrit.iotivity.org/gerrit/14013

[IOT-1400] Remove multicast presence node list in client side.

MCPresenceNode(multicast presence list) never remove.
it causes a big memory leak.
and since checking sequence number not required.
it is better to remove for simple stack logic.

Change-Id: I000772b12c88b30bd771fc759ac2ffaacedd0cc0
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13119
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: daeken kwon <daeken.kwon@samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

Add delay before OcPlatform.startPresence().

Added a two second delay before calling OcPlatform.startPresence() on the server side.
This gives the client side ample time to have the presence listener in place for expected
good behavior.

Change-Id: I0bc63b157c756abb510c3e2fb9651c3e14503b31
Signed-off-by: Larry Sachs <larry.j.sachs@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13971
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: George Nash <george.nash@intel.com>
Reviewed-by: Rick Bell <richard.s.bell@intel.com>

build: Rewrite sqlite SConscript a more portable way

Windows support should be improved.

Fixed weird indentation that looked strange
 when I was investigating if files were present in Tizen builder.

Change-Id: I80c9667a502a1115fdfbcd5ecd50b1e799ff5fdb
Bug: https://jira.iotivity.org/browse/IOT-820
Origin: https://gerrit.iotivity.org/gerrit/#/c/9641/1/
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/9653
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>

Update build scripts for changes to RD for Windows

These changes allow Windows to build correctly with
Resource Directory code. Changes from WITH_RD to RD_MODE were
introduced in early October, but the RUN.BAT file that builds
Windows was not updated, so Windows has been building with a
broken mix of RD and not RD to this point. Changes to RUN.BAT and
SCONS scripts bring Windows builds up-to-date.

Change-Id: I9ba789a11fa0ca1865822578f7da8d4a56439660
Signed-off-by: Mike Fenelon <mike.fenelon@microsoft.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13905
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>
Reviewed-by: Habib Virji <habib.virji@samsung.com>

linux: Use sqlite from system like Tizen does

It must be installed before building,
 For instance on debian and derived:
 apt-get install libsqlite3-dev

Note for later, it would make sense to move
 all those platform tests into sqlite sconfile.

Bug: https://jira.iotivity.org/browse/IOT-1296
Change-Id: I431a11821844bef8eabba30e1111b1ebf0799d66
Origin: https://gerrit.iotivity.org/gerrit/#/c/9135/
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/9135
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>

[IOT-1506] fix unsubscribe presence handler.

To set handle for unsubscribe presence is missed.

Change-Id: Ie98c10d97265e70b2b09d6fef7957e4ecb83e49b
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13917
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Larry Sachs <larry.j.sachs@intel.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

[IOT-1481] Fix app crash when stop iotivity.

When create portList, assigned port should be pointer.

Change-Id: Ie6e820ec76186fa5295ec4da384d027450dc62f4
Signed-off-by: jaehyun Cho <jaehyun3.cho@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13811
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: jihwan seo <jihwan.seo@samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

provisioning: Support older g++ (for Tizen)

It was successfully tested with gcc-4.6.4
 on Tizen:2.3.1:Wearable.

Change-Id: Ib97c4bfe73d1d40ee8a029a016b7d69e2b3e3d99
Origin: https://gerrit.iotivity.org/gerrit/#/c/12059/
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12059
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashwini Kumar <k.ashwini@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit c20fd6b9217ac3f0331ad708211d15a5e2be3120)
Reviewed-on: https://gerrit.iotivity.org/gerrit/12161

update presence sample app for android.

- enable multicast presecne in client
- start presence can be triggered for several times
  after initialize step like createResource(..).
- this change is realted to IOT-1468.
  but it's not resolve patch for that.

Change-Id: Ia896b93eb0b10386cfe87969cebd8e2b18531f45
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13799
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

[IOT-1464] Set NULL after deleting dataQueue of queueing thread

Set NULL after deleting dataQueue of queueing thread

Change-Id: Ia32df8a988503f4ef4bd01f51005102cddc1a301
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13591
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: jihwan seo <jihwan.seo@samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
(cherry picked from commit 1f75e2636e71cc0a59570fb39f97d4474d6e9c51)
Reviewed-on: https://gerrit.iotivity.org/gerrit/13839

Urgent Fix (in ocstack.c)

Fix error in ocstack.c which prevents us to Sign Up to cloud
It was appeared in next patchset
[IOT-1413,IOT-1415] Fixed request handling bugs for /oic/ping resource

Change-Id: Icf193a19107ce2cb044537f6a0a5058944c39afd
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Signed-off-by: Andrii Shtompel <a.shtompel@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13241
Reviewed-by: Kevin Kane <kkane@microsoft.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: dongik Lee <dongik.lee@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>
(cherry picked from commit de0b348a1cb56a2a04b9a7640262fe00e8c3c13b)
Reviewed-on: https://gerrit.iotivity.org/gerrit/13689
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

Added to obtain an address from a domain.

For connect to cloud using domain.

Change-Id: I3afc2f86f3b9e02bc048354cf9c209df095af21f
Signed-off-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13781
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

Resolve circular dependency for resource directory server

RD Shared Library creates a circular dependency between
resource_directory and octbstack. This patch resolves this dependency by
creating a seprating findResource part of the resource_directory.

Change-Id: I653b9130e10f22dd61f4f1bd0b6ff4c47a69606a
Signed-off-by: Habib Virji <habib.virji@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13935
Reviewed-by: Todd Malsbary <todd.malsbary@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

[IOT-1426] Clean android examples with scons clean option

Change-Id: I29d57c2759d6073c01a9f888b2f7b9930c16590e
Signed-off-by: George Nash <george.nash@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13833
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Larry Sachs <larry.j.sachs@intel.com>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>
Reviewed-by: Rick Bell <richard.s.bell@intel.com>

tizen: Only package libuuid1.so if present

As this trick is a workaround for current version of Tizen SDK,
avoid to break on failure to ship copied lib.

Change-Id: Idad5dd5ab3e24a569bffe22b1f83badb1906978f
Bug: https://jira.iotivity.org/browse/IOT-1343
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13827
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

Remove oc library dependency on resource-directory module

Remove oc library dependency on resource-directory module

Change-Id: I0ca8b791a79debf880b953794986ad81e5523338
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Signed-off-by: Habib Virji <habib.virji@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13867
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13889

Change a timeout for resource discovery in cloud provisioning

Change-Id: Id211ff2afab83cdeaaaf68162ca9d5cdbffeca8a
Signed-off-by: Parkhi <h_w.park@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13771
Reviewed-by: Harish Marappa <h.marappa@samsung.com>
Reviewed-by: Jihun Ha <jihun.ha@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

build: pkgconfig should link ocmapi too

Change-Id: Ide4901338ba919b36cf129be5ecefc6f4f71d519
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13525
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Habib Virji <habib.virji@samsung.com>
(cherry picked from commit ae4c031dd2af6f05ed18d55f2d5c196e042f9bf6)
Reviewed-on: https://gerrit.iotivity.org/gerrit/13565
Reviewed-by: Chul Lee <chuls.lee@samsung.com>

[IOT-1482] fix getPlatformInfo and getDeviceInfo of C++-SDK sample app.

cause patch : https://gerrit.iotivity.org/gerrit/#/c/12909/

Change-Id: If50cba713a67239619047ccb012678f73fb42682
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13677
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-by: Jaewook Jung <jw0213.jung@samsung.com>
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>

Use third_party_libs.scons of resource in resource-directory

resource-directory was moved to resource layer from service
layer. so third_party_libs.scons of resource should be used.

Change-Id: I9d1f06f041318443b62d78242b8bc04f77a6f4f3
Signed-off-by: Habib Virji <habib.virji@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13767
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

[IOT-1462] Generate shared library for resource directory

Generate shared library for all platforms. Require update to all example
and unittest as test uses shared library.

https://jira.iotivity.org/browse/IOT-1462

Change-Id: I9d169d8e4e08835f3e57f1771789fe5b90636da7
Signed-off-by: Habib Virji <habib.virji@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13657
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>

Update CPP Doxygen file for NS

CPP doxygen file is updated

Change-Id: I3b582956f290ea25266e183945397f6963d05fc7
Signed-off-by: cc <ch79.cho@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13757
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

DoxyGen file update.

Add Connectivity Abstraction docs.

Change-Id: If4bf501e0dcaa609c2011c40bf848552ff984450
Signed-off-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13709
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: byonggon chun <bg.chun@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Remove the rubbish code in pmutility.c

Change-Id: I7a37d7c1b5960c779b051b894c3e79c9ba9fdc50
Signed-off-by: Chul Lee <chuls.lee@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13829
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>

[IOT-1386] Update ins value after deleting resource from rd

- Support multiple ins query for deleting resource.
- Reset ins value of deleted resource.
- Enable RD build in all platforms.
- https://jira.iotivity.org/browse/IOT-1386

Change-Id: If7f19f63592ccfa6d298561da5ad173b0965d32c
Signed-off-by: Habib Virji <habib.virji@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12183
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>