borenet@google.com [Mon, 27 Jan 2014 18:08:55 +0000 (18:08 +0000)]
roll_deps.py: Make default_bots_list a module-level variable
This allows us to import the script rather than run it in a sub-shell.
BUG=skia:
R=halcanary@google.com
Review URL: https://codereview.chromium.org/
140973003
git-svn-id: http://skia.googlecode.com/svn/trunk@13200
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 27 Jan 2014 18:06:03 +0000 (18:06 +0000)]
Revert of Workaround for assertion in NVPR config in bench. (https://codereview.chromium.org/
131503007/)
Reason for revert:
broke the build.
Original issue's description:
> Workaround for assertion in NVPR config in bench.
>
> BUG=skia:2078
>
> Committed: http://code.google.com/p/skia/source/detail?r=13196
R=robertphillips@google.com
TBR=robertphillips@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:2078
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
148473002
git-svn-id: http://skia.googlecode.com/svn/trunk@13199
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 27 Jan 2014 18:05:21 +0000 (18:05 +0000)]
Revert of nvpr baselines (https://codereview.chromium.org/
132333008/)
Reason for revert:
broke the build
Original issue's description:
> nvpr baselines
>
> BUG=skia:2042
>
> Committed: https://code.google.com/p/skia/source/detail?r=13195
TBR=
NOTREECHECKS=true
NOTRY=true
BUG=skia:2042
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
148013003
git-svn-id: http://skia.googlecode.com/svn/trunk@13198
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Mon, 27 Jan 2014 17:51:12 +0000 (17:51 +0000)]
New baselines for Win7 DirectWrite (shader2 and bezier_conic) and Intel Rhb (imagefiltersbase and imageblur). All failures are pixel intensity mismatch <= 3.
BUG=skia:2085,skia:2081
TBR=epoger@google.com
Review URL: https://codereview.chromium.org/
138623007
git-svn-id: http://skia.googlecode.com/svn/trunk@13197
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 27 Jan 2014 17:36:38 +0000 (17:36 +0000)]
Workaround for assertion in NVPR config in bench.
BUG=skia:2078
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
131503007
git-svn-id: http://skia.googlecode.com/svn/trunk@13196
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Mon, 27 Jan 2014 17:04:00 +0000 (17:04 +0000)]
nvpr baselines
BUG=skia:2042
Review URL: https://codereview.chromium.org/
132333008
git-svn-id: http://skia.googlecode.com/svn/trunk@13195
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 27 Jan 2014 16:34:45 +0000 (16:34 +0000)]
Explain empty report in compare_codereview.py.
Let user know when control and roll have no common trybots, instead of
being silent.
BUG=skia:
R=borenet@google.com
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/
135683003
git-svn-id: http://skia.googlecode.com/svn/trunk@13194
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Mon, 27 Jan 2014 16:22:36 +0000 (16:22 +0000)]
Rebaseline some GPU and ANGLE results which started failing on Win7.
BUG=skia:2081
TBR=epoger@google.com
Review URL: https://codereview.chromium.org/
135593005
git-svn-id: http://skia.googlecode.com/svn/trunk@13193
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 27 Jan 2014 15:41:07 +0000 (15:41 +0000)]
add optional SkAlphaType parameter to notifyPixelsChanged
R=scroggo@google.com, halcanary@google.com, robertphillips@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/
147213002
git-svn-id: http://skia.googlecode.com/svn/trunk@13192
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Mon, 27 Jan 2014 15:05:39 +0000 (15:05 +0000)]
Remove misc. suppressions from ignored-tests.txt added in https://codereview.chromium.org/
105893003. These tests were rebaselined shortly after that patch landed, but the suppressions weren't removed, so differences have snuck in and not been rebaselined.
New Android baselines for imagefiltersgraph, imagefilterscropped, imagefiltersbase, imageblur GMs.
New Nexus4 baselines for testimagefilters, spritebitmap GM.
R=borenet@google.com
TBR=borenet, bungeman
BUG=skia:
Review URL: https://codereview.chromium.org/
141033008
git-svn-id: http://skia.googlecode.com/svn/trunk@13191
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 27 Jan 2014 13:42:58 +0000 (13:42 +0000)]
fix more 64bit warnings
BUG=skia:
Review URL: https://codereview.chromium.org/
147683003
git-svn-id: http://skia.googlecode.com/svn/trunk@13190
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 27 Jan 2014 13:41:02 +0000 (13:41 +0000)]
remove SkScalarMul from public headers
BUG=skia:
Review URL: https://codereview.chromium.org/
132453008
git-svn-id: http://skia.googlecode.com/svn/trunk@13189
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Sun, 26 Jan 2014 20:51:00 +0000 (20:51 +0000)]
Add NVPR configs to bench
BUG=skia:2042
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
145943003
git-svn-id: http://skia.googlecode.com/svn/trunk@13188
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Sun, 26 Jan 2014 18:07:40 +0000 (18:07 +0000)]
Add NVPR configs to GM
BUG=skia:2042
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
139803003
git-svn-id: http://skia.googlecode.com/svn/trunk@13187
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Sun, 26 Jan 2014 17:51:22 +0000 (17:51 +0000)]
rebaselines from NVPR enable and nexus4 blur radius
BUG=skia:2042
Review URL: https://codereview.chromium.org/
146593003
git-svn-id: http://skia.googlecode.com/svn/trunk@13186
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Sun, 26 Jan 2014 07:01:45 +0000 (07:01 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@13185
2bbb7eff-a529-9590-31e7-
b0007b416f81
tfarina@chromium.org [Sat, 25 Jan 2014 18:45:45 +0000 (18:45 +0000)]
Remove unused methods from SkWindow.
I came to this while grepping for deprecated SkBitmap's eraseRGB()
method.
BUG=None
TEST=SampleApp still links
R=reed@google.com, robertphillips@google.com
Review URL: https://codereview.chromium.org/
147433002
git-svn-id: http://skia.googlecode.com/svn/trunk@13184
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Sat, 25 Jan 2014 16:54:31 +0000 (16:54 +0000)]
add alternative to isRect named asRect
This defines yunchao's proposed interface in terms of
an existing implementation.
BUG=skia:
R=reed@google.com, yunchao.he@intel.com
Author: caryclark@google.com
Review URL: https://codereview.chromium.org/
140953003
git-svn-id: http://skia.googlecode.com/svn/trunk@13183
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Sat, 25 Jan 2014 16:46:20 +0000 (16:46 +0000)]
add legacy/helper allocN32Pixels, and convert gm to use it
This is an intermediate api, but might help us quickly get to a point where
no one is creating bitmaps in a 2-step process (setConfig + alloc).
BUG=skia:
R=halcanary@google.com
Review URL: https://codereview.chromium.org/
140593005
git-svn-id: http://skia.googlecode.com/svn/trunk@13182
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Sat, 25 Jan 2014 07:01:49 +0000 (07:01 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@13181
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 24 Jan 2014 22:38:39 +0000 (22:38 +0000)]
SkOnce: add option to call another cleanup function once at exit.
Use this to clean up empty SkData and SkPathRef.
Current leaks:
Leaked SkRefCntBase: 40
Leaked SkFlattenable: 32
Leaked SkPixelRef: 32
Leaked SkMallocPixelRef: 32
Leaked SkFontConfigInterface: 1
Leaked SkWeakRefCnt: 1
Leaked SkTypeface: 1
Leaked SkFontMgr: 1
Leaked SkDataTable: 3
Leaked SkImage: 1
Leaked ???: 1
Leaked ???: 1
BUG=skia:
R=halcanary@google.com, reed@google.com
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/
132803005
git-svn-id: http://skia.googlecode.com/svn/trunk@13180
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 24 Jan 2014 21:50:03 +0000 (21:50 +0000)]
Updates bench expectations; adds new platforms.
BUG=skia:
R=borenet@google.com, robertphillips@google.com
Author: bensong@google.com
Review URL: https://codereview.chromium.org/
131343009
git-svn-id: http://skia.googlecode.com/svn/trunk@13179
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 24 Jan 2014 21:46:29 +0000 (21:46 +0000)]
fix (some) 64bit warnings -- size_t -> int
BUG=skia:
R=mtklein@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/
147053003
git-svn-id: http://skia.googlecode.com/svn/trunk@13178
2bbb7eff-a529-9590-31e7-
b0007b416f81
tfarina@chromium.org [Fri, 24 Jan 2014 20:56:26 +0000 (20:56 +0000)]
Cleanup: Sanitize the order of includes under tests/
Initially this was to make sure Test.h appeared after the Sk*.h includes.
Patch generated by the following command line:
$ ~/chromium/src/tools/sort-headers.py tests/*.cpp
BUG=None
TEST=tests
R=robertphillips@google.com
Review URL: https://codereview.chromium.org/
145313004
git-svn-id: http://skia.googlecode.com/svn/trunk@13177
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 24 Jan 2014 20:49:44 +0000 (20:49 +0000)]
Turn NVPR on by default (but off in tools).
BUG=skia:2042
Committed: http://code.google.com/p/skia/source/detail?r=13164
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
144003006
git-svn-id: http://skia.googlecode.com/svn/trunk@13176
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 24 Jan 2014 19:25:39 +0000 (19:25 +0000)]
Add a sample doc in markdown format.
BUG=skia:
R=epoger@google.com, halcanary@google.com, borenet@google.com, jcgregorio@google.com, bungeman@google.com
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/
146943002
git-svn-id: http://skia.googlecode.com/svn/trunk@13175
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Fri, 24 Jan 2014 18:53:42 +0000 (18:53 +0000)]
add installPixels
BUG=skia:
R=halcanary@google.com
Review URL: https://codereview.chromium.org/
143073008
git-svn-id: http://skia.googlecode.com/svn/trunk@13174
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 24 Jan 2014 18:48:00 +0000 (18:48 +0000)]
Revert of Use SkMScalar as intermediates in SkMatrix44::setConcat. (https://codereview.chromium.org/
146823002/)
Reason for revert:
This will break many Chromium tests when we roll.
Original issue's description:
> Use SkMScalar as intermediates in SkMatrix44::setConcat.
>
> BUG=skia:
>
> Committed: http://code.google.com/p/skia/source/detail?r=13167
R=reed@google.com
TBR=reed@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/
147033002
git-svn-id: http://skia.googlecode.com/svn/trunk@13173
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 24 Jan 2014 18:34:11 +0000 (18:34 +0000)]
new tool: download all GM images for a given builder, ready for skdiff
BUG=skia:1919
R=rmistry@google.com, bsalomon@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
143653006
git-svn-id: http://skia.googlecode.com/svn/trunk@13172
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 24 Jan 2014 18:33:07 +0000 (18:33 +0000)]
Resolve a few memory leaks in tests.
Purge the global scaled image cache after use in tests. The cache was
right to hold on to the pixels indefinitely, but this change makes it
easier to run down actual memory leaks.
Add SK_DECLARE_INST_COUNT to several classes.
BUG=skia:
R=reed@google.com
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/
145443004
git-svn-id: http://skia.googlecode.com/svn/trunk@13171
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 24 Jan 2014 18:28:35 +0000 (18:28 +0000)]
make GM self-test run gm/rebaseline_server unittests
R=borenet@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
143983017
git-svn-id: http://skia.googlecode.com/svn/trunk@13170
2bbb7eff-a529-9590-31e7-
b0007b416f81
halcanary@google.com [Fri, 24 Jan 2014 16:04:09 +0000 (16:04 +0000)]
Revert "Turn NVPR on by default (but off in tools)."
This reverts commit
83d81c96de34950bdd84dc575997a250b685a3d6.
Broke Windows build. Autorevert didn't work.
TBR=bsalomon@google.com,robertphillips@google.com
NOTREECHECKS=true
NOTRY=true
NOPRESUBMIT=true
BUG=skia:2042
Review URL: https://codereview.chromium.org/
146863003
git-svn-id: http://skia.googlecode.com/svn/trunk@13169
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Fri, 24 Jan 2014 15:43:50 +0000 (15:43 +0000)]
[Reland of r13154, since the Housekeeping bot seems to have reverted it in r13155. Next time I'll put the "do not disturb" sign on my commit.]
Refactor SkMorphologyImageFilter, CPU and GPU paths. This required making opts/ dependent on effects/, so that we could use the SkMorphologyProc type in SkMorphologyImageFilter.h.
Correctness and performance covered by existing tests; no change in functionality.
R=bsalomon@google.com, djsollen@google.com, reed@google.com
Committed: https://code.google.com/p/skia/source/detail?r=13154
BUG=skia:
Review URL: https://codereview.chromium.org/
135013004
git-svn-id: http://skia.googlecode.com/svn/trunk@13168
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 24 Jan 2014 15:30:46 +0000 (15:30 +0000)]
Use SkMScalar as intermediates in SkMatrix44::setConcat.
BUG=skia:
R=reed@google.com
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/
146823002
git-svn-id: http://skia.googlecode.com/svn/trunk@13167
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Fri, 24 Jan 2014 15:02:11 +0000 (15:02 +0000)]
Add new baselines for imagefiltersscaled GM.
TBR=borenet
Review URL: https://codereview.chromium.org/
145993005
git-svn-id: http://skia.googlecode.com/svn/trunk@13166
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 24 Jan 2014 14:38:27 +0000 (14:38 +0000)]
Add factory class for generating various flavors of GrTextContext.
This is the first pass of making Gr*TextContext more generic and easily
subclassed. The next stage will be making GrBitmapTextContext and
GrDistanceFieldTextContext more similar by moving the SkDraw loop into
each subclass.
BUG=skia:2018
Committed: http://code.google.com/p/skia/source/detail?r=13142
R=bsalomon@google.com, reed@google.com
Author: jvanverth@google.com
Review URL: https://codereview.chromium.org/
144283002
git-svn-id: http://skia.googlecode.com/svn/trunk@13165
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 24 Jan 2014 14:38:13 +0000 (14:38 +0000)]
Turn NVPR on by default (but off in tools).
BUG=skia:2042
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
144003006
git-svn-id: http://skia.googlecode.com/svn/trunk@13164
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 24 Jan 2014 12:39:25 +0000 (12:39 +0000)]
modify authors file format to use python fnmatch
BUG=skia:2060
R=rmistry@google.com
Author: hcm@google.com
Review URL: https://codereview.chromium.org/
145963002
git-svn-id: http://skia.googlecode.com/svn/trunk@13163
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Thu, 23 Jan 2014 23:34:38 +0000 (23:34 +0000)]
Rebaselines for r13156.
There seems to be an issue where expectations are missing from storage.
Either they didn't actually upload, we pointed at the wrong one.
git-svn-id: http://skia.googlecode.com/svn/trunk@13162
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Thu, 23 Jan 2014 23:25:19 +0000 (23:25 +0000)]
Rebaselines for r13156.
The thing blurred in imageblur is actually text.
Who knew?
git-svn-id: http://skia.googlecode.com/svn/trunk@13161
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Thu, 23 Jan 2014 22:26:04 +0000 (22:26 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@13160
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Thu, 23 Jan 2014 22:24:41 +0000 (22:24 +0000)]
Rebaselines for r13156.
These are for affected baselines which are now failing,
but the expected image appears to be unavailable.
git-svn-id: http://skia.googlecode.com/svn/trunk@13159
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Thu, 23 Jan 2014 22:19:16 +0000 (22:19 +0000)]
Rebaseline for r13156.
git-svn-id: http://skia.googlecode.com/svn/trunk@13158
2bbb7eff-a529-9590-31e7-
b0007b416f81
tfarina@chromium.org [Thu, 23 Jan 2014 21:30:43 +0000 (21:30 +0000)]
Remove unused SampleTests.cpp source file.
We never compile this file.
BUG=None
TEST=tests
R=reed@google.com, robertphillips@google.com
Review URL: https://codereview.chromium.org/
143823016
git-svn-id: http://skia.googlecode.com/svn/trunk@13157
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Thu, 23 Jan 2014 19:01:36 +0000 (19:01 +0000)]
Clarify kAutohinting is kForceAutohinting.
BUG=skia:2047
R=reed@google.com
Review URL: https://codereview.chromium.org/
139943004
git-svn-id: http://skia.googlecode.com/svn/trunk@13156
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Thu, 23 Jan 2014 18:48:56 +0000 (18:48 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@13155
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Thu, 23 Jan 2014 18:45:23 +0000 (18:45 +0000)]
Refactor SkMorphologyImageFilter, CPU and GPU paths. This required making opts/ dependent on effects/, so that we could use the SkMorphologyProc type in SkMorphologyImageFilter.h.
Correctness and performance covered by existing tests; no change in functionality.
R=bsalomon@google.com, djsollen@google.com, reed@google.com
Review URL: https://codereview.chromium.org/
135013004
git-svn-id: http://skia.googlecode.com/svn/trunk@13154
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 23 Jan 2014 18:42:31 +0000 (18:42 +0000)]
Add a suppressions file for leak sanitizer.
LeakSanitizer is built into AddressSanitizer, and runs with no extra speed
penalty. Most interestingly, it's got a lock-free allocator, so it doesn't
bottleneck threaded code.
This file is enough to supress all leak warnings except from the Nvidia driver
on my desktop for tests and dm. Looks like lsan doesn't or can't pay attention
to leaked globals (-fno-common doesn't affect this).
BUG=skia:
R=robertphillips@google.com
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/
145033010
git-svn-id: http://skia.googlecode.com/svn/trunk@13153
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 23 Jan 2014 17:21:28 +0000 (17:21 +0000)]
Upstream Android Changes from K release
R=scroggo@google.com
Author: djsollen@google.com
Review URL: https://codereview.chromium.org/
145233002
git-svn-id: http://skia.googlecode.com/svn/trunk@13152
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 23 Jan 2014 17:21:19 +0000 (17:21 +0000)]
add leaks flag to show unref'd insts
Leaks are shown optionally instead of always for tests, gm, and bench.
The current display does not show actual leaks necessarily, but
shows global objects that were not deleted when the test ended.
To enable the end-of-run leak display, pass --leaks or -l.
BUG=skia:
R=mtklein@google.com
Author: caryclark@google.com
Review URL: https://codereview.chromium.org/
143943009
git-svn-id: http://skia.googlecode.com/svn/trunk@13151
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Thu, 23 Jan 2014 15:22:42 +0000 (15:22 +0000)]
Basic support for vector FON.
This change gives vector FON fonts slightly better support than bitmap
FON fonts which we already have some support for.
This also fixes the calculation of the y component of advances for
bitmap and vector FON glyphs.
git-svn-id: http://skia.googlecode.com/svn/trunk@13150
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 23 Jan 2014 15:16:05 +0000 (15:16 +0000)]
No deduping dictionaries for matrices and regions.
There's little benefit to deduping matrices and regions: they're infrequently
used, and doubly infrequently reused. Their use-weighted byte cost is tiny.
There is some downside to deduping matrices and regions. Even when they're not
used, we prepare dictionaries for deduping them for every picture. Each of
these dictionaries costs 160 bytes, so two unused dictionaries make a big chunk
of the ~1100 bytes it takes to allocate an SkPictureRecord. (~330 come from
parent class SkCanvas, 768 from SkPictureRecord itself, here reduced to 448).
One side benefit of not deduping these guys is that the change weighs -140 lines of code.
It may go without saying, but this breaks the picture format.
Testing: out/Debug/tests && out/Debug/dm (which runs all picture modes by default)
BUG=skia:1850
R=reed@google.com, bensong@google.com, robertphillips@google.com
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/
143883006
git-svn-id: http://skia.googlecode.com/svn/trunk@13149
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 23 Jan 2014 14:30:21 +0000 (14:30 +0000)]
Remove extraneous folders from includes.
R=reed@google.com, bsalomon@google.com, mtklein@google.com
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/
145203003
git-svn-id: http://skia.googlecode.com/svn/trunk@13148
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 23 Jan 2014 13:53:12 +0000 (13:53 +0000)]
Both gears and snow should detect if Path is available, and also report on the console if present.
BUG=skia:
R=robertphillips@google.com
Author: jcgregorio@google.com
Review URL: https://codereview.chromium.org/
143743004
git-svn-id: http://skia.googlecode.com/svn/trunk@13147
2bbb7eff-a529-9590-31e7-
b0007b416f81
tfarina@chromium.org [Thu, 23 Jan 2014 02:02:57 +0000 (02:02 +0000)]
Remove more unnamed namespace usages.
Skia prefers 'static' over 'unnamed' namespaces.
BUG=None
TEST=skgpu and tools
R=robertphillips@google.com, bsalomon@google.com
Review URL: https://codereview.chromium.org/
139743010
git-svn-id: http://skia.googlecode.com/svn/trunk@13146
2bbb7eff-a529-9590-31e7-
b0007b416f81
mike@reedtribe.org [Thu, 23 Jan 2014 02:02:45 +0000 (02:02 +0000)]
remove SkScalarMul macro
git-svn-id: http://skia.googlecode.com/svn/trunk@13145
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 22 Jan 2014 22:57:19 +0000 (22:57 +0000)]
Chromium Codereview Comparison Script.
This script takes two Codereview URLs, looks at the trybot results for
the two codereviews and compares the results.
Motivation: This should speed up the DEPS roll procedure.
BUG=skia:2039
R=robertphillips@google.com, borenet@google.com
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/
143503003
git-svn-id: http://skia.googlecode.com/svn/trunk@13144
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 22 Jan 2014 22:01:41 +0000 (22:01 +0000)]
Revert of Add factory class for generating various flavors of GrTextContext. (https://codereview.chromium.org/
144283002/)
Reason for revert:
Breaks Chrome. Need to fix template issue.
Original issue's description:
> Add factory class for generating various flavors of GrTextContext.
>
> This is the first pass of making Gr*TextContext more generic and easily
> subclassed. The next stage will be making GrBitmapTextContext and
> GrDistanceFieldTextContext more similar by moving the SkDraw loop into
> each subclass.
>
> BUG=skia:2018
>
> Committed: http://code.google.com/p/skia/source/detail?r=13142
R=bsalomon@google.com, reed@google.com
TBR=bsalomon@google.com, reed@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:2018
Author: jvanverth@google.com
Review URL: https://codereview.chromium.org/
145023006
git-svn-id: http://skia.googlecode.com/svn/trunk@13143
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 22 Jan 2014 21:37:03 +0000 (21:37 +0000)]
Add factory class for generating various flavors of GrTextContext.
This is the first pass of making Gr*TextContext more generic and easily
subclassed. The next stage will be making GrBitmapTextContext and
GrDistanceFieldTextContext more similar by moving the SkDraw loop into
each subclass.
BUG=skia:2018
R=bsalomon@google.com, reed@google.com
Author: jvanverth@google.com
Review URL: https://codereview.chromium.org/
144283002
git-svn-id: http://skia.googlecode.com/svn/trunk@13142
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 22 Jan 2014 14:43:47 +0000 (14:43 +0000)]
Remove GetGr() hack.
It seems no GM are using this.
BUG=None
TEST=SampleApp
R=bsalomon@google.com, caryclark@google.com
Author: tfarina@chromium.org
Review URL: https://codereview.chromium.org/
144543003
git-svn-id: http://skia.googlecode.com/svn/trunk@13141
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 22 Jan 2014 14:37:08 +0000 (14:37 +0000)]
update mesa version mapping to GL version
mesa3d have updated to 10.0 to support OpenGL 3.3, see http://www.mesa3d.org/index.html. At least Intel has implemented mesa 10.0 on IA.
BUG=None
R=bsalomon@google.com
Author: yunchao.he@intel.com
Review URL: https://codereview.chromium.org/
143803012
git-svn-id: http://skia.googlecode.com/svn/trunk@13140
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Wed, 22 Jan 2014 07:01:54 +0000 (07:01 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@13139
2bbb7eff-a529-9590-31e7-
b0007b416f81
tfarina@chromium.org [Tue, 21 Jan 2014 23:39:22 +0000 (23:39 +0000)]
Remove unnamed namespace usage from tests/
Skia preference is to use 'static' keyword rather than use unnamed
namespace.
BUG=None
TEST=tests
R=robertphillips@google.com, bsalomon@google.com
Review URL: https://codereview.chromium.org/
132403008
git-svn-id: http://skia.googlecode.com/svn/trunk@13138
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 21 Jan 2014 21:38:49 +0000 (21:38 +0000)]
Add reviewers to roll_deps.py, remove linux_heapcheck bot
The --reviewers and --cc are disabled for now, while we work on the workflow.
BUG=skia:
R=robertphillips@google.com
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/
143903005
git-svn-id: http://skia.googlecode.com/svn/trunk@13137
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 21 Jan 2014 20:48:46 +0000 (20:48 +0000)]
Remove a stray setReserve that causes dynamic allocation in picture creation.
This brings us down to about 10 calls to malloc per picture.
No measurable change in bench_record or bench_pictures.
BUG=
R=reed@google.com
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/
132693009
git-svn-id: http://skia.googlecode.com/svn/trunk@13136
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 21 Jan 2014 20:03:09 +0000 (20:03 +0000)]
Rename Logan skimage expectations: .jon -> .json
BUG=skia:
R=scroggo@google.com
Author: borenet@google.com
Review URL: https://codereview.chromium.org/
144253002
git-svn-id: http://skia.googlecode.com/svn/trunk@13135
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 21 Jan 2014 19:48:47 +0000 (19:48 +0000)]
Add comment at top of freetype.gyp.
This tells VI to use colors when viewing.
R=djsollen@google.com
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/
138123007
git-svn-id: http://skia.googlecode.com/svn/trunk@13134
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Tue, 21 Jan 2014 17:40:48 +0000 (17:40 +0000)]
really really fix iOS build.
Review URL: https://codereview.chromium.org/
132693007
git-svn-id: http://skia.googlecode.com/svn/trunk@13133
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Tue, 21 Jan 2014 16:52:48 +0000 (16:52 +0000)]
Really fix ios build?
Review URL: https://codereview.chromium.org/
144063003
git-svn-id: http://skia.googlecode.com/svn/trunk@13132
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Tue, 21 Jan 2014 16:35:56 +0000 (16:35 +0000)]
Fix ios build?
Review URL: https://codereview.chromium.org/
134083009
git-svn-id: http://skia.googlecode.com/svn/trunk@13131
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 21 Jan 2014 16:09:18 +0000 (16:09 +0000)]
Move GrGLInterface function pointers into a nested struct
BUG=skia:2042
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
133073009
git-svn-id: http://skia.googlecode.com/svn/trunk@13130
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 21 Jan 2014 15:11:02 +0000 (15:11 +0000)]
Scope our ANNOTATE_BENIGN_RACE.
This should unstick the DEPS roll. When building with TSAN, Chromium's pulling
in the canonical one from dynamic_annotations.h, and we're trying to redefine it.
R=robertphillips@google.com, reed@google.com, bsalomon@google.com
TBR=reed@google.com
BUG=
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/
144063002
git-svn-id: http://skia.googlecode.com/svn/trunk@13129
2bbb7eff-a529-9590-31e7-
b0007b416f81
borenet@google.com [Tue, 21 Jan 2014 14:25:35 +0000 (14:25 +0000)]
Whitepspace change to verify that the bots are working
This CL caused some buildslaves to fail to UpdateScripts:
https://skia.googlesource.com/buildbot/+/
6707360ca6f76ae383ac7558015fb94f4d12577c
Review URL: https://codereview.chromium.org/
144073002
git-svn-id: http://skia.googlecode.com/svn/trunk@13128
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Mon, 20 Jan 2014 19:58:28 +0000 (19:58 +0000)]
Apply the CTM to filter parameters for SkBlurImageFilter, SkDropShadowImageFilter, SkDisplacementMapEffect and SkMorphologyImageFilter. I had resisted this (and may later put in an assert that the CTM contains no rotation, skew or perspective), but it just makes the filters play better with Skia generally.
This revealed that the displacement map was not handling clipping or upstream cropping at all well (the color would "swim" through the displacement at the edge of the clip rect). Fixed by passing through the correct offsets to the bitmap accesses in both raster and GPU paths. Same for morphology.
R=sugoi@google.com
Review URL: https://codereview.chromium.org/
137053003
git-svn-id: http://skia.googlecode.com/svn/trunk@13127
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Mon, 20 Jan 2014 16:14:02 +0000 (16:14 +0000)]
Allow an override of MACOSX_DEPLOYMENT_TARGET, so the user can build against a different SDK if desired.
R=mtklein@google.com, bungeman, mtklein
Review URL: https://codereview.chromium.org/
138033018
git-svn-id: http://skia.googlecode.com/svn/trunk@13126
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Fri, 17 Jan 2014 20:33:09 +0000 (20:33 +0000)]
Fix utils.gyp missing file
TBR=robertphillips@google.com
Review URL: https://codereview.chromium.org/
142043003
git-svn-id: http://skia.googlecode.com/svn/trunk@13125
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 17 Jan 2014 20:16:05 +0000 (20:16 +0000)]
ignore some verylargebitmap errors
BUG=skia:1978
NOTREECHECK=True
NOTRY=True
R=senorblanco@google.com
TBR=senorblanco
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
140643003
git-svn-id: http://skia.googlecode.com/svn/trunk@13124
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 17 Jan 2014 17:56:21 +0000 (17:56 +0000)]
Speed up GrResourceCache add and lookup by using TDynamicHash
Speed up GrResourceCache add and lookup by using TDynamicHash instead
of GrTHashTable. GrTHashTable spends most of its time memmoving the
array elements while sorting after an add. Lookup is not particularly
fast either.
R=mtklein@google.com, bsalomon@google.com, reed@google.com
Author: kkinnunen@nvidia.com
Review URL: https://codereview.chromium.org/
91453002
git-svn-id: http://skia.googlecode.com/svn/trunk@13122
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 17 Jan 2014 17:55:14 +0000 (17:55 +0000)]
Tweak validate() to check less as the size of the hash grows.
This makes working with a non-trivial SkTDynamicHash less painful in Debug
builds. validate() is skipped in Release, so this has no effect there.
BUG=
R=kkinnunen@nvidia.com, bsalomon@google.com
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/
140753003
git-svn-id: http://skia.googlecode.com/svn/trunk@13121
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 17 Jan 2014 17:55:02 +0000 (17:55 +0000)]
Make leak counters thread-safe and turn them on by default for Debug
Make leak counters implemented with SK_DECLARE_INST_COUNT thread-safe.
Enable the leak counting for Debug builds when Skia is built as a
static library. Having SK_DECLARE_INST_COUNT without
SK_DEFINE_INST_COUNT relies on static variables in member functions
declared in the header files. These might be duplicated in the clients
of the library when Skia is built as a dynamic library, producing
incorrect operation.
Protect the instance counter initialization step (initStep) by
using SkOnce.
Makes SkOnce.h part of the public API, since SkInstCnt is public.
Protect the per-class child list shared variable with a per-class mutex.
Changes the behavior in the way that if the child list has been
"cleaned up", it will still try to create subsequent child lists.
BUG=skia:1219
R=robertphillips@google.com, mtklein@google.com, bsalomon@google.com, bungeman@google.com, djsollen@google.com
Author: kkinnunen@nvidia.com
Review URL: https://codereview.chromium.org/
99483003
git-svn-id: http://skia.googlecode.com/svn/trunk@13120
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 17 Jan 2014 16:59:03 +0000 (16:59 +0000)]
Adding SK_API to SkGLContextHelper and SkNullGLContext for use in blink unit test component build
BUG=skia:
R=bsalomon@chromium.org
Author: junov@chromium.org
Review URL: https://codereview.chromium.org/
141813002
git-svn-id: http://skia.googlecode.com/svn/trunk@13119
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 17 Jan 2014 15:05:38 +0000 (15:05 +0000)]
Move GrGLExtensions from GrGLContextInfo to GrGLInterface
BUG=skia:2042
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
140823003
git-svn-id: http://skia.googlecode.com/svn/trunk@13118
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 17 Jan 2014 15:00:14 +0000 (15:00 +0000)]
Add AUTHORS file for copyright tracking
BUG=skia:
R=jcgregorio@google.com, rmistry@google.com
Author: hcm@google.com
Review URL: https://codereview.chromium.org/
138413004
git-svn-id: http://skia.googlecode.com/svn/trunk@13117
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 16 Jan 2014 22:54:41 +0000 (22:54 +0000)]
Adding SkPictureImageFilter to the fuzzer
BUG=skia:
R=senorblanco@google.com, senorblanco@chromium.org, sugoi@google.com
Author: sugoi@chromium.org
Review URL: https://codereview.chromium.org/
140993004
git-svn-id: http://skia.googlecode.com/svn/trunk@13116
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 16 Jan 2014 20:49:46 +0000 (20:49 +0000)]
Remove GR_GL_IGNORE_ES3_MSAA.s
R=jvanverth@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
140933005
git-svn-id: http://skia.googlecode.com/svn/trunk@13115
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 16 Jan 2014 19:48:33 +0000 (19:48 +0000)]
Clear the canvas before drawing the gears.
BUG=skia:
R=robertphillips@google.com
Author: jcgregorio@google.com
Review URL: https://codereview.chromium.org/
141113002
git-svn-id: http://skia.googlecode.com/svn/trunk@13114
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 16 Jan 2014 19:48:19 +0000 (19:48 +0000)]
Make tools/submit_try safer
Using proc.wait() in combination with PIPE doesn't seem
to be safe for large patches according to
http://docs.python.org/2/library/subprocess.html.
Moving to proc.communicate().
Signed-off-by: Kévin PETIT <kevin.petit@arm.com>
BUG=skia:
R=djsollen@google.com, borenet@google.com
Author: kevin.petit.arm@gmail.com
Review URL: https://codereview.chromium.org/
141023003
git-svn-id: http://skia.googlecode.com/svn/trunk@13113
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 16 Jan 2014 18:49:01 +0000 (18:49 +0000)]
Allow GrGLInterface factories in Chromium to continue to compile.
BUG=skia:2042
TBR=jvanverth@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
136573003
git-svn-id: http://skia.googlecode.com/svn/trunk@13112
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 16 Jan 2014 18:39:04 +0000 (18:39 +0000)]
Make GrGLContextInfo have private ptr to GrGLInterface
BUG=skia:2042
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
140843003
git-svn-id: http://skia.googlecode.com/svn/trunk@13111
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 16 Jan 2014 18:16:37 +0000 (18:16 +0000)]
Missing #include "SkTemplates.h" for SkAutoTMalloc.
BUG=
R=halcanary@google.com
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/
137783021
git-svn-id: http://skia.googlecode.com/svn/trunk@13110
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Thu, 16 Jan 2014 17:51:07 +0000 (17:51 +0000)]
quick fix for r13108
BUG=skia:2042
NOTREECHECKS
NOTRY
TBR=robertphillips@google.com
Review URL: https://codereview.chromium.org/
135313004
git-svn-id: http://skia.googlecode.com/svn/trunk@13109
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 16 Jan 2014 16:35:09 +0000 (16:35 +0000)]
Rename GrGLBinding->GrGLStandard, no longer a bitfield
BUG=skia:2042
R=jvanverth@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
133413003
git-svn-id: http://skia.googlecode.com/svn/trunk@13108
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 16 Jan 2014 15:47:06 +0000 (15:47 +0000)]
Hide bitmap rowbyes assert when LEGACY_ONLOCKPIXELS
Motivation: without this, we break Blink.
BUG=skia:
NOTREECHECKS=true
NOTRY=true
R=robertphillips@google.com
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/
140903002
git-svn-id: http://skia.googlecode.com/svn/trunk@13107
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 16 Jan 2014 14:46:16 +0000 (14:46 +0000)]
SK_API SkMallocPixelRef
Motivation: make https://codereview.chromium.org/
138393002/ work.
R=reed@google.com, djsollen@google.com, bsalomon@google.com
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/
135853019
git-svn-id: http://skia.googlecode.com/svn/trunk@13106
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Thu, 16 Jan 2014 07:01:48 +0000 (07:01 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@13105
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 15 Jan 2014 23:09:01 +0000 (23:09 +0000)]
Move SkMessageBus::Get out of header, and retry crrev.com/
106563002.
BUG=
R=bsalomon@google.com, kkinnunen@nvidia.com
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/
140053002
git-svn-id: http://skia.googlecode.com/svn/trunk@13104
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 15 Jan 2014 22:24:58 +0000 (22:24 +0000)]
Factor out UnPreMultiplyPreservingByteOrder
BUG=
R=reed@google.com
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/
130303005
git-svn-id: http://skia.googlecode.com/svn/trunk@13103
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 15 Jan 2014 21:39:18 +0000 (21:39 +0000)]
Use MACOSX_DEPLOYMENT_TARGET instead of SDKROOT.
MACOSX_DEPLOYMENT_TARGET is the minimum unconditionally supported OS,
which should just be 10.6 for us until Chrome changes. SDKROOT is the
maximum conditionally supported OS, which defaults sanely to whatever's
the latest SDK the machine has, so we don't need to mention it.
BUG=skia:
R=bungeman@google.com
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/
137793010
git-svn-id: http://skia.googlecode.com/svn/trunk@13102
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 15 Jan 2014 21:28:25 +0000 (21:28 +0000)]
DM: don't change byte order when unpremultiplying to compare to PNGs.
We've already decoded the PNGs themselves into unpremultiplied bitmaps with native byte order. SkColor is just not the right choice unless you get lucky.
dm -w /tmp/dm && dm -r /tmp/dm still works on Linux, and it's much closer to working on Mac:
0 tasks left, 2 failed
Failures:
matrixconvolution_gpu
colormatrix_gpu
BUG=skia:
R=reed@google.com
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/
139943002
git-svn-id: http://skia.googlecode.com/svn/trunk@13101
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 15 Jan 2014 20:35:54 +0000 (20:35 +0000)]
render_pictures: adjust unittests to show specific failures
BUG=skia:2043,skia:2044
R=rmistry@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
139383004
git-svn-id: http://skia.googlecode.com/svn/trunk@13100
2bbb7eff-a529-9590-31e7-
b0007b416f81
projects / platform / upstream / libSkiaSharp.git / log