commit-bot@chromium.org [Thu, 29 May 2014 04:04:54 +0000 (04:04 +0000)]
whitespace change to trigger buildbots and get all GM images uploaded
NOTREECHECKS=True
NOTRY=True
R=bsalomon@google.com
TBR=bsalomon
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
304823003
git-svn-id: http://skia.googlecode.com/svn/trunk@14945
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 29 May 2014 01:12:10 +0000 (01:12 +0000)]
separate view matrix from rt adjustment
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
299943002
git-svn-id: http://skia.googlecode.com/svn/trunk@14944
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 29 May 2014 01:03:18 +0000 (01:03 +0000)]
git cl dcommit# Enter a description of the change.
shadertext2 rebaselines
TBR=
NOTRY=True
NOTREECHECKS=True
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
305853002
git-svn-id: http://skia.googlecode.com/svn/trunk@14943
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 28 May 2014 22:47:26 +0000 (22:47 +0000)]
Add sk_memcpy32 to Memcpy bench.
The bench predates the implementation in SkUtils, but now that we've got it of course we want to measure our actual implementation.
BUG=skia:
R=reed@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
302763006
git-svn-id: http://skia.googlecode.com/svn/trunk@14942
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 28 May 2014 22:42:31 +0000 (22:42 +0000)]
Shut up windows build errors on new GM
BUG=skia:
R=mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
300973005
git-svn-id: http://skia.googlecode.com/svn/trunk@14941
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 28 May 2014 21:52:12 +0000 (21:52 +0000)]
make new blurrect GM and replace the dozens of existing ones
BUG=
NOTRY=True
R=reed@google.com, epoger@google.com
Author: humper@google.com
Review URL: https://codereview.chromium.org/
306583007
git-svn-id: http://skia.googlecode.com/svn/trunk@14940
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 28 May 2014 21:44:05 +0000 (21:44 +0000)]
Set the default discardable pool size for Android framework.
BUG=skia:2389
R=halcanary@google.com
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/
303893002
git-svn-id: http://skia.googlecode.com/svn/trunk@14939
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 28 May 2014 21:43:59 +0000 (21:43 +0000)]
Spin off just SkLazyFnPtr from
305513002.
The memory barrier in SkOnce is a perf regression for sk_mem{set,cpy} in
SkUtils on ARM. We can do a lot better for function pointers.
BUG=skia:
Committed: http://code.google.com/p/skia/source/detail?r=14929
R=bungeman@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
305753002
git-svn-id: http://skia.googlecode.com/svn/trunk@14938
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 28 May 2014 21:32:25 +0000 (21:32 +0000)]
rebaseline #5 for shadertext2
TBR=
NOTRY=True
NOTREECHECKS=True
Author: reed@google.com
Review URL: https://codereview.chromium.org/
305603005
git-svn-id: http://skia.googlecode.com/svn/trunk@14937
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 28 May 2014 21:14:31 +0000 (21:14 +0000)]
yet more rebaselines for shadertext and mandrills
TBR=
NOTRY=True
NOTREECHECKS=True
Author: reed@google.com
Review URL: https://codereview.chromium.org/
302953002
git-svn-id: http://skia.googlecode.com/svn/trunk@14936
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 28 May 2014 21:00:53 +0000 (21:00 +0000)]
more rebaselines for shadertext2 and stroketext and a couple of mandrills
TBR=epoger
NOTRY=True
NOTREECHECKS=True
Author: reed@google.com
Review URL: https://codereview.chromium.org/
303693013
git-svn-id: http://skia.googlecode.com/svn/trunk@14935
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 28 May 2014 20:02:17 +0000 (20:02 +0000)]
Revert "Remove SkThread.h from public API."
Too much depends on SkThread being in include/core in Chrome build.
This reverts commit
b1aec17df6078115c797839c9646081ccba2bd09.
NOTREECHECKS=true
NOTRY=true
R=reed@google.com, mtklein@google.com
TBR=reed
BUG=skia:
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
303813003
git-svn-id: http://skia.googlecode.com/svn/trunk@14934
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 28 May 2014 19:58:14 +0000 (19:58 +0000)]
Revert of Spin off just SkLazyFnPtr from
305513002. (https://codereview.chromium.org/
305753002/)
Reason for revert:
depends on bad cl
Original issue's description:
> Spin off just SkLazyFnPtr from
305513002.
>
> The memory barrier in SkOnce is a perf regression for sk_mem{set,cpy} in
> SkUtils on ARM. We can do a lot better for function pointers.
>
> BUG=skia:
>
> Committed: http://code.google.com/p/skia/source/detail?r=14929
R=bungeman@google.com, mtklein@chromium.org
TBR=bungeman@google.com, mtklein@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/
300843012
git-svn-id: http://skia.googlecode.com/svn/trunk@14933
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 28 May 2014 19:57:18 +0000 (19:57 +0000)]
Revert of Fix SkAtomics_win.h typos. (https://codereview.chromium.org/
293363017/)
Reason for revert:
depends on bad cl
Original issue's description:
> Fix SkAtomics_win.h typos.
>
> NOTRY=true
>
> BUG=skia:
>
> Committed: http://code.google.com/p/skia/source/detail?r=14930
R=mtklein@chromium.org
TBR=mtklein@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/
304503011
git-svn-id: http://skia.googlecode.com/svn/trunk@14932
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 28 May 2014 19:52:54 +0000 (19:52 +0000)]
add flag to disable changes to image scaling to avoid breaking every single
layout test on blink all at once.
BUG=
R=epoger@google.com
TBR=epoger
NOTRY=True
NOTREECHECKS=True
Author: humper@google.com
Review URL: https://codereview.chromium.org/
298133008
git-svn-id: http://skia.googlecode.com/svn/trunk@14931
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 28 May 2014 19:50:29 +0000 (19:50 +0000)]
Fix SkAtomics_win.h typos.
NOTRY=true
BUG=skia:
R=mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
293363017
git-svn-id: http://skia.googlecode.com/svn/trunk@14930
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 28 May 2014 19:40:21 +0000 (19:40 +0000)]
Spin off just SkLazyFnPtr from
305513002.
The memory barrier in SkOnce is a perf regression for sk_mem{set,cpy} in
SkUtils on ARM. We can do a lot better for function pointers.
BUG=skia:
R=bungeman@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
305753002
git-svn-id: http://skia.googlecode.com/svn/trunk@14929
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Wed, 28 May 2014 19:29:25 +0000 (19:29 +0000)]
Fix filter bounds computation for SkOffsetImageFilter.
SkOffsetImageFilter::onFilterBounds() was not recursing into its input
filter when computing bounds.
BUG=374556
R=junov@chromium.org
Review URL: https://codereview.chromium.org/
304743003
git-svn-id: http://skia.googlecode.com/svn/trunk@14928
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 28 May 2014 19:25:08 +0000 (19:25 +0000)]
more rebaselines for shadertext
TBR=epoger
NOTRY=True
Author: reed@google.com
Review URL: https://codereview.chromium.org/
302433017
git-svn-id: http://skia.googlecode.com/svn/trunk@14927
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 28 May 2014 19:24:54 +0000 (19:24 +0000)]
Remove SkThread.h from public API.
BUG=skia:
R=reed@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
303463009
git-svn-id: http://skia.googlecode.com/svn/trunk@14926
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 28 May 2014 18:51:03 +0000 (18:51 +0000)]
Add SkPurgeGlobalDiscardableMemoryPool, needed to replace SkImageRef
BUG=skia:2389
R=reed@google.com, scroggo@google.com
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/
298423002
git-svn-id: http://skia.googlecode.com/svn/trunk@14925
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 28 May 2014 18:49:15 +0000 (18:49 +0000)]
rebaseline shadertext2 shadertext3 and stroketext (sans 2)
NOTRY=True
TBR=epoger
Author: reed@google.com
Review URL: https://codereview.chromium.org/
304763003
git-svn-id: http://skia.googlecode.com/svn/trunk@14924
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 28 May 2014 18:26:00 +0000 (18:26 +0000)]
add a verbose flag to skdiff that shows the progress and status of
each comparison
BUG=
R=bungeman@google.com
Author: humper@google.com
Review URL: https://codereview.chromium.org/
302443012
git-svn-id: http://skia.googlecode.com/svn/trunk@14923
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 28 May 2014 18:05:42 +0000 (18:05 +0000)]
rename ignored tests
BUG=
R=epoger@google.com
TBR=epoger
NOTRY=true
NOTREECHECKS=True
Author: humper@google.com
Review URL: https://codereview.chromium.org/
304533008
git-svn-id: http://skia.googlecode.com/svn/trunk@14922
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 28 May 2014 17:30:10 +0000 (17:30 +0000)]
Add script to rebaseline benches from codereview trybot results
This script is designed to be used by the RecreateSKPs bot. Eventually, the bot will:
1. Generate new SKPs
2. Upload the new SKPs to a subdirectory with an ID or generation number.
3. Change Skia to use the new SKPs:
a. Create and upload a Skia CL which changes the "current SKP generation" file to point to the new SKPs
b. Launch Perf trybots on that CL.
c. Call this script every 5 minutes until it successfully creates new baselines for each of the launched Perf bots.
d. Add the new baselines to the CL
e. Upload a second patch set of the CL
f. Check the CQ bit on the CL
BUG=skia:2225
R=epoger@google.com, halcanary@google.com, bensong@google.com
Author: borenet@google.com
Review URL: https://codereview.chromium.org/
297893004
git-svn-id: http://skia.googlecode.com/svn/trunk@14921
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 28 May 2014 17:30:02 +0000 (17:30 +0000)]
Make image scaling have floating point scales. Third attempt to land this
due to some struggles with the CQ. Original CL here:
https://codereview.chromium.org/
298243003/
BUG=
R=bsalomon@google.com, epoger@google.com
TBR=bsalomon, epoger
Author: humper@google.com
Review URL: https://codereview.chromium.org/
300113008
git-svn-id: http://skia.googlecode.com/svn/trunk@14920
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Wed, 28 May 2014 17:25:02 +0000 (17:25 +0000)]
Followup GM rebaselines for non-GPU configs after removing tests from ignored-tests.txt
Review URL: https://codereview.chromium.org/
303693012
git-svn-id: http://skia.googlecode.com/svn/trunk@14919
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Wed, 28 May 2014 16:41:21 +0000 (16:41 +0000)]
Take care of a bunch of pending GPU rebaselines and remove tests from ignored-tests.txt
Review URL: https://codereview.chromium.org/
300863006
git-svn-id: http://skia.googlecode.com/svn/trunk@14918
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 28 May 2014 16:16:08 +0000 (16:16 +0000)]
Revert of add colortable support to imagegenerator (https://codereview.chromium.org/
304443003/)
Reason for revert:
failing tests
Original issue's description:
> add colortable support to imagegenerator
>
> BUG=skia:
>
> Committed: http://code.google.com/p/skia/source/detail?r=14916
R=halcanary@google.com, scroggo@google.com
TBR=halcanary@google.com, scroggo@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Author: reed@google.com
Review URL: https://codereview.chromium.org/
300873007
git-svn-id: http://skia.googlecode.com/svn/trunk@14917
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 28 May 2014 16:01:55 +0000 (16:01 +0000)]
add colortable support to imagegenerator
BUG=skia:
R=halcanary@google.com, scroggo@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/
304443003
git-svn-id: http://skia.googlecode.com/svn/trunk@14916
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Wed, 28 May 2014 15:40:26 +0000 (15:40 +0000)]
Better handling of bitmaps in DirectWrite.
R=reed@google.com
Review URL: https://codereview.chromium.org/
303773002
git-svn-id: http://skia.googlecode.com/svn/trunk@14915
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 28 May 2014 15:02:37 +0000 (15:02 +0000)]
Include SkTypes to fix Android frameworks build
Since Android's defines are included in SkUserConfig (rather than
being defined in the build file), we need to include something that
includes SkUserConfig (transitively; meaning just about anything)
before we can use any build macros. Include SkTypes, "the correct
way to get access to the config system" so that
SK_BUILD_FOR_ANDROID is defined before querying it.
R=robertphillips@google.com, djsollen@google.com, mtklein@google.com
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/
294393011
git-svn-id: http://skia.googlecode.com/svn/trunk@14914
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 28 May 2014 13:23:39 +0000 (13:23 +0000)]
Add SKP_VERSION file to determine which SKPs to download
BUG=skia:2225
R=epoger@google.com, rmistry@google.com, bensong@google.com
Author: borenet@google.com
Review URL: https://codereview.chromium.org/
299403009
git-svn-id: http://skia.googlecode.com/svn/trunk@14913
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Wed, 28 May 2014 03:06:06 +0000 (03:06 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@14912
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 27 May 2014 23:41:45 +0000 (23:41 +0000)]
add replay entry point to SkPictureRecorder for Android
This CL adds an Android-only entry point to address the Java Picture(Picture) and serialize use cases. Note that (in its current form) it doesn't preserve the old API's handling of unbalanced saves/saveLayers (this CL always balances them).
R=reed@google.com, scroggo@google.com, djsollen@google.com, mtklein@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
252873005
git-svn-id: http://skia.googlecode.com/svn/trunk@14911
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 27 May 2014 21:51:38 +0000 (21:51 +0000)]
Revert of PictureBenchmark JSON logging (https://codereview.chromium.org/
286903025/)
Reason for revert:
Broke some Windows builds; see http://skbug.com/2609 ('certain Windows Build-* bots failing since r14905').
Before re-landing with a fix, please send to some of the trybots that failed the first time.
Original issue's description:
> Add JSON logging support to bench_pictures by adding a PictureResultsWriter class (in tools/PictureResultsWriter.h) to process logging information, using a very similar style as bench/ResultsWriter.h
>
> JSON format described in code, above PictureJSONResultsWriter class
>
> BUG=skia:
>
> Committed: http://code.google.com/p/skia/source/detail?r=14906
R=bensong@google.com, jcgregorio@google.com, kelvinly@google.com
TBR=bensong@google.com, jcgregorio@google.com, kelvinly@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:2609
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
306483010
git-svn-id: http://skia.googlecode.com/svn/trunk@14910
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 27 May 2014 21:30:37 +0000 (21:30 +0000)]
remove SkBitmap::asImageInfo
BUG=skia:
R=scroggo@google.com, halcanary@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/
305483005
git-svn-id: http://skia.googlecode.com/svn/trunk@14909
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 27 May 2014 21:15:35 +0000 (21:15 +0000)]
add box image to resources; landing separately to avoid issues with
trybots for the code that uses this
BUG=
R=epoger@google.com
TBR=epoger
NOTRY=True
Author: humper@google.com
Review URL: https://codereview.chromium.org/
303713002
git-svn-id: http://skia.googlecode.com/svn/trunk@14908
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Tue, 27 May 2014 21:12:42 +0000 (21:12 +0000)]
Manual SVN revert of https://code.google.com/p/skia/source/detail?r=14905
git-svn-id: http://skia.googlecode.com/svn/trunk@14907
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 27 May 2014 20:57:44 +0000 (20:57 +0000)]
Add JSON logging support to bench_pictures by adding a PictureResultsWriter class (in tools/PictureResultsWriter.h) to process logging information, using a very similar style as bench/ResultsWriter.h
JSON format described in code, above PictureJSONResultsWriter class
BUG=skia:
R=bensong@google.com, jcgregorio@google.com
Author: kelvinly@google.com
Review URL: https://codereview.chromium.org/
286903025
git-svn-id: http://skia.googlecode.com/svn/trunk@14906
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 27 May 2014 20:54:04 +0000 (20:54 +0000)]
floating point scale factors for images
New version of https://codereview.chromium.org/
298243003/ made to deal with binary file being lost.
BUG=
TBR=bsalomon
NOTRY=true
Author: humper@google.com
Review URL: https://codereview.chromium.org/
307553005
git-svn-id: http://skia.googlecode.com/svn/trunk@14905
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 27 May 2014 20:10:48 +0000 (20:10 +0000)]
whitespace change to trigger new builds after buildbot fix
BUG=skia:2608
NOTREECHECKS=True
NOTRY=True
R=borenet@google.com
TBR=borenet
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
300223005
git-svn-id: http://skia.googlecode.com/svn/trunk@14904
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 27 May 2014 19:26:59 +0000 (19:26 +0000)]
Revert of Revert of Add compressed texture capabilities for GPU devices
(https://codereview.chromium.org/
307543002/)
Reason for revert:
Re-landing the original CL, because the revert didn't fix things. See http://skbug.com/2608 ('RunDecodingTests failing on multiple platforms')
Original issue's description:
> Revert of Add compressed texture capabilities for GPU devices (https://codereview.chromium.org/
292323003/)
>
> Reason for revert:
> RunDecodingTests failing on multiple platforms. Please use trybots to validate and re-land.
>
> Original issue's description:
> > Add compressed texture capabilities for GPU devices
> >
> > BUG=skia:
> >
> > Committed: http://code.google.com/p/skia/source/detail?r=14880
> >
> > Committed: http://code.google.com/p/skia/source/detail?r=14901
>
> TBR=bsalomon@google.com,robertphillips@google.com,krajcevski@google.com
> NOTREECHECKS=true
> NOTRY=true
> BUG=skia:
>
> Committed: http://code.google.com/p/skia/source/detail?r=14902
R=bsalomon@google.com, robertphillips@google.com, krajcevski@google.com
TBR=bsalomon@google.com, krajcevski@google.com, robertphillips@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
302553008
git-svn-id: http://skia.googlecode.com/svn/trunk@14903
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 27 May 2014 19:07:10 +0000 (19:07 +0000)]
Revert of Add compressed texture capabilities for GPU devices (https://codereview.chromium.org/
292323003/)
Reason for revert:
RunDecodingTests failing on multiple platforms. Please use trybots to validate and re-land.
Original issue's description:
> Add compressed texture capabilities for GPU devices
>
> BUG=skia:
>
> Committed: http://code.google.com/p/skia/source/detail?r=14880
>
> Committed: http://code.google.com/p/skia/source/detail?r=14901
R=bsalomon@google.com, robertphillips@google.com, krajcevski@google.com
TBR=bsalomon@google.com, krajcevski@google.com, robertphillips@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
307543002
git-svn-id: http://skia.googlecode.com/svn/trunk@14902
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 27 May 2014 18:52:24 +0000 (18:52 +0000)]
Add compressed texture capabilities for GPU devices
BUG=skia:
Committed: http://code.google.com/p/skia/source/detail?r=14880
R=bsalomon@google.com, robertphillips@google.com
Author: krajcevski@google.com
Review URL: https://codereview.chromium.org/
292323003
git-svn-id: http://skia.googlecode.com/svn/trunk@14901
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 27 May 2014 17:31:25 +0000 (17:31 +0000)]
Add another expectation for bug with perspective gpu
BUG=skia:2605
R=robertphillips@google.com
Author: krajcevski@google.com
Review URL: https://codereview.chromium.org/
301593006
git-svn-id: http://skia.googlecode.com/svn/trunk@14900
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 27 May 2014 17:03:25 +0000 (17:03 +0000)]
Fixing windows warnings
BUG=skia:
R=bsalomon@google.com, epoger@google.com
Author: sugoi@chromium.org
Review URL: https://codereview.chromium.org/
298093006
git-svn-id: http://skia.googlecode.com/svn/trunk@14899
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 27 May 2014 17:01:49 +0000 (17:01 +0000)]
Adds perf expectations for ANGLE bot.
BUG=skia:2576
NOTRY=true
R=borenet@google.com
Author: bensong@google.com
Review URL: https://codereview.chromium.org/
303643002
git-svn-id: http://skia.googlecode.com/svn/trunk@14898
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 27 May 2014 16:28:43 +0000 (16:28 +0000)]
Remove some unnecessary uses of SkOnce.
- gm/imagefiltersgraph.cpp can just use a global registrar
- SkScaledImageCache always accesses its global under a lock
BUG=skia:
R=bungeman@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
297273006
git-svn-id: http://skia.googlecode.com/svn/trunk@14897
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 27 May 2014 15:55:35 +0000 (15:55 +0000)]
Use SkAtomics_sync on Android
Every doc I've found about using Android's atomics says, "stop".
"* A handful of basic atomic operations. The appropriate pthread
* functions should be used instead of these whenever possible."
"... we recommend stopping from using these functions entirely. Very fortunately, GCC provides handy intrinsics functions that work with very reasonable performance and always provide a full barrier."
As far as I can tell, there's no code generation change here: both the __sync atomics and the android_ atomics use full memory barriers. (And now with this all unified, it'll be easier to get the real wins by switching everything to __atomic atomics, which are like __sync atomics but allow control over memory barriers.)
BUG=skia:
R=bungeman@google.com, djsollen@google.com, mtklein@google.com, reed@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
305593002
git-svn-id: http://skia.googlecode.com/svn/trunk@14896
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 27 May 2014 15:28:03 +0000 (15:28 +0000)]
rebaseline simpleblurroundrect
BUG=
TBR=bsalomon
Author: humper@google.com
Review URL: https://codereview.chromium.org/
300833002
git-svn-id: http://skia.googlecode.com/svn/trunk@14895
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 27 May 2014 15:16:37 +0000 (15:16 +0000)]
Drop support for non-atomic non-mutex platforms.
(Clients can still provide these themselves if they really want.)
BUG=skia:
R=reed@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
295373005
git-svn-id: http://skia.googlecode.com/svn/trunk@14894
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 27 May 2014 15:04:57 +0000 (15:04 +0000)]
Update expectations for etc1bitmap
R=robertphillips@google.com
Author: krajcevski@google.com
Review URL: https://codereview.chromium.org/
300063007
git-svn-id: http://skia.googlecode.com/svn/trunk@14893
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 27 May 2014 15:00:32 +0000 (15:00 +0000)]
Implement sk_atomic_conditional_inc with sk_atomic_cas.
Now that we have sk_atomic_cas, we can replace all the platform-specific CAS loops with one.
BUG=skia:
R=bungeman@google.com, mtklein@google.com, reed@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
300553003
git-svn-id: http://skia.googlecode.com/svn/trunk@14892
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 27 May 2014 14:59:47 +0000 (14:59 +0000)]
Move SkDecodingImageGenerator.h to include/
This will allow Android to access it and remove SkImageRef.
Depends on https://codereview.chromium.org/
293283002/
BUG=skia:2389
R=reed@google.com, djsollen@google.com, halcanary@google.com
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/
228613003
git-svn-id: http://skia.googlecode.com/svn/trunk@14891
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 27 May 2014 14:35:25 +0000 (14:35 +0000)]
Add OpenGL Compressed Texture enum values
R=bsalomon@google.com, robertphillips@google.com
Author: krajcevski@google.com
Review URL: https://codereview.chromium.org/
293263004
git-svn-id: http://skia.googlecode.com/svn/trunk@14890
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 27 May 2014 14:14:22 +0000 (14:14 +0000)]
hide discardable factory from public imagegenerator api
BUG=skia:
R=halcanary@google.com, scroggo@google.com, djsollen@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/
295243006
git-svn-id: http://skia.googlecode.com/svn/trunk@14889
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 27 May 2014 14:03:51 +0000 (14:03 +0000)]
remove SK_SUPPORT_LEGACY_BITMAPFLATTEN code
BUG=skia:
R=scroggo@google.com, reed@google.com
Author: reed@chromium.org
Review URL: https://codereview.chromium.org/
303563002
git-svn-id: http://skia.googlecode.com/svn/trunk@14888
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 27 May 2014 13:52:51 +0000 (13:52 +0000)]
Adding new filters to fuzzer
New image filters were added since the last time I worked on the fuzzer, so I added them to the fuzzer. Same changes will be made to the clusterfuzz fuzzer.
BUG=skia:
R=bsalomon@google.com
Author: sugoi@chromium.org
Review URL: https://codereview.chromium.org/
300153002
git-svn-id: http://skia.googlecode.com/svn/trunk@14887
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 27 May 2014 12:45:42 +0000 (12:45 +0000)]
sk_memcpy32 should fall back on libc memcpy.
Writing it out ourselves was a ~2x slowdown on ARM.
BUG=skia:
R=henrik.smiding@intel.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
292663013
git-svn-id: http://skia.googlecode.com/svn/trunk@14886
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 27 May 2014 00:23:36 +0000 (00:23 +0000)]
remove SK_SUPPORT_LEGACY_BUILDMIPMAP
TBR=scroggo
Author: reed@chromium.org
Review URL: https://codereview.chromium.org/
293393007
git-svn-id: http://skia.googlecode.com/svn/trunk@14885
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Sat, 24 May 2014 03:05:26 +0000 (03:05 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@14884
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 23 May 2014 20:40:26 +0000 (20:40 +0000)]
Revert of Add compressed texture capabilities for GPU devices (https://codereview.chromium.org/
292323003/)
Reason for revert:
Signeness comparison breaks build. After working some more, I think the API design will be cleaner without the Uncompressed enum, so I'm removing it and retesting everything.
Original issue's description:
> Add compressed texture capabilities for GPU devices
>
> BUG=skia:
>
> Committed: http://code.google.com/p/skia/source/detail?r=14880
R=bsalomon@google.com, robertphillips@google.com, halcanary@google.com
TBR=bsalomon@google.com, robertphillips@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Author: krajcevski@google.com
Review URL: https://codereview.chromium.org/
296313003
git-svn-id: http://skia.googlecode.com/svn/trunk@14883
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 23 May 2014 20:25:15 +0000 (20:25 +0000)]
move ashmem switching logic to SkDiscardableMemory::Create
R=scroggo@google.com, reed@google.com
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/
293283002
git-svn-id: http://skia.googlecode.com/svn/trunk@14882
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 23 May 2014 20:00:59 +0000 (20:00 +0000)]
Change the PKM decoder to adhere to sampler size
This fixes a bug where the red and blue channels seemed to be swapped on some platforms after decoding, and brings it more in line with the logic already in libbmp.
BUG=skia:
R=halcanary@google.com, robertphillips@google.com
Author: krajcevski@google.com
Review URL: https://codereview.chromium.org/
297853005
git-svn-id: http://skia.googlecode.com/svn/trunk@14881
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 23 May 2014 20:00:54 +0000 (20:00 +0000)]
Add compressed texture capabilities for GPU devices
BUG=skia:
R=bsalomon@google.com, robertphillips@google.com
Author: krajcevski@google.com
Review URL: https://codereview.chromium.org/
292323003
git-svn-id: http://skia.googlecode.com/svn/trunk@14880
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 23 May 2014 19:22:13 +0000 (19:22 +0000)]
rather than committing new unreviewed expectations, just ignore the failures
This way, subsequent runs of the bots will try to re-upload the image file. (They don't try to upload images for passing tests.)
BUG=skia:2603
NOTREECHECKS=True
NOTRY=True
R=fmalita@google.com
TBR=fmalita
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
297853007
git-svn-id: http://skia.googlecode.com/svn/trunk@14879
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 23 May 2014 19:13:56 +0000 (19:13 +0000)]
Revert of Modify sample buffer size for larger displays. (https://codereview.chromium.org/
240433002/)
Reason for revert:
This also changes verylargebitmap, and the difference appears to be meaningful. Henrik, I have emailed you the images that differ.
Original issue's description:
> Modify sample buffer size for larger displays.
>
> Increases the intermediate buffer size for sample pixel indexes,
> used in the sample proc function calls. If the operation is bigger
> than the buffer it's split into multiple calls, creating overhead.
> This would especially impact the performance of SIMD optimizations.
> Also, aligns the start address of the buffer to 16 bytes, to enable
> more efficient SIMD optimizations.
>
> Author: henrik.smiding@intel.com
>
> Signed-off-by: Henrik Smiding <henrik.smiding@intel.com>
>
> Committed: http://code.google.com/p/skia/source/detail?r=14825
>
> Committed: http://code.google.com/p/skia/source/detail?r=14872
R=reed@google.com, mtklein@google.com, tomhudson@google.com, djsollen@google.com, joakim.landberg@intel.com, bsalomon@chromium.org, bsalomon@google.com, henrik.smiding@intel.com
TBR=reed@google.com
NOTREECHECKS=true
NOTRY=true
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/
294023016
git-svn-id: http://skia.googlecode.com/svn/trunk@14878
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 23 May 2014 19:09:46 +0000 (19:09 +0000)]
Revert of Suppress more GMs pending rebaseline after
0533146d005 (https://codereview.chromium.org/
296173009/)
Reason for revert:
The CL for which these were added needs to be reverted. The best example of its breakage is in verylargebitmap.
Original issue's description:
> Suppress more GMs pending rebaseline after
0533146d005
>
> TBR=scroggo@google.com
>
> Committed: https://code.google.com/p/skia/source/detail?r=14874
R=fmalita@chromium.org
TBR=fmalita@chromium.org
NOTREECHECKS=true
NOTRY=true
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/
298973008
git-svn-id: http://skia.googlecode.com/svn/trunk@14877
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 23 May 2014 19:08:17 +0000 (19:08 +0000)]
instead of ignoring testimagefilters EVERYWHERE, just ignore particular failures
BUG=skia:2603
NOTREECHECKS=True
NOTRY=True
R=fmalita@google.com
TBR=fmalita
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
296213009
git-svn-id: http://skia.googlecode.com/svn/trunk@14876
2bbb7eff-a529-9590-31e7-
b0007b416f81
fmalita@google.com [Fri, 23 May 2014 18:44:21 +0000 (18:44 +0000)]
Suppress testimagefilters GM.
Failing on Android, but results missing.
BUG=skia:2603
TBR=epoger@google.com
Review URL: https://codereview.chromium.org/
299143006
git-svn-id: http://skia.googlecode.com/svn/trunk@14875
2bbb7eff-a529-9590-31e7-
b0007b416f81
fmalita@google.com [Fri, 23 May 2014 18:34:18 +0000 (18:34 +0000)]
Suppress more GMs pending rebaseline after
0533146d005
TBR=scroggo@google.com
Review URL: https://codereview.chromium.org/
296173009
git-svn-id: http://skia.googlecode.com/svn/trunk@14874
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 23 May 2014 16:26:57 +0000 (16:26 +0000)]
manual bench rebase after f757fd3
R=robertphillips@google.com
TBR=robertphillips@google.com
Bypassing trybots:
NOTRY=true
Author: fmalita@chromium.org
Review URL: https://codereview.chromium.org/
293093007
git-svn-id: http://skia.googlecode.com/svn/trunk@14873
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 23 May 2014 16:05:43 +0000 (16:05 +0000)]
Modify sample buffer size for larger displays.
Increases the intermediate buffer size for sample pixel indexes,
used in the sample proc function calls. If the operation is bigger
than the buffer it's split into multiple calls, creating overhead.
This would especially impact the performance of SIMD optimizations.
Also, aligns the start address of the buffer to 16 bytes, to enable
more efficient SIMD optimizations.
Author: henrik.smiding@intel.com
Signed-off-by: Henrik Smiding <henrik.smiding@intel.com>
Committed: http://code.google.com/p/skia/source/detail?r=14825
R=reed@google.com, mtklein@google.com, tomhudson@google.com, djsollen@google.com, joakim.landberg@intel.com, scroggo@google.com, bsalomon@chromium.org, bsalomon@google.com
Author: henrik.smiding@intel.com
Review URL: https://codereview.chromium.org/
240433002
git-svn-id: http://skia.googlecode.com/svn/trunk@14872
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 23 May 2014 16:01:31 +0000 (16:01 +0000)]
(bad) rebaselines for shader change
TBR=halcanary
NOTRY=True
Author: reed@google.com
Review URL: https://codereview.chromium.org/
296983013
git-svn-id: http://skia.googlecode.com/svn/trunk@14871
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 23 May 2014 16:01:09 +0000 (16:01 +0000)]
Adds more bots for bench alerts.
Bypassing trybots:
NOTRY=true
R=borenet@google.com
Author: bensong@google.com
Review URL: https://codereview.chromium.org/
291343008
git-svn-id: http://skia.googlecode.com/svn/trunk@14870
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 23 May 2014 15:31:02 +0000 (15:31 +0000)]
fix bench rebase tool to cope with wider range of bots.
BUG=skia:2373
R=kelvinly@google.com
TBR=kelvinly@google.com
NOTRY=true
Author: bensong@google.com
Review URL: https://codereview.chromium.org/
292623005
git-svn-id: http://skia.googlecode.com/svn/trunk@14869
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 23 May 2014 13:55:44 +0000 (13:55 +0000)]
rebaseline after unitmapper shader change
TBR=epoger
NOTRY=True
Author: reed@google.com
Review URL: https://codereview.chromium.org/
294973012
git-svn-id: http://skia.googlecode.com/svn/trunk@14868
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 23 May 2014 13:21:55 +0000 (13:21 +0000)]
stop calling SkBitmap::flatten
BUG=skia:
R=scroggo@google.com, halcanary@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/
295793002
git-svn-id: http://skia.googlecode.com/svn/trunk@14867
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 23 May 2014 13:05:33 +0000 (13:05 +0000)]
Adds angle to bench expectation configs.
BUG=skia:2576
R=robertphillips@google.com
TBR=robertphillips@google.com
NOTRY=true
Author: bensong@google.com
Review URL: https://codereview.chromium.org/
293033013
git-svn-id: http://skia.googlecode.com/svn/trunk@14866
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 23 May 2014 12:32:23 +0000 (12:32 +0000)]
fix stroking large drawPosText
BUG=skia:
R=bungeman@google.com, yunchao.he@intel.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/
288983004
git-svn-id: http://skia.googlecode.com/svn/trunk@14865
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 23 May 2014 11:51:16 +0000 (11:51 +0000)]
manual bench rebase after 7693dbf
R=robertphillips@google.com
TBR=robertphillips@google.com
Bypassing trybots:
NOTRY=true
Author: bensong@google.com
Review URL: https://codereview.chromium.org/
297943002
git-svn-id: http://skia.googlecode.com/svn/trunk@14864
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 23 May 2014 08:09:26 +0000 (08:09 +0000)]
fix the visual diff of raster vs gpu -- vertices_80. The sw-raster is correct, all images are blurry.
While some images generated by gpu doesn't respect SkPaint's alpha value.
In gpu path, when pass SkPaint's alpha and color to GrPaint by SkPaint2GrPaintNoShader,
either alpha or colors can't not be passed. We can't pass both of them by the API.
Premultiply paint's alpha to colors's alpha in drawVertices, and pass colors to GrPaint.
The rendering result will respect colors in drawVertices, and the alpha value set in SkPaint as well.
BUG=skia:2592
R=bsalomon@google.com
Author: yunchao.he@intel.com
Review URL: https://codereview.chromium.org/
292943002
git-svn-id: http://skia.googlecode.com/svn/trunk@14863
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Fri, 23 May 2014 03:03:34 +0000 (03:03 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@14862
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 23 May 2014 01:02:21 +0000 (01:02 +0000)]
Revert of Turn on preprocessing by default (https://codereview.chromium.org/
299033002/)
Reason for revert:
Don't want this enabled by default right now
Original issue's description:
> Turn on preprocessing by default
>
> The idea is to commit this late at night and then revert it after all the perf bots are running. It should only effect the GPU configs.
>
> Committed: http://code.google.com/p/skia/source/detail?r=14860
R=bsalomon@google.com
TBR=bsalomon@google.com
NOTREECHECKS=true
NOTRY=true
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
299123002
git-svn-id: http://skia.googlecode.com/svn/trunk@14861
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 22 May 2014 23:27:27 +0000 (23:27 +0000)]
Turn on preprocessing by default
The idea is to commit this late at night and then revert it after all the perf bots are running. It should only effect the GPU configs.
R=bsalomon@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
299033002
git-svn-id: http://skia.googlecode.com/svn/trunk@14860
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 22 May 2014 22:35:24 +0000 (22:35 +0000)]
temporarily add back in the factores that took a unitmapper
BUG=skia:
R=fmalita@google.com, fmalita@chromium.org, reed@chromium.org
Author: reed@google.com
Review URL: https://codereview.chromium.org/
292513006
git-svn-id: http://skia.googlecode.com/svn/trunk@14859
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Thu, 22 May 2014 21:29:20 +0000 (21:29 +0000)]
Add pkm missing from r14852 (Simple PKM image decoder - https://codereview.chromium.org/
292663011/) commit
git-svn-id: http://skia.googlecode.com/svn/trunk@14858
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 22 May 2014 20:09:05 +0000 (20:09 +0000)]
remove bit rotted gyp from most
BUG=skia:2597
R=epoger@google.com
TBR=epoger
NOTRY=true
Author: caryclark@google.com
Review URL: https://codereview.chromium.org/
297823004
git-svn-id: http://skia.googlecode.com/svn/trunk@14857
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 22 May 2014 19:58:22 +0000 (19:58 +0000)]
remove bit rot test gyp
BUG=skia:2597
R=epoger@google.com
TBR=epoger
NOTRY=true
Author: caryclark@google.com
Review URL: https://codereview.chromium.org/
296053016
git-svn-id: http://skia.googlecode.com/svn/trunk@14856
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 22 May 2014 19:30:54 +0000 (19:30 +0000)]
If our gyp does not exist, use chromium's.
The previous version had faith that if the third_party folder
existed, it must contain externals/gyp. A recent change added
third_party (in git, as opposed to using DEPS), so now Android
has third_party but not externals/gyp.
Now check the full filepath. If it's not there, back up to
chromium's version.
Fixes Android canary bot.
R=halcanary@google.com
TBR=halcanary@google.com
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/
295103008
git-svn-id: http://skia.googlecode.com/svn/trunk@14855
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Thu, 22 May 2014 18:53:10 +0000 (18:53 +0000)]
turn assert into not_implemented_yet for patheffects on text
git-svn-id: http://skia.googlecode.com/svn/trunk@14854
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 22 May 2014 18:43:05 +0000 (18:43 +0000)]
re-expose hasLocalMatrix for now (can't hurt) -- unblocks blink
BUG=skia:
R=fmalita@google.com, fmalita@chromium.org
Author: reed@google.com
Review URL: https://codereview.chromium.org/
299043002
git-svn-id: http://skia.googlecode.com/svn/trunk@14853
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Thu, 22 May 2014 18:40:29 +0000 (18:40 +0000)]
Simple PKM image decoder.
https://codereview.chromium.org/
292663011/
git-svn-id: http://skia.googlecode.com/svn/trunk@14852
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 22 May 2014 18:24:42 +0000 (18:24 +0000)]
Fix memcpy32_sse2_unalign.
The whole point of mempcy32_sse2_unalign is that we didn't align dst128
and src128. So it's not safe at all to cast them back to dst and src.
That tells the compiler that dst/src are 128-bit aligned, and then it
autovectorizes the cleanup while-loop using that (false) knowledge with
aligned SSE instructions.
This leads to crashes on memcpy32_sse2_unalign_10, which is small enough
that we actually get non-16-byte aligned memory. The larger size
benches could be crashing too, but they're big enough allocations that
they're probably always 16-byte aligned anyway.
BUG=skia:2589
R=fmalita@chromium.org, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
291893008
git-svn-id: http://skia.googlecode.com/svn/trunk@14851
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Thu, 22 May 2014 17:59:51 +0000 (17:59 +0000)]
tweak stroketext GM to actually test dashing
git-svn-id: http://skia.googlecode.com/svn/trunk@14850
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Thu, 22 May 2014 17:59:21 +0000 (17:59 +0000)]
Remove SK_IGNORE_UNDERLINE_POSITION_FIX now that it is no longer used.
R=reed@google.com
Review URL: https://codereview.chromium.org/
294663016
git-svn-id: http://skia.googlecode.com/svn/trunk@14849
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 22 May 2014 17:41:41 +0000 (17:41 +0000)]
update stroketext gm
TBR=bungeman
Author: reed@google.com
Review URL: https://codereview.chromium.org/
293983016
git-svn-id: http://skia.googlecode.com/svn/trunk@14848
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Thu, 22 May 2014 17:06:31 +0000 (17:06 +0000)]
Rebaseline two GMs that subtly changed in perspective after convexity fix.
BUG=skia:
Review URL: https://codereview.chromium.org/
292983015
git-svn-id: http://skia.googlecode.com/svn/trunk@14847
2bbb7eff-a529-9590-31e7-
b0007b416f81
tfarina@chromium.org [Thu, 22 May 2014 15:54:05 +0000 (15:54 +0000)]
Don't try to remove xcodebuild directory on Windows.
make.py is a python script to be run *only* on Windows and thus
xcodebuild directory should not exist there. If we never create it on Windows,
then why should we try to remove something we don't create there?
R=epoger@google.com
Review URL: https://codereview.chromium.org/
299443005
git-svn-id: http://skia.googlecode.com/svn/trunk@14846
2bbb7eff-a529-9590-31e7-
b0007b416f81
projects / platform / upstream / libSkiaSharp.git / log