Denis Kenzior [Thu, 29 Oct 2009 19:21:04 +0000 (14:21 -0500)]
Fix: Also auto register when status is unknown
Denis Kenzior [Thu, 29 Oct 2009 19:18:19 +0000 (14:18 -0500)]
Fix: Quiet compiler warning
Denis Kenzior [Thu, 29 Oct 2009 17:50:52 +0000 (12:50 -0500)]
Refactor: Make MBM driver actually use EMRDY
Denis Kenzior [Thu, 29 Oct 2009 17:50:28 +0000 (12:50 -0500)]
Fix: Return EINPROGRESS as intended
Claudio Takahasi [Tue, 27 Oct 2009 20:24:11 +0000 (18:24 -0200)]
Fix message handling for autostart.
Current implementation of libdbus Request name is blocking, consequently
the first incomming message that triggered the service autostart is not
being processed properly.
Denis Kenzior [Thu, 29 Oct 2009 05:10:03 +0000 (00:10 -0500)]
Fix: Refine logic for hangup
Denis Kenzior [Thu, 29 Oct 2009 04:40:04 +0000 (23:40 -0500)]
Fix: This hack is no longer necessary
Denis Kenzior [Thu, 29 Oct 2009 04:39:15 +0000 (23:39 -0500)]
In the simple single active call case, use hangup
Denis Kenzior [Thu, 29 Oct 2009 00:23:25 +0000 (19:23 -0500)]
Fix: Don't pass the indexes
These can be obtained inside the function anyway
Denis Kenzior [Wed, 28 Oct 2009 22:40:35 +0000 (17:40 -0500)]
Fix: No need to set this to NULL
Denis Kenzior [Wed, 28 Oct 2009 22:40:06 +0000 (17:40 -0500)]
Cleanup: Fixup style
Zhenhua Zhang [Wed, 28 Oct 2009 11:01:24 +0000 (19:01 +0800)]
Add voicecall driver for Bluetooth HFP
HFP voicecall driver uses AT+CIEV indicator to notify call status
update according to Bluetooth HFP spec v1.5. This patch only adds single
call support.
Zhenhua Zhang [Wed, 28 Oct 2009 17:42:39 +0000 (01:42 +0800)]
Refactor: Move alloc/release id to atutil.c
Zhenhua Zhang [Wed, 28 Oct 2009 17:22:06 +0000 (01:22 +0800)]
Refactor: Move & Rename functions to atutil.c
Move and rename call_compare and call_compare_by_status to atutil.c.
These will be utilized by other drivers, including hfpmodem.
Denis Kenzior [Wed, 28 Oct 2009 21:56:45 +0000 (16:56 -0500)]
Cleanup previous patch
Ryan Raasch [Tue, 27 Oct 2009 12:55:16 +0000 (13:55 +0100)]
Add serial settings parser to modemconf plugin
Denis Kenzior [Wed, 28 Oct 2009 21:38:55 +0000 (16:38 -0500)]
Cleanup previous patch and update docs
Ryan Raasch [Tue, 27 Oct 2009 12:54:31 +0000 (13:54 +0100)]
Refactor: Capitalize g_at_tty option names
Denis Kenzior [Wed, 28 Oct 2009 19:36:14 +0000 (14:36 -0500)]
Fix: Take care of the logic for Dialing
The logic for dialing a call while other calls are in the system is a
bit more complicated than what was implemented.
There are several cases to consider:
- Active Call and Held Call
In this situation we cannot dial, the user must drop one of the
calls.
- Active Call and Waiting Call -> We have to put the active call on
hold, unfortunately there is no standard command to do so without
affecting the waiting call. If the modem has a vendor specific
implementation, then try to use that.
- Active Call only -> Put the active call on hold. We use the
swap_without_accept implementation (if exists) to be safe, otherwise
we fall back to hold active calls.
- No Active calls -> Simply dial
Denis Kenzior [Wed, 28 Oct 2009 19:28:51 +0000 (14:28 -0500)]
Refactor: Avoid unnecessary forward declarations
Denis Kenzior [Wed, 28 Oct 2009 19:27:39 +0000 (14:27 -0500)]
Refactor: Move more code around
Avoid unnecessary forward declarations
Denis Kenzior [Wed, 28 Oct 2009 19:23:51 +0000 (14:23 -0500)]
Refactor: Move code to avoid forward declaration
Denis Kenzior [Wed, 28 Oct 2009 19:12:21 +0000 (14:12 -0500)]
Refactor: Get rid of PENDING_FLAG in voicecalls
the pending variable was enough already. Also refactor to use
__ofono_dbus_pending_reply to make the code much more readable.
Denis Kenzior [Wed, 28 Oct 2009 18:06:34 +0000 (13:06 -0500)]
Add utility to parse CLIR option
Denis Kenzior [Wed, 28 Oct 2009 00:47:52 +0000 (19:47 -0500)]
Refactor: replace netreg get_operator with mcc/mnc
The full operator information is useless as only mcc/mnc are really
required. The internal structures will be changing soon
Denis Kenzior [Tue, 27 Oct 2009 19:41:43 +0000 (14:41 -0500)]
Fix: Don't emit spurious Base Station Name signal
Denis Kenzior [Tue, 27 Oct 2009 17:47:42 +0000 (12:47 -0500)]
Fix: Skip empty emergency numbers
Denis Kenzior [Tue, 27 Oct 2009 17:39:20 +0000 (12:39 -0500)]
Fix: Obscure crash when GPRS is not supported
Denis Kenzior [Tue, 27 Oct 2009 17:39:09 +0000 (12:39 -0500)]
Fix: Properly unregister context on exit
Denis Kenzior [Mon, 26 Oct 2009 23:30:41 +0000 (18:30 -0500)]
Fix: Use driver_attached instead of attached
Denis Kenzior [Mon, 26 Oct 2009 22:26:19 +0000 (17:26 -0500)]
Make netreg_update based on CREG, not CGREG
Denis Kenzior [Mon, 26 Oct 2009 22:25:52 +0000 (17:25 -0500)]
Simplify logic in netreg_update
Denis Kenzior [Mon, 26 Oct 2009 22:00:35 +0000 (17:00 -0500)]
Fix unused variable warning
Denis Kenzior [Mon, 26 Oct 2009 21:59:22 +0000 (16:59 -0500)]
Don't cause an infinite loop
Denis Kenzior [Mon, 26 Oct 2009 21:58:24 +0000 (16:58 -0500)]
Get rid of the AFTER_ROAMING stuff
Denis Kenzior [Mon, 26 Oct 2009 21:57:21 +0000 (16:57 -0500)]
Ignore gprs status when not attached/attaching
Denis Kenzior [Mon, 26 Oct 2009 21:56:52 +0000 (16:56 -0500)]
Update attached status when gprs status changes
Denis Kenzior [Mon, 26 Oct 2009 21:55:03 +0000 (16:55 -0500)]
Fix: notify_attached was only used when detached
The standard only specifies that the context might have been detached by
the network / mobile equipment. Not attached.
Denis Kenzior [Mon, 26 Oct 2009 21:54:18 +0000 (16:54 -0500)]
Add a master function for updating attached state
Denis Kenzior [Mon, 26 Oct 2009 21:20:36 +0000 (16:20 -0500)]
Fixup initialization logic
Denis Kenzior [Mon, 26 Oct 2009 21:19:54 +0000 (16:19 -0500)]
Fix: Initialize registration statuses
Denis Kenzior [Mon, 26 Oct 2009 21:18:17 +0000 (16:18 -0500)]
Fix: Reset netreg to 0 when unregistered
Andrzej Zaborowski [Sun, 25 Oct 2009 08:35:26 +0000 (09:35 +0100)]
Refactor: Make GPRS use information from netreg
Andrzej Zaborowski [Sun, 25 Oct 2009 08:35:26 +0000 (09:35 +0100)]
Fix: Don't attach if searching
Don't ask driver to attach GPRS if modem is already searching for an
operator.
Andrzej Zaborowski [Sun, 25 Oct 2009 08:14:54 +0000 (09:14 +0100)]
Fix interpretation of new GPRS registration status signal.
Denis Kenzior [Sat, 24 Oct 2009 17:19:58 +0000 (12:19 -0500)]
Fix: Fix segfault from improperly initialized data
Denis Kenzior [Sat, 24 Oct 2009 17:19:38 +0000 (12:19 -0500)]
Fix: Register for E2NAP notifications
Denis Kenzior [Sat, 24 Oct 2009 17:19:12 +0000 (12:19 -0500)]
Fix: ENAP=0 is the only way to use this
Marcel Holtmann [Sat, 24 Oct 2009 16:14:26 +0000 (01:14 +0900)]
Remove support for call forwarding and barring from MBM plugin
Marcel Holtmann [Sat, 24 Oct 2009 16:06:45 +0000 (01:06 +0900)]
Add test script for activating the first context
Marcel Holtmann [Sat, 24 Oct 2009 15:57:32 +0000 (00:57 +0900)]
Add simple test script for creating a context and setting APN
Marcel Holtmann [Sat, 24 Oct 2009 15:51:29 +0000 (00:51 +0900)]
Fix tiny copy-and-past left-over
Marcel Holtmann [Sat, 24 Oct 2009 15:49:08 +0000 (00:49 +0900)]
Add test script for showing primary data contexts
Marcel Holtmann [Sat, 24 Oct 2009 15:42:23 +0000 (00:42 +0900)]
Add some extra special handling to list-modem test script
Andrzej Zaborowski [Sat, 24 Oct 2009 09:28:07 +0000 (11:28 +0200)]
Register gprs-context on calypso modem/phonesim.
Andrzej Zaborowski [Sat, 24 Oct 2009 09:27:23 +0000 (11:27 +0200)]
Just return success when value already set in SetProperty.
Denis Kenzior [Fri, 23 Oct 2009 20:17:55 +0000 (15:17 -0500)]
Fix: Some modems report PDP_type in a list
Denis Kenzior [Fri, 23 Oct 2009 20:17:33 +0000 (15:17 -0500)]
Add GPRS context setup to MBM plugin
Denis Kenzior [Fri, 23 Oct 2009 20:16:56 +0000 (15:16 -0500)]
Fix: Connect up gprs and gprs_context
Denis Kenzior [Fri, 23 Oct 2009 20:15:33 +0000 (15:15 -0500)]
Fix: Typo in property name
Denis Kenzior [Fri, 23 Oct 2009 18:49:14 +0000 (13:49 -0500)]
Add initial implementation of MBM gprs context
Denis Kenzior [Fri, 23 Oct 2009 17:55:03 +0000 (12:55 -0500)]
Fix: Update Init string & shutdown string for mbm
Denis Kenzior [Fri, 23 Oct 2009 17:14:47 +0000 (12:14 -0500)]
Register for CGEV indications in gprs context
Denis Kenzior [Fri, 23 Oct 2009 17:14:34 +0000 (12:14 -0500)]
Remove unused code and make compiler happy
Denis Kenzior [Fri, 23 Oct 2009 17:08:48 +0000 (12:08 -0500)]
Add basic atmodem gprs context implementation
Denis Kenzior [Fri, 23 Oct 2009 16:14:55 +0000 (11:14 -0500)]
Add implementation of GPRS context atom
Denis Kenzior [Fri, 23 Oct 2009 01:59:07 +0000 (20:59 -0500)]
Fix: Rename Flag
Denis Kenzior [Fri, 23 Oct 2009 01:32:36 +0000 (20:32 -0500)]
Deactivate the context for removal if active
Denis Kenzior [Fri, 23 Oct 2009 00:00:38 +0000 (19:00 -0500)]
Refactor/Implement basic activate logic
Not yet tested
Denis Kenzior [Thu, 22 Oct 2009 23:35:44 +0000 (18:35 -0500)]
Add stub of gprs context deactivated
Denis Kenzior [Thu, 22 Oct 2009 23:35:32 +0000 (18:35 -0500)]
Fix: Typos
Denis Kenzior [Thu, 22 Oct 2009 23:00:33 +0000 (18:00 -0500)]
Refactor: Initialization code
Denis Kenzior [Thu, 22 Oct 2009 23:00:07 +0000 (18:00 -0500)]
Add GPRS registration status implementation
Denis Kenzior [Thu, 22 Oct 2009 22:56:42 +0000 (17:56 -0500)]
Remove unused code
Denis Kenzior [Thu, 22 Oct 2009 22:50:30 +0000 (17:50 -0500)]
Fix: Style
Denis Kenzior [Thu, 22 Oct 2009 22:50:20 +0000 (17:50 -0500)]
Remove unused functions
Denis Kenzior [Thu, 22 Oct 2009 22:49:49 +0000 (17:49 -0500)]
Refactor: Deactivate all contexts function
Denis Kenzior [Thu, 22 Oct 2009 22:49:36 +0000 (17:49 -0500)]
Remove unused function
Denis Kenzior [Thu, 22 Oct 2009 22:49:22 +0000 (17:49 -0500)]
Refactor: GPRS Remove Context function
Denis Kenzior [Thu, 22 Oct 2009 22:48:39 +0000 (17:48 -0500)]
Refactor: GPRS CreateContext function
Denis Kenzior [Thu, 22 Oct 2009 22:46:50 +0000 (17:46 -0500)]
Remove unused function
Denis Kenzior [Thu, 22 Oct 2009 22:46:10 +0000 (17:46 -0500)]
Refactor: context object path list
Denis Kenzior [Thu, 22 Oct 2009 22:44:14 +0000 (17:44 -0500)]
Refactor: Context set_property function
Denis Kenzior [Thu, 22 Oct 2009 22:42:40 +0000 (17:42 -0500)]
Refactor: Context get_properties
Denis Kenzior [Thu, 22 Oct 2009 22:42:01 +0000 (17:42 -0500)]
Refactor: context finding by path
Denis Kenzior [Thu, 22 Oct 2009 22:41:23 +0000 (17:41 -0500)]
Remove unused function
Denis Kenzior [Thu, 22 Oct 2009 22:39:57 +0000 (17:39 -0500)]
Add CID range function
Denis Kenzior [Thu, 22 Oct 2009 22:37:39 +0000 (17:37 -0500)]
Refactor: Primary Context dbus reg/unreg
Denis Kenzior [Thu, 22 Oct 2009 22:23:44 +0000 (17:23 -0500)]
Refactor: Use ofono_bool_t instead of int
Denis Kenzior [Thu, 22 Oct 2009 22:20:50 +0000 (17:20 -0500)]
Refactor: Rename GPRS type enums
Denis Kenzior [Thu, 22 Oct 2009 22:14:50 +0000 (17:14 -0500)]
Refactor: Split up GPRS into two atoms
Split up GPRS into two atoms: GPRS and GPRS Context. GPRS will handle
the areas of GPRS network registration, basic GPRS capability detection
and attach / detach.
GPRS Context will handle setting up / activating / deactivating the
indicidual contexts.
This will allow us to use the generic GPRS atom for most devices while
customizing the GPRS context accordingly.
Denis Kenzior [Thu, 22 Oct 2009 22:11:58 +0000 (17:11 -0500)]
Add InUse error type
Denis Kenzior [Tue, 20 Oct 2009 21:29:10 +0000 (16:29 -0500)]
Second round of renaming
Denis Kenzior [Tue, 20 Oct 2009 18:09:54 +0000 (13:09 -0500)]
Refactor: First round of renaming
Denis Kenzior [Tue, 20 Oct 2009 17:09:46 +0000 (12:09 -0500)]
Refactor: rename data-connection to gprs
Keep the name specific to GSM, other implementations will probably
require their own interfaces
Andrzej Zaborowski [Mon, 12 Oct 2009 21:35:59 +0000 (23:35 +0200)]
Add GPRS support
This commit implements the GPRS context setup and teardown according to
doc/dataconnectionmanager-api.txt
One issue with the AT implementation of the api is that "Powered" (a
read-write property) can be set independently of "Attached" (read-only
property) and remain set when "Attached" is clear. The semantics would
be that the network doesn't have resources to let the modem attach,
but the modem waits for the resources to become available and then
attaches. On AT the modem is in this state only when executing +CGATT,
so currently the code will rerun +CGATT as soon as the previous one
returns with error, probably starving other commands. A possible
workaround would be for "Powered" to flip back to False after the modem
fails to attach once, or give up on having separate properties.
Alternatively we could re-try to attach periodically but on one modem
I've tried +CGATT fails after about 1 minute (that's the Calypso) and
on another only about 0.5s (Nokia phones with AT emulation).
When "Powered" is set and "RoamingAllowed" is clear and we manage to
attach and find that we're roaming, ofono resets "Powered".
We may want to catch the user trying to dial *99***1# which is the
backwards compatibility quirk for old modems (same way ofono parses
USSD strings).
Denis Kenzior [Fri, 23 Oct 2009 18:56:26 +0000 (13:56 -0500)]
Fix: Invalid call state transition
When an active and a waiting call exist, and the active is released the
waiting call becomes incoming. This wasn't properly handled by the
generic at driver.
Zhang, Zhenhua [Fri, 23 Oct 2009 10:20:13 +0000 (18:20 +0800)]
Replace Glib type with standard C type
Zhenhua Zhang [Thu, 22 Oct 2009 16:47:08 +0000 (00:47 +0800)]
Handle right bracket in next_unquoted_string
Denis Kenzior [Thu, 22 Oct 2009 00:07:37 +0000 (19:07 -0500)]
Mention Ryan's contributions