platform/upstream/dotnet/runtime.git
5 years agoFix and re-enable AddFontFile_Directory_ThrowsFileNotFoundException test, rename...
Frederik Carlier [Wed, 26 Jun 2019 13:41:44 +0000 (15:41 +0200)]
Fix and re-enable AddFontFile_Directory_ThrowsFileNotFoundException test, rename GetAdjustedPalette_InvalidTypes_ThrowsArgumentException (dotnet/corefx#38873)

* Fix and re-enable AddFontFile_Directory_ThrowsFileNotFoundException test

* Accept Desktop exception, too.

* Avoid two unit test with the same name

Commit migrated from https://github.com/dotnet/corefx/commit/d73a90663d15b7d80dcecb026b37d3b87267d116

5 years agoDisable some tests for Windows IoT (dotnet/corefx#38912)
Dan Moseley [Wed, 26 Jun 2019 13:36:14 +0000 (06:36 -0700)]
Disable some tests for Windows IoT (dotnet/corefx#38912)

* Disable for IoT

* IconConverter tests

* S.DS

* S.DS.AM

* typo

* Fact to Theory

Commit migrated from https://github.com/dotnet/corefx/commit/56e68cff21c62181bb0b8d8d3302cbbbeef8eb57

5 years agoEnable fixed tests, formatting update (dotnet/corefx#38909)
buyaa-n [Wed, 26 Jun 2019 07:27:55 +0000 (00:27 -0700)]
Enable fixed tests, formatting update (dotnet/corefx#38909)

Commit migrated from https://github.com/dotnet/corefx/commit/219b67118e3a2d539afc1ff3bb2c10e1bc7b03d2

5 years agoCoreFx dotnet/corefx#38894: Use (s)byte and (u)int16 get apis (dotnet/corefx#38905)
Mandar Sahasrabuddhe [Wed, 26 Jun 2019 07:27:00 +0000 (12:57 +0530)]
CoreFx dotnet/corefx#38894: Use (s)byte and (u)int16 get apis (dotnet/corefx#38905)

Commit migrated from https://github.com/dotnet/corefx/commit/dad20ba6f801ac7089f73b828ea2296b0d1348f9

5 years agoImplement MaxResponseHeadersLength for HTTP2 (dotnet/corefx#38560)
Cory Nelson [Wed, 26 Jun 2019 07:04:36 +0000 (00:04 -0700)]
Implement MaxResponseHeadersLength for HTTP2 (dotnet/corefx#38560)

Implement MaxResponseHeadersLength for HTTP2. Resolves dotnet/corefx#35528.
Implement huffman-coded header support in Http2LoopbackServer.
Move HuffmanDecodingTests from functional to unit tests to avoid reflection.

Commit migrated from https://github.com/dotnet/corefx/commit/f0ec881bbb7945e35e3cf6862ea309b1143659f7

5 years agoDefault distro version for tests (dotnet/corefx#38860)
Dan Moseley [Wed, 26 Jun 2019 02:44:22 +0000 (19:44 -0700)]
Default distro version for tests (dotnet/corefx#38860)

* Default distro version for tests

* Move it

* typo

* typo

* Update PlatformApis.Unix.cs

Commit migrated from https://github.com/dotnet/corefx/commit/4f0d10773ccbb4849b869b6a0a73d5938f1804bd

5 years ago Checking if the eventlog registry key is actually an eventlog (dotnet/corefx#38430)
Anirudh Agnihotry [Wed, 26 Jun 2019 01:48:20 +0000 (18:48 -0700)]
 Checking if the eventlog registry key is actually an eventlog (dotnet/corefx#38430)

*  checking if the eventlog registry key is actually an eventlog

* optimising the code a  little bit

* modified test

* skipping test on .net frameworj

Commit migrated from https://github.com/dotnet/corefx/commit/18f5e7b7f9c13b309f7ac978747c828ed417e543

5 years agoAdd WritePropertyName standlone API on the Utf8JsonWriter. (dotnet/corefx#38864)
Ahson Khan [Tue, 25 Jun 2019 22:07:36 +0000 (15:07 -0700)]
Add WritePropertyName standlone API on the Utf8JsonWriter. (dotnet/corefx#38864)

* Add WritePropertyName standlone API on the Utf8JsonWriter.

* Fix write indented, add more tests, and more debug.asserts.

* Remove _isProperty field and rely on _tokenType ==
JsonTokenType.PropertyName

* Auto-gen the ref.

* Address PR feedback.

Commit migrated from https://github.com/dotnet/corefx/commit/a5b35f5600b615d4f30c64183891c83fd76bf491

5 years agoRemove IFormattable implementations on intrinsic Vector types
Jan Kotas [Tue, 25 Jun 2019 20:11:52 +0000 (13:11 -0700)]
Remove IFormattable implementations on intrinsic Vector types

Commit migrated from https://github.com/dotnet/corefx/commit/aba8dac72c4a672305b25a1a9a05befad1a55c70

5 years agoAdd better validation for JsonCommentHandling enum and re-order the values. (dotnet...
Ahson Khan [Tue, 25 Jun 2019 21:14:47 +0000 (14:14 -0700)]
Add better validation for JsonCommentHandling enum and re-order the values. (dotnet/corefx#38622)

* Add validation for JsonCommentHandling enum.

* Address PR feedback.

* Fix typos and make the checks consistent.

* Add parameter name to the argument OOR exception and update tests.

Commit migrated from https://github.com/dotnet/corefx/commit/0691e5ffc5b569730688f0a61aa63555db2b1e47

5 years agoNormalize generate ref source paths correctly (dotnet/corefx#38870)
Viktor Hofer [Tue, 25 Jun 2019 20:45:17 +0000 (22:45 +0200)]
Normalize generate ref source paths correctly (dotnet/corefx#38870)

* Normalize generate ref source paths correctly

* Trim trailing slash from RefPath

Commit migrated from https://github.com/dotnet/corefx/commit/27411a58170810f6334a722ae73e8354601dcb85

5 years agoFix infinite loop in JsonSerializer.WriteValue (dotnet/corefx#38892)
Brennan [Tue, 25 Jun 2019 20:32:00 +0000 (13:32 -0700)]
Fix infinite loop in JsonSerializer.WriteValue (dotnet/corefx#38892)

Commit migrated from https://github.com/dotnet/corefx/commit/98937e7f1d4882395722dedadcf57df23d0ea13f

5 years ago Fixing up HandleNull in JsonSerializer.Read to reset the property for dictionaries...
Tanner Gooding [Tue, 25 Jun 2019 19:46:27 +0000 (12:46 -0700)]
 Fixing up HandleNull in JsonSerializer.Read to reset the property for dictionaries. (dotnet/corefx#38704)

* Fixing up HandleNull in JsonSerializer.Read to reset the property for dictionaries.

* Adding regression tests for dotnet/corefx#38565

* Fixing HandleDictionary in JsonSerializer.Write to respect IgnoreNullValues

* Updating the Regression38565_Serialize test to not expect null

* Responding to PR feedback and adding a regression test for dotnet/corefx#38557

Commit migrated from https://github.com/dotnet/corefx/commit/78e00d4b0ad5b390c9a54431c632062392c3ed7e

5 years agoPreserve more envirnment variables during tests remote execution (dotnet/corefx#38889)
Tarek Mahmoud Sayed [Tue, 25 Jun 2019 19:45:33 +0000 (12:45 -0700)]
Preserve more envirnment variables during tests remote execution (dotnet/corefx#38889)

Commit migrated from https://github.com/dotnet/corefx/commit/3b25185ca127fdb8e31fc51854ce44484c758143

5 years agoCoreFx dotnet/corefx#36125 (Try)Get for byte sbyte short ushort (dotnet/corefx#38469)
Mandar Sahasrabuddhe [Tue, 25 Jun 2019 19:03:33 +0000 (00:33 +0530)]
CoreFx dotnet/corefx#36125 (Try)Get for byte sbyte short ushort (dotnet/corefx#38469)

* CoreFx dotnet/corefx#36125 (Try)Get for byte sbyte short ushort

* Init out values on failure return paths.

* APIs in JsonElement and related tests

* More test cases, test bug fixes, code fixes

Commit migrated from https://github.com/dotnet/corefx/commit/b2af402ee9f169be00b4be09887e6db0dba2bff1

5 years agoDisable failing Process test (dotnet/corefx#38885)
William Godbe [Tue, 25 Jun 2019 19:00:44 +0000 (12:00 -0700)]
Disable failing Process test (dotnet/corefx#38885)

Commit migrated from https://github.com/dotnet/corefx/commit/e4d34071b2049268283676152a61d1ed2cd52879

5 years agoUse SpanTestHelpers from Common within StringTests rather than TestHelpers which...
Ahson Khan [Tue, 25 Jun 2019 18:36:15 +0000 (11:36 -0700)]
Use SpanTestHelpers from Common within StringTests rather than TestHelpers which doesn't exist (dotnet/corefx#38865)

* Revert "Fix build break for TestHelpers, move to common and rename to MemoryTestHelpers"

This reverts commit dotnet/corefx@61f9b4c44336a7e32f8679e0a186a9177d384c49.

* Use SpanTestHelpers from Common rather than TestHelpers which doesn't
exist.

Commit migrated from https://github.com/dotnet/corefx/commit/edbee902747970e86dbcf19727e72b8216946bb8

5 years agoAdding tests covering the scenario listed in dotnet/corefx#38643 (dotnet/corefx#38696)
Tanner Gooding [Tue, 25 Jun 2019 18:11:44 +0000 (11:11 -0700)]
Adding tests covering the scenario listed in dotnet/corefx#38643 (dotnet/corefx#38696)

Commit migrated from https://github.com/dotnet/corefx/commit/2439b9a00bd3a8c4e4714470fee4f224978b5678

5 years agoDisable nano in PR CI (dotnet/corefx#38883)
Stephen Toub [Tue, 25 Jun 2019 15:39:51 +0000 (11:39 -0400)]
Disable nano in PR CI (dotnet/corefx#38883)

Commit migrated from https://github.com/dotnet/corefx/commit/16dd0366218f18065eb31e0f59bb0c0b63b62954

5 years agoSupport additional OIDs for SignedCms digest algorithms
Kevin Jones [Tue, 25 Jun 2019 14:45:59 +0000 (10:45 -0400)]
Support additional OIDs for SignedCms digest algorithms

If an existing CMS has a digest algorithm identifier of {Digest}withRSA, the algorithm will be treated as unknown, however this works in the Desktop .NET Framework. This adds support for those algorithm identifiers for signature verification, but not for creation.

Commit migrated from https://github.com/dotnet/corefx/commit/e40dbeb9c4adfec29e291e11e98d92924efea673

5 years agoAdded reflection emit member accessor (dotnet/corefx#38233)
Yoh Deadfall [Tue, 25 Jun 2019 14:18:12 +0000 (17:18 +0300)]
Added reflection emit member accessor (dotnet/corefx#38233)

Commit migrated from https://github.com/dotnet/corefx/commit/25374d33af29283db17bab255971b3f6f17c0fbf

5 years agoFix exception type tested for in SignerIdentifierType_InvalidValues (dotnet/corefx...
Jeremy Barton [Tue, 25 Jun 2019 13:47:49 +0000 (06:47 -0700)]
Fix exception type tested for in SignerIdentifierType_InvalidValues (dotnet/corefx#38847)

Commit migrated from https://github.com/dotnet/corefx/commit/df7147a81d664c1462bfa6e7bc2042b2afca4072

5 years agoUpdate docker images on linux (dotnet/corefx#38867)
Viktor Hofer [Tue, 25 Jun 2019 13:23:21 +0000 (15:23 +0200)]
Update docker images on linux (dotnet/corefx#38867)

Commit migrated from https://github.com/dotnet/corefx/commit/c12b7dcd08eda9489d88fa808707fda28f60b24d

5 years agoRemove TargetSite checks from DictionaryConcurrentAccessDetection (dotnet/corefx...
Stephen Toub [Tue, 25 Jun 2019 12:49:25 +0000 (08:49 -0400)]
Remove TargetSite checks from DictionaryConcurrentAccessDetection (dotnet/corefx#38856)

Commit migrated from https://github.com/dotnet/corefx/commit/836ebdb1128a0137d7d3337a2c240856c1085e86

5 years agoFix XmlLicenseTransformTest.ItDecryptsLicense test
Stephen Toub [Tue, 25 Jun 2019 04:59:16 +0000 (00:59 -0400)]
Fix XmlLicenseTransformTest.ItDecryptsLicense test

Use a phrase that can't be valid base64.

Commit migrated from https://github.com/dotnet/corefx/commit/60d8aa31a4c1ffa0e125bd7941aca171439a2f72

5 years agoMerge pull request dotnet/corefx#38854 from scalablecory/fix-ShutdownIgnoringErrorsAsync
Cory Nelson [Tue, 25 Jun 2019 00:49:33 +0000 (17:49 -0700)]
Merge pull request dotnet/corefx#38854 from scalablecory/fix-ShutdownIgnoringErrorsAsync

Eat SocketException during Http2LoopbackConnection.ShutdownIgnoringErrorsAsync

Commit migrated from https://github.com/dotnet/corefx/commit/d36898b35b10eb6f7ad07023b1fca94640e78ecc

5 years agoResolve an exception affecting innerloop CI when Socket.Shutdown() fails during Http2...
Cory Nelson [Tue, 25 Jun 2019 00:43:41 +0000 (17:43 -0700)]
Resolve an exception affecting innerloop CI when Socket.Shutdown() fails during Http2LoopbackConnection.ShutdownIgnoringErrorsAsync()

Commit migrated from https://github.com/dotnet/corefx/commit/e514b0fba5693da417c79f87b10211184472a970

5 years agoRegenerate ref against implementation and add nullable annotations for System.Reflect...
Santiago Fernandez Madero [Tue, 25 Jun 2019 00:12:35 +0000 (19:12 -0500)]
Regenerate ref against implementation and add nullable annotations for System.Reflection.Emit (dotnet/corefx#38513)

* Regenerate reference assembly against implementation

* Add nullable annotations to ref assembly

* API review feedback

* Fix build break

Commit migrated from https://github.com/dotnet/corefx/commit/d688b187115d70ecd6df79a9cb9a04e46b1b00e1

5 years agoFix build break for TestHelpers, move to common and rename to MemoryTestHelpers
Santiago Fernandez Madero [Mon, 24 Jun 2019 20:29:23 +0000 (13:29 -0700)]
Fix build break for TestHelpers, move to common and rename to MemoryTestHelpers

Commit migrated from https://github.com/dotnet/corefx/commit/61f9b4c44336a7e32f8679e0a186a9177d384c49

5 years agoupdate MemoryExtensions ToUpper/ToLower tests for throws on overlapping buffer
Marco Rossignoli [Sat, 22 Jun 2019 09:37:39 +0000 (11:37 +0200)]
update MemoryExtensions ToUpper/ToLower tests for throws on overlapping buffer

address PR feedback

update tests

Address PR feedback

address PR feedback

Commit migrated from https://github.com/dotnet/corefx/commit/3d9e91a1885577f0043884f8818c9c3c97a72298

5 years agoUpdate StackTrace tests after nullable changes
Santiago Fernandez Madero [Fri, 21 Jun 2019 04:58:30 +0000 (21:58 -0700)]
Update StackTrace tests after nullable changes

Commit migrated from https://github.com/dotnet/corefx/commit/4f707dc836e088d5c56ac934a0ba425d88938b37

5 years agoHandle Byte Order Mark in Utf8JsonReader.Read (dotnet/corefx#38470)
Prashanth Govindarajan [Mon, 24 Jun 2019 22:48:12 +0000 (15:48 -0700)]
Handle Byte Order Mark in Utf8JsonReader.Read (dotnet/corefx#38470)

* Handle Byte Order Mark in Utf8JsonReader.Read

* Address feedback

Commit migrated from https://github.com/dotnet/corefx/commit/2366ba3fe5c2f531f7be5f4810d3829301d8d3d6

5 years agoTest for fix of issue dotnet/corefx#3408
imcarolwang [Mon, 24 Jun 2019 08:30:36 +0000 (01:30 -0700)]
Test for fix of issue dotnet/corefx#3408

Commit migrated from https://github.com/dotnet/corefx/commit/57a2750da0bf6ac6e421dda43c468f485dba8ae0

5 years agoClean up System.Drawing.Common unit tests (dotnet/corefx#38771)
Frederik Carlier [Mon, 24 Jun 2019 21:25:32 +0000 (23:25 +0200)]
Clean up System.Drawing.Common unit tests (dotnet/corefx#38771)

* LinearGradientBrushTests: Add missing using statements

* EncoderParametersTests: Add missing using statements

* EncoderParametertests: Additional using statements

* GraphicsPathTests: Add using statements

* Add missing using statements

* RegionTests: Add missing using statements

* Fix typo

* MatrixTests: Add using statements

* GraphicsTests: Add missing using statements

* Fix ConditionalTheory -> ConditionalFact

* Clone the clip before applying a transform

* Convert Rotate1bit4bit to a theory

* SurroundColors_Null_ThrowsArgumentNullException: Theory -> Fact

* Check for a NullReferenceException instead of an ArgumentNullException

This test was previously disabled (because it was incorrectly marked as a theory instead of a fact).

This is the current behavior on NetFX.

* No parameter name to validate

* Don't use statics for disposed objects

* Invoke the finalizer during the test

* PR feedback

* PR feedback

Commit migrated from https://github.com/dotnet/corefx/commit/8ede3e8c930cd4c1a466d0b8209d0128cbfda89a

5 years agoTweak diagnostics for Dns_GetHostEntry_HostString_Ok failures in CI (dotnet/corefx...
Stephen Toub [Mon, 24 Jun 2019 21:21:07 +0000 (17:21 -0400)]
Tweak diagnostics for Dns_GetHostEntry_HostString_Ok failures in CI (dotnet/corefx#38831)

Gather more details when Dns.GetHostEntry("") fails in CI with "Name or service not known".

Commit migrated from https://github.com/dotnet/corefx/commit/ba5c2769a01a8480824ce1b3a3cf40408325ff94

5 years agoRevert "Tweak preferLocal value in System.Net.Sockets (dotnet/corefx#37369)" (dotnet...
Stephen Toub [Mon, 24 Jun 2019 21:18:01 +0000 (17:18 -0400)]
Revert "Tweak preferLocal value in System.Net.Sockets (dotnet/corefx#37369)" (dotnet/corefx#38829)

This reverts commit dotnet/corefx@bf0fb29fb55cf4c3d9063c78e8f72fb9cd4d041b.

Commit migrated from https://github.com/dotnet/corefx/commit/e2042dba58c522ab2dcc566a92c866b6186ce0dc

5 years agoRemove faulty Http2Stream asserts (dotnet/corefx#38842)
Stephen Toub [Mon, 24 Jun 2019 21:14:34 +0000 (17:14 -0400)]
Remove faulty Http2Stream asserts (dotnet/corefx#38842)

These asserts are only valid if we're still holding the lock, which we're not.

Commit migrated from https://github.com/dotnet/corefx/commit/3c0d8436115c3d6905cd46d37fde980f73281995

5 years agoAPI Review feedback (dotnet/corefx#38826)
Santiago Fernandez Madero [Mon, 24 Jun 2019 19:57:46 +0000 (14:57 -0500)]
API Review feedback (dotnet/corefx#38826)

Commit migrated from https://github.com/dotnet/corefx/commit/ab249fa17463b2ea07bd43fc09b96320e84724d2

5 years agoAdd nullable annotations to System.Reflection.Emit.ILGeneration (dotnet/corefx#38514)
Santiago Fernandez Madero [Mon, 24 Jun 2019 19:24:43 +0000 (14:24 -0500)]
Add nullable annotations to System.Reflection.Emit.ILGeneration (dotnet/corefx#38514)

* Add nullable annotations to System.Reflection.Emit.ILGeneration

* API Review feedback

Commit migrated from https://github.com/dotnet/corefx/commit/792bebecab6a7c5fc721939891a844d8e94df3c8

5 years agoMerge pull request dotnet/corefx#38832 from dotnet/stephentoub-disabletest
Cory Nelson [Mon, 24 Jun 2019 18:59:06 +0000 (11:59 -0700)]
Merge pull request dotnet/corefx#38832 from dotnet/stephentoub-disabletest

Disable Http2_FlowControl_ClientDoesNotExceedWindows test

Commit migrated from https://github.com/dotnet/corefx/commit/db1ef41efc7757bc88c52f46141092611855f2b0

5 years agoMinor follow-ups/cleanups in Http2Connection and Http2Stream (dotnet/corefx#38817)
Stephen Toub [Mon, 24 Jun 2019 18:58:09 +0000 (14:58 -0400)]
Minor follow-ups/cleanups in Http2Connection and Http2Stream (dotnet/corefx#38817)

- Fix/adjust several uses of string interpolation in SocketsHttpHandler.
- Remove a Task.WhenAny allocation from SendAsync in the common case where there is no request content or where the request content sending completes synchronously.
- In GetWaiterTask use CT.UnsafeRegister instead of Register, as ExecutionContext, as the callback doesn't need context flowed.
- In GetWaiterTask, avoid allocating an unnecessary Task for the _waitSource if the token isn't cancelable.
- In GetWaiter task's cancellation callback, avoid allocating an OCE not associated with the wait.  Instead, just complete the waiter, and then rely on the subsequent cancellation check to propagate cancellation appropriately.
- Use CompareExchange to write to _abortException so that _abortException never changes its value once it's non-null.  We currently have several code paths that check the type of _abortException and then do something based on it, and that could cause issues if its type could change between the check and the action.
- Clean up HTTP2 SendAsync method, e.g. remove unnecessary tmps, remove duplicated await, use slightly more descriptive variable names, only wrap OCE with one for cancellationToken if cancellationToken has had cancellation requested.
- Replace a use of ExceptionDispatchInfo.Throw with just throw.  The former should be used when and only when throwing an exception object that may previously have been thrown; in this case we're throwing a new object that was never thrown before.
- Add detailed comment describing thread-safety around Http2Stream._waitSource
- Clean up a few comments
- Add some missing .ConfigureAwait(false) in loopback servers

Commit migrated from https://github.com/dotnet/corefx/commit/e771af6f93fe4bdc9e6172563e42422d5fdd30ff

5 years agoDisable Http2_FlowControl_ClientDoesNotExceedWindows test
Stephen Toub [Mon, 24 Jun 2019 18:53:53 +0000 (14:53 -0400)]
Disable Http2_FlowControl_ClientDoesNotExceedWindows test

Commit migrated from https://github.com/dotnet/corefx/commit/99d5257629744a6683ed3724fb8fa24852a4af86

5 years agoAdd nullable annotations to System.Resources.ResourceManager ref assembly (dotnet...
Santiago Fernandez Madero [Mon, 24 Jun 2019 18:49:43 +0000 (13:49 -0500)]
Add nullable annotations to System.Resources.ResourceManager ref assembly (dotnet/corefx#38518)

* Add nullable annotations to System.Resources.ResourceManager ref assembly

* Address API Review feedback

Commit migrated from https://github.com/dotnet/corefx/commit/ae7b3970bb2c8d76004ea397083ce7ceb1238133

5 years agoAdd nullable attributes to System.Runtime ref (dotnet/corefx#38732)
Santiago Fernandez Madero [Mon, 24 Jun 2019 18:32:36 +0000 (13:32 -0500)]
Add nullable attributes to System.Runtime ref (dotnet/corefx#38732)

Commit migrated from https://github.com/dotnet/corefx/commit/d3d1ab1c58862ebebe09d387631393a70982fe9a

5 years agoUpdating System.Text.Json package description (dotnet/corefx#38691)
Jose Perez Rodriguez [Mon, 24 Jun 2019 18:06:01 +0000 (11:06 -0700)]
Updating System.Text.Json package description (dotnet/corefx#38691)

* Updating System.Text.Json package description

* Fix ordering and namespace

* Fix description

Commit migrated from https://github.com/dotnet/corefx/commit/eebe43224d8994b5b47bc2906c271ea6f256728b

5 years agoFix overread when decoding X509KeyUsage extension on Windows
Jeremy Barton [Mon, 24 Jun 2019 17:44:37 +0000 (10:44 -0700)]
Fix overread when decoding X509KeyUsage extension on Windows

CryptDecodeObject on X509_KEY_USAGE always sets cbStructInfo to 32 (or 20 on x86),
reporting 8 bytes (both architectures) more than needed for the CRYPT_BIT_BLOB
structure (0 bytes more than the structure when transporting pbData=NULL).

However, that value is over-representative of the number of bytes actually
written (modified) in this case.  The CRYPT_BIT_BLOB contains a cbData saying
how long the actual payload is (0 (pbData==NULL), 1, or 2 bytes), but
DecodeX509KeyUsageExtension didn't read it, just blindly read the value as a DWORD,
implicitly counting on the zero-init of arrays (and Win32's choice of values
combined with Little Endian layout).

By respecting the decoded cbData value (and not over-reading) the helper no
longer needs to manually clear the stackalloc.

Commit migrated from https://github.com/dotnet/corefx/commit/0a05173f98493547d40b1865808481e76ede1212

5 years agoHTTP2: Fix InboundWindowSize_Exceeded_Throw failure under load (dotnet/corefx#38736)
Cory Nelson [Mon, 24 Jun 2019 17:43:58 +0000 (10:43 -0700)]
HTTP2: Fix InboundWindowSize_Exceeded_Throw failure under load (dotnet/corefx#38736)

* Resolves dotnet/corefx#38708. Test tegression caused by different behavior under high load.

* Improve comment explaining inconsistency of exception source.

Commit migrated from https://github.com/dotnet/corefx/commit/6a81e6195005a9edb125d67e5865b1db1403838c

5 years agoRemove redundant tests and cleanup file (dotnet/corefx#38800)
Maryam Ariyan [Mon, 24 Jun 2019 17:43:13 +0000 (10:43 -0700)]
Remove redundant tests and cleanup file (dotnet/corefx#38800)

Commit migrated from https://github.com/dotnet/corefx/commit/b0c55b4aa644baa82f0f51b45bf3e5dc56a731ba

5 years agofollow up on duplex operation for HTTP/2 (dotnet/corefx#38226)
Tomas Weinfurt [Sun, 23 Jun 2019 21:42:52 +0000 (14:42 -0700)]
follow up on duplex operation for HTTP/2 (dotnet/corefx#38226)

* follow up on duplex operation

* updates

* add test for cancelation

* log responseHeadersTask if bodyTask fails first

* improve cancelation

* feedback from review

* update SendAsync_ConcurentSendReceive_Fail test

* feedback from review

* update SendSettingsAckAsync

* more HTTP/2 cancelation tests

* update test to accept any derivative from OperationCanceledException

* feedback from review

* roll-back changes in AcceptConnectionAsync

Commit migrated from https://github.com/dotnet/corefx/commit/cad5159981f518f455be3528d0ee8eca2e00742a

5 years agoUpdated SDK and cmake version
Viktor Hofer [Sun, 23 Jun 2019 19:44:44 +0000 (21:44 +0200)]
Updated SDK and cmake version

Commit migrated from https://github.com/dotnet/corefx/commit/4f54051ba4ceeb7ce5d05f5896378b2e8c293d2e

5 years agoFix SslStream client auth with intermediate certificates on Linux (dotnet/corefx...
David Shulman [Sun, 23 Jun 2019 04:12:35 +0000 (21:12 -0700)]
Fix SslStream client auth with intermediate certificates on Linux (dotnet/corefx#38789)

On Linux, a client TLS certificate chaining to multiple intermediate certificates wasn't
sending the complete list of intermediates because the final one in the chain wasn't
trusted. This differs from Windows behavior. This was causing the application to fail
to authenticate to the payment provider in the repro.

This PR fixes SslStream so that it will send the complete list of intermediates if the
chain build operation results in a "PartialChain" instead of a fully trusted chain.

Due to the complexity of this scenario, I didn't write a standalone CI test. But I was
able to run the original repro (using a docker container) to validate the fix.

Fixes dotnet/corefx#37927

Commit migrated from https://github.com/dotnet/corefx/commit/3b39190472c73ef0c4da485bfba0aa57f9ae3b37

5 years agoRemove Serialization Guard public APIs (dotnet/corefx#38739)
Levi Broderick [Sun, 23 Jun 2019 02:48:00 +0000 (19:48 -0700)]
Remove Serialization Guard public APIs (dotnet/corefx#38739)

* Remove Serialization Guard public APIs
- Also refactors reflection helpers into separate file

* PR feedback - remove DeserializationBlockedException refs entirely

Commit migrated from https://github.com/dotnet/corefx/commit/8b73a6dfacccefa8d160077ebff11007ff72fda3

5 years agoPrefer ILLinkTrim.xml over InternalsVisibleTo (System.Text.Encodings.Web) (dotnet...
Levi Broderick [Sun, 23 Jun 2019 00:19:02 +0000 (17:19 -0700)]
Prefer ILLinkTrim.xml over InternalsVisibleTo (System.Text.Encodings.Web) (dotnet/corefx#38787)

Commit migrated from https://github.com/dotnet/corefx/commit/22ce0f6e236001f8280c5f8639f546a301a89a6c

5 years agoFix helper thread stack size for Alpine (dotnet/corefx#38743)
Jan Vorlicek [Sat, 22 Jun 2019 22:06:44 +0000 (00:06 +0200)]
Fix helper thread stack size for Alpine (dotnet/corefx#38743)

* Fix helper thread stack size for Alpine

CoreFX creates a helper thread for handling some signals. This thread is
created using pthread API without explicit setting of stack size. That
means that on Alpine, it gets only 85kB of stack. We have hit stack
overflow in one of our coreclr tests in checked build due to that.

This change sets the default stack size of that thread to 512kB,
which should be sufficient.

* Make the stack size setting non-release build only

In release build, the stack is sufficient.
I've also spotted that in the previous commit, I've actually missed
passing the attributes to the pthread_create, so I am fixing that.

Commit migrated from https://github.com/dotnet/corefx/commit/627c1007a297e947962c2d5269dbe20063144fbf

5 years agoFix multiple remarks in System.Text.Json Xml docs (dotnet/corefx#38690)
Ganbarukamo41 [Sat, 22 Jun 2019 22:03:40 +0000 (07:03 +0900)]
Fix multiple remarks in System.Text.Json Xml docs (dotnet/corefx#38690)

* Fix multiple remarks in System.Text.Json Xml docs

* Remove unnecessary paragraph tags

* Use returns tag instead of remarks

Commit migrated from https://github.com/dotnet/corefx/commit/be73988bed4a904a3f1f66db752b6ae209ca28f1

5 years agoAdd support for NumericString to X500DistinguishedName
Jeremy Barton [Sat, 22 Jun 2019 03:59:30 +0000 (20:59 -0700)]
Add support for NumericString to X500DistinguishedName

An X500DN which contains a valid NumericString will now not cause the
entire string to turn into the empty string; which (per the tests) matches the
Windows/NetFX behavior.

Certificates with NumericString subjects do not load on macOS, because the OS considers them invalid.

Commit migrated from https://github.com/dotnet/corefx/commit/d7631df16a92da0e21bcb64240d5007f0dab95ed

5 years agoAdd UTF-8 support to TextEncoder (dotnet/corefx#38356)
Levi Broderick [Sat, 22 Jun 2019 03:38:05 +0000 (20:38 -0700)]
Add UTF-8 support to TextEncoder (dotnet/corefx#38356)

Commit migrated from https://github.com/dotnet/corefx/commit/9b486c1ea7bcfe7d09206ae449bffb049754ade5

5 years agoRevert "Socket: Linux: unblock synchronous socket operations on Dispose (dotnet/coref...
David Shulman [Fri, 21 Jun 2019 23:51:34 +0000 (16:51 -0700)]
Revert "Socket: Linux: unblock synchronous socket operations on Dispose (dotnet/corefx#37486)" (dotnet/corefx#38764)

This reverts commit dotnet/corefx@3fac6ad5bc4576eb2216ccb24fbed2bf173d41f4.

Commit migrated from https://github.com/dotnet/corefx/commit/42ecf717478504fd7cc072f3586c6edd1ba57daa

5 years agoSwitch from IndexOf(string) to Contains(string) for better readability and performanc...
Andrii Siriak [Fri, 21 Jun 2019 22:25:09 +0000 (01:25 +0300)]
Switch from IndexOf(string) to Contains(string) for better readability and performance (dotnet/corefx#38757)

* Fix performance IndexOf(string) -> Contains(string)

* Make comparison ordinal

Commit migrated from https://github.com/dotnet/corefx/commit/8e23fa839544c1d0c18e3f728b439bf66cf125f3

5 years agoFix nested objects in object arrays (dotnet/corefx#38527)
Jeremy Kuhne [Fri, 21 Jun 2019 21:48:31 +0000 (14:48 -0700)]
Fix nested objects in object arrays (dotnet/corefx#38527)

We weren't recognizing polymorphism for json objects nested in .NET object arrays.

This change also hides the debugger backing field for clarity.

Commit migrated from https://github.com/dotnet/corefx/commit/8be1263dc00a0ce14b5c2dfb4077d4a92cbf6d3b

5 years agoImprove code coverage: Struct, value type test (dotnet/corefx#38403)
buyaa-n [Fri, 21 Jun 2019 20:02:44 +0000 (13:02 -0700)]
Improve code coverage: Struct, value type test (dotnet/corefx#38403)

Code coverage: Struct, value type tests

Commit migrated from https://github.com/dotnet/corefx/commit/c181ec76bbaf2d85883bef1328a7f61e5cbf8016

5 years agoadd path to assert (dotnet/corefx#38709)
Dan Moseley [Fri, 21 Jun 2019 17:04:56 +0000 (10:04 -0700)]
add path to assert (dotnet/corefx#38709)

Commit migrated from https://github.com/dotnet/corefx/commit/adfa9d3fab65929262aa1419289794282de95b44

5 years agoAdd Activity.SetIdFormat (dotnet/corefx#38628)
Liudmila Molkova [Fri, 21 Jun 2019 16:54:13 +0000 (09:54 -0700)]
Add Activity.SetIdFormat  (dotnet/corefx#38628)

* Add Activity.SetIdFormat dotnet/corefx#36999

* separate individual tests and run ones that access statics in remote executor

* Exception messages to Resources

* Review comments

* Fix tests

Commit migrated from https://github.com/dotnet/corefx/commit/1fa8627a53115e5244e2f17310fb3b5b8685ec7a

5 years agoAdditional custom converter support for System.Object (dotnet/corefx#38741)
Steve Harter [Fri, 21 Jun 2019 16:38:20 +0000 (09:38 -0700)]
Additional custom converter support for System.Object (dotnet/corefx#38741)

Commit migrated from https://github.com/dotnet/corefx/commit/f3ee3e12107597b27e3be31b81732e266a1c60c5

5 years agoImprove comment explaining inconsistency of exception source.
Cory Nelson [Fri, 21 Jun 2019 16:31:41 +0000 (09:31 -0700)]
Improve comment explaining inconsistency of exception source.

Commit migrated from https://github.com/dotnet/corefx/commit/0f966e368fef859e578c55b45bbdd7539a42405d

5 years agoMerge pull request dotnet/corefx#38746 from imcarolwang/wcfissue3408
Stephen Bonikowsky [Fri, 21 Jun 2019 16:10:45 +0000 (09:10 -0700)]
Merge pull request dotnet/corefx#38746 from imcarolwang/wcfissue3408

Config ReaderQotas.MaxStringContentLength has no effect for some test…

Commit migrated from https://github.com/dotnet/corefx/commit/7f4bbeb0e21c55d489d848440d92d7ff93cffb0c

5 years agoAdd netcoreapp3.0 ref to System.IO.Pipelines package (dotnet/corefx#38731)
Jose Perez Rodriguez [Fri, 21 Jun 2019 16:03:48 +0000 (09:03 -0700)]
Add netcoreapp3.0 ref to System.IO.Pipelines package (dotnet/corefx#38731)

* Add netcoreapp3.0 ref to System.IO.Pipelines package

* Removing Exclude Compile from package dependencies

* Apply PR Feedback

* Move the import of the Packaging.targets

Commit migrated from https://github.com/dotnet/corefx/commit/df62e8f9110c263a69d491bf771c210860209d4c

5 years agoRegenerate ref assembly against implementation and add nullable annotations for Syste...
Santiago Fernandez Madero [Fri, 21 Jun 2019 07:16:04 +0000 (00:16 -0700)]
Regenerate ref assembly against implementation and add nullable annotations for System.Reflection.Primitives (dotnet/corefx#38517)

* Regenerate ref assembly against implementation

* Add nullable annotations to System.Reflection.Primitives

Commit migrated from https://github.com/dotnet/corefx/commit/e5aa6a5b6df5593e17b794dfcf5cf7ec87e9ef1d

5 years agoAdd nullable annotations to System.Diagnostics.StackTrace ref (dotnet/corefx#38428)
Santiago Fernandez Madero [Fri, 21 Jun 2019 06:05:24 +0000 (23:05 -0700)]
Add nullable annotations to System.Diagnostics.StackTrace ref (dotnet/corefx#38428)

* Add nullable annotations to System.Diagnostics.StackTrace ref

* Address nullable feedback from API Review

Commit migrated from https://github.com/dotnet/corefx/commit/f0b1b6ee70a36a13d097582bf7c982b7b9e8530d

5 years agoAdd nullable annotations to System.Diagnostics.Tracing ref (dotnet/corefx#38434)
Santiago Fernandez Madero [Fri, 21 Jun 2019 06:01:57 +0000 (23:01 -0700)]
Add nullable annotations to System.Diagnostics.Tracing ref (dotnet/corefx#38434)

* Add nullable annotations to System.Diagnostics.Tracing ref

* Address API Review feedback

Commit migrated from https://github.com/dotnet/corefx/commit/96fe425e1ae8e16dcd726b6bea7bf4bd6295ba6c

5 years agoRegenerate ref assembly and add nullable annotations for System.Reflection.Emit.Light...
Santiago Fernandez Madero [Fri, 21 Jun 2019 04:45:36 +0000 (21:45 -0700)]
Regenerate ref assembly and add nullable annotations for System.Reflection.Emit.Lightweight (dotnet/corefx#38515)

* Regenerate ref assembly against implementation

* Add nullable attributes to System.Reflection.Emit.LightWeight ref

Commit migrated from https://github.com/dotnet/corefx/commit/32d256ed4bf4daeab4b6b866fdef9fe921c8aa5f

5 years agoConfig ReaderQotas.MaxStringContentLength has no effect for some test data on NetCore.
imcarolwang [Fri, 21 Jun 2019 04:22:36 +0000 (21:22 -0700)]
Config ReaderQotas.MaxStringContentLength has no effect for some test data on NetCore.

Commit migrated from https://github.com/dotnet/corefx/commit/1a36d8c5a33bb1d8288e4fcb765d1f1b2576bf5e

5 years agoFix failing PostAsyncExpect100Continue_LateForbiddenResponse_Ok (dotnet/corefx#38742)
Krzysztof Wicher [Fri, 21 Jun 2019 04:07:00 +0000 (21:07 -0700)]
Fix failing PostAsyncExpect100Continue_LateForbiddenResponse_Ok (dotnet/corefx#38742)

* PostAsyncExpect100Continue: Keep client alive until server finishes

* replace MRE with ShutdownIgnoringErrorsAsync

Commit migrated from https://github.com/dotnet/corefx/commit/bff9c7b2ac6b0608f555b0d4b82b5ffb983a8f2f

5 years agoFix for issue where iterating over directories ending in a dot would unexpectedly...
Carlos Sanchez Lopez [Fri, 21 Jun 2019 02:58:33 +0000 (19:58 -0700)]
Fix for issue where iterating over directories ending in a dot would unexpectedly throw (dotnet/corefx#38489)

Issue
In Windows, when iterating over the files of a directory whose name ends in a dot, the iteration fails by throwing an unexpected exception, even when using the proper prefix "\\?\" for the full directory path.

Fix
Add a new boolean argument at the end of the enumeration function signatures that will indicate if the passed path is normalized or not. If it is normalized (which only happens when the path is created by us, not by the user), then we can create the handle using that path. If it's not normalized, we attempt to get its full path before creating the handle, which will throw if a full path can't be obtained.

Added a new unit test to verify the fixed behavior and updated some others whose behavior changed with this fix.

Commit migrated from https://github.com/dotnet/corefx/commit/8e95261ef710e0df980a6d46923eb3c0e8b0bc83

5 years agoImprove AssertExtensions.Equal performance for large arrays (dotnet/corefx#38725)
Jan Kotas [Fri, 21 Jun 2019 01:37:04 +0000 (18:37 -0700)]
Improve AssertExtensions.Equal performance for large arrays (dotnet/corefx#38725)

Assert.Equals on arrays boxes each element and then performs a complex
operation to compare each box. This is slow for large arrays, and extremely
slow for large arrays on checked CoreCLR.

Use AssertExtensions.Equal for large arrays in File.Copy tests to make
them reasonably fast on checked CoreCLR.

Commit migrated from https://github.com/dotnet/corefx/commit/c53300f0696c4817bc06a8ef8711a0bb46f362ec

5 years agoFix factory converters used as attributes (dotnet/corefx#38740)
Jeremy Kuhne [Thu, 20 Jun 2019 23:50:02 +0000 (16:50 -0700)]
Fix factory converters used as attributes (dotnet/corefx#38740)

* Fix factory converters used as attributes

Need to unpack the type specific converter when associating directly with a property.

Add default constructor to StringEnum converter.

* Move the factory unpack per feedback

Commit migrated from https://github.com/dotnet/corefx/commit/c6c1890ecd8e258f4a6e97a94e23881ed7a88392

5 years agoAdd support for Uri to JsonSerializer (dotnet/corefx#38655)
Layomi Akinrinade [Thu, 20 Jun 2019 22:38:10 +0000 (18:38 -0400)]
Add support for Uri to JsonSerializer (dotnet/corefx#38655)

* Add support for Uri to JsonSerializer

* Address review feedback

* Original string -> ToString

Commit migrated from https://github.com/dotnet/corefx/commit/b2aee04410ad2f3d4cd372b84b74bb246cb04e7d

5 years agoAdd nullable annotations to System.Security.Principal ref assembly (dotnet/corefx...
Santiago Fernandez Madero [Thu, 20 Jun 2019 22:36:27 +0000 (15:36 -0700)]
Add nullable annotations to System.Security.Principal ref assembly (dotnet/corefx#38519)

Commit migrated from https://github.com/dotnet/corefx/commit/fb38d14bd501f05dbd2f8c3c85ac262b821d97ca

5 years agoRegenerate ref assembly and add nullable annotations to ref assembly for System.Text...
Santiago Fernandez Madero [Thu, 20 Jun 2019 22:35:53 +0000 (15:35 -0700)]
Regenerate ref assembly and add nullable annotations to ref assembly for System.Text.Encoding.Extensions (dotnet/corefx#38520)

* Regenerate ref assembly against implementation

* Add nullable annotations to ref assembly

Commit migrated from https://github.com/dotnet/corefx/commit/1f4de5dff6dbfad36662af015142db5f6cb317f7

5 years agoUpdate StringTests for Span.ToLower/Upper with null culture (dotnet/corefx#38692)
Santiago Fernandez Madero [Thu, 20 Jun 2019 22:18:57 +0000 (15:18 -0700)]
Update StringTests for Span.ToLower/Upper with null culture (dotnet/corefx#38692)

* Update StringTests for Span.ToLower/Upper with null culture

* Darc update for dotnet/coreclr from build 20190619.2

* Darc update for dotnet/coreclr from build 20190620.2

Commit migrated from https://github.com/dotnet/corefx/commit/149bde31df743ba2a3d79a1944de411a8016acb4

5 years agoAdding validation to ensure all runtime-only files are present on all runtime-specifi...
Jose Perez Rodriguez [Thu, 20 Jun 2019 20:20:10 +0000 (13:20 -0700)]
Adding validation to ensure all runtime-only files are present on all runtime-specific packages (dotnet/corefx#38730)

Commit migrated from https://github.com/dotnet/corefx/commit/f80d2324feaf77b902ea93d76a3aa5236b0e2f27

5 years agoAdding unit test to cover NullReferenceException when passing null to a collection...
David Cantu [Thu, 20 Jun 2019 20:12:18 +0000 (13:12 -0700)]
Adding unit test to cover NullReferenceException when passing null to a collection (dotnet/corefx#38566)

* Adding unit test to cover NullReferenceException when passing null to a collaction (issue dotnet/corefx#37078)

* Adding Peer Review suggestions.

* Splitting referece type and value type test scenarios into separate methods.

Commit migrated from https://github.com/dotnet/corefx/commit/e044c800294595ad3abc6b6f3b4ff739a5b3c83a

5 years agoString enum converter (dotnet/corefx#38702)
Jeremy Kuhne [Thu, 20 Jun 2019 19:07:20 +0000 (12:07 -0700)]
String enum converter (dotnet/corefx#38702)

* String enum converter

Adds public converter for converting enums to strings and vice-versa.

* Address feedback.

* Missing a readonly

* Fix exception and swtich to ConcurrentDictionary

* Merge fixup

Commit migrated from https://github.com/dotnet/corefx/commit/66a18944db6d64b67adb1320d41004a9140babc1

5 years agoResolves dotnet/corefx#38708. Test tegression caused by different behavior under...
Cory Nelson [Thu, 20 Jun 2019 18:31:31 +0000 (11:31 -0700)]
Resolves dotnet/corefx#38708. Test tegression caused by different behavior under high load.

Commit migrated from https://github.com/dotnet/corefx/commit/9182532968d95f74be7df222318e52cc0834553f

5 years ago Increase sample size of random number generation tests
Kevin Jones [Thu, 20 Jun 2019 18:25:09 +0000 (14:25 -0400)]
 Increase sample size of random number generation tests

Commit migrated from https://github.com/dotnet/corefx/commit/ddb08d9df0b6206833f5ba143403a0a52cca2f40

5 years agoImprove test coverage for Convert.FromBase64 (dotnet/corefx#38724)
Jan Kotas [Thu, 20 Jun 2019 18:15:44 +0000 (11:15 -0700)]
Improve test coverage for Convert.FromBase64 (dotnet/corefx#38724)

Commit migrated from https://github.com/dotnet/corefx/commit/707b15859af2fb23e17acfdc915d4cb5ee9112ad

5 years ago[Tests]: JsonSerializer.ToString serialization tests containing Enum (dotnet/corefx...
Maryam Ariyan [Thu, 20 Jun 2019 17:49:32 +0000 (10:49 -0700)]
[Tests]: JsonSerializer.ToString serialization tests containing Enum (dotnet/corefx#38531)

Commit migrated from https://github.com/dotnet/corefx/commit/046dbada036d786f420a7775ebcfd51a2a777add

5 years agosupporting duplicate using hashsets (dotnet/corefx#38705)
Anirudh Agnihotry [Thu, 20 Jun 2019 17:47:42 +0000 (10:47 -0700)]
supporting duplicate using hashsets (dotnet/corefx#38705)

Commit migrated from https://github.com/dotnet/corefx/commit/24e81ed6260fabf1211510a93c24385204f08323

5 years agoFix exception tests to match CoreCLR change (dotnet/corefx#38727)
Dan Moseley [Thu, 20 Jun 2019 17:21:08 +0000 (10:21 -0700)]
Fix exception tests to match CoreCLR change (dotnet/corefx#38727)

Commit migrated from https://github.com/dotnet/corefx/commit/41f0787f93d6c51baf3cd90b39b6e572ce5c6582

5 years agoSocket: Linux: unblock synchronous socket operations on Dispose (dotnet/corefx#37486)
Tom Deseyn [Thu, 20 Jun 2019 16:31:19 +0000 (18:31 +0200)]
Socket: Linux: unblock synchronous socket operations on Dispose (dotnet/corefx#37486)

* Socket: Linux: unblock synchronous socket operations on Dispose

* Fix windows build

* TryUnblockSocket: always do an abortive close for TCP

* TryUnblockSocket: experiment, always call Shutdown

* SyncTcpReceiveSendGetsCancelledByDisposeOrClose: Don't check for abortive close

* Fix build

* Revert always shutdown to compare CI results

* PR feedback

* TcpReceiveSendGetsCanceledByDisposeOrClose: fix timing race

* TcpReceiveSendGetsCanceledByDisposeOrClose: fix timing race II

* Fix test

* TcpReceiveSendGetsCanceledByDisposeOrClose: fix timing race III

* TcpReceiveSendGetsCanceledByDisposeOrClose: only run on Sync

* Also perform abortive close when canceling async send/receive

* Fix aborted set to true

* Check what fails on OSX with Shutdown

* Revert "Check what fails on OSX with Shutdown"

This reverts commit dotnet/corefx@5ab7fce93c9f95a07ce8a1a3cdd3839ca4e6eb31.

* Don't perform abortive close for operations that were already canceled

* interrup  Accept/Listen on OSX

* Find out what Disconnectx does for different tests on CI machines

* Move Linux connect AF_UNSPEC and OSX disconnectx into pal Disconnect function, update tests for OSX

* Trigger CI

* TcpReceiveSendGetsCanceledByDispose: check SocketErrorCode

* TcpReceiveSendGetsCanceledByDispose: OSX is also performing an RST close for disconnectx

* Revert "TcpReceiveSendGetsCanceledByDispose: OSX is also performing an RST close for disconnectx"

This reverts commit dotnet/corefx@a8d5b02724d650866388b816cde58cb082a53d6e.

* TcpReceiveSendGetsCanceledByDispose: fix test for OSX

* call CancelIoEx to kick out pending operations

* Socket interop: replace IntPtr with SafeHandle

* Windows: RST close when operations were canceled

* Extend tests to check local SocketError

* test: update expected SocketErrors

* update tests: Apm API throws ObjectDisposedException instead of SocketException

* Extend asserts

* Update expected result for ConnectTask

* Update tests based on Windows behavior (https://github.com/dotnet/corefx/pull/37706)

* Map SocketErrors in Socket.cs

* Rewrite nullable asserts

* Fix test for Mac

* Handle SendFile SocketError

* SyncSendFileGetsCanceledByDispose: change how we generate the large file

* SyncSendFileGetsCanceledByDispose: ensure unique filename

* Fix NETFX build

* SyncSendFileGetsCanceledByDispose: skip on NetFramework

* PR feedback

* Fix broken build

* Perform DangerousAddRef for Socket used with UpdateAcceptContext socket option

Commit migrated from https://github.com/dotnet/corefx/commit/3fac6ad5bc4576eb2216ccb24fbed2bf173d41f4

5 years agoFix sequencing of MakeCommonResourcesPriFile (dotnet/corefx#38707)
Viktor Hofer [Thu, 20 Jun 2019 14:45:26 +0000 (16:45 +0200)]
Fix sequencing of MakeCommonResourcesPriFile (dotnet/corefx#38707)

* Fix sequencing of MakeCommonResourcesPriFile

* Disable pri file generation on allconfigs

* Disable testhost binplacing on allconfigurations

* Disable uap tool restore without testhost

* Manual darc update from build '20190421.1'

Commit migrated from https://github.com/dotnet/corefx/commit/375ba8f48581e36b02ee99691f55380bb42557c5

5 years agoEnforce JsonSerializerOptions.MaxDepth on write (dotnet/corefx#38706)
Steve Harter [Thu, 20 Jun 2019 14:41:49 +0000 (07:41 -0700)]
Enforce JsonSerializerOptions.MaxDepth on write (dotnet/corefx#38706)

Commit migrated from https://github.com/dotnet/corefx/commit/10a074131a98a41ee4542ac4ea7039f1f41b212b

5 years agoFix ipv6 address parsing with leading compressor (dotnet/corefx#38654)
Marco Rossignoli [Thu, 20 Jun 2019 14:24:33 +0000 (16:24 +0200)]
Fix ipv6 address parsing with leading compressor (dotnet/corefx#38654)

* fix ipv6 parse

* address PR feedback

* address PR feedback

Commit migrated from https://github.com/dotnet/corefx/commit/600469a826ecd26ea5710847557819eff78e3759

5 years agoDisable SocketsHttpHandlerTest_Http2.InboundWindowSize_Exceeded_Throw (dotnet/corefx...
Eric StJohn [Thu, 20 Jun 2019 13:56:15 +0000 (06:56 -0700)]
Disable SocketsHttpHandlerTest_Http2.InboundWindowSize_Exceeded_Throw (dotnet/corefx#38722)

Test is consistently failing in CI.

Commit migrated from https://github.com/dotnet/corefx/commit/468355e66daf9eaeb1978703fa6365cd1e37e644

5 years agoupdates to packaging APIs and fixes (dotnet/corefx#38699)
Steven Kirbach [Thu, 20 Jun 2019 05:09:50 +0000 (22:09 -0700)]
updates to packaging APIs and fixes (dotnet/corefx#38699)

* updates to packaging APIs and fixes

* removing checks entirely and fixing tests

* removing newline

* skipping tests on desktop

Commit migrated from https://github.com/dotnet/corefx/commit/74032a608cf39d8eaa2955cc46d0ac677e3ae12c

5 years agoRemove extended option in System.Reflection.AssemblyNameTests.FullName (dotnet/corefx...
Ryan Lucia [Thu, 20 Jun 2019 03:18:55 +0000 (23:18 -0400)]
Remove extended option in System.Reflection.AssemblyNameTests.FullName (dotnet/corefx#38687)

* Remove extended option in System.Reflection.AssemblyNameTests.FullName

* Remove ToLowerInvariant calls

* Remove another ToLowerInvariant call

* Remove another 'extended' option

Commit migrated from https://github.com/dotnet/corefx/commit/6c95084f64df294b645729aea9934f72271292eb

5 years agoAdd nullable annotations to System.Diagnostics.Tools ref (dotnet/corefx#38432)
Santiago Fernandez Madero [Thu, 20 Jun 2019 02:43:27 +0000 (19:43 -0700)]
Add nullable annotations to System.Diagnostics.Tools ref (dotnet/corefx#38432)

Commit migrated from https://github.com/dotnet/corefx/commit/f99d24a5eef5aeaa897e62b471c1815ea0175b9e

5 years agoAdding New Idictionary tests and fixing test name and input for type Mismatch (dotnet...
Anirudh Agnihotry [Thu, 20 Jun 2019 02:23:25 +0000 (19:23 -0700)]
Adding New Idictionary tests and fixing test name and input for type Mismatch (dotnet/corefx#38660)

* Adding New Idictionary tests and fixing test name and inout for type mismatch

* Changing name of the variable

Commit migrated from https://github.com/dotnet/corefx/commit/36678a0eabe03d786a5f16563ee04abd4b640d24

5 years agoUpdate unix-instructions.md (dotnet/corefx#38703)
Dan Moseley [Thu, 20 Jun 2019 01:56:10 +0000 (18:56 -0700)]
Update unix-instructions.md (dotnet/corefx#38703)

* Update unix-instructions.md

* Update unix-instructions.md

Commit migrated from https://github.com/dotnet/corefx/commit/055052f451d01c6f00209a682cac6f354caaa888

5 years ago[master] Update dependencies from dotnet/coreclr (dotnet/corefx#38679)
dotnet-maestro[bot] [Thu, 20 Jun 2019 01:50:19 +0000 (01:50 +0000)]
[master] Update dependencies from dotnet/coreclr (dotnet/corefx#38679)

* Update dependencies from https://github.com/dotnet/coreclr build 20190618.4

- Microsoft.NET.Sdk.IL - 3.0.0-preview7.19318.4
- Microsoft.NETCore.ILAsm - 3.0.0-preview7.19318.4
- Microsoft.NETCore.Runtime.CoreCLR - 3.0.0-preview7.19318.4

* IndexOfAny ZeroLength values

* Test updates for relaxed Array.Copy type checks

Fixes dotnet/corefx#38535

Commit migrated from https://github.com/dotnet/corefx/commit/51a9c8f1dc56d366f5eb435f231052e2614c7a76