platform/upstream/coreclr.git
7 years ago[Arm64] Fix instGen_Set_Reg_To_Imm per review
Steve MacLean, Qualcomm Datacenter Technologies, Inc [Thu, 11 May 2017 15:55:38 +0000 (15:55 +0000)]
[Arm64] Fix instGen_Set_Reg_To_Imm per review

7 years ago[Arm64] Use movn in instGen_Set_Reg_To_Imm
Steve MacLean, Qualcomm Datacenter Technologies, Inc [Mon, 8 May 2017 20:08:07 +0000 (20:08 +0000)]
[Arm64] Use movn in instGen_Set_Reg_To_Imm

Reduces total generated instructions
Fixes #3092

7 years agoUpdate CoreClr, CoreFx to preview2-25309-01, preview2-25309-01, respectively (#11427)
dotnet bot [Tue, 9 May 2017 14:32:46 +0000 (07:32 -0700)]
Update CoreClr, CoreFx to preview2-25309-01, preview2-25309-01, respectively (#11427)

7 years agoEnable build on old Linux (#11414)
Jan Vorlicek [Tue, 9 May 2017 09:03:32 +0000 (11:03 +0200)]
Enable build on old Linux (#11414)

This change enables building coreclr on old Linux distros that
don't have PR_SET_PTRACER and don't have _xstate struct in the
standard sigcontext.h header.

7 years agoAvoid throwing in the globalization managed callbacks (#11454)
Tarek Mahmoud Sayed [Tue, 9 May 2017 01:03:05 +0000 (18:03 -0700)]
Avoid throwing in the globalization managed callbacks (#11454)

* Avoid throwing in the globalization managed callbacks

* Add Assert

7 years agoFailFast stderr logging with stacktrace (#11397)
Viktor Hofer [Tue, 9 May 2017 00:41:06 +0000 (17:41 -0700)]
FailFast stderr logging with stacktrace (#11397)

7 years agoMerge pull request #11457 from jashook/arm64_pri1_tests
Jarret Shook [Mon, 8 May 2017 23:18:08 +0000 (16:18 -0700)]
Merge pull request #11457 from jashook/arm64_pri1_tests

[Arm64] For arm64 jobs build pri1 tests by default

7 years agoMerge pull request #11451 from pgavlin/gh11447
Pat Gavlin [Mon, 8 May 2017 22:56:54 +0000 (15:56 -0700)]
Merge pull request #11451 from pgavlin/gh11447

Fix issue #11447.

7 years ago[Arm64] For arm64 jobs build pri1 tests by default
jashook [Mon, 8 May 2017 22:41:12 +0000 (15:41 -0700)]
[Arm64] For arm64 jobs build pri1 tests by default

This relates to coreclr #11423, enabling pri1 tests to
be built.

7 years agoAdd assembly level attribute on CoreLib (#11449)
Alex Ghiondea [Mon, 8 May 2017 22:14:02 +0000 (15:14 -0700)]
Add assembly level attribute on CoreLib (#11449)

7 years agoAdd the "createdump" to the linux runtime package. (#11441)
Mike McLaughlin [Mon, 8 May 2017 20:34:41 +0000 (13:34 -0700)]
Add the "createdump" to the linux runtime package. (#11441)

7 years agoFix issue #11447.
Pat Gavlin [Mon, 8 May 2017 19:17:42 +0000 (12:17 -0700)]
Fix issue #11447.

This issue was caused by the code for PInvoke frame initialization reading
from the stub argument register after it had been trashed by prior
instructions. This change fixes this issue by inserting the PInvoke
frame initialization at the beginning of the scratch block into which it
is inserted rather than at the end.

Note that a more correct fix here would be to represent the stub
argument as a lclVar rather than a physical register; that work is
tracked by #11450.

7 years agoMake CoreCLR work properly under PaX's RANDMMAP (#11382)
Koundinya Veluri [Mon, 8 May 2017 19:16:21 +0000 (12:16 -0700)]
Make CoreCLR work properly under PaX's RANDMMAP (#11382)

Make CoreCLR work properly under PaX's RANDMMAP

Issues:
- The ExecutableMemoryAllocator is used to attempt to map native images into a memory range near libcoreclr so that its helper table can use short relative addresses for jumps to libcoreclr
  - RANDMMAP typically prevents mmap calls with a specific address from reserving memory at the requested address, so the executable memory allocator fails to reserve any memory. When Server GC is enabled, the large GC heap can exacerbate the issue by taking address space near libcoreclr.
- Native images are loaded far from libcoreclr, and now jump stub space needs to be allocated near the native image, but RANDMMAP typically prevents this too
- NGenReserveForJumpStubs is intended to reserve some memory near mapped native images for jump stubs, but that reservation is done with a separate mmap call in the same way as above and RANDMMAP typically prevents this too
- The JIT needs to allocate memory for code that may need to jump/call to a native image or libcoreclr, which may require jump stubs near the code that cannot be allocated. CodeHeapReserveForJumpStubs reserves space in code heap blocks without using a separate call to mmap, so this works, but without this environment variable by default there is still a good chance of failing.
- See https://github.com/dotnet/coreclr/blob/56d550d4f8aec2dd40b72a182205d0a2463a1bc9/Documentation/design-docs/jump-stubs.md for more details

Fixes #8480
- It would be ideal to fix all of the above properly, such that there would never be a need to attempt reserving memory within a certain range. Since we're running out of time for 2.0, I figured the following simpler, temporary solution that should cover most of the practical cases, may be appropriate for 2.0.
- Extended ExecutableMemoryAllocator to reserve address space even when it cannot do so near libcoreclr
- Had ClrVirtualAllocWithinRange use the executable memory allocator to reserve memory for jump stubs when the requested range is satisfied
- This covers a maximum of ~2 GB of executable code and should cover most of the practical cases. Once this space is exhausted, under RANDMMAP, native images loaded later will fail, and for jitted code the environment variable above can be used.

7 years agoMerge pull request #11445 from jashook/fix_build_break
Jarret Shook [Mon, 8 May 2017 19:14:18 +0000 (12:14 -0700)]
Merge pull request #11445 from jashook/fix_build_break

Add define for FEATURE_SIMD

7 years agoMerge pull request #11443 from DrewScoggins/CopyFix
Drew Scoggins [Mon, 8 May 2017 18:50:45 +0000 (11:50 -0700)]
Merge pull request #11443 from DrewScoggins/CopyFix

Fix copy error in perf script

7 years agoMerge pull request #11231 from russellhadley/UpdateEHDoc
Russell C Hadley [Mon, 8 May 2017 18:08:11 +0000 (11:08 -0700)]
Merge pull request #11231 from russellhadley/UpdateEHDoc

Update EH WriteThru doc with review feedback.

7 years agoUpdate doc with review feedback.
Russell Hadley [Wed, 26 Apr 2017 19:24:24 +0000 (12:24 -0700)]
Update doc with review feedback.

Factor in additional exception cases from Andy and fix some wording from
Joe.

7 years agoAdd define for FEATURE_SIMD
jashook [Mon, 8 May 2017 16:30:24 +0000 (09:30 -0700)]
Add define for FEATURE_SIMD

This fixs a build break in the desktop product.

7 years agoUse profile information to differentiate files
Drew Scoggins [Mon, 8 May 2017 17:19:05 +0000 (10:19 -0700)]
Use profile information to differentiate files

7 years agoMinor typo corrected (#11444)
Sebastian Lauber [Mon, 8 May 2017 16:08:27 +0000 (18:08 +0200)]
Minor typo corrected (#11444)

7 years agoChange xcopy to copy
Drew Scoggins [Mon, 8 May 2017 06:26:42 +0000 (23:26 -0700)]
Change xcopy to copy

7 years agoFix copy error in perf script
Drew Scoggins [Mon, 8 May 2017 05:09:20 +0000 (22:09 -0700)]
Fix copy error in perf script

When I merged the PR that enabled the lean runs I added another call to
our run script.  This run script had an assumption that it would only
ever be called once and as such would try and copy two files that had
the same name.  This would cause it to prompt to overwrite or not and
fail the run.  This change makes each copy unique based on the
collection flags that were used for collection.

7 years agoMake Debugger class static (#11439)
Justin Van Patten [Mon, 8 May 2017 03:42:41 +0000 (20:42 -0700)]
Make Debugger class static (#11439)

* Make Debugger class static

It's static in the .NET Standard and .NET Core refs, and in CoreRT's
implementation, so make it static in the CoreCLR implementation as well.
Also, minor cleanup while making changes here.

7 years agoLog Events to EventPipe on Linux (#11433)
Brian Robbins [Sat, 6 May 2017 19:36:08 +0000 (12:36 -0700)]
Log Events to EventPipe on Linux (#11433)

* Implement the EventPipe object model for providers and events.

* Plumb Runtime Events into EventPipe (#11145)

Plumb runtime ETW events into the EventPipe.

* Fix bug where all events except for SampleProfiler events were never enabled.

* Plumb EventPipeEventInstance through the EventPipe.

* Implement EventPipeFile and FastSerializer.

* Write event contents to the EventPipeFile.

* Only build EventPipe on Linux.

* Conditionally add a sentinel value marking event end.

* Send SampleProfiler events to the EventPipeFile.

* Fix provider ID printing to JSON file.

* Write the start date/time, timestamp, and clock frequency into the trace file.

* Support unloading of EventPipeProviders.

* Handle failure cases when we can't walk the stack or are shutting down.

* Fix a bug where we pass a null src pointer to memcpy.

7 years agoDelete dead code (#11431)
Jan Kotas [Sat, 6 May 2017 18:03:27 +0000 (11:03 -0700)]
Delete dead code (#11431)

7 years agoDelete moved file
Jan Kotas [Sat, 6 May 2017 14:18:56 +0000 (07:18 -0700)]
Delete moved file

7 years agoDelete moved files and fix build breaks
Jan Kotas [Sat, 6 May 2017 03:48:28 +0000 (20:48 -0700)]
Delete moved files and fix build breaks

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
7 years agoMove more files to shared CoreLib partition (#11429)
Jan Kotas [Sat, 6 May 2017 03:32:38 +0000 (20:32 -0700)]
Move more files to shared CoreLib partition (#11429)

7 years agoRemove ArrayList (#11426)
Justin Van Patten [Fri, 5 May 2017 23:56:49 +0000 (16:56 -0700)]
Remove ArrayList (#11426)

Also cleanup FEATURE_NONGENERIC_COLLECTIONS while on it.

7 years agoMerge pull request #11428 from DrewScoggins/LeanRuns
Drew Scoggins [Fri, 5 May 2017 23:44:00 +0000 (08:44 +0900)]
Merge pull request #11428 from DrewScoggins/LeanRuns

Fix typo in perf.groovy

7 years agoFix typo in perf.groovy
Drew Scoggins [Fri, 5 May 2017 23:07:27 +0000 (16:07 -0700)]
Fix typo in perf.groovy

Had a typo where I was passing deafult instead of default as a flag to
the collection harness.  This fixes that.

7 years ago[Arm64/Unix] Enable FEATURE_USE_SOFTWARE_WRITE_WATCH_FOR_GC_HEAP (#11375)
Steve MacLean [Fri, 5 May 2017 23:16:37 +0000 (19:16 -0400)]
[Arm64/Unix] Enable FEATURE_USE_SOFTWARE_WRITE_WATCH_FOR_GC_HEAP (#11375)

* [Arm64/Unix] Enable FEATURE_USE_SOFTWARE_WRITE_WATCH_FOR_GC_HEAP
* [Arm64/Unix] Enable FEATURE_MANUALLY_MANAGED_CARD_BUNDLES

7 years agoAdd a GC Reliability Framework job to the CI (#11280)
Sean Gillespie [Fri, 5 May 2017 22:57:25 +0000 (15:57 -0700)]
Add a GC Reliability Framework job to the CI (#11280)

* Add GC Reliability Framework CI job

* Three changes:
  1) To address offline feedback, update the CI trigger phase document
  and the GC testing instructions
  2) Set the timeout for GC RF CI jobs to 24 hours, so they don't time
  out (they will run for 15 hours by default)
  3) Refactor "scenario == 'gc_reliability_framework' to its own method
  so that new GC RF scenarios can easily and cleanly be added if
  desired in the future

7 years agoMerge pull request #11425 from jashook/build_arm64_tests
Jarret Shook [Fri, 5 May 2017 21:35:56 +0000 (14:35 -0700)]
Merge pull request #11425 from jashook/build_arm64_tests

Build tests for arm64 runs.

7 years agoAdd compact entry points for ARM (#11109)
gbalykov [Fri, 5 May 2017 20:07:44 +0000 (23:07 +0300)]
Add compact entry points for ARM (#11109)

7 years agoBuild tests for arm64 runs.
jashook [Fri, 5 May 2017 20:06:31 +0000 (13:06 -0700)]
Build tests for arm64 runs.

This has been separated to allow coreclr #11423 to be tested
incrementally in the PR.

7 years agoUpdate CoreClr to preview2-25305-03 (#11421)
dotnet bot [Fri, 5 May 2017 19:54:49 +0000 (12:54 -0700)]
Update CoreClr to preview2-25305-03 (#11421)

7 years agoReturn null from CultureData.GetLocaleInfoEx (#11422)
Pedro Lamas [Fri, 5 May 2017 19:30:05 +0000 (20:30 +0100)]
Return null from CultureData.GetLocaleInfoEx (#11422)

7 years agoFix build breaks
Jan Kotas [Fri, 5 May 2017 15:47:11 +0000 (08:47 -0700)]
Fix build breaks

7 years agoSwitch over to shared Interop.Globalization.cs on Windows (#3528)
Jan Kotas [Fri, 5 May 2017 15:03:16 +0000 (08:03 -0700)]
Switch over to shared Interop.Globalization.cs on Windows (#3528)

- Match CoreCLR refactoring done for invariant culture
- Use actual unsafe types in the interop signatures instead of opaque IntPtr
- Use Unsafe.As to get a pointer to stack allocated structure instead of allocating GCHandles
- Remove use of NativeCallable for enumeration to make the same code work on both CoreRT and CoreCLR. (I have kelp the NativeCallable annotations commented out so that we can switch back to them once C# gets the intrinsics to make it possible.)

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
7 years agoMerge pull request #11405 from rartemev/issue_10857_addingseq
Roman Artemev [Fri, 5 May 2017 18:17:42 +0000 (11:17 -0700)]
Merge pull request #11405 from rartemev/issue_10857_addingseq

Fixed memory instruction selection for integer register which contants  simd8 type in ELT hook prolog

7 years agoPath.GetDirectoryName() throw exception when path is empty or has only white spaces...
Santiago Fernandez Madero [Fri, 5 May 2017 18:12:21 +0000 (11:12 -0700)]
Path.GetDirectoryName() throw exception when path is empty or has only white spaces (#11403)

* Throw exception when path is empty or has only white spaces

7 years agoRemoved Dictionary<TKey, TValue>.GetValueOrDefault Methods (#11388)
Tarun Pothulapati [Fri, 5 May 2017 17:49:59 +0000 (17:49 +0000)]
Removed Dictionary<TKey, TValue>.GetValueOrDefault Methods (#11388)

* Removed Dictionary.GetValueOrDefault Methods and the method calls in Rtpe.cs,CustomAttribute.cs

* Replaced the Dictionary.GetValueOrDefault Methods

* Used !s_pca.ContainsKey(caType) instead of s_pca.ContainsKey(caType) == false

7 years agoAdd lean run support to CoreCLR perf (#11347)
Drew Scoggins [Fri, 5 May 2017 17:39:15 +0000 (02:39 +0900)]
Add lean run support to CoreCLR perf (#11347)

In the xunit performance harness we added support for a "lean" run which
only runs the stopwatch to collect duration and none of the ETW
providers are turned on.  This adds support in the automation for doing
runs that use this lean feature.

7 years agoMerge pull request #11411 from justinvp/delegate_opequality
Stephen Toub [Fri, 5 May 2017 16:35:21 +0000 (12:35 -0400)]
Merge pull request #11411 from justinvp/delegate_opequality

Use ReferenceEquals instead of Delegate.op_Equality for sentinel checks

7 years agoUpdate CoreClr, CoreFx to preview2-25305-01, preview2-25305-01, respectively (#11384)
dotnet bot [Fri, 5 May 2017 15:19:07 +0000 (08:19 -0700)]
Update CoreClr, CoreFx to preview2-25305-01, preview2-25305-01, respectively (#11384)

7 years agoFixed issue #11383 (#11385)
sergey ignatov [Fri, 5 May 2017 15:12:07 +0000 (18:12 +0300)]
Fixed issue #11383 (#11385)

7 years agoMerge pull request #11361 from mikedn/imp-strlen-except
Bruce Forstall [Fri, 5 May 2017 14:24:49 +0000 (07:24 -0700)]
Merge pull request #11361 from mikedn/imp-strlen-except

Add missing GTF_EXCEPT when importing string length intrinsic

7 years agoFix incorrect metadata on SOS.NETCore.dll (#11395) again (#11415)
Mike McLaughlin [Fri, 5 May 2017 05:48:21 +0000 (22:48 -0700)]
Fix incorrect metadata on SOS.NETCore.dll (#11395) again (#11415)

There was a simple msbuild property.

Issue #11381

7 years agoAdd missing GTF_EXCEPT when importing string length intrinsic
Mike Danes [Wed, 3 May 2017 05:35:13 +0000 (08:35 +0300)]
Add missing GTF_EXCEPT when importing string length intrinsic

7 years agoMove UnmanagedMemoryStream and related types to shared CoreLib partition (#11409)
Jan Kotas [Fri, 5 May 2017 04:12:20 +0000 (21:12 -0700)]
Move UnmanagedMemoryStream and related types to shared CoreLib partition (#11409)

7 years agoAdd new test for COMPlus_TailcallStress=1 bug, currently disabled (#11410)
Bruce Forstall [Fri, 5 May 2017 03:55:26 +0000 (20:55 -0700)]
Add new test for COMPlus_TailcallStress=1 bug, currently disabled (#11410)

Add new test for COMPlus_TailcallStress=1 bug, currently disabled

7 years agoMerge pull request #11401 from wtgodbe/DeleteNis
William Godbe [Fri, 5 May 2017 02:54:53 +0000 (19:54 -0700)]
Merge pull request #11401 from wtgodbe/DeleteNis

Rename all xxx.ni.dll's to xxx.dll for Helix Crossgen runs

7 years agoFixed memory instruction selector for integer register which contants simd8 type
Roman Artemev [Thu, 4 May 2017 20:14:15 +0000 (13:14 -0700)]
Fixed memory instruction selector for integer register which contants simd8 type

7 years agoUpdate contributing-workflow.md
Karel Zikmund [Thu, 4 May 2017 23:23:21 +0000 (16:23 -0700)]
Update contributing-workflow.md

7 years agoRefactor arm32/arm64 per-node codegen into functions (#11377)
Bruce Forstall [Thu, 4 May 2017 23:07:26 +0000 (16:07 -0700)]
Refactor arm32/arm64 per-node codegen into functions (#11377)

These new functions can sometimes be shared, as they are identical or
virtually so.

In addition, the driver function genCodeForTreeNode() has been
made common.

7 years agoRename all xxx.ni.dll's to xxx.dll for Helix Crossgen runs
wtgodbe [Thu, 4 May 2017 18:57:51 +0000 (11:57 -0700)]
Rename all xxx.ni.dll's to xxx.dll for Helix Crossgen runs

7 years agoFix incorrect metadata on SOS.NETCore.dll (#11395)
Mike McLaughlin [Thu, 4 May 2017 22:19:57 +0000 (15:19 -0700)]
Fix incorrect metadata on SOS.NETCore.dll (#11395)

Issue #11381

7 years agoUpdate first-class-structs.md
Carol Eidt [Thu, 4 May 2017 22:09:55 +0000 (15:09 -0700)]
Update first-class-structs.md

7 years agoUpdate first-class-structs.md
Carol Eidt [Thu, 4 May 2017 22:07:37 +0000 (15:07 -0700)]
Update first-class-structs.md

7 years agoUse ReferenceEquals instead of Delegate.op_Equality for sentinel checks
Justin Van Patten [Thu, 4 May 2017 22:05:38 +0000 (15:05 -0700)]
Use ReferenceEquals instead of Delegate.op_Equality for sentinel checks

The reference equality check is more efficient than
Delegate.op_Equality.

7 years agoRemove UnmanagedMemoryStream overflow checks. (#11376)
Ian Hays [Thu, 4 May 2017 22:01:16 +0000 (15:01 -0700)]
Remove UnmanagedMemoryStream overflow checks. (#11376)

* Remove UnmanagedMemoryStream overflow checks.
* Catch negative UMS PositionPointers
* Switch UMS PositionPointer exception order

7 years agoFix ProjectN build break (dotnet/corert#3517)
Jan Kotas [Thu, 4 May 2017 19:37:39 +0000 (12:37 -0700)]
Fix ProjectN build break (dotnet/corert#3517)

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
7 years agoSystem.IO.Path.GetPathRoot string.Empty or whitespace character string should throw...
Viktor Hofer [Thu, 4 May 2017 21:11:33 +0000 (23:11 +0200)]
System.IO.Path.GetPathRoot string.Empty or whitespace character string should throw ArgumentException (#11387)

* GetPathRoot string.Empty and string whitespace throws ArgumentException

* throw in next line

* Refined method description

* Unix impl adjusted

* Indentation

* pr feedback

* Delete Path.Unix.cs

* Adding param to ArgumentException

7 years agoReenable MapViewOfFile PAL test1 (#11393)
Jan Vorlicek [Thu, 4 May 2017 20:19:53 +0000 (13:19 -0700)]
Reenable MapViewOfFile PAL test1 (#11393)

This change reenables the test that was having problems on systems when the /tmp
is created on tmpfs file system which doesn't support direct access (unbuffered).
The fix is to explicitly use /var/tmp instead (and /data/local/tmp/ on Android).

7 years agoRemove stale section on managed debugging. (#11392)
Mike McLaughlin [Thu, 4 May 2017 17:58:58 +0000 (10:58 -0700)]
Remove stale section on managed debugging. (#11392)

7 years agoMerge pull request #11370 from CarolEidt/ILOffsetDump
Carol Eidt [Thu, 4 May 2017 17:49:09 +0000 (10:49 -0700)]
Merge pull request #11370 from CarolEidt/ILOffsetDump

Dump GT_IL_OFFSET value in hex

7 years agoDocument Linux libnuma dependency (#11367)
Tom Deseyn [Thu, 4 May 2017 15:13:22 +0000 (17:13 +0200)]
Document Linux libnuma dependency (#11367)

7 years agoDisable symbol package MyGet publish on release/* (#11372)
Davis Goodin [Thu, 4 May 2017 14:17:24 +0000 (09:17 -0500)]
Disable symbol package MyGet publish on release/* (#11372)

7 years agoDelete moved file
Jan Kotas [Thu, 4 May 2017 03:35:14 +0000 (20:35 -0700)]
Delete moved file

7 years agoMerge pull request dotnet/corert#3506 from dotnet/nmirror
Jan Kotas [Thu, 4 May 2017 01:58:57 +0000 (18:58 -0700)]
Merge pull request dotnet/corert#3506 from dotnet/nmirror

Merge nmirror to master

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
7 years agoUpdate CoreClr, CoreFx to preview2-25303-03, preview2-25303-04, respectively (#11354)
dotnet bot [Thu, 4 May 2017 04:58:52 +0000 (21:58 -0700)]
Update CoreClr, CoreFx to preview2-25303-03, preview2-25303-04, respectively (#11354)

7 years agoCreatedump fixes and cleanup. (#11368)
Mike McLaughlin [Thu, 4 May 2017 00:17:22 +0000 (17:17 -0700)]
Createdump fixes and cleanup. (#11368)

Fixed "with heap" option to actually include all the heaps. The way /proc/$pid/maps
was parsed missed most of the RW data/heap regions.

Added -u/--full full core dump options.

Removed the useless m_memStatus variable in enummem.cpp.

7 years ago[Arm64/Unix] Revise JIT_MemSet (#11217)
Steve MacLean [Wed, 3 May 2017 22:52:42 +0000 (18:52 -0400)]
[Arm64/Unix] Revise JIT_MemSet (#11217)

* [Arm64/Unix] Revise JIT_MemSet

Use DC ZVA
Use stp
Correctly handle short set lengths
Simplify code & pseudo code
Use uint*_t to make pseudo code more readable

7 years agoAdding System\Runtime\CompilerServices\IsByRefLikeAttribute type (#11369)
Vladimir Sadov [Wed, 3 May 2017 22:22:32 +0000 (15:22 -0700)]
Adding System\Runtime\CompilerServices\IsByRefLikeAttribute type (#11369)

described in: https://github.com/dotnet/corefx/issues/19212

7 years agoFix some static analysis warnings
Russ Keldorph [Sun, 30 Apr 2017 13:17:30 +0000 (06:17 -0700)]
Fix some static analysis warnings

Most fixes are just addressing the use of (signed) enum-typed variables
as array indices.  Casting to unsigned allows us to cheaply include the
lower bound checks in the existing upper bound checks.  I would prefer
to force the underlying types of enumerations to be unsigned, but that
is a relatively new C++ feature and could have broader consequences than
I want to risk at this point.

The one other fix to asmparse.cpp just suppresses a warning that, while
technically valid, is not causing a real problem.  Perhaps this will get
better if/when #2305 is addressed.

7 years agoDump GT_IL_OFFSET value in hex
Carol Eidt [Wed, 3 May 2017 21:01:44 +0000 (14:01 -0700)]
Dump GT_IL_OFFSET value in hex

7 years agoRemove COMCoverage::nativeCoverBlock (#11364)
Jan Vorlicek [Wed, 3 May 2017 18:57:04 +0000 (11:57 -0700)]
Remove COMCoverage::nativeCoverBlock (#11364)

Remove this unused function and the corresponding references in
ecalllist.h

7 years agoFix Binder NI to IL fallback (#11341)
Steve MacLean [Wed, 3 May 2017 18:24:21 +0000 (14:24 -0400)]
Fix Binder NI to IL fallback (#11341)

* Fix Binder NI to IL fallback

Always try NI first

* Fix Windows warning as error

* [Arm64/Unix] Revise PR per feedback

* More cleanup

7 years agoPlace precompiled SPC.dll in native assets folder. (#11359)
Gaurav Khanna [Wed, 3 May 2017 17:50:34 +0000 (10:50 -0700)]
Place precompiled SPC.dll in native assets folder. (#11359)

Place precompiled SPC.dll in native assets folder.

7 years agoFix load from (#11342)
Gaurav Khanna [Wed, 3 May 2017 15:35:56 +0000 (08:35 -0700)]
Fix load from (#11342)

* Add LoadFrom dependencies to the LoadFrom list

* Add a comment

7 years agoImplement Type.IsTypeDefinition property on CoreCLR (#11355)
Atsushi Kanamori [Wed, 3 May 2017 13:40:42 +0000 (06:40 -0700)]
Implement Type.IsTypeDefinition property on CoreCLR (#11355)

This api was just approved.

https://github.com/dotnet/corefx/issues/17345

7 years agoRevert "[ARM32/Linux] Copy tests.zip only for CI test and use x86 unittest"
Russ Keldorph [Wed, 3 May 2017 03:59:24 +0000 (20:59 -0700)]
Revert "[ARM32/Linux] Copy tests.zip only for CI test and use x86 unittest"

This reverts commit 2ec8b5c2cc6d68ca02eb743e679997a8f11c90aa.

7 years agoMerge pull request #11362 from DrewScoggins/FixSmoketest
Drew Scoggins [Wed, 3 May 2017 07:08:18 +0000 (16:08 +0900)]
Merge pull request #11362 from DrewScoggins/FixSmoketest

Fix triggering of perf correctness runs

7 years agoFix triggering of perf correctness runs
Drew Scoggins [Wed, 3 May 2017 06:55:33 +0000 (23:55 -0700)]
Fix triggering of perf correctness runs

When I made the change to have the correctness runs fire in a PR without
the trigger phrase I accidentally did it for all PR's not just for the
smoketest runs.  This change fixes that.

7 years agoMerge pull request #11180 from DrewScoggins/AddCorrectnessRuns
Drew Scoggins [Wed, 3 May 2017 04:44:46 +0000 (13:44 +0900)]
Merge pull request #11180 from DrewScoggins/AddCorrectnessRuns

Add smoketest for performance tests

7 years agoAdd smoketest for performance tests
Drew Scoggins [Mon, 24 Apr 2017 18:36:27 +0000 (11:36 -0700)]
Add smoketest for performance tests

This adds a run that will fire on the set of Azure VMs and will only run
for one interation.  This along with the changes to fail a performance
run if a test fails will allow us to start gating checkins on the
performance tests still running.

7 years agoMerge pull request #11340 from ericstj/fixCrossTargetFolder
Eric StJohn [Tue, 2 May 2017 23:39:14 +0000 (16:39 -0700)]
Merge pull request #11340 from ericstj/fixCrossTargetFolder

Fix folder name for cross-targeting assets

7 years ago[ARM32/Linux] Copy tests.zip only for CI test and use x86 unittest
Hyeongseok Oh [Wed, 26 Apr 2017 06:44:16 +0000 (15:44 +0900)]
[ARM32/Linux] Copy tests.zip only for CI test and use x86 unittest

- Copy tests.zip only from x86 Windows build for CI test
- Use x86 unittest instead of x64: 32bit architecture

7 years agoEnable Marshal.SecureStringToBSTR and Marshal.ZeroFreeBSTR on Unix (#11234)
John Bottenberg [Tue, 2 May 2017 20:54:52 +0000 (13:54 -0700)]
Enable Marshal.SecureStringToBSTR and Marshal.ZeroFreeBSTR on Unix (#11234)

7 years agoMerge pull request #11336 from wtgodbe/TestingOnLinux
William Godbe [Tue, 2 May 2017 20:34:51 +0000 (13:34 -0700)]
Merge pull request #11336 from wtgodbe/TestingOnLinux

Update Unix test instructions

7 years agoUpdate Unix test instructions
wtgodbe [Tue, 2 May 2017 19:10:00 +0000 (12:10 -0700)]
Update Unix test instructions

7 years agoFix folder name for cross-targeting assets
Eric St. John [Tue, 2 May 2017 20:16:52 +0000 (13:16 -0700)]
Fix folder name for cross-targeting assets

7 years agoEnable LoadFrom to pickup assemblies next to requesting assembly (#11333)
Gaurav Khanna [Tue, 2 May 2017 20:14:01 +0000 (13:14 -0700)]
Enable LoadFrom to pickup assemblies next to requesting assembly (#11333)

* Enable LoadFrom to pickup assemblies from next to requestor

* Make early out explicit

7 years agoMerge pull request #11329 from BruceForstall/RefactorArmCodegen
Bruce Forstall [Tue, 2 May 2017 18:28:38 +0000 (11:28 -0700)]
Merge pull request #11329 from BruceForstall/RefactorArmCodegen

Refactor arm32/arm64 codegen

7 years agoUpdate CoreFx to preview2-25302-03 (#11331)
dotnet bot [Tue, 2 May 2017 18:21:36 +0000 (11:21 -0700)]
Update CoreFx to preview2-25302-03 (#11331)

7 years agoSurgically remove unsupported tailcall cases
Russ Keldorph [Mon, 1 May 2017 16:57:21 +0000 (09:57 -0700)]
Surgically remove unsupported tailcall cases

Rather than disabling tailcall tests entirely, surgically remove the
failing cases so the remaining cases can be enabled.

7 years agoUpdate CoreClr, CoreFx to preview2-25302-02, preview2-25302-01, respectively (#11326)
dotnet bot [Tue, 2 May 2017 14:23:21 +0000 (07:23 -0700)]
Update CoreClr, CoreFx to preview2-25302-02, preview2-25302-01, respectively (#11326)

7 years agoAdded missing icu headers for Android (#11325)
Cyd Haselton [Tue, 2 May 2017 11:52:46 +0000 (06:52 -0500)]
Added missing icu headers for Android (#11325)

urename.h and ustring.h contain the u_stncpy and its definition.
If they are not in the list of icushim.h headers, Android build fails.

7 years agoFix assert
Bruce Forstall [Tue, 2 May 2017 06:52:12 +0000 (23:52 -0700)]
Fix assert