platform/upstream/efl.git
5 years agostatic_libs/vg_common: Remove extra blank lines
Christopher Michael [Wed, 24 Apr 2019 12:58:57 +0000 (08:58 -0400)]
static_libs/vg_common: Remove extra blank lines

NB: No functional changes

5 years agostatic_libs/vg_common: Fix resource leak
Christopher Michael [Wed, 24 Apr 2019 12:56:00 +0000 (08:56 -0400)]
static_libs/vg_common: Fix resource leak

Coverity reports a resource leak here. The function _create_node
returns allocated storage which should be freed when we are finished
with it.

Fixes CID1382215

@fix

5 years agoecore-evas-x: Fix double free
Christopher Michael [Wed, 24 Apr 2019 12:52:02 +0000 (08:52 -0400)]
ecore-evas-x: Fix double free

Coverity reports, and reading the code confirms, that the variable
'out' has already been freed (or is NULL) when reaching this line of
execution.

Fixes CID1382851

@fix

5 years agoui.relative_layout: fix incorrect type casting
Yeongjong Lee [Wed, 24 Apr 2019 12:09:53 +0000 (21:09 +0900)]
ui.relative_layout: fix incorrect type casting

Summary: `temph` can be double type.

Reviewers: Jaehyun_Cho

Reviewed By: Jaehyun_Cho

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8695

5 years agoui.relative_layout: enhance relation_xxx_set,get apis
Yeongjong Lee [Wed, 24 Apr 2019 11:33:20 +0000 (20:33 +0900)]
ui.relative_layout: enhance relation_xxx_set,get apis

Summary:
I forgot `efl_pack_layout_request` after relation_xxx is changed.
Unnecessary register function in `relation_xxx_get` will return unexpected result.
if a object is not child of relative_layout, `relation_xxx_get` should return
`target = NULL` and `relative = 0.0` with error message.

Test Plan: make check

Reviewers: Jaehyun_Cho

Reviewed By: Jaehyun_Cho

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8627

5 years agoui.relative_layout: add callbacks to update layout
Yeongjong Lee [Wed, 24 Apr 2019 11:32:45 +0000 (20:32 +0900)]
ui.relative_layout: add callbacks to update layout

Summary:
If the size or hints of a child changes, relative_layout need to update layout.
And, if a child is deleted, it should be unregisterd from relative_layout.

Depends on D8625

Test Plan: elementary_test -to 'efl.ui.relative_layout'

Reviewers: Jaehyun_Cho

Reviewed By: Jaehyun_Cho

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8626

5 years agoeo_parser: fix unreachable code
Taehyub Kim [Wed, 24 Apr 2019 09:56:32 +0000 (11:56 +0200)]
eo_parser: fix unreachable code

Summary: fix unreachable code for kw_enum case in parse_unit function

Reviewers: q66, Jaehyun_Cho, woohyun

Reviewed By: q66

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8696

5 years agodocs: Fix genlist widget preview generation
Xavi Artigas [Wed, 24 Apr 2019 08:52:31 +0000 (10:52 +0200)]
docs: Fix genlist widget preview generation

Summary:
This was making "ninja doc" segfault for me.
If these function tables are not initialized they contain garbage, which leads
to the worst kind of undefined behavior.

Test Plan: Apply D8561 and try `ninja doc`. It was dumping core for me, and it does not do it anymore after this patch.

Reviewers: bu5hm4n, zmike, cedric

Reviewed By: bu5hm4n

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8697

5 years agoevas x: code refactoring.
Hermet Park [Wed, 24 Apr 2019 07:39:23 +0000 (16:39 +0900)]
evas x: code refactoring.

keep simple code as possible.

5 years agomeson: ensure that buffer header is installed correctly
Marcel Hollerbach [Tue, 23 Apr 2019 19:54:50 +0000 (21:54 +0200)]
meson: ensure that buffer header is installed correctly

the directory it was installed to was <prefix>/include/evas/engine-1/
instead of <prefix>/include/evas-1/ which is wrong. This fixes
enlightenment building.

Reviewed-by: Lauro Neto <lauromauro_>
Differential Revision: https://phab.enlightenment.org/D8692

5 years agosoftware_generic: fix a logic to handle the missed type. 06/205106/1
Wonki Kim [Mon, 29 Apr 2019 07:00:11 +0000 (16:00 +0900)]
software_generic: fix a logic to handle the missed type.

XRGB8888 looks not existing as a pair within getter/setter.
this patch modifies it

Change-Id: Ia8808a4826dedd20fad942f06ba18345ea5c4bf8
Signed-off-by: Wonki Kim <wonki_.kim@samsung.com>
5 years agoedje_calc: replace eina_stringshare_ref with eina_stringshare_add 81/204781/2 accepted/tizen/unified/20190429.103734 submit/tizen/20190426.083556
Yeongjong Lee [Fri, 26 Apr 2019 05:55:37 +0000 (14:55 +0900)]
edje_calc: replace eina_stringshare_ref with eina_stringshare_add

Summary:
When there is circular dependency in edc, a bunch of CRI log is printed.
This patch fixes it.
```
ERR<10159>:edje lib/edje/edje_calc.c:3919 _edje_part_recalc() Circular dependency in the group 'test' : longpartname -> longpartname -> longpartname2
ERR<10159>:edje lib/edje/edje_calc.c:3896 _edje_part_recalc() Circular dependency when calculating part "longpartname". Already calculating XY [03] axes. Need to calculate Y [02] axes
CRI<10159>: lib/eina/eina_share_common.c:559 _eina_share_common_node_from_str() *** Eina Magic Check Failed at 0x7fb7c93ebf60 !!!
    Input handle is wrong type.
    Expected: 98761254 - Eina Stringshare Node
    Supplied: 2f736e6f - (unknown)

CRI<10159>: lib/eina/eina_share_common.c:559 _eina_share_common_node_from_str() *** Eina Magic Check Failed at 0x7fb7c93ec5d1 !!!
    Input handle is wrong type.
    Expected: 98761254 - Eina Stringshare Node
    Supplied: 5f747261 - (unknown)
```
If string is already stored, `eina_stringshare_add` increase its reference count.

Test Plan:
test.c
```
//edje_cc test.edc && gcc -o test test.c `pkg-config --libs --cflags elementary`

int main(int argc, char **argv)
{
   elm_init(argc, argv);

   Evas_Object *win = elm_win_util_standard_add("test", "test");

   Evas_Object *layout = elm_layout_add(win);
   elm_layout_file_set(layout, "./test.edj", "test");
   elm_win_resize_object_add(win, layout);
   evas_object_show(layout);
   evas_object_resize(win, 200, 200);
   evas_object_show(win);

   elm_run();

   elm_shutdown();

   return 0;
}
```

test.edc
```
collections {
   group { name: "test";
      parts {
         rect { name: "longpartname";
            desc { "default";
                rel1.to: "longpartname2";
            }
         }
         rect { name: "longpartname2";
            type: RECT;
            desc { "default";
                rel2.to: "longpartname";
            }
         }
      }
   }
}
```

Reviewers: SanghyeonLee, zmike

Reviewed By: SanghyeonLee

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8717

Change-Id: I60a00da735f4e65b176badcb1219798b5aeff016

5 years agoui.relative_layout: enhance relation_xxx_set,get apis 80/204780/2
Yeongjong Lee [Wed, 24 Apr 2019 11:33:20 +0000 (20:33 +0900)]
ui.relative_layout: enhance relation_xxx_set,get apis

Summary:
I forgot `efl_pack_layout_request` after relation_xxx is changed.
Unnecessary register function in `relation_xxx_get` will return unexpected result.
if a object is not child of relative_layout, `relation_xxx_get` should return
`target = NULL` and `relative = 0.0` with error message.

Test Plan: make check

Reviewers: Jaehyun_Cho

Reviewed By: Jaehyun_Cho

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8627

Change-Id: Ifc3fd0f64bb337758bfb1766cf1b334cc2376832

5 years agoui.relative_layout: add callbacks to update layout 79/204779/2
Yeongjong Lee [Wed, 24 Apr 2019 11:32:45 +0000 (20:32 +0900)]
ui.relative_layout: add callbacks to update layout

Summary:
If the size or hints of a child changes, relative_layout need to update layout.
And, if a child is deleted, it should be unregisterd from relative_layout.

Depends on D8625

Test Plan: elementary_test -to 'efl.ui.relative_layout'

Reviewers: Jaehyun_Cho

Reviewed By: Jaehyun_Cho

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8626

Change-Id: I591ffef693eee563e9a7d266b7e122936aa7aa7b

5 years agoevas waylang_egl: flag on msaa to optimize map drawing. 84/204784/2
Hermet Park [Fri, 26 Apr 2019 07:58:52 +0000 (16:58 +0900)]
evas waylang_egl: flag on msaa to optimize map drawing.

This msaa flag could help map drawing by avoiding unnecessary framebuffer mapping.

Change-Id: Ib2f9bde97ba98b7d386e9505926579ef524f2338

5 years agoui.relative_layout: add internal clipper 78/204778/2
Yeongjong Lee [Wed, 24 Apr 2019 11:23:52 +0000 (20:23 +0900)]
ui.relative_layout: add internal clipper

Summary: If there is no clipper of container, color_set and clipper_set api won't work.

Test Plan:
1. elementary_test -to 'efl.ui.relative_layout'
2. Click button1
3. check that buttons color are changed.

Reviewers: Jaehyun_Cho

Reviewed By: Jaehyun_Cho

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8625

Change-Id: I2d69eb9dd42b3b415f70d09a0365b8002d54da15

5 years agoeo_parser: fix unreachable code 77/204777/2
Taehyub Kim [Wed, 24 Apr 2019 09:56:32 +0000 (11:56 +0200)]
eo_parser: fix unreachable code

Summary: fix unreachable code for kw_enum case in parse_unit function

Reviewers: q66, Jaehyun_Cho, woohyun

Reviewed By: q66

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8696

Change-Id: Ia15e245c6a87c9d4c7b0a0785cf31ba8f5690342

5 years agoefl_ui_animation_view: Add since_tizen docs 83/204783/2
JunsuChoi [Fri, 26 Apr 2019 08:04:05 +0000 (17:04 +0900)]
efl_ui_animation_view: Add since_tizen docs

Change-Id: I08527a484fbe62061d03ffadb56756c4856df6d6

5 years agoecore_evas wayland: fix a build break. 45/204745/3
Hermet Park [Thu, 25 Apr 2019 09:55:55 +0000 (18:55 +0900)]
ecore_evas wayland: fix a build break.

Summary: missed changing here.

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8712

Change-Id: Ib63e1681ef5d370ea38d3c400efa3d6936661aa4

5 years agoevas wayland_egl: set up config depth/stencil/msaa properly. 44/204744/4
Hermet Park [Thu, 25 Apr 2019 09:41:43 +0000 (18:41 +0900)]
evas wayland_egl: set up config depth/stencil/msaa properly.

Change-Id: I8c1c0af0efa10f1536f292609e6266ff892e4544

5 years agoelementry win: support msaa, stencil and depth bits for wayland. 41/204741/3
Hermet Park [Thu, 25 Apr 2019 08:25:52 +0000 (17:25 +0900)]
elementry win: support msaa, stencil and depth bits for wayland.

Change-Id: I1a6bb202769bce41075513954c551c83b035bb31

5 years agoecore_evas: generalize option defines. 40/204740/3
Hermet Park [Thu, 25 Apr 2019 08:08:37 +0000 (17:08 +0900)]
ecore_evas: generalize option defines.

There some engine option defines could be generalized from the window system
since those options could be used through wayland, x11 both, and probably so on.

Change-Id: I1dfef761f7024b573a35038e1acb10d619dc61ad

5 years agoecore wayland: expand internal interface to pass engine option list. 39/204739/3
Hermet Park [Thu, 25 Apr 2019 07:56:40 +0000 (16:56 +0900)]
ecore wayland: expand internal interface to pass engine option list.

This is a prepartion patch to support msaa in wayland.
ui window needs to deliver engine options (stencil, depth, msaa bits)
to evas engine side, ecore_evas_wayland_egl should have the argument to pass.

Change-Id: I7f529f0e0ae2f1f46062dfc7d6a4dd7beaed8382

5 years agoedje_load: Delete unnecessary style update function call. 68/204668/2
Woochanlee [Thu, 25 Apr 2019 09:46:47 +0000 (18:46 +0900)]
edje_load: Delete unnecessary style update function call.

https://phab.enlightenment.org/D8560
I tried to push this commit on upstream.
But We has diffrent logic for style update.

@tizen_fix

Change-Id: I1da315768cfe117029372717a86f0d5242c21d91

5 years agovg_common_json: Support mask with matte case. 05/204705/1
JunsuChoi [Fri, 26 Apr 2019 01:46:06 +0000 (10:46 +0900)]
vg_common_json: Support mask with matte case.

Summary:
The layer can have both a mask node and a matte node.
In this case, one of them may be missing because it uses one mask_set api.
If there is a matte, the mask is to be child of the matte.

Test Plan:
.._mask_set(layer, matte);
.._mask_set(layer, mask);

Reviewers: Hermet, kimcinoo

Reviewed By: Hermet

Subscribers: cedric, #reviewers, smohanty, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8709

Change-Id: I2a617cbaf087ae9839befa40b94d6e40e2d859ce

5 years agoentry: revert a single line 03/204703/2
Wonki Kim [Fri, 26 Apr 2019 01:42:43 +0000 (10:42 +0900)]
entry: revert a single line

Summary:
the line this patch is reverting was not I intended.
at D8362, I just wanted to accept what zmike proposed.
this patch make the previous patch what It was supposed to be.

Reviewers: zmike

Subscribers: bowonryu, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8694

Change-Id: I5ffcf88e2c8b6ec73b16e603f922f754e05bdb7d
Signed-off-by: Bowon Ryu <bowon.ryu@samsung.com>
5 years agoefl_ui_animation_view: Remove docs in set/get. 01/204701/1
JunsuChoi [Thu, 25 Apr 2019 08:32:48 +0000 (17:32 +0900)]
efl_ui_animation_view: Remove docs in set/get.

Summary:
   it is not used. and not generated at docs of C# and python languages.

Test Plan: N/A

Reviewers: kimcinoo, Hermet

Reviewed By: kimcinoo

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8711

Change-Id: Ic711cfd77c9f84f925e586d20a7284cf5db986bd

5 years agoelm_theme: Check the ref count to delete or unref. 86/204686/2
Woochanlee [Thu, 25 Apr 2019 12:19:35 +0000 (21:19 +0900)]
elm_theme: Check the ref count to delete or unref.

In case of the ref count bigger than 1.
That means the eo_theme ref count is 2.

In that case we need to call efl_unref when theme freed.
other case we can delete eo_theme.

@fix

https://phab.enlightenment.org/D8714
e25f00c2d5d98854b1ddab5d9d3b34ce63766db3

Change-Id: Ifcbcd40ece56f8b466fbb3e00b1344a000f55ca8

5 years agoefl_mono: EflSharp application uses efl_sharp theme 70/204670/1
Jaehyun Cho [Thu, 25 Apr 2019 10:28:37 +0000 (19:28 +0900)]
efl_mono: EflSharp application uses efl_sharp theme

efl_sharp theme is overlaid to be used by EflSharp application.
i.e. /usr/share/efl-sharp/efl-sharp-theme.edj

Change-Id: Ied26f2d0bd55dd98d199f0fa9894bb4294df98b8

5 years agoefl_ui_win: add new swallow part for circle object 96/199496/3
Taehyub Kim [Tue, 12 Feb 2019 06:48:11 +0000 (15:48 +0900)]
efl_ui_win: add new swallow part for circle object

Change-Id: Iba8fb5806187773d80ebf5a62f1e6116ba8c61f2

5 years agoui.relative_layout: fix incorrect type casting
Yeongjong Lee [Wed, 24 Apr 2019 12:09:53 +0000 (21:09 +0900)]
ui.relative_layout: fix incorrect type casting

Summary: `temph` can be double type.

Reviewers: Jaehyun_Cho

Reviewed By: Jaehyun_Cho

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8695

5 years agoEfl.Ui.Animation_View: Enhance documentation of elm_animation_view. 42/204642/1
JunsuChoi [Wed, 24 Apr 2019 07:17:48 +0000 (16:17 +0900)]
Efl.Ui.Animation_View: Enhance documentation of elm_animation_view.

Summary:
 - Add "Animation View" item at elementary_main.
 - Change EAPIs naming.
 - Change version 1.22 to 1.23.

Test Plan:
make doc
firefox doc/html/widgetslist.html
Go "Animation View"

Reviewers: Hermet, kimcinoo, segfaultxavi

Subscribers: segfaultxavi, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8675

Change-Id: I1a570f8f8b73ab0e41d0b21dbe8fbde274118927

5 years ago[EvasGL] Fix the partial rendering bug 31/204631/1
Wonsik Jung [Thu, 25 Apr 2019 06:44:43 +0000 (15:44 +0900)]
[EvasGL] Fix the partial rendering bug

Fix the partial rendering bug

Change-Id: Ide85ba49c4a32e198079d258ddf7876f0a6bb4a6

5 years agomeson: migrate upstream patches to tizen
Wonki Kim [Wed, 24 Apr 2019 04:57:03 +0000 (13:57 +0900)]
meson: migrate upstream patches to tizen

regarding patches(93983e0, 6114570, 7273fbb, 3418659),
they have too many diff to cherry-pick on tizen
this patch migrate them

Change-Id: Id72ecf0e9acf5b1913967afff20ac008d7920c8e

5 years agomeson: make it possible to link our engines against evas
Marcel Hollerbach [Fri, 19 Apr 2019 18:39:31 +0000 (14:39 -0400)]
meson: make it possible to link our engines against evas

Summary:
it FINALLY happend! With this python bindings should be able to work
again with a meson build, you can also enable b_lundef right now. And it
appears to work, with this we can also get another step closer to a
windows build.
Depends on D8669

Reviewers: zmike, stefan_schmidt, cedric, vtorri

Reviewed By: zmike

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8670

5 years agomeson: seperate the engine build file from the rest
Marcel Hollerbach [Fri, 19 Apr 2019 18:39:25 +0000 (14:39 -0400)]
meson: seperate the engine build file from the rest

Summary:
this is required later on, where we want to build the engines
undependend from image loaders etc.
Depends on D8668

Reviewers: zmike, stefan_schmidt, cedric, vtorri

Reviewed By: zmike

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8669

Change-Id: Iad68a3932bdb10868f51f2f881737befb92f4b6a

5 years agomeson: move build definitions of software_generic to libevas
Marcel Hollerbach [Fri, 19 Apr 2019 18:39:22 +0000 (14:39 -0400)]
meson: move build definitions of software_generic to libevas

Summary:
with this we don't have any static module anymore in the engine
directory. This means either *all* modules in the enignes directory are
static OR shared. There is no mixture anymore. This is a requirement for
the directory to be build whenever we want it to be build.
Depends on D8667

Reviewers: zmike, stefan_schmidt, cedric, vtorri

Reviewed By: zmike

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8668

Change-Id: I973c4366b888d1d452b8b0e25340b6fc6dd5a5b5

5 years agomeson: move gl_common to gl_generic
Marcel Hollerbach [Fri, 19 Apr 2019 18:39:17 +0000 (14:39 -0400)]
meson: move gl_common to gl_generic

Summary:
sooo, gl_common stuff is only used by gl_generic, (and maybe others.
However, it is build static anyways and only linked into gl_generic).

This means, only software_generic is still in here and we can remove one
special case from the build instructions.

Reviewers: zmike, stefan_schmidt, cedric, vtorri

Reviewed By: zmike

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8667

Change-Id: Id7b2641c95d7581a43da4a07dc8531347f8b6caf

5 years agoefl_canvas_animation_player: fix to apply animation when player starts 68/204468/1 accepted/tizen/unified/20190425.014546 submit/tizen/20190424.080239
Jaehyun Cho [Wed, 24 Apr 2019 05:44:50 +0000 (14:44 +0900)]
efl_canvas_animation_player: fix to apply animation when player starts

Previously, animation was not applied immediately when player starts
animation because elapsed time is 0.
This caused flickering object if animation begins with alpha 0 because
the alpha 0 animation is not applied immediately.

Now, animation is applied immediately when player start animation.

Change-Id: I0656540589492d68b3fb61ef8eb25faadf3f4011

5 years agoefl_ui_stack: handle memory allocation fail 67/204467/1
Jaehyun Cho [Wed, 24 Apr 2019 05:44:19 +0000 (14:44 +0900)]
efl_ui_stack: handle memory allocation fail

check if memory allocation succeeds and handle memory allocation fail.

Change-Id: Iebee55a63cef5c37f910aacef6067a1431ec9452

5 years agoexamples : update list_view examples to use item_class_set not layout_theme_config. submit/tizen/20190424.060632
SangHyeon Jade Lee [Tue, 23 Apr 2019 07:34:32 +0000 (07:34 +0000)]
examples : update list_view examples to use item_class_set not layout_theme_config.

widget_factory support item_class_set for factory created child.

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D8684

5 years agoecore: rely on event instead of creating one Eo object per future that need resolving.
Cedric BAIL [Fri, 29 Mar 2019 00:18:08 +0000 (17:18 -0700)]
ecore: rely on event instead of creating one Eo object per future that need resolving.

This was a terrible oversight, but the point of having a small native type for future was
for making them efficient. Still we were using one Eo object for dispatching per future
to dispatch new value. I could have gathered all the dispatch with just one object, but
at the end we do have one object that notify us of the loop iteration... the loop object!
And we have event on that object that we can rely to trigger the dispatching of future
without requiring any additional object. So let's do that instead.

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8567

5 years agoefl_ui_scroller: fix Efl.Content implementation
Marcel Hollerbach [Mon, 22 Apr 2019 20:10:19 +0000 (22:10 +0200)]
efl_ui_scroller: fix Efl.Content implementation

this commit ensures the following:
- Delete content when new content is set
- Content set input validation
- Correct parent setting

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D8682

5 years agoefl_ui_tab_page: implement content_set / unset correctly
Marcel Hollerbach [Mon, 22 Apr 2019 19:52:45 +0000 (21:52 +0200)]
efl_ui_tab_page: implement content_set / unset correctly

This patchset ensures that the following features are supported:
- content-widget deletion on set content
- content-widget validation on set calls
- invalid cases return false
- event emission

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D8681

5 years agoefl_ui_popup: fix widget_parent inheritance
Marcel Hollerbach [Mon, 22 Apr 2019 19:30:05 +0000 (21:30 +0200)]
efl_ui_popup: fix widget_parent inheritance

when you inherit from widget_parent, you MUST call the super function.

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D8680

5 years agoefl_core_command_line: Fix resource leak
Christopher Michael [Tue, 23 Apr 2019 13:26:13 +0000 (09:26 -0400)]
efl_core_command_line: Fix resource leak

Coverity reports that we leak the return from _escape(command) here,
so since we have to free the return from _escape, place it in it's own
variable that we can call free() on after we are done with it.

Fixes CID1399105

@fix

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8688

5 years agocsharp: Fix test code memory handling
Lauro Moura [Tue, 23 Apr 2019 15:12:31 +0000 (12:12 -0300)]
csharp: Fix test code memory handling

Summary:
It was causing the test to crash when running in debug build.

Also some minor fixes cleaning up stuff when exiting.

Fixes T7792.

Reviewers: segfaultxavi, vitor.sousa

Reviewed By: segfaultxavi, vitor.sousa

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T7792

Differential Revision: https://phab.enlightenment.org/D8679

5 years agomono-docs: Honor DESTDIR when installing XML docs
Xavi Artigas [Tue, 23 Apr 2019 11:53:26 +0000 (11:53 +0000)]
mono-docs: Honor DESTDIR when installing XML docs

The DESTDIR envvar was not being taken into account and the XML doc file
ended up in a different place than the DLL.

Fix T7802

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8687

5 years agofix compilation on alpine
Boris Faure [Tue, 23 Apr 2019 13:40:53 +0000 (09:40 -0400)]
fix compilation on alpine

Reviewers: zmike

Reviewed By: zmike

Subscribers: zmike, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8642

5 years agoelput: Remove useless call to eldbus_message_unref
Christopher Michael [Tue, 23 Apr 2019 13:14:52 +0000 (09:14 -0400)]
elput: Remove useless call to eldbus_message_unref

If we are returning here due to a failure to create the eldbus
message, then there is no point in trying to free it as it is already
null.

@fix

5 years agomeson: enable strict linking
Marcel Hollerbach [Tue, 23 Apr 2019 13:06:52 +0000 (09:06 -0400)]
meson: enable strict linking

Summary: with this commit you can compile efl with -Wl,-z,defs.

Reviewers: zmike

Reviewed By: zmike

Subscribers: simotek, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8677

5 years agocsharp: Fixes repeated method names.
Lauro Moura [Tue, 23 Apr 2019 10:19:09 +0000 (12:19 +0200)]
csharp: Fixes repeated method names.

Summary:
After D8397, interfaces have the I prefix again, so the "Do" prefix on
methods with repeated names may not be needed for them in most cases.

This commit also consolidates the method_managed_name calls with the
overload receiving attributes::function_def instead of plain name.

Fixes T7791

Depends on D8645

Reviewers: vitor.sousa, felipealmeida, segfaultxavi

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T7791

Differential Revision: https://phab.enlightenment.org/D8650

5 years agomono-docs: Update DocFX blacklist
Xavi Artigas [Tue, 23 Apr 2019 10:17:11 +0000 (12:17 +0200)]
mono-docs: Update DocFX blacklist

NativeInherit sibling classes have been replaced by NativeMethods internal classes.

5 years agocsharp: refactor native_inherit into a nested class.
Lauro Moura [Tue, 23 Apr 2019 09:48:03 +0000 (11:48 +0200)]
csharp: refactor native_inherit into a nested class.

Summary:
Efl.Ui.Button_NativeInherit -> Efl.Ui.Button.NativeMethods

Will help using EFL# with completion tools.

* Added pragmas around the native function definitions to avoid
  warnings related to the name of native functions
* Updated some style fixes for native function wrappers.

Their preamble and epilogue styling will be dealt with in future diffs.

As a side effect, concrete classes had to be made public again as they
hold the function pointers to the native methods of their interfaces.
Thus a third party library class that implements IFoo should be able to
access these methods.

Fixes T7743

Depends on D8622

Reviewers: vitor.sousa, felipealmeida, segfaultxavi

Reviewed By: vitor.sousa, segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T7743

Differential Revision: https://phab.enlightenment.org/D8645

5 years agomono-docs: Use full name in page title
Xavi Artigas [Tue, 23 Apr 2019 09:07:29 +0000 (11:07 +0200)]
mono-docs: Use full name in page title

Reference page titles are now "Class Efl.Ui.Win" instead of "Class Win".
And also remove Namespace and Assembly sections.
Namespace is redundant since we use fully-qualified names everywhere.
Assembly is useless since we build the docs from the source so this entry is
always "temp.dll".

5 years agomono-docs: Use full name in list of derived classes
Xavi Artigas [Tue, 23 Apr 2019 08:51:56 +0000 (10:51 +0200)]
mono-docs: Use full name in list of derived classes

In the EFL API we have several objects with the same name in different namespaces.
Thus it is important to use fully-qualified names throughout the docs, to avoid
confusion.
However, the default DocFX templates prefer using only simple class names.
The default templates have already been modified to use full names everywhere
except in the list of derived classes in the hierarchy section, where a DocFX
bug was hit.
This commit is a workaround to that bug (see
https://github.com/dotnet/docfx/issues/3769#issuecomment-485616064 )
so full names (with links) are used in the whole hierarchy.

5 years agoelc_hoversel: fix selected event compatibility issue
Taehyub Kim [Tue, 23 Apr 2019 06:48:58 +0000 (06:48 +0000)]
elc_hoversel: fix selected event compatibility issue

Fix selected event compatibility issue.
When item of hoversel is selected,
item selected callback does not call in hoversel sample of elementary_test.

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8683

5 years agoecore: add an helper for Efl.Boolean_Model to get all the index with a requested...
Cedric BAIL [Wed, 3 Apr 2019 21:23:01 +0000 (14:23 -0700)]
ecore: add an helper for Efl.Boolean_Model to get all the index with a requested value.

Differential Revision: https://phab.enlightenment.org/D8569

5 years agocsharp: Small style changes
Lauro Moura [Mon, 22 Apr 2019 21:15:19 +0000 (18:15 -0300)]
csharp: Small style changes

Summary:
- Marshal annotations
- Parameters
- Structs
- Parts

Depends on D8614

Reviewers: segfaultxavi, vitor.sousa

Reviewed By: segfaultxavi, vitor.sousa

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8622

5 years agocsharp: klass style changes
Lauro Moura [Mon, 22 Apr 2019 21:07:11 +0000 (18:07 -0300)]
csharp: klass style changes

Summary:
Warnings down to 120k

Depends on D8612

Reviewers: vitor.sousa, felipealmeida, segfaultxavi

Reviewed By: vitor.sousa, segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl_language_bindings

Differential Revision: https://phab.enlightenment.org/D8614

5 years agocsharp: Simple spacing rules changes
Lauro Moura [Mon, 22 Apr 2019 20:53:30 +0000 (17:53 -0300)]
csharp: Simple spacing rules changes

Summary: Also do not generated empty tag if doc would be empty.

Reviewers: vitor.sousa, segfaultxavi

Reviewed By: vitor.sousa, segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8612

5 years agoautotools: add lib/evas/common/evas_map_image_internal_high.c to dist
Mike Blumenkrantz [Mon, 22 Apr 2019 11:21:58 +0000 (07:21 -0400)]
autotools: add lib/evas/common/evas_map_image_internal_high.c to dist

Summary: ref 84e162b01f542f31bc1c6dfc0f190eb965211229

Reviewers: devilhorns

Reviewed By: devilhorns

Subscribers: cedric, #reviewers, #committers

Tags: #efl_build

Differential Revision: https://phab.enlightenment.org/D8676

5 years agoecore_wl2_input: fix a way it works when it has multiple input devices
Wonki Kim [Mon, 22 Apr 2019 11:06:58 +0000 (07:06 -0400)]
ecore_wl2_input: fix a way it works when it has multiple input devices

Summary:
if there are multiple input devices, especially touch and mouse type devices simultaneous.
a logic can't recognize the current input device in _ecore_wl2_input_mouse_move_send function.
because focus.touch would not be cleared even touch actions from user has finished.

This patch clears input->focus.touch if users release their finger from touch device.

Reviewers: raster, eagleeye, devilhorns

Reviewed By: devilhorns

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8673

5 years agoefl_access: remove all legacy usage from eo files
Yeongjong Lee [Mon, 22 Apr 2019 02:00:33 +0000 (11:00 +0900)]
efl_access: remove all legacy usage from eo files

@tizen_fix

Change-Id: I6ce352eb4839d73788e67fd6e605401521e0a128

5 years agoui.table: remove leagcy evas_table from Efl.Ui.Table
Yeongjong Lee [Thu, 18 Apr 2019 08:22:44 +0000 (08:22 +0000)]
ui.table: remove leagcy evas_table from Efl.Ui.Table

Remove evas_table.
This expect to improve performance by removing internal function call related
evas_table.

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8615

5 years agoui.relative_layout: replace evas_object_event_callback_xxx with efl_event_callback_xxx
Yeongjong Lee [Wed, 17 Apr 2019 08:24:25 +0000 (08:24 +0000)]
ui.relative_layout: replace evas_object_event_callback_xxx with efl_event_callback_xxx

remove legacy function

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8630

5 years agoelementary: fix another instances of no parent for Efl.Io.Model.
Cedric BAIL [Tue, 2 Apr 2019 18:42:48 +0000 (11:42 -0700)]
elementary: fix another instances of no parent for Efl.Io.Model.

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8539

5 years agoelementary: fix elm_fileselector_entry model_get to be properly build with a parent...
Cedric BAIL [Tue, 2 Apr 2019 17:04:32 +0000 (10:04 -0700)]
elementary: fix elm_fileselector_entry model_get to be properly build with a parent and synchronously.

This fix the following warning:
ERR<12924>:eo ../src/lib/eo/eo.c:880 _efl_add_internal_start() Creation of 'Efl.Io.Model' object at line 443 in '../src/lib/elementary/elc_fileselector_entry.c' is done without parent. This should use efl_add_ref.

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8536

5 years agoelementary: add a queue to postpone object destruction when necessary.
Cedric BAIL [Tue, 2 Apr 2019 19:30:45 +0000 (12:30 -0700)]
elementary: add a queue to postpone object destruction when necessary.

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8540

5 years agoelementary: enforce Efl.IoModel as a base type for fileselector.
Cedric BAIL [Thu, 18 Apr 2019 23:17:05 +0000 (16:17 -0700)]
elementary: enforce Efl.IoModel as a base type for fileselector.

On the long run, we might just want to have an Efl.Model dedicated to
be used by fileselector and inherit Efl.IoModel from it. At the moment,
we don't, but I think it is still best to rely on this assumption to
make the fileselector code simpler.

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8654

5 years agoeio: rely on inheritance and reflection for Efl.IoModel path property.
Cedric BAIL [Thu, 18 Apr 2019 23:16:26 +0000 (16:16 -0700)]
eio: rely on inheritance and reflection for Efl.IoModel path property.

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8653

5 years agoecore: implement reflection for Efl.LoopModel properties.
Cedric BAIL [Thu, 18 Apr 2019 23:15:16 +0000 (16:15 -0700)]
ecore: implement reflection for Efl.LoopModel properties.

This enable relying on Eo reflection capabilities to expose Efl.Model properties.
Should make API nicer to maintain.

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8652

5 years agoefl_ui_spec: add tests for efl.content
Marcel Hollerbach [Wed, 17 Apr 2019 12:45:19 +0000 (14:45 +0200)]
efl_ui_spec: add tests for efl.content

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D8640

5 years agoelm_part_helper: emit changed events when content is changed
Marcel Hollerbach [Wed, 17 Apr 2019 14:41:33 +0000 (16:41 +0200)]
elm_part_helper: emit changed events when content is changed

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D8639

5 years agoefl_ui_win: do not error when NULL is setted as content
Marcel Hollerbach [Wed, 17 Apr 2019 16:52:31 +0000 (18:52 +0200)]
efl_ui_win: do not error when NULL is setted as content

NULL is valid, and the sub_object code does refuse to allow NULL, hence
we need this check here.

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D8638

5 years agoefl_ui_layout: only delete and unparent objects here when alive
Marcel Hollerbach [Wed, 17 Apr 2019 16:51:32 +0000 (18:51 +0200)]
efl_ui_layout: only delete and unparent objects here when alive

something else might cause the object to get magically revived. Once the
object is invalidated, some things are able to set a parent again, which
causes the widget to continue with refcount 1 and a parent.

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D8637

5 years agoefl_ui_panel: redo content handling
Marcel Hollerbach [Wed, 17 Apr 2019 15:43:21 +0000 (17:43 +0200)]
efl_ui_panel: redo content handling

before the events where not emitted correctly. Additionally input values
like 0x1 have been accepted as valid.

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D8636

5 years agoevas svg: code refactoring.
Hermet Park [Fri, 19 Apr 2019 06:21:07 +0000 (15:21 +0900)]
evas svg: code refactoring.

reorder data fields to packing memory fit.

5 years agovg_common_svg : Implement gradientTransform property of linearGradient
JunsuChoi [Fri, 19 Apr 2019 06:07:11 +0000 (15:07 +0900)]
vg_common_svg : Implement gradientTransform property of linearGradient

Summary:
Svg parser gets transformation matrix information from svg.
If there is a matrix, calculate matrix operations
on the start and end points of the gradient.

TODO: We should implement gradientTransform of radialGradient.

Test Plan: N/A

Reviewers: Hermet, smohanty

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8663

5 years agovg_common_svg: Prevent duplicate operations for percentage value
JunsuChoi [Fri, 19 Apr 2019 04:56:48 +0000 (13:56 +0900)]
vg_common_svg: Prevent duplicate operations for percentage value

Summary:
x1, y1, x2 and y2 of Svg_Linear_Gradient structure must be a percentage value.(0 ~ 1)
but these variables are reused with efl_gfx_gradient_linear_start/end_set/get
and duplicate operations occur.

Test Plan: N/A

Reviewers: Hermet, smohanty

Reviewed By: Hermet

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8662

5 years agoelementary: ensure that the parent model is still alive when resolving future for...
Cedric BAIL [Thu, 28 Mar 2019 19:42:45 +0000 (12:42 -0700)]
elementary: ensure that the parent model is still alive when resolving future for fileselector.

This future where relying on the parent model being alive to work (efl_parent_get). For
that reason we should have been using efl_future_then with the parent Model as a measure
to make sure this is always the case.

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8500

5 years agoecore: move property string definition to shared headers for Efl.Composite_Model.
Cedric BAIL [Thu, 4 Apr 2019 00:24:22 +0000 (17:24 -0700)]
ecore: move property string definition to shared headers for Efl.Composite_Model.

Reviewed-by: SangHyeon Jade Lee <sh10233.lee@samsung.com>
Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es>
Differential Revision: https://phab.enlightenment.org/D8568

5 years agoEvil tests: remove tests of functions provided by mingw-w64
Vincent Torri [Thu, 18 Apr 2019 18:48:12 +0000 (14:48 -0400)]
Evil tests: remove tests of functions provided by mingw-w64

Summary: mingw-w64 developpers already tests basename and dirname

Test Plan: compilation

Reviewers: zmike, raster

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8649

5 years agoeolian: remove legacy generation from tests
Daniel Kolesa [Thu, 18 Apr 2019 17:35:36 +0000 (19:35 +0200)]
eolian: remove legacy generation from tests

5 years agoci: disable mingw build temporarily
Mike Blumenkrantz [Thu, 18 Apr 2019 16:35:52 +0000 (12:35 -0400)]
ci: disable mingw build temporarily

Summary: this cannot succeed until the docker image is rebuilt

Reviewers: lauromoura

Reviewed By: lauromoura

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8648

5 years agomeson: unbreak cxx header installation
Marcel Hollerbach [Thu, 18 Apr 2019 13:31:57 +0000 (09:31 -0400)]
meson: unbreak cxx header installation

Summary:
before we had *correct* fileds in the subdir: keyword. However,
install_dir: was wrong, so *this* time, this seems right.

Reviewers: cedric, zmike, segfaultxavi, raster

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8634

5 years agoWindows: remove fnmatch and regex in Evil and use the ones in regex DLL installed...
Vincent Torri [Thu, 18 Apr 2019 13:31:51 +0000 (09:31 -0400)]
Windows: remove fnmatch and regex in Evil and use the ones in regex DLL installed by ewpi

Test Plan: compilation with autotools and meson (at least as far as it can go)

Reviewers: zmike, raster

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8646

5 years agoecore_sdl: fix detection of sdl with meson build
Vincent Torri [Thu, 18 Apr 2019 13:29:31 +0000 (09:29 -0400)]
ecore_sdl: fix detection of sdl with meson build

Summary: SDL 2.* pkconfig file is sdl2, not sdl

Test Plan: meson configuration

Reviewers: zmike, raster

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8647

5 years agoeolian_gen: remove support for legacy header file generation
Daniel Kolesa [Thu, 18 Apr 2019 16:10:45 +0000 (18:10 +0200)]
eolian_gen: remove support for legacy header file generation

5 years agoautotools: remove usage of eolian_gen .eo.legacy.h generation
Daniel Kolesa [Thu, 18 Apr 2019 15:55:06 +0000 (17:55 +0200)]
autotools: remove usage of eolian_gen .eo.legacy.h generation

5 years agomeson: remove usage of eolian_gen .eo.legacy.h generation
Daniel Kolesa [Thu, 18 Apr 2019 15:50:42 +0000 (17:50 +0200)]
meson: remove usage of eolian_gen .eo.legacy.h generation

5 years agoelm_scroller_legacy: remove generated legacy include
Daniel Kolesa [Thu, 18 Apr 2019 15:08:47 +0000 (17:08 +0200)]
elm_scroller_legacy: remove generated legacy include

Instead replace with the type definitions in this place. It is
not included from anywhere else, so it's fine.

5 years agotests: add api coverage for evas image
Mike Blumenkrantz [Tue, 16 Apr 2019 12:34:09 +0000 (08:34 -0400)]
tests: add api coverage for evas image

verify that legacy apis function as expected when using legacy api to
load and unload images

Reviewed-by: Hermet Park <hermetpark@gmail.com>
Differential Revision: https://phab.enlightenment.org/D8619

5 years agoevas: implement Efl.File.unload for evas image classes
Mike Blumenkrantz [Thu, 18 Apr 2019 13:05:31 +0000 (09:05 -0400)]
evas: implement Efl.File.unload for evas image classes

this fixes unloading images using the evas_object_image_file_set legacy
api

ref D8616

Differential Revision: https://phab.enlightenment.org/D8618

5 years agoevas_legacy: remove unused generated legacy includes
Daniel Kolesa [Thu, 18 Apr 2019 13:45:44 +0000 (15:45 +0200)]
evas_legacy: remove unused generated legacy includes

These define types never used in Evas_Legacy.h.

5 years agoefl_ui_layout, elm_layout_legacy: add missing/remove unused include
Daniel Kolesa [Thu, 18 Apr 2019 13:31:55 +0000 (15:31 +0200)]
efl_ui_layout, elm_layout_legacy: add missing/remove unused include

The efl_ui_layout.eo.h header was incorrectly not included in
Elementary.h, which resulted in build failures after the legacy
and otherwise unused efl_ui_layout.eo.legacy.h include was removed.

5 years agoelm_progressbar_legacy: remove unused include
Daniel Kolesa [Thu, 18 Apr 2019 13:28:59 +0000 (15:28 +0200)]
elm_progressbar_legacy: remove unused include

This does not define anything useful.

5 years agoefl_ui_slider: remove unused legacy header include
Daniel Kolesa [Thu, 18 Apr 2019 13:27:50 +0000 (15:27 +0200)]
efl_ui_slider: remove unused legacy header include

This does not define anything useful.

5 years agoelm_image_legacy: remove bad "legacy" include
Daniel Kolesa [Thu, 18 Apr 2019 13:24:58 +0000 (15:24 +0200)]
elm_image_legacy: remove bad "legacy" include

This only contains some Efl_ structures and typedefs now, hidden
behind a BETA_API define. It has no place in legacy.

5 years agoecore-drm2: Fix API function parameters for background color set
Christopher Michael [Thu, 18 Apr 2019 13:10:49 +0000 (09:10 -0400)]
ecore-drm2: Fix API function parameters for background color set

Passing int as parameters here is too small for left shifting the
colors so make these parameters uint64_t