platform/upstream/llvm.git
4 years ago[BPF] generate BTF_KIND_VARs for all non-static globals
Yonghong Song [Tue, 12 Nov 2019 19:31:52 +0000 (11:31 -0800)]
[BPF] generate BTF_KIND_VARs for all non-static globals

Enable to generate BTF_KIND_VARs for non-static
default-section globals which is not allowed previously.
Modified the existing test case to accommodate the new change.

Also removed unused linkage enum members VAR_GLOBAL_TENTATIVE and
VAR_GLOBAL_EXTERNAL.

Differential Revision: https://reviews.llvm.org/D70145

4 years ago[GlobalsAA] Restrict ModRef result if any internal method has its address taken.
Alina Sbirlea [Thu, 31 Oct 2019 19:35:46 +0000 (12:35 -0700)]
[GlobalsAA] Restrict ModRef result if any internal method has its address taken.

Summary:
If there are any internal methods whose address was taken, conclude there is nothing known in relation of any other internal method and a global.

Reviewers: nlopes, sanjoy.google

Subscribers: hiraditya, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D69690

4 years ago[LLDB] Fix/silence CMake developer warning for LLDB framework.
Jonas Devlieghere [Tue, 12 Nov 2019 22:15:06 +0000 (14:15 -0800)]
[LLDB] Fix/silence CMake developer warning for LLDB framework.

This fixes the following warning for developers:

  Target 'liblldb' was changed to a FRAMEWORK sometime after install().  This
  may result in the wrong install DESTINATION.  Set the FRAMEWORK property
  earlier.

The solution is to pass the FRAMEWORK flag to add_lldb_library and set
the target property before install(). For now liblldb is the only
customer.

4 years ago[GVNHoist] Preserve AAResults.
Alina Sbirlea [Tue, 12 Nov 2019 22:07:32 +0000 (14:07 -0800)]
[GVNHoist] Preserve AAResults.

Resolves PR38906, PR40898.

4 years agoAllow additional file suffixes/extensions considered as source in main include grouping
mydeveloperday [Tue, 12 Nov 2019 21:15:17 +0000 (21:15 +0000)]
Allow additional file suffixes/extensions considered as source in main include grouping

Summary:
By additional regex match, grouping of main include can be enabled in files that are not normally considered as a C/C++ source code.
For example, this might be useful in templated code, where template implementations are being held in *Impl.hpp files.
On the occassion, 'assume-filename' option description was reworded as it was misleading. It has nothing to do with `style=file` option and it does not influence sourced style filename.

Reviewers: rsmith, ioeric, krasimir, sylvestre.ledru, MyDeveloperDay

Reviewed By: MyDeveloperDay

Subscribers: MyDeveloperDay, cfe-commits

Patch by:  furdyna

Tags: #clang

Differential Revision: https://reviews.llvm.org/D67750

4 years ago[LLDB] Always remove debugserver from LLVM_DISTRIBUTION_COMPONENTS
Jonas Devlieghere [Tue, 12 Nov 2019 20:57:00 +0000 (12:57 -0800)]
[LLDB] Always remove debugserver from LLVM_DISTRIBUTION_COMPONENTS

Centralize the logic to remove debugserver from
LLVM_DISTRIBUTION_COMPONENTS when LLDB_USE_SYSTEM_DEBUGSERVER is
enabled. Now this happens regardless of whether the tests are enabled.

4 years ago[AArch64] Update for Exynos
Evandro Menezes [Tue, 12 Nov 2019 20:28:25 +0000 (14:28 -0600)]
[AArch64] Update for Exynos

Fix the modeling for loads and stores using the register offset addresing mode.

4 years ago[AArch64] Fix addressing mode predicates
Evandro Menezes [Tue, 12 Nov 2019 20:13:30 +0000 (14:13 -0600)]
[AArch64] Fix addressing mode predicates

Fix predicates related to the register offset addressing mode.

4 years ago[CodeGen] Fix getArrayAccessFor crashes as in bug 32534 with -polly-vectorizer=polly.
Michael Kruse [Tue, 12 Nov 2019 19:48:07 +0000 (13:48 -0600)]
[CodeGen] Fix getArrayAccessFor crashes as in bug 32534 with -polly-vectorizer=polly.

Root cause is VectorBlockGenerator::copyStmt iterates all instructions
in basic block, however some load instructions may be not unnecessary
thus removed by simplification. As a result, these load instructions
don't have a corresponding array.

Looking at BlockGenerator::copyBB, it only iterates instructions list
of ScopStmt. Given it must be a block type scop in case of
vectorization, I think we should do the same in
VectorBlockGenerator::copyStmt.

Patch by bin.narwal <bin.narwal@gmail.com>

Differential Revision: https://reviews.llvm.org/D70076

4 years ago[Analyzer] Use a reference in a range-based for
Mark de Wever [Tue, 12 Nov 2019 19:51:06 +0000 (20:51 +0100)]
[Analyzer] Use a reference in a range-based for

Let the checkers use a reference instead of a copy in a range-based
for loop.

This avoids new warnings due to D68912 adds -Wrange-loop-analysis to -Wall.

Differential Revision: https://reviews.llvm.org/D70047

4 years ago[OpenMP] Use an explicit copy in a range-based for
Mark de Wever [Tue, 12 Nov 2019 19:48:11 +0000 (20:48 +0100)]
[OpenMP] Use an explicit copy in a range-based for

The std::pair<const clang::ValueDecl *, llvm::ArrayRef<clang::OMPClauseMappableExprCommon::MappableComponent>>
type will be copied in a range-based for loop. Make the copy explicit to
avoid the -Wrange-loop-analysis warning.

This avoids new warnings due to D68912 adds -Wrange-loop-analysis to -Wall.

Differential Revision: https://reviews.llvm.org/D70046

4 years ago[AST] Use an explicit copy in a range-based for
Mark de Wever [Tue, 12 Nov 2019 19:46:19 +0000 (20:46 +0100)]
[AST] Use an explicit copy in a range-based for

The AssociationIteratorTy type will be copied in a range-based for loop.
Make the copy explicit to avoid the -Wrange-loop-analysis warning.

This avoids new warnings due to D68912 adds -Wrange-loop-analysis to -Wall.

Differential Revision: https://reviews.llvm.org/D70045

4 years ago[LLDB][Formatters] Re-enable std::function formatter with fixes to improve non-cached...
shafik [Tue, 12 Nov 2019 19:23:38 +0000 (11:23 -0800)]
[LLDB][Formatters] Re-enable std::function formatter with fixes to improve non-cached lookup performance

Performance issues lead to the libc++ std::function formatter to be disabled. We addressed some of those performance issues by adding caching see D67111
This PR fixes the first lookup performance by not using FindSymbolsMatchingRegExAndType(...) and instead finding the compilation unit the std::function wrapped callable should be in and then searching for the callable directly in the CU.

Differential Revision: https://reviews.llvm.org/D69913

4 years ago[llvm-objcopy][COFF] Implement --redefine-sym and --redefine-syms
Fangrui Song [Sat, 9 Nov 2019 00:19:33 +0000 (16:19 -0800)]
[llvm-objcopy][COFF] Implement --redefine-sym and --redefine-syms

The parsing error tests in ELF/redefine-symbols.test are not specific to ELF.
Move them to redefine-symbols.test.
Add COFF/redefine-symbols.test for COFF specific tests.

Also fix the documentation regarding --redefine-syms: the old and new
names are separated by whitespace, not an equals sign.

Reviewed By: mstorsjo

Differential Revision: https://reviews.llvm.org/D70036

4 years ago[ObjectFileMachO] Fix the build for __arm64__.
Davide Italiano [Tue, 12 Nov 2019 19:10:36 +0000 (11:10 -0800)]
[ObjectFileMachO] Fix the build for __arm64__.

Catch up with an API change.

4 years agoARM: Don't emit R_ARM_NONE relocations to compact unwinding decoders in .ARM.exidx...
Peter Collingbourne [Fri, 8 Nov 2019 19:03:34 +0000 (11:03 -0800)]
ARM: Don't emit R_ARM_NONE relocations to compact unwinding decoders in .ARM.exidx on Android.

These relocations are specified by the ARM EHABI (section 6.3). As I understand
it, their purpose is to accommodate unwinder implementations that wish to
reduce code size by placing the implementations of the compact unwinding
decoders in a separate translation unit, and using extern weak symbols to
refer to them from the main unwinder implementation, so that they are only
linked when something in the binary needs them in order to unwind.

However, neither of the unwinders used on Android (libgcc, LLVM libunwind)
use this technique, and in fact emitting these relocations ends up being
counterproductive to code size because they cause a copy of the unwinder
to be statically linked into most binaries, regardless of whether it is
actually needed. Furthermore, these relocations create circular dependencies
(between libc and the unwinder) in cases where the unwinder is dynamically
linked and libc contains compact unwind info.

Therefore, deviate from the EHABI here and stop emitting these relocations
on Android.

Differential Revision: https://reviews.llvm.org/D70027

4 years agoFix build with shared libraries. NFC.
Michael Liao [Tue, 12 Nov 2019 18:37:27 +0000 (13:37 -0500)]
Fix build with shared libraries. NFC.

- Dependent components need linking directly.

4 years ago[OPENMP]Use copy constructors instead of assignment operators in declare
Alexey Bataev [Tue, 12 Nov 2019 16:19:26 +0000 (11:19 -0500)]
[OPENMP]Use copy constructors instead of assignment operators in declare
reduction initializers.

Better to use copy constructor at the initialization of the declare
reduction construct rather than assignment operator.

4 years ago[libcxxabi] Prevent cmake from removing our explicit system C++ include paths
Sam Clegg [Thu, 7 Nov 2019 22:51:25 +0000 (14:51 -0800)]
[libcxxabi] Prevent cmake from removing our explicit system C++ include paths

We build with `-nostdinc++` and add our own header path via
`LIBCXXABI_LIBCXX_INCLUDES`.  However cmake tried to be clever and if
`LIBCXXABI_LIBCXX_INCLUDES` happens to match the compilers system path
it will remove the `-I` flag meaning we can't access any C++ headers.

Ideally cmake would be able see that we are using `-nostdinc++` and
disable this behaviour.

Differential Revision: https://reviews.llvm.org/D69973

4 years ago[Hexagon] Update PS_aligna with max stack alignment once isel completes
Krzysztof Parzyszek [Tue, 12 Nov 2019 17:42:27 +0000 (11:42 -0600)]
[Hexagon] Update PS_aligna with max stack alignment once isel completes

4 years agoPerformance: Add a set of visited SymbolFiles to the other FindFiles variant.
Adrian Prantl [Tue, 12 Nov 2019 17:25:59 +0000 (09:25 -0800)]
Performance: Add a set of visited SymbolFiles to the other FindFiles variant.

This is basically the same bug as in r260434.

SymbolFileDWARF::FindTypes has exponential worst-case when digging
through dependency DAG of .pcm files because each object file and .pcm
file may depend on an already-visited .pcm file, which may again have
dependencies. Fixed here by carrying a set of already visited
SymbolFiles around.

rdar://problem/56993424

Differential Revision: https://reviews.llvm.org/D70106

4 years ago[lit] Better/earlier errors for empty runs
Julian Lettner [Tue, 12 Nov 2019 16:24:26 +0000 (08:24 -0800)]
[lit] Better/earlier errors for empty runs

Fail early, when we discover no tests at all, or filter out all of them.

There is also `--allow-empty-runs` to disable test to allow workflows
like `LIT_FILTER=abc ninja check-all`.  Apparently `check-all` invokes
lit multiple times if certain projects are enabled, which would produce
unwanted "empty runs". Specify via `LIT_OPTS=--allow-empty-runs`.

There are 3 causes for empty runs:
1) No tests discovered.  This is always an error.  Fix test suite config
   or command line.
2) All tests filtered out.  This is an error by default, but can be
   suppressed via `--alow-empty-runs`.  Should prevent accidentally
   passing empty runs, but allow the workflow above.
3) The number of shards is greater than the number of tests.  Currently,
   this is never an error.  Personally, I think we should consider
   making this an error by default; if this happens, you are doing
   something wrong. I added a warning but did not change the behavior,
   since this warrants more discussion.

Reviewed By: atrick, jdenny

Differential Revision: https://reviews.llvm.org/D70105

4 years agoclang/Modules: Error if ReadASTBlock does not find the main module
Duncan P. N. Exon Smith [Sun, 10 Nov 2019 21:14:52 +0000 (13:14 -0800)]
clang/Modules: Error if ReadASTBlock does not find the main module

If ReadASTBlock does not find its top-level submodule, there's something
wrong the with the PCM.  Error in that case, to avoid hitting problems
further from the source.

Note that the Swift compiler sometimes hits a case in
CompilerInstance::loadModule where the top-level submodule mysteriously
does not have Module::IsFromModuleFile set.  That will emit a confusing
warn_missing_submodule, which was never intended for the main module.
The recent audit of error-handling in ReadAST may have rooted out the
real problem.  If not, this commit will help to clarify the real
problem, and replace a confusing warning with an error pointing at the
malformed PCM file.

We're specifically sniffing out whether the top-level submodule was
found/processed, in case there is a malformed module file that is
missing it.  If there is an error encountered during ReadSubmoduleBlock
the return status should already propagate through.  It would be nice to
detect other missing submodules around here to catch other instances of
warn_missing_submodule closer to the source, but that's left as a future
exercise.

https://reviews.llvm.org/D70063

4 years ago[SLP] add test for miscompile with reduction (PR43948); NFC
Sanjay Patel [Tue, 12 Nov 2019 16:36:41 +0000 (11:36 -0500)]
[SLP] add test for miscompile with reduction (PR43948); NFC

4 years ago[Hexagon] Fix vector spill expansion to use proper alignment
Krzysztof Parzyszek [Mon, 11 Nov 2019 15:05:21 +0000 (09:05 -0600)]
[Hexagon] Fix vector spill expansion to use proper alignment

1. Add pseudos PS_vloadrv_ai and PS_vstorerv_ai: those are now used
   for single vector registers in loadRegFromStackSlot (and store...).
2. Remove pseudos PS_vloadrwu_ai and PS_vstorerwu_ai. The alignment is
   now checked when expanding spill pseudos (both in frame lowering
   and in expand-post-ra-pseudos), and a proper instruction is generated.
3. Update MachineMemOperands when dealigning vector spill slots.
4. Return vector predicate registers in getCallerSavedRegs.

4 years ago[Hexagon] Convert stack object offsets to int64, NFC
Krzysztof Parzyszek [Mon, 11 Nov 2019 14:49:07 +0000 (08:49 -0600)]
[Hexagon] Convert stack object offsets to int64, NFC

This will print [SP-56] instead of [SP+4294967240].

4 years ago[Hexagon] Handle stack realignment in hexagon-vextract
Krzysztof Parzyszek [Sat, 9 Nov 2019 01:07:02 +0000 (19:07 -0600)]
[Hexagon] Handle stack realignment in hexagon-vextract

4 years ago[Hexagon] Require PS_aligna whenever variable-sized objects are present
Krzysztof Parzyszek [Sat, 9 Nov 2019 01:05:28 +0000 (19:05 -0600)]
[Hexagon] Require PS_aligna whenever variable-sized objects are present

4 years ago[PowerPC] Remove allow-deprecated-dag-overlap and fix broken tests
Jinsong Ji [Tue, 12 Nov 2019 15:00:09 +0000 (15:00 +0000)]
[PowerPC] Remove allow-deprecated-dag-overlap and fix broken tests

Summary:
This is found during review of https://reviews.llvm.org/D67088.

CHECK-DAG is non-overlapping after https://reviews.llvm.org/D47106.
-allow-deprecated-dag-overlap was introduced to temporary accept old
behavior.

But it actually hide some broken tests, eg: `test/CodeGen/PowerPC/swaps-le-1.ll`
The codegen has changed, but the CHECK-DAG still PASS due to allowing `overlap`.

This patch remove the deprecated options, and fix the broken tests.

Reviewers: #powerpc, hfinkel, nemanjai, steven.zhang, shchenz

Reviewed By: shchenz

Subscribers: shchenz, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D69733

4 years ago[DBG][OPT] Attempt to salvage or undef debug info when removing trivially deletable...
Tom Weaver [Tue, 12 Nov 2019 15:17:04 +0000 (15:17 +0000)]
[DBG][OPT] Attempt to salvage or undef debug info when removing trivially deletable instructions in the Reassociate Expression pass.

Reviewed By: aprantl, vsk

Differential revision: https://reviews.llvm.org/D69943

4 years ago[PowerPC][NFC]Fix typo in desc for enable-ppc-prefetching
Jinsong Ji [Tue, 12 Nov 2019 14:46:57 +0000 (14:46 +0000)]
[PowerPC][NFC]Fix typo in desc for enable-ppc-prefetching

4 years ago[Examples] Add IRTransformations directory to examples.
Florian Hahn [Tue, 12 Nov 2019 14:06:12 +0000 (14:06 +0000)]
[Examples] Add IRTransformations directory to examples.

This patch adds a new IRTransformations directory to llvm/examples/. This is
intended to serve as a new home for example transformations/analysis
code used by various tutorials.

If LLVM_BUILD_EXAMPLES is enabled, the ExamplesIRTransforms library is
linked into the opt binary and the example passes become available.

To start off with, it contains the CFG simplifications used in the IR
part of the 'Getting Started With LLVM: Basics' tutorial at the US LLVM
Developers Meeting 2019.

Reviewers: paquette, jfb, meikeb, lhames, kbarton

Reviewed By: paquette

Differential Revision: https://reviews.llvm.org/D69416

4 years agoRevert "Fix lookup of symbols at the same address with no size vs. size"
Muhammad Omair Javaid [Tue, 12 Nov 2019 13:48:32 +0000 (18:48 +0500)]
Revert "Fix lookup of symbols at the same address with no size vs. size"

This reverts commit 3f594ed1686b44138bee245c708773e526643aaf.

This change has cause LLDB expression evaluation to fail on Arm Linux.

Differential Revision: https://reviews.llvm.org/D63540

4 years ago[lldb] Fix more -Wdeprecated-copy warnings
Pavel Labath [Tue, 12 Nov 2019 13:25:18 +0000 (14:25 +0100)]
[lldb] Fix more -Wdeprecated-copy warnings

This warning triggers when a class defines a copy constructor but not a
copy-assignment operator (which then gets auto-generated by the
compiler). Fix the warning by deleting the other operator too, as the
default implementation works just fine.

4 years ago[lldb] Fix some warnings in the python plugin
Pavel Labath [Tue, 12 Nov 2019 13:33:52 +0000 (14:33 +0100)]
[lldb] Fix some warnings in the python plugin

4 years agoMark llvm::ConstantExpr::getAsInstruction as const
Alex Denisov [Tue, 12 Nov 2019 09:57:32 +0000 (10:57 +0100)]
Mark llvm::ConstantExpr::getAsInstruction as const

Summary:
getAsInstruction is the only non-const member method.
It is impossible to enforce const-correctness because of it.

Reviewers: jmolloy, majnemer

Reviewed By: jmolloy

Subscribers: hiraditya, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D70113

4 years agoAArch64: add arm64_32 support to Clang.
Tim Northover [Tue, 18 Sep 2018 09:34:39 +0000 (10:34 +0100)]
AArch64: add arm64_32 support to Clang.

4 years ago[lldb] [Process/NetBSD] Use PT_STOP to stop the process [NFCI]
Michał Górny [Sun, 10 Nov 2019 17:39:55 +0000 (18:39 +0100)]
[lldb] [Process/NetBSD] Use PT_STOP to stop the process [NFCI]

Differential Revision: https://reviews.llvm.org/D70060

4 years ago[AArch64ExpandPseudos] Preserve renamable state when expanding MOVi64 & co.
Florian Hahn [Tue, 12 Nov 2019 10:35:31 +0000 (10:35 +0000)]
[AArch64ExpandPseudos] Preserve renamable state when expanding MOVi64 & co.

If the MOVi operand was renamable, the operands of the expanded
instructions are also renamable.

Reviewers: thegameg, samparker, zatrazz

Reviewed By: thegameg

Differential Revision: https://reviews.llvm.org/D70061

4 years ago[InstCombine] Skip scalable vectors in combineLoadToOperationType
Diana Picus [Thu, 7 Nov 2019 12:09:32 +0000 (13:09 +0100)]
[InstCombine] Skip scalable vectors in combineLoadToOperationType

Don't try to canonicalize loads to scalable vector types to loads
of integers.

This removes one assertion when trying to use a TypeSize as a parameter
to DataLayout::isLegalInteger. It does not handle the second part of the
function (which looks at bitcasts).

This patch also contains a NFC fix for Load Analysis, where a variable
initialization that would cause the same assertion is moved closer to
its use. This allows us to run the new test for InstCombine without
having to teach LocationSize to play nicely with scalable vectors.

Differential Revision: https://reviews.llvm.org/D70075

4 years ago[X86] Cleanup prefixes + regenerate for fp-intrinsics-fma.ll
Simon Pilgrim [Tue, 12 Nov 2019 11:24:00 +0000 (11:24 +0000)]
[X86] Cleanup prefixes + regenerate for fp-intrinsics-fma.ll

4 years agoFileCheckPattern::FindRegexVarEnd - make helper function static. NFC
Simon Pilgrim [Tue, 12 Nov 2019 11:14:03 +0000 (11:14 +0000)]
FileCheckPattern::FindRegexVarEnd - make helper function static. NFC

Fixes cppcheck warning.

4 years ago[X86] Add PR39464 addcarry/subborrow test cases
Simon Pilgrim [Tue, 12 Nov 2019 11:11:40 +0000 (11:11 +0000)]
[X86] Add PR39464 addcarry/subborrow test cases

Additional coverage for D70079

4 years ago[lldb][test] Macros in expressions require DWARF 5
Tatyana Krasnukha [Mon, 11 Nov 2019 17:36:55 +0000 (20:36 +0300)]
[lldb][test] Macros in expressions require DWARF 5

4 years ago[LoopInterchange] Only skip PHIs with incoming values from the inner loop.
Florian Hahn [Tue, 12 Nov 2019 10:23:26 +0000 (10:23 +0000)]
[LoopInterchange] Only skip PHIs with incoming values from the inner loop.

Currently we have limited support for outer loops with multiple basic
blocks after the inner loop exit. But the current checks for creating
PHIs for loop exit values only assumes the header and latches of the
outer loop. It is better to just skip incoming values defined in the
original inner loops. Those are handled earlier.

Reviewers: efriedma, mcrosier

Reviewed By: efriedma

Differential Revision: https://reviews.llvm.org/D70059

4 years ago[lldb][NFC] Simplify a return in ThreadPlanStepInRange::DefaultShouldStopHereCallback
Raphael Isemann [Tue, 12 Nov 2019 09:58:46 +0000 (10:58 +0100)]
[lldb][NFC] Simplify a return in ThreadPlanStepInRange::DefaultShouldStopHereCallback

We know should_stop_here is false here, so we might as well return false directly.

4 years agoDWARFDebugLoclists: add location list "interpretation" logic
Pavel Labath [Thu, 7 Nov 2019 09:33:18 +0000 (10:33 +0100)]
DWARFDebugLoclists: add location list "interpretation" logic

Summary:
This patch extracts the logic for computing the "absolute" locations,
which was partially present in the debug_loclists dumper, completes it,
and moves it into a separate function. This makes it possible to later
reuse the same logic for uses other than dumping.

The dumper is changed to reuse the location list interpreter, and its
format is changed somewhat. In "verbose" mode it prints the "raw" value
of a location list, the interpreted location (if available) and the
expression itself. In non-verbose mode it prints only one of the
location forms: it prefers the interpreted form, but falls back to the
"raw" format if interpretation is not possible (for instance, because we
were not given a base address, or the resolution of indirect addresses
failed).

This patch also undos some of the changes made in D69672, namely the
part about making all functions static. The main reason for this is that
I learned that the original approach (dumping only fully resolved
locations) meant that it was impossible to rewrite one of the existing
tests. To make that possible (and make the "inline location" dump work
in more cases), I now reuse the same dumping mechanism as is used for
section-based dumping. As this required having more objects know about
the various location lists classes, it seemed like a good idea to create
an interface abstracting the difference between them.

Therefore, I now create a DWARFLocationTable class, which will serve as
a base class for the location list classes. DWARFDebugLoclists is made
to inherit from that. DWARFDebugLoc will follow.

Another positive effect of this change is that section-based dumping
code will not need to use templates (as originally) envisioned, and that
the argument lists of the dumping functions become shorter.

Reviewers: dblaikie, probinson, JDevlieghere, aprantl, SouraVX

Subscribers: hiraditya, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D70081

4 years ago[X86] Add more add/sub carry tests
David Zarzycki [Mon, 11 Nov 2019 13:07:51 +0000 (15:07 +0200)]
[X86] Add more add/sub carry tests

Preparation for: https://reviews.llvm.org/D70079

https://reviews.llvm.org/D70077

4 years ago[clang-format] [PR36294] AlwaysBreakAfterReturnType works incorrectly for some operat...
mydeveloperday [Tue, 12 Nov 2019 09:14:51 +0000 (09:14 +0000)]
[clang-format] [PR36294] AlwaysBreakAfterReturnType works incorrectly for some operator functions

Summary:
https://bugs.llvm.org/show_bug.cgi?id=36294

Addressing bug related to returning after return type not being honoured for some operator types.

```
$ bin/clang-format --style="{BasedOnStyle: llvm, AlwaysBreakAfterReturnType: TopLevelDefinitions}" /tmp/foo.cpp
class Foo {
public:
  bool operator!() const;
  bool operator<(Foo const &) const;
  bool operator*() const;
  bool operator->() const;
  bool operator+() const;
  bool operator-() const;
  bool f() const;
};

bool Foo::operator!() const { return true; }
bool
Foo::operator<(Foo const &) const {
  return true;
}
bool Foo::operator*() const { return true; }
bool Foo::operator->() const { return true; }
bool
Foo::operator+() const {
  return true;
}
bool
Foo::operator-() const {
  return true;
}
bool
Foo::f() const {
  return true;
}
```

Reviewers: mitchell-stellar, klimek, owenpan, sammccall, rianquinn

Reviewed By: sammccall

Subscribers: merge_guards_bot, cfe-commits

Tags: #clang-format, #clang-tools-extra, #clang

Differential Revision: https://reviews.llvm.org/D69573

4 years ago[lldb] Add missing include to ObjCLanguage.cpp to fix build
Raphael Isemann [Tue, 12 Nov 2019 09:21:49 +0000 (10:21 +0100)]
[lldb] Add missing include to ObjCLanguage.cpp to fix build

4 years ago[lldb][NFC] Move LLVM RTTI implementation from enum to static ID variable
Raphael Isemann [Tue, 12 Nov 2019 09:04:32 +0000 (10:04 +0100)]
[lldb][NFC] Move LLVM RTTI implementation from enum to static ID variable

Summary:
swift-lldb currently has to patch the ExpressionKind enum to add support for Swift expressions. If we implement LLVM's RTTI
with a static ID variable instead of a centralised enum we can drop that patch.

Reviewers: labath, davide

Reviewed By: labath

Subscribers: JDevlieghere, lldb-commits

Tags: #upstreaming_lldb_s_downstream_patches, #lldb

Differential Revision: https://reviews.llvm.org/D70070

4 years ago[lldb][NFC] Remove unused CompilerType::IsPossibleCPlusPlusDynamicType
Raphael Isemann [Tue, 12 Nov 2019 09:02:59 +0000 (10:02 +0100)]
[lldb][NFC] Remove unused CompilerType::IsPossibleCPlusPlusDynamicType

Reviewers: davide, xiaobai

Reviewed By: davide, xiaobai

Subscribers: davide, JDevlieghere, lldb-commits

Tags: #lldb

Differential Revision: https://reviews.llvm.org/D70074

4 years ago[lldb] Check if we actually have a Clang type in ObjCLanguage::GetPossibleFormattersM...
Raphael Isemann [Mon, 11 Nov 2019 13:25:54 +0000 (14:25 +0100)]
[lldb] Check if we actually have a Clang type in ObjCLanguage::GetPossibleFormattersMatches

We call IsPossibleDynamicType but we also need to check if this is a Clang type,
otherwise other languages with dynamic types (like Swift) might end up being interpreted
as potential Obj-C dynamic types.

4 years ago[NFC][InstCombine] Add tests that show a number of canonicalization opportunities
Daniil Suchkov [Mon, 30 Sep 2019 05:16:37 +0000 (12:16 +0700)]
[NFC][InstCombine] Add tests that show a number of canonicalization opportunities

Reviewers: spatel, RKSimon, lebedev.ri, apilipenko

Reviewed-By: apilipenko
Tags: #llvm

Subscribers: llvm-commits

Differential Revision: https://reviews.llvm.org/D68263

4 years agoMCP: Fixed bug with dest overlapping copy source
Tim Renouf [Mon, 11 Nov 2019 11:06:09 +0000 (11:06 +0000)]
MCP: Fixed bug with dest overlapping copy source

In MachineCopyPropagation, when propagating the source of a copy into
the operand of a later instruction, bail if a destination overlaps
(partly defines) the copy source. If the instruction where the
substitution is happening is also a copy, allowing the propagation
confuses the tracking mechanism.

Differential Revision: https://reviews.llvm.org/D69953

Change-Id: Ic570754f878f2d91a4a50a9bdcf96fbaa240726d

4 years ago[X86] Add fptosi test to fp-intrinsics.ll
Craig Topper [Tue, 12 Nov 2019 07:30:55 +0000 (23:30 -0800)]
[X86] Add fptosi test to fp-intrinsics.ll

4 years ago[X86] Update stale comment. NFC
Craig Topper [Tue, 12 Nov 2019 04:35:58 +0000 (20:35 -0800)]
[X86] Update stale comment. NFC

4 years ago[VFABI] Remove unused variables in testcase, fix buildbot
Mikael Holmen [Tue, 12 Nov 2019 07:28:12 +0000 (08:28 +0100)]
[VFABI] Remove unused variables in testcase, fix buildbot

E.g. the buildbot at

 http://lab.llvm.org:8011/builders/ppc64le-lld-multistage-test/builds/7259/steps/build-stage2-unified-tree/logs/stdio

failed with

/home/buildbots/ppc64le-lld-multistage-test/ppc64le-lld-multistage-test/llvm-project/llvm/unittests/Transforms/Utils/VFABIUtils.cpp:50:22: error: unused variable 'FnAttrs' [-Werror,-Wunused-variable]
  const AttributeSet FnAttrs = Attrs.getFnAttributes();
                     ^
1 error generated.

4 years ago[llvm-readelf/llvm-readobj][test] - Convert elf-linker-options.ll to use YAML.
Georgii Rymar [Fri, 8 Nov 2019 12:21:24 +0000 (15:21 +0300)]
[llvm-readelf/llvm-readobj][test] - Convert elf-linker-options.ll to use YAML.

This converts elf-linker-options.ll to use yaml2obj instead of llc,
improves and cleanups it a bit.

This opens a road to add an additional tests for checking the broken cases.

Differential revision: https://reviews.llvm.org/D70004

4 years ago[yaml2obj/obj2yaml] - Add support for SHT_LLVM_LINKER_OPTIONS sections.
Georgii Rymar [Wed, 6 Nov 2019 15:14:12 +0000 (18:14 +0300)]
[yaml2obj/obj2yaml] - Add support for SHT_LLVM_LINKER_OPTIONS sections.

SHT_LLVM_LINKER_OPTIONS section contains pairs of null-terminated strings.
This patch adds support for them.

Differential revision: https://reviews.llvm.org/D69895

4 years ago[Attributor] Use must-be-executed-context in align deduction
Hideto Ueno [Tue, 12 Nov 2019 06:36:49 +0000 (06:36 +0000)]
[Attributor] Use must-be-executed-context in align deduction

Summary:
This patch introduces align attribute deduction for callsite argument, function argument, function returned and floating value based on must-be-executed-context.

Reviewers: jdoerfert, sstefan1

Reviewed By: jdoerfert

Subscribers: hiraditya, jfb, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D69797

4 years ago[Support] Optimize SHA1 implementation
Nick Terrell [Tue, 12 Nov 2019 06:07:12 +0000 (22:07 -0800)]
[Support] Optimize SHA1 implementation

* Add inline to the helper functions because gcc-9 won't inline all of
  them without the hint. I've avoided `__attribute__((always_inline))`
  because gcc and clang will inline without it, and improves
  compatibility.
* Replace the byte-by-byte copy in update() with endian::readbe32()
  since perf reports that 1/2 of the time is spent copying into the
  buffer before this patch.

When lld uses --build-id=sha1 it spends 30-45% of CPU in SHA1 depending on the binary (not wall-time since it is parallel). This patch speeds up SHA1 by a factor of 2 on clang-8 and 3 on gcc-6. This leads to a >10% improvement in overall linking time.

lld-speed-test benchmarks run on an Intel i9-9900k with Turbo disabled on CPU 0 compiled with clang-9. Stats recorded with `perf stat -r 5`. All inputs are using `--build-id=sha1`.

| Input | Before (seconds) | After (seconds) |
| --- | --- | --- |
| chrome | 2.14 | 1.82 (-15%) |
| chrome-icf | 2.56 | 2.29 (-10%) |
| clang | 0.65 | 0.53 (-18%) |
| clang-fsds | 0.69 | 0.58 (-16%) |
| clang-gdb-index | 21.71 | 19.3 (-11%) |
| gold | 0.42 | 0.34 (-19%) |
| gold-fsds | 0.431 | 0.355 (-17%) |
| linux-kernel | 0.625 | 0.575 (-8%) |
| llvm-as | 0.045 | 0.039 (-14%) |
| llvm-as-fsds | 0.035 | 0.039 (-11%) |
| mozilla | 11.3 | 9.8  (-13%) |
| mozilla-gc | 11.84 | 10.36 (-12%) |
| mozilla-O0 | 8.2 | 5.84 (-28%) |
| scylla | 5.59 | 4.52 (-19%) |

Reviewed By: ruiu, MaskRay

Differential Revision: https://reviews.llvm.org/D69295

4 years agoAMDGPU/SI: make ~SIScheduleBlockCreator trivial
Fangrui Song [Tue, 12 Nov 2019 05:51:59 +0000 (21:51 -0800)]
AMDGPU/SI: make ~SIScheduleBlockCreator trivial

4 years ago[PDB] Make pdb::DbiModuleDescriptor destructor trivial
Fangrui Song [Tue, 12 Nov 2019 05:26:26 +0000 (21:26 -0800)]
[PDB] Make pdb::DbiModuleDescriptor destructor trivial

4 years ago[SLP] Look-ahead operand reordering heuristic.
Vasileios Porpodas [Mon, 11 Nov 2019 18:50:20 +0000 (18:50 +0000)]
[SLP] Look-ahead operand reordering heuristic.

Summary: This patch introduces a new heuristic for guiding operand reordering. The new "look-ahead" heuristic can look beyond the immediate predecessors. This helps break ties when the immediate predecessors have identical opcodes (see lit test for examples).

Reviewers: RKSimon, ABataev, dtemirbulatov, Ayal, hfinkel, rnk

Reviewed By: RKSimon, dtemirbulatov

Subscribers: xbolva00, Carrot, hiraditya, phosek, rnk, rcorcs, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D60897

4 years agoFix null dereference in yaml::Document::skip
Thomas Finch [Tue, 12 Nov 2019 04:48:28 +0000 (20:48 -0800)]
Fix null dereference in yaml::Document::skip

Summary: The attached test case replicates a null dereference crash in
`yaml::Document::skip()`. This was fixed by adding a check and early
return in the method.

Reviewers: Bigcheese, hintonda, beanz

Reviewed By: hintonda

Subscribers: hiraditya, dexonsmith, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D69974

4 years agogn build: Merge e9a06e06064
LLVM GN Syncbot [Tue, 12 Nov 2019 03:49:52 +0000 (03:49 +0000)]
gn build: Merge e9a06e06064

4 years ago[VFABI] Read/Write functions for the VFABI attribute.
Francesco Petrogalli [Wed, 30 Oct 2019 19:08:21 +0000 (19:08 +0000)]
[VFABI] Read/Write functions for the VFABI attribute.

The attribute is stored at the `FunctionIndex` attribute set, with the
name "vector-function-abi-variant".

The get/set methods of the attribute have assertion to verify that:

1. Each name in the attribute is a valid VFABI mangled name.

2. Each name in the attribute correspond to a function declared in the
   module.

Differential Revision: https://reviews.llvm.org/D69976

4 years agoAdd rpath to liblldb so vendors can ship their own python framework (or others)
António Afonso [Mon, 11 Nov 2019 21:39:30 +0000 (13:39 -0800)]
Add rpath to liblldb so vendors can ship their own python framework (or others)

Summary:
I want to be able to specify which python framework to use for lldb in macos. With python2.7 we could just rely on the MacOS one but python3.7 is not shipped with the OS.
An alternative is to use the one shipped with Xcode but that could be path dependent or maybe the user doesn't have Xcode installed at all.
A definite solution is to just ship a python framework with lldb. To make this possible I added "@loader_path/../../../" to the rpath so it points to the same directory as the LLDB.framework, this way we can just drop any frameworks there.

Reviewers: hhb, sgraenitz, xiaobai, smeenai, beanz, labath

Reviewed By: labath

Subscribers: beanz, labath, mgorny, lldb-commits

Tags: #lldb

Differential Revision: https://reviews.llvm.org/D69931

4 years agoAdd InstCombine/InstructionSimplify support for Freeze Instruction
aqjune [Wed, 6 Nov 2019 16:12:17 +0000 (01:12 +0900)]
Add InstCombine/InstructionSimplify support for Freeze Instruction

Summary:
- Add llvm::SimplifyFreezeInst
- Add InstCombiner::visitFreeze
- Add llvm tests

Reviewers: majnemer, sanjoy, reames, lebedev.ri, spatel

Reviewed By: reames, lebedev.ri

Subscribers: reames, lebedev.ri, filcab, regehr, trentxintong, llvm-commits

Differential Revision: https://reviews.llvm.org/D29013

4 years ago[NFC] Fix test case after edab7dd426249bd40059b49b255ba9cc5b784753
Nemanja Ivanovic [Tue, 12 Nov 2019 02:37:09 +0000 (20:37 -0600)]
[NFC] Fix test case after edab7dd426249bd40059b49b255ba9cc5b784753

The author of the patch forgot to add -verify-machineinstrs to the RUN
lines which would have made the issue appear on all bots. Added that
as well as a fix for the undefined register issue (after the hoisting).

4 years ago[X86] Remove setOperationAction lines that say to promote MVT::i1
Craig Topper [Tue, 12 Nov 2019 02:16:14 +0000 (18:16 -0800)]
[X86] Remove setOperationAction lines that say to promote MVT::i1

MVT::i1 should be removed by type legalization before we reach
any code that would act on the promote action.

Mainly to avoid replicating this for strict FP versions of these
operations.

4 years ago[IR] Resolve an error at freeze's unit tests
Juneyoung Lee [Tue, 12 Nov 2019 02:23:19 +0000 (11:23 +0900)]
[IR] Resolve an error at freeze's unit tests

4 years ago[MC] Make MCFragment trivially destructible
Fangrui Song [Tue, 12 Nov 2019 02:11:15 +0000 (18:11 -0800)]
[MC] Make MCFragment trivially destructible

4 years ago[IR] Redefine Freeze instruction
aqjune [Wed, 6 Nov 2019 16:17:49 +0000 (01:17 +0900)]
[IR] Redefine Freeze instruction

Summary:
This patch redefines freeze instruction from being UnaryOperator to a subclass of UnaryInstruction.

ConstantExpr freeze is removed, as discussed in the previous review.
FreezeOperator is not added because there's no ConstantExpr freeze.
`freeze i8* null` test is added to `test/Bindings/llvm-c/freeze.ll` as well, because the null pointer-related bug in `tools/llvm-c/echo.cpp` is now fixed.
InstVisitor has visitFreeze now because freeze is not unaryop anymore.

Reviewers: whitequark, deadalnix, craig.topper, jdoerfert, lebedev.ri

Reviewed By: craig.topper, lebedev.ri

Subscribers: regehr, nlopes, mehdi_amini, hiraditya, steven_wu, dexonsmith, jfb, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D69932

4 years agoclang/Modules: Clean up modules on error in ReadAST
Duncan P. N. Exon Smith [Sun, 10 Nov 2019 18:42:29 +0000 (10:42 -0800)]
clang/Modules: Clean up modules on error in ReadAST

ReadASTBlock and ReadASTExtensions can both return failures.  Be
consistent and remove all the just-loaded modules, just like when
ReadASTCore returns failures.

https://reviews.llvm.org/D70055

4 years ago[X86] Remove some else branches after checking for !useSoftFloat() that set operation...
Craig Topper [Tue, 12 Nov 2019 00:30:42 +0000 (16:30 -0800)]
[X86] Remove some else branches after checking for !useSoftFloat() that set operations to Expand.

If we're using soft floats, then these operations shoudl be
softened during type legalization. They'll never get to
LegalizeVectorOps or LegalizeDAG so they don't need to be
Expanded there.

4 years agoclang/Modules: Add missing diagnostics for malformed AST files
Duncan P. N. Exon Smith [Sun, 10 Nov 2019 19:07:20 +0000 (11:07 -0800)]
clang/Modules: Add missing diagnostics for malformed AST files

These were found via an audit.  In the case of `ParseLineTable` this is
actually dead code, since parsing the line table always succeeds, but
it's prudent to be defensive since it's possible an assertion there
could be converted to a `true` return in the future.

4 years ago[lldb] Re-enable VSCode tests
Jonas Devlieghere [Mon, 11 Nov 2019 23:58:27 +0000 (15:58 -0800)]
[lldb] Re-enable VSCode tests

The VSCode tests were all disabled on macOS because the implementation
had some issues that resulted in flakiness on Darwin. It seems most of
these issues have been addressed. I've re-enabled all the tests that
consistently passed locally.

4 years ago[X86] Add avx512 command lines to vector-constrained-fp-intrinsics.ll. NFC
Craig Topper [Mon, 11 Nov 2019 23:51:00 +0000 (15:51 -0800)]
[X86] Add avx512 command lines to vector-constrained-fp-intrinsics.ll. NFC

4 years ago[X86] Autogenerate checks in fp-intrinsics.ll. Split fma tests off to fp-intrinsics...
Craig Topper [Mon, 11 Nov 2019 23:42:25 +0000 (15:42 -0800)]
[X86] Autogenerate checks in fp-intrinsics.ll. Split fma tests off to fp-intrinsics-fma.ll. NFC

4 years agoclang/Modules: Split loop in ReadAST between failable and not
Duncan P. N. Exon Smith [Sun, 10 Nov 2019 18:50:12 +0000 (10:50 -0800)]
clang/Modules: Split loop in ReadAST between failable and not

Split a loop in ReadAST that visits the just-loaded module chain,
between an initial loop that reads further from the ASTs (and can fail)
and a second loop that does some preloading (and cannot fail).  This
makes it less likely for a reading failure to affect the AST.

This is not fixing a known bug and the behaviour change may not be
observable, it's just part of an audit to look at all of the error
handling in the ASTReader.

https://reviews.llvm.org/D70056

4 years agoclang/Modules: Use range-based for in ASTReader::ReadAST, NFC
Duncan P. N. Exon Smith [Mon, 11 Nov 2019 23:42:25 +0000 (15:42 -0800)]
clang/Modules: Use range-based for in ASTReader::ReadAST, NFC

4 years ago[PowerPC][XCOFF] Add support for zero initialized global values.
Sean Fertile [Mon, 28 Oct 2019 20:07:10 +0000 (16:07 -0400)]
[PowerPC][XCOFF] Add support for zero initialized global values.

For XCOFF, globals mapped into the .bss section are linked as COMMON
definitions. This behaviour is incorrect for zero initialized data, so
emit those to the .data section instead.

Differential Revision: https://reviews.llvm.org/D69528

4 years agoFixing PowerPC llc test cases for Disable hoisting MI to hotter basic blocks by addin...
Victor Huang [Mon, 11 Nov 2019 23:47:47 +0000 (23:47 +0000)]
Fixing PowerPC llc test cases for Disable hoisting MI to hotter basic blocks by adding powerpc triple

4 years agoclang/Modules: Delay err_module_file_conflict if a diagnostic is in flight
Duncan P. N. Exon Smith [Sun, 10 Nov 2019 19:17:42 +0000 (11:17 -0800)]
clang/Modules: Delay err_module_file_conflict if a diagnostic is in flight

As part of an audit of whether all errors are being reported from the
ASTReader, delay err_module_file_conflict if a diagnostic is already in
flight when it is hit.  This required plumbing an extra argument through
the delayed diagnostic mechanics in DiagnosticsEngine.

4 years ago[Reproducer] Quit the debugger after generating a reproducer
Jonas Devlieghere [Mon, 11 Nov 2019 22:16:52 +0000 (14:16 -0800)]
[Reproducer] Quit the debugger after generating a reproducer

Currently nothing prevents you from continuing your debug session after
generating the reproducer. This can cause the reproducer to end up in an
inconsistent state. Most of the time this doesn't matter, but I want to
prevent this from causing bugs in the future.

4 years agoDisable hoisting MI to hotter basic blocks
Victor Huang [Mon, 11 Nov 2019 21:32:56 +0000 (21:32 +0000)]
Disable hoisting MI to hotter basic blocks

In current Hoist() function of machine licm pass, it will not check the source and destination basic block frequencies that a instruction is hoisted from/to.
There is a chance that instruction is hoisted from a cold to a hot basic block.

In this patch, we add options to disable machine instruction hoisting if destination block is hotter.

Differential Revision: https://reviews.llvm.org/D63676

4 years ago[AArch64] Update for Exynos
Evandro Menezes [Mon, 11 Nov 2019 20:27:14 +0000 (14:27 -0600)]
[AArch64] Update for Exynos

Fix the costs of FP register moves.

4 years ago[AArch64] Add new scheduling predicates
Evandro Menezes [Mon, 11 Nov 2019 20:24:24 +0000 (14:24 -0600)]
[AArch64] Add new scheduling predicates

Add new scheduling predicates to identify more ASIMD forms.

4 years agoclang-format: fix a typo introduced by the previous change
Sylvestre Ledru [Mon, 11 Nov 2019 20:52:08 +0000 (21:52 +0100)]
clang-format: fix a typo introduced by the previous change

4 years agoReplace tabs with spaces. (NFC)
Adrian Prantl [Mon, 11 Nov 2019 20:22:55 +0000 (12:22 -0800)]
Replace tabs with spaces. (NFC)

4 years agoFix a regression in macOS-style path remapping.
Adrian Prantl [Sat, 9 Nov 2019 01:35:52 +0000 (17:35 -0800)]
Fix a regression in macOS-style path remapping.

When we switched to the LLVM .debug_line parser, the .dSYM-style path
remapping logic stopped working for relative paths because of how
RemapSourceFile silently fails for relative paths. This patch both
makes the code more readable and fixes this particular bug.

One interesting thing I learned is that Module::RemapSourceFile() is a
macOS-only code path that operates on on the lldb::Module level and is
completely separate from target.source-map, which operates on a
per-Target level.

Differential Revision: https://reviews.llvm.org/D70037

rdar://problem/56924558

4 years agoAdd a testcase for .dSYM path remapping dictionaries.
Adrian Prantl [Fri, 8 Nov 2019 22:05:45 +0000 (14:05 -0800)]
Add a testcase for .dSYM path remapping dictionaries.

rdar://problem/56924558

4 years ago[ModuloSchedule] Fix modulo expansion for data loop carried dependencies.
Thomas Raoux [Mon, 11 Nov 2019 19:25:19 +0000 (11:25 -0800)]
[ModuloSchedule] Fix modulo expansion for data loop carried dependencies.

The new experimental expansion has a problem when a value has a data
dependency with an instruction from a previous stage. This is due to
the way we peel out the kernel. To fix that I'm changing the way we
peel out the kernel. We now peel the kernel NumberStage - 1 times.
The code would be correct at this point if we didn't have to handle
cases where the loop iteration is smaller than the number of stages.
To handle this case we move instructions between different epilogues
based on their stage and remap the PHI instructions correctly.

Differential Revision: https://reviews.llvm.org/D69538

4 years ago[OPENMP50]Generalize handling of context matching/scoring.
Alexey Bataev [Thu, 7 Nov 2019 16:03:10 +0000 (11:03 -0500)]
[OPENMP50]Generalize handling of context matching/scoring.

Summary:
Untie context matching/scoring from the attribute for declare variant
directive to simplify future uses in other context-dependent directives.

Reviewers: jdoerfert

Subscribers: guansong, kkwli0, caomhin, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D69952

4 years ago[OPENMP50]Add support for nested atomic and simd constructs in
Alexey Bataev [Mon, 11 Nov 2019 18:44:42 +0000 (13:44 -0500)]
[OPENMP50]Add support for nested atomic and simd constructs in
simd-based directives.

According to OpenMP 5.0 standard, ordered simd, atomic and simd
directives are allowed as nested directives in the simd-based
directives.

4 years agoAdd missing override modifiers for FileCheckExpressionAST::eval() overrides.
Simon Pilgrim [Mon, 11 Nov 2019 18:51:14 +0000 (18:51 +0000)]
Add missing override modifiers for FileCheckExpressionAST::eval() overrides.

4 years agoMake FileCheckNumericVariable::getDefLineNumber const. NFC
Simon Pilgrim [Mon, 11 Nov 2019 18:44:13 +0000 (18:44 +0000)]
Make FileCheckNumericVariable::getDefLineNumber const. NFC

Fixes cppcheck warning.

4 years ago[debuginfo] Update test to account for missing __debug_macinfo
Jonas Devlieghere [Mon, 11 Nov 2019 18:40:06 +0000 (10:40 -0800)]
[debuginfo] Update test to account for missing __debug_macinfo

We no longer emit this section if it's empty.