Vincent Torri [Wed, 15 May 2019 11:27:37 +0000 (12:27 +0100)]
Evil: move the inclusion of all headers in evil_private.h
Summary: first step for making Evil private. evil_private.h will be included in the EFL source code instead of Evil.h
Test Plan: compilation
Reviewers: raster, cedric, zmike
Reviewed By: raster
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8893
WooHyun Jung [Wed, 15 May 2019 06:14:15 +0000 (15:14 +0900)]
Makefile_Cxx: add include dependency with evas/gesture
Summary:
There was a build break when "make check". This patch will
fix the issue.
Test Plan:
- ./autogen.sh --with-tests=regular --enable-csharp-bindings
- make
- sudo make install
- sudo make check
Reviewers: Jaehyun_Cho, CHAN, zmike, segfaultxavi
Reviewed By: Jaehyun_Cho
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8896
JunsuChoi [Wed, 15 May 2019 02:22:45 +0000 (11:22 +0900)]
ector_software_rasterizer: Improved masking calculation.
Summary:
The memory allocation for the buffer size is improved to
allocate only the width size.
Test Plan: N/A
Reviewers: Hermet, kimcinoo
Reviewed By: Hermet
Subscribers: cedric, #reviewers, smohanty, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8873
Marcel Hollerbach [Tue, 14 May 2019 19:51:12 +0000 (15:51 -0400)]
efl_ui: remove Efl.Ui.Clickable from containers
Summary:
these widgets here are containers, means: they contain items that can be
clicked, but the container itself cannot be clicked. Later on, we should
introduce a new interface which contains events that reflect the clicked
event of theire items.
Depends on D8827
Reviewers: zmike, segfaultxavi, cedric
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8828
Marcel Hollerbach [Tue, 14 May 2019 19:51:06 +0000 (15:51 -0400)]
efl_ui_tab_bar: remove Efl.Ui.Clickable
Summary:
nothing here uses this directly, and nothing emits events. For now the
implementation is removed. If this is required later on, it can be
readded.
Depends on D8826
Reviewers: zmike, segfaultxavi, cedric
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8827
Marcel Hollerbach [Tue, 14 May 2019 19:50:53 +0000 (15:50 -0400)]
efl_ui_panes: migrate to efl_ui_clickable
Summary:
the implementation of efl_ui_clickable is now used to tricker the
events. efl,action,click and efl,action,click,double is not needed
anymore from the theme.
Depends on D8824
Reviewers: zmike, segfaultxavi, cedric
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8825
Marcel Hollerbach [Tue, 14 May 2019 19:50:47 +0000 (15:50 -0400)]
efl_ui_text: migrate to efl_ui_clickable
Summary:
This now uses the efl_ui_clickable mixin. It is impossible right now to
test this in the test suite, as every single configuration of the
efl.ui.text object is ending up in an error. Which is not allowed in the
test suite. Additionally, simulating clicks on the objects gets it into
some sort of inifinite recursion when asking for cursor positions.
Depends on D8823
Reviewers: zmike, segfaultxavi, cedric
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8824
Marcel Hollerbach [Tue, 14 May 2019 19:50:39 +0000 (15:50 -0400)]
efl_ui_image: migrate to efl.ui.clickable
Summary:
the mixin is now used to emit the events of the mixins. This is verified
by the testsuite. The testsuite needs a special treatment for the
object, because a missing image-file of the object would result in a 0x0
image size.
Depends on D8822
Reviewers: zmike, segfaultxavi, cedric
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8823
Marcel Hollerbach [Tue, 14 May 2019 19:50:32 +0000 (15:50 -0400)]
efl_test_clickable: introduce new tests
Summary:
the new test checks if the events are correctly emitted
Depends on D8821
Reviewers: zmike, segfaultxavi, cedric
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8822
Marcel Hollerbach [Tue, 14 May 2019 19:50:25 +0000 (15:50 -0400)]
efl_ui_button: port to efl.ui.clickable
Summary: Depends on D8820
Reviewers: zmike, segfaultxavi, cedric
Reviewed By: segfaultxavi
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8821
Marcel Hollerbach [Tue, 14 May 2019 19:50:15 +0000 (15:50 -0400)]
efl_ui: move clickable from efl to efl_ui
Summary:
efl_ui_clickable is now a mixin. The mixin now brings two APIs the press
and unpress API can be used to tell the implementation the state of the
presses. Within the implementation the calls to press / unpress are then
converted to longpress / clicked events.
Reviewers: zmike, segfaultxavi, cedric
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8820
Xavi Artigas [Tue, 14 May 2019 06:51:05 +0000 (08:51 +0200)]
efl-mono: Use Efl.Ui.Win API instead of Elm.Policy
Summary:
This removes another bit of legacy API from the C# bindings.
This also reverts "elm: Put back Policy and Policy_Quit in EO files"
(
a9132a9a66955608e913bb1228e4adb371310b09) so that these two Elm enums are
definitely out of the EO files.
Test Plan:
Everything, including mono bindings, continue to build.
At runtime, C# apps still exit when all windows are closed.
Reviewers: lauromoura, vitor.sousa, q66
Reviewed By: q66
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8890
Woochanlee [Tue, 14 May 2019 07:37:20 +0000 (16:37 +0900)]
Gesture Manager: Add gestures and fix gesture managing, recognizer logic.
Summary:
https://phab.enlightenment.org/T7544
Provides a way for a user to get a gesture manager, recognizer instance.
Supports different recognizer properties for each target(Eo).
Gesture, Touch Class Life-cycle re-implementation. for supporting multiple touches.
Add below gestures.
efl_canvas_gesture_tap
efl_canvas_gesture_double_tap
efl_canvas_gesture_triple_tap
efl_canvas_gesture_long_tap
efl_canvas_gesture_momentum
efl_canvas_gesture_zoom
efl_canvas_gesture_flick
Test Plan:
Simple test -> test_gesture_framework.c
More test cases will upload.
Reviewers: woohyun, smohanty, segfaultxavi, Jaehyun_Cho
Reviewed By: Jaehyun_Cho
Subscribers: Jaehyun_Cho, segfaultxavi, cedric
Tags: #efl, #do_not_merge
Differential Revision: https://phab.enlightenment.org/D7579
Lauro Moura [Tue, 14 May 2019 06:38:50 +0000 (08:38 +0200)]
csharp: Fix event marshalling for value types
Summary:
It was wrongly assuming value types were passed by value.
As stated in the documentation, all arguments are passed with a single
level of indirection.
Fixes T7957
Reviewers: woohyun, felipealmeida, vitor.sousa, segfaultxavi
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7957
Differential Revision: https://phab.enlightenment.org/D8889
Marcel Hollerbach [Mon, 13 May 2019 19:14:20 +0000 (15:14 -0400)]
elc_fileselector: make a few events again legacy
Summary:
the events changed here should not be used. They should use legacy
events.
Depends on D8816
Reviewers: zmike, segfaultxavi, cedric
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8819
Marcel Hollerbach [Mon, 13 May 2019 19:14:13 +0000 (15:14 -0400)]
elementary: do not emit new events in legacy
Summary:
This commits prepares the tree in order to mess with the events in the
Efl.Ui.Clickable event. Events which have been emitted in a none legacy
widget, are now emitted either with evas, when the widget is legacy due
to inheritance. Or via the normal event and normal event functions.
In case the widget is a legacy only widget (not used at all in the new
api), then the events are for now emitted with
evas_object_smart_callback_call.
Cases where event handlers have been added to legacy widgets, smart
events are now used, and not the eo one anymore.
ref T7844
Depends on D8813
Reviewers: cedric, zmike, segfaultxavi
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7844
Differential Revision: https://phab.enlightenment.org/D8816
Marcel Hollerbach [Mon, 13 May 2019 19:14:03 +0000 (15:14 -0400)]
efl_ui_clickable: move repeat event
Summary:
the repeat event is only emitted by the implementations of
efl_ui_autorepeat. Additionally, the event should only be used by those
who implement this interface.
Depends on D8832
Reviewers: zmike, segfaultxavi, cedric
Reviewed By: zmike, segfaultxavi
Subscribers: jpeg, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8813
Marcel Hollerbach [Mon, 13 May 2019 19:13:54 +0000 (15:13 -0400)]
elm_panel: do not use the unfocusable state here
Summary:
the widget itself is a focus_layer which means, the tree is orphaned and
cannot be accessed until the panel is visible. There is not need for us
to manually track this state.
fix T7908
Depends on D8831
Reviewers: marcellus, zmike, segfaultxavi, cedric
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7908
Differential Revision: https://phab.enlightenment.org/D8832
Marcel Hollerbach [Mon, 13 May 2019 19:13:46 +0000 (15:13 -0400)]
meson: we are not in release mode anymore
Test Plan:
Run the build, enable debug messages, and you will see that DBG messages start to appear again on your screen.
As an example ´EINA_LOG_LEVELS="elementary_focus:10" ./src/bin/elementary_test´
Reviewers: zmike, segfaultxavi, cedric
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8831
Mike Blumenkrantz [Mon, 13 May 2019 15:45:13 +0000 (11:45 -0400)]
evas/image: fix broken auto_fill mechanism when manually changing fill
Summary:
if auto_fill is set (which is the default for image objects), manually setting
the fill for the image would previously only persist until the image was resized,
at which point the auto_fill would activate and re-set the image's fill to be
the same as the image's object geometry
this fixes the auto_fill behavior to stop modifying the image's fill geometry
if the fill is manually changed by the user, which fixes using fill on most
image objects
@fix
Reviewers: cedric, Hermet
Reviewed By: cedric
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8879
Mike Blumenkrantz [Mon, 13 May 2019 15:44:27 +0000 (11:44 -0400)]
evas/scale_sample: call alloca for the scanline buffer after clamping width
Summary:
this is already a risky call for larger scanlines, so use the clamped value
to further reduce the chance of blowing out the stack
Depends on D8839
Reviewers: cedric, segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, #reviewers, #committers
Tags: #efl_rendering
Differential Revision: https://phab.enlightenment.org/D8840
Mike Blumenkrantz [Mon, 13 May 2019 15:44:18 +0000 (11:44 -0400)]
evas/scale_sample: fix mask geometry clamping in scale thread
Summary:
the 'y' parameter is not relevant here. this clamping exists solely
to avoid reading outside the bounds of the mask, and 'y' is the scanline
at which to begin the masking
subtracting the mask size here does not make sense: we are attempting to clamp
to the size of the mask in order to avoid buffer over-read, so this means that
we are mapping the maximum y coordinate of the mask (mask_y + mask_h) to be
relative to the clipped y coordinate (dst_clip_y)
Depends on D8838
Reviewers: cedric, segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, #reviewers, #committers
Tags: #efl_rendering
Differential Revision: https://phab.enlightenment.org/D8839
Mike Blumenkrantz [Mon, 13 May 2019 15:44:11 +0000 (11:44 -0400)]
evas/scale_sample: slightly refactor some mask geometry clamping
Summary:
this was a bit confusing to read since the comparators are not ordered
as expected
no functional changes
Depends on D8837
Reviewers: cedric, segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, #reviewers, #committers
Tags: #efl_rendering
Differential Revision: https://phab.enlightenment.org/D8838
Mike Blumenkrantz [Mon, 13 May 2019 15:44:02 +0000 (11:44 -0400)]
evas_render: deduplicate mapped mask render code
Summary:
this code block was repeated multiple times throughout the function
no functional changes
Reviewers: cedric, kimcinoo
Reviewed By: kimcinoo
Subscribers: kimcinoo, #reviewers, #committers
Tags: #efl_rendering
Differential Revision: https://phab.enlightenment.org/D8837
Carsten Haitzler (Rasterman) [Mon, 13 May 2019 13:40:08 +0000 (14:40 +0100)]
edje src - mark with efl version so we don't get warnings
Carsten Haitzler (Rasterman) [Mon, 13 May 2019 13:21:04 +0000 (14:21 +0100)]
ecore drm2 - fix warnigns in DBG eina logs for long types
on 32bit longs are 32bit so cast appropriately to not have warnings.
Carsten Haitzler (Rasterman) [Mon, 13 May 2019 13:12:28 +0000 (14:12 +0100)]
eina - value - test - cats warnings on 32bit to get some silence
longs will be truncated on 32bit in these tests so be explicit to not
have warinings.
note - eina value tests are broken on 32bit anyway already - the
conversions to/from long types are broken and fail. this doesn't fix
that.
Xavi Artigas [Mon, 13 May 2019 09:27:40 +0000 (11:27 +0200)]
elm: Put back Policy and Policy_Quit in EO files
In
e027ad2626 these enums were moved to header files, which is correct,
since they are legacy and should not be present in EO files.
However, the C# bindings are still using them.
Until nobody is using these two enums, adding them back to EO fixes the build.
Jaehyun Cho [Fri, 10 May 2019 10:36:17 +0000 (19:36 +0900)]
efl_mono: generate efl_canvas_vg_object.eo.cs by meson
This commit is the same as
0e8f289d7dfb4c5877559917a57a3ac08545fb86
but this commit is for meson.
To use vector graphics in efl csharp bindings, it is permitted to
generate efl_canvas_vg_object.eo.cs.
Other efl_canvas_vg .eo.cs files have already been generated because the
file names were changed from efl_vg to efl_canvas_vg.
Jaehyun Cho [Fri, 10 May 2019 10:29:34 +0000 (19:29 +0900)]
efl_mono: move libeflcustomexportsmono.so to lib with versions by meson
meson generates libeflcustomexportsmono.so to lib/efl-mono-1/ directory
unlike other so files.
Moreover, the so file does not have versions in the file name unlike
other so files.
Like other so files, libeflcustomexportsmono.so is moved to lib
directory with versions in the file name.
Shinwoo Kim [Mon, 13 May 2019 04:09:24 +0000 (13:09 +0900)]
Efl.Ui.Textpath: enhance to support legacy API
Summary:
The legacy API is available after https://phab.enlightenment.org/D7033 but
internal function does not care of it. This change makes textpath work with
the legacy style file(./data/elementary/themes/edc/elm/textpath.edc).
Reviewers: Hermet, jsuya
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8875
Marcel Hollerbach [Mon, 29 Apr 2019 09:11:10 +0000 (11:11 +0200)]
efl_canvas_animation: reply on the correct API
the animation itself does not implement the player interface, and
nothing forces it to do so. Additionally, we should ask the reference
object for the current progress. Not the animation object.
This fixes pos_set / pos_get.
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D8783
Vincent Torri [Wed, 8 May 2019 20:28:05 +0000 (20:28 +0000)]
eina vpath: fix warning on Windows, as well as the public path
Differential Revision: https://phab.enlightenment.org/D8866
Cedric BAIL [Fri, 10 May 2019 21:42:57 +0000 (14:42 -0700)]
eina: add tests for the new Vpath syntax.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8884
Cedric BAIL [Fri, 10 May 2019 21:37:24 +0000 (14:37 -0700)]
eina: update vpath to also support a more classic syntax for variable.
This enable vpath to recognize also ${} as a variable. It does mimic
what Efl.ViewModel provide with Efl.ViewModel.PropertyText and various
other language.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8883
Cedric BAIL [Fri, 10 May 2019 21:28:49 +0000 (14:28 -0700)]
eina: refactor and simplify vpath.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8882
Cedric BAIL [Sat, 11 May 2019 00:58:33 +0000 (17:58 -0700)]
ecore: forgotten autotools update.
Romain Naour [Tue, 16 Apr 2019 19:33:44 +0000 (21:33 +0200)]
libunibreak: add missing __has_attribute definitions for old compilers
__has_attribute has been introduced with gcc 5 [1].
[1] https://www.gnu.org/software/gcc/gcc-5/changes.html
Fixes:
http://autobuild.buildroot.net/results/
64ab825048fac1654b0d0698740ddf857fcc0afa/build-end.log
Signed-off-by: Cedric BAIL <cedric.bail@free.fr>
Cedric BAIL [Thu, 25 Apr 2019 22:51:19 +0000 (15:51 -0700)]
elementary: move Fileselector to rely on Efl.FilterModel for filtering instead of custom logic.
This simply a bit the logic of things, but more refactoring would be nice for this widget.
Reviewed-by: SangHyeon Jade Lee <sh10233.lee@samsung.com>
Differential Revision: https://phab.enlightenment.org/D8799
Cedric BAIL [Thu, 18 Apr 2019 17:53:07 +0000 (10:53 -0700)]
ecore: add a test for the new Efl.FilterModel.
Reviewed-by: SangHyeon Jade Lee <sh10233.lee@samsung.com>
Differential Revision: https://phab.enlightenment.org/D8798
Cedric BAIL [Thu, 4 Apr 2019 00:25:06 +0000 (17:25 -0700)]
ecore: add Efl.Filter_Model
This model provide facility to filter the content of composited model.
Reviewed-by: SangHyeon Jade Lee <sh10233.lee@samsung.com>
Differential Revision: https://phab.enlightenment.org/D8797
Vincent Torri [Fri, 10 May 2019 14:01:59 +0000 (10:01 -0400)]
elementary genlist: fix potential uninitialized variable.
Test Plan: compilation
Reviewers: raster, zmike
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8874
Vincent Torri [Thu, 9 May 2019 18:09:08 +0000 (14:09 -0400)]
Ecore_Exe: fix warning on Windows
Summary: ExitProcess() has not the signature expected by CreateRemoteThread()
Test Plan: compilation
Reviewers: raster, zmike, cedric
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8870
Cedric BAIL [Fri, 29 Mar 2019 00:09:14 +0000 (17:09 -0700)]
ecore: make sure that ecore stay initialized during the full test.
efl_app_test_promise.c is slightly special and corrective action have to be
taken to make sure that ecore_init return the right value when the no fork
mode of libcheck is used.
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8566
Cedric BAIL [Thu, 25 Apr 2019 22:46:59 +0000 (15:46 -0700)]
ecore: refactor Efl.CompositeModel to provide child allocation to other internal Model.
Reviewed-by: SangHyeon Jade Lee <sh10233.lee@samsung.com>
Differential Revision: https://phab.enlightenment.org/D8796
Cedric BAIL [Thu, 25 Apr 2019 22:44:17 +0000 (15:44 -0700)]
ecore: property handle allocation error in Efl.CompositeModel.
Reviewed-by: SangHyeon Jade Lee <sh10233.lee@samsung.com>
Differential Revision: https://phab.enlightenment.org/D8795
Cedric BAIL [Thu, 25 Apr 2019 22:40:31 +0000 (15:40 -0700)]
eina: always initialize all the field of Eina_Value used by Eina_Promise.
Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es>
Differential Revision: https://phab.enlightenment.org/D8794
Cedric BAIL [Thu, 25 Apr 2019 22:38:20 +0000 (15:38 -0700)]
eio: correctly set reference count of cached child object.
Reviewed-by: SangHyeon Jade Lee <sh10233.lee@samsung.com>
Differential Revision: https://phab.enlightenment.org/D8793
Daniel Kolesa [Thu, 9 May 2019 14:16:42 +0000 (16:16 +0200)]
eolian: move from eo_prefix to c_prefix
Daniel Kolesa [Thu, 9 May 2019 13:19:13 +0000 (15:19 +0200)]
edje_types: (re)move legacy types to header
These are not used anywhere in eo files, so no point in keeping
them around in their legacy form.
Daniel Kolesa [Thu, 9 May 2019 12:55:17 +0000 (14:55 +0200)]
elm: (re)move some legacy types/enums back to header
These are legacy-only and not used anywhere in .eo files, so
move them where they belong. They are still used within impls
around the place. The others can't be moved as they are still
used in .eo files in places, that has to be dealt with separately.
Carsten Haitzler (Rasterman) [Thu, 9 May 2019 11:29:17 +0000 (12:29 +0100)]
much better fix to invalid uv coords with new map render code
this fixes the
d81d1337b087fbc23fb7439c269c1f7e34aa5fa2 fix to do it
in the inner loop so uu and vv stay valid. still not a great fix but
better than chashes.
JunsuChoi [Thu, 9 May 2019 10:30:37 +0000 (19:30 +0900)]
ector_software_rasterizer : Move duplicate alloca
Summary: Move the alloca() outside of the loop.
Test Plan: N/A
Reviewers: Hermet, kimcinoo
Reviewed By: Hermet
Subscribers: cedric, #reviewers, smohanty, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8869
Yeongjong Lee [Thu, 9 May 2019 06:42:13 +0000 (15:42 +0900)]
navigation_layout: set efl.content y-axis align to 0.0
Summary:
If `efl.content` min size is greater than edc area size, `efl.bar` and
`efl.content` are overlapped because default y-align is 0.5.
This patch avoid it.
Test Plan:
Sample code:
```
// gcc -o efl_ui_stack_example efl_ui_stack_example.c `pkg-config --cflags --libs elementary`
EAPI_MAIN void
efl_main(void *data EINA_UNUSED, const Efl_Event *ev EINA_UNUSED)
{
Eo *win = efl_add(EFL_UI_WIN_CLASS, efl_main_loop_get());
Eo *stack = efl_add(EFL_UI_STACK_CLASS, win);
efl_content_set(win, stack);
Eo *nl = efl_add(EFL_UI_NAVIGATION_LAYOUT_CLASS, stack,
efl_ui_stack_push(stack, efl_added));
Eo *bn = efl_add(EFL_UI_NAVIGATION_BAR_CLASS, stack);
efl_text_set(bn, "Title Text");
efl_ui_navigation_layout_bar_set(nl, bn);
Eo *btn = efl_add(EFL_UI_BUTTON_CLASS, nl,
efl_text_set(efl_added, "Button 1"),
efl_gfx_hint_size_min_set(efl_added, EINA_SIZE2D(50, 80)),
efl_content_set(nl, efl_added));
efl_gfx_entity_size_set(win, EINA_SIZE2D(100, 80));
}
EFL_MAIN()
```
Reviewers: Jaehyun_Cho
Reviewed By: Jaehyun_Cho
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8868
Marcel Hollerbach [Wed, 8 May 2019 16:27:41 +0000 (12:27 -0400)]
meson: lets execute eldbus test suite
Summary:
this was simply forgotten.
Depends on D8861
Reviewers: segfaultxavi, zmike
Reviewed By: zmike
Subscribers: zmike, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8862
Marcel Hollerbach [Wed, 8 May 2019 16:27:35 +0000 (12:27 -0400)]
Revert "eldbus_test_eldbus_message: Fix resource leak"
Summary:
This reverts commit
24c07f03d1427db2ed9dee7428c83352b60439dd.
This appears to be wrong "eldbus_message_iter_del" does free the message
itself. So this causes a double free and a failing test suite.
Reviewers: segfaultxavi, zmike
Reviewed By: zmike
Subscribers: zmike, devilhorns, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8861
Vincent Torri [Wed, 8 May 2019 16:19:00 +0000 (12:19 -0400)]
Evil: fix warning on 64 bits
Summary: int is 32 bits, HANDLE is void *, so cast to uintptr_t in between
Test Plan: compilation
Reviewers: raster, cedric, zmike
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8865
Mike Blumenkrantz [Wed, 8 May 2019 14:14:48 +0000 (10:14 -0400)]
meson: remove semicolons in windows build
Summary: Depends on D8859
Reviewers: bu5hm4n
Reviewed By: bu5hm4n
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8860
Vincent Torri [Wed, 8 May 2019 14:14:45 +0000 (10:14 -0400)]
Evil: remove localtime_r as mingw-w64 defines it when _POSIX_C_SOURCE is defined
Summary:
localtime_r() is already defined by mingw-w64 when _POSIX_C_SOURCE is defined
edit: also only define _POSIX_C_SOURCE (correctly) on windows
Reviewers: bu5hm4n
Reviewed By: bu5hm4n
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8859
Carsten Haitzler (Rasterman) [Wed, 8 May 2019 13:00:47 +0000 (14:00 +0100)]
Revert "Evil: remove localtime_r as mingw-w64 defines it when _POSIX_C_SOURCE is defined"
This reverts commit
a4c44e5e744dba15dfe512668127906afd4b6dba.
this breaks on osx it seems... :(
Vincent Torri [Wed, 8 May 2019 12:39:36 +0000 (08:39 -0400)]
Evil: remove wrapper around getcwd()
Summary: getcwd() is declared in direct.h
Test Plan: compilation
Reviewers: raster, cedric, zmike
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8858
Vincent Torri [Wed, 8 May 2019 11:39:54 +0000 (12:39 +0100)]
Evil: remove localtime_r as mingw-w64 defines it when _POSIX_C_SOURCE is defined
Summary: localtime_r() is already defined by mingw-w64 when _POSIX_C_SOURCE is defined
Test Plan: compilation
Reviewers: raster, zmike, cedric
Subscribers: #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7907
Differential Revision: https://phab.enlightenment.org/D8854
Yeongjong Lee [Mon, 27 May 2019 04:49:04 +0000 (13:49 +0900)]
elm_atspi_bridge: Fix uninitialized ret value
Change-Id: I1258c1050c0935a6dbdd467dde74dfa98163867b
Jaehyun Cho [Mon, 27 May 2019 10:32:01 +0000 (19:32 +0900)]
efl_ui_stack: fix not to keep final state of push/pop animations
It is just required to show pushed content and hide popped content after
the push/pop animations.
Therefore, it is not required to keep the final state of the push/pop
animations after finishing the push/pop animations.
Change-Id: I4a318a6607a545b51f6bb2a146bcb080acb49461
Jongmin Lee [Tue, 28 May 2019 02:06:05 +0000 (11:06 +0900)]
spec: resolve packaging error for x86_64 and aarch64 with meson
Change-Id: Iae150cb6b66c4c2ad6817b6f687f6efd819076e3
Bowon Ryu [Tue, 21 May 2019 13:30:04 +0000 (09:30 -0400)]
elm_entry: prevents invalid cursor position updates
Summary:
sd->cursor_pos is updated in _entry_cursor_changed_signal_cb.
Generally, there is no problem.
But in some cases, before the _entry_cursor_changed_signal_cb is called
there is a situation in which cursor_pos is updated through _elm_entry_efl_ui_widget_theme_apply.
In this case,
before _entry_cursor_changed_signal_cb is called,
in _elm_entry_efl_ui_widget_theme_apply ()
cursor_pos = sd->cursor_pos; The wrong cursor_pos is set here.
Because it is the value before sd->cursor_pos is updated.
This causes an invalid cursor position when entering a key into the entry.
This patch prevents sd->cursor_pos from being updated with invalid values.
Reviewers: zmike, woohyun
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8923
Change-Id: I89fd0551435c429585529dcb095b18176d9fd0b1
Hermet Park [Wed, 22 May 2019 08:09:41 +0000 (17:09 +0900)]
efl_ui_win: skip request additional window_position_set in atomic move, resize
geometry_set() will trigger ecore_evas_move_resize() that takes care
of new position and size. It doens't need to call ecore_wl2_window_position_set()
by efl_ui_win. And this response flag makes it skip properly.
Change-Id: I60a927f5b31a683e85357d53714af756e2fe57a6
Shinwoo Kim [Wed, 22 May 2019 07:52:37 +0000 (16:52 +0900)]
elementary: remove deprecated API
Following API was deprecated from 2.4.
- elm_ctxpopup_direction_available_get (ACR-319)
- elm_win_profiles_set (ACR-353)
It is time to remove. This patch is related to ACR-1373.
Change-Id: Ida5f59d9d0f6c7bb622c4541e1ee53dd8307c3c2
Hermet Park [Mon, 20 May 2019 11:58:10 +0000 (20:58 +0900)]
efl_ui_win: Add a geometry set interface to support atomic move resize behavior in Tizen.
This interface communicate with wayland server to change geometry of window amotically.
This feature is only valid in Tizen, we don't have any test environment in upstream side.
So right moment, we only submit this as Tizen only until this feature is proved enough.
Change-Id: I74eae78d5d00b98d25a785411dc7d656936899b7
Hermet Park [Mon, 20 May 2019 11:49:26 +0000 (20:49 +0900)]
ecore_evas wayland: Support atomic move resize behavior.
Current move-resize requests wayland server to handle them as the separate requests.
This brings windows look flickering since it does both behavior sequencially.
Remove Tizen only engine serial_get function,
We can handle this in ecore_evas_move_resize() instead.
and Call the tizen specific wayland function to guarantee the atmoic move resize behavior.
Change-Id: I2a8cf2298b7548fefc7c00744391e36fbcd8ab92
YoungGun Chun [Fri, 17 May 2019 06:18:41 +0000 (15:18 +0900)]
Add missing call to _is_operation_permitted in _accessible_gesture_do atspi call
Change-Id: Ic7755741c384599ba4623a286a1a99f2203385cd
Hosang Kim [Fri, 17 May 2019 08:11:12 +0000 (17:11 +0900)]
ecore_evas_extn: add closing socket when ipc server is not created.
@fix @tizen_only
Change-Id: I5e00ba1622b919b1a292035d35ad00d68c7609d7
Hermet Park [Fri, 10 May 2019 11:40:14 +0000 (20:40 +0900)]
evas image: Support android 9 patch feature.
Change-Id: Ie80783b234ea5b6173965c975df007a3e301a2e7
Sungtaek Hong [Thu, 30 Jun 2016 11:52:26 +0000 (20:52 +0900)]
implement style_set API for index item
Change-Id: Idbdfecdcbf866b56366cb47308246dc02d6905a0
Signed-off-by: Sungtaek Hong <sth253.hong@samsung.com>
JunsuChoi [Fri, 17 May 2019 01:38:32 +0000 (10:38 +0900)]
evas_vg_node: Move change flag value setting
Summary:
_node_change function is only executed
when the flag is none to prevent duplicate calls.
If CHANGE_MATRIX_FLAG is added to the flag in advance,
_node_change function does not operate normally.
Test Plan:
cd ./src/examples/evas
gcc -o evas_vg_simple evas-vg-simple.c `pkg-config --libs --cflags evas ecore ecore-evas eina ector eo efl` -lm
./evas_vg_simple
Reviewers: Hermet, kimcinoo, smohanty
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8895
Change-Id: I84a5c78026158522ae7347ed701b9662c6df4517
Jaehyun Cho [Wed, 15 May 2019 12:53:02 +0000 (21:53 +0900)]
efl_canvas_text: fix to set halign correctly
Previously, halign_auto was AUTO_NORMAL when halign was set so the given
halign value could not be applied correctly.
Now, halign_auto is modified to AUTO_NONE before halign is set so the
given halign value is applied correctly.
Change-Id: I853b9900529b8fcc06430659382c1f5565a67e6c
Jaehyun Cho [Wed, 15 May 2019 10:14:38 +0000 (19:14 +0900)]
efl_ui_popup: add efl.background swallow part
To make background part cover popup's bg image, efl.background swallow
part is added.
Change-Id: I9f236ffba02b54a96d1da49ef868da4ea36f2bf9
Jaehyun Cho [Wed, 15 May 2019 08:23:32 +0000 (17:23 +0900)]
efl_ui: fix to use Efl.Ui.Widget's "background" and "shadow" part class
To use Efl.Ui.Widget's "background" and "shadow" part class, each widget
inheriting from Efl.Ui.Widget should not use their Part class for
"background" and "shadow" parts.
Change-Id: Ia0fdb08e3c2bed42343572d11a3f2a278e27eeea
JunsuChoi [Wed, 15 May 2019 02:22:45 +0000 (11:22 +0900)]
ector_software_rasterizer: Improved masking calculation.
Summary:
The memory allocation for the buffer size is improved to
allocate only the width size.
Test Plan: N/A
Reviewers: Hermet, kimcinoo
Reviewed By: Hermet
Subscribers: cedric, #reviewers, smohanty, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8873
Change-Id: I02b2c32fdd46ade765ba3a6222f632d70c621dd8
JunsuChoi [Thu, 9 May 2019 10:30:37 +0000 (19:30 +0900)]
ector_software_rasterizer : Move duplicate alloca
Summary: Move the alloca() outside of the loop.
Test Plan: N/A
Reviewers: Hermet, kimcinoo
Reviewed By: Hermet
Subscribers: cedric, #reviewers, smohanty, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8869
Change-Id: I3eaf6130eeda2f304ab86c3a5657d50ff80d4f5b
Junseok, Kim [Mon, 13 May 2019 08:38:04 +0000 (17:38 +0900)]
ecore_wl2_display: Add some null checks.
Change-Id: I82ca08b465852ad7aff74ccc53ed82882e3643af
Hermet Park [Mon, 13 May 2019 06:45:50 +0000 (15:45 +0900)]
evas png: apply interpolation when scale down image loading.
Summary:
This patch improves png quality when image uses scale-down at image loading.
Since current scale-down logic just works like point sampling,
image result could be wholely different,
Simply, if source data is consist of continous white and black pixels,
and scale down factor is 2, the sampled data would be only white,
and lose all black pixels, or vice versa.
The result can be unexpected by users.
Even current jpeg scale-down works with interpolation.
Before:
{
F3711651}
After:
{
F3711652}
Original:
{
F3711653}
Reviewers: cedric, raster, #committers, kimcinoo, jsuya
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8788
Change-Id: I904ace4bfe944e76beb4818af43f6bc63077c163
Myoungwoon Roy, Kim [Mon, 13 May 2019 01:35:23 +0000 (10:35 +0900)]
elm doc: fix wrong ingroup name of textpath.
This patch fixes the wrong ingroup name of textpath for API reference documentation.
Change-Id: I1a23ad77afe59e9464aca290b2a9f28c6d9b24c2
Jaehyun Cho [Thu, 9 May 2019 06:59:54 +0000 (15:59 +0900)]
efl_mono: generate efl_canvas_vg_object.eo.cs
To use vector graphics in efl csharp bindings, it is permitted to
generate efl_canvas_vg_object.eo.cs.
Other efl_canvas_vg .eo.cs files have already been generated because the
file names were changed from efl_vg to efl_canvas_vg.
Change-Id: Idc8f4a7dfde7c89ba963d93d0ddd1cc7ea3463e9
Jaehyun Cho [Fri, 3 May 2019 07:41:06 +0000 (16:41 +0900)]
packaging: install libeflcustomexportsmono.so by efl-devel rpm
Like other .so files, libeflcustomexportsmono.so is supposed to be
installed by devel rpm (efl-devel rpm).
Change-Id: I9060c9f95a8dbe34c30381935f55a87131a8ca7b
Hermet Park [Thu, 9 May 2019 04:08:09 +0000 (13:08 +0900)]
ecore wayland: enable engine alpha channel in default.
This might bring less performwance at full region rendering,
but there are some compatibility issues,
Non-background ui apps, overlay video apps has been already...
Change-Id: Iebf5cdbb5cb7416d942f6e3a9de65f0fc9a68308
JunsuChoi [Wed, 8 May 2019 07:57:19 +0000 (16:57 +0900)]
ector_software_rasterizer: Support gradient mask blending
Summary: This patch supports mask blending of gradient shapes.
Test Plan: N/A
Reviewers: Hermet, kimcinoo
Reviewed By: Hermet
Subscribers: cedric, #reviewers, smohanty, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8855
Change-Id: I536b6f325734f4606ba5b736c750491dcf8cb61e
Lauro Moura [Tue, 7 May 2019 11:44:23 +0000 (13:44 +0200)]
csharp: Add Part suffix for the part wrappers
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8835
Vincent Torri [Tue, 7 May 2019 10:07:19 +0000 (11:07 +0100)]
eina_file: speed up listing of directories on Windows
Summary:
forbid the creation of short name (legacy of DOS)
Without optimisation
1. using only Win32 API, just iterating over directories (in micro seconds) :
10 files : 47
1000 files : 270
100000 files : 73227
2. using eina_file_dir_list() with a callback which does nothing :
10 files : 53
1000 files : 265
100000 files : 69624
usually there is a small overhead for eina API, which is normal
With optimisation
1. using only Win32 API, just iterating over directories (in micro seconds) :
10 files : 51
1000 files : 256
100000 files : 33345
2. using eina_file_dir_list() with a callback which does nothing :
10 files : 53
1000 files : 251
100000 files : 33832
speed up with 1000 files and more. Twice faster with 100000 files
Test Plan: benchmark program
Reviewers: raster, cedric, zmike
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8842
Hermet Park [Tue, 7 May 2019 08:34:12 +0000 (17:34 +0900)]
efl_ui_textpath: remove err log in none error case.
Ali Alzyod [Mon, 6 May 2019 12:01:24 +0000 (14:01 +0200)]
efl_ui_text: clear selection after cut
Test Plan:
```
#define EFL_EO_API_SUPPORT 1
#define EFL_BETA_API_SUPPORT 1
#include <Eina.h>
#include <Elementary.h>
#include <Efl_Ui.h>
static void
_gui_quit_cb(void *data EINA_UNUSED, const Efl_Event *event EINA_UNUSED)
{
efl_exit(0);
}
static void
_gui_setup()
{
Eo *win, *box;
win = efl_add(EFL_UI_WIN_CLASS, efl_main_loop_get(),
efl_ui_win_type_set(efl_added, EFL_UI_WIN_TYPE_BASIC),
efl_text_set(efl_added, "Hello World"),
efl_ui_win_autodel_set(efl_added, EINA_TRUE));
// when the user clicks "close" on a window there is a request to delete
efl_event_callback_add(win, EFL_UI_WIN_EVENT_DELETE_REQUEST, _gui_quit_cb, NULL);
box = efl_add(EFL_UI_BOX_CLASS, win,
efl_content_set(win, efl_added),
efl_gfx_hint_size_min_set(efl_added, EINA_SIZE2D(360, 240)));
efl_add(EFL_UI_TEXT_CLASS, box,
efl_text_markup_set(efl_added, "Hello World.<ps>This is an <b>Efl.Ui</b> application!"),
efl_text_interactive_selection_allowed_set(efl_added, EINA_TRUE),
efl_text_multiline_set(efl_added,EINA_TRUE),
efl_gfx_hint_weight_set(efl_added, 1.0, 0.9),
efl_gfx_hint_align_set(efl_added, 0.5, 0.5),
efl_pack(box, efl_added));
efl_add(EFL_UI_BUTTON_CLASS, box,
efl_text_set(efl_added, "Quit"),
efl_gfx_hint_weight_set(efl_added, 1.0, 0.1),
efl_pack(box, efl_added),
efl_event_callback_add(efl_added, EFL_UI_EVENT_CLICKED,
_gui_quit_cb, efl_added));
}
EAPI_MAIN void
efl_main(void *data EINA_UNUSED, const Efl_Event *ev EINA_UNUSED)
{
_gui_setup();
}
EFL_MAIN()
```
Reviewers: woohyun, bowonryu, segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8833
Carsten Haitzler (Rasterman) [Mon, 6 May 2019 20:31:01 +0000 (21:31 +0100)]
evas - map render - quick fix for segv in new map renderer
u or v go below 0... sometimes. right now i don't know the full path
to there, bute crashes with flat theme when the busy spinner shows
over an ibar icon when you launch... this at least stops that.
this needs hunting in more detail than i'm going to do on my laptop
on the couch...
Ali Alzyod [Tue, 23 Apr 2019 15:46:47 +0000 (15:46 +0000)]
elm_entry: speed up setting text (check if same text is already set), fix setting same text pointer
This patch deal with two cases:
1- Setting text in Entry (elm_entry_entry_set) , as the one get using (elm_entry_entry_get), caused the entry to become empty.
* becase entry string was free inside the elm_entry_entry_set function, without checking new passed string.
Now we check if same string was passed to the function, then nothing need to be changed.
```
// Old Behaviour : Entry will become empty
// New Behaviour : Entry will Skip setting same text
elm_entry_entry_set(app->entry, elm_entry_entry_get(app->entry));
```
2- Setting text in Entry (elm_entry_entry_set) , with same content string.
* internally entry will set empty string then set passed string, which will case recalculation and re-render the entry element.
Now we check if same string data that is passed to the function is the same of the entry content, then nothing need to be changed.
```
// This will be skiped internally since same text is set
elm_entry_entry_set(app->entry, "aaaaa");
elm_entry_entry_set(app->entry, "aaaaa"); //skipped
```
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8572
Daniel Kolesa [Mon, 6 May 2019 14:48:21 +0000 (16:48 +0200)]
eolian: fail on scan file conflict
If two files of the same name are found in the include paths,
the scan should fail.
Daniel Kolesa [Mon, 6 May 2019 14:46:50 +0000 (16:46 +0200)]
eolian: fix conflicts between eo file names in tests
Fixes T7911.
Mike Blumenkrantz [Tue, 30 Apr 2019 19:30:02 +0000 (15:30 -0400)]
meson: enable and fix build of ddrag+gdi engines for evas
there are some specific defines and cflags needed for these builds
to succeed and provide the expected functionality
Depends on D8733
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Reviewed-by: Vincent Torri <vincent.torri@gmail.com>
Differential Revision: https://phab.enlightenment.org/D8734
Mike Blumenkrantz [Fri, 26 Apr 2019 13:11:59 +0000 (09:11 -0400)]
meson: fix and enable win32 ecore-evas engine build
these defines must be set in order to provide the expected engine functionality
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8733
Mike Blumenkrantz [Tue, 30 Apr 2019 19:09:59 +0000 (15:09 -0400)]
meson: do not build emotion generic loader on windows
this is not supported
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8732
Mike Blumenkrantz [Mon, 6 May 2019 14:24:56 +0000 (10:24 -0400)]
meson: add sdl deps for corresponding ecore-evas engine
this fixes the sdl engine build
Depends on D8730
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8731
Mike Blumenkrantz [Fri, 26 Apr 2019 13:10:28 +0000 (09:10 -0400)]
meson: add versioning to and install the evil dll
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8730