platform/upstream/llvm.git
4 years ago[Fixed Point] [AST] Add an AST serialization code for fixed-point literals.
Vince Bridgers [Tue, 7 Apr 2020 19:46:08 +0000 (14:46 -0500)]
[Fixed Point] [AST] Add an AST serialization code for fixed-point literals.

Summary:
This patch adds the EXPR_FIXEDPOINT_LITERAL AST
code to serialize FixedPointLiterals. They were previously
being serialized with the code for integer literals, which
doesn't work properly.

Reviewers: leonardchan, rjmccall

Reviewed By: leonardchan, rjmccall

Subscribers: vabridgers, JesperAntonsson, bjope, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D57226

4 years ago[SVE] Remove calls to getBitWidth from Hexagon
Christopher Tetreault [Tue, 14 Apr 2020 17:58:39 +0000 (10:58 -0700)]
[SVE] Remove calls to getBitWidth from Hexagon

Reviewers: efriedma, sdesmalen, kparzysz

Reviewed By: kparzysz

Subscribers: tschuett, hiraditya, rkruppe, psnobl, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D77899

4 years ago[STLExtras] Make const the * operator for mapped_iterator.
Alina Sbirlea [Tue, 14 Apr 2020 01:51:20 +0000 (18:51 -0700)]
[STLExtras] Make const the * operator for mapped_iterator.

Summary:
The current non-const * operator shadows the const operator in
iterator_adaptor_base.

Reviewers: mehdi_amini, rriddle!, dblaikie, timshen

Subscribers: dexonsmith, jpienaar, burmako, shauheen, antiagainst, nicolasvasilache, arpith-jacob, mgester, lucyrfox, liufengdb, Joonsoo, grosul1, frgossen, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D78073

4 years ago[InstCombine] add tests for bitcasted shuffle operand; NFC
Sanjay Patel [Tue, 14 Apr 2020 17:38:21 +0000 (13:38 -0400)]
[InstCombine] add tests for bitcasted shuffle operand; NFC

Similar to D76844, but this is casted from wider element type.
See D77881.

4 years ago[InstSimplify] add test for select that should not be simplified; NFC
Sanjay Patel [Mon, 13 Apr 2020 19:31:59 +0000 (15:31 -0400)]
[InstSimplify] add test for select that should not be simplified; NFC

See discussion in D77868

4 years ago[SVE] Remove calls to getBitWidth from ARM
Christopher Tetreault [Tue, 14 Apr 2020 17:34:35 +0000 (10:34 -0700)]
[SVE] Remove calls to getBitWidth from ARM

Reviewers: efriedma

Reviewed By: efriedma

Subscribers: tschuett, kristof.beyls, hiraditya, rkruppe, psnobl, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D77904

4 years agoFix setting Python3_ROOT_DIR on Windows
Isuru Fernando [Fri, 10 Apr 2020 00:44:56 +0000 (19:44 -0500)]
Fix setting Python3_ROOT_DIR on Windows

Summary:
Previously the value of Python3_ROOT_DIR was set to the string
"PYTHON_HOME" instead of the value of the variable named
PYTHON_HOME. This commit fixes that as CMake expects
a path as the value of Python3_ROOT_DIR

Reviewers: #lldb, JDevlieghere, teemperor

Reviewed By: #lldb, JDevlieghere, teemperor

Subscribers: teemperor, JDevlieghere, mgorny, lldb-commits

Tags: #lldb

Differential Revision: https://reviews.llvm.org/D77842

4 years ago[X86] Add tests to clang Driver to ensure that SLH/Retpoline features are not enabled...
Scott Constable [Tue, 14 Apr 2020 17:32:12 +0000 (10:32 -0700)]
[X86] Add tests to clang Driver to ensure that SLH/Retpoline features are not enabled with LVI-CFI

Differential Revision: https://reviews.llvm.org/D77427

4 years ago[builtins] Make __umodsi3/__udivdi3/__umoddi3 standalone (shift and subtract)
Fangrui Song [Fri, 10 Apr 2020 22:14:52 +0000 (15:14 -0700)]
[builtins] Make __umodsi3/__udivdi3/__umoddi3 standalone (shift and subtract)

@kamleshbhalui reported that when the Standard Extension M
(Multiplication and Division) is disabled for RISC-V,
`__udivdi3` will call __udivmodti4 which will in turn calls `__udivdi3`.

This patch moves __udivsi3 (shift and subtract) to int_div_impl.inc
`__udivXi3`, optimize a bit, add a `__umodXi3`, and use `__udivXi3` and
`__umodXi3` to define `__udivsi3` `__umodsi3` `__udivdi3` `__umoddi3`.

Reviewed By: kamleshbhalui

Differential Revision: https://reviews.llvm.org/D77912

4 years ago[FileCheck] Add missing include in FileCheckImpl.h
Thomas Preud'homme [Tue, 14 Apr 2020 17:24:32 +0000 (18:24 +0100)]
[FileCheck] Add missing include in FileCheckImpl.h

FileCheckImpl.h internal header uses type defined in the public
FileCheck.h header but fails to include it. This commit fixes that.

Test Plan: Built it locally successfully.

4 years ago[SVE] Remove calls to getBitWidth from AArch64
Christopher Tetreault [Tue, 14 Apr 2020 17:06:23 +0000 (10:06 -0700)]
[SVE] Remove calls to getBitWidth from AArch64

Reviewers: efriedma

Reviewed By: efriedma

Subscribers: danielkiss, tschuett, kristof.beyls, hiraditya, rkruppe, psnobl, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D77905

4 years ago[lldb/Reproducers] Make static methods go through the invoke wrapper.
Jonas Devlieghere [Tue, 14 Apr 2020 17:18:50 +0000 (10:18 -0700)]
[lldb/Reproducers] Make static methods go through the invoke wrapper.

They don't actually have to, but it makes it easier to unify the
corresponding code and macros. NFC.

4 years ago[AArch64][SVE] Refine node definitions for ff & nf loads/stores (NFC)
Andrzej Warzynski [Wed, 8 Apr 2020 10:15:48 +0000 (11:15 +0100)]
[AArch64][SVE] Refine node definitions for ff & nf loads/stores (NFC)

Summary:
Only first-faulting and non-faulting loads read/update the FFR register
and hence only the corresponding SDNodes should be decorated with
`SDNPOptInGlue` and `SDNPOutGlue`. This patch:
  * removes SDNPOptInGlue from regular loads stores (FFR is not read)
  * adds SDNPOutGlue to first-faulting and non-faulting loads (FFR is
    both read and updated)

Differential Revision: https://reviews.llvm.org/D77724

4 years ago[flang] Upstream patch to enable the fir-ops test. bug 45487
Eric Schweitz [Tue, 14 Apr 2020 16:50:50 +0000 (09:50 -0700)]
[flang] Upstream patch to enable the fir-ops test. bug 45487

Differential revision: https://reviews.llvm.org/D77834

4 years ago[gn build] (manually) port c8a5b30bac6
Nico Weber [Tue, 14 Apr 2020 16:51:58 +0000 (12:51 -0400)]
[gn build] (manually) port c8a5b30bac6

4 years ago[lldb/Reproducers] Capture reproducers from the API test suite.
Jonas Devlieghere [Tue, 14 Apr 2020 15:41:50 +0000 (08:41 -0700)]
[lldb/Reproducers] Capture reproducers from the API test suite.

Make it possible to capture reproducers from the API test suite. Given
the symmetry between capture and replay, this patch also adds the
necessary code for replay. For now this is a NO-OP until the
corresponding reproducer instrumentation changes land.

For more info please refer to the RFC on lldb-dev:
http://lists.llvm.org/pipermail/lldb-dev/2020-April/016100.html

Differential revision: https://reviews.llvm.org/D77588

4 years ago[AbstractCallSite] Check that callback callee index is within call arguments
Sergey Dmitriev [Tue, 14 Apr 2020 16:12:34 +0000 (09:12 -0700)]
[AbstractCallSite] Check that callback callee index is within call arguments

Summary:
AbstractCallSite::getCallbackUses() does not check that callback callee index from
the callback metadata does not exceed the total number of call arguments. This patch
add such validation check.

Reviewers: jdoerfert, sstefan1

Reviewed By: jdoerfert

Subscribers: hiraditya, arphaman, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D78112

4 years ago[libc++] Remove support for .fail.mm tests
Louis Dionne [Tue, 14 Apr 2020 16:16:58 +0000 (12:16 -0400)]
[libc++] Remove support for .fail.mm tests

There are no such tests in the libc++ test suite, and I want to move
away from `.fail.cpp` tests (in favour of something else) too, which
require a workaround.

4 years ago[ADT] Mix the bit width into APInt's hash_value
Benjamin Kramer [Tue, 14 Apr 2020 16:13:49 +0000 (18:13 +0200)]
[ADT] Mix the bit width into APInt's hash_value

Otherwise all zero values from i1 to i64 collide.

4 years ago[SveEmitter] Add range checks for immediates and predicate patterns.
Sander de Smalen [Tue, 14 Apr 2020 14:56:36 +0000 (15:56 +0100)]
[SveEmitter] Add range checks for immediates and predicate patterns.

Summary:
This patch adds a mechanism to easily add range checks for a builtin's
immediate operands. This patch is tested with the qdech intrinsic, which takes
both an enum for the predicate pattern, as well as an immediate for the
multiplier.

Reviewers: efriedma, SjoerdMeijer, rovka

Reviewed By: efriedma, SjoerdMeijer

Subscribers: mgorny, tschuett, mgrang, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D76678

4 years ago[lldb/Docs] Document active and passive replay.
Jonas Devlieghere [Tue, 14 Apr 2020 15:39:46 +0000 (08:39 -0700)]
[lldb/Docs] Document active and passive replay.

Document reproducer replay and its two modes.

Differential revision: https://reviews.llvm.org/D77771

4 years ago[FunctionAttrs] Don't copy all the nodes where a reference is fine.
Benjamin Kramer [Tue, 14 Apr 2020 14:52:26 +0000 (16:52 +0200)]
[FunctionAttrs] Don't copy all the nodes where a reference is fine.

4 years ago[PowerPC][NFC] Remove spurious incorrect CHECKNEXT directive from test
Nemanja Ivanovic [Tue, 14 Apr 2020 15:11:13 +0000 (10:11 -0500)]
[PowerPC][NFC] Remove spurious incorrect CHECKNEXT directive from test

The directive was a typo when I first wrote the test case, then
decided to use the script and the script didn't remove the line
with the typo.

4 years ago[LV][ARM] Add tail-folding tests for MVE. NFC.
Sjoerd Meijer [Tue, 14 Apr 2020 14:38:12 +0000 (15:38 +0100)]
[LV][ARM] Add tail-folding tests for MVE. NFC.

D77635 added support to recognise primary induction variables for counting-down
loops. This allows us to fold the scalar tail loop into the main vector body,
which we need for MVE tail-predication. This adds some ARM tail-folding test
cases that we want to support.

This test was extracted from D76838, which implemented a different approach to
reverse and thus find a primary induction variable.

4 years ago[SveEmitter] Fix encoding/decoding of SVETypeFlags
Sander de Smalen [Tue, 14 Apr 2020 14:31:20 +0000 (15:31 +0100)]
[SveEmitter] Fix encoding/decoding of SVETypeFlags

Summary:
This issue was introduced when reworking D75861. The bug isn't
actually hit with current unit tests because the contiguous loads/stores
infer the EltType and the MemEltType from the pointer and result, rather
than using the flags. But it will be needed for other intrinsics, such as
gather/scatter.

Reviewers: SjoerdMeijer, Andrzej

Reviewed By: SjoerdMeijer

Subscribers: andwar, tschuett, cfe-commits, llvm-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D76617

4 years ago[SveEmitter] Implement builtins for contiguous loads/stores
Sander de Smalen [Tue, 14 Apr 2020 12:17:52 +0000 (13:17 +0100)]
[SveEmitter] Implement builtins for contiguous loads/stores

This adds builtins for all contiguous loads/stores, including
non-temporal, first-faulting and non-faulting.

Reviewers: efriedma, SjoerdMeijer

Reviewed By: SjoerdMeijer

Tags: #clang

Differential Revision: https://reviews.llvm.org/D76238

4 years ago[gn build] Port 45630243562
LLVM GN Syncbot [Tue, 14 Apr 2020 14:20:02 +0000 (14:20 +0000)]
[gn build] Port 45630243562

4 years ago[Target][ARM] Fix VPT Block Pass miscompilation
Pierre-vh [Thu, 9 Apr 2020 08:19:23 +0000 (09:19 +0100)]
[Target][ARM] Fix VPT Block Pass miscompilation

The pass was incorrectly reverting back to a "T" when something wrote
to VPR inside a "E" block. This is not the correct behaviour, the
predicate should stay the same.

Differential Revision: https://reviews.llvm.org/D77798

4 years ago[Target][ARM] Adding MVE VPT Optimisation Pass
Pierre-vh [Wed, 18 Mar 2020 15:23:17 +0000 (15:23 +0000)]
[Target][ARM] Adding MVE VPT Optimisation Pass

Differential Revision: https://reviews.llvm.org/D76709

4 years ago[clangd] Add tests that no-op changes are cheap
Sam McCall [Mon, 13 Apr 2020 20:07:12 +0000 (22:07 +0200)]
[clangd] Add tests that no-op changes are cheap

Summary:
We want to be sure they don't cause AST rebuilds or evict items from the cache.
D77847 is going to start sending spurious no-op changes (in case the preamble
was invalidated), this is cheap enough but we shouldn't regress that in future.

Reviewers: kadircet

Subscribers: ilya-biryukov, javed.absar, MaskRay, jkorous, arphaman, jfb, usaxena95, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D78048

4 years agolibclc: Use temporary files rather than a pipe
Daniel Stone [Tue, 14 Apr 2020 04:42:50 +0000 (00:42 -0400)]
libclc: Use temporary files rather than a pipe

This is required for using the Ninja backend on Windows, as it passes
commands directly to CreateProcess, and does not allow the shell to
interpret them: https://ninja-build.org/manual.html#ref_rule_command

Using the Visual Studio backend is not possible as attempting to create
a static library target comprised entirely of novel languages not known
to the Visual Studio backend built in to CMake's C++ source will
generate nothing at all.

reviewer: jvesely
Differential Revision: https://reviews.llvm.org/D77165

4 years agolibclc: Don't pass linker flags to CLC/LLAsm
Daniel Stone [Tue, 14 Apr 2020 04:41:29 +0000 (00:41 -0400)]
libclc: Don't pass linker flags to CLC/LLAsm

We don't want the regular linker flags for these invocations, since
we're not compiling to the target machine anyway. This fixes things like
'/machine:x64' being unknown when invoked under Windows.

reviewer: jvesely
Differential Revision: https://reviews.llvm.org/D77164

4 years agolibclc: Use echo rather than true for try_compile
Daniel Stone [Tue, 14 Apr 2020 04:40:20 +0000 (00:40 -0400)]
libclc: Use echo rather than true for try_compile

When providing a fake compiler, libclc currently uses 'true' which does
not exist on Windows. Use echo instead as the no-op.

reviewer: jvesely
Differential Revision: https://reviews.llvm.org/D77163

4 years agolibclc: Fix LLVM library linking on Windows
Daniel Stone [Tue, 14 Apr 2020 04:38:22 +0000 (00:38 -0400)]
libclc: Fix LLVM library linking on Windows

CMake requires library lists on Windows to be split by semi-colons,
rather than the spaces we get from llvm-config. Fix this by a
substitution on Windows.

reviewer: jvesely
Differential Revision: https://reviews.llvm.org/D77162

4 years ago[DWARFDebugLine] Check for (EOF) errors when parsing v5 content descriptors
Pavel Labath [Mon, 23 Mar 2020 10:40:25 +0000 (11:40 +0100)]
[DWARFDebugLine] Check for (EOF) errors when parsing v5 content descriptors

Summary:
Without that we could be silently reading zeroes, as that's the default
DataExtractor behavior. The entire parse would still most likely fail,
but it would do that with a seemingly unrelated/nonsensical error
message.

Reviewers: dblaikie, probinson, jhenderson

Subscribers: hiraditya, MaskRay, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D77554

4 years ago[ADCE] Fix incorrect reporting of CFG changes
Max Kazantsev [Tue, 14 Apr 2020 13:25:31 +0000 (20:25 +0700)]
[ADCE] Fix incorrect reporting of CFG changes

This patch fixes 2 related bugs in ADCE:
- `performDeadCodeElimination` does not report changes if it did ONLY
  CFG changes (affects both old and new pass managers);
- When control flow removal is enabled, new pass manager does not
  drop CFG analyses.

Both can lead to incorrect loop info after ADCE that does only CFG changes.

Differential Revision: https://reviews.llvm.org/D78103
Reviewed By: Denis Antrushin

4 years ago[clang-objc-fuzzer] Add LLVMFuzzerInitialize to fix msvc builds (PR44414)
Simon Pilgrim [Tue, 14 Apr 2020 12:37:10 +0000 (13:37 +0100)]
[clang-objc-fuzzer] Add LLVMFuzzerInitialize to fix msvc builds (PR44414)

The (supposedly superfluous) LLVMFuzzerInitialize function was removed when this file was copied from clang-fuzzer, but this is causing link errors on some targets. @morehouse confirmed on D69171 that it was OK to add back.

4 years ago[libc++] Simplify how with_system_cxx_lib and availability features are defined
Louis Dionne [Mon, 13 Apr 2020 21:12:30 +0000 (17:12 -0400)]
[libc++] Simplify how with_system_cxx_lib and availability features are defined

Instead of spamming a bunch of available features that are not actually
used anywhere, only set those that are actually used in the test suite.
In the future, this should probably be based on the target triple only,
with the ability to have wildcards in the triple.

4 years ago[libc++] NFC: Minor cleanups in config.py
Louis Dionne [Mon, 13 Apr 2020 21:28:52 +0000 (17:28 -0400)]
[libc++] NFC: Minor cleanups in config.py

Remove mentions of the ValgrindExecutor, which doesn't exist. That
executor is literally nowhere in the code base, so this is dead code
as far as we're concerned.

Also, inline a one-liner function that was called exactly once.

4 years ago[TTI][X86] Add X86TTIImpl::getScalarizationOverhead implementation.
Simon Pilgrim [Tue, 14 Apr 2020 11:58:02 +0000 (12:58 +0100)]
[TTI][X86] Add X86TTIImpl::getScalarizationOverhead implementation.

This is a currently just a wrapper to the base type, I'll be adding ISD::BUILD_VECTOR costs in a future patch.

4 years ago[lldb/test] Fix TestLoadUnload
Med Ismail Bennani [Tue, 14 Apr 2020 11:53:26 +0000 (13:53 +0200)]
[lldb/test] Fix TestLoadUnload

Summary:
[lldb/test] Fix TestLoadUnload failure introduced in e0dbd025131c4d77d8a5050a91d391d950529a8c

It seems that `env_cmd_string` is declared and used few lines under this
self.runCmd expression. I guess this is some left-over from an older
version.

Signed-off-by: Med Ismail Bennani <medismail.bennani@gmail.com>
Reviewers: labath

Reviewed By: labath

Subscribers: lldb-commits

Tags: #lldb

Differential Revision: https://reviews.llvm.org/D78094

4 years ago[Test] Add failing test that demonstrates buggy behavior of ADCE
Max Kazantsev [Tue, 14 Apr 2020 11:15:16 +0000 (18:15 +0700)]
[Test] Add failing test that demonstrates buggy behavior of ADCE

ADCE messes up with loop info (proved for new pass manager only) by
making some loop blocks unreachable, without making proper updates
to the loop.

4 years ago[ValueLattice] Remove unused DataLayout parameter of mergeIn, NFC
Aaron Puchert [Tue, 14 Apr 2020 11:32:43 +0000 (13:32 +0200)]
[ValueLattice] Remove unused DataLayout parameter of mergeIn, NFC

Reviewed By: fhahn, echristo

Differential Revision: https://reviews.llvm.org/D78061

4 years ago[LLDB] Remove xfail aarch64-linux from test_step_over_load*
Muhammad Omair Javaid [Tue, 14 Apr 2020 11:19:05 +0000 (16:19 +0500)]
[LLDB] Remove xfail aarch64-linux from test_step_over_load*

test_step_over_load_with_svr4 and test_step_over_load now pass on
aarch64 linux.

Fixed by change-id: e0dbd025131c4d77d8a5050a91d391d950529a8c

Differential Revision: https://reviews.llvm.org/D77662

4 years ago[ADT/STLExtras.h] - Add llvm::is_sorted wrapper and update callers.
Georgii Rymar [Mon, 13 Apr 2020 11:46:41 +0000 (14:46 +0300)]
[ADT/STLExtras.h] - Add llvm::is_sorted wrapper and update callers.

It can be used to avoid passing the begin and end of a range.
This makes the code shorter and it is consistent with another
wrappers we already have.

Differential revision: https://reviews.llvm.org/D78016

4 years ago[MLIR] Constant fold multiplies in deriveStaticUpperBound.
Tres Popp [Tue, 7 Apr 2020 12:12:04 +0000 (14:12 +0200)]
[MLIR] Constant fold multiplies in deriveStaticUpperBound.

Summary:
This operation occurs during collapseParallelLoops, so we constant fold
them also to allow more situations of determining a loop invariant upper
bound when lowering to the GPU dialect from the Loop dialect.

Differential Revision: https://reviews.llvm.org/D77723

4 years ago[AST] Dont invalide VarDecl even the default initializaiton is failed.
Haojian Wu [Fri, 3 Apr 2020 09:00:16 +0000 (11:00 +0200)]
[AST] Dont invalide VarDecl even the default initializaiton is failed.

Summary:
This patch would cause clang emit more diagnostics, but it is much better than https://reviews.llvm.org/D76831

```cpp
struct A {
  A(int);
  ~A() = delete;
};
void k() {
  A a;
}

```

before the patch:

/tmp/t3.cpp:24:5: error: no matching constructor for initialization of 'A'
  A a;
    ^
/tmp/t3.cpp:20:3: note: candidate constructor not viable: requires 1 argument, but 0 were provided
  A(int);
  ^
/tmp/t3.cpp:19:8: note: candidate constructor (the implicit copy constructor) not viable: requires 1 argument, but 0 were provided
struct A {

After the patch:

/tmp/t3.cpp:24:5: error: no matching constructor for initialization of 'A'
  A a;
    ^
/tmp/t3.cpp:20:3: note: candidate constructor not viable: requires 1 argument, but 0 were provided
  A(int);
  ^
/tmp/t3.cpp:19:8: note: candidate constructor (the implicit copy constructor) not viable: requires 1 argument, but 0 were provided
struct A {
       ^
/tmp/t3.cpp:24:5: error: attempt to use a deleted function
  A a;
    ^
/tmp/t3.cpp:21:3: note: '~A' has been explicitly marked deleted here
  ~A() = delete;

Reviewers: sammccall

Reviewed By: sammccall

Subscribers: cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D77395

4 years agoRecommit "[SCCP] Use SimplifyBinOp for non-integer constant/expressions & overdef."
Florian Hahn [Tue, 14 Apr 2020 10:15:20 +0000 (11:15 +0100)]
Recommit "[SCCP] Use SimplifyBinOp for non-integer constant/expressions & overdef."

This includes a fix reported with simplifications in the presence of
NaN.

This reverts the revert commit 06408451bf12d4baed1fb1312d8af6e6bbb6a797.

4 years ago[AssumeBundles] preserve knowledge in DCE
Tyker [Tue, 14 Apr 2020 09:57:19 +0000 (11:57 +0200)]
[AssumeBundles] preserve knowledge in DCE

Reviewers: jdoerfert

Reviewed By: jdoerfert

Subscribers: hiraditya, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D77403

4 years ago[AssumeBundles] preserve knowledge in DSE
Tyker [Tue, 14 Apr 2020 09:56:56 +0000 (11:56 +0200)]
[AssumeBundles] preserve knowledge in DSE

Reviewers: jdoerfert

Reviewed By: jdoerfert

Subscribers: hiraditya, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D77404

4 years ago[AssumeBundles] preserve information in NewGVN
Tyker [Tue, 14 Apr 2020 09:56:38 +0000 (11:56 +0200)]
[AssumeBundles] preserve information in NewGVN

Reviewers: jdoerfert

Reviewed By: jdoerfert

Subscribers: Prazek, hiraditya, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D77406

4 years ago[AssumeBundles] preserve information in LICM
Tyker [Tue, 14 Apr 2020 09:56:16 +0000 (11:56 +0200)]
[AssumeBundles] preserve information in LICM

Reviewers: jdoerfert

Reviewed By: jdoerfert

Subscribers: hiraditya, asbirlea, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D77407

4 years ago[AssumeBundles] adapte GVN to assume bundles
Tyker [Tue, 14 Apr 2020 09:55:56 +0000 (11:55 +0200)]
[AssumeBundles] adapte GVN to assume bundles

Summary:
prevent GVN from removing assume bundles
make GVN preserve information from removed instructions

Reviewers: jdoerfert

Reviewed By: jdoerfert

Subscribers: hiraditya, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D77405

4 years ago[Analyzer][StreamChecker] Added evaluation of fseek.
Balázs Kéri [Tue, 14 Apr 2020 09:14:17 +0000 (11:14 +0200)]
[Analyzer][StreamChecker] Added evaluation of fseek.

Summary:
Function `fseek` is now evaluated with setting error return value
and error flags.

Reviewers: Szelethus, NoQ, xazax.hun, rnkovacs, dcoughlin, baloghadamsoftware, martong

Reviewed By: Szelethus

Subscribers: ASDenysPetrov, xazax.hun, baloghadamsoftware, szepet, a.sidorin, mikhail.ramalho, Szelethus, donat.nagy, dkrupp, gamesh411, Charusso, martong, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D75851

4 years ago[LLD][ELF][Test] - Fixed the broken test case.
Georgii Rymar [Tue, 14 Apr 2020 10:20:51 +0000 (13:20 +0300)]
[LLD][ELF][Test] - Fixed the broken test case.

There was no ":" after "SEC", hence the check was
disabled. Found with the use of D78024.

4 years ago[gn build] Port 36c76de6789
LLVM GN Syncbot [Tue, 14 Apr 2020 09:55:20 +0000 (09:55 +0000)]
[gn build] Port 36c76de6789

4 years ago[AArch64][SVE] Add a pass for SVE intrinsic optimisations
Kerry McLaughlin [Tue, 14 Apr 2020 08:52:04 +0000 (09:52 +0100)]
[AArch64][SVE] Add a pass for SVE intrinsic optimisations

Summary:
Creates the SVEIntrinsicOpts pass. In this patch, the pass tries
to remove unnecessary reinterpret intrinsics which convert to
and from svbool_t (llvm.aarch64.sve.convert.[to|from].svbool)

For example, the reinterprets below are redundant:

  %1 = call <vscale x 16 x i1> @llvm.aarch64.sve.convert.to.svbool.nxv4i1(<vscale x 4 x i1> %a)
  %2 = call <vscale x 4 x i1> @llvm.aarch64.sve.convert.from.svbool.nxv4i1(<vscale x 16 x i1> %1)

The pass also looks for ptest intrinsics and phi instructions where
the operands are being needlessly converted to and from svbool_t.

Reviewers: sdesmalen, andwar, efriedma, cameron.mcinally, c-rhodes, rengolin

Reviewed By: efriedma

Subscribers: mgorny, tschuett, kristof.beyls, hiraditya, rkruppe, psnobl, danielkiss, cfe-commits, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D76078

4 years ago[MC][ARM] Emit R_ARM_BASE_PREL for _GLOBAL_OFFSET_TABLE_ expressions
Peter Smith [Mon, 13 Apr 2020 07:55:07 +0000 (08:55 +0100)]
[MC][ARM] Emit R_ARM_BASE_PREL for _GLOBAL_OFFSET_TABLE_ expressions

The _GLOBAL_OFFSET_TABLE_ in SysVr4 ELF is conventionally the base of the
.got or .got.prel sections. Expressions such as _GLOBAL_OFFSET_TABLE_
- (.L1 +8) are used in assembler code to calculate offsets into the .got.
At present MC outputs a R_ARM_REL32 with respect to the
_GLOBAL_OFFSET_TABLE_ symbol, whereas gas outputs a R_ARM_BASE_PREL
relocation with respect to the _GLOBAL_OFFSET_TABLE_ symbol. While both are
correct the R_ARM_REL32 depends on the value of the _GLOBAL_OFFSET_TABLE_
symbol, wheras te R_ARM_BASE_PREL relocation is idependent of the symbol.
The R_ARM_BASE_PREL is therefore slightly more robust to linker's that may
not follow the conventional placement of _GLOBAL_OFFSET_TABLE_; for example
LLD for some time defined _GLOBAL_OFFSET_TABLE_ to 0.

Differential Revision: https://reviews.llvm.org/D46319

4 years ago[lldb/test] Make TestLoadUnload compatible with windows
Pavel Labath [Mon, 6 Apr 2020 20:24:51 +0000 (22:24 +0200)]
[lldb/test] Make TestLoadUnload compatible with windows

Summary:
This patch introduces a header "dylib.h" which can be used in tests to
handle shared libraries semi-portably. The shared library APIs on
windows and posix systems look very different, but their underlying
functionality is relatively similar, so the mapping is not difficult.

It also introduces two new macros to wrap the functinality necessary to
export/import function across the dll boundary on windows. Previously we
had the LLDB_TEST_API macro for this purpose, which automagically
changed meaning depending on whether we were building the shared library
or the executable. While convenient for simple cases, this approach was
not sufficient for the more complicated setups where one deals with
multiple shared libraries.

Lastly it rewrites TestLoadUnload, to make use of the new APIs. The
trickiest aspect there is the handling of DYLD_LIBRARY_PATH on macos --
previously setting this variable was not needed as the test used
@executable_path-relative dlopens, but the new generic api does not
support that. Other systems do not support such dlopens either so the
test already contained support for setting the appropriate path
variable, and this patch just makes that logic more generic. In doesn't
seem that the purpose of this test was to exercise @executable_path
imports, so this should not be a problem.

These changes are sufficient to make some of the TestLoadUnload tests
pass on windows. Two other tests will start to pass once D77287 lands.

Reviewers: amccarth, jingham, JDevlieghere, compnerd

Subscribers: lldb-commits

Tags: #lldb

Differential Revision: https://reviews.llvm.org/D77662

4 years ago[SanitizerCoverage] The section name for inline-bool-flag was too long for darwin...
Pratyai Mazumder [Tue, 14 Apr 2020 06:49:31 +0000 (23:49 -0700)]
[SanitizerCoverage] The section name for inline-bool-flag was too long for darwin builds, so shortening it.

Summary:
Following up on the comments on D77638.

Not undoing rGd6525eff5ebfa0ef1d6cd75cb9b40b1881e7a707 here at the moment, since I don't know how to test mac builds. Please let me know if I should include that here too.

Reviewers: vitalybuka

Reviewed By: vitalybuka

Subscribers: hiraditya, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D77889

4 years ago[Analyzer][VLASize] Support multi-dimensional arrays.
Balázs Kéri [Tue, 14 Apr 2020 07:20:22 +0000 (09:20 +0200)]
[Analyzer][VLASize] Support multi-dimensional arrays.

Summary:
Check the size constraints for every (variable) dimension of the array.
Try to compute array size by multiplying size for every dimension.

Reviewers: Szelethus, martong, baloghadamsoftware, gamesh411

Reviewed By: Szelethus, martong

Subscribers: rnkovacs, xazax.hun, baloghadamsoftware, szepet, a.sidorin, mikhail.ramalho, Szelethus, donat.nagy, dkrupp, gamesh411, Charusso, martong, ASDenysPetrov, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D77305

4 years ago[libc] Add very basic stdio FILE and fwrite
Alex Brachet [Tue, 14 Apr 2020 08:02:27 +0000 (04:02 -0400)]
[libc] Add very basic stdio FILE and fwrite

Summary:
This patch adds a very basic `FILE` type and basic `fwrite`.

It also removes `snprintf` from `StdIO`'s function spec because `VarArgType` was causing the generation to fail.

Reviewers: sivachandra, PaulkaToast

Reviewed By: sivachandra

Subscribers: mgorny, MaskRay, tschuett, libc-commits

Differential Revision: https://reviews.llvm.org/D77626

4 years ago[libc] Remove <functional> dependency in syscall_test.cpp
Alex Brachet [Tue, 14 Apr 2020 07:27:10 +0000 (03:27 -0400)]
[libc] Remove <functional> dependency in syscall_test.cpp

Summary: Create self contained functional header which has a type similar to `std::function`

Reviewers: sivachandra, PaulkaToast

Reviewed By: sivachandra

Subscribers: mgorny, tschuett, libc-commits

Differential Revision: https://reviews.llvm.org/D77948

4 years ago[VE] Remove unnecessary iz pattern
Kazushi (Jam) Marukawa [Tue, 14 Apr 2020 06:56:44 +0000 (08:56 +0200)]
[VE] Remove unnecessary iz pattern

Summary:
This iz pattern is a special pattern of im pattern.  This im pattern
has been supported by https://reviews.llvm.org/D77769, so removing
iz pattern as a continuous patch.

Reviewed By: simoll

Differential Revision: https://reviews.llvm.org/D77770

4 years ago[CallSite removal][CodeGen] Replace ImmutableCallSite with CallBase in isInTailCallPo...
Craig Topper [Tue, 14 Apr 2020 06:04:52 +0000 (23:04 -0700)]
[CallSite removal][CodeGen] Replace ImmutableCallSite with CallBase in isInTailCallPosition.

4 years ago[llvm][NFC][CallSite] Remove CallSite from CGSCCPassManager
Mircea Trofin [Tue, 14 Apr 2020 04:41:25 +0000 (21:41 -0700)]
[llvm][NFC][CallSite] Remove CallSite from CGSCCPassManager

Reviewers: craig.topper, dblaikie, davidxl

Subscribers: llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D78080

4 years ago[XRay] Define uint64_t Address = Sled.Address; NFC
Fangrui Song [Tue, 14 Apr 2020 05:28:31 +0000 (22:28 -0700)]
[XRay] Define uint64_t Address = Sled.Address; NFC

This makes it easy to change the address stored in a sled from an
absolute address to a PC-relative address.

4 years agoFix the MLIR integer attribute parser to be correct in the face of large integer...
Chris Lattner [Mon, 13 Apr 2020 23:37:00 +0000 (16:37 -0700)]
Fix the MLIR integer attribute parser to be correct in the face of large integer attributes, it was previously artificially limited to 64 bits.

Reviewers: rriddle!

Subscribers: mehdi_amini, rriddle, jpienaar, burmako, shauheen, antiagainst, nicolasvasilache, arpith-jacob, mgester, lucyrfox, liufengdb, Joonsoo, grosul1, frgossen, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D78065

4 years ago[llvm][NFC] CallSite removal from inliner-related files
Mircea Trofin [Mon, 13 Apr 2020 23:39:52 +0000 (16:39 -0700)]
[llvm][NFC] CallSite removal from inliner-related files

Summary: This removes CallSite from inliner files. Some dependencies where thus affected.

Reviewers: dblaikie, davidxl, craig.topper

Subscribers: arsenm, jvesely, nhaehnle, eraman, hiraditya, aheejin, kerbowa, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D77991

4 years agoFix MLIR test case failure caused by 89e0662dee5fa541f284e6be0af9e36e7f39f947
Uday Bondhugula [Tue, 14 Apr 2020 04:24:19 +0000 (09:54 +0530)]
Fix MLIR test case failure caused by 89e0662dee5fa541f284e6be0af9e36e7f39f947

Fix MLIR test case failure introduced by
89e0662dee5fa541f284e6be0af9e36e7f39f947. LLVM's IR builder
now automatically sets the alignment on alloca.

4 years ago[MLIR] Remove dead affine.applys while generating pointwise copies
Uday Bondhugula [Mon, 13 Apr 2020 19:48:37 +0000 (01:18 +0530)]
[MLIR] Remove dead affine.applys while generating pointwise copies

This makes no impact on the test cases because affine-data-copy-generate
runs whole function canonicalization at its end; however, the latter
will be removed in a pending revision. It is thus useful to clean up
these affine.applys right here, and eventually, not even generate
these (when the right API to compose by construction is in place).

Differential Revision: https://reviews.llvm.org/D78055

4 years ago[X86] Use a more realisitic cost for truncate v16i64->v16i8 with avx512f.
Craig Topper [Tue, 14 Apr 2020 03:43:43 +0000 (20:43 -0700)]
[X86] Use a more realisitic cost for truncate v16i64->v16i8 with avx512f.

Still not great and we could probably codegen this better, but
11 was clearly ridiculous.

4 years ago[X86] Split AVX512 getCastInstrCost into tables that require useAVX512Regs() and...
Craig Topper [Tue, 14 Apr 2020 02:29:33 +0000 (19:29 -0700)]
[X86] Split AVX512 getCastInstrCost into tables that require useAVX512Regs() and those that just operate on 256 or smaller vectors.

Use useAVX512Regs() to skip lookups instead of using type legalization
action.

4 years ago[X86] Add a more accurate truncate cost for v8i64->v8i8
Craig Topper [Tue, 14 Apr 2020 01:59:09 +0000 (18:59 -0700)]
[X86] Add a more accurate truncate cost for v8i64->v8i8

4 years ago[X86] Add truncate cost model tests to min-legal-vector-width.ll for when we're avoid...
Craig Topper [Tue, 14 Apr 2020 01:37:23 +0000 (18:37 -0700)]
[X86] Add truncate cost model tests to min-legal-vector-width.ll for when we're avoiding 512 bit vectors.

4 years ago[lit] Update local test objects "in place" from remote test objects
Julian Lettner [Tue, 14 Apr 2020 03:44:15 +0000 (20:44 -0700)]
[lit] Update local test objects "in place" from remote test objects

Update local test object "in place" from remote test object.  We need to
do this to ensure that discovered test object which is used for printing
test results reflect the changes.

> Why are we sending back the whole test object from the worker process
> (lit.worker.execute) instead of just the result?

Unfortunately, the test result is not the only "result" of test
execution.  Other members (e.g., xfails, requires) of the Test class are
set only during execution.  Those members affect the behavior of
`isExpectedToFail` and `setResult`, and are accessed when printing
results.  For example, xunit.xml test results include missing features
for "skip reasons".  The lack of separation between an immutable "test
definition" and "generated outputs" (including the primary result and
other secondary state) is unfortunate historical design decision in lit.

> Why do we update the initial test object instead of just discarding it
> and continuing with the pickled test object?

Both of these approaches would work.  However, note that we need a fully
populated test object for printing results.  Updating the existing one
seems to be the easier path.

4 years ago[VE] Adapt D77995 CallSite removal
Fangrui Song [Tue, 14 Apr 2020 02:54:39 +0000 (19:54 -0700)]
[VE] Adapt D77995 CallSite removal

4 years agoGlobalISel: Fix casted unmerge of G_CONCAT_VECTORS
Matt Arsenault [Sat, 11 Apr 2020 17:57:15 +0000 (13:57 -0400)]
GlobalISel: Fix casted unmerge of G_CONCAT_VECTORS

This was assuming a scalarizing unmerge, and would fail assert if the
unmerge was to smaller vector types.

4 years agoAdd duplex to R_HEX_GOT_16_X
Brian Cain [Fri, 10 Apr 2020 21:19:30 +0000 (16:19 -0500)]
Add duplex to R_HEX_GOT_16_X

Building 'espresso' from llvm-test-suite revealed missing support
for duplex instructions with R_HEX_GOT_16_X.

4 years ago[gn build] Port 384ca190ae7
LLVM GN Syncbot [Tue, 14 Apr 2020 00:27:34 +0000 (00:27 +0000)]
[gn build] Port 384ca190ae7

4 years agoRevert "Move ModuleSummaryAnalysis from libAnalysis to libObject to break the depende...
Mehdi Amini [Tue, 14 Apr 2020 00:27:08 +0000 (00:27 +0000)]
Revert "Move ModuleSummaryAnalysis from libAnalysis to libObject to break the dependency from Analysis to Object"

This reverts commit 10df1563d608323a3144afc5f6038ecb81869b92.

Some buildbots are broken.

4 years ago[gn build] (manually) merge 10df1563d some more
Nico Weber [Tue, 14 Apr 2020 00:15:01 +0000 (20:15 -0400)]
[gn build] (manually) merge 10df1563d some more

4 years ago[SVE] Change return type of getNumElements to unsigned
Christopher Tetreault [Mon, 13 Apr 2020 23:00:10 +0000 (16:00 -0700)]
[SVE] Change return type of getNumElements to unsigned

Reviewers: efriedma, sdesmalen, craig.topper, dexonsmith

Reviewed By: efriedma, sdesmalen

Subscribers: tschuett, hiraditya, rkruppe, psnobl, mehdi_amini, rriddle, jpienaar, burmako, shauheen, antiagainst, nicolasvasilache, arpith-jacob, mgester, lucyrfox, aartbik, liufengdb, Joonsoo, grosul1, frgossen, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D77763

4 years ago[gn build] Port 10df1563d60
LLVM GN Syncbot [Mon, 13 Apr 2020 23:18:41 +0000 (23:18 +0000)]
[gn build] Port 10df1563d60

4 years agoAMDGPU/GlobalISel: Combines for V_CVT_F32_UBYTE[0-3]
Matt Arsenault [Sun, 29 Mar 2020 16:34:35 +0000 (12:34 -0400)]
AMDGPU/GlobalISel: Combines for V_CVT_F32_UBYTE[0-3]

Ports the existing DAG combines, minus the simplify demanded bits
which seems to have no equivalent now. Without these, this isn't
particularly helpful in most of the IR sample cases.

4 years agoMove ModuleSummaryAnalysis from libAnalysis to libObject to break the dependency...
Mehdi Amini [Mon, 13 Apr 2020 04:21:40 +0000 (04:21 +0000)]
Move ModuleSummaryAnalysis from libAnalysis to libObject to break the dependency from Analysis to Object

ModuleSummaryAnalysis is the only file in libAnalysis that brings a
dependency on the CodeGen layer from libAnalysis, moving it breaks this
dependency.

Differential Revision: https://reviews.llvm.org/D77994

4 years ago[AMDGPU][GlobalISel] Fix div_scale in FDIV lowering
Austin Kerbow [Mon, 13 Apr 2020 06:25:18 +0000 (23:25 -0700)]
[AMDGPU][GlobalISel] Fix div_scale in FDIV lowering

Differential Revision: https://reviews.llvm.org/D78004

4 years ago[CUDA] Fix missed CUDA version mappings.
Artem Belevich [Mon, 13 Apr 2020 21:55:26 +0000 (14:55 -0700)]
[CUDA] Fix missed CUDA version mappings.

4 years ago[WebAssembly] Fix try placement in fixing unwind mismatches
Heejin Ahn [Fri, 10 Apr 2020 23:46:39 +0000 (16:46 -0700)]
[WebAssembly] Fix try placement in fixing unwind mismatches

Summary:
In CFGStackify, `fixUnwindMismatches` function fixes unwind destination
mismatches created by `try` marker placement. For example,
```
try
  ...
  call @qux  ;; This should throw to the caller!
catch
  ...
end
```
When `call @qux` is supposed to throw to the caller, it is possible that
it is wrapped inside a `catch` so in case it throws it ends up unwinding
there incorrectly. (Also it is possible `call @qux` is supposed to
unwind to another `catch` within the same function.)

To fix this, we wrap this inner `call @qux` with a nested
`try`-`catch`-`end` sequence, and within the nested `catch` body, branch
to the right destination:
```
block $l0
  try
    ...
    try                 ;; new nested try
      call @qux
    catch               ;; new nested catch
      local.set n       ;; store exnref to a local
      br $l0
    end
  catch
    ...
  end
end
local.get n             ;; retrieve exnref back
rethrow                 ;; rethrow to the caller
```

The previous algorithm placed the nested `try` right before the `call`.
But it is possible that there are stackified instructions before the
call from which the call takes arguments.
```
try
  ...
  i32.const 5
  call @qux  ;; This should throw to the caller!
catch
  ...
end
```

In this case we have to place `try` before those stackified
instructions.
```
block $l0
  try
    ...
    try                 ;; this should go *before* 'i32.const 5'
      i32.const 5
      call @qux
    catch
      local.set n
      br $l0
    end
  catch
    ...
  end
end
local.get n
rethrow
```

We correctly handle this in the first normal `try` placement phase
(`placeTryMarker` function), but failed to handle this in this
`fixUnwindMismatches`.

Reviewers: dschuff

Subscribers: sbc100, jgravelle-google, hiraditya, sunfish, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D77950

4 years agoFix a typo in the error message for an incorrect prototype.
Jean-Luc Brouillet [Mon, 13 Apr 2020 22:40:56 +0000 (15:40 -0700)]
Fix a typo in the error message for an incorrect prototype.

Summary: Cut & paste error had the error message mentionning "}" rather than ")".

Differential Revision: https://reviews.llvm.org/D77625

4 years ago[AVR] Support aliases in non-zero address space
Ayke van Laethem [Sat, 14 Mar 2020 17:52:01 +0000 (18:52 +0100)]
[AVR] Support aliases in non-zero address space

This fixes code like the following on AVR:

void foo(void) {
}
void bar(void) __attribute__((alias("foo")));

Code like this is present in compiler-rt, which I'm trying to build.

Differential Revision: https://reviews.llvm.org/D76182

4 years ago[libunwind] Enable the new libc++ testing format by default
Louis Dionne [Wed, 8 Apr 2020 14:42:56 +0000 (10:42 -0400)]
[libunwind] Enable the new libc++ testing format by default

The new format should be equivalent to the old format, and it is now the
default format when running the libc++ and libc++abi tests. This commit
changes the libunwind tests to use the new format by default too. If
unexpected failures are discovered, it should be fine to revert this
commit until they are addressed.

Also note that it is still possible to use the old format by passing
`--param=use_old_format=True` when running Lit for the time being.

Differential Revision: https://reviews.llvm.org/D77733

4 years agoRemove '<' from test for better yam2obj input consumption
jasonliu [Mon, 13 Apr 2020 21:39:10 +0000 (21:39 +0000)]
Remove '<' from test for better yam2obj input consumption

Address post-commit comment:
https://reviews.llvm.org/D77580#inline-713676

yaml2obj does not record the source filename in the output,
 which may make FileCheck tests brittle sometimes.

4 years ago[libc++] Mark test failing with macos < 10.13 as unsupported
Louis Dionne [Mon, 13 Apr 2020 21:38:40 +0000 (17:38 -0400)]
[libc++] Mark test failing with macos < 10.13 as unsupported

4 years ago[mlir][NFC] Replace mlir/Support/Functional.h with llvm equivalents.
River Riddle [Mon, 13 Apr 2020 21:07:38 +0000 (14:07 -0700)]
[mlir][NFC] Replace mlir/Support/Functional.h with llvm equivalents.

Summary: Functional.h contains many different methods that have a direct, and more efficient, equivalent in LLVM. This revision replaces all usages with the LLVM equivalent, and removes the header. This is part of larger cleanup, pr45513, merging MLIR support facilities into LLVM.

Differential Revision: https://reviews.llvm.org/D78053

4 years ago[libc++] NFC: Remove unused Lit features in the test suite
Louis Dionne [Mon, 13 Apr 2020 20:52:34 +0000 (16:52 -0400)]
[libc++] NFC: Remove unused Lit features in the test suite

The libc++ test suite currently defines several features that are not
used anywhere in the tests, or that are redundant with other features.
For the purpose of simplifying config.py and to ease the bring up of a
new configuration, this commit removes some of these features:

- rename dylib-has-no-filesystem to c++filesystem-disabled, which exists
- rename apple-darwin to just darwin, which is already set
- remove useless setting of libstdc++, which is already set correctly
- remove libcpp-abi-unstable, which is not used anywhere
- remove the glibc-XXX features, which are not used anywhere

4 years ago[CHR] Clean up some code and reduce copying. NFCI.
Benjamin Kramer [Mon, 13 Apr 2020 21:03:03 +0000 (23:03 +0200)]
[CHR] Clean up some code and reduce copying. NFCI.

4 years agoRevert a few unsuccessful attempts at fixing bots.
Nico Weber [Mon, 13 Apr 2020 20:53:06 +0000 (16:53 -0400)]
Revert a few unsuccessful attempts at fixing bots.

I broke bots last week and tried a few things to fix them.
These were attempts that didn't help, so back them back out.

This reverts commit c7aff9a109b611e4954a3055061a8076b4baa385.
This reverts commit 8838d6d3566d940859fd26b20aed4cb57d490988.
This reverts commit e875ba1509955dc4b3512d820edecc0da26fa38d.

4 years agoUse a temporary file, to allow running on read-only file systems
Sterling Augustine [Mon, 13 Apr 2020 20:09:22 +0000 (13:09 -0700)]
Use a temporary file, to allow running on read-only file systems

4 years ago[libc++] NFC: Remove unused method call
Louis Dionne [Mon, 13 Apr 2020 20:50:11 +0000 (16:50 -0400)]
[libc++] NFC: Remove unused method call