Panu Matilainen [Fri, 1 Feb 2008 17:53:04 +0000 (19:53 +0200)]
Ditch the "system" %_topdir, default to ~/rpmbuild instead
- building as root should be discouraged and /usr/src for building stuff
is horribly wrong anyway
Panu Matilainen [Fri, 1 Feb 2008 15:27:22 +0000 (17:27 +0200)]
Don't close GPG/PGP stdin to avoid harmless warning (rhbz#197602)
- patch from rpm5.org
Panu Matilainen [Fri, 1 Feb 2008 11:25:18 +0000 (13:25 +0200)]
Avoid silly fixed size buffer in urlhelper
Panu Matilainen [Fri, 1 Feb 2008 11:00:40 +0000 (13:00 +0200)]
Allocate macro buffers dynamically
- avoids some entirely needless overflow cases
- somewhat similarly to rpm5.org but use heap instead of stack
Panu Matilainen [Fri, 1 Feb 2008 10:11:03 +0000 (12:11 +0200)]
Allocate various macro buffers from heap not stack
Panu Matilainen [Fri, 1 Feb 2008 09:36:13 +0000 (11:36 +0200)]
Define + use MACROBUFSIZ for macro expansion buffer size
- double the buffer size while at it...
Panu Matilainen [Fri, 1 Feb 2008 09:09:13 +0000 (11:09 +0200)]
Macro shell expansion fixes (rhbz#431009)
Panu Matilainen [Wed, 30 Jan 2008 15:20:09 +0000 (17:20 +0200)]
Add rpmtypes to doxygen, with todo reminders..
Panu Matilainen [Wed, 30 Jan 2008 15:05:29 +0000 (17:05 +0200)]
Include spring-cleaning
- put some consistency into include ordering
- everything (apart from bits missed ;) is now ordered like this
1. "system.h"
2. other system includes
3. rpm public headers
4. rpm private headers
5. "debug.h"
Panu Matilainen [Wed, 30 Jan 2008 14:04:40 +0000 (16:04 +0200)]
Use rpmsenseFlags type for dependency flags everywhere (hopefully)
Panu Matilainen [Wed, 30 Jan 2008 12:27:41 +0000 (14:27 +0200)]
Use headerIsSource() instead of doing it manually
Panu Matilainen [Wed, 30 Jan 2008 11:53:51 +0000 (13:53 +0200)]
rpmlib.h mass eviction
- explicitly include what's really needed instead
- document remaining uses
Panu Matilainen [Wed, 30 Jan 2008 11:03:54 +0000 (13:03 +0200)]
Move HGE and related prototypes to header.h
Panu Matilainen [Wed, 30 Jan 2008 11:00:26 +0000 (13:00 +0200)]
Move rpmTagType stuff to rpmtag.h now that they can move
Panu Matilainen [Wed, 30 Jan 2008 10:59:38 +0000 (12:59 +0200)]
Stick rpmCallbackType to rpmtypes too..
Panu Matilainen [Wed, 30 Jan 2008 10:51:09 +0000 (12:51 +0200)]
Add missing system includes
Panu Matilainen [Wed, 30 Jan 2008 10:42:07 +0000 (12:42 +0200)]
Uninline headerFreeData()
Panu Matilainen [Wed, 30 Jan 2008 10:21:59 +0000 (12:21 +0200)]
Stick relocation struct to rpmfi, typedef to rpmtypes...
Panu Matilainen [Wed, 30 Jan 2008 10:20:59 +0000 (12:20 +0200)]
Move FD_t to rpmtypes.h, used all over ..
Panu Matilainen [Wed, 30 Jan 2008 09:55:06 +0000 (11:55 +0200)]
Move rpmRC definition to rpmtypes
- lot of places drag in rpmlib.h just for that...
Panu Matilainen [Wed, 30 Jan 2008 09:51:28 +0000 (11:51 +0200)]
rpmgi.h doesn't need rpmte and rpmts headers, implementation does
Panu Matilainen [Wed, 30 Jan 2008 09:49:25 +0000 (11:49 +0200)]
Remove bunch of unnecessary rpmlib.h includes
- replace with rpmtypes.h where needed
Panu Matilainen [Wed, 30 Jan 2008 09:02:39 +0000 (11:02 +0200)]
Move header and -iterator to rpmtypes
Panu Matilainen [Wed, 30 Jan 2008 08:57:15 +0000 (10:57 +0200)]
Move rpmalKey and rpmal to rpmtypes
Panu Matilainen [Wed, 30 Jan 2008 08:54:04 +0000 (10:54 +0200)]
Move fnpyKey typedef to rpmtypes, its widely used...
Panu Matilainen [Wed, 30 Jan 2008 08:33:32 +0000 (10:33 +0200)]
Move rpmts and other major data typedefs to rpmtypes from rpmlib
Panu Matilainen [Wed, 30 Jan 2008 08:23:47 +0000 (10:23 +0200)]
Add missing c++ ifdefs to rpmtag and rpmtypes headers
Panu Matilainen [Wed, 30 Jan 2008 08:16:14 +0000 (10:16 +0200)]
Move header tagdata types from header.h to rpmtypes.h
Panu Matilainen [Wed, 30 Jan 2008 08:13:09 +0000 (10:13 +0200)]
Add stub rpmtypes.h header stub
- place to stick in common typedefs to untangle header cross-include jungle
Panu Matilainen [Wed, 30 Jan 2008 07:36:02 +0000 (09:36 +0200)]
Remove fts flag API symbols from help messages
- a --help message isn't an API reference...
Panu Matilainen [Wed, 30 Jan 2008 07:24:43 +0000 (09:24 +0200)]
Updated Polish translation (Piotr Drąg)
Panu Matilainen [Mon, 28 Jan 2008 13:10:14 +0000 (15:10 +0200)]
Make rpmbuild -bs and -ts imply --nodeps (rhbz#235507)
- better fix might be creating srpm header early but until then...
Panu Matilainen [Mon, 28 Jan 2008 11:43:32 +0000 (13:43 +0200)]
More missing system includes for size_t & friends
Panu Matilainen [Mon, 28 Jan 2008 09:45:38 +0000 (11:45 +0200)]
Add missing system includes to rpmmacro.h
Panu Matilainen [Mon, 28 Jan 2008 07:20:33 +0000 (09:20 +0200)]
Fix printing of filenames with whitespace in check-files (rhbz#430428)
Panu Matilainen [Fri, 25 Jan 2008 15:33:35 +0000 (17:33 +0200)]
Urgh, add geode to x86_64 secondary arch subst-crack...
Panu Matilainen [Sun, 27 Jan 2008 15:28:32 +0000 (17:28 +0200)]
Document libmagic requirement
Panu Matilainen [Sun, 27 Jan 2008 14:39:40 +0000 (16:39 +0200)]
Rename isCompressed() -> rpmFileIsCompressed() for namespacing
Panu Matilainen [Sun, 27 Jan 2008 14:13:47 +0000 (16:13 +0200)]
Couple of missing doxygen groupings
Panu Matilainen [Sun, 27 Jan 2008 14:11:46 +0000 (16:11 +0200)]
Detect lzma magic if it exists, otherwise dumb check for .lzma filename
- Newer lzma-utils make a magic header in archives, current stable versions
don't. Guessing based on common compression flags used by current lzma
versions is feeble and futile...
Panu Matilainen [Sun, 27 Jan 2008 14:00:40 +0000 (16:00 +0200)]
Use the suffix checker in rpmfc instead of inline defined version
Panu Matilainen [Sun, 27 Jan 2008 14:00:06 +0000 (16:00 +0200)]
Helper function for checking given suffix on path
Panu Matilainen [Fri, 25 Jan 2008 11:54:39 +0000 (13:54 +0200)]
Quote find-debuginfo builddir to avoid whitespace issues
Panu Matilainen [Fri, 25 Jan 2008 10:24:55 +0000 (12:24 +0200)]
Don't reset target when reading included rpmrc's.
Doesn't seem to break anything and fixes rhbz#232429 AFAICT...
Panu Matilainen [Fri, 25 Jan 2008 10:20:56 +0000 (12:20 +0200)]
Hackery to get secondary arch macros included on x86_64 (rhbz#194123)
Panu Matilainen [Fri, 25 Jan 2008 10:14:23 +0000 (12:14 +0200)]
Bandaid patch for truncated error message in russian (mdvbz#31680)
Just up the stupid static reservation "high enuff" for now.
asprintf() would be nice here but it's not at all portable, revisit later.
Panu Matilainen [Fri, 25 Jan 2008 10:01:16 +0000 (12:01 +0200)]
Permit conflicting ghost files
Patch from Pascal Rigaux
Panu Matilainen [Fri, 25 Jan 2008 06:30:32 +0000 (08:30 +0200)]
Print regular provides on build too (mdvbz#36672)
Patch ported from rpm5.org by Pascal Rigaux
Panu Matilainen [Thu, 24 Jan 2008 07:34:33 +0000 (09:34 +0200)]
Missing space in russian translation (mdvbz#36974)
Patch originally from Andrey Borzenkov
Panu Matilainen [Wed, 23 Jan 2008 05:56:51 +0000 (07:56 +0200)]
Make uncompress macros match reality (_ vs __ prefix)
Panu Matilainen [Sat, 19 Jan 2008 09:40:59 +0000 (11:40 +0200)]
Add support for Geode CPU (rhbz#428979)
Patch from Dennis Gilmore
Panu Matilainen [Thu, 10 Jan 2008 11:39:00 +0000 (13:39 +0200)]
Define and use UGIDMAX instead of hardcoded 1024 all over
Panu Matilainen [Thu, 10 Jan 2008 11:35:03 +0000 (13:35 +0200)]
pgpHexStr() returns pointer to static buffer, return const char *
Panu Matilainen [Thu, 10 Jan 2008 09:48:31 +0000 (11:48 +0200)]
And *really* skip the leading % in --define, double duh :)
Panu Matilainen [Thu, 10 Jan 2008 06:44:21 +0000 (08:44 +0200)]
Fix thinko in macroname underscore conversion, duh
Panu Matilainen [Wed, 9 Jan 2008 16:56:34 +0000 (18:56 +0200)]
Document internal vs external BDB usage in INSTALL
Panu Matilainen [Wed, 9 Jan 2008 17:07:20 +0000 (19:07 +0200)]
Drop internal db from dist tarballs
- tarball down to almost 1/4 of earlier size
- check if internal db is present in configure, point to INSTALL if not
- distcheck needs --with-external-db now to have any chance at working
- leaving to hg for now for easy reversal if getting second thoughts ;)
Panu Matilainen [Wed, 9 Jan 2008 15:50:25 +0000 (17:50 +0200)]
Dirty hack to determine BDB .la name automatically
Panu Matilainen [Wed, 9 Jan 2008 09:11:49 +0000 (11:11 +0200)]
Implementation of triggerprein scriptlets.
Ported from rpm5.org work of Jeff Johnson to 4.4.x by Pascal Rigaux,
further adopted to fit HEAD...
Panu Matilainen [Wed, 9 Jan 2008 08:39:55 +0000 (10:39 +0200)]
Permit files with glob characters in *.rpm packages (#147383)
Patch from Alexander Suvorov
Panu Matilainen [Wed, 9 Jan 2008 08:34:08 +0000 (10:34 +0200)]
Avoid access(2) quirks querying symlinks, lstat(2) instead (#60288)
Ported from rpm5.org work of Jeff Johnson
Panu Matilainen [Wed, 9 Jan 2008 08:21:01 +0000 (10:21 +0200)]
Handle spaces in file path arguments correctly (#217258)
Ported from rpm5.org work of Jeff Johnson with some differences:
- place into rpmfileutil instead of rpmgi as it's more generic than just rpmgi
- rename rpmgiEscapeSpaces -> rpmEscapeSpaces
- return char *, not const char * as the return string must be freed by caller
Panu Matilainen [Wed, 9 Jan 2008 07:28:09 +0000 (09:28 +0200)]
Convert '-' to '_' within --define macro names (#124995)
Patch derived from rpm5.org of Jeff Johnson
Panu Matilainen [Wed, 9 Jan 2008 07:22:31 +0000 (09:22 +0200)]
Last 8 bytes of RSA modulus is keyid for V3 pubkeys (#205080)
- ported from rpm5.org work of Jeff Johnson
- minimal fix suitable for 4.4.2.x too, full rpm5.org changes require
api changes which would be ok for HEAD but that's a bigger task...
Panu Matilainen [Mon, 7 Jan 2008 14:09:20 +0000 (16:09 +0200)]
Set a default 0022 umask value always (#83006)
Patch derived from rpm5.org work of Jeff Johnson
Panu Matilainen [Mon, 7 Jan 2008 13:37:43 +0000 (15:37 +0200)]
Print --usage to stderr instead of stdout (rhbz#164021)
Patch derived from rpm5.org work of Jeff Johnson
Panu Matilainen [Mon, 7 Jan 2008 12:48:57 +0000 (14:48 +0200)]
Don't unlink non-temporary file in FSM_UNDO (rhbz#223931)
Ported from rpm5.org work of Jeff Johnson.
Panu Matilainen [Mon, 7 Jan 2008 12:25:24 +0000 (14:25 +0200)]
Fix field-width specifiers when no space between (rhbz#323221)
Ported from rpm5.org work of Jeff Johnson.
Panu Matilainen [Mon, 7 Jan 2008 11:57:10 +0000 (13:57 +0200)]
Handle "use vX.X.X" in perl dependency extraction (rhbz#140597)
Patch by Steven Prichard
Panu Matilainen [Fri, 4 Jan 2008 10:04:49 +0000 (12:04 +0200)]
Saner RPM_FORCEFREE_TYPE definition
Panu Matilainen [Fri, 4 Jan 2008 10:00:51 +0000 (12:00 +0200)]
Remove now useless nested function in debugedit
Panu Matilainen [Thu, 3 Jan 2008 10:37:03 +0000 (12:37 +0200)]
Lose unused pgpMpiHex()
Panu Matilainen [Wed, 2 Jan 2008 15:47:30 +0000 (17:47 +0200)]
Revert rpmfi bits from
01cd03ea8f8a
- nasty breakage from new signedness mismatches..
Panu Matilainen [Wed, 2 Jan 2008 15:02:06 +0000 (17:02 +0200)]
Signedness consistency in rpmfi interface vs internal structures
Panu Matilainen [Wed, 2 Jan 2008 14:18:55 +0000 (16:18 +0200)]
Avoid compressFilelist() stack overflow in pathological cases
- allocate dirNames etc arrays on heap, not stack
- the arrays can be rather large and alloca isn't very friendly when it
fails...
Panu Matilainen [Wed, 2 Jan 2008 13:02:18 +0000 (15:02 +0200)]
Teach (unused) headerFreeTag about RPM_FORCEFREE_TYPE
Panu Matilainen [Wed, 2 Jan 2008 12:44:58 +0000 (14:44 +0200)]
Gah, nss doesn't use size_t for lengths...
Panu Matilainen [Wed, 2 Jan 2008 12:37:16 +0000 (14:37 +0200)]
Assorted int -> size_t string size fixes in build code
Panu Matilainen [Wed, 2 Jan 2008 12:10:25 +0000 (14:10 +0200)]
More assorted int -> size_t uses
Panu Matilainen [Wed, 2 Jan 2008 11:55:16 +0000 (13:55 +0200)]
Assorted int -> size_t corrections for string lengths
Panu Matilainen [Wed, 2 Jan 2008 11:22:26 +0000 (13:22 +0200)]
Use size_t, not int for header format padding args
Panu Matilainen [Wed, 19 Dec 2007 10:05:56 +0000 (12:05 +0200)]
Add rpm_data_t (and _constdata_t) for header data, use everywhere
- consistent, easy to grep for and change...
- bogus consts removed where spotted
Panu Matilainen [Wed, 19 Dec 2007 12:13:34 +0000 (14:13 +0200)]
Const-pedantry here and there...
Panu Matilainen [Wed, 19 Dec 2007 11:19:55 +0000 (13:19 +0200)]
Const pedantry
Panu Matilainen [Wed, 19 Dec 2007 10:49:52 +0000 (12:49 +0200)]
Fix some const issues in macros
Panu Matilainen [Mon, 31 Dec 2007 09:56:06 +0000 (11:56 +0200)]
tgi doesnt need fts private include
Panu Matilainen [Sat, 22 Dec 2007 12:26:56 +0000 (14:26 +0200)]
Fix multi-line macro expansion in last line of spec (mdvbz#27417)
Patch from Pascal Rigaux:
1. creating functions restoreFirstChar(), copyNextLineFromOFI() and
copyNextLineFinish() out of copyNextLine()
2. creating function readLineFromOFI() out of readLine()
3. inline copyNextLine
4. if we can restoreFirstChar, then use it, otherwise read from file
(ie don't read from file when we have a remaining multiline macro in
spec->nextline)
Panu Matilainen [Wed, 19 Dec 2007 16:53:14 +0000 (18:53 +0200)]
Hum, NSS needs to be shut down too
- some ~80 bytes are still leaked apparently from somewhere within nss/nspr
Panu Matilainen [Wed, 19 Dec 2007 07:38:32 +0000 (09:38 +0200)]
Add dumb maintainer snapshot generator make rule
Panu Matilainen [Wed, 19 Dec 2007 07:12:59 +0000 (09:12 +0200)]
Ordering fix (don't use RPMSENSE_PREREQ) from Pascal Rigaux
Panu Matilainen [Wed, 19 Dec 2007 07:01:39 +0000 (09:01 +0200)]
Drop duplicate locale.h check
Panu Matilainen [Tue, 18 Dec 2007 19:33:40 +0000 (21:33 +0200)]
Avoid exiting too early due to nested rpmdbCheckSignals()
Panu Matilainen [Tue, 18 Dec 2007 11:42:42 +0000 (13:42 +0200)]
Update translations
Panu Matilainen [Tue, 18 Dec 2007 11:41:29 +0000 (13:41 +0200)]
Todo-update...
Panu Matilainen [Tue, 18 Dec 2007 10:53:57 +0000 (12:53 +0200)]
Drop bogus const from rpmReadPackageManifest argvptr
- it's malloced and needs freeing by the caller..
Panu Matilainen [Tue, 18 Dec 2007 10:53:16 +0000 (12:53 +0200)]
Cast to silence gcc..
Panu Matilainen [Tue, 18 Dec 2007 10:29:46 +0000 (12:29 +0200)]
One leftover reloc constfree..
Panu Matilainen [Tue, 18 Dec 2007 10:08:13 +0000 (12:08 +0200)]
Remove bunch of bogus cli-related consts...
Panu Matilainen [Tue, 18 Dec 2007 10:07:48 +0000 (12:07 +0200)]
Use constfree on relocations for now
- they're totally exposed all they way to rpmqv.c.. eww
Panu Matilainen [Tue, 18 Dec 2007 09:56:54 +0000 (11:56 +0200)]
Remove bogus const from rpmInstallSource*() parameters
- spec and cookie are malloced and need to be freed by caller
- unconst various other rpmQVK arguments & friends, no api exists to
free them so caller needs to handle anyway