skia.committer@gmail.com [Fri, 18 Jan 2013 07:07:28 +0000 (07:07 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@7268
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Thu, 17 Jan 2013 22:07:50 +0000 (22:07 +0000)]
change SkPath::dump() to output compilable code snippet, to aid in debugging.
git-svn-id: http://skia.googlecode.com/svn/trunk@7267
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Thu, 17 Jan 2013 21:02:47 +0000 (21:02 +0000)]
shape ops work in progress
mostly working on cubic/cubic intersect
git-svn-id: http://skia.googlecode.com/svn/trunk@7266
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Thu, 17 Jan 2013 20:19:13 +0000 (20:19 +0000)]
Don't die when there are no fonts available.
https://codereview.appspot.com/7147044/
git-svn-id: http://skia.googlecode.com/svn/trunk@7265
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Thu, 17 Jan 2013 19:51:41 +0000 (19:51 +0000)]
Added new bench to test out 1xN BitmapProcShaders
https://codereview.appspot.com/7160043/
git-svn-id: http://skia.googlecode.com/svn/trunk@7264
2bbb7eff-a529-9590-31e7-
b0007b416f81
rmistry@google.com [Thu, 17 Jan 2013 18:43:29 +0000 (18:43 +0000)]
All skp files in Google Storage have been updated
git-svn-id: http://skia.googlecode.com/svn/trunk@7261
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Thu, 17 Jan 2013 18:39:59 +0000 (18:39 +0000)]
Fix call to INHERITED::isEqual in GrRadial2Gradient. Should be INHERITED::onIsEqual.
git-svn-id: http://skia.googlecode.com/svn/trunk@7260
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Thu, 17 Jan 2013 17:54:28 +0000 (17:54 +0000)]
Reapply r7198 with Mac/Windows fixes
BUG=https://code.google.com/p/skia/issues/detail?id=1067
Review URL: https://codereview.appspot.com/7138056
git-svn-id: http://skia.googlecode.com/svn/trunk@7258
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Thu, 17 Jan 2013 16:50:08 +0000 (16:50 +0000)]
Remove default implementation of GrEffect::isEqual. Make GrSingleTextureEffect abstract.
Review URL: https://codereview.appspot.com/7142049
git-svn-id: http://skia.googlecode.com/svn/trunk@7254
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Thu, 17 Jan 2013 16:30:56 +0000 (16:30 +0000)]
Make navigating the picture view in debugger more functional.
https://codereview.appspot.com/7134049/
git-svn-id: http://skia.googlecode.com/svn/trunk@7253
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Thu, 17 Jan 2013 16:07:04 +0000 (16:07 +0000)]
Fix debugger handling of clip rrects
https://codereview.appspot.com/7135053/
git-svn-id: http://skia.googlecode.com/svn/trunk@7252
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Thu, 17 Jan 2013 16:01:19 +0000 (16:01 +0000)]
cherry-pick from 7241: speed-up matrix44::setconcat when both inputs are
scale+translate by inlining the zero-assignments, rather than calling sk_bzero.
bench: matrix44_setconcat 2x faster
git-svn-id: http://skia.googlecode.com/svn/trunk@7251
2bbb7eff-a529-9590-31e7-
b0007b416f81
rmistry@google.com [Thu, 17 Jan 2013 14:50:59 +0000 (14:50 +0000)]
Adding CheckChangeHasOnlyOneEol to upload and commit presubmit checks
Review URL: https://codereview.appspot.com/7151043
git-svn-id: http://skia.googlecode.com/svn/trunk@7247
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Thu, 17 Jan 2013 14:39:20 +0000 (14:39 +0000)]
Switch debugger profiling stubs over to being guarded by SK_DEVELOPER
https://codereview.appspot.com/7134053/
git-svn-id: http://skia.googlecode.com/svn/trunk@7246
2bbb7eff-a529-9590-31e7-
b0007b416f81
tomhudson@google.com [Thu, 17 Jan 2013 13:29:35 +0000 (13:29 +0000)]
Revert r7241, which broke tests on most platforms.
git-svn-id: http://skia.googlecode.com/svn/trunk@7245
2bbb7eff-a529-9590-31e7-
b0007b416f81
djsollen@google.com [Thu, 17 Jan 2013 13:20:01 +0000 (13:20 +0000)]
Remove unused debugger code from SampleApp.
Review URL: https://codereview.appspot.com/7133049
git-svn-id: http://skia.googlecode.com/svn/trunk@7244
2bbb7eff-a529-9590-31e7-
b0007b416f81
rmistry@google.com [Thu, 17 Jan 2013 12:55:34 +0000 (12:55 +0000)]
Top-level presubmit script for Skia trunk that checks https://skia-tree-status.appspot.com/banner-status?format=json before a CL is committed.
gcl and git-cl will check for and run the presubmit script before you upload and/or commit your changes.
Review URL: https://codereview.appspot.com/7138046
git-svn-id: http://skia.googlecode.com/svn/trunk@7242
2bbb7eff-a529-9590-31e7-
b0007b416f81
tomhudson@google.com [Thu, 17 Jan 2013 12:17:00 +0000 (12:17 +0000)]
Add SSE2 multiplication for SkMatrix44 on some platforms.
Original author whunt@chromium.org.
https://codereview.appspot.com/7058077/
git-svn-id: http://skia.googlecode.com/svn/trunk@7241
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Thu, 17 Jan 2013 07:06:06 +0000 (07:06 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@7240
2bbb7eff-a529-9590-31e7-
b0007b416f81
junov@chromium.org [Wed, 16 Jan 2013 20:12:22 +0000 (20:12 +0000)]
Fixing expression logic from r7237/r7234
TBR=borenet
git-svn-id: http://skia.googlecode.com/svn/trunk@7238
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Wed, 16 Jan 2013 19:57:02 +0000 (19:57 +0000)]
Compiler warning fixes for r7235
git-svn-id: http://skia.googlecode.com/svn/trunk@7237
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Wed, 16 Jan 2013 19:24:15 +0000 (19:24 +0000)]
fix int->scalar warnings
git-svn-id: http://skia.googlecode.com/svn/trunk@7236
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Wed, 16 Jan 2013 18:54:15 +0000 (18:54 +0000)]
add gm for comparing drawSprite and drawBitmap
git-svn-id: http://skia.googlecode.com/svn/trunk@7235
2bbb7eff-a529-9590-31e7-
b0007b416f81
junov@chromium.org [Wed, 16 Jan 2013 18:43:36 +0000 (18:43 +0000)]
Turn on the kUsePathBoundsForClip_RecordingFlag in bench, gm and tools that use class PictureRenderer
Chrome uses this flag for recording to skpicture in order to improve performance.
Therefore, skai benchmarks should run with this flag enabled, and we need
gm and render_pictures test coverage to validate it. In gm, the vanilla
SkPicture test step will still run without the flag to ensure that case still gets test
coverage, while the SkPicture test steps that use rtree and tileGrid will now run with
the flag enabled.
Review URL: https://codereview.appspot.com/7111043
git-svn-id: http://skia.googlecode.com/svn/trunk@7234
2bbb7eff-a529-9590-31e7-
b0007b416f81
edisonn@google.com [Wed, 16 Jan 2013 18:18:48 +0000 (18:18 +0000)]
Add option to ignore small pixel diffs for --validate. By default, right
now we will default to max diff of 256, which means that for now we
report all pixels that are not as expected and we do not error out.
Ideally we will decrease the value of max diff to something that does
not have visual impact, e.g. 10, then we will report small changes with
the intensity under 10, but we will error out for anything larger.
Review URL: https://codereview.appspot.com/7137046
git-svn-id: http://skia.googlecode.com/svn/trunk@7232
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Wed, 16 Jan 2013 16:28:58 +0000 (16:28 +0000)]
mark default constructor for SkMatrix44 as deprecated, since it calls setIdentity()
and we have explicit (enum-based) constructors to distinguish that from uninitialized.
git-svn-id: http://skia.googlecode.com/svn/trunk@7228
2bbb7eff-a529-9590-31e7-
b0007b416f81
junov@chromium.org [Wed, 16 Jan 2013 16:07:39 +0000 (16:07 +0000)]
Adding SK_API to SkTileGridPicture class declaration
Unreviewed
git-svn-id: http://skia.googlecode.com/svn/trunk@7227
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Wed, 16 Jan 2013 15:51:47 +0000 (15:51 +0000)]
Change some function/vars from EffectPtr to EffectRef to reflect GrEffectPtr->GrEffectRef renaming.
git-svn-id: http://skia.googlecode.com/svn/trunk@7226
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Wed, 16 Jan 2013 15:38:37 +0000 (15:38 +0000)]
Fix no-static-init (android) build.
git-svn-id: http://skia.googlecode.com/svn/trunk@7225
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Wed, 16 Jan 2013 15:31:06 +0000 (15:31 +0000)]
Fix GPU-less build.
git-svn-id: http://skia.googlecode.com/svn/trunk@7224
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Wed, 16 Jan 2013 15:25:55 +0000 (15:25 +0000)]
Fix missing "class" in friend decls in GrEffect.h
git-svn-id: http://skia.googlecode.com/svn/trunk@7223
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Wed, 16 Jan 2013 15:16:18 +0000 (15:16 +0000)]
Wrap GrEffects in GrEffectPtr.
This is the first step towards automatic recycling of scratch resouces in the cache via ref-cnts.
R=robertphillips@google.com
Review URL: https://codereview.appspot.com/7092061
git-svn-id: http://skia.googlecode.com/svn/trunk@7222
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Wed, 16 Jan 2013 15:15:24 +0000 (15:15 +0000)]
remove legacy build-flags for drawBitmapRect
add SkRect::isetWH()
Review URL: https://codereview.appspot.com/7127045
git-svn-id: http://skia.googlecode.com/svn/trunk@7221
2bbb7eff-a529-9590-31e7-
b0007b416f81
edisonn@google.com [Wed, 16 Jan 2013 15:03:24 +0000 (15:03 +0000)]
revert change 7218
git-svn-id: http://skia.googlecode.com/svn/trunk@7220
2bbb7eff-a529-9590-31e7-
b0007b416f81
edisonn@google.com [Wed, 16 Jan 2013 14:47:06 +0000 (14:47 +0000)]
Add option to ignore small pixel diffs for --validate. By default, right now we will default to max diff of 256, which means that for now we report all pixels that are not as expected and we do not error out. Ideally we will decrease the value of max diff to something that does not have visual impact, e.g. 10, then we will report small changes with the intensity under 10, but we will error out for anything larger.
Review URL: https://codereview.appspot.com/7139043
git-svn-id: http://skia.googlecode.com/svn/trunk@7218
2bbb7eff-a529-9590-31e7-
b0007b416f81
rmistry@google.com [Wed, 16 Jan 2013 13:50:33 +0000 (13:50 +0000)]
Whitespace change to trigger doxygen upload
git-svn-id: http://skia.googlecode.com/svn/trunk@7217
2bbb7eff-a529-9590-31e7-
b0007b416f81
borenet@google.com [Wed, 16 Jan 2013 13:25:45 +0000 (13:25 +0000)]
Whitespace change to trigger uploads after skia-autogen reset
git-svn-id: http://skia.googlecode.com/svn/trunk@7216
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Wed, 16 Jan 2013 07:05:56 +0000 (07:05 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@7215
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Wed, 16 Jan 2013 04:19:01 +0000 (04:19 +0000)]
better quick fix for GM self-test: ignore instance-counting lines in Debug output
BUG=http://code.google.com/p/skia/issues/detail?id=1068
Review URL: https://codereview.appspot.com/7127044
git-svn-id: http://skia.googlecode.com/svn/trunk@7214
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Wed, 16 Jan 2013 03:34:15 +0000 (03:34 +0000)]
quick fix for GM self-test failures after r7206
BUG=http://code.google.com/p/skia/issues/detail?id=1068
Review URL: https://codereview.appspot.com/7131043
git-svn-id: http://skia.googlecode.com/svn/trunk@7213
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 15 Jan 2013 21:54:27 +0000 (21:54 +0000)]
Add VALIDATE_FAILURE_IS_A_TOOL_FAILURE to specify whether a failure in validation
means the tool should return failure or not. For now it is not defined, which
means any failed pixels are still reported to stdout, but the tool does not
return an error, allowing the bots to go green (until we can fix these failures).
Review URL: https://codereview.appspot.com/7105056
git-svn-id: http://skia.googlecode.com/svn/trunk@7211
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Tue, 15 Jan 2013 20:58:17 +0000 (20:58 +0000)]
Fix busted texture coords in GrGLBlendEffect.
Review URL: https://codereview.appspot.com/7095062
git-svn-id: http://skia.googlecode.com/svn/trunk@7209
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 15 Jan 2013 20:57:45 +0000 (20:57 +0000)]
Have drawBitmapRectToRect devolve to drawBitmap if it can (to avoid creating
a bitmap-shader, which is slower when the matrix is nearly translate-only).
SK_IGNORE_DRAWBITMAPRECT_AS_DRAWBITMAP will disable this if needed.
Review URL: https://codereview.appspot.com/7100058
git-svn-id: http://skia.googlecode.com/svn/trunk@7208
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Tue, 15 Jan 2013 20:37:04 +0000 (20:37 +0000)]
Re-enable inst counting in debug builds.
R=robertphillips@google.com
Review URL: https://codereview.appspot.com/7098066
git-svn-id: http://skia.googlecode.com/svn/trunk@7206
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 15 Jan 2013 20:34:54 +0000 (20:34 +0000)]
add LF at end of file
git-svn-id: http://skia.googlecode.com/svn/trunk@7205
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 15 Jan 2013 20:26:59 +0000 (20:26 +0000)]
add LF at end of file to fix warning
git-svn-id: http://skia.googlecode.com/svn/trunk@7204
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Tue, 15 Jan 2013 20:24:03 +0000 (20:24 +0000)]
Revert r7198 until I can fix https://code.google.com/p/skia/issues/detail?id=1067
Review URL: https://codereview.appspot.com/7124043
git-svn-id: http://skia.googlecode.com/svn/trunk@7203
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 15 Jan 2013 20:21:19 +0000 (20:21 +0000)]
add benches for drawBitmapRectToRect with slight scale/translate
git-svn-id: http://skia.googlecode.com/svn/trunk@7202
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Tue, 15 Jan 2013 20:17:47 +0000 (20:17 +0000)]
Added print out of SkShader information to debugger
https://codereview.appspot.com/7105045/
git-svn-id: http://skia.googlecode.com/svn/trunk@7201
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Tue, 15 Jan 2013 19:10:16 +0000 (19:10 +0000)]
gm: use new Expectations struct instead of comparison bitmaps
Review URL: https://codereview.appspot.com/7088044
git-svn-id: http://skia.googlecode.com/svn/trunk@7198
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Tue, 15 Jan 2013 18:29:41 +0000 (18:29 +0000)]
Update gm self-test results to expect new runtime config debug message
git-svn-id: http://skia.googlecode.com/svn/trunk@7197
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Tue, 15 Jan 2013 17:16:51 +0000 (17:16 +0000)]
Separate our jsoncpp dependency from Chromium's jsoncpp overrides.
BUG=https://code.google.com/p/skia/issues/detail?id=909
Review URL: https://codereview.appspot.com/7098047
git-svn-id: http://skia.googlecode.com/svn/trunk@7187
2bbb7eff-a529-9590-31e7-
b0007b416f81
sugoi@google.com [Tue, 15 Jan 2013 16:35:31 +0000 (16:35 +0000)]
Unreviewed mac build fix : Removing unused variable
git-svn-id: http://skia.googlecode.com/svn/trunk@7186
2bbb7eff-a529-9590-31e7-
b0007b416f81
sugoi@google.com [Tue, 15 Jan 2013 15:59:45 +0000 (15:59 +0000)]
Added missing include in non GPU case.
Review URL: https://codereview.appspot.com/7093067
git-svn-id: http://skia.googlecode.com/svn/trunk@7185
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 15 Jan 2013 15:51:59 +0000 (15:51 +0000)]
Fix bug in cubic-clipper (SkEdgeClipper). When we chop the cubic on Top/Bottom
of the cliprect, we (correctly) clamp the Y coordinate of the control-point
right next to the on-curve point that was chopped (this ensures we don't go
slightly outside of the clip-rect due to imperfect T value calculation). However,
the code was also clamping the other control-point as well, resulting in warping
the cubic, which could sometimes force it outside of the clip.
The fix is to just remove the line of code that clampped the 2nd control-point.
unittest added to reproduce a test cubic that triggered an assert, due to the
cubic being outside of the cliprect. The test (w/o the fix) will assert in
a SK_DEBUG build.
Review URL: https://codereview.appspot.com/7100056
git-svn-id: http://skia.googlecode.com/svn/trunk@7184
2bbb7eff-a529-9590-31e7-
b0007b416f81
borenet@google.com [Tue, 15 Jan 2013 15:50:42 +0000 (15:50 +0000)]
Turn off timeIndividualTiles
The parser isn't working properly.
Review URL: https://codereview.appspot.com/7100057
git-svn-id: http://skia.googlecode.com/svn/trunk@7183
2bbb7eff-a529-9590-31e7-
b0007b416f81
sugoi@google.com [Tue, 15 Jan 2013 15:40:19 +0000 (15:40 +0000)]
Implementation of the displacement effect (both CPU and GPU)
TEST=Added new GM called "displacement"
Review URL: https://codereview.appspot.com/7058075
git-svn-id: http://skia.googlecode.com/svn/trunk@7182
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 15 Jan 2013 14:54:00 +0000 (14:54 +0000)]
To support alignment pragmas (for speed), we need to relax assumptions about
our sizeof. So rewrite operator= and copy-constructor to just copy individual
fields.
Review URL: https://codereview.appspot.com/7098063
git-svn-id: http://skia.googlecode.com/svn/trunk@7181
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Tue, 15 Jan 2013 12:53:31 +0000 (12:53 +0000)]
dashing asPoints could draw excessively long first dash
https://codereview.appspot.com/7098054/
Will require rebaselining of dashing gm.
git-svn-id: http://skia.googlecode.com/svn/trunk@7177
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Tue, 15 Jan 2013 12:19:31 +0000 (12:19 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@7176
2bbb7eff-a529-9590-31e7-
b0007b416f81
mike@reedtribe.org [Tue, 15 Jan 2013 03:28:22 +0000 (03:28 +0000)]
call endContext() if we have to return false from setContext(), to keep the
debugging fInSetContext flag up-to-date.
git-svn-id: http://skia.googlecode.com/svn/trunk@7175
2bbb7eff-a529-9590-31e7-
b0007b416f81
humper@google.com [Tue, 15 Jan 2013 03:03:38 +0000 (03:03 +0000)]
fix warning on linux
BUG=
Review URL: https://codereview.appspot.com/7101058
git-svn-id: http://skia.googlecode.com/svn/trunk@7174
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Tue, 15 Jan 2013 02:01:40 +0000 (02:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@7173
2bbb7eff-a529-9590-31e7-
b0007b416f81
humper@google.com [Mon, 14 Jan 2013 22:09:54 +0000 (22:09 +0000)]
fix all the false --> NULL issues in the gradient code
BUG=
Review URL: https://codereview.appspot.com/7095056
git-svn-id: http://skia.googlecode.com/svn/trunk@7170
2bbb7eff-a529-9590-31e7-
b0007b416f81
humper@google.com [Mon, 14 Jan 2013 22:01:14 +0000 (22:01 +0000)]
remove namespace qualifier for feof; it's making android unhappy
BUG=
Review URL: https://codereview.appspot.com/7106048
git-svn-id: http://skia.googlecode.com/svn/trunk@7169
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Mon, 14 Jan 2013 21:53:45 +0000 (21:53 +0000)]
Fix a problem in the matrix convolution image filter exposed by https://code.google.com/p/skia/source/detail?r=7152: when offsetting texture coordinates in a GrEffect, take the origin of the source bitmap origin into account, and flip Y coordinates when we need to.
NOTE: this will cause the matrixconvolution GM's to need to be rebaselined (again!).
Review URL: https://codereview.appspot.com/7086054
git-svn-id: http://skia.googlecode.com/svn/trunk@7168
2bbb7eff-a529-9590-31e7-
b0007b416f81
humper@google.com [Mon, 14 Jan 2013 21:01:28 +0000 (21:01 +0000)]
another false --> NULL return fix
false --> NULL for failure return
BUG=
Review URL: https://codereview.appspot.com/7100052
git-svn-id: http://skia.googlecode.com/svn/trunk@7167
2bbb7eff-a529-9590-31e7-
b0007b416f81
humper@google.com [Mon, 14 Jan 2013 20:17:04 +0000 (20:17 +0000)]
false --> NULL for failure return
BUG=
Review URL: https://codereview.appspot.com/7096058
git-svn-id: http://skia.googlecode.com/svn/trunk@7165
2bbb7eff-a529-9590-31e7-
b0007b416f81
humper@google.com [Mon, 14 Jan 2013 20:11:00 +0000 (20:11 +0000)]
move template specializations to inline functions in the header to make windows happy again
BUG=
Review URL: https://codereview.appspot.com/7099053
git-svn-id: http://skia.googlecode.com/svn/trunk@7164
2bbb7eff-a529-9590-31e7-
b0007b416f81
humper@google.com [Mon, 14 Jan 2013 19:42:08 +0000 (19:42 +0000)]
replace getline with fgets for portability
BUG=
Review URL: https://codereview.appspot.com/7085058
git-svn-id: http://skia.googlecode.com/svn/trunk@7163
2bbb7eff-a529-9590-31e7-
b0007b416f81
humper@google.com [Mon, 14 Jan 2013 19:20:28 +0000 (19:20 +0000)]
remove dynamic_cast because rtti is disabled on some platforms (but not all??)
BUG=
Review URL: https://codereview.appspot.com/7102056
git-svn-id: http://skia.googlecode.com/svn/trunk@7161
2bbb7eff-a529-9590-31e7-
b0007b416f81
humper@google.com [Mon, 14 Jan 2013 19:03:46 +0000 (19:03 +0000)]
fix gcc build
BUG=
Review URL: https://codereview.appspot.com/7095055
git-svn-id: http://skia.googlecode.com/svn/trunk@7160
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Mon, 14 Jan 2013 19:03:20 +0000 (19:03 +0000)]
Remove SK_DRAW_POS_TEXT_IGNORE_SUBPIXEL_LEFT_ALIGN_FIX.
https://codereview.appspot.com/7070073/
git-svn-id: http://skia.googlecode.com/svn/trunk@7159
2bbb7eff-a529-9590-31e7-
b0007b416f81
humper@google.com [Mon, 14 Jan 2013 18:49:19 +0000 (18:49 +0000)]
Runtime configuration system for skia. This will allow developers to control settings at launch time without relying on compile-time flags or recompilation. It can be used to turn features on and off, as well as to control numeric quantities to 'tune' algorithms. Once I make sure it's working across all platforms I'll send out a quick tutorial on its use.
Review URL: https://codereview.appspot.com/7098051
git-svn-id: http://skia.googlecode.com/svn/trunk@7158
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Mon, 14 Jan 2013 18:25:55 +0000 (18:25 +0000)]
Make SkScalerContextRec::getMatrixFrom2x2 more direct.
https://codereview.appspot.com/7070072/
git-svn-id: http://skia.googlecode.com/svn/trunk@7157
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Mon, 14 Jan 2013 18:10:08 +0000 (18:10 +0000)]
Fix uninitialized memory issue
https://codereview.appspot.com/7085055/
git-svn-id: http://skia.googlecode.com/svn/trunk@7156
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Mon, 14 Jan 2013 17:40:15 +0000 (17:40 +0000)]
Change SkAutoTUnref usage
https://codereview.appspot.com/7094054/
git-svn-id: http://skia.googlecode.com/svn/trunk@7155
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Mon, 14 Jan 2013 17:07:22 +0000 (17:07 +0000)]
Fix debug build after r7153 (removed param referenced in assertion)
git-svn-id: http://skia.googlecode.com/svn/trunk@7154
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Mon, 14 Jan 2013 16:46:26 +0000 (16:46 +0000)]
Change signature of SkShader::asNewEffect(), implement for SkBitmapProcShader.
Review URL: https://codereview.appspot.com/7086051
git-svn-id: http://skia.googlecode.com/svn/trunk@7153
2bbb7eff-a529-9590-31e7-
b0007b416f81
junov@chromium.org [Mon, 14 Jan 2013 16:27:50 +0000 (16:27 +0000)]
Changing imageFilter GM tests to use drawBitmap instead of drawSprite
The motivation is be able to test the filters with scaled SkPicture playback in isolation from the issues that surround usage of drawSprite
Review URL: https://codereview.appspot.com/7060071
git-svn-id: http://skia.googlecode.com/svn/trunk@7152
2bbb7eff-a529-9590-31e7-
b0007b416f81
digit@google.com [Mon, 14 Jan 2013 14:58:22 +0000 (14:58 +0000)]
Use the NDK's cpu-features library when building skia for Chromium/Android.
This patch ensures that when Skia is built for Chromium, it will
always use the Android NDK's cpu-features helper library to detect
NEON at runtime.
This is needed because sandboxed Chromium renderer processes cannot
access /proc, and the probing performed in SkUtilsArm.cpp will never
work. As such, the NEON code paths will never be used even when the
device supports them.
Chromium has special code that ensures that the browser process
passes the CPU features flags to every renderer process, but
Skia needs to use android_getCpuFeatures() to get them.
See http://crbug.com/164154 for full details.
Review URL: https://codereview.appspot.com/7102045
git-svn-id: http://skia.googlecode.com/svn/trunk@7149
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Mon, 14 Jan 2013 14:36:40 +0000 (14:36 +0000)]
Fix typo bug caught by mac warn-as-error (= should have been &=).
git-svn-id: http://skia.googlecode.com/svn/trunk@7148
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Fri, 11 Jan 2013 22:24:04 +0000 (22:24 +0000)]
Implement getConstantColorComponents() for matrix convolution.
R=senorblanco@chromium.org
Review URL: https://codereview.appspot.com/7092047
git-svn-id: http://skia.googlecode.com/svn/trunk@7146
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Fri, 11 Jan 2013 21:08:55 +0000 (21:08 +0000)]
Add GrEffect::updateKnownColorComponents(). It is used to determine whether the output of an effect has a constant output value for r,g,b, or a.
Review URL: https://codereview.appspot.com/7064057
git-svn-id: http://skia.googlecode.com/svn/trunk@7144
2bbb7eff-a529-9590-31e7-
b0007b416f81
junov@chromium.org [Fri, 11 Jan 2013 21:04:40 +0000 (21:04 +0000)]
Adding commandline option to gm to make it write image results for tests that fails due to pixel mismatches.
Review URL: https://codereview.appspot.com/7100043
git-svn-id: http://skia.googlecode.com/svn/trunk@7143
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Fri, 11 Jan 2013 20:54:44 +0000 (20:54 +0000)]
Fix leaks in blurrect benchs and gm.
Review URL: https://codereview.appspot.com/7071060
git-svn-id: http://skia.googlecode.com/svn/trunk@7142
2bbb7eff-a529-9590-31e7-
b0007b416f81
borenet@google.com [Fri, 11 Jan 2013 20:45:24 +0000 (20:45 +0000)]
Enable per-tile logging in bench_pictures
- Modify bench_pictures buildstep to translate "key: True" --> "--key" rather
than requiring "key: value" --> "--key value"
- Add whacky TileArgs helper which includes "timeIndividualTiles: True"
Review URL: https://codereview.appspot.com/7092046
git-svn-id: http://skia.googlecode.com/svn/trunk@7141
2bbb7eff-a529-9590-31e7-
b0007b416f81
edisonn@google.com [Fri, 11 Jan 2013 20:30:41 +0000 (20:30 +0000)]
Add option to render PDFs to memory only.
Review URL: https://codereview.appspot.com/7097045
git-svn-id: http://skia.googlecode.com/svn/trunk@7140
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Fri, 11 Jan 2013 20:02:32 +0000 (20:02 +0000)]
SkImageDecoder_WIC should work on Win7 with Win8 SDK.
https://codereview.appspot.com/7099044/
git-svn-id: http://skia.googlecode.com/svn/trunk@7139
2bbb7eff-a529-9590-31e7-
b0007b416f81
edisonn@google.com [Fri, 11 Jan 2013 16:08:07 +0000 (16:08 +0000)]
Fix typo, report in validate diff teh value of the pixel, not the address of the pixel.
git-svn-id: http://skia.googlecode.com/svn/trunk@7135
2bbb7eff-a529-9590-31e7-
b0007b416f81
rmistry@google.com [Fri, 11 Jan 2013 14:19:52 +0000 (14:19 +0000)]
Rebaselined webpage image GMs for ['base-macmini'] on Google Storage.
git-svn-id: http://skia.googlecode.com/svn/trunk@7130
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Fri, 11 Jan 2013 13:54:30 +0000 (13:54 +0000)]
Make GrEffect::textureAccess non-virtual. Require subclasses to append their GrTAs.
Review URL: https://codereview.appspot.com/7062063
git-svn-id: http://skia.googlecode.com/svn/trunk@7129
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Fri, 11 Jan 2013 13:54:21 +0000 (13:54 +0000)]
Remove non-destructive playback from GrIODB.
Review URL: https://codereview.appspot.com/7057070
git-svn-id: http://skia.googlecode.com/svn/trunk@7128
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Fri, 11 Jan 2013 02:01:25 +0000 (02:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@7127
2bbb7eff-a529-9590-31e7-
b0007b416f81
rmistry@google.com [Fri, 11 Jan 2013 01:42:39 +0000 (01:42 +0000)]
Whitespace change to trigger rebuilds
git-svn-id: http://skia.googlecode.com/svn/trunk@7126
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Thu, 10 Jan 2013 19:55:18 +0000 (19:55 +0000)]
Rename onFilterImageGPU to filterImageGPU(), to match skia convention. No change in functionality.
(Note that this does mean that clients must override onFilterImage() to implement the raster path, but filterImageGPU() to implement the GPU path.)
Review URL: https://codereview.appspot.com/7058078
git-svn-id: http://skia.googlecode.com/svn/trunk@7123
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Thu, 10 Jan 2013 18:56:18 +0000 (18:56 +0000)]
DirectWrite generatePath must transform the path by the current matrix.
https://codereview.appspot.com/7061061/
This will require at least the shadertext2 gm for DirectWrite to be rebaselined.
git-svn-id: http://skia.googlecode.com/svn/trunk@7121
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Thu, 10 Jan 2013 18:54:11 +0000 (18:54 +0000)]
Add display of more SkPaint fields in Debugger
https://codereview.appspot.com/7060063/
git-svn-id: http://skia.googlecode.com/svn/trunk@7120
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Thu, 10 Jan 2013 17:11:27 +0000 (17:11 +0000)]
gm: if no readPath is given, report all tests as "missing reference image" instead of "passed"
Review URL: https://codereview.appspot.com/7070066
git-svn-id: http://skia.googlecode.com/svn/trunk@7119
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Thu, 10 Jan 2013 16:58:02 +0000 (16:58 +0000)]
Fix assertion caused by change in 7117.
SkRect::intersect returns false if either rectange is empty.
SkCanvas::quickReject returns true if an empty rectange is entirely contained within the clip bounds.
git-svn-id: http://skia.googlecode.com/svn/trunk@7118
2bbb7eff-a529-9590-31e7-
b0007b416f81