lu_zero [Sat, 17 Nov 2007 17:32:16 +0000 (17:32 +0000)]
address 73718 from David Ward
svn path=/trunk/vorbis/; revision=14172
lu_zero [Sat, 17 Nov 2007 17:14:57 +0000 (17:14 +0000)]
Partially addressing issues pointed in comment 73639 by Magnus Westerlund
svn path=/trunk/vorbis/; revision=14171
lu_zero [Sat, 17 Nov 2007 15:27:52 +0000 (15:27 +0000)]
Update reference to vorbis spec, to partially address lars.eggert@nokia.com comment
svn path=/trunk/vorbis/; revision=14170
ivo [Sat, 17 Nov 2007 15:27:32 +0000 (15:27 +0000)]
Erik de Castro Lopo's patch to add -Wdeclaration-after-statement. Closes ticket #1232
svn path=/trunk/vorbis/; revision=14169
lu_zero [Tue, 6 Nov 2007 08:39:53 +0000 (08:39 +0000)]
address comment 73637 from Magnus Westerlund
svn path=/trunk/vorbis/; revision=14104
Ralph Giles [Sat, 27 Oct 2007 17:45:51 +0000 (17:45 +0000)]
Add the updated RTP draft to the distribution.
svn path=/trunk/vorbis/; revision=14056
lu_zero [Sat, 27 Oct 2007 15:25:19 +0000 (15:25 +0000)]
fixes addressing Spencer Dawkins <spencer@mcsr-labs.org> comments
svn path=/trunk/vorbis/; revision=14055
lu_zero [Fri, 26 Oct 2007 20:21:13 +0000 (20:21 +0000)]
Many fixes suggested by Alfred <ah@tr-sys.de>
svn path=/trunk/vorbis/; revision=14054
erikd [Sat, 1 Sep 2007 04:26:27 +0000 (04:26 +0000)]
test/write_read.c : Move delaration before first statement.
svn path=/trunk/vorbis/; revision=13685
erikd [Sat, 1 Sep 2007 03:17:21 +0000 (03:17 +0000)]
Fix compile warnings in recently re-enabled test code.
svn path=/trunk/vorbis/; revision=13684
Ralph Giles [Fri, 31 Aug 2007 03:16:30 +0000 (03:16 +0000)]
Hook up the libvorbis self test code so it is run by automake's 'check'
target. This only enables the sharedbook.c self test, as the codebook.c
self test has bit rotted.
Unfortunately the doc stuff scrolls the results off the screen, but
given the trouble we've had with the doc build in the past, I'm
loath to place it before the code.
svn path=/trunk/vorbis/; revision=13666
Monty [Thu, 30 Aug 2007 02:40:29 +0000 (02:40 +0000)]
Fix to bug #1229
svn path=/trunk/vorbis/; revision=13657
Monty [Wed, 29 Aug 2007 18:43:39 +0000 (18:43 +0000)]
Removing erikd's 'test harness' from Makefile.am as it breaks the build.
Not reverting r13652 entirely-- yet.
svn path=/trunk/vorbis/; revision=13656
erikd [Wed, 29 Aug 2007 11:42:06 +0000 (11:42 +0000)]
Add the bare bones of a test suite.
svn path=/trunk/vorbis/; revision=13652
Monty [Wed, 29 Aug 2007 11:25:58 +0000 (11:25 +0000)]
One more patch to bug #300
svn path=/trunk/vorbis/; revision=13651
Monty [Tue, 28 Aug 2007 18:25:49 +0000 (18:25 +0000)]
Bug #300 was not completely killed; a setting for uncoupled modes in
setup_22.h got missed.
svn path=/trunk/vorbis/; revision=13644
Monty [Tue, 28 Aug 2007 17:45:00 +0000 (17:45 +0000)]
Erikd: take care that added comments with detailed explanations are
actually correct. The default callbacks in vorbisfile.h are not an
attempt to preserve ABI, they're due to peculiarities of Windows
linking strategies.
svn path=/trunk/vorbis/; revision=13643
erikd [Sun, 26 Aug 2007 01:17:24 +0000 (01:17 +0000)]
lib/lookup_data.h : Add ifdef around FROMdB_LOOKUP to prevent compiler warnings.
svn path=/trunk/vorbis/; revision=13631
erikd [Sun, 26 Aug 2007 00:38:33 +0000 (00:38 +0000)]
include/vorbis/vorbisfile.h : Add comments about a desired change that cannot be made until we're willing to break ABI compatibility.
svn path=/trunk/vorbis/; revision=13630
erikd [Sun, 26 Aug 2007 00:24:57 +0000 (00:24 +0000)]
Detect availability of C99 inline keyword in configure and use it in lib/scales.h. Also add workaround for MSVS which uses __inline.
svn path=/trunk/vorbis/; revision=13629
erikd [Wed, 22 Aug 2007 21:44:29 +0000 (21:44 +0000)]
doc/Makefile.am : Fix broken build.
svn path=/trunk/vorbis/; revision=13590
lu_zero [Wed, 22 Aug 2007 09:38:33 +0000 (09:38 +0000)]
Leftovers...
svn path=/trunk/vorbis/; revision=13584
erikd [Mon, 20 Aug 2007 10:44:04 +0000 (10:44 +0000)]
Remove warnings about unused or uninitialized variables.
svn path=/trunk/vorbis/; revision=13578
erikd [Mon, 20 Aug 2007 10:04:37 +0000 (10:04 +0000)]
Remove unused parameter from function _ve_amp.
svn path=/trunk/vorbis/; revision=13577
erikd [Mon, 20 Aug 2007 10:03:18 +0000 (10:03 +0000)]
Make _v_writestring const correct.
svn path=/trunk/vorbis/; revision=13576
erikd [Mon, 20 Aug 2007 09:56:50 +0000 (09:56 +0000)]
Move struct and func definition to codec_internal.h.
svn path=/trunk/vorbis/; revision=13575
lu_zero [Mon, 20 Aug 2007 09:30:49 +0000 (09:30 +0000)]
draft 07
svn path=/trunk/vorbis/; revision=13574
erikd [Sun, 19 Aug 2007 09:36:24 +0000 (09:36 +0000)]
Make vorbis comment functions const correct.
svn path=/trunk/vorbis/; revision=13571
lu_zero [Thu, 16 Aug 2007 08:54:30 +0000 (08:54 +0000)]
Simplify configuration-uri handling
svn path=/trunk/vorbis/; revision=13558
lu_zero [Thu, 16 Aug 2007 08:34:22 +0000 (08:34 +0000)]
add the start of a real configuration string, as suggested by Colin
svn path=/trunk/vorbis/; revision=13557
lu_zero [Thu, 16 Aug 2007 08:31:50 +0000 (08:31 +0000)]
Move back gzip, bzip2 and vorbis reference to the normative section
svn path=/trunk/vorbis/; revision=13556
lu_zero [Thu, 16 Aug 2007 08:28:27 +0000 (08:28 +0000)]
add reference to rfc4588 as suggested by Colin
svn path=/trunk/vorbis/; revision=13555
Mike Smith [Fri, 10 Aug 2007 16:22:18 +0000 (16:22 +0000)]
Reverting previous change.
Ivo: do not change copyright policy without asking people.
svn path=/trunk/vorbis/; revision=13526
ivo [Fri, 10 Aug 2007 16:17:31 +0000 (16:17 +0000)]
Collective Copyright statement.
svn path=/trunk/vorbis/; revision=13525
sping [Sat, 28 Jul 2007 21:27:15 +0000 (21:27 +0000)]
Make VS2003 do what VS2005 already does
svn path=/trunk/vorbis/; revision=13380
sping [Sat, 28 Jul 2007 20:31:41 +0000 (20:31 +0000)]
Visual Studio 2005 projects file updates: Missing link dependencies "libogg.lib libvorbis.lib" added, no more debugging info for release builds, solution file added
svn path=/trunk/vorbis/; revision=13377
Ralph Giles [Wed, 25 Jul 2007 17:37:04 +0000 (17:37 +0000)]
Bump version number post-release.
svn path=/trunk/vorbis/; revision=13363
Ralph Giles [Wed, 25 Jul 2007 16:27:00 +0000 (16:27 +0000)]
Update library versioning and changelog for the 1.2.0 release.
svn path=/trunk/vorbis/; revision=13312
Monty [Tue, 24 Jul 2007 01:08:23 +0000 (01:08 +0000)]
Catch one bulletproofing oversight; only an app bug would trip it
svn path=/trunk/vorbis/; revision=13294
Monty [Tue, 24 Jul 2007 00:09:47 +0000 (00:09 +0000)]
Update documentation, version numbers, copyright dates
svn path=/trunk/vorbis/; revision=13293
Monty [Mon, 23 Jul 2007 20:17:41 +0000 (20:17 +0000)]
Add ov_fopen() (like ov_open, but does the fopen within libvorbisfile)
and extend ov_open_callbacks() mechanism as means of encouraging use
over ov_open().
Use of ov_open() now strongly discouraged under Windows;
ov_open_callbacks(fd,vf,NULL,0,OV_CALLBACKS_NOCLOSE) as a direct
replacement or ov_fopen() as a convenient substitute.
svn path=/trunk/vorbis/; revision=13289
Ralph Giles [Mon, 23 Jul 2007 18:58:56 +0000 (18:58 +0000)]
We have a new encoder version string.
svn path=/trunk/vorbis/; revision=13288
Ralph Giles [Mon, 23 Jul 2007 18:56:09 +0000 (18:56 +0000)]
New built copies of the decoder spec.
svn path=/trunk/vorbis/; revision=13287
Tim Terriberry [Fri, 20 Jul 2007 03:47:48 +0000 (03:47 +0000)]
Add vorbis_synthesis_idheader to the .def file for win32.
svn path=/trunk/vorbis/; revision=13284
Ralph Giles [Wed, 4 Jul 2007 18:25:00 +0000 (18:25 +0000)]
Also update the configured version.
svn path=/trunk/vorbis/; revision=13225
Ralph Giles [Wed, 4 Jul 2007 18:24:28 +0000 (18:24 +0000)]
Update the changelog. Also bump the version number to a new minor. There
are still no encoder improvements over 1.1, but the handling of
multiplexed streams is a new feature and warrents the jump.
svn path=/trunk/vorbis/; revision=13224
Ralph Giles [Wed, 4 Jul 2007 17:58:43 +0000 (17:58 +0000)]
Update the doc link to the rtp draft as well.
svn path=/trunk/vorbis/; revision=13221
Monty [Wed, 4 Jul 2007 05:13:33 +0000 (05:13 +0000)]
Well. *that* deadlock bug has been lurking in seeking for a long time.
A bigger chunksize + just the right annodex file finally reproduced it
here.
svn path=/trunk/vorbis/; revision=13217
Monty [Tue, 3 Jul 2007 23:53:43 +0000 (23:53 +0000)]
New vorbisfile multiplexing support passes built-in playback and seeking
tests.
svn path=/trunk/vorbis/; revision=13215
Monty [Tue, 3 Jul 2007 21:31:52 +0000 (21:31 +0000)]
Multiplex support fixes; basic functions test OK on single stream files
now, time to test chains and multiplexing.
svn path=/trunk/vorbis/; revision=13214
Monty [Tue, 3 Jul 2007 08:59:28 +0000 (08:59 +0000)]
Multiplexed stream support for vorbisfile *IN PROGRESS*
Don't use it, I know for certain it's broken.
Just a commit to make switching machines easier :-)
svn path=/trunk/vorbis/; revision=13213
Monty [Mon, 2 Jul 2007 23:20:21 +0000 (23:20 +0000)]
Add return checks to all instances of seek_func and _seek_helper.
Should close bug #853.
svn path=/trunk/vorbis/; revision=13211
Monty [Mon, 2 Jul 2007 22:51:10 +0000 (22:51 +0000)]
Although bug 552 was complaining about behavior that was illegal
anyway, added an additional proofing check to vorbisfile to aid a
developer figuring out what he's doing wrong.
svn path=/trunk/vorbis/; revision=13210
Monty [Fri, 29 Jun 2007 05:14:41 +0000 (05:14 +0000)]
Fix for bug 577; used a different approach than the submitted patch
(rather than fudging an out of bound result after computation, do it
the right way to begin with)
Add test for fix to seeking_example.
svn path=/trunk/vorbis/; revision=13198
Monty [Fri, 29 Jun 2007 05:07:49 +0000 (05:07 +0000)]
Draft filename changed, build system must be updated to match.
svn path=/trunk/vorbis/; revision=13197
lu_zero [Mon, 25 Jun 2007 13:18:18 +0000 (13:18 +0000)]
06 commit to ietf
svn path=/trunk/vorbis/; revision=13190
Monty [Sat, 23 Jun 2007 06:42:39 +0000 (06:42 +0000)]
...if we're going to verify against minimum legal blocksize, we really
ought to verify against maximum too.
svn path=/trunk/vorbis/; revision=13179
Monty [Fri, 22 Jun 2007 05:29:52 +0000 (05:29 +0000)]
More fixes to handle the null-entry codebook case. It appears the
failure to handle this case affects more of the code than thought;
many of the old low-bitrate crash cases trace back to this problem.
This also affects tremor. These changes are not yet thoroughly
tested.
svn path=/trunk/vorbis/; revision=13172
Monty [Fri, 22 Jun 2007 03:51:56 +0000 (03:51 +0000)]
Apply patch as supplied in ticket 851
svn path=/trunk/vorbis/; revision=13171
Monty [Fri, 22 Jun 2007 03:34:25 +0000 (03:34 +0000)]
The automated book training scripts managed to create a few residue
books with no codewords (in that mode with that partitioning scheme,
no values happened to fall into that partition). This is not really
an error.
However, the residue encoding code did not account for the possibility
of looking up a codebook best match and finding no entries. Because
the unused book only came up very rarely (four hours of training audio
didn't hit it once), it took a while to notice and only comes up on
platforms with subtly different FP than the machine used to do
training.
This bug affects very low bitrate stereo 8, 11, 16 and 22kHz modes;
added code to check for 'no match in codebook' (correct behavior is to
encode nothing) and for good measure, removed the four dummy codebooks
as there's no point in wasting a few bytes in the header to pack a
nothing.
Closes bug 1142.
svn path=/trunk/vorbis/; revision=13170
Monty [Fri, 22 Jun 2007 03:01:47 +0000 (03:01 +0000)]
Add additional check when attempting to encode values through
codebooks with no entries. Ideally that wouldn't happen, but it looks
like the automated codebook training ended up with a few 'null' books.
svn path=/trunk/vorbis/; revision=13169
Monty [Fri, 22 Jun 2007 01:02:19 +0000 (01:02 +0000)]
Attempted fix for bug #300; the last comment identified a legitimate static bounds overrun that would have explained the behavior.
svn path=/trunk/vorbis/; revision=13168
Monty [Fri, 22 Jun 2007 00:58:15 +0000 (00:58 +0000)]
Don't forget to test all changes in a code cleanup-- residue type 2 encoding was broken by last night's round of fixes.
Tested fixed.
svn path=/trunk/vorbis/; revision=13167
lu_zero [Thu, 21 Jun 2007 14:57:34 +0000 (14:57 +0000)]
Draft update
svn path=/trunk/vorbis/; revision=13163
Monty [Thu, 21 Jun 2007 07:06:25 +0000 (07:06 +0000)]
Numerous small changes to resolve possible and certain issues found by
Coverity.
svn path=/trunk/vorbis/; revision=13162
Monty [Thu, 21 Jun 2007 06:20:08 +0000 (06:20 +0000)]
Correct a cleanup dispatch error when a bitstream is rejected due to
illegal map/floor/residue type. The cleanup subdispatch was done by
type, unfortunately, the invalid type just read in. Fixed.
also bump lib revision.
svn path=/trunk/vorbis/; revision=13160
Monty [Thu, 21 Jun 2007 05:22:35 +0000 (05:22 +0000)]
Spec addition to clarify corner case; residue and floor decoded sections
may overflow the base vector's actual storage; this *must* be handled by
decoders.
svn path=/trunk/vorbis/; revision=13159
Monty [Thu, 21 Jun 2007 04:35:10 +0000 (04:35 +0000)]
Catch one more omission in the vector length guarding
svn path=/trunk/vorbis/; revision=13155
Monty [Thu, 21 Jun 2007 04:22:33 +0000 (04:22 +0000)]
I had forgotten that the res2 top level interprets limits differently
than res0 and res1; guarding code (and garbled playback) fixed
svn path=/trunk/vorbis/; revision=13154
Monty [Thu, 21 Jun 2007 00:51:15 +0000 (00:51 +0000)]
If you're going to guard against max blocksize, make sure you choose the right blocksize.
svn path=/trunk/vorbis/; revision=13153
Monty [Thu, 21 Jun 2007 00:42:23 +0000 (00:42 +0000)]
Additional bounds checking to guard against the case where a residue
or floor is decoding into a vector larger than the current blocksize.
This is not illegal, but no encoder has ever tried it and as such, it
had not been noticed that the code did not handle the case correctly.
svn path=/trunk/vorbis/; revision=13151
Ralph Giles [Wed, 20 Jun 2007 22:25:42 +0000 (22:25 +0000)]
Update change log with the news so far.
svn path=/trunk/vorbis/; revision=13150
Monty [Wed, 20 Jun 2007 22:06:55 +0000 (22:06 +0000)]
Correct a bug where the guard code is allowing illegally small blocksizes.
svn path=/trunk/vorbis/; revision=13149
lu_zero [Wed, 13 Jun 2007 00:32:41 +0000 (00:32 +0000)]
Fix the SDP example
svn path=/trunk/vorbis/; revision=13132
Ralph Giles [Thu, 7 Jun 2007 22:19:17 +0000 (22:19 +0000)]
Update autogen.sh to handle automake 1.10.
svn path=/trunk/vorbis/; revision=13069
Ralph Giles [Thu, 7 Jun 2007 21:07:21 +0000 (21:07 +0000)]
Update the makefile to reference the updated rtp drafts.
svn path=/trunk/vorbis/; revision=13068
lu_zero [Tue, 29 May 2007 08:33:44 +0000 (08:33 +0000)]
Draft updated
svn path=/trunk/vorbis/; revision=12996
lu_zero [Tue, 29 May 2007 08:24:22 +0000 (08:24 +0000)]
Latest batch of fixes
svn path=/trunk/vorbis/; revision=12995
lu_zero [Mon, 14 May 2007 13:00:02 +0000 (13:00 +0000)]
Make nut v understandable
svn path=/trunk/vorbis/; revision=12946
lu_zero [Fri, 11 May 2007 11:14:32 +0000 (11:14 +0000)]
Fixed the Packed Headers Detail Figure
svn path=/trunk/vorbis/; revision=12940
lu_zero [Fri, 11 May 2007 09:50:23 +0000 (09:50 +0000)]
First rephrase of the new header packing procedure, more pending
svn path=/trunk/vorbis/; revision=12939
Ralph Giles [Wed, 9 May 2007 17:48:57 +0000 (17:48 +0000)]
Update the makefile for the new RTP draft revision number.
svn path=/trunk/vorbis/; revision=12934
lu_zero [Tue, 8 May 2007 08:22:19 +0000 (08:22 +0000)]
Yet another change in the headers packing, in practice nothing changes if you use a dummy comment header ( 2| 30| 28| ident| comment| setup| ) but should be flexible enough to be used for other codecs or evolutions of vorbis
svn path=/trunk/vorbis/; revision=12929
lu_zero [Mon, 7 May 2007 20:54:02 +0000 (20:54 +0000)]
Headers packing changes as requested by rillian
svn path=/trunk/vorbis/; revision=12923
lu_zero [Sun, 6 May 2007 14:16:55 +0000 (14:16 +0000)]
Typo fixes from Silvia Pfeiffer
svn path=/trunk/vorbis/; revision=12922
lu_zero [Wed, 2 May 2007 20:26:10 +0000 (20:26 +0000)]
Update the text document
svn path=/trunk/vorbis/; revision=12908
lu_zero [Wed, 2 May 2007 20:18:26 +0000 (20:18 +0000)]
To be committed soon
svn path=/trunk/vorbis/; revision=12907
lu_zero [Wed, 2 May 2007 20:16:32 +0000 (20:16 +0000)]
Colin Perkins' latest comments
svn path=/trunk/vorbis/; revision=12906
Tim Terriberry [Fri, 27 Apr 2007 23:39:58 +0000 (23:39 +0000)]
The structure is not freed, just its contents.
svn path=/trunk/vorbis/; revision=12897
lu_zero [Wed, 18 Apr 2007 08:17:04 +0000 (08:17 +0000)]
Updated document, will be sumbitted to ietf soon
svn path=/trunk/vorbis/; revision=12889
lu_zero [Wed, 18 Apr 2007 08:08:24 +0000 (08:08 +0000)]
Offer/Answer clarification
svn path=/trunk/vorbis/; revision=12888
lu_zero [Wed, 18 Apr 2007 07:27:53 +0000 (07:27 +0000)]
Iana update completed
svn path=/trunk/vorbis/; revision=12887
lu_zero [Wed, 18 Apr 2007 07:07:03 +0000 (07:07 +0000)]
iana update?
svn path=/trunk/vorbis/; revision=12886
lu_zero [Tue, 17 Apr 2007 15:13:33 +0000 (15:13 +0000)]
idnits fixes
svn path=/trunk/vorbis/; revision=12883
lu_zero [Fri, 6 Apr 2007 12:44:25 +0000 (12:44 +0000)]
uncommitted date/name change...
svn path=/trunk/vorbis/; revision=12832
lu_zero [Fri, 6 Apr 2007 11:21:43 +0000 (11:21 +0000)]
New draft
svn path=/trunk/vorbis/; revision=12831
lu_zero [Tue, 27 Mar 2007 20:20:13 +0000 (20:20 +0000)]
move to base64 instead of base16
svn path=/trunk/vorbis/; revision=12813
Thomas Vander Stichele [Mon, 5 Mar 2007 14:55:14 +0000 (14:55 +0000)]
not sure how I missed this wrong includedir
svn path=/trunk/vorbis/; revision=12652
Ralph Giles [Tue, 27 Feb 2007 19:40:34 +0000 (19:40 +0000)]
Add missing vqsplit.h and localcodebook.h headers to the distribution.
svn path=/trunk/vorbis/; revision=12581
lu_zero [Sat, 20 Jan 2007 18:39:33 +0000 (18:39 +0000)]
Updates, pending review
svn path=/trunk/vorbis/; revision=12364