profile/ivi/webkit-efl.git
12 years agoAdd public page loading performance tests using web-page-replay
rniwa@webkit.org [Fri, 1 Jun 2012 03:19:31 +0000 (03:19 +0000)]
Add public page loading performance tests using web-page-replay
https://bugs.webkit.org/show_bug.cgi?id=84008

Reviewed by Dirk Pranke.

PerformanceTests:

Add replay tests for google.com and youtube.com as examples.

* Replay: Added.
* Replay/www.google.com.replay: Added.
* Replay/www.youtube.com.replay: Added.

Tools:

Add the primitive implementation of replay performance tests. We use web-page-replay (http://code.google.com/p/web-page-replay/)
to cache data locally. Each replay test is represented by a text file with .replay extension containing a single URL.
To hash out bugs and isolate them from the rest of performance tests, replay tests are hidden behind --replay flag.

Run "run-perf-tests --replay PerformanceTests/Replay" after changing the system network preference to forward HTTP and HTTPS requests
to localhost:8080 and localhost:8443 respectively (i.e. configure the system as if there are HTTP proxies at ports 8080 and 8443)
excluding: *.webkit.org, *.googlecode.com, *.sourceforge.net, pypi.python.org, and www.adambarth.com for thirdparty Python dependencies.
run-perf-tests starts web-page-replay, which provides HTTP proxies at ports 8080 and 8443 to replay pages.

* Scripts/webkitpy/layout_tests/port/driver.py:
(Driver.is_external_http_test): Added.
* Scripts/webkitpy/layout_tests/port/webkit.py:
(WebKitDriver._command_from_driver_input): Allow test names that starts with http:// or https://.
* Scripts/webkitpy/performance_tests/perftest.py:
(PerfTest.__init__): Takes port.
(PerfTest.prepare): Added. Overridden by ReplayPerfTest.
(PerfTest):
(PerfTest.run): Calls run_single.
(PerfTest.run_single): Extracted from PageLoadingPerfTest.run.
(ChromiumStylePerfTest.__init__):
(PageLoadingPerfTest.__init__):
(PageLoadingPerfTest.run):
(ReplayServer): Added. Responsible for starting and stopping replay.py in the web-page-replay.
(ReplayServer.__init__):
(ReplayServer.wait_until_ready): Wait until port 8080 is ready. I have tried looking at the piped output from web-page-replay
but it caused a dead lock on some web pages.
(ReplayServer.stop):
(ReplayServer.__del__):
(ReplayPerfTest):
(ReplayPerfTest.__init__):
(ReplayPerfTest._start_replay_server):
(ReplayPerfTest.prepare): Creates test.wpr and test-expected.png to cache the page when a replay test is ran for the first time.
The subsequent runs of the same test will just use test.wpr.
(ReplayPerfTest.run_single):
(PerfTestFactory):
(PerfTestFactory.create_perf_test):
* Scripts/webkitpy/performance_tests/perftest_unittest.py:
(MainTest.test_parse_output):
(MainTest.test_parse_output_with_failing_line):
(TestPageLoadingPerfTest.test_run):
(TestPageLoadingPerfTest.test_run_with_bad_output):
(TestReplayPerfTest):
(TestReplayPerfTest.ReplayTestPort):
(TestReplayPerfTest.ReplayTestPort.__init__):
(TestReplayPerfTest.ReplayTestPort.__init__.ReplayTestDriver):
(TestReplayPerfTest.ReplayTestPort.__init__.ReplayTestDriver.run_test):
(TestReplayPerfTest.ReplayTestPort._driver_class):
(TestReplayPerfTest.MockReplayServer):
(TestReplayPerfTest.MockReplayServer.__init__):
(TestReplayPerfTest.MockReplayServer.stop):
(TestReplayPerfTest._add_file):
(TestReplayPerfTest._setup_test):
(TestReplayPerfTest.test_run_single):
(TestReplayPerfTest.test_run_single.run_test):
(TestReplayPerfTest.test_run_single_fails_without_webpagereplay):
(TestReplayPerfTest.test_prepare_fails_when_wait_until_ready_fails):
(TestReplayPerfTest.test_run_single_fails_when_output_has_error):
(TestReplayPerfTest.test_run_single_fails_when_output_has_error.run_test):
(TestReplayPerfTest.test_prepare):
(TestReplayPerfTest.test_prepare.run_test):
(TestReplayPerfTest.test_prepare_calls_run_single):
(TestReplayPerfTest.test_prepare_calls_run_single.run_single):
(TestPerfTestFactory.test_regular_test):
(TestPerfTestFactory.test_inspector_test):
(TestPerfTestFactory.test_page_loading_test):
* Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner):
(PerfTestsRunner._parse_args): Added --replay flag to enable replay tests.
(PerfTestsRunner._collect_tests): Collect .replay files when replay tests are enabled.
(PerfTestsRunner._collect_tests._is_test_file):
(PerfTestsRunner.run): Exit early if one of calls to prepare() fails.
* Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
(create_runner):
(run_test):
(_tests_for_runner):
(test_run_test_set):
(test_run_test_set_kills_drt_per_run):
(test_run_test_pause_before_testing):
(test_run_test_set_for_parser_tests):
(test_run_test_set_with_json_output):
(test_run_test_set_with_json_source):
(test_run_test_set_with_multiple_repositories):
(test_run_with_upload_json):
(test_upload_json):
(test_upload_json.MockFileUploader.upload_single_text_file):
(_add_file):
(test_collect_tests):
(test_collect_tests_with_multile_files):
(test_collect_tests_with_multile_files.add_file):
(test_collect_tests_with_skipped_list):
(test_collect_tests_with_page_load_svg):
(test_collect_tests_should_ignore_replay_tests_by_default):
(test_collect_tests_with_replay_tests):
(test_parse_args):
* Scripts/webkitpy/thirdparty/__init__.py: Added the dependency for web-page-replay version 1.1.1.
(AutoinstallImportHook.find_module):
(AutoinstallImportHook._install_webpagereplay):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119188 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed, rolling out r119146.
commit-queue@webkit.org [Fri, 1 Jun 2012 02:16:03 +0000 (02:16 +0000)]
Unreviewed, rolling out r119146.
http://trac.webkit.org/changeset/119146
https://bugs.webkit.org/show_bug.cgi?id=88035

android breakage fixed in http://crrev.com/139945 (Requested
by fischman on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-31

Source/WebCore:

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement):
(WebCore::HTMLMediaElement::startProgressEventTimer):
(WebCore::HTMLMediaElement::changeNetworkStateFromLoadingToIdle):
(WebCore::HTMLMediaElement::progressEventTimerFired):
(WebCore::HTMLMediaElement::startPlaybackProgressTimer):
* platform/graphics/MediaPlayer.cpp:
(WebCore::NullMediaPlayerPrivate::didLoadingProgress):
(WebCore::MediaPlayer::didLoadingProgress):
* platform/graphics/MediaPlayer.h:
* platform/graphics/MediaPlayerPrivate.h:
(MediaPlayerPrivateInterface):
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::MediaPlayerPrivateAVFoundation):
(WebCore::MediaPlayerPrivateAVFoundation::didLoadingProgress):
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
(MediaPlayerPrivateAVFoundation):
* platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:
(WebCore::MediaPlayerPrivate::didLoadingProgress):
* platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.h:
(MediaPlayerPrivate):
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer):
(WebCore::MediaPlayerPrivateGStreamer::didLoadingProgress):
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
(MediaPlayerPrivateGStreamer):
* platform/graphics/mac/MediaPlayerPrivateQTKit.h:
(MediaPlayerPrivateQTKit):
* platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::MediaPlayerPrivateQTKit::MediaPlayerPrivateQTKit):
(WebCore::MediaPlayerPrivateQTKit::didLoadingProgress):
* platform/graphics/qt/MediaPlayerPrivateQt.cpp:
(WebCore::MediaPlayerPrivateQt::MediaPlayerPrivateQt):
(WebCore::MediaPlayerPrivateQt::didLoadingProgress):
* platform/graphics/qt/MediaPlayerPrivateQt.h:
(MediaPlayerPrivateQt):
* platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::MediaPlayerPrivateQuickTimeVisualContext):
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::didLoadingProgress):
* platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.h:
(MediaPlayerPrivateQuickTimeVisualContext):
* platform/graphics/wince/MediaPlayerPrivateWinCE.h:
(MediaPlayerPrivate):

Source/WebKit/chromium:

* public/WebMediaPlayer.h:
(WebMediaPlayer):
* src/WebMediaPlayerClientImpl.cpp:
(WebKit::WebMediaPlayerClientImpl::didLoadingProgress):
* src/WebMediaPlayerClientImpl.h:
(WebMediaPlayerClientImpl):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119187 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[BlackBerry] WebGL and 2D canvas output not available to WebPageCompositor
commit-queue@webkit.org [Fri, 1 Jun 2012 01:37:40 +0000 (01:37 +0000)]
[BlackBerry] WebGL and 2D canvas output not available to WebPageCompositor
https://bugs.webkit.org/show_bug.cgi?id=88012

Patch by Arvid Nilsson <anilsson@rim.com> on 2012-05-31
Reviewed by George Staikos.

Properly set up resource sharing between WebKit thread EGL contexts and
the compositing thread EGL context, so the texture ID produced by WebGL
and 2D canvas makes sense to the compositing context.

There's no public API to supply an EGLContext yet, so we're lucky that
the embedder never makes its context un-current. Just grab the current
context on the compositing thread and use that as the compositing
context.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::setCompositor):
* Api/WebPageCompositor.cpp:
(BlackBerry::WebKit::WebPageCompositor::WebPageCompositor):
(BlackBerry::WebKit::WebPageCompositor::~WebPageCompositor):
* Api/WebPage_p.h:
(WebPagePrivate):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119185 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoXSSAuditor bypass with leading /*///*/ comment
tsepez@chromium.org [Fri, 1 Jun 2012 01:31:21 +0000 (01:31 +0000)]
XSSAuditor bypass with leading /*///*/ comment
https://bugs.webkit.org/show_bug.cgi?id=88002

Reviewed by Adam Barth.

Source/WebCore:

Fixes issue in xssauditor's parsing of /*/.

Test: http/tests/security/xssAuditor/script-tag-with-trailing-comment4.html

* html/parser/XSSAuditor.cpp:
(WebCore::XSSAuditor::decodedSnippetForJavaScript):

LayoutTests:

Fixes issue in xssauditor's parsing of /*/.

* http/tests/security/xssAuditor/script-tag-with-trailing-comment4-expected.txt: Added.
* http/tests/security/xssAuditor/script-tag-with-trailing-comment4.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119184 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoSupport building the Android port of chromium with Ninja
commit-queue@webkit.org [Fri, 1 Jun 2012 01:13:14 +0000 (01:13 +0000)]
Support building the Android port of chromium with Ninja
https://bugs.webkit.org/show_bug.cgi?id=87545

Patch by Yaron Friedman <yfriedman@chromium.org> on 2012-05-31
Reviewed by Adam Barth.

Ensures that shared libraries are looked up in a generator-agnostic
way and that output is placed in the correct directory.

Depends on http://codereview.chromium.org/10386188/

* DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119183 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoBug: Negative SVG rect rx,ry corner radii values aren't handled correctly
commit-queue@webkit.org [Fri, 1 Jun 2012 00:59:41 +0000 (00:59 +0000)]
Bug: Negative SVG rect rx,ry corner radii values aren't handled correctly
https://bugs.webkit.org/show_bug.cgi?id=87859

Patch by Hans Muller <hmuller@adobe.com> on 2012-05-31
Reviewed by Dirk Schulze.

Source/WebCore:

Added the rect element corner radius constraints specified in steps 2-4 of
http://www.w3.org/TR/SVG/shapes.html#RectElement to Path::addRoundedRect().
Support for steps 6 and 7 was already included.  Steps 2-4:

2 - If neither rx nor ry are properly specified, then set both rx and ry to 0. (This will result in square corners.)
3 - Otherwise, if a properly specified value is provided for rx, but not for ry then set both rx and ry to the value of rx.
4 - Otherwise, if a properly specified value is provided for ry, but not for rx, then set both rx and ry to the value of ry.

Tests: svg/custom/rect-negative-corner-radii-expected.svg
       svg/custom/rect-negative-corner-radii.svg

* platform/graphics/Path.cpp:
(WebCore::Path::addRoundedRect):

LayoutTests:

Added a reftest which verifies that negative rect corner radius values are handled per the SVG spec,
http://www.w3.org/TR/SVG/shapes.html#RectElement.

* svg/custom/rect-negative-corner-radii-expected.svg: Added.
* svg/custom/rect-negative-corner-radii.svg: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119182 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[EFL] Gardening. Skip fast/loader/opaque-base-url.html only on debug bots.
rakuco@webkit.org [Fri, 1 Jun 2012 00:56:33 +0000 (00:56 +0000)]
[EFL] Gardening. Skip fast/loader/opaque-base-url.html only on debug bots.

The test hits an assertion which obviously only crashes the debug
bots.

* platform/efl/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119181 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[EFL] Unskip fast/multicol tests.
rakuco@webkit.org [Fri, 1 Jun 2012 00:55:53 +0000 (00:55 +0000)]
[EFL] Unskip fast/multicol tests.

Most tests were passing and just needed new baselines. Only skip
the few failing ones.

* platform/efl/Skipped:
* platform/efl/fast/multicol/block-axis-horizontal-bt-expected.png: Added.
* platform/efl/fast/multicol/block-axis-horizontal-bt-expected.txt: Added.
* platform/efl/fast/multicol/block-axis-horizontal-tb-expected.png: Added.
* platform/efl/fast/multicol/block-axis-horizontal-tb-expected.txt: Added.
* platform/efl/fast/multicol/block-axis-vertical-lr-expected.png: Added.
* platform/efl/fast/multicol/block-axis-vertical-lr-expected.txt: Added.
* platform/efl/fast/multicol/block-axis-vertical-rl-expected.png: Added.
* platform/efl/fast/multicol/block-axis-vertical-rl-expected.txt: Added.
* platform/efl/fast/multicol/client-rects-expected.png: Added.
* platform/efl/fast/multicol/client-rects-expected.txt: Added.
* platform/efl/fast/multicol/column-count-with-rules-expected.png:
* platform/efl/fast/multicol/column-rules-expected.png:
* platform/efl/fast/multicol/column-rules-stacking-expected.png:
* platform/efl/fast/multicol/columns-shorthand-parsing-expected.png:
* platform/efl/fast/multicol/float-avoidance-expected.png:
* platform/efl/fast/multicol/float-multicol-expected.png:
* platform/efl/fast/multicol/float-paginate-complex-expected.png:
* platform/efl/fast/multicol/float-paginate-complex-expected.txt:
* platform/efl/fast/multicol/float-paginate-empty-lines-expected.png:
* platform/efl/fast/multicol/float-paginate-expected.png:
* platform/efl/fast/multicol/layers-in-multicol-expected.png:
* platform/efl/fast/multicol/layers-split-across-columns-expected.png:
* platform/efl/fast/multicol/margin-collapse-expected.png:
* platform/efl/fast/multicol/max-height-columns-block-expected.png:
* platform/efl/fast/multicol/nested-columns-expected.png:
* platform/efl/fast/multicol/nested-columns-expected.txt:
* platform/efl/fast/multicol/overflow-across-columns-expected.png:
* platform/efl/fast/multicol/overflow-across-columns-percent-height-expected.png:
* platform/efl/fast/multicol/overflow-unsplittable-expected.png:
* platform/efl/fast/multicol/paginate-block-replaced-expected.png:
* platform/efl/fast/multicol/pagination-h-horizontal-bt-expected.png: Added.
* platform/efl/fast/multicol/pagination-h-horizontal-bt-expected.txt: Added.
* platform/efl/fast/multicol/pagination-h-horizontal-tb-expected.png: Added.
* platform/efl/fast/multicol/pagination-h-horizontal-tb-expected.txt: Added.
* platform/efl/fast/multicol/pagination-h-vertical-lr-expected.png: Added.
* platform/efl/fast/multicol/pagination-h-vertical-lr-expected.txt: Added.
* platform/efl/fast/multicol/pagination-h-vertical-rl-expected.png: Added.
* platform/efl/fast/multicol/pagination-h-vertical-rl-expected.txt: Added.
* platform/efl/fast/multicol/pagination-v-horizontal-bt-expected.png: Added.
* platform/efl/fast/multicol/pagination-v-horizontal-bt-expected.txt: Added.
* platform/efl/fast/multicol/pagination-v-horizontal-tb-expected.png: Added.
* platform/efl/fast/multicol/pagination-v-horizontal-tb-expected.txt: Added.
* platform/efl/fast/multicol/pagination-v-vertical-lr-expected.png: Added.
* platform/efl/fast/multicol/pagination-v-vertical-lr-expected.txt: Added.
* platform/efl/fast/multicol/pagination-v-vertical-rl-expected.png: Added.
* platform/efl/fast/multicol/pagination-v-vertical-rl-expected.txt: Added.
* platform/efl/fast/multicol/positioned-split-expected.png:
* platform/efl/fast/multicol/positioned-with-constrained-height-expected.png:
* platform/efl/fast/multicol/positive-leading-expected.png:
* platform/efl/fast/multicol/scrolling-overflow-expected.png:
* platform/efl/fast/multicol/single-line-expected.png: Added.
* platform/efl/fast/multicol/single-line-expected.txt: Added.
* platform/efl/fast/multicol/span/anonymous-before-child-parent-crash-expected.png: Added.
* platform/efl/fast/multicol/span/anonymous-split-block-crash-expected.png:
* platform/efl/fast/multicol/span/anonymous-style-inheritance-expected.png:
* platform/efl/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.png:
* platform/efl/fast/multicol/span/clone-flexbox-expected.txt: Added.
* platform/efl/fast/multicol/span/clone-summary-expected.txt: Added.
* platform/efl/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.png:
* platform/efl/fast/multicol/span/span-as-immediate-child-generated-content-expected.png:
* platform/efl/fast/multicol/span/span-as-immediate-child-property-removal-expected.png:
* platform/efl/fast/multicol/span/span-as-immediate-child-property-removal-expected.txt:
* platform/efl/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.png:
* platform/efl/fast/multicol/span/span-as-immediate-columns-child-expected.png:
* platform/efl/fast/multicol/span/span-as-immediate-columns-child-removal-expected.png:
* platform/efl/fast/multicol/span/span-as-immediate-columns-child-removal-expected.txt:
* platform/efl/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.png:
* platform/efl/fast/multicol/span/span-as-nested-columns-child-expected.png:
* platform/efl/fast/multicol/span/span-as-nested-inline-block-child-expected.png:
* platform/efl/fast/multicol/span/span-margin-collapsing-expected.png:
* platform/efl/fast/multicol/table-margin-collapse-expected.png:
* platform/efl/fast/multicol/table-vertical-align-expected.png:
* platform/efl/fast/multicol/table-vertical-align-expected.txt:
* platform/efl/fast/multicol/unsplittable-inline-block-expected.png:
* platform/efl/fast/multicol/vertical-lr/column-break-with-balancing-expected.png:
* platform/efl/fast/multicol/vertical-lr/column-count-with-rules-expected.png:
* platform/efl/fast/multicol/vertical-lr/column-rules-expected.png:
* platform/efl/fast/multicol/vertical-lr/float-avoidance-expected.png:
* platform/efl/fast/multicol/vertical-lr/float-multicol-expected.png:
* platform/efl/fast/multicol/vertical-lr/float-paginate-complex-expected.png:
* platform/efl/fast/multicol/vertical-lr/float-paginate-complex-expected.txt:
* platform/efl/fast/multicol/vertical-lr/float-paginate-expected.png:
* platform/efl/fast/multicol/vertical-lr/nested-columns-expected.png:
* platform/efl/fast/multicol/vertical-lr/nested-columns-expected.txt:
* platform/efl/fast/multicol/vertical-lr/unsplittable-inline-block-expected.png:
* platform/efl/fast/multicol/vertical-rl/column-break-with-balancing-expected.png:
* platform/efl/fast/multicol/vertical-rl/column-count-with-rules-expected.png:
* platform/efl/fast/multicol/vertical-rl/column-rules-expected.png:
* platform/efl/fast/multicol/vertical-rl/float-avoidance-expected.png:
* platform/efl/fast/multicol/vertical-rl/float-multicol-expected.png:
* platform/efl/fast/multicol/vertical-rl/float-paginate-complex-expected.png:
* platform/efl/fast/multicol/vertical-rl/float-paginate-complex-expected.txt:
* platform/efl/fast/multicol/vertical-rl/float-paginate-expected.png:
* platform/efl/fast/multicol/vertical-rl/nested-columns-expected.png:
* platform/efl/fast/multicol/vertical-rl/nested-columns-expected.txt:
* platform/efl/fast/multicol/vertical-rl/rule-style-expected.txt: Added.
* platform/efl/fast/multicol/vertical-rl/unsplittable-inline-block-expected.png:
* platform/efl/test_expectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119180 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[chromium] Migrate to WebTransformationMatrix
jamesr@google.com [Fri, 1 Jun 2012 00:24:32 +0000 (00:24 +0000)]
[chromium] Migrate to WebTransformationMatrix
https://bugs.webkit.org/show_bug.cgi?id=87788

Patch by Shawn Singh <shawnsingh@chromium.org> on 2012-05-31
Reviewed by James Robinson.

Source/Platform:

* chromium/public/WebTransformationMatrix.h:
(WebTransformationMatrix):

Source/WebCore:

Covered by all existing layout tests and unit tests.

This patch replaces all occurrences of WebCore::TransformationMatrix
with WebKit::WebTransformationMatrix in the chromium compositor code.

* platform/chromium/support/WebTransformationMatrix.cpp:
(WebKit::WebTransformationMatrix::WebTransformationMatrix):
(WebKit):
* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::setSublayerTransform):
(WebCore::LayerChromium::setTransform):
(WebCore::LayerChromium::setTransformFromAnimation):
* platform/graphics/chromium/LayerChromium.h:
(LayerChromium):
(WebCore::LayerChromium::sublayerTransform):
(WebCore::LayerChromium::drawTransform):
(WebCore::LayerChromium::setDrawTransform):
(WebCore::LayerChromium::screenSpaceTransform):
(WebCore::LayerChromium::setScreenSpaceTransform):
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::drawCheckerboardQuad):
(WebCore::LayerRendererChromium::drawDebugBorderQuad):
(WebCore::LayerRendererChromium::drawBackgroundFilters):
(WebCore::LayerRendererChromium::drawRenderSurfaceQuad):
(WebCore::LayerRendererChromium::drawSolidColorQuad):
(WebCore::LayerRendererChromium::drawTileQuad):
(WebCore::LayerRendererChromium::drawHeadsUpDisplay):
(WebCore::LayerRendererChromium::toGLMatrix):
(WebCore::LayerRendererChromium::drawTexturedQuad):
(WebCore::LayerRendererChromium::copyTextureToFramebuffer):
* platform/graphics/chromium/LayerRendererChromium.h:
(WebCore::LayerRendererChromium::projectionMatrix):
(WebCore::LayerRendererChromium::windowMatrix):
(LayerRendererChromium):
* platform/graphics/chromium/LinkHighlight.cpp:
(WebCore::LinkHighlight::LinkHighlight):
* platform/graphics/chromium/RenderSurfaceChromium.h:
(WebCore::RenderSurfaceChromium::drawTransform):
(WebCore::RenderSurfaceChromium::setDrawTransform):
(WebCore::RenderSurfaceChromium::originTransform):
(WebCore::RenderSurfaceChromium::setOriginTransform):
(WebCore::RenderSurfaceChromium::screenSpaceTransform):
(WebCore::RenderSurfaceChromium::setScreenSpaceTransform):
(WebCore::RenderSurfaceChromium::replicaDrawTransform):
(WebCore::RenderSurfaceChromium::setReplicaDrawTransform):
(WebCore::RenderSurfaceChromium::replicaOriginTransform):
(WebCore::RenderSurfaceChromium::setReplicaOriginTransform):
(WebCore::RenderSurfaceChromium::replicaScreenSpaceTransform):
(WebCore::RenderSurfaceChromium::setReplicaScreenSpaceTransform):
(RenderSurfaceChromium):
* platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::updateTiles):
* platform/graphics/chromium/cc/CCAnimationCurve.h:
(WebCore):
(CCTransformAnimationCurve):
* platform/graphics/chromium/cc/CCDamageTracker.cpp:
(WebCore::CCDamageTracker::extendDamageForLayer):
(WebCore::CCDamageTracker::extendDamageForRenderSurface):
* platform/graphics/chromium/cc/CCDrawQuad.h:
(WebCore::CCDrawQuad::quadTransform):
(WebCore::CCDrawQuad::layerTransform):
* platform/graphics/chromium/cc/CCKeyframedAnimationCurve.cpp:
(WebCore::CCTransformKeyframe::clone):
(WebCore::CCKeyframedTransformAnimationCurve::getValue):
* platform/graphics/chromium/cc/CCKeyframedAnimationCurve.h:
(CCKeyframedTransformAnimationCurve):
* platform/graphics/chromium/cc/CCLayerAnimationController.cpp:
(WebCore::CCLayerAnimationController::tickAnimations):
* platform/graphics/chromium/cc/CCLayerAnimationController.h:
(WebKit):
(WebCore):
(CCLayerAnimationControllerClient):
* platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::quadTransform):
(WebCore::CCLayerImpl::setTransformFromAnimation):
(WebCore::CCLayerImpl::setSublayerTransform):
(WebCore::CCLayerImpl::setTransform):
* platform/graphics/chromium/cc/CCLayerImpl.h:
(CCLayerImpl):
(WebCore::CCLayerImpl::sublayerTransform):
(WebCore::CCLayerImpl::drawTransform):
(WebCore::CCLayerImpl::setDrawTransform):
(WebCore::CCLayerImpl::screenSpaceTransform):
(WebCore::CCLayerImpl::setScreenSpaceTransform):
* platform/graphics/chromium/cc/CCLayerSorter.cpp:
(WebCore::CCLayerSorter::LayerShape::LayerShape):
(WebCore::CCLayerSorter::createGraphNodes):
* platform/graphics/chromium/cc/CCLayerSorter.h:
(WebKit):
(LayerShape):
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::updateLayers):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
* platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
(WebCore::CCLayerTreeHostCommon::calculateVisibleRect):
(WebCore::isSurfaceBackFaceVisible):
(WebCore::calculateVisibleLayerRect):
(WebCore::isScaleOrTranslation):
(WebCore::calculateDrawTransformsAndVisibilityInternal):
(WebCore::CCLayerTreeHostCommon::calculateDrawTransformsAndVisibility):
* platform/graphics/chromium/cc/CCLayerTreeHostCommon.h:
(CCLayerTreeHostCommon):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::damageInSurfaceSpace):
(WebCore::CCLayerTreeHostImpl::calculateRenderSurfaceLayerList):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
(WebCore):
* platform/graphics/chromium/cc/CCMathUtil.cpp:
(WebCore::projectPoint):
(WebCore::mapPoint):
(WebCore::CCMathUtil::mapClippedRect):
(WebCore::CCMathUtil::projectClippedRect):
(WebCore::CCMathUtil::mapClippedQuad):
(WebCore::CCMathUtil::mapQuad):
(WebCore::CCMathUtil::projectQuad):
* platform/graphics/chromium/cc/CCMathUtil.h:
(WebKit):
(WebCore):
(CCMathUtil):
* platform/graphics/chromium/cc/CCOcclusionTracker.cpp:
(WebCore::transformSurfaceOpaqueRegion):
(WebCore::reduceOcclusionBelowSurface):
(WebCore::contentToScreenSpaceTransform):
(WebCore::contentToTargetSurfaceTransform):
(WebCore::addOcclusionBehindLayer):
(WebCore::::markOccludedBehindLayer):
(WebCore::testContentRectOccluded):
(WebCore::computeUnoccludedContentRect):
(WebCore::::unoccludedContributingSurfaceContentRect):
* platform/graphics/chromium/cc/CCOcclusionTracker.h:
* platform/graphics/chromium/cc/CCOverdrawMetrics.cpp:
(WebCore::CCOverdrawMetrics::didUpload):
(WebCore::CCOverdrawMetrics::didCullForDrawing):
(WebCore::CCOverdrawMetrics::didDraw):
* platform/graphics/chromium/cc/CCOverdrawMetrics.h:
(WebKit):
(CCOverdrawMetrics):
* platform/graphics/chromium/cc/CCQuadCuller.cpp:
* platform/graphics/chromium/cc/CCRenderPass.cpp:
(WebCore::CCRenderPass::appendQuadsToFillScreen):
* platform/graphics/chromium/cc/CCRenderSurface.h:
(WebCore::CCRenderSurface::setDrawTransform):
(WebCore::CCRenderSurface::drawTransform):
(WebCore::CCRenderSurface::setOriginTransform):
(WebCore::CCRenderSurface::originTransform):
(WebCore::CCRenderSurface::setScreenSpaceTransform):
(WebCore::CCRenderSurface::screenSpaceTransform):
(WebCore::CCRenderSurface::setReplicaDrawTransform):
(WebCore::CCRenderSurface::replicaDrawTransform):
(WebCore::CCRenderSurface::setReplicaOriginTransform):
(WebCore::CCRenderSurface::replicaOriginTransform):
(WebCore::CCRenderSurface::setReplicaScreenSpaceTransform):
(WebCore::CCRenderSurface::replicaScreenSpaceTransform):
(CCRenderSurface):
* platform/graphics/chromium/cc/CCSharedQuadState.cpp:
(WebCore::CCSharedQuadState::create):
(WebCore::CCSharedQuadState::CCSharedQuadState):
* platform/graphics/chromium/cc/CCSharedQuadState.h:
(CCSharedQuadState):
(WebCore::CCSharedQuadState::quadTransform):
(WebCore::CCSharedQuadState::layerTransform):
* platform/graphics/chromium/cc/CCSolidColorLayerImpl.cpp:
(WebCore::CCSolidColorLayerImpl::quadTransform):
* platform/graphics/chromium/cc/CCSolidColorLayerImpl.h:
(CCSolidColorLayerImpl):
* platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
(WebCore::CCTiledLayerImpl::quadTransform):
* platform/graphics/chromium/cc/CCTiledLayerImpl.h:
(CCTiledLayerImpl):

Source/WebKit/chromium:

* src/WebLayer.cpp:
(WebKit::WebLayer::setSublayerTransform):
(WebKit::WebLayer::setTransform):
* tests/CCAnimationTestCommon.cpp:
(WebKitTests::FakeTransformTransition::getValue):
* tests/CCAnimationTestCommon.h:
* tests/CCDamageTrackerTest.cpp:
(WebKitTests::executeCalculateDrawTransformsAndVisibility):
(WebKitTests::TEST_F):
* tests/CCKeyframedAnimationCurveTest.cpp:
* tests/CCLayerAnimationControllerTest.cpp:
* tests/CCLayerImplTest.cpp:
(WebCore::TEST):
* tests/CCLayerIteratorTest.cpp:
* tests/CCLayerSorterTest.cpp:
* tests/CCLayerTreeHostCommonTest.cpp:
* tests/CCLayerTreeHostTest.cpp:
(WTF::CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers::commitCompleteOnCCThread):
(WTF::setLayerPropertiesForTesting):
(WTF::CCLayerTreeHostTestAtomicCommitWithPartialUpdate::beginTest):
(WTF::setTestLayerPropertiesForTesting):
(WTF::CCLayerTreeHostTestLayerOcclusion::beginTest):
(WTF::CCLayerTreeHostTestLayerOcclusionWithFilters::beginTest):
(WTF::CCLayerTreeHostTestManySurfaces::beginTest):
* tests/CCLayerTreeTestCommon.h:
(WebKitTests):
* tests/CCMathUtilTest.cpp:
* tests/CCOcclusionTrackerTest.cpp:
(WebKitTests::CCOcclusionTrackerTest::createRoot):
(WebKitTests::CCOcclusionTrackerTest::createLayer):
(WebKitTests::CCOcclusionTrackerTest::createSurface):
(WebKitTests::CCOcclusionTrackerTest::createDrawingLayer):
(WebKitTests::CCOcclusionTrackerTest::createReplicaLayer):
(WebKitTests::CCOcclusionTrackerTest::createDrawingSurface):
(CCOcclusionTrackerTest):
(WebKitTests::CCOcclusionTrackerTest::setBaseProperties):
(WebKitTests::CCOcclusionTrackerTest::setProperties):
(WebKitTests::CCOcclusionTrackerTestRotatedChild::runMyTest):
(WebKitTests::CCOcclusionTrackerTestTranslatedChild::runMyTest):
(WebKitTests::CCOcclusionTrackerTestChildInRotatedChild::runMyTest):
(WebKitTests::CCOcclusionTrackerTestVisitTargetTwoTimes::runMyTest):
(WebKitTests::CCOcclusionTrackerTestSurfaceRotatedOffAxis::runMyTest):
(WebKitTests::CCOcclusionTrackerTestSurfaceWithTwoOpaqueChildren::runMyTest):
(WebKitTests::CCOcclusionTrackerTestOverlappingSurfaceSiblings::runMyTest):
(WebKitTests::CCOcclusionTrackerTestOverlappingSurfaceSiblingsWithTwoTransforms::runMyTest):
(WebKitTests::CCOcclusionTrackerTestFilters::runMyTest):
(WebKitTests::CCOcclusionTrackerTest3dTransform::runMyTest):
(WebKitTests::CCOcclusionTrackerTestPerspectiveTransform::runMyTest):
(WebKitTests::CCOcclusionTrackerTestPerspectiveTransformBehindCamera::runMyTest):
(WebKitTests::CCOcclusionTrackerTestLayerBehindCameraDoesNotOcclude::runMyTest):
(WebKitTests::CCOcclusionTrackerTestLargePixelsOccludeInsideClipRect::runMyTest):
(WebKitTests::CCOcclusionTrackerTestSurfaceOcclusionTranslatesToParent::runMyTest):
(WebKitTests::CCOcclusionTrackerTestDontOccludePixelsNeededForBackgroundFilter::runMyTest):
(WebKitTests::CCOcclusionTrackerTestTwoBackgroundFiltersReduceOcclusionTwice::runMyTest):
(WebKitTests::CCOcclusionTrackerTestDontReduceOcclusionBelowBackgroundFilter::runMyTest):
(WebKitTests::CCOcclusionTrackerTestDontReduceOcclusionIfBackgroundFilterIsOccluded::runMyTest):
(WebKitTests::CCOcclusionTrackerTestReduceOcclusionWhenBackgroundFilterIsPartiallyOccluded::runMyTest):
* tests/CCQuadCullerTest.cpp:
* tests/CCRenderSurfaceTest.cpp:
* tests/FloatQuadTest.cpp:
* tests/LayerChromiumTest.cpp:
* tests/LinkHighlightTest.cpp:
* tests/TiledLayerChromiumTest.cpp:
* tests/WebTransformationMatrixTest.cpp:
(WebKit::TEST):
(WebKit):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119178 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoJSGlobalObject does not mark m_privateNameStructure
mhahnenberg@apple.com [Fri, 1 Jun 2012 00:02:09 +0000 (00:02 +0000)]
JSGlobalObject does not mark m_privateNameStructure
https://bugs.webkit.org/show_bug.cgi?id=88023

Rubber stamped by Gavin Barraclough.

* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::visitChildren): We need to mark this so it doesn't get
inadvertently garbage collected.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119175 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Win] 4 css3 tests fail
jberlin@webkit.org [Thu, 31 May 2012 23:53:31 +0000 (23:53 +0000)]
[Win] 4 css3 tests fail
https://bugs.webkit.org/show_bug.cgi?id=88024

Add Windows-specific expected (failing?) results to get the bots green.

* platform/win/css3: Added.
* platform/win/css3/filters: Added.
* platform/win/css3/filters/composited-during-animation-expected.txt: Added.
* platform/win/css3/filters/composited-during-animation-layertree-expected.txt: Added.
* platform/win/css3/filters/composited-during-transition-layertree-expected.txt: Added.
* platform/win/css3/unicode-bidi-isolate-basic-expected.png: Added.
* platform/win/css3/unicode-bidi-isolate-basic-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119174 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[chromium] Single thread proxy should not tick animations unless the layer renderer...
commit-queue@webkit.org [Thu, 31 May 2012 23:48:30 +0000 (23:48 +0000)]
[chromium] Single thread proxy should not tick animations unless the layer renderer has been initialized
https://bugs.webkit.org/show_bug.cgi?id=87873

Patch by Ian Vollick <vollick@chromium.org> on 2012-05-31
Reviewed by James Robinson.

When the layer renderer fails to initialize, be sure to stop the animation timer.

Source/WebCore:

Unit test: CCLayerTreeHostTestInitializeLayerRendererFailsAfterAddAnimation.runSingleThread

* platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::initializeLayerRenderer):
(WebCore::CCSingleThreadProxy::didAddAnimation):
(WebCore::CCSingleThreadProxy::animationTimerDelay):
(WebCore):
* platform/graphics/chromium/cc/CCSingleThreadProxy.h:

Source/WebKit/chromium:

* tests/CCLayerTreeHostTest.cpp:
(CompositorFakeWebGraphicsContext3DWithTextureTracking):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::create):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::createTexture):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::deleteTexture):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::bindTexture):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::numTextures):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::texture):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::resetTextures):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::numUsedTextures):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::usedTexture):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::resetUsedTextures):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::CompositorFakeWebGraphicsContext3DWithTextureTracking):
(WTF):
(WTF::TestHooks::didRecreateContext):
(TestHooks):
(WTF::TestHooks::createContext):
(CCLayerTreeHostTest):
(WTF::CCLayerTreeHostTest::clearEndTestTask):
(WTF::CCLayerTreeHostTest::CCLayerTreeHostTest):
(EndTestTask):
(WTF::CCLayerTreeHostTest::EndTestTask::EndTestTask):
(WTF::CCLayerTreeHostTest::EndTestTask::~EndTestTask):
(WTF::CCLayerTreeHostTest::EndTestTask::clearTest):
(WTF::CCLayerTreeHostTest::EndTestTask::run):
(WTF::CCLayerTreeHostTest::runTest):
(WTF::CCLayerTreeHostTest::endTestAfterDelay):
(FakeWebGraphicsContext3DMakeCurrentFails):
(WTF::FakeWebGraphicsContext3DMakeCurrentFails::makeContextCurrent):
(CCLayerTreeHostTestInitializeLayerRendererFailsAfterAddAnimation):
(WTF::CCLayerTreeHostTestInitializeLayerRendererFailsAfterAddAnimation::CCLayerTreeHostTestInitializeLayerRendererFailsAfterAddAnimation):
(WTF::CCLayerTreeHostTestInitializeLayerRendererFailsAfterAddAnimation::beginTest):
(WTF::CCLayerTreeHostTestInitializeLayerRendererFailsAfterAddAnimation::animateLayers):
(WTF::CCLayerTreeHostTestInitializeLayerRendererFailsAfterAddAnimation::didRecreateContext):
(WTF::CCLayerTreeHostTestInitializeLayerRendererFailsAfterAddAnimation::afterTest):
(WTF::TEST_F):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119173 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRenderLayerCompositor cleanup: make RenderGeometryMap part of the OverlapMap
simon.fraser@apple.com [Thu, 31 May 2012 23:25:05 +0000 (23:25 +0000)]
RenderLayerCompositor cleanup: make RenderGeometryMap part of the OverlapMap
https://bugs.webkit.org/show_bug.cgi?id=88021

Reviewed by James Robinson.

We only ever use the RenderGeometryMap when we have an OverlapMap, so make
it a member of the OverlapMap.

No behavior change.

* rendering/RenderLayerCompositor.cpp:
(RenderLayerCompositor::OverlapMap):
(WebCore::RenderLayerCompositor::OverlapMap::geometryMap):
(WebCore::RenderLayerCompositor::updateCompositingLayers):
(WebCore::RenderLayerCompositor::addToOverlapMap):
(WebCore::RenderLayerCompositor::addToOverlapMapRecursive):
(WebCore::RenderLayerCompositor::computeCompositingRequirements):
* rendering/RenderLayerCompositor.h:
(WebCore):
(RenderLayerCompositor):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119172 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[V8] Pass Isolate to v8Boolean()
haraken@chromium.org [Thu, 31 May 2012 23:13:44 +0000 (23:13 +0000)]
[V8] Pass Isolate to v8Boolean()
https://bugs.webkit.org/show_bug.cgi?id=87948

Reviewed by Adam Barth.

The objective is to pass Isolate around in V8 bindings.
This patch passes Isolate to v8Boolean().

No tests. No change in behavior.

* bindings/v8/SerializedScriptValue.cpp:
* bindings/v8/custom/V8DOMStringMapCustom.cpp:
(WebCore::V8DOMStringMap::namedPropertyDeleter):
* bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
(WebCore::V8InjectedScriptHost::isHTMLAllCollectionCallback):
* bindings/v8/custom/V8StorageCustom.cpp:
(WebCore::storageDeleter):
* bindings/v8/custom/V8WebSocketCustom.cpp:
(WebCore::V8WebSocket::sendCallback):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119171 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix a broken ChangeLog entry from r119113 due to a corrupted patch.
mrobinson@webkit.org [Thu, 31 May 2012 23:12:55 +0000 (23:12 +0000)]
Fix a broken ChangeLog entry from r119113 due to a corrupted patch.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119170 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Win] 10 fast/forms tests failing
jberlin@webkit.org [Thu, 31 May 2012 23:00:07 +0000 (23:00 +0000)]
[Win] 10 fast/forms tests failing
https://bugs.webkit.org/show_bug.cgi?id=88013

Add/update Windows-expected (failing?) results to get the bots greener.

* platform/win/fast/forms/basic-selects-expected.png: Added.
* platform/win/fast/forms/basic-selects-expected.txt:
* platform/win/fast/forms/fieldset-legend-padding-unclipped-fieldset-border-expected.png:
* platform/win/fast/forms/fieldset-legend-padding-unclipped-fieldset-border-expected.txt:
* platform/win/fast/forms/file: Added.
* platform/win/fast/forms/file/file-input-disabled-expected.png: Added.
* platform/win/fast/forms/file/file-input-disabled-expected.txt: Added.
* platform/win/fast/forms/implicit-submission-expected.txt:
* platform/win/fast/forms/input-step-as-double-expected.txt: Added.
* platform/win/fast/forms/input-text-drag-down-expected.png:
* platform/win/fast/forms/input-text-drag-down-expected.txt:
* platform/win/fast/forms/select: Added.
* platform/win/fast/forms/select-overflow-scroll-expected.png: Added.
* platform/win/fast/forms/select-overflow-scroll-expected.txt: Added.
* platform/win/fast/forms/select-overflow-scroll-inherited-expected.png: Added.
* platform/win/fast/forms/select-overflow-scroll-inherited-expected.txt: Added.
* platform/win/fast/forms/select/optgroup-rendering-expected.png: Added.
* platform/win/fast/forms/select/optgroup-rendering-expected.txt: Added.
* platform/win/fast/forms/text-control-intrinsic-widths-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119166 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2012-05-15 Brett Wilson <brettw@chromium.org>
brettw@chromium.org [Thu, 31 May 2012 22:54:20 +0000 (22:54 +0000)]
2012-05-15  Brett Wilson  <brettw@chromium.org>

        Hook up GTK IsKeyPad flag for keyboard events, and preserve this flag
        on all platforms when converting back to a WebKeyboardEvent.

        https://bugs.webkit.org/show_bug.cgi?id=86514

        Reviewed by Dimitri Glazkov.

        * src/WebInputEventConversion.cpp:
        (WebKit::WebKeyboardEventBuilder::WebKeyboardEventBuilder):
        * src/gtk/WebInputEventFactory.cpp:
        (WebKit::WebInputEventFactory::keyboardEvent):
        * tests/WebInputEventFactoryTestGtk.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119164 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoEnable support for rvalue references when building with a version of clang that suppo...
andersca@apple.com [Thu, 31 May 2012 22:50:05 +0000 (22:50 +0000)]
Enable support for rvalue references when building with a version of clang that supports them
https://bugs.webkit.org/show_bug.cgi?id=88018

Re-enable support for rvalue references when building with a version of Xcode newer than 4.2.

* wtf/Compiler.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119162 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoIndexedDB: Implement IDBTransaction.error and IDBRequest.error
commit-queue@webkit.org [Thu, 31 May 2012 22:47:34 +0000 (22:47 +0000)]
IndexedDB: Implement IDBTransaction.error and IDBRequest.error
https://bugs.webkit.org/show_bug.cgi?id=87865

Patch by Alec Flett <alecflett@chromium.org> on 2012-05-31
Reviewed by Tony Chang.

Source/WebCore:

Added "error" attribute to IDBRequest and IDBTransaction. Update
IDBDatabaseError to honor the IDBDatabaseException behavior
of dealing with IDB-specific throws of DOMException codes,
as per the spec.

Existing tests which previously tested 'errorCode' and
'webkitErrorMessage' have been updated to use the new attribute.

* Modules/indexeddb/IDBCursor.cpp:
(WebCore::IDBCursor::advance):
* Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::setVersion):
* Modules/indexeddb/IDBDatabaseError.h:
(WebCore::IDBDatabaseError::create):
(WebCore::IDBDatabaseError::code):
(WebCore::IDBDatabaseError::idbCode):
(WebCore::IDBDatabaseError::name):
(WebCore::IDBDatabaseError::IDBDatabaseError):
(IDBDatabaseError):
* Modules/indexeddb/IDBDatabaseException.cpp:
(WebCore):
(WebCore::getErrorEntry):
(WebCore::IDBDatabaseException::initializeDescription):
(WebCore::IDBDatabaseException::getErrorName):
(WebCore::IDBDatabaseException::getLegacyErrorCode):
* Modules/indexeddb/IDBDatabaseException.h:
(IDBDatabaseException):
* Modules/indexeddb/IDBObjectStore.cpp:
(WebCore::IDBObjectStore::createIndex):
* Modules/indexeddb/IDBRequest.cpp:
(WebCore::IDBRequest::error):
(WebCore):
(WebCore::IDBRequest::resetReadyState):
(WebCore::IDBRequest::abort):
(WebCore::IDBRequest::onError):
(WebCore::IDBRequest::onSuccess):
(WebCore::IDBRequest::onSuccessWithContinuation):
(WebCore::IDBRequest::dispatchEvent):
* Modules/indexeddb/IDBRequest.h:
(IDBRequest):
* Modules/indexeddb/IDBRequest.idl:
* Modules/indexeddb/IDBTransaction.cpp:
(WebCore::IDBTransaction::error):
(WebCore):
(WebCore::IDBTransaction::setError):
* Modules/indexeddb/IDBTransaction.h:
(IDBTransaction):
* Modules/indexeddb/IDBTransaction.idl:

Source/WebKit/chromium:

IDBDatabaseError now honors IDB-specific DOMException codes,
so make sure that's how they are passed to/from chromium.

* src/WebIDBDatabaseError.cpp:
(WebKit::WebIDBDatabaseError::assign):

LayoutTests:

* storage/indexeddb/basics-expected.txt:
* storage/indexeddb/basics-workers-expected.txt:
* storage/indexeddb/create-and-remove-object-store-expected.txt:
* storage/indexeddb/cursor-continue-expected.txt:
* storage/indexeddb/cursor-update-expected.txt:
* storage/indexeddb/database-basics-expected.txt:
* storage/indexeddb/deleteIndex-expected.txt:
* storage/indexeddb/factory-cmp-expected.txt:
* storage/indexeddb/get-keyrange-expected.txt:
* storage/indexeddb/index-basics-expected.txt:
* storage/indexeddb/index-basics-workers-expected.txt:
* storage/indexeddb/index-count-expected.txt:
* storage/indexeddb/index-unique-expected.txt:
* storage/indexeddb/invalid-keys-expected.txt:
* storage/indexeddb/key-generator-expected.txt:
* storage/indexeddb/key-type-array-expected.txt:
* storage/indexeddb/keypath-edges-expected.txt:
* storage/indexeddb/keyrange-expected.txt:
* storage/indexeddb/objectstore-autoincrement-expected.txt:
* storage/indexeddb/objectstore-basics-expected.txt:
* storage/indexeddb/objectstore-basics-workers-expected.txt:
* storage/indexeddb/objectstore-count-expected.txt:
* storage/indexeddb/open-cursor-expected.txt:
* storage/indexeddb/readonly-expected.txt:
* storage/indexeddb/resources/basics.js:
(test):
(openCallback):
* storage/indexeddb/resources/create-and-remove-object-store.js:
(testCreateAndRemove):
(cleanDatabase):
(tryOnceMore):
* storage/indexeddb/resources/cursor-continue.js:
(ascendingErrorTestLessThan.request.onsuccess):
(ascendingErrorTestLessThan):
(ascendingErrorTestEqual.request.onsuccess):
(ascendingErrorTestEqual):
(descendingErrorTestGreaterThan.request.onsuccess):
(descendingErrorTestGreaterThan):
(descendingErrorTestEqual.request.onsuccess):
(descendingErrorTestEqual):
(onTransactionComplete):
* storage/indexeddb/resources/cursor-update.js:
(keyCursor):
* storage/indexeddb/resources/database-basics.js:
(testClose):
* storage/indexeddb/resources/database-quota.js:
(logError):
* storage/indexeddb/resources/deleteIndex.js:
(twiddleIndexes):
(postTwiddling):
* storage/indexeddb/resources/factory-cmp.js:
(testValidKeys):
(testInvalidKeys):
* storage/indexeddb/resources/get-keyrange.js:
(getNullTest):
* storage/indexeddb/resources/index-basics.js:
(index3Count):
* storage/indexeddb/resources/index-count.js:
* storage/indexeddb/resources/index-unique.js:
(addMoreDataFailed):
* storage/indexeddb/resources/invalid-keys.js:
* storage/indexeddb/resources/key-generator.js:
* storage/indexeddb/resources/key-type-array.js:
(testDepthLimits):
* storage/indexeddb/resources/keypath-edges.js:
* storage/indexeddb/resources/keyrange.js:
(test):
* storage/indexeddb/resources/objectstore-autoincrement.js:
(getAbrahamSuccess):
* storage/indexeddb/resources/objectstore-basics.js:
(setVersionSuccess):
(createIndex):
(addAgainFailure):
(removeSuccessButNotThere):
(testPreConditions.request.onsuccess):
(testPreConditions):
* storage/indexeddb/resources/objectstore-count.js:
* storage/indexeddb/resources/open-cursor.js:
(cursorWithKeySuccess):
(cursorSuccess):
* storage/indexeddb/resources/readonly.js:
(openSuccess):
* storage/indexeddb/resources/set_version_queue.js:
(connectionError):
* storage/indexeddb/resources/shared.js:
(unexpectedErrorCallback):
(evalAndExpectException):
* storage/indexeddb/resources/transaction-abort-workers.js:
(transactionAborted):
(transactionCompleted):
(timeoutTest.transaction.onabort):
(timeoutTest):
(errorTransactionAborted):
* storage/indexeddb/resources/transaction-abort.js:
(firstAdd):
(secondAdd):
(transactionAborted):
* storage/indexeddb/resources/transaction-after-close.js:
(firstTransactionComplete):
* storage/indexeddb/resources/transaction-and-objectstore-calls.js:
(created):
(afterComplete):
* storage/indexeddb/resources/transaction-basics.js:
(testInactiveAbortedTransaction):
(testInactiveCompletedTransaction):
(testInvalidMode):
* storage/indexeddb/resources/transaction-read-only.js:
(setVersionDone):
(gotCursor):
* storage/indexeddb/set_version_queue-expected.txt:
* storage/indexeddb/transaction-abort-expected.txt:
* storage/indexeddb/transaction-abort-workers-expected.txt:
* storage/indexeddb/transaction-after-close-expected.txt:
* storage/indexeddb/transaction-and-objectstore-calls-expected.txt:
* storage/indexeddb/transaction-basics-expected.txt:
* storage/indexeddb/transaction-read-only-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119161 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[chromium] Assertion failures during compositor startup in lost context situations
jamesr@google.com [Thu, 31 May 2012 22:43:25 +0000 (22:43 +0000)]
[chromium] Assertion failures during compositor startup in lost context situations
https://bugs.webkit.org/show_bug.cgi?id=87912

Reviewed by Adrienne Walker.

Source/WebCore:

getShaderiv and getProgramiv may return 0 if the context is lost. We correctly recover in this case, so it's
bogus to fail an ASSERT in debug in this case.

Added new unit test in LayerRendererChromiumTest to cover this.

* platform/graphics/chromium/ProgramBinding.cpp:
(WebCore::contextLost):
(WebCore):
(WebCore::ProgramBindingBase::init):
(WebCore::ProgramBindingBase::createShaderProgram):

Source/WebKit/chromium:

Adds a unit test verifying that even if we lose our context during or before initialization we get through the
rest of the path without failing ASSERT()s.

* tests/LayerRendererChromiumTest.cpp:
(LoseContextOnFirstGetContext):
(LoseContextOnFirstGetContext::LoseContextOnFirstGetContext):
(TEST):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119160 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed, rolling out r119113.
commit-queue@webkit.org [Thu, 31 May 2012 22:37:16 +0000 (22:37 +0000)]
Unreviewed, rolling out r119113.
http://trac.webkit.org/changeset/119113
https://bugs.webkit.org/show_bug.cgi?id=88016

This caused multiple regressions (Requested by mrobinson on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-31

* WebCoreSupport/TextCheckerClientGtk.cpp:
(WebKit::TextCheckerClientGtk::checkSpellingOfString):
* webkit/webkitspellcheckerenchant.cpp:
(checkSpellingOfString):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119159 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix crash in V8Document::createTouchListCallback.
benm@google.com [Thu, 31 May 2012 22:34:01 +0000 (22:34 +0000)]
Fix crash in V8Document::createTouchListCallback.
https://bugs.webkit.org/show_bug.cgi?id=87085

Source/WebCore:

Reviewed by Abhishek Arya.

Test: fast/events/touch/document-create-touch-list-crash.html

* bindings/v8/custom/V8DocumentCustom.cpp:
(WebCore::V8Document::createTouchListCallback): Verify the native type
of the arguments passed to createTouchList are Touches before appending
them to the TouchList. In the case of a non-Touch argument, insert
null into the TouchList. This consolidates V8 and JSC bindings
behaviour.
* dom/Document.cpp: Remove dead code.
* dom/Document.h: ditto.

LayoutTests:

Test for crash in document.createTouchList when it
is supplied with non-touch parameters.

Reviewed by Abhishek Arya.

* fast/events/touch/document-create-touch-list-crash-expected.txt: Added.
* fast/events/touch/document-create-touch-list-crash.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119158 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoDataLog should be usable outside of JSC
fpizlo@apple.com [Thu, 31 May 2012 22:30:03 +0000 (22:30 +0000)]
DataLog should be usable outside of JSC
https://bugs.webkit.org/show_bug.cgi?id=88015

Reviewed by Oliver Hunt.

* wtf/DataLog.h:
(WTF):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119157 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUpdating test expectations after r119124.
rafaelw@chromium.org [Thu, 31 May 2012 22:18:40 +0000 (22:18 +0000)]
Updating test expectations after r119124.

* platform/chromium/fast/workers/storage/test-authorizer-sync-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119156 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Chromium] Chromium DRT should be able to load external resources
rniwa@webkit.org [Thu, 31 May 2012 21:51:07 +0000 (21:51 +0000)]
[Chromium] Chromium DRT should be able to load external resources
https://bugs.webkit.org/show_bug.cgi?id=87893

Reviewed by Dirk Pranke.

Allow external resources to be loaded when the main frame's URL is also an external resource.
This change is analogous to r118231 for Mac port.

* DumpRenderTree/chromium/WebViewHost.cpp:
(blockRequest):
(isLocalhost):
(hostIsUsedBySomeTestsToGenerateError):
(WebViewHost::willSendRequest):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119153 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRemove some duplicate code in RenderLayerCompositor
simon.fraser@apple.com [Thu, 31 May 2012 21:21:29 +0000 (21:21 +0000)]
Remove some duplicate code in RenderLayerCompositor
https://bugs.webkit.org/show_bug.cgi?id=88009

Reviewed by Anders Carlsson.

RenderLayerCompositor::hasNonAffineTransform() has the same code
as the existing RenderLayer::has3DTransform(), so just use the
RenderLayer method and remove hasNonAffineTransform().

No behavior change.

* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::computeCompositingRequirements):
* rendering/RenderLayerCompositor.h:
(RenderLayerCompositor):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119151 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Win] 5 fast/events/popup-* tests fail
jberlin@webkit.org [Thu, 31 May 2012 21:15:20 +0000 (21:15 +0000)]
[Win] 5 fast/events/popup-* tests fail
https://bugs.webkit.org/show_bug.cgi?id=88008

Add Windows-specific expected (failing?) results to get the bots greener.

* platform/win/fast/events/popup-allowed-from-gesture-initiated-event-expected.txt: Added.
* platform/win/fast/events/popup-allowed-from-gesture-initiated-form-submit-expected.txt: Added.
* platform/win/fast/events/popup-blocked-from-fake-user-gesture-expected.txt: Added.
* platform/win/fast/events/popup-blocked-from-untrusted-mouse-click-expected.txt: Added.
* platform/win/fast/events/popup-blocking-timers-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119149 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Win] 23 media tests fail / time out
jberlin@webkit.org [Thu, 31 May 2012 21:10:39 +0000 (21:10 +0000)]
[Win] 23 media tests fail / time out
https://bugs.webkit.org/show_bug.cgi?id=88005

Add/update the Windows expected (failing?) results to get the bots greener.

* platform/win/Skipped:
* platform/win/media/audio-controls-rendering-expected.txt:
* platform/win/media/audio-repaint-expected.txt:
* platform/win/media/controls-after-reload-expected.txt:
* platform/win/media/controls-strict-expected.txt:
* platform/win/media/controls-styling-expected.txt:
* platform/win/media/controls-without-preload-expected.txt:
* platform/win/media/media-can-play-wav-audio-expected.txt: Added.
* platform/win/media/media-controls-clone-expected.txt:
* platform/win/media/media-controls-invalid-url-expected.txt: Added.
* platform/win/media/media-document-audio-repaint-expected.txt:
* platform/win/media/nodesFromRect-shadowContent-expected.txt: Added.
* platform/win/media/video-colorspace-yuv420-expected.txt: Added.
* platform/win/media/video-colorspace-yuv422-expected.txt: Added.
* platform/win/media/video-controls-rendering-expected.txt:
* platform/win/media/video-display-toggle-expected.txt:
* platform/win/media/video-no-audio-expected.txt:
* platform/win/media/video-pause-immediately-expected.txt: Added.
* platform/win/media/video-playing-and-pause-expected.txt: Added.
* platform/win/media/video-size-intrinsic-scale-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119147 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed, rolling out r119125.
rafaelw@chromium.org [Thu, 31 May 2012 21:09:01 +0000 (21:09 +0000)]
Unreviewed, rolling out r119125.
http://trac.webkit.org/changeset/119125
https://bugs.webkit.org/show_bug.cgi?id=88007

Will break android build if rolled (Requested by rafaelw_ on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-31

Source/WebCore:

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement):
(WebCore::HTMLMediaElement::startProgressEventTimer):
(WebCore::HTMLMediaElement::changeNetworkStateFromLoadingToIdle):
(WebCore::HTMLMediaElement::progressEventTimerFired):
(WebCore::HTMLMediaElement::startPlaybackProgressTimer):
* platform/graphics/MediaPlayer.cpp:
(WebCore::NullMediaPlayerPrivate::bytesLoaded):
(WebCore::MediaPlayer::bytesLoaded):
* platform/graphics/MediaPlayer.h:
* platform/graphics/MediaPlayerPrivate.h:
(MediaPlayerPrivateInterface):
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::MediaPlayerPrivateAVFoundation):
(WebCore::MediaPlayerPrivateAVFoundation::bytesLoaded):
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
(MediaPlayerPrivateAVFoundation):
* platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:
(WebCore::MediaPlayerPrivate::bytesLoaded):
* platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.h:
(MediaPlayerPrivate):
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer):
(WebCore::MediaPlayerPrivateGStreamer::bytesLoaded):
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
(MediaPlayerPrivateGStreamer):
* platform/graphics/mac/MediaPlayerPrivateQTKit.h:
(MediaPlayerPrivateQTKit):
* platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::MediaPlayerPrivateQTKit::MediaPlayerPrivateQTKit):
(WebCore::MediaPlayerPrivateQTKit::bytesLoaded):
* platform/graphics/qt/MediaPlayerPrivateQt.cpp:
(WebCore::MediaPlayerPrivateQt::MediaPlayerPrivateQt):
(WebCore::MediaPlayerPrivateQt::bytesLoaded):
* platform/graphics/qt/MediaPlayerPrivateQt.h:
(MediaPlayerPrivateQt):
* platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::MediaPlayerPrivateQuickTimeVisualContext):
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::bytesLoaded):
* platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.h:
(MediaPlayerPrivateQuickTimeVisualContext):
* platform/graphics/wince/MediaPlayerPrivateWinCE.h:
(MediaPlayerPrivate):

Source/WebKit/chromium:

* public/WebMediaPlayer.h:
(WebMediaPlayer):
* src/WebMediaPlayerClientImpl.cpp:
(WebKit::WebMediaPlayerClientImpl::bytesLoaded):
* src/WebMediaPlayerClientImpl.h:
(WebMediaPlayerClientImpl):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119146 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoDisentangle code that relies on USE(AUTOMATIC_TEXT_REPLACEMENT) from that which merel...
aestes@apple.com [Thu, 31 May 2012 21:03:16 +0000 (21:03 +0000)]
Disentangle code that relies on USE(AUTOMATIC_TEXT_REPLACEMENT) from that which merely relies on PLATFORM(MAC)
https://bugs.webkit.org/show_bug.cgi?id=87933

Reviewed by Dan Bernstein.

Source/WebCore:

* editing/Editor.cpp:
* editing/Editor.h:
* loader/EmptyClients.h:
* page/ContextMenuController.cpp:
(WebCore::ContextMenuController::contextMenuItemSelected):
* page/EditorClient.h:

Source/WebKit/mac:

* WebCoreSupport/WebEditorClient.h:
* WebCoreSupport/WebEditorClient.mm:

Source/WebKit2:

* WebProcess/WebCoreSupport/WebEditorClient.h:
* WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119145 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Win] fast/events/remove-target* tests fail
jberlin@webkit.org [Thu, 31 May 2012 20:58:29 +0000 (20:58 +0000)]
[Win] fast/events/remove-target* tests fail
https://bugs.webkit.org/show_bug.cgi?id=88006

Add Windows-specific expected (failing?) results to get the bots greener.

* platform/win/fast/events/remove-target-in-mouseup-deep-expected.txt: Added.
* platform/win/fast/events/remove-target-in-mouseup-expected.txt: Added.
* platform/win/fast/events/remove-target-in-mouseup-insertback-expected.txt: Added.
* platform/win/fast/events/remove-target-in-mouseup-twice-expected.txt: Added.
* platform/win/fast/events/remove-target-with-shadow-in-drag-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119144 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoDisable support for rvalue references until I figure out why this is breaking the...
andersca@apple.com [Thu, 31 May 2012 20:55:17 +0000 (20:55 +0000)]
Disable support for rvalue references until I figure out why this is breaking the Xcode 4.2 build.

* wtf/Compiler.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119143 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[EFL] Gardening; skip fast/canvas/canvas-imageSmoothingEnabled.
rakuco@webkit.org [Thu, 31 May 2012 20:53:10 +0000 (20:53 +0000)]
[EFL] Gardening; skip fast/canvas/canvas-imageSmoothingEnabled.

Skip the test just like GTK+, as there seems to be a problem in
the cairo backend that makes the test fail.

* platform/efl/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119142 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoBuild fixes.
andersca@apple.com [Thu, 31 May 2012 20:44:21 +0000 (20:44 +0000)]
Build fixes.

Disable the C++11 extensions warning.

* DumpRenderTree/mac/Configurations/Base.xcconfig:
* TestWebKitAPI/Configurations/Base.xcconfig:
* WebKitTestRunner/Configurations/Base.xcconfig:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119140 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[chromium] Move drawing code for RenderSurfaces into LayerRendererChromium
danakj@chromium.org [Thu, 31 May 2012 20:41:38 +0000 (20:41 +0000)]
[chromium] Move drawing code for RenderSurfaces into LayerRendererChromium
https://bugs.webkit.org/show_bug.cgi?id=87877

Reviewed by James Robinson.

Source/WebCore:

We add data to CCRenderSurfaceDrawQuad so that the only use of
CCRenderSurface directly from LayerRendererChromium is to
reserve, release, and use the surface's textures, and to set the
scissor rect. Each of these changes will be done independent
of this change.

Covered by existing tests.

* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::applyFilters):
(WebCore):
(WebCore::LayerRendererChromium::drawBackgroundFilters):
(WebCore::LayerRendererChromium::drawRenderSurfaceQuad):
(WebCore::LayerRendererChromium::copyTextureToFramebuffer):
* platform/graphics/chromium/LayerRendererChromium.h:
(LayerRendererChromium):
* platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::contentsTextureId):
* platform/graphics/chromium/cc/CCLayerImpl.h:
(CCLayerImpl):
* platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
(WebCore::calculateDrawTransformsAndVisibilityInternal):
* platform/graphics/chromium/cc/CCQuadCuller.cpp:
* platform/graphics/chromium/cc/CCQuadCuller.h:
(CCQuadCuller):
* platform/graphics/chromium/cc/CCRenderPass.cpp:
(WebCore::CCRenderPass::appendQuadsForRenderSurfaceLayer):
* platform/graphics/chromium/cc/CCRenderSurface.cpp:
(WebCore):
(WebCore::CCRenderSurface::CCRenderSurface):
(WebCore::CCRenderSurface::prepareContentsTexture):
(WebCore::CCRenderSurface::releaseContentsTexture):
(WebCore::CCRenderSurface::hasValidContentsTexture):
(WebCore::CCRenderSurface::releaseBackgroundTexture):
(WebCore::CCRenderSurface::hasValidBackgroundTexture):
(WebCore::CCRenderSurface::hasMask):
(WebCore::CCRenderSurface::replicaHasMask):
(WebCore::CCRenderSurface::appendQuads):
* platform/graphics/chromium/cc/CCRenderSurface.h:
(WebCore):
(CCRenderSurface):
* platform/graphics/chromium/cc/CCRenderSurfaceDrawQuad.cpp:
(WebCore::CCRenderSurfaceDrawQuad::create):
(WebCore::CCRenderSurfaceDrawQuad::CCRenderSurfaceDrawQuad):
* platform/graphics/chromium/cc/CCRenderSurfaceDrawQuad.h:
(WebKit):
(CCRenderSurfaceDrawQuad):
(WebCore::CCRenderSurfaceDrawQuad::maskTextureId):
(WebCore::CCRenderSurfaceDrawQuad::filters):
(WebCore::CCRenderSurfaceDrawQuad::backgroundFilters):
* platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
(WebCore::CCTiledLayerImpl::contentsTextureId):
* platform/graphics/chromium/cc/CCTiledLayerImpl.h:
(CCTiledLayerImpl):

Source/WebKit/chromium:

* tests/CCRenderSurfaceTest.cpp:
(WebCore::TEST):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119139 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Win] 10 fast/text tests failing
jberlin@webkit.org [Thu, 31 May 2012 20:28:36 +0000 (20:28 +0000)]
[Win] 10 fast/text tests failing
https://bugs.webkit.org/show_bug.cgi?id=87998

Add/update Windows-specific expected (failing?) pixel results in order to get the bots greener.

* platform/win/fast/text/complex-preferred-logical-widths-expected.png: Added.
* platform/win/fast/text/complex-synthetic-bold-space-width-expected.png: Added.
* platform/win/fast/text/international/arabic-justify-expected.png: Added.
* platform/win/fast/text/international/bidi-mirror-he-ar-expected.png:
* platform/win/fast/text/international/float-as-only-child-of-isolate-crash-expected.png: Added.
* platform/win/fast/text/international/text-combine-image-test-expected.png:
* platform/win/fast/text/international/text-spliced-font-expected.png: Added.
* platform/win/fast/text/line-initial-and-final-swashes-expected.png: Added.
* platform/win/fast/text/midword-break-before-surrogate-pair-2-expected.png: Added.
* platform/win/fast/text/unicode-variation-selector-expected.png: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119138 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed gardening, updating baselines after r119124.
zandobersek@gmail.com [Thu, 31 May 2012 20:16:07 +0000 (20:16 +0000)]
Unreviewed gardening, updating baselines after r119124.

* dom/xhtml/level3/core/documentnormalizedocument10-expected.txt:
* dom/xhtml/level3/core/documentsetxmlversion03-expected.txt:
* fast/workers/storage/test-authorizer-sync-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119137 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago<rdar://problem/11544454> and https://bugs.webkit.org/show_bug.cgi?id=87990
beidson@apple.com [Thu, 31 May 2012 19:58:01 +0000 (19:58 +0000)]
<rdar://problem/11544454> and https://bugs.webkit.org/show_bug.cgi?id=87990
Crashes unregistering DOMWindowProperties while releasing CachedPages

Reviewed by Jessie Berlin.

This patch rewrites DOMWindowProperty to always keep direct track of the DOMWindow
it has registered with and to only ever unregister from that very same DOMWindow.

No new tests. (While the direct cause of the crash is understood, reproducing it is not)

* page/DOMWindowProperty.cpp:
(WebCore::DOMWindowProperty::DOMWindowProperty):
(WebCore::DOMWindowProperty::~DOMWindowProperty):
(WebCore::DOMWindowProperty::disconnectFrameForPageCache):
(WebCore::DOMWindowProperty::reconnectFrameFromPageCache):
(WebCore::DOMWindowProperty::willDestroyGlobalObjectInCachedFrame):
(WebCore::DOMWindowProperty::willDestroyGlobalObjectInFrame):
(WebCore::DOMWindowProperty::willDetachGlobalObjectFromFrame):
* page/DOMWindowProperty.h:
(DOMWindowProperty):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119136 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Blackberry] Initialize the select client and delete the pointer
staikos@webkit.org [Thu, 31 May 2012 19:30:33 +0000 (19:30 +0000)]
[Blackberry] Initialize the select client and delete the pointer
in the destructor so it doesn't leak.  Fixes test crashes.
https://bugs.webkit.org/show_bug.cgi?id=87992

Reviewed by Rob Buis.

* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::InputHandler):
(BlackBerry::WebKit::InputHandler::~InputHandler):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119134 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoVector should have a move constructor and move assignment operator
andersca@apple.com [Thu, 31 May 2012 19:12:30 +0000 (19:12 +0000)]
Vector should have a move constructor and move assignment operator
https://bugs.webkit.org/show_bug.cgi?id=87997

Reviewed by Andreas Kling.

* wtf/Compiler.h:
Use __has_extension so we can use move semantics and other C++11 features even when building as C++98.

* wtf/Vector.h:
Add a move constructor and a move assignment operator to Vector.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119132 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agorename flexbox CSS properties from flex-align and flex-item-align to align-items...
tony@chromium.org [Thu, 31 May 2012 19:08:19 +0000 (19:08 +0000)]
rename flexbox CSS properties from flex-align and flex-item-align to align-items and align-self
https://bugs.webkit.org/show_bug.cgi?id=87907

Reviewed by Ojan Vafai.

Source/WebCore:

This was recently changed in the spec:
http://dev.w3.org/csswg/css3-flexbox/#align-items-property

No new tests, updated the tests to use the new naming.

* css/CSSComputedStyleDeclaration.cpp:
(WebCore):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
* css/CSSParser.cpp:
(WebCore::isValidKeywordPropertyAndValue):
(WebCore::isKeywordPropertyID):
(WebCore::CSSParser::parseValue):
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator EAlignItems):
* css/CSSProperty.cpp:
(WebCore::CSSProperty::isInheritedProperty):
* css/CSSPropertyNames.in:
* css/StyleBuilder.cpp:
(WebCore::StyleBuilder::StyleBuilder):
* css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRulesForList):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::sizesToIntrinsicLogicalWidth):
* rendering/RenderFlexibleBox.cpp:
(WebCore::alignmentForChild):
(WebCore::RenderFlexibleBox::layoutAndPlaceChildren):
(WebCore::RenderFlexibleBox::alignChildren):
* rendering/style/RenderStyle.h:
* rendering/style/RenderStyleConstants.h:
* rendering/style/StyleFlexibleBoxData.cpp:
(WebCore::StyleFlexibleBoxData::StyleFlexibleBoxData):
(WebCore::StyleFlexibleBoxData::operator==):
* rendering/style/StyleFlexibleBoxData.h:
(StyleFlexibleBoxData): Move member variables to StyleRareNonInheritedData
because these values will eventually apply to more than just flexbox.
* rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):
* rendering/style/StyleRareNonInheritedData.h:
(StyleRareNonInheritedData):

LayoutTests:

Updated tests for new CSS property names.

* css3/flexbox/align-absolute-child.html:
* css3/flexbox/cross-axis-scrollbar.html:
* css3/flexbox/css-properties-expected.txt:
* css3/flexbox/css-properties.html:
* css3/flexbox/flex-align-baseline.html:
* css3/flexbox/flex-align-column.html:
* css3/flexbox/flex-align-end.html:
* css3/flexbox/flex-align-stretch.html:
* css3/flexbox/flex-align-vertical-writing-mode.html:
* css3/flexbox/flex-align.html:
* css3/flexbox/line-wrapping.html:
* css3/flexbox/multiline-align.html:
* css3/flexbox/multiline-reverse-wrap-baseline.html:
* css3/flexbox/orthogonal-flex-directions.html:
* css3/flexbox/position-absolute-child.html:
* css3/flexbox/true-centering.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119131 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Win] 10 fast/text tests failing
jberlin@webkit.org [Thu, 31 May 2012 18:52:35 +0000 (18:52 +0000)]
[Win] 10 fast/text tests failing
https://bugs.webkit.org/show_bug.cgi?id=87998

Add/update Windows-specific expected (failing?) results in order to get the bots greener.

* platform/win/fast/text/complex-preferred-logical-widths-expected.txt: Added.
* platform/win/fast/text/complex-synthetic-bold-space-width-expected.txt: Added.
* platform/win/fast/text/international/arabic-justify-expected.txt: Added.
* platform/win/fast/text/international/bidi-mirror-he-ar-expected.txt: Added.
* platform/win/fast/text/international/float-as-only-child-of-isolate-crash-expected.txt: Added.
* platform/win/fast/text/international/text-combine-image-test-expected.txt:
* platform/win/fast/text/international/text-spliced-font-expected.txt: Added.
* platform/win/fast/text/line-initial-and-final-swashes-expected.txt: Added.
* platform/win/fast/text/midword-break-before-surrogate-pair-2-expected.txt: Added.
* platform/win/fast/text/unicode-variation-selector-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119130 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[chromium] Add copy constructor to WebFilterOperations
danakj@chromium.org [Thu, 31 May 2012 18:48:47 +0000 (18:48 +0000)]
[chromium] Add copy constructor to WebFilterOperations
https://bugs.webkit.org/show_bug.cgi?id=87970

Reviewed by James Robinson.

* chromium/public/WebFilterOperations.h:
(WebKit::WebFilterOperations::WebFilterOperations):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119129 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUpdating test expectations (svg/as-image/animated-svg-as-image.html)
rafaelw@chromium.org [Thu, 31 May 2012 18:37:19 +0000 (18:37 +0000)]
Updating test expectations (svg/as-image/animated-svg-as-image.html)

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119128 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago [WK2] window.internals settings are not reset between tests
ap@apple.com [Thu, 31 May 2012 18:11:55 +0000 (18:11 +0000)]
    [WK2] window.internals settings are not reset between tests
        https://bugs.webkit.org/show_bug.cgi?id=87783

        Reviewed by Mihai Parparita.

        * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
        (WTR::InjectedBundle::done): Call resetAfterTest().

        * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
        (WTR::InjectedBundlePage::prepare): Renamed from "reset" for clarity.
        (WTR::InjectedBundlePage::resetAfterTest): Added a function that resets internals.
        This needs to be done after a tets, because the code assumes that there is an object
        with this name in global scope.

        * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119127 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[BlackBerry] Crash when destroying WebOverlay with active WebOverlayOverride
commit-queue@webkit.org [Thu, 31 May 2012 18:09:33 +0000 (18:09 +0000)]
[BlackBerry] Crash when destroying WebOverlay with active WebOverlayOverride
https://bugs.webkit.org/show_bug.cgi?id=87968

Patch by Arvid Nilsson <anilsson@rim.com> on 2012-05-31
Reviewed by Rob Buis.

The override object is using a compositing thread WebOverlayPrivate
object with no client because the layer doesn't delegate drawing to the
WebOverlayPrivate, it's only used to modify the override properties on
the underlying compositing thread layer.

Since the m_layerCompositingThreadClient is optional, we have to add
null checks.

* Api/WebOverlay.cpp:
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::~WebOverlayPrivateCompositingThread):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::setClient):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::setContentsToImage):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::setContentsToColor):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::setDrawsContent):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::invalidate):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119126 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoReplace WebMediaPlayer::bytesLoaded() with an explicit didLoadingProgress()
fischman@chromium.org [Thu, 31 May 2012 18:03:28 +0000 (18:03 +0000)]
Replace WebMediaPlayer::bytesLoaded() with an explicit didLoadingProgress()
https://bugs.webkit.org/show_bug.cgi?id=86113

Reviewed by Eric Carlson.

Source/WebCore:

No new functionality, so no new tests.  Loading progress is already tested by existing layouttests.

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement):
(WebCore::HTMLMediaElement::startProgressEventTimer):
(WebCore::HTMLMediaElement::changeNetworkStateFromLoadingToIdle):
(WebCore::HTMLMediaElement::progressEventTimerFired):
(WebCore::HTMLMediaElement::startPlaybackProgressTimer):
* platform/graphics/MediaPlayer.cpp:
(WebCore::NullMediaPlayerPrivate::didLoadingProgress):
(WebCore::MediaPlayer::didLoadingProgress):
* platform/graphics/MediaPlayer.h:
* platform/graphics/MediaPlayerPrivate.h:
(MediaPlayerPrivateInterface):
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::MediaPlayerPrivateAVFoundation):
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
(MediaPlayerPrivateAVFoundation):
* platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:
(WebCore::MediaPlayerPrivate::didLoadingProgress):
* platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.h:
(MediaPlayerPrivate):
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer):
(WebCore::MediaPlayerPrivateGStreamer::didLoadingProgress):
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
(MediaPlayerPrivateGStreamer):
* platform/graphics/mac/MediaPlayerPrivateQTKit.h:
(MediaPlayerPrivateQTKit):
* platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::MediaPlayerPrivateQTKit::MediaPlayerPrivateQTKit):
(WebCore::MediaPlayerPrivateQTKit::didLoadingProgress):
* platform/graphics/qt/MediaPlayerPrivateQt.cpp:
(WebCore::MediaPlayerPrivateQt::MediaPlayerPrivateQt):
(WebCore::MediaPlayerPrivateQt::didLoadingProgress):
* platform/graphics/qt/MediaPlayerPrivateQt.h:
(MediaPlayerPrivateQt):
* platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::MediaPlayerPrivateQuickTimeVisualContext):
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::didLoadingProgress):
* platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.h:
(MediaPlayerPrivateQuickTimeVisualContext):
* platform/graphics/wince/MediaPlayerPrivateWinCE.h:
(MediaPlayerPrivate):

Source/WebKit/chromium:

* public/WebMediaPlayer.h:
(WebMediaPlayer):
* src/WebMediaPlayerClientImpl.cpp:
(WebKit::WebMediaPlayerClientImpl::didLoadingProgress):
* src/WebMediaPlayerClientImpl.h:
(WebMediaPlayerClientImpl):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119125 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoMake DOM Exceptions Errors
arv@chromium.org [Thu, 31 May 2012 18:00:03 +0000 (18:00 +0000)]
Make DOM Exceptions Errors
https://bugs.webkit.org/show_bug.cgi?id=85078

Reviewed by Oliver Hunt.

WebIDL mandates that exceptions should have Error.prototype on its prototype chain.

For JSC we have access to the Error.prototype from the binding code.

For V8 we set a field in the WrapperTypeInfo and when the constructor function is created we
set the prototype as needed.

Updated test: fast/dom/DOMException/prototype-object.html

Source/JavaScriptCore:

* JavaScriptCore.xcodeproj/project.pbxproj:
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::reset):
* runtime/JSGlobalObject.h:
(JSC):
(JSGlobalObject):
(JSC::JSGlobalObject::errorPrototype):

Source/WebCore:

* ForwardingHeaders/runtime/ErrorPrototype.h: Added.
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateImplementation):
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateNamedConstructorCallback):
(GenerateImplementation):
* bindings/scripts/test/JS/JSTestException.cpp:
(WebCore::JSTestException::createPrototype):
* bindings/scripts/test/JS/JSTestException.h:
* bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestEventConstructor.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestException.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestNode.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore):
(WebCore::V8TestObj::installPerContextProperties):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore):
* bindings/v8/NPV8Object.cpp:
(WebCore::npObjectTypeInfo):
* bindings/v8/V8BindingPerContextData.cpp:
(WebCore):
(WebCore::V8BindingPerContextData::init):
(WebCore::V8BindingPerContextData::createWrapperFromCacheSlowCase):
(WebCore::V8BindingPerContextData::constructorForTypeSlowCase):
* bindings/v8/V8BindingPerContextData.h:
(V8BindingPerContextData):
* bindings/v8/V8HiddenPropertyName.h:
(WebCore):
* bindings/v8/WrapperTypeInfo.h:
(WebCore):
(WrapperTypeInfo):
* bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
(WebCore):

LayoutTests:

* fast/dom/DOMException/prototype-object-expected.txt:
* fast/dom/DOMException/prototype-object.html:
* fast/dom/DOMException/resources/prototype-object.js: Removed.
* platform/chromium-win/fast/dom/NamedNodeMap-setNamedItem-crash-expected.txt: Removed.
* platform/chromium-win/fast/dom/timer-clear-interval-in-handler-and-generate-error-expected.txt: Removed.
* platform/chromium-win/svg/filters/feBlend-invalid-mode-expected.txt: Removed.
* platform/chromium/dom/xhtml/level3/core/documentnormalizedocument10-expected.txt: Added.
* platform/chromium/dom/xhtml/level3/core/documentsetxmlversion03-expected.txt: Added.
* platform/chromium/fast/dom/DOMException/prototype-object-expected.txt:
* platform/chromium/fast/dom/NamedNodeMap-setNamedItem-crash-expected.txt: Renamed from LayoutTests/platform/chromium-mac/fast/dom/NamedNodeMap-setNamedItem-crash-expected.txt.
* platform/chromium/fast/dom/timer-clear-interval-in-handler-and-generate-error-expected.txt: Renamed from LayoutTests/platform/chromium-mac/fast/dom/timer-clear-interval-in-handler-and-generate-error-expected.txt.
* platform/chromium/svg/filters/feBlend-invalid-mode-expected.txt: Renamed from LayoutTests/platform/chromium-mac/svg/filters/feBlend-invalid-mode-expected.txt.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119124 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Win] ASSERT(oldLayoutDelta == view()->layoutDelta()) failed in RenderBlock::layoutBl...
jberlin@webkit.org [Thu, 31 May 2012 17:56:12 +0000 (17:56 +0000)]
[Win] ASSERT(oldLayoutDelta == view()->layoutDelta()) failed in RenderBlock::layoutBlockChild
when running media/media-volume-slider-rendered-below.html
https://bugs.webkit.org/show_bug.cgi?id=87450

Add the test to the Windows Skipped list to get the bots greener.

* platform/win/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119123 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[chromium] create WebTransformOperation interface for chromium platform
commit-queue@webkit.org [Thu, 31 May 2012 17:38:08 +0000 (17:38 +0000)]
[chromium] create WebTransformOperation interface for chromium platform
https://bugs.webkit.org/show_bug.cgi?id=87510

Patch by Ian Vollick <vollick@chromium.org> on 2012-05-31
Reviewed by James Robinson.

Source/Platform:

* Platform.gypi:
* chromium/public/WebTransformOperations.h: Added.
(WebKit):
(WebTransformOperations):
(WebKit::WebTransformOperations::~WebTransformOperations):
(WebKit::WebTransformOperations::WebTransformOperations):
(WebKit::WebTransformOperations::operator=):

Source/WebCore:

Unit tests:
    WebTransformOperationsTest.transformTypesAreUnique
    WebTransformOperationsTest.matchesTypesSameLength
    WebTransformOperationsTest.matchesTypesDifferentLength
    WebTransformOperationsTest.applyTranslate
    WebTransformOperationsTest.applyRotate
    WebTransformOperationsTest.applyScale
    WebTransformOperationsTest.applySkew
    WebTransformOperationsTest.applyPerspective
    WebTransformOperationsTest.applyMatrix
    WebTransformOperationsTest.applyOrder
    WebTransformOperationsTest.blendOrder
    WebTransformOperationsTest.blendProgress
    WebTransformOperationsTest.blendWhenTypesDoNotMatch

* WebCore.gypi:
* platform/chromium/support/WebTransformOperations.cpp: Added.
(WebKit):
(WebTransformOperationsPrivate):
(WebKit::WebTransformOperations::apply):
(WebKit::WebTransformOperations::blend):
(WebKit::WebTransformOperations::matchesTypes):
(WebKit::WebTransformOperations::appendTranslate):
(WebKit::WebTransformOperations::appendRotate):
(WebKit::WebTransformOperations::appendScale):
(WebKit::WebTransformOperations::appendSkew):
(WebKit::WebTransformOperations::appendPerspective):
(WebKit::WebTransformOperations::appendMatrix):
(WebKit::WebTransformOperations::reset):
(WebKit::WebTransformOperations::initialize):

Source/WebKit/chromium:

* WebKit.gypi:
* tests/WebTransformOperationsTest.cpp: Added.
(TEST):
(checkProgress):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119121 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago10 W3C video and audio canPlayType tests are failing on Mac and Win
jberlin@webkit.org [Thu, 31 May 2012 17:35:18 +0000 (17:35 +0000)]
10 W3C video and audio canPlayType tests are failing on Mac and Win
https://bugs.webkit.org/show_bug.cgi?id=75184

Add Windows-specific expected (failing?) results to get the bots greener.

* platform/win/media/W3C: Added.
* platform/win/media/W3C/audio: Added.
* platform/win/media/W3C/audio/canPlayType: Added.
* platform/win/media/W3C/audio/canPlayType/canPlayType_supported_but_no_codecs_parameter_1-expected.txt: Added.
* platform/win/media/W3C/audio/canPlayType/canPlayType_supported_but_no_codecs_parameter_2-expected.txt: Added.
* platform/win/media/W3C/video: Added.
* platform/win/media/W3C/video/canPlayType: Added.
* platform/win/media/W3C/video/canPlayType/canPlayType_codecs_order_2-expected.txt: Added.
* platform/win/media/W3C/video/canPlayType/canPlayType_codecs_order_3-expected.txt: Added.
* platform/win/media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_2-expected.txt: Added.
* platform/win/media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_3-expected.txt: Added.
* platform/win/media/W3C/video/canPlayType/canPlayType_two_implies_one_3-expected.txt: Added.
* platform/win/media/W3C/video/canPlayType/canPlayType_two_implies_one_4-expected.txt: Added.
* platform/win/media/W3C/video/canPlayType/canPlayType_two_implies_one_5-expected.txt: Added.
* platform/win/media/W3C/video/canPlayType/canPlayType_two_implies_one_6-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119120 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Blackberry] WebKit's fullscreen mode needs to notify page client.
commit-queue@webkit.org [Thu, 31 May 2012 17:33:39 +0000 (17:33 +0000)]
[Blackberry] WebKit's fullscreen mode needs to notify page client.
https://bugs.webkit.org/show_bug.cgi?id=87337

Patch by Chris Guan <chris.guan@torchmobile.com.cn> on 2012-05-31
Reviewed by Antonio Gomes.

Move "fullScreenVideoCapable" into webpagePrivate to make code
clean for "fullScreenForElement/Node" of cromeClientBlackberry,
All Video checks and code path selections are in webpagePrivate now.
For some UX and secure reasons, we could not apply fullscreen capacity
for all elements, So we use client's fullscreenStart/Stop only for
those video elements and those elements containing video tags.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::webContext):
(BlackBerry::WebKit::WebPage::notifyFullScreenVideoExited):
(WebKit):
(BlackBerry::WebKit::containsVideoTags):
(BlackBerry::WebKit::WebPagePrivate::enterFullScreenForElement):
(BlackBerry::WebKit::WebPagePrivate::exitFullScreenForElement):
* Api/WebPageClient.h:
* Api/WebPage_p.h:
(WebCore):
(WebPagePrivate):
* WebCoreSupport/ChromeClientBlackBerry.cpp:
(WebCore::ChromeClientBlackBerry::enterFullScreenForElement):
(WebCore::ChromeClientBlackBerry::exitFullScreenForElement):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119119 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[GTK] Memory leak in webkit_web_view_init
commit-queue@webkit.org [Thu, 31 May 2012 17:29:02 +0000 (17:29 +0000)]
[GTK] Memory leak in webkit_web_view_init
https://bugs.webkit.org/show_bug.cgi?id=87943

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-05-31
Reviewed by Martin Robinson.

Fixed a memory leak in webkit_web_view_init by making the
UserMediaClientGtk to be owned by the WebView.

* webkit/webkitwebview.cpp:
(webkit_web_view_init):
* webkit/webkitwebviewprivate.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119118 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix reference to unset variable in debug mode
wingo@igalia.com [Thu, 31 May 2012 17:28:21 +0000 (17:28 +0000)]
Fix reference to unset variable in debug mode
https://bugs.webkit.org/show_bug.cgi?id=87981

Reviewed by Geoffrey Garen.

* runtime/JSONObject.cpp (Stringifier::Holder::Holder):
Initialize m_size in debug mode, as we check it later in an assert.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119117 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[EFL][DRT] EFL's DRT navigation_policy_decision implementation
commit-queue@webkit.org [Thu, 31 May 2012 17:15:20 +0000 (17:15 +0000)]
[EFL][DRT] EFL's DRT navigation_policy_decision implementation
https://bugs.webkit.org/show_bug.cgi?id=85006

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-05-31
Reviewed by Tor Arne Vestbø.

Tools:

Added navigation_policy_decision implementation for DumpRenderTreeView.
Added LayoutTestController::setCustomPolicyDelegate implementation.
Modified LayoutTestController::waitForPolicyDelegate.

* DumpRenderTree/efl/DumpRenderTree.cpp:
* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::resetDefaultsToConsistentValues):
* DumpRenderTree/efl/DumpRenderTreeEfl.h:
* DumpRenderTree/efl/DumpRenderTreeView.cpp:
(navigationTypeToString): aux function
(onNavigationPolicyDecision): navigation_policy_decision implementation
(drtViewAdd):
* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::setCustomPolicyDelegate):
(LayoutTestController::waitForPolicyDelegate):

LayoutTests:

Unskipped corresponding tests. Those still not passing are put into
test_expectations.txt.

* platform/efl/Skipped:
* platform/efl/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119116 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[EFL][DRT] LayoutTestController does not implement clearApplicationCacheForOrigin
commit-queue@webkit.org [Thu, 31 May 2012 17:00:02 +0000 (17:00 +0000)]
[EFL][DRT] LayoutTestController does not implement clearApplicationCacheForOrigin
https://bugs.webkit.org/show_bug.cgi?id=86195

Patch by Jussi Kukkonen <jussi.kukkonen@intel.com> on 2012-05-31
Reviewed by Gustavo Noronha Silva.

Source/WebKit/efl:

add new function to clear security origin application cache,
and a function to create a security origin from url string.
Reindent the header to match new longer return signature.

* ewk/ewk_security_origin.cpp:
(ewk_security_origin_application_cache_clear):
(ewk_security_origin_new_from_string):
* ewk/ewk_security_origin.h:

Tools:

Implement clearApplicationCacheForOrigin in EFL
LayoutTestController.

* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::clearApplicationCacheForOrigin):

LayoutTests:

Unskip http/tests/appcache/origin-delete.html now that
EFL TestLayoutController has required functionality.

* platform/efl/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119115 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agom_totalAllocated should be intialized in RenderArena constructor
yurys@chromium.org [Thu, 31 May 2012 16:53:16 +0000 (16:53 +0000)]
m_totalAllocated should be intialized in RenderArena constructor
https://bugs.webkit.org/show_bug.cgi?id=87967

Reviewed by Ojan Vafai.

* rendering/RenderArena.cpp:
(WebCore::RenderArena::RenderArena): added missing initializer.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119114 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoSpell checker doesn't recognize contractions (apostrophes)
commit-queue@webkit.org [Thu, 31 May 2012 16:36:29 +0000 (16:36 +0000)]
Spell checker doesn't recognize contractions (apostrophes)
https://bugs.webkit.org/show_bug.cgi?id=86118

Patch by commit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc> on 2012-05-31
Reviewed by Gustavo Noronha Silva.

The Enchant spell checker was breaking words on apostrophes, because
apparently they were always being detected as Pango word-end
characters. To know whether or not the apostrophe is a
word end character requires looking at a string with a larger
granularity than one character.

Simplify the way the we break strings, by search for non-graphable
character manually to find word starts and ends. This has the side
effect of removing the dependency on Pango and eliminating one copy.

This change also cleans up some misbehavior on the part of the
WebCoreSupport layer which was not converting from Unicode character
offsets to UTF-16. These offsets can be different if any of the
characters in the UTF-16 string are surrogate pairs (non BMP
characters).

* WebCoreSupport/TextCheckerClientGtk.cpp:
(WebKit::TextCheckerClientGtk::checkSpellingOfString): Properly
convert from Unicode offsets to UTF-16 offsets.
* webkit/webkitspellcheckerenchant.cpp:
(findByteOffsetToFirstNonGraphableCharacter): Added this helper.
(getExtentsOfNextWord): Ditto.
(wordIsSpelledCorrectlyInAtLeastOneDictionary): Ditto.
(checkSpellingOfString): Don't split words on apostrophes.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119113 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[GTK] Unreviewed. Added FAIL expectation due to failure after r119100.
mario@webkit.org [Thu, 31 May 2012 16:32:33 +0000 (16:32 +0000)]
[GTK] Unreviewed. Added FAIL expectation due to failure after r119100.

* platform/gtk/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119112 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Win] 6 canvas tests failing
jberlin@webkit.org [Thu, 31 May 2012 16:08:15 +0000 (16:08 +0000)]
[Win] 6 canvas tests failing
https://bugs.webkit.org/show_bug.cgi?id=87983

Add Windows-specific expected (failing?) results to get the bots greener.

* platform/win/fast/canvas/canvas-draw-canvas-on-canvas-shadow-expected.txt: Added.
* platform/win/fast/canvas/canvas-fillRect-gradient-shadow-expected.txt: Added.
* platform/win/fast/canvas/canvas-scale-drawImage-shadow-expected.txt: Added.
* platform/win/fast/canvas/canvas-scale-fillPath-shadow-expected.txt: Added.
* platform/win/fast/canvas/canvas-scale-fillRect-shadow-expected.txt: Added.
* platform/win/fast/canvas/canvas-transforms-fillRect-shadow-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119111 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoThe difference between a column and a column group renderer is badly drawn
jchaffraix@webkit.org [Thu, 31 May 2012 16:00:20 +0000 (16:00 +0000)]
The difference between a column and a column group renderer is badly drawn
https://bugs.webkit.org/show_bug.cgi?id=87556

Reviewed by Abhishek Arya.

No expected change in behavior.

This patch tries to draw a better line between those 3 concepts:
- renderer is a RenderTableCol (RenderObject::isRenderTableCol).
- renderer is a column (RenderTableCol::isTableColumn()).
- renderer is a column group (RenderTableCol::isTableColumnGroup()).
(most of the code that needs to know the difference manipulate a RenderTableCol
so there was no need to move the 2 last helpers into RenderObject)

* rendering/AutoTableLayout.cpp:
(WebCore::AutoTableLayout::recalcColumn):
Factored the code to use the column / column group iteration we
set up in the rest of the code. Made the code more self-describing
by using more RenderTableCol functions.

* rendering/RenderObject.cpp:
(WebCore::RenderObject::addChild):
Factored the code to use the isTableColumn() and isTableColumnGroup() to
better underline what we check.

* rendering/RenderObject.h:
(WebCore::RenderObject::isRenderTableCol):
(WebCore::RenderObject::isTablePart):
Renamed isTableCol to isRenderTableCol to match the class as this doesn't
imply that the renderer is actually a column.

* html/HTMLTableColElement.cpp:
(WebCore::HTMLTableColElement::parseAttribute):
* rendering/AutoTableLayout.cpp:
(WebCore::AutoTableLayout::fullRecalc):
* rendering/RenderTable.cpp:
(WebCore::RenderTable::addChild):
(WebCore::RenderTable::layout):
(WebCore::RenderTable::firstColumn):
Updated after the isRenderTableCol rename.

* dom/Text.cpp:
(WebCore::Text::rendererIsNeeded):
* editing/htmlediting.cpp:
(WebCore::isTableStructureNode):
Ditto and renamed some variables.

* html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::rendererIsNeeded):
Ditto and added a FIXME as the logic doesn't seem very bullet proof.

* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::computeCollapsedStartBorder):
(WebCore::RenderTableCell::computeCollapsedEndBorder):
(WebCore::RenderTableCell::computeCollapsedBeforeBorder):
(WebCore::RenderTableCell::computeCollapsedAfterBorder):
Changed to use the enclosingColumnGroup* helpers.

* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::paintCell):
* rendering/RenderTableCol.cpp:
(WebCore::RenderTableCol::isChildAllowed):
(WebCore::RenderTableCol::canHaveChildren):
(WebCore::RenderTableCol::enclosingColumnGroup):
(WebCore::RenderTableCol::nextColumn):
Updated to use the new functions.

* rendering/RenderTableCol.h:
(WebCore::RenderTableCol::isTableColumn):
(WebCore::RenderTableCol::isTableColumnGroup):
(WebCore::RenderTableCol::enclosingColumnGroupIfAdjacentBefore):
(WebCore::RenderTableCol::enclosingColumnGroupIfAdjacentAfter):
Added the following new helpers.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119110 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix Lion build after r119073.
jberlin@webkit.org [Thu, 31 May 2012 15:41:33 +0000 (15:41 +0000)]
Fix Lion build after r119073.

* platform/Decimal.cpp:
(WebCore::Decimal::toString):
Do not attempt to assign a unsigned long long to an int.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119109 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[GTK] Add webkit_download_get_request to WebKit2 GTK+ API
carlosgc@webkit.org [Thu, 31 May 2012 15:31:54 +0000 (15:31 +0000)]
[GTK] Add webkit_download_get_request to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=87957

Reviewed by Martin Robinson.

* UIProcess/API/gtk/WebKitDownload.cpp:
(webkit_download_get_request): Return the WebKitURIRequest
representing the request that originated the download.
* UIProcess/API/gtk/WebKitDownload.h:
* UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbol.
* UIProcess/API/gtk/tests/TestDownloads.cpp:
(testDownloadLocalFile):
(testDownloadRemoteFile):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119108 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[SOUP] WebProcess crashes when a download is started from an existing ResourceHandle
carlosgc@webkit.org [Thu, 31 May 2012 15:29:48 +0000 (15:29 +0000)]
[SOUP] WebProcess crashes when a download is started from an existing ResourceHandle
https://bugs.webkit.org/show_bug.cgi?id=87953

Reviewed by Martin Robinson.

The output stream to write the downloaded data is created in the
didReceiveResponse callback of the download client. When a
download is created for an existing ResourceHandle (this happens
for example when policy decision is download), the response has
already been received. In this case we should make sure that the
download client is notified about the response, so that when data
actually arrives the output stream has already been created.

* WebProcess/Downloads/soup/DownloadSoup.cpp:
(WebKit::Download::startWithHandle):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119107 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[GTK] Fix webkit_web_view_can_execute_editing_command() API doc
carlosgc@webkit.org [Thu, 31 May 2012 15:27:19 +0000 (15:27 +0000)]
[GTK] Fix webkit_web_view_can_execute_editing_command() API doc
https://bugs.webkit.org/show_bug.cgi?id=87930

Reviewed by Martin Robinson.

* UIProcess/API/gtk/WebKitWebView.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119106 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[BlackBerry] Crash when closing web page if selection is active
commit-queue@webkit.org [Thu, 31 May 2012 15:27:15 +0000 (15:27 +0000)]
[BlackBerry] Crash when closing web page if selection is active
https://bugs.webkit.org/show_bug.cgi?id=87962

Patch by Arvid Nilsson <anilsson@rim.com> on 2012-05-31
Reviewed by Antonio Gomes.

The embedder may try to remove a layer from the compositor at a stage
where the compositor has been set to 0.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::addCompositingThreadOverlay):
(BlackBerry::WebKit::WebPage::removeCompositingThreadOverlay):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119105 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[v8] Fix bug reference in array-override-set.html test
commit-queue@webkit.org [Thu, 31 May 2012 15:15:25 +0000 (15:15 +0000)]
[v8] Fix bug reference in array-override-set.html test
https://bugs.webkit.org/show_bug.cgi?id=87952

Patch by Ulan Degenbaev <ulan@chromium.org> on 2012-05-31
Reviewed by Abhishek Arya.

* fast/canvas/webgl/array-override-set-expected.txt:
* fast/canvas/webgl/array-override-set.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119104 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[GTK] Unreviewed. Added FAIL expectation due to test consistently failing.
mario@webkit.org [Thu, 31 May 2012 15:12:18 +0000 (15:12 +0000)]
[GTK] Unreviewed. Added FAIL expectation due to test consistently failing.

* platform/gtk/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119103 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[EFL] Enable CSS_IMAGE_SET flag
commit-queue@webkit.org [Thu, 31 May 2012 14:47:30 +0000 (14:47 +0000)]
[EFL] Enable CSS_IMAGE_SET flag
https://bugs.webkit.org/show_bug.cgi?id=87727

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-05-31
Reviewed by Adam Roben.

.:

Add CSS_IMAGE_SET flag to CMake and enable it by default on EFL port.

* Source/cmake/OptionsEfl.cmake:
* Source/cmake/WebKitFeatures.cmake:
* Source/cmakeconfig.h.cmake:

Source/WebCore:

Fix CMakeLists.txt so that CSSImageSetValue.cpp gets compiled if
CSS_IMAGE_SET flag is enabled.

* CMakeLists.txt:

LayoutTests:

Unskip test case associated to CSS image-set functionality now that it
is enabled by default on EFL port.

* platform/efl/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119102 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed. Added FAIL expectation for GTK due to missing feature in DRT.
mario@webkit.org [Thu, 31 May 2012 14:44:34 +0000 (14:44 +0000)]
Unreviewed. Added FAIL expectation for GTK due to missing feature in DRT.

* platform/gtk/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119101 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agothe imageSmoothingEnabled flag needs to be in the state object
commit-queue@webkit.org [Thu, 31 May 2012 14:32:13 +0000 (14:32 +0000)]
the imageSmoothingEnabled flag needs to be in the state object
https://bugs.webkit.org/show_bug.cgi?id=87853

Patch by Keyar Hood <keyar@chromium.org> on 2012-05-31
Reviewed by Darin Adler.

Source/WebCore:

Updated fast/canvas/canvas-imageSmoothingEnabled.html instead of
adding a new test.

The imageSmoothingEnabled flag is saved in the draw state now.
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::CanvasRenderingContext2D):
(WebCore::CanvasRenderingContext2D::State::State):
(WebCore::CanvasRenderingContext2D::State::operator=):
(WebCore::CanvasRenderingContext2D::webkitImageSmoothingEnabled):
(WebCore::CanvasRenderingContext2D::setWebkitImageSmoothingEnabled):
* html/canvas/CanvasRenderingContext2D.h:
(State):

LayoutTests:

Updated the test for imageSmoothingEnabled to test that it is saved in
the draw state.

* fast/canvas/canvas-imageSmoothingEnabled-expected.txt:
* fast/canvas/script-tests/canvas-imageSmoothingEnabled.js:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119100 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWeb Inspector: Fix checkbox position on Settings screen.
caseq@chromium.org [Thu, 31 May 2012 14:08:10 +0000 (14:08 +0000)]
Web Inspector: Fix checkbox position on Settings screen.
https://bugs.webkit.org/show_bug.cgi?id=87007

Patch by Eugene Klyuchnikov <eustas.bug@gmail.com> on 2012-05-31
Reviewed by Yury Semikhatsky.

Checkbox seems to be improperly aligned.
It is "shifted" up on 1px on Mac and 2px on Linux.
Also, keyboard-shortcuts screen has "wrapped" key descriptions on Mac.

UI changes, no new tests.

* inspector/front-end/helpScreen.css:
(.help-container): Fixed column width.
(.help-block): Ditto.
(.help-key-cell): Ditto.
(body.platform-mac .help-container): Ditto.
(body.platform-mac .help-block): Ditto.
(body.platform-mac .help-key-cell): Ditto.
(.help-content p): Ajdusted spacing between lines
(.help-content input[type=checkbox]): Fixed alignment.
(body.platform-mac .help-content input[type=checkbox]): Ditto.
(.help-content input[type=radio]): Fixed alignment.
(body.platform-mac .help-content input[type=radio]): Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119099 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] Simplify QT_VERSION_CHECKS for Qt5 by introducing HAVE(QT5)
vestbo@webkit.org [Thu, 31 May 2012 14:00:53 +0000 (14:00 +0000)]
[Qt] Simplify QT_VERSION_CHECKS for Qt5 by introducing HAVE(QT5)
https://bugs.webkit.org/show_bug.cgi?id=87955

Reviewed by Simon Hausmann.

Source/WebCore:

* bridge/qt/qt_class.cpp:
* bridge/qt/qt_instance.cpp:
* bridge/qt/qt_runtime.h:
* page/qt/EventHandlerQt.cpp:
* platform/graphics/GraphicsContext3D.h:
* platform/graphics/OpenGLShims.cpp:
* platform/graphics/OpenGLShims.h:
* platform/graphics/gstreamer/PlatformVideoWindowPrivate.h:
* platform/graphics/gstreamer/PlatformVideoWindowQt.cpp:
* platform/graphics/qt/GraphicsContext3DQt.cpp:
* platform/graphics/qt/SimpleFontDataQt.cpp:
* platform/graphics/texmap/TextureMapper.h:
* platform/graphics/texmap/TextureMapperGL.cpp:
* platform/qt/DeviceMotionProviderQt.h:
* platform/qt/DeviceOrientationProviderQt.h:
* platform/qt/KURLQt.cpp:
* platform/qt/PlatformScreenQt.cpp:
* platform/qt/QWebPageClient.h:
* plugins/qt/PluginPackageQt.cpp:
* plugins/qt/PluginViewQt.cpp:

Source/WebKit/qt:

* Api/qgraphicswebview.cpp:
* Api/qgraphicswebview.h:
* Api/qwebframe.cpp:
* Api/qwebframe_p.h:
* Api/qwebpage.cpp:
* Api/qwebpage.h:
* Api/qwebsettings.cpp:
* Api/qwebview.cpp:
* Api/qwebview.h:
* WebCoreSupport/FrameLoaderClientQt.cpp:
* WebCoreSupport/GeolocationClientQt.cpp:
* WebCoreSupport/GeolocationClientQt.h:
* WebCoreSupport/PageClientQt.cpp:
* WebCoreSupport/WebEventConversion.cpp:
* declarative/plugin.cpp:
* tests/qwebframe/tst_qwebframe.cpp:
* tests/util.h:

Source/WebKit2:

* UIProcess/API/qt/tests/publicapi/tst_publicapi.cpp:

Source/WTF:

* wtf/qt/UtilsQt.h:

Tools:

* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
* DumpRenderTree/qt/EventSenderQt.cpp:
* DumpRenderTree/qt/QtInitializeTestFonts.cpp:
* DumpRenderTree/qt/main.cpp:
* QtTestBrowser/cookiejar.cpp:
* QtTestBrowser/launcherwindow.cpp:
* WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
* qmake/mkspecs/features/default_post.prf:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119098 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoHave StylePropertySet constructor take array/length instead of vector.
kling@webkit.org [Thu, 31 May 2012 13:38:47 +0000 (13:38 +0000)]
Have StylePropertySet constructor take array/length instead of vector.
<http://webkit.org/b/87876>

Reviewed by Antti Koivisto.

Remove the StylePropertyVector typedef and have StylePropertySet constructors
take CSSProperty*/length since we are copying the data into a tightly packed
array anyway. This frees up the call sites to use whatever storage they please
rather than being restricted to a vector with inlineCapacity=4.

Change said call sites to use an arbitrary high inline capacity (256) for their
stack-allocated temporary vectors.

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::copyPropertiesInSet):
* css/CSSParser.cpp:
(WebCore::filterProperties):
(WebCore::CSSParser::createStylePropertySet):
* css/StylePropertySet.cpp:
(WebCore::StylePropertySet::createImmutable):
(WebCore::StylePropertySet::StylePropertySet):
(WebCore::StylePropertySet::removePropertiesInSet):
(WebCore::StylePropertySet::copyPropertiesInSet):
* css/StylePropertySet.h:
(WebCore::StylePropertySet::create):
(StylePropertySet):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119097 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[EFL] Gardening after r118989
commit-queue@webkit.org [Thu, 31 May 2012 13:24:13 +0000 (13:24 +0000)]
[EFL] Gardening after r118989
https://bugs.webkit.org/show_bug.cgi?id=87958

Unreviewed gardening.

fast/css/font-face-download-error.html is skipped as bug85977 is not fixed yet.

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-05-31

* platform/efl/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119096 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt][WK2] Add missing ViewportUpdateDeferrer guarding to setPageItemRectVisible(...
commit-queue@webkit.org [Thu, 31 May 2012 13:07:36 +0000 (13:07 +0000)]
[Qt][WK2] Add missing ViewportUpdateDeferrer guarding to setPageItemRectVisible() calls.
https://bugs.webkit.org/show_bug.cgi?id=87936

Patch by Zalan Bujtas <zbujtas@gmail.com> on 2012-05-31
Reviewed by Kenneth Rohde Christiansen.

* UIProcess/qt/QtViewportInteractionEngine.cpp:
(WebKit::QtViewportInteractionEngine::viewportAttributesChanged):
(WebKit::QtViewportInteractionEngine::pageContentsSizeChanged):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119095 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFixing compilation with SVG disabled.
commit-queue@webkit.org [Thu, 31 May 2012 12:41:11 +0000 (12:41 +0000)]
Fixing compilation with SVG disabled.
https://bugs.webkit.org/show_bug.cgi?id=87944

This patch adds the missing enumeration value
'CSSPropertyWebkitBoxDecorationBreak' into switch statements to make
clang happy.

Patch by Mike West <mkwst@chromium.org> on 2012-05-31
Reviewed by Alexis Menard.

* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
* css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRulesForList):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119094 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Chromium] Unreviewed, update Mac Leopard baselines for fast/muticol/span/span-as...
apavlov@chromium.org [Thu, 31 May 2012 12:33:17 +0000 (12:33 +0000)]
[Chromium] Unreviewed, update Mac Leopard baselines for fast/muticol/span/span-as-immediate-columns-child.html.

* platform/chromium-mac-leopard/fast/multicol/span/span-as-immediate-columns-child-expected.png:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119093 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[EFL][WK2] Add WKURLRequestEfl and WKURLResponseEfl
commit-queue@webkit.org [Thu, 31 May 2012 12:30:02 +0000 (12:30 +0000)]
[EFL][WK2] Add WKURLRequestEfl and WKURLResponseEfl
https://bugs.webkit.org/show_bug.cgi?id=70231

Patch by Keunsoon Lee <keunsoon.lee@samsung.com> on 2012-05-31
Reviewed by Chang Shu.

These codes can be used for WKPageDecidePolicyForResponseCallback on page policy callbacks.
The callback conveys WKURLResponseRef and WKURLRequestRef as parameter.

By the way, EFL browser needs content type from response to decide correct policy.
Another information, cookie, is necessary with similar reason.
But, there is no way to obtain such information on WebKit2 main stream, except for WKURLRequestCopyURL().

So, EFL port created those files to extract necessary information from WKURLResponseRef and WKURLRequestRef,
and not to desturb WebKit2 main stream.

* Shared/API/c/efl/WKURLRequestEfl.cpp: Added.
(WKURLRequestEflCopyCookies): extracting cookie information from WKURLRequestRef.
* Shared/API/c/efl/WKURLRequestEfl.h: Added.
* Shared/API/c/efl/WKURLResponseEfl.cpp: Added.
(WKURLResponseEflCopyContentType): extracting content type (i.e. MIME type) from WKURLResponseRef.
* Shared/API/c/efl/WKURLResponseEfl.h: Added.
* Shared/efl/WebCoreArgumentCodersEfl.cpp: Added.
(CoreIPC):
(CoreIPC::::encode):
(CoreIPC::::decode):
* Shared/efl/WebURLRequestEfl.cpp: Added.
(WebKit):
(WebKit::WebURLRequestEfl::WebURLRequestEfl):
(WebKit::WebURLRequestEfl::cookies): obtaining cookie information from ResourceRequest.
* Shared/efl/WebURLRequestEfl.h: Added.
(WebKit):
(WebURLRequestEfl):
(WebKit::WebURLRequestEfl::create):
* Shared/efl/WebURLResponseEfl.cpp: Added.
(WebKit):
(WebKit::WebURLResponseEfl::WebURLResponseEfl):
(WebKit::WebURLResponseEfl::contentType): obtaining content type (i.e. MIME type) from ResourceResponse.
* Shared/efl/WebURLResponseEfl.h: Added.
(WebKit):
(WebURLResponseEfl):
(WebKit::WebURLResponseEfl::create):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119092 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] Unreviewed gardening, skip new failing tests, unskip a now passing test.
ossy@webkit.org [Thu, 31 May 2012 12:06:32 +0000 (12:06 +0000)]
[Qt] Unreviewed gardening, skip new failing tests, unskip a now passing test.

* platform/qt/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119091 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed. Added new baselines for GTK after r117815.
mario@webkit.org [Thu, 31 May 2012 11:57:51 +0000 (11:57 +0000)]
Unreviewed. Added new baselines for GTK after r117815.

* platform/gtk/svg/zoom/page/zoom-hixie-rendering-model-004-expected.txt: Added.
* platform/gtk/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.png: Added.
* platform/gtk/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.txt: Added.
* platform/gtk/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.png: Updated.
* platform/gtk/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119090 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed. Added new baselines for GTK after r118891.
mario@webkit.org [Thu, 31 May 2012 11:57:31 +0000 (11:57 +0000)]
Unreviewed. Added new baselines for GTK after r118891.

* platform/gtk/fast/forms/select/optgroup-rendering-expected.png: Added.
* platform/gtk/fast/forms/select/optgroup-rendering-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119089 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Platform] Implementation of Decimal(int32_t) isn't portable.
yosin@chromium.org [Thu, 31 May 2012 11:54:18 +0000 (11:54 +0000)]
[Platform] Implementation of Decimal(int32_t) isn't portable.
https://bugs.webkit.org/show_bug.cgi?id=87941

Reviewed by Kent Tamura.

This patch changes negation of integer to make unsigned integer
in portable way.

No new tests. This patch doesn't change behavior.

* platform/Decimal.cpp:
(WebCore::Decimal::Decimal): Use uint64_t(-int64_t(i32)) instead of uint64_t(-i32)

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119088 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agofast/events/message-port-multi.html needs new baseline after r119027
ossy@webkit.org [Thu, 31 May 2012 11:48:03 +0000 (11:48 +0000)]
fast/events/message-port-multi.html needs new baseline after r119027
https://bugs.webkit.org/show_bug.cgi?id=87949

Unreviewed gardening.

Update baseline for fast/events/message-port-multi.html after r119027.
Now all the checks are passing and we can get rid of the FAIL lines in
the expected result.

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-05-31

* fast/events/message-port-multi-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119087 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[EFL][WK2] Rename ewk_private.h to ewk_view_private.h
gyuyoung.kim@samsung.com [Thu, 31 May 2012 11:35:18 +0000 (11:35 +0000)]
[EFL][WK2] Rename ewk_private.h to ewk_view_private.h
https://bugs.webkit.org/show_bug.cgi?id=87923

Reviewed by Kenneth Rohde Christiansen.

EFL WK1 decided to divide up ewk_private.h into each file's XXX_private.h file in order to maintain
internal functions more easily. EFL WK2 needs to adjust this as well.

* UIProcess/API/efl/PageClientImpl.cpp:
* UIProcess/API/efl/ewk_view_private.h: Renamed from Source/WebKit2/UIProcess/API/efl/ewk_private.h.
(WebCore):
* UIProcess/cairo/BackingStoreCairo.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119086 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWeb Inspector: [Chromium] Cannot bring Inspector to front when paused on breakpoint
apavlov@chromium.org [Thu, 31 May 2012 11:28:40 +0000 (11:28 +0000)]
Web Inspector: [Chromium] Cannot bring Inspector to front when paused on breakpoint
https://bugs.webkit.org/show_bug.cgi?id=87871

Reviewed by Yury Semikhatsky.

When input events handling is suppressed (due to the JS being paused on a breakpoint), we should report
these events as NOT handled by the WebKit, so that the browser can handle them appropriately
(on MacOS, switching between the application windows is done through the default key event handler, so if you run
event.preventDefault() for all keydown events in a handler, the Chromium window switch will not occur on Cmd+`).

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::handleInputEvent):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119085 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[EFL] Gardening after r118993
commit-queue@webkit.org [Thu, 31 May 2012 11:22:29 +0000 (11:22 +0000)]
[EFL] Gardening after r118993
https://bugs.webkit.org/show_bug.cgi?id=87946

Unreviewed gardening.

Test fast/forms/file/input-file-write-files.html that was added at r118993 relies on
unsupported EventSender.beginDragWithFiles and hence should be skipped.

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-05-31

* platform/efl/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119084 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed. Unskipping tests for GTK now passing in all the bots.
mario@webkit.org [Thu, 31 May 2012 11:14:42 +0000 (11:14 +0000)]
Unreviewed. Unskipping tests for GTK now passing in all the bots.

* platform/gtk/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119083 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agofast/dom/Window/mozilla-focus-blur.html failing after r118916
mario@webkit.org [Thu, 31 May 2012 10:42:17 +0000 (10:42 +0000)]
fast/dom/Window/mozilla-focus-blur.html failing after r118916
https://bugs.webkit.org/show_bug.cgi?id=87951

Unreviewed. Added FAIL expectation for GTK after r118916.

* platform/gtk/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119082 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoTest expectation pngs missing checksums
abecsi@webkit.org [Thu, 31 May 2012 10:10:38 +0000 (10:10 +0000)]
Test expectation pngs missing checksums
https://bugs.webkit.org/show_bug.cgi?id=87947

Reviewed by Ojan Vafai.

Add proper platform independent png expectation with checksum and revert chromium
expectations since layoutTestController.keepWebHistory() seems to have no effect
on chromium, and the test is still failing (See bug 87839).

* http/tests/misc/acid3-expected.png: Add png with embedded checksum.
* platform/chromium-mac-leopard/http/tests/misc/acid3-expected.png: Revert to prior r118566.
* platform/chromium-mac-snowleopard/http/tests/misc/acid3-expected.png: Revert to prior r118566.
* platform/chromium-mac/http/tests/misc/acid3-expected.png: Revert to prior r118566.
* platform/chromium-mac/http/tests/misc/acid3-expected.txt: Revert to prior r118566.
* platform/chromium/test_expectations.txt: Revert to prior r118566.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119081 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoSource/WebCore: [CMAKE][EFL] Remove unneeded include path
gyuyoung.kim@samsung.com [Thu, 31 May 2012 10:02:14 +0000 (10:02 +0000)]
Source/WebCore: [CMAKE][EFL] Remove unneeded include path
https://bugs.webkit.org/show_bug.cgi?id=87927

Reviewed by Kenneth Rohde Christiansen.

Though *wtf* directory was moved to Source/WTF, PlatformEfl.cmake is still including the previous
path. In addition, files on EFL port are using "<wtf/gobject/XXX>" directly in #include line.
So, EFL port doesn't need to include ${JAVASCRIPTCORE_DIR}/wtf/gobject path anymore.

* PlatformEfl.cmake: Remove '${JAVASCRIPTCORE_DIR}/wtf/gobject' path from include path list.

Source/WebKit: [CMAKE][EFL] Remove unneeded include path
https://bugs.webkit.org/show_bug.cgi?id=87927

Reviewed by Kenneth Rohde Christiansen.

Though *wtf* directory was moved to Source/WTF, PlatformEfl.cmake is still including the previous
path. In addition, files on EFL port are using <wtf/gobject/XXX> directly in #include line.
So, EFL port doesn't need to include ${JAVASCRIPTCORE_DIR}/wtf/gobject path anymore.

* PlatformEfl.cmake: Remove '${JAVASCRIPTCORE_DIR}/wtf/gobject' path from include path list.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119080 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed. Rolled DEPS.
peter@chromium.org [Thu, 31 May 2012 09:50:29 +0000 (09:50 +0000)]
Unreviewed.  Rolled DEPS.

* DEPS:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119079 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] Don't enforce the version of libpng for the config test when passing the option...
zoltan@webkit.org [Thu, 31 May 2012 09:47:14 +0000 (09:47 +0000)]
[Qt] Don't enforce the version of libpng for the config test when passing the option to the linker

Rubber-stamped by Kenneth Rohde Christiansen.

* qmake/config.tests/libpng/libpng.pro:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119078 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Chromium] Automatically install 64-bit linker for Android
peter@chromium.org [Thu, 31 May 2012 09:22:45 +0000 (09:22 +0000)]
[Chromium] Automatically install 64-bit linker for Android
https://bugs.webkit.org/show_bug.cgi?id=79780

Reviewed by Adam Barth.

Source/WebKit/chromium:

Change the Android-specific dependencies to inherit their revision from
Chromium's DEPS file, like many other dependencies do, solving the
versioning problem that we're running in to right now. These are listed
in Chromium's main DEPS file starting Chromium r139529.

* DEPS:

Tools:

Change the update-webkit-chromium script to check whether the 64-bit
linker needs to be installed as part of the update process. The actual
code for doing these checks and "installing" it has been added to the
webkitdirs.pm script.

The linker itself is part of the third_party/aosp repository, which
will be pulled in through the DEPS change.

* Scripts/update-webkit-chromium:
* Scripts/webkitdirs.pm:
(chromiumInstall64BitAndroidLinkerIfNeeded):
(chromiumReplaceAndroidLinkerIfNeeded):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119077 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[EFL] Gardening after r118957
commit-queue@webkit.org [Thu, 31 May 2012 09:02:02 +0000 (09:02 +0000)]
[EFL] Gardening after r118957
https://bugs.webkit.org/show_bug.cgi?id=87937

Unreviewed gardening.

compositing/layer-creation/fixed-position-and-transform.html and compositing/layer-creation/fixed-position-under-transform.html
added with r118957 were skipped in EFL port as EFL's LayoutTestController does not implement layerTreeAsText.

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-05-31

* platform/efl/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119076 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoBuild fix for Chromium Linux (Tests) after r119073.
yosin@chromium.org [Thu, 31 May 2012 08:55:10 +0000 (08:55 +0000)]
Build fix for Chromium Linux (Tests) after r119073.

* tests/DecimalTest.cpp:
(TEST_F):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119075 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] Unreviewed gardening. Rebase xss test, skip failing tests.
kkristof@inf.u-szeged.hu [Thu, 31 May 2012 08:42:35 +0000 (08:42 +0000)]
[Qt] Unreviewed gardening. Rebase xss test, skip failing tests.

Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2012-05-31

* platform/qt/Skipped:
* platform/qt/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-document-write-expected.txt:
* platform/qt/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-javascript-url-expected.txt:
* platform/qt/http/tests/security/aboutBlank/xss-DENIED-set-opener-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119074 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Platform] Introduce Decimal class for Number/Range input type.
yosin@chromium.org [Thu, 31 May 2012 08:28:29 +0000 (08:28 +0000)]
[Platform] Introduce Decimal class for Number/Range input type.
https://bugs.webkit.org/show_bug.cgi?id=87360

Reviewed by Kent Tamura.

Source/WebCore:

This patch added new class Decimal for decimal arithmatic in two
files: platform/Decimal.cpp and Decimal.h with unit test.

Test: WebKit/chromium/tests/DecimalTest.cpp

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* platform/Decimal.cpp: Added.
(WebCore):
(DecimalPrivate):
(SpecialValueHandler):
(WebCore::DecimalPrivate::SpecialValueHandler::SpecialValueHandler):
(WebCore::DecimalPrivate::SpecialValueHandler::handle):
(WebCore::DecimalPrivate::SpecialValueHandler::value):
(UInt128):
(WebCore::DecimalPrivate::UInt128::UInt128):
(WebCore::DecimalPrivate::UInt128::high):
(WebCore::DecimalPrivate::UInt128::low):
(WebCore::DecimalPrivate::UInt128::multiply):
(WebCore::DecimalPrivate::UInt128::highUInt32):
(WebCore::DecimalPrivate::UInt128::lowUInt32):
(WebCore::DecimalPrivate::UInt128::isZero):
(WebCore::DecimalPrivate::UInt128::makeUInt64):
(WebCore::DecimalPrivate::UInt128::operator/=):
(WebCore::DecimalPrivate::UInt128::multiplyHigh):
(WebCore::DecimalPrivate::countDigits):
(WebCore::DecimalPrivate::scaleDown):
(WebCore::DecimalPrivate::scaleUp):
(WebCore::Decimal::EncodedData::EncodedData):
(WebCore::Decimal::EncodedData::operator==):
(WebCore::Decimal::Decimal):
(WebCore::Decimal::operator=):
(WebCore::Decimal::operator+=):
(WebCore::Decimal::operator-=):
(WebCore::Decimal::operator*=):
(WebCore::Decimal::operator/=):
(WebCore::Decimal::operator-):
(WebCore::Decimal::operator+):
(WebCore::Decimal::operator*):
(WebCore::Decimal::operator/):
(WebCore::Decimal::operator==):
(WebCore::Decimal::operator!=):
(WebCore::Decimal::operator<):
(WebCore::Decimal::operator<=):
(WebCore::Decimal::operator>):
(WebCore::Decimal::operator>=):
(WebCore::Decimal::abs):
(WebCore::Decimal::alignOperands):
(WebCore::Decimal::ceiling):
(WebCore::Decimal::compareTo):
(WebCore::Decimal::floor):
(WebCore::Decimal::fromString):
(WebCore::Decimal::infinity):
(WebCore::Decimal::nan):
(WebCore::Decimal::remainder):
(WebCore::Decimal::round):
(WebCore::Decimal::toString):
(WebCore::Decimal::zero):
* platform/Decimal.h: Added.
(WebCore):
(DecimalPrivate):
(Decimal):
(EncodedData):
(WebCore::Decimal::EncodedData::operator!=):
(WebCore::Decimal::EncodedData::coefficient):
(WebCore::Decimal::EncodedData::exponent):
(WebCore::Decimal::EncodedData::isFinite):
(WebCore::Decimal::EncodedData::isNaN):
(WebCore::Decimal::EncodedData::isSpecial):
(WebCore::Decimal::EncodedData::isZero):
(WebCore::Decimal::EncodedData::sign):
(WebCore::Decimal::EncodedData::setSign):
(WebCore::Decimal::EncodedData::formatClass):
(WebCore::Decimal::isFinite):
(WebCore::Decimal::isNaN):
(WebCore::Decimal::isNegative):
(WebCore::Decimal::isPositive):
(WebCore::Decimal::isSpecial):
(WebCore::Decimal::isZero):
(WebCore::Decimal::value):
(AlignedOperands):
(WebCore::Decimal::invertSign):
(WebCore::Decimal::exponent):
(WebCore::Decimal::sign):

Source/WebKit/chromium:

This patch added unit test for Decimal class.

* WebKit.gypi:
* tests/DecimalTest.cpp: Added.
(WebCore):
(WebCore::operator<<): Output Decimal for unit test debugging
(DecimalStepRange):
(DecimalStepRange::DecimalStepRange):
(DecimalStepRange::clampValue):
(DecimalTest):
(DecimalTest::encode):
(DecimalTest::fromString):
(DecimalTest::stepDown):
(DecimalTest::stepUp):
(TEST_F):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119073 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[EFL][DRT] Gardening after r118920
commit-queue@webkit.org [Thu, 31 May 2012 08:22:54 +0000 (08:22 +0000)]
[EFL][DRT] Gardening after r118920
https://bugs.webkit.org/show_bug.cgi?id=87934

Unreviewed, gardening of http/tests/local/fileapi/file-last-modified-after-delete.html which
relies on unsupported drag'n'drop feature.

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-05-31

* platform/efl/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119072 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWeb Inspector: Retainers are missing for all objects
commit-queue@webkit.org [Thu, 31 May 2012 08:05:10 +0000 (08:05 +0000)]
Web Inspector: Retainers are missing for all objects
https://bugs.webkit.org/show_bug.cgi?id=87655

Skip the test on wincairo platform.

Patch by Alexei Filippov <alexeif@chromium.org> on 2012-05-31
Reviewed by Yury Semikhatsky.

* platform/wincairo/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119071 268f45cc-cd09-0410-ab3c-d52691b4dbfc